Re: Review Request 36049: Added support for modularized Authorizer

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review94664
---



src/local/local.cpp (lines 217 - 219)


Does it make sense to log a warning for this?

```
if (flags.authorizers != master::DEFAULT_AUTHORIZER && flags.acls.isSome()) 
{
  LOG(WARNNING) << /* acls are being ignored! */;
}
```



src/local/local.cpp (lines 238 - 248)


This behavior is noticeably different, since we used to simply 
`EXIT(EXIT_FAILURE)` on this error. What's the rationale here?

My thoughts: if an authorizer fails to initialize given some ACLs, it's 
seems likely that the ACLs are ill-formed. In which case, the intent from the 
user is clear that they __want__ authorization, but they made a mistake in 
their ACL construction. Therefore, it seems more reasonable for us to exit with 
an error rather than ignoring their intent and skipping authorization 
altogether.



src/master/flags.cpp (line 417)


Can we expand a little upon `Authorizer implementation to use.`?

Maybe something like: `Authorizer implementation to use when authorizating 
actions that required it.`?



src/master/flags.cpp (line 422)


`s/than default/than the default`
`s/contents//`



src/master/flags.cpp (line 425)


I think we can follow what we do for `authenticators` in 
`src/master/master.cpp` to indicate the lack of support for multiple 
authorizers.

(1) split `flags.authorizers` by `,`
(2) if empty -> no authorizers specified
(3) if size > 1, multiple authorizers not supported
(4) proceed with the first name.



src/master/main.cpp (lines 346 - 379)


Same comments as `src/local/local.cpp`


- Michael Park


On Aug. 5, 2015, 9:15 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36049/
> ---
> 
> (Updated Aug. 5, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2947
> https://issues.apache.org/jira/browse/MESOS-2947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds and integrates helper classes needed to support an `Authorizer` module. 
> Also adds a flag to the master, allowing the selection of an `Authorizer` 
> module.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp PRE-CREATION 
>   include/mesos/module/authorizer.hpp PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/authorizer/authorizer.cpp PRE-CREATION 
>   src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff 
>   src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce 
>   src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341 
>   src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f 
>   src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 
>   src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
> 
> Diff: https://reviews.apache.org/r/36049/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 36050: Added test authorizer module.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review94665
---


As I mentioned in https://reviews.apache.org/r/36048/, I think it might make 
sense to provide a `authorization` module in which `authorizer` is a member of.
Similar to the relationship between the `authentication` module and its 
members: `authenticatee` and `authenticator`.

In the context of this patch, I'm suggesting that we could have 
`examples/test_authorizer_module.cpp`, `addAuthorizationModules`, etc instead,
and keep the authorizer itself as `TestLocalAuthorizer`.


src/examples/test_authorizer_module.cpp (line 33)


Remove new line.



src/examples/test_authorizer_module.cpp (line 35)


`s/nullptr/NULL/`



src/tests/authorization_tests.cpp (line 43)


`s/AuthorizerTestTypes/AuthorizerTypes/`?


- Michael Park


On Aug. 5, 2015, 9:04 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36050/
> ---
> 
> (Updated Aug. 5, 2015, 9:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2947
> https://issues.apache.org/jira/browse/MESOS-2947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a test authorizer module.
> 
> Updates the authorization tests in order to perform typed tests on the 
> default authorizer implementation and on the test authorizer module.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/examples/test_authorizer_module.cpp PRE-CREATION 
>   src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 
>   src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 
>   src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 
> 
> Diff: https://reviews.apache.org/r/36050/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 36049: Added support for modularized Authorizer

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review94667
---



src/master/flags.cpp (line 415)


Could we please add this flag to the documentation i.e. configuration.md


- Joerg Schad


On Aug. 5, 2015, 9:15 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36049/
> ---
> 
> (Updated Aug. 5, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2947
> https://issues.apache.org/jira/browse/MESOS-2947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds and integrates helper classes needed to support an `Authorizer` module. 
> Also adds a flag to the master, allowing the selection of an `Authorizer` 
> module.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp PRE-CREATION 
>   include/mesos/module/authorizer.hpp PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/authorizer/authorizer.cpp PRE-CREATION 
>   src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff 
>   src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce 
>   src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341 
>   src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f 
>   src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 
>   src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
> 
> Diff: https://reviews.apache.org/r/36049/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 37272: Remove thread_tests.cpp in stout.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37272/
---

Review request for mesos and Alex Clemmer.


Bugs: MESOS-3139
https://issues.apache.org/jira/browse/MESOS-3139


Repository: mesos


Description
---

Remove thread_tests.cpp in stout.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
b1a519007e5bed196541f294c4676277f9708714 

Diff: https://reviews.apache.org/r/37272/diff/


Testing
---


Thanks,

haosdent huang

Review Request 37273: Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

Review request for mesos and Alex Clemmer.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
997cc0d0e316e316136d4746e50e9e292a82b36b 
  3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang

Review Request 37275: Generate make batch file to build project in windows.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

Review request for mesos and Alex Clemmer.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37272/
---

(Updated Aug. 9, 2015, 6:21 p.m.)


Review request for mesos and Alex Clemmer.


Summary (updated)
-

[1/3]Remove thread_tests.cpp in stout.


Bugs: MESOS-3139
https://issues.apache.org/jira/browse/MESOS-3139


Repository: mesos


Description
---

Remove thread_tests.cpp in stout.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
b1a519007e5bed196541f294c4676277f9708714 

Diff: https://reviews.apache.org/r/37272/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [3/3]Generate make batch file to build project in windows.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Aug. 9, 2015, 6:21 p.m.)


Review request for mesos and Alex Clemmer.


Summary (updated)
-

[3/3]Generate make batch file to build project in windows.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/
---

(Updated Aug. 9, 2015, 6:21 p.m.)


Review request for mesos and Alex Clemmer.


Summary (updated)
-

[2/3]Add CMake macro VsBuildCommand in libprocess.


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
997cc0d0e316e316136d4746e50e9e292a82b36b 
  3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/37273/diff/


Testing
---


Thanks,

haosdent huang

Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.


Bugs: MESOS-3131
https://issues.apache.org/jira/browse/MESOS-3131


Repository: mesos


Description
---

Just wanted to send out the abstraction for feedback.


Diffs
-

  src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7 
  src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc 
  src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 

Diff: https://reviews.apache.org/r/37277/diff/


Testing
---

make check

No new tests have been added yet.


Thanks,

Vinod Kone

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Artem Harutyunyan]

> On Aug. 8, 2015, 3:07 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [37013, 37017, 37018]
> > 
> > Failed command: ./support/apply-review.sh -n -r 37018
> > 
> > Error:
> >  2015-08-08 22:07:03 URL:https://reviews.apache.org/r/37018/diff/raw/ 
> > [49035/49035] -> "37018.patch" [1]
> > error: patch failed: 
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp:76
> > error: 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp: patch 
> > does not apply
> > Failed to apply patch
> 
> Michael Park wrote:
> Looks like this needs to be rebased since @bmahler took care of the style 
> issues in `stout/version.hpp` for us already in 
> https://github.com/apache/mesos/commit/e870bb3ed5cc6aa6dca088f7e4c58d6220e02595.

Done.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/#review94653
---


On Aug. 9, 2015, 3:16 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37018/
> ---
> 
> (Updated Aug. 9, 2015, 3:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> 39a6a3f26f59915f7a338796558eb19c93788ced 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 451a53d152011db0ca89a8b2e9bf47ba277cf132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 967201888114e01f1a2d3c9cfaae847f1ce42d13 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> 35fb034f303ffda8e786a8cb564b92d02cddbfe9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> ae54566b9d0160def6146aa0ce634bdbf0967142 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
> 89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 30baa65837621a277cf9d1042a751bfe18004b05 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 24c26e90d2386bf5319f07c69c20efacb95f12eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
> 5d7404bed73774644451f74a15c63da32441f529 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> 420d5bbb4c275eed3e663d40501b127d8fc7749f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 0e94e22817e21fc7944a995092e54bf302ab0e2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
> bbb796d647e9dd591802722f498cdc2fd39bca3e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
> 70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> 5af9be8fe419fe7f798a31dfa399516cd3514f67 
>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
> 0004fa5cd249269504155e51e52cd802c0916851 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> a7de91f73b08494157873dd8a0df8538c22d2e24 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> f0b0a488059e6cbc041697280356d45f3ff95f17 
>   3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
> ea8a13f25d72bb645842d32a91b168b67d33c3eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 450b3a7e67cf5f49888691d03997b8409004519e 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> 984c02c982dc4dd8eb528d79e715847ef7a693b8 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
> d03678552ae222cb8748ac7e57c600f8688761c4 
> 
> Diff: https://reviews.apache.org/r/37018/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/
---

(Updated Aug. 9, 2015, 3:16 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
Park.


Changes
---

Rebased.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
39a6a3f26f59915f7a338796558eb19c93788ced 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
451a53d152011db0ca89a8b2e9bf47ba277cf132 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
967201888114e01f1a2d3c9cfaae847f1ce42d13 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
35fb034f303ffda8e786a8cb564b92d02cddbfe9 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
ae54566b9d0160def6146aa0ce634bdbf0967142 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
30baa65837621a277cf9d1042a751bfe18004b05 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
549fc46cedb643ef1ebdf8441c332a02ac45016d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
24c26e90d2386bf5319f07c69c20efacb95f12eb 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
5d7404bed73774644451f74a15c63da32441f529 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
420d5bbb4c275eed3e663d40501b127d8fc7749f 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
0e94e22817e21fc7944a995092e54bf302ab0e2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
bbb796d647e9dd591802722f498cdc2fd39bca3e 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
5af9be8fe419fe7f798a31dfa399516cd3514f67 
  3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
0004fa5cd249269504155e51e52cd802c0916851 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
a7de91f73b08494157873dd8a0df8538c22d2e24 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
f0b0a488059e6cbc041697280356d45f3ff95f17 
  3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
ea8a13f25d72bb645842d32a91b168b67d33c3eb 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
5ad611497a47be64c539e832b9a1c23e6cf9586d 
  3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
450b3a7e67cf5f49888691d03997b8409004519e 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
984c02c982dc4dd8eb528d79e715847ef7a693b8 
  3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
d03678552ae222cb8748ac7e57c600f8688761c4 

Diff: https://reviews.apache.org/r/37018/diff/


Testing
---

`egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check


Thanks,

Artem Harutyunyan

Re: Review Request 37017: [2/3] Removed whitespace padding in overloaded operators (libprocess).

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37017/#review94682
---

Ship it!


Ship It!

- Michael Park


On Aug. 8, 2015, 9:58 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37017/
> ---
> 
> (Updated Aug. 8, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/address.hpp 
> be216db823160f5db1dfb4502bf832246fb3df6d 
>   3rdparty/libprocess/include/process/async.hpp 
> d0c560aa48ef1c88407a6b1c42223fce3170245c 
>   3rdparty/libprocess/include/process/deferred.hpp 
> b11acc4bed390fd33d782143afb6231fc7606bea 
>   3rdparty/libprocess/include/process/event.hpp 
> 522771a62bcdea458e33e4b15d590bd8c1dc5e22 
>   3rdparty/libprocess/include/process/executor.hpp 
> 23384c2ca206fdbb1fcc4c06a6ca99b0ee0b3498 
>   3rdparty/libprocess/include/process/future.hpp 
> db92767619ec7b6ab1a0803c240725a2633d2489 
>   3rdparty/libprocess/include/process/gmock.hpp 
> d4499526af3652a6c6600e871b843af49388b4ee 
>   3rdparty/libprocess/include/process/http.hpp 
> f24ca24f4b2926d6d9651b90bdf4dd8156f71c9f 
>   3rdparty/libprocess/include/process/latch.hpp 
> 460971e67a64c5b62bac5370a6a616c7f13bac51 
>   3rdparty/libprocess/include/process/limiter.hpp 
> ce692883c74bc9a5cb4822567e5d7edee81ae0a3 
>   3rdparty/libprocess/include/process/metrics/counter.hpp 
> 6ea32200d1b26a192731d9c14bcda48cf7855917 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> 5a328d3786e047459d9b245c8dd38a00d3b41b3b 
>   3rdparty/libprocess/include/process/once.hpp 
> 4b0cbe073dd0cd89b9ae788e66ccdf707afd0fc6 
>   3rdparty/libprocess/include/process/owned.hpp 
> 428e922327fd05e2e2f943bbb498cd58543cdc70 
>   3rdparty/libprocess/include/process/pid.hpp 
> 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 3ec3775165d1cef1d081e465d809d46e09d49b5c 
>   3rdparty/libprocess/include/process/sequence.hpp 
> 2dec013012c01813d43f80899f1292eecc7e414d 
>   3rdparty/libprocess/include/process/shared.hpp 
> b4d90ca0309be1116ae8421716894652b5bd0890 
>   3rdparty/libprocess/include/process/socket.hpp 
> a882330b45be10bab1e3e8fd8983e172eb0e4efc 
>   3rdparty/libprocess/include/process/time.hpp 
> 095409ac151c8ae3320c47cb50247718044dde83 
>   3rdparty/libprocess/include/process/timeout.hpp 
> 868da4935ca3c9959749b5c51b446179834086e4 
>   3rdparty/libprocess/include/process/timer.hpp 
> 02ebd32569cf0c25a1434107cd0cca76cf8a2659 
>   3rdparty/libprocess/src/http.cpp b44c1f457279a67fc5d60fab639b8baec71bef41 
>   3rdparty/libprocess/src/pid.cpp a5c527443cebb0c150f59fb4abe80216794a209b 
>   3rdparty/libprocess/src/process_reference.hpp 
> c070158defe234bfcdff06a829c7a001dc66ba1f 
>   3rdparty/libprocess/src/test-master.cpp 
> 2a2ed0e9ac58d7973b1254c708cbd97a7a33b762 
>   3rdparty/libprocess/src/test-slave.cpp 
> 5a924a0bca21397f059cf558d67853cc4103e5da 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 95e3257b030128e9d03dde9aa048602c68c6a446 
>   3rdparty/libprocess/src/time.cpp 87f1f367f422df0efe3bd57f983404e572dc5314 
> 
> Diff: https://reviews.apache.org/r/37017/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/#review94681
---

Ship it!


I'll get this committed for you since it's been agreed upon that we're going to 
make this style change. I've found following minor fixes, but I'll fix them 
before committing (since the longer we wait, the more we'll have to rebase).


3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp (line 96)


Removed unnecessary specialization: `<>`.



3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp (line 102)


`s/!operator == (that);/!(*this == that);` here and below.



3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp (line 87)


`s/operator []/operator[]/`



3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp (line 115)


`s/> >/>>/`


Also updated `3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp` which 
was committed after this patch, and has a couple of instances of `operator () 
(...)`.

- Michael Park


On Aug. 9, 2015, 10:16 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37018/
> ---
> 
> (Updated Aug. 9, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> 39a6a3f26f59915f7a338796558eb19c93788ced 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 451a53d152011db0ca89a8b2e9bf47ba277cf132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 967201888114e01f1a2d3c9cfaae847f1ce42d13 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> 35fb034f303ffda8e786a8cb564b92d02cddbfe9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> ae54566b9d0160def6146aa0ce634bdbf0967142 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
> 89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 30baa65837621a277cf9d1042a751bfe18004b05 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 24c26e90d2386bf5319f07c69c20efacb95f12eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
> 5d7404bed73774644451f74a15c63da32441f529 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> 420d5bbb4c275eed3e663d40501b127d8fc7749f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 0e94e22817e21fc7944a995092e54bf302ab0e2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
> bbb796d647e9dd591802722f498cdc2fd39bca3e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
> 70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> 5af9be8fe419fe7f798a31dfa399516cd3514f67 
>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
> 0004fa5cd249269504155e51e52cd802c0916851 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> a7de91f73b08494157873dd8a0df8538c22d2e24 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> f0b0a488059e6cbc041697280356d45f3ff95f17 
>   3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
> ea8a13f25d72bb645842d32a91b168b67d33c3eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 450b3a7e67cf5f49888691d03997b8409004519e 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> 984c02c982dc4dd8eb528d79e715847ef7a693b8 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
> d03678552ae222cb8748ac7e57c600f8688761c4 
> 
> Diff: https://reviews.apache.org/r/37018/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37013: [1/3] Removed whitespace padding in overloaded operators (mesos).

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37013/#review94683
---

Ship it!


As I mentioned in [r37018](https://reviews.apache.org/r/37018/), I think the 
process will be smooother if we commit this sooner than later. I'll update the 
following instances before I commit!


include/mesos/resources.hpp (line 290)


```
-  operator const google::protobuf::RepeatedPtrField& () const;
+  operator const google::protobuf::RepeatedPtrField&() const;
```



src/common/attributes.hpp (line 77)


```
-  operator const google::protobuf::RepeatedPtrField& () const
+  operator const google::protobuf::RepeatedPtrField&() const
```



src/common/resources.cpp (line 1054)


```
-Resources::operator const google::protobuf::RepeatedPtrField& () 
const
+Resources::operator const google::protobuf::RepeatedPtrField&() 
const
```


2 instances were found in comments:

`src/state/log.cpp`
```
-  // must be used instead of 'operator []' since Snapshot doesn't have
+  // must be used instead of 'operator[]' since Snapshot doesn't have
```

`src/tests/containerizer/docker_containerizer_tests.cpp`
```
-// current implementation of 'UPID::operator bool ()' fails if the IP
+// current implementation of 'UPID::operator bool()' fails if the IP
```

- Michael Park


On Aug. 8, 2015, 9:57 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37013/
> ---
> 
> (Updated Aug. 8, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 3824ec0b11cc2d3e4a2a8409171107839d706a28 
>   docs/mesos-c++-style-guide.md d8ad0acbb5f1484699f06e6748328a1ec0e7957f 
>   include/mesos/resources.hpp d4d5cafd937cccf6c4eff905e3024d53b4594bf7 
>   include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 
>   include/mesos/values.hpp c61f9e87f1e240c71571793d24751fbe53ed45d2 
>   src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 
>   src/common/attributes.cpp a8a621e52f0399dbd480437279bdbadf0916f745 
>   src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 
>   src/common/type_utils.cpp 36a2469274abb356376279cf7c2f88cf29c2796e 
>   src/common/values.cpp 2431d9e276072c40061f8626d56a0727b16a088f 
>   src/jvm/jvm.hpp 90febda728e7068f7ace678c55a7061741c748bb 
>   src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf 
>   src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
>   src/linux/routing/filter/basic.hpp fea8976b8d4e53be23b2ba838a2091b7187b8e55 
>   src/linux/routing/filter/icmp.hpp b732193aafcbb72a79036cd69418dbfb21428fff 
>   src/linux/routing/filter/ip.hpp ec6f643639879639d56b81e97b4ea7b4b487e1e5 
>   src/linux/routing/handle.hpp 052c7cc1a967797d245a275d08cc774f627398a5 
>   src/log/log.hpp 7c905c7e431b6663af8cdbce94d98c905da878ae 
>   src/log/network.hpp ff3496b2f648944087eaed8b314d64f3671c3f50 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 6aec14f2dbe4476f9c2a857f2d54f30c12c3133d 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 85eef6bbb4c8b3436f0cd345cd9f1c4e8289e110 
>   src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
>   src/master/registrar.hpp c1463c52b835e3dd653e64dcceacdb31b00fca54 
>   src/messages/flags.hpp 17f8bf3aaa2f10d20abac14c4ace845cde251760 
>   src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d 
>   src/messages/messages.hpp f7afcf757696cd210b26ce8dd3a173f036c23da1 
>   src/slave/gc.hpp 780f9c988b72ad3b22db191a62bff62621b15733 
>   src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
>   src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 
>   src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
>   src/zookeeper/authentication.hpp 1c503077cd577cd0440e62d7b9c7ddf128bbceab 
>   src/zookeeper/group.hpp 9e0ed327aec6f26982984d8fd379dbd6140589b3 
>   src/zookeeper/url.hpp b4253e86c0e597a737e83a9660d29ea9748bf285 
>   src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b 
> 
> Diff: https://reviews.apache.org/r/37013/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37268: Style checker checking for { on newline

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
---


Bad patch!

Reviews applied: [37266]

Failed command: ./support/apply-review.sh -n -r 37266

Error:
 2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ 
[8119/8119] -> "37266.patch" [1]
Traceback (most recent call last):
  File "./support/jsonurl.py", line 25, in 
print data
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3: 
ordinal not in range(128)
Successfully applied: Style checker checking for { on newline

As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.

This commit contains the files changed in the mesos project


Review: https://reviews.apache.org/r/37266
fatal: empty ident name (for ) not allowed
Failed to commit patch

- Mesos ReviewBot


On Aug. 9, 2015, 4:57 a.m., José Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> ---
> 
> (Updated Aug. 9, 2015, 4:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As requested in the issue MESOS-2578 the style checker now
> verifies "{" on newline for class and methods declarations.
> 
> This commit contains the files changed in the stout project
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 30baa65837621a277cf9d1042a751bfe18004b05 
> 
> Diff: https://reviews.apache.org/r/37268/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> José Guilherme Vanz
> 
>

Re: Review Request 37013: [1/3] Removed whitespace padding in overloaded operators (mesos).

[Michael Park]

> On Aug. 8, 2015, 8:14 p.m., Michael Park wrote:
> > docs/mesos-c++-style-guide.md, line 40
> > 
> >
> > I think we can simply delete this, rather than saying "don't do". What 
> > do you think?
> 
> Artem Harutyunyan wrote:
> I'm not sure whether or not (new) developers will naturally skip the 
> whitespace around the operators :). But if you think that they will, then 
> sure, we can just remove the line.
> 
> Michael Park wrote:
> Yeah, it's the norm in the C++ community (C++ Standard, `cppreference`, 
> Scott Meyers' Effective C++ series, ClangFormat, etc).

Removed and committed.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37013/#review94645
---


On Aug. 8, 2015, 9:57 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37013/
> ---
> 
> (Updated Aug. 8, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 3824ec0b11cc2d3e4a2a8409171107839d706a28 
>   docs/mesos-c++-style-guide.md d8ad0acbb5f1484699f06e6748328a1ec0e7957f 
>   include/mesos/resources.hpp d4d5cafd937cccf6c4eff905e3024d53b4594bf7 
>   include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 
>   include/mesos/values.hpp c61f9e87f1e240c71571793d24751fbe53ed45d2 
>   src/common/attributes.hpp 0a043d5b5dca804c6dd215cabd2704f24df71a33 
>   src/common/attributes.cpp a8a621e52f0399dbd480437279bdbadf0916f745 
>   src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 
>   src/common/type_utils.cpp 36a2469274abb356376279cf7c2f88cf29c2796e 
>   src/common/values.cpp 2431d9e276072c40061f8626d56a0727b16a088f 
>   src/jvm/jvm.hpp 90febda728e7068f7ace678c55a7061741c748bb 
>   src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf 
>   src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
>   src/linux/routing/filter/basic.hpp fea8976b8d4e53be23b2ba838a2091b7187b8e55 
>   src/linux/routing/filter/icmp.hpp b732193aafcbb72a79036cd69418dbfb21428fff 
>   src/linux/routing/filter/ip.hpp ec6f643639879639d56b81e97b4ea7b4b487e1e5 
>   src/linux/routing/handle.hpp 052c7cc1a967797d245a275d08cc774f627398a5 
>   src/log/log.hpp 7c905c7e431b6663af8cdbce94d98c905da878ae 
>   src/log/network.hpp ff3496b2f648944087eaed8b314d64f3671c3f50 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 6aec14f2dbe4476f9c2a857f2d54f30c12c3133d 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 85eef6bbb4c8b3436f0cd345cd9f1c4e8289e110 
>   src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
>   src/master/registrar.hpp c1463c52b835e3dd653e64dcceacdb31b00fca54 
>   src/messages/flags.hpp 17f8bf3aaa2f10d20abac14c4ace845cde251760 
>   src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d 
>   src/messages/messages.hpp f7afcf757696cd210b26ce8dd3a173f036c23da1 
>   src/slave/gc.hpp 780f9c988b72ad3b22db191a62bff62621b15733 
>   src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
>   src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 
>   src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
>   src/zookeeper/authentication.hpp 1c503077cd577cd0440e62d7b9c7ddf128bbceab 
>   src/zookeeper/group.hpp 9e0ed327aec6f26982984d8fd379dbd6140589b3 
>   src/zookeeper/url.hpp b4253e86c0e597a737e83a9660d29ea9748bf285 
>   src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b 
> 
> Diff: https://reviews.apache.org/r/37013/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37260: mesos: Fixed break before braces style for 'enum'.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37260/
---

(Updated Aug. 9, 2015, 11:57 p.m.)


Review request for mesos and Artem Harutyunyan.


Changes
---

Rebased.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/clang-format.md ce51a61d4ee0a3331e97b23ddcfd92405694f5c1 
  docs/mesos-c++-style-guide.md 857f3dc9fe3c0013034045878f2e54d6a78214d1 
  src/authentication/cram_md5/authenticatee.cpp 
63ae17e5ed4702eb48feb2217e8f30556de78f42 
  src/authentication/cram_md5/authenticator.cpp 
6a84e9184df837cd90ac7485b88ae7f47e12537b 
  src/examples/event_call_framework.cpp 
02c24c2cd45b3dcb97def605aa735c6efd951943 
  src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d 
  src/log/coordinator.cpp da689fa294832e72a9f4733ba475371f5866eeab 
  src/slave/containerizer/composing.cpp 
a6a170c7e8e962953952fce057332764e3685e90 
  src/slave/containerizer/docker.hpp e43d300fa4b7bf486227359150ea788ed89c1945 
  src/slave/slave.hpp 02b711507c9a70df10cdace6b850c4d7803186bb 
  src/state/zookeeper.cpp 54ee88cfda3b711df7bc0f927320bfc68724fe64 
  src/tests/containerizer/docker_containerizer_tests.cpp 
fb86cfeff77502106926d0adea72af8b7240d1b1 
  src/zookeeper/group.hpp 8021e3bb57cd1d26a07b4d4cc96e2795cb79f577 

Diff: https://reviews.apache.org/r/37260/diff/


Testing
---

`ag --cpp -l -s "enum.*{"`
`make check`


Thanks,

Michael Park

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

[Michael Park]

> On Aug. 9, 2015, 11:10 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp, line 98
> > 
> >
> > Removed unnecessary specialization: `<>`.

Turns out I was wrong about this. Committed a fix.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018/#review94681
---


On Aug. 9, 2015, 10:16 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37018/
> ---
> 
> (Updated Aug. 9, 2015, 10:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Michael 
> Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> 39a6a3f26f59915f7a338796558eb19c93788ced 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 451a53d152011db0ca89a8b2e9bf47ba277cf132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 967201888114e01f1a2d3c9cfaae847f1ce42d13 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> 35fb034f303ffda8e786a8cb564b92d02cddbfe9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> ae54566b9d0160def6146aa0ce634bdbf0967142 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
> e969b09efc4ce6b080c6c7bea1a8a8d445c6a279 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
> 89e77bf75c642c00ac9e0d36a3dbe71838e0efab 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 4910ca3908c4b73a2faa9ee5360e6be2a9534f41 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 6e0a17859dd6dcfff37f61eb46f5f1883189e3ca 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
> 30baa65837621a277cf9d1042a751bfe18004b05 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 549fc46cedb643ef1ebdf8441c332a02ac45016d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
> 24c26e90d2386bf5319f07c69c20efacb95f12eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
> 5d7404bed73774644451f74a15c63da32441f529 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 
> 420d5bbb4c275eed3e663d40501b127d8fc7749f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> 0e94e22817e21fc7944a995092e54bf302ab0e2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
> bbb796d647e9dd591802722f498cdc2fd39bca3e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signals.hpp 
> 70e9b15445fe9a86d5b6e3da0542bbd1886ac8a9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> 5af9be8fe419fe7f798a31dfa399516cd3514f67 
>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 
> 0004fa5cd249269504155e51e52cd802c0916851 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> a7de91f73b08494157873dd8a0df8538c22d2e24 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> f0b0a488059e6cbc041697280356d45f3ff95f17 
>   3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp 
> ea8a13f25d72bb645842d32a91b168b67d33c3eb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> 5ad611497a47be64c539e832b9a1c23e6cf9586d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 450b3a7e67cf5f49888691d03997b8409004519e 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> 984c02c982dc4dd8eb528d79e715847ef7a693b8 
>   3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 
> d03678552ae222cb8748ac7e57c600f8688761c4 
> 
> Diff: https://reviews.apache.org/r/37018/diff/
> 
> 
> Testing
> ---
> 
> `egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 37258: stout: Fixed break before braces style for 'enum'.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37258/
---

(Updated Aug. 10, 2015, 12:59 a.m.)


Review request for mesos, Artem Harutyunyan and Till Toenshoff.


Repository: mesos


Description
---

See summary.

Left the instances in 
`3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc` and 
`3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h` alone since 
these are supposed to be simulate (and match?) what would be generated by 
`protobuf`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
549fc46cedb643ef1ebdf8441c332a02ac45016d 
  3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp 
e8a62175a9c266711064993233e4d224b8f850cd 
  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
ed75f95bbf6c54beea9f7a4d8aaaecaa04735535 

Diff: https://reviews.apache.org/r/37258/diff/


Testing
---

```bash
$ ag --cpp -l -s "enum.*{"
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h
```
`make check`


Thanks,

Michael Park

Re: Review Request 37259: libprocess: Fixed break before braces style for 'enum'.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37259/
---

(Updated Aug. 10, 2015, 12:59 a.m.)


Review request for mesos, Artem Harutyunyan and Till Toenshoff.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/clock.hpp 
0f73f894c753711db4fdefa9df40d5674aacc6f7 
  3rdparty/libprocess/include/process/http.hpp 
04c2274bbd53b7e7ed770ea201555218559af078 
  3rdparty/libprocess/include/process/process.hpp 
bf8e2bf46fad2eae1c9f1b788b2b71305664e508 
  3rdparty/libprocess/include/process/socket.hpp 
a882330b45be10bab1e3e8fd8983e172eb0e4efc 
  3rdparty/libprocess/src/decoder.hpp fa2984ef267e7a381d024d20d1b37f1d39148559 
  3rdparty/libprocess/src/encoder.hpp c5ff7615c99e3e7eafb132182428c779324d72b8 
  3rdparty/libprocess/src/libevent.hpp 6617ea6aa4f6033905985e789f681a7c5e0b1fa0 

Diff: https://reviews.apache.org/r/37259/diff/


Testing
---

`ag --cpp -l -s "enum.*{"`
`make check`


Thanks,

Michael Park

Re: Review Request 37246: Refactor store to use updated DockerImage.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37246/#review94691
---



src/slave/containerizer/provisioners/docker/store.hpp (line 52)


Why convert a C++ style comment to C style?


- Cong Wang


On Aug. 8, 2015, 1:37 a.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37246/
> ---
> 
> (Updated Aug. 8, 2015, 1:37 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor local store to use updated DockerImage.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37246/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37268: Style checker checking for { on newline

[José Guilherme Vanz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
---

(Updated Aug. 10, 2015, 1:46 a.m.)


Review request for mesos.


Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description
---

As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.

This commit contains the files changed in the stout project


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
30baa65837621a277cf9d1042a751bfe18004b05 

Diff: https://reviews.apache.org/r/37268/diff/


Testing
---


Thanks,

José Guilherme Vanz

Re: Review Request 37266: Style checker checking for { on newline

[José Guilherme Vanz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37266/
---

(Updated Aug. 10, 2015, 1:46 a.m.)


Review request for mesos.


Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description
---

As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.

This commit contains the files changed in the mesos project


Diffs
-

  src/authentication/cram_md5/authenticator.cpp 
6a84e9184df837cd90ac7485b88ae7f47e12537b 
  src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 
  src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
  src/logging/logging.cpp fb798670d9ac79c75ad39905614fbfe1ea25fba6 
  src/python/native/src/mesos/native/module.hpp 
31da47b474d017e910d90e41ad15f2163b07dc89 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
88c0cbc61f3f97b084cc3b3fae8999b07d4aa1c7 
  src/tests/containerizer/docker_containerizer_tests.cpp 
80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 
  src/tests/containerizer/rootfs.hpp 55dd4964cfb1ca0e5f7b7616ccc6d5ad2be135d7 
  src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 
  support/cpplint.py bfd3390002a680b07aa3fcf785279ad19625294b 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/37266/diff/


Testing
---


Thanks,

José Guilherme Vanz

Re: Review Request 37267: Style checker checking for { on newline

[José Guilherme Vanz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37267/
---

(Updated Aug. 10, 2015, 1:47 a.m.)


Review request for mesos.


Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578


Repository: mesos


Description
---

As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.

This commit contains the files changed in the libprocess project


Diffs
-

  3rdparty/libprocess/include/process/filter.hpp 
db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/future.hpp 
db92767619ec7b6ab1a0803c240725a2633d2489 
  3rdparty/libprocess/include/process/metrics/metric.hpp 
c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/process.hpp 
bf8e2bf46fad2eae1c9f1b788b2b71305664e508 

Diff: https://reviews.apache.org/r/37267/diff/


Testing
---


Thanks,

José Guilherme Vanz

Re: Review Request 37275: [3/3]Generate make batch file to build project in windows.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review94693
---


Patch looks great!

Reviews applied: [37272, 37273, 37275]

All tests passed.

- Mesos ReviewBot


On Aug. 9, 2015, 6:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Aug. 9, 2015, 6:21 p.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review94695
---


Bad patch!

Reviews applied: [37277]

Failed command: ./support/apply-review.sh -n -r 37277

Error:
 2015-08-10 02:30:31 URL:https://reviews.apache.org/r/37277/diff/raw/ 
[5524/5524] -> "37277.patch" [1]
error: patch failed: src/master/master.hpp:1628
error: src/master/master.hpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 9, 2015, 8:31 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37277/
> ---
> 
> (Updated Aug. 9, 2015, 8:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Just wanted to send out the abstraction for feedback.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7 
>   src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc 
>   src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 
> 
> Diff: https://reviews.apache.org/r/37277/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> No new tests have been added yet.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 37260: mesos: Fixed break before braces style for 'enum'.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37260/#review94696
---


Patch looks great!

Reviews applied: [37258, 37259, 37260]

All tests passed.

- Mesos ReviewBot


On Aug. 10, 2015, 1 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37260/
> ---
> 
> (Updated Aug. 10, 2015, 1 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md ce51a61d4ee0a3331e97b23ddcfd92405694f5c1 
>   docs/mesos-c++-style-guide.md 857f3dc9fe3c0013034045878f2e54d6a78214d1 
>   src/authentication/cram_md5/authenticatee.cpp 
> 63ae17e5ed4702eb48feb2217e8f30556de78f42 
>   src/authentication/cram_md5/authenticator.cpp 
> 6a84e9184df837cd90ac7485b88ae7f47e12537b 
>   src/examples/event_call_framework.cpp 
> 02c24c2cd45b3dcb97def605aa735c6efd951943 
>   src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d 
>   src/log/coordinator.cpp da689fa294832e72a9f4733ba475371f5866eeab 
>   src/slave/containerizer/composing.cpp 
> a6a170c7e8e962953952fce057332764e3685e90 
>   src/slave/containerizer/docker.hpp e43d300fa4b7bf486227359150ea788ed89c1945 
>   src/slave/slave.hpp 02b711507c9a70df10cdace6b850c4d7803186bb 
>   src/state/zookeeper.cpp 54ee88cfda3b711df7bc0f927320bfc68724fe64 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> fb86cfeff77502106926d0adea72af8b7240d1b1 
>   src/zookeeper/group.hpp 8021e3bb57cd1d26a07b4d4cc96e2795cb79f577 
> 
> Diff: https://reviews.apache.org/r/37260/diff/
> 
> 
> Testing
> ---
> 
> `ag --cpp -l -s "enum.*{"`
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>