[GitHub] [spark] AmplabJenkins removed a comment on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab
AmplabJenkins removed a comment on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/26138#issuecomment-542617331 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab
wangyum commented on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/26138#issuecomment-545758101 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect
maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move
the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338391294
##
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala
##
@@ -46,4 +47,14 @@ private case object MySQLDialect extends JdbcDialect {
}
override def isCascadingTruncateTable(): Option[Boolean] = Some(false)
+
+ override def validateFetchSize(size: Int): Unit = {
+require(size >= 0 || size == Integer.MIN_VALUE,
+ s"Invalid value `${size.toString}` for parameter " +
+s"`${JDBCOptions.JDBC_BATCH_FETCH_SIZE}` for MySQL. " +
+s"The value should be >= 0 or equals Integer.MIN_VALUE; " +
Review comment:
nit: you don't need `s` here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect
maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move
the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338390391
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##
@@ -184,6 +184,9 @@ private[jdbc] class JDBCRDD(
options: JDBCOptions)
extends RDD[InternalRow](sc, Nil) {
+ import scala.collection.JavaConverters._
Review comment:
How about moving this into the header and removing the other import?:
https://github.com/apache/spark/blob/fd899d6331f4777a36a3f2a79a6b2fa123dccc1a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala#L274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect
maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move
the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338391122
##
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##
@@ -150,6 +151,30 @@ abstract class JdbcDialect extends Serializable {
def beforeFetch(connection: Connection, properties: Map[String, String]):
Unit = {
}
+ /**
+ * Do some extra properties validation work in addition to the validation in
[[JDBCOptions]],
+ * eg. [[validateFetchSize()]].
+ * @param properties The connection properties. This is passed through from
the relation.
+ */
+ def validateProperties(properties: Map[String, String]): Unit = {
+val fetchSize = properties.getOrElse(JDBCOptions.JDBC_BATCH_FETCH_SIZE,
"0").toInt
+validateFetchSize(fetchSize)
+ }
+
+ /**
+ * This is to validate the fetch size specified via
[[JDBCOptions.JDBC_BATCH_FETCH_SIZE]].
+ * The implementation here requires the fetch size >= 0, sub classes may
override it to meet
+ * requirement of different dialects.
+ * @param size the fetch size to validate.
+ */
+ protected def validateFetchSize(size: Int): Unit = {
Review comment:
How about just making this IF public in JdbcDialect? Then, dropping
`validateProperties`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect
maropu commented on issue #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect URL: https://github.com/apache/spark/pull/26230#issuecomment-545757199 Can you add some tests in `JDBCSuite`? You can see the other examples there, e.g., https://github.com/apache/spark/blob/fd899d6331f4777a36a3f2a79a6b2fa123dccc1a/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala#L781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
cloud-fan commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545756654 The last argument is about performance: https://github.com/apache/spark/pull/26190#discussion_r338206250 My point is that: The regex-based java version is faster but it's not as functional as the antlr parser as I pointed out in the above comment. Now we are in the early stage of exposing the interval type, and we should focus more on the functionality instead of performance. For the `INTERVAL '...'` literal syntax and parsing watermark string, the performance doesn't really matter. For cast, the performance matters, but it's better to have a UTF8String based parser instead of regex-based. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL]
Add partitionby hint for sql queries
URL: https://github.com/apache/spark/pull/25464#discussion_r338391078
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##
@@ -137,31 +137,96 @@ object ResolveHints {
}
/**
- * COALESCE Hint accepts name "COALESCE" and "REPARTITION".
- * Its parameter includes a partition number.
+ * COALESCE Hint accepts names "COALESCE", "REPARTITION", and
"REPARTITIONBYRANGE".
*/
- object ResolveCoalesceHints extends Rule[LogicalPlan] {
-private val COALESCE_HINT_NAMES = Set("COALESCE", "REPARTITION")
+ class ResolveCoalesceHints(conf: SQLConf) extends Rule[LogicalPlan] {
+
+/**
+ * This function handles hints for "COALESCE" and "REPARTITION".
+ * The "COALESCE" hint only has a partition number as a parameter. The
"REPARTITION" hint
+ * has a partition number, columns, or both of them as parameters.
+ */
+private def createRepartition(
+shuffle: Boolean, hint: UnresolvedHint): LogicalPlan = {
+ val hintName = hint.name.toUpperCase(Locale.ROOT)
+
+ def createRepartitionByExpression(
+ numPartitions: Int, partitionExprs: Seq[Any]):
RepartitionByExpression = {
+val invalidParams =
partitionExprs.filter(!_.isInstanceOf[UnresolvedAttribute])
+if (invalidParams.nonEmpty) {
+ throw new AnalysisException(s"$hintName Hint parameter should
include columns, but " +
+s"${invalidParams.mkString(", ")} found")
+}
+RepartitionByExpression(
+ partitionExprs.map(_.asInstanceOf[Expression]), hint.child,
numPartitions)
+ }
-def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperators {
- case h: UnresolvedHint if
COALESCE_HINT_NAMES.contains(h.name.toUpperCase(Locale.ROOT)) =>
-val hintName = h.name.toUpperCase(Locale.ROOT)
-val shuffle = hintName match {
- case "REPARTITION" => true
- case "COALESCE" => false
+ hint.parameters match {
+case Seq(IntegerLiteral(numPartitions)) =>
+ Repartition(numPartitions, shuffle, hint.child)
+case Seq(numPartitions: Int) =>
+ Repartition(numPartitions, shuffle, hint.child)
+// The "COALESCE" hint (shuffle = false) must have a partition number
only
+case _ if !shuffle =>
+ throw new AnalysisException(s"$hintName Hint expects a partition
number as a parameter")
+
+case param @ Seq(IntegerLiteral(numPartitions), _*) if shuffle =>
+ createRepartitionByExpression(numPartitions, param.tail)
+case param @ Seq(numPartitions: Int, _*) if shuffle =>
+ createRepartitionByExpression(numPartitions, param.tail)
+case param @ Seq(_*) if shuffle =>
+ createRepartitionByExpression(conf.numShufflePartitions, param)
+ }
+}
+
+/**
+ * This function handles hints for "REPARTITIONBYRANGE".
+ * The "REPARTITIONBYRANGE" hint must have column names and a partition
number is optional.
+ */
+private def createRepartitionByRange(hint: UnresolvedHint):
RepartitionByExpression = {
+ val hintName = hint.name.toUpperCase(Locale.ROOT)
+
+ def createRepartitionByExpression(
Review comment:
`createRepartitionByExpression` seems duplicated. Can we just make one
private function to share?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL]
Add partitionby hint for sql queries
URL: https://github.com/apache/spark/pull/25464#discussion_r338390931
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##
@@ -137,31 +137,96 @@ object ResolveHints {
}
/**
- * COALESCE Hint accepts name "COALESCE" and "REPARTITION".
- * Its parameter includes a partition number.
+ * COALESCE Hint accepts names "COALESCE", "REPARTITION", and
"REPARTITIONBYRANGE".
*/
- object ResolveCoalesceHints extends Rule[LogicalPlan] {
-private val COALESCE_HINT_NAMES = Set("COALESCE", "REPARTITION")
+ class ResolveCoalesceHints(conf: SQLConf) extends Rule[LogicalPlan] {
+
+/**
+ * This function handles hints for "COALESCE" and "REPARTITION".
+ * The "COALESCE" hint only has a partition number as a parameter. The
"REPARTITION" hint
+ * has a partition number, columns, or both of them as parameters.
+ */
+private def createRepartition(
+shuffle: Boolean, hint: UnresolvedHint): LogicalPlan = {
+ val hintName = hint.name.toUpperCase(Locale.ROOT)
+
+ def createRepartitionByExpression(
+ numPartitions: Int, partitionExprs: Seq[Any]):
RepartitionByExpression = {
+val invalidParams =
partitionExprs.filter(!_.isInstanceOf[UnresolvedAttribute])
+if (invalidParams.nonEmpty) {
+ throw new AnalysisException(s"$hintName Hint parameter should
include columns, but " +
+s"${invalidParams.mkString(", ")} found")
+}
+RepartitionByExpression(
+ partitionExprs.map(_.asInstanceOf[Expression]), hint.child,
numPartitions)
+ }
-def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperators {
- case h: UnresolvedHint if
COALESCE_HINT_NAMES.contains(h.name.toUpperCase(Locale.ROOT)) =>
-val hintName = h.name.toUpperCase(Locale.ROOT)
-val shuffle = hintName match {
- case "REPARTITION" => true
- case "COALESCE" => false
+ hint.parameters match {
+case Seq(IntegerLiteral(numPartitions)) =>
+ Repartition(numPartitions, shuffle, hint.child)
+case Seq(numPartitions: Int) =>
+ Repartition(numPartitions, shuffle, hint.child)
+// The "COALESCE" hint (shuffle = false) must have a partition number
only
+case _ if !shuffle =>
+ throw new AnalysisException(s"$hintName Hint expects a partition
number as a parameter")
+
+case param @ Seq(IntegerLiteral(numPartitions), _*) if shuffle =>
+ createRepartitionByExpression(numPartitions, param.tail)
Review comment:
Hm, It's `REPARTITION()` but why does it creates range partition in this
case? Do you intend to support range partition by something like
`REPARTITION(...)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)
AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755371 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)
AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755378 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112578/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)
AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755378 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112578/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)
AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755371 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)
SparkQA removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545709744 **[Test build #112578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112578/testReport)** for PR 26238 at commit [`62790ac`](https://github.com/apache/spark/commit/62790acf0d8bb72add6e813b9b02a4c6994d8dd9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)
SparkQA commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545754953 **[Test build #112578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112578/testReport)** for PR 26238 at commit [`62790ac`](https://github.com/apache/spark/commit/62790acf0d8bb72add6e813b9b02a4c6994d8dd9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754294 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754298 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17551/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754294 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries
HyukjinKwon commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-545754103 Looks making sense to me. cc @maryannxue, @maropu, @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754298 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17551/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545753982 **[Test build #112587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112587/testReport)** for PR 26190 at commit [`48b7ef4`](https://github.com/apache/spark/commit/48b7ef4c42c2bf98ffda16e77e2ef10bd78f5d9f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats
HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL]
New statistic to improve data size estimate for columnar storage formats
URL: https://github.com/apache/spark/pull/26016#discussion_r338388607
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -1331,6 +1331,29 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val DESERIALIZATION_FACTOR_CALC_ENABLED =
+buildConf("spark.sql.statistics.deserFactor.calc.enabled")
+ .doc("Enables the calculation of the deserialization factor as a table
statistic. " +
+"This factor is intended to be calculated for columnar storage formats
as a ratio of " +
+"actual data size to raw file size but currently Spark calculates this
only for the ORC " +
+"format. Spark uses this ratio is to scale up the estimated size,
which leads to " +
+"better estimate of in-memory data size and improves the query
optimization (i.e., join " +
+"strategy). In case of partitioned table the maximum of these factors
is taken. " +
+"Spark stores this factor in the meta store and reuses it so the table
" +
+"can grow without having to recompute this statistic. " +
+"The stored factor can be removed only by a TRUNCATE or a DROP table
so even a " +
+"subsequent ANALYZE TABLE where the calculation is disabled keeps the
old value.")
+ .booleanConf
+ .createWithDefault(false)
+
+ val DESERIALIZATION_FACTOR_EXTRA_DISTORTION =
+buildConf("spark.sql.statistics.deserFactor.distortion")
Review comment:
Sorry if I rushed to read but why do we need this configuration?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17550/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752463 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752440 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752446 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17549/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752446 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17549/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17550/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752463 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752440 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
SparkQA commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752072 **[Test build #112585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112585/testReport)** for PR 25854 at commit [`307802a`](https://github.com/apache/spark/commit/307802a5e599fadfafc9fb4ffe2ccbd10d60f6ba). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752071 **[Test build #112586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112586/testReport)** for PR 26190 at commit [`77f69a1`](https://github.com/apache/spark/commit/77f69a11216bc0012653f2fcfd35ceb496af39b2). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AngersZh commented on a change in pull request #25854: [SPARK-29145][SQL]
Support sub-queries in join conditions
URL: https://github.com/apache/spark/pull/25854#discussion_r338387047
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
##
@@ -204,6 +204,84 @@ class SubquerySuite extends QueryTest with
SharedSparkSession {
}
}
+ test("SPARK-29145: JOIN Condition use QueryList") {
+withTempView("s1", "s2", "s3") {
+ Seq(1, 3, 5, 7, 9).toDF("id").createOrReplaceTempView("s1")
+ Seq(1, 3, 4, 6, 9).toDF("id").createOrReplaceTempView("s2")
+ Seq(3, 4, 6, 9).toDF("id").createOrReplaceTempView("s3")
+
+ checkAnswer(
+sql("SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id IN
(select 9)"),
+Row(9) :: Nil)
+
+ checkAnswer(
+sql("SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id NOT IN
(select 9)"),
+Row(1) :: Row(3) :: Nil)
+
+ // case `IN`
+ checkAnswer(
+sql("SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id IN
(select id from s3)"),
+Row(3) :: Row(9) :: Nil)
+
+ checkAnswer(
+sql("SELECT s1.id as id2 from s1 LEFT SEMI JOIN s2 " +
Review comment:
Changed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112576/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750782 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750786 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112576/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750782 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17548/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17548/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750602 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750560 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17547/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750554 Build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750602 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750405 **[Test build #112576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112576/testReport)** for PR 26237 at commit [`9f234e9`](https://github.com/apache/spark/commit/9f234e9c3bb7f7756b456b197fd31bde90dd396f). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class UncacheTableStatement(` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750560 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17547/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750554 Build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands
SparkQA removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545704979 **[Test build #112576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112576/testReport)** for PR 26237 at commit [`9f234e9`](https://github.com/apache/spark/commit/9f234e9c3bb7f7756b456b197fd31bde90dd396f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats
HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL]
New statistic to improve data size estimate for columnar storage formats
URL: https://github.com/apache/spark/pull/26016#discussion_r338386395
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##
@@ -46,6 +47,17 @@ object OrcUtils extends Logging {
"ZLIB" -> ".zlib",
"LZO" -> ".lzo")
+ def rawSize(hadoopConf: Configuration, filePath: Path): BigInt = {
+val fs = filePath.getFileSystem(hadoopConf)
+val readerOptions = OrcFile.readerOptions(hadoopConf).filesystem(fs)
+try {
+ val reader = OrcFile.createReader(filePath, readerOptions)
Review comment:
Hm, wouldn't this require the driver side to touch and read every file?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750297 **[Test build #112584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112584/testReport)** for PR 26190 at commit [`f759fd5`](https://github.com/apache/spark/commit/f759fd5f5e088ceded5f6980204e335a5800e9c9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] PavithraRamachandran commented on a change in pull request #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab
PavithraRamachandran commented on a change in pull request #26138:
[SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in
JDBC/ODBC Server Tab
URL: https://github.com/apache/spark/pull/26138#discussion_r338386018
##
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ToolTips.scala
##
@@ -29,4 +29,16 @@ private[ui] object ToolTips {
val THRIFT_SERVER_DURATION =
"Difference between start time and close time"
+
+ val THRIFT_SESSION_TOTAL_EXECUTE =
+"Number of operations submitted in this session."
+
+ val THRIFT_SESSION_START_TIME =
+"Session Start time,on launching the session."
+
+ val THRIFT_SESSION_FINISH_TIME =
+"Session end time, after closing the session."
+
+ val THRIFT_SESSION_DURATION =
+"Active duration of the session."
Review comment:
@wangyum i have added tooltip for all the columns in session table. Could
you review?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing
cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#discussion_r338384646 ## File path: sql/core/benchmarks/IntervalBenchmark-results.txt ## @@ -1,25 +1,25 @@ -Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 10.15 -Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz +Java HotSpot(TM) 64-Bit Server VM 1.8.0_161-b12 on Mac OS X 10.14 +Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz cast strings to intervals:Best Time(ms) Avg Time(ms) Stdev(ms)Rate(M/s) Per Row(ns) Relative -string w/ interval 420435 18 2.4 419.8 1.0X -string w/o interval 359365 10 2.8 358.7 1.2X -1 units w/ interval 752759 8 1.3 752.0 0.6X -1 units w/o interval762766 4 1.3 762.0 0.6X -2 units w/ interval 961970 8 1.0 960.7 0.4X -2 units w/o interval970976 9 1.0 970.2 0.4X -3 units w/ interval1130 1136 7 0.91130.4 0.4X -3 units w/o interval 1150 1158 9 0.91150.3 0.4X -4 units w/ interval1333 1336 3 0.71333.5 0.3X -4 units w/o interval 1354 1359 4 0.71354.5 0.3X -5 units w/ interval1523 1525 2 0.71523.3 0.3X -5 units w/o interval 1549 1551 3 0.61549.4 0.3X -6 units w/ interval1661 1663 2 0.61660.8 0.3X -6 units w/o interval 1691 1704 13 0.61691.2 0.2X -7 units w/ interval1811 1817 8 0.61810.6 0.2X -7 units w/o interval 1853 1854 1 0.51853.2 0.2X -8 units w/ interval2029 2037 8 0.52028.7 0.2X -8 units w/o interval 2075 2075 1 0.52074.5 0.2X -9 units w/ interval2170 2175 5 0.52170.0 0.2X -9 units w/o interval 2204 2212 8 0.52203.6 0.2X +prepare string w/ interval 403419 18 2.5 403.1 1.0X +prepare string w/o interval 341353 21 2.9 341.1 1.2X +1 units w/ interval5154 5159 8 0.25153.5 0.1X +1 units w/o interval 4818 4833 20 0.24817.6 0.1X +2 units w/ interval6191 6223 41 0.26190.6 0.1X +2 units w/o interval 6236 6264 25 0.26235.7 0.1X +3 units w/ interval7397 7567 170 0.17397.0 0.1X +3 units w/o interval 7280 7367 76 0.17279.6 0.1X +4 units w/ interval8197 8228 27 0.18197.3 0.0X +4 units w/o interval 7977 7989 17 0.17977.3 0.1X +5 units w/ interval9089 9192 101 0.19088.8 0.0X +5 units w/o interval 8853 8858 5 0.18852.8 0.0X +6 units w/ interval9696 9720 23 0.19695.6 0.0X +6 units w/o interval 9509 9518 9 0.19509.4 0.0X +7 units w/ interval 10738
[GitHub] [spark] maropu commented on issue #25344: [SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect
maropu commented on issue #25344: [SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-545746972 That should be like this? https://github.com/apache/spark/pull/25344/files#diff-391379a5ec51082e2ae1209db15c02b3R549 ``` case ShortType => (stmt: PreparedStatement, row: Row, pos: Int) => stmt.setInt(pos + 1, row.getShort(pos)) ``` => ``` case ShortType => (stmt: PreparedStatement, row: Row, pos: Int) => stmt.setShort(pos + 1, row.getShort(pos)) ``` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-545746713 This patch is a bit hard to say a bug fix (as pointed out at https://github.com/apache/spark/pull/25749#issuecomment-530565191) and I think that's why it was not backported .. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
HyukjinKwon commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545746315 Seems making sense to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"
maropu commented on a change in pull request #25854: [SPARK-29145][SQL] Spark
SQL cannot handle "NOT IN" condition when using "JOIN"
URL: https://github.com/apache/spark/pull/25854#discussion_r338382197
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
##
@@ -204,6 +204,84 @@ class SubquerySuite extends QueryTest with
SharedSparkSession {
}
}
+ test("SPARK-29145: JOIN Condition use QueryList") {
+withTempView("s1", "s2", "s3") {
+ Seq(1, 3, 5, 7, 9).toDF("id").createOrReplaceTempView("s1")
+ Seq(1, 3, 4, 6, 9).toDF("id").createOrReplaceTempView("s2")
+ Seq(3, 4, 6, 9).toDF("id").createOrReplaceTempView("s3")
+
+ checkAnswer(
+sql("SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id IN
(select 9)"),
+Row(9) :: Nil)
+
+ checkAnswer(
+sql("SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id NOT IN
(select 9)"),
+Row(1) :: Row(3) :: Nil)
+
+ // case `IN`
+ checkAnswer(
+sql("SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id IN
(select id from s3)"),
+Row(3) :: Row(9) :: Nil)
+
+ checkAnswer(
+sql("SELECT s1.id as id2 from s1 LEFT SEMI JOIN s2 " +
Review comment:
nit: can you follow the format of the other tests? In multi-line cases, the
format seems to be like this;
```
sql("""
|
| ...
...
| ) """.stripMargin)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"
maropu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545745432 Can you update the title? `Support sub-queries in join conditions`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py
AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744459 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py
AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17546/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py
AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17546/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py
AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744459 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py
SparkQA commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744186 **[Test build #112583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112583/testReport)** for PR 26232 at commit [`bff5a70`](https://github.com/apache/spark/commit/bff5a70e2bdcd23fccdb03647fd70f0197440cac). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #26114: [SPARK-29468][SQL] Change Literal.sql to be correct for floats.
maropu commented on a change in pull request #26114: [SPARK-29468][SQL] Change
Literal.sql to be correct for floats.
URL: https://github.com/apache/spark/pull/26114#discussion_r338379260
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##
@@ -370,7 +390,7 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
case _ if v.isNaN => "'NaN'"
case Float.PositiveInfinity => "'Infinity'"
case Float.NegativeInfinity => "'-Infinity'"
-case _ => v
+case _ => s"'$v'"
Review comment:
oh, that's smarter..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] PavithraRamachandran commented on issue #26222: [SPARK-29504][WebUI] Toggle full job description on click
PavithraRamachandran commented on issue #26222: [SPARK-29504][WebUI] Toggle full job description on click URL: https://github.com/apache/spark/pull/26222#issuecomment-545740477 @gengliangwang thank you . Could you merge? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] habren closed pull request #24663: [SPARK-27792][SQL] SkewJoin--handle only skewed keys with broadcastjoin
habren closed pull request #24663: [SPARK-27792][SQL] SkewJoin--handle only skewed keys with broadcastjoin URL: https://github.com/apache/spark/pull/24663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26109: [SPARK-29461][SQL] Measure the number of records being updated for JDBC writer
SparkQA commented on issue #26109: [SPARK-29461][SQL] Measure the number of records being updated for JDBC writer URL: https://github.com/apache/spark/pull/26109#issuecomment-545736477 **[Test build #112582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112582/testReport)** for PR 26109 at commit [`620d111`](https://github.com/apache/spark/commit/620d111d91da8ea8ece0cda50d531d50e3ad5020). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545735858 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545735864 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112573/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545735858 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545735864 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112573/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
SparkQA removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545687186 **[Test build #112573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112573/testReport)** for PR 26184 at commit [`80b80e5`](https://github.com/apache/spark/commit/80b80e5f207577760564e145210f9246750515ee). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545735535 **[Test build #112573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112573/testReport)** for PR 26184 at commit [`80b80e5`](https://github.com/apache/spark/commit/80b80e5f207577760564e145210f9246750515ee). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545734989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112572/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545734987 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545734987 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545734989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112572/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545734557 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112581/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
SparkQA removed a comment on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545685637 **[Test build #112572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112572/testReport)** for PR 26184 at commit [`8f33e02`](https://github.com/apache/spark/commit/8f33e02610fdafab8397cd561fb189c557e0e8fe). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
AmplabJenkins removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545734552 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26184: [SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26184#issuecomment-545734603 **[Test build #112572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112572/testReport)** for PR 26184 at commit [`8f33e02`](https://github.com/apache/spark/commit/8f33e02610fdafab8397cd561fb189c557e0e8fe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
SparkQA removed a comment on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545729039 **[Test build #112581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112581/testReport)** for PR 26118 at commit [`a52de2e`](https://github.com/apache/spark/commit/a52de2e4b258e7fecad4143e00f01df4b096a513). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545734557 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112581/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
AmplabJenkins commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545734552 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.
SparkQA commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545734318 **[Test build #112581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112581/testReport)** for PR 26118 at commit [`a52de2e`](https://github.com/apache/spark/commit/a52de2e4b258e7fecad4143e00f01df4b096a513). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AmplabJenkins removed a comment on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545733271 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AmplabJenkins commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545733556 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AmplabJenkins commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545733271 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-545733055 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-545733059 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112574/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-545733059 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112574/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-545733055 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
SparkQA removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-545687207 **[Test build #112574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112574/testReport)** for PR 26178 at commit [`83b9f19`](https://github.com/apache/spark/commit/83b9f19beb1bea7b31ca46c5338649d3dcf86d15). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AngersZh commented on issue #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240#issuecomment-545732686 @gatorsmile Open pr for branch-2.4. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-545732712 **[Test build #112574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112574/testReport)** for PR 26178 at commit [`83b9f19`](https://github.com/apache/spark/commit/83b9f19beb1bea7b31ca46c5338649d3dcf86d15). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu opened a new pull request #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe
AngersZh opened a new pull request #26240: [SPARK-29530][SQL][branch-2.4] Make SQLConf in SQL parse process thread safe URL: https://github.com/apache/spark/pull/26240 ### What changes were proposed in this pull request? SparkSession.sql() method parse process not under current sparksession's conf, so some configuration about parser is not valid in multi-thread situation. In this pr, we add a SQLConf parameter to AbstractSqlParser and initial it with SessionState's conf. Then for each SparkSession's parser process. It will use's it's own SessionState's SQLConf and to be thread safe ### Why are the changes needed? Fix bug ### Does this PR introduce any user-facing change? NO ### How was this patch tested? NO This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
AmplabJenkins removed a comment on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite URL: https://github.com/apache/spark/pull/26234#issuecomment-545731656 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112575/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
AmplabJenkins commented on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite URL: https://github.com/apache/spark/pull/26234#issuecomment-545731652 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
AmplabJenkins commented on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite URL: https://github.com/apache/spark/pull/26234#issuecomment-545731656 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112575/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
AmplabJenkins removed a comment on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite URL: https://github.com/apache/spark/pull/26234#issuecomment-545731652 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] LantaoJin edited a comment on issue #24663: [SPARK-27792][SQL] SkewJoin--handle only skewed keys with broadcastjoin
LantaoJin edited a comment on issue #24663: [SPARK-27792][SQL] SkewJoin--handle only skewed keys with broadcastjoin URL: https://github.com/apache/spark/pull/24663#issuecomment-545730909 It looks like the same with https://github.com/frb502/spark-skewed-join-hint/blob/28c3ac5601f938d1a8c61548cf09f7ff998046c2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala#L102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
SparkQA removed a comment on issue #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite URL: https://github.com/apache/spark/pull/26234#issuecomment-545688821 **[Test build #112575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112575/testReport)** for PR 26234 at commit [`cce2fcc`](https://github.com/apache/spark/commit/cce2fccc825d64a0d6302b9eeab387671a9c1336). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
