[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181765818
  
Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52155123
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,7 +61,7 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receivers = MutableList(receiverActor) ++ receivers
--- End diff --

If you retain a Scala collection here, it's more direct / efficient in 
theory to write `receiverActor +=: receivers` to prepend. In practice, I don't 
know what people find easier to understand.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52163789
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -39,7 +39,7 @@ case class UnsubscribeReceiver(receiverActor: ActorRef)
 class FeederActor extends Actor {
 
   val rand = new Random()
-  var receivers: LinkedList[ActorRef] = new LinkedList[ActorRef]()
+  var receivers: ArrayBuffer[ActorRef] = new ArrayBuffer[ActorRef]()
--- End diff --

This could just be `var receivers =ArrayBuffer[ActorRef]()`. In fact it can 
be a `val`; the one other assignment in the line with `dropWhile` is pointless 
for a mutable collection.

I suppose one could argue we should be using some form of linked list with 
O(1) insertion at the head, but given it's an example, I'm not so worried.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

GitHub user agsachin opened a pull request:

https://github.com/apache/spark/pull/3

[SPARK-13177][Examples]Update ActorWordCount example to not directly use 
low level linked list as it is deprecated.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agsachin/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit c8bc67ec900bed7f8f0d7884f543281a0e216956
Author: sachin aggarwal 
Date:   2016-02-08T10:29:42Z

changing LinkedList to MutableList

commit 1c9adfaf8ef7668bd336b583e45a012b0353de22
Author: sachin aggarwal 
Date:   2016-02-08T10:31:01Z

Merge branch 'master' of github.com:agsachin/spark




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

Github user agsachin commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52155735
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -18,16 +18,14 @@
 // scalastyle:off println
 package org.apache.spark.examples.streaming
 
-import scala.collection.mutable.LinkedList
-import scala.reflect.ClassTag
-import scala.util.Random
-
 import akka.actor._
 import com.typesafe.config.ConfigFactory
-
 import org.apache.spark.SparkConf
-import org.apache.spark.streaming.{Seconds, StreamingContext}
 import org.apache.spark.streaming.akka.{ActorReceiver, AkkaUtils}
+import org.apache.spark.streaming.{Seconds, StreamingContext}
+
+import scala.collection.mutable._
--- End diff --

sorry , will fix that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

Github user agsachin commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181349834
  
@srowen  if this is ok can u ask jenkins to test..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52154782
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -39,7 +37,7 @@ case class UnsubscribeReceiver(receiverActor: ActorRef)
 class FeederActor extends Actor {
 
   val rand = new Random()
-  var receivers: LinkedList[ActorRef] = new LinkedList[ActorRef]()
+  var receivers: MutableList[ActorRef] = new MutableList[ActorRef]()
--- End diff --

I think `mutable.ArrayBuffer` is more standard?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52154706
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -18,16 +18,14 @@
 // scalastyle:off println
 package org.apache.spark.examples.streaming
 
-import scala.collection.mutable.LinkedList
-import scala.reflect.ClassTag
-import scala.util.Random
-
 import akka.actor._
 import com.typesafe.config.ConfigFactory
-
 import org.apache.spark.SparkConf
-import org.apache.spark.streaming.{Seconds, StreamingContext}
 import org.apache.spark.streaming.akka.{ActorReceiver, AkkaUtils}
+import org.apache.spark.streaming.{Seconds, StreamingContext}
+
+import scala.collection.mutable._
--- End diff --

These imports were in the right place before


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181299450
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

Github user agsachin commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52155740
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,7 +61,7 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receivers = MutableList(receiverActor) ++ receivers
--- End diff --

I agree this is more readable but existing code was using ++ so I 
maintained it .
let me update it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

Github user agsachin commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52157133
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -18,16 +18,14 @@
 // scalastyle:off println
 package org.apache.spark.examples.streaming
 
-import scala.collection.mutable.LinkedList
-import scala.reflect.ClassTag
-import scala.util.Random
-
 import akka.actor._
 import com.typesafe.config.ConfigFactory
-
 import org.apache.spark.SparkConf
-import org.apache.spark.streaming.{Seconds, StreamingContext}
 import org.apache.spark.streaming.akka.{ActorReceiver, AkkaUtils}
+import org.apache.spark.streaming.{Seconds, StreamingContext}
+
+import scala.collection.mutable._
--- End diff --

Is there any configuration file which I can import so that intellij uses 
recommended settings as default ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

Github user agsachin commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181376718
  
@srowen , I agree with you on Linked List front, just thinking to keep 
example simple


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52230832
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

> Is there any mutation method that does this?

There are -= and --= which take an element, respectively an seq of elements 
to remove. Alternatively there is remove(n: Int) which takes an index to remove.

Considering the options, I would highly recommend going with a Set


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52230982
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

dropWhile can then be replaced by a simple `set -= receiverActor`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181532871
  
**[Test build #50934 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50934/consoleFull)**
 for PR 3 at commit 
[`06273fc`](https://github.com/apache/spark/commit/06273fcc1d1a22f723eeedc90706102706069647).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52214076
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
--- End diff --

Nitpick: receivers.prepend is maybe more comprehensible than +=:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52219962
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

Ah, darn you are right there. Is there any mutation method that does this?

Yes you're right that `ListBuffer` or a mutable `Set` could be a better 
choice.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[zsxwing]

Github user zsxwing commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52228038
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

+1 for `Set`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[zsxwing]

Github user zsxwing commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181530951
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52214655
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -39,7 +39,7 @@ case class UnsubscribeReceiver(receiverActor: ActorRef)
 class FeederActor extends Actor {
 
   val rand = new Random()
-  var receivers: LinkedList[ActorRef] = new LinkedList[ActorRef]()
+  val receivers = new ArrayBuffer[ActorRef]()
--- End diff --

Would a mutable Set be a better fit here? It seems that `receivers` is used 
to hold distinct ActorRefs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52214846
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

Unfortunately, this does actually not remove the elements from the original 
receivers (instead it creates a new ArrayBuffer without the given elements).

Please look at my previous comment, maybe a Set is better suited here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52213895
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -18,7 +18,7 @@
 // scalastyle:off println
 package org.apache.spark.examples.streaming
 
-import scala.collection.mutable.LinkedList
+import scala.collection.mutable.ArrayBuffer
--- End diff --

Would a ListBuffer be a better fit here? This is only an example but is a 
O(1) prepend data structure better suited here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181538066
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181537893
  
**[Test build #50934 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50934/consoleFull)**
 for PR 3 at commit 
[`06273fc`](https://github.com/apache/spark/commit/06273fcc1d1a22f723eeedc90706102706069647).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181538068
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50934/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181606745
  
**[Test build #50944 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50944/consoleFull)**
 for PR 3 at commit 
[`f38d7b6`](https://github.com/apache/spark/commit/f38d7b6ec06b8001dd84e0c350a74e56f25e2e5a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[agsachin]

Github user agsachin commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52236639
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

which one you will suggest to use HashSet or LinkedHashSet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on a diff in the pull request:

https://github.com/apache/spark/pull/3#discussion_r52237857
  
--- Diff: 
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
 ---
@@ -63,11 +63,11 @@ class FeederActor extends Actor {
   def receive: Receive = {
 case SubscribeReceiver(receiverActor: ActorRef) =>
   println("received subscribe from %s".format(receiverActor.toString))
-  receivers = LinkedList(receiverActor) ++ receivers
+  receiverActor +=: receivers
 
 case UnsubscribeReceiver(receiverActor: ActorRef) =>
   println("received unsubscribe from 
%s".format(receiverActor.toString))
-  receivers = receivers.dropWhile(x => x eq receiverActor)
+  receivers.dropWhile(x => x eq receiverActor)
--- End diff --

The difference between the two:

> The iterator and all traversal methods of this class visit elements in 
the order they were inserted. 

So it really depends if ordering is important or not


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181612264
  
**[Test build #50944 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50944/consoleFull)**
 for PR 3 at commit 
[`f38d7b6`](https://github.com/apache/spark/commit/f38d7b6ec06b8001dd84e0c350a74e56f25e2e5a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[jodersky]

Github user jodersky commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181612945
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181612414
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13177][Examples]Update ActorWordCount e...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3#issuecomment-181612419
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50944/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org