Some advice regarding mod_jk
Hi, I am developing an using mod_jk, apache 1.3.26 and Tomcat 4.1.7, Redhat 7.2 and have come across an issue with regards to mod_jk. Now I assumed that the Ajp13Processors under mod_jk acted as pool to process incoming requests. But I hadn't realised that a processor is created per socket and then it processes requests on that socket until it is shut down. This means that even on a lightly loaded machine I can quite easily have 7-8 processors (hence threads, hence processes) depending on which apache child processes my request. I would like to modify the code for the Ajp13Connector as follows, and I wonder what the developers think the consequence would be for reasonble sized sight (say ~10,000 hits a day). 1. Add a maxIdleProcessors, so that short periods of peak activity don't leave loads of processors hanging around. I would probably set this value quite low (probably 2-3). 2. I would modify Ajp13Processor so that it processes a single request and then recycles itself, rather than waiting for more requests on the same socket. I have made these changes and tested them and the behaviour doesn't appear to be too bad. Peak activity does slow a little bit, but overall usage of resources (i.e. threads) is much lower. Any comments? Regards, Arshad -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10860] New: - apxs:Error: Command failed with rc=65536
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10860. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10860 apxs:Error: Command failed with rc=65536 Summary: apxs:Error: Command failed with rc=65536 Product: Tomcat 4 Version: 4.0 Beta 4 Platform: PC OS/Version: Solaris Status: NEW Severity: Normal Priority: Other Component: Connector:JK/AJP (deprecated) AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Compling mod_jk for Apache 2.0., Solaris 2.7. /usr/local/apache2/bin/apxs -o mod_jk.so -DSOLARIS -I../common - I/usr/j2se/include -I/usr/j2se/include/solaris -c *.c ../common/*.c /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c -o mod_jk.lo mod_jk.c touch mod_jk.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_ajp12_worker.lo ../common/jk_ajp12_worker.c touch ../common/jk_ajp12_worker.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_ajp13.lo ../common/jk_ajp13.c touch ../common/jk_ajp13.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_ajp13_worker.lo ../common/jk_ajp13_worker.c touch ../common/jk_ajp13_worker.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_ajp14.lo ../common/jk_ajp14.c touch ../common/jk_ajp14.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_ajp14_worker.lo ../common/jk_ajp14_worker.c touch ../common/jk_ajp14_worker.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_ajp_common.lo ../common/jk_ajp_common.c touch ../common/jk_ajp_common.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_connect.lo ../common/jk_connect.c touch ../common/jk_connect.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_context.lo ../common/jk_context.c touch ../common/jk_context.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o ../common/jk_jni_worker.lo ../common/jk_jni_worker.c touch ../common/jk_jni_worker.slo /usr/local/apache2/build/libtool --silent --mode=compile gcc -prefer-pic - DAP_HAVE_DESIGNATED_INITIALIZER -DSOLARIS2=7 -D_POSIX_PTHREAD_SEMANTICS - D_REENTRANT -g -O2 -DNO_DBM_REWRITEMAP -I/usr/local/apache2/include - I../common -I/usr/j2se/include -I/usr/j2se/include/solaris -DSOLARIS -c - o
DO NOT REPLY [Bug 10860] - apxs:Error: Command failed with rc=65536
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10860. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10860 apxs:Error: Command failed with rc=65536 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-16 11:12 --- You don't have APR in the configure path, upgrade to a more recent jtc, ie the one from 4.1.7 -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Some advice regarding mod_jk
Arshad Mahmood wrote: Hi, I am developing an using mod_jk, apache 1.3.26 and Tomcat 4.1.7, Redhat 7.2 and have come across an issue with regards to mod_jk. Now I assumed that the Ajp13Processors under mod_jk acted as pool to process incoming requests. But I hadn't realised that a processor is created per socket and then it processes requests on that socket until it is shut down. This means that even on a lightly loaded machine I can quite easily have 7-8 processors (hence threads, hence processes) depending on which apache child processes my request. I would also like to see the thread behaviour for the Ajp13Processor improved. I would like to modify the code for the Ajp13Connector as follows, and I wonder what the developers think the consequence would be for reasonble sized sight (say ~10,000 hits a day). 1. Add a maxIdleProcessors, so that short periods of peak activity don't leave loads of processors hanging around. I would probably set this value quite low (probably 2-3). I don't mind idle threads hanging around if they get reused. 2. I would modify Ajp13Processor so that it processes a single request and then recycles itself, rather than waiting for more requests on the same socket. This doesn't work well when apache handles static .shtml pages which have more than one SSI of a JSP or servlet which gets handled by Tomcat. I would rather see an idle timeout. I have made these changes and tested them and the behaviour doesn't appear to be too bad. Peak activity does slow a little bit, but overall usage of resources (i.e. threads) is much lower. Any comments? Regards, Arshad -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10850] - HttpUtils.getRequestURL omits port number
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10850. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10850 HttpUtils.getRequestURL omits port number [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2002-07-16 14:15 --- Hummm. I tried your test case with 4.1.7 and it works for me. (Linux RedHat 7.3 and jdk 1.4) I have bug 6659 open against HttpUtils. Note that HttpUtils is a part of the servlet API spec and not strictly a tomcat project. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10850] - HttpUtils.getRequestURL omits port number
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10850. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10850 HttpUtils.getRequestURL omits port number --- Additional Comments From [EMAIL PROTECTED] 2002-07-16 14:21 --- The bug was filed against 4.0.4. Maybe it somehow doesn't work with 4.0.4, but with the other versions. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[GUMP] Build Failure - jakarta-tomcat-4.0
This email is autogenerated from the output from:
http://jakarta.apache.org/builds/gump/2002-07-16/jakarta-tomcat-4.0.html
Buildfile: build.xml
deploy-prepare:
deploy-static:
deploy:
[echo] Target: Catalina - Deploy ...
flags:
flags.display:
[echo] --- Build environment for Catalina ---
[echo] If ${property_name} is displayed, then the property is not set)
[echo] --- Build options ---
[echo] full.dist=${full.dist}
[echo] build.sysclasspath=only
[echo] compile.debug=${compile.debug}
[echo] compile.deprecation=${compile.deprecation}
[echo] compile.optimize=${compile.optimize}
[echo] --- Ant Flags ---
[echo] style task available (required)=true
[echo] --- JDK ---
[echo] jdk.1.2.present=true
[echo] jdk.1.3.present=true
[echo] jdk.1.4.present=${jdk.1.4.present}
[echo] --- Source Dependencies ---
[echo] jtc.home.present=true
[echo] --- Required Libraries ---
[echo] beanutils.present=true
[echo] collections.present=true
[echo] digester.present=true
[echo] jaxp.present=true
[echo] jndi.present=true
[echo] logging.present=true
[echo] regexp.present=true
[echo] servlet.present=true
[echo] --- Optional Libraries ---
[echo] daemon.present=${daemon.present}
[echo] dbcp.present=true
[echo] jaas.present=true
[echo] javamail.present=true
[echo] jmx.present=true
[echo] jsse.present=true
[echo] jta.present=true
[echo] junit.present=true
[echo] ldap.present=true
[echo] modeler.present=true
[echo] pool.present=true
[echo] tyrex.present=${tyrex.present}
[echo] --- Required JARs ---
[echo] jndi.jar.present(except JDK 1.3+)=true
[echo] regexp.jar.present=true
[echo] servlet.jar.present=true
[echo] xerces.jar.present(except JDK 1.4+ or xerces2)=true
[echo] xerces2.jars.present(except JDK 1.4+ or xerces1)=${xerces2.jars.present}
[echo] --- Optional JARs ---
[echo] daemon.jar.present=${daemon.jar.present}
[echo] dbcp.jar.present=true
[echo] jaas.jar.present=true
[echo] javamail.jar.present=true
[echo] jdbc20ext.jar.present=true
[echo] jmx.jar.present=true
[echo] jta.jar.present=true
[echo] junit.jar.present=${junit.jar.present}
[echo] ldap.jar.present=true
[echo] modeler.jar.present=true
[echo] pool.jar.present=true
[echo] tyrex.jar.present=${tyrex.jar.present}
[echo] --- Conditional compilation flags ---
[echo] compile.daemon=${compile.daemon}
[echo] compile.dbcp=true
[echo] compile.jaas=true
[echo] compile.javamail=true
[echo] compile.jmx=true
[echo] compile.jndi=true
[echo] compile.jsse=true
[echo] compile.jta=true
[echo] compile.junit=true
[echo] compile.ldap=true
[echo] compile.ssi=true
[echo] compile.tyrex=${compile.tyrex}
[echo] --- Distribution flags ---
[echo] copy.daemon.jar=${copy.daemon.jar}
[echo] copy.dbcp.jar=true
[echo] copy.jaas.jar=true
[echo] copy.jdbc20ext.jar=true
[echo] copy.javamail.jar=true
[echo] copy.jmx.jar=true
[echo] copy.jndi.jar=${copy.jndi.jar}
[echo] copy.jta.jar=true
[echo] copy.ldap.jar=${copy.ldap.jar}
[echo] copy.logging.jar=true
[echo] copy.modeler.jar=true
[echo] copy.pool.jar=true
[echo] copy.tyrex.jar=${copy.tyrex.jar}
[echo] copy.xerces.jar=true
[echo] copy.xerces2.jars=${copy.xerces2.jars}
build-prepare:
copy-activation.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-daemon.jar:
copy-dbcp.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jaas.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-jdbc20ext.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jmx.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-jndi.jar:
copy-jsse.jar:
copy-jta.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-ldap.jar:
copy-modeler.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-pool.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-tyrex.jar:
copy-xerces.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/endorsed
copy-xerces2.jars:
build-static:
build-tomcat-util:
detect:
RE: [GUMP] Build Failure - jakarta-tomcat-4.0
Anyone knows what happen?
I can remember that Sam said that this problem relates to use in the
build classpath some intermediate product of our build, revised logs,
and nobody has changed anything in gump.xml or in build.xml lately..,
Saludos ,
Ignacio J. Ortega
-Mensaje original-
De: Craig McClanahan [mailto:[EMAIL PROTECTED]]
Enviado el: 16 de julio de 2002 16:38
Para: [EMAIL PROTECTED]
Asunto: [GUMP] Build Failure - jakarta-tomcat-4.0
This email is autogenerated from the output from:
http://jakarta.apache.org/builds/gump/2002-07-16/jakarta-tomc
at-4.0.html
Buildfile: build.xml
deploy-prepare:
deploy-static:
deploy:
[echo] Target: Catalina - Deploy ...
flags:
flags.display:
[echo] --- Build environment for Catalina ---
[echo] If ${property_name} is displayed, then the
property is not set)
[echo] --- Build options ---
[echo] full.dist=${full.dist}
[echo] build.sysclasspath=only
[echo] compile.debug=${compile.debug}
[echo] compile.deprecation=${compile.deprecation}
[echo] compile.optimize=${compile.optimize}
[echo] --- Ant Flags ---
[echo] style task available (required)=true
[echo] --- JDK ---
[echo] jdk.1.2.present=true
[echo] jdk.1.3.present=true
[echo] jdk.1.4.present=${jdk.1.4.present}
[echo] --- Source Dependencies ---
[echo] jtc.home.present=true
[echo] --- Required Libraries ---
[echo] beanutils.present=true
[echo] collections.present=true
[echo] digester.present=true
[echo] jaxp.present=true
[echo] jndi.present=true
[echo] logging.present=true
[echo] regexp.present=true
[echo] servlet.present=true
[echo] --- Optional Libraries ---
[echo] daemon.present=${daemon.present}
[echo] dbcp.present=true
[echo] jaas.present=true
[echo] javamail.present=true
[echo] jmx.present=true
[echo] jsse.present=true
[echo] jta.present=true
[echo] junit.present=true
[echo] ldap.present=true
[echo] modeler.present=true
[echo] pool.present=true
[echo] tyrex.present=${tyrex.present}
[echo] --- Required JARs ---
[echo] jndi.jar.present(except JDK 1.3+)=true
[echo] regexp.jar.present=true
[echo] servlet.jar.present=true
[echo] xerces.jar.present(except JDK 1.4+ or xerces2)=true
[echo] xerces2.jars.present(except JDK 1.4+ or
xerces1)=${xerces2.jars.present}
[echo] --- Optional JARs ---
[echo] daemon.jar.present=${daemon.jar.present}
[echo] dbcp.jar.present=true
[echo] jaas.jar.present=true
[echo] javamail.jar.present=true
[echo] jdbc20ext.jar.present=true
[echo] jmx.jar.present=true
[echo] jta.jar.present=true
[echo] junit.jar.present=${junit.jar.present}
[echo] ldap.jar.present=true
[echo] modeler.jar.present=true
[echo] pool.jar.present=true
[echo] tyrex.jar.present=${tyrex.jar.present}
[echo] --- Conditional compilation flags ---
[echo] compile.daemon=${compile.daemon}
[echo] compile.dbcp=true
[echo] compile.jaas=true
[echo] compile.javamail=true
[echo] compile.jmx=true
[echo] compile.jndi=true
[echo] compile.jsse=true
[echo] compile.jta=true
[echo] compile.junit=true
[echo] compile.ldap=true
[echo] compile.ssi=true
[echo] compile.tyrex=${compile.tyrex}
[echo] --- Distribution flags ---
[echo] copy.daemon.jar=${copy.daemon.jar}
[echo] copy.dbcp.jar=true
[echo] copy.jaas.jar=true
[echo] copy.jdbc20ext.jar=true
[echo] copy.javamail.jar=true
[echo] copy.jmx.jar=true
[echo] copy.jndi.jar=${copy.jndi.jar}
[echo] copy.jta.jar=true
[echo] copy.ldap.jar=${copy.ldap.jar}
[echo] copy.logging.jar=true
[echo] copy.modeler.jar=true
[echo] copy.pool.jar=true
[echo] copy.tyrex.jar=${copy.tyrex.jar}
[echo] copy.xerces.jar=true
[echo] copy.xerces2.jars=${copy.xerces2.jars}
build-prepare:
copy-activation.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-daemon.jar:
copy-dbcp.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jaas.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-jdbc20ext.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jmx.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
[copy] Copying 1 file to
DO NOT REPLY [Bug 10871] New: - Spaces in install directory causes errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10871. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10871 Spaces in install directory causes errors Summary: Spaces in install directory causes errors Product: Tomcat 4 Version: 4.0.4 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I installed Tomcat 4.0.4 on a Windows 2000 machine and I checked the NT service option during the install. When I start Tomcat as a service I get this error, however when I start Tomcat from startup.bat, it works just fine. Here is the error message. Please notice that the nested exception is 'no protocol: Files/Apache'. In reality, I think Tomcat is looking for C:\Program Files\Apache Tomcat 4.0\common\classes, but cannot find it due to the spaces... java.rmi.ServerException: RemoteException occurred in server thread; nested exception is: java.rmi.UnmarshalException: error unmarshalling arguments; nested exception is: java.net.MalformedURLException: no protocol: Files/Apache at sun.rmi.server.UnicastServerRef.dispatch(Unknown Source) at sun.rmi.transport.Transport$1.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at sun.rmi.transport.Transport.serviceCall(Unknown Source) at sun.rmi.transport.tcp.TCPTransport.handleMessages(Unknown Source) at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(Unknown Source) at java.lang.Thread.run(Unknown Source) at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer (StreamRemoteCall.java:247) at sun.rmi.transport.StreamRemoteCall.executeCall (StreamRemoteCall.java:223) at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:133) at com.sterlingcommerce.swm.swme.sm.SessionFactoryImpl_Stub.updateProperties (Unknown Source) at com.sterlingcommerce.swm.swme.lm.pageBean.setSIProperty (pageBean.java:125) at org.apache.jsp.SIProperties$jsp._jspService (SIProperties$jsp.java:131) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:107) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.jasper.servlet.JspServlet$JspServletWrapper.service (JspServlet.java:202) at org.apache.jasper.servlet.JspServlet.serviceJspFile (JspServlet.java:382) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:474) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java:243) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:566) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:472) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java:190) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:566) at org.apache.catalina.valves.CertificatesValve.invoke (CertificatesValve.java:246) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:564) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:472) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:943) at org.apache.catalina.core.StandardContext.invoke (StandardContext.java:2343) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java:180) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:566) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java:170) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:564) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java:170) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:564) at org.apache.catalina.valves.AccessLogValve.invoke (AccessLogValve.java:468) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java:564) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java:472) at
cvs commit: jakarta-tomcat-connectors gump.xml
nacho 2002/07/16 08:37:12 Modified:.gump.xml Log: Added nags for all project we have, and a dependency on xerces.. Thanks to Stefan Bodewig Revision ChangesPath 1.6 +5 -0 jakarta-tomcat-connectors/gump.xml Index: gump.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/gump.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- gump.xml 8 Jun 2002 00:15:13 - 1.5 +++ gump.xml 16 Jul 2002 15:37:11 - 1.6 @@ -25,6 +25,8 @@ home nested=util/build/ jar name=lib/tomcat-util.jar/ +nag to=[EMAIL PROTECTED] + from=Craig McClanahan lt;[EMAIL PROTECTED]gt;/ /project project name=jakarta-tomcat-coyote @@ -58,6 +60,7 @@ depend project=jakarta-ant/ depend project=commons-logging/ depend project=jakarta-tomcat-util/ +depend project=xml-xerces/ depend project=jakarta-tomcat-coyote/ home nested=jk/build/ @@ -65,6 +68,8 @@ jar name=lib/jkconfig.jar/ jar name=lib/tomcat-jk2.jar/ jar name=lib/tomcat-jni.jar/ +nag to=[EMAIL PROTECTED] + from=Craig McClanahan lt;[EMAIL PROTECTED]gt;/ /project -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-servletapi-5 - Imported sources
kinman 2002/07/16 09:38:43 Log: - Initial files supporting JSP 2.0 Status: Vendor Tag: js5 Release Tags: r1 N jakarta-servletapi-5/BUILDING.txt N jakarta-servletapi-5/.cvsignore U jakarta-servletapi-5/LICENSE N jakarta-servletapi-5/README.txt N jakarta-servletapi-5/build.xml N jakarta-servletapi-5/src/share/dtd/web-app_2_2.dtd N jakarta-servletapi-5/src/share/dtd/jspxml.dtd N jakarta-servletapi-5/src/share/dtd/jspxml.xsd N jakarta-servletapi-5/src/share/dtd/web-app_2_3.dtd.backup N jakarta-servletapi-5/src/share/dtd/web-app_2_3.dtd N jakarta-servletapi-5/src/share/dtd/web-jsptaglibrary_2_0.dtd N jakarta-servletapi-5/src/share/dtd/web-jsptaglibrary_1_1.dtd N jakarta-servletapi-5/src/share/dtd/web-jsptaglibrary_1_2.dtd N jakarta-servletapi-5/src/share/javax/servlet/FilterChain.java N jakarta-servletapi-5/src/share/javax/servlet/Filter.java N jakarta-servletapi-5/src/share/javax/servlet/GenericServlet.java N jakarta-servletapi-5/src/share/javax/servlet/FilterConfig.java N jakarta-servletapi-5/src/share/javax/servlet/LocalStrings.properties N jakarta-servletapi-5/src/share/javax/servlet/LocalStrings_ja.properties N jakarta-servletapi-5/src/share/javax/servlet/RequestDispatcher.java N jakarta-servletapi-5/src/share/javax/servlet/Servlet.java N jakarta-servletapi-5/src/share/javax/servlet/ServletConfig.java N jakarta-servletapi-5/src/share/javax/servlet/ServletContext.java N jakarta-servletapi-5/src/share/javax/servlet/ServletContextEvent.java N jakarta-servletapi-5/src/share/javax/servlet/ServletContextAttributeEvent.java N jakarta-servletapi-5/src/share/javax/servlet/ServletContextAttributeListener.java N jakarta-servletapi-5/src/share/javax/servlet/ServletContextListener.java N jakarta-servletapi-5/src/share/javax/servlet/ServletRequest.java N jakarta-servletapi-5/src/share/javax/servlet/ServletException.java N jakarta-servletapi-5/src/share/javax/servlet/ServletInputStream.java N jakarta-servletapi-5/src/share/javax/servlet/ServletOutputStream.java N jakarta-servletapi-5/src/share/javax/servlet/ServletRequestWrapper.java N jakarta-servletapi-5/src/share/javax/servlet/ServletResponse.java N jakarta-servletapi-5/src/share/javax/servlet/ServletResponseWrapper.java N jakarta-servletapi-5/src/share/javax/servlet/SingleThreadModel.java N jakarta-servletapi-5/src/share/javax/servlet/UnavailableException.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpServlet.java N jakarta-servletapi-5/src/share/javax/servlet/http/Cookie.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpServletRequestWrapper.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpServletRequest.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpServletResponseWrapper.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpServletResponse.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionContext.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSession.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionActivationListener.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionAttributeListener.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionBindingEvent.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionBindingListener.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionEvent.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpSessionListener.java N jakarta-servletapi-5/src/share/javax/servlet/http/HttpUtils.java N jakarta-servletapi-5/src/share/javax/servlet/http/LocalStrings.properties N jakarta-servletapi-5/src/share/javax/servlet/http/LocalStrings_es.properties N jakarta-servletapi-5/src/share/javax/servlet/http/LocalStrings_ja.properties N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspTagException.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/HttpJspPage.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspContext.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspEngineInfo.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspException.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspFactory.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspPage.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/PageContext.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/JspWriter.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/el/VariableResolver.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/el/ELException.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/el/ExpressionEvaluator.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/tagext/BodyTag.java N jakarta-servletapi-5/src/share/javax/servlet/jsp/tagext/.nbattrs N jakarta-servletapi-5/src/share/javax/servlet/jsp/tagext/TagAdapter.java N
Re: [GUMP] Build Failure - jakarta-tomcat-4.0
On Tue, 16 Jul 2002, Ignacio J. Ortega [EMAIL PROTECTED] wrote: I can remember that Sam said that this problem relates to use in the build classpath some intermediate product of our build, java.lang.InternalError: jzentry == 0 usually happens inside of Ant when you modify a jar that is on the CLASSPATH. on my box, Gump will run the build with big snip / export CLASSPATH=$CLASSPATH:/home/bodewig/dev/gump/jakarta-tomcat-connectors/coyote/build/lib/tomcat-coyote.jar export CLASSPATH=$CLASSPATH:/home/bodewig/dev/gump/jakarta-tomcat-4.0/build/server/lib/catalina.jar export CLASSPATH=$CLASSPATH:/home/bodewig/dev/gump/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar export CLASSPATH=$CLASSPATH:/home/bodewig/dev/gump/jakarta-servletapi-4/lib/servlet.jar export CLASSPATH=$CLASSPATH:/home/bodewig/dev/gump/jakarta-tomcat-4.0/catalina/build/server/classes big snip / and in the build log we see (Sam's box) [jar] Building jar: /home/rubys/jakarta/jakarta-tomcat-4.0/build/server/lib/catalina.jar so catalina.jar gets updated, this seems to be the thing that needs to be fixed (either don't build catalina.jar in tomcat-4.0 again or don't depend on tomcat-catalina). revised logs, and nobody has changed anything in gump.xml or in build.xml lately.., But then again it has been weeks since the last successful compile of Tomcat (mx4j is back for a few days only and since then Tomcat has been failing). Stefan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Order of work vs depend
Stefan, suggestions? it seem that the JDK doesn't take kindly to jars being modified while in use. Putting work dirs first provided a workaround. http://jakarta.apache.org/builds/gump/latest/jakarta-tomcat-4.0.html http://jakarta.apache.org/builds/gump/latest/xml-axis-security.html -- Forwarded by Sam Ruby/Raleigh/IBM on 07/16/2002 10:53 AM --- Please respond to Tomcat Developers List [EMAIL PROTECTED] To:'Tomcat Developers List' [EMAIL PROTECTED] cc:Sam Ruby/Raleigh/IBM@IBMUS Subject:RE: [GUMP] Build Failure - jakarta-tomcat-4.0 Anyone knows what happen? I can remember that Sam said that this problem relates to use in the build classpath some intermediate product of our build, revised logs, and nobody has changed anything in gump.xml or in build.xml lately.., Saludos , Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Order of work vs depend
On Tue, 16 Jul 2002, Sam Ruby [EMAIL PROTECTED] wrote: it seem that the JDK doesn't take kindly to jars being modified while in use. Too true. But is it really necessary to change catalina.jar? If so, does it have to be on the CLASSPATH in the first place? Putting work dirs first provided a workaround. I don't know enough about either Tomcat's or Axis' build process to see whether it is a problem in Gump or just hints at a problem of the build process as such. Change the order back, if you think Gump is wrong (I'm not convinced, though). Stefan BTW, could somebody please add a dependency on Xerces to the Gump descriptor of jakarta-tomcat-jk and maybe even add a nag so that http://jakarta.apache.org/builds/gump/2002-07-16/jakarta-tomcat-jk.html would become visible? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Order of work vs depend
De: Stefan Bodewig [mailto:[EMAIL PROTECTED]] Enviado el: 16 de julio de 2002 17:17 BTW, could somebody please add a dependency on Xerces to the Gump descriptor of jakarta-tomcat-jk and maybe even add a nag so that http://jakarta.apache.org/builds/gump/2002-07-16/jakarta-tomc at-jk.html would become visible? Done, Thanks, Saludos , Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9434] - Response Filters do not work with jsp:forward
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9434. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9434 Response Filters do not work with jsp:forward [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2002-07-16 17:11 --- Dmitri Valdin [EMAIL PROTECTED] suggests that this is fixed with the last check in (6/18). Can you verify it's been fixed with the latest milestone 4.1.7 Beta? Thanks, Amy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters CompressionFilter.java CompressionResponseStream.java
amyroh 2002/07/16 10:15:18
Modified:webapps/examples/WEB-INF/classes/compressionFilters
CompressionFilter.java
CompressionResponseStream.java
Log:
Add include action to be extended with parameter gzip:
jsp:include page=/pageToInclude.jsp flush=true
jsp:param name=gzip value=false/
/jsp:include
The result was previously compressed twice in the calling page when you
include.
Patch submitted by Dimitri Valdin [EMAIL PROTECTED].
Thanks, Dimitri. :-)
Revision ChangesPath
1.7 +16 -5
jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Index: CompressionFilter.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- CompressionFilter.java18 Jun 2002 19:53:25 - 1.6
+++ CompressionFilter.java16 Jul 2002 17:15:18 - 1.7
@@ -129,7 +129,7 @@
if (str!=null) {
compressionThreshold = Integer.parseInt(str);
if (compressionThreshold != 0 compressionThreshold
minThreshold) {
-if (debug 0) {
+ if (debug 0) {
System.out.println(compressionThreshold should be either 0
- no compression or = + minThreshold);
System.out.println(compressionThreshold set to +
minThreshold);
}
@@ -191,6 +191,17 @@
if (debug 1) {
System.out.println(requestURI = +
((HttpServletRequest)request).getRequestURI());
}
+
+// Are we allowed to compress ?
+String s = (String) ((HttpServletRequest)request).getParameter(gzip);
+if (false.equals(s)) {
+if (debug 0) {
+System.out.println(got parameter gzip=false -- don't
compress, just chain filter);
+}
+chain.doFilter(request, response);
+return;
+}
+
Enumeration e =
((HttpServletRequest)request).getHeaders(Accept-Encoding);
while (e.hasMoreElements()) {
1.6 +21 -5
jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java
Index: CompressionResponseStream.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- CompressionResponseStream.java18 Jun 2002 19:53:25 - 1.5
+++ CompressionResponseStream.java16 Jul 2002 17:15:18 - 1.6
@@ -189,8 +189,14 @@
if (gzipstream != null) {
flushToGZip();
gzipstream.close();
+gzipstream = null;
} else {
if (bufferCount 0) {
+if (debug 2) {
+System.out.print(output.write();
+System.out.write(buffer, 0, bufferCount);
+System.out.println());
+}
output.write(buffer, 0, bufferCount);
bufferCount = 0;
}
@@ -291,7 +297,9 @@
System.out.println(write, bufferCount = + bufferCount + len = +
len + off = + off);
}
if (debug 2) {
+System.out.print(write();
System.out.write(b, off, len);
+System.out.println());
}
if (closed)
@@ -324,9 +332,17 @@
public void writeToGZip(byte b[], int off, int len) throws IOException {
if (debug 1) {
-System.out.println(* writeToGZip, len = + len);
+System.out.println(writeToGZip, len = + len);
+}
+if (debug 2) {
+System.out.print(writeToGZip();
+System.out.write(b, off, len);
+System.out.println());
}
if (gzipstream == null) {
+if (debug 1) {
+System.out.println(new GZIPOutputStream);
+}
gzipstream = new GZIPOutputStream(output);
response.addHeader(Content-Encoding, gzip);
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters CompressionFilter.java
amyroh 2002/07/16 10:19:13
Modified:webapps/examples/WEB-INF/classes/compressionFilters
CompressionFilter.java
Log:
Fix indentation.
Revision ChangesPath
1.8 +5 -5
jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java
Index: CompressionFilter.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- CompressionFilter.java16 Jul 2002 17:15:18 - 1.7
+++ CompressionFilter.java16 Jul 2002 17:19:13 - 1.8
@@ -129,7 +129,7 @@
if (str!=null) {
compressionThreshold = Integer.parseInt(str);
if (compressionThreshold != 0 compressionThreshold
minThreshold) {
- if (debug 0) {
+if (debug 0) {
System.out.println(compressionThreshold should be either 0
- no compression or = + minThreshold);
System.out.println(compressionThreshold set to +
minThreshold);
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9434] - Response Filters do not work with jsp:forward
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9434. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9434 Response Filters do not work with jsp:forward [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-07-16 17:21 --- Change it back to previous status. Didn't mean to change the status. Just wanted confirmation from the reporter. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_iis_thread_pool.c
mturk 2002/07/16 10:27:21
Modified:jk/native2/server/isapi jk_iis_thread_pool.c
Log:
Make all thread function as void and use
ExitThread insted of return 0.
Revision ChangesPath
1.3 +9 -7
jakarta-tomcat-connectors/jk/native2/server/isapi/jk_iis_thread_pool.c
Index: jk_iis_thread_pool.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_iis_thread_pool.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- jk_iis_thread_pool.c 14 Jul 2002 13:41:36 - 1.2
+++ jk_iis_thread_pool.c 16 Jul 2002 17:27:21 - 1.3
@@ -112,7 +112,7 @@
/* Timeout for threads shutdown 2 minutes */
#define SHUTDOWN_TIMEOUT 12
-DWORD WINAPI thread_pool_manager(void *p)
+VOID WINAPI thread_pool_manager(void *p)
{
ULONG n1, n2;
OVERLAPPED *pOverLapped;
@@ -137,10 +137,11 @@
work = TRUE;
}
}
-return 0;
+/* Clean up and die. */
+ExitThread(0);
}
-DWORD WINAPI thread_worker(void *p)
+VOID WINAPI thread_worker(void *p)
{
ULONG n1, n2;
OVERLAPPED *pOverLapped;
@@ -174,7 +175,8 @@
InterlockedDecrement(thread-busy);
}
}
-return 0;
+/* Clean up and die. */
+ExitThread(0);
}
int jk2_iis_init_pool(jk_env_t *env)
@@ -211,7 +213,7 @@
/* Create the ThreadPool manager thread */
global_thread_pool.manager_thread = CreateThread(NULL,
0,
-thread_pool_manager,
+(LPTHREAD_START_ROUTINE)thread_pool_manager,
NULL,
0,
global_thread_pool.manager_id);
@@ -231,7 +233,7 @@
DWORD id;
global_thread_pool.handles[i] = CreateThread(NULL,
0,
-thread_worker,
+(LPTHREAD_START_ROUTINE)thread_worker,
global_thread_pool.threads[i],
0,
id);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_isapi_plugin.c
mturk 2002/07/16 10:29:20
Modified:jk/native2/server/isapi jk_isapi_plugin.c
Log:
Make all thread function as void and use ExitThread insted of return 0.
Change the call to the write_error_response to use the defines from
jk_iis.h to skip multiple writting of the same thing.
Revision ChangesPath
1.40 +10 -18
jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c
Index: jk_isapi_plugin.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_isapi_plugin.c,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- jk_isapi_plugin.c 14 Jul 2002 13:39:13 - 1.39
+++ jk_isapi_plugin.c 16 Jul 2002 17:29:20 - 1.40
@@ -130,14 +130,9 @@
static void write_error_response(PHTTP_FILTER_CONTEXT pfc,char *status,char * msg)
{
char crlf[3] = { (char)13, (char)10, '\0' };
-char ctype[30];
+char *ctype = Content-Type:text/html\r\n\r\n;
DWORD len = strlen(msg);
-sprintf(ctype,
-Content-Type:text/html%s%s,
-crlf,
-crlf);
-
/* reject !!! */
pfc-ServerSupportFunction(pfc,
SF_REQ_SEND_RESPONSE_HEADER,
@@ -151,7 +146,7 @@
HANDLE jk2_inited_event;
HANDLE jk2_starter_thread = NULL;
-DWORD WINAPI jk2_isapi_starter( LPVOID lpParam )
+VOID jk2_isapi_starter( LPVOID lpParam )
{
Sleep(1000);
@@ -177,7 +172,8 @@
}
apr_pool_destroy(jk_globalPool);
apr_terminate();
-return 0;
+/* Clean up and die. */
+ExitThread(0);
}
BOOL WINAPI GetFilterVersion(PHTTP_FILTER_VERSION pVer)
@@ -189,7 +185,7 @@
jk2_starter_event = CreateEvent(NULL, FALSE, FALSE, NULL);
jk2_starter_thread = CreateThread(NULL, 0,
- jk2_isapi_starter,
+ (LPTHREAD_START_ROUTINE)jk2_isapi_starter,
NULL,
0,
dwThreadId);
@@ -319,8 +315,7 @@
env-l-jkLog(env, env-l, JK_LOG_ERROR,
HttpFilterProc [%s] contains one or more invalid escape
sequences.\n,
uri);
-write_error_response(pfc,400 Bad Request,
-HTMLBODYH1Request contains invalid
encoding/H1/BODY/HTML);
+write_error_response(pfc,400 Bad Request, HTML_ERROR_400);
workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
return SF_STATUS_REQ_FINISHED;
}
@@ -328,8 +323,7 @@
env-l-jkLog(env, env-l, JK_LOG_EMERG,
HttpFilterProc [%s] contains forbidden escape
sequences.\n,
uri);
-write_error_response(pfc,403 Forbidden,
-HTMLBODYH1Access is
Forbidden/H1/BODY/HTML);
+write_error_response(pfc,403 Forbidden, HTML_ERROR_403);
workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
return SF_STATUS_REQ_FINISHED;
}
@@ -374,8 +368,7 @@
env-l-jkLog(env, env-l, JK_LOG_ERROR,
HttpFilterProc [%s] re-encoding request exceeds
maximum buffer size.\n,
uri);
-write_error_response(pfc,400 Bad Request,
-HTMLBODYH1Request contains too many
characters that need to be encoded./H1/BODY/HTML);
+write_error_response(pfc,400 Bad Request,
HTML_ERROR_400);
workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv,
env );
return SF_STATUS_REQ_FINISHED;
}
@@ -430,8 +423,7 @@
HttpFilterProc [%s] points to the web-inf or meta-inf
directory.\nSomebody try to hack into the site!!!\n,
uri);
-write_error_response(pfc,403 Forbidden,
-HTMLBODYH1Access is
Forbidden/H1/BODY/HTML);
+write_error_response(pfc,403 Forbidden, HTML_ERROR_403);
workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
return SF_STATUS_REQ_FINISHED;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_iis.h
mturk 2002/07/16 10:30:15
Modified:jk/native2/server/isapi jk_iis.h
Log:
Add the Error 400 and 403 as #define html.
Revision ChangesPath
1.11 +15 -3 jakarta-tomcat-connectors/jk/native2/server/isapi/jk_iis.h
Index: jk_iis.h
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/isapi/jk_iis.h,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- jk_iis.h 8 Jul 2002 07:48:47 - 1.10
+++ jk_iis.h 16 Jul 2002 17:30:15 - 1.11
@@ -104,7 +104,19 @@
#define BAD_REQUEST -1
#define BAD_PATH-2
-#define MAX_SERVERNAME 128
+#define MAX_SERVERNAME 128
+
+#define HTML_ERROR_400 !DOCTYPE HTML PUBLIC \-//W3C//DTD HTML 4.0
Transitional//EN\ \
+HTMLHEADTITLEBad request!/TITLE/HEAD \
+BODYH1Bad request!/H1DLDD\n \
+Your browser (or proxy) sent a request that \
+this server could not
understand./DL/DD/BODY/HTML
+
+#define HTML_ERROR_403 !DOCTYPE HTML PUBLIC \-//W3C//DTD HTML 4.0
Transitional//EN\ \
+HTMLHEADTITLEAccess
forbidden!!/TITLE/HEAD \
+BODYH1Access forbidden!/H1DLDD\n \
+You don't have permission to access the requested
object. \
+It is either read-protected or not readable by the
server./DL/DD/BODY/HTML
#define GET_SERVER_VARIABLE_VALUE(pool, name, place) {\
@@ -117,7 +129,7 @@
)) { \
(place) = (pool)-pstrdup(env,(pool),huge_buf); \
} \
-}\
+}
#define GET_SERVER_VARIABLE_VALUE_INT(name, place, def) { \
huge_buf_sz = sizeof(huge_buf); \
@@ -133,7 +145,7 @@
} else {\
(place) = def; \
} \
-}\
+}
static int JK_METHOD jk2_service_iis_head(jk_env_t *env, jk_ws_service_t *s );
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Missed vote
Arg. I missed the vote where the Servlet API and JSP classes were going to be stored in the same repo. Is there any way that I can -1 that after the fact? Several of us have worked hard over the years to completely separate the Servlet API from the JSP API for various valid reasons (including the fact that some of us don't like JSP). This fight came to an end when Sun decided to create separation of the two API's by having separate JSR's. Now, it seems that we are moving backwards again by having the two API's stored in the same repo and now that I found out that that has happened, I would love to try to stop it from going any further. What can we do here? -jon -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Jasper error with struts patch
The jsp code it's self:
logic:present name=prospectForm property=prospectid
jsp:include page=/prospectmenu.jsp flush=true/
/logic:present
The JSP generated code that is bad:
private boolean _jspx_meth_logic_present_0(javax.servlet.jsp.tagext.Tag
_jspx_th_html_form_0,
javax.servlet.jsp.PageContext
pageContext)
throws Throwable {
JspWriter out = pageContext.getOut();
HttpServletRequest request =
(HttpServletRequest)pageContext.getRequest();
ServletResponse response = pageContext.getResponse();
/* logic:present */
{
[SNIP]
JspRuntimeLibrary.include(request,
response,
/prospectmenu.jsp,
out,
true);
The error:
An error occurred at line: 58 in the jsp file: /content/prospectform.jsp
Generated servlet error:
[javac] Compiling 1 source file
/opt2/jakarta-tomcat-4.1.7-LE-jdk14/work/Standalone/localhost/helpdesk/content/p
rospectform$jsp.java:371:
include(javax.servlet.http.HttpServletRequest,javax.se
rvlet.http.HttpServletResponse,java.lang.String,javax.servlet.jsp.JspWriter,bool
ean) in org.apache.jasper.runtime.JspRuntimeLibrary cannot be applied to
(javax.
servlet.http.HttpServletRequest,javax.servlet.ServletResponse,java.lang.String,j
avax.servlet.jsp.JspWriter,boolean)
JspRuntimeLibrary.include(request, response,
/prospectmenu.jsp, out,
true);
^
1 error
The problem is that JspRuntimeLibrary.include signature does not match
the code generated: ServletResponse can not be morphed into a
HttpServletResponse. So here is a patch, BUT I do not know what else it
will break. I figure that someone who knows jasper can figure out
what to do. :-)
PATCH:
diff -wruN /var/tmp/bpm/Generator.java.~1~
src/share/org/apache/jasper/compiler/Generator.java
--- /var/tmp/bpm/Generator.java.~1~ Thu Jun 27 12:32:17 2002
+++ src/share/org/apache/jasper/compiler/Generator.java Tue Jul 16
10:46:17 2002
@@ -1155,7 +1155,7 @@
out.println(HttpServletRequest request =
(HttpServletRequest)pageContext.getRequest(););
}
if (n.isHasIncludeAction()) {
- out.println(ServletResponse response =
pageContext.getResponse(););
+out.println(HttpServletResponse response =
(HttpServletResponse)pageContext.getResponse(););
}
}
--
Brian Millett
Enterprise Consulting Group Shifts in paradigms
(314) 205-9030 often cause nose bleeds.
[EMAIL PROTECTED] Greg Glenn
--- /var/tmp/bpm/Generator.java.~1~ Thu Jun 27 12:32:17 2002
+++ src/share/org/apache/jasper/compiler/Generator.java Tue Jul 16 10:46:17 2002
@@ -1155,7 +1155,7 @@
out.println(HttpServletRequest request =
(HttpServletRequest)pageContext.getRequest(););
}
if (n.isHasIncludeAction()) {
- out.println(ServletResponse response =
pageContext.getResponse(););
+out.println(HttpServletResponse response =
+(HttpServletResponse)pageContext.getResponse(););
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
kinman 2002/07/16 12:36:16
Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
Log:
- turn off debug message for smap.
Revision ChangesPath
1.2 +1 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java
Index: SmapUtil.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- SmapUtil.java 16 Jul 2002 19:30:51 - 1.1
+++ SmapUtil.java 16 Jul 2002 19:36:16 - 1.2
@@ -167,7 +167,7 @@
// Installation logic (from Robert Field, JSR-045 spec lead)
private static class SDEInstaller {
- static final boolean verbose = true;
+ static final boolean verbose = false;
static final String nameSDE = SourceDebugExtension;
byte[] orig;
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2 build.properties.sample
kinman 2002/07/16 12:45:04
Added: jasper2 build.properties.sample
Log:
Revision ChangesPath
1.1 jakarta-tomcat-jasper/jasper2/build.properties.sample
Index: build.properties.sample
===
# -
# build.properties.sample
#
# This is an example build.properties file, used to customize building
# Jasper2 for your local environment. It defines the location of all external
# modules that Jasper2 depends on. Copy this file to build.properties
# in the top-level source directory, and customize it as needed.
#
# $Id: build.properties.sample,v 1.1 2002/07/16 19:45:04 kinman Exp $
# -
# - Pointer to Catalina -
catalina.home=../../jakarta-tomcat-4.0/build
# - Pointer to JSP Standard Tag Library distribution -
standard.home=${base.path}/jakarta-taglibs/standard
jsp20el.jar=${standard.home}/../dist/jsp20el/jsp20el.jar
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: New branches and repositories
Craig, These modules are not accessible to the anoncvs user. Is there anything we need to do to make that work? Thanks, Patrick Craig R. McClanahan wrote: The new repositories (jakarta-servletapi-5, jakarta-tomcat-5, and jakarta-tomcat-catalina) have been set up with just a LICENSE file checked in. Craig On Fri, 12 Jul 2002, Remy Maucherat wrote: Date: Fri, 12 Jul 2002 10:52:22 +0200 From: Remy Maucherat [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: New branches and repositories So it looks like the vote result (nearly everyone who voted +1 to the 5.0 proposal voted, and there's a clear majority for the winning choices) is: A) Use new jakarta-servletapi-5 (a root will need to create it) B) Use new jakarta-tomcat-catalina (a root will need to create it) C) Use HEAD of jakarta-tomcat-connectors (I will create the branch for Coyote 1.0) D) Use new jakarta-tomcat-5 (a root will need to create it) E) Use HEAD of jakarta-tomcat-jasper (I will create the branch for the current Jasper2 code) Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- _ Patrick Luby Email: [EMAIL PROTECTED] Sun Microsystems Phone: 408-276-7471 901 San Antonio Road, USCA14-303 Palo Alto, CA 94303-4900 _ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Missed vote
On Tue, 16 Jul 2002, Jon Scott Stevens wrote: Date: Tue, 16 Jul 2002 11:56:40 -0700 From: Jon Scott Stevens [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: tomcat-dev [EMAIL PROTECTED] Subject: Missed vote Arg. I missed the vote where the Servlet API and JSP classes were going to be stored in the same repo. Is there any way that I can -1 that after the fact? Several of us have worked hard over the years to completely separate the Servlet API from the JSP API for various valid reasons (including the fact that some of us don't like JSP). This fight came to an end when Sun decided to create separation of the two API's by having separate JSR's. Now, it seems that we are moving backwards again by having the two API's stored in the same repo and now that I found out that that has happened, I would love to try to stop it from going any further. What can we do here? What's so painful about a ten-line build.xml target that creates a separate JAR file with just the javax.servlet and javax.servlet.http API classes, if that's what you need? Sharing a CVS repository has little or nothing to do with how many distributable outputs you create. On the other hand, having both servlet and JSP APIs in a single JAR file is quite useful to a very large number of existing Tomcat (and other container) users, so it should be available also. -jon Craig -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: New branches and repositories
On Tue, 16 Jul 2002, Patrick Luby wrote: Date: Tue, 16 Jul 2002 13:11:25 -0700 From: Patrick Luby [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED], [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: Re: New branches and repositories Craig, These modules are not accessible to the anoncvs user. Is there anything we need to do to make that work? Should work now (needed to create symlinks in /home/cvspublic). Thanks, Patrick Craig Craig R. McClanahan wrote: The new repositories (jakarta-servletapi-5, jakarta-tomcat-5, and jakarta-tomcat-catalina) have been set up with just a LICENSE file checked in. Craig On Fri, 12 Jul 2002, Remy Maucherat wrote: Date: Fri, 12 Jul 2002 10:52:22 +0200 From: Remy Maucherat [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: New branches and repositories So it looks like the vote result (nearly everyone who voted +1 to the 5.0 proposal voted, and there's a clear majority for the winning choices) is: A) Use new jakarta-servletapi-5 (a root will need to create it) B) Use new jakarta-tomcat-catalina (a root will need to create it) C) Use HEAD of jakarta-tomcat-connectors (I will create the branch for Coyote 1.0) D) Use new jakarta-tomcat-5 (a root will need to create it) E) Use HEAD of jakarta-tomcat-jasper (I will create the branch for the current Jasper2 code) Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- _ Patrick Luby Email: [EMAIL PROTECTED] Sun Microsystems Phone: 408-276-7471 901 San Antonio Road, USCA14-303 Palo Alto, CA 94303-4900 _ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9434] - Response Filters do not work with jsp:forward
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9434. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9434 Response Filters do not work with jsp:forward [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED --- Additional Comments From [EMAIL PROTECTED] 2002-07-16 20:29 --- Thanks! It was the same bug as #10048, however, submitter of #10048 was able to provide a fix. Tested sucessfully with 4.1.7 beta, 4.1.6 should work, too. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
luehe 2002/07/16 13:40:11
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Log:
Convert expression to String (using String.valueOf(Object)), so they
can be printed using Writer.write(String).
Revision ChangesPath
1.37 +5 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- Generator.java16 Jul 2002 19:30:51 - 1.36
+++ Generator.java16 Jul 2002 20:40:11 - 1.37
@@ -810,7 +810,8 @@
public void visit(Node.Expression n) throws JasperException {
n.setBeginJavaLine(out.getJavaLine());
- out.printil(out.write( + new String(n.getText()) + ););
+ out.printil(out.write(String.valueOf(
+ + new String(n.getText()) + )););
n.setEndJavaLine(out.getJavaLine());
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
FW: Tomcat voted Best Java Application Server
Not acked -- Forwarded Message From: Adams, Lamont [EMAIL PROTECTED] Date: Tue, 16 Jul 2002 15:13:44 -0400 To: '[EMAIL PROTECTED]' [EMAIL PROTECTED] Subject: Tomcat voted Best Java Application Server Hi there, I'm not sure who the best person is to contact about this, so you were nominated. I'm writing to let you know that Tomcat was voted Best Java Application Server by our members at CNet Network's Builder.com. There'll be an official announcement on our site soon, and we will be making available an award graphic as well. Please let me know if there's someone in particular I should contact when the announcement article publishes. Thanks Lamont Adams Web Editor Builder.com -- End of Forwarded Message -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Missed vote
Craig R. McClanahan [EMAIL PROTECTED] wrote: On Tue, 16 Jul 2002, Jon Scott Stevens wrote: Date: Tue, 16 Jul 2002 11:56:40 -0700 From: Jon Scott Stevens [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: tomcat-dev [EMAIL PROTECTED] Subject: Missed vote Arg. I missed the vote where the Servlet API and JSP classes were going to be stored in the same repo. Is there any way that I can -1 that after the fact? Several of us have worked hard over the years to completely separate the Servlet API from the JSP API for various valid reasons (including the fact that some of us don't like JSP). This fight came to an end when Sun decided to create separation of the two API's by having separate JSR's. Now, it seems that we are moving backwards again by having the two API's stored in the same repo and now that I found out that that has happened, I would love to try to stop it from going any further. What can we do here? What's so painful about a ten-line build.xml target that creates a separate JAR file with just the javax.servlet and javax.servlet.http API classes, if that's what you need? Sharing a CVS repository has little or nothing to do with how many distributable outputs you create. On the other hand, having both servlet and JSP APIs in a single JAR file is quite useful to a very large number of existing Tomcat (and other container) users, so it should be available also. Logically it's more confusing to see servlet.jar to have both. Especially now that they are _two_ separate JSRs. Two APIs, IMO, two JARs, but as I replied earlier, it's not my problem anymore. Pier -- [Perl] combines all the worst aspects of C and Lisp: a billion of different sublanguages in one monolithic executable. It combines the power of C with the readability of PostScript. [Jamie Zawinski - DNA Lounge - San Francisco] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
kinman 2002/07/16 15:35:05
Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
Log:
- turn off more debug messages.
Revision ChangesPath
1.3 +8 -2
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java
Index: SmapUtil.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/SmapUtil.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- SmapUtil.java 16 Jul 2002 19:36:16 - 1.2
+++ SmapUtil.java 16 Jul 2002 22:35:04 - 1.3
@@ -73,6 +73,8 @@
*/
public class SmapUtil {
+static final boolean verbose = false;
+
//*
// Constants
@@ -167,7 +169,6 @@
// Installation logic (from Robert Field, JSR-045 spec lead)
private static class SDEInstaller {
- static final boolean verbose = false;
static final String nameSDE = SourceDebugExtension;
byte[] orig;
@@ -461,7 +462,12 @@
for( int i = 0; i numChildNodes; i++ ) {
Node n = nodes.getNode( i );
Mark mark = n.getStart();
- System.out.println(Mark(start): line=+ mark.getLineNumber() +
col=+mark.getColumnNumber() +Node: begLine=+n.getBeginJavaLine() +
endLine=+n.getEndJavaLine());
+
+ if (verbose) {
+System.out.println(Mark(start): line=+ mark.getLineNumber() +
+ col=+mark.getColumnNumber() +Node: begLine=+
+n.getBeginJavaLine() + endLine=+n.getEndJavaLine());
+ }
String unqualifiedName = unqualify(mark.getFile());
s.addFile(unqualifiedName);
s.addLineData(mark.getLineNumber(),
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
luehe 2002/07/16 15:39:20
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Log:
Fixed infinite loop in fragment generation for jsp:body.
Revision ChangesPath
1.38 +7 -10
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- Generator.java16 Jul 2002 20:40:11 - 1.37
+++ Generator.java16 Jul 2002 22:39:20 - 1.38
@@ -1689,10 +1689,7 @@
out.print(attributeValue(value, false, JspFragment.class,
null ));
} else {
-// Parent node must be a CustomTag since
-// isSimpleTagHandler is set to true.
- generateJspFragment((Node.CustomTag)n.getParent(),
-simpleTagHandlerVar);
+ generateJspFragment(n, simpleTagHandlerVar);
}
out.println(););
} else {
@@ -2377,7 +2374,7 @@
* Generates anonymous JspFragment inner class which is passed as an
* argument to SimpleTag.setJspBody().
*/
- private void generateJspFragment(Node parent, String tagHandlerVar)
+ private void generateJspFragment(Node n, String tagHandlerVar)
throws JasperException
{
// XXX - A possible optimization here would be to check to see
@@ -2387,10 +2384,10 @@
// body. The implementation of this fragment can come from
// the org.apache.jasper.runtime package as a support class.
int id = helperClassBuffer.getFragmentId();
-helperClassBuffer.openFragment( parent );
+helperClassBuffer.openFragment( n );
ServletWriter outSave = out;
out = helperClassBuffer.getOut();
-visitBody( parent );
+visitBody( n );
out = outSave;
helperClassBuffer.closeFragment();
// XXX - Need to change pageContext to jspContext if
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Missed vote
on 7/16/02 1:14 PM, Craig R. McClanahan [EMAIL PROTECTED] wrote: What's so painful about a ten-line build.xml target that creates a separate JAR file with just the javax.servlet and javax.servlet.http API classes, if that's what you need? Sharing a CVS repository has little or nothing to do with how many distributable outputs you create. On the other hand, having both servlet and JSP APIs in a single JAR file is quite useful to a very large number of existing Tomcat (and other container) users, so it should be available also. Craig I used to say the same thing about Turbine and Torque. You could use Torque without using any of the Turbine code...yet people refused to use Torque because it was packaged in the same jar file as Turbine. I also think that keeping two different API's in the same .jar file is a terrible idea. Think about all the issues we have/had with the XML api's. The Servlet API is also on a different release cycle than the JSP API. Also, having things in the same repo makes it to easy to create dependencies between the two API's...that is why the JSR's were split as well. As Pier said, 2 API's, 2 JSR's, 2 CVS repo's. Consider this my strong -1. -jon -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerGenerator.java
[EMAIL PROTECTED] wrote: luehe 2002/07/16 15:39:20 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed infinite loop in fragment generation for jsp:body. BTW, those patches probably need to be also applied to the 4.1 branch. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java
kinman 2002/07/16 16:40:06 Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java Log: - Generation of smap seems to cause the container to freeze occasionally. It is turned off for now; and will need to be debugged later. Revision ChangesPath 1.20 +5 -5 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java Index: Compiler.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v retrieving revision 1.19 retrieving revision 1.20 diff -u -r1.19 -r1.20 --- Compiler.java 16 Jul 2002 19:30:51 - 1.19 +++ Compiler.java 16 Jul 2002 23:40:06 - 1.20 @@ -245,7 +245,7 @@ writer.close(); //JSR45 Support - note this needs to be checked by a JSR45 guru - SmapUtil.generateSmap(ctxt, pageNodes, true); + //XXX SmapUtil.generateSmap(ctxt, pageNodes, true); } /** @@ -319,7 +319,7 @@ } //JSR45 Support - note this needs to be checked by a JSR45 guru - SmapUtil.installSmap(ctxt); + //XXX SmapUtil.installSmap(ctxt); } /** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java
luehe 2002/07/16 17:35:31
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Log:
escape \n when outputting jsp:plugin params
Revision ChangesPath
1.39 +4 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- Generator.java16 Jul 2002 22:39:20 - 1.38
+++ Generator.java17 Jul 2002 00:35:30 - 1.39
@@ -1233,7 +1233,7 @@
escape( name ) + \\\ value= + +
attributeValue( n.getValue(), false, String.class,
null ) + + \ ); );
-out.printil( out.write(\\n\); );
+out.printil(out.write(\\\n\););
}
else {
// We want something of the form
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit:jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerGenerator.java
Remy, No they don't: they are bug fixes for JSP2.0 stuff. I'll make sure bug fixes that apply to both branches get in both branches. Don't worry! :-) - Kin-man Date: Wed, 17 Jul 2002 00:43:53 +0200 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java To: Tomcat Developers List [EMAIL PROTECTED] Content-transfer-encoding: 7bit [EMAIL PROTECTED] wrote: luehe 2002/07/16 15:39:20 Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java Log: Fixed infinite loop in fragment generation for jsp:body. BTW, those patches probably need to be also applied to the 4.1 branch. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9913] - Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913 Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36 --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 02:12 --- Finally had some more time to play with this. Here is what the problem is... jk_handler starts with this (line 1184 in mod_jk.c): -- if(strcmp(r-handler,JK_HANDLER)) return DECLINED; -- when page is explicitly referenced, r-handler is jakarta-servlet, so all goes well. However, when the page is the default page, r-handler is httpd/unix-directory so jk_handler simply declines to serve the request. The most obvious fix for this is: -- if(strcmp(r-handler,JK_HANDLER) strcmp(r-handler,DIR_MAGIC_TYPE)) return DECLINED; -- I don't know enough about Apache 2 and mod_jk to vouch for this fix, so any of the Apache/mod_jk specialists out there, please review before I commit. The fix does cause (at least) one problem... The getServletPath() call returns '/' rather than actual page, for instance '/index.jsp' or '/index.vm', which is different from 1.3.x. Anyway, some progress... -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9913] - Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913 Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36 --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 03:01 --- ... the getServletPath() returning '/' or '/path/to/page/' definitely causes major dramas ... It causes the rewriten URL's to not have any extension (e.g. they end up being something like this: '/path/to/page/;jsessionid='), which then causes mod_jk not to be picked to serve the request at all and Apache just proclaims that the page does not exist... Back to the drawing board ;-) Bojan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9913] - Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913 Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36 --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 04:50 --- I am not sure but this seems to me to be like the bug I opened, #10789, against mod_jk2. At least the symptom is the same, when a directory URL is requested, the DirectoryIndex file (default page) is not being handled by mod_jk2 (mod_jk). I just built mod_jk and put some fprintf statements in it to trace the entry of the hook functions for the module. This is the print out from requesting http://my.numeric.ip/. It looks exactly the same as it does for mod_jk2, i.e. the translate and map_to_storage hooks pick up index.jsp, but then the handler hook is not getting invoked. G:\Apache32\Apache2\binapache -X jk_translate( ) ENTER Unparsed uri: / Return DECLINED jk_map_to_storage( ) ENTER Unparsed uri: / Return DECLINED jk_translate( ) ENTER Unparsed uri: /index.html Return DECLINED jk_map_to_storage( ) ENTER Unparsed uri: /index.html Return DECLINED jk_translate( ) ENTER Unparsed uri: /index.jsp Return OK jk_map_to_storage( ) ENTER Unparsed uri: /index.jsp Return OK jk_translate( ) ENTER Unparsed uri: /error/HTTP_FORBIDDEN.html.var Return DECLINED jk_map_to_storage( ) ENTER Unparsed uri: /error/HTTP_FORBIDDEN.html.var Return DECLINED jk_translate( ) ENTER Unparsed uri: /error/include/top.html Return DECLINED jk_map_to_storage( ) ENTER Unparsed uri: /error/include/top.html Return DECLINED jk_handler( ) ENTER Unparsed uri: /error/include/top.html Return DECLINED jk_translate( ) ENTER Unparsed uri: /error/include/bottom.html Return DECLINED jk_map_to_storage( ) ENTER Unparsed uri: /error/include/bottom.html Return DECLINED jk_handler( ) ENTER Unparsed uri: /error/include/bottom.html Return DECLINED jk_translate( ) ENTER Unparsed uri: /error/include/../contact.html.var Return DECLINED jk_map_to_storage( ) ENTER Unparsed uri: /error/include/../contact.html.var Return DECLINED Do you think 9913 and 10789 are the same thing? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9913] - Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913 Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36 --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 05:13 --- Yep, I'd say so. Bojan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10789] - Setting DirectoryIndex of index.jsp does not get served by jk2
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789 Setting DirectoryIndex of index.jsp does not get served by jk2 --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 05:32 --- From mod_jk2.c, function jk2_handler, line 536: --- if(uriEnv==NULL || strcmp(r-handler,JK_HANDLER)!= 0 ) return DECLINED; --- which kind of boils down to the same thing as in bug 9913, except this is for mod_jk2, as compared to mod_jk. I guess this fix here would be (following the logic of 9913 fix): --- if(uriEnv==NULL || (strcmp(r-handler,JK_HANDLER) strcmp(r-handler,DIR_MAGIC_TYPE))) return DECLINED; --- Bojan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
bojan 2002/07/16 22:40:35 Modified:jk/native/apache-2.0 mod_jk.c Log: Fix picking up default pages from Apache 2.x Revision ChangesPath 1.47 +3 -2 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c Index: mod_jk.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v retrieving revision 1.46 retrieving revision 1.47 diff -u -r1.46 -r1.47 --- mod_jk.c 23 Jun 2002 05:40:29 - 1.46 +++ mod_jk.c 17 Jul 2002 05:40:35 - 1.47 @@ -1181,7 +1181,8 @@ jk_server_conf_t *conf; int rc; -if(strcmp(r-handler,JK_HANDLER))/* not for me, try next handler */ +/* not for me, try next handler */ +if(strcmp(r-handler,JK_HANDLER) strcmp(r-handler,DIR_MAGIC_TYPE)) return DECLINED; xconf = (jk_server_conf_t *)ap_get_module_config(r-server-module_config, -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9913] - Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9913 Default pages not picked up by mod_jk 1.2.0 with Apache 2.0.36 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 05:41 --- Actually, the fix works quite fine for JSP's, since Tomcat 3.3.x automagically redirects all requests that end in '/' to the correct JSP. The only problem that the fix was causing was related to Velocity pages served by my own PumpServlet, which depended upon getServletPath() returning the actual page. And since that's easy to fix... So, unless there is a better fix out there, the above goes in. Bojan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 mod_jk2.c
bojan 2002/07/16 22:58:34 Modified:jk/native2/server/apache2 mod_jk2.c Log: Fix picking up default pages from Apache 2.x Revision ChangesPath 1.40 +3 -2 jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c Index: mod_jk2.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c,v retrieving revision 1.39 retrieving revision 1.40 diff -u -r1.39 -r1.40 --- mod_jk2.c 8 Jul 2002 13:31:23 - 1.39 +++ mod_jk2.c 17 Jul 2002 05:58:34 - 1.40 @@ -533,7 +533,8 @@ uriEnv=ap_get_module_config( r-request_config, jk2_module ); /* not for me, try next handler */ -if(uriEnv==NULL || strcmp(r-handler,JK_HANDLER)!= 0 ) +if(uriEnv==NULL || + (strcmp(r-handler,JK_HANDLER) strcmp(r-handler,DIR_MAGIC_TYPE))) return DECLINED; /* If this is a proxy request, we'll notify an error */ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10789] - Setting DirectoryIndex of index.jsp does not get served by jk2
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789 Setting DirectoryIndex of index.jsp does not get served by jk2 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-17 06:00 --- Mark, please give the fix a good bashing. It's now in CVS. Bojan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
