Re: [JK2] jni channel doesn't send POST data (WAS: [JK2] Apache2add read-ahead for POST data)
Mladen Turk wrote: -Original Message- From: Costin Manolache It's most likely a bug. I know Nacho is using JNI with IIS - and the code looks fine. Yeah, it was... Just fixed it in the cvs. We were sending reply msg and the handler was feeding post msg. Oops I fill a bit guilty for this one ;-( Looks fine now (tested with 100K POST data) using either JNI or socket. MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_lb.c jk_channel_jni.c jk_channel.c
mturk 2002/11/21 01:03:18
Modified:jk/native2/common jk_worker_lb.c jk_channel_jni.c
jk_channel.c
Log:
Get rid of the one-shot worker initialization scheme.
It doesn't work as it should, and it slows down the load balacer.
Once when service channel will be introduced it will take care of that.
Revision ChangesPath
1.28 +9 -62 jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c
Index: jk_worker_lb.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_lb.c,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- jk_worker_lb.c21 Nov 2002 07:46:41 - 1.27
+++ jk_worker_lb.c21 Nov 2002 09:03:17 - 1.28
@@ -85,7 +85,6 @@
typedef struct {
struct jk_mutex *cs;
-int initializing;
int attempts;
int recovery;
int timeout;
@@ -334,35 +333,12 @@
/* Since there is potential worker state change
* make the find best worker call thread safe
*/
-if (!lb_priv-initializing) {
-if (lb_priv-cs != NULL)
-lb_priv-cs-lock(env, lb_priv-cs);
-rec=jk2_get_most_suitable_worker(env, lb, s, attempt);
-
-if (lb_priv-cs != NULL)
-lb_priv-cs-unLock(env, lb_priv-cs);
-if (!rec lb_priv-timeout) {
-time_t now = time(NULL);
-if ((int)(now - lb_priv-error_time) lb_priv-timeout) {
-#ifdef HAS_APR
-apr_thread_yield();
-#endif
-continue;
-}
-}
-else
-lb_priv-error_time = time(NULL);
-}
-else if (!rec){
-/* If we are initializing the service wait until
- * the initialization finishes or times out
- */
-if (lb-cs != NULL) {
-lb-cs-lock(env, lb-cs);
-lb-cs-unLock(env, lb-cs);
-}
-continue;
-}
+if (lb_priv-cs != NULL)
+lb_priv-cs-lock(env, lb_priv-cs);
+rec=jk2_get_most_suitable_worker(env, lb, s, attempt);
+
+if (lb_priv-cs != NULL)
+lb_priv-cs-unLock(env, lb_priv-cs);
attempt++;
s-is_recoverable_error = JK_FALSE;
@@ -405,50 +381,21 @@
s-jvm_route = rec-route;
s-realWorker = rec;
-if (rec-mbean-initialize !lb_priv-initializing lb-cs != NULL) {
-/* If the worker has not been called yet serialize the call */
-lb-cs-lock(env, lb-cs);
-lb_priv-initializing = JK_TRUE;
-rec-error_time = time(NULL);
-}
+
rc = rec-service(env, rec, s);
if(rc==JK_OK) {
rec-in_error_state = JK_FALSE;
rec-error_time = 0;
-/* Set the initialized flag to TRUE if that was the first call */
-if (rec-mbean-initialize lb-cs != NULL) {
-rec-mbean-initialize = 0;
-lb_priv-initializing = JK_FALSE;
-lb-cs-unLock(env, lb-cs);
-}
return JK_OK;
}
-if (rec-mbean-initialize lb-cs != NULL) {
-time_t now = time(NULL);
-/* In the case of initialization timeout disable the worker */
-if ((int)(now - rec-error_time) rec-mbean-initialize) {
-rec-mbean-disabled = JK_TRUE;
-lb_priv-initializing = JK_FALSE;
-s-is_recoverable_error = JK_FALSE;
-env-l-jkLog(env, env-l, JK_LOG_ERROR,
- lb_worker.service() worker init timeout for %s\n,
- rec-channelName);
-lb-cs-unLock(env, lb-cs);
-}
-else {
-#ifdef HAS_APR
-apr_thread_yield();
-#endif
-continue;
-}
-}
/* If this is a browser connection error dont't check other
* workers.
*/
if (rc == JK_HANDLER_ERROR) {
-
+rec-in_error_state = JK_FALSE;
+rec-error_time = 0;
return JK_HANDLER_ERROR;
}
1.38 +1 -3 jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c
Index: jk_channel_jni.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- jk_channel_jni.c 6 Nov 2002 16:32:25 - 1.37
+++
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/common ChannelSocket.java
hgomez 2002/11/21 01:32:17
Modified:jk/java/org/apache/jk/common ChannelSocket.java
Log:
Report timeout exception as such
Revision ChangesPath
1.27 +7 -7
jakarta-tomcat-connectors/jk/java/org/apache/jk/common/ChannelSocket.java
Index: ChannelSocket.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/common/ChannelSocket.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- ChannelSocket.java20 Nov 2002 14:16:46 - 1.26
+++ ChannelSocket.java21 Nov 2002 09:32:17 - 1.27
@@ -555,14 +555,14 @@
}
}
} catch( Exception ex ) {
-if( ex.getMessage().indexOf( Connection reset ) =0 ||
-ex.getMessage().indexOf( Read timed out ) =0 )
+if( ex.getMessage().indexOf( Connection reset ) = 0)
log.info( Server has been restarted or reset this connection);
+else if (ex.getMessage().indexOf( Read timed out ) =0 )
+log.info( connection timeout reached);
else
log.error( Error, processing connection, ex);
}
- finally {
-
+finally {
/*
* Whatever happened to this connection (remote closed it, timeout,
read error)
* the socket SHOULD be closed, or we may be in situation where the
webserver
@@ -572,10 +572,10 @@
try {
this.close( ep );
}
-catch( Exception ex) {
-log.error( Error, closing connection, ex);
+catch( Exception e) {
+log.error( Error, closing connection, e);
}
- }
+}
}
public int invoke( Msg msg, MsgContext ep ) throws IOException {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5/resources/confinstall server_2.xml
hgomez 2002/11/21 01:39:41 Modified:resources/confinstall server_2.xml Log: No timeout to be set in AJP13 connector, it's the webserver responsability to drop unused connections Revision ChangesPath 1.5 +1 -1 jakarta-tomcat-5/resources/confinstall/server_2.xml Index: server_2.xml === RCS file: /home/cvs/jakarta-tomcat-5/resources/confinstall/server_2.xml,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- server_2.xml 11 Oct 2002 08:58:56 - 1.4 +++ server_2.xml 21 Nov 2002 09:39:41 - 1.5 @@ -21,7 +21,7 @@ Connector className=org.apache.coyote.tomcat5.CoyoteConnector port=8009 minProcessors=5 maxProcessors=75 enableLookups=true redirectPort=8443 - acceptCount=10 debug=0 connectionTimeout=2 + acceptCount=10 debug=0 connectionTimeout=0 useURIValidationHack=false protocolHandlerClassName=org.apache.jk.server.JkCoyoteHandler/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/conf server.xml
[EMAIL PROTECTED] wrote: hgomez 2002/11/21 01:42:36 Modified:catalina/src/conf server.xml Log: No timeout to be set in AJP13 connector, it's the webserver responsability to drop unused connections Revision ChangesPath 1.65 +1 -1 jakarta-tomcat-4.0/catalina/src/conf/server.xml Index: server.xml === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/conf/server.xml,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- server.xml 5 Nov 2002 11:41:49 - 1.64 +++ server.xml 21 Nov 2002 09:42:36 - 1.65 @@ -107,7 +107,7 @@ Connector className=org.apache.coyote.tomcat4.CoyoteConnector port=8009 minProcessors=5 maxProcessors=75 enableLookups=true redirectPort=8443 - acceptCount=10 debug=0 connectionTimeout=2 + acceptCount=10 debug=0 connectionTimeout=0 useURIValidationHack=false protocolHandlerClassName=org.apache.jk.server.JkCoyoteHandler/ We shouldn't close the connection on the java side to avoid webserver to be puzzled with half-closed sockets. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[TOMCAT] Disabling Server shutdown port?
Hi, Can we disable the server shutdown port? I was thinking if I set the port to 0, then the StandardServer shouldn't create the shutdown socket. The reason for that is cause the embedded TC doesn't really need that if the JNI is the only communication channel. Server could be shut down from 'inside'. This will enable multiple TC instances too, using the same server.xml file. Of course the await() needs to be refactored so it will not fail in that case. Thoughts? MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [TOMCAT] Disabling Server shutdown port?
Mladen Turk wrote: Hi, Can we disable the server shutdown port? I was thinking if I set the port to 0, then the StandardServer shouldn't create the shutdown socket. The reason for that is cause the embedded TC doesn't really need that if the JNI is the only communication channel. Server could be shut down from 'inside'. This will enable multiple TC instances too, using the same server.xml file. Of course the await() needs to be refactored so it will not fail in that case. Thoughts? You should use the BootstrapService class instead of Bootstrap. In 5.0, this has been refactored in a single class (with a flag to trigger the await). Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [TOMCAT] Disabling Server shutdown port?
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
You should use the BootstrapService class instead of
Bootstrap.
Silly me ... ;-(.
What about ChannelSocket can it be disabled too ?
Something like:
public void init() throws IOException {
// Find a port.
if (startPort == 0) {
port = 0;
log.info(JK2: ajp13 disabling channelSocket);
running = true;
return;
}
If the connector port is set to 0 then no listening socket will be
created (cause one doesn't want to listen on this server).
MT.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Does anyone care....
OK... I will put the jk2 connector on my development machine and merge the changes at my next opportunity. Thanks again for your help. .-.| Steven Velez oo|| Software Engineer /`'\| alventive (\_;/) | 678-202-2226 -Original Message- From: Ignacio J. Ortega [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 6:54 PM To: 'Tomcat Developers List' Subject: RE: Does anyone care Steven, JK2 is aproaching Stable state at very good pace, and the help there is much more needed than in jk1, testing and reporting bugs, and implemeting features like yours, is preferred.. in any case yours is ok for jk1.. thought.. in to jk2. Do you think it's better to do this sooner or later? I think sooner the better, mostly i can easily test to your changes in my dev machine ;), and development in jk2 ( native2 ) it's active at the moment, and jk1 it's freezed .. soo With respect to your last comment: Is submitting patches as incidents in bugzilla preferred to posting them on the mailing list? If so, I will do this in the future. Well, you finally seemed to the get the answer by yourself :), but for sure a bug with a [PATCH] in the summary and a good explanation, with the patch attached will do well too, i prefer it, it gets stored ata safe place ( much better than a mail archive ) and we can add comments for posterity.. and the bugzilla mails go to the tomcat-dev too.. so better to add a it as bug.. IMHO.. Thank you very much. Thank you for your patience Saludos, Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14736] New: - Unable to set servlet init parameters from web.xml and application context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14736.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14736
Unable to set servlet init parameters from web.xml and application context
Summary: Unable to set servlet init parameters from web.xml and
application context
Product: Tomcat 4
Version: 4.1.12
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: Other
Component: Servlet JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
When trying to set the context parameter according to:
http://jakarta.apache.org/tomcat/tomcat-4.1-doc/config/context.html
Both in the WEB-INF/web.xml and in a application context file the parameters can
not be read from the servlet with ServletContext.getInitParameter().
--
catalina/webapps/webapp.xml:
!-- R-Server context --
Context path=/boris/web docBase=/home/boris/work/rs-home/war/web/web
debug=1 reloadable=true crossContext=false
Parameter name=LoggerName value=rserver-web override=false/
/Context
WEB-INF/web.xml :
!DOCTYPE web-app
PUBLIC -//Sun Microsystems, Inc.//DTD Web Application 2.3//EN
http://java.sun.com/dtd/web-app_2_3.dtd;
web-app
display-nameServer Administration Interface/display-name
description
The Server administration interface.
/description
!-- Change these values --
context-param
param-nameLoggerName/param-name
param-valuerserver-web/param-value
/context-param
servlet
servlet-nameServer/servlet-name
servlet-classcom.ipunplugged.AppServlet/servlet-class
/servlet
/web-app
--
ApplicationServelet.java :
public class AppServlet extends HttpServlet {
public void init() {
String name = getServletConfig().getInitParameter(LoggerName);
if(name == null)
Log.error(Missing logger name); // always !
}
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14165] - Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165 Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 14:03 --- has anyone looked at this... if nothing else this makes dev a real pain. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14165] - Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165 Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 14:07 --- Why would you want to delete the work directories when developing? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Javac memory leak
Ok, I did some testing running 4.1.14 as a service... Now my knowledge of memory management is not so good so this might mean nothing. When running as a service if I goto every example jsp page (the examples that come with the install) Compiled Memory starts at 37872 and ends at 39048 Not compiled Memory starts at 39635 and ends at 58760 Does this not look like a memory leak in the jsp compile code?? Thanks, John -Original Message- From: Holger Brozio [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 12:14 PM To: Tomcat Developers List Subject: Re: Javac memory leak I also have no memory leak problems now with Tomcat 4.1.12. But i'm using jikes instead of javac as jsp page compiler. Whats about switching to jikes. If the memory leak problem is gone with jikes, javac still leaks memory, otherwise it is a problem in the jsp pages. Cheers Holger - Original Message - From: John Trollinger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, November 20, 2002 3:39 PM Subject: Javac memory leak Does anyone know if the javac memory leak still exists (1.4.1 docs say it does not). I have a test the goes through a bunch of jsp pages and if they are not precompiled I get a out of memory exception. Thanks, John -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14165] - Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165 Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 14:30 --- I'm not sure if thinking of it as a cache helps much since I agree if it was a cache then you would expect to be able to easily clear it. The work directory is in reality more of a practical internal detail of Tomcat, rather than being part of any public functionality. The whole thing could in theory, even though being crap idea, have been built in memory and you wouldn't be able to touch it. I guess it is unfortunate that you gone as far as exposing these internals to your clients, I suspect if you need to have this sorted, you need to look at it yourself. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14165] - Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14165 Deleting a directory with compiled jsp pages causes FileNotFoundException on recompile [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 14:36 --- To be honest I agree with most of your points.. the only time I realy want to delete it is when getting files from vss because sometimes the timestamps are older than what I had localy (i know i can check them out with a current timestamp) -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Javac memory leak
I think we should define memory leak. During the precompilation of the jsp pages, the resulting class files are also loaded by the classloader. This means of course, that the memory size increases. It is up to the garbage collector to remove the loaded classes from memory. In other words, it depends how long you wait after the precompilation with your memory measurement. If you look at the memory size immediate after the precompilation, the size is higher. If you wait a certain time frame and don't call any jsp page, the garbage collector should run and remove all unused instances of jsp classes. HTH Holger - Original Message - From: John Trollinger [EMAIL PROTECTED] To: 'Tomcat Developers List' [EMAIL PROTECTED] Sent: Thursday, November 21, 2002 3:22 PM Subject: RE: Javac memory leak Ok, I did some testing running 4.1.14 as a service... Now my knowledge of memory management is not so good so this might mean nothing. When running as a service if I goto every example jsp page (the examples that come with the install) Compiled Memory starts at 37872 and ends at 39048 Not compiled Memory starts at 39635 and ends at 58760 Does this not look like a memory leak in the jsp compile code?? Thanks, John -Original Message- From: Holger Brozio [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 12:14 PM To: Tomcat Developers List Subject: Re: Javac memory leak I also have no memory leak problems now with Tomcat 4.1.12. But i'm using jikes instead of javac as jsp page compiler. Whats about switching to jikes. If the memory leak problem is gone with jikes, javac still leaks memory, otherwise it is a problem in the jsp pages. Cheers Holger - Original Message - From: John Trollinger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, November 20, 2002 3:39 PM Subject: Javac memory leak Does anyone know if the javac memory leak still exists (1.4.1 docs say it does not). I have a test the goes through a bunch of jsp pages and if they are not precompiled I get a out of memory exception. Thanks, John -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Tagging JK2_2_0_2
Hi, There has been lots of changes since 2.0.1 like: - Regular expressions for uri mapping - Duplicating global directives - Fixing POST on JNI - etc... I'm planning to tag the JK2 on Monday 25th. Any objections to that? Also we still need to do a lot of work on the docs (hope that John will help us here finally ;). MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Javac memory leak
that is unusual. I've done baseline performance tests with the standard examples and haven't seen that kind of behavior with 4.1.10-12. Can you start tomcat with verbose:gc and see what kind of output you're getting. Just because the memory allocated to Java is 58megs at the end, it doesn't mean it's actually using all of it actively. getting the GC output will tell you how much memory is being used, when GC runs and whether or not a fullGC ran. in past experience with 4.0.4, after loading all the example pages tomcat's memory allocation is around 45megs. peter John Trollinger wrote: Ok, I did some testing running 4.1.14 as a service... Now my knowledge of memory management is not so good so this might mean nothing. When running as a service if I goto every example jsp page (the examples that come with the install) Compiled Memory starts at 37872 and ends at 39048 Not compiled Memory starts at 39635 and ends at 58760 Does this not look like a memory leak in the jsp compile code?? Thanks, John -Original Message- From: Holger Brozio [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 12:14 PM To: Tomcat Developers List Subject: Re: Javac memory leak I also have no memory leak problems now with Tomcat 4.1.12. But i'm using jikes instead of javac as jsp page compiler. Whats about switching to jikes. If the memory leak problem is gone with jikes, javac still leaks memory, otherwise it is a problem in the jsp pages. Cheers Holger - Original Message - From: John Trollinger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, November 20, 2002 3:39 PM Subject: Javac memory leak Does anyone know if the javac memory leak still exists (1.4.1 docs say it does not). I have a test the goes through a bunch of jsp pages and if they are not precompiled I get a out of memory exception. Thanks, John -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[DONATION] procrun
Hi, I would like to donate the following code to the Apache community. The main reason for that is missing of decent service dispatcher for the Tomcat. The application can be run either as a service, console application, dll, or windows application. Needs some work and testing, but it can be IMO very usefull. Of course the licence is BSD only if accepted. MT. procrun.zip Description: Zip compressed data -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Tagging JK2_2_0_2
Mladen Turk wrote: Hi, There has been lots of changes since 2.0.1 like: - Regular expressions for uri mapping - Duplicating global directives - Fixing POST on JNI - etc... I'm planning to tag the JK2 on Monday 25th. Any objections to that? I have some patches to commit. I will mail when I have finished. Also we still need to do a lot of work on the docs (hope that John will help us here finally ;). MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Javac memory leak
Just to double check against tomcat 4.1.12, the memory usage seems normal to me John. After tomcat starts up, it is using 23megs. My webapp loads when tomcat starts up, so your numbers may be lower. The system has 256megs of memory and 750mhz cpu. after I I hit all the pages in /examples/jsp/ directory, the memory allocated to java is 40megs. I even ran it with OptimizeIt and I don't see any memory leaks. peter peter lin wrote: that is unusual. I've done baseline performance tests with the standard examples and haven't seen that kind of behavior with 4.1.10-12. Can you start tomcat with verbose:gc and see what kind of output you're getting. Just because the memory allocated to Java is 58megs at the end, it doesn't mean it's actually using all of it actively. getting the GC output will tell you how much memory is being used, when GC runs and whether or not a fullGC ran. in past experience with 4.0.4, after loading all the example pages tomcat's memory allocation is around 45megs. peter John Trollinger wrote: Ok, I did some testing running 4.1.14 as a service... Now my knowledge of memory management is not so good so this might mean nothing. When running as a service if I goto every example jsp page (the examples that come with the install) Compiled Memory starts at 37872 and ends at 39048 Not compiled Memory starts at 39635 and ends at 58760 Does this not look like a memory leak in the jsp compile code?? Thanks, John -Original Message- From: Holger Brozio [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 12:14 PM To: Tomcat Developers List Subject: Re: Javac memory leak I also have no memory leak problems now with Tomcat 4.1.12. But i'm using jikes instead of javac as jsp page compiler. Whats about switching to jikes. If the memory leak problem is gone with jikes, javac still leaks memory, otherwise it is a problem in the jsp pages. Cheers Holger - Original Message - From: John Trollinger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, November 20, 2002 3:39 PM Subject: Javac memory leak Does anyone know if the javac memory leak still exists (1.4.1 docs say it does not). I have a test the goes through a bunch of jsp pages and if they are not precompiled I get a out of memory exception. Thanks, John -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_jni.c
jfclere 2002/11/21 08:08:32
Modified:jk/native2/common jk_worker_jni.c
Log:
Allow no-threaded APR. - But no-threaded APR won't work anyway -
Revision ChangesPath
1.35 +2 -0 jakarta-tomcat-connectors/jk/native2/common/jk_worker_jni.c
Index: jk_worker_jni.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_jni.c,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- jk_worker_jni.c 7 Nov 2002 07:28:27 - 1.34
+++ jk_worker_jni.c 21 Nov 2002 16:08:32 - 1.35
@@ -451,9 +451,11 @@
jniWorker-jk_main_method,
jargs);
if (jniWorker-hook == JK2_WORKER_HOOK_SHUTDOWN) {
+#if APR_HAS_THREADS
while (jk_jni_status_code != 2) {
apr_thread_yield();
}
+#endif
vm-detach(env, vm);
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Javac memory leak
When I run the examples with -verbose:gc this is what I get (just the snippits at the end) From uncompiled jsp pages [GC 14707K-13665K(28412K), 0.0059002 secs] [GC 15521K-15518K(28412K), 0.0128997 secs] [GC 17374K-16086K(28412K), 0.0092266 secs] [GC 17942K-16258K(28412K), 0.0086307 secs] [GC 18114K-16213K(28412K), 0.0046327 secs] [GC 18069K-17934K(28412K), 0.0114056 secs] [GC 19790K-19672K(28412K), 0.0155838 secs] Did you see me on the stderr window? Did you see me on the browser window as well? [GC 21520K-20092K(28412K), 0.0094920 secs] [GC 21947K-20095K(28412K), 0.0075890 secs] [GC 21951K-21758K(28412K), 0.0131385 secs] [GC 23614K-23528K(28412K), 0.0137372 secs] [GC 25384K-23769K(28412K), 0.0079125 secs] [GC 25625K-24336K(28412K), 0.0073652 secs] [GC 26192K-26170K(28412K), 0.0153369 secs] [GC 28026K-27460K(29436K), 0.0190963 secs] [Full GC 27460K-15538K(29436K), 0.2839948 secs] [GC 17394K-15720K(28412K), 0.0060262 secs] [GC 17575K-15746K(28412K), 0.0046218 secs] [GC 17602K-15745K(28412K), 0.0027241 secs] [GC 17601K-15745K(28412K), 0.0025604 secs] [GC 17601K-15746K(28412K), 0.0026679 secs] Stopping service Tomcat-Standalone From compiled jsp pages [GC 11356K-10577K(14028K), 0.0061505 secs] [GC 11532K-11034K(14028K), 0.0046978 secs] [GC 11994K-11305K(14028K), 0.0060575 secs] [GC 12265K-11341K(14028K), 0.0059876 secs] [GC 12297K-11396K(14028K), 0.0065578 secs] [GC 12356K-11538K(14028K), 0.0063572 secs] [GC 12498K-11598K(14028K), 0.0040036 secs] [GC 12558K-11965K(14028K), 0.0052529 secs] Did you see me on the stderr window? Did you see me on the browser window as well? [GC 12925K-12020K(14028K), 0.0046872 secs] Stopping service Tomcat-Standalone As you can see there is about a 4 meg diff between the two This is using j2sdk 1.4.1 on windows XP with 512 ram using tomcat 4.1.14LE -Original Message- From: peter lin [mailto:[EMAIL PROTECTED]] Sent: Thursday, November 21, 2002 10:56 AM To: Tomcat Developers List Subject: Re: Javac memory leak Just to double check against tomcat 4.1.12, the memory usage seems normal to me John. After tomcat starts up, it is using 23megs. My webapp loads when tomcat starts up, so your numbers may be lower. The system has 256megs of memory and 750mhz cpu. after I I hit all the pages in /examples/jsp/ directory, the memory allocated to java is 40megs. I even ran it with OptimizeIt and I don't see any memory leaks. peter peter lin wrote: that is unusual. I've done baseline performance tests with the standard examples and haven't seen that kind of behavior with 4.1.10-12. Can you start tomcat with verbose:gc and see what kind of output you're getting. Just because the memory allocated to Java is 58megs at the end, it doesn't mean it's actually using all of it actively. getting the GC output will tell you how much memory is being used, when GC runs and whether or not a fullGC ran. in past experience with 4.0.4, after loading all the example pages tomcat's memory allocation is around 45megs. peter John Trollinger wrote: Ok, I did some testing running 4.1.14 as a service... Now my knowledge of memory management is not so good so this might mean nothing. When running as a service if I goto every example jsp page (the examples that come with the install) Compiled Memory starts at 37872 and ends at 39048 Not compiled Memory starts at 39635 and ends at 58760 Does this not look like a memory leak in the jsp compile code?? Thanks, John -Original Message- From: Holger Brozio [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 12:14 PM To: Tomcat Developers List Subject: Re: Javac memory leak I also have no memory leak problems now with Tomcat 4.1.12. But i'm using jikes instead of javac as jsp page compiler. Whats about switching to jikes. If the memory leak problem is gone with jikes, javac still leaks memory, otherwise it is a problem in the jsp pages. Cheers Holger - Original Message - From: John Trollinger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, November 20, 2002 3:39 PM Subject: Javac memory leak Does anyone know if the javac memory leak still exists (1.4.1 docs say it does not). I have a test the goes through a bunch of jsp pages and if they are not precompiled I get a out of memory exception. Thanks, John -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional
DO NOT REPLY [Bug 14741] New: - TagFiles with same name in different tag directories overwrite the generated java files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14741. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14741 TagFiles with same name in different tag directories overwrite the generated java files Summary: TagFiles with same name in different tag directories overwrite the generated java files Product: Tomcat 5 Version: Nightly Build Platform: Other OS/Version: Other Status: NEW Severity: Critical Priority: Other Component: Jasper2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Because the package name used for tagfile generated source is always the same you will get collisions if you have two tag files with the same name but in different directories. Take the HelloWorld tagfile example in the jsp-examples war and change it to the following : %@ taglib prefix=mytag tagdir=/WEB-INF/tags/test % %@ taglib prefix=mytag1 tagdir=/WEB-INF/tags % html head titleJSP 2.0 Examples - Hello World SimpleTag Handler/title /head body h1JSP 2.0 Examples - Hello World SimpleTag Handler/h1 hr pThis tag handler simply echos Hello, World! It's an example of a very basic SimpleTag handler with no body./p br buResult:/u/b mytag:helloWorld/ mytag1:helloWorld/ /body /html Make a copy of the helloWorld.tag in WEB-INF/tags and copy it to WEB-INF/tags/test change the test helloWorld.tag to this : %-- - Copyright (c) 2002 The Apache Software Foundation. All rights - reserved. --% Hello, world Again! When you run http://localhost:8080/jsp-examples/jsp2/simpletag/hello.jsp You see this : Result: Hello, world Again! Hello, world Again! In the working directory for the jsp-examples war there is only one copy of helloWorld.java found in the work\Standalone\localhost\jsp-examples\tagfiles\org\apache\jsp\tagfile directory. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_socket.c jk_channel_un.c jk_logger_file.c
jfclere 2002/11/21 08:23:59 Modified:jk/native2/common jk_channel_socket.c jk_channel_un.c jk_logger_file.c Log: Add FD_CLOEXEC to prevent log file and sockets beeing opened in a son process. Submitted by Martin Kraemer. Revision ChangesPath 1.45 +5 -0 jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c Index: jk_channel_socket.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c,v retrieving revision 1.44 retrieving revision 1.45 diff -u -r1.44 -r1.45 --- jk_channel_socket.c 7 Nov 2002 16:46:28 - 1.44 +++ jk_channel_socket.c 21 Nov 2002 16:23:59 - 1.45 @@ -364,6 +364,11 @@ setsockopt(sock, IPPROTO_TCP, TCP_NODELAY,(char *)set,sizeof(set)); } +#if defined(F_SETFD) defined(FD_CLOEXEC) +/* Protect the socket so that it will not be inherited by child processes */ +fcntl(sock, F_SETFD, FD_CLOEXEC); +#endif + if( ch-mbean-debug 0 ) env-l-jkLog(env, env-l, JK_LOG_DEBUG, channelSocket.connect(), sock = %d\n, sock); 1.14 +6 -0 jakarta-tomcat-connectors/jk/native2/common/jk_channel_un.c Index: jk_channel_un.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_un.c,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- jk_channel_un.c 8 Jul 2002 13:41:13 - 1.13 +++ jk_channel_un.c 21 Nov 2002 16:23:59 - 1.14 @@ -79,6 +79,7 @@ #include jk_global.h #include string.h +#include fcntl.h #include jk_registry.h #ifdef HAVE_UNIXSOCKETS @@ -275,6 +276,11 @@ return JK_ERR; } } + +#if defined(F_SETFD) defined(FD_CLOEXEC) +/* Protect the socket so that it will not be inherited by child processes */ +fcntl(unixsock, F_SETFD, FD_CLOEXEC); +#endif if( ch-mbean-debug 0 ) env-l-jkLog(env, env-l, JK_LOG_DEBUG, 1.36 +8 -1 jakarta-tomcat-connectors/jk/native2/common/jk_logger_file.c Index: jk_logger_file.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_logger_file.c,v retrieving revision 1.35 retrieving revision 1.36 diff -u -r1.35 -r1.36 --- jk_logger_file.c 4 Oct 2002 16:08:19 - 1.35 +++ jk_logger_file.c 21 Nov 2002 16:23:59 - 1.36 @@ -67,6 +67,7 @@ #include jk_map.h #include jk_logger.h #include stdio.h +#include fcntl.h #include jk_registry.h @@ -172,6 +173,12 @@ Can't open log file %s\n, _this-name ); return JK_ERR; } +#if defined(F_SETFD) defined(FD_CLOEXEC) +/* Protect the log file + * so that it will not be inherited by child processes + */ +fcntl(fileno(f), F_SETFD, FD_CLOEXEC); +#endif _this-logger_private = f; } _this-jkLog(env, _this,JK_LOG_INFO, -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14742] New: - jsp:setProperty mangles character set with param=
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14742. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14742 jsp:setProperty mangles character set with param= Summary: jsp:setProperty mangles character set with param= Product: Tomcat 4 Version: 4.1.12 Platform: PC OS/Version: Windows XP Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have form setup by a JSP page with pageEncoding=UTF-8 which posts to a JSP page which also sets pageEncoding=UTF-8. There's a textarea on the form. When I use jsp:setProperty with a param to push the text into a bean, the text is mangled, in the classic assume Latin-1 fashion. I was under the impression that the versions of servlet and JSP in Tomcat 4 would get this right. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_jni.c
That's like you said ... ;)
Is there a Java implementation withouth threads?
If not then, we should disable jni for non-threaded apr.
Make that dependent of HAVE_JNI. There is no need to compile in the JNI
for non-threaded servers.
Or simply...
#ifndef APR_HAS_THREADS
#error You will need to enable threads to compile JNI
#endif
-Original Message-
From: [EMAIL PROTECTED]
+#if APR_HAS_THREADS
while (jk_jni_status_code != 2) {
apr_thread_yield();
}
+#endif
MT.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Javac memory leak
This is from the examples jsp right? or are they from your webapp? the latest optimizeit has a leak finder feature. you may want to download the trail version and give it a shot. from the data it looks like a lot of objects are promoted to old memory from heap. It doesn't necessarily constitute a memory leak though. if you use a lot of static variables, that could easily account for objects getting promoted to old memory peter John Trollinger wrote: When I run the examples with -verbose:gc this is what I get (just the snippits at the end) From uncompiled jsp pages [GC 14707K-13665K(28412K), 0.0059002 secs] [GC 15521K-15518K(28412K), 0.0128997 secs] [GC 17374K-16086K(28412K), 0.0092266 secs] [GC 17942K-16258K(28412K), 0.0086307 secs] [GC 18114K-16213K(28412K), 0.0046327 secs] [GC 18069K-17934K(28412K), 0.0114056 secs] [GC 19790K-19672K(28412K), 0.0155838 secs] Did you see me on the stderr window? Did you see me on the browser window as well? [GC 21520K-20092K(28412K), 0.0094920 secs] [GC 21947K-20095K(28412K), 0.0075890 secs] [GC 21951K-21758K(28412K), 0.0131385 secs] [GC 23614K-23528K(28412K), 0.0137372 secs] [GC 25384K-23769K(28412K), 0.0079125 secs] [GC 25625K-24336K(28412K), 0.0073652 secs] [GC 26192K-26170K(28412K), 0.0153369 secs] [GC 28026K-27460K(29436K), 0.0190963 secs] [Full GC 27460K-15538K(29436K), 0.2839948 secs] [GC 17394K-15720K(28412K), 0.0060262 secs] [GC 17575K-15746K(28412K), 0.0046218 secs] [GC 17602K-15745K(28412K), 0.0027241 secs] [GC 17601K-15745K(28412K), 0.0025604 secs] [GC 17601K-15746K(28412K), 0.0026679 secs] Stopping service Tomcat-Standalone From compiled jsp pages [GC 11356K-10577K(14028K), 0.0061505 secs] [GC 11532K-11034K(14028K), 0.0046978 secs] [GC 11994K-11305K(14028K), 0.0060575 secs] [GC 12265K-11341K(14028K), 0.0059876 secs] [GC 12297K-11396K(14028K), 0.0065578 secs] [GC 12356K-11538K(14028K), 0.0063572 secs] [GC 12498K-11598K(14028K), 0.0040036 secs] [GC 12558K-11965K(14028K), 0.0052529 secs] Did you see me on the stderr window? Did you see me on the browser window as well? [GC 12925K-12020K(14028K), 0.0046872 secs] Stopping service Tomcat-Standalone As you can see there is about a 4 meg diff between the two This is using j2sdk 1.4.1 on windows XP with 512 ram using tomcat 4.1.14LE -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Javac memory leak
This is the examples with the install.. What I don't understand is why there is a difference when compiled vs uncompiled and the diff is always there. When we run our tests if our jsp pages are uncompiled the diff is about 170 meg.. That is what causes me to be a little nervous. I will try optimizeit and see what it shows.. Thanks for all your time.. John -Original Message- From: peter lin [mailto:[EMAIL PROTECTED]] Sent: Thursday, November 21, 2002 11:36 AM To: Tomcat Developers List Subject: Re: Javac memory leak This is from the examples jsp right? or are they from your webapp? the latest optimizeit has a leak finder feature. you may want to download the trail version and give it a shot. from the data it looks like a lot of objects are promoted to old memory from heap. It doesn't necessarily constitute a memory leak though. if you use a lot of static variables, that could easily account for objects getting promoted to old memory peter John Trollinger wrote: When I run the examples with -verbose:gc this is what I get (just the snippits at the end) From uncompiled jsp pages [GC 14707K-13665K(28412K), 0.0059002 secs] [GC 15521K-15518K(28412K), 0.0128997 secs] [GC 17374K-16086K(28412K), 0.0092266 secs] [GC 17942K-16258K(28412K), 0.0086307 secs] [GC 18114K-16213K(28412K), 0.0046327 secs] [GC 18069K-17934K(28412K), 0.0114056 secs] [GC 19790K-19672K(28412K), 0.0155838 secs] Did you see me on the stderr window? Did you see me on the browser window as well? [GC 21520K-20092K(28412K), 0.0094920 secs] [GC 21947K-20095K(28412K), 0.0075890 secs] [GC 21951K-21758K(28412K), 0.0131385 secs] [GC 23614K-23528K(28412K), 0.0137372 secs] [GC 25384K-23769K(28412K), 0.0079125 secs] [GC 25625K-24336K(28412K), 0.0073652 secs] [GC 26192K-26170K(28412K), 0.0153369 secs] [GC 28026K-27460K(29436K), 0.0190963 secs] [Full GC 27460K-15538K(29436K), 0.2839948 secs] [GC 17394K-15720K(28412K), 0.0060262 secs] [GC 17575K-15746K(28412K), 0.0046218 secs] [GC 17602K-15745K(28412K), 0.0027241 secs] [GC 17601K-15745K(28412K), 0.0025604 secs] [GC 17601K-15746K(28412K), 0.0026679 secs] Stopping service Tomcat-Standalone From compiled jsp pages [GC 11356K-10577K(14028K), 0.0061505 secs] [GC 11532K-11034K(14028K), 0.0046978 secs] [GC 11994K-11305K(14028K), 0.0060575 secs] [GC 12265K-11341K(14028K), 0.0059876 secs] [GC 12297K-11396K(14028K), 0.0065578 secs] [GC 12356K-11538K(14028K), 0.0063572 secs] [GC 12498K-11598K(14028K), 0.0040036 secs] [GC 12558K-11965K(14028K), 0.0052529 secs] Did you see me on the stderr window? Did you see me on the browser window as well? [GC 12925K-12020K(14028K), 0.0046872 secs] Stopping service Tomcat-Standalone As you can see there is about a 4 meg diff between the two This is using j2sdk 1.4.1 on windows XP with 512 ram using tomcat 4.1.14LE -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_jni.c
Mladen Turk wrote:
That's like you said ... ;)
Is there a Java implementation withouth threads?
I do not think so.
If not then, we should disable jni for non-threaded apr.
Make that dependent of HAVE_JNI. There is no need to compile in the JNI
for non-threaded servers.
Yes. But that is even more complicated we should not try to compile JNI if the
threads used by APR are not the ones used by the JVM. Any idea how to test that?
Or simply...
#ifndef APR_HAS_THREADS
#error You will need to enable threads to compile JNI
#endif
#else
#error You will need to enable threads to compile JNI
#endif
in common jk_worker_jni.c ;-))
-Original Message-
From: [EMAIL PROTECTED]
+#if APR_HAS_THREADS
while (jk_jni_status_code != 2) {
apr_thread_yield();
}
+#endif
MT.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Tagging JK2_2_0_2
Mladen Turk wrote: Hi, There has been lots of changes since 2.0.1 like: - Regular expressions for uri mapping - Duplicating global directives - Fixing POST on JNI - etc... I'm planning to tag the JK2 on Monday 25th. Any objections to that? I remember that a FIONBIO was causing me some problems it seems there is a #if 0 #endif So the code between is not used any more. Could we remove it? Also we still need to do a lot of work on the docs (hope that John will help us here finally ;). MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Tagging JK2_2_0_2
-Original Message- I remember that a FIONBIO was causing me some problems it seems there is a #if 0 #endif So the code between is not used any more. Could we remove it? Yes... That was my invention after all (blocking blocked socket) ;-). /* When a socket is created, it operates in blocking mode * by default (nonblocking mode is disabled), so there is no need * to set it to the blocking mode prior timeout setting. * This is consistent with BSD sockets. ... MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JkCoyoteHandler does not respect port attribute inserver.xml
This has been fixed, I think. There was a checkin by Costin to jk/java/org/apache/jk/server JkMain.java - on 30/Oct/2001 So, I'm guessing that means Catalina 4.1.14 or so? Jeff Tulley ([EMAIL PROTECTED]) (801)861-5322 Novell, Inc., the leading provider of Net business solutions http://www.novell.com [EMAIL PROTECTED] 11/20/02 7:26:52 PM Did anyone notice that Tomcat 4.1.12 does not respect the port attribute for the AJP13 connector I have a connector defined like this, Connector className=org.apache.coyote.tomcat4.CoyoteConnector port=8010 minProcessors=5 maxProcessors=75 enableLookups=true redirectPort=8444 acceptCount=10 debug=0 connectionTimeout=2 useURIValidationHack=false protocolHandlerClassName=org.apache.jk.server.JkCoyoteHandler/ and yet, tomcat starts the connector on port 8009. any thoughts? Filip ~ Namaste - I bow to the divine in you ~ Filip Hanik Software Architect www.filip.net -Original Message- From: Tim Funk [mailto:[EMAIL PROTECTED]] Sent: Wednesday, November 20, 2002 6:19 PM To: [EMAIL PROTECTED] Subject: [PATCH] Disable access log rotation Is anyone opposed to looking at bug 14724? It replaces a similiar enhancment [bug 12145](with patch) logged a few months ago. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14724 The patch also enables writing out Cookies, incoming headers, Session attributes, and HttpServletRequest attributes in a syntax similar to apache. If this functionality is added to the admin app, I believe the following needs added to mbeans-descriptors.xml in the AccessLogValve section. attribute name=rotatable description=Rotate log is=true type=boolean/ -Tim -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Javac memory leak
Well d/l optimizeit and realized it would take a few weeks for me to understand what it is trying to tell me.. Just to double check against tomcat 4.1.12, the memory usage seems normal to me John. After tomcat starts up, it is using 23megs. My webapp loads when tomcat starts up, so your numbers may be lower. The system has 256megs of memory and 750mhz cpu. after I I hit all the pages in /examples/jsp/ directory, the memory allocated to java is 40megs. Peter, did you try it with the examples compiled and then uncompiled and get the same results.. Or did you just run them once?? I even ran it with OptimizeIt and I don't see any memory leaks. peter -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c
costin 2002/11/21 09:53:48
Modified:jk/native/common jk_ajp_common.c
Log:
Do not send the initial chunk for chunked encoding ( only for
regular POST ).
Ajp13 servers ( tomcat x.y, etc ) expect this initial chunk
only if a content-length is specified.
( this is just an initial fix - I still need to test various
cases )
Revision ChangesPath
1.33 +10 -3 jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
Index: jk_ajp_common.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- jk_ajp_common.c 30 Oct 2002 22:12:20 - 1.32
+++ jk_ajp_common.c 21 Nov 2002 17:53:48 - 1.33
@@ -808,7 +808,7 @@
}
if (!r-is_chunked) {
-ae-left_bytes_to_send -= len;
+ ae-left_bytes_to_send -= len;
}
if (len 0) {
@@ -905,7 +905,14 @@
* for resend if the remote Tomcat is down, a fact we will learn only
* doing a read (not yet)
*/
-if (s-is_chunked || ae-left_bytes_to_send 0) {
+ /* || s-is_chunked - this can't be done here. The original protocol sends the
first
+chunk of post data ( based on Content-Length ), and that's what the java
side expects.
+Sending this data for chunked would break other ajp13 serers.
+
+Note that chunking will continue to work - using the normal read.
+ */
+
+if (ae-left_bytes_to_send 0) {
int len = ae-left_bytes_to_send;
if (len AJP13_MAX_SEND_BODY_SZ)
len = AJP13_MAX_SEND_BODY_SZ;
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_ajp13.c
costin 2002/11/21 09:58:35
Modified:jk/native2/common jk_worker_ajp13.c
Log:
Same fix for jk2. Don't send initial chunk for chunked encoding.
The reason the data is sent for POST - in almost all cases tomcat
will read it ( required by the spec - to process the data ). This way
we avoid a round-trip.
We don't send more than 8k for few reasons - tomcat may want to
discard the request ( for example to prevent a huge body that it
can't handle ), the TCP stack would do round-trips anyway ( for flow-control )
and most requests are 8k anyway.
There is a major problem ( since the first release of Ajp13) related
with the fact that this chunk of data is not properly
marshalled ( it doesn't have the 'type' descriptor ).
Revision ChangesPath
1.42 +8 -1 jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c
Index: jk_worker_ajp13.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- jk_worker_ajp13.c 18 Oct 2002 15:23:52 - 1.41
+++ jk_worker_ajp13.c 21 Nov 2002 17:58:35 - 1.42
@@ -351,7 +351,14 @@
request was sent ( we're receiving data from client, can be slow, no
need to delay - we can do that in paralel. ( not very sure this is
very usefull, and it brakes the protocol ) ! */
-if (has_post_body || s-is_chunked || s-left_bytes_to_send 0) {
+
+ /* || s-is_chunked - this can't be done here. The original protocol sends the
first
+chunk of post data ( based on Content-Length ), and that's what the java
side expects.
+Sending this data for chunked would break other ajp13 serers.
+
+Note that chunking will continue to work - using the normal read.
+ */
+if (has_post_body || s-left_bytes_to_send 0) {
/* We never sent any POST data and we check it we have to send at
* least of block of data (max 8k). These data will be kept in reply
* for resend if the remote Tomcat is down, a fact we will learn only
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14282] - mod_jk/ajp13 returns wrong response after bad chunk-encoding request
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14282.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14282
mod_jk/ajp13 returns wrong response after bad chunk-encoding request
--- Additional Comments From [EMAIL PROTECTED] 2002-11-21 18:23 ---
I will try the latest tomcat and let you know if I still have this problem. Here
is how we are able to reproduce it:
I have a servlet:
import javax.servlet.http.HttpServlet;
import java.io.PrintWriter;
import java.io.IOException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
import org.apache.log4j.Category;
import java.util.Enumeration;
public class LoadServlet extends HttpServlet
{
public void init(ServletConfig config) throws ServletException
{
Category logger = Category.getRoot();
logger.info(LoadServlet::init(): Loading LoadServlet!);
}
public void service(HttpServletRequest request, HttpServletResponse response)
{
Category logger = Category.getRoot();
StringBuffer url = new StringBuffer();
url.append(LoadServlet::service(): Request URL ( + ((HttpServletRequest)
request).getRequestURI() + ?);
Enumeration enum = request.getParameterNames();
while (enum.hasMoreElements())
{
String key = (String) enum.nextElement();
url.append(key + = + request.getParameter(key));
}
logger.info(url.toString() + ));
// Take the request and response to it.
String id = request.getParameter(ID);
logger.info(LoadServlet::service(): Got ID parameter( + id + ));
StringBuffer responseString = new StringBuffer().append(HTMLThe ID you p
assed in is: + id + /HTML\n);
logger.info(LoadServlet::service(): Response ( + responseString + ));
response.addHeader(ID , java.net.URLEncoder.encode(id));
try
{
PrintWriter pw = response.getWriter();
pw.write(responseString.toString());
}
catch(IOException e)
{
logger.error(e.getMessage(), e);
}
}
}
running on tomcat that just returns the parameter(ID) in both the header and the
body of the response. I also have a perl script:
#!/usr/local/bin/perl -w
use IO::Socket;
unless (@ARGV 1) { die Usage: ./syncsvt.pl: host port\n;}
($host) = $ARGV[0];
($port) = $ARGV[1];
$remote = IO::Socket::INET-new( Proto = tcp,
PeerAddr = $host,
PeerPort = $port,
);
unless ($remote) { die Cannot connect to $host\n }
$remote-autoflush(1);
print $remote GET /index.jsp HTTP/1.1\x0d\x0aHost:
host1.foo.com\x0d\x0aTransfer-Encoding:
Chunked\x0d\x0a\x0d\x0a\x0d\x0a\x0d\x0a;
while ( $remote ) { print }
close $remote;
that invokes my chunked encoding request.
To reproduce the problem, I first run the perl script and hit the apache server
on port 80 and get back the 404 response saying index.jsp is not found. Then
with two browsers open, I invoke the LoadServlet servlet with the parameter
ID=value through apache using HTTPS 4-5 times on each browser repeatedly.
After a while, one of my requests will return the 404 response for the
chunked-encoding request I made earlier from my perl script. After that, every
once in a while, I will get back the response of one of my previous requests.
A tcpdump of my tomcat server on port 8009 shows that it is writing the correct
response back, but the mod_jk log in debug mode shows that it receieved the
response of a previous request.
Modifying the mod_jk shared lib to close the socket in ajp_done():
// close the socket
jk_close_socket(p-sd, l);
p-sd = -1;
seems to fix this problem because the socket is no longer reused, but I'm still
not sure what causes the problem and closing the socket each time takes away the
advantages of reusing the socket.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [DONATION] procrun
Looks good. Is this your code ( or code you have copyright to ) ? IMO the best way would be to make a proposal and add it to j-t-c, it seems very related with the jk_nt_service and mod_jk jni mode. If you want it to be a standalone and separated program - I think it would be better to propose it to jakarta-commons, but from what I can see in the code it would be better to merge it in jk. Costin Mladen Turk wrote: Hi, I would like to donate the following code to the Apache community. The main reason for that is missing of decent service dispatcher for the Tomcat. The application can be run either as a service, console application, dll, or windows application. Needs some work and testing, but it can be IMO very usefull. Of course the licence is BSD only if accepted. MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14741] - TagFiles with same name in different tag directories overwrite the generated java files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14741. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14741 TagFiles with same name in different tag directories overwrite the generated java files [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 18:30 --- Implicit tag files are described in JSP.8.4.3 of PFD. Implicit TLDs are constructed from all the tag files in and under /WEB-INF/tags. Note that name of a tag file in the implicit TLD is the name of the tag file, minus the .tag extention, and is used for matching the tag handlers. This implies that you cannot have two tag files of the same name under /WEB-INF/tags. Consider mytag:HelloWorld/ in you example. Which one are you using, /WEB-INF/tags/HelloWorld.tag or /WEB-INF/tags/test/HelloWorld.tag? Perhaps Jasper should detect and flag as error duplicate tag file? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Tagging JK2_2_0_2
+1 I'll try to add a bit more documentation ( and re-test ) the config stuff ( reloading etc ) as well as the chunked fix. Costin Mladen Turk wrote: Hi, There has been lots of changes since 2.0.1 like: - Regular expressions for uri mapping - Duplicating global directives - Fixing POST on JNI - etc... I'm planning to tag the JK2 on Monday 25th. Any objections to that? Also we still need to do a lot of work on the docs (hope that John will help us here finally ;). MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: howto extend catalina with mbeans
The solution is not yet very well defined. Right now catalina can be extended with Valves or connectors or listeners. Some of them (like jk connector ) can define MBeans. The major problem is having the admin interface recognize them - it should work but I never tried. I already committed some code to modeler to allow modules to have their own modeler description ( in META-INF/modeler-mbean.xml ) and have it loaded automatically using getResources(). The code is not yet used, but will probably be for 5.0 ( or I hope so ). But if you implement your own mbean - you can register them yourself. The only important thing is to get the MBeanServer using the same mechanisms ( i.e. get existing instead of creating new one ). Also note that there are discussions on using modeler mbean to implement config changes ( it is not yet clear what's the best solution ), that may affect the support for custom mbeans. Another issue that wasn't much discussed is having mechanisms to use mbeans as extensions ( hooks, etc) - and use the mbean lifecycle and naming as a registration ( or alternatively, use a JNDI/JMX combination - the big problem with JMX is that you can't get the real object, all calls must be made via mbean server) Costin Jakob Praher wrote: hi all, first of all kudos for the 4.1.x release - working with jmx is simply great ;-) I have a question, how to best extend catalina through jmx: for instance I have a special connector mbean or adaptor mbean, that I want to load into catalina. is there a way (for instance in the server.xml configuration file) to laod this mbean during startup ? if not: what is the best way to plug in a third party mbean into catalina ? should I write a custom lifecyclelistener? thanks -- Jakob the best way to predict the future ist to invent it -- Alan Kay -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [TOMCAT] Disabling Server shutdown port?
+1
I don't know if this is known - the socket channel has a feature
to specify a range - if the port is taken it'll try the next one.
This allows a single config file to be used for a pool of tomcats
( i.e. simpler config for load-balancing ).
Costin
Mladen Turk wrote:
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
You should use the BootstrapService class instead of
Bootstrap.
Silly me ... ;-(.
What about ChannelSocket can it be disabled too ?
Something like:
public void init() throws IOException {
// Find a port.
if (startPort == 0) {
port = 0;
log.info(JK2: ajp13 disabling channelSocket);
running = true;
return;
}
If the connector port is set to 0 then no listening socket will be
created (cause one doesn't want to listen on this server).
MT.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14741] - TagFiles with same name in different tag directories overwrite the generated java files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14741. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14741 TagFiles with same name in different tag directories overwrite the generated java files [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 18:44 --- You are not understanding the test case. I have two tag directories in WEB-INF: WEB-INF/tags WEB-INF/tags/test According to the 2.0 spec each directory is treated as a separate tag library JSP.8.4.3 The JSP container must generate an implicit tag library for each directory under and including /WEB-INF/tags/. I have two tag files both called helloWorld.tag. One is : WEB-INF/tags/helloWorld.tag the other is : WEB-INF/tags/test/helloWorld.tag Then I have a jsp that uses both tags. It defines two taglib directives : %@ taglib prefix=mytag tagdir=/WEB-INF/tags/test % %@ taglib prefix=mytag1 tagdir=/WEB-INF/tags % One for each taglib directory i have. The jsp calls both tags : mytag:helloWorld/ mytag1:helloWorld/ As both tags are generated to the same package name and directory they will overwrite each other. Try this with the hello world tagfile test and you will see the problem -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JK2 module for AOLserver
Alexander Leyke wrote: The JNI channel is special because it is single-threaded ( a doors channel will use the same type of code ), and that has some implications in how the request is processed - but the data encoding is the same. Does it mean that in-process worker is a performance bottleneck in single-process server? It seems we have a communication problem :-) - again I don't understand what you are reffering to. In jk1, the JNI worker had some performance problems - because it created a lot of strings and made many (expensive) JNI calls. The ajp and socket was optimized, but the JNI was not ( it would have required a lot of C code ). In jk2, all those strings are eliminated ( from C side ), we also eliminate the buffer allocation ( we reuse the same jbyteArray and C array, with code to eventually support NIO - that cuts 2 memcpy and few other small things ). We also reduce the number of JNI calls to a minimum ( or almost ). Regarding the single-threaded behavior - I think this is a major benefit for JNI ( or doors ) workers, since it can avoid thread switching and a lot of synchronization. In all other protocol there are 2 threads sending data to each other. This won't be visible for a small number of RPS, but I expect it to be important for very high loads. Well - most likely this is just a benchmarking exercise - if the servlets are doing anything usefull they'll dominate the execution time anyway, the connector overhead is already extremely small. The JNI worker is working for IIS and Apache2, I see no reason why it won't work with AOLserver. ( I suppose you're aware of the jk1 AOLserver connector - it also used JNI, so you shouldn't have any major problems ) I am aware of nstomcat module which works with Tomcat 3, but not Tomcat 4. There is nothing of that nature under jakarta-tomcat-connectors-4.1.12-src/jk/native. Should I look better? You just need to port the nstomcat module to jk2. jk1 doesn't support tomcat4 in-process, jk2 does. From the connector point of view it doesn't matter what tomcat is run ( at one point it even detected the tomcat version at runtime - all it cares is to have coyote/jk2 available and have a class with main() ). Just get the socket to work ( it's easier to debug the server-specific code), then enable the jni channel and worker. OK, as I am working on it, there are some Java errors from Tomcat startup within AOLserver. I can repeat those errors when running TomcatStarter class from shell command line. Did you get the connector to work with sockets ? ( i.e tomcat out of process ) ? That's the first step, you need this to work well to test the aol-specific code. Nacho and Mladen are using the JNI code the most, but I suspect with a different version of tomcat. You can configure a different starter ( TomcatStarter did work with an older version of BootstrapService - now you can't use the 4.1 version of BS without daemon ). You can probably try to just configure it to use o.a.catalina.startup.Bootstrap. ( or a different starter with a main() ) Costin :: stderr.log :: TomcatStarter: main() Try org.apache.tomcat.startup.Main Try org.apache.catalina.startup.BootstrapService Starting org.apache.catalina.startup.BootstrapService java.lang.NullPointerException at org.apache.catalina.startup.BootstrapService.start(BootstrapService.java:244) at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:307) at java.lang.reflect.Method.invoke(Native Method) at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:127) at java.lang.Thread.run(Thread.java:484) Created catalinaLoader in: /deleted - AL/jakarta-tomcat-4.1.12/server/lib [INFO] Registry - -Loading registry information [INFO] Registry - -Creating new Registry instance [INFO] Registry - -Creating MBeanServer [INFO] Http11Protocol - -Initializing Coyote HTTP/1.1 on port 8089 java.lang.ArrayIndexOutOfBoundsException at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:305) at java.lang.reflect.Method.invoke(Native Method) at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:127) at java.lang.Thread.run(Thread.java:484) java.lang.ArrayIndexOutOfBoundsException at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:131) at java.lang.Thread.run(Thread.java:484) :: stdout.log :: Bootstrap: Starting service TomcatStarter: Done TomcatStarter: Done -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [DONATION] procrun
-Original Message- From: news [mailto:[EMAIL PROTECTED]] On Behalf Of Costin Manolache Sent: Thursday, November 21, 2002 7:24 PM To: [EMAIL PROTECTED] Subject: Re: [DONATION] procrun Looks good. Is this your code ( or code you have copyright to ) ? My own. IMO the best way would be to make a proposal and add it to j-t-c, it seems very related with the jk_nt_service and mod_jk jni mode. If you want it to be a standalone and separated program - I think it would be better to propose it to jakarta-commons, but from what I can see in the code it would be better to merge it in jk. Well I'm using it for launching and installing TC services (without console poping window), so it can belong to the j-t-c. I'm planning to add to it the process monitor (something like ApacheMonitor) that will go in the try and will capture the TC's (process) stdio/stderr inside the WIN32 GUI. Perhaps we may figure out some name for that? MT. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: howto extend catalina with mbeans
Am Don, 2002-11-21 um 19.29 schrieb Costin Manolache: The solution is not yet very well defined. yup. I have experienced the same. Right now catalina can be extended with Valves or connectors or listeners. Some of them (like jk connector ) can define MBeans. The major problem is having the admin interface recognize them - it should work but I never tried. I'll have to look at them. I only know that the default mbeans are plugged in with a lifecyclelistener. I already committed some code to modeler to allow modules to have their own modeler description ( in META-INF/modeler-mbean.xml ) and have it loaded automatically using getResources(). The code is not yet used, but will probably be for 5.0 ( or I hope so ). But if you implement your own mbean - you can register them yourself. ok. would be interesting to see what the avalon project is doing in this direction - they have management extensions for their containers. but I like the idea of beeing able to add MBeans to webapps. where is your code located in the jakarta-modeller source tree ? The only important thing is to get the MBeanServer using the same mechanisms ( i.e. get existing instead of creating new one ). don't know exactly what you mean by this ... Also note that there are discussions on using modeler mbean to implement config changes ( it is not yet clear what's the best solution ), that may affect the support for custom mbeans. sounds interesting. Another issue that wasn't much discussed is having mechanisms to use mbeans as extensions ( hooks, etc) - and use the mbean lifecycle and naming as a registration ( or alternatively, use a JNDI/JMX combination - the big problem with JMX is that you can't get the real object, all calls must be made via mbean server) yes that's the tradeof. this makes JMX so powerful ( no direct references ) but it can make things slow ... one thing I could imagine is to go both directions: a) via MBeans b) via plain java interfaces ... thanks very much for your help -- Jakob Costin Jakob Praher wrote: hi all, first of all kudos for the 4.1.x release - working with jmx is simply great ;-) I have a question, how to best extend catalina through jmx: for instance I have a special connector mbean or adaptor mbean, that I want to load into catalina. is there a way (for instance in the server.xml configuration file) to laod this mbean during startup ? if not: what is the best way to plug in a third party mbean into catalina ? should I write a custom lifecyclelistener? thanks -- Jakob the best way to predict the future ist to invent it -- Alan Kay -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: howto extend catalina with mbeans
Am Don, 2002-11-21 um 19.29 schrieb Costin Manolache: The solution is not yet very well defined. yup. I have experienced the same. Right now catalina can be extended with Valves or connectors or listeners. Some of them (like jk connector ) can define MBeans. The major problem is having the admin interface recognize them - it should work but I never tried. I'll have to look at them. I only know that the default mbeans are plugged in with a lifecyclelistener. I already committed some code to modeler to allow modules to have their own modeler description ( in META-INF/modeler-mbean.xml ) and have it loaded automatically using getResources(). The code is not yet used, but will probably be for 5.0 ( or I hope so ). But if you implement your own mbean - you can register them yourself. ok. would be interesting to see what the avalon project is doing in this direction - they have management extensions for their containers. but I like the idea of beeing able to add MBeans to webapps. where is your code located in the jakarta-modeller source tree ? The only important thing is to get the MBeanServer using the same mechanisms ( i.e. get existing instead of creating new one ). don't know exactly what you mean by this ... Also note that there are discussions on using modeler mbean to implement config changes ( it is not yet clear what's the best solution ), that may affect the support for custom mbeans. sounds interesting. Another issue that wasn't much discussed is having mechanisms to use mbeans as extensions ( hooks, etc) - and use the mbean lifecycle and naming as a registration ( or alternatively, use a JNDI/JMX combination - the big problem with JMX is that you can't get the real object, all calls must be made via mbean server) yes that's the tradeof. this makes JMX so powerful ( no direct references ) but it can make things slow ... one thing I could imagine is to go both directions: a) via MBeans b) via plain java interfaces ... thanks very much for your help -- Jakob Costin Jakob Praher wrote: hi all, first of all kudos for the 4.1.x release - working with jmx is simply great ;-) I have a question, how to best extend catalina through jmx: for instance I have a special connector mbean or adaptor mbean, that I want to load into catalina. is there a way (for instance in the server.xml configuration file) to laod this mbean during startup ? if not: what is the best way to plug in a third party mbean into catalina ? should I write a custom lifecyclelistener? thanks -- Jakob the best way to predict the future ist to invent it -- Alan Kay -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: howto extend catalina with mbeans
Jakob Praher wrote: Right now catalina can be extended with Valves or connectors or listeners. Some of them (like jk connector ) can define MBeans. The major problem is having the admin interface recognize them - it should work but I never tried. I'll have to look at them. I only know that the default mbeans are plugged in with a lifecyclelistener. The lifecycle listener generates model mbeans for components. A component can register its own mbeans. There is one major problem - if a component is not recognized by modeler ( which generates the mbean proxy ) you may see an exception. That will be fixed ( by using the META-INF and the introspection - and allowing external components to be loaded by modeler ). but I like the idea of beeing able to add MBeans to webapps. where is your code located in the jakarta-modeller source tree ? Registry.java. There are 2 pieces of code - one for loading descriptors from META-INF and another one for generating metadata using introspection. Using mbeans in webapps ( or adding modeler wrappers for any bean ) is easy, the real problem is integrating those mbeans with the admin and using the full power of the mbean model ( like jboss is doing ) ( for things like reloading modules, etc). The module-as-webapp stuff in tomcat3.3 tried to solve the same problem, but mbeans and mlets are a _far_ better solution. The only important thing is to get the MBeanServer using the same mechanisms ( i.e. get existing instead of creating new one ). don't know exactly what you mean by this ... Don't create the mbean server - first look for existing instances. Look at Registry.java for the code that gets the mbean server. Another issue that wasn't much discussed is having mechanisms to use mbeans as extensions ( hooks, etc) - and use the mbean lifecycle and naming as a registration ( or alternatively, use a JNDI/JMX combination - the big problem with JMX is that you can't get the real object, all calls must be made via mbean server) yes that's the tradeof. this makes JMX so powerful ( no direct references ) but it can make things slow ... For config stage - it doesn't matter most of the time, it's not a critical path. ( you don't do 100 config changes per second ). JMX notifications can be used to dynamically add/remove modules - but the problem is that inside the code you must use the real instance ( instead of invoke ). That's why I think JNDI + JMX is the right solution - catalina already has a very good JNDI support, and what we can do is use JNDI for naming and JMX for management ( the way they were intended :-). JMX notifications and name can be used to lookup in JNDI for the actual hook ( Valve, interceptor, handler, etc ), and combined with the mlet stuff this gives us the maximum flexibility ( i.e. you can add/remove/change/reconfig connectors and valves without restarting the server - if you want to ). All this is relatively easy to implement - but it requires a lot of preparation ( and agreement on the details ). one thing I could imagine is to go both directions: a) via MBeans b) via plain java interfaces ... That's my opinion as well ( with the plain java interfaces bound in the JNDI ). Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14736] - Unable to set servlet init parameters from web.xml and application context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14736. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14736 Unable to set servlet init parameters from web.xml and application context --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 21:40 --- FYI: as far as web.xml goes, the example you posted here will place an init parameter in the servlet context, not the servlet. instead of: String name = getServletConfig().getInitParameter(LoggerName); try this: String name = getServletContext().getInitParameter(LoggerName); -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [DONATION] procrun
Costin Manolache wrote: Looks good. Is this your code ( or code you have copyright to ) ? IMO the best way would be to make a proposal and add it to j-t-c, it seems very related with the jk_nt_service and mod_jk jni mode. If you want it to be a standalone and separated program - I think it would be better to propose it to jakarta-commons, but from what I can see in the code it would be better to merge it in jk. +1. I am looking for a replacement for JavaService, currently used by the Win installer. This code could also go into the commons-daemon project, but I'm fine with it in j-t-c. Could you provide a compiled version also ? Thanks, Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JK2 module for AOLserver
Costin Manolache wrote: In jk2, all those strings are eliminated ( from C side ), we also eliminate the buffer allocation ( we reuse the same jbyteArray and C array, with code to eventually support NIO - that cuts 2 memcpy and few other small things ). We also reduce the number of JNI calls to a minimum ( or almost ). Regarding the single-threaded behavior - I think this is a major benefit for JNI ( or doors ) workers, since it can avoid thread switching and a lot of synchronization. In all other protocol there are 2 threads sending data to each other. This won't be visible for a small number of RPS, but I expect it to be important for very high loads. Well - most likely this is just a benchmarking exercise - if the servlets are doing anything usefull they'll dominate the execution time anyway, the connector overhead is already extremely small. Ah! I understand now what you meant by single-threaded. It does sound like a better option. You just need to port the nstomcat module to jk2. jk1 doesn't support tomcat4 in-process, jk2 does. From the connector point of view it doesn't matter what tomcat is run ( at one point it even detected the tomcat version at runtime - all it cares is to have coyote/jk2 available and have a class with main() ). Exactly what I am doing. I have all AOLserver JK2 C code (simingly!) in place, and after fixing some things in workers2/jk2.properties I can see the worker attempt to communicate with AJP connector on port 8009: jk_channel_socket.c:328:channelSocket.open() connect failed localhost:8009 146 Connection refused I think above is due to Tomcat failing to initialize properly when in-process. It does listen on 8009 when I launch it from command line. Did you get the connector to work with sockets ? ( i.e tomcat out of process ) ? That's the first step, you need this to work well to test the aol-specific code. Yes. Works perfectly well, leaves nothing suspicious in the logs. You can configure a different starter ( TomcatStarter did work with an older version of BootstrapService - now you can't use the 4.1 version of BS without daemon ). You can probably try to just configure it to use o.a.catalina.startup.Bootstrap. ( or a different starter with a main() ) I see o.a.jk.apr.TomcatStarter.main() call o.a.catalina.startup.BootstrapService.main(). I didn't think of changing the bootstrap class. I see the followin candidates: org/apache/catalina/startup/Bootstrap.class org/apache/catalina/startup/BootstrapService.class org/apache/catalina/startup/CatalinaService.class org/apache/catalina/startup/Catalina.class org/apache/catalina/startup/Embedded.class Unfortunately the link to Catalina Javadocs off is broken on the jakarta.apache.org Website. I'll browse through the Java sources, butwould be helpful if anyone could mention which bootstrap class I could use in place of TomcatStarter A related question - what does this log entry mean? I think it is related to [worker.jni:onShutdown] entry in workers2.properties. jk_worker_jni.c:369:jni.init() disabling the non init hook worker Thanks, Alex :: stderr.log :: TomcatStarter: main() Try org.apache.tomcat.startup.Main Try org.apache.catalina.startup.BootstrapService Starting org.apache.catalina.startup.BootstrapService java.lang.NullPointerException at org.apache.catalina.startup.BootstrapService.start(BootstrapService.java:244) at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:307) at java.lang.reflect.Method.invoke(Native Method) at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:127) at java.lang.Thread.run(Thread.java:484) Created catalinaLoader in: /deleted - AL/jakarta-tomcat-4.1.12/server/lib [INFO] Registry - -Loading registry information [INFO] Registry - -Creating new Registry instance [INFO] Registry - -Creating MBeanServer [INFO] Http11Protocol - -Initializing Coyote HTTP/1.1 on port 8089 java.lang.ArrayIndexOutOfBoundsException at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:305) at java.lang.reflect.Method.invoke(Native Method) at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:127) at java.lang.Thread.run(Thread.java:484) java.lang.ArrayIndexOutOfBoundsException at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:131) at java.lang.Thread.run(Thread.java:484) :: stdout.log :: Bootstrap: Starting service TomcatStarter: Done TomcatStarter: Done -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14722] - Missing/invalid string resource for StandardSession
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14722. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14722 Missing/invalid string resource for StandardSession [EMAIL PROTECTED] changed: What|Removed |Added Summary|Missing/invalid string |Missing/invalid string |resource for|resource for StandardSession -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [DONATION] procrun
Remy Maucherat wrote: Costin Manolache wrote: Looks good. Is this your code ( or code you have copyright to ) ? IMO the best way would be to make a proposal and add it to j-t-c, it seems very related with the jk_nt_service and mod_jk jni mode. If you want it to be a standalone and separated program - I think it would be better to propose it to jakarta-commons, but from what I can see in the code it would be better to merge it in jk. +1. I am looking for a replacement for JavaService, currently used by the Win installer. Well, you could also use jk_nt_service :-) It works very well with tomcat4 ( or tomcat3 or any other java program ), is stable. But very ugly :-( Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JK2 module for AOLserver
Alexander Leyke wrote: You can configure a different starter ( TomcatStarter did work with an older version of BootstrapService - now you can't use the 4.1 version of BS without daemon ). You can probably try to just configure it to use o.a.catalina.startup.Bootstrap. ( or a different starter with a main() ) I see o.a.jk.apr.TomcatStarter.main() call o.a.catalina.startup.BootstrapService.main(). I didn't think of changing the bootstrap class. I see the followin candidates: org/apache/catalina/startup/Bootstrap.class org/apache/catalina/startup/BootstrapService.class org/apache/catalina/startup/CatalinaService.class org/apache/catalina/startup/Catalina.class org/apache/catalina/startup/Embedded.class Unfortunately the link to Catalina Javadocs off is broken on the jakarta.apache.org Website. I'll browse through the Java sources, butwould be helpful if anyone could mention which bootstrap class I could use in place of TomcatStarter I used BootstrapService because it didn't create the 8005 shutdown socket. My tests were done with 4.0. You can create your own wrapper, use CatalinaService directly or call Bootstrap ( if you don't mind 8005 - in your case it doesn't matter too much since you'll have a single process ). A related question - what does this log entry mean? I think it is related to [worker.jni:onShutdown] entry in workers2.properties. jk_worker_jni.c:369:jni.init() disabling the non init hook worker I have no idea. Ask Mladen :-) I know he added special code to allow multiple classes to be called on startup, init, shutdown, etc. There are several ways to load the java class. Since you see the messages from TomcatStarter - I assume it's harmless. :: stderr.log :: TomcatStarter: main() Try org.apache.tomcat.startup.Main Try org.apache.catalina.startup.BootstrapService Starting org.apache.catalina.startup.BootstrapService java.lang.NullPointerException at org.apache.catalina.startup.BootstrapService.start(BootstrapService.java:244) at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:307) at java.lang.reflect.Method.invoke(Native Method) at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:127) at java.lang.Thread.run(Thread.java:484) Created catalinaLoader in: /deleted - AL/jakarta-tomcat-4.1.12/server/lib [INFO] Registry - -Loading registry information [INFO] Registry - -Creating new Registry instance [INFO] Registry - -Creating MBeanServer [INFO] Http11Protocol - -Initializing Coyote HTTP/1.1 on port 8089 java.lang.ArrayIndexOutOfBoundsException at org.apache.catalina.startup.BootstrapService.main(BootstrapService.java:305) at java.lang.reflect.Method.invoke(Native Method) at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:127) at java.lang.Thread.run(Thread.java:484) java.lang.ArrayIndexOutOfBoundsException at org.apache.jk.apr.TomcatStarter.run(TomcatStarter.java:131) at java.lang.Thread.run(Thread.java:484) :: stdout.log :: Bootstrap: Starting service TomcatStarter: Done TomcatStarter: Done -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JK2 module for AOLserver
Costin Manolache wrote: I used BootstrapService because it didn't create the 8005 shutdown socket. My tests were done with 4.0. You can create your own wrapper, use CatalinaService directly or call Bootstrap ( if you don't mind 8005 - in your case it doesn't matter too much since you'll have a single process ). Bootstrap just worked for me sigh of relief. Comments in BootstrapService.java suggest it is for Win32. Are you testing on NT? I am still getting Java exceptions and for some reason javac doesn't want to compile (it cannot find modern compiler and is looking for classic), but JSP I had compiled before are running. A related question - what does this log entry mean? I think it is related to [worker.jni:onShutdown] entry in workers2.properties. jk_worker_jni.c:369:jni.init() disabling the non init hook worker I have no idea. Ask Mladen :-) I know he added special code to allow multiple classes to be called on startup, init, shutdown, etc. There are several ways to load the java class. Since you see the messages from TomcatStarter - I assume it's harmless. I saw the code which sends the message. Looks like it just disables hooks that don't belong to startup, init, or close phase. I am not sure what implications it has. Thanks! Alex -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14282] - mod_jk/ajp13 returns wrong response after bad chunk-encoding request
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14282. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14282 mod_jk/ajp13 returns wrong response after bad chunk-encoding request --- Additional Comments From [EMAIL PROTECTED] 2002-11-21 23:57 --- The latest version of mod_jk in CVS seems to fix this behavior. I no longer see the mixed request response pairs during my test. However, my chunked encoding request now hangs. I have to either ctrl-c the request or wait for the socket timeout to close the connection. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JK2 module for AOLserver
Alexander Leyke wrote: I used BootstrapService because it didn't create the 8005 shutdown socket. My tests were done with 4.0. You can create your own wrapper, use CatalinaService directly or call Bootstrap ( if you don't mind 8005 - in your case it doesn't matter too much since you'll have a single process ). Bootstrap just worked for me sigh of relief. Comments in BootstrapService.java suggest it is for Win32. Are you testing on NT? I am still getting Java exceptions and for some reason javac doesn't want to compile (it cannot find modern compiler and is looking for classic), but JSP I had compiled before are running. Are you using the jni channel ? Is that working too ? Regarding jsp - it uses ant to compile, so you may want to set a system property to specify the compiler ( you can do it in the worker config ). I use build.compiler=jikes :-) I saw the code which sends the message. Looks like it just disables hooks that don't belong to startup, init, or close phase. I am not sure what implications it has. You can have hooks for startup, init, or close - but the only one that matters ( in most cases ) is the one that loads main(). Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanUtils.java
billbarker2002/11/21 20:44:10
Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanUtils.java
Log:
Relaxing the restrictions on creating Valve MBeans.
There is no functional change for Catalina Valves. For custom Valves, they only
need to implement 'Contained', not extend ValveBase. At the very least, throwing a
checked-exception is much better then throwing the non-checked ClassCastException.
Revision ChangesPath
1.46 +13 -6
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java
Index: MBeanUtils.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java,v
retrieving revision 1.45
retrieving revision 1.46
diff -u -r1.45 -r1.46
--- MBeanUtils.java 8 Nov 2002 11:49:29 - 1.45
+++ MBeanUtils.java 22 Nov 2002 04:44:10 - 1.46
@@ -105,7 +105,6 @@
import org.apache.catalina.deploy.ContextResourceLink;
import org.apache.catalina.deploy.NamingResources;
import org.apache.catalina.deploy.ResourceParams;
-import org.apache.catalina.valves.ValveBase;
import org.apache.commons.beanutils.PropertyUtils;
import org.apache.commons.modeler.ManagedBean;
import org.apache.commons.modeler.Registry;
@@ -1571,7 +1570,15 @@
throws MalformedObjectNameException {
ObjectName name = null;
-Container container = ((ValveBase)valve).getContainer();
+Container container = null;
+if( valve instanceof Contained ) {
+container = ((Contained)valve).getContainer();
+}
+if( container == null ) {
+throw new MalformedObjectNameException(
+ Cannot create mbean for non-contained valve +
+ valve);
+}
if (container instanceof Engine) {
Service service = ((Engine)container).getService();
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5952] - Refence to $JAVACMD in tomcat.conf incorrect in RPM dist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5952. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5952 Refence to $JAVACMD in tomcat.conf incorrect in RPM dist [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | Version|4.0.1 Final |4.1.12 --- Additional Comments From [EMAIL PROTECTED] 2002-11-22 05:48 --- Still exists in tomcat4-4.1.12 rpm dated 10/8/2002 http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.1.12/rpms/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
