Re: [5.0.1] Tagging today
Costin Manolache wrote: Kin-Man Chung wrote: I also don't believe jsp-examples has been successful compiled with JSPC before. I know haven't tried that with JSP2.0 examples. With automatic compiling of the tag files, I won't be surprise if there are problems. :) It doesn't matter what it's for - if it is valid JSP it should compile with jspc the same as with jspservlet :-). If it's not valid - it should be removed... I tried to look into the issue, but it's quite complex :-( I don't like that new spec feature, overall. Same for the ability to put the TLD in random places. It seems the new spec revisions mean more complex + more bloated :-( This is quite disappointing ... Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Date: Fri, 21 Feb 2003 19:16:46 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: [5.0.1] Tagging today To: Tomcat Developers List [EMAIL PROTECTED] Costin Manolache wrote: Kin-Man Chung wrote: I also don't believe jsp-examples has been successful compiled with JSPC before. I know haven't tried that with JSP2.0 examples. With automatic compiling of the tag files, I won't be surprise if there are problems. :) It doesn't matter what it's for - if it is valid JSP it should compile with jspc the same as with jspservlet :-). If it's not valid - it should be removed... I tried to look into the issue, but it's quite complex :-( I have just committed a fix for using JSPC to compile JSP pages that uses tag files. The complication comes from the need to compile tag files into class objects before a JSP page that references them can be compiled. I don't know a better strategy for precompiling an application would be to first compile all the tag files first, then compile the JSP pages after that. The added complication is that a tag file may use other tag files, or even be circularly dependent. I don't like that new spec feature, overall. Same for the ability to put the TLD in random places. It's supposed to help page authors that are not programmers. But if a seasoned programmer find tag files hard to use, it's not a good sign. It seems the new spec revisions mean more complex + more bloated :-( This is quite disappointing ... Isn't that always true? :-) You need to add new features but cannot remove old ones. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Kin-Man Chung wrote: Date: Fri, 21 Feb 2003 19:16:46 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: [5.0.1] Tagging today To: Tomcat Developers List [EMAIL PROTECTED] Costin Manolache wrote: Kin-Man Chung wrote: I also don't believe jsp-examples has been successful compiled with JSPC before. I know haven't tried that with JSP2.0 examples. With automatic compiling of the tag files, I won't be surprise if there are problems. :) It doesn't matter what it's for - if it is valid JSP it should compile with jspc the same as with jspservlet :-). If it's not valid - it should be removed... I tried to look into the issue, but it's quite complex :-( I have just committed a fix for using JSPC to compile JSP pages that uses tag files. The complication comes from the need to compile tag files into class objects before a JSP page that references them can be compiled. I don't know a better strategy for precompiling an application would be to first compile all the tag files first, then compile the JSP pages after that. The added complication is that a tag file may use other tag files, or even be circularly dependent. Yes, I understood the purpose of the code (but not really the code itself). I don't like that new spec feature, overall. Same for the ability to put the TLD in random places. It's supposed to help page authors that are not programmers. But if a seasoned programmer find tag files hard to use, it's not a good sign. No, it's easy to use. The problem is that I don't quite see the point, and on the implementation side, it gets nasty ;-) It seems the new spec revisions mean more complex + more bloated :-( This is quite disappointing ... Isn't that always true? :-) You need to add new features but cannot remove old ones. Yes, it's always true. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Kin-Man Chung wrote: It seems the new spec revisions mean more complex + more bloated :-( This is quite disappointing ... Isn't that always true? :-) You need to add new features but cannot remove old ones. You can allways side-step and create a new specification for the new features. The reality is that nobody ( person or expert group ) can predict how a spec will be used and create something perfect. Tag libraries are good - but we know that it is possible to have a much simpler model for the simple case, we can probably make the complex case much more efficient ( code generation ). And it is possible to still support the original spec with a wrapper - or leave it as it is and direct people to the new spec. Like NIO did for java.io. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). I'd need a Win9x compatible version of procrun to make the release, also :) I will try to test and fix the win9x code. But the only win9x machine I have here is _very_ slow. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Remy Maucherat wrote: From my experience, Tomcat 5.0.1 doesn't appear to have any critical issue remaining. I plan to put the 5.0.1 tag later today and release alpha binaries. Remy Will you put the necessary source/binaries in : http://jakarta.apache.org/builds/jakarta-tomcat/ or may be better http://jakarta.apache.org/builds/jakarta-tomcat-5/ So I could try to make a rpm of it ;) Regards BTW, we'll need also jakarta-servletapi-5 somewhere. Regards (back to work) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Clere, Jean-Frederic wrote: Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). I'd need a Win9x compatible version of procrun to make the release, also :) I will try to test and fix the win9x code. The test shows it it is not OK. I will now look for a fix. But the only win9x machine I have here is _very_ slow. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... -- Jeanfrancois build-static: [copy] Copying 1 file to /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/server/webapps/admin [copy] Copying 1 file to /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/server/webapps/admin/WEB-INF/classes/org/apache/webapp/admin build-main: [javac] Compiling 1 source file to /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/server/webapps/admin/WEB-INF/classes [mkdir] Created dir: /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/server/webapps/admin/WEB-INF/src/admin [mkdir] Created dir: /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/webapps/ROOT/WEB-INF/src [mkdir] Created dir: /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/webapps/ROOT/WEB-INF/classes [mkdir] Created dir: /disk/raid0/home/jfarcand/jakarta-tomcat/jakarta-tomcat-5/build/webapps/jsp-examples/WEB-INF/src [jasper2] org.apache.jasper.JasperException: XML parsing error on file /WEB-INF/lib/standard.jar: (line 307, col 39) [jasper2] at org.apache.jasper.compiler.TldLocationsCache.processTldsInJar(TldLocationsCache.java:302) [jasper2] at org.apache.jasper.compiler.TldLocationsCache.processJars(TldLocationsCache.java:239) [jasper2] at org.apache.jasper.compiler.TldLocationsCache.init(TldLocationsCache.java:171) [jasper2] at org.apache.jasper.compiler.TldLocationsCache.getLocation(TldLocationsCache.java:392) [jasper2] at org.apache.jasper.JspCompilationContext.getTldLocation(JspCompilationContext.java:534) [jasper2] at org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:447) [jasper2] at org.apache.jasper.compiler.Parser.parseDirective(Parser.java:504) [jasper2] at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1541) [jasper2] at org.apache.jasper.compiler.Parser.parse(Parser.java:164) [jasper2] at org.apache.jasper.compiler.ParserController.parse(ParserController.java:270) [jasper2] at org.apache.jasper.compiler.ParserController.parse(ParserController.java:155) [jasper2] at org.apache.jasper.compiler.ParserController.parse(ParserController.java:142) [jasper2] at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:243) [jasper2] at org.apache.jasper.JspC.processFile(JspC.java:572) [jasper2] at org.apache.jasper.JspC.execute(JspC.java:808) [jasper2] at java.lang.reflect.Method.invoke(Native Method) [jasper2] at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:147) [jasper2] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:166) [jasper2] at org.apache.tools.ant.Task.perform(Task.java:319) [jasper2] at org.apache.tools.ant.Target.execute(Target.java:309) [jasper2] at org.apache.tools.ant.Target.performTasks(Target.java:336) [jasper2] at org.apache.tools.ant.Project.executeTarget(Project.java:1306) [jasper2] at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:371) [jasper2] at org.apache.tools.ant.Task.perform(Task.java:319) [jasper2] at org.apache.tools.ant.Target.execute(Target.java:309) [jasper2] at org.apache.tools.ant.Target.performTasks(Target.java:336) [jasper2] at org.apache.tools.ant.Project.executeTarget(Project.java:1306) [jasper2] at org.apache.tools.ant.Project.executeTargets(Project.java:1250) [jasper2] at org.apache.tools.ant.Main.runBuild(Main.java:610) [jasper2] at org.apache.tools.ant.Main.start(Main.java:196) [jasper2] at org.apache.tools.ant.Main.main(Main.java:235) [jasper2] [ERROR] TldLocationsCache - -Exception initializing TldLocationsCache org.apache.jasper.JasperException: XML parsing error on file /WEB-INF/lib/standard.jar: (line 307, col 39) [jasper2] org.apache.jasper.JasperException: XML parsing error on file /WEB-INF/jsp/example-taglib.tld: (line 307, col 39) [jasper2] at org.apache.jasper.xmlparser.ParserUtils.parseXMLDocument(ParserUtils.java:145) [jasper2] at org.apache.jasper.compiler.TagLibraryInfoImpl.parseTLD(TagLibraryInfoImpl.java:255) [jasper2] at org.apache.jasper.compiler.TagLibraryInfoImpl.init(TagLibraryInfoImpl.java:197) [jasper2] at org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:448) [jasper2] at org.apache.jasper.compiler.Parser.parseDirective(Parser.java:504) [jasper2] at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1541) [jasper2] at org.apache.jasper.compiler.Parser.parse(Parser.java:164) [jasper2] at org.apache.jasper.compiler.ParserController.parse(ParserController.java:270) [jasper2] at org.apache.jasper.compiler.ParserController.parse(ParserController.java:155) [jasper2] at org.apache.jasper.compiler.ParserController.parse(ParserController.java:142) [jasper2] at
Re: [5.0.1] Tagging today
Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). I'd need a Win9x compatible version of procrun to make the release, also :) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). +1 for fixing the bug too - but I don't know how :-) It seems to be introduced by one of the recent changes - I had no problem compiling the admin few weeks ago. We either roll back the change or find another way. One thing should be clear - precompiled jsps should be included with tomcat5 and we should strongly recommend ( and support ) this mode for production sites. For development it is normal to compile the page, but doing the compilation on a production server is really bad idea. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Costin Manolache wrote: Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). +1 for fixing the bug too - but I don't know how :-) It seems to be introduced by one of the recent changes - I had no problem compiling the admin few weeks ago. We either roll back the change or find another way. The bug happens in the jsp-examples precompilation (which is supposed to work also, right ?). One of the tag examples apparently causes problems. One thing should be clear - precompiled jsps should be included with tomcat5 and we should strongly recommend ( and support ) this mode for production sites. For development it is normal to compile the page, but doing the compilation on a production server is really bad idea. +1. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Date: Tue, 18 Feb 2003 21:46:54 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: [5.0.1] Tagging today To: Tomcat Developers List [EMAIL PROTECTED] Costin Manolache wrote: Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). +1 for fixing the bug too - but I don't know how :-) It seems to be introduced by one of the recent changes - I had no problem compiling the admin few weeks ago. We either roll back the change or find another way. The bug happens in the jsp-examples precompilation (which is supposed to work also, right ?). One of the tag examples apparently causes problems. The strange thing is the error hapeened with source.jsp, which is not one of the exmaples. Do you guys know what it's for? I also don't believe jsp-examples has been successful compiled with JSPC before. I know haven't tried that with JSP2.0 examples. With automatic compiling of the tag files, I won't be surprise if there are problems. :) One thing should be clear - precompiled jsps should be included with tomcat5 and we should strongly recommend ( and support ) this mode for production sites. For development it is normal to compile the page, but doing the compilation on a production server is really bad idea. +1. +1 from me too. However, is Jspc good enough now? Are there areas that need to be fixed? We should not make this a requirement for tomcat5 and recommand such a practice until it is good enough. For now we should just turn off precompilation of the examples until the problem is identified and fixed. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Kin-Man Chung wrote: Date: Tue, 18 Feb 2003 21:46:54 +0100 From: Remy Maucherat [EMAIL PROTECTED] Subject: Re: [5.0.1] Tagging today To: Tomcat Developers List [EMAIL PROTECTED] Costin Manolache wrote: Remy Maucherat wrote: Costin Manolache wrote: Remy Maucherat wrote: Jeanfrancois Arcand wrote: Are you able to build it? The nightly build failled with the following (see below). I will look at the failure latter this afternoon... It's a hint that there are urgent bugs to fix in either JspC or Jasper, which make precompilation fail (read my commit massage to see the full story) ;-) Well, we can't release a milestone with both gump and normal build failing. At this point disabling the precompilation seems the best short-term workaround, but I think we should rather wait with the milestone until the fix is available. That's reasonable. +1 for fixing the bugs (I tried a bit and failed). +1 for fixing the bug too - but I don't know how :-) It seems to be introduced by one of the recent changes - I had no problem compiling the admin few weeks ago. We either roll back the change or find another way. The bug happens in the jsp-examples precompilation (which is supposed to work also, right ?). One of the tag examples apparently causes problems. The strange thing is the error hapeened with source.jsp, which is not one of the exmaples. Do you guys know what it's for? It's actually in \jsp2\tagfiles\panel.jsp. I also don't believe jsp-examples has been successful compiled with JSPC before. I know haven't tried that with JSP2.0 examples. With automatic compiling of the tag files, I won't be surprise if there are problems. :) One thing should be clear - precompiled jsps should be included with tomcat5 and we should strongly recommend ( and support ) this mode for production sites. For development it is normal to compile the page, but doing the compilation on a production server is really bad idea. +1. +1 from me too. However, is Jspc good enough now? Are there areas that need to be fixed? We should not make this a requirement for tomcat5 and recommand such a practice until it is good enough. For now we should just turn off precompilation of the examples until the problem is identified and fixed. Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.1] Tagging today
Kin-Man Chung wrote: It seems to be introduced by one of the recent changes - I had no problem compiling the admin few weeks ago. We either roll back the change or find another way. The bug happens in the jsp-examples precompilation (which is supposed to work also, right ?). One of the tag examples apparently causes problems. The strange thing is the error hapeened with source.jsp, which is not one of the exmaples. Do you guys know what it's for? I also don't believe jsp-examples has been successful compiled with JSPC before. I know haven't tried that with JSP2.0 examples. With automatic compiling of the tag files, I won't be surprise if there are problems. :) It doesn't matter what it's for - if it is valid JSP it should compile with jspc the same as with jspservlet :-). If it's not valid - it should be removed... One thing should be clear - precompiled jsps should be included with tomcat5 and we should strongly recommend ( and support ) this mode for production sites. For development it is normal to compile the page, but doing the compilation on a production server is really bad idea. +1. +1 from me too. However, is Jspc good enough now? Are there areas that need to be fixed? We should not make this a requirement for tomcat5 and recommand such a practice until it is good enough. For now we should just turn off precompilation of the examples until the problem is identified and fixed. It's not a requirement for tomcat5 - people can use whatever they want. Our examples and the admin and all jsps we ship should be precompiled - it is a very bad example if the first time you load hello.jsp it takes 1 minute. If people add a jsp to the examples - it will be compiled by jspservet and will work as before. Jspc works fine - the generated code is exactly the same as with JspServlet. I used it with pretty complex apps ( with 4.1 ). The only problem that jspc may have is that a lot of the development on jasper is done using jspservlet, and far less testing is done on jspc - and if we start precompiling it'll be more likely the problems will be fixed. The difference is just in the calling environment. BTW, IMO it is also much better for the code stability - as changes are made to jasper, knowing that all admin and examples compile is a good test. Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
