Re: [tor-bugs] #33867 [Applications/Tor Browser]: Disable password manager and password generation

[Tor Bug Tracker & Wiki]

#33867: Disable password manager and password generation
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 The password generation feature is also disabled when
 `signon.rememberSignons` = `false` which we already set in
 browser/app/profile/000-tor-browser.js.

 I am leaving this ticket open so we double-check this one more time in
 case Mozilla makes more changes before ESR78. Useful references:
 * https://searchfox.org/mozilla-central/search?q=generationEnabled=
 * https://searchfox.org/mozilla-
 central/search?q=getLoginSavingEnabled=LoginManager.jsm
 * https://searchfox.org/mozilla-
 central/search?q=.enabled+%3D=LoginHelper.jsm

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33924 [Core Tor/Tor]: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS

[Tor Bug Tracker & Wiki]

#33924: Tor beginning with 0.4.1 seems to ignore SIGNAL SHUTDOWN on iOS
--+
 Reporter:  tla   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.7
 Severity:  Major | Resolution:  duplicate
 Keywords:  backport? |  Actual Points:
Parent ID:  #33087| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  new => closed
 * resolution:   => duplicate
 * parent:   => #33087


Comment:

 This is a duplicate of #33087 and is fixed if Tor.framework bumps its Tor
 version to the recently released Tor tag `tor-0.4.3.5`.

 The problem was solved by Teor and is caused by Tor by mistake closing
 standard error. When something would write to standard error after Tor has
 terminated, the program would crash.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33866 [Applications/Tor Browser]: Add Onion Service info to new cert viewer

[Tor Bug Tracker & Wiki]

#33866: Add Onion Service info to new cert viewer
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 As Kathy and I understand it, the patch for #23247 added "Onion Service"
 to the "Technical Details" section of the Page Info window's Security
 panel and did not modify the certificate viewer itself. If that is
 accurate, there is nothing to do here because that panel appears to be
 unchanged in post-ESR68 Firefox... at least for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

[Tor Bug Tracker & Wiki]

#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--+
 Reporter:  acat  |  Owner:  acat
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:  14
Parent ID:  #33661| Points:
 Reviewer:  sysrqb, gk|Sponsor:  Sponsor58-must
--+

Comment (by mcs):

 Kathy and I noticed today that there is a bug in the rebased #23247 patch
 (5defe271e8919e77267883f8513cf095451fffd2) that causes the Page Info
 window's Security panel to not display all of its content. The root cause
 is that Mozilla removed `hostName` inside `_getSecurityInfo()` within
 browser/base/content/pageinfo/security.js. Here is a fixup patch:
 {{{
  var isBroken = ui.state & Ci.nsIWebProgressListener.STATE_IS_BROKEN;
  var isMixed =
ui.state &
(Ci.nsIWebProgressListener.STATE_LOADED_MIXED_ACTIVE_CONTENT |
  Ci.nsIWebProgressListener.STATE_LOADED_MIXED_DISPLAY_CONTENT);
  var isEV = ui.state &
 Ci.nsIWebProgressListener.STATE_IDENTITY_EV_TOPLEVEL;
  var isOnion = false;
 +const hostName = this.windowInfo.hostName;
  if (hostName && hostName.endsWith(".onion")) {
isOnion = true;
  }

  let secInfo = await
 
window.opener.gBrowser.selectedBrowser.browsingContext.currentWindowGlobal.getSecurityInfo();
  if (secInfo) {
secInfo.QueryInterface(Ci.nsITransportSecurityInfo);
let cert = secInfo.serverCert;
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34126 [Circumvention/Snowflake]: Handle onicecandidate firing after connection closed

[Tor Bug Tracker & Wiki]

#34126: Handle onicecandidate firing after connection closed
-+
 Reporter:  arlolra  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
-+

Comment (by arlolra):

 Fixed in https://github.com/node-webrtc/node-webrtc/pull/625 and should be
 in the next release, at which point we can revert the above patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33865 [Applications/Tor Browser]: Maybe disable all auto-play

[Tor Bug Tracker & Wiki]

#33865: Maybe disable all auto-play
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 Making all media click-to-play on Tor Browser's Standard security level is
 a departure from Firefox's default behavior and might surprise some
 people. However, as Richard said, doing so might make sense from a network
 load point of view.

 We would need to verify that setting `media.autoplay.default` to `5` does
 not interact badly with NoScript's "click to play" logic (currently
 enabled on our Safer and Safest security levels).

 Possibly related: #22985

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33856 [Applications/Tor Browser]: Set browser.privatebrowsing.forceMediaMemoryCache=true

[Tor Bug Tracker & Wiki]

#33856: Set browser.privatebrowsing.forceMediaMemoryCache=true
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 To be consistent with the behavior of our ESR68-based Tor Browser, we
 should add the following lines to 000-tor-browser.js:
 {{{
 // Use the in-memory media cache and increase its maximum size (#29120)
 pref("browser.privatebrowsing.forceMediaMemoryCache", true);
 pref("media.memory_cache_max_size", 16384);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30832 [Applications/Tor Browser]: Fix tor-browser tbb-tests

[Tor Bug Tracker & Wiki]

#30832: Fix tor-browser tbb-tests
-+-
 Reporter:  acat |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ReleaseTrainMigration|  Actual Points:  3
  TorBrowserTeam202005R  |
Parent ID:  #33654   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by acat):

 * reviewer:   => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27105 [Applications/Quality Assurance and Testing]: Fix Tor Browser testsuite

[Tor Bug Tracker & Wiki]

#27105: Fix Tor Browser testsuite
-+-
 Reporter:  boklm|  Owner:  acat
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-testsuite,   |  Actual Points:
  TorBrowserTeam202005R, ReleaseTrainMigration   |
Parent ID:  #33654   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by acat):

 * reviewer:   => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34242 [Applications/Tor Browser]: Creating containers for Linux targets is busted due to outdated apt

[Tor Bug Tracker & Wiki]

#34242: Creating containers for Linux targets is busted due to outdated apt
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202005R,  |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Patch looks good, and sha256 hashes confirmed. Thanks!

 Merged with commit `e202334a89191016e6419fe5cbedd965727b3103`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 This is only an issue if someone flips the hidden pref
 `browser.ssb.enabled` to `true`. The tracking bug for the site-specific
 browsing feature is:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1602117
 If we are worried about someone playing with this loaded gun we could stub
 out the `applyOSIntegration()` function in
 browser/components/ssb/WindowsSupport.jsm but it seems okay to ignore this
 for now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review
 * reviewer:  sysrqb => sysrqb, ahf


Comment:

 This should be in `needs_review`. The commit has not changed. The latest
 version is on `bug_33559_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33559_v2=541eb200e06c1c55ab3c8facdfd02a9ae70e)
 (among other branches)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27105 [Applications/Quality Assurance and Testing]: Fix Tor Browser testsuite

[Tor Bug Tracker & Wiki]

#27105: Fix Tor Browser testsuite
-+-
 Reporter:  boklm|  Owner:  acat
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-testsuite,   |  Actual Points:
  TorBrowserTeam202005R, ReleaseTrainMigration   |
Parent ID:  #33654   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by acat):

 This can be tested with a `testbuild-linux-x86_64` build from the
 https://github.com/acatarineu/tor-browser-build/commits/33533+6 branch
 (`d88a471e4d2f5e6e91361e09e00a9480a4089b23`), and command `./tbb-testsuite
 --no-xdummy /path/to/tor-browser.xz`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33556 [Applications/Tor Browser]: Add TBB project for android-components

[Tor Bug Tracker & Wiki]

#33556: Add TBB project for android-components
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-team (added)
 * owner:  tbb-team => gk
 * status:  needs_revision => assigned
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005
 * reviewer:  gk => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33559 [Applications/Tor Browser]: Update tor-android-service To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33559: Update tor-android-service To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  assigned => needs_review


Comment:

 `bug_33559_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33559_v2=91d98030ede7dbe2b3f38d2eeed97fc70110d15b)
 contains a patch for review.

 The branch contains an additional patch, commit
 `d356f1a34ddf4054b4605bb1f4886bf19dcacb73`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33559_v2=d356f1a34ddf4054b4605bb1f4886bf19dcacb73)
 which points to my `tor-android-service` branch (`bug_33559`) to get
 things building. That branch (https://gitweb.torproject.org/user/gk/tor-
 android-
 service.git/commit/?h=bug_33559=80db85213ea4af1a7976531ecbba94e521d6efbd)
 needs review as well.

 I cleaned a bunch of things up while I was at it as it seemed to me those
 artifacts are not needed anymore. In particular, I got rid off
 `libtun2socks.so` which I think we don't need for our use-case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33854 [Applications/Tor Browser]: Spoof Network ID

[Tor Bug Tracker & Wiki]

#33854: Spoof Network ID
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 Additional references:
 * https://bugzilla.mozilla.org/show_bug.cgi?id=1550605
 * https://github.com/acatarineu/tor-
 browser/blob/33533%2B5/netwerk/base/nsINetworkLinkService.idl#L49
 * https://github.com/acatarineu/tor-
 browser/blob/33533%2B5/netwerk/system/netlink/NetlinkService.cpp#L1731
 (`CalculateNetworkID()` method).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33854 [Applications/Tor Browser]: Spoof Network ID

[Tor Bug Tracker & Wiki]

#33854: Spoof Network ID
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 The network ID is visible at about:networking#networkid. It is also
 exposed to privileged WebExtensions (see
 toolkit/components/extensions/parent/ext-networkStatus.js), probably to
 support the Firefox Private Network (VPN) feature. Because the network ID
 is not exposed to web content or even regular WebExtensions, maybe we
 should just leave it as-is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34164 [Applications/Tor Launcher]: Tor Launcher hangs with 33533+5 branch

[Tor Bug Tracker & Wiki]

#34164: Tor Launcher hangs with 33533+5 branch
+-
 Reporter:  acat|  Owner:  brade
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff78-esr TorBrowserTeam202005R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  acat|Sponsor:
+-
Changes (by acat):

 * reviewer:   => acat


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34206 [Applications/Tor Launcher]: Tor Launcher button labels are missing (Firefox 76)

[Tor Bug Tracker & Wiki]

#34206: Tor Launcher button labels are missing (Firefox 76)
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ReleaseTrainMigration,   |  Actual Points:
  TorBrowserTeam202005R, ff78-esr|
Parent ID:   | Points:
 Reviewer:  acat |Sponsor:
-+-
Changes (by acat):

 * reviewer:   => acat


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34209 [Applications/Tor Browser]: about:tor and about:tbupdate fail to load in debug build of Tor Browser

[Tor Bug Tracker & Wiki]

#34209: about:tor and about:tbupdate fail to load in debug build of Tor Browser
--+---
 Reporter:  mcs   |  Owner:  mcs
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:  #33533| Points:
 Reviewer:  acat  |Sponsor:  Sponsor58-can
--+---
Changes (by acat):

 * reviewer:   => acat


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32537 [Applications/Quality Assurance and Testing]: Update marionette version used in tor browser testsuite, for ESR78

[Tor Bug Tracker & Wiki]

#32537: Update marionette version used in tor browser testsuite, for ESR78
-+-
 Reporter:  boklm|  Owner:  acat
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  ReleaseTrainMigration|  Actual Points:
  TorBrowserTeam202005R  |
Parent ID:  #33654   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58
-+-
Changes (by acat):

 * status:  needs_review => new


Comment:

 Doing this in #27105.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34164 [Applications/Tor Launcher]: Tor Launcher hangs with 33533+5 branch

[Tor Bug Tracker & Wiki]

#34164: Tor Launcher hangs with 33533+5 branch
+-
 Reporter:  acat|  Owner:  brade
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff78-esr TorBrowserTeam202005R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+-
Changes (by acat):

 * status:  needs_review => merge_ready


Comment:

 Ok to merge in a esr78 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34206 [Applications/Tor Launcher]: Tor Launcher button labels are missing (Firefox 76)

[Tor Bug Tracker & Wiki]

#34206: Tor Launcher button labels are missing (Firefox 76)
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ReleaseTrainMigration,   |  Actual Points:
  TorBrowserTeam202005R, ff78-esr|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  ReleaseTrainMigration, TorBrowserTeam202005R =>
 ReleaseTrainMigration, TorBrowserTeam202005R, ff78-esr
 * sponsor:  Sponsor58-can =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34013 [Applications/Tor Browser]: Bump node version to v10.19

[Tor Bug Tracker & Wiki]

#34013: Bump node version to v10.19
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33932 [Applications/Tor Browser]: Improve steps for creating gradle dependencies lists for projects

[Tor Bug Tracker & Wiki]

#33932: Improve steps for creating gradle dependencies lists for projects
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-maint,  |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202004   |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34206 [Applications/Tor Launcher]: Tor Launcher button labels are missing (Firefox 76)

[Tor Bug Tracker & Wiki]

#34206: Tor Launcher button labels are missing (Firefox 76)
-+-
 Reporter:  mcs  |  Owner:  brade
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Normal   | Resolution:
 Keywords:  ReleaseTrainMigration,   |  Actual Points:
  TorBrowserTeam202005R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-can
-+-
Changes (by acat):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34209 [Applications/Tor Browser]: about:tor and about:tbupdate fail to load in debug build of Tor Browser

[Tor Bug Tracker & Wiki]

#34209: about:tor and about:tbupdate fail to load in debug build of Tor Browser
--+---
 Reporter:  mcs   |  Owner:  mcs
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:  #33533| Points:
 Reviewer:|Sponsor:  Sponsor58-can
--+---
Changes (by acat):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33932 [Applications/Tor Browser]: Improve steps for creating gradle dependencies lists for projects

[Tor Bug Tracker & Wiki]

#33932: Improve steps for creating gradle dependencies lists for projects
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-maint,  |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202004   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * sponsor:   => Sponsor58-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #33558, #33561, #33563, #33564, ...

[Tor Bug Tracker & Wiki]

Batch modification to #33558, #33561, #33563, #33564, #33626, #33760, #33973, 
#34011, #34012, #34013, #34014, #34187 by gk:
sponsor to Sponsor58-must

Comment:
sponsor58-must

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33534 [Applications/Tor Browser]: Review FF release notes from FF69 to latest (FF75)

[Tor Bug Tracker & Wiki]

#33534: Review FF release notes from FF69 to latest (FF75)
--+
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  20
Parent ID:  #33661| Points:
 Reviewer:|Sponsor:  Sponsor58-must
--+
Changes (by sysrqb):

 * owner:  (none) => tbb-team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34196 [Applications/Tor Browser]: Update site info URL with the onion name

[Tor Bug Tracker & Wiki]

#34196: Update site info URL with the onion name
---+--
 Reporter:  antonela   |  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  ux-team TorBrowserTeam202005R  |  Actual Points:
Parent ID: | Points:
 Reviewer:  sysrqb, antonela   |Sponsor:
---+--

Comment (by antonela):

 \o/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34196 [Applications/Tor Browser]: Update site info URL with the onion name

[Tor Bug Tracker & Wiki]

#34196: Update site info URL with the onion name
---+--
 Reporter:  antonela   |  Owner:  tbb-team
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  ux-team TorBrowserTeam202005R  |  Actual Points:
Parent ID: | Points:
 Reviewer:  sysrqb, antonela   |Sponsor:
---+--
Changes (by sysrqb):

 * keywords:  ux-team TorBrowser202005R => ux-team TorBrowserTeam202005R
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks acat!

 I merged the torbrowser fixup with commit
 `a87a532c070322f8ba252da6a577c872d07d53b3`, and the torbutton patch with
 `96321fdd1715f52cab00f6654ebc8fb420a5489d`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33435 [Metrics/Onionperf]: Document BASETORRC environment variable

[Tor Bug Tracker & Wiki]

#33435: Document BASETORRC environment variable
---+
 Reporter:  acute  |  Owner:  phw
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.2
Parent ID: | Points:  0.2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by phw):

 * actualpoints:  0.1 => 0.2


Comment:

 Adding my 0.1 actual points.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27105 [Applications/Quality Assurance and Testing]: Fix Tor Browser testsuite

[Tor Bug Tracker & Wiki]

#27105: Fix Tor Browser testsuite
-+-
 Reporter:  boklm|  Owner:  acat
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-testsuite,   |  Actual Points:
  TorBrowserTeam202005R, ReleaseTrainMigration   |
Parent ID:  #33654   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by acat):

 * keywords:  tbb-testsuite, TorBrowserTeam202004, ReleaseTrainMigration =>
 tbb-testsuite, TorBrowserTeam202005R, ReleaseTrainMigration
 * status:  assigned => needs_review


Comment:

 Marking this for review, but note that followup work will be needed, for
 77b->78esr, and to address the remaining issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

[Tor Bug Tracker & Wiki]

#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.25
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by phw):

 * status:  needs_review => merge_ready
 * actualpoints:   => 0.25


Comment:

 Replying to [comment:7 acute]:
 > I've pushed a minor fixup commit onto my github branch to remove the
 duplication of the requirements:
 >
 > https://github.com/ana-
 cc/onionperf/commit/893306c97bff0526c42ee97dda789ebf310304be.patch
 >
 > With this applied, it is good to merge. Phw, if you are happy with this
 you can set this to merge-ready!
 [[br]]
 That's a useful patch, thanks! I force-pushed it to my GitHub branch,
 making this ready for merge now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27105 [Applications/Quality Assurance and Testing]: Fix Tor Browser testsuite

[Tor Bug Tracker & Wiki]

#27105: Fix Tor Browser testsuite
-+-
 Reporter:  boklm|  Owner:  acat
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Quality Assurance and   |Version:
  Testing|
 Severity:  Normal   | Resolution:
 Keywords:  tbb-testsuite,   |  Actual Points:
  TorBrowserTeam202004, ReleaseTrainMigration|
Parent ID:  #33654   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by acat):

 I think it might be better to do all reviewing/followup here instead of
 all the N different children, but I'm not sure.

 For now, here is a branch https://github.com/acatarineu/tor-browser-
 bundle-testsuite/commits/27105 fixing several tests, mostly targeting a
 `33533+5` build (based on mozilla-beta 77). I only tested locally
 (linux64) via `./tbb-testsuite --no-xdummy` command. Note: the fix for
 #34250 is needed for several tests to pass. This will need to be ongoing
 work, in parallel to #33533, as we still have to do more rebases until
 esr78.

 There are a couple of tests (`noscript`, `https-everywhere`) which I
 enabled and partially fixed but do not work completely yet. For
 `noscript`, I suspect this might be a regression of `33533`, since the
 test passes with a `tor-browser-linux64-9.0.10_en-US.tar.xz` build (with
 the #34250 fix). I'll create a ticket to investigate that. For `https-
 everywhere` test, it seems to be flaky, as it usually works when tests are
 run with `./tbb-testsuite --no-xdummy --enable-tests tor_bootstrap,https-
 everywhere`, but usually doesn't when the full testsuite is run. I could
 not find out yet why `https-everywhere` is not redirecting to `https` for
 the test page in some cases, but I guess further investigation can be done
 later in #30431.

 Apart from this I think this should also be tested in the other platforms
 we support, as I only tried in linux64. I could try locally for Windows,
 but not sure about macosx. Do we still have a test server that we could
 use for this?

 I also think it would make sense to start moving some of the tests to
 `tor-browser.git` repo, at least the `marionette` ones. We currently can't
 test the full browser there, but we could try to make changes so that
 something close enough to "full" tor-browser is built from `tor-
 browser.git` to allow tests to pass (and be helpful). For me, I can see
 at least two reasons why this would be helpful.

 A couple of questions wrt the changes I made (or not made):

 * Added `TorBrowser/Tor/PluggableTransports/snowflake-client` to
 exceptions in `Fix readelf_RELRO test` and `Fix readelf_stack_canary
 test`, is this expected to be needed?

 * Added `updater` to exceptions in `Fix readelf_no_rpath test`, is this
 fine, or should we do something about it?

 * I did not try to enable `fpcentral`, as I'm not sure if we are going to
 maintain that?

 * I did not try to enable `acid3`, not sure if it's helpful as it is now,
 but maybe we could "pin" it's state via a screenshot to track changes
 between versions?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

[Tor Bug Tracker & Wiki]

#34250: Fix torbutton noscript-control race condition
--+-
 Reporter:  acat  |  Owner:  acat
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by acat):

 I think it's perfectly fine delaying this, it's not very likely that this
 issue happens in practice for users.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

[Tor Bug Tracker & Wiki]

#33974: Update OnionPerf to TGen 1.0.0
---+
 Reporter:  karsten|  Owner:  jnewsome
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by jnewsome):

 * owner:  metrics-team => jnewsome


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

[Tor Bug Tracker & Wiki]

#34250: Fix torbutton noscript-control race condition
--+-
 Reporter:  acat  |  Owner:  acat
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by sysrqb):

 How risky is this patch? I'm concerned we are very near declaring 9.5 as
 Stable, and this is fixing a race-condition for which we haven't received
 any reports from users. I'm leaning towards delaying this until 10.0a1. Do
 you disagree?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33812 [Core Tor/Tor]: Add unit tests for bandwidth statistics functions

[Tor Bug Tracker & Wiki]

#33812: Add unit tests for bandwidth statistics functions
---+---
 Reporter:  MrSquanchee|  Owner:  MrSquanchee
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33617 | Points:  2
 Reviewer:  ahf|Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Thanks to both of you for your suggestions, I have added your suggestions
 in the PR.
 I think, we are done with it now.

 https://github.com/torproject/tor/pull/1853

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34253 [Applications/GetTor]: GetTor should set In-Reply-To when responding to email

[Tor Bug Tracker & Wiki]

#34253: GetTor should set In-Reply-To when responding to email
-+
 Reporter:  phw  |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/GetTor  |Version:
 Severity:  Minor|   Keywords:
Actual Points:   |  Parent ID:
   Points:  0.5  |   Reviewer:
  Sponsor:   |
-+
 GetTor currently doesn't set the `In-Reply-To` header when responding to
 an email. That breaks threading in the user's mailbox and it also makes it
 slightly more difficult to test our autoresponder.

 It's not high priority but let's add the `In-Reply-To` header at some
 point.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33853 [Applications/Tor Browser]: Disable What's New? feature

[Tor Bug Tracker & Wiki]

#33853: Disable What's New? feature
--+---
 Reporter:  pospeselr |  Owner:  tbb-team
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ux-team   |  Actual Points:
Parent ID:  #33534| Points:
 Reviewer:|Sponsor:  Sponsor58
--+---

Comment (by mcs):

 It seems that acat's #31575 patch disables all of this functionality.
 Specifically, with that patch in place `ToolbarPanelHub.init()` is not
 called, which means that the "What's New?" toolbar item and the app menu
 item are not visible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

[Tor Bug Tracker & Wiki]

#33626: Add TBB project for GeckoView
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:  sysrqb => sysrqb, ahf


Comment:

 Branch bug_33626_v11 looks good, and was reviewed as part of #33973.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33435 [Metrics/Onionperf]: Document BASETORRC environment variable

[Tor Bug Tracker & Wiki]

#33435: Document BASETORRC environment variable
---+
 Reporter:  acute  |  Owner:  phw
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.1
Parent ID: | Points:  0.2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * cc: metrics-team (added)
 * status:  merge_ready => closed
 * points:  0.3 => 0.2
 * resolution:   => fixed
 * actualpoints:   => 0.1


Comment:

 Oh, I hadn't seen that this is ready to be merged. I guess we need to copy
 metrics-team in order to get updates sent to metrics-bugs@.

 Rebased and pushed to master!

 I agree that having documentation in several places is a bit confusing.
 That is on my list, but I'll create a ticket to discuss any changes before
 making them.

 Moving acute's 0.2 actual points to the Actual Points field (yes, that is
 confusing). phw, please add any actual points of yours to those.

 Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

[Tor Bug Tracker & Wiki]

#33973: Create fat .aar for geckoview
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 The proposed changes seems to work. I have been able to build it
 reproducible on two different machines and learned about a hw issue on a
 third machine. It sounds like I got the same results as GeKo, which is
 good. I have not tried to build with _v8, but only with _v7, but it seems
 like _v8 is fixing the one issue I had with 'container-image'.

 The perl/bash and yaml all seems good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34163 [Applications/Tor Browser]: testbuild target is broken for Tor Browser 64 bit (versionCode can't get computed) (was: testbuild target is broken for Tor Browser aarch64 (versionCo

[Tor Bug Tracker & Wiki]

#34163: testbuild target is broken for Tor Browser 64 bit (versionCode can't get
computed)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, ff78-esr-will-  |  Actual Points:
  have   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: sysrqb (added)
 * keywords:  tbb-rbm, ff78-esr-will-have => tbb-rbm, tbb-mobile, ff78-esr-
 will-have


Comment:

 #34252 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34252 [Applications/Tor Browser]: Fix Android x86_64 testbuild

[Tor Bug Tracker & Wiki]

#34252: Fix Android x86_64 testbuild
--+---
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Yeah, I hit that, too, #34163.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34252 [Applications/Tor Browser]: Fix Android x86_64 testbuild

[Tor Bug Tracker & Wiki]

#34252: Fix Android x86_64 testbuild
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 In #32788, we began using a constant build date in the testbuild.
 Unfortunately, on Android x86_64 (and I assume aarch64), we hit:

 {{{
  0:02.07 Traceback (most recent call last):
  0:02.07   File "/usr/lib/python2.7/runpy.py", line 174, in
 _run_module_as_main
  0:02.07 "__main__", fname, loader, pkg_name)
  0:02.07   File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
  0:02.07 exec code in run_globals
  0:02.07   File "/var/tmp/build/firefox-
 4acec7610371/python/mozbuild/mozbuild/action/file_generate.py", line 120,
 in 
  0:02.07 sys.exit(main(sys.argv[1:]))
  0:02.07   File "/var/tmp/build/firefox-
 4acec7610371/python/mozbuild/mozbuild/action/file_generate.py", line 71,
 in main
  0:02.07 ret = module.__dict__[method](output,
 *args.additional_arguments, **kwargs)
  0:02.07   File "/var/tmp/build/firefox-
 4acec7610371/mobile/android/base/generate_build_config.py", line 145, in
 generate_android_manifest
  0:02.07 defines=_defines(),
  0:02.07   File "/var/tmp/build/firefox-
 4acec7610371/mobile/android/base/generate_build_config.py", line 129, in
 _defines
  0:02.07 max_sdk=max_sdk)
  0:02.07   File "/var/tmp/build/firefox-
 4acec7610371/python/mozbuild/mozbuild/android_version_code.py", line 140,
 in android_version_code
  0:02.07 return android_version_code_v0(buildid, *args, **kwargs)
  0:02.07   File "/var/tmp/build/firefox-
 4acec7610371/python/mozbuild/mozbuild/android_version_code.py", line 31,
 in android_version_code_v0
  0:02.07 "for CPU arch %s" % cpu_arch)
  0:02.07 ValueError: Don't know how to compute android:versionCode for CPU
 arch x86_64
  0:02.07 make[4]: *** [backend.mk:11: .deps/AndroidManifest.xml.stub]
 Error 1
  0:02.07 make[4]: Leaving directory '/var/tmp/build/firefox-4acec7610371
 /obj-x86_64-linux-android/mobile/android/base'
  0:02.07 make[3]: *** [/var/tmp/build/firefox-
 4acec7610371/config/recurse.mk:101: mobile/android/base/export] Error 2
  0:02.07 make[3]: *** Waiting for unfinished jobs...
 }}}
 ` 0:02.07 ValueError: Don't know how to compute android:versionCode for
 CPU arch x86_64`

 This is because the fixed build date (`20010101010101`) is less than
 `2015080100`, and this results in the Firefox build system using the
 old Android version code scheme which only supports x86 and armv7.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34125 [Applications/Tor Browser]: Fix torbutton proxy api due to change in Firefox 77.

[Tor Bug Tracker & Wiki]

#34125: Fix torbutton proxy api due to change in Firefox 77.
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff78-esr tbb-torbutton,  |  Actual Points:
  TorBrowserTeam202005R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

[Tor Bug Tracker & Wiki]

#34250: Fix torbutton noscript-control race condition
--+-
 Reporter:  acat  |  Owner:  acat
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by mcs):

 * status:  needs_review => merge_ready


Comment:

 r=brade, r=mcs
 The patch looks good. After reading the older tickets, it does seems as if
 "pageshow" was added to handle a theoretical situation that was not
 necessarily ever observed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33913 [Internal Services/Service - jenkins]: migrate rouyi to the ganeti cluster

[Tor Bug Tracker & Wiki]

#33913: migrate rouyi to the ganeti cluster
-+
 Reporter:  anarcat  |  Owner:  weasel
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - jenkins  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tpa-roadmap-may  |  Actual Points:
Parent ID:  #32802   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by hiro):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34251 [Core Tor/Tor]: Fix edge case handling in Rust protover is supported

[Tor Bug Tracker & Wiki]

#34251: Fix edge case handling in Rust protover is supported
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt, rust,|  Actual Points:  0.1
  protover, 042-backport, 043-backport   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * sponsor:   => Sponsor55-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:12 gk]:
 > One thing I still need to think about is:
 > {{{
 > There are some combinations of libraries, or tools and libraries, that
 are incompatible, or can lead to bugs. One such incompatibility is
 compiling with a version of the Android support libraries that is not the
 latest version (or in particular, a version lower than your
 targetSdkVersion).
 > }}}
 > (found at: https://stackoverflow.com/questions/53094716/implementation-
 com-android-supportappcompat-v728-0-0)
 >
 > We do set the `targetSdkVersion` to `29` while we have
 > {{{
 > dependencies {
 > implementation project(':universal')
 > implementation 'net.freehaven.tor.control:jtorctl:0.2'
 > implementation 'org.slf4j:slf4j-api:1.7.25'
 > implementation 'org.slf4j:slf4j-android:1.7.25'
 > implementation 'com.android.support:appcompat-v7:28.0.0'
 > testImplementation 'junit:junit:4.12'
 > androidTestImplementation project(':android_tor_installer')
 > androidTestImplementation 'org.torproject:tor-android-
 binary:0.3.5.8-rc-v2'
 > androidTestImplementation 'com.android.support.test:runner:1.0.1'
 > androidTestImplementation 'com.android.support.test.espresso
 :espresso-core:3.0.1'
 > }
 > }}}
 > I wonder whether that's indeed as problematic for us as the quote
 suggests...

 As a data point: Mozilla seems to be on 28.0.0 for the support library
 while targeting Android 29.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34247 [Applications/Tor Browser]: Update tor-browser-build README

[Tor Bug Tracker & Wiki]

#34247: Update tor-browser-build README
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb, rbm, TorBrowserTeam202005R, |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:2 boklm]:
 > Replying to [comment:1 gk]:
 > > `bug_34247` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_34247=fcf9f666e8fd81e9e85b5a1c23318ca411959f8b)
 has a patch for review.
 >
 > This patch looks good to me.
 >
 > I noticed an other minor error: there is only one empty line before
 `Description of makefile rules` (while there are two for every other
 title).

 Good point. Fixed and everything merged to `master` with commit
 `2c48c7178644bc4ba219791ed56e4078ed9e9d18`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34247 [Applications/Tor Browser]: Update tor-browser-build README

[Tor Bug Tracker & Wiki]

#34247: Update tor-browser-build README
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb, rbm, TorBrowserTeam202005R, |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:1 gk]:
 > `bug_34247` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_34247=fcf9f666e8fd81e9e85b5a1c23318ca411959f8b)
 has a patch for review.

 This patch looks good to me.

 I noticed an other minor error: there is only one empty line before
 `Description of makefile rules` (while there are two for every other
 title).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7193 [Core Tor/Tor]: Tor's sybil protection doesn't consider IPv6

[Tor Bug Tracker & Wiki]

#7193: Tor's sybil protection doesn't consider IPv6
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, intro, tor-dirauth, security,  |  Actual Points:
  sybil, network-health, outreachy-ipv6, |
  network-team-roadmap-2020Q1|
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by maurice_pibouin):

 * status:  needs_revision => needs_review


Comment:

 Finally managed to write the whole patch ! See
 https://github.com/torproject/tor/pull/1871
 I feel like the test file is a bit too long, do you have suggestions on
 how to factorize it better ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 One thing I still need to think about is:
 {{{
 There are some combinations of libraries, or tools and libraries, that are
 incompatible, or can lead to bugs. One such incompatibility is compiling
 with a version of the Android support libraries that is not the latest
 version (or in particular, a version lower than your targetSdkVersion).
 }}}
 (found at: https://stackoverflow.com/questions/53094716/implementation-
 com-android-supportappcompat-v728-0-0)

 We do set the `targetSdkVersion` to `29` while we have
 {{{
 dependencies {
 implementation project(':universal')
 implementation 'net.freehaven.tor.control:jtorctl:0.2'
 implementation 'org.slf4j:slf4j-api:1.7.25'
 implementation 'org.slf4j:slf4j-android:1.7.25'
 implementation 'com.android.support:appcompat-v7:28.0.0'
 testImplementation 'junit:junit:4.12'
 androidTestImplementation project(':android_tor_installer')
 androidTestImplementation 'org.torproject:tor-android-
 binary:0.3.5.8-rc-v2'
 androidTestImplementation 'com.android.support.test:runner:1.0.1'
 androidTestImplementation 'com.android.support.test.espresso:espresso-
 core:3.0.1'
 }
 }}}
 I wonder whether that's indeed as problematic for us as the quote
 suggests...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34200 [Core Tor/Tor]: Refactor tor's circuit path node selection checks

[Tor Bug Tracker & Wiki]

#34200: Refactor tor's circuit path node selection checks
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6,extra-review, prop311,  |  Actual Points:  1.5
  technical-debt, extra-review   |
Parent ID:  #33221   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * keywords:  ipv6, prop311, technical-debt => ipv6,extra-review, prop311,
 technical-debt, extra-review
 * reviewer:   => nickm
 * actualpoints:  1 => 1.5


Comment:

 I have rebased this PR on top of #33222, and added a changes file:
 * master: https://github.com/torproject/tor/pull/1888

 To see the changes without #33222:
 * https://github.com/teor2345/tor/pull/2

 This PR makes some of tor's node selection code a lot simpler. It fixes a
 bunch of subtle bugs and edge cases. The code was almost impossible to
 unit test before the refactor. After the refactor, it's a lot more
 consistent and modular.

 Here are the features and functions that don't have unit tests:
 * node selection
   * choose_good_exit_server_general()
   * count_acceptable_nodes()
   * router_choose_random_node_helper()
   * router_choose_random_node()
   * router_can_choose_node()
   * router_add_running_nodes_to_smartlist()

 Some of these functions are also modified in #33222. It should be easier
 to write the #33222 node selection unit tests on top of this refactor.

 This code also runs in chutney, as part of Tor's CI. But chutney doesn't
 fully test node selection.

 I suggest that we manually review the refactoring in this PR. We should
 also write unit tests for these functions (or open another ticket for the
 unit tests).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34251 [Core Tor/Tor]: Fix edge case handling in Rust protover is supported

[Tor Bug Tracker & Wiki]

#34251: Fix edge case handling in Rust protover is supported
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.5-rc
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt, rust,|  Actual Points:  0.1
  protover, 042-backport, 043-backport   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_review


Comment:

 Fixed in master in
 
https://github.com/torproject/tor/pull/1874/commits/3efe53562fea2f4d71f0f620e10f4b5319b99fcb
 as part of #33222.

 But someone still needs to make backport branches :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

[Tor Bug Tracker & Wiki]

#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:  0.1
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Fixed in master in
 
https://github.com/torproject/tor/pull/1874/commits/f05c144d7c91df365c667a48c0d99f548d766437
 as part of #33222.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

[Tor Bug Tracker & Wiki]

#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:  0.1
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-

Comment (by teor):

 But someone still needs to make backport branches :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

[Tor Bug Tracker & Wiki]

#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:  0.1
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * owner:  dgoulet => (none)
 * sponsor:   => Sponsor55-can
 * actualpoints:  0,1 => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33222 [Core Tor/Tor]: Prop 311: 4.2. Implement IPv6 ORPort Reachability Self-Tests

[Tor Bug Tracker & Wiki]

#33222: Prop 311: 4.2. Implement IPv6 ORPort Reachability Self-Tests
---+
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ipv6, prop311  |  Actual Points:  4
Parent ID:  #33221 | Points:  6
 Reviewer:  nickm  |Sponsor:  Sponsor55-must
---+
Changes (by teor):

 * actualpoints:  3 => 4


Comment:

 I have pushed some extra tests and changes files:
 * master: https://github.com/torproject/tor/pull/1874

 This branch also fixes the following Rust protover bugs in master:
 * #34248: add HSIntro=5 in Rust
 * #34251: fix error handling in Rust protover is supported
 I've left those tickets open, because we need to backport those changes.

 Here are the features and functions that don't have unit tests:
 * launch IPv6 ORPort self-test circuits
   * fmt_addr32_port()
   * fmt_af_family() - refactoring
   * fmt_addr_family() - refactoring
   * router_get_orport()
   * extend_info_from_router()
   * router_do_orport_reachability_checks()
   * router_do_dirport_reachability_checks() - minor modifications and
 refactoring
   * router_do_reachability_checks() - minor modifications and refactoring
   * inform_testing_reachability() - minor modifications and refactoring
 * when launching IPv6 ORPort self-test circuits, make sure that the last
 hop supports IPv6 extends
   * node_supports_initiating_ipv6_extends()
   * node_supports_accepting_ipv6_extends()
   * router_add_running_nodes_to_smartlist() - added IPv6 extend check

 These tests should be much easier to write on top of the refactor in
 #34200.

 This code runs in chutney's IPv6 networks, which are part of Tor's CI. But
 chutney doesn't fully test IPv6 reachability yet. Chutney will test more
 of this code, when we split tor's IPv4 and IPv6 reachability flags in
 #34067.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33939 [Applications/Tor Browser]: Decide which components of Fenix to rip out, disable, or use

[Tor Bug Tracker & Wiki]

#33939: Decide which components of Fenix to rip out, disable, or use
--+
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam202004  |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
  |  Sponsor58-must
--+

Comment (by gk):

 Thanks, that's a good start. Two thoughts while skimming the list (I did
 not look carefully yet)

 1) At least the progressive web apps (PWA) part should probably be in the
 Must Audit section. We even have a ticket for that already: #25845 :)

 2) I was wondering how the dependencies those dependencies have would
 influence where we put them category-wise. So, starting with one layer
 seems good to me but I feel we might need dig deeper to have a final
 assessment. One of the things I am already wary of is getting all the
 application-services parts roped in "for free". Not all components are
 probably needing that (I've not checked) but I bet some would move into
 the Must Audit part alone due to that. And there's probably other stuff
 that is bubbling in this morass, under the quite surface... :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34251 [Core Tor/Tor]: Fix edge case handling in Rust protover is supported

[Tor Bug Tracker & Wiki]

#34251: Fix edge case handling in Rust protover is supported
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core |Version:  Tor: 0.3.3.5-rc
  Tor/Tor|   Keywords:  044-should, technical-debt, rust,
 Severity:  Normal   |  protover, 042-backport, 043-backport
Actual Points:  0.1  |  Parent ID:
   Points:  0.5  |   Reviewer:
  Sponsor:   |
-+-
 Tor's Rust FFI for protocol_list_supports_protocol_or_later() returns true
 for the empty protocol list.

 In C, the function returns false, but this behaviour is undocumented.

 This bug doesn't affect protocol_list_supports_protocol() in Rust, because
 the Rust error checks are done in a different order.

 I'll add a quick fix to #33222, but someone else will need to do the
 backport. We might want to do the Rust error checks in the same order,
 too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

[Tor Bug Tracker & Wiki]

#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  dgoulet
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:  0,1
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * actualpoints:   => 0,1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

[Tor Bug Tracker & Wiki]

#34250: Fix torbutton noscript-control race condition
--+--
 Reporter:  acat  |  Owner:  acat
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam202005R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * keywords:  TorBrowserTeam202005 => TorBrowserTeam202005R
 * status:  assigned => needs_review


Comment:

 Patch for review in https://github.com/acatarineu/torbutton/commit/34250.

 Unfortunately I could not find a simple way to reproduce the issue, other
 than running a `tbb-testsuite` test. So, with `tor-browser-linux64-9.0
 .10_en-US.tar.xz` build, and https://github.com/acatarineu/tor-browser-
 bundle-testsuite/commit/8b36cbe63d4189a6b6d6dce3810239b734fb6e2e, I can
 reproduce with:

 `./tbb-testsuite --default-retry 1 --no-xdummy --enable-tests dom-objects-
 enumeration-worker /tmp/tor-browser-linux64-9.0.10_en-US.tar.xz`

 Without the torbutton patch, this fails with `NoSuchElementException:
 Unable to locate element: enumeration`. With the patch, it fails with:

 {{{
 AssertionError: Unknown objects:
 DOMError
 toSource
 uneval
 }}}

 The missing objects are expected, since the tests were fixed for a #33533
 (33533+5) Firefox 77 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-tema (removed)
 * cc: tbb-team (added)
 * status:  assigned => needs_review
 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202005
 => tbb-mobile, tbb-rbm, GeorgKoppen202005, TorBrowserTeam202005R


Comment:

 `bug_33558_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33558_v3=496918096fce1c5b23c28727e77f69c530251781)
 has an updated patch, building on top of sisbell's, for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33559 [Applications/Tor Browser]: Update tor-android-service To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33559: Update tor-android-service To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-team (added)
 * owner:  tbb-team => gk
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33559 [Applications/Tor Browser]: Update tor-android-service To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33559: Update tor-android-service To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005
 * reviewer:  gk => sysrqb, ahf
 * status:  needs_review => needs_revision


Comment:

 Mozilla still has the `minVersion` set to `16` (at least for non-64bit
 targets). We should keep that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34187 [Applications/Tor Browser]: Update zlib build script to pick up new android toolchain

[Tor Bug Tracker & Wiki]

#34187: Update zlib build script to pick up new android toolchain
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

[Tor Bug Tracker & Wiki]

#34250: Fix torbutton noscript-control race condition
--+
 Reporter:  acat  |  Owner:  acat
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam202005
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 While debugging some testsuite tests, I saw some race condition with the
 noscript initialization which prevents some tests from running correctly.

 We currently listen for both `startup` and `pageshow` events
 [https://gitweb.torproject.org/torbutton.git/tree/modules/noscript-
 control.js?id=36f8182a25818548d62b7fbc6be4d2472773b820#n149 here], and in
 some tests, `pageshow` events are being received before `startup`, which
 results in the configuration message being lost and noscript being
 initialized with the default settings, blocking scripts.

 This was originally introduced in #27427, which added checks for the event
 types precisely because of these issues. However, "pageshow" in specific
 situations also seems to trigger those.

 In that ticket, "pageshow" was added `for a slightly more graceful failure
 mode in case Torbutton somehow misses NoScript startup`. However, I don't
 think that can really happen, and I suggest we just listen to `startup`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:  sysrqb => sysrqb, ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33564 [Applications/Tor Browser]: Upgrade ZSTD to use Android NDK 20

[Tor Bug Tracker & Wiki]

#33564: Upgrade ZSTD to use Android NDK 20
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .1
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:  sysrqb => sysrqb, ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33563 [Applications/Tor Browser]: Upgrade Tor To Use Android NDK 20

[Tor Bug Tracker & Wiki]

#33563: Upgrade Tor To Use Android NDK 20
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:  sysrqb => sysrqb, ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 20

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 20
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * reviewer:  sysrqb => sysrqb, ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

[Tor Bug Tracker & Wiki]

#33973: Create fat .aar for geckoview
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
-+-
Changes (by ahf):

 * reviewer:  sysrqb => sysrqb, ahf


Comment:

 Adding self to reviewer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 Thank you. Putting this back into needs_review while we wait for CI to
 finish.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 I renamed my original repository to `tor-fork` and forked a new repository
 from the official `tor` mirror repository, and then pushed my changes.

 I have created pull request [https://github.com/torproject/tor/pull/1899
 #1899]

 P.S I just noticed teor's reply, I was a bit slower when posting :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:5 TheDcoder]:
 > Replying to [comment:4 ahf]:
 >
 > > I think the patch looks fine, but could I get you to create a pull-
 request against our master branch on https://github.com/torproject/tor ?
 This would allow us to verify that the code passes our test-suites and is
 mergeable.
 >
 > Great to know that the patch looks fine. I will certainly create a pull-
 request, though it looks like GitHub's user interface only allows PRs from
 "forks", my repository is not considered a fork because I had cloned it
 from gitweb.torproject.org and then pushed it to a repository under my
 user account. So I need to figure out how to create a pull-request.

 Yes, that's an annoying limitation of GitHub.

 When that's happened to me, I've created a fork under another name, and
 used that fork. (You can also rename and archive the old repository. Then
 you can push all your branches to a new fork under the correct name.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 Replying to [comment:4 ahf]:

 > I think the patch looks fine, but could I get you to create a pull-
 request against our master branch on https://github.com/torproject/tor ?
 This would allow us to verify that the code passes our test-suites and is
 mergeable.

 Great to know that the patch looks fine. I will certainly create a pull-
 request, though it looks like GitHub's user interface only allows PRs from
 "forks", my repository is not considered a fork because I had cloned it
 from gitweb.torproject.org and then pushed it to a repository under my
 user account. So I need to figure out how to create a pull-request.

 > We are generally not very good at dealing with Microsoft Windows, so if
 you know its APIs well, and are working on something related to this,
 please feel free to poke us about anything that you might discover. We
 could definitely need some help in this area :-)

 Thank you, I am not an expert, but I will try to lend a hand whenever I
 can :)

 > Thank you for working on this!

 My pleasure!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

[Tor Bug Tracker & Wiki]

#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  dgoulet
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  044-should, technical-debt,  |  Actual Points:
  042-backport, 043-backport |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I also opened #34249 to make sure the versions stay in sync.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34249 [Core Tor/Tor]: Make sure the C and Rust protovers can't get out of sync

[Tor Bug Tracker & Wiki]

#34249: Make sure the C and Rust protovers can't get out of sync
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  044-should
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:|
--+
 There is a recurring bug, where we modify the C protover, but forget the
 Rust protover. (See #34248, #33285, #29631 for similar issues.)

 We could fix the underlying issue by fetching the string from a common
 location, using C's `#include` or Rust's `include_str!()`.

 Then we could test that C and Rust are the same by putting a copy of the
 protover string in the unit tests, and making sure that it matches the
 currently supported protocol versions.

 This fix and test will be important for proposal 318, because it will
 modify both protocol version implementations:
 https://github.com/torproject/torspec/blob/master/proposals/318-limit-
 protovers.md

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34248 [Core Tor/Tor]: Declare HSIntro=5 in Tor's rust protover implementation

[Tor Bug Tracker & Wiki]

#34248: Declare HSIntro=5 in Tor's rust protover implementation
-+-
 Reporter:  teor |  Owner:  dgoulet
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core |Version:  Tor: 0.4.2.1-alpha
  Tor/Tor|   Keywords:  044-should, technical-debt,
 Severity:  Normal   |  042-backport, 043-backport
Actual Points:   |  Parent ID:
   Points:  0.5  |   Reviewer:
  Sponsor:   |
-+-
 My protover tests for #33222 fail in Rust, because Tor's rust protover
 doesn't declare HSIntro=5.

 I'll do a quick fix in #33222, but I want to leave the backport to David.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33675 [Core Tor/Chutney]: Search microdescriptor files for relay ed25519 keys

[Tor Bug Tracker & Wiki]

#33675: Search microdescriptor files for relay ed25519 keys
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:  0.2
Parent ID:  #33050 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * parent:  #33428 => #33050


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33226 [Core Tor/Tor]: Prop 311: 5. Declare Support for Subprotocol Version "Relay=3"

[Tor Bug Tracker & Wiki]

#33226: Prop 311: 5. Declare Support for Subprotocol Version "Relay=3"
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  prop311, ipv6, network-team- |  Actual Points:  1
  roadmap-2020Q2 |
Parent ID:  #33048   | Points:  0.5
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * parent:  #33222 => #33048


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33676 [Core Tor/Chutney]: Stop waiting a set time for microdescriptors

[Tor Bug Tracker & Wiki]

#33676: Stop waiting a set time for microdescriptors
---+---
 Reporter:  teor   |  Owner:  anuradha1904
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Chutney   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:
Parent ID:  #33050 | Points:  0.5
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * parent:  #33428 => #33050


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #33312, #33313, #33394

[Tor Bug Tracker & Wiki]

Batch modification to #33312, #33313, #33394 by karsten:
sponsor to 

Comment:
Taking Metrics/Cloud tickets out of Sponsor 59.

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33432 [Metrics/Onionperf]: Multiple downloads for oneshot mode

[Tor Bug Tracker & Wiki]

#33432: Multiple downloads for oneshot mode
---+--
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by karsten):

 * sponsor:   => Sponsor59


Comment:

 Let's consider doing this as part of Sponsor 59.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

[Tor Bug Tracker & Wiki]

#33428: Make chutney check for relay microdescriptors before verifying
-+-
 Reporter:  teor |  Owner:  teor
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Chutney |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6,   |  Actual Points:  0.6
  network-team-roadmap-2020Q1|
Parent ID:  #33050   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * actualpoints:  0.5 => 0.6


Comment:

 0.3.5 still needs a bit of time before verifying, so I reverted that part
 of the branch.

 I originally thought these timing issues were due to microdescriptors. But
 there's clearly something more subtle that we fixed in 0.4.0 and later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33395 [Metrics/Cloud]: Add option to replace the client and server torrc files

[Tor Bug Tracker & Wiki]

#33395: Add option to replace the client and server torrc files
---+--
 Reporter:  acute  |  Owner:  metrics-team
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Cloud  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33319 | Points:  1
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * sponsor:  Sponsor59-must =>


Comment:

 Okay. Removing from Sponsor 59 then. We can still do it, just not for this
 sponsor. Thanks for the analysis and clarification!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33871 [Core Tor/sbws]: Scale exactly as torflow does?

[Tor Bug Tracker & Wiki]

#33871: Scale exactly as torflow does?
-+-
 Reporter:  juga |  Owner:  juga
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  sbws:
 |  1.1.x-final
Component:  Core Tor/sbws|Version:
 Severity:  Normal   | Resolution:
 Keywords:  sbws-majority-blocker, sbws-roadmap  |  Actual Points:
Parent ID:  #33775   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mikeperry):

 Replying to [comment:15 juga]:
 > Replying to [comment:14 mikeperry]:
 > > Oh I missed that sbws was including avg_bandwidth in the min().. That
 definitely should not be there. Average will always be below observed,
 >
 > I don't think this is the case, just taking randomly a relay from my
 `cached-descriptors`:
 > {{{
 > router rotateRelay21 188.227.170.106 2109 0 0
 > fingerprint 1387 BB67 C0A1 BCE2 8133 FF72 39E0 27D5 4C56 538D
 > bandwidth 2621440 10485760 5445375
 > }}}
 >
 > I also looked 2 years ago at the spec and the code
 (https://onbasca.readthedocs.io/en/latest/bandwidth_tor.html) and
 concluded that the average is `min(RelayBandwidthRate, BandwidthRate,
 MaxAdvertisedBandwidth)`, which are all set by the operator (or torrc
 defaults), am i mistaken?.
 > Maybe you're thinking on the `advertised` bandwidth, not the average?

 Hrm it appears TorFlow is actually taking the minimum of all three here:
 https://gitweb.torproject.org/pytorctl.git/tree/TorCtl.py#n459

 So this should match sbws taking the min of all three..

 Sorry I did not recall that either. It has been 8 years since I worked on
 this code.

 If it is not the order of composition of the min() you mention, then I am
 not sure what the issue is still :/.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
---+
 Reporter:  irl|  Owner:  metrics-team
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID: | Points:  1.0
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  accepted => assigned
 * owner:  karsten => metrics-team
 * points:  1 => 1.0
 * actualpoints:   => 0.4


Comment:

 After having looked at past logs and thinking about possible fixes I came
 up with a rather trivial fix: let's give up on using a strict date filter
 when analyzing logs and simply include all transfers and control events
 found in the parsed log files.

 Example: op-ab's log files from 2019-01-13 contain measurements from
 2019-01-12 and -13, because log rotation didn't happen at 2019-01-12
 23:59:59. With the current code, the analysis file produced at 2019-01-13
 23:59:59 is called `2019-01-13.onionperf.analysis.json.xz` and contains
 measurements from 2019-01-13 only. After the suggested change the file
 would still have that file name but contain all measurements from
 2019-01-12 and -13 as found in the log files.

 (A possible alternative that I had been thinking about before was that the
 analysis of a single pair of log files could produce more than one
 analysis files depending on how many dates are covered in the log files.
 This can get nasty, though. We'd have to consider all sorts of edge cases
 where two log files contain measurements for the same date. But really, we
 don't have to make sure that measurements go into analysis files with a
 specific date. Let's just not do this anymore.)

 I didn't work on the implementation yet and would like to leave this to
 others, also as a way to sanity check the concept. If I were to implement
 this I'd probably avoid using the `date_filter` parameter when doing the
 nightly analysis and introduce some sort of `date_prefix` parameter. We
 should just use that `date_filter` by default for all analysis files, and
 we might consider deprecating the `date_prefix` parameter in the user
 interface. When testing this, we'll have to ensure that it works for the
 nightly case as well as the reprocessing case.

 Returning to metrics-team.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29369 [Metrics/Onionperf]: Fix message logging and filtering

[Tor Bug Tracker & Wiki]

#29369: Fix message logging and filtering
---+
 Reporter:  irl|  Owner:  karsten
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  reopened => accepted
 * owner:  metrics-team => karsten


Comment:

 I started looking into this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * owner:  tbb-team => gk
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33558 [Applications/Tor Browser]: Update TOPL To Use Updated Android Toolchain

[Tor Bug Tracker & Wiki]

#33558: Update TOPL To Use Updated Android Toolchain
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  GeorgKoppen202005, TorBrowserTeam202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: tbb-tema (added)
 * reviewer:  gk => sysrqb
 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R => tbb-mobile, tbb-
 rbm, GeorgKoppen202005, TorBrowserTeam202005


Comment:

 There is now a `var/android-plugin` which is never used, though. Just
 remove it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

[Tor Bug Tracker & Wiki]

#33973: Create fat .aar for geckoview
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:27 ahf]:
 > I have managed to build this branch now on two different machines.
 >
 > The only changes I have had to make so far are:
 >
 > {{{
 > diff --git a/README b/README
 > index 8e97e2f..2457f15 100644
 > --- a/README
 > +++ b/README
 > @@ -198,7 +198,7 @@ builds, and will require that you run Debian Stretch
 and install build
 >  dependencies for all the components that are built. This can be done
 >  with the following command:
 >
 > -  # apt-get install build-essential python automake libtool zip unzip
 > +  # apt-get install build-essential python automake libtool zip unzip \
 >  autoconf2.13 openjdk-8-jdk gettext-base autotools-dev \
 >  automake autoconf libtool autopoint libssl-dev \
 >  pkg-config zlib1g-dev libparallel-forkmanager-perl \
 > diff --git a/projects/geckoview/config b/projects/geckoview/config
 > index 63da289..ddab204 100644
 > --- a/projects/geckoview/config
 > +++ b/projects/geckoview/config
 > @@ -93,6 +93,7 @@ steps:
 >
 >  input_files:
 >- project: container-image
 > +pkg_type: build
 >- name: '[% c("var/compiler") %]'
 >  project: '[% c("var/compiler") %]'
 >  pkg_type: build
 > }}}
 >
 > Where the last part was from boklm and GeKo on IRC.

 Thanks. The first part is addressed in #34247 and for the other one I
 pushed a fixup commit to `bug_33973_v7` (commit
 `3a24048253dd5f4fe79c0d44e3aff9f0fdb81d92`). `bug_33973_v8`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33973_v8=544853e0c7c8adb58fb36a4582244a00f72a5838)
 has the fixed up commit rebased on latest `master` and the updated branch
 for #33626 (`bug_33626_v11`).

 > From what I can tell with the code is that it seems reasonable. I am not
 sure what the common strategy is for when you review build-system
 components in the browser. In Tor we have all kinds of sanitizers from
 shellcheck that we run on shell-like scripts. The code looks fine to me,
 is easy to understand once the gist of rbm kicks in.

 There are no sanitizers for `tor-browser-build` changes (yet). It's "just"
 code change review and testing that the proposed changes actually work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34247 [Applications/Tor Browser]: Update tor-browser-build README

[Tor Bug Tracker & Wiki]

#34247: Update tor-browser-build README
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb, rbm, TorBrowserTeam202005R, |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb, rbm, TorBrowserTeam202005, GeorgKoppen202005 => tbb, rbm,
 TorBrowserTeam202005R, GeorgKoppen202005
 * status:  assigned => needs_review


Comment:

 `bug_34247` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_34247=fcf9f666e8fd81e9e85b5a1c23318ca411959f8b)
 has a patch for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30586 [Metrics/Onionperf]: requirements are not included in setup.py

[Tor Bug Tracker & Wiki]

#30586: requirements are not included in setup.py
---+
 Reporter:  irl|  Owner:  phw
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 I've pushed a minor fixup commit onto my github branch to remove the
 duplication of the requirements:

 https://github.com/ana-
 cc/onionperf/commit/893306c97bff0526c42ee97dda789ebf310304be.patch

 With this applied, it is good to merge. Phw, if you are happy with this
 you can set this to merge-ready!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs