Blocking screen on click of Link
Hi,
I am using Link for export functionality on my screen using following code.
Link exportLink = new Link(export) {
@Override
public void onClick() {
ListABC list = ABCService
.exportABCList();
ExportUtil export = new ExportUtil();
export.exportABCToExcel(list,
getRequestCycle());
}
};
I need to block the screen for any other functionality by the user while
this functionality gets over. For other functionalities this is being done
by using the following code that can be called only for any ajax call:
@Override
public String getAjaxIndicatorMarkupId() {
return div_blockScreen;
}
As i am using Link instead of any ajax link (using ajax link for export
functionality does not work,gives some javascript error )this method is not
getting called. I thought of calling a javascript method on click on this
link so that i can block the screen but how will i get to know when to
unblock it, means on what event i should do it. If somebody has any idea how
to do it please let me know.
Thanks in advance!
-
_kl_ :)
--
View this message in context:
http://apache-wicket.1842946.n4.nabble.com/Blocking-screen-on-click-of-Link-tp4653425.html
Sent from the Users forum mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Re: wicket-6 User friendly form validation with Wicket (stuq)
Hi, On Sun, Oct 28, 2012 at 9:31 PM, Rafał Krupiński r.krupin...@gmail.com wrote: On Wed, Oct 24, 2012 at 10:13 AM, Martin Grigorov mgrigo...@apache.org wrote: Hi, The URL below doesn't load and I cannot see what is his implementation. Hm, it loaded when I posted that message :( Anyway, I would like to have a label for each validated input field and put there any error messages related to that input. I haven't found any example other than that old article by Daan van Etten and that was for wicket 1.3. Daan's solution used his own FeedbackLabel class and filtered FeedbackPanel but it doesn't work with wicket 6. Please paste your code and compile errors/exceptions to see what doesn't work. -- Pozdrawiam / Best Regards Rafal Krupinski - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Custom CSS for Feedback message is broken in 1.5
Hi, [X] Other suggestion: (please specify) Here is what I think it should be: - div element should have class feedbackPanel (this is already the case) - li element(s) should have class that specifies the feedback message level (currently by default Wicket sets feedbackPanelLEVEL, but this is configurable with org.apache.wicket.markup.html.panel.FeedbackPanel#getCSSClass(FeedbackMessage)) - the span should not have class at all (currently it has the same class as the li element) - the styling should be done with CSS selectors (e.g. div.feedbackPanel; div.feedbackPanel li.alert-warn; div.feedbackPanel li.alert-warn span; ...) - if custom markup is needed then a custom FeedbackPanel is needed (one that extends from the default FeedbackPanel or a completely new one, it depends on the use case) On Sun, Oct 28, 2012 at 6:03 PM, Sebastien seb...@gmail.com wrote: Hi, To sum-up this thread: we have a (not huge, but still) design issue that annoys several users. A patch* has been provided but some questions remains... Given this, I would suggest a kind-of vote about the several points discussed earlier, in order to enlighten the dev-team about the preferred choice of their (beloved) users.** Here are some possible options: [ ] Please apply the patch as-is. It currently provides 2 methods (#getListCSSClass and #getLabelCSSClass), #getCSSClass is marked a deprecated until marked as private (or removed) [ ] Do not apply the patch as-is, #getCSSClass should be kept (not marked as deprecated) [ ] Do not apply the patch as-is, I do not agree with the 2 method names. I would have preferred: (please specify) [ ] This is not an issue; this does not need to be corrected [ ] Other suggestion: (please specify) Thanks in advance for your contribution, Sebastien (*) https://issues.apache.org/jira/browse/WICKET-4831 (**) Sure, dev-team opinion is also kindly asked! :) -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Remove ?1 from URL on GoogleAnalytics tracked pages
Hi Sebastien,
Thanks for sharing this solution!
I find it very useful.
Do you want to add it in the Wiki so it will be easier to find and
part of the documentation.
See few comments inline.
On Sun, Oct 28, 2012 at 3:49 PM, Sebastien seb...@gmail.com wrote:
Hi,
For whom might be interested, here is a solution on how to remove ?1 params
from tracked page's URL on GoogleAnalytics. This follows a thread entitled
I would url clear, without jsessionid and ?1
To achieve this, the approach is to not attempt to remove/adapt ?1 params
from statefull page's URL, but rather supply a clean URL to the GA
javascript object: _gaq.push(['_trackPageview', 'the/clean/url']);
For this cooking recipe we need:
1/ the GA client script in a js-templated file (ie: my/package/gaq.js) so
the URL value can be supplied through a variable:
_gaq.push(['_trackPageview', '${url}']);
2/ a behavior, that will:
2a/ resolves the URL (ie: /context/page)
2b/ de-templates the js file, with the url value, using a
TextTemplateResourceReference
2c/ renders the js file back to the page.
Then, add the behavior to your (base) page, and that's it.
The behavior looks like:
class GoogleAnalyticsBehavior extends Behavior
{
private static final long serialVersionUID = 1L;
private final String url;
public GoogleAnalyticsBehavior(final WebPage page)
{
No need to pass an instance of WebPage. You need just its class.
this.url = this.getUrl(page);
}
private String getUrl(WebPage page)
{
Url pageUrl = Url.parse(page.urlFor(page.getClass(),
null).toString());
Url baseUrl = new
Url(page.getRequestCycle().getUrlRenderer().getBaseUrl());
baseUrl.resolveRelative(pageUrl);
No need to play with the base url and calculate the urls yourself.
Use:
Url fullUrl = urlRenderer.renderFullUrl(pageUrl)
return String.format(%s/%s, page.getRequest().getContextPath(),
baseUrl);
}
private IModelMapString, Object newResourceModel()
{
MapString, Object map = new HashMapString, Object();
map.put(url, this.url);
return Model.ofMap(map);
}
private ResourceReference newResourceReference()
{
return new
TextTemplateResourceReference(GoogleAnalyticsBehavior.class, gaq.js,
this.newResourceModel());
}
@Override
public void renderHead(Component component, IHeaderResponse response)
{
super.renderHead(component, response);
response.render(JavaScriptHeaderItem.forReference(this.newResourceReference(),
gaq));
}
}
Thanks to Martin (I would say: again!) to have suggested the right pointers.
Sebastien.
On Fri, Oct 26, 2012 at 1:17 AM, Sebastien seb...@gmail.com wrote:
Hi Martin,
Thanks for your answer! Yes, I think it - indirectly - answers the need!
In short: Google Analytics does not take into account the canonical links
directly (it appears to be for indexing purpose only). However, you put me
on the right direction, and a simple solution is provided here:
http://stackoverflow.com/questions/9103794/canonical-url-in-analytics
I will give this a try and will let you know!
Thanks again best regards,
Sebastien.
On Thu, Oct 25, 2012 at 5:17 PM, Martin Grigorov mgrigo...@apache.orgwrote:
Hi Sebastien,
Is
http://googlewebmastercentral.blogspot.com/2009/02/specify-your-canonical.html
a solution for this use case ?
On Thu, Oct 25, 2012 at 5:42 PM, Sebastien seb...@gmail.com wrote:
Hi,
I have a question related to this thread, how is it possible to have a
variable name for ?1, ?2 ?
ie: ?state=1, ?state=2 (or another variable name)
Is there any existing IRequestMapper for that for instance?
One use case, is that google analytics allows to not take into account
some
url variables so pages are not considered as distinct (MyPage?1 and
MyPage?2 should sums stats for only one page: MyPage, which is not the
case
yet)
Thanks in advance!
Sebastien.
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Re: Custom CSS for Feedback message is broken in 1.5
[X] Other suggestion: I agree with Martin's points, especially the 3rd one (span should have no CSS class). To ease extending of FeedbackPanel I'd suggest to delegate #newItem() of the nested MessageListView to a new protected method #newMessageItem() in FeedbackPanel. (Similar to DataTable#newRowItem()) Best regards Sven On 10/29/2012 08:53 AM, Martin Grigorov wrote: Hi, [X] Other suggestion: (please specify) Here is what I think it should be: - div element should have class feedbackPanel (this is already the case) - li element(s) should have class that specifies the feedback message level (currently by default Wicket sets feedbackPanelLEVEL, but this is configurable with org.apache.wicket.markup.html.panel.FeedbackPanel#getCSSClass(FeedbackMessage)) - the span should not have class at all (currently it has the same class as the li element) - the styling should be done with CSS selectors (e.g. div.feedbackPanel; div.feedbackPanel li.alert-warn; div.feedbackPanel li.alert-warn span; ...) - if custom markup is needed then a custom FeedbackPanel is needed (one that extends from the default FeedbackPanel or a completely new one, it depends on the use case) On Sun, Oct 28, 2012 at 6:03 PM, Sebastien seb...@gmail.com wrote: Hi, To sum-up this thread: we have a (not huge, but still) design issue that annoys several users. A patch* has been provided but some questions remains... Given this, I would suggest a kind-of vote about the several points discussed earlier, in order to enlighten the dev-team about the preferred choice of their (beloved) users.** Here are some possible options: [ ] Please apply the patch as-is. It currently provides 2 methods (#getListCSSClass and #getLabelCSSClass), #getCSSClass is marked a deprecated until marked as private (or removed) [ ] Do not apply the patch as-is, #getCSSClass should be kept (not marked as deprecated) [ ] Do not apply the patch as-is, I do not agree with the 2 method names. I would have preferred: (please specify) [ ] This is not an issue; this does not need to be corrected [ ] Other suggestion: (please specify) Thanks in advance for your contribution, Sebastien (*) https://issues.apache.org/jira/browse/WICKET-4831 (**) Sure, dev-team opinion is also kindly asked! :) - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Redirect to Wicket page with 301 Moved Permanently
Hi Dan, I'd recommend to revert your changes. Wicket by default uses render strategy which involves http redirects which has to be temporary. With your change you will always use permanent redirects and this may cause some problems. For example you may skip the ACTION phase of the processing and go directly to RENDER phase just because the action url is already marked as permanently moved. Read the javadoc of org.apache.wicket.settings.IRequestCycleSettings.RenderStrategy for more info. On Sat, Oct 27, 2012 at 3:47 PM, Dan dan.traczyn...@gmail.com wrote: I know this is a bit late to reply, but I just had this same problem and I was unable to find a solution posted anywhere. I was able to solve the problem and change the redirect behaviour to always use 301 instead of 302 by subclassing Wicket's org.apache.wicket.protocol.http.servlet.ServletWebResponse class and overriding the sendRedirect method to use my own custom logic instead of the HttpServletResponse.sendRedirect logic. I wrote it up here: http://pushinginertia.com/2012/10/wicket-redirect-301-moved-permanently-302-found/ Perhaps we can make the change I outlined directly in wicket-core and then make it configurable so that the web application can default to a 301 or 302 redirect, based on the requirements of each web application. -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Redirect-to-Wicket-page-with-301-Moved-Permanently-tp4631888p4653406.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Blocking screen on click of Link
Hi,
Check:
https://cwiki.apache.org/WICKET/ajax-update-and-file-download-in-one-blow.html
It describes how to do with Ajax and it will be much easier than with a Link.
On Mon, Oct 29, 2012 at 9:21 AM, _kl_ kriti@igate.com wrote:
Hi,
I am using Link for export functionality on my screen using following code.
Link exportLink = new Link(export) {
@Override
public void onClick() {
ListABC list = ABCService
.exportABCList();
ExportUtil export = new ExportUtil();
export.exportABCToExcel(list,
getRequestCycle());
}
};
I need to block the screen for any other functionality by the user while
this functionality gets over. For other functionalities this is being done
by using the following code that can be called only for any ajax call:
@Override
public String getAjaxIndicatorMarkupId() {
return div_blockScreen;
}
As i am using Link instead of any ajax link (using ajax link for export
functionality does not work,gives some javascript error )this method is not
getting called. I thought of calling a javascript method on click on this
link so that i can block the screen but how will i get to know when to
unblock it, means on what event i should do it. If somebody has any idea how
to do it please let me know.
Thanks in advance!
-
_kl_ :)
--
View this message in context:
http://apache-wicket.1842946.n4.nabble.com/Blocking-screen-on-click-of-Link-tp4653425.html
Sent from the Users forum mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Re: WiQuery SortableBehavior/DroppableBehavior questions
Hi
First, onStopWidgetMove() function from dashboard.js is called on
sortableBehavior.setStopEvent(). That js function creates a json with the
new widgets positions. Second, the StopSortableAjaxBehavior (see respond
method) is called with parameter data (json created above).
For more info see:
protected void onBind() {
getComponent().add(sortableBehavior);
sortableBehavior.setStopEvent(new JsScopeUiEvent() {
...
});
}
protected void respond(AjaxRequestTarget target) {
...
}
Best regards,
Decebal
--
View this message in context:
http://apache-wicket.1842946.n4.nabble.com/WiQuery-SortableBehavior-DroppableBehavior-questions-tp4653349p4653434.html
Sent from the Users forum mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
Re: Custom CSS for Feedback message is broken in 1.5
[X] Other suggestion: don't have a class on the span, or even better, don't have the span element at all inside the list-item For any customisations beyound this, just create your own FeedbackPanel, it's easy and gives complete control. On Sun, Oct 28, 2012, at 17:03, Sebastien wrote: Hi, To sum-up this thread: we have a (not huge, but still) design issue that annoys several users. A patch* has been provided but some questions remains... Given this, I would suggest a kind-of vote about the several points discussed earlier, in order to enlighten the dev-team about the preferred choice of their (beloved) users.** Here are some possible options: [ ] Please apply the patch as-is. It currently provides 2 methods (#getListCSSClass and #getLabelCSSClass), #getCSSClass is marked a deprecated until marked as private (or removed) [ ] Do not apply the patch as-is, #getCSSClass should be kept (not marked as deprecated) [ ] Do not apply the patch as-is, I do not agree with the 2 method names. I would have preferred: (please specify) [ ] This is not an issue; this does not need to be corrected [ ] Other suggestion: (please specify) Thanks in advance for your contribution, Sebastien (*) https://issues.apache.org/jira/browse/WICKET-4831 (**) Sure, dev-team opinion is also kindly asked! :) - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Test project
Hi all, There is no problen to open this Maven project in NetBeans and use the start class to launch it on the bundled jetty server... The quickstart: https://github.com/papegaaij/wicket-atmosphere-quickstart https://github.com/papegaaij/wicket-atmosphere-quickstart I have created a simple NetBeans Web project with the same source files. Can someone open it and try to run it. The application is deployed on the GlassFish server without any errors, but the app is not started correct. What is wrong? My project: https://www.dropbox.com/s/2si4vvbmxo4fqxg/TestUI.zip https://www.dropbox.com/s/2si4vvbmxo4fqxg/TestUI.zip -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Test-project-tp4653437.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Test project
Hi, Better ask this question in Atmosphere mailing list. They know more about the internals of how Jetty/Tomcat/GF/... should work. On Mon, Oct 29, 2012 at 12:52 PM, Mats mats.gudmunds...@delaval.com wrote: Hi all, There is no problen to open this Maven project in NetBeans and use the start class to launch it on the bundled jetty server... The quickstart: https://github.com/papegaaij/wicket-atmosphere-quickstart https://github.com/papegaaij/wicket-atmosphere-quickstart I have created a simple NetBeans Web project with the same source files. Can someone open it and try to run it. The application is deployed on the GlassFish server without any errors, but the app is not started correct. What is wrong? My project: https://www.dropbox.com/s/2si4vvbmxo4fqxg/TestUI.zip https://www.dropbox.com/s/2si4vvbmxo4fqxg/TestUI.zip -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Test-project-tp4653437.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Sort ListChoice component
Hi all, how can I sort ListChoice elements with moveUp and moveDown button? Thanks M -- Dott. Marco Di Sabatino Di Diodoro Tel. +39 3939065570 Tirasa S.r.l. Viale D'Annunzio 267 - 65127 Pescara Tel +39 0859116307 / FAX +39 085973 http://www.tirasa.net Apache Syncope PPMC Member http://people.apache.org/~mdisabatino
ActiveRequest in RequestLogger
Hi, In production we are logging the active requests into the log file using RequestLogger. Intersestingly we are seeing the value of active requests always increasing.For example, between 20:00 to 22:00 we are seeing the following values for active request.257302607626341264552655426663267762689727022271392724127360274802758027669277902787427943279452803828134282272827928421The number of active sessions is 500. We using wicket 1.4.19 on jdk 1.5.22.My assumption was that it would reflect the current number of active requests but this proves me wrong.Am I missing something here?Thanks,Srikanth -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/ActiveRequest-in-RequestLogger-tp4653443.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: ActiveRequest in RequestLogger
Hi, Please try with Wicket 1.5.8/6.2.0 (with a mini application if you are not able to migrate now) and see whether it behaves the same way. There we improvements in this area for Wicket 1.5. On Mon, Oct 29, 2012 at 3:15 PM, Srikanth.NT ntsrika...@gmail.com wrote: Hi, In production we are logging the active requests into the log file using RequestLogger. Intersestingly we are seeing the value of active requests always increasing.For example, between 20:00 to 22:00 we are seeing the following values for active request.257302607626341264552655426663267762689727022271392724127360274802758027669277902787427943279452803828134282272827928421The number of active sessions is 500. We using wicket 1.4.19 on jdk 1.5.22.My assumption was that it would reflect the current number of active requests but this proves me wrong.Am I missing something here?Thanks,Srikanth -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/ActiveRequest-in-RequestLogger-tp4653443.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Sort ListChoice component
Take a look at component Palette. It has something similar to sort selected options. Hi all, how can I sort ListChoice elements with moveUp and moveDown button? Thanks M -- Dott. Marco Di Sabatino Di Diodoro Tel. +39 3939065570 Tirasa S.r.l. Viale D'Annunzio 267 - 65127 Pescara Tel +39 0859116307 / FAX +39 085973 http://www.tirasa.net Apache Syncope PPMC Member http://people.apache.org/~mdisabatino - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: WiQuery SortableBehavior/DroppableBehavior questions
@Decebal: Thank you. I realized the problem lies somewhere around the model.. Changes in the sort order do get saved to the underlying .xml-file, but those changes won't get rendered by just doing an AJAX update. When I press F5 to make a browser refresh, the page gets rendered properly. The model is a LoadableDetachableModel. http://pastebin.com/5ReSqdJf - line 52: save changes to .xml - line 55: update ListView (parent of it) via AJAX - line 62: initialize ListView Model I double-checked I really update a parent container, and as far as I understand the LoadableDetachableModel, it loads its ressources everytime it is used. So when I re-render the component via AJAX, it should pull the current values from the .xml. But that does not happen, somehow.. And that the AJAX update actually DOES work, when I move an item from one to another list, confuses me even more.
Re: WiQuery SortableBehavior/DroppableBehavior questions
First, I think that line 55 is not necessary because jquery makes the modification on the client side. The important part is to save changes to xml (on the server side). Maybe a programmatic detach on your model resolves your problem. In the update method you make some modifications on response, the model object is in cache and detach method is call automatically by wicket at the end of request. Best regards, Decebal -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/WiQuery-SortableBehavior-DroppableBehavior-questions-tp4653349p4653448.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Atmosphere Application - Configuration
Hi, On Fri, Oct 26, 2012 at 8:13 PM, Nick Pratt nbpr...@gmail.com wrote: How do you configure a Spring+Wicket application that was being loaded via the WicketFilter and the SpringWebApplicationFactory to use Atmosphere. Specifically, how do I get the Atmosphere servlet to trigger the WicketApplication load via the Spring factory (so my App gets created via Spring)? afaik AtmosphereServlet dispatches to WicketFilter eventually so the way of doing is same as before. Also, for an application with context path of /foo, should I set param-namefilterMappingUrlPattern/param-name to be /foo/* for the AtmosphereServlet as well as servlet-mapping servlet-nameAtmosphereApplication/servlet-name url-pattern/foo/*/url-pattern /servlet-mapping looks ok Regards Nick -- regards, Vineet Semwal - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: WiQuery SortableBehavior/DroppableBehavior questions
Well, that was the cause for all that trouble. Such a pity I didn't think of it myself :P Sure, the view is already up-to-date after resorting it via jQuery. Everything's working now. Thanks a lot, Decebal
Re: Custom CSS for Feedback message is broken in 1.5
Hi, This would change be very well received, from my side. :-) :-) Cheers, Joachim Martin Grigorov wrote: Hi, [X] Other suggestion: (please specify) Here is what I think it should be: - div element should have class feedbackPanel (this is already the case) - li element(s) should have class that specifies the feedback message level (currently by default Wicket sets feedbackPanelLEVEL, but this is configurable with org.apache.wicket.markup.html.panel.FeedbackPanel#getCSSClass(FeedbackMessage)) - the span should not have class at all (currently it has the same class as the li element) - the styling should be done with CSS selectors (e.g. div.feedbackPanel; div.feedbackPanel li.alert-warn; div.feedbackPanel li.alert-warn span; ...) - if custom markup is needed then a custom FeedbackPanel is needed (one that extends from the default FeedbackPanel or a completely new one, it depends on the use case) On Sun, Oct 28, 2012 at 6:03 PM, Sebastien seb...@gmail.com wrote: Hi, To sum-up this thread: we have a (not huge, but still) design issue that annoys several users. A patch* has been provided but some questions remains... Given this, I would suggest a kind-of vote about the several points discussed earlier, in order to enlighten the dev-team about the preferred choice of their (beloved) users.** Here are some possible options: [ ] Please apply the patch as-is. It currently provides 2 methods (#getListCSSClass and #getLabelCSSClass), #getCSSClass is marked a deprecated until marked as private (or removed) [ ] Do not apply the patch as-is, #getCSSClass should be kept (not marked as deprecated) [ ] Do not apply the patch as-is, I do not agree with the 2 method names. I would have preferred: (please specify) [ ] This is not an issue; this does not need to be corrected [ ] Other suggestion: (please specify) Thanks in advance for your contribution, Sebastien (*) https://issues.apache.org/jira/browse/WICKET-4831 (**) Sure, dev-team opinion is also kindly asked! :) Joachim -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Joachim Schrod, Roedermark, Germany Email: jsch...@acm.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
