Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Nir Soffer has uploaded a new change for review.
Change subject: bootstrap: Return recovery error during lvm bootstrap
..
bootstrap: Return recovery error during lvm bootstrap
Since lvm bootstrap is performed in a background thread, it may not be
done when vdsm is asked to connect to stoarge pool or manipulate
images. This may lead to a race when lvm bootstrap thread is
deactivating a logical volume after engine asked to activate it.
This patch use the recovery mechanisim to respond with a recovery error
until lvm bootstrap is done, keeping backward compatibility with old
clients.
Before this patch, lvm bootstrap was avoiding such races for special
logical volumes by refrshing instead of deactivating. This may not be
needed any more, and may be removed in future patch.
Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm/BindingXMLRPC.py
M vdsm/clientIF.py
M vdsm/storage/hsm.py
3 files changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/21530/1
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fcd3221..c195219 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -984,10 +984,10 @@
# Ready to show the log into vdsm.log
f.im_self.log.log(logLevel, logStr)
-if f.im_self.cif._recovery:
-res = errCode['recovery']
-else:
+if f.im_self.cif.ready:
res = f(*args, **kwargs)
+else:
+res = errCode['recovery']
f.im_self.cif.log.log(logLevel, 'return %s with %s',
f.__name__, res)
return res
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 0b67e45..ac548a8 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -107,6 +107,10 @@
raise
self._prepareBindings()
+@property
+def ready(self):
+return (self.irs is None or self.irs.ready) and not self._recovery
+
def contEIOVms(self, sdUUID, isDomainStateValid):
# This method is called everytime the onDomainStateChange
# event is emitted, this event is emitted even when a domain goes
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index c8af8b1..2fbc086 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -329,6 +329,7 @@
for this thread
:type defExcFun: function
+self._ready = False
rm.ResourceManager.getInstance().registerNamespace(
STORAGE, rm.SimpleResourceFactory())
self.storage_repository = config.get('irs', 'repository')
@@ -374,7 +375,11 @@
self.log.warn(Failed to clean Storage Repository., exc_info=True)
def storageRefresh():
-lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS)
+try:
+lvm.bootstrap(blockSD.SPECIAL_LVS)
+finally:
+self._ready = True
+
sdCache.refreshStorage()
fileUtils.createdir(self.tasksDir)
@@ -405,6 +410,10 @@
monitorInterval = config.getint('irs', 'sd_health_check_delay')
self.domainMonitor = domainMonitor.DomainMonitor(monitorInterval)
+@property
+def ready(self):
+return self._ready
+
@public
def registerDomainStateChangeCallback(self, callbackFunc):
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: wait until lvm bootstrap is done before connecting to pool
Nir Soffer has abandoned this change. Change subject: hsm: wait until lvm bootstrap is done before connecting to pool .. Abandoned Replaced by http://gerrit.ovirt.org/21530 -- To view, visit http://gerrit.ovirt.org/21388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I22e851dca4c2063d19446f34897a7b208b9cace4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4808/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5608/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5691/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure cancellation of migrations gets handled correctly
oVirt Jenkins CI Server has posted comments on this change. Change subject: Ensure cancellation of migrations gets handled correctly .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4809/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5609/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5692/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Nir Soffer has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 1: (1 comment) File vdsm/storage/hsm.py Line 375: self.log.warn(Failed to clean Storage Repository., exc_info=True) Line 376: Line 377: def storageRefresh(): Line 378: try: Line 379: lvm.bootstrap(blockSD.SPECIAL_LVS) refreshlvs keyword arg will be restored in the next patch. Line 380: finally: Line 381: self._ready = True Line 382: Line 383: sdCache.refreshStorage() -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to Volume Create command
Aravinda VK has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 3: Updated the schema file. -- To view, visit http://gerrit.ovirt.org/21082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to Volume Create command
Aravinda VK has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/21082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to Volume Create command
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Add force option to Volume Create command .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4810/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5610/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5693/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b3a6f79c1473c4bc5d7976de20c03e1ac513af0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix ipwrapper Monitor for deleted links and oneline input
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix ipwrapper Monitor for deleted links and oneline input
..
Patch Set 3:
(3 comments)
File lib/vdsm/ipwrapper.py
Line 544: self.proc.kill()
Line 545:
Line 546: @classmethod
Line 547: def _parse(cls, text):
Line 548: deletionText = 'Deleted'
Done
Line 549: changes = []
Line 550: for line in text.splitlines():
Line 551: state = None
Line 552: if line.startswith(deletionText):
Line 549: changes = []
Line 550: for line in text.splitlines():
Line 551: state = None
Line 552: if line.startswith(deletionText):
Line 553: state = deletionText.upper()
Done
Line 554: line = line[len(deletionText):]
Line 555:
Line 556: _, device, data = [el.strip() for el in line.split(':',
2)]
Line 557: flagVal, _ = data.split('\\', 1) # We don't parse
link/ether
Line 552: if line.startswith(deletionText):
Line 553: state = deletionText.upper()
Line 554: line = line[len(deletionText):]
Line 555:
Line 556: _, device, data = [el.strip() for el in line.split(':',
2)]
Done
Line 557: flagVal, _ = data.split('\\', 1) # We don't parse
link/ether
Line 558:
Line 559: flags, values = data.split('')
Line 560: flags = frozenset(flags[1:].split(','))
--
To view, visit http://gerrit.ovirt.org/21411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: Move to using detailed oneline
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper Monitor: Move to using detailed oneline .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4811/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/836/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5694/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ipwrapper Monitor: fix for deleted links
..
ipwrapper Monitor: fix for deleted links
The previous parsing would not work when a link was deleted. This
patch fixes it and sets the state as DELETED on those cases.
Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
M tests/ipwrapperTests.py
2 files changed, 21 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/21534/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index cb029a6..bc7ee85 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -532,6 +532,8 @@
class Monitor(object):
Minimal wrapper over `ip monitor link`
+_DELETED_TEXT = 'Deleted'
+LINK_STATE_DELETED = 'DELETED'
def __init__(self):
self.proc = None
@@ -548,17 +550,22 @@
changes = []
for line in text.splitlines():
state = None
+if line.startswith(cls._DELETED_TEXT):
+state = cls.LINK_STATE_DELETED
+line = line[len(cls._DELETED_TEXT):]
+
_, device, data = [el.strip() for el in line.split(':', 2)]
flagVal, _ = data.split('\\', 1) # We don't parse link/ether
flags, values = data.split('')
flags = frozenset(flags[1:].split(','))
-values = (el for el in values.strip().split(' ') if el)
-for key, value in pairwise(values):
-if key == 'state':
-state = value
-break
+if state is None:
+values = (el for el in values.strip().split(' ') if el)
+for key, value in pairwise(values):
+if key == 'state':
+state = value
+break
changes.append(MonitorEvent(device, flags, state))
diff --git a/tests/ipwrapperTests.py b/tests/ipwrapperTests.py
index 7e0be2a..d85deb3 100644
--- a/tests/ipwrapperTests.py
+++ b/tests/ipwrapperTests.py
@@ -194,7 +194,10 @@
'noqueue state DOWN \\link/ether 33:44:55:66:77:88 brd '
'ff:ff:ff:ff:ff:ff \n'
'4: wlp3s0: BROADCAST,MULTICAST,UP,LOWER_UP \\'
- 'link/ether \n')
+ 'link/ether \n'
+ 'Deleted 418: foo: BROADCAST,MULTICAST mtu 1500 qdisc noop '
+ 'state DOWN group default \\link/ether ba:2c:7b:68:b8:77 '
+ 'brd ff:ff:ff:ff:ff:ff\n')
expected = [
MonitorEvent(
'bond0',
@@ -203,6 +206,10 @@
MonitorEvent(
'wlp3s0',
frozenset(['BROADCAST', 'MULTICAST', 'UP', 'LOWER_UP']),
-None)]
+None),
+MonitorEvent(
+'foo',
+frozenset(['BROADCAST', 'MULTICAST']),
+'DELETED')]
self.assertEqual(Monitor._parse(out), expected)
--
To view, visit http://gerrit.ovirt.org/21534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add 3.4. to clusterLevels and supportedENGINEs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add 3.4. to clusterLevels and supportedENGINEs. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4812/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5695/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceada517e2cd85a35264f9c60fc6f121f559f40d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper Monitor: fix for deleted links .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/837/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5696/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure cancellation of migrations gets handled correctly
Dan Kenigsberg has posted comments on this change. Change subject: Ensure cancellation of migrations gets handled correctly .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure cancellation of migrations gets handled correctly
Dan Kenigsberg has submitted this change and it was merged. Change subject: Ensure cancellation of migrations gets handled correctly .. Ensure cancellation of migrations gets handled correctly If the migration is cancelled before the source calls libvirt.migrateToURI2 we have to raise an libvirtError with the VIR_ERROR_OPERATION_ABORTED error code to ensure that _finishSuccessfully() does not get called and we're correctly reporting that the migration has been cancelled and that we're destroying the VM on the destination in the process, since we're bailing out. Additionally we'll do the check if the migration has been cancelled right after the semaphore has been accquired, to avoid doing things like calling the before_vm_migration_source hook and calling the destination vdsm to create the VM instance. Change-Id: Id271a41466bc355ca505f764206457af419f0edd Bug-Url: https://bugzilla.redhat.com/1023131 Signed-off-by: Martin Polednik mpole...@redhat.com Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21445 Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/vm.py 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add 3.4. to clusterLevels and supportedENGINEs.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add 3.4. to clusterLevels and supportedENGINEs. .. Add 3.4. to clusterLevels and supportedENGINEs. Add version 3.4. to clusterLevels and supportedENGINEs, returned by VDSM as part of engine calling getCapabilities. This allows to test 3.4 specific features from engine. Change-Id: Iceada517e2cd85a35264f9c60fc6f121f559f40d Signed-off-by: ndarshan dnara...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21443 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/dsaversion.py.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceada517e2cd85a35264f9c60fc6f121f559f40d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add 3.4. to clusterLevels and supportedENGINEs.
Dan Kenigsberg has posted comments on this change. Change subject: Add 3.4. to clusterLevels and supportedENGINEs. .. Patch Set 3: Verified+1 Code-Review+2 No need to verify. -- To view, visit http://gerrit.ovirt.org/21443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceada517e2cd85a35264f9c60fc6f121f559f40d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Ensure cancellation of migrations gets handled correctly
Hello Dan Kenigsberg, Michal Skrivanek, Martin Polednik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21536
to review the following change.
Change subject: Ensure cancellation of migrations gets handled correctly
..
Ensure cancellation of migrations gets handled correctly
If the migration is cancelled before the source calls libvirt.migrateToURI2
we have to raise an libvirtError with the VIR_ERROR_OPERATION_ABORTED error
code to ensure that _finishSuccessfully() does not get called and we're
correctly reporting that the migration has been cancelled and that we're
destroying the VM on the destination in the process, since we're bailing
out.
Additionally we'll do the check if the migration has been cancelled
right after the semaphore has been accquired, to avoid doing things
like calling the before_vm_migration_source hook and calling the
destination vdsm to create the VM instance.
Change-Id: Id271a41466bc355ca505f764206457af419f0edd
Bug-Url: https://bugzilla.redhat.com/1023131
Signed-off-by: Martin Polednik mpole...@redhat.com
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21445
Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/vm.py
1 file changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/21536/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 0921fb2..e64767b 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -145,7 +145,7 @@
'message': 'Migration in progress'},
'progress': 0}
threading.Thread.__init__(self)
-self._preparingMigrationEvt = False
+self._preparingMigrationEvt = True
self._migrationCanceledEvt = False
self._monitorThread = None
@@ -288,6 +288,19 @@
# vdsm 4.13 expect this to exist
self._machineParams['afterMigrationStatus'] = ''
+@staticmethod
+def _raiseAbortError():
+e = libvirt.libvirtError(defmsg='')
+# we have to override the value to get what we want
+# err might be None
+e.err = (libvirt.VIR_ERR_OPERATION_ABORTED, # error code
+ libvirt.VIR_FROM_QEMU, # error domain
+ 'operation aborted',# error message
+ libvirt.VIR_ERR_WARNING,# error level
+ '', '', '', # str1, str2, str3,
+ -1, -1) # int1, int2
+raise e
+
def run(self):
try:
mstate = ''
@@ -296,6 +309,8 @@
self._prepareGuest()
MigrationSourceThread._ongoingMigrations.acquire()
try:
+if self._migrationCanceledEvt:
+self._raiseAbortError()
self.log.debug(migration semaphore acquired)
if not mstate:
self._vm.conf['_migrationParams'] = {
@@ -321,7 +336,6 @@
self.log.error(Failed to migrate, exc_info=True)
def _startUnderlyingMigration(self):
-self._preparingMigrationEvt = True
if self._mode == 'file':
hooks.before_vm_hibernate(self._vm._dom.XMLDesc(0), self._vm.conf)
try:
@@ -383,6 +397,9 @@
(libvirt.VIR_MIGRATE_TUNNELLED if
self._tunneled else 0),
None, maxBandwidth)
+else:
+self._raiseAbortError()
+
finally:
t.cancel()
if MigrationMonitorThread._MIGRATION_MONITOR_INTERVAL:
--
To view, visit http://gerrit.ovirt.org/21536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Ensure cancellation of migrations gets handled correctly
Vinzenz Feenstra has posted comments on this change. Change subject: Ensure cancellation of migrations gets handled correctly .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Frank Kobzik has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 13: Guys, is this patch waiting for anything? Is it ok to merge? -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to add brick command
Timothy Asir has posted comments on this change.
Change subject: gluster: Add force option to add brick command
..
Patch Set 2:
(2 comments)
File vdsm/gluster/api.py
Line 109: self.svdsmProxy.glusterVolumeReset(volumeName, option, force)
Line 110:
Line 111: @exportAsVerb
Line 112: def volumeBrickAdd(self, volumeName, brickList,
Line 113:replicaCount=0, stripeCount=0, options=None):
Done
Line 114: self.svdsmProxy.glusterVolumeAddBrick(volumeName,
Line 115: brickList,
Line 116: replicaCount,
Line 117: stripeCount,
File vdsm/gluster/cli.py
Line 551: if replicaCount:
Line 552: command += [replica, %s % replicaCount]
Line 553: command += brickList
Line 554: if option:
Line 555: command.append('force')
Done
Line 556: try:
Line 557: _execGlusterXml(command)
Line 558: return True
Line 559: except ge.GlusterCmdFailedException as e:
--
To view, visit http://gerrit.ovirt.org/21525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Kanagaraj M kmayi...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Ensure cancellation of migrations gets handled correctly
Dan Kenigsberg has posted comments on this change. Change subject: Ensure cancellation of migrations gets handled correctly .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id271a41466bc355ca505f764206457af419f0edd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 13:
(3 comments)
Frank, it needs a review, and a little bit of extra work, I'm afraid.
File lib/vdsm/define.py
Line 146: ERROR = 1
Line 147: NORMAL = 0
Line 148:
Line 149:
Line 150: class RngSource:
I see no reason to have this class.
Please move this dictionary to caps.py, and call it RNG_SOURCES.
Then it could be safely used from caps.py and vm.py.
Line 151: PATH = {'random': '/dev/random',
File vdsm/caps.py
Line 309: caps['memSize'] = str(utils.readMemInfo()['MemTotal'] / 1024)
Line 310: caps['reservedMem'] = str(config.getint('vars',
'host_mem_reserve') +
Line 311: config.getint('vars',
'extra_mem_reserve'))
Line 312: caps['guestOverhead'] = config.get('vars', 'guest_ram_overhead')
Line 313: caps['rngSources'] = _getRngSources()
RNG_SOURCES.keys() would do right.
Line 314:
Line 315: return caps
Line 316:
Line 317:
File vdsm/vm.py
Line 1710:
Line 1711: rng.appendChildWithArgs('rate', None, **rateAttrs)
Line 1712:
Line 1713: # backend... / element
Line 1714: if self.specParams['source'] in RngSource.PATH:
It is impolite to ignore an explicit request by Engine. Vdsm reports its
supported source. If Engine has a bug and requests something that does not
exist, we should raise KeyError and explode.
Line 1715: rng.appendChildWithArgs('backend',
Line 1716:
RngSource.PATH[self.specParams['source']],
Line 1717: model='random')
Line 1718:
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 13: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster: correct parameter for creating hookpath in verb hoo...
Hello Bala.FA, Aravinda VK, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/21538 to review the following change. Change subject: gluster: correct parameter for creating hookpath in verb hookAdd. .. gluster: correct parameter for creating hookpath in verb hookAdd. parameter hookLevel must be in lower case for creating correct path for hook. so that parameter is changed to lower case. Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 https://bugzilla.redhat.com/show_bug.cgi?id=1028972 Signed-off-by: ndarshan dnara...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21017 Reviewed-by: Aravinda VK avish...@redhat.com Reviewed-by: Bala.FA barum...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/gluster/hooks.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/21538/1 diff --git a/vdsm/gluster/hooks.py b/vdsm/gluster/hooks.py index 914d09d..4f1c14d 100644 --- a/vdsm/gluster/hooks.py +++ b/vdsm/gluster/hooks.py @@ -244,7 +244,7 @@ @makePublic def hookAdd(glusterCmd, hookLevel, hookName, hookData, hookMd5Sum, enable=False): -hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel) +hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel.lower()) try: os.makedirs(hookPath) if selinux.is_selinux_enabled(): -- To view, visit http://gerrit.ovirt.org/21538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to add brick command
Timothy Asir has posted comments on this change. Change subject: gluster: Add force option to add brick command .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/21525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Kanagaraj M kmayi...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to add brick command
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Add force option to add brick command .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4814/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5614/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5697/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Kanagaraj M kmayi...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5615/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/838/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5698/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4816/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/839/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5699/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: Move to using detailed oneline
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper Monitor: Move to using detailed oneline .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4817/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5617/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/840/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5700/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper Monitor: fix for deleted links .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4818/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5618/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/841/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5701/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
Frank Kobzik has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 13: ok, thanks for response. -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Frank Kobzik fkob...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: Move to using detailed oneline
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper Monitor: Move to using detailed oneline
..
Patch Set 5: Verified+1 Code-Review+2
(1 comment)
File tests/ipwrapperTests.py
Line 189: for text in bad_rules:
Line 190: self.assertRaises(ValueError, Rule.fromText, text)
Line 191:
Line 192: def testMonitorEvents(self):
Line 193: out = ('273: bond0: BROADCAST,MULTICAST,MASTER mtu 1500
qdisc '
Frankly I prefer keeping qdisc with its value. But enough with nitpicking.
Line 194:'noqueue state DOWN \\link/ether 33:44:55:66:77:88
brd '
Line 195:'ff:ff:ff:ff:ff:ff \n'
Line 196:'4: wlp3s0: BROADCAST,MULTICAST,UP,LOWER_UP \\'
Line 197:'link/ether \n')
--
To view, visit http://gerrit.ovirt.org/21411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: Move to using detailed oneline
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper Monitor: Move to using detailed oneline .. ipwrapper Monitor: Move to using detailed oneline Change the ip monitor command to use the more machine readable ip -d -o monitor link (one line per link event). Change-Id: I1c593467d328c39654eae723126f889b51ff39d2 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21411 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/ipwrapper.py M tests/ipwrapperTests.py 2 files changed, 19 insertions(+), 16 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper Monitor: fix for deleted links .. Patch Set 2: Code-Review+2 That's so much clears now! -- To view, visit http://gerrit.ovirt.org/21534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netinfo/sampling: split speed into nic and bond specific methods
..
netinfo/sampling: split speed into nic and bond specific methods
Speed is calculated very differently for nics and bonds. This patch
splits the logic into two different methods and makes netinfo and
sampling use them.
Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
M vdsm/sampling.py
3 files changed, 42 insertions(+), 30 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/21542/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index ebfda41..5d3e0ae 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -178,6 +178,9 @@
detectedType = LinkType.NIC
return detectedType
+def isBOND(self):
+return self.type == LinkType.BOND
+
def isDUMMY(self):
return self.type == LinkType.DUMMY
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index dd54a96..2fcf431 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -264,34 +264,34 @@
return operstateFile.read().strip()
-def speed(dev):
-# return the speed of devices that are capable of replying
+def nicSpeed(nicName):
+Returns the nic speed if it is a legal value and nicName refers to a
+nic, 0 otherwise.
try:
-# operstat() filters out down/disabled nics
-if operstate(dev) != OPERSTATE_UP:
-return 0
-
-# nics() filters out OS devices (bonds, vlans, bridges)
-# virtio is a valid device, but doesn't support speed
-if dev in nics() and not isvirtio(dev):
-# the device may have been disabled/downed after checking
-# so we validate the return value as sysfs may return
-# special values to indicate the device is down/disabled
-with open('/sys/class/net/%s/speed' % dev) as speedFile:
-s = int(speedFile.read())
-if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s 0:
-return s
-elif dev in bondings():
-bondopts = bondOpts(dev, keys=['slaves', 'active_slave', 'mode'])
-if bondopts['slaves']:
-if bondopts['mode'][1] in _BONDING_FAILOVER_MODES:
-s = speed(bondopts['active_slave'][0])
-elif bondopts['mode'][1] in _BONDING_LOADBALANCE_MODES:
-s = sum(speed(slave) for slave in bondopts['slaves'])
-return s
-
+with open('/sys/class/net/%s/speed' % nicName) as speedFile:
+s = int(speedFile.read())
+if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s 0:
+return s
+except OSError as ose:
+if ose.errno != errno.ENOENT:
+logging.exception('cannot read %s nic speed', nicName)
except Exception:
-logging.exception('cannot read %s speed', dev)
+logging.exception('cannot read %s speed', nicName)
+return 0
+
+
+def bondSpeed(bondName):
+Returns the bond speed if bondName refers to a bond, 0 otherwise.
+opts = bondOpts(bondName, keys=['slaves', 'active_slave', 'mode'])
+try:
+if opts['slaves']:
+if opts['mode'][1] in _BONDING_FAILOVER_MODES:
+s = nicSpeed(opts['active_slave'][0])
+elif opts['mode'][1] in _BONDING_LOADBALANCE_MODES:
+s = sum(nicSpeed(slave) for slave in opts['slaves'])
+return s
+except Exception:
+logging.exception('cannot read %s speed', bondName)
return 0
@@ -522,7 +522,7 @@
def _nicinfo(nic, paddr):
info = _devinfo(nic)
-info.update({'hwaddr': gethwaddr(nic), 'speed': speed(nic)})
+info.update({'hwaddr': gethwaddr(nic), 'speed': nicSpeed(nic)})
if paddr.get(nic):
info['permhwaddr'] = paddr[nic]
return (nic, info)
diff --git a/vdsm/sampling.py b/vdsm/sampling.py
index d87f5bf..bc7acb5 100644
--- a/vdsm/sampling.py
+++ b/vdsm/sampling.py
@@ -35,6 +35,7 @@
from vdsm import utils
from vdsm import netinfo
+from vdsm.ipwrapper import getLinks
from vdsm.constants import P_VDSM_RUN
_THP_STATE_PATH = '/sys/kernel/mm/transparent_hugepage/enabled'
@@ -384,9 +385,17 @@
self._stopEvent.set()
def _updateIfidsIfrates(self):
-self._ifids = netinfo.nics() + netinfo.bondings() + netinfo.vlans() + \
-netinfo.bridges()
-self._ifrates = map(netinfo.speed, self._ifids)
+devices = getLinks()
+self._ifids = [dev.name for dev in devices]
+self._ifrates = []
+for dev in devices:
+if dev.isNIC():
+speed = netinfo.nicSpeed(dev.name)
+elif dev.isBOND():
+speed = netinfo.bondSpeed(dev.name)
+else:
+speed = 0
+
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4819/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5619/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/842/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5702/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5620/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/843/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5703/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper Monitor: fix for deleted links .. Patch Set 2: -Code-Review -- To view, visit http://gerrit.ovirt.org/21534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
Antoni Segura Puimedon has posted comments on this change. Change subject: ipwrapper Monitor: fix for deleted links .. Patch Set 2: Verified+1 Code-Review+1 Passed the unit tests and manual verification: on Ipython: In [6]: m = Monitor() In [7]: m.start() on a separate bash shell: sudo ip link add dumm type dummie sudo ip link del dumm type dummie on Ipython: In [8]: m.stop() In [9]: m.events() Out[9]: [MonitorEvent(device='dumm', flags=frozenset(['BROADCAST', 'NOARP']), state='DOWN'), MonitorEvent(device='dumm', flags=frozenset(['BROADCAST', 'NOARP']), state='DELETED')] -- To view, visit http://gerrit.ovirt.org/21534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper Monitor: fix for deleted links
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper Monitor: fix for deleted links .. ipwrapper Monitor: fix for deleted links The previous parsing would not work when a link was deleted. This patch fixes it and sets the state as DELETED on those cases. Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21534 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/ipwrapper.py M tests/ipwrapperTests.py 2 files changed, 21 insertions(+), 7 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2220d5b196efe1cc34821ff8145fbddcc431d7b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5704/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5622/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/845/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5705/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo/sampling: split speed into nic and bond specific methods
..
Patch Set 4:
(1 comment)
File lib/vdsm/netinfo.py
Line 268: Returns the nic speed if it is a legal value and nicName
refers to a
Line 269: nic, 0 otherwise.
Line 270: try:
Line 271: with open('/sys/class/net/%s/speed' % nicName) as speedFile:
Line 272: s = int(speedFile.read())
I found the long comment about these magic numbers quite helpful, and see no
reason to drop it.
Line 273: if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s 0:
Line 274: return s
Line 275: except OSError as ose:
Line 276: if ose.errno != errno.ENOENT:
--
To view, visit http://gerrit.ovirt.org/21542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo/sampling: split speed into nic and bond specific methods
..
Patch Set 4:
(1 comment)
File lib/vdsm/netinfo.py
Line 268: Returns the nic speed if it is a legal value and nicName
refers to a
Line 269: nic, 0 otherwise.
Line 270: try:
Line 271: with open('/sys/class/net/%s/speed' % nicName) as speedFile:
Line 272: s = int(speedFile.read())
True! I shouldn't remove these things.
Line 273: if s not in (2 ** 16 - 1, 2 ** 32 - 1) or s 0:
Line 274: return s
Line 275: except OSError as ose:
Line 276: if ose.errno != errno.ENOENT:
--
To view, visit http://gerrit.ovirt.org/21542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4823/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/846/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5706/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert gluster prepareImage: return gluster-specific inform...
Federico Simoncelli has posted comments on this change. Change subject: Revert gluster prepareImage: return gluster-specific information .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90be682593183434012ddfd5578af38bfa2e0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't try to get speed for bonds with no active_slave
Antoni Segura Puimedon has uploaded a new change for review. Change subject: Don't try to get speed for bonds with no active_slave .. Don't try to get speed for bonds with no active_slave When a failover bond doesn't have active_slave speed will be 0. Change-Id: I082308b8126b58db2599e072974653d94dafd9e1 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M lib/vdsm/netinfo.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/21553/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index 0ac5b7d..9ce6975 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -290,7 +290,8 @@ try: if opts['slaves']: if opts['mode'][1] in _BONDING_FAILOVER_MODES: -s = nicSpeed(opts['active_slave'][0]) +active_slave = opts['active_slave'][0] +s = nicSpeed(active_slave) if active_slave else 0 elif opts['mode'][1] in _BONDING_LOADBALANCE_MODES: s = sum(nicSpeed(slave) for slave in opts['slaves']) return s -- To view, visit http://gerrit.ovirt.org/21553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I082308b8126b58db2599e072974653d94dafd9e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5624/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/847/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5707/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add asynchronous operation to the monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add asynchronous operation to the monitor .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5625/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/848/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5708/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ca850fc324a5b4c0268541fd4d4d062706a159 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert gluster prepareImage: return gluster-specific inform...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert gluster prepareImage: return gluster-specific information .. Revert gluster prepareImage: return gluster-specific information This reverts commit 51081b81de8cda48e0060e which is universally known to be quite ugly, and is also unhelpful since we do not support gluster-based VM with snapshots. Change-Id: I9b90be682593183434012ddfd5578af38bfa2e0b Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21508 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Federico Simoncelli: Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit http://gerrit.ovirt.org/21508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b90be682593183434012ddfd5578af38bfa2e0b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert gluster prepareImage: return gluster-specific inform...
Dan Kenigsberg has posted comments on this change. Change subject: Revert gluster prepareImage: return gluster-specific information .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b90be682593183434012ddfd5578af38bfa2e0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Keeping gluster modules when with_gluster set to 0
Dan Kenigsberg has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo/sampling: split speed into nic and bond specific methods
..
Patch Set 6: Code-Review+2
(1 comment)
File lib/vdsm/netinfo.py
Line 212: else:
Line 213: paths = (BONDING_OPT % (bond, key) for key in keys)
Line 214: opts = {}
Line 215: for path in paths:
Line 216: with open(path) as optFile:
please remember to fix bondOpts so that an empty string translates to an empty
list, not to [''].
Line 217: opts[os.path.basename(path)] =
optFile.read().rstrip().split(' ')
Line 218: return opts
Line 219:
Line 220:
--
To view, visit http://gerrit.ovirt.org/21542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 6: Verified+1 verified base start-up and uts -- To view, visit http://gerrit.ovirt.org/21477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4826/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5709/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5627/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/850/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5710/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 6: Code-Review-1 (3 comments) Commit Message Line 10: Line 11: 1. Make get() retrieve all the links at once and aggregate Line 12:information from those links (instead of calling nics, bondings, Line 13:etc). Line 14: 2. Add the needed convenience methos in ipwrapper's Link so (2) is methos-methods you probably mean so (1) is much simpler. But it would be simpler to just make this addition of convenience methods, and simplification of isHidden() in a separate patch... Line 15:much simpler. Line 16: 3. Increase the consistency of the netinfo testsuite so that if we Line 17:were to use the master fields they would be correct and pointing to Line 18:an existent device. Line 14: 2. Add the needed convenience methos in ipwrapper's Link so (2) is Line 15:much simpler. Line 16: 3. Increase the consistency of the netinfo testsuite so that if we Line 17:were to use the master fields they would be correct and pointing to Line 18:an existent device. existent-existing. improving the testsuit is honorable, but then again - a separate issue. Line 19: 4. NET_PATH is not being used in netinfo anymore. Move it to Line 20:ipwrapper where it is used (otherwise pep8 would report error due Line 21:to unused constant. Line 22: Line 15:much simpler. Line 16: 3. Increase the consistency of the netinfo testsuite so that if we Line 17:were to use the master fields they would be correct and pointing to Line 18:an existent device. Line 19: 4. NET_PATH is not being used in netinfo anymore. Move it to 4 is not done, right? Line 20:ipwrapper where it is used (otherwise pep8 would report error due Line 21:to unused constant. Line 22: Line 23: Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Keeping gluster modules when with_gluster set to 0
Dan Kenigsberg has submitted this change and it was merged. Change subject: Keeping gluster modules when with_gluster set to 0 .. Keeping gluster modules when with_gluster set to 0 Currently the code imports and uses gluster modules. Setting with_gluster=0 brakes the code. With this patch with_gluster=0 will only drop the vdsm-gluster rpm creation. Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21477 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in M vdsm/supervdsmServer 2 files changed, 9 insertions(+), 11 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5713/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
Federico Simoncelli has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 3: Verified+1 Verified: rpm build successfully -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts
..
bondOpts: Fix reporting [] instead of [''] for empty opts
Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/netinfo.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/21554/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index dd54a96..28643e8 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -214,7 +214,8 @@
opts = {}
for path in paths:
with open(path) as optFile:
-opts[os.path.basename(path)] = optFile.read().rstrip().split(' ')
+opts[os.path.basename(path)] = [
+el for el in optFile.read().rstrip().split(' ') if el]
return opts
--
To view, visit http://gerrit.ovirt.org/21554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't try to get speed for bonds with no (active) slave
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't try to get speed for bonds with no (active) slave .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/851/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5711/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082308b8126b58db2599e072974653d94dafd9e1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Keeping gluster modules when with_gluster set to 0
Yaniv Bronhaim has posted comments on this change. Change subject: Keeping gluster modules when with_gluster set to 0 .. Patch Set 7: backport to 3.3, right? -- To view, visit http://gerrit.ovirt.org/21477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cdbd8b399652bf0d306308e2d4cfc0014be689c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5714/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused scsiFencing parameter
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove unused scsiFencing parameter
..
sp: remove unused scsiFencing parameter
Change-Id: I7d9b62c08cf8925fbc1856655dc49dd41eacd2d9
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
4 files changed, 13 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/21555/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 67ce3b7..7014f38 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -742,8 +742,10 @@
return 0, ''
def spmStart(self, args):
-validateArgTypes(args, [str, int, int, int, str, int, int],
- requiredArgsNumber=5)
+validateArgTypes(args, [str, int, int, int, int, int],
+ requiredArgsNumber=4)
+# adding parameters for backward compatibility
+args.insert(4, ) # scsiFencing
status = self.s.spmStart(*args)
if status['status']['code']:
return status['status']['code'], status['status']['message']
@@ -2078,8 +2080,7 @@
'entity (server)'
)),
'spmStart': (serv.spmStart,
- ('spUUID prevID prevLVER recoveryMode '
- 'scsiFencing maxHostID version',
+ ('spUUID recoveryMode maxHostID version',
'Start SPM functionality'
)),
'spmStop': (serv.spmStop,
diff --git a/vdsm/API.py b/vdsm/API.py
index c799090..f2b0895 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1045,7 +1045,7 @@
maxHostID = storage.clusterlock.MAX_HOST_ID
recoveryMode = None # unused
return self._irs.spmStart(self._UUID, prevID, prevLver, recoveryMode,
- enableScsiFencing, maxHostID, domVersion)
+ maxHostID, domVersion)
def spmStop(self):
return self._irs.spmStop(self._UUID)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index fcf2e3f..a8039ec 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -541,7 +541,7 @@
return dict(poollist=self.pools.keys())
@public
-def spmStart(self, spUUID, prevID, prevLVER, recoveryMode, scsiFencing,
+def spmStart(self, spUUID, prevID, prevLVER, recoveryMode,
maxHostID=clusterlock.MAX_HOST_ID, domVersion=None,
options=None):
@@ -556,8 +556,6 @@
:type prevLVER: int
:param recoveryMode: The mode in which to recover the SPM.
:type recoveryMode: RecoveryEnum?
-:param scsiFencing: Do you want to fence the scsi.
-:type scsiFencing: bool
:param maxHostID: The maximum Host ID in the cluster.
:type maxHostID: int
:param options: unused
@@ -566,11 +564,10 @@
:rtype: UUID
-argsStr = (spUUID=%s, prevID=%s, prevLVER=%s, recoveryMode=%s,
- scsiFencing=%s, maxHostID=%s, domVersion=%s %
- (spUUID, prevID, prevLVER, recoveryMode, scsiFencing,
-maxHostID, domVersion))
-vars.task.setDefaultException(se.SpmStartError(%s % (argsStr)))
+vars.task.setDefaultException(se.SpmStartError(
+spUUID=%s, prevID=%s, prevLVER=%s, recoveryMode=%s,
+maxHostID=%s, domVersion=%s % (spUUID, prevID, prevLVER,
+recoveryMode, maxHostID, domVersion)))
if domVersion is not None:
domVersion = int(domVersion)
@@ -592,7 +589,7 @@
vars.task.setManager(self.taskMng)
vars.task.setRecoveryPolicy(auto)
vars.task.addJob(Job(spmStart, pool.startSpm, prevID, prevLVER,
- scsiFencing, maxHostID, domVersion))
+ maxHostID, domVersion))
@public
def spmStop(self, spUUID, options=None):
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 8682b9c..de7c264 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -222,8 +222,7 @@
pass
@unsecured
-def startSpm(self, prevID, prevLVER, scsiFencing, maxHostID,
- expectedDomVersion=None):
+def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):
Starts the SPM functionality.
@@ -232,8 +231,6 @@
:type spUUID: UUID
:param prevID: obsolete
:param prevLVER: obsolete
-:param scsiFencing: Should there be scsi fencing.?
-:type scsiFencing: bool
:param maxHostID: The maximun ID of the host.?
:type maxHostID: int
--
To view, visit http://gerrit.ovirt.org/21555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Change in vdsm[master]: sp: remove unused recoveryMode from spmStart
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove unused recoveryMode from spmStart
..
sp: remove unused recoveryMode from spmStart
Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
4 files changed, 10 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/21556/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 7014f38..6c2cacc 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -742,9 +742,10 @@
return 0, ''
def spmStart(self, args):
-validateArgTypes(args, [str, int, int, int, int, int],
+validateArgTypes(args, [str, int, int, int, int],
requiredArgsNumber=4)
# adding parameters for backward compatibility
+args.insert(3, 0) # recoveryMode
args.insert(4, ) # scsiFencing
status = self.s.spmStart(*args)
if status['status']['code']:
@@ -2080,7 +2081,7 @@
'entity (server)'
)),
'spmStart': (serv.spmStart,
- ('spUUID recoveryMode maxHostID version',
+ ('spUUID maxHostID version',
'Start SPM functionality'
)),
'spmStop': (serv.spmStop,
diff --git a/vdsm/API.py b/vdsm/API.py
index f2b0895..c59c0cc 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1043,9 +1043,8 @@
maxHostID=None, domVersion=None):
if maxHostID is None:
maxHostID = storage.clusterlock.MAX_HOST_ID
-recoveryMode = None # unused
-return self._irs.spmStart(self._UUID, prevID, prevLver, recoveryMode,
- maxHostID, domVersion)
+return self._irs.spmStart(self._UUID, prevID, prevLver, maxHostID,
+ domVersion)
def spmStop(self):
return self._irs.spmStop(self._UUID)
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fcd3221..96b9e88 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -640,8 +640,8 @@
scsiFencing, maxHostID=None,
domVersion=None, options=None):
pool = API.StoragePool(spUUID)
-return pool.spmStart(prevID, prevLVER, scsiFencing,
- maxHostID, domVersion)
+return pool.spmStart(prevID, prevLVER, scsiFencing, maxHostID,
+ domVersion)
def poolSpmStop(self, spUUID, options=None):
pool = API.StoragePool(spUUID)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index a8039ec..1f63785 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -541,7 +541,7 @@
return dict(poollist=self.pools.keys())
@public
-def spmStart(self, spUUID, prevID, prevLVER, recoveryMode,
+def spmStart(self, spUUID, prevID, prevLVER,
maxHostID=clusterlock.MAX_HOST_ID, domVersion=None,
options=None):
@@ -554,8 +554,6 @@
:param prevLVER: The previous version of the pool that was managed by
the SPM.
:type prevLVER: int
-:param recoveryMode: The mode in which to recover the SPM.
-:type recoveryMode: RecoveryEnum?
:param maxHostID: The maximum Host ID in the cluster.
:type maxHostID: int
:param options: unused
@@ -565,9 +563,8 @@
vars.task.setDefaultException(se.SpmStartError(
-spUUID=%s, prevID=%s, prevLVER=%s, recoveryMode=%s,
-maxHostID=%s, domVersion=%s % (spUUID, prevID, prevLVER,
-recoveryMode, maxHostID, domVersion)))
+spUUID=%s, prevID=%s, prevLVER=%s, maxHostID=%s, domVersion=%s
+% (spUUID, prevID, prevLVER, maxHostID, domVersion)))
if domVersion is not None:
domVersion = int(domVersion)
--
To view, visit http://gerrit.ovirt.org/21556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove scsiKey from connectStoragePool
Federico Simoncelli has uploaded a new change for review. Change subject: sp: remove scsiKey from connectStoragePool .. sp: remove scsiKey from connectStoragePool Change-Id: I39c02f9256b1ef802ca4ec434a19aeecfea1f87a Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/API.py M vdsm/storage/hsm.py M vdsm/storage/sp.py 3 files changed, 34 insertions(+), 45 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/21557/1 diff --git a/vdsm/API.py b/vdsm/API.py index c59c0cc..ba47955 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -963,7 +963,7 @@ self._UUID = UUID def connect(self, hostID, scsiKey, masterSdUUID, masterVersion): -return self._irs.connectStoragePool(self._UUID, hostID, scsiKey, +return self._irs.connectStoragePool(self._UUID, hostID, masterSdUUID, masterVersion) def connectStorageServer(self, domainType, connectionParams): @@ -981,11 +981,10 @@ ioOpTimeoutSec, leaseRetries) def destroy(self, hostID, scsiKey): -return self._irs.destroyStoragePool(self._UUID, hostID, scsiKey) +return self._irs.destroyStoragePool(self._UUID, hostID) def disconnect(self, hostID, scsiKey, remove): -return self._irs.disconnectStoragePool(self._UUID, hostID, scsiKey, - remove) +return self._irs.disconnectStoragePool(self._UUID, hostID, remove) def disconnectStorageServer(self, domainType, connectionParams): return self._irs.disconnectStorageServer(domainType, self._UUID, diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 1f63785..c3820b2 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -878,7 +878,7 @@ self.validateSdUUID(msdUUID) pool.refresh(msdUUID, masterVersion) except: -self._disconnectPool(pool, pool.id, pool.scsiKey, False) +self._disconnectPool(pool, pool.id, False) raise if pool.hsmMailer: @@ -977,8 +977,8 @@ poolName, masterDom, domList, masterVersion, leaseParams) @public -def connectStoragePool(self, spUUID, hostID, scsiKey, - msdUUID, masterVersion, options=None): +def connectStoragePool(self, spUUID, hostID, msdUUID, masterVersion, + options=None): Connect a Host to a specific storage pool. @@ -986,7 +986,6 @@ :type spUUID: UUID :param hostID: The hostID to be used for clustered locking. :type hostID: int -:param scsiKey: ? :param msdUUID: The UUID for the pool's master domain. :type msdUUID: UUID :param masterVersion: The expected master version. Used for validation. @@ -1001,15 +1000,14 @@ vars.task.setDefaultException( se.StoragePoolConnectionError( -spUUID=%s, msdUUID=%s, masterVersion=%s, hostID=%s, -scsiKey=%s % (spUUID, msdUUID, masterVersion, -hostID, scsiKey))) +spUUID=%s, msdUUID=%s, masterVersion=%s, hostID=%s, % +(spUUID, msdUUID, masterVersion, hostID))) with rmanager.acquireResource(STORAGE, HSM_DOM_MON_LOCK, rm.LockType.exclusive): -return self._connectStoragePool(spUUID, hostID, scsiKey, msdUUID, +return self._connectStoragePool(spUUID, hostID, msdUUID, masterVersion, options) -def _connectStoragePool(self, spUUID, hostID, scsiKey, msdUUID, +def _connectStoragePool(self, spUUID, hostID, msdUUID, masterVersion, options=None): misc.validateUUID(spUUID, 'spUUID') @@ -1024,7 +1022,7 @@ pass # pool not connected yet else: with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.shared): -pool.update(hostID, scsiKey, msdUUID, masterVersion) +pool.update(hostID, msdUUID, masterVersion) return True with rmanager.acquireResource(STORAGE, spUUID, rm.LockType.exclusive): @@ -1033,11 +1031,11 @@ except se.StoragePoolUnknown: pass # pool not connected yet else: -pool.update(hostID, scsiKey, msdUUID, masterVersion) +pool.update(hostID, msdUUID, masterVersion) return True pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) -res = pool.connect(hostID, scsiKey, msdUUID, masterVersion) +res = pool.connect(hostID, msdUUID, masterVersion) if res: self.pools[spUUID] = pool for callback in self.domainStateChangeCallbacks: @@ -1046,7 +1044,7 @@ return res
Change in vdsm[master]: sp: turn spm status attributes private
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: turn spm status attributes private .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5634/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5717/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 14: Code-Review-1 (3 comments) File lib/vdsm/utils.py Line 103: return stat.S_ISBLK(os.stat(path).st_mode) Line 104: Line 105: Line 106: def touchFile(filePath, ignoreExceptions=False): Line 107: ohh love it, Thanks! :) but.. can you please separate this to another patch and I'll comment there? Line 108: Subset of POSIX touch functionality Line 109: :param filePath: The file to touch Line 110: :param ignoreExceptions: Should file handling exceptions be ignored? Line 111: File vdsm/logger.conf.in Line 1: [loggers] Line 2: keys=root,vds,Storage,metadata you need to define your new logger Line 3: Line 4: [handlers] Line 5: keys=console,syslog,logfile,metadata Line 6: Line 1: [loggers] Line 2: keys=root,vds,Storage,metadata Line 3: Line 4: [handlers] Line 5: keys=console,syslog,logfile,metadata and your new handler.. Line 6: Line 7: [formatters] Line 8: keys=long,simple,none,sysform Line 9: -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused recoveryMode from spmStart
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove unused recoveryMode from spmStart .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4836/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5719/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove scsiKey from connectStoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove scsiKey from connectStoragePool .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4837/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5720/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c02f9256b1ef802ca4ec434a19aeecfea1f87a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't try to get speed for bonds with no active_slave
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't try to get speed for bonds with no active_slave .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/852/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5712/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082308b8126b58db2599e072974653d94dafd9e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 18: Code-Review-1 (1 comment) one last comment File lib/vdsm/tool/unified_persistence.py Line 138: Line 139: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded(): Line 140: upgrade.log.debug(Running upgrade %s % upgradeName) Line 141: unifiedPersistenceUpgrade.run() Line 142: upgrade.seal() as a command you should return 0 on success or always, raise exception on failure -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused scsiFencing parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove unused scsiFencing parameter .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4835/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5635/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5718/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d9b62c08cf8925fbc1856655dc49dd41eacd2d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move reconnection info check to StoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4833/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5633/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5716/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: fix missing method in TransportWrapper
Federico Simoncelli has abandoned this change. Change subject: vdscli: fix missing method in TransportWrapper .. Abandoned -- To view, visit http://gerrit.ovirt.org/21429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id25df21af1a9c9350876198d02f5f87ee49295fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4832/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/853/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5715/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't try to get speed for bonds with no active_slave
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't try to get speed for bonds with no active_slave .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4838/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/854/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5721/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082308b8126b58db2599e072974653d94dafd9e1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Yaniv Bronhaim has posted comments on this change. Change subject: bootstrap: Return recovery error during lvm bootstrap .. Patch Set 1: Code-Review-1 (2 comments) File vdsm/clientIF.py Line 108: self._prepareBindings() Line 109: Line 110: @property Line 111: def ready(self): Line 112: return (self.irs is None or self.irs.ready) and not self._recovery you'll get AttributeError here Line 113: Line 114: def contEIOVms(self, sdUUID, isDomainStateValid): Line 115: # This method is called everytime the onDomainStateChange Line 116: # event is emitted, this event is emitted even when a domain goes File vdsm/storage/hsm.py Line 377: def storageRefresh(): Line 378: try: Line 379: lvm.bootstrap(blockSD.SPECIAL_LVS) Line 380: finally: Line 381: self._ready = True if that's the case, make it synchronized. get the must end part out of the external thread, unless you have something important to do meanwhile .. Line 382: Line 383: sdCache.refreshStorage() Line 384: Line 385: fileUtils.createdir(self.tasksDir) -- To view, visit http://gerrit.ovirt.org/21530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 11: Code-Review+1
(1 comment)
File vdsm/caps.py
Line 204: vendor = None
Line 205: allModels[m.getAttribute('name')] = vendor
Line 206:
Line 207: return allModels
Line 208: except:
some would say that you should be more exception specific here. but if they
mind they can raise it themselves
Line 209: logging.error('Error while getting all CPU models',
exc_info=True)
Line 210: return {}
Line 211:
Line 212:
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: just a suggestion: to have unique uuid for the host during deploy process, i recommend to modify also lib/vdsm/utils.py:getHostUUID that uses dmidecode command explicitly -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/855/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5722/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
mtayer told me that he wants to comment something here.. otherwise you would
have my +1 already.
Line 662: # hack until we replace core dump with abrt
Line 663:
Line 664: %if 0%{?rhel}
Line 665: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
Ok, thanks Yaniv. /me waiting his comments.
Line 662: # hack until we replace core dump with abrt
Line 663:
Line 664: %if 0%{?rhel}
Line 665: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
Yaniv Bronhaim has posted comments on this change. Change subject: generate qemu-kvm coredumps using abrt .. Patch Set 7: (6 comments) Commit Message Line 3: AuthorDate: 2013-10-30 16:02:10 +0200 Line 4: Commit: Mooli Tayer mta...@redhat.com Line 5: CommitDate: 2013-11-21 10:58:52 +0200 Line 6: Line 7: generate qemu-kvm coredumps using abrt I would say, removing core dump configuration from vdsm and start using abrt service as a substitute Line 8: Line 9: Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 File init/systemd/vdsmd.service.in Line 6: Conflicts=libvirt-guests.service ksmtuned.service Line 7: Line 8: [Service] Line 9: Type=simple Line 10: LimitCORE=infinity is LimitCore can be removed too? Line 11: EnvironmentFile=-/etc/sysconfig/vdsm Line 12: ExecStartPre=@LIBEXECDIR@/vdsmd_init_common.sh --pre-start Line 13: ExecStart=@VDSMDIR@/daemonAdapter -0 /dev/null -1 /dev/null -2 /dev/null @VDSMDIR@/vdsm Line 14: ExecStopPost=@LIBEXECDIR@/vdsmd_init_common.sh --post-stop File init/sysvinit/vdsmd.init.in Line 25: prog=vdsm Line 26: PIDFILE=@VDSMRUNDIR@/vdsmd.pid Line 27: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 28: NEEDED_SERVICES=iscsid multipathd rpcbind ntpd wdmd sanlock network libvirtd Line 29: supervdsmd abrtd should be stated also in init/upstart/vdsmd.upstart Line 30: CONFLICTING_SERVICES=libvirt-guests ksmtuned Line 31: LOCK_FILE=/var/lock/subsys/vdsmd Line 32: VDSM_TOOL=@BINDIR@/vdsm-tool Line 33: NICE_LOWEST=-20 File init/vdsmd_init_common.sh.in Line 21 Line 22 Line 23 Line 24 Line 25 abrt conf should be configured? (http://linux.die.net/man/5/abrt.conf) File lib/vdsm/config.py.in Line 26 Line 27 Line 28 Line 29 Line 30 can't be that user will want to disable also the abrt's coredumps ?.. it might consume some memory that can be important to some.. File vdsm/vdsm Line 163 Line 164 Line 165 Line 166 Line 167 does rlimit configure effects abrt? if is, should you initialize it? -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster prepareImage: return gluster-specific information
Yaniv Bronhaim has posted comments on this change. Change subject: gluster prepareImage: return gluster-specific information .. Patch Set 1: Code-Review-2 we just reverted this change from master. any reason why to backport it? -- To view, visit http://gerrit.ovirt.org/21151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a8fbf2baafa1f9bfc3677b1301c7934ca74651 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Don't try to get speed for bonds with no active_slave
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't try to get speed for bonds with no active_slave .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4840/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/856/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5723/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I082308b8126b58db2599e072974653d94dafd9e1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: pep8: Fix indentation to comply with pep8 1.3.3
Yaniv Bronhaim has submitted this change and it was merged. Change subject: pep8: Fix indentation to comply with pep8 1.3.3 .. pep8: Fix indentation to comply with pep8 1.3.3 Commit 2c9f0d66db7795 introduced a pep8 indentation regression, breaking the build on RHEL using vdsm provided pep8. This patch fixes the indentation by breaking long statement to multiple lines. Change-Id: I3431742f9dbfd86a9816c7b3c6de90e282dbd415 Relates-To: https://bugzilla.redhat.com/1022975 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21055 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21196 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/storage/imageRepository/formatConverter.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3431742f9dbfd86a9816c7b3c6de90e282dbd415 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: pep8: Fix indentation to comply with pep8 1.3.3
Yaniv Bronhaim has posted comments on this change. Change subject: pep8: Fix indentation to comply with pep8 1.3.3 .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3431742f9dbfd86a9816c7b3c6de90e282dbd415 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
guess it relates to http://gerrit.ovirt.org/#/c/21290/1/vdsm.spec.in
Line 662: # hack until we replace core dump with abrt
Line 663:
Line 664: %if 0%{?rhel}
Line 665: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
Antoni Segura Puimedon has posted comments on this change. Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
Antoni Segura Puimedon has posted comments on this change. Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts .. Patch Set 1: -Verified -- To view, visit http://gerrit.ovirt.org/21554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix the premature selinux dependency fix
Yaniv Bronhaim has posted comments on this change. Change subject: fix the premature selinux dependency fix .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts .. Patch Set 1: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4832/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/853/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5724/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
Antoni Segura Puimedon has posted comments on this change.
Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts
..
Patch Set 2: Verified+1
Manual verification:
In [1]: from vdsm import netinfo
In [2]: netinfo.bondOpts('bond777')
Out[2]:
{'active_slave': [],
'ad_actor_key': [],
'ad_aggregator': [],
'ad_num_ports': [],
'ad_partner_key': [],
'ad_partner_mac': [],
'ad_select': ['stable', '0'],
'all_slaves_active': ['0'],
'arp_all_targets': ['any', '0'],
'arp_interval': ['0'],
'arp_ip_target': [],
'arp_validate': ['none', '0'],
'downdelay': ['0'],
'fail_over_mac': ['none', '0'],
'lacp_rate': ['slow', '0'],
'lp_interval': ['1'],
'mii_status': ['up'],
'miimon': ['100'],
'min_links': ['0'],
'mode': ['broadcast', '3'],
'num_grat_arp': ['1'],
'num_unsol_na': ['1'],
'primary': [],
'primary_reselect': ['always', '0'],
'queue_id': ['dummy_888:0', 'dummy_999:0'],
'resend_igmp': ['1'],
'slaves': ['dummy_888', 'dummy_999'],
'updelay': ['0'],
'use_carrier': ['1'],
'xmit_hash_policy': ['layer2', '0']}
In [3]: netinfo.speed('bond777')
Out[3]: 0
In [4]: netinfo.bondOpts('bond0')
Out[4]:
{'active_slave': [],
'ad_actor_key': ['0'],
'ad_aggregator': ['0'],
'ad_num_ports': ['0'],
'ad_partner_key': ['0'],
'ad_partner_mac': [],
'ad_select': ['stable', '0'],
'all_slaves_active': ['0'],
'arp_all_targets': ['any', '0'],
'arp_interval': ['0'],
'arp_ip_target': [],
'arp_validate': ['none', '0'],
'downdelay': ['0'],
'fail_over_mac': ['none', '0'],
'lacp_rate': ['slow', '0'],
'lp_interval': ['1'],
'mii_status': ['down'],
'miimon': ['9'],
'min_links': ['0'],
'mode': ['802.3ad', '4'],
'num_grat_arp': ['1'],
'num_unsol_na': ['1'],
'primary': [],
'primary_reselect': ['always', '0'],
'queue_id': [],
'resend_igmp': ['1'],
'slaves': [],
'updelay': ['0'],
'use_carrier': ['1'],
'xmit_hash_policy': ['layer2', '0']}
In [5]: netinfo.speed('bond0')
Out[5]: 0
--
To view, visit http://gerrit.ovirt.org/21554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bondOpts: Fix reporting [] instead of [''] for empty opts
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondOpts: Fix reporting [] instead of [''] for empty opts .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5641/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/857/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5725/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20963543ec6b0f9ff42c02431ec9758d7de0531e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5642/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5726/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5643/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/859/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5727/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo/sampling: split speed into nic and bond specific met...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo/sampling: split speed into nic and bond specific methods .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5644/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/860/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5728/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d02ce7dec2cafec99478f3b5f089f1fce76d7e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
