Re: Patch 7.1.243
On Fri 8-Feb-08 3:31am -0600, Tony Mechelynck wrote: Bill McCarthy wrote: On Wed 6-Feb-08 9:33pm -0600, Charles E. Campbell, Jr. wrote: Bill McCarthy wrote: On Wed 6-Feb-08 9:15 am -0600, Bream Molten wrote: Patch 7.1.243 (after 7.1.240) Problem:U doesn't work on all text in Visual mode. (Adri Verhoef) Solution: Loop over all the lines to be changed. Add tests for this. Files: src/ops.c, src/testdir/test39.in, src/testdir/test39.ok I have sequentially applied all prior patches, yet: patching file src/ops.c Hunk #1 FAILED at 2197. Hunk #2 FAILED at 2242. Hunk #3 FAILED at 2325. 3 out of 3 hunks FAILED -- saving rejects to file src/ops.c.rej patching file src/testdir/test39.in Hunk #1 FAILED at 1. Hunk #2 FAILED at 16. 2 out of 2 hunks FAILED -- saving rejects to file src/testdir/test39.in.rej patching file src/testdir/test39.ok patching file src/version.c After obtaining the patched files from the SVN repository, I applied 244 without a problem. Hmm -- I've been sequentially applying the patches, and have had no problems thus far. I get them via ftp. Thanks for your response, Chip. This may be a failure of my email program - The Bat!. I see the problem (the non-printable characters less than decimal 31 and greater than decimal 127). I get my patches here. I usually get export to gVim - that passes the data in RFC-822 compliant format. I tried exporting to a file as a Unix mailbox and then editing that file with gVim - same problem. Even the first patch for ops.c (which contains non of these special characters) had a few =20 things. Is the email we are receiving from the list correct? Is anyone else having problems with patches containing characters outside the 31-127 range? If so, than perhaps Bram should give us a warning on such patches - i.e. get these from the FTP site. I've had problems in the past when getting patches from the mail: not necessarily any fault of Bram's, my ISP's mail servers sometimes (apparently unpredictably) convert mail either way between 8bit and quoted-printable. Now when an email is encoded in quoted-printable format (as shown by the Content-Transfer-Encoding header) some special characters are recoded by means of a notation starting with an equal sign, meaning that the equal sign itself acquires a special meaning in the message as transmitted. Most mail clients are aware of this and decode the quoted-printable format to make it readable, but if you save the mail as rfc822 it will still be in quoted-printable and thus not in a format acceptable by the patch program. Quoted-printable means the following: - An equal sign at the end of a line means continuation: this line should be joined to the next one by removal of both the equal sign and the line break; - An equal sign followed by two hex digits should be replaced by the corresponding byte (for example, =3D in Latin1 quoted-printable means a true equal sign); - After the above transformations, the result should be interpreted according to the encoding defined by the charset attribute in the Content-Type header. Thanks for that detailed explanation of what's going on and how one could deal with it. Patches on the FTP site -- at ftp://ftp.vim.org/pub/vim/patches/7.1/ -- don't need all the above conversions, they are in whatever format Bram used before any quoted-printable conversion (usually in 8-bit Latin1, sometimes --when necessary-- in UTF-8). I'm convinced :-) From now on I patch only from the FTP site. BTW, it still requires one conversion - since my source is in DOS format. However I already have that built into my patch alias. I still think it would be nice if the patch emails contained a warning whenever there are any characters in the range of [^\t -~]. -- Best regards, Bill --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Patch 7.1.243
Bill McCarthy wrote: [...] I'm convinced :-) From now on I patch only from the FTP site. Sometimes (rarely) a patch will appear on the vim_dev list and not immediately on the FTP site. (It always does eventually appear -- sometimes the day after.) BTW, it still requires one conversion - since my source is in DOS format. However I already have that built into my patch alias. It may depend on which compiler you're using, but I've never had problems with sources in Unix 'fileformat', not even on Windows. It is true that even when I was on Windows, I never compiled Vim using the Microsoft Visual-C compiler (I used first Borland's BCC 5, and then, when I encountered problems with BCC32 and multibyte functions on Win98, I used Cygwin gcc). Vim itself can also source scripts in Unix format (on non-Unix OSes, this requires that 'fileformats' includes unix, which is the default in 'nocompatible' mode). For the patching operation itself, I found out that all patch programs that I tried on Windows, except the one from Cygwin, would choke on the Vim patches. I still think it would be nice if the patch emails contained a warning whenever there are any characters in the range of [^\t -~]. other than tab or 20-7E; yes; but the equal sign is also transformed in quoted-printable, and sometimes the space. IIUC, Bram nowadays normally sends the patches in 8bit format, which is easier for us; but as I said, some ISPs' mail routers (including mine's) convert between Content-Transfer-Encodings (8bit, quoted-printable, base64, ...). Best regards, Tony. -- He was not in the least bit scared to be mashed into a pulp Or to have his eyes gouged out and his elbows broken; To have his kneecaps split and his body burned away And his limbs all hacked and mangled, brave Sir Robin. Monty Python and the Holy Grail PYTHON (MONTY) PICTURES LTD --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Patch 7.1.243
On Wed 6-Feb-08 9:33pm -0600, Charles E. Campbell, Jr. wrote: Bill McCarthy wrote: On Wed 6-Feb-08 9:15 am -0600, Bream Molten wrote: Patch 7.1.243 (after 7.1.240) Problem:U doesn't work on all text in Visual mode. (Adri Verhoef) Solution: Loop over all the lines to be changed. Add tests for this. Files: src/ops.c, src/testdir/test39.in, src/testdir/test39.ok I have sequentially applied all prior patches, yet: patching file src/ops.c Hunk #1 FAILED at 2197. Hunk #2 FAILED at 2242. Hunk #3 FAILED at 2325. 3 out of 3 hunks FAILED -- saving rejects to file src/ops.c.rej patching file src/testdir/test39.in Hunk #1 FAILED at 1. Hunk #2 FAILED at 16. 2 out of 2 hunks FAILED -- saving rejects to file src/testdir/test39.in.rej patching file src/testdir/test39.ok patching file src/version.c After obtaining the patched files from the SVN repository, I applied 244 without a problem. Hmm -- I've been sequentially applying the patches, and have had no problems thus far. I get them via ftp. Thanks for your response, Chip. This may be a failure of my email program - The Bat!. I see the problem (the non-printable characters less than decimal 31 and greater than decimal 127). I get my patches here. I usually get export to gVim - that passes the data in RFC-822 compliant format. I tried exporting to a file as a Unix mailbox and then editing that file with gVim - same problem. Even the first patch for ops.c (which contains non of these special characters) had a few =20 things. Is the email we are receiving from the list correct? Is anyone else having problems with patches containing characters outside the 31-127 range? If so, than perhaps Bram should give us a warning on such patches - i.e. get these from the FTP site. -- Best regards, Bill --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Patch 7.1.243
On Thu, Feb 07, 2008 at 09:02:28PM -0600, Bill McCarthy wrote: This may be a failure of my email program - The Bat!. I see the problem (the non-printable characters less than decimal 31 and greater than decimal 127). At least for mutt, you can perform a decoding save via EscC and the resulting file will be fine. I'm not sure if The Bat! has something similar, but I'd think most mail clients should. Might just have to dig around in the docs. James -- GPG Key: 1024D/61326D40 2003-09-02 James Vega [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: Patch 7.1.243
On Thu 7-Feb-08 10:15pm -0600, James Vega wrote: On Thu, Feb 07, 2008 at 09:02:28PM -0600, Bill McCarthy wrote: This may be a failure of my email program - The Bat!. I see the problem (the non-printable characters less than decimal 31 and greater than decimal 127). At least for mutt, you can perform a decoding save via EscC and the resulting file will be fine. I'm not sure if The Bat! has something similar, but I'd think most mail clients should. Might just have to dig around in the docs. Thanks, James, I'll pass this along to The Bat! technical support. -- Best regards, Bill --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Patch 7.1.243
(1) Just write an ß, go to Normal mode and do U. The ß gets killed. Do U again and the ß appears again. You can do this repeatedly. (2) Just write a line containing an ß. Visual select the whole line and do U. The line is uppercase afterwards. Now do U repeatedly. The whole line disappears, appears, disappears ... (3) Write a line without any ß. Visual select the whole line and do U. The line is upercase afterwards and the Visual selection is gone (which is ok). But if you do U repeatedly now, you will see the whole line alternate between lowercase and uppercase. None of these are bugs. In normal mode, U means single-line undo/redo. Only with a visual selection does it mean uppercase. gU means uppercase in normal mode as well as visual mode. In normal mode it is an operator that should be followed by a motion. Cheers, Ben. Send instant messages to your online friends http://au.messenger.yahoo.com --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Patch 7.1.243
On Wed 6-Feb-08 9:15 am -0600, Bream Molten wrote: Patch 7.1.243 (after 7.1.240) Problem:U doesn't work on all text in Visual mode. (Adri Verhoef) Solution: Loop over all the lines to be changed. Add tests for this. Files: src/ops.c, src/testdir/test39.in, src/testdir/test39.ok I have sequentially applied all prior patches, yet: patching file src/ops.c Hunk #1 FAILED at 2197. Hunk #2 FAILED at 2242. Hunk #3 FAILED at 2325. 3 out of 3 hunks FAILED -- saving rejects to file src/ops.c.rej patching file src/testdir/test39.in Hunk #1 FAILED at 1. Hunk #2 FAILED at 16. 2 out of 2 hunks FAILED -- saving rejects to file src/testdir/test39.in.rej patching file src/testdir/test39.ok patching file src/version.c After obtaining the patched files from the SVN repository, I applied 244 without a problem. -- Best regards, Bill --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
