date:20180108

[webkit-changes] [226616] trunk/Source/JavaScriptCore

2018-01-08 Thread zandobersek

Title: [226616] trunk/Source/_javascript_Core








Revision 226616
Author zandober...@gmail.com
Date 2018-01-08 23:17:06 -0800 (Mon, 08 Jan 2018)


Log Message
REGRESSION(r225913): about 30 JSC test failures on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=181162


Unreviewed follow-up to r226298. Enable the fast case in
DFG::SpeculativeJIT::compileArraySlice() for any 64-bit platform,
assuming in good faith that enough GP registers are available on any
such configuration. The accompanying comment is adjusted to describe
this assumption.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArraySlice):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226615 => 226616)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-09 07:10:36 UTC (rev 226615)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-09 07:17:06 UTC (rev 226616)
@@ -1,3 +1,18 @@
+2018-01-08  Zan Dobersek  
+
+REGRESSION(r225913): about 30 JSC test failures on ARMv7
+https://bugs.webkit.org/show_bug.cgi?id=181162
+
+
+Unreviewed follow-up to r226298. Enable the fast case in
+DFG::SpeculativeJIT::compileArraySlice() for any 64-bit platform,
+assuming in good faith that enough GP registers are available on any
+such configuration. The accompanying comment is adjusted to describe
+this assumption.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileArraySlice):
+
 2018-01-08  JF Bastien  
 
 WebAssembly: mask indexed accesses to Table


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (226615 => 226616)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-09 07:10:36 UTC (rev 226615)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-09 07:17:06 UTC (rev 226616)
@@ -7639,8 +7639,9 @@
 
 MacroAssembler::JumpList slowCases;
 m_jit.move(TrustedImmPtr(0), storageResultGPR);
-// X86 only has 6 GP registers, which is not enough for the fast case here. At least without custom code, which is not currently worth the extra code maintenance.
-if (isARM64() || isX86_64()) {
+// Enable the fast case on 64-bit platforms, where a sufficient amount of GP registers should be available.
+// Other platforms could support the same approach with custom code, but that is not currently worth the extra code maintenance.
+if (is64Bit()) {
 GPRTemporary scratch(this);
 GPRTemporary scratch2(this);
 GPRTemporary indexingMask(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226614] trunk

2018-01-08 Thread commit-queue

Title: [226614] trunk








Revision 226614
Author commit-qu...@webkit.org
Date 2018-01-08 22:41:18 -0800 (Mon, 08 Jan 2018)


Log Message
::first-letter incorrectly selects grapheme pairs
https://bugs.webkit.org/show_bug.cgi?id=181315

Patch by Chris Nardi  on 2018-01-08
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Updated css-pseudo-4 to latest WPT revision and added first-letter-004.html.

* web-platform-tests/css/css-pseudo-4/first-letter-004-expected.html: Added.
* web-platform-tests/css/css-pseudo-4/first-letter-004.html: Added.
* web-platform-tests/css/css-pseudo-4/marker-color-expected.html:
* web-platform-tests/css/css-pseudo-4/marker-color.html:
* web-platform-tests/css/css-pseudo-4/marker-font-properties.html:
* web-platform-tests/css/css-pseudo-4/w3c-import.log:

Source/WebCore:

Grapheme pairs were incorrectly selected by ::first-letter. This
change fixes their selection.

Tests: Updated fast/css/first-letter-punctuation.html and imported
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/first-letter-004.html

* rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::isPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):

LayoutTests:

* fast/css/first-letter-punctuation-expected.html: Added.
* fast/css/first-letter-punctuation.html:
* platform/gtk/fast/css/first-letter-punctuation-expected.png: Removed.
* platform/gtk/fast/css/first-letter-punctuation-expected.txt: Removed.
* platform/ios/fast/css/first-letter-punctuation-expected.txt: Removed.
* platform/mac/fast/css/first-letter-punctuation-expected.png: Removed.
* platform/mac/fast/css/first-letter-punctuation-expected.txt: Removed.
* platform/win/fast/css/first-letter-punctuation-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/first-letter-punctuation.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/marker-color-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/marker-color.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/marker-font-properties.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp


Added Paths

trunk/LayoutTests/fast/css/first-letter-punctuation-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/first-letter-004-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo-4/first-letter-004.html


Removed Paths

trunk/LayoutTests/platform/gtk/fast/css/first-letter-punctuation-expected.png
trunk/LayoutTests/platform/gtk/fast/css/first-letter-punctuation-expected.txt
trunk/LayoutTests/platform/ios/fast/css/first-letter-punctuation-expected.txt
trunk/LayoutTests/platform/mac/fast/css/first-letter-punctuation-expected.png
trunk/LayoutTests/platform/mac/fast/css/first-letter-punctuation-expected.txt
trunk/LayoutTests/platform/win/fast/css/first-letter-punctuation-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (226613 => 226614)

--- trunk/LayoutTests/ChangeLog	2018-01-09 06:19:20 UTC (rev 226613)
+++ trunk/LayoutTests/ChangeLog	2018-01-09 06:41:18 UTC (rev 226614)
@@ -1,3 +1,19 @@
+2018-01-08  Chris Nardi  
+
+::first-letter incorrectly selects grapheme pairs
+https://bugs.webkit.org/show_bug.cgi?id=181315
+
+Reviewed by Darin Adler.
+
+* fast/css/first-letter-punctuation-expected.html: Added.
+* fast/css/first-letter-punctuation.html:
+* platform/gtk/fast/css/first-letter-punctuation-expected.png: Removed.
+* platform/gtk/fast/css/first-letter-punctuation-expected.txt: Removed.
+* platform/ios/fast/css/first-letter-punctuation-expected.txt: Removed.
+* platform/mac/fast/css/first-letter-punctuation-expected.png: Removed.
+* platform/mac/fast/css/first-letter-punctuation-expected.txt: Removed.
+* platform/win/fast/css/first-letter-punctuation-expected.txt: Removed.
+
 2018-01-08  Darin Adler  
 
 Special list-item counter starts from an incorrect number for ::before and ::after


Added: trunk/LayoutTests/fast/css/first-letter-punctuation-expected.html (0 => 226614)

--- trunk/LayoutTests/fast/css/first-letter-punctuation-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css/first-letter-punctuation-expected.html	2018-01-09 06:41:18 UTC (rev 226614)
@@ -0,0 +1,20 @@
+
+
+
+
+.bigGreenText
+{
+color: green;
+font-size: 36px;
+}
+
+
+
+Test passes if all the T and surrounding punctuation are green.
+(T)est
+Test
+Test
+Test
+Test
+
+
\ No newline at end

[webkit-changes] [226613] trunk

2018-01-08 Thread darin

Title: [226613] trunk








Revision 226613
Author da...@apple.com
Date 2018-01-08 22:19:20 -0800 (Mon, 08 Jan 2018)


Log Message
Special list-item counter starts from an incorrect number for ::before and ::after
https://bugs.webkit.org/show_bug.cgi?id=181084

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/css/counters/counter-list-item.html

* Sources.txt: Removed CounterDirectives.cpp.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::counterToCSSValue): Updated for changes to the CounterDirectives struct.
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInheritCounter): Ditto.
(WebCore::StyleBuilderCustom::applyValueCounter): Ditto.

* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::parseValue): Call setExplicitValue(std::nullopt) instead
of clearExplicitValue since we are using std::optional now.

* rendering/RenderCounter.cpp:
(WebCore::listItemCounterDirectives): Added. Computes the counter directives that
express the effects on the list-item counter from list item and list elements.
Used something as close to what the CSS 3 draft says as possible. This uses a
negative increment when creating a list to counteract the positive increment done
by a list element, except in the case of an unordered list. This is where the bug
fix actually lies. Also fixed handling of reversed ordered lists at the same time.
(WebCore::planCounter): Refactored to use the function above. Also changed the
code to pay attention to both the counter directives and the implicit ones from
list item and list elements, getting as close as possible to what the specification
seems to call for.

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem): Since we are using std::optional and no
longer using bit fields, simplified the constructor for each list item.
(WebCore::RenderListItem::calcValue const): Deleted.
(WebCore::RenderListItem::updateValueNow const): Merged in all the code from the
old calcValue function, but it is also simpler now since m_value is std::optional.
(WebCore::RenderListItem::updateValue): Updated to use std::optional.
(WebCore::RenderListItem::setExplicitValue): Ditto.
(WebCore::RenderListItem::clearExplicitValue): Deleted.
(WebCore::RenderListItem::updateListMarkerNumbers): Updated to use std::optional.
(WebCore::RenderListItem::isInReversedOrderedList const): Added. This is used by
the counter code so it can decrement instead of incrementing.

* rendering/RenderListItem.h: Updated to use std::optional. Also marked functions
final instead of override and initialized m_notInList after making it not be a
bitfield any more.

* rendering/style/CounterDirectives.cpp: Removed.
* rendering/style/CounterDirectives.h: Removed most of the CounterDirectives
class and replaced it with a struct with two std::optional. Added an addClamped
function so the counter code can share it with the addIncrementValue function.
If we want to make a faster version that doesn't use double, we can come back
and do that. Also moved the == function to the header since the implementation
is so trivial.

* rendering/style/StyleAllInOne.cpp: Removed CounterDirectives.cpp.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Updated to
use std::make_unique directly instead of using a clone function.

LayoutTests:

* fast/css/counters/counter-list-item-expected.html: Added.
* fast/css/counters/counter-list-item.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/StyleBuilderCustom.h
trunk/Source/WebCore/html/HTMLLIElement.cpp
trunk/Source/WebCore/rendering/RenderCounter.cpp
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderListItem.h
trunk/Source/WebCore/rendering/style/CounterDirectives.h
trunk/Source/WebCore/rendering/style/StyleAllInOne.cpp
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp


Added Paths

trunk/LayoutTests/fast/css/counters/counter-list-item-expected.html
trunk/LayoutTests/fast/css/counters/counter-list-item.html


Removed Paths

trunk/Source/WebCore/rendering/style/CounterDirectives.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (226612 => 226613)

--- trunk/LayoutTests/ChangeLog	2018-01-09 04:08:21 UTC (rev 226612)
+++ trunk/LayoutTests/ChangeLog	2018-01-09 06:19:20 UTC (rev 226613)
@@ -1,3 +1,13 @@
+2018-01-08  Darin Adler  
+
+Special list-item counter starts from an incorrect number for ::before and ::after
+https://bugs.webkit.org/show_bug.cgi?id=181084
+
+Reviewed by Zalan Bujtas.
+
+* fast/css/counters/counter-list-item-expected.html: Added.
+* fast/css/counters/counter-list-item.html: Added.
+
 2018-01-08  Said Abou-Hallawa

[webkit-changes] [226612] trunk

2018-01-08 Thread wenson_hsieh

Title: [226612] trunk








Revision 226612
Author wenson_hs...@apple.com
Date 2018-01-08 20:08:21 -0800 (Mon, 08 Jan 2018)


Log Message
[Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
https://bugs.webkit.org/show_bug.cgi?id=181420


Reviewed by Alex Christensen.

Source/WebCore:

Add a new IDL definition for uniqueIdentifier on HTMLAttachmentElement. This allows clients to relate attachment
elements in the DOM to _WKAttachments delivered via Objective-C SPI.

Adjusted existing tests in WKAttachmentTests.

* html/HTMLAttachmentElement.idl:

Tools:

Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
of corresponding _WKAttachments.

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAttachmentElement.idl
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (226611 => 226612)

--- trunk/Source/WebCore/ChangeLog	2018-01-09 03:52:49 UTC (rev 226611)
+++ trunk/Source/WebCore/ChangeLog	2018-01-09 04:08:21 UTC (rev 226612)
@@ -1,3 +1,18 @@
+2018-01-08  Wenson Hsieh  
+
+[Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
+https://bugs.webkit.org/show_bug.cgi?id=181420
+
+
+Reviewed by Alex Christensen.
+
+Add a new IDL definition for uniqueIdentifier on HTMLAttachmentElement. This allows clients to relate attachment
+elements in the DOM to _WKAttachments delivered via Objective-C SPI.
+
+Adjusted existing tests in WKAttachmentTests.
+
+* html/HTMLAttachmentElement.idl:
+
 2018-01-08  Don Olmstead  
 
 AccessibilityARIAGrid does not compile when accessibility is disabled


Modified: trunk/Source/WebCore/html/HTMLAttachmentElement.idl (226611 => 226612)

--- trunk/Source/WebCore/html/HTMLAttachmentElement.idl	2018-01-09 03:52:49 UTC (rev 226611)
+++ trunk/Source/WebCore/html/HTMLAttachmentElement.idl	2018-01-09 04:08:21 UTC (rev 226612)
@@ -28,4 +28,5 @@
 EnabledAtRuntime=AttachmentElement,
 ] interface HTMLAttachmentElement : HTMLElement {
 attribute File? file;
+readonly attribute DOMString uniqueIdentifier;
 };


Modified: trunk/Tools/ChangeLog (226611 => 226612)

--- trunk/Tools/ChangeLog	2018-01-09 03:52:49 UTC (rev 226611)
+++ trunk/Tools/ChangeLog	2018-01-09 04:08:21 UTC (rev 226612)
@@ -1,3 +1,17 @@
+2018-01-08  Wenson Hsieh  
+
+[Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
+https://bugs.webkit.org/show_bug.cgi?id=181420
+
+
+Reviewed by Alex Christensen.
+
+Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
+of corresponding _WKAttachments.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+(TestWebKitAPI::TEST):
+
 2018-01-08  Alex Christensen  
 
 Add WKNavigationDelegate SPI exposing WebProcess crash reason


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (226611 => 226612)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm	2018-01-09 03:52:49 UTC (rev 226611)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm	2018-01-09 04:08:21 UTC (rev 226612)
@@ -570,6 +570,7 @@
 EXPECT_FALSE([webView hasAttribute:@"webkitattachmentbloburl" forQuerySelector:@"attachment"]);
 EXPECT_FALSE([webView hasAttribute:@"webkitattachmentpath" forQuerySelector:@"attachment"]);
 EXPECT_FALSE([webView hasAttribute:@"webkitattachmentid" forQuerySelector:@"attachment"]);
+EXPECT_WK_STREQ([attachment uniqueIdentifier], [webView stringByEvaluatingJavaScript:@"document.querySelector('attachment').uniqueIdentifier"]);
 {
 ObserveAttachmentUpdatesForScope observer(webView.get());
 [webView stringByEvaluatingJavaScript:@"document.querySelector('attachment').remove()"];
@@ -589,6 +590,7 @@
 observer.expectAttachmentUpdates(@[], @[attachment.get()]);
 }
 [attachment expectRequestedDataToBe:testHTMLData()];
+EXPECT_WK_STREQ([attachment uniqueIdentifier], [webView stringByEvaluatingJavaScript:@"document.querySelector('attachment').uniqueIdentifier"]);
 [webView _synchronouslyExecuteEditCommand:@"SelectAll" argument:nil];
 {
 ObserveAttachmentUpdatesForScope observer(webView.get());
@@ -617,6 +619,7 @@
 observer.expectAttachmentUpdates(@[], @[attachment.get()]);
 }
 [attachment expectRequestedDataToBe:[NSData data]];
+EXPECT_WK_STREQ([attachment uniqueIdentifier], [webView stringByEvaluatingJavaScript:@"document.querySelector('attachment').uniqueIdentifier"]);
 {
 ObserveAttachmentUpdatesForScope

[webkit-changes] [226611] trunk/Source

2018-01-08 Thread jmarcell

Title: [226611] trunk/Source








Revision 226611
Author jmarc...@apple.com
Date 2018-01-08 19:52:49 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -1,6 +1,6 @@
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (226610 => 226611)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-09 03:27:20 UTC (rev 226610)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-09 03:52:49 UTC (rev 226611)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 605;
+MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;

[webkit-changes] [226610] trunk

2018-01-08 Thread achristensen

Title: [226610] trunk








Revision 226610
Author achristen...@apple.com
Date 2018-01-08 19:27:20 -0800 (Mon, 08 Jan 2018)


Log Message
Add WKNavigationDelegate SPI exposing WebProcess crash reason
https://bugs.webkit.org/show_bug.cgi?id=181410


Reviewed by Wenson Hsieh.

Source/WebKit:

We exposed it in the C SPI.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::toWKProcessTerminationReason):
(WebKit::NavigationState::NavigationClient::processDidTerminate):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (226609 => 226610)

--- trunk/Source/WebKit/ChangeLog	2018-01-09 03:26:18 UTC (rev 226609)
+++ trunk/Source/WebKit/ChangeLog	2018-01-09 03:27:20 UTC (rev 226610)
@@ -1,5 +1,22 @@
 2018-01-08  Alex Christensen  
 
+Add WKNavigationDelegate SPI exposing WebProcess crash reason
+https://bugs.webkit.org/show_bug.cgi?id=181410
+
+
+Reviewed by Wenson Hsieh.
+
+We exposed it in the C SPI.
+
+* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
+* UIProcess/Cocoa/NavigationState.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+(WebKit::toWKProcessTerminationReason):
+(WebKit::NavigationState::NavigationClient::processDidTerminate):
+
+2018-01-08  Alex Christensen  
+
 Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad
 https://bugs.webkit.org/show_bug.cgi?id=181413
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h (226609 => 226610)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h	2018-01-09 03:26:18 UTC (rev 226609)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h	2018-01-09 03:27:20 UTC (rev 226610)
@@ -48,6 +48,13 @@
 } WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 #endif
 
+typedef NS_ENUM(NSInteger, _WKProcessTerminationReason) {
+_WKProcessTerminationReasonExceededMemoryLimit,
+_WKProcessTerminationReasonExceededCPULimit,
+_WKProcessTerminationReasonRequestedByClient,
+_WKProcessTerminationReasonCrash,
+} WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 static const WKNavigationActionPolicy _WKNavigationActionPolicyDownload = (WKNavigationActionPolicy)(WKNavigationActionPolicyAllow + 1);
 static const WKNavigationActionPolicy WK_API_AVAILABLE(macosx(10.11), ios(9.0)) _WKNavigationActionPolicyAllowWithoutTryingAppLink = (WKNavigationActionPolicy)(WKNavigationActionPolicyAllow + 2);
 
@@ -89,6 +96,7 @@
 - (void)_webView:(WKWebView *)webView didFailNavigation:(WKNavigation *)navigation withError:(NSError *)error userInfo:(id )userInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 - (void)_webView:(WKWebView *)webView URL:(NSURL *)url contentRuleListIdentifiers:(NSArray *)identifiers notifications:(NSArray *)notifications WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
+- (void)_webView:(WKWebView *)webView webContentProcessDidTerminateWithReason:(_WKProcessTerminationReason)reason WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 #if TARGET_OS_IPHONE
 - (void)_webView:(WKWebView *)webView didStartLoadForQuickLookDocumentInMainFrameWithFileName:(NSString *)fileName uti:(NSString *)uti;


Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h (226609 => 226610)

--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h	2018-01-09 03:26:18 UTC (rev 226609)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h	2018-01-09 03:27:20 UTC (rev 226610)
@@ -198,6 +198,7 @@
 bool webViewRenderingProgressDidChange : 1;
 bool webViewDidReceiveAuthenticationChallengeCompletionHandler : 1;
 bool webViewWebContentProcessDidTerminate : 1;
+bool webViewWebContentProcessDidTerminateWithReason : 1;
 bool webViewCanAuthenticateAgainstProtectionSpace : 1;
 bool webViewDidReceiveAuthenticationChallenge : 1;
 bool webViewWebProcessDidCrash : 1;


Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm (226609 => 226610)

--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm	2018-01-09 03:26:18 UTC (rev 226609)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm	2018-01-09 03:27:20 UTC (rev 226610)
@@ -162,6 +162,7 @@
 m_navigationDelegateMethods.webViewRenderingProgressDidChange = [delegate

[webkit-changes] [226609] trunk/Source/WebKit

2018-01-08 Thread achristensen

Title: [226609] trunk/Source/WebKit








Revision 226609
Author achristen...@apple.com
Date 2018-01-08 19:26:18 -0800 (Mon, 08 Jan 2018)


Log Message
Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad
https://bugs.webkit.org/show_bug.cgi?id=181413


Reviewed by Wenson Hsieh.

* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::decidePolicyForPluginLoad):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageNavigationClient):
* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::toWKPluginModuleLoadPolicy):
(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APILoaderClient.h
trunk/Source/WebKit/UIProcess/API/APINavigationClient.h
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (226608 => 226609)

--- trunk/Source/WebKit/ChangeLog	2018-01-09 03:08:47 UTC (rev 226608)
+++ trunk/Source/WebKit/ChangeLog	2018-01-09 03:26:18 UTC (rev 226609)
@@ -1,3 +1,25 @@
+2018-01-08  Alex Christensen  
+
+Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad
+https://bugs.webkit.org/show_bug.cgi?id=181413
+
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/API/APINavigationClient.h:
+(API::NavigationClient::decidePolicyForPluginLoad):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageNavigationClient):
+* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
+* UIProcess/Cocoa/NavigationState.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+(WebKit::toPluginModuleLoadPolicy):
+(WebKit::toWKPluginModuleLoadPolicy):
+(WebKit::NavigationState::NavigationClient::decidePolicyForPluginLoad):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::findPlugin):
+
 2018-01-08  Ryosuke Niwa  
 
 iOS build fix attempt after r226602.


Modified: trunk/Source/WebKit/UIProcess/API/APILoaderClient.h (226608 => 226609)

--- trunk/Source/WebKit/UIProcess/API/APILoaderClient.h	2018-01-09 03:08:47 UTC (rev 226608)
+++ trunk/Source/WebKit/UIProcess/API/APILoaderClient.h	2018-01-09 03:26:18 UTC (rev 226609)
@@ -103,7 +103,7 @@
 virtual void navigationGestureDidEnd(WebKit::WebPageProxy&, bool willNavigate, WebKit::WebBackForwardListItem&) { }
 
 #if ENABLE(NETSCAPE_PLUGIN_API)
-virtual WebKit::PluginModuleLoadPolicy pluginLoadPolicy(WebKit::WebPageProxy&, WebKit::PluginModuleLoadPolicy currentPluginLoadPolicy, API::Dictionary*, WTF::String& /* unavailabilityDescription */) { return currentPluginLoadPolicy; }
+virtual WebKit::PluginModuleLoadPolicy pluginLoadPolicy(WebKit::WebPageProxy&, WebKit::PluginModuleLoadPolicy currentPluginLoadPolicy, API::Dictionary&, WTF::String& /* unavailabilityDescription */) { return currentPluginLoadPolicy; }
 virtual void didFailToInitializePlugin(WebKit::WebPageProxy&, API::Dictionary&) { }
 virtual void didBlockInsecurePluginVersion(WebKit::WebPageProxy&, API::Dictionary*) { }
 #endif // ENABLE(NETSCAPE_PLUGIN_API)


Modified: trunk/Source/WebKit/UIProcess/API/APINavigationClient.h (226608 => 226609)

--- trunk/Source/WebKit/UIProcess/API/APINavigationClient.h	2018-01-09 03:08:47 UTC (rev 226608)
+++ trunk/Source/WebKit/UIProcess/API/APINavigationClient.h	2018-01-09 03:26:18 UTC (rev 226609)
@@ -113,7 +113,7 @@
 
 #if ENABLE(NETSCAPE_PLUGIN_API)
 virtual bool didFailToInitializePlugIn(WebKit::WebPageProxy&, API::Dictionary&) { return false; }
-virtual WebKit::PluginModuleLoadPolicy decidePolicyForPluginLoad(WebKit::WebPageProxy&, WebKit::PluginModuleLoadPolicy currentPluginLoadPolicy, Dictionary*, WTF::String&)
+virtual WebKit::PluginModuleLoadPolicy decidePolicyForPluginLoad(WebKit::WebPageProxy&, WebKit::PluginModuleLoadPolicy currentPluginLoadPolicy, Dictionary&, WTF::String&)
 {
 return currentPluginLoadPolicy;
 }


Modified: trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp (226608 => 226609)

--- trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp	2018-01-09 03:08:47 UTC (rev 226608)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp	2018-01-09 03:26:18 UTC (rev 226609)
@@ -1278,15 +1278,15 @@
 m_client.pluginDidFail(toAPI(), kWKErrorCodeInsecurePlugInVersion, toAPI(pluginInformation), m_client.base.clientInfo);
 }
 
-PluginModuleLoadPolicy

[webkit-changes] [226608] trunk/Source/WebKit

2018-01-08 Thread rniwa

Title: [226608] trunk/Source/WebKit








Revision 226608
Author rn...@webkit.org
Date 2018-01-08 19:08:47 -0800 (Mon, 08 Jan 2018)


Log Message
iOS build fix attempt after r226602.

* UIProcess/API/C/WKContextMenuListener.cpp:
(WKContextMenuListenerUseContextMenuItems):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (226607 => 226608)

--- trunk/Source/WebKit/ChangeLog	2018-01-09 02:56:05 UTC (rev 226607)
+++ trunk/Source/WebKit/ChangeLog	2018-01-09 03:08:47 UTC (rev 226608)
@@ -1,3 +1,10 @@
+2018-01-08  Ryosuke Niwa  
+
+iOS build fix attempt after r226602.
+
+* UIProcess/API/C/WKContextMenuListener.cpp:
+(WKContextMenuListenerUseContextMenuItems):
+
 2018-01-08  Alex Christensen  
 
 Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions


Modified: trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp (226607 => 226608)

--- trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp	2018-01-09 02:56:05 UTC (rev 226607)
+++ trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp	2018-01-09 03:08:47 UTC (rev 226608)
@@ -60,6 +60,6 @@
 toImpl(listenerRef)->useContextMenuItems(WTFMove(items));
 #else
 UNUSED_PARAM(listenerRef);
-UNUSED_PARAM(items);
+UNUSED_PARAM(arrayRef);
 #endif
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226605] trunk

2018-01-08 Thread commit-queue

Title: [226605] trunk








Revision 226605
Author commit-qu...@webkit.org
Date 2018-01-08 18:07:53 -0800 (Mon, 08 Jan 2018)


Log Message
Unreviewed, rolling out r226532 and r226540.
https://bugs.webkit.org/show_bug.cgi?id=181422

jessie says basic browsing does not seem to work (Requested by
alexchristensen on #webkit).

Reverted changesets:

"Add CSP support to service workers"
https://bugs.webkit.org/show_bug.cgi?id=181385
https://trac.webkit.org/changeset/226532

"SWClientConnection should not keep references to service
worker jobs"
https://bugs.webkit.org/show_bug.cgi?id=181381
https://trac.webkit.org/changeset/226540

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.h
trunk/Source/WebCore/workers/service/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/SWClientConnection.h
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h
trunk/Source/WebCore/workers/service/ServiceWorkerContextData.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContextData.h
trunk/Source/WebCore/workers/service/ServiceWorkerFetchResult.h
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebCore/workers/service/server/RegistrationDatabase.cpp
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226604 => 226605)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-09 02:05:48 UTC (rev 226604)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-09 02:07:53 UTC (rev 226605)
@@ -1,3 +1,22 @@
+2018-01-08  Commit Queue  
+
+Unreviewed, rolling out r226532 and r226540.
+https://bugs.webkit.org/show_bug.cgi?id=181422
+
+jessie says basic browsing does not seem to work (Requested by
+alexchristensen on #webkit).
+
+Reverted changesets:
+
+"Add CSP support to service workers"
+https://bugs.webkit.org/show_bug.cgi?id=181385
+https://trac.webkit.org/changeset/226532
+
+"SWClientConnection should not keep references to service
+worker jobs"
+https://bugs.webkit.org/show_bug.cgi?id=181381
+https://trac.webkit.org/changeset/226540
+
 2018-01-08  Youenn Fablet  
 
 Add CSP support to service workers


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt (226604 => 226605)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt	2018-01-09 02:05:48 UTC (rev 226604)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt	2018-01-09 02:07:53 UTC (rev 226605)
@@ -1,6 +1,6 @@
 
 PASS CSP test for connect-src in ServiceWorkerGlobalScope 
 PASS importScripts test for connect-src 
-PASS Fetch test for connect-src 
-PASS Redirected fetch test for connect-src 
+FAIL Fetch test for connect-src assert_unreached: unexpected rejection: assert_unreached: fetch should fail. Reached unreachable code Reached unreachable code
+FAIL Redirected fetch test for connect-src assert_unreached: unexpected rejection: assert_unreached: Redirected fetch should fail. Reached unreachable code Reached unreachable code
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt (226604 => 226605)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt	2018-01-09 02:05:48 UTC

[webkit-changes] [226604] trunk

2018-01-08 Thread wenson_hsieh

Title: [226604] trunk








Revision 226604
Author wenson_hs...@apple.com
Date 2018-01-08 18:05:48 -0800 (Mon, 08 Jan 2018)


Log Message
[Attachment Support] Expose file name and content type of WKAttachment
https://bugs.webkit.org/show_bug.cgi?id=181390


Reviewed by Tim Horton.

Source/WebCore:

Add new structs in AttachmentTypes.h and refactor HTMLAttachmentElement::requestData to requestInfo. See below
for more details. Augmented existing API tests in WKAttachmentTests.

* html/AttachmentTypes.h:

Add a struct to represent a snapshot of information about an attachment element.

* html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::requestInfo):
(WebCore::HTMLAttachmentElement::requestData): Deleted.
* html/HTMLAttachmentElement.h:

Change requestData to requestInfo. Instead of fetching and delivering data via callback, requestInfo returns an
AttachmentInfo.

* rendering/RenderThemeIOS.mm:
(WebCore::RenderAttachmentInfo::addLine):
(WebCore::RenderAttachmentInfo::buildWrappedLines):
(WebCore::RenderAttachmentInfo::buildSingleLine):
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
(WebCore::RenderThemeIOS::attachmentBaseline const):
(WebCore::paintAttachmentIcon):
(WebCore::paintAttachmentText):
(WebCore::paintAttachmentProgress):
(WebCore::attachmentBorderPath):
(WebCore::RenderThemeIOS::paintAttachment):
(WebCore::AttachmentInfo::addLine): Deleted.
(WebCore::AttachmentInfo::buildWrappedLines): Deleted.
(WebCore::AttachmentInfo::buildSingleLine): Deleted.
(WebCore::AttachmentInfo::AttachmentInfo): Deleted.

Rename AttachmentInfo to RenderAttachmentInfo to resolve a name conflict with the new AttachmentInfo struct.

Source/WebKit:

Add support for -[_WKAttachment requestInfo:], which fetches a snapshot of the attachment's state. This API is
meant to be a replacement for -requestData: that provides additional metadata about the attachment.

* Scripts/webkit/messages.py:
(headers_for_type):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/WebCoreArgumentCoders.h:

Add IPC support for AttachmentInfo. Note that instead of using (encode|decode)SharedBuffer, we send and receive
data references to the shared buffer.

* UIProcess/API/APIAttachment.cpp:
(API::Attachment::requestInfo):
(API::Attachment::requestData): Deleted.
* UIProcess/API/APIAttachment.h:

Change requestData to requestInfo.

* UIProcess/API/Cocoa/_WKAttachment.h:
* UIProcess/API/Cocoa/_WKAttachment.mm:
(-[_WKAttachmentInfo initWithInfo:]):
(-[_WKAttachmentInfo data]):
(-[_WKAttachmentInfo name]):
(-[_WKAttachmentInfo filePath]):
(-[_WKAttachmentInfo contentType]):
(-[_WKAttachment requestInfo:]):
(-[_WKAttachment requestData:]):

Implement -requestInfo: by calling into APIAttachment, and reimplement -requestData: in terms of -requestInfo:.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::attachmentInfoCallback):
(WebKit::WebPageProxy::requestAttachmentInfo):
(WebKit::WebPageProxy::sharedBufferCallback): Deleted.
(WebKit::WebPageProxy::requestAttachmentData): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

Rename the SharedBufferCallback IPC message to AttachmentInfoCallback, and make it conditional on
ATTACHMENT_ELEMENT. Rename requestAttachmentData to requestAttachmentInfo.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestAttachmentInfo):
(WebKit::WebPage::invokeSharedBufferCallback): Deleted.
(WebKit::WebPage::requestAttachmentData): Deleted.

Rename requestAttachmentData to requestAttachmentInfo and adopt HTMLAttachmentElement::requestInfo.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(-[_WKAttachment synchronouslyRequestInfo:]):
(-[_WKAttachment synchronouslyRequestData:]):

Reimplement this in terms of -synchronouslyRequestInfo:.

(-[_WKAttachment expectRequestedDataToBe:]):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/AttachmentTypes.h
trunk/Source/WebCore/html/HTMLAttachmentElement.cpp
trunk/Source/WebCore/html/HTMLAttachmentElement.h
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit/UIProcess/API/APIAttachment.cpp
trunk/Source/WebKit/UIProcess/API/APIAttachment.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Tools/ChangeLog

[webkit-changes] [226603] trunk/Source/WebCore

2018-01-08 Thread sbarati

Title: [226603] trunk/Source/WebCore








Revision 226603
Author sbar...@apple.com
Date 2018-01-08 17:55:40 -0800 (Mon, 08 Jan 2018)


Log Message
Speculative build fix after r226600. We only use clflush on x86 and the `asm volatile` syntax is not available in the Windows build.

No new tests because this is a build fix.

* dom/Comment.cpp:
(WebCore::Comment::clflushReadLength):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Comment.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226602 => 226603)

--- trunk/Source/WebCore/ChangeLog	2018-01-09 01:53:29 UTC (rev 226602)
+++ trunk/Source/WebCore/ChangeLog	2018-01-09 01:55:40 UTC (rev 226603)
@@ -1,3 +1,12 @@
+2018-01-08  Saam Barati  
+
+Speculative build fix after r226600. We only use clflush on x86 and the `asm volatile` syntax is not available in the Windows build.
+
+No new tests because this is a build fix.
+
+* dom/Comment.cpp:
+(WebCore::Comment::clflushReadLength):
+
 2018-01-08  Michael Saboff  
 
 Add a DOM gadget for Spectre testing


Modified: trunk/Source/WebCore/dom/Comment.cpp (226602 => 226603)

--- trunk/Source/WebCore/dom/Comment.cpp	2018-01-09 01:53:29 UTC (rev 226602)
+++ trunk/Source/WebCore/dom/Comment.cpp	2018-01-09 01:55:40 UTC (rev 226603)
@@ -86,6 +86,7 @@
 
 void Comment::clflushReadLength()
 {
+#if CPU(X86_64) && !OS(WINDOWS)
 auto clflush = [] (void* ptr) {
 char* ptrToFlush = static_cast(ptr);
 asm volatile ("clflush %0" :: "m"(*ptrToFlush) : "memory");
@@ -92,6 +93,7 @@
 };
 
 clflush(_readLength);
+#endif
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226602] trunk/Source/WebKit

2018-01-08 Thread achristensen

Title: [226602] trunk/Source/WebKit








Revision 226602
Author achristen...@apple.com
Date 2018-01-08 17:53:29 -0800 (Mon, 08 Jan 2018)


Log Message
Pass around Vector instead of WKArrayRef or Vector
https://bugs.webkit.org/show_bug.cgi?id=181419

Reviewed by Tim Horton.

Passing a WKArrayRef to an API object is messy and was preventing me from moving things around and making ObjC SPI.
No change in behavior.  Just using different layering abstractions for the same data.

* UIProcess/API/C/WKContextMenuListener.cpp:
(WKContextMenuListenerUseContextMenuItems):
* UIProcess/WebContextMenuListenerProxy.cpp:
(WebKit::WebContextMenuListenerProxy::useContextMenuItems):
* UIProcess/WebContextMenuListenerProxy.h:
* UIProcess/WebContextMenuProxy.h:
* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
(WebKit::WebContextMenuProxyMac::showContextMenu):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp
trunk/Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp
trunk/Source/WebKit/UIProcess/WebContextMenuListenerProxy.h
trunk/Source/WebKit/UIProcess/WebContextMenuProxy.h
trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp
trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.h
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h
trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
trunk/Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (226601 => 226602)

--- trunk/Source/WebKit/ChangeLog	2018-01-09 01:21:04 UTC (rev 226601)
+++ trunk/Source/WebKit/ChangeLog	2018-01-09 01:53:29 UTC (rev 226602)
@@ -1,3 +1,24 @@
+2018-01-08  Alex Christensen  
+
+Pass around Vector instead of WKArrayRef or Vector
+https://bugs.webkit.org/show_bug.cgi?id=181419
+
+Reviewed by Tim Horton.
+
+Passing a WKArrayRef to an API object is messy and was preventing me from moving things around and making ObjC SPI.
+No change in behavior.  Just using different layering abstractions for the same data.
+
+* UIProcess/API/C/WKContextMenuListener.cpp:
+(WKContextMenuListenerUseContextMenuItems):
+* UIProcess/WebContextMenuListenerProxy.cpp:
+(WebKit::WebContextMenuListenerProxy::useContextMenuItems):
+* UIProcess/WebContextMenuListenerProxy.h:
+* UIProcess/WebContextMenuProxy.h:
+* UIProcess/mac/WebContextMenuProxyMac.h:
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
+(WebKit::WebContextMenuProxyMac::showContextMenu):
+
 2018-01-08  John Wilander  
 
 Storage Access API: Remove access for all frames under a page when the page is closed


Modified: trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp (226601 => 226602)

--- trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp	2018-01-09 01:21:04 UTC (rev 226601)
+++ trunk/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp	2018-01-09 01:53:29 UTC (rev 226602)
@@ -26,7 +26,9 @@
 #include "config.h"
 #include "WKContextMenuListener.h"
 
+#include "APIArray.h"
 #include "WKAPICast.h"
+#include "WebContextMenuItem.h"
 #include "WebContextMenuListenerProxy.h"
 
 using namespace WebKit;
@@ -40,10 +42,22 @@
 #endif
 }
 
-void WKContextMenuListenerUseContextMenuItems(WKContextMenuListenerRef listenerRef, WKArrayRef items)
+void WKContextMenuListenerUseContextMenuItems(WKContextMenuListenerRef listenerRef, WKArrayRef arrayRef)
 {
 #if ENABLE(CONTEXT_MENUS)
-toImpl(listenerRef)->useContextMenuItems(items);
+RefPtr array = toImpl(arrayRef);
+size_t newSize = array ? array->size() : 0;
+Vector items;
+items.reserveInitialCapacity(newSize);
+for (size_t i = 0; i < newSize; ++i) {
+WebContextMenuItem* item = array->at(i);
+if (!item)
+continue;
+
+items.uncheckedAppend(*item);
+}
+
+toImpl(listenerRef)->useContextMenuItems(WTFMove(items));
 #else
 UNUSED_PARAM(listenerRef);
 UNUSED_PARAM(items);


Modified: trunk/Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp (226601 => 226602)

--- trunk/Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp	2018-01-09 01:21:04 UTC (rev 226601)
+++ trunk/Source/WebKit/UIProcess/WebContextMenuListenerProxy.cpp	2018-01-09 01:53:29 UTC (rev 226602)
@@ -47,24 +47,12 @@
 {
 }
 
-void WebContextMenuListenerProxy::useContextMenuItems(WKArrayRef items)
+void WebContextMenuListenerProxy::useContextMenuItems(Vector&& items)
 {
 if (!m_contextMenuMac)
 return;
 
-RefPtr array = toImpl(items);
-size_t newSize = array ? array->size() : 0;
-Vector dataItems;
-dataItems.reserveInitialCapacity(newSize);
-for (size_t i = 0; i < newSize; ++i) {
-WebContextMenuItem* item

[webkit-changes] [226600] trunk/Source

2018-01-08 Thread msaboff

Title: [226600] trunk/Source








Revision 226600
Author msab...@apple.com
Date 2018-01-08 17:07:29 -0800 (Mon, 08 Jan 2018)


Log Message
Add a DOM gadget for Spectre testing
https://bugs.webkit.org/show_bug.cgi?id=181351

Source/_javascript_Core:

Reviewed by Michael Saboff.

Added a new JSC::Option named enableSpectreGadgets to enable any gadgets added to test
Spectre mitigations.

* runtime/Options.h:

Source/WebCore:

Reviewed by Saam Barati.

This change is used to test Spectre mitigations.

Added a side data array to the Comment DOM node to test for Spectre issues in
the DOM layer.  This additional functionality is disabled by default and must
be enabled through the JSC option "enableSpectreGadgets".

* dom/Comment.cpp:
(WebCore::Comment::Comment):
(WebCore::Comment::setReadLength):
(WebCore::Comment::charCodeAt):
(WebCore::Comment::clflushReadLength):
* dom/Comment.h:
* dom/Comment.idl:
* page/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::spectreGadgetsEnabled const):
* page/RuntimeEnabledFeatures.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Comment.cpp
trunk/Source/WebCore/dom/Comment.h
trunk/Source/WebCore/dom/Comment.idl
trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226599 => 226600)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-09 00:35:35 UTC (rev 226599)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-09 01:07:29 UTC (rev 226600)
@@ -1,3 +1,15 @@
+2018-01-08  Michael Saboff  
+
+Add a DOM gadget for Spectre testing
+https://bugs.webkit.org/show_bug.cgi?id=181351
+
+Reviewed by Michael Saboff.
+
+Added a new JSC::Option named enableSpectreGadgets to enable any gadgets added to test
+Spectre mitigations.
+
+* runtime/Options.h:
+
 2018-01-08  Mark Lam  
 
 Rename CodeBlock::m_vm to CodeBlock::m_poisonedVM.


Modified: trunk/Source/_javascript_Core/runtime/Options.h (226599 => 226600)

--- trunk/Source/_javascript_Core/runtime/Options.h	2018-01-09 00:35:35 UTC (rev 226599)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2018-01-09 01:07:29 UTC (rev 226600)
@@ -460,6 +460,8 @@
 \
 v(bool, disableSpectreMitigations, false, Restricted, "Disable Spectre mitigations.") \
 \
+v(bool, enableSpectreGadgets, false, Restricted, "enable gadgets to test Spectre mitigations.") \
+\
 v(bool, useAsyncIterator, enableAsyncIteration, Normal, "Allow to use Async Iterator in JS.") \
 \
 v(bool, failToCompileWebAssemblyCode, false, Normal, "If true, no Wasm::Plan will sucessfully compile a function.") \


Modified: trunk/Source/WebCore/ChangeLog (226599 => 226600)

--- trunk/Source/WebCore/ChangeLog	2018-01-09 00:35:35 UTC (rev 226599)
+++ trunk/Source/WebCore/ChangeLog	2018-01-09 01:07:29 UTC (rev 226600)
@@ -1,3 +1,27 @@
+2018-01-08  Michael Saboff  
+
+Add a DOM gadget for Spectre testing
+https://bugs.webkit.org/show_bug.cgi?id=181351
+
+Reviewed by Saam Barati.
+
+This change is used to test Spectre mitigations.
+
+Added a side data array to the Comment DOM node to test for Spectre issues in
+the DOM layer.  This additional functionality is disabled by default and must
+be enabled through the JSC option "enableSpectreGadgets".
+
+* dom/Comment.cpp:
+(WebCore::Comment::Comment):
+(WebCore::Comment::setReadLength):
+(WebCore::Comment::charCodeAt):
+(WebCore::Comment::clflushReadLength):
+* dom/Comment.h:
+* dom/Comment.idl:
+* page/RuntimeEnabledFeatures.cpp:
+(WebCore::RuntimeEnabledFeatures::spectreGadgetsEnabled const):
+* page/RuntimeEnabledFeatures.h:
+
 2018-01-08  Said Abou-Hallawa  
 
 A canvas should not be tainted if it draws a data URL SVGImage with a 


Modified: trunk/Source/WebCore/dom/Comment.cpp (226599 => 226600)

--- trunk/Source/WebCore/dom/Comment.cpp	2018-01-09 00:35:35 UTC (rev 226599)
+++ trunk/Source/WebCore/dom/Comment.cpp	2018-01-09 01:07:29 UTC (rev 226600)
@@ -23,12 +23,27 @@
 #include "Comment.h"
 
 #include "Document.h"
+#include "RuntimeEnabledFeatures.h"
 
 namespace WebCore {
 
+static constexpr unsigned s_maxDataLength = 100u;
+
 inline Comment::Comment(Document& document, const String& text)
 : CharacterData(document, text, CreateOther)
 {
+if (RuntimeEnabledFeatures::sharedFeatures().spectreGadgetsEnabled()) {
+setReadLength(text.length());
+m_data.resize(s_maxDataLength);
+m_data.fill(0);
+m_dataPtr = m_data.data();
+
+for (size_t i = 0; i < m_readLength; i++)
+m_data[i] = text.characterAt(i);
+} else {
+setReadLength(0);
+

[webkit-changes] [226598] tags/Safari-604.5.5/

2018-01-08 Thread jmarcell

Title: [226598] tags/Safari-604.5.5/








Revision 226598
Author jmarc...@apple.com
Date 2018-01-08 16:16:36 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.5.5.

Added Paths

tags/Safari-604.5.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226597] tags/Safari-604.5.4/

2018-01-08 Thread jmarcell

Title: [226597] tags/Safari-604.5.4/








Revision 226597
Author jmarc...@apple.com
Date 2018-01-08 16:16:35 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.5.4.

Added Paths

tags/Safari-604.5.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226595] tags/Safari-604.5.100.4/

2018-01-08 Thread jmarcell

Title: [226595] tags/Safari-604.5.100.4/








Revision 226595
Author jmarc...@apple.com
Date 2018-01-08 16:12:37 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.5.100.4.

Added Paths

tags/Safari-604.5.100.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226596] tags/Safari-604.5.100.5/

2018-01-08 Thread jmarcell

Title: [226596] tags/Safari-604.5.100.5/








Revision 226596
Author jmarc...@apple.com
Date 2018-01-08 16:12:38 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.5.100.5.

Added Paths

tags/Safari-604.5.100.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226590] branches/safari-604.5.100-branch

2018-01-08 Thread jmarcell

Title: [226590] branches/safari-604.5.100-branch








Revision 226590
Author jmarc...@apple.com
Date 2018-01-08 16:07:10 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36257610

Reduce the precision of "high" resolution time to 1ms
https://bugs.webkit.org/show_bug.cgi?id=180910


Reviewed by Saam Barati.

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711

* TestExpectations:

Modified Paths

branches/safari-604.5.100-branch/LayoutTests/ChangeLog
branches/safari-604.5.100-branch/LayoutTests/TestExpectations
branches/safari-604.5.100-branch/Source/WebCore/ChangeLog
branches/safari-604.5.100-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
branches/safari-604.5.100-branch/Source/WebCore/page/Performance.cpp




Diff

Modified: branches/safari-604.5.100-branch/LayoutTests/ChangeLog (226589 => 226590)

--- branches/safari-604.5.100-branch/LayoutTests/ChangeLog	2018-01-09 00:07:06 UTC (rev 226589)
+++ branches/safari-604.5.100-branch/LayoutTests/ChangeLog	2018-01-09 00:07:10 UTC (rev 226590)
@@ -1,5 +1,33 @@
 2017-12-18  Jason Marcell  
 
+ Apply patch. rdar://problem/36257610
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Jason Marcell  
+
 Cherry-pick r226065. rdar://problem/36080415
 
 2017-12-18  Zalan Bujtas  


Modified: branches/safari-604.5.100-branch/LayoutTests/TestExpectations (226589 => 226590)

--- branches/safari-604.5.100-branch/LayoutTests/TestExpectations	2018-01-09 00:07:06 UTC (rev 226589)
+++ branches/safari-604.5.100-branch/LayoutTests/TestExpectations	2018-01-09 00:07:10 UTC (rev 226590)
@@ -1404,3 +1404,6 @@
 webkit.org/b/177997 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Pass Failure ]
 
 webkit.org/b/174284 media/video-source-before-src.html [ Skip ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]


Modified: branches/safari-604.5.100-branch/Source/WebCore/ChangeLog (226589 => 226590)

--- branches/safari-604.5.100-branch/Source/WebCore/ChangeLog	2018-01-09 00:07:06 UTC (rev 226589)
+++ branches/safari-604.5.100-branch/Source/WebCore/ChangeLog	2018-01-09 00:07:10 UTC (rev 226590)
@@ -1,5 +1,37 @@
 2017-12-18  Jason Marcell  
 
+ Apply patch. rdar://problem/36257610
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::fillRTCStats):
+* page/Performance.cpp:
+(WebCore::Performance::reduceTimeResolution):
+
+2017-12-18  Jason Marcell  
+
 Cherry-pick r226065. rdar://problem/36080415
 
 2017-12-18  Zalan Bujtas  


Modified: branches/safari-604.5.100-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226589 => 226590)

--- branches/safari-604.5.100-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-09 00:07:06 UTC (rev 226589)
+++

[webkit-changes] [226592] branches/safari-604.5.100-branch/Source/JavaScriptCore/wasm/js/ JSWebAssemblyMemory.cpp

2018-01-08 Thread jmarcell

Title: [226592] branches/safari-604.5.100-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp








Revision 226592
Author jmarc...@apple.com
Date 2018-01-08 16:07:16 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36276168

fix indexing mask

Modified Paths

branches/safari-604.5.100-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp




Diff

Modified: branches/safari-604.5.100-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp (226591 => 226592)

--- branches/safari-604.5.100-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-09 00:07:14 UTC (rev 226591)
+++ branches/safari-604.5.100-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-09 00:07:16 UTC (rev 226592)
@@ -117,7 +117,7 @@
 }
 m_memoryBase = memory().memory();
 m_memorySize = memory().size();
-m_memorySize = memory().indexingMask();
+m_indexingMask = memory().indexingMask();
 }
 
 // We need to clear out the old array buffer because it might now be pointing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226593] branches/safari-604.5.100-branch/Source

2018-01-08 Thread jmarcell

Title: [226593] branches/safari-604.5.100-branch/Source








Revision 226593
Author jmarc...@apple.com
Date 2018-01-08 16:07:20 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.5.100-branch/Source/WebKit/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.5.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (226592 => 226593)

--- branches/safari-604.5.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-09 00:07:16 UTC (rev 226592)
+++ branches/safari-604.5.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-09 00:07:20 UTC (rev 226593)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
 TINY_VERSION = 100;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);

[webkit-changes] [226588] branches/safari-604-branch/Source/WebCore

2018-01-08 Thread jmarcell

Title: [226588] branches/safari-604-branch/Source/WebCore








Revision 226588
Author jmarc...@apple.com
Date 2018-01-08 15:51:01 -0800 (Mon, 08 Jan 2018)


Log Message
Cherry-pick r226457. rdar://problem/36323985

Modified Paths

branches/safari-604-branch/Source/WebCore/ChangeLog
branches/safari-604-branch/Source/WebCore/svg/SVGAnimatedTypeAnimator.h
branches/safari-604-branch/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h




Diff

Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (226587 => 226588)

--- branches/safari-604-branch/Source/WebCore/ChangeLog	2018-01-08 23:50:58 UTC (rev 226587)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog	2018-01-08 23:51:01 UTC (rev 226588)
@@ -1,3 +1,28 @@
+2018-01-05  Jason Marcell  
+
+Cherry-pick r226457. rdar://problem/36323985
+
+2018-01-05  Said Abou-Hallawa  
+
+SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() should do nothing if the property is not animating
+https://bugs.webkit.org/show_bug.cgi?id=181316
+
+
+Reviewed by Simon Fraser.
+
+This is a speculative change to fix a crash which appeared after r226065.
+The crash is very intermittent and sometimes very hard to reproduce. The
+basic code analysis did not show how this crash can even happen.
+
+* svg/SVGAnimatedTypeAnimator.h:
+(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues): For SVG property
+with two values, e.g. ,  we need to
+detach the wrappers of the animated property if the animated values are
+going to change. This is similar to what we did in resetFromBaseValue().
+
+* svg/properties/SVGAnimatedListPropertyTearOff.h:
+(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
+
 2017-12-18  Jason Marcell  
 
  Apply patch. rdar://problem/36257607


Modified: branches/safari-604-branch/Source/WebCore/svg/SVGAnimatedTypeAnimator.h (226587 => 226588)

--- branches/safari-604-branch/Source/WebCore/svg/SVGAnimatedTypeAnimator.h	2018-01-08 23:50:58 UTC (rev 226587)
+++ branches/safari-604-branch/Source/WebCore/svg/SVGAnimatedTypeAnimator.h	2018-01-08 23:51:01 UTC (rev 226588)
@@ -127,10 +127,14 @@
 {
 ASSERT(animatedTypes[0].properties.size() == 2);
 ASSERT(type.type() == m_type);
+auto* firstProperty = castAnimatedPropertyToActualType(animatedTypes[0].properties[0].get());
+auto* secondProperty =  castAnimatedPropertyToActualType(animatedTypes[0].properties[1].get());
+firstProperty->synchronizeWrappersIfNeeded();
+secondProperty->synchronizeWrappersIfNeeded();
 
 std::pair& animatedTypeValue = (type.*getter)();
-animatedTypeValue.first = castAnimatedPropertyToActualType(animatedTypes[0].properties[0].get())->currentBaseValue();
-animatedTypeValue.second = castAnimatedPropertyToActualType(animatedTypes[0].properties[1].get())->currentBaseValue();
+animatedTypeValue.first = firstProperty->currentBaseValue();
+animatedTypeValue.second = secondProperty->currentBaseValue();
 
 executeAction(StartAnimationAction, animatedTypes, 0, );
 executeAction(StartAnimationAction, animatedTypes, 1, );


Modified: branches/safari-604-branch/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h (226587 => 226588)

--- branches/safari-604-branch/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h	2018-01-08 23:50:58 UTC (rev 226587)
+++ branches/safari-604-branch/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h	2018-01-08 23:51:01 UTC (rev 226588)
@@ -138,7 +138,11 @@
 
 void synchronizeWrappersIfNeeded()
 {
-ASSERT(isAnimating());
+if (!isAnimating()) {
+// This should never happen, but we've seen it in the field. Please comment in bug #181316 if you hit this.
+ASSERT_NOT_REACHED();
+return;
+}
 
 // Eventually the wrapper list needs synchronization because any SVGAnimateLengthList::calculateAnimatedValue() call may
 // mutate the length of our values() list, and thus the wrapper() cache needs synchronization, to have the same size.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226585] branches/safari-604-branch/Source

2018-01-08 Thread jmarcell

Title: [226585] branches/safari-604-branch/Source








Revision 226585
Author jmarc...@apple.com
Date 2018-01-08 15:50:53 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (226584 => 226585)

--- branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-08 23:50:49 UTC (rev 226584)
+++ branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-08 23:50:53 UTC (rev 226585)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226586] branches/safari-604-branch/Source/JavaScriptCore/wasm/js/ JSWebAssemblyMemory.cpp

2018-01-08 Thread jmarcell

Title: [226586] branches/safari-604-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp








Revision 226586
Author jmarc...@apple.com
Date 2018-01-08 15:50:55 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36276141

fix indexing mask

Modified Paths

branches/safari-604-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp




Diff

Modified: branches/safari-604-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp (226585 => 226586)

--- branches/safari-604-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-08 23:50:53 UTC (rev 226585)
+++ branches/safari-604-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-08 23:50:55 UTC (rev 226586)
@@ -117,7 +117,7 @@
 }
 m_memoryBase = memory().memory();
 m_memorySize = memory().size();
-m_memorySize = memory().indexingMask();
+m_indexingMask = memory().indexingMask();
 }
 
 // We need to clear out the old array buffer because it might now be pointing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226584] branches/safari-604-branch

2018-01-08 Thread jmarcell

Title: [226584] branches/safari-604-branch








Revision 226584
Author jmarc...@apple.com
Date 2018-01-08 15:50:49 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36257607

Reduce the precision of "high" resolution time to 1ms
https://bugs.webkit.org/show_bug.cgi?id=180910


Reviewed by Saam Barati.

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711

* TestExpectations:

Modified Paths

branches/safari-604-branch/LayoutTests/ChangeLog
branches/safari-604-branch/LayoutTests/TestExpectations
branches/safari-604-branch/Source/WebCore/ChangeLog
branches/safari-604-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
branches/safari-604-branch/Source/WebCore/page/Performance.cpp




Diff

Modified: branches/safari-604-branch/LayoutTests/ChangeLog (226583 => 226584)

--- branches/safari-604-branch/LayoutTests/ChangeLog	2018-01-08 23:50:45 UTC (rev 226583)
+++ branches/safari-604-branch/LayoutTests/ChangeLog	2018-01-08 23:50:49 UTC (rev 226584)
@@ -1,5 +1,33 @@
 2017-12-18  Jason Marcell  
 
+ Apply patch. rdar://problem/36257607
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Jason Marcell  
+
 Cherry-pick r226065. rdar://problem/36080413
 
 2017-12-18  Zalan Bujtas  


Modified: branches/safari-604-branch/LayoutTests/TestExpectations (226583 => 226584)

--- branches/safari-604-branch/LayoutTests/TestExpectations	2018-01-08 23:50:45 UTC (rev 226583)
+++ branches/safari-604-branch/LayoutTests/TestExpectations	2018-01-08 23:50:49 UTC (rev 226584)
@@ -1404,3 +1404,6 @@
 webkit.org/b/177997 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Pass Failure ]
 
 webkit.org/b/174284 media/video-source-before-src.html [ Skip ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]


Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (226583 => 226584)

--- branches/safari-604-branch/Source/WebCore/ChangeLog	2018-01-08 23:50:45 UTC (rev 226583)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog	2018-01-08 23:50:49 UTC (rev 226584)
@@ -1,5 +1,37 @@
 2017-12-18  Jason Marcell  
 
+ Apply patch. rdar://problem/36257607
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::fillRTCStats):
+* page/Performance.cpp:
+(WebCore::Performance::reduceTimeResolution):
+
+2017-12-18  Jason Marcell  
+
 Cherry-pick r226065. rdar://problem/36080413
 
 2017-12-18  Zalan Bujtas  


Modified: branches/safari-604-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226583 => 226584)

--- branches/safari-604-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 23:50:45 UTC (rev 226583)
+++ branches/safari-604-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 23:50:49 UTC (rev 226584)
@@ -35,6 +35,7 @@

[webkit-changes] [226583] branches/safari-604-branch/Source/JavaScriptCore

2018-01-08 Thread jmarcell

Title: [226583] branches/safari-604-branch/Source/_javascript_Core








Revision 226583
Author jmarc...@apple.com
Date 2018-01-08 15:50:45 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36257695

Disable/remove SharedArrayBuffers from Web API
rdar://problem/36077849

Removed SharedArrayBuffer prototype and structure to disable.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayBufferPrototype const):
(JSC::JSGlobalObject::arrayBufferStructure const):

Modified Paths

branches/safari-604-branch/Source/_javascript_Core/ChangeLog
branches/safari-604-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp
branches/safari-604-branch/Source/_javascript_Core/runtime/JSGlobalObject.h




Diff

Modified: branches/safari-604-branch/Source/_javascript_Core/ChangeLog (226582 => 226583)

--- branches/safari-604-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:32:53 UTC (rev 226582)
+++ branches/safari-604-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:50:45 UTC (rev 226583)
@@ -1,5 +1,21 @@
 2017-12-19  Jason Marcell  
 
+Apply patch. rdar://problem/36257695
+
+Disable/remove SharedArrayBuffers from Web API
+rdar://problem/36077849
+
+Removed SharedArrayBuffer prototype and structure to disable.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::init):
+(JSC::JSGlobalObject::visitChildren):
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::arrayBufferPrototype const):
+(JSC::JSGlobalObject::arrayBufferStructure const):
+
+2017-12-19  Jason Marcell  
+
 Apply patch. rdar://problem/36111993
 
 Cherry-pick r225363, r225437, r225632, r225659, r225697, r225857. rdar://problem/36085975


Modified: branches/safari-604-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp (226582 => 226583)

--- branches/safari-604-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 23:32:53 UTC (rev 226582)
+++ branches/safari-604-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 23:50:45 UTC (rev 226583)
@@ -571,8 +571,10 @@
 
 m_arrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Default));
 m_arrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_arrayBufferPrototype.get()));
+#if ENABLE(SHARED_ARRAY_BUFFER)
 m_sharedArrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Shared));
 m_sharedArrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_sharedArrayBufferPrototype.get()));
+#endif
 
 m_iteratorPrototype.set(vm, this, IteratorPrototype::create(vm, this, IteratorPrototype::createStructure(vm, this, m_objectPrototype.get(;
 m_generatorPrototype.set(vm, this, GeneratorPrototype::create(vm, this, GeneratorPrototype::createStructure(vm, this, m_iteratorPrototype.get(;
@@ -617,10 +619,11 @@
 
 JSArrayBufferConstructor* arrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_arrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Default);
 m_arrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 JSArrayBufferConstructor* sharedArrayBufferConstructor = nullptr;
 sharedArrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_sharedArrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Shared);
 m_sharedArrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, sharedArrayBufferConstructor, DontEnum);
-
+#endif
 #define CREATE_CONSTRUCTOR_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
 capitalName ## Constructor* lowerName ## Constructor = capitalName ## Constructor::create(vm, capitalName ## Constructor::createStructure(vm, this, m_functionPrototype.get()), m_ ## lowerName ## Prototype.get(), m_speciesGetterSetter.get()); \
 m_ ## lowerName ## Prototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, lowerName ## Constructor, DontEnum); \
@@ -683,7 +686,9 @@
 putDirectWithoutTransition(vm, vm.propertyNames->builtinNames().ArrayPrivateName(), arrayConstructor, DontEnum | DontDelete | ReadOnly);
 
 putDirectWithoutTransition(vm, vm.propertyNames->ArrayBuffer, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 putDirectWithoutTransition(vm,

[webkit-changes] [226582] tags/Safari-605.1.20/Source

2018-01-08 Thread jmarcell

Title: [226582] tags/Safari-605.1.20/Source








Revision 226582
Author jmarc...@apple.com
Date 2018-01-08 15:32:53 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-605.1.20/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-605.1.20/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-605.1.20/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-605.1.20/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-605.1.20/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-605.1.20/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-605.1.20/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-605.1.20/Source/_javascript_Core/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-605.1.20/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-605.1.20/Source/WebCore/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-605.1.20/Source/WebCore/PAL/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-605.1.20/Source/WebInspectorUI/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-605.1.20/Source/WebKit/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-605.1.20/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (226581 => 226582)

--- tags/Safari-605.1.20/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-08 23:27:52 UTC (rev 226581)
+++ tags/Safari-605.1.20/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-01-08 23:32:53 UTC (rev 226582)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 19;
+TINY_VERSION = 20;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226580] tags/Safari-604.4.7.10.6/

2018-01-08 Thread jmarcell

Title: [226580] tags/Safari-604.4.7.10.6/








Revision 226580
Author jmarc...@apple.com
Date 2018-01-08 15:23:21 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.4.7.10.6.

Added Paths

tags/Safari-604.4.7.10.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226579] tags/Safari-604.4.7.10.5/

2018-01-08 Thread jmarcell

Title: [226579] tags/Safari-604.4.7.10.5/








Revision 226579
Author jmarc...@apple.com
Date 2018-01-08 15:19:48 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.4.7.10.5.

Added Paths

tags/Safari-604.4.7.10.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226578] trunk/LayoutTests

2018-01-08 Thread jlewis3

Title: [226578] trunk/LayoutTests








Revision 226578
Author jlew...@apple.com
Date 2018-01-08 15:16:58 -0800 (Mon, 08 Jan 2018)


Log Message
Marked imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181087

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226577 => 226578)

--- trunk/LayoutTests/ChangeLog	2018-01-08 23:15:39 UTC (rev 226577)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 23:16:58 UTC (rev 226578)
@@ -1,5 +1,14 @@
 2018-01-08  Matt Lewis  
 
+Marked imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181087
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2018-01-08  Matt Lewis  
+
 Unreviewed, rolling out r226385.
 
 The test introduced with this was a flaky since being added.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (226577 => 226578)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-01-08 23:15:39 UTC (rev 226577)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-01-08 23:16:58 UTC (rev 226578)
@@ -1295,3 +1295,5 @@
 
 webkit.org/181167 imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html [ Pass Failure ]
 
+webkit.org/181087 imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226576] branches/safari-604.4.7.10-branch/Source/JavaScriptCore/wasm/js/ JSWebAssemblyMemory.cpp

2018-01-08 Thread jmarcell

Title: [226576] branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp








Revision 226576
Author jmarc...@apple.com
Date 2018-01-08 15:15:36 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36267662

fix indexing mask

Modified Paths

branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp




Diff

Modified: branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp (226575 => 226576)

--- branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-08 23:15:34 UTC (rev 226575)
+++ branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-08 23:15:36 UTC (rev 226576)
@@ -117,7 +117,7 @@
 }
 m_memoryBase = memory().memory();
 m_memorySize = memory().size();
-m_memorySize = memory().indexingMask();
+m_indexingMask = memory().indexingMask();
 }
 
 // We need to clear out the old array buffer because it might now be pointing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226572] branches/safari-604.4.7.10-branch/Source

2018-01-08 Thread jmarcell

Title: [226572] branches/safari-604.4.7.10-branch/Source








Revision 226572
Author jmarc...@apple.com
Date 2018-01-08 15:15:13 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36116826

Use index masking for TypedArrays and and Wasm.
https://bugs.webkit.org/show_bug.cgi?id=180920

Reviewed by Filip Pizlo.

We should have index masking for our TypedArray code in the
DFG/FTL and for Wasm when doing bounds checking. Index masking for
Wasm is added to the WasmBoundsCheckValue. Since we don't CSE any
WasmBoundsCheckValues we don't need to worry about combining a
bounds check for a load and a store. I went with fusing the
pointer masking in the WasmBoundsCheckValue since it should reduce
additional compiler overhead.

* b3/B3LowerToAir.cpp:
* b3/B3Validate.cpp:
* b3/B3WasmBoundsCheckValue.cpp:
(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
(JSC::B3::WasmBoundsCheckValue::dumpMeta const):
* b3/B3WasmBoundsCheckValue.h:
(JSC::B3::WasmBoundsCheckValue::pinnedIndexingMask const):
* b3/air/AirCustom.h:
(JSC::B3::Air::WasmBoundsCheckCustom::generate):
* b3/testb3.cpp:
(JSC::B3::testWasmBoundsCheck):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::loadFromIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::pointerIntoTypedArray):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitComputeButterflyIndexingMask):
* runtime/Butterfly.h:
* runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::JSArrayBufferView):
* runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::offsetOfIndexingMask):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::load):
(JSC::Wasm::B3IRGenerator::store):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::Memory):
* wasm/WasmMemory.h:
(JSC::Wasm::Memory::offsetOfIndexingMask):
* wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::PinnedRegisterInfo::get):
(JSC::Wasm::PinnedRegisterInfo::PinnedRegisterInfo):
* wasm/WasmMemoryInformation.h:
(JSC::Wasm::PinnedRegisterInfo::toSave const):
* wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):

Use index masking for TypedArrays and and Wasm.
https://bugs.webkit.org/show_bug.cgi?id=180920

Reviewed by Filip Pizlo.

Copy things from ToT that we will need for a branch.

* wtf/MathExtras.h:
(WTF::computeIndexingMask):
* wtf/StdLibExtras.h:
(std::clz):

Modified Paths

branches/safari-604.4.7.10-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.10-branch/Source/_javascript_Core/b3/B3LowerToAir.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/b3/B3Validate.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/b3/air/AirCustom.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/b3/testb3.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/jit/AssemblyHelpers.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/Butterfly.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h
branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/WasmBinding.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/WasmMemory.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/wasm/WasmMemory.h

[webkit-changes] [226571] branches/safari-604.4.7.10-branch

2018-01-08 Thread jmarcell

Title: [226571] branches/safari-604.4.7.10-branch








Revision 226571
Author jmarc...@apple.com
Date 2018-01-08 15:15:07 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36116741

Reduce the precision of "high" resolution time to 1ms
https://bugs.webkit.org/show_bug.cgi?id=180910


Reviewed by Saam Barati.

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711

* TestExpectations:

Modified Paths

branches/safari-604.4.7.10-branch/LayoutTests/ChangeLog
branches/safari-604.4.7.10-branch/LayoutTests/TestExpectations
branches/safari-604.4.7.10-branch/Source/WebCore/ChangeLog
branches/safari-604.4.7.10-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
branches/safari-604.4.7.10-branch/Source/WebCore/page/Performance.cpp




Diff

Modified: branches/safari-604.4.7.10-branch/LayoutTests/ChangeLog (226570 => 226571)

--- branches/safari-604.4.7.10-branch/LayoutTests/ChangeLog	2018-01-08 23:15:04 UTC (rev 226570)
+++ branches/safari-604.4.7.10-branch/LayoutTests/ChangeLog	2018-01-08 23:15:07 UTC (rev 226571)
@@ -1,3 +1,31 @@
+2017-12-18  Jason Marcell  
+
+ Apply patch. rdar://problem/36116741
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35339755


Modified: branches/safari-604.4.7.10-branch/LayoutTests/TestExpectations (226570 => 226571)

--- branches/safari-604.4.7.10-branch/LayoutTests/TestExpectations	2018-01-08 23:15:04 UTC (rev 226570)
+++ branches/safari-604.4.7.10-branch/LayoutTests/TestExpectations	2018-01-08 23:15:07 UTC (rev 226571)
@@ -1404,3 +1404,6 @@
 webkit.org/b/177997 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Pass Failure ]
 
 webkit.org/b/174284 media/video-source-before-src.html [ Skip ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]


Modified: branches/safari-604.4.7.10-branch/Source/WebCore/ChangeLog (226570 => 226571)

--- branches/safari-604.4.7.10-branch/Source/WebCore/ChangeLog	2018-01-08 23:15:04 UTC (rev 226570)
+++ branches/safari-604.4.7.10-branch/Source/WebCore/ChangeLog	2018-01-08 23:15:07 UTC (rev 226571)
@@ -1,3 +1,35 @@
+2017-12-18  Jason Marcell  
+
+ Apply patch. rdar://problem/36116741
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::fillRTCStats):
+* page/Performance.cpp:
+(WebCore::Performance::reduceTimeResolution):
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35339755


Modified: branches/safari-604.4.7.10-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226570 => 226571)

--- branches/safari-604.4.7.10-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 23:15:04 UTC (rev 226570)
+++ branches/safari-604.4.7.10-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 23:15:07 UTC (rev 226571)
@@

[webkit-changes] [226569] branches/safari-604.4.7.10-branch/Source/JavaScriptCore

2018-01-08 Thread jmarcell

Title: [226569] branches/safari-604.4.7.10-branch/Source/_javascript_Core








Revision 226569
Author jmarc...@apple.com
Date 2018-01-08 15:14:58 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36116696

Disable/remove SharedArrayBuffers from Web API
rdar://problem/36077849

Removed SharedArrayBuffer prototype and structure to disable.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayBufferPrototype const):
(JSC::JSGlobalObject::arrayBufferStructure const):

Modified Paths

branches/safari-604.4.7.10-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp
branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSGlobalObject.h




Diff

Modified: branches/safari-604.4.7.10-branch/Source/_javascript_Core/ChangeLog (226568 => 226569)

--- branches/safari-604.4.7.10-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:14:11 UTC (rev 226568)
+++ branches/safari-604.4.7.10-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:14:58 UTC (rev 226569)
@@ -1,3 +1,19 @@
+2017-12-19  Jason Marcell  
+
+Apply patch. rdar://problem/36116696
+
+Disable/remove SharedArrayBuffers from Web API
+rdar://problem/36077849
+
+Removed SharedArrayBuffer prototype and structure to disable.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::init):
+(JSC::JSGlobalObject::visitChildren):
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::arrayBufferPrototype const):
+(JSC::JSGlobalObject::arrayBufferStructure const):
+
 2017-11-06  Jason Marcell  
 
 Cherry-pick r224426. rdar://problem/35364690


Modified: branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp (226568 => 226569)

--- branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 23:14:11 UTC (rev 226568)
+++ branches/safari-604.4.7.10-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 23:14:58 UTC (rev 226569)
@@ -574,8 +574,10 @@
 
 m_arrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Default));
 m_arrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_arrayBufferPrototype.get()));
+#if ENABLE(SHARED_ARRAY_BUFFER)
 m_sharedArrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Shared));
 m_sharedArrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_sharedArrayBufferPrototype.get()));
+#endif
 
 m_iteratorPrototype.set(vm, this, IteratorPrototype::create(vm, this, IteratorPrototype::createStructure(vm, this, m_objectPrototype.get(;
 m_generatorPrototype.set(vm, this, GeneratorPrototype::create(vm, this, GeneratorPrototype::createStructure(vm, this, m_iteratorPrototype.get(;
@@ -620,10 +622,11 @@
 
 JSArrayBufferConstructor* arrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_arrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Default);
 m_arrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 JSArrayBufferConstructor* sharedArrayBufferConstructor = nullptr;
 sharedArrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_sharedArrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Shared);
 m_sharedArrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, sharedArrayBufferConstructor, DontEnum);
-
+#endif
 #define CREATE_CONSTRUCTOR_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
 capitalName ## Constructor* lowerName ## Constructor = capitalName ## Constructor::create(vm, capitalName ## Constructor::createStructure(vm, this, m_functionPrototype.get()), m_ ## lowerName ## Prototype.get(), m_speciesGetterSetter.get()); \
 m_ ## lowerName ## Prototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, lowerName ## Constructor, DontEnum); \
@@ -686,7 +689,9 @@
 putDirectWithoutTransition(vm, vm.propertyNames->builtinNames().ArrayPrivateName(), arrayConstructor, DontEnum | DontDelete | ReadOnly);
 
 putDirectWithoutTransition(vm, vm.propertyNames->ArrayBuffer, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 putDirectWithoutTransition(vm,

[webkit-changes] [226568] trunk/Source/WebCore

2018-01-08 Thread zalan

Title: [226568] trunk/Source/WebCore








Revision 226568
Author za...@apple.com
Date 2018-01-08 15:14:11 -0800 (Mon, 08 Jan 2018)


Log Message
[RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181405


Reviewed by Antti Koivisto.

This is about moving the code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addChild):
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addChild):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::addChild):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::RenderTreeBuilder):
(WebCore::RenderTreeBuilder::insertChildToSVGContainer):
(WebCore::RenderTreeBuilder::insertChildToSVGInline):
(WebCore::RenderTreeBuilder::insertChildToSVGRoot):
(WebCore::RenderTreeBuilder::insertChildToSVGText):
* rendering/updating/RenderTreeBuilder.h:
(WebCore::RenderTreeBuilder::SVGBuilder):
* rendering/updating/RenderTreeBuilderSVG.cpp: Added.
(WebCore::RenderTreeBuilder::SVG::SVG):
(WebCore::RenderTreeBuilder::SVG::insertChild):
* rendering/updating/RenderTreeBuilderSVG.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h


Added Paths

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226567 => 226568)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 23:11:11 UTC (rev 226567)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 23:14:11 UTC (rev 226568)
@@ -1,3 +1,39 @@
+2018-01-08  Zalan Bujtas  
+
+[RenderTreeBuilder] Move SVG addChild logic to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=181405
+
+
+Reviewed by Antti Koivisto.
+
+This is about moving the code, no cleanup and/or normalization (unfortunately it also means
+some temporary changes).  
+
+No change in functionality.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/svg/RenderSVGContainer.cpp:
+(WebCore::RenderSVGContainer::addChild):
+* rendering/svg/RenderSVGInline.cpp:
+(WebCore::RenderSVGInline::addChild):
+* rendering/svg/RenderSVGRoot.cpp:
+(WebCore::RenderSVGRoot::addChild):
+* rendering/svg/RenderSVGText.cpp:
+(WebCore::RenderSVGText::addChild):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::RenderTreeBuilder):
+(WebCore::RenderTreeBuilder::insertChildToSVGContainer):
+(WebCore::RenderTreeBuilder::insertChildToSVGInline):
+(WebCore::RenderTreeBuilder::insertChildToSVGRoot):
+(WebCore::RenderTreeBuilder::insertChildToSVGText):
+* rendering/updating/RenderTreeBuilder.h:
+(WebCore::RenderTreeBuilder::SVGBuilder):
+* rendering/updating/RenderTreeBuilderSVG.cpp: Added.
+(WebCore::RenderTreeBuilder::SVG::SVG):
+(WebCore::RenderTreeBuilder::SVG::insertChild):
+* rendering/updating/RenderTreeBuilderSVG.h: Added.
+
 2018-01-08  John Wilander  
 
 Storage Access API: Remove access for all frames under a page when the page is closed


Modified: trunk/Source/WebCore/Sources.txt (226567 => 226568)

--- trunk/Source/WebCore/Sources.txt	2018-01-08 23:11:11 UTC (rev 226567)
+++ trunk/Source/WebCore/Sources.txt	2018-01-08 23:14:11 UTC (rev 226568)
@@ -1992,6 +1992,7 @@
 rendering/updating/RenderTreeBuilderList.cpp
 rendering/updating/RenderTreeBuilderMultiColumn.cpp
 rendering/updating/RenderTreeBuilderRuby.cpp
+rendering/updating/RenderTreeBuilderSVG.cpp
 rendering/updating/RenderTreeBuilderTable.cpp
 rendering/updating/RenderTreePosition.cpp
 rendering/updating/RenderTreeUpdater.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (226567 => 226568)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-08 23:11:11 UTC (rev 226567)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-08 23:14:11 UTC (rev 226568)
@@ -5595,6 +5595,8 @@
 		11C5F1182003E7760001AE60 /* RenderTreeBuilderInline.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderInline.h; sourceTree = ""; };
 		11C5F11D2003F69E0001AE60 /*

[webkit-changes] [226567] tags/Safari-604.4.7.1.6/

2018-01-08 Thread jmarcell

Title: [226567] tags/Safari-604.4.7.1.6/








Revision 226567
Author jmarc...@apple.com
Date 2018-01-08 15:11:11 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.4.7.1.6.

Added Paths

tags/Safari-604.4.7.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226566] tags/Safari-604.4.7.1.5/

2018-01-08 Thread jmarcell

Title: [226566] tags/Safari-604.4.7.1.5/








Revision 226566
Author jmarc...@apple.com
Date 2018-01-08 15:10:29 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.4.7.1.5.

Added Paths

tags/Safari-604.4.7.1.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226565] branches/safari-604.4.7.1-branch/Source

2018-01-08 Thread jmarcell

Title: [226565] branches/safari-604.4.7.1-branch/Source








Revision 226565
Author jmarc...@apple.com
Date 2018-01-08 15:09:30 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (226564 => 226565)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:09:27 UTC (rev 226564)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:09:30 UTC (rev 226565)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226564 => 226565)

--- branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:09:27 UTC (rev 226564)
+++ branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:09:30 UTC (rev 226565)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (226564 => 226565)

--- branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:09:27 UTC (rev 226564)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:09:30 UTC (rev 226565)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (226564 => 226565)

--- branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:09:27 UTC (rev 226564)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:09:30 UTC (rev 226565)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (226564 => 226565)

--- branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:09:27 UTC (rev 226564)
+++ branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:09:30 UTC (rev 226565)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig (226564 => 226565)

--- branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:09:27 UTC (rev 226564)
+++ branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:09:30 UTC (rev 226565)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 6;
+NANO_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified:

[webkit-changes] [226563] branches/safari-604.4.7.1-branch/Source

2018-01-08 Thread jmarcell

Title: [226563] branches/safari-604.4.7.1-branch/Source








Revision 226563
Author jmarc...@apple.com
Date 2018-01-08 15:09:25 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.4.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (226562 => 226563)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:09:22 UTC (rev 226562)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 23:09:25 UTC (rev 226563)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226562 => 226563)

--- branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:09:22 UTC (rev 226562)
+++ branches/safari-604.4.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 23:09:25 UTC (rev 226563)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (226562 => 226563)

--- branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:09:22 UTC (rev 226562)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 23:09:25 UTC (rev 226563)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (226562 => 226563)

--- branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:09:22 UTC (rev 226562)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 23:09:25 UTC (rev 226563)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (226562 => 226563)

--- branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:09:22 UTC (rev 226562)
+++ branches/safari-604.4.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 23:09:25 UTC (rev 226563)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig (226562 => 226563)

--- branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:09:22 UTC (rev 226562)
+++ branches/safari-604.4.7.1-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 23:09:25 UTC (rev 226563)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 1;
-NANO_VERSION = 5;
+NANO_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified:

[webkit-changes] [226564] branches/safari-604.4.7.1-branch/Source/JavaScriptCore/wasm/js/ JSWebAssemblyMemory.cpp

2018-01-08 Thread jmarcell

Title: [226564] branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp








Revision 226564
Author jmarc...@apple.com
Date 2018-01-08 15:09:27 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36267626

fix indexing mask

Modified Paths

branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp




Diff

Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp (226563 => 226564)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-08 23:09:25 UTC (rev 226563)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/js/JSWebAssemblyMemory.cpp	2018-01-08 23:09:27 UTC (rev 226564)
@@ -117,7 +117,7 @@
 }
 m_memoryBase = memory().memory();
 m_memorySize = memory().size();
-m_memorySize = memory().indexingMask();
+m_indexingMask = memory().indexingMask();
 }
 
 // We need to clear out the old array buffer because it might now be pointing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226558] branches/safari-604.4.7.1-branch/Source

2018-01-08 Thread jmarcell

Title: [226558] branches/safari-604.4.7.1-branch/Source








Revision 226558
Author jmarc...@apple.com
Date 2018-01-08 15:08:54 -0800 (Mon, 08 Jan 2018)


Log Message
Cherry-pick r226068. rdar://problem/36116392

Modified Paths

branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/jit/ThunkGenerators.cpp
branches/safari-604.4.7.1-branch/Source/WTF/ChangeLog
branches/safari-604.4.7.1-branch/Source/WTF/wtf/MathExtras.h
branches/safari-604.4.7.1-branch/Source/WTF/wtf/SizeLimits.cpp
branches/safari-604.4.7.1-branch/Source/WTF/wtf/Vector.h
branches/safari-604.4.7.1-branch/Source/WTF/wtf/text/StringImpl.cpp
branches/safari-604.4.7.1-branch/Source/WTF/wtf/text/StringImpl.h
branches/safari-604.4.7.1-branch/Source/WTF/wtf/text/StringView.h
branches/safari-604.4.7.1-branch/Source/WTF/wtf/text/WTFString.h




Diff

Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog (226557 => 226558)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:08:49 UTC (rev 226557)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:08:54 UTC (rev 226558)
@@ -1,3 +1,26 @@
+2017-12-18  Jason Marcell  
+
+Cherry-pick r226068. rdar://problem/36116392
+
+2017-12-16  Filip Pizlo  
+
+Vector index masking
+https://bugs.webkit.org/show_bug.cgi?id=180909
+
+Reviewed by Keith Miller.
+
+Adopt index masking for strings.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
+* ftl/FTLAbstractHeapRepository.h:
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
+(JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt):
+* jit/ThunkGenerators.cpp:
+(JSC::stringCharLoad):
+
 2017-12-19  Jason Marcell  
 
 Apply patch. rdar://problem/36116362


Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (226557 => 226558)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-08 23:08:49 UTC (rev 226557)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-08 23:08:54 UTC (rev 226558)
@@ -1994,6 +1994,7 @@
 GPRReg scratchReg = scratch.gpr();
 
 m_jit.loadPtr(MacroAssembler::Address(stringReg, JSString::offsetOfValue()), scratchReg);
+m_jit.and32(MacroAssembler::Address(scratchReg, StringImpl::maskOffset()), indexReg);
 
 // Load the character into scratchReg
 JITCompiler::Jump is16Bit = m_jit.branchTest32(MacroAssembler::Zero, MacroAssembler::Address(scratchReg, StringImpl::flagsOffset()), TrustedImm32(StringImpl::flagIs8Bit()));
@@ -2041,6 +2042,7 @@
 speculationCheck(OutOfBounds, JSValueRegs(), 0, outOfBounds);
 
 m_jit.loadPtr(MacroAssembler::Address(baseReg, JSString::offsetOfValue()), scratchReg);
+m_jit.and32(MacroAssembler::Address(scratchReg, StringImpl::maskOffset()), propertyReg);
 
 // Load the character into scratchReg
 JITCompiler::Jump is16Bit = m_jit.branchTest32(MacroAssembler::Zero, MacroAssembler::Address(scratchReg, StringImpl::flagsOffset()), TrustedImm32(StringImpl::flagIs8Bit()));


Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h (226557 => 226558)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h	2018-01-08 23:08:49 UTC (rev 226557)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h	2018-01-08 23:08:54 UTC (rev 226558)
@@ -105,6 +105,7 @@
 macro(StringImpl_data, StringImpl::dataOffset()) \
 macro(StringImpl_hashAndFlags, StringImpl::flagsOffset()) \
 macro(StringImpl_length, StringImpl::lengthMemoryOffset()) \
+macro(StringImpl_mask, StringImpl::maskOffset()) \
 macro(Structure_classInfo, Structure::classInfoOffset()) \
 macro(Structure_globalObject, Structure::globalObjectOffset()) \
 macro(Structure_prototype, Structure::prototypeOffset()) \


Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (226557 => 226558)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2018-01-08 23:08:49 UTC (rev 226557)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2018-01-08 23:08:54 UTC (rev 226558)
@@ -5400,6 +5400,7 @@
 LBasicBlock lastNext =

[webkit-changes] [226559] branches/safari-604.4.7.1-branch

2018-01-08 Thread jmarcell

Title: [226559] branches/safari-604.4.7.1-branch








Revision 226559
Author jmarc...@apple.com
Date 2018-01-08 15:08:58 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36116546

Reduce the precision of "high" resolution time to 1ms
https://bugs.webkit.org/show_bug.cgi?id=180910


Reviewed by Saam Barati.

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711

* TestExpectations:

Modified Paths

branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog
branches/safari-604.4.7.1-branch/LayoutTests/TestExpectations
branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog
branches/safari-604.4.7.1-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
branches/safari-604.4.7.1-branch/Source/WebCore/page/Performance.cpp




Diff

Modified: branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog (226558 => 226559)

--- branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog	2018-01-08 23:08:54 UTC (rev 226558)
+++ branches/safari-604.4.7.1-branch/LayoutTests/ChangeLog	2018-01-08 23:08:58 UTC (rev 226559)
@@ -1,3 +1,31 @@
+2017-12-18  Jason Marcell  
+
+Apply patch. rdar://problem/36116546
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35296404


Modified: branches/safari-604.4.7.1-branch/LayoutTests/TestExpectations (226558 => 226559)

--- branches/safari-604.4.7.1-branch/LayoutTests/TestExpectations	2018-01-08 23:08:54 UTC (rev 226558)
+++ branches/safari-604.4.7.1-branch/LayoutTests/TestExpectations	2018-01-08 23:08:58 UTC (rev 226559)
@@ -1404,3 +1404,6 @@
 webkit.org/b/177997 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Pass Failure ]
 
 webkit.org/b/174284 media/video-source-before-src.html [ Skip ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]


Modified: branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog (226558 => 226559)

--- branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog	2018-01-08 23:08:54 UTC (rev 226558)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/ChangeLog	2018-01-08 23:08:58 UTC (rev 226559)
@@ -1,3 +1,35 @@
+2017-12-18  Jason Marcell  
+
+Apply patch. rdar://problem/36116546
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::fillRTCStats):
+* page/Performance.cpp:
+(WebCore::Performance::reduceTimeResolution):
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35296404


Modified: branches/safari-604.4.7.1-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226558 => 226559)

--- branches/safari-604.4.7.1-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 23:08:54 UTC (rev 226558)
+++ branches/safari-604.4.7.1-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 23:08:58 UTC (rev 226559)
@@ -35,6 +35,7 @@

[webkit-changes] [226560] branches/safari-604.4.7.1-branch/Source

2018-01-08 Thread jmarcell

Title: [226560] branches/safari-604.4.7.1-branch/Source








Revision 226560
Author jmarc...@apple.com
Date 2018-01-08 15:09:04 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36116390

Use index masking for TypedArrays and and Wasm.
https://bugs.webkit.org/show_bug.cgi?id=180920

Reviewed by Filip Pizlo.

We should have index masking for our TypedArray code in the
DFG/FTL and for Wasm when doing bounds checking. Index masking for
Wasm is added to the WasmBoundsCheckValue. Since we don't CSE any
WasmBoundsCheckValues we don't need to worry about combining a
bounds check for a load and a store. I went with fusing the
pointer masking in the WasmBoundsCheckValue since it should reduce
additional compiler overhead.

* b3/B3LowerToAir.cpp:
* b3/B3Validate.cpp:
* b3/B3WasmBoundsCheckValue.cpp:
(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
(JSC::B3::WasmBoundsCheckValue::dumpMeta const):
* b3/B3WasmBoundsCheckValue.h:
(JSC::B3::WasmBoundsCheckValue::pinnedIndexingMask const):
* b3/air/AirCustom.h:
(JSC::B3::Air::WasmBoundsCheckCustom::generate):
* b3/testb3.cpp:
(JSC::B3::testWasmBoundsCheck):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::loadFromIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::pointerIntoTypedArray):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitComputeButterflyIndexingMask):
* runtime/Butterfly.h:
* runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::JSArrayBufferView):
* runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::offsetOfIndexingMask):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::load):
(JSC::Wasm::B3IRGenerator::store):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::Memory):
* wasm/WasmMemory.h:
(JSC::Wasm::Memory::offsetOfIndexingMask):
* wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::PinnedRegisterInfo::get):
(JSC::Wasm::PinnedRegisterInfo::PinnedRegisterInfo):
* wasm/WasmMemoryInformation.h:
(JSC::Wasm::PinnedRegisterInfo::toSave const):
* wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):

Use index masking for TypedArrays and and Wasm.
https://bugs.webkit.org/show_bug.cgi?id=180920

Reviewed by Filip Pizlo.

Copy things from ToT that we will need for a branch.

* wtf/MathExtras.h:
(WTF::computeIndexingMask):
* wtf/StdLibExtras.h:
(std::clz):

Modified Paths

branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.1-branch/Source/_javascript_Core/b3/B3LowerToAir.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/b3/B3Validate.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/b3/air/AirCustom.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/b3/testb3.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/jit/AssemblyHelpers.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/Butterfly.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/WasmBinding.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/WasmMemory.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/WasmMemory.h
branches/safari-604.4.7.1-branch/Source/_javascript_Core/wasm/WasmMemoryInformation.cpp

[webkit-changes] [226557] branches/safari-604.4.7.1-branch/Source/JavaScriptCore

2018-01-08 Thread jmarcell

Title: [226557] branches/safari-604.4.7.1-branch/Source/_javascript_Core








Revision 226557
Author jmarc...@apple.com
Date 2018-01-08 15:08:49 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36116362

Disable/remove SharedArrayBuffers from Web API
rdar://problem/36077849

Removed SharedArrayBuffer prototype and structure to disable.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayBufferPrototype const):
(JSC::JSGlobalObject::arrayBufferStructure const):

Modified Paths

branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp
branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSGlobalObject.h




Diff

Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog (226556 => 226557)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog	2018-01-08 22:59:10 UTC (rev 226556)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/ChangeLog	2018-01-08 23:08:49 UTC (rev 226557)
@@ -1,3 +1,19 @@
+2017-12-19  Jason Marcell  
+
+Apply patch. rdar://problem/36116362
+
+Disable/remove SharedArrayBuffers from Web API
+rdar://problem/36077849
+
+Removed SharedArrayBuffer prototype and structure to disable.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::init):
+(JSC::JSGlobalObject::visitChildren):
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::arrayBufferPrototype const):
+(JSC::JSGlobalObject::arrayBufferStructure const):
+
 2017-11-06  Jason Marcell  
 
 Cherry-pick r224426. rdar://problem/35364675


Modified: branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp (226556 => 226557)

--- branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 22:59:10 UTC (rev 226556)
+++ branches/safari-604.4.7.1-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 23:08:49 UTC (rev 226557)
@@ -574,8 +574,10 @@
 
 m_arrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Default));
 m_arrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_arrayBufferPrototype.get()));
+#if ENABLE(SHARED_ARRAY_BUFFER)
 m_sharedArrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Shared));
 m_sharedArrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_sharedArrayBufferPrototype.get()));
+#endif
 
 m_iteratorPrototype.set(vm, this, IteratorPrototype::create(vm, this, IteratorPrototype::createStructure(vm, this, m_objectPrototype.get(;
 m_generatorPrototype.set(vm, this, GeneratorPrototype::create(vm, this, GeneratorPrototype::createStructure(vm, this, m_iteratorPrototype.get(;
@@ -620,10 +622,11 @@
 
 JSArrayBufferConstructor* arrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_arrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Default);
 m_arrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 JSArrayBufferConstructor* sharedArrayBufferConstructor = nullptr;
 sharedArrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_sharedArrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Shared);
 m_sharedArrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, sharedArrayBufferConstructor, DontEnum);
-
+#endif
 #define CREATE_CONSTRUCTOR_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
 capitalName ## Constructor* lowerName ## Constructor = capitalName ## Constructor::create(vm, capitalName ## Constructor::createStructure(vm, this, m_functionPrototype.get()), m_ ## lowerName ## Prototype.get(), m_speciesGetterSetter.get()); \
 m_ ## lowerName ## Prototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, lowerName ## Constructor, DontEnum); \
@@ -686,7 +689,9 @@
 putDirectWithoutTransition(vm, vm.propertyNames->builtinNames().ArrayPrivateName(), arrayConstructor, DontEnum | DontDelete | ReadOnly);
 
 putDirectWithoutTransition(vm, vm.propertyNames->ArrayBuffer, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 putDirectWithoutTransition(vm, vm.propertyNames->SharedArrayBuffer,

[webkit-changes] [226556] trunk/Source/JavaScriptCore

2018-01-08 Thread mark . lam

Title: [226556] trunk/Source/_javascript_Core








Revision 226556
Author mark@apple.com
Date 2018-01-08 14:59:10 -0800 (Mon, 08 Jan 2018)


Log Message
Rename CodeBlock::m_vm to CodeBlock::m_poisonedVM.
https://bugs.webkit.org/show_bug.cgi?id=181403


Rubber-stamped by JF Bastien.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::predictedMachineCodeSize):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::vm const):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::heap const):
(JSC::CodeBlock::replaceConstant):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226555 => 226556)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-08 22:51:30 UTC (rev 226555)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-08 22:59:10 UTC (rev 226556)
@@ -1,3 +1,28 @@
+2018-01-08  Mark Lam  
+
+Rename CodeBlock::m_vm to CodeBlock::m_poisonedVM.
+https://bugs.webkit.org/show_bug.cgi?id=181403
+
+
+Rubber-stamped by JF Bastien.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::~CodeBlock):
+(JSC::CodeBlock::setConstantRegisters):
+(JSC::CodeBlock::propagateTransitions):
+(JSC::CodeBlock::finalizeLLIntInlineCaches):
+(JSC::CodeBlock::jettison):
+(JSC::CodeBlock::predictedMachineCodeSize):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::vm const):
+(JSC::CodeBlock::addConstant):
+(JSC::CodeBlock::heap const):
+(JSC::CodeBlock::replaceConstant):
+* llint/LowLevelInterpreter.asm:
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+
 2018-01-07  Mark Lam  
 
 Apply poisoning to more pointers in JSC.


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (226555 => 226556)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2018-01-08 22:51:30 UTC (rev 226555)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2018-01-08 22:59:10 UTC (rev 226556)
@@ -313,7 +313,7 @@
 , m_steppingMode(SteppingModeDisabled)
 , m_numBreakpoints(0)
 , m_ownerExecutable(*other.vm(), this, other.m_ownerExecutable.get())
-, m_vm(other.m_vm)
+, m_poisonedVM(other.m_poisonedVM)
 , m_instructions(other.m_instructions)
 , m_thisRegister(other.m_thisRegister)
 , m_scopeRegister(other.m_scopeRegister)
@@ -379,7 +379,7 @@
 , m_steppingMode(SteppingModeDisabled)
 , m_numBreakpoints(0)
 , m_ownerExecutable(*vm, this, ownerExecutable)
-, m_vm(vm)
+, m_poisonedVM(vm)
 , m_thisRegister(unlinkedCodeBlock->thisRegister())
 , m_scopeRegister(unlinkedCodeBlock->scopeRegister())
 , m_source(WTFMove(sourceProvider))
@@ -857,7 +857,7 @@
 
 CodeBlock::~CodeBlock()
 {
-VM& vm = *m_vm;
+VM& vm = *m_poisonedVM;
 if (UNLIKELY(vm.m_perBytecodeProfiler))
 vm.m_perBytecodeProfiler->notifyDestruction(this);
 
@@ -914,7 +914,7 @@
 
 void CodeBlock::setConstantRegisters(const Vector& constants, const Vector& constantsSourceCodeRepresentation)
 {
-VM& vm = *m_vm;
+VM& vm = *m_poisonedVM;
 auto scope = DECLARE_THROW_SCOPE(vm);
 JSGlobalObject* globalObject = m_globalObject.get();
 ExecState* exec = globalObject->globalExec();
@@ -1167,7 +1167,7 @@
 if (m_allTransitionsHaveBeenMarked)
 return;
 
-VM& vm = *m_vm;
+VM& vm = *m_poisonedVM;
 bool allAreMarkedSoFar = true;
 
 if (jitType() == JITCode::InterpreterThunk) {
@@ -1300,7 +1300,7 @@
 
 void CodeBlock::finalizeLLIntInlineCaches()
 {
-VM& vm = *m_vm;
+VM& vm = *m_poisonedVM;
 const Vector& propertyAccessInstructions = m_unlinkedCode->propertyAccessInstructions();
 for (size_t size = propertyAccessInstructions.size(), i = 0; i < size; ++i) {
 Instruction* curInstruction = ()[propertyAccessInstructions[i]];
@@ -1960,7 +1960,7 @@
 }
 #endif // ENABLE(DFG_JIT)
 
-VM& vm = *m_vm;
+VM& vm = *m_poisonedVM;
 DeferGCForAWhile deferGC(*heap());
 
 // We want to accomplish two things here:
@@ -2768,8 +2768,8 @@
 
 size_t CodeBlock::predictedMachineCodeSize()
 {
-VM* vm = m_vm.unpoisoned();
-// This will be called from CodeBlock::CodeBlock before either m_vm or the
+VM* vm = m_poisonedVM.unpoisoned();
+

[webkit-changes] [226554] tags/Safari-604.4.7.0.4/

2018-01-08 Thread jmarcell

Title: [226554] tags/Safari-604.4.7.0.4/








Revision 226554
Author jmarc...@apple.com
Date 2018-01-08 14:50:34 -0800 (Mon, 08 Jan 2018)


Log Message
Tag Safari-604.4.7.0.4.

Added Paths

tags/Safari-604.4.7.0.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226548] branches/safari-604.4.7.0-branch/Source/JavaScriptCore

2018-01-08 Thread jmarcell

Title: [226548] branches/safari-604.4.7.0-branch/Source/_javascript_Core








Revision 226548
Author jmarc...@apple.com
Date 2018-01-08 14:42:10 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36113365

32-bit fix.

Modified Paths

branches/safari-604.4.7.0-branch/Source/_javascript_Core/assembler/MacroAssembler.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/jit/AssemblyHelpers.h




Diff

Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/assembler/MacroAssembler.h (226547 => 226548)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/assembler/MacroAssembler.h	2018-01-08 22:42:07 UTC (rev 226547)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/assembler/MacroAssembler.h	2018-01-08 22:42:10 UTC (rev 226548)
@@ -593,6 +593,11 @@
 urshift32(trustedImm32ForShift(imm), srcDest);
 }
 
+void urshiftPtr(RegisterID shiftAmmount, RegisterID srcDest)
+{
+urshift32(shiftAmmount, srcDest);
+}
+
 void negPtr(RegisterID dest)
 {
 neg32(dest);
@@ -902,6 +907,11 @@
 urshift64(trustedImm32ForShift(imm), srcDest);
 }
 
+void urshiftPtr(RegisterID shiftAmmount, RegisterID srcDest)
+{
+urshift64(shiftAmmount, srcDest);
+}
+
 void negPtr(RegisterID dest)
 {
 neg64(dest);


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/jit/AssemblyHelpers.h (226547 => 226548)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/jit/AssemblyHelpers.h	2018-01-08 22:42:07 UTC (rev 226547)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/jit/AssemblyHelpers.h	2018-01-08 22:42:10 UTC (rev 226548)
@@ -1442,10 +1442,20 @@
 
 void emitComputeButterflyIndexingMask(GPRReg vectorLengthGPR, GPRReg scratchGPR, GPRReg resultGPR)
 {
+ASSERT(scratchGPR != resultGPR);
+Jump done;
+if (isX86() && !isX86_64()) {
+Jump nonZero = branchTest32(NonZero, vectorLengthGPR);
+move(TrustedImm32(0), resultGPR);
+done = jump();
+nonZero.link(this);
+}
 // If vectorLength == 0 then clz will return 32 on both ARM and x86. On 64-bit systems, we can then do a 64-bit right shift on a 32-bit -1 to get a 0 mask for zero vectorLength. On 32-bit ARM, shift masks with 0xff, which means it will still create a 0 mask.
 countLeadingZeros32(vectorLengthGPR, scratchGPR);
 move(TrustedImm32(-1), resultGPR);
-urshift64(scratchGPR, resultGPR);
+urshiftPtr(scratchGPR, resultGPR);
+if (done.isSet())
+done.link(this);
 }
 
 // Call this if you know that the value held in allocatorGPR is non-null. This DOES NOT mean






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226549] branches/safari-604.4.7.0-branch/Source/JavaScriptCore/offlineasm

2018-01-08 Thread jmarcell

Title: [226549] branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm








Revision 226549
Author jmarc...@apple.com
Date 2018-01-08 14:42:12 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36113365

Fix build failure for iOS. Partial cherry-pick r223239 (offlineasm portion of that change).

Modified Paths

branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/arm64.rb
branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/asm.rb
branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/instructions.rb




Diff

Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/arm64.rb (226548 => 226549)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/arm64.rb	2018-01-08 22:42:10 UTC (rev 226548)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/arm64.rb	2018-01-08 22:42:12 UTC (rev 226549)
@@ -260,6 +260,31 @@
 newList
 end
 
+def arm64LowerLabelReferences(list)
+newList = []
+list.each {
+| node |
+if node.is_a? Instruction
+case node.opcode
+when "loadi", "loadis", "loadp", "loadq", "loadb", "loadbs", "loadh", "loadhs"
+labelRef = node.operands[0]
+if labelRef.is_a? LabelReference
+tmp = Tmp.new(node.codeOrigin, :gpr)
+newList << Instruction.new(codeOrigin, "globaladdr", [LabelReference.new(node.codeOrigin, labelRef.label), tmp])
+newList << Instruction.new(codeOrigin, node.opcode, [Address.new(node.codeOrigin, tmp, Immediate.new(node.codeOrigin, labelRef.offset)), node.operands[1]])
+else
+newList << node
+end
+else
+newList << node
+end
+else
+newList << node
+end
+}
+newList
+end
+
 # Workaround for Cortex-A53 erratum (835769)
 def arm64CortexA53Fix835769(list)
 newList = []
@@ -296,6 +321,7 @@
 result = riscLowerHardBranchOps64(result)
 result = riscLowerShiftOps(result)
 result = arm64LowerMalformedLoadStoreAddresses(result)
+result = arm64LowerLabelReferences(result)
 result = riscLowerMalformedAddresses(result) {
 | node, address |
 case node.opcode
@@ -904,6 +930,15 @@
 $asm.putStr("#if CPU(ARM64_CORTEXA53)")
 $asm.puts "nop"
 $asm.putStr("#endif")
+when "globaladdr"
+uid = $asm.newUID
+$asm.puts "L_offlineasm_loh_adrp_#{uid}:"
+$asm.puts "adrp #{operands[1].arm64Operand(:ptr)}, #{operands[0].asmLabel}@GOTPAGE"
+$asm.puts "L_offlineasm_loh_ldr_#{uid}:"
+$asm.puts "ldr #{operands[1].arm64Operand(:ptr)}, [#{operands[1].arm64Operand(:ptr)}, #{operands[0].asmLabel}@GOTPAGEOFF]"
+$asm.deferAction {
+$asm.puts ".loh AdrpLdrGot L_offlineasm_loh_adrp_#{uid}, L_offlineasm_loh_ldr_#{uid}"
+}
 else
 lowerDefault
 end


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/asm.rb (226548 => 226549)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/asm.rb	2018-01-08 22:42:10 UTC (rev 226548)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/asm.rb	2018-01-08 22:42:12 UTC (rev 226549)
@@ -46,6 +46,8 @@
 @codeOrigin = nil
 @numLocalLabels = 0
 @numGlobalLabels = 0
+@deferredActions = []
+@count = 0
 
 @newlineSpacerState = :none
 @lastlabel = ""
@@ -73,10 +75,23 @@
 putsProcEndIfNeeded
 end
 putsLastComment
+@deferredActions.each {
+| action |
+action.call()
+}
 @outp.puts "OFFLINE_ASM_END" if !$emitWinAsm
 @state = :cpp
 end
 
+def deferAction()
+@deferredActions << proc
+end
+
+def newUID
+@count += 1
+@count
+end
+
 def inAsm
 enterAsm
 yield


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/instructions.rb (226548 => 226549)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/instructions.rb	2018-01-08 22:42:10 UTC (rev 226548)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/offlineasm/instructions.rb	2018-01-08 22:42:12 UTC (rev 226549)
@@ -267,7 +267,8 @@
 ARM64_INSTRUCTIONS =
 [
  "pcrtoaddr",   # Address from PC relative offset - adr instruction
- "nopFixCortexA53Err835769" # nop on Cortex-A53 (nothing otherwise)
+ "nopFixCortexA53Err835769", # nop on Cortex-A53 (nothing otherwise)
+ "globaladdr"
 ]
 
 RISC_INSTRUCTIONS =






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226550] branches/safari-604.4.7.0-branch/Source

2018-01-08 Thread jmarcell

Title: [226550] branches/safari-604.4.7.0-branch/Source








Revision 226550
Author jmarc...@apple.com
Date 2018-01-08 14:42:16 -0800 (Mon, 08 Jan 2018)


Log Message
Versioning.

Modified Paths

branches/safari-604.4.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.4.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.4.7.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.4.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.4.7.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.4.7.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.4.7.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (226549 => 226550)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 22:42:12 UTC (rev 226549)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-08 22:42:16 UTC (rev 226550)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 0;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (226549 => 226550)

--- branches/safari-604.4.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 22:42:12 UTC (rev 226549)
+++ branches/safari-604.4.7.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-08 22:42:16 UTC (rev 226550)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 0;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.0-branch/Source/WebCore/Configurations/Version.xcconfig (226549 => 226550)

--- branches/safari-604.4.7.0-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 22:42:12 UTC (rev 226549)
+++ branches/safari-604.4.7.0-branch/Source/WebCore/Configurations/Version.xcconfig	2018-01-08 22:42:16 UTC (rev 226550)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 0;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (226549 => 226550)

--- branches/safari-604.4.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 22:42:12 UTC (rev 226549)
+++ branches/safari-604.4.7.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-08 22:42:16 UTC (rev 226550)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 0;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.4.7.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (226549 => 226550)

--- branches/safari-604.4.7.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 22:42:12 UTC (rev 226549)
+++ branches/safari-604.4.7.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-08 22:42:16 UTC (rev 226550)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 0;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-604.4.7.0-branch/Source/WebKit/Configurations/Version.xcconfig (226549 => 226550)

--- branches/safari-604.4.7.0-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 22:42:12 UTC (rev 226549)
+++ branches/safari-604.4.7.0-branch/Source/WebKit/Configurations/Version.xcconfig	2018-01-08 22:42:16 UTC (rev 226550)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 4;
 TINY_VERSION = 7;
 MICRO_VERSION = 0;
-NANO_VERSION = 4;
+NANO_VERSION = 5;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified:

[webkit-changes] [226544] branches/safari-604.4.7.0-branch/Source

2018-01-08 Thread jmarcell

Title: [226544] branches/safari-604.4.7.0-branch/Source








Revision 226544
Author jmarc...@apple.com
Date 2018-01-08 14:41:39 -0800 (Mon, 08 Jan 2018)


Log Message
Cherry-pick r226068. rdar://problem/36113378

Modified Paths

branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/jit/ThunkGenerators.cpp
branches/safari-604.4.7.0-branch/Source/WTF/ChangeLog
branches/safari-604.4.7.0-branch/Source/WTF/wtf/MathExtras.h
branches/safari-604.4.7.0-branch/Source/WTF/wtf/SizeLimits.cpp
branches/safari-604.4.7.0-branch/Source/WTF/wtf/Vector.h
branches/safari-604.4.7.0-branch/Source/WTF/wtf/text/StringImpl.cpp
branches/safari-604.4.7.0-branch/Source/WTF/wtf/text/StringImpl.h
branches/safari-604.4.7.0-branch/Source/WTF/wtf/text/StringView.h
branches/safari-604.4.7.0-branch/Source/WTF/wtf/text/WTFString.h




Diff

Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog (226543 => 226544)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog	2018-01-08 22:41:33 UTC (rev 226543)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog	2018-01-08 22:41:39 UTC (rev 226544)
@@ -1,3 +1,26 @@
+2017-12-18  Jason Marcell  
+
+Cherry-pick r226068. rdar://problem/36113378
+
+2017-12-16  Filip Pizlo  
+
+Vector index masking
+https://bugs.webkit.org/show_bug.cgi?id=180909
+
+Reviewed by Keith Miller.
+
+Adopt index masking for strings.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
+* ftl/FTLAbstractHeapRepository.h:
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
+(JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt):
+* jit/ThunkGenerators.cpp:
+(JSC::stringCharLoad):
+
 2017-12-19  Jason Marcell  
 
 Apply patch. rdar://problem/36113314


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (226543 => 226544)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-08 22:41:33 UTC (rev 226543)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-08 22:41:39 UTC (rev 226544)
@@ -1994,6 +1994,7 @@
 GPRReg scratchReg = scratch.gpr();
 
 m_jit.loadPtr(MacroAssembler::Address(stringReg, JSString::offsetOfValue()), scratchReg);
+m_jit.and32(MacroAssembler::Address(scratchReg, StringImpl::maskOffset()), indexReg);
 
 // Load the character into scratchReg
 JITCompiler::Jump is16Bit = m_jit.branchTest32(MacroAssembler::Zero, MacroAssembler::Address(scratchReg, StringImpl::flagsOffset()), TrustedImm32(StringImpl::flagIs8Bit()));
@@ -2041,6 +2042,7 @@
 speculationCheck(OutOfBounds, JSValueRegs(), 0, outOfBounds);
 
 m_jit.loadPtr(MacroAssembler::Address(baseReg, JSString::offsetOfValue()), scratchReg);
+m_jit.and32(MacroAssembler::Address(scratchReg, StringImpl::maskOffset()), propertyReg);
 
 // Load the character into scratchReg
 JITCompiler::Jump is16Bit = m_jit.branchTest32(MacroAssembler::Zero, MacroAssembler::Address(scratchReg, StringImpl::flagsOffset()), TrustedImm32(StringImpl::flagIs8Bit()));


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h (226543 => 226544)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h	2018-01-08 22:41:33 UTC (rev 226543)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h	2018-01-08 22:41:39 UTC (rev 226544)
@@ -105,6 +105,7 @@
 macro(StringImpl_data, StringImpl::dataOffset()) \
 macro(StringImpl_hashAndFlags, StringImpl::flagsOffset()) \
 macro(StringImpl_length, StringImpl::lengthMemoryOffset()) \
+macro(StringImpl_mask, StringImpl::maskOffset()) \
 macro(Structure_classInfo, Structure::classInfoOffset()) \
 macro(Structure_globalObject, Structure::globalObjectOffset()) \
 macro(Structure_prototype, Structure::prototypeOffset()) \


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (226543 => 226544)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2018-01-08 22:41:33 UTC (rev 226543)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2018-01-08 22:41:39 UTC (rev 226544)
@@ -5400,6 +5400,7 @@
 LBasicBlock lastNext =

[webkit-changes] [226545] branches/safari-604.4.7.0-branch

2018-01-08 Thread jmarcell

Title: [226545] branches/safari-604.4.7.0-branch








Revision 226545
Author jmarc...@apple.com
Date 2018-01-08 14:41:42 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36113340

Reduce the precision of "high" resolution time to 1ms
https://bugs.webkit.org/show_bug.cgi?id=180910


Reviewed by Saam Barati.

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711

* TestExpectations:

Modified Paths

branches/safari-604.4.7.0-branch/LayoutTests/ChangeLog
branches/safari-604.4.7.0-branch/LayoutTests/TestExpectations
branches/safari-604.4.7.0-branch/Source/WebCore/ChangeLog
branches/safari-604.4.7.0-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
branches/safari-604.4.7.0-branch/Source/WebCore/page/Performance.cpp




Diff

Modified: branches/safari-604.4.7.0-branch/LayoutTests/ChangeLog (226544 => 226545)

--- branches/safari-604.4.7.0-branch/LayoutTests/ChangeLog	2018-01-08 22:41:39 UTC (rev 226544)
+++ branches/safari-604.4.7.0-branch/LayoutTests/ChangeLog	2018-01-08 22:41:42 UTC (rev 226545)
@@ -1,3 +1,31 @@
+2017-12-18  Jason Marcell  
+
+Apply patch. rdar://problem/36113340
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35296405


Modified: branches/safari-604.4.7.0-branch/LayoutTests/TestExpectations (226544 => 226545)

--- branches/safari-604.4.7.0-branch/LayoutTests/TestExpectations	2018-01-08 22:41:39 UTC (rev 226544)
+++ branches/safari-604.4.7.0-branch/LayoutTests/TestExpectations	2018-01-08 22:41:42 UTC (rev 226545)
@@ -1404,3 +1404,6 @@
 webkit.org/b/177997 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Pass Failure ]
 
 webkit.org/b/174284 media/video-source-before-src.html [ Skip ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]


Modified: branches/safari-604.4.7.0-branch/Source/WebCore/ChangeLog (226544 => 226545)

--- branches/safari-604.4.7.0-branch/Source/WebCore/ChangeLog	2018-01-08 22:41:39 UTC (rev 226544)
+++ branches/safari-604.4.7.0-branch/Source/WebCore/ChangeLog	2018-01-08 22:41:42 UTC (rev 226545)
@@ -1,3 +1,35 @@
+2017-12-18  Jason Marcell  
+
+Apply patch. rdar://problem/36113340
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2017-12-18  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::fillRTCStats):
+* page/Performance.cpp:
+(WebCore::Performance::reduceTimeResolution):
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35296405


Modified: branches/safari-604.4.7.0-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226544 => 226545)

--- branches/safari-604.4.7.0-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 22:41:39 UTC (rev 226544)
+++ branches/safari-604.4.7.0-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 22:41:42 UTC (rev 226545)
@@ -35,6 +35,7 @@

[webkit-changes] [226546] branches/safari-604.4.7.0-branch/Source

2018-01-08 Thread jmarcell

Title: [226546] branches/safari-604.4.7.0-branch/Source








Revision 226546
Author jmarc...@apple.com
Date 2018-01-08 14:41:50 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36113365

Use index masking for TypedArrays and and Wasm.
https://bugs.webkit.org/show_bug.cgi?id=180920

Reviewed by Filip Pizlo.

We should have index masking for our TypedArray code in the
DFG/FTL and for Wasm when doing bounds checking. Index masking for
Wasm is added to the WasmBoundsCheckValue. Since we don't CSE any
WasmBoundsCheckValues we don't need to worry about combining a
bounds check for a load and a store. I went with fusing the
pointer masking in the WasmBoundsCheckValue since it should reduce
additional compiler overhead.

* b3/B3LowerToAir.cpp:
* b3/B3Validate.cpp:
* b3/B3WasmBoundsCheckValue.cpp:
(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
(JSC::B3::WasmBoundsCheckValue::dumpMeta const):
* b3/B3WasmBoundsCheckValue.h:
(JSC::B3::WasmBoundsCheckValue::pinnedIndexingMask const):
* b3/air/AirCustom.h:
(JSC::B3::Air::WasmBoundsCheckCustom::generate):
* b3/testb3.cpp:
(JSC::B3::testWasmBoundsCheck):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::loadFromIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::pointerIntoTypedArray):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitComputeButterflyIndexingMask):
* runtime/Butterfly.h:
* runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::JSArrayBufferView):
* runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::offsetOfIndexingMask):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::load):
(JSC::Wasm::B3IRGenerator::store):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::Memory):
* wasm/WasmMemory.h:
(JSC::Wasm::Memory::offsetOfIndexingMask):
* wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::PinnedRegisterInfo::get):
(JSC::Wasm::PinnedRegisterInfo::PinnedRegisterInfo):
* wasm/WasmMemoryInformation.h:
(JSC::Wasm::PinnedRegisterInfo::toSave const):
* wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):

Use index masking for TypedArrays and and Wasm.
https://bugs.webkit.org/show_bug.cgi?id=180920

Reviewed by Filip Pizlo.

Copy things from ToT that we will need for a branch.

* wtf/MathExtras.h:
(WTF::computeIndexingMask):
* wtf/StdLibExtras.h:
(std::clz):

Modified Paths

branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.0-branch/Source/_javascript_Core/b3/B3LowerToAir.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/b3/B3Validate.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/b3/air/AirCustom.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/b3/testb3.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/jit/AssemblyHelpers.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/Butterfly.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/wasm/WasmBinding.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/wasm/WasmMemory.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/wasm/WasmMemory.h
branches/safari-604.4.7.0-branch/Source/_javascript_Core/wasm/WasmMemoryInformation.cpp

[webkit-changes] [226543] branches/safari-604.4.7.0-branch/Source/JavaScriptCore

2018-01-08 Thread jmarcell

Title: [226543] branches/safari-604.4.7.0-branch/Source/_javascript_Core








Revision 226543
Author jmarc...@apple.com
Date 2018-01-08 14:41:33 -0800 (Mon, 08 Jan 2018)


Log Message
Apply patch. rdar://problem/36113314

Disable/remove SharedArrayBuffers from Web API
rdar://problem/36077849

Removed SharedArrayBuffer prototype and structure to disable.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayBufferPrototype const):
(JSC::JSGlobalObject::arrayBufferStructure const):

Modified Paths

branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp
branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSGlobalObject.h




Diff

Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog (226542 => 226543)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog	2018-01-08 22:41:07 UTC (rev 226542)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/ChangeLog	2018-01-08 22:41:33 UTC (rev 226543)
@@ -1,3 +1,19 @@
+2017-12-19  Jason Marcell  
+
+Apply patch. rdar://problem/36113314
+
+Disable/remove SharedArrayBuffers from Web API
+rdar://problem/36077849
+
+Removed SharedArrayBuffer prototype and structure to disable.
+
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::init):
+(JSC::JSGlobalObject::visitChildren):
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::arrayBufferPrototype const):
+(JSC::JSGlobalObject::arrayBufferStructure const):
+
 2017-11-06  Jason Marcell  
 
 Cherry-pick r224426. rdar://problem/35364681


Modified: branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp (226542 => 226543)

--- branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 22:41:07 UTC (rev 226542)
+++ branches/safari-604.4.7.0-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-08 22:41:33 UTC (rev 226543)
@@ -574,8 +574,10 @@
 
 m_arrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Default));
 m_arrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_arrayBufferPrototype.get()));
+#if ENABLE(SHARED_ARRAY_BUFFER)
 m_sharedArrayBufferPrototype.set(vm, this, JSArrayBufferPrototype::create(vm, this, JSArrayBufferPrototype::createStructure(vm, this, m_objectPrototype.get()), ArrayBufferSharingMode::Shared));
 m_sharedArrayBufferStructure.set(vm, this, JSArrayBuffer::createStructure(vm, this, m_sharedArrayBufferPrototype.get()));
+#endif
 
 m_iteratorPrototype.set(vm, this, IteratorPrototype::create(vm, this, IteratorPrototype::createStructure(vm, this, m_objectPrototype.get(;
 m_generatorPrototype.set(vm, this, GeneratorPrototype::create(vm, this, GeneratorPrototype::createStructure(vm, this, m_iteratorPrototype.get(;
@@ -620,10 +622,11 @@
 
 JSArrayBufferConstructor* arrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_arrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Default);
 m_arrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 JSArrayBufferConstructor* sharedArrayBufferConstructor = nullptr;
 sharedArrayBufferConstructor = JSArrayBufferConstructor::create(vm, JSArrayBufferConstructor::createStructure(vm, this, m_functionPrototype.get()), m_sharedArrayBufferPrototype.get(), m_speciesGetterSetter.get(), ArrayBufferSharingMode::Shared);
 m_sharedArrayBufferPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, sharedArrayBufferConstructor, DontEnum);
-
+#endif
 #define CREATE_CONSTRUCTOR_FOR_SIMPLE_TYPE(capitalName, lowerName, properName, instanceType, jsName, prototypeBase) \
 capitalName ## Constructor* lowerName ## Constructor = capitalName ## Constructor::create(vm, capitalName ## Constructor::createStructure(vm, this, m_functionPrototype.get()), m_ ## lowerName ## Prototype.get(), m_speciesGetterSetter.get()); \
 m_ ## lowerName ## Prototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, lowerName ## Constructor, DontEnum); \
@@ -686,7 +689,9 @@
 putDirectWithoutTransition(vm, vm.propertyNames->builtinNames().ArrayPrivateName(), arrayConstructor, DontEnum | DontDelete | ReadOnly);
 
 putDirectWithoutTransition(vm, vm.propertyNames->ArrayBuffer, arrayBufferConstructor, DontEnum);
+#if ENABLE(SHARED_ARRAY_BUFFER)
 putDirectWithoutTransition(vm, vm.propertyNames->SharedArrayBuffer,

[webkit-changes] [226540] trunk/Source

2018-01-08 Thread commit-queue

Title: [226540] trunk/Source








Revision 226540
Author commit-qu...@webkit.org
Date 2018-01-08 14:33:23 -0800 (Mon, 08 Jan 2018)


Log Message
SWClientConnection should not keep references to service worker jobs
https://bugs.webkit.org/show_bug.cgi?id=181381

Patch by Youenn Fablet  on 2018-01-08
Reviewed by Chris Dumez.

Source/WebCore:

Difficult to test determiniscally but corresponding crash log should no longer happen in debug builds.

Stopped passing ServiceWorkerJob references from ServiceWorkerContainer (potentially in service worker thread) to SWClientConnection (main thread).
Instead pass job identifiers and related data to the main thread.

Minor refactoring to use ServiceWorkerJobIdentifier instead of ServiceWorkerJobDataIdentifier which contains more data than needed.

* workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::postTaskForJob):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::clearPendingJobs):
(WebCore::SWClientConnection::finishedFetchingScript): Deleted.
* workers/service/SWClientConnection.h:
* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
* workers/service/ServiceWorkerContainer.h:
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::resolveUnregistrationJob):
(WebCore::SWServer::startScriptFetch):
* workers/service/server/SWServer.h:

Source/WebKit:

Updated IPC handling based on WebCore refactoring.

* Scripts/webkit/messages.py:
(forward_declarations_and_headers):
(headers_for_type):
* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::rejectJobInClient):
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
(WebKit::WebSWServerConnection::startScriptFetchInClient):
* StorageProcess/ServiceWorker/WebSWServerConnection.h:
* WebProcess/Storage/WebSWClientConnection.messages.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/SWClientConnection.h
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h
trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (226539 => 226540)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 22:19:15 UTC (rev 226539)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 22:33:23 UTC (rev 226540)
@@ -1,3 +1,41 @@
+2018-01-08  Youenn Fablet  
+
+SWClientConnection should not keep references to service worker jobs
+https://bugs.webkit.org/show_bug.cgi?id=181381
+
+Reviewed by Chris Dumez.
+
+Difficult to test determiniscally but corresponding crash log should no longer happen in debug builds.
+
+Stopped passing ServiceWorkerJob references from ServiceWorkerContainer (potentially in service worker thread) to SWClientConnection (main thread).
+Instead pass job identifiers and related data to the main thread.
+
+Minor refactoring to use ServiceWorkerJobIdentifier instead of ServiceWorkerJobDataIdentifier which contains more data than needed.
+
+* workers/service/SWClientConnection.cpp:
+(WebCore::SWClientConnection::scheduleJob):
+(WebCore::SWClientConnection::failedFetchingScript):
+(WebCore::SWClientConnection::postTaskForJob):
+(WebCore::SWClientConnection::jobRejectedInServer):
+(WebCore::SWClientConnection::registrationJobResolvedInServer):
+(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
+(WebCore::SWClientConnection::startScriptFetchForServer):
+(WebCore::SWClientConnection::clearPendingJobs):
+(WebCore::SWClientConnection::finishedFetchingScript): Deleted.
+* workers/service/SWClientConnection.h:
+* workers/service/ServiceWorkerContainer.cpp:
+(WebCore::ServiceWorkerContainer::scheduleJob):
+

[webkit-changes] [226539] trunk

2018-01-08 Thread wenson_hsieh

Title: [226539] trunk








Revision 226539
Author wenson_hs...@apple.com
Date 2018-01-08 14:19:15 -0800 (Mon, 08 Jan 2018)


Log Message
Copying, pasting, and then deleting an attachment element breaks attachment data requests
https://bugs.webkit.org/show_bug.cgi?id=181365


Reviewed by Tim Horton.

Source/WebCore:

Currently, copying and pasting an attachment element within the same document and then deleting backwards to
remove the pasted attachment element causes the original attachment element to be inaccessible via SPI. This is
because there are now two different attachment elements with the same unique identifier, such that Document,
which keeps a map of all unique attachment identifiers to attachment elements, will lose track of the original
attachment element.

To fix this, we ensure that attachment elements should always have unique identifiers when they are inserted
into the document. We make several small adjustments to accomplish this:

1.  First, refactor HTMLAttachmentElement's unique identifier so that it no longer depends on the value of the
"webkitattachmentid" attribute, and is instead just a member of HTMLAttachmentElement that is not exposed to
DOM bindings. This means setting and querying an attachment element's uniqueIdentifier can be done without
triggering any side effects, such as layout or mutation events.

2.  Next, make "webkitattachmentid" a temporary attribute similar to "webkitattachmentpath" and
"webkitattachmentbloburl", so that it is added only when generating a markup fragment for editing, and
removed upon deserialization.

3.  Lastly, shift the responsibility of assigning a unique identifier to an attachment away from places where we
create attachment elements, and instead have Document enforce this when an attachment element is inserted.

Tests:  WKAttachmentTests.InsertAndRemoveDuplicateAttachment
WKAttachmentTests.InsertDuplicateAttachmentAndUpdateData

* dom/Document.cpp:
(WebCore::Document::didInsertAttachmentElement):

Assign the unique identifier of an attachment element that has been inserted. If the identifier already tracks
an existing attachment element in the document or is missing, reassign the identifier to a new value.

* editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::WebContentReader::readFilePaths):

Remove calls to setUniqueIdentifier here, since Document will assign a unique identifier upon insertion.

* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendCustomAttributes):
(WebCore::createFragmentFromMarkup):

Set the attachment's unique identifier to the value of the "webkitattachmentid" attribute. When moving existing
attachments around in the DOM without duplication, this ensures that the attachment will be removed and
reinserted in the document without triggering removal and insertion client delegate methods.

When pasting an attachment element that has the same identifier as an existing attachment, we let Document
realize that the attachment identifier already exists, and reassign it to a unique value.

* html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::uniqueIdentifier const): Deleted.
(WebCore::HTMLAttachmentElement::setUniqueIdentifier): Deleted.
* html/HTMLAttachmentElement.h:

Tools:

Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
detail.

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/html/HTMLAttachmentElement.cpp
trunk/Source/WebCore/html/HTMLAttachmentElement.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (226538 => 226539)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 22:13:40 UTC (rev 226538)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 22:19:15 UTC (rev 226539)
@@ -1,3 +1,64 @@
+2018-01-08  Wenson Hsieh  
+
+Copying, pasting, and then deleting an attachment element breaks attachment data requests
+https://bugs.webkit.org/show_bug.cgi?id=181365
+
+
+Reviewed by Tim Horton.
+
+Currently, copying and pasting an attachment element within the same document and then deleting backwards to
+remove the pasted attachment element causes the original attachment element to be inaccessible via SPI. This is
+because there are now two different attachment elements with the same unique identifier, such that Document,
+which keeps a map of all unique attachment identifiers to attachment elements, will lose track of the

[webkit-changes] [226537] trunk/Source/WebCore

2018-01-08 Thread zalan

Title: [226537] trunk/Source/WebCore








Revision 226537
Author za...@apple.com
Date 2018-01-08 14:04:02 -0800 (Mon, 08 Jan 2018)


Log Message
[RenderTreeBuilder] Move RenderBlockFlow addChild logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181348


Reviewed by Antti Koivisto.

This is about moving the code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::addChild):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::RenderTreeBuilder):
(WebCore::RenderTreeBuilder::insertChildToRenderBlockFlow):
* rendering/updating/RenderTreeBuilder.h:
(WebCore::RenderTreeBuilder::blockFlowBuilder):
* rendering/updating/RenderTreeBuilderBlockFlow.cpp: Added.
(WebCore::RenderTreeBuilder::BlockFlow::BlockFlow):
(WebCore::RenderTreeBuilder::BlockFlow::insertChild):
* rendering/updating/RenderTreeBuilderBlockFlow.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp


Added Paths

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlockFlow.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlockFlow.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226536 => 226537)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 22:01:13 UTC (rev 226536)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 22:04:02 UTC (rev 226537)
@@ -1,3 +1,30 @@
+2018-01-08  Zalan Bujtas  
+
+[RenderTreeBuilder] Move RenderBlockFlow addChild logic to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=181348
+
+
+Reviewed by Antti Koivisto.
+
+This is about moving the code, no cleanup and/or normalization (unfortunately it also means
+some temporary changes).  
+
+No change in functionality.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::addChild):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::RenderTreeBuilder):
+(WebCore::RenderTreeBuilder::insertChildToRenderBlockFlow):
+* rendering/updating/RenderTreeBuilder.h:
+(WebCore::RenderTreeBuilder::blockFlowBuilder):
+* rendering/updating/RenderTreeBuilderBlockFlow.cpp: Added.
+(WebCore::RenderTreeBuilder::BlockFlow::BlockFlow):
+(WebCore::RenderTreeBuilder::BlockFlow::insertChild):
+* rendering/updating/RenderTreeBuilderBlockFlow.h: Added.
+
 2018-01-08  Youenn Fablet  
 
 Add CSP support to service workers


Modified: trunk/Source/WebCore/Sources.txt (226536 => 226537)

--- trunk/Source/WebCore/Sources.txt	2018-01-08 22:01:13 UTC (rev 226536)
+++ trunk/Source/WebCore/Sources.txt	2018-01-08 22:04:02 UTC (rev 226537)
@@ -1985,6 +1985,7 @@
 
 rendering/updating/RenderTreeBuilder.cpp
 rendering/updating/RenderTreeBuilderBlock.cpp
+rendering/updating/RenderTreeBuilderBlockFlow.cpp
 rendering/updating/RenderTreeBuilderFirstLetter.cpp
 rendering/updating/RenderTreeBuilderFormControls.cpp
 rendering/updating/RenderTreeBuilderInline.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (226536 => 226537)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-08 22:01:13 UTC (rev 226536)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-08 22:04:02 UTC (rev 226537)
@@ -5593,6 +5593,8 @@
 		119340A11FEE024000935F1E /* RenderTreeBuilderBlock.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderBlock.h; sourceTree = ""; };
 		11C5F1162003E7750001AE60 /* RenderTreeBuilderInline.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeBuilderInline.cpp; sourceTree = ""; };
 		11C5F1182003E7760001AE60 /* RenderTreeBuilderInline.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderInline.h; sourceTree = ""; };
+		11C5F11D2003F69E0001AE60 /* RenderTreeBuilderBlockFlow.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderBlockFlow.h; sourceTree = ""; };
+		11C5F11F2003F69F0001AE60 /* RenderTreeBuilderBlockFlow.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeBuilderBlockFlow.cpp; sourceTree = ""; };
 		11E067EB1E62461300162D16 /* SimpleLineLayoutCoverage.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path =

[webkit-changes] [226536] trunk/Source/WebKit

2018-01-08 Thread commit-queue

Title: [226536] trunk/Source/WebKit








Revision 226536
Author commit-qu...@webkit.org
Date 2018-01-08 14:01:13 -0800 (Mon, 08 Jan 2018)


Log Message
[Cocoa] Web Inspector: Provide a way for clients to check if an NSWindow is a Web Inspector window
https://bugs.webkit.org/show_bug.cgi?id=181361


Patch by Joseph Pecoraro  on 2018-01-08
Reviewed by Darin Adler.

* WebKit.xcodeproj/project.pbxproj:
New files.

* Shared/API/Cocoa/_WKNSWindowExtras.h: Added.
* Shared/API/Cocoa/_WKNSWindowExtras.mm: Added.
(-[NSWindow _web_isWebInspectorWindow]):
Method to determing if a window is being used for Web Inspector content.

* UIProcess/mac/WKInspectorWindow.h: Added.
* UIProcess/mac/WKInspectorWindow.mm: Added.
Named subclass so we can use isKindOfClass.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createFrontendWindow):
Use the named subclass.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.h
trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.mm
trunk/Source/WebKit/UIProcess/mac/WKInspectorWindow.h
trunk/Source/WebKit/UIProcess/mac/WKInspectorWindow.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (226535 => 226536)

--- trunk/Source/WebKit/ChangeLog	2018-01-08 21:54:24 UTC (rev 226535)
+++ trunk/Source/WebKit/ChangeLog	2018-01-08 22:01:13 UTC (rev 226536)
@@ -1,3 +1,27 @@
+2018-01-08  Joseph Pecoraro  
+
+[Cocoa] Web Inspector: Provide a way for clients to check if an NSWindow is a Web Inspector window
+https://bugs.webkit.org/show_bug.cgi?id=181361
+
+
+Reviewed by Darin Adler.
+
+* WebKit.xcodeproj/project.pbxproj:
+New files.
+
+* Shared/API/Cocoa/_WKNSWindowExtras.h: Added.
+* Shared/API/Cocoa/_WKNSWindowExtras.mm: Added.
+(-[NSWindow _web_isWebInspectorWindow]):
+Method to determing if a window is being used for Web Inspector content.
+
+* UIProcess/mac/WKInspectorWindow.h: Added.
+* UIProcess/mac/WKInspectorWindow.mm: Added.
+Named subclass so we can use isKindOfClass.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::createFrontendWindow):
+Use the named subclass.
+
 2018-01-08  Tim Horton  
 
 Build fix for WKPDFView


Added: trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.h (0 => 226536)

--- trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.h	(rev 0)
+++ trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.h	2018-01-08 22:01:13 UTC (rev 226536)
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2018 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import 
+
+#if WK_API_ENABLED
+
+#if !TARGET_OS_IPHONE
+
+@interface NSWindow (WKExtras)
+
+- (BOOL)_web_isWebInspectorWindow;
+
+@end
+
+#endif // !TARGET_OS_IPHONE
+
+#endif // WK_API_ENABLED


Added: trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.mm (0 => 226536)

--- trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.mm	(rev 0)
+++ trunk/Source/WebKit/Shared/API/Cocoa/_WKNSWindowExtras.mm	2018-01-08 22:01:13 UTC (rev 226536)
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2018 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following

[webkit-changes] [226535] trunk/JSTests

2018-01-08 Thread ryanhaddad

Title: [226535] trunk/JSTests








Revision 226535
Author ryanhad...@apple.com
Date 2018-01-08 13:54:24 -0800 (Mon, 08 Jan 2018)


Log Message
Disable SharedArrayBuffer tests missed in r226386.
https://bugs.webkit.org/show_bug.cgi?id=181266

Unreviewed test gardening.

* test262.yaml:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262.yaml




Diff

Modified: trunk/JSTests/ChangeLog (226534 => 226535)

--- trunk/JSTests/ChangeLog	2018-01-08 21:53:57 UTC (rev 226534)
+++ trunk/JSTests/ChangeLog	2018-01-08 21:54:24 UTC (rev 226535)
@@ -1,3 +1,12 @@
+2018-01-08  Ryan Haddad  
+
+Disable SharedArrayBuffer tests missed in r226386.
+https://bugs.webkit.org/show_bug.cgi?id=181266
+
+Unreviewed test gardening.
+
+* test262.yaml:
+
 2018-01-06  Yusuke Suzuki  
 
 Object.getOwnPropertyNames includes "arguments" and "caller" for bound functions


Modified: trunk/JSTests/test262.yaml (226534 => 226535)

--- trunk/JSTests/test262.yaml	2018-01-08 21:53:57 UTC (rev 226534)
+++ trunk/JSTests/test262.yaml	2018-01-08 21:54:24 UTC (rev 226535)
@@ -13026,7 +13026,7 @@
 - path: test262/test/built-ins/ArrayBuffer/prototype/slice/this-is-sharedarraybuffer.js
   cmd: runTest262 :skip, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
 - path: test262/test/built-ins/ArrayBuffer/prototype/slice/this-is-sharedarraybuffer.js
-  cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
+  cmd: runTest262 :skip, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/ArrayBuffer/prototype/slice/tointeger-conversion-end.js
   cmd: runTest262 :normal, "NoException", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []
 - path: test262/test/built-ins/ArrayBuffer/prototype/slice/tointeger-conversion-end.js
@@ -52382,31 +52382,31 @@
 - path: test262/test/built-ins/TypedArrays/buffer-arg-returns-new-instance-sab.js
   cmd: runTest262 :skip, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
 - path: test262/test/built-ins/TypedArrays/buffer-arg-returns-new-instance-sab.js
-  cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
+  cmd: runTest262 :skip, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
 - path: test262/test/built-ins/TypedArrays/buffer-arg-returns-new-instance.js
   cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
 - path: test262/test/built-ins/TypedArrays/buffer-arg-returns-new-instance.js
   cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
 - path: test262/test/built-ins/TypedArrays/buffer-arg-toindex-bytelength-sab.js
-  cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
+  cmd: runTest262 :skip, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
 - path: test262/test/built-ins/TypedArrays/buffer-arg-toindex-bytelength-sab.js
-  cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
+  cmd: runTest262 :skip, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
 - path: test262/test/built-ins/TypedArrays/buffer-arg-toindex-bytelength.js
   cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
 - path: test262/test/built-ins/TypedArrays/buffer-arg-toindex-bytelength.js
   cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
 - path: test262/test/built-ins/TypedArrays/buffer-arg-toindex-byteoffset-sab.js
-  cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
+  cmd: runTest262 :skip, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], []
 - path: test262/test/built-ins/TypedArrays/buffer-arg-toindex-byteoffset-sab.js
-  cmd: runTest262 :normal, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js", "../../../harness/testTypedArray.js"], [:strict]
+  cmd: runTest262 :skip, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js",

[webkit-changes] [226534] trunk/LayoutTests

2018-01-08 Thread jlewis3

Title: [226534] trunk/LayoutTests








Revision 226534
Author jlew...@apple.com
Date 2018-01-08 13:53:57 -0800 (Mon, 08 Jan 2018)


Log Message
Marked http/wpt/cache-storage/cache-put-stream.https.any.html as flaky on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=181107

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226533 => 226534)

--- trunk/LayoutTests/ChangeLog	2018-01-08 21:48:02 UTC (rev 226533)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 21:53:57 UTC (rev 226534)
@@ -1,3 +1,12 @@
+2018-01-08  Matt Lewis  
+
+Marked http/wpt/cache-storage/cache-put-stream.https.any.html as flaky on macOS WK2.
+https://bugs.webkit.org/show_bug.cgi?id=181107
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2018-01-08  Basuke Suzuki  
 
 [WinCairo] Add default port TestExpectations for wincairo


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (226533 => 226534)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-08 21:48:02 UTC (rev 226533)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-08 21:53:57 UTC (rev 226534)
@@ -859,3 +859,5 @@
 
 webkit.org/b/181069 fast/mediastream/MediaStream-MediaElement-setObject-null.html [ Pass Failure ]
 
+webkit.org/b/181107 http/wpt/cache-storage/cache-put-stream.https.any.html [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226533] trunk/Source/WebKit

2018-01-08 Thread timothy_horton

Title: [226533] trunk/Source/WebKit








Revision 226533
Author timothy_hor...@apple.com
Date 2018-01-08 13:48:02 -0800 (Mon, 08 Jan 2018)


Log Message
Build fix for WKPDFView
https://bugs.webkit.org/show_bug.cgi?id=181399


Reviewed by Simon Fraser.

* UIProcess/ios/WKPDFView.mm:
Disable deprecation warnings in this whole file.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (226532 => 226533)

--- trunk/Source/WebKit/ChangeLog	2018-01-08 21:19:24 UTC (rev 226532)
+++ trunk/Source/WebKit/ChangeLog	2018-01-08 21:48:02 UTC (rev 226533)
@@ -1,3 +1,14 @@
+2018-01-08  Tim Horton  
+
+Build fix for WKPDFView
+https://bugs.webkit.org/show_bug.cgi?id=181399
+
+
+Reviewed by Simon Fraser.
+
+* UIProcess/ios/WKPDFView.mm:
+Disable deprecation warnings in this whole file.
+
 2018-01-08  Youenn Fablet  
 
 Caches::writeCachesToDisk should assert that it is initialized


Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm (226532 => 226533)

--- trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm	2018-01-08 21:19:24 UTC (rev 226532)
+++ trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm	2018-01-08 21:48:02 UTC (rev 226533)
@@ -49,6 +49,11 @@
 #import 
 #import 
 
+// All of UIPDFPage* are deprecated, so just ignore deprecated declarations
+// in this file until we switch off them.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 using namespace WebCore;
 using namespace WebKit;
 
@@ -885,4 +890,6 @@
 
 @end
 
+#pragma clang diagnostic pop
+
 #endif /* PLATFORM(IOS) */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226532] trunk

2018-01-08 Thread commit-queue

Title: [226532] trunk








Revision 226532
Author commit-qu...@webkit.org
Date 2018-01-08 13:19:24 -0800 (Mon, 08 Jan 2018)


Log Message
Add CSP support to service workers
https://bugs.webkit.org/show_bug.cgi?id=181385

Patch by Youenn Fablet  on 2018-01-08
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt:
* web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt:
* web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Added recovery of CSP information from WorkerScriptLoader.
Added plumbing to pass the CSP information to Service Workers.
Added persistency support for the CSP information.

* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::WorkerScriptLoader::didReceiveResponse):
* workers/WorkerScriptLoader.h:
(WebCore::WorkerScriptLoader::contentSecurityPolicy const):
* workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
* workers/service/SWClientConnection.h:
* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerContextData.cpp:
(WebCore::ServiceWorkerContextData::isolatedCopy const):
* workers/service/ServiceWorkerContextData.h:
(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):
* workers/service/ServiceWorkerFetchResult.h:
(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):
* workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::create):
* workers/service/ServiceWorkerGlobalScope.h:
* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::notifyFinished):
* workers/service/ServiceWorkerJobClient.h:
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):
* workers/service/server/RegistrationDatabase.cpp:
(WebCore::v1RecordsTableSchema):
(WebCore::RegistrationDatabase::openSQLiteDatabase):
(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::updateWorker):
(WebCore::SWServer::installContextData):
* workers/service/server/SWServer.h:
* workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::scriptFetchFinished):
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::m_contentSecurityPolicy):
(WebCore::SWServerWorker::contextData const):
* workers/service/server/SWServerWorker.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.h
trunk/Source/WebCore/workers/service/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/SWClientConnection.h
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h
trunk/Source/WebCore/workers/service/ServiceWorkerContextData.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContextData.h
trunk/Source/WebCore/workers/service/ServiceWorkerFetchResult.h
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebCore/workers/service/server/RegistrationDatabase.cpp
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226531 => 226532)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-08 21:06:49 UTC (rev 226531)
+++

[webkit-changes] [226531] trunk

2018-01-08 Thread commit-queue

Title: [226531] trunk








Revision 226531
Author commit-qu...@webkit.org
Date 2018-01-08 13:06:49 -0800 (Mon, 08 Jan 2018)


Log Message
Use no-cache fetch mode when loading main documents with location.reload()
https://bugs.webkit.org/show_bug.cgi?id=181285

Patch by Youenn Fablet  on 2018-01-08
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Start to translate cache policy used for navigation as FetchOptions::Cache.
This allows ensuring service workers receive the right cache mode when intercepting navigation loads.
To not change current navigation behavior, ReturnCacheDataElseLoad and ReturnCacheDataDontLoad still trigger default fetch cache mode.

For Reload and ReloadExpiredOnly frame load types, using no-cache mode is more efficient than reload mode,
as a conditional request will be sent if possible. This applies to location.reload which is consistent with other browsers.
Keep reload mode for ReloadFromOrigin.

* loader/DocumentLoader.cpp:
(WebCore::toFetchOptionsCache):
(WebCore::DocumentLoader::loadMainResource):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::defaultRequestCachingPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
* loader/NavigationScheduler.cpp:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/NavigationScheduler.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226530 => 226531)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-08 21:05:17 UTC (rev 226530)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-08 21:06:49 UTC (rev 226531)
@@ -1,3 +1,12 @@
+2018-01-08  Youenn Fablet  
+
+Use no-cache fetch mode when loading main documents with location.reload()
+https://bugs.webkit.org/show_bug.cgi?id=181285
+
+Reviewed by Alex Christensen.
+
+* web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
+
 2018-01-08  Ms2ger  
 
 Update imagebitmap tests.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt (226530 => 226531)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt	2018-01-08 21:05:17 UTC (rev 226530)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt	2018-01-08 21:06:49 UTC (rev 226531)
@@ -1,5 +1,4 @@
 
-
 PASS Service Worker headers in the request of a fetch event 
 PASS Service Worker responds to fetch event with string 
 PASS Service Worker responds to fetch event with blob body 
@@ -12,7 +11,7 @@
 PASS Multiple calls of respondWith must throw InvalidStateErrors 
 PASS Service Worker event.respondWith must set the used flag 
 PASS Service Worker should expose FetchEvent URL fragments. 
-FAIL Service Worker responds to fetch event with the correct cache types assert_unreached: unexpected rejection: assert_equals: expected "no-cache" but got "default" Reached unreachable code
+PASS Service Worker responds to fetch event with the correct cache types 
 PASS Service Worker should intercept EventSource 
 PASS Service Worker responds to fetch event with the correct integrity_metadata 
 PASS FetchEvent#body is a string 


Modified: trunk/Source/WebCore/ChangeLog (226530 => 226531)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 21:05:17 UTC (rev 226530)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 21:06:49 UTC (rev 226531)
@@ -1,5 +1,34 @@
 2018-01-08  Youenn Fablet  
 
+Use no-cache fetch mode when loading main documents with location.reload()
+https://bugs.webkit.org/show_bug.cgi?id=181285
+
+Reviewed by Alex Christensen.
+
+Covered by rebased tests.
+
+Start to translate cache policy used for navigation as FetchOptions::Cache.
+This allows ensuring service workers receive the right cache mode when intercepting navigation loads.
+To not change current navigation behavior, ReturnCacheDataElseLoad and ReturnCacheDataDontLoad still trigger default fetch cache mode.
+
+For Reload and ReloadExpiredOnly frame load types, using no-cache mode is more efficient than reload mode,
+as a conditional request will be sent if possible. This applies to location.reload which is consistent with other browsers.
+Keep reload mode for ReloadFromOrigin.
+
+* loader/DocumentLoader.cpp:
+

[webkit-changes] [226529] trunk/Source/WebKitLegacy/mac

2018-01-08 Thread ddkilzer

Title: [226529] trunk/Source/WebKitLegacy/mac








Revision 226529
Author ddkil...@apple.com
Date 2018-01-08 13:02:06 -0800 (Mon, 08 Jan 2018)


Log Message
Fix check-webkit-style issues with WebNSDataExtras.mm


Reviewed by Alex Christensen.

* Misc/WebNSDataExtras.mm:
(-[NSString _web_capitalizeRFC822HeaderFieldName]):
(-[NSData _webkit_guessedMIMETypeForXML]):
(-[NSData _webkit_guessedMIMEType]):
(-[NSData _web_isCaseInsensitiveEqualToCString:]):
(_findEOL):
(-[NSData _webkit_parseRFC822HeaderFields]):
(-[NSData _web_locationAfterFirstBlankLine]):
- Fix all the check-webkit-style warnings.

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Misc/WebNSDataExtras.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (226528 => 226529)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-08 20:47:48 UTC (rev 226528)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-08 21:02:06 UTC (rev 226529)
@@ -1,5 +1,22 @@
 2018-01-08  David Kilzer  
 
+Fix check-webkit-style issues with WebNSDataExtras.mm
+
+
+Reviewed by Alex Christensen.
+
+* Misc/WebNSDataExtras.mm:
+(-[NSString _web_capitalizeRFC822HeaderFieldName]):
+(-[NSData _webkit_guessedMIMETypeForXML]):
+(-[NSData _webkit_guessedMIMEType]):
+(-[NSData _web_isCaseInsensitiveEqualToCString:]):
+(_findEOL):
+(-[NSData _webkit_parseRFC822HeaderFields]):
+(-[NSData _web_locationAfterFirstBlankLine]):
+- Fix all the check-webkit-style warnings.
+
+2018-01-08  David Kilzer  
+
 Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
 
 


Modified: trunk/Source/WebKitLegacy/mac/Misc/WebNSDataExtras.mm (226528 => 226529)

--- trunk/Source/WebKitLegacy/mac/Misc/WebNSDataExtras.mm	2018-01-08 20:47:48 UTC (rev 226528)
+++ trunk/Source/WebKitLegacy/mac/Misc/WebNSDataExtras.mm	2018-01-08 21:02:06 UTC (rev 226529)
@@ -34,12 +34,11 @@
 
 @implementation NSString (WebNSDataExtrasInternal)
 
--(NSString *)_web_capitalizeRFC822HeaderFieldName
+- (NSString *)_web_capitalizeRFC822HeaderFieldName
 {
 CFStringRef name = (CFStringRef)self;
 NSString *result = nil;
 
-CFIndex i; 
 CFIndex len = CFStringGetLength(name);
 char* charPtr = nullptr;
 UniChar* uniCharPtr = nullptr;
@@ -46,15 +45,14 @@
 Boolean useUniCharPtr = FALSE;
 Boolean shouldCapitalize = TRUE;
 Boolean somethingChanged = FALSE;
-
-for (i = 0; i < len; i ++) {
+
+for (CFIndex i = 0; i < len; i ++) {
 UniChar ch = CFStringGetCharacterAtIndex(name, i);
 Boolean replace = FALSE;
 if (shouldCapitalize && ch >= 'a' && ch <= 'z') {
 ch = ch + 'A' - 'a';
 replace = TRUE;
-} 
-else if (!shouldCapitalize && ch >= 'A' && ch <= 'Z') {
+} else if (!shouldCapitalize && ch >= 'A' && ch <= 'Z') {
 ch = ch + 'a' - 'A';
 replace = TRUE;
 }
@@ -66,39 +64,30 @@
 useUniCharPtr = FALSE;
 charPtr = static_cast(CFAllocatorAllocate(kCFAllocatorDefault, len + 1, 0));
 CFStringGetCString(name, charPtr, len+1, kCFStringEncodingISOLatin1);
-} 
-else {
+} else {
 useUniCharPtr = TRUE;
 uniCharPtr = static_cast(CFAllocatorAllocate(kCFAllocatorDefault, len * sizeof(UniChar), 0));
 CFStringGetCharacters(name, CFRangeMake(0, len), uniCharPtr);
 }
 }
-if (useUniCharPtr) {
+if (useUniCharPtr)
 uniCharPtr[i] = ch;
-} 
-else {
+else
 charPtr[i] = ch;
-}
 }
-if (ch == '-') {
+if (ch == '-')
 shouldCapitalize = TRUE;
-} 
-else {
+else
 shouldCapitalize = FALSE;
-}
 }
 if (somethingChanged) {
-if (useUniCharPtr) {
+if (useUniCharPtr)
 result = (NSString *)CFStringCreateWithCharactersNoCopy(NULL, uniCharPtr, len, NULL);
-} 
-else {
+else
 result = (NSString *)CFStringCreateWithCStringNoCopy(NULL, charPtr, kCFStringEncodingISOLatin1, NULL);
-}
-} 
-else {
+} else
 result = [self retain];
-}
-
+
 return [result autorelease];
 }
 
@@ -106,25 +95,24 @@
 
 @implementation NSData (WebKitExtras)
 
--(NSString *)_webkit_guessedMIMETypeForXML
+- (NSString *)_webkit_guessedMIMETypeForXML
 {
 NSUInteger length = [self length];
 const UInt8* bytes = static_cast([self bytes]);
-
+
 #define CHANNEL_TAG_LENGTH 7
-
+
 const char* p = reinterpret_cast(bytes);
 int remaining = std::min(length, WEB_GUESS_MIME_TYPE_PEEK_LENGTH) - (CHANNEL_TAG_LENGTH - 1);
-
+

[webkit-changes] [226527] trunk/LayoutTests

2018-01-08 Thread commit-queue

Title: [226527] trunk/LayoutTests








Revision 226527
Author commit-qu...@webkit.org
Date 2018-01-08 12:45:45 -0800 (Mon, 08 Jan 2018)


Log Message
[WinCairo] Add default port TestExpectations for wincairo
https://bugs.webkit.org/show_bug.cgi?id=179221

Patch by Basuke Suzuki  on 2018-01-08
Reviewed by Alex Christensen.

* platform/wincairo-win10/TestExpectations: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/wincairo-win10/
trunk/LayoutTests/platform/wincairo-win10/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226526 => 226527)

--- trunk/LayoutTests/ChangeLog	2018-01-08 18:58:32 UTC (rev 226526)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 20:45:45 UTC (rev 226527)
@@ -1,3 +1,12 @@
+2018-01-08  Basuke Suzuki  
+
+[WinCairo] Add default port TestExpectations for wincairo
+https://bugs.webkit.org/show_bug.cgi?id=179221
+
+Reviewed by Alex Christensen.
+
+* platform/wincairo-win10/TestExpectations: Added.
+
 2018-01-08  Youenn Fablet  
 
 Stop exposing fetch and extendable events to window


Added: trunk/LayoutTests/platform/wincairo-win10/TestExpectations (0 => 226527)

--- trunk/LayoutTests/platform/wincairo-win10/TestExpectations	(rev 0)
+++ trunk/LayoutTests/platform/wincairo-win10/TestExpectations	2018-01-08 20:45:45 UTC (rev 226527)
@@ -0,0 +1,243 @@
+# These are the layout test expectations for WinCairo on Windows 10.
+#
+# See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
+
+#//
+# Platform-specific directories. Skipped here, then re-enabled on the appropriate platform.
+#//
+
+#//
+# End platform-specific directories.
+#//
+
+#//
+# These areas are not implemented well on WinCairo
+#//
+
+accessibility [ Skip ]
+animations [ Skip ]
+canvas/philip [ Skip ]
+contentfiltering [ Skip ]
+credentials [ Skip ]
+crypto [ Skip ]
+css1 [ Skip ]
+css2.1 [ Skip ]
+css3 [ Skip ]
+editing [ Skip ]
+fullscreen [ Skip ]
+gamepad [ Skip ]
+imported [ Skip ]
+inspector [ Skip ]
+jquery [ Skip ]
+mathml [ Skip ]
+media [ Skip ]
+plugins [ Skip ]
+pointer-lock [ Skip ]
+security [ Skip ]
+storage/indexeddb [ Skip ]
+svg [ Skip ]
+tables/mozilla [ Skip ]
+wasm [ Skip ]
+webgl [ Skip ]
+webrtc [ Skip ]
+webaudio [ Skip ]
+webarchive [ Skip ]
+workers [ Skip ]
+
+fast/animation [ Skip ]
+fast/attachment [ Skip ]
+fast/block [ Skip ]
+fast/borders [ Skip ]
+fast/canvas/webgl [ Skip ]
+fast/css [ Skip ]
+fast/css3-text [ Skip ]
+fast/css-generated-content [ Skip ]
+fast/css-intrinsic-dimensions [ Skip ]
+fast/css-grid-layout [ Skip ]
+fast/dom/DeviceMotion [ Skip ]
+fast/dom/DeviceOrientation [ Skip ]
+fast/dom/Geolocation/ [ Skip ]
+fast/dom/HTMLLinkElement [ Skip ]
+fast/dynamic [ Skip ]
+fast/events/touch  [ Skip ]
+fast/files [ Skip ]
+fast/forms/file [ Skip ]
+fast/mediastream [ Skip ]
+fast/speechsynthesis [ Skip ]
+
+#//
+# Following tests are labeled "Skip" because not working well and causes crash or timeout
+#//
+
+fast/canvas/canvas-bg-multiple-removal.html [ Skip ]
+fast/canvas/canvas-createPattern-video-loading.html [ Skip ]
+fast/canvas/canvas-createPattern-video-modify.html [ Skip ]
+fast/canvas/webgpu/webgpu-dispatch.html [ Skip ]
+fast/dom/FileList-iterator-using-open-panel.html [ Skip ]
+fast/dom/MutationObserver/end-of-task-delivery.html [ Skip ]
+fast/dom/MutationObserver/inline-event-listener.html [ Skip ]
+fast/dom/Range/detach-range-during-deletecontents.html [ Skip ]
+fast/dom/SelectorAPI/bug-17313.html [ Skip ]
+fast/dom/Window/a-rel-noopener.html [ Skip ]
+fast/dom/Window/child-window-focus.html [ Skip ]
+fast/dom/Window/get-set-properties.html [ Skip ]
+fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Skip ]
+fast/dom/Window/window-resize-contents.html [ Skip ]
+fast/dom/Window/window-resize-update-scrollbars.html [ Skip ]
+fast/dom/css-cached-import-rule.html [ Skip ]
+fast/dom/empty-hash-and-search.html [ Skip ]
+fast/dom/frame-loading-via-document-write.html [ Skip ]
+fast/dom/navigator-cookieEnabled-no-crash.html [ Skip ]
+fast/dom/rtl-scroll-to-leftmost-and-resize.html [ Skip ]
+fast/encoding/backslash-encoding-jp.html [ Skip ]

[webkit-changes] [226526] trunk

2018-01-08 Thread commit-queue

Title: [226526] trunk








Revision 226526
Author commit-qu...@webkit.org
Date 2018-01-08 10:58:32 -0800 (Mon, 08 Jan 2018)


Log Message
Stop exposing fetch and extendable events to window
https://bugs.webkit.org/show_bug.cgi?id=181325

Patch by Youenn Fablet  on 2018-01-08
Reviewed by Chris Dumez.

Source/WebCore:

Covered by updated tests.

Marked FetchEvent and ExtendableEvent as visible in ServiceWorker environments only.
Moved related Internals testing routines to ServiceWorkerInternals.

* testing/Internals.cpp:
(WebCore::Internals::waitForFetchEventToFinish): Deleted.
(WebCore::Internals::createBeingDispatchedFetchEvent): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
* testing/ServiceWorkerInternals.cpp:
(WebCore::ServiceWorkerInternals::waitForFetchEventToFinish):
(WebCore::ServiceWorkerInternals::createBeingDispatchedFetchEvent):
* testing/ServiceWorkerInternals.h:
* testing/ServiceWorkerInternals.idl:
* workers/service/ExtendableEvent.idl:
* workers/service/FetchEvent.idl:

LayoutTests:

* http/wpt/service-workers/extendableEvent.https-expected.txt:
* http/wpt/service-workers/extendableEvent.https.html:
* http/wpt/service-workers/fetchEvent.https-expected.txt:
* http/wpt/service-workers/fetchEvent.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/service-workers/extendableEvent.https-expected.txt
trunk/LayoutTests/http/wpt/service-workers/extendableEvent.https.html
trunk/LayoutTests/http/wpt/service-workers/fetchEvent.https-expected.txt
trunk/LayoutTests/http/wpt/service-workers/fetchEvent.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/ServiceWorkerInternals.cpp
trunk/Source/WebCore/testing/ServiceWorkerInternals.h
trunk/Source/WebCore/testing/ServiceWorkerInternals.idl
trunk/Source/WebCore/workers/service/ExtendableEvent.idl
trunk/Source/WebCore/workers/service/FetchEvent.idl


Added Paths

trunk/LayoutTests/http/wpt/service-workers/extendableEvent-worker.js
trunk/LayoutTests/http/wpt/service-workers/fetchEvent-worker.js




Diff

Modified: trunk/LayoutTests/ChangeLog (226525 => 226526)

--- trunk/LayoutTests/ChangeLog	2018-01-08 18:55:10 UTC (rev 226525)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 18:58:32 UTC (rev 226526)
@@ -1,3 +1,15 @@
+2018-01-08  Youenn Fablet  
+
+Stop exposing fetch and extendable events to window
+https://bugs.webkit.org/show_bug.cgi?id=181325
+
+Reviewed by Chris Dumez.
+
+* http/wpt/service-workers/extendableEvent.https-expected.txt:
+* http/wpt/service-workers/extendableEvent.https.html:
+* http/wpt/service-workers/fetchEvent.https-expected.txt:
+* http/wpt/service-workers/fetchEvent.https.html:
+
 2018-01-08  Antti Koivisto  
 
 REGRESSION (r219145): Toggling layer borders on a static document no longer works immediately


Added: trunk/LayoutTests/http/wpt/service-workers/extendableEvent-worker.js (0 => 226526)

--- trunk/LayoutTests/http/wpt/service-workers/extendableEvent-worker.js	(rev 0)
+++ trunk/LayoutTests/http/wpt/service-workers/extendableEvent-worker.js	2018-01-08 18:58:32 UTC (rev 226526)
@@ -0,0 +1,42 @@
+function testWaitUntilNonPromiseParameters()
+{
+var event = new ExtendableEvent('ExtendableEvent', {});
+try {
+event.waitUntil(new Request(''));
+return 'Should throw';
+} catch (e) {
+return e.name === 'InvalidStateError' ? 'PASS' : 'Got exception ' + e;
+}
+}
+
+function testExtendableEvent()
+{
+if (new ExtendableEvent('ExtendableEvent').type !== 'ExtendableEvent')
+return 'Type of ExtendableEvent should be ExtendableEvent';
+if (new ExtendableEvent('ExtendableEvent', {}).type !== 'ExtendableEvent')
+return 'Type of ExtendableEvent should be ExtendableEvent';
+if (new ExtendableEvent('ExtendableEvent', {}).cancelable !== false)
+return 'Default ExtendableEvent.cancelable should be false';
+if (new ExtendableEvent('ExtendableEvent', {}).bubbles !== false)
+return 'Default ExtendableEvent.bubbles should be false';
+if (new ExtendableEvent('ExtendableEvent', {cancelable: false}).cancelable !== false)
+return 'ExtendableEvent.cancelable should be false';
+return "PASS";
+}
+
+async function doTest(event)
+{
+try {
+var result = event.data + " is an unknown test";
+if (event.data ="" "waitUntil-non-promise-parameters")
+result = testWaitUntilNonPromiseParameters();
+else if (event.data ="" "extendable-event")
+result = testExtendableEvent();
+
+event.source.postMessage(result);
+} catch (e) {
+event.source.postMessage("Exception: " + e.message);
+}
+}
+
+self.addEventListener("message", doTest);


Modified:

[webkit-changes] [226524] tags/Safari-605.1.19.1/Source

2018-01-08 Thread jmarcell

Title: [226524] tags/Safari-605.1.19.1/Source








Revision 226524
Author jmarc...@apple.com
Date 2018-01-08 10:55:07 -0800 (Mon, 08 Jan 2018)


Log Message
Cherry-pick r226461. rdar://problem/36085949

Modified Paths

tags/Safari-605.1.19.1/Source/_javascript_Core/ChangeLog
tags/Safari-605.1.19.1/Source/_javascript_Core/b3/B3LowerToAir.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/b3/B3Validate.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.h
tags/Safari-605.1.19.1/Source/_javascript_Core/b3/air/AirCustom.h
tags/Safari-605.1.19.1/Source/_javascript_Core/b3/testb3.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
tags/Safari-605.1.19.1/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/jit/JITPropertyAccess.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/runtime/Butterfly.h
tags/Safari-605.1.19.1/Source/_javascript_Core/runtime/JSArrayBufferView.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/WasmBinding.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/WasmMemory.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/WasmMemory.h
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/WasmMemoryInformation.cpp
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/WasmMemoryInformation.h
tags/Safari-605.1.19.1/Source/_javascript_Core/wasm/js/JSToWasm.cpp
tags/Safari-605.1.19.1/Source/WTF/ChangeLog
tags/Safari-605.1.19.1/Source/WTF/wtf/MathExtras.h




Diff

Modified: tags/Safari-605.1.19.1/Source/_javascript_Core/ChangeLog (226523 => 226524)

--- tags/Safari-605.1.19.1/Source/_javascript_Core/ChangeLog	2018-01-08 18:55:00 UTC (rev 226523)
+++ tags/Safari-605.1.19.1/Source/_javascript_Core/ChangeLog	2018-01-08 18:55:07 UTC (rev 226524)
@@ -1,5 +1,78 @@
 2018-01-08  Jason Marcell  
 
+Cherry-pick r226461. rdar://problem/36085949
+
+2018-01-04  Keith Miller  
+
+TypedArrays and Wasm should use index masking.
+https://bugs.webkit.org/show_bug.cgi?id=181313
+
+Reviewed by Michael Saboff.
+
+We should have index masking for our TypedArray code in the
+DFG/FTL and for Wasm when doing bounds checking. Index masking for
+Wasm is added to the WasmBoundsCheckValue. Since we don't CSE any
+WasmBoundsCheckValues we don't need to worry about combining a
+bounds check for a load and a store. I went with fusing the
+pointer masking in the WasmBoundsCheckValue since it should reduce
+additional compiler overhead.
+
+* b3/B3LowerToAir.cpp:
+* b3/B3Validate.cpp:
+* b3/B3WasmBoundsCheckValue.cpp:
+(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
+(JSC::B3::WasmBoundsCheckValue::dumpMeta const):
+* b3/B3WasmBoundsCheckValue.h:
+(JSC::B3::WasmBoundsCheckValue::pinnedIndexingMask const):
+* b3/air/AirCustom.h:
+(JSC::B3::Air::WasmBoundsCheckCustom::generate):
+* b3/testb3.cpp:
+(JSC::B3::testWasmBoundsCheck):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
+(JSC::DFG::SpeculativeJIT::loadFromIntTypedArray):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
+(JSC::DFG::SpeculativeJIT::compileNewTypedArrayWithSize):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
+(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
+(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
+(JSC::FTL::DFG::LowerDFGToB3::pointerIntoTypedArray):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emitIntTypedArrayGetByVal):
+* runtime/Butterfly.h:
+(JSC::Butterfly::computeIndexingMask const):
+(JSC::Butterfly::computeIndexingMaskForVectorLength): Deleted.
+* runtime/JSArrayBufferView.cpp:
+(JSC::JSArrayBufferView::JSArrayBufferView):
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::B3IRGenerator):
+(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
+(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
+

[webkit-changes] [226525] tags/Safari-605.1.19.1

2018-01-08 Thread jmarcell

Title: [226525] tags/Safari-605.1.19.1








Revision 226525
Author jmarc...@apple.com
Date 2018-01-08 10:55:10 -0800 (Mon, 08 Jan 2018)


Log Message
Cherry-pick r226495. rdar://problem/36085943

Modified Paths

tags/Safari-605.1.19.1/LayoutTests/ChangeLog
tags/Safari-605.1.19.1/LayoutTests/TestExpectations
tags/Safari-605.1.19.1/Source/WebCore/ChangeLog
tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp




Diff

Modified: tags/Safari-605.1.19.1/LayoutTests/ChangeLog (226524 => 226525)

--- tags/Safari-605.1.19.1/LayoutTests/ChangeLog	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/LayoutTests/ChangeLog	2018-01-08 18:55:10 UTC (rev 226525)
@@ -1,5 +1,22 @@
 2018-01-08  Jason Marcell  
 
+Cherry-pick r226495. rdar://problem/36085943
+
+2018-01-07  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
+due to a test bug. The test fix is tracked in https://github.com/w3c/web-platform-tests/pull/8711
+
+* TestExpectations:
+
+2018-01-08  Jason Marcell  
+
 Cherry-pick r226386. rdar://problem/36077849
 
 2018-01-03  Michael Saboff  


Modified: tags/Safari-605.1.19.1/LayoutTests/TestExpectations (226524 => 226525)

--- tags/Safari-605.1.19.1/LayoutTests/TestExpectations	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/LayoutTests/TestExpectations	2018-01-08 18:55:10 UTC (rev 226525)
@@ -1669,3 +1669,6 @@
 webkit.org/b/158205 applicationmanifest/ [ Skip ]
 
 webkit.org/b/178785 perf/object-keys.html [ Pass Failure ]
+
+# There is a bug in the test
+imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ]


Modified: tags/Safari-605.1.19.1/Source/WebCore/ChangeLog (226524 => 226525)

--- tags/Safari-605.1.19.1/Source/WebCore/ChangeLog	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/Source/WebCore/ChangeLog	2018-01-08 18:55:10 UTC (rev 226525)
@@ -1,5 +1,26 @@
 2018-01-08  Jason Marcell  
 
+Cherry-pick r226495. rdar://problem/36085943
+
+2018-01-07  Ryosuke Niwa  
+
+Reduce the precision of "high" resolution time to 1ms
+https://bugs.webkit.org/show_bug.cgi?id=180910
+
+
+Reviewed by Saam Barati.
+
+Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().
+
+Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.
+
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+(WebCore::fillRTCStats):
+* page/Performance.cpp:
+(WebCore::Performance::reduceTimeResolution):
+
+2018-01-08  Jason Marcell  
+
 Cherry-pick r226371. rdar://problem/36146670
 
 2018-01-03  Joseph Pecoraro  


Modified: tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (226524 => 226525)

--- tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2018-01-08 18:55:10 UTC (rev 226525)
@@ -35,6 +35,7 @@
 #include "Logging.h"
 #include "MediaStreamEvent.h"
 #include "NotImplemented.h"
+#include "Performance.h"
 #include "PlatformStrategies.h"
 #include "RTCDataChannel.h"
 #include "RTCDataChannelEvent.h"
@@ -50,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -310,7 +312,7 @@
 
 static inline void fillRTCStats(RTCStatsReport::Stats& stats, const webrtc::RTCStats& rtcStats)
 {
-stats.timestamp = rtcStats.timestamp_us() / 1000.0;
+stats.timestamp = Performance::reduceTimeResolution(Seconds::fromMicroseconds(rtcStats.timestamp_us())).milliseconds();
 stats.id = fromStdString(rtcStats.id());
 }
 


Modified: tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp (226524 => 226525)

--- tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp	2018-01-08 18:55:07 UTC (rev 226524)
+++ tags/Safari-605.1.19.1/Source/WebCore/page/Performance.cpp	2018-01-08 18:55:10 UTC (rev 226525)
@@ -75,7 +75,7 @@
 
 Seconds Performance::reduceTimeResolution(Seconds seconds)
 {
-double resolution = (100_us).seconds();
+double resolution = (1000_us).seconds();
 double reduced = std::floor(seconds.seconds() / resolution) * resolution;
 return Seconds(reduced);
 }






___
webkit-changes

[webkit-changes] [226522] tags/Safari-605.1.19.1

2018-01-08 Thread jmarcell

Title: [226522] tags/Safari-605.1.19.1








Revision 226522
Author jmarc...@apple.com
Date 2018-01-08 10:54:53 -0800 (Mon, 08 Jan 2018)


Log Message
Cherry-pick r226371. rdar://problem/36146670

Modified Paths

tags/Safari-605.1.19.1/LayoutTests/ChangeLog
tags/Safari-605.1.19.1/LayoutTests/inspector/css/get-system-fonts.html
tags/Safari-605.1.19.1/Source/WebCore/ChangeLog
tags/Safari-605.1.19.1/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp




Diff

Modified: tags/Safari-605.1.19.1/LayoutTests/ChangeLog (226521 => 226522)

--- tags/Safari-605.1.19.1/LayoutTests/ChangeLog	2018-01-08 18:47:26 UTC (rev 226521)
+++ tags/Safari-605.1.19.1/LayoutTests/ChangeLog	2018-01-08 18:54:53 UTC (rev 226522)
@@ -1,3 +1,18 @@
+2018-01-08  Jason Marcell  
+
+Cherry-pick r226371. rdar://problem/36146670
+
+2018-01-03  Joseph Pecoraro  
+
+Web Inspector: Slow open time enumerating system fonts (FontCache::systemFontFamilies)
+https://bugs.webkit.org/show_bug.cgi?id=180979
+
+
+Reviewed by Matt Baker.
+
+* inspector/css/get-system-fonts.html:
+Cleanup the test a bit.
+
 2018-01-07  Jason Marcell  
 
 Cherry-pick r226359. rdar://problem/36146670


Modified: tags/Safari-605.1.19.1/LayoutTests/inspector/css/get-system-fonts.html (226521 => 226522)

--- tags/Safari-605.1.19.1/LayoutTests/inspector/css/get-system-fonts.html	2018-01-08 18:47:26 UTC (rev 226521)
+++ tags/Safari-605.1.19.1/LayoutTests/inspector/css/get-system-fonts.html	2018-01-08 18:54:53 UTC (rev 226522)
@@ -28,7 +28,6 @@
 
 
 
-  This test ensures that the inspector can enumerate system font families, and checks for the
- existence of common fonts.
+This test ensures that the inspector can enumerate system font families, and checks for the existence of common fonts.
 
 


Modified: tags/Safari-605.1.19.1/Source/WebCore/ChangeLog (226521 => 226522)

--- tags/Safari-605.1.19.1/Source/WebCore/ChangeLog	2018-01-08 18:47:26 UTC (rev 226521)
+++ tags/Safari-605.1.19.1/Source/WebCore/ChangeLog	2018-01-08 18:54:53 UTC (rev 226522)
@@ -1,3 +1,24 @@
+2018-01-08  Jason Marcell  
+
+Cherry-pick r226371. rdar://problem/36146670
+
+2018-01-03  Joseph Pecoraro  
+
+Web Inspector: Slow open time enumerating system fonts (FontCache::systemFontFamilies)
+https://bugs.webkit.org/show_bug.cgi?id=180979
+
+
+Reviewed by Matt Baker.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(fontNameIsSystemFont):
+(WebCore::FontCache::systemFontFamilies):
+Switch to the original Mac algorithm before r180979 that uses
+CTFontManagerCopyAvailableFontFamilyNames. Previously this wasn't
+available on iOS but now it is. This is a performance improvement on
+both platforms, but significantly so on macOS. It also finds more,
+valid, family names.
+
 2018-01-07  Jason Marcell  
 
 Cherry-pick r226359. rdar://problem/36146670


Modified: tags/Safari-605.1.19.1/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (226521 => 226522)

--- tags/Safari-605.1.19.1/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2018-01-08 18:47:26 UTC (rev 226521)
+++ tags/Safari-605.1.19.1/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2018-01-08 18:54:53 UTC (rev 226522)
@@ -367,6 +367,11 @@
 return result;
 }
 
+static inline bool fontNameIsSystemFont(CFStringRef fontName)
+{
+return CFStringGetLength(fontName) > 0 && CFStringGetCharacterAtIndex(fontName, 0) == '.';
+}
+
 #if ENABLE(VARIATION_FONTS)
 struct VariationDefaults {
 float defaultValue;
@@ -417,8 +422,9 @@
 {
 if (CTFontDescriptorIsSystemUIFont(adoptCF(CTFontCopyFontDescriptor(font)).get()))
 return true;
+
 auto name = adoptCF(CTFontCopyPostScriptName(font));
-return CFStringGetLength(name.get()) > 0 && CFStringGetCharacterAtIndex(name.get(), 0) == '.';
+return fontNameIsSystemFont(name.get());
 }
 
 // These values were calculated by performing a linear regression on the CSS weights/widths/slopes and Core Text weights/widths/slopes of San Francisco.
@@ -731,25 +737,24 @@
 
 Vector FontCache::systemFontFamilies()
 {
-// FIXME: 
-auto attributes = adoptCF(CFDictionaryCreate(kCFAllocatorDefault, nullptr, nullptr, 0, , ));
-auto emptyFontDescriptor = adoptCF(CTFontDescriptorCreateWithAttributes(attributes.get()));
-auto matchedDescriptors = adoptCF(CTFontDescriptorCreateMatchingFontDescriptors(emptyFontDescriptor.get(), nullptr));
-if (!matchedDescriptors)
-return { };
+Vector fontFamilies;
 
-CFIndex numMatches = CFArrayGetCount(matchedDescriptors.get());
-if (!numMatches)
-return { };
+auto availableFontFamilies =

[webkit-changes] [226521] trunk

2018-01-08 Thread antti

Title: [226521] trunk








Revision 226521
Author an...@apple.com
Date 2018-01-08 10:47:26 -0800 (Mon, 08 Jan 2018)


Log Message
REGRESSION (r219145): Toggling layer borders on a static document no longer works immediately
https://bugs.webkit.org/show_bug.cgi?id=176260


Reviewed by Simon Fraser.

Source/WebCore:

Optimization reveled bugs in debug indicator painting.

Test: compositing/debug-borders-dynamic.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateDebugIndicators):
(WebCore::GraphicsLayerCA::updateDebugBorder): Deleted.

- Rename to indicate this is not just about debug borders.
- Trigger display so repaint counters get painted. This helper is only called when the indicators change.

* platform/graphics/ca/GraphicsLayerCA.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):

Ensure we do compositing update on debug border change even when there is no layout.

LayoutTests:

* compositing/debug-borders-dynamic-expected.html: Added.
* compositing/debug-borders-dynamic.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

trunk/LayoutTests/compositing/debug-borders-dynamic-expected.html
trunk/LayoutTests/compositing/debug-borders-dynamic.html




Diff

Modified: trunk/LayoutTests/ChangeLog (226520 => 226521)

--- trunk/LayoutTests/ChangeLog	2018-01-08 18:38:31 UTC (rev 226520)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 18:47:26 UTC (rev 226521)
@@ -1,3 +1,14 @@
+2018-01-08  Antti Koivisto  
+
+REGRESSION (r219145): Toggling layer borders on a static document no longer works immediately
+https://bugs.webkit.org/show_bug.cgi?id=176260
+
+
+Reviewed by Simon Fraser.
+
+* compositing/debug-borders-dynamic-expected.html: Added.
+* compositing/debug-borders-dynamic.html: Added.
+
 2018-01-08  Yacine Bandou  
 
 [EME] Add layout test for InitData and InitDataType in CENC encrypted event


Added: trunk/LayoutTests/compositing/debug-borders-dynamic-expected.html (0 => 226521)

--- trunk/LayoutTests/compositing/debug-borders-dynamic-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/debug-borders-dynamic-expected.html	2018-01-08 18:47:26 UTC (rev 226521)
@@ -0,0 +1,7 @@
+
+if (window.internals) {
+internals.settings.setShowRepaintCounter(true);
+internals.settings.setShowDebugBorders(true);
+}
+
+


Added: trunk/LayoutTests/compositing/debug-borders-dynamic.html (0 => 226521)

--- trunk/LayoutTests/compositing/debug-borders-dynamic.html	(rev 0)
+++ trunk/LayoutTests/compositing/debug-borders-dynamic.html	2018-01-08 18:47:26 UTC (rev 226521)
@@ -0,0 +1,8 @@
+
+
+document.body.offsetLeft;
+if (window.internals) {
+internals.settings.setShowRepaintCounter(true);
+internals.settings.setShowDebugBorders(true);
+}
+


Modified: trunk/Source/WebCore/ChangeLog (226520 => 226521)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 18:38:31 UTC (rev 226520)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 18:47:26 UTC (rev 226521)
@@ -1,3 +1,29 @@
+2018-01-08  Antti Koivisto  
+
+REGRESSION (r219145): Toggling layer borders on a static document no longer works immediately
+https://bugs.webkit.org/show_bug.cgi?id=176260
+
+
+Reviewed by Simon Fraser.
+
+Optimization reveled bugs in debug indicator painting.
+
+Test: compositing/debug-borders-dynamic.html
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
+(WebCore::GraphicsLayerCA::updateDebugIndicators):
+(WebCore::GraphicsLayerCA::updateDebugBorder): Deleted.
+
+- Rename to indicate this is not just about debug borders.
+- Trigger display so repaint counters get painted. This helper is only called when the indicators change.
+
+* platform/graphics/ca/GraphicsLayerCA.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
+
+Ensure we do compositing update on debug border change even when there is no layout.
+
 2018-01-08  Zalan Bujtas 
 
 [RenderTreeBuilder] Move RenderInline addChild logic to RenderTreeBuilder


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (226520 => 226521)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2018-01-08 18:38:31 UTC (rev 226520)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2018-01-08 18:47:26 UTC (rev 226521)
@@ -1793,7 +1793,7 @@

[webkit-changes] [226520] trunk/Source/WebCore

2018-01-08 Thread zalan

Title: [226520] trunk/Source/WebCore








Revision 226520
Author za...@apple.com
Date 2018-01-08 10:38:31 -0800 (Mon, 08 Jan 2018)


Log Message
[RenderTreeBuilder] Move RenderInline addChild logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181336


Reviewed by Antti Koivisto.

This is about moving the code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChild):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::childBecameNonInline):
(WebCore::nextContinuation): Deleted.
(WebCore::RenderInline::continuationBefore): Deleted.
(WebCore::newChildIsInline): Deleted.
(WebCore::RenderInline::cloneAsContinuation const): Deleted.
(WebCore::RenderInline::splitInlines): Deleted.
(WebCore::RenderInline::splitFlow): Deleted.
(WebCore::canUseAsParentForContinuation): Deleted.
(WebCore::RenderInline::addChildToContinuation): Deleted.
* rendering/RenderInline.h:
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::RenderTreeBuilder):
(WebCore::RenderTreeBuilder::insertChildToRenderInline):
(WebCore::RenderTreeBuilder::insertChildToRenderInlineIgnoringContinuation):
(WebCore::RenderTreeBuilder::splitFlow):
* rendering/updating/RenderTreeBuilder.h:
(WebCore::RenderTreeBuilder::inlineBuilder):
* rendering/updating/RenderTreeBuilderInline.cpp: Added.
(WebCore::canUseAsParentForContinuation):
(WebCore::nextContinuation):
(WebCore::continuationBefore):
(WebCore::cloneAsContinuation):
(WebCore::newChildIsInline):
(WebCore::inFlowPositionedInlineAncestor):
(WebCore::RenderTreeBuilder::Inline::Inline):
(WebCore::RenderTreeBuilder::Inline::insertChild):
(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
(WebCore::RenderTreeBuilder::Inline::insertChildIgnoringContinuation):
(WebCore::RenderTreeBuilder::Inline::splitFlow):
(WebCore::RenderTreeBuilder::Inline::splitInlines):
* rendering/updating/RenderTreeBuilderInline.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderTable.h


Added Paths

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderInline.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226519 => 226520)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 18:37:37 UTC (rev 226519)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 18:38:31 UTC (rev 226520)
@@ -1,3 +1,53 @@
+2018-01-08  Zalan Bujtas 
+
+[RenderTreeBuilder] Move RenderInline addChild logic to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=181336
+
+
+Reviewed by Antti Koivisto.
+
+This is about moving the code, no cleanup and/or normalization (unfortunately it also means
+some temporary changes).  
+
+No change in functionality.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::addChild):
+(WebCore::RenderInline::addChildIgnoringContinuation):
+(WebCore::RenderInline::childBecameNonInline):
+(WebCore::nextContinuation): Deleted.
+(WebCore::RenderInline::continuationBefore): Deleted.
+(WebCore::newChildIsInline): Deleted.
+(WebCore::RenderInline::cloneAsContinuation const): Deleted.
+(WebCore::RenderInline::splitInlines): Deleted.
+(WebCore::RenderInline::splitFlow): Deleted.
+(WebCore::canUseAsParentForContinuation): Deleted.
+(WebCore::RenderInline::addChildToContinuation): Deleted.
+* rendering/RenderInline.h:
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::RenderTreeBuilder):
+(WebCore::RenderTreeBuilder::insertChildToRenderInline):
+(WebCore::RenderTreeBuilder::insertChildToRenderInlineIgnoringContinuation):
+(WebCore::RenderTreeBuilder::splitFlow):
+* rendering/updating/RenderTreeBuilder.h:
+(WebCore::RenderTreeBuilder::inlineBuilder):
+* rendering/updating/RenderTreeBuilderInline.cpp: Added.
+(WebCore::canUseAsParentForContinuation):
+(WebCore::nextContinuation):
+(WebCore::continuationBefore):
+(WebCore::cloneAsContinuation):
+(WebCore::newChildIsInline):
+(WebCore::inFlowPositionedInlineAncestor):
+(WebCore::RenderTreeBuilder::Inline::Inline):
+(WebCore::RenderTreeBuilder::Inline::insertChild):
+

[webkit-changes] [226519] trunk/Source/WebKit

2018-01-08 Thread commit-queue

Title: [226519] trunk/Source/WebKit








Revision 226519
Author commit-qu...@webkit.org
Date 2018-01-08 10:37:37 -0800 (Mon, 08 Jan 2018)


Log Message
WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds
https://bugs.webkit.org/show_bug.cgi?id=181384

Patch by Youenn Fablet  on 2018-01-08
Reviewed by Chris Dumez.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::terminateServiceWorkerProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (226518 => 226519)

--- trunk/Source/WebKit/ChangeLog	2018-01-08 18:33:24 UTC (rev 226518)
+++ trunk/Source/WebKit/ChangeLog	2018-01-08 18:37:37 UTC (rev 226519)
@@ -1,3 +1,13 @@
+2018-01-08  Youenn Fablet  
+
+WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds
+https://bugs.webkit.org/show_bug.cgi?id=181384
+
+Reviewed by Chris Dumez.
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::terminateServiceWorkerProcess):
+
 2018-01-08  Frederic Wang  
 
 Unreviewed build fix after r226211.


Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (226518 => 226519)

--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2018-01-08 18:33:24 UTC (rev 226518)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2018-01-08 18:37:37 UTC (rev 226519)
@@ -1458,6 +1458,9 @@
 if (!m_serviceWorkerProcess)
 return;
 
+#ifndef NDEBUG
+auto protectedThis = makeRef(*this);
+#endif
 m_serviceWorkerProcess->requestTermination(ProcessTerminationReason::RequestedByClient);
 ASSERT(!m_processes.contains(m_serviceWorkerProcess));
 ASSERT(!m_serviceWorkerProcess);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226517] trunk/Source/WebInspectorUI

2018-01-08 Thread commit-queue

Title: [226517] trunk/Source/WebInspectorUI








Revision 226517
Author commit-qu...@webkit.org
Date 2018-01-08 09:42:17 -0800 (Mon, 08 Jan 2018)


Log Message
Web Inspector: Find next / previous within a resource content view does not have bouncy highlight when editor scrolls
https://bugs.webkit.org/show_bug.cgi?id=181279


Patch by Joseph Pecoraro  on 2018-01-08
Reviewed by Brian Burg.

* UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype._revealSearchResult):
Reposition the bouncy highlight on scroll based on the CodeMirror
line/ch position of the search result.

(WI.TextEditor.prototype._removeBouncyHighlightElementIfNeeded):
Track the bouncy highlight scroll handler in a member variable so that
we always remember to remove it and don't leak scroll handlers.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (226516 => 226517)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-01-08 17:40:21 UTC (rev 226516)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-01-08 17:42:17 UTC (rev 226517)
@@ -1,3 +1,20 @@
+2018-01-08  Joseph Pecoraro  
+
+Web Inspector: Find next / previous within a resource content view does not have bouncy highlight when editor scrolls
+https://bugs.webkit.org/show_bug.cgi?id=181279
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/TextEditor.js:
+(WI.TextEditor.prototype._revealSearchResult):
+Reposition the bouncy highlight on scroll based on the CodeMirror
+line/ch position of the search result.
+
+(WI.TextEditor.prototype._removeBouncyHighlightElementIfNeeded):
+Track the bouncy highlight scroll handler in a member variable so that
+we always remember to remove it and don't leak scroll handlers.
+
 2018-01-07  David Kilzer  
 
 Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (226516 => 226517)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js	2018-01-08 17:40:21 UTC (rev 226516)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js	2018-01-08 17:42:17 UTC (rev 226517)
@@ -1055,7 +1055,7 @@
 
 _revealSearchResult(result, changeFocus, directionInCaseOfRevalidation)
 {
-var position = result.find();
+let position = result.find();
 
 // Check for a valid position, it might have been removed from editing by the user.
 // If the position is invalide, revalidate all positions reveal as needed.
@@ -1078,50 +1078,55 @@
 if (changeFocus)
 this._codeMirror.focus();
 
+// Collect info for the bouncy highlight.
+let highlightEditorPosition = this._codeMirror.getCursor("start");
+let textContent = this._codeMirror.getSelection();
+
 // Remove the bouncy highlight if it is still around. The animation will not
 // start unless we remove it and add it back to the document.
-if (this._bouncyHighlightElement)
-this._bouncyHighlightElement.remove();
+this._removeBouncyHighlightElementIfNeeded();
 
 // Create the bouncy highlight.
 this._bouncyHighlightElement = document.createElement("div");
 this._bouncyHighlightElement.className = WI.TextEditor.BouncyHighlightStyleClassName;
+this._bouncyHighlightElement.textContent = textContent;
 
-// Collect info for the bouncy highlight.
-var textContent = this._codeMirror.getSelection();
-var coordinates = this._codeMirror.cursorCoords(true, "page");
+function positionBouncyHighlight() {
+// Adjust the coordinates to be based in the text editor's space.
+let coordinates = this._codeMirror.cursorCoords(highlightEditorPosition, "page");
+let textEditorRect = this.element.getBoundingClientRect();
+coordinates.top -= textEditorRect.top;
+coordinates.left -= textEditorRect.left;
 
-// Adjust the coordinates to be based in the text editor's space.
-let textEditorRect = this.element.getBoundingClientRect();
-coordinates.top -= textEditorRect.top;
-coordinates.left -= textEditorRect.left;
+// Position the bouncy highlight.
+this._bouncyHighlightElement.style.top = coordinates.top + "px";
+this._bouncyHighlightElement.style.left = coordinates.left + "px";
+}
 
-// Position and show the bouncy highlight.
-this._bouncyHighlightElement.textContent = textContent;
-this._bouncyHighlightElement.style.top = coordinates.top + "px";
-this._bouncyHighlightElement.style.left = coordinates.left + "px";
+// Position and show the highlight.
+positionBouncyHighlight.call(this);

[webkit-changes] [226516] trunk/Source/WebCore

2018-01-08 Thread zalan

Title: [226516] trunk/Source/WebCore








Revision 226516
Author za...@apple.com
Date 2018-01-08 09:40:21 -0800 (Mon, 08 Jan 2018)


Log Message
[RenderTreeBuilder] Move RenderBlock addChild logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181319


Reviewed by Antti Koivisto.

This is about moving the code, no cleanup and/or normalization (unfortunately it also means
some temporary changes).

No change in functionality.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::childBecameNonInline):
(WebCore::RenderBlock::continuationBefore): Deleted.
(WebCore::RenderBlock::addChildToContinuation): Deleted.
(WebCore::getInlineRun): Deleted.
(WebCore::RenderBlock::makeChildrenNonInline): Deleted.
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::markBoxForRelayoutAfterSplit): Deleted.
(WebCore::RenderBox::splitAnonymousBoxesAroundChild): Deleted.
* rendering/RenderBox.h:
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::markBoxForRelayoutAfterSplit):
(WebCore::getInlineRun):
(WebCore::RenderTreeBuilder::RenderTreeBuilder):
(WebCore::RenderTreeBuilder::insertChildToRenderBlock):
(WebCore::RenderTreeBuilder::insertChildToRenderBlockIgnoringContinuation):
(WebCore::RenderTreeBuilder::makeChildrenNonInline):
(WebCore::RenderTreeBuilder::splitAnonymousBoxesAroundChild):
* rendering/updating/RenderTreeBuilder.h:
(WebCore::RenderTreeBuilder::blockBuilder):
* rendering/updating/RenderTreeBuilderBlock.cpp: Added.
(WebCore::continuationBefore):
(WebCore::RenderTreeBuilder::Block::Block):
(WebCore::RenderTreeBuilder::Block::insertChild):
(WebCore::RenderTreeBuilder::Block::insertChildToContinuation):
(WebCore::RenderTreeBuilder::Block::insertChildIgnoringContinuation):
* rendering/updating/RenderTreeBuilderBlock.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderRubyBase.cpp
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableRow.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h


Added Paths

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlock.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226515 => 226516)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 17:02:33 UTC (rev 226515)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 17:40:21 UTC (rev 226516)
@@ -1,3 +1,58 @@
+2018-01-08  Zalan Bujtas  
+
+[RenderTreeBuilder] Move RenderBlock addChild logic to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=181319
+
+
+Reviewed by Antti Koivisto.
+
+This is about moving the code, no cleanup and/or normalization (unfortunately it also means
+some temporary changes).  
+
+No change in functionality.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::addChild):
+(WebCore::RenderBlock::addChildIgnoringContinuation):
+(WebCore::RenderBlock::childBecameNonInline):
+(WebCore::RenderBlock::continuationBefore): Deleted.
+(WebCore::RenderBlock::addChildToContinuation): Deleted.
+(WebCore::getInlineRun): Deleted.
+(WebCore::RenderBlock::makeChildrenNonInline): Deleted.
+* rendering/RenderBlock.h:
+* rendering/RenderBox.cpp:
+(WebCore::markBoxForRelayoutAfterSplit): Deleted.
+(WebCore::RenderBox::splitAnonymousBoxesAroundChild): Deleted.
+* rendering/RenderBox.h:
+* rendering/RenderRubyBase.cpp:
+(WebCore::RenderRubyBase::moveChildren):
+(WebCore::RenderRubyBase::moveBlockChildren):
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::addChild):
+* rendering/RenderTableRow.cpp:
+(WebCore::RenderTableRow::addChild):
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::addChild):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::markBoxForRelayoutAfterSplit):
+(WebCore::getInlineRun):
+

[webkit-changes] [226515] trunk/Source/WebCore

2018-01-08 Thread commit-queue

Title: [226515] trunk/Source/WebCore








Revision 226515
Author commit-qu...@webkit.org
Date 2018-01-08 09:02:33 -0800 (Mon, 08 Jan 2018)


Log Message
Standard controls sometimes say video is in pip when it isnt.
https://bugs.webkit.org/show_bug.cgi?id=181095
rdar://problem/36182687

Patch by Jeremy Jones  on 2018-01-08
Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::exitFullscreen):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226514 => 226515)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 16:46:15 UTC (rev 226514)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 17:02:33 UTC (rev 226515)
@@ -1,3 +1,14 @@
+2018-01-08  Jeremy Jones  
+
+Standard controls sometimes say video is in pip when it isnt.
+https://bugs.webkit.org/show_bug.cgi?id=181095
+rdar://problem/36182687
+
+Reviewed by Eric Carlson.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::exitFullscreen):
+
 2018-01-08  Jer Noble  
 
 REGRESSION: [iOS] ASSERTION FAILED: !node.isConnected() in WebCore::notifyNodeInsertedIntoDocument


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (226514 => 226515)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-08 16:46:15 UTC (rev 226514)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-08 17:02:33 UTC (rev 226515)
@@ -5896,6 +5896,7 @@
 else
 document().page()->chrome().client().exitVideoFullscreenForVideoElement(downcast(*this));
 scheduleEvent(eventNames().webkitendfullscreenEvent);
+scheduleEvent(eventNames().webkitpresentationmodechangedEvent);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226514] trunk/Source/WebCore

2018-01-08 Thread jer . noble

Title: [226514] trunk/Source/WebCore








Revision 226514
Author jer.no...@apple.com
Date 2018-01-08 08:46:15 -0800 (Mon, 08 Jan 2018)


Log Message
REGRESSION: [iOS] ASSERTION FAILED: !node.isConnected() in WebCore::notifyNodeInsertedIntoDocument
https://bugs.webkit.org/show_bug.cgi?id=181091

Reviewed by Darin Adler.

Move the work previously performed in insertedIntoAncestor() into didFinishInsertingNode().

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226513 => 226514)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 16:14:02 UTC (rev 226513)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 16:46:15 UTC (rev 226514)
@@ -1,3 +1,15 @@
+2018-01-08  Jer Noble  
+
+REGRESSION: [iOS] ASSERTION FAILED: !node.isConnected() in WebCore::notifyNodeInsertedIntoDocument
+https://bugs.webkit.org/show_bug.cgi?id=181091
+
+Reviewed by Darin Adler.
+
+Move the work previously performed in insertedIntoAncestor() into didFinishInsertingNode().
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::prepareForLoad):
+
 2018-01-08  Zan Dobersek  
 
 [Cairo] Use isolated fill and stroke source containers


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (226513 => 226514)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-08 16:14:02 UTC (rev 226513)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-08 16:46:15 UTC (rev 226514)
@@ -909,13 +909,17 @@
 INFO_LOG(LOGIDENTIFIER);
 
 HTMLElement::insertedIntoAncestor(insertionType, parentOfInsertedTree);
-if (insertionType.connectedToDocument) {
+if (insertionType.connectedToDocument)
 m_inActiveDocument = true;
 
-if (m_networkState == NETWORK_EMPTY && !attributeWithoutSynchronization(srcAttr).isEmpty())
-prepareForLoad();
-}
+return InsertedIntoAncestorResult::NeedsPostInsertionCallback;
+}
 
+void HTMLMediaElement::didFinishInsertingNode()
+{
+if (m_inActiveDocument && m_networkState == NETWORK_EMPTY && !attributeWithoutSynchronization(srcAttr).isEmpty())
+prepareForLoad();
+
 if (!m_explicitlyMuted) {
 m_explicitlyMuted = true;
 m_muted = hasAttributeWithoutSynchronization(mutedAttr);
@@ -922,11 +926,6 @@
 m_mediaSession->canProduceAudioChanged();
 }
 
-return InsertedIntoAncestorResult::NeedsPostInsertionCallback;
-}
-
-void HTMLMediaElement::didFinishInsertingNode()
-{
 configureMediaControls();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226513] trunk/Source/WebKit

2018-01-08 Thread fred . wang

Title: [226513] trunk/Source/WebKit








Revision 226513
Author fred.w...@free.fr
Date 2018-01-08 08:14:02 -0800 (Mon, 08 Jan 2018)


Log Message
Unreviewed build fix after r226211.

Patch by Frederic Wang  on 2018-01-08

* UIProcess/API/Cocoa/WKPreferencesPrivate.h: Use WK_IOS_TBA for iOS.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (226512 => 226513)

--- trunk/Source/WebKit/ChangeLog	2018-01-08 15:55:14 UTC (rev 226512)
+++ trunk/Source/WebKit/ChangeLog	2018-01-08 16:14:02 UTC (rev 226513)
@@ -1,3 +1,9 @@
+2018-01-08  Frederic Wang  
+
+Unreviewed build fix after r226211.
+
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h: Use WK_IOS_TBA for iOS.
+
 2018-01-08  Youenn Fablet  
 
 navigator.onLine does not work inside service workers


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (226512 => 226513)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h	2018-01-08 15:55:14 UTC (rev 226512)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h	2018-01-08 16:14:02 UTC (rev 226513)
@@ -112,7 +112,7 @@
 
 @property (nonatomic, setter=_setPeerConnectionEnabled:) BOOL _peerConnectionEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 @property (nonatomic, setter=_setMediaDevicesEnabled:) BOOL _mediaDevicesEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0));
-@property (nonatomic, setter=_setScreenCaptureEnabled:) BOOL _screenCaptureEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_MAC_TBA));
+@property (nonatomic, setter=_setScreenCaptureEnabled:) BOOL _screenCaptureEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 @property (nonatomic, setter=_setMockCaptureDevicesEnabled:) BOOL _mockCaptureDevicesEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0));
 @property (nonatomic, setter=_setMockCaptureDevicesPromptEnabled:) BOOL _mockCaptureDevicesPromptEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 @property (nonatomic, setter=_setMediaCaptureRequiresSecureConnection:) BOOL _mediaCaptureRequiresSecureConnection WK_API_AVAILABLE(macosx(10.13), ios(11.0));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226512] trunk/LayoutTests

2018-01-08 Thread Ms2ger

Title: [226512] trunk/LayoutTests








Revision 226512
Author ms2...@igalia.com
Date 2018-01-08 07:55:14 -0800 (Mon, 08 Jan 2018)


Log Message
Update imagebitmap tests.
https://bugs.webkit.org/show_bug.cgi?id=181379

Unreviewed test gardening.


LayoutTests/imported/w3c:

* web-platform-tests/2dcontext/imagebitmap/common.js:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html:

LayoutTests:

* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/common.js
trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html
trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (226511 => 226512)

--- trunk/LayoutTests/ChangeLog	2018-01-08 15:00:38 UTC (rev 226511)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 15:55:14 UTC (rev 226512)
@@ -1,3 +1,15 @@
+2018-01-08  Ms2ger  
+
+Update imagebitmap tests.
+https://bugs.webkit.org/show_bug.cgi?id=181379
+
+Unreviewed test gardening.
+
+* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
+* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
+* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
+* platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
+
 2018-01-08  Youenn Fablet  
 
 navigator.onLine does not work inside service workers


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226511 => 226512)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-08 15:00:38 UTC (rev 226511)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-01-08 15:55:14 UTC (rev 226512)
@@ -1,3 +1,16 @@
+2018-01-08  Ms2ger  
+
+Update imagebitmap tests.
+https://bugs.webkit.org/show_bug.cgi?id=181379
+
+Unreviewed test gardening.
+
+* web-platform-tests/2dcontext/imagebitmap/common.js:
+* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
+* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html:
+* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
+* web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html:
+
 2018-01-07  Ms2ger  
 
 Implement createImageBitmap(ImageBitmap)


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/common.js (226511 => 226512)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/common.js	2018-01-08 15:00:38 UTC (rev 226511)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/common.js	2018-01-08 15:55:14 UTC (rev 226512)
@@ -1,58 +1,107 @@
-function testCanvasDisplayingPattern(canvas)
-{
-var tolerance = 5; // for creating ImageBitmap from a video, the tolerance needs to be high
-_assertPixelApprox(canvas, 5,5, 255,0,0,255, "5,5", "255,0,0,255", tolerance);
-_assertPixelApprox(canvas, 15,5, 0,255,0,255, "15,5", "0,255,0,255", tolerance);
-_assertPixelApprox(canvas, 5,15, 0,0,255,255, "5,15", "0,0,255,255", tolerance);
-

[webkit-changes] [226511] trunk/Source/WebCore

2018-01-08 Thread zandobersek

Title: [226511] trunk/Source/WebCore








Revision 226511
Author zandober...@gmail.com
Date 2018-01-08 07:00:38 -0800 (Mon, 08 Jan 2018)


Log Message
[Cairo] Use isolated fill and stroke source containers
https://bugs.webkit.org/show_bug.cgi?id=181386

Reviewed by Carlos Garcia Campos.

Generate fill and stroke source objects upon invocation of various Cairo
operations, initializing necessary data from the GraphicsContextState
object.

Cairo::FillSource and Cairo::StrokeSource structs are introduced, both
being default-constructible as well as providing a constructor that
accepts a GraphicsContextState object from which the appropriate
resources are created.

The FillSource and StrokeSource objects are then passed to
PlatformContextCairo's prepareForFilling() and prepareForStroking()
methods. Here the helper prepareCairoContextSource() function is now
invoked with cairo_pattern_t objects as pattern or gradient sources, or
the source color if neither cairo_pattern_t object is specified.

The FillSource and StrokeSource constructors mimic the previous behavior
of prepareCairoContextSource(). In case the source is a Pattern object,
a cairo_pattern_t object is created from that. In case of FillSource,
we also retrieve pattern size, transform and repetition information. In
case the source os a Gradient object, we create a 'base' cairo_pattern_t
object for a completely opaque alpha channel. Additionally, if the alpha
value on the state is not 1, we create an alpha-adjusted cairo_pattern_t
that is potentially used for any filling or stroking operation that has
to preserve transparency. If neither Pattern or Gradient objects are set
on the GraphicsContextState, we default to the current fill or stroke
color.

Overall, there's no change in behavior, this is simply a refactoring
that enables us to construct Cairo objects for filling and stroking
sources at the time of Cairo operation dispatch, instead of pulling down
GraphicsContextState deeper into the Cairo-specific code.

No new tests -- no change in functionality.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawPathShadow):
(WebCore::Cairo::fillCurrentCairoPath):
(WebCore::Cairo::FillSource::FillSource):
(WebCore::Cairo::StrokeSource::StrokeSource):
(WebCore::Cairo::fillRect):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::fillPath):
(WebCore::Cairo::strokeRect):
(WebCore::Cairo::strokePath):
(WebCore::Cairo::drawGlyphs):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::FontCascade::drawGlyphs):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::prepareCairoContextSource):
(WebCore::PlatformContextCairo::prepareForFilling):
(WebCore::PlatformContextCairo::prepareForStroking):
(WebCore::PlatformContextCairo::clipForPatternFilling):
* platform/graphics/cairo/PlatformContextCairo.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp
trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h
trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226510 => 226511)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 14:43:50 UTC (rev 226510)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 15:00:38 UTC (rev 226511)
@@ -1,3 +1,71 @@
+2018-01-08  Zan Dobersek  
+
+[Cairo] Use isolated fill and stroke source containers
+https://bugs.webkit.org/show_bug.cgi?id=181386
+
+Reviewed by Carlos Garcia Campos.
+
+Generate fill and stroke source objects upon invocation of various Cairo
+operations, initializing necessary data from the GraphicsContextState
+object.
+
+Cairo::FillSource and Cairo::StrokeSource structs are introduced, both
+being default-constructible as well as providing a constructor that
+accepts a GraphicsContextState object from which the appropriate
+resources are created.
+
+The FillSource and StrokeSource objects are then passed to
+PlatformContextCairo's prepareForFilling() and prepareForStroking()
+methods. Here the helper prepareCairoContextSource() function is now
+invoked with cairo_pattern_t objects as pattern or gradient sources, or
+the source color if neither cairo_pattern_t object is specified.
+
+The FillSource and StrokeSource constructors mimic the previous behavior
+of prepareCairoContextSource(). In case the source is a

[webkit-changes] [226510] trunk

2018-01-08 Thread commit-queue

Title: [226510] trunk








Revision 226510
Author commit-qu...@webkit.org
Date 2018-01-08 06:43:50 -0800 (Mon, 08 Jan 2018)


Log Message
navigator.onLine does not work inside service workers
https://bugs.webkit.org/show_bug.cgi?id=181079


Patch by Youenn Fablet  on 2018-01-08
Reviewed by Darin Adler.

Source/WebCore:

Test: http/wpt/service-workers/online.https.html

Added support for onLine by reusing a similar implementation as regular workers.
Added ServiceWorkerInternals as an interface for an object exposed as self.internals in WTR.
This object has currently one method to trigger change in the online/offline status.
This allows writing a test for the onLine feature.

Note that self.internals is inserted asynchronously after the script was evaluated.
When writing a worker script using self.internals, one must make sure to use self.internals when initialized.
online-worker.js for instance makes use of self.internals in a postMessage callback.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WorkerScriptController.h:
* dom/ScriptExecutionContext.h:
* testing/ServiceWorkerInternals.cpp: Added.
(WebCore::ServiceWorkerInternals::ServiceWorkerInternals):
(WebCore::ServiceWorkerInternals::setOnline):
* testing/ServiceWorkerInternals.h: Added.
* testing/ServiceWorkerInternals.idl: Added.
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setupNewlyCreateServiceWorker):
* testing/js/WebCoreTestSupport.h:
* workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::registerServiceWorkerThreadForInstall):
(WebCore::SWContextManager::startedServiceWorker):
* workers/service/context/SWContextManager.h:
(WebCore::SWContextManager::setServiceWorkerCreationCallback):
(WebCore::SWContextManager::workerByID):
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::~ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::networkStateChanged):
(WebCore::ServiceWorkerThreadProxy::notifyNetworkStateChange):
* workers/service/context/ServiceWorkerThreadProxy.h:

Source/WebKit:

Added support for a callback called for each service worker proxy creation.
Callback is used by WTR to inject a self.internals object used for testing.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetServiceWorkerProxyCreationCallback):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setServiceWorkerProxyCreationCallback):
* WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.

LayoutTests:

* http/wpt/service-workers/online-worker.js: Added.
(async.waitForOnlineEvent):
(async.doTest):
* http/wpt/service-workers/online.https-expected.txt: Added.
* http/wpt/service-workers/online.https.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WorkerScriptController.h
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Source/WebCore/workers/service/context/SWContextManager.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.h
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp


Added Paths

trunk/LayoutTests/http/wpt/service-workers/online-worker.js
trunk/LayoutTests/http/wpt/service-workers/online.https-expected.txt
trunk/LayoutTests/http/wpt/service-workers/online.https.html
trunk/Source/WebCore/testing/ServiceWorkerInternals.cpp
trunk/Source/WebCore/testing/ServiceWorkerInternals.h
trunk/Source/WebCore/testing/ServiceWorkerInternals.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (226509 => 226510)

--- trunk/LayoutTests/ChangeLog	2018-01-08 14:38:23 UTC (rev 226509)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 14:43:50 UTC (rev 226510)
@@ -1,5 +1,19 @@
 2018-01-08  Youenn Fablet  
 
+navigator.onLine does not work inside service workers

[webkit-changes] [226508] trunk/Source/WebCore

2018-01-08 Thread philn

Title: [226508] trunk/Source/WebCore








Revision 226508
Author ph...@webkit.org
Date 2018-01-08 05:53:10 -0800 (Mon, 08 Jan 2018)


Log Message
[GStreamer][Soup] Remove dead getCreateOrReadBuffer code path
https://bugs.webkit.org/show_bug.cgi?id=181376

Reviewed by Carlos Garcia Campos.

This code path is no longer used now that the GStreamer HTTP
source element uses data coming directly from the network process.

* SourcesGTK.txt:
* SourcesWPE.txt:
* loader/MediaResourceLoader.cpp:
(WebCore::MediaResource::getOrCreateReadBuffer): Deleted.
* loader/MediaResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/cache/CachedRawResource.h:
* loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::finishedTimingForWorkerLoad):
(WebCore::CachedRawResourceClient::getOrCreateReadBuffer): Deleted.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::getOrCreateReadBuffer): Deleted.
* loader/soup/CachedRawResourceSoup.cpp: Removed.
* loader/soup/SubresourceLoaderSoup.cpp: Removed.
* platform/graphics/PlatformMediaResourceLoader.h:
(WebCore::PlatformMediaResourceClient::loadFinished):
(WebCore::PlatformMediaResourceClient::getOrCreateReadBuffer): Deleted.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::getOrCreateReadBuffer): Deleted.
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::getOrCreateReadBuffer): Deleted.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::ensureReadBuffer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesGTK.txt
trunk/Source/WebCore/SourcesWPE.txt
trunk/Source/WebCore/loader/MediaResourceLoader.cpp
trunk/Source/WebCore/loader/MediaResourceLoader.h
trunk/Source/WebCore/loader/SubresourceLoader.h
trunk/Source/WebCore/loader/cache/CachedRawResource.h
trunk/Source/WebCore/loader/cache/CachedRawResourceClient.h
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h
trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
trunk/Source/WebCore/platform/network/ResourceHandleClient.h
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp


Removed Paths

trunk/Source/WebCore/loader/soup/CachedRawResourceSoup.cpp
trunk/Source/WebCore/loader/soup/SubresourceLoaderSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226507 => 226508)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 12:32:49 UTC (rev 226507)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 13:53:10 UTC (rev 226508)
@@ -1,3 +1,37 @@
+2018-01-08  Philippe Normand  
+
+[GStreamer][Soup] Remove dead getCreateOrReadBuffer code path
+https://bugs.webkit.org/show_bug.cgi?id=181376
+
+Reviewed by Carlos Garcia Campos.
+
+This code path is no longer used now that the GStreamer HTTP
+source element uses data coming directly from the network process.
+
+* SourcesGTK.txt:
+* SourcesWPE.txt:
+* loader/MediaResourceLoader.cpp:
+(WebCore::MediaResource::getOrCreateReadBuffer): Deleted.
+* loader/MediaResourceLoader.h:
+* loader/SubresourceLoader.h:
+* loader/cache/CachedRawResource.h:
+* loader/cache/CachedRawResourceClient.h:
+(WebCore::CachedRawResourceClient::finishedTimingForWorkerLoad):
+(WebCore::CachedRawResourceClient::getOrCreateReadBuffer): Deleted.
+* loader/cache/CachedResource.h:
+(WebCore::CachedResource::getOrCreateReadBuffer): Deleted.
+* loader/soup/CachedRawResourceSoup.cpp: Removed.
+* loader/soup/SubresourceLoaderSoup.cpp: Removed.
+* platform/graphics/PlatformMediaResourceLoader.h:
+(WebCore::PlatformMediaResourceClient::loadFinished):
+(WebCore::PlatformMediaResourceClient::getOrCreateReadBuffer): Deleted.
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(CachedResourceStreamingClient::getOrCreateReadBuffer): Deleted.
+* platform/network/ResourceHandleClient.h:
+(WebCore::ResourceHandleClient::getOrCreateReadBuffer): Deleted.
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::ResourceHandle::ensureReadBuffer):
+
 2018-01-08  Zan Dobersek   and Carlos Garcia Campos  
 
 [GStreamer] use FastMalloc-based GstAllocator


Modified: trunk/Source/WebCore/SourcesGTK.txt (226507 => 226508)

--- trunk/Source/WebCore/SourcesGTK.txt	2018-01-08 12:32:49 UTC (rev 226507)
+++ trunk/Source/WebCore/SourcesGTK.txt	2018-01-08 13:53:10 UTC (rev 226508)
@@ -41,9 +41,6 @@
 
 editing/atk/FrameSelectionAtk.cpp
 
-loader/soup/CachedRawResourceSoup.cpp
-loader/soup/SubresourceLoaderSoup.cpp
-
 page/linux/ResourceUsageOverlayLinux.cpp
 page/linux/ResourceUsageThreadLinux.cpp
 


Modified: trunk/Source/WebCore/SourcesWPE.txt (226507 => 226508)

--- trunk/Source/WebCore/SourcesWPE.txt	2018-01-08

[webkit-changes] [226507] trunk/LayoutTests

2018-01-08 Thread commit-queue

Title: [226507] trunk/LayoutTests








Revision 226507
Author commit-qu...@webkit.org
Date 2018-01-08 04:32:49 -0800 (Mon, 08 Jan 2018)


Log Message
imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html is slow in Debug
https://bugs.webkit.org/show_bug.cgi?id=181382

Unreviewed.

Patch by Youenn Fablet  on 2018-01-08

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226506 => 226507)

--- trunk/LayoutTests/ChangeLog	2018-01-08 11:33:14 UTC (rev 226506)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 12:32:49 UTC (rev 226507)
@@ -1,3 +1,12 @@
+2018-01-08  Youenn Fablet  
+
+imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html is slow in Debug
+https://bugs.webkit.org/show_bug.cgi?id=181382
+
+Unreviewed.
+
+* TestExpectations:
+
 2018-01-08  Carlos Garcia Campos  
 
 Unreviewed GTK gardening. Rebaseline test again after r226500.


Modified: trunk/LayoutTests/TestExpectations (226506 => 226507)

--- trunk/LayoutTests/TestExpectations	2018-01-08 11:33:14 UTC (rev 226506)
+++ trunk/LayoutTests/TestExpectations	2018-01-08 12:32:49 UTC (rev 226507)
@@ -186,6 +186,7 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ DumpJSConsoleLogInStdErr ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ]
+[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html [ Slow ]
 
 # Skip workers tests that are timing out or are SharedWorker related only
 imported/w3c/web-platform-tests/workers/constructors/Worker/same-origin.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226506] trunk/Source/ThirdParty/libwebrtc

2018-01-08 Thread ddkilzer

Title: [226506] trunk/Source/ThirdParty/libwebrtc








Revision 226506
Author ddkil...@apple.com
Date 2018-01-08 03:33:14 -0800 (Mon, 08 Jan 2018)


Log Message
libwebrtc: Fix 'ld: warning: cannot export hidden symbol' messages


Reviewed by Youenn Fablet.

* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:
- Remove 117 symbols that are not currently exported.  These
  warnings only appear in Release and Production builds.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (226505 => 226506)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-01-08 09:38:38 UTC (rev 226505)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-01-08 11:33:14 UTC (rev 226506)
@@ -1,3 +1,16 @@
+2018-01-08  David Kilzer  
+
+libwebrtc: Fix 'ld: warning: cannot export hidden symbol' messages
+
+
+Reviewed by Youenn Fablet.
+
+* Configurations/libwebrtc.iOS.exp:
+* Configurations/libwebrtc.iOSsim.exp:
+* Configurations/libwebrtc.mac.exp:
+- Remove 117 symbols that are not currently exported.  These
+  warnings only appear in Release and Production builds.
+
 2018-01-05  Youenn Fablet  
 
 Close WebRTC sockets when marked as defunct


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp (226505 => 226506)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp	2018-01-08 09:38:38 UTC (rev 226505)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp	2018-01-08 11:33:14 UTC (rev 226506)
@@ -397,123 +397,7 @@
 _I422ToARGBRow_NEON
 _ARGBToRAWRow_NEON
 
-_WebRtcIsac_Create
-_WebRtcIsac_DecoderInit
-_WebRtcIsac_Encode
-_WebRtcIsac_EncoderInit
-_WebRtcIsac_Free
-_WebRtcIsac_UpdateBwEstimate
-_WebRtcIsacfix_AllpassFilter2FixDec16C
-_WebRtcIsacfix_AutocorrC
-_WebRtcIsacfix_CalculateResidualEnergyC
-_WebRtcIsacfix_HighpassFilterFixDec32C
-_WebRtcIsacfix_Spec2TimeC
-_WebRtcIsacfix_Time2SpecC
-_WebRtcIsacfix_kHPStCoeffOut1Q30
-_WebRtcIsacfix_kLowerApFactorsQ15
-_WebRtcIsacfix_kUpperApFactorsQ15
-_WebRtcOpus_Decode
-_WebRtcOpus_DecodePlc
-_WebRtcOpus_DecoderChannels
-_WebRtcOpus_DecoderCreate
-_WebRtcOpus_DecoderFree
-_WebRtcOpus_DecoderInit
-_WebRtcOpus_DisableCbr
-_WebRtcOpus_DisableDtx
-_WebRtcOpus_DisableFec
-_WebRtcOpus_DurationEst
-_WebRtcOpus_EnableCbr
-_WebRtcOpus_EnableDtx
-_WebRtcOpus_EnableFec
-_WebRtcOpus_Encode
-_WebRtcOpus_EncoderCreate
-_WebRtcOpus_EncoderFree
-_WebRtcOpus_SetBitRate
-_WebRtcOpus_SetComplexity
-_WebRtcOpus_SetForceChannels
-_WebRtcOpus_SetMaxPlaybackRate
-_WebRtcOpus_SetPacketLossRate
-_WebRtcPcm16b_Decode
-_WebRtcPcm16b_Encode
-_WebRtcSpl_AddAffineVectorToVector
-_WebRtcSpl_AddVectorsAndShift
-_WebRtcSpl_AffineTransformVector
-_WebRtcSpl_AutoCorrelation
-_WebRtcSpl_ComplexBitReverse
-_WebRtcSpl_ComplexFFT
-_WebRtcSpl_ComplexIFFT
-_WebRtcSpl_CopyFromEndW16
-_WebRtcSpl_CrossCorrelation
-_WebRtcSpl_CrossCorrelationC
-_WebRtcSpl_DivResultInQ31
-_WebRtcSpl_DivU32U16
-_WebRtcSpl_DivW32HiLow
-_WebRtcSpl_DivW32W16
-_WebRtcSpl_DivW32W16ResW16
 _WebRtcSpl_DotProductWithScale
-_WebRtcSpl_ElementwiseVectorMult
-_WebRtcSpl_Energy
-_WebRtcSpl_FilterAR
-_WebRtcSpl_FilterARFastQ12
-_WebRtcSpl_FilterMAFastQ12
-_WebRtcSpl_GetHanningWindow
-_WebRtcSpl_GetScalingSquare
-_WebRtcSpl_Init
-_WebRtcSpl_LevinsonDurbin
-_WebRtcSpl_MaxAbsIndexW16
-_WebRtcSpl_MaxAbsValueW16
-_WebRtcSpl_MaxAbsValueW32
-_WebRtcSpl_MaxIndexW16
-_WebRtcSpl_MaxIndexW32
-_WebRtcSpl_MaxValueW16
-_WebRtcSpl_MaxValueW32
-_WebRtcSpl_MemCpyReversedOrder
-_WebRtcSpl_MemSetW16
-_WebRtcSpl_MemSetW32
-_WebRtcSpl_MinIndexW16
-_WebRtcSpl_MinIndexW32
-_WebRtcSpl_MinValueW16
-_WebRtcSpl_MinValueW32
-_WebRtcSpl_RandN
-_WebRtcSpl_RandU
-_WebRtcSpl_RandUArray
-_WebRtcSpl_Resample48khzTo32khz
-_WebRtcSpl_ReverseOrderMultArrayElements
-_WebRtcSpl_ScaleAndAddVectors
-_WebRtcSpl_ScaleAndAddVectorsWithRound
-_WebRtcSpl_ScaleVector
-_WebRtcSpl_ScaleVectorWithSat
-_WebRtcSpl_Sqrt
-_WebRtcSpl_SqrtFloor
-_WebRtcSpl_SqrtOfOneMinusXSquared
-_WebRtcSpl_VectorBitShiftW16
-_WebRtcSpl_VectorBitShiftW32
-_WebRtcSpl_VectorBitShiftW32ToW16
-_WebRtcSpl_ZerosArrayW16
-_WebRtcSpl_ZerosArrayW32
-_WebRtcVad_CalcVad16khz
-_WebRtcVad_CalcVad32khz
-_WebRtcVad_CalcVad48khz
-_WebRtcVad_CalcVad8khz
-_WebRtcVad_CalculateFeatures
-_WebRtcVad_Create
-_WebRtcVad_Downsampling
-_WebRtcVad_FindMinimum
-_WebRtcVad_Free
-_WebRtcVad_GaussianProbability
-_WebRtcVad_Init
-_WebRtcVad_InitCore
-_WebRtcVad_Process
-_WebRtcVad_ValidRateAndFrameLength
-_WebRtcVad_set_mode
-_WebRtcVad_set_mode_core
-_WebRtc_CreateBuffer
-_WebRtc_FreeBuffer
-_WebRtc_InitBuffer
-_WebRtc_ReadBuffer
-_WebRtc_WriteBuffer

[webkit-changes] [226505] trunk/LayoutTests

2018-01-08 Thread carlosgc

Title: [226505] trunk/LayoutTests








Revision 226505
Author carlo...@webkit.org
Date 2018-01-08 01:38:38 -0800 (Mon, 08 Jan 2018)


Log Message
Unreviewed GTK gardening. Rebaseline test again after r226500.

* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (226504 => 226505)

--- trunk/LayoutTests/ChangeLog	2018-01-08 09:34:36 UTC (rev 226504)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 09:38:38 UTC (rev 226505)
@@ -1,5 +1,11 @@
 2018-01-08  Carlos Garcia Campos  
 
+Unreviewed GTK gardening. Rebaseline test again after r226500.
+
+* platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
+
+2018-01-08  Carlos Garcia Campos  
+
 Unreviewed GTK gardening. Partially revert r224460.
 
 Two tests were incorrectly rebaselined in r224460.


Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt (226504 => 226505)

--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt	2018-01-08 09:34:36 UTC (rev 226504)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt	2018-01-08 09:38:38 UTC (rev 226505)
@@ -9,9 +9,9 @@
 PASS createImageBitmap with a HTMLCanvasElement source and sw set to 0 rejects with a RangeError. 
 PASS createImageBitmap with a HTMLCanvasElement source and sh set to 0 rejects with a RangeError. 
 FAIL createImageBitmap with a HTMLCanvasElement source and oversized (unallocatable) crop region rejects with an InvalidStateError DOMException. assert_unreached: Should have rejected: undefined Reached unreachable code
-FAIL createImageBitmap with a OffscreenCanvas source and sw set to 0 rejects with a RangeError. promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
-FAIL createImageBitmap with a OffscreenCanvas source and sh set to 0 rejects with a RangeError. promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
-FAIL createImageBitmap with a OffscreenCanvas source and oversized (unallocatable) crop region rejects with an InvalidStateError DOMException. promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
+FAIL createImageBitmap with a OffscreenCanvas source and sw set to 0 rejects with a RangeError. assert_throws: function "function () { throw e }" threw object "TypeError: Type error" ("TypeError") expected object "RangeError" ("RangeError")
+FAIL createImageBitmap with a OffscreenCanvas source and sh set to 0 rejects with a RangeError. assert_throws: function "function () { throw e }" threw object "TypeError: Type error" ("TypeError") expected object "RangeError" ("RangeError")
+FAIL createImageBitmap with a OffscreenCanvas source and oversized (unallocatable) crop region rejects with an InvalidStateError DOMException. assert_throws: function "function () { throw e }" threw object "TypeError: Type error" ("TypeError") expected object "InvalidStateError" ("InvalidStateError")
 PASS createImageBitmap with a ImageData source and sw set to 0 rejects with a RangeError. 
 PASS createImageBitmap with a ImageData source and sh set to 0 rejects with a RangeError. 
 FAIL createImageBitmap with a ImageData source and oversized (unallocatable) crop region rejects with an InvalidStateError DOMException. assert_throws: function "function () { throw e }" threw object "TypeError: createImageBitmap with ImageData is not implemented" ("TypeError") expected object "InvalidStateError" ("InvalidStateError")
@@ -26,6 +26,6 @@
 PASS createImageBitmap with empty image source rejects with a InvalidStateError. 
 FAIL createImageBitmap with empty video source rejects with a InvalidStateError. assert_throws: function "function () { throw e }" threw object "TypeError: createImageBitmap with HTMLVideoElement is not implemented" ("TypeError") expected object "InvalidStateError" ("InvalidStateError")
 PASS createImageBitmap with an oversized canvas source rejects with a RangeError. 
-FAIL createImageBitmap with an invalid OffscreenCanvas source rejects with a RangeError. promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: OffscreenCanvas"
+FAIL createImageBitmap with an invalid OffscreenCanvas source rejects with a RangeError. assert_throws: function "function () { throw e }" threw object "TypeError: Type error" ("TypeError") expected object "InvalidStateError" ("InvalidStateError")
 FAIL

[webkit-changes] [226504] trunk/Source/WebCore

2018-01-08 Thread carlosgc

Title: [226504] trunk/Source/WebCore








Revision 226504
Author carlo...@webkit.org
Date 2018-01-08 01:34:36 -0800 (Mon, 08 Jan 2018)


Log Message
[GStreamer] use FastMalloc-based GstAllocator
https://bugs.webkit.org/show_bug.cgi?id=165793

Reviewed by Philippe Normand.

Add GstAllocatorFastMalloc, a GstAllocator implementation using fast malloc. It's only used when fast malloc is
enabled and can be disabled using an environment variable for debugging purposes.

* platform/GStreamer.cmake:
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer):
* platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp: Added.
(gstMemoryFastMallocNew):
(gstAllocatorFastMallocAlloc):
(gstAllocatorFastMallocFree):
(gstAllocatorFastMallocMemMap):
(gstAllocatorFastMallocMemUnmap):
(gstAllocatorFastMallocMemCopy):
(gstAllocatorFastMallocMemShare):
(gstAllocatorFastMallocMemIsSpan):
(gst_allocator_fast_malloc_class_init):
(gst_allocator_fast_malloc_init):
* platform/graphics/gstreamer/GstAllocatorFastMalloc.h: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/GStreamer.cmake
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226503 => 226504)

--- trunk/Source/WebCore/ChangeLog	2018-01-08 09:22:49 UTC (rev 226503)
+++ trunk/Source/WebCore/ChangeLog	2018-01-08 09:34:36 UTC (rev 226504)
@@ -1,3 +1,29 @@
+2018-01-08  Zan Dobersek   and Carlos Garcia Campos  
+
+[GStreamer] use FastMalloc-based GstAllocator
+https://bugs.webkit.org/show_bug.cgi?id=165793
+
+Reviewed by Philippe Normand.
+
+Add GstAllocatorFastMalloc, a GstAllocator implementation using fast malloc. It's only used when fast malloc is
+enabled and can be disabled using an environment variable for debugging purposes.
+
+* platform/GStreamer.cmake:
+* platform/graphics/gstreamer/GStreamerUtilities.cpp:
+(WebCore::initializeGStreamer):
+* platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp: Added.
+(gstMemoryFastMallocNew):
+(gstAllocatorFastMallocAlloc):
+(gstAllocatorFastMallocFree):
+(gstAllocatorFastMallocMemMap):
+(gstAllocatorFastMallocMemUnmap):
+(gstAllocatorFastMallocMemCopy):
+(gstAllocatorFastMallocMemShare):
+(gstAllocatorFastMallocMemIsSpan):
+(gst_allocator_fast_malloc_class_init):
+(gst_allocator_fast_malloc_init):
+* platform/graphics/gstreamer/GstAllocatorFastMalloc.h: Added.
+
 2018-01-07  Ms2ger  
 
 Implement createImageBitmap(ImageBitmap)


Modified: trunk/Source/WebCore/platform/GStreamer.cmake (226503 => 226504)

--- trunk/Source/WebCore/platform/GStreamer.cmake	2018-01-08 09:22:49 UTC (rev 226503)
+++ trunk/Source/WebCore/platform/GStreamer.cmake	2018-01-08 09:34:36 UTC (rev 226504)
@@ -9,6 +9,7 @@
 platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp
 platform/graphics/gstreamer/GRefPtrGStreamer.cpp
 platform/graphics/gstreamer/GStreamerUtilities.cpp
+platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp
 platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
 platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
 platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp (226503 => 226504)

--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp	2018-01-08 09:22:49 UTC (rev 226503)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp	2018-01-08 09:34:36 UTC (rev 226504)
@@ -24,6 +24,7 @@
 #include "GStreamerUtilities.h"
 
 #include "GRefPtrGStreamer.h"
+#include "GstAllocatorFastMalloc.h"
 #include "IntSize.h"
 
 #include 
@@ -154,6 +155,12 @@
 bool gstInitialized = gst_init_check(nullptr, nullptr, ());
 ASSERT_WITH_MESSAGE(gstInitialized, "GStreamer initialization failed: %s", error ? error->message : "unknown error occurred");
 
+if (isFastMallocEnabled()) {
+const char* disableFastMalloc = getenv("WEBKIT_GST_DISABLE_FAST_MALLOC");
+if (!disableFastMalloc || !strcmp(disableFastMalloc, "0"))
+gst_allocator_set_default(GST_ALLOCATOR(g_object_new(gst_allocator_fast_malloc_get_type(), nullptr)));
+}
+
 #if ENABLE(VIDEO_TRACK) && USE(GSTREAMER_MPEGTS)
 if (gstInitialized)
 gst_mpegts_initialize();


Added: trunk/Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp (0 => 226504)

--- trunk/Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp	(rev 0)
+++

[webkit-changes] [226503] trunk/Source/WebKitLegacy/mac

2018-01-08 Thread ddkilzer

Title: [226503] trunk/Source/WebKitLegacy/mac








Revision 226503
Author ddkil...@apple.com
Date 2018-01-08 01:22:49 -0800 (Mon, 08 Jan 2018)


Log Message
Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects



* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
- Use reinterpret_cast(const_cast())
  to avoid warnings from casting CFStringRef to NPNSString*.
  Note that CFMutableStringRef is the same as CFStringRef
  without the const modifier, hence its use in the const_cast<>
  above.

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (226502 => 226503)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-08 09:16:58 UTC (rev 226502)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-08 09:22:49 UTC (rev 226503)
@@ -1,5 +1,19 @@
 2018-01-08  David Kilzer  
 
+Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
+
+
+
+* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
+(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
+- Use reinterpret_cast(const_cast())
+  to avoid warnings from casting CFStringRef to NPNSString*.
+  Note that CFMutableStringRef is the same as CFStringRef
+  without the const modifier, hence its use in the const_cast<>
+  above.
+
+2018-01-08  David Kilzer  
+
 Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
 
 


Modified: trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm (226502 => 226503)

--- trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm	2018-01-08 09:16:58 UTC (rev 226502)
+++ trunk/Source/WebKitLegacy/mac/Plugins/WebNetscapePluginEventHandlerCocoa.mm	2018-01-08 09:22:49 UTC (rev 226503)
@@ -291,7 +291,7 @@
 NPCocoaEvent event;
 
 initializeEvent(, NPCocoaEventTextInput);
-event.data.text.text = (NPNSString*)text.get();
+event.data.text.text = reinterpret_cast(const_cast(text.get()));
 
 sendEvent();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226502] trunk/LayoutTests

2018-01-08 Thread carlosgc

Title: [226502] trunk/LayoutTests








Revision 226502
Author carlo...@webkit.org
Date 2018-01-08 01:16:58 -0800 (Mon, 08 Jan 2018)


Log Message
Unreviewed GTK gardening. Partially revert r224460.

Two tests were incorrectly rebaselined in r224460.

* platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
* platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (226501 => 226502)

--- trunk/LayoutTests/ChangeLog	2018-01-08 09:08:45 UTC (rev 226501)
+++ trunk/LayoutTests/ChangeLog	2018-01-08 09:16:58 UTC (rev 226502)
@@ -1,3 +1,12 @@
+2018-01-08  Carlos Garcia Campos  
+
+Unreviewed GTK gardening. Partially revert r224460.
+
+Two tests were incorrectly rebaselined in r224460.
+
+* platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
+* platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
+
 2018-01-07  Ms2ger  
 
 Implement createImageBitmap(ImageBitmap)


Modified: trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (226501 => 226502)

--- trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt	2018-01-08 09:08:45 UTC (rev 226501)
+++ trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt	2018-01-08 09:16:58 UTC (rev 226502)
@@ -8,39 +8,39 @@
   text run at (0,0) width 771: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the"
   text run at (0,18) width 53: "test tool."
   RenderBlock {DIV} at (0,52) size 784x56
-RenderTextControl {INPUT} at (2,2) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #00)]
-  RenderFlexibleBox {DIV} at (3,3) size 203x18
-RenderBlock {DIV} at (0,0) size 203x18
-RenderBlock {DIV} at (203,9) size 0x0
-RenderText {#text} at (213,4) size 4x17
-  text run at (213,4) width 4: " "
-RenderTextControl {INPUT} at (219,2) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #00)]
-  RenderFlexibleBox {DIV} at (3,3) size 203x18
-RenderBlock {DIV} at (0,0) size 203x18
-RenderBlock {DIV} at (203,9) size 0x0
-RenderText {#text} at (430,4) size 4x17
-  text run at (430,4) width 4: " "
-RenderTextControl {INPUT} at (434,2) size 306x24 [bgcolor=#FAFFBD] [border: (2px inset #00)]
+RenderTextControl {INPUT} at (2,2) size 191x24 [bgcolor=#FF] [border: (2px inset #00)]
+  RenderFlexibleBox {DIV} at (3,3) size 185x18
+RenderBlock {DIV} at (0,0) size 185x18
+RenderBlock {DIV} at (185,9) size 0x0
+RenderText {#text} at (195,5) size 4x17
+  text run at (195,5) width 4: " "
+RenderTextControl {INPUT} at (201,2) size 191x24 [bgcolor=#FF] [border: (2px inset #00)]
+  RenderFlexibleBox {DIV} at (3,3) size 185x18
+RenderBlock {DIV} at (0,0) size 185x18
+RenderBlock {DIV} at (185,9) size 0x0
+RenderText {#text} at (394,5) size 4x17
+  text run at (394,5) width 4: " "
+RenderTextControl {INPUT} at (398,2) size 306x24 [bgcolor=#FF] [border: (2px inset #00)]
   RenderFlexibleBox {DIV} at (3,3) size 300x18
 RenderBlock {DIV} at (0,0) size 300x18
 RenderBlock {DIV} at (300,9) size 0x0
-RenderText {#text} at (740,4) size 4x17
-  text run at (740,4) width 4: " "
-RenderTextControl {INPUT} at (2,30) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #00)]
-  RenderFlexibleBox {DIV} at (3,3) size 203x18
-RenderBlock {DIV} at (0,0) size 203x18
-RenderBlock {DIV} at (203,9) size 0x0
-layer at (13,73) size 203x18 scrollWidth 430
-  RenderBlock {DIV} at (0,0) size 203x18 [color=#0099]
-RenderText {#text} at (0,0) size 430x18
-  text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog."
-layer at (230,73) size 203x18 scrollWidth 430
-  RenderBlock {DIV} at (0,0) size 203x18 [color=#0099]
-RenderText {#text} at (0,0) size 430x18
-  text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog."
-layer at (445,73) size 300x18 scrollWidth 430
+RenderText {#text} at (704,5) size 4x17
+  text run at (704,5) width 4: " "

85 matches

Mail list logo