[webkit-changes] [227775] trunk
Title: [227775] trunk
Revision 227775
Author utatane@gmail.com
Date 2018-01-29 23:34:44 -0800 (Mon, 29 Jan 2018)
Log Message
[JSC] Relax line terminators in String to make JSON subset of JS
https://bugs.webkit.org/show_bug.cgi?id=182232
Reviewed by Keith Miller.
JSTests:
* ChakraCore/test/es5/Lex_u3.baseline-jsc:
* stress/relaxed-line-terminators-in-string.js: Added.
(shouldBe):
Source/_javascript_Core:
"Subsume JSON" spec is now stage 3[1]. Before this spec change,
JSON can accept \u2028 / \u2029 in string while JS cannot do that.
It accidentally made JSON non subset of JS.
Now we extend our JS string to accept \u2028 / \u2029 to make JSON
subset of JS in this spec change.
[1]: https://github.com/tc39/proposal-json-superset
* parser/Lexer.cpp:
(JSC::Lexer::parseStringSlowCase):
LayoutTests:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3.html:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4.html:
Modified Paths
trunk/JSTests/ChakraCore/test/es5/Lex_u3.baseline-jsc
trunk/JSTests/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt
trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3.html
trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt
trunk/LayoutTests/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.cpp
Added Paths
trunk/JSTests/stress/relaxed-line-terminators-in-string.js
Diff
Modified: trunk/JSTests/ChakraCore/test/es5/Lex_u3.baseline-jsc (227774 => 227775)
--- trunk/JSTests/ChakraCore/test/es5/Lex_u3.baseline-jsc 2018-01-30 07:00:19 UTC (rev 227774)
+++ trunk/JSTests/ChakraCore/test/es5/Lex_u3.baseline-jsc 2018-01-30 07:34:44 UTC (rev 227775)
@@ -2,7 +2,7 @@
undefined
str const Left
str const right
-LS in string - compile failure in ES5: expected.SyntaxError: Unexpected EOF
+str%20const%20Left%20%u2028%20str%20const%20right
LS in regex literal - compile failure in ES5: expected.SyntaxError: Unterminated regular _expression_ literal '/str const regex '
LS%20in%20escape%20sequence%20string%20literal%20%20%3Amore%20string
BOM is WS : 91
Modified: trunk/JSTests/ChangeLog (227774 => 227775)
--- trunk/JSTests/ChangeLog 2018-01-30 07:00:19 UTC (rev 227774)
+++ trunk/JSTests/ChangeLog 2018-01-30 07:34:44 UTC (rev 227775)
@@ -1,3 +1,14 @@
+2018-01-29 Yusuke Suzuki
+
+[JSC] Relax line terminators in String to make JSON subset of JS
+https://bugs.webkit.org/show_bug.cgi?id=182232
+
+Reviewed by Keith Miller.
+
+* ChakraCore/test/es5/Lex_u3.baseline-jsc:
+* stress/relaxed-line-terminators-in-string.js: Added.
+(shouldBe):
+
2018-01-29 Michael Saboff
REGRESSION (r227341): DFG_ASSERT failure at JSC::DFG::AtTailAbstractState::forNode()
Added: trunk/JSTests/stress/relaxed-line-terminators-in-string.js (0 => 227775)
--- trunk/JSTests/stress/relaxed-line-terminators-in-string.js (rev 0)
+++ trunk/JSTests/stress/relaxed-line-terminators-in-string.js 2018-01-30 07:34:44 UTC (rev 227775)
@@ -0,0 +1,14 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+shouldBe(eval("'\u2028Japanese'").charCodeAt(0), 0x2028);
+shouldBe(eval("'\u2029Japanese'").charCodeAt(0), 0x2029);
+shouldBe(eval("'\u2028日本語'").charCodeAt(0), 0x2028);
+shouldBe(eval("'\u2029日本語'").charCodeAt(0), 0x2029);
+
+shouldBe(eval("'\u2028Japanese' + 'hello' + 'world'").charCodeAt(0), 0x2028);
+shouldBe(eval("'\u2029Japanese' + 'hello' + 'world'").charCodeAt(0), 0x2029);
+shouldBe(eval("'\u2028日本語' + 'hello' + 'world'").charCodeAt(0), 0x2028);
+shouldBe(eval("'\u2029日本語' + 'hello' + 'world'").charCodeAt(0), 0x2029);
Modified: trunk/LayoutTests/ChangeLog (227774 => 227775)
--- trunk/LayoutTests/ChangeLog 2018-01-30 07:00:19 UTC (rev 227774)
+++ trunk/LayoutTests/ChangeLog 2018-01-30 07:34:44 UTC (rev 227775)
@@ -1,3 +1,15 @@
+2018-01-29 Yusuke Suzuki
+
+[JSC] Relax line terminators in String to make JSON subset of JS
+https://bugs.webkit.org/show_bug.cgi?id=182232
+
+Reviewed by Keith Miller.
+
+* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
+* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3.html:
+* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
+* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4.html:
+
2018-01-29 Youenn Fablet
[webkit-changes] [227774] branches/safari-605-branch
Title: [227774] branches/safari-605-branch
Revision 227774
Author jmarc...@apple.com
Date 2018-01-29 23:00:19 -0800 (Mon, 29 Jan 2018)
Log Message
Cherry-pick r227737. rdar://problem/36746140
Modified Paths
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannel.cpp
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.h
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelRegistry.cpp
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelRegistry.h
branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/UIMessagePortChannelProvider.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm
Diff
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227773 => 227774)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-01-30 06:32:38 UTC (rev 227773)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-01-30 07:00:19 UTC (rev 227774)
@@ -1,3 +1,31 @@
+2018-01-29 Jason Marcell
+
+Cherry-pick r227737. rdar://problem/36746140
+
+2018-01-29 Brady Eidson
+
+Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
+https://bugs.webkit.org/show_bug.cgi?id=182229
+
+Reviewed by Chris Dumez.
+
+Covered by existing LayoutTests and a new API test.
+
+* dom/messageports/MessagePortChannel.cpp:
+(WebCore::MessagePortChannel::checkRemotePortForActivity): Don't use the global singleton
+ provider. Instead use the provider that belongs to the owning registry.
+
+* dom/messageports/MessagePortChannelProviderImpl.cpp:
+(WebCore::MessagePortChannelProviderImpl::MessagePortChannelProviderImpl): Pass a reference
+ to *this to the Registry.
+* dom/messageports/MessagePortChannelProviderImpl.h:
+
+* dom/messageports/MessagePortChannelRegistry.cpp:
+(WebCore::MessagePortChannelRegistry::MessagePortChannelRegistry): Keep a Provider member so
+ MessagePortChannels can get to it instead of relying on the global singleton provider.
+* dom/messageports/MessagePortChannelRegistry.h:
+(WebCore::MessagePortChannelRegistry::provider):
+
2018-01-26 Jason Marcell
Cherry-pick r227570. rdar://problem/36873398
Modified: branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannel.cpp (227773 => 227774)
--- branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannel.cpp 2018-01-30 06:32:38 UTC (rev 227773)
+++ branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannel.cpp 2018-01-30 07:00:19 UTC (rev 227774)
@@ -240,7 +240,7 @@
callback(hasActivity);
} };
-MessagePortChannelProvider::singleton().checkProcessLocalPortForActivity(remotePort, *m_processes[i], WTFMove(outerCallback));
+m_registry.provider().checkProcessLocalPortForActivity(remotePort, *m_processes[i], WTFMove(outerCallback));
}
bool MessagePortChannel::hasAnyMessagesPendingOrInFlight() const
Modified: branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp (227773 => 227774)
--- branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp 2018-01-30 06:32:38 UTC (rev 227773)
+++ branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp 2018-01-30 07:00:19 UTC (rev 227774)
@@ -33,6 +33,11 @@
namespace WebCore {
+MessagePortChannelProviderImpl::MessagePortChannelProviderImpl()
+: m_registry(*this)
+{
+}
+
MessagePortChannelProviderImpl::~MessagePortChannelProviderImpl()
{
ASSERT_NOT_REACHED();
Modified: branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.h (227773 => 227774)
--- branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.h 2018-01-30 06:32:38 UTC (rev 227773)
+++ branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.h 2018-01-30 07:00:19 UTC (rev 227774)
@@ -32,6 +32,7 @@
class MessagePortChannelProviderImpl : public MessagePortChannelProvider {
public:
+MessagePortChannelProviderImpl();
~MessagePortChannelProviderImpl() final;
private:
Modified: branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelRegistry.cpp (227773 => 227774)
--- branches/safari-605-branch/Source/WebCore/dom/messageports/Message
[webkit-changes] [227773] trunk/Source
Title: [227773] trunk/Source
Revision 227773
Author carlo...@webkit.org
Date 2018-01-29 22:32:38 -0800 (Mon, 29 Jan 2018)
Log Message
WebDriver: evaluateJavaScriptFunction should return null when return value is undefined
https://bugs.webkit.org/show_bug.cgi?id=180350
Reviewed by Carlos Alberto Lopez Perez.
Source/WebDriver:
Stop handling the empty string as a special case of evaluateJavaScriptFunction result.
* Session.cpp:
(WebDriver::Session::executeScript):
Source/WebKit:
undefined can't be converted to JSON string, in which case JSON.stringify() returns undefined and we handle that
case to return an empty string. We currently handle this case for execute script commands, but not in all other
cases where we use evaluateJavaScriptFunction. It would be simpler if evaluateJavaScriptFunction returned null,
because in that case we wouldn't need to handle it as a special case.
15.2 Executing Script
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-json-clone
Fixes: imported/w3c/webdriver/tests/state/get_element_property.py::test_element_non_existent
* WebProcess/Automation/WebAutomationSessionProxy.js:
(let.AutomationSessionProxy.prototype._jsonStringify): Return "null" instead of "" when undefined is given.
Modified Paths
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js
Diff
Modified: trunk/Source/WebDriver/ChangeLog (227772 => 227773)
--- trunk/Source/WebDriver/ChangeLog 2018-01-30 05:56:36 UTC (rev 227772)
+++ trunk/Source/WebDriver/ChangeLog 2018-01-30 06:32:38 UTC (rev 227773)
@@ -1,3 +1,15 @@
+2018-01-29 Carlos Garcia Campos
+
+WebDriver: evaluateJavaScriptFunction should return null when return value is undefined
+https://bugs.webkit.org/show_bug.cgi?id=180350
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Stop handling the empty string as a special case of evaluateJavaScriptFunction result.
+
+* Session.cpp:
+(WebDriver::Session::executeScript):
+
2018-01-26 Carlos Garcia Campos
WebDriver: service hangs after a browser crash
Modified: trunk/Source/WebDriver/Session.cpp (227772 => 227773)
--- trunk/Source/WebDriver/Session.cpp 2018-01-30 05:56:36 UTC (rev 227772)
+++ trunk/Source/WebDriver/Session.cpp 2018-01-30 06:32:38 UTC (rev 227773)
@@ -1800,10 +1800,6 @@
completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
return;
}
-if (valueString.isEmpty()) {
-completionHandler(CommandResult::success());
-return;
-}
RefPtr resultValue;
if (!JSON::Value::parseJSON(valueString, resultValue)) {
completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
Modified: trunk/Source/WebKit/ChangeLog (227772 => 227773)
--- trunk/Source/WebKit/ChangeLog 2018-01-30 05:56:36 UTC (rev 227772)
+++ trunk/Source/WebKit/ChangeLog 2018-01-30 06:32:38 UTC (rev 227773)
@@ -1,3 +1,23 @@
+2018-01-29 Carlos Garcia Campos
+
+WebDriver: evaluateJavaScriptFunction should return null when return value is undefined
+https://bugs.webkit.org/show_bug.cgi?id=180350
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+undefined can't be converted to JSON string, in which case JSON.stringify() returns undefined and we handle that
+case to return an empty string. We currently handle this case for execute script commands, but not in all other
+cases where we use evaluateJavaScriptFunction. It would be simpler if evaluateJavaScriptFunction returned null,
+because in that case we wouldn't need to handle it as a special case.
+
+15.2 Executing Script
+https://w3c.github.io/webdriver/webdriver-spec.html#dfn-json-clone
+
+Fixes: imported/w3c/webdriver/tests/state/get_element_property.py::test_element_non_existent
+
+* WebProcess/Automation/WebAutomationSessionProxy.js:
+(let.AutomationSessionProxy.prototype._jsonStringify): Return "null" instead of "" when undefined is given.
+
2018-01-29 Ryosuke Niwa
Release assert in updateLayout while waiting for sync reply to WebPageProxy::HasInsecureContent
Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js (227772 => 227773)
--- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js 2018-01-30 05:56:36 UTC (rev 227772)
+++ trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js 2018-01-30 06:32:38 UTC (rev 227773)
@@ -88,7 +88,7 @@
_jsonStringify(original)
{
-return JSON.stringify(original, (key, value) => this._replaceJSONValue(key, value)) || "";
+return JSON.stringify(original, (key, value) => this._replaceJSONValue(key, value)) || "null";
}
_reviveJSONValue(key, value)
[webkit-changes] [227772] trunk/Source/WebKit
Title: [227772] trunk/Source/WebKit Revision 227772 Author rn...@webkit.org Date 2018-01-29 21:56:36 -0800 (Mon, 29 Jan 2018) Log Message Release assert in updateLayout while waiting for sync reply to WebPageProxy::HasInsecureContent https://bugs.webkit.org/show_bug.cgi?id=182273 Reviewed by Chris Dumez. The assertion was caused by unrelated sync IPCs being processed while WebContent process is waiting for the reply to WebPageProxy::HasInsecureContent. Since this IPC can be used while creating CachedFrame, it's not safe to execute arbitrary code. Fixed the bug by using DoNotProcessIncomingMessagesWhenWaitingForSyncReply added in r227566. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (227771 => 227772) --- trunk/Source/WebKit/ChangeLog 2018-01-30 05:36:38 UTC (rev 227771) +++ trunk/Source/WebKit/ChangeLog 2018-01-30 05:56:36 UTC (rev 227772) @@ -1,3 +1,19 @@ +2018-01-29 Ryosuke Niwa + +Release assert in updateLayout while waiting for sync reply to WebPageProxy::HasInsecureContent +https://bugs.webkit.org/show_bug.cgi?id=182273 + +Reviewed by Chris Dumez. + +The assertion was caused by unrelated sync IPCs being processed while WebContent process is waiting for +the reply to WebPageProxy::HasInsecureContent. Since this IPC can be used while creating CachedFrame, +it's not safe to execute arbitrary code. + +Fixed the bug by using DoNotProcessIncomingMessagesWhenWaitingForSyncReply added in r227566. + +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame): + 2018-01-29 Wenson Hsieh Add a build step to copy resources from WebKitAdditions as bundle resources in WebKit Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (227771 => 227772) --- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2018-01-30 05:36:38 UTC (rev 227771) +++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2018-01-30 05:56:36 UTC (rev 227772) @@ -1371,7 +1371,7 @@ return; HasInsecureContent hasInsecureContent; -if (webPage->sendSync(Messages::WebPageProxy::HasInsecureContent(), Messages::WebPageProxy::HasInsecureContent::Reply(hasInsecureContent))) +if (webPage->sendSync(Messages::WebPageProxy::HasInsecureContent(), Messages::WebPageProxy::HasInsecureContent::Reply(hasInsecureContent), Seconds::infinity(), IPC::SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply)) cachedFrame->setHasInsecureContent(hasInsecureContent); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227771] trunk/Source/WebKit
Title: [227771] trunk/Source/WebKit
Revision 227771
Author wenson_hs...@apple.com
Date 2018-01-29 21:36:38 -0800 (Mon, 29 Jan 2018)
Log Message
Add a build step to copy resources from WebKitAdditions as bundle resources in WebKit
https://bugs.webkit.org/show_bug.cgi?id=182268
Reviewed by Tim Horton and Dan Bernstein.
Adds a "Copy Additional Resources" phase when building WebKit. This phase copies resources from
usr/local/include/WebKitAdditions/WebKit/AdditionalResources in the build directory into the
unlocalized resources directory. If the AdditionalResources directory does not exist in the build
directory, we fall back to searching the SDK.
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (227770 => 227771)
--- trunk/Source/WebKit/ChangeLog 2018-01-30 02:15:14 UTC (rev 227770)
+++ trunk/Source/WebKit/ChangeLog 2018-01-30 05:36:38 UTC (rev 227771)
@@ -1,3 +1,18 @@
+2018-01-29 Wenson Hsieh
+
+Add a build step to copy resources from WebKitAdditions as bundle resources in WebKit
+https://bugs.webkit.org/show_bug.cgi?id=182268
+
+
+Reviewed by Tim Horton and Dan Bernstein.
+
+Adds a "Copy Additional Resources" phase when building WebKit. This phase copies resources from
+usr/local/include/WebKitAdditions/WebKit/AdditionalResources in the build directory into the
+unlocalized resources directory. If the AdditionalResources directory does not exist in the build
+directory, we fall back to searching the SDK.
+
+* WebKit.xcodeproj/project.pbxproj:
+
2018-01-29 Youenn Fablet
ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (227770 => 227771)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-01-30 02:15:14 UTC (rev 227770)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-01-30 05:36:38 UTC (rev 227771)
@@ -4745,12 +4745,12 @@
BC8283F916B4FDDE00A278FE /* com.apple.WebKit.Plugin.32.xpc */,
BC82841F16B4FDF600A278FE /* com.apple.WebKit.Plugin.64.xpc */,
51F7DC4A180CC93600212CA3 /* com.apple.WebKit.Storage.xpc */,
+372EBB462017E64300085064 /* com.apple.WebKit.WebContent.Development.xpc */,
BC3DE46615A91763008D26FC /* com.apple.WebKit.WebContent.xpc */,
1AC25FB012A48EA700BD2671 /* PluginProcessShim.dylib */,
510031F61379CACB00C8DFE4 /* SecItemShim.dylib */,
8DC2EF5B0486A6940098B216 /* WebKit.framework */,
CDC3830617211799008A2FC3 /* WebProcessShim.dylib */,
-372EBB462017E64300085064 /* com.apple.WebKit.WebContent.Development.xpc */,
);
name = Products;
sourceTree = "";
@@ -4979,8 +4979,8 @@
1A4F976E100E7B6600637A18 /* Version.xcconfig */,
7C0BB9A818DCDE890006C086 /* WebContent-iOS.entitlements */,
37B418EB1C9624F20031E63B /* WebContent-OSX.entitlements */,
+372EBB4A2017E7685064 /* WebContentService.Development.xcconfig */,
BCACC40E16B0B8A800B6E092 /* WebContentService.xcconfig */,
-372EBB4A2017E7685064 /* WebContentService.Development.xcconfig */,
BCB86F4B116AAACD00CE20B7 /* WebKit.xcconfig */,
A1EDD2DD1884B9E300BBFE98 /* WebProcessShim.xcconfig */,
);
@@ -9701,6 +9701,7 @@
375A248817E5048E00C9A086 /* Postprocess WKBase.h */,
1AD98ECF191D867300CAA6DF /* Postprocess WKFoundation.h */,
1A1D2115191D96380001619F /* Postprocess Framework Headers */,
+2E16B6F42019BC25008996D6 /* Copy Additional Resources */,
8DC2EF520486A6940098B216 /* Resources */,
372589431C1E496800C92CA9 /* Copy Shims */,
7CB16FEE1724BA05007A0A95 /* Copy Plug-in Sandbox Profiles */,
@@ -10010,6 +10011,16 @@
shellPath = /bin/sh;
shellScript = "# Touch Info.plist to let Xcode know it needs to copy it into the built product\nif [[ \"${CONFIGURATION}\" != \"Production\" ]]; then\ntouch \"${PROJECT_DIR}/Info.plist\";\nfi;\n";
};
+ 2E16B6F42019BC25008996D6 /* Copy Additional Resources */ = {
+ isa = PBXShellScriptBuildPhase;
+ buildActionMask = 12;
+ files = (
+ );
+ name = "Copy Additional Resources";
+ runOnlyForDeploymentPostprocessing = 0;
+ shellPath = /bin/sh;
+ shellScript = "set -e\n\nRELATIVE_SOURCE_PATH=\"usr/local/include/WebKitAdditions/WebKit/AdditionalResources\"\nSOURCE_PATH=\"$BUILT_PRODUCTS_DIR/$RELATIVE_SOURCE_PATH\"\n\nif [[ ! -d \"$SOURCE_PATH\" ]]; then\nSOURCE_PATH=\"$SDK_DIR/$RELATIVE_SOURCE_PATH\"\nfi\n\nif [[ -d \"$SOURCE_PATH\" ]]; then\nditto $SOURCE_PATH \"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH\"\nfi";
+ };
3713F0231429063D0036387F /* Check For Inappropriate Objective-C Class Names */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
___
webkit-changes mailing list
webkit-changes@list
[webkit-changes] [227770] trunk
Title: [227770] trunk Revision 227770 Author commit-qu...@webkit.org Date 2018-01-29 18:15:14 -0800 (Mon, 29 Jan 2018) Log Message ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses https://bugs.webkit.org/show_bug.cgi?id=182134 Patch by Youenn Fablet on 2018-01-29 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt: Source/WebKit: As per fetch spec, a response with a redirection status code but no Location header should not be considered as a redirection. This is also consistent with SubresourceLoader::didReceiveResponse. * WebProcess/Storage/ServiceWorkerClientFetch.cpp: (WebKit::ServiceWorkerClientFetch::didReceiveResponse): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt trunk/Source/WebCore/platform/network/HTTPHeaderMap.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp Diff Modified: trunk/LayoutTests/ChangeLog (227769 => 227770) --- trunk/LayoutTests/ChangeLog 2018-01-30 02:04:09 UTC (rev 227769) +++ trunk/LayoutTests/ChangeLog 2018-01-30 02:15:14 UTC (rev 227770) @@ -1,5 +1,14 @@ 2018-01-29 Youenn Fablet +ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses +https://bugs.webkit.org/show_bug.cgi?id=182134 + +Reviewed by Chris Dumez. + +* TestExpectations: + +2018-01-29 Youenn Fablet + Cache API should make sure to resolve caches.open promises in the same order as called https://bugs.webkit.org/show_bug.cgi?id=182193 Modified: trunk/LayoutTests/TestExpectations (227769 => 227770) --- trunk/LayoutTests/TestExpectations 2018-01-30 02:04:09 UTC (rev 227769) +++ trunk/LayoutTests/TestExpectations 2018-01-30 02:15:14 UTC (rev 227770) @@ -153,7 +153,6 @@ imported/w3c/web-platform-tests/fetch/api/abort/general-serviceworker.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-partial-stream.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/http-to-https-redirect-and-register.https.html [ Skip ] -imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/postmessage.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https.html [ Skip ] imported/w3c/web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https.html [ Skip ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (227769 => 227770) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-01-30 02:04:09 UTC (rev 227769) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-01-30 02:15:14 UTC (rev 227770) @@ -1,3 +1,12 @@ +2018-01-29 Youenn Fablet + +ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses +https://bugs.webkit.org/show_bug.cgi?id=182134 + +Reviewed by Chris Dumez. + +* web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt: + 2018-01-29 Oleksandr Skachkov FetchResponse should support ConsumeData callback on chunk data is received: handling ReadableStream bodies Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt (227769 => 227770) --- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt 2018-01-30 02:04:09 UTC (rev 227769) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt 2018-01-30 02:15:14 UTC (rev 227770) @@ -1,6 +1,4 @@ - -Harness Error (TIMEOUT), message = null PASS Normal redirect to same-origin scope. PASS Normal redirect to other-origin scope. @@ -24,11 +22,11 @@ PASS Redirect to same-origin other-scope with opaque redirect response. PASS Redirect to other-origin out-scope with opaque redirect response. PASS Redirect to other-origin in-scope with opaque redirect response. -TIMEOUT No location redirect response. Test timed out -NOTRUN Redirect to same-origin out-scope with opaque redirect response which is passed through Cache. -NOTRUN Redirect to same-origin same-scope with opaque redirect response which is passed through Cache. -NOTRUN Redirect to same-origin other-scope with opaque redirect response which is passed through Cache. -NOTRUN Redirect to other-origin out-scope with opaque redirect response which is passed thro
[webkit-changes] [227769] trunk/PerformanceTests
Title: [227769] trunk/PerformanceTests
Revision 227769
Author an...@apple.com
Date 2018-01-29 18:04:09 -0800 (Mon, 29 Jan 2018)
Log Message
StyleBench: Remove : from a test name
https://bugs.webkit.org/show_bug.cgi?id=182258
Reviewed by Ryosuke Niwa.
It breaks reporting.
* StyleBench/resources/style-bench.js:
(nthPseudoClassConfiguration):
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/StyleBench/resources/style-bench.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (227768 => 227769)
--- trunk/PerformanceTests/ChangeLog 2018-01-30 01:41:22 UTC (rev 227768)
+++ trunk/PerformanceTests/ChangeLog 2018-01-30 02:04:09 UTC (rev 227769)
@@ -1,3 +1,15 @@
+2018-01-29 Antti Koivisto
+
+StyleBench: Remove : from a test name
+https://bugs.webkit.org/show_bug.cgi?id=182258
+
+Reviewed by Ryosuke Niwa.
+
+It breaks reporting.
+
+* StyleBench/resources/style-bench.js:
+(nthPseudoClassConfiguration):
+
2018-01-29 Ryosuke Niwa
Temporarily skip StyleBench until webkit.org/b/182088 is fixed.
Modified: trunk/PerformanceTests/StyleBench/resources/style-bench.js (227768 => 227769)
--- trunk/PerformanceTests/StyleBench/resources/style-bench.js 2018-01-30 01:41:22 UTC (rev 227768)
+++ trunk/PerformanceTests/StyleBench/resources/style-bench.js 2018-01-30 02:04:09 UTC (rev 227769)
@@ -102,7 +102,7 @@
static nthPseudoClassConfiguration()
{
return Object.assign(this.defaultConfiguration(), {
-name: ':nth pseudo classes',
+name: 'Nth pseudo classes',
pseudoClassChance: 0.1,
pseudoClasses: [
'nth-child(2n+1)',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227768] trunk
Title: [227768] trunk Revision 227768 Author commit-qu...@webkit.org Date 2018-01-29 17:41:22 -0800 (Mon, 29 Jan 2018) Log Message Cache API should make sure to resolve caches.open promises in the same order as called https://bugs.webkit.org/show_bug.cgi?id=182193 Patch by Youenn Fablet on 2018-01-29 Reviewed by Chris Dumez. Source/WebCore: Covered by LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https.html. * Modules/cache/DOMCacheStorage.cpp: (WebCore::DOMCacheStorage::doRemove): Removed optimization consisting in removing the cache from DOMCacheStorage object synchronously. This optimization prevents going to the network process to try deleting the cache. Source/WebKit: Covered by added test. Whenever opening/removing a cache requires writing to disk, wait to finish the task until any disk writing task is done. Applying this strategy when clearing data so that we also clear data that is pending to be written. For removing cache, we now return whether a cache was actually deleted by returning zero as removed cache identifier. WebCore uses that information to return true/false as promise resolution value. * NetworkProcess/cache/CacheStorageEngine.cpp: (WebKit::CacheStorage::Engine::retrieveCaches): * NetworkProcess/cache/CacheStorageEngineCaches.cpp: (WebKit::CacheStorage::Caches::clear): (WebKit::CacheStorage::Caches::open): (WebKit::CacheStorage::Caches::remove): (WebKit::CacheStorage::Caches::writeCachesToDisk): (WebKit::CacheStorage::Caches::cacheInfos): (WebKit::CacheStorage::Caches::cacheInfos const): Deleted. * NetworkProcess/cache/CacheStorageEngineCaches.h: (WebKit::CacheStorage::Caches::createWeakPtr): LayoutTests: * http/wpt/cache-storage/cache-open.https-expected.txt: Added. * http/wpt/cache-storage/cache-open.https.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/cache/DOMCacheStorage.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h Added Paths trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https-expected.txt trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https.html Diff Modified: trunk/LayoutTests/ChangeLog (227767 => 227768) --- trunk/LayoutTests/ChangeLog 2018-01-30 01:38:23 UTC (rev 227767) +++ trunk/LayoutTests/ChangeLog 2018-01-30 01:41:22 UTC (rev 227768) @@ -1,3 +1,14 @@ +2018-01-29 Youenn Fablet + +Cache API should make sure to resolve caches.open promises in the same order as called +https://bugs.webkit.org/show_bug.cgi?id=182193 + + +Reviewed by Chris Dumez. + +* http/wpt/cache-storage/cache-open.https-expected.txt: Added. +* http/wpt/cache-storage/cache-open.https.html: Added. + 2018-01-29 Matt Lewis Marked imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html as flaky. Added: trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https-expected.txt (0 => 227768) --- trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https-expected.txt (rev 0) +++ trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https-expected.txt 2018-01-30 01:41:22 UTC (rev 227768) @@ -0,0 +1,4 @@ + +PASS Testing ordering of opening cache promises resolution +PASS Testing ordering of deleting cache promises resolution + Added: trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https.html (0 => 227768) --- trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https.html (rev 0) +++ trunk/LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https.html 2018-01-30 01:41:22 UTC (rev 227768) @@ -0,0 +1,33 @@ + + + +Cache Storage: testing open and delete in parallel + + +