[webkit-changes] [236101] trunk
Title: [236101] trunk Revision 236101 Author yusukesuz...@slowstart.org Date 2018-09-17 22:47:33 -0700 (Mon, 17 Sep 2018) Log Message [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t https://bugs.webkit.org/show_bug.cgi?id=185339 Patch by Yusuke Suzuki on 2018-09-17 Reviewed by Mark Lam. Source/WebCore: * fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::blobSize): * platform/cocoa/NetworkExtensionContentFilter.h: * platform/cocoa/NetworkExtensionContentFilter.mm: (WebCore::NetworkExtensionContentFilter::initialize): (WebCore::NetworkExtensionContentFilter::willSendRequest): (WebCore::NetworkExtensionContentFilter::responseReceived): (WebCore::NetworkExtensionContentFilter::addData): (WebCore::NetworkExtensionContentFilter::finishedAddingData): (WebCore::NetworkExtensionContentFilter::handleDecision): Use per-function BinarySemaphore instead of holding it in NetworkExtensionContentFilter's field. * platform/glib/FileMonitorGLib.cpp: (WebCore::FileMonitor::FileMonitor): (WebCore::FileMonitor::~FileMonitor): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange): (WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange): Use BinarySemaphore. And remove unused dispatch_semaphore_t. * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (-[WebAVStreamDataParserListener streamDataParserWillProvideContentKeyRequestInitializationData:forTrackID:]): (-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]): (WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC): (WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC): (WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID): (WebCore::SourceBufferPrivateAVFObjC::abort): (WebCore::SourceBufferPrivateAVFObjC::setCDMSession): (WebCore::SourceBufferPrivateAVFObjC::setCDMInstance): Use Box and Box. * platform/graphics/cocoa/WebCoreDecompressionSession.h: * platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::WebCoreDecompressionSession): Remove unused dispatch_semaphore_t. * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously): * platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp: (WebCore::getRunLoop): (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest): (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse): (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse): (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace): * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h: * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: (-[WebCoreResourceHandleAsOperationQueueDelegate initWithHandle:messageQueue:]): (-[WebCoreResourceHandleAsOperationQueueDelegate detachHandle]): (-[WebCoreResourceHandleAsOperationQueueDelegate dealloc]): (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]): Use BinarySemaphore instead. Source/WebKit: * Platform/IPC/Connection.cpp: (IPC::Connection::SyncMessageState::wait): * Shared/mac/SecItemShim.cpp: (WebKit::sendSecItemRequest): Use BinarySemaphore. * UIProcess/ResourceLoadStatisticsPersistentStorage.cpp: (WebKit::ResourceLoadStatisticsPersistentStorage::finishAllPendingWorkSynchronously): * UIProcess/WebStorage/StorageManager.cpp: (WebKit::StorageManager::applicationWillTerminate): * UIProcess/ios/WKActionSheetAssistant.mm: (appLinkForURL): Use BinarySemaphore to wait for async completion handler. We also fix memory leak since the old code does not call dispatch_release for the used semaphore. Source/WTF: This patch adds WTF::Semaphore, which is based on WTF::Lock and WTF::Condition. * WTF.xcodeproj/project.pbxproj: * wtf/CMakeLists.txt: * wtf/Semaphore.h: Added. (WTF::Semaphore::Semaphore): (WTF::Semaphore::signal): (WTF::Semaphore::waitUntil): (WTF::Semaphore::waitFor): (WTF::Semaphore::wait): * wtf/generic/WorkQueueGeneric.cpp: (WorkQueue::platformInitialize): * wtf/threads/BinarySemaphore.cpp: (WTF::BinarySemaphore::waitUntil):
[webkit-changes] [236100] trunk
Title: [236100] trunk
Revision 236100
Author simon.fra...@apple.com
Date 2018-09-17 21:14:39 -0700 (Mon, 17 Sep 2018)
Log Message
Many modern media control tests leak documents in testing
https://bugs.webkit.org/show_bug.cgi?id=189437
Reviewed by Darin Adler.
Source/WebCore:
In order to accurately detect leaks in media controls tests which use lots of
SVGImages, we have to:
- Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
to clear references to elements.
- Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
to drop the last handle to the CachedResource for an SVGImage.
- Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
to run again after that timer has fired.
This should fix most of the spurious leak reports involving SVGImage documents.
* page/MemoryRelease.cpp:
(WebCore::releaseCriticalMemory):
Source/WebKit:
In order to accurately detect leaks in media controls tests which use lots of
SVGImages, we have to:
- Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
to clear references to elements.
- Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
to drop the last handle to the CachedResource for an SVGImage.
- Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
to run again after that timer has fired.
This should fix most of the spurious leak reports involving SVGImage documents.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCallAfterTasksAndTimers):
(WKBundlePagePostTask): Deleted.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Tools:
In order to accurately detect leaks in media controls tests which use lots of
SVGImages, we have to:
- Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
to clear references to elements.
- Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
to drop the last handle to the CachedResource for an SVGImage.
- Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
to run again after that timer has fired.
This should fix most of the spurious leak reports involving SVGImage documents.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reportLiveDocuments):
(WTR::InjectedBundle::didReceiveMessageToPage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/MemoryRelease.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236099 => 236100)
--- trunk/Source/WebCore/ChangeLog 2018-09-18 02:54:37 UTC (rev 236099)
+++ trunk/Source/WebCore/ChangeLog 2018-09-18 04:14:39 UTC (rev 236100)
@@ -1,3 +1,24 @@
+2018-09-17 Simon Fraser
+
+Many modern media control tests leak documents in testing
+https://bugs.webkit.org/show_bug.cgi?id=189437
+
+Reviewed by Darin Adler.
+
+In order to accurately detect leaks in media controls tests which use lots of
+SVGImages, we have to:
+- Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
+ to clear references to elements.
+- Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
+ to drop the last handle to the CachedResource for an SVGImage.
+- Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
+ to run again after that timer has fired.
+
+This should fix most of the spurious leak reports involving SVGImage documents.
+
+* page/MemoryRelease.cpp:
+(WebCore::releaseCriticalMemory):
+
2018-09-17 Jer Noble
Add support for HEVC codec types in Media Capabilities
Modified: trunk/Source/WebCore/page/MemoryRelease.cpp (236099 => 236100)
--- trunk/Source/WebCore/page/MemoryRelease.cpp 2018-09-18 02:54:37 UTC (rev 236099)
+++ trunk/Source/WebCore/page/MemoryRelease.cpp 2018-09-18 04:14:39 UTC (rev 236100)
@@ -28,6 +28,7 @@
#include "CSSFontSelector.h"
#include "CSSValuePool.h"
+#include "CachedResourceLoader.h"
#include "Chrome.h"
#include "ChromeClient.h"
#include "CommonVM.h"
@@ -88,6 +89,7 @@
for (auto& document : copyToVectorOf>(Document::allDocuments())) {
document->styleScope().releaseMemory();
document->fontSelector().emptyCaches();
+document->cachedResourceLoader().garbageCollectDocumentResources();
}
GCController::singleton().deleteAllCode(JSC::DeleteAllCodeIfNotCollecting);
Modified:
[webkit-changes] [236099] trunk/Source/WebKitLegacy/win
Title: [236099] trunk/Source/WebKitLegacy/win
Revision 236099
Author hironori.fu...@sony.com
Date 2018-09-17 19:54:37 -0700 (Mon, 17 Sep 2018)
Log Message
[Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
https://bugs.webkit.org/show_bug.cgi?id=189612
Reviewed by Alex Christensen.
Non-trivial types can't be used as aruguments of LOG_ERROR and
ASSERT_WITH_MESSAGE.
* DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
static_cast to convert BString.
* WebLocalizableStrings.cpp:
(copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
char* by using 'key.utf8().data()'.
Modified Paths
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.cpp
trunk/Source/WebKitLegacy/win/WebLocalizableStrings.cpp
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (236098 => 236099)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-09-18 01:42:35 UTC (rev 236098)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-09-18 02:54:37 UTC (rev 236099)
@@ -1,3 +1,20 @@
+2018-09-17 Fujii Hironori
+
+[Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
+https://bugs.webkit.org/show_bug.cgi?id=189612
+
+Reviewed by Alex Christensen.
+
+Non-trivial types can't be used as aruguments of LOG_ERROR and
+ASSERT_WITH_MESSAGE.
+
+* DefaultPolicyDelegate.cpp:
+(DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
+static_cast to convert BString.
+* WebLocalizableStrings.cpp:
+(copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
+char* by using 'key.utf8().data()'.
+
2018-09-13 Ryan Haddad
Unreviewed, rolling out r235953.
Modified: trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.cpp (236098 => 236099)
--- trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.cpp 2018-09-18 01:42:35 UTC (rev 236098)
+++ trunk/Source/WebKitLegacy/win/DefaultPolicyDelegate.cpp 2018-09-18 02:54:37 UTC (rev 236099)
@@ -179,7 +179,7 @@
BString frameName;
frame->name();
-LOG_ERROR("called unableToImplementPolicyWithError:%S inFrame:%S", errorStr ? errorStr : TEXT(""), frameName ? frameName : TEXT(""));
+LOG_ERROR("called unableToImplementPolicyWithError:%S inFrame:%S", errorStr ? static_cast(errorStr) : TEXT(""), frameName ? static_cast(frameName) : TEXT(""));
return S_OK;
}
Modified: trunk/Source/WebKitLegacy/win/WebLocalizableStrings.cpp (236098 => 236099)
--- trunk/Source/WebKitLegacy/win/WebLocalizableStrings.cpp 2018-09-18 01:42:35 UTC (rev 236098)
+++ trunk/Source/WebKitLegacy/win/WebLocalizableStrings.cpp 2018-09-18 02:54:37 UTC (rev 236099)
@@ -161,7 +161,7 @@
CFStringRef result = CFCopyLocalizedStringWithDefaultValue(key.createCFString().get(), 0, bundle, notFound, 0);
-ASSERT_WITH_MESSAGE(result != notFound, "could not find localizable string %s in bundle", key);
+ASSERT_WITH_MESSAGE(result != notFound, "could not find localizable string %s in bundle", key.utf8().data());
return result;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236098] trunk/Source/WebKit
Title: [236098] trunk/Source/WebKit Revision 236098 Author m...@apple.com Date 2018-09-17 18:42:35 -0700 (Mon, 17 Sep 2018) Log Message Try to fix Apple internal builds with the iOS 12.0 SDK. * Configurations/WebKit.xcconfig: Disable framework header postprocessing for iOS 12.0. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/WebKit.xcconfig Diff Modified: trunk/Source/WebKit/ChangeLog (236097 => 236098) --- trunk/Source/WebKit/ChangeLog 2018-09-18 01:01:32 UTC (rev 236097) +++ trunk/Source/WebKit/ChangeLog 2018-09-18 01:42:35 UTC (rev 236098) @@ -1,3 +1,9 @@ +2018-09-17 Dan Bernstein + +Try to fix Apple internal builds with the iOS 12.0 SDK. + +* Configurations/WebKit.xcconfig: Disable framework header postprocessing for iOS 12.0. + 2018-09-17 Ryan Haddad Unreviewed, rolling out r236092 because it breaks internal builds. Also, remove stray '+' character from ChangeLog file. Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (236097 => 236098) --- trunk/Source/WebKit/Configurations/WebKit.xcconfig 2018-09-18 01:01:32 UTC (rev 236097) +++ trunk/Source/WebKit/Configurations/WebKit.xcconfig 2018-09-18 01:42:35 UTC (rev 236098) @@ -150,6 +150,7 @@ WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_MACOS_1014)); WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_MACOS_BEFORE_1014 = YES; WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*11.*] = YES; +WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*12.0*] = YES; WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS)); WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES = -Wl,-not_for_dyld_shared_cache; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236097] trunk/Source/WebKit
Title: [236097] trunk/Source/WebKit
Revision 236097
Author ryanhad...@apple.com
Date 2018-09-17 18:01:32 -0700 (Mon, 17 Sep 2018)
Log Message
Unreviewed, rolling out r236092 because it breaks internal builds. Also, remove stray '+' character from ChangeLog file.
* Scripts/copy-webcontent-resources-to-private-headers.sh: Removed.
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Removed Paths
trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh
Diff
Modified: trunk/Source/WebKit/ChangeLog (236096 => 236097)
--- trunk/Source/WebKit/ChangeLog 2018-09-18 00:54:48 UTC (rev 236096)
+++ trunk/Source/WebKit/ChangeLog 2018-09-18 01:01:32 UTC (rev 236097)
@@ -1,5 +1,12 @@
-+2018-08-17 Ben Richards
+2018-09-17 Ryan Haddad
+Unreviewed, rolling out r236092 because it breaks internal builds. Also, remove stray '+' character from ChangeLog file.
+
+* Scripts/copy-webcontent-resources-to-private-headers.sh: Removed.
+* WebKit.xcodeproj/project.pbxproj:
+
+2018-08-17 Ben Richards
+
Add script to generate WebContent service resource files and change XPC service main SPI to have it's own header
https://bugs.webkit.org/show_bug.cgi?id=188601
Deleted: trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh (236096 => 236097)
--- trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh 2018-09-18 00:54:48 UTC (rev 236096)
+++ trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh 2018-09-18 01:01:32 UTC (rev 236097)
@@ -1,59 +0,0 @@
-#!/bin/sh
-#
-# Copyright (C) 2018 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-#notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-#notice, this list of conditions and the following disclaimer in the
-#documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-# THE POSSIBILITY OF SUCH DAMAGE.
-
-set -e
-
-WEB_CONTENT_RESOURCES_PATH="${BUILT_PRODUCTS_DIR}/WebKit.framework/PrivateHeaders/CustomWebContentResources"
-mkdir -p "${WEB_CONTENT_RESOURCES_PATH}"
-
-echo "Copying WebContent entitlements to ${WEB_CONTENT_RESOURCES_PATH}"
-if [[ ${WK_PLATFORM_NAME} == "macosx" ]]; then
-ENTITLEMENTS_FILE="${TEMP_FILE_DIR}/${FULL_PRODUCT_NAME}.xcent"
-else
-ENTITLEMENTS_FILE="${SRCROOT}/Configurations/WebContent-iOS.entitlements"
-fi
-ditto "${ENTITLEMENTS_FILE}" "${WEB_CONTENT_RESOURCES_PATH}/WebContent.entitlements"
-
-echo "Copying WebContentProcess.xib to ${WEB_CONTENT_RESOURCES_PATH}"
-WEBCONTENT_XIB="${SRCROOT}/Resources/WebContentProcess.xib"
-ditto "${WEBCONTENT_XIB}" "${WEB_CONTENT_RESOURCES_PATH}/WebContentProcess.xib"
-
-echo "Copying Info.plist to ${WEB_CONTENT_RESOURCES_PATH}"
-PROCESSED_INFOPLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"
-UNPROCESSED_INFOPLIST="${INFOPLIST_FILE}"
-COPIED_INFOPLIST="${WEB_CONTENT_RESOURCES_PATH}/Info.plist"
-ditto "${UNPROCESSED_INFOPLIST}" "${COPIED_INFOPLIST}"
-
-echo "Setting fixed entry values for ${COPIED_INFOPLIST}"
-if [[ ${WK_PLATFORM_NAME} == "macosx" ]]; then
-FIXED_ENTRIES=( ":XPCService:RunLoopType" )
-else
-FIXED_ENTRIES=()
-fi
-
-for ((i = 0; i < ${#FIXED_ENTRIES[@]}; ++i)); do
-ENTRY_VALUE=$(/usr/libexec/PlistBuddy -c "Print ${FIXED_ENTRIES[$i]}" "${PROCESSED_INFOPLIST}")
-/usr/libexec/PlistBuddy -c "Set ${FIXED_ENTRIES[$i]} ${ENTRY_VALUE}" "${COPIED_INFOPLIST}"
-done
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (236096 => 236097)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-09-18 00:54:48 UTC (rev 236096)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-09-18 01:01:32 UTC (rev 236097)
@@ -3024,7 +3024,6 @@
414DEDD51F9EDDDF0047C40D /* ServiceWorkerProcessProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ServiceWorkerProcessProxy.h;
[webkit-changes] [236096] trunk/LayoutTests
Title: [236096] trunk/LayoutTests Revision 236096 Author ryanhad...@apple.com Date 2018-09-17 17:54:48 -0700 (Mon, 17 Sep 2018) Log Message Layout Test legacy-animation-engine/animations/play-state-in-shorthand.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=185651 Unreviewed test gardening. * platform/mac/TestExpectations: Mark test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236095 => 236096) --- trunk/LayoutTests/ChangeLog 2018-09-18 00:31:40 UTC (rev 236095) +++ trunk/LayoutTests/ChangeLog 2018-09-18 00:54:48 UTC (rev 236096) @@ -1,3 +1,12 @@ +2018-09-17 Ryan Haddad + +Layout Test legacy-animation-engine/animations/play-state-in-shorthand.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=185651 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: Mark test as flaky. + 2018-09-17 Justin Fan Updated expected test [ PASS ] messages for new test-harness format for webgl tests Modified: trunk/LayoutTests/platform/mac/TestExpectations (236095 => 236096) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-09-18 00:31:40 UTC (rev 236095) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-09-18 00:54:48 UTC (rev 236096) @@ -1768,4 +1768,4 @@ [ Mojave+ ] fast/gradients/conic-gradient-extended-stops.html [ Pass ] [ Mojave+ ] fast/gradients/conic-gradient.html [ Pass ] - +webkit.org/b/185651 legacy-animation-engine/animations/play-state-in-shorthand.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236094] trunk
Title: [236094] trunk
Revision 236094
Author jer.no...@apple.com
Date 2018-09-17 16:24:21 -0700 (Mon, 17 Sep 2018)
Log Message
Add support for HEVC codec types in Media Capabilities
https://bugs.webkit.org/show_bug.cgi?id=189565
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/hevc-codec-parameters.html
Add some utility methods for parsing HEVC codec strings, and using those parsed
values to query the platform for detailed support for HEVC decoding.
Drive-by fix: Modify MediaEngineConfigurationFactory to allow for null function
pointers in the encode/decode factory pair.
* Sources.txt:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/cocoa/VideoToolboxSoftLink.cpp:
* platform/cocoa/VideoToolboxSoftLink.h:
* platform/graphics/HEVCUtilities.cpp: Added.
(WebCore::parseHEVCCodecParameters):
* platform/graphics/HEVCUtilities.h: Added.
* platform/graphics/cocoa/HEVCUtilitiesCocoa.cpp: Added.
(WebCore::validateHEVCParameters):
* platform/graphics/cocoa/HEVCUtilitiesCocoa.h: Added.
* platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp: Added.
(WebCore::videoCodecTypeFromRFC4281Type):
(WebCore::createMediaPlayerDecodingConfigurationCocoa):
* platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.h: Added.
* platform/mediacapabilities/MediaEngineConfigurationFactory.cpp:
(WebCore::factories):
(WebCore::MediaEngineConfigurationFactory::createDecodingConfiguration):
(WebCore::MediaEngineConfigurationFactory::createEncodingConfiguration):
* testing/Internals.cpp:
(WebCore::Internals::parseHEVCCodecParameters):
* testing/Internals.h:
* testing/Internals.idl:
Source/WTF:
Extract the toIntegralType template into its own header.
* wtf/CMakeLists.txt:
* wtf/text/StringConversion.h: Added.
(isCharacterAllowedInBase):
(toIntegralType):
* wtf/text/WTFString.cpp:
LayoutTests:
* media/hevc-codec-parameters-expected.txt: Added.
* media/hevc-codec-parameters.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/text/WTFString.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/cocoa/VideoToolboxSoftLink.cpp
trunk/Source/WebCore/platform/cocoa/VideoToolboxSoftLink.h
trunk/Source/WebCore/platform/mediacapabilities/MediaEngineConfigurationFactory.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/media/hevc-codec-parameters-expected.txt
trunk/LayoutTests/media/hevc-codec-parameters.html
trunk/Source/WTF/wtf/text/StringToIntegerConversion.h
trunk/Source/WebCore/platform/graphics/HEVCUtilities.cpp
trunk/Source/WebCore/platform/graphics/HEVCUtilities.h
trunk/Source/WebCore/platform/graphics/cocoa/HEVCUtilitiesCocoa.cpp
trunk/Source/WebCore/platform/graphics/cocoa/HEVCUtilitiesCocoa.h
trunk/Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp
trunk/Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.h
Diff
Modified: trunk/LayoutTests/ChangeLog (236093 => 236094)
--- trunk/LayoutTests/ChangeLog 2018-09-17 23:21:49 UTC (rev 236093)
+++ trunk/LayoutTests/ChangeLog 2018-09-17 23:24:21 UTC (rev 236094)
@@ -1,3 +1,13 @@
+2018-09-17 Jer Noble
+
+Add support for HEVC codec types in Media Capabilities
+https://bugs.webkit.org/show_bug.cgi?id=189565
+
+Reviewed by Eric Carlson.
+
+* media/hevc-codec-parameters-expected.txt: Added.
+* media/hevc-codec-parameters.html: Added.
+
2018-09-17 Devin Rousso
Web Inspector: generate CSSKeywordCompletions from backend values
Added: trunk/LayoutTests/media/hevc-codec-parameters-expected.txt (0 => 236094)
--- trunk/LayoutTests/media/hevc-codec-parameters-expected.txt (rev 0)
+++ trunk/LayoutTests/media/hevc-codec-parameters-expected.txt 2018-09-17 23:24:21 UTC (rev 236094)
@@ -0,0 +1,9 @@
+EXPECTED (internals.parseHEVCCodecParameters("bad-parameter") == 'null') OK
+EXPECTED (internals.parseHEVCCodecParameters("hvc1") == 'null') OK
+EXPECTED (internals.parseHEVCCodecParameters("hev1.1.6.L93") === '{ 0, 1, 6, false, 93 }') OK
+EXPECTED (internals.parseHEVCCodecParameters("hev1.A4.41.H120") === '{ 1, 4, 65, true, 120 }') OK
+EXPECTED (internals.parseHEVCCodecParameters("hev1.B1.4.L63") === '{ 2, 1, 4, false, 63 }') OK
+EXPECTED (internals.parseHEVCCodecParameters("hev1.D1.4.L63") == 'null') OK
+EXPECTED (internals.parseHEVCCodecParameters("hev1.B1.4.L68000") == 'null') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/hevc-codec-parameters.html (0 => 236094)
--- trunk/LayoutTests/media/hevc-codec-parameters.html (rev 0)
+++ trunk/LayoutTests/media/hevc-codec-parameters.html 2018-09-17 23:24:21 UTC (rev
[webkit-changes] [236093] trunk/Source/ThirdParty/libwebrtc
Title: [236093] trunk/Source/ThirdParty/libwebrtc
Revision 236093
Author you...@apple.com
Date 2018-09-17 16:21:49 -0700 (Mon, 17 Sep 2018)
Log Message
Build fix after https://trac.webkit.org/changeset/236070
https://bugs.webkit.org/show_bug.cgi?id=189635
Unreviewed.
Fix for iOS internal builds.
* Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (236092 => 236093)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-09-17 23:00:54 UTC (rev 236092)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-09-17 23:21:49 UTC (rev 236093)
@@ -1,5 +1,17 @@
2018-09-17 Youenn Fablet
+Build fix after https://trac.webkit.org/changeset/236070
+https://bugs.webkit.org/show_bug.cgi?id=189635
+
+
+Unreviewed.
+Fix for iOS internal builds.
+
+* Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
+2018-09-17 Youenn Fablet
+
Enable VCP for iOS and reenable it for MacOS
https://bugs.webkit.org/show_bug.cgi?id=189635
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm (236092 => 236093)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm 2018-09-17 23:00:54 UTC (rev 236092)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm 2018-09-17 23:21:49 UTC (rev 236093)
@@ -603,7 +603,7 @@
pixelFormat = nullptr;
}
CFDictionaryRef encoderSpecs = nullptr;
-#if (!defined(WEBRTC_IOS) || ENABLE_VCP_ENCODER)
+#if !defined(WEBRTC_IOS)
auto useHardwareEncoder = webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse;
// Currently hw accl is supported above 360p on mac, below 360p
// the compression session will be created with hw accl disabled.
@@ -610,6 +610,10 @@
CFTypeRef sessionKeys[] = { kVTVideoEncoderSpecification_EnableHardwareAcceleratedVideoEncoder, kVTVideoEncoderSpecification_RequireHardwareAcceleratedVideoEncoder, kVTCompressionPropertyKey_RealTime };
CFTypeRef sessionValues[] = { useHardwareEncoder, useHardwareEncoder, kCFBooleanTrue };
encoderSpecs = CFDictionaryCreate(kCFAllocatorDefault, sessionKeys, sessionValues, 3, , );
+#else
+ CFTypeRef sessionKeys[] = { kVTCompressionPropertyKey_RealTime };
+ CFTypeRef sessionValues[] = { kCFBooleanTrue };
+ encoderSpecs = CFDictionaryCreate(kCFAllocatorDefault, sessionKeys, sessionValues, 1, , );
#endif
OSStatus status =
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236092] trunk/Source/WebKit
Title: [236092] trunk/Source/WebKit
Revision 236092
Author achristen...@apple.com
Date 2018-09-17 16:00:54 -0700 (Mon, 17 Sep 2018)
Log Message
+2018-08-17 Ben Richards
Add script to generate WebContent service resource files and change XPC service main SPI to have it's own header
https://bugs.webkit.org/show_bug.cgi?id=188601
Reviewed by Dan Bernstein.
Added a script to the process entitlements build phase of the WebContent service that copies resource
files to WebKit.framework/PrivateHeaders/CustomWebContentResources. These resource files are to
be used by clients who would like to make a custom WebContent service.
* Scripts/copy-webcontent-resources-to-private-headers.sh: Added.
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh
Diff
Modified: trunk/Source/WebKit/ChangeLog (236091 => 236092)
--- trunk/Source/WebKit/ChangeLog 2018-09-17 22:43:11 UTC (rev 236091)
+++ trunk/Source/WebKit/ChangeLog 2018-09-17 23:00:54 UTC (rev 236092)
@@ -1,3 +1,18 @@
++2018-08-17 Ben Richards
+
+Add script to generate WebContent service resource files and change XPC service main SPI to have it's own header
+https://bugs.webkit.org/show_bug.cgi?id=188601
+
+Reviewed by Dan Bernstein.
+
+Added a script to the process entitlements build phase of the WebContent service that copies resource
+files to WebKit.framework/PrivateHeaders/CustomWebContentResources. These resource files are to
+be used by clients who would like to make a custom WebContent service.
+
+* Scripts/copy-webcontent-resources-to-private-headers.sh: Added.
+* WebKit.xcodeproj/project.pbxproj:
+
+
2018-09-17 Simon Fraser
Add more Fullscreen logging
Added: trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh (0 => 236092)
--- trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh (rev 0)
+++ trunk/Source/WebKit/Scripts/copy-webcontent-resources-to-private-headers.sh 2018-09-17 23:00:54 UTC (rev 236092)
@@ -0,0 +1,59 @@
+#!/bin/sh
+#
+# Copyright (C) 2018 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+#notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+#notice, this list of conditions and the following disclaimer in the
+#documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+# THE POSSIBILITY OF SUCH DAMAGE.
+
+set -e
+
+WEB_CONTENT_RESOURCES_PATH="${BUILT_PRODUCTS_DIR}/WebKit.framework/PrivateHeaders/CustomWebContentResources"
+mkdir -p "${WEB_CONTENT_RESOURCES_PATH}"
+
+echo "Copying WebContent entitlements to ${WEB_CONTENT_RESOURCES_PATH}"
+if [[ ${WK_PLATFORM_NAME} == "macosx" ]]; then
+ENTITLEMENTS_FILE="${TEMP_FILE_DIR}/${FULL_PRODUCT_NAME}.xcent"
+else
+ENTITLEMENTS_FILE="${SRCROOT}/Configurations/WebContent-iOS.entitlements"
+fi
+ditto "${ENTITLEMENTS_FILE}" "${WEB_CONTENT_RESOURCES_PATH}/WebContent.entitlements"
+
+echo "Copying WebContentProcess.xib to ${WEB_CONTENT_RESOURCES_PATH}"
+WEBCONTENT_XIB="${SRCROOT}/Resources/WebContentProcess.xib"
+ditto "${WEBCONTENT_XIB}" "${WEB_CONTENT_RESOURCES_PATH}/WebContentProcess.xib"
+
+echo "Copying Info.plist to ${WEB_CONTENT_RESOURCES_PATH}"
+PROCESSED_INFOPLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"
+UNPROCESSED_INFOPLIST="${INFOPLIST_FILE}"
+COPIED_INFOPLIST="${WEB_CONTENT_RESOURCES_PATH}/Info.plist"
+ditto "${UNPROCESSED_INFOPLIST}" "${COPIED_INFOPLIST}"
+
+echo "Setting fixed entry values for ${COPIED_INFOPLIST}"
+if [[ ${WK_PLATFORM_NAME} == "macosx" ]]; then
+FIXED_ENTRIES=( ":XPCService:RunLoopType" )
+else
+FIXED_ENTRIES=()
+fi
+
+for ((i = 0; i < ${#FIXED_ENTRIES[@]}; ++i)); do
+ENTRY_VALUE=$(/usr/libexec/PlistBuddy -c "Print ${FIXED_ENTRIES[$i]}" "${PROCESSED_INFOPLIST}")
+
[webkit-changes] [236091] trunk
Title: [236091] trunk Revision 236091 Author drou...@apple.com Date 2018-09-17 15:43:11 -0700 (Mon, 17 Sep 2018) Log Message Web Inspector: generate CSSKeywordCompletions from backend values https://bugs.webkit.org/show_bug.cgi?id=189041 Reviewed by Joseph Pecoraro. Source/_javascript_Core: * inspector/protocol/CSS.json: Include an optional `aliases` array and `inherited` boolean for `CSSPropertyInfo`. Source/WebCore: Modified existing test inspector/css/getSupportedCSSProperties.html. * inspector/agents/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getSupportedCSSProperties): Send alias and longhand information for all properties, and any known keyword values for those applicable. This makes use of `CSSParserFastPaths::isValidKeywordPropertyAndValue` to determine if a given keyword is a valid value for each property. This only generates a list for properties who have no non-keyword values. * css/makeprop.pl: * css/makevalues.pl: Create additional helper functions/constants for retrieving strings of each CSS keyword. * css/CSSProperty.h: (WebCore::CSSProperty::aliasesForProperty): * css/CSSPrimitiveValue.cpp: (WebCore::valueName): * css/CSSValuePool.cpp: (WebCore::CSSValuePool::CSSValuePool): (WebCore::CSSValuePool::createIdentifierValue): Source/WebInspectorUI: Moves the longhands map to `WI.CSSKeywordCompletions` for more global access. Creates an aliases map to support completions on aliases with the same values as the non-alias name. Removes all keyword-only properties from `WI.CSSKeywordCompletions._propertyKeywordMap` as they are now generated by the backend (kept for compatibility). * UserInterface/Models/CSSCompletions.js: (WI.CSSCompletions): (WI.CSSCompletions.requestCSSCompletions.propertyNamesCallback): (WI.CSSCompletions.prototype.isShorthandPropertyName): * UserInterface/Models/CSSKeywordCompletions.js: (WI.CSSKeywordCompletions.forProperty.addKeywordsForName): Added. (WI.CSSKeywordCompletions.forProperty): (WI.CSSKeywordCompletions.addCustomCompletions): * UserInterface/Models/CSSProperty.js: (WI.CSSProperty.isInheritedPropertyName): LayoutTests: * inspector/css/getSupportedCSSProperties-expected.txt: * inspector/css/getSupportedCSSProperties.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt trunk/LayoutTests/inspector/css/getSupportedCSSProperties.html trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/protocol/CSS.json trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValue.cpp trunk/Source/WebCore/css/CSSProperty.h trunk/Source/WebCore/css/CSSValuePool.cpp trunk/Source/WebCore/css/makeprop.pl trunk/Source/WebCore/css/makevalues.pl trunk/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js Diff Modified: trunk/LayoutTests/ChangeLog (236090 => 236091) --- trunk/LayoutTests/ChangeLog 2018-09-17 22:22:15 UTC (rev 236090) +++ trunk/LayoutTests/ChangeLog 2018-09-17 22:43:11 UTC (rev 236091) @@ -1,3 +1,13 @@ +2018-09-17 Devin Rousso + +Web Inspector: generate CSSKeywordCompletions from backend values +https://bugs.webkit.org/show_bug.cgi?id=189041 + +Reviewed by Joseph Pecoraro. + +* inspector/css/getSupportedCSSProperties-expected.txt: +* inspector/css/getSupportedCSSProperties.html: + 2018-09-17 Youenn Fablet track.onmute isn't called for a remote MediaStreamTrack when its counter part track is removed from the peer connection Modified: trunk/LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt (236090 => 236091) --- trunk/LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt 2018-09-17 22:22:15 UTC (rev 236090) +++ trunk/LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt 2018-09-17 22:43:11 UTC (rev 236091) @@ -1,2 +1,32 @@ -box-shadow is supported +"box-sizing" is supported +"box-sizing" has aliases: + - "-webkit-box-sizing" +"box-sizing" has keyword values: + - "border-box" + - "content-box" +"filter" is supported +"filter" has aliases: + - "-webkit-filter" + +"font-style" is supported +"font-style" is inherited + +"margin" is supported +"margin" has longhands: + - "margin-top" + - "margin-right" + - "margin-bottom" + - "margin-left" + +"text-transform" is supported +"text-transform" has aliases: + - "-epub-text-transform" +"text-transform" is inherited +"text-transform" has keyword values: + - "none" + - "capitalize" + - "uppercase" + - "lowercase" + + Modified: trunk/LayoutTests/inspector/css/getSupportedCSSProperties.html (236090 => 236091) --- trunk/LayoutTests/inspector/css/getSupportedCSSProperties.html 2018-09-17 22:22:15 UTC (rev 236090) +++
[webkit-changes] [236090] trunk
Title: [236090] trunk Revision 236090 Author you...@apple.com Date 2018-09-17 15:22:15 -0700 (Mon, 17 Sep 2018) Log Message track.onmute isn't called for a remote MediaStreamTrack when its counter part track is removed from the peer connection https://bugs.webkit.org/show_bug.cgi?id=176281 Reviewed by Eric Carlson. Source/WebCore: Listen to libwebrtc remove track callbacks. Implement handling as per https://w3c.github.io/webrtc-pc/#process-remote-track-removal. This triggers a mute event on the track. Test: webrtc/remove-track.html * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::removeRemoteTrack): (WebCore::LibWebRTCMediaEndpoint::OnRemoveTrack): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::LibWebRTCPeerConnectionBackend::shouldOfferAllowToReceive const): Drive by fix: Plan B code path does not mandate having an rtc backend for each sender. LayoutTests: * webrtc/remove-track-expected.txt: Added. * webrtc/remove-track.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp Added Paths trunk/LayoutTests/webrtc/remove-track-expected.txt trunk/LayoutTests/webrtc/remove-track.html Diff Modified: trunk/LayoutTests/ChangeLog (236089 => 236090) --- trunk/LayoutTests/ChangeLog 2018-09-17 22:21:32 UTC (rev 236089) +++ trunk/LayoutTests/ChangeLog 2018-09-17 22:22:15 UTC (rev 236090) @@ -1,3 +1,14 @@ +2018-09-17 Youenn Fablet + +track.onmute isn't called for a remote MediaStreamTrack when its counter part track is removed from the peer connection +https://bugs.webkit.org/show_bug.cgi?id=176281 + + +Reviewed by Eric Carlson. + +* webrtc/remove-track-expected.txt: Added. +* webrtc/remove-track.html: Added. + 2018-09-17 Dawei Fenton Fixed typo in TestExpectations file. Added: trunk/LayoutTests/webrtc/remove-track-expected.txt (0 => 236090) --- trunk/LayoutTests/webrtc/remove-track-expected.txt (rev 0) +++ trunk/LayoutTests/webrtc/remove-track-expected.txt 2018-09-17 22:22:15 UTC (rev 236090) @@ -0,0 +1,5 @@ + +PASS Setup audio video exchange +PASS Remove video track +PASS Remove audio track + Added: trunk/LayoutTests/webrtc/remove-track.html (0 => 236090) --- trunk/LayoutTests/webrtc/remove-track.html (rev 0) +++ trunk/LayoutTests/webrtc/remove-track.html 2018-09-17 22:22:15 UTC (rev 236090) @@ -0,0 +1,72 @@ + + + + +Testing basic video exchange from offerer to receiver + + +