[webkit-changes] [242411] trunk/Source/WebKit
Title: [242411] trunk/Source/WebKit Revision 242411 Author beid...@apple.com Date 2019-03-04 23:55:27 -0800 (Mon, 04 Mar 2019) Log Message Unreviewed, rolling out r242376. Broke some tests Reverted changeset: "Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs." https://bugs.webkit.org/show_bug.cgi?id=195291 https://trac.webkit.org/changeset/242376 Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (242410 => 242411) --- trunk/Source/WebKit/ChangeLog 2019-03-05 04:27:58 UTC (rev 242410) +++ trunk/Source/WebKit/ChangeLog 2019-03-05 07:55:27 UTC (rev 242411) @@ -1,3 +1,16 @@ +2019-03-04 Brady Eidson + +Unreviewed, rolling out r242376. + +Broke some tests + +Reverted changeset: + +"Correctly handle sandbox extensions when the same WKWebView +loads multiple file:// URLs." +https://bugs.webkit.org/show_bug.cgi?id=195291 +https://trac.webkit.org/changeset/242376 + 2019-03-04 Fujii Hironori Use a SQLite database to hold the ResourceLoadStatistics data Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (242410 => 242411) --- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-03-05 04:27:58 UTC (rev 242410) +++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-03-05 07:55:27 UTC (rev 242411) @@ -4412,7 +4412,7 @@ if (!documentLoader || !provisionalDocumentLoader) return false; -if (documentLoader->url().isLocalFile() && provisionalDocumentLoader->url().isLocalFile() && equalIgnoringQueryAndFragment(documentLoader->url(), provisionalDocumentLoader->url())) +if (documentLoader->url().isLocalFile() && provisionalDocumentLoader->url().isLocalFile()) return true; return false; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [242410] trunk/Source/WebInspectorUI
Title: [242410] trunk/Source/WebInspectorUI
Revision 242410
Author commit-qu...@webkit.org
Date 2019-03-04 20:27:58 -0800 (Mon, 04 Mar 2019)
Log Message
Web Inspector: Reload actions from second level inspector should properly reload the inspected inspector
https://bugs.webkit.org/show_bug.cgi?id=195306
Patch by Joseph Pecoraro on 2019-03-04
Reviewed by Matt Baker.
* UserInterface/Base/Main.js:
Provide a better reload for a Nth level inspector.
* UserInterface/Debug/Bootstrap.js:
(WI.runBootstrapOperations):
Simplify, should not need to check for InspectorFrontendHost.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242409 => 242410)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-05 04:24:44 UTC (rev 242409)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-05 04:27:58 UTC (rev 242410)
@@ -1,5 +1,19 @@
2019-03-04 Joseph Pecoraro
+Web Inspector: Reload actions from second level inspector should properly reload the inspected inspector
+https://bugs.webkit.org/show_bug.cgi?id=195306
+
+Reviewed by Matt Baker.
+
+* UserInterface/Base/Main.js:
+Provide a better reload for a Nth level inspector.
+
+* UserInterface/Debug/Bootstrap.js:
+(WI.runBootstrapOperations):
+Simplify, should not need to check for InspectorFrontendHost.
+
+2019-03-04 Joseph Pecoraro
+
Web Inspector: MediaSource logging not initialized properly
https://bugs.webkit.org/show_bug.cgi?id=195307
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (242409 => 242410)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-03-05 04:24:44 UTC (rev 242409)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-03-05 04:27:58 UTC (rev 242410)
@@ -2260,19 +2260,25 @@
this.archiveMainFrame();
};
+WI._reloadInspectedInspector = function()
+{
+const options = {};
+WI.runtimeManager.evaluateInInspectedWindow(`InspectorFrontendHost.reopen()`, options, function(){});
+};
+
WI._reloadPage = function(event)
{
if (!window.PageAgent)
return;
-PageAgent.reload();
event.preventDefault();
-};
-WI._reloadToolbarButtonClicked = function(event)
-{
-// Reload page from origin if the button is clicked while the shift key is pressed down.
-PageAgent.reload.invoke({ignoreCache: this.modifierKeys.shiftKey});
+if (InspectorFrontendHost.inspectionLevel() > 1) {
+WI._reloadInspectedInspector();
+return;
+}
+
+PageAgent.reload();
};
WI._reloadPageFromOrigin = function(event)
@@ -2280,10 +2286,27 @@
if (!window.PageAgent)
return;
+event.preventDefault();
+
+if (InspectorFrontendHost.inspectionLevel() > 1) {
+WI._reloadInspectedInspector();
+return;
+}
+
PageAgent.reload.invoke({ignoreCache: true});
-event.preventDefault();
};
+WI._reloadToolbarButtonClicked = function(event)
+{
+if (InspectorFrontendHost.inspectionLevel() > 1) {
+WI._reloadInspectedInspector();
+return;
+}
+
+// Reload page from origin if the button is clicked while the shift key is pressed down.
+PageAgent.reload.invoke({ignoreCache: this.modifierKeys.shiftKey});
+};
+
WI._updateReloadToolbarButton = function()
{
if (!window.PageAgent) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js (242409 => 242410)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2019-03-05 04:24:44 UTC (rev 242409)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js 2019-03-05 04:27:58 UTC (rev 242410)
@@ -103,7 +103,7 @@
applyDumpMessagesState(dumpMessagesCurrentState());
// Next Level Inspector.
-let inspectionLevel = InspectorFrontendHost ? InspectorFrontendHost.inspectionLevel() : 1;
+let inspectionLevel = InspectorFrontendHost.inspectionLevel();
const inspectInspectorToolTip = WI.unlocalizedString("Open Web Inspector [%d]").format(inspectionLevel + 1);
let inspectInspectorToolbarItem = new WI.ButtonToolbarItem("inspect-inspector", inspectInspectorToolTip);
WI.toolbar.addToolbarItem(inspectInspectorToolbarItem, WI.Toolbar.Section.CenterRight);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [242409] trunk/Source/WebKit
Title: [242409] trunk/Source/WebKit
Revision 242409
Author hironori.fu...@sony.com
Date 2019-03-04 20:24:44 -0800 (Mon, 04 Mar 2019)
Log Message
Use a SQLite database to hold the ResourceLoadStatistics data
https://bugs.webkit.org/show_bug.cgi?id=194867
Unreviewed build fix for WinCairo.
ResourceLoadStatisticsDebug and RELEASE_LOG_INFO_IF are not
defined because WinCairo port defines RELEASE_LOG_DISABLED.
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess): Enclosed RELEASE_LOG_INFO_IF with #if !RELEASE_LOG_DISABLED.
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccessUnderOpener): Ditto.
(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlocking): Ditto.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (242408 => 242409)
--- trunk/Source/WebKit/ChangeLog 2019-03-05 04:22:08 UTC (rev 242408)
+++ trunk/Source/WebKit/ChangeLog 2019-03-05 04:24:44 UTC (rev 242409)
@@ -1,3 +1,19 @@
+2019-03-04 Fujii Hironori
+
+Use a SQLite database to hold the ResourceLoadStatistics data
+https://bugs.webkit.org/show_bug.cgi?id=194867
+
+
+Unreviewed build fix for WinCairo.
+
+ResourceLoadStatisticsDebug and RELEASE_LOG_INFO_IF are not
+defined because WinCairo port defines RELEASE_LOG_DISABLED.
+
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess): Enclosed RELEASE_LOG_INFO_IF with #if !RELEASE_LOG_DISABLED.
+(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccessUnderOpener): Ditto.
+(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlocking): Ditto.
+
2019-03-04 Brent Fulgham
Use a SQLite database to hold the ResourceLoadStatistics data
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (242408 => 242409)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2019-03-05 04:22:08 UTC (rev 242408)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2019-03-05 04:24:44 UTC (rev 242409)
@@ -734,12 +734,16 @@
switch (cookieTreatmentForOrigin(subFrameDomain)) {
case CookieTreatmentResult::BlockAndPurge: {
+#if !RELEASE_LOG_DISABLED
RELEASE_LOG_INFO_IF(debugLoggingEnabled(), ResourceLoadStatisticsDebug, "Cannot grant storage access to %{public}s since its cookies are blocked in third-party contexts and it has not received user interaction as first-party.", subFrameDomain.string().utf8().data());
+#endif
completionHandler(StorageAccessStatus::CannotRequestAccess);
}
return;
case CookieTreatmentResult::BlockAndKeep: {
+#if !RELEASE_LOG_DISABLED
RELEASE_LOG_INFO_IF(debugLoggingEnabled(), ResourceLoadStatisticsDebug, "No need to grant storage access to %{public}s since its cookies are not blocked in third-party contexts.", subFrameDomain.string().utf8().data());
+#endif
completionHandler(StorageAccessStatus::HasAccess);
}
return;
@@ -750,13 +754,17 @@
auto userWasPromptedEarlier = promptEnabled && hasUserGrantedStorageAccessThroughPrompt(subFrameStatus.second, topFrameDomain);
if (promptEnabled && !userWasPromptedEarlier) {
+#if !RELEASE_LOG_DISABLED
RELEASE_LOG_INFO_IF(debugLoggingEnabled(), ResourceLoadStatisticsDebug, "About to ask the user whether they want to grant storage access to %{public}s under %{public}s or not.", subFrameDomain.string().utf8().data(), topFrameDomain.string().utf8().data());
+#endif
completionHandler(StorageAccessStatus::RequiresUserPrompt);
return;
}
+#if !RELEASE_LOG_DISABLED
if (userWasPromptedEarlier)
RELEASE_LOG_INFO_IF(debugLoggingEnabled(), ResourceLoadStatisticsDebug, "Storage access was granted to %{public}s under %{public}s.", subFrameDomain.string().utf8().data(), topFrameDomain.string().utf8().data());
+#endif
SQLiteStatement incrementStorageAccess(m_database, makeString("UPDATE ObservedDomains SET timesAccessedAsFirstPartyDueToStorageAccessAPI = timesAccessedAsFirstPartyDueToStorageAccessAPI + 1 WHERE domainID = ", String::number(subFrameStatus.second)));
if (incrementStorageAccess.prepare() != SQLITE_OK
@@ -783,7 +791,9 @@
if (cookieTreatmentForOrigin(domainInNeedOfStorageAccess) != CookieTreatmentResult::Allow)
return;
+#if !RELEASE_LOG_DISABLED
RELEASE_LOG_INFO_IF(debugLoggingEnabled(), ResourceLoadStatisticsDebug, "[Temporary combatibility fix] Storage access was granted for %{public}s under opener page from %{public}s, with user interaction in the opened window.", domainInNeedOfStorageAccess.string().utf8().data(),
[webkit-changes] [242408] trunk/Source/WebInspectorUI
Title: [242408] trunk/Source/WebInspectorUI
Revision 242408
Author commit-qu...@webkit.org
Date 2019-03-04 20:22:08 -0800 (Mon, 04 Mar 2019)
Log Message
Web Inspector: MediaSource logging not initialized properly
https://bugs.webkit.org/show_bug.cgi?id=195307
Patch by Joseph Pecoraro on 2019-03-04
Reviewed by Matt Baker.
* UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.initializeLogChannels):
Typo caused undefined to be included and trigger assertions.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242407 => 242408)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-05 04:00:21 UTC (rev 242407)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-05 04:22:08 UTC (rev 242408)
@@ -1,3 +1,14 @@
+2019-03-04 Joseph Pecoraro
+
+Web Inspector: MediaSource logging not initialized properly
+https://bugs.webkit.org/show_bug.cgi?id=195307
+
+Reviewed by Matt Baker.
+
+* UserInterface/Controllers/ConsoleManager.js:
+(WI.ConsoleManager.prototype.initializeLogChannels):
+Typo caused undefined to be included and trigger assertions.
+
2019-03-04 Devin Rousso
Web Inspector: CSS: class input isn't fully centered
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js (242407 => 242408)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js 2019-03-05 04:00:21 UTC (rev 242407)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js 2019-03-05 04:22:08 UTC (rev 242408)
@@ -174,7 +174,7 @@
if (this._loggingChannelSources.length)
return;
-this._loggingChannelSources = [WI.ConsoleMessage.MessageSource.Media, WI.ConsoleMessage.MessageSource.WebRTC, WI.ConsoleMessage.MessageSource.MessageSource];
+this._loggingChannelSources = [WI.ConsoleMessage.MessageSource.Media, WI.ConsoleMessage.MessageSource.WebRTC, WI.ConsoleMessage.MessageSource.MediaSource];
target.ConsoleAgent.getLoggingChannels((error, channels) => {
if (error)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [242407] trunk/Source/WebCore
Title: [242407] trunk/Source/WebCore
Revision 242407
Author justin_...@apple.com
Date 2019-03-04 20:00:21 -0800 (Mon, 04 Mar 2019)
Log Message
Unreviewed build fix for High Sierra.
* platform/graphics/gpu/cocoa/GPUBufferMetal.mm: Should fix "global constructor" error.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (242406 => 242407)
--- trunk/Source/WebCore/ChangeLog 2019-03-05 03:00:29 UTC (rev 242406)
+++ trunk/Source/WebCore/ChangeLog 2019-03-05 04:00:21 UTC (rev 242407)
@@ -1,3 +1,9 @@
+2019-03-04 Justin Fan
+
+Unreviewed build fix for High Sierra.
+
+* platform/graphics/gpu/cocoa/GPUBufferMetal.mm: Should fix "global constructor" error.
+
2019-03-04 Brent Fulgham
Use a SQLite database to hold the ResourceLoadStatistics data
Modified: trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm (242406 => 242407)
--- trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm 2019-03-05 03:00:29 UTC (rev 242406)
+++ trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm 2019-03-05 04:00:21 UTC (rev 242407)
@@ -39,7 +39,7 @@
namespace WebCore {
-static const auto readOnlyFlags = OptionSet { GPUBufferUsage::Flags::Index, GPUBufferUsage::Flags::Vertex, GPUBufferUsage::Flags::Uniform, GPUBufferUsage::Flags::TransferSource };
+static constexpr auto readOnlyFlags = OptionSet { GPUBufferUsage::Flags::Index, GPUBufferUsage::Flags::Vertex, GPUBufferUsage::Flags::Uniform, GPUBufferUsage::Flags::TransferSource };
bool GPUBuffer::validateBufferUsage(const GPUDevice& device, OptionSet usage)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [242405] trunk/Source/WebInspectorUI
Title: [242405] trunk/Source/WebInspectorUI
Revision 242405
Author drou...@apple.com
Date 2019-03-04 17:34:16 -0800 (Mon, 04 Mar 2019)
Log Message
Web Inspector: CSS: class input isn't fully centered
https://bugs.webkit.org/show_bug.cgi?id=195297
Reviewed by Matt Baker.
* UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input): Deleted.
(body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input): Deleted.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242404 => 242405)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-05 00:55:15 UTC (rev 242404)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-05 01:34:16 UTC (rev 242405)
@@ -1,5 +1,17 @@
2019-03-04 Devin Rousso
+Web Inspector: CSS: class input isn't fully centered
+https://bugs.webkit.org/show_bug.cgi?id=195297
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:
+(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
+(body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input): Deleted.
+(body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input): Deleted.
+
+2019-03-04 Devin Rousso
+
Web Inspector: Audit: show the version number in the UI
https://bugs.webkit.org/show_bug.cgi?id=195292
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css (242404 => 242405)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css 2019-03-05 00:55:15 UTC (rev 242404)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.css 2019-03-05 01:34:16 UTC (rev 242405)
@@ -151,7 +151,6 @@
overflow-y: scroll;
}
-/* FIXME: Elements with the "hidden" attribute still show up if "display: flex;" */
.sidebar > .panel.details.css-style > .content ~ .class-list-container[hidden] {
display: none;
}
@@ -165,18 +164,8 @@
flex-grow: 1;
height: 18px;
margin: 0;
-
---panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start: 2px;
}
-body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input {
-margin-left: var(--panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start);
-}
-
-body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input {
-margin-right: var(--panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start);
-}
-
.sidebar > .panel.details.css-style > .content ~ .class-list-container > *:matches(.new-class, .class-toggle) {
margin: 1px 3px;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [242404] trunk
Title: [242404] trunk Revision 242404 Author justin_...@apple.com Date 2019-03-04 16:55:15 -0800 (Mon, 04 Mar 2019) Log Message [Web GPU] Blitting function prototypes https://bugs.webkit.org/show_bug.cgi?id=195224 Reviewed by Dean Jackson. Source/WebCore: Implement barebones GPUCommandBuffer::copy* prototypes while rounding out GPUTexture implementation details. Test: webgpu/blit-commands.html * Modules/webgpu/GPUOrigin3D.h: Added. * Modules/webgpu/GPUOrigin3D.idl: Added. * Modules/webgpu/WebGPUCommandBuffer.cpp: Add copy view struct implementations. (WebCore::WebGPUBufferCopyView::asGPUBufferCopyView const): Added. (WebCore::WebGPUTextureCopyView::asGPUTextureCopyView const): Added. (WebCore::WebGPUCommandBuffer::copyBufferToBuffer): Added. (WebCore::WebGPUCommandBuffer::copyBufferToTexture): Added. (WebCore::WebGPUCommandBuffer::copyTextureToBuffer): Added. (WebCore::WebGPUCommandBuffer::copyTextureToTexture): Added. * Modules/webgpu/WebGPUCommandBuffer.h: Add new functions and supporting structs. * Modules/webgpu/WebGPUCommandBuffer.idl: Ditto. * Modules/webgpu/WebGPURenderPassDescriptor.cpp: Refactor constructors to copy the entire base class. (WebCore::GPURenderPassColorAttachmentDescriptor::GPURenderPassColorAttachmentDescriptor): (WebCore::GPURenderPassDepthStencilAttachmentDescriptor::GPURenderPassDepthStencilAttachmentDescriptor): (WebCore::WebGPURenderPassDescriptor::asGPURenderPassDescriptor const): (WebCore::attachment): Deleted. * Modules/webgpu/WebGPUTexture.h: (WebCore::WebGPUTexture::texture const): Added. * platform/graphics/gpu/GPUBuffer.h: (WebCore::GPUBuffer::byteLength const): Added. (WebCore::GPUBuffer::isTransferSource const): Added. (WebCore::GPUBuffer::isTransferDestination const): Renamed from isTransferDst. Refactored for OptionSet API. (WebCore::GPUBuffer::isVertex const): Ditto. (WebCore::GPUBuffer::isUniform const): Ditto. (WebCore::GPUBuffer::isStorage const): Ditto. (WebCore::GPUBuffer::isMappable const): Ditto. (WebCore::GPUBuffer::isMapWrite const): Ditto. (WebCore::GPUBuffer::isMapRead const): Ditto. * platform/graphics/gpu/GPUBufferUsage.h: Refactored for better bit flag style. * platform/graphics/gpu/GPUCommandBuffer.h: (WebCore::GPUCommandBuffer::blitEncoder const): Added. * platform/graphics/gpu/GPURenderPassDescriptor.h: * platform/graphics/gpu/GPUTexture.h: Cache usage flags for reference. (WebCore::GPUTexture::isTransferSrc const): Added. (WebCore::GPUTexture::isTransferDst const): Added. (WebCore::GPUTexture::isOutputAttachment const): Added. * platform/graphics/gpu/GPUTextureUsage.h: Refactor to match GPUBufferUsage.h. * platform/graphics/gpu/cocoa/GPUBufferMetal.mm: (WebCore::GPUBuffer::validateBufferUsage): Renamed from validateBufferCreate, refactored for OptionSet. (WebCore::GPUBuffer::tryCreate): (WebCore::GPUBuffer::GPUBuffer): (WebCore::GPUBuffer::isReadOnly const): (WebCore::GPUBuffer::setSubData): Add alignment check according to Metal docs. * platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm: (WebCore::GPUCommandBuffer::create): No need to use this alias here. (WebCore::GPUCommandBuffer::GPUCommandBuffer): Ditto. (WebCore::GPUCommandBuffer::copyBufferToBuffer): Added. (WebCore::GPUCommandBuffer::copyBufferToTexture): Added. (WebCore::GPUCommandBuffer::copyTextureToBuffer): Added. (WebCore::GPUCommandBuffer::copyTextureToTexture): Added. * platform/graphics/gpu/cocoa/GPUQueueMetal.mm: (WebCore::GPUQueue::submit): End encoding on the MTLCommandBuffer's blitCommandEncoder if it was used. * platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm: (WebCore::GPUSwapChain::getNextTexture): Now provide usage flags to texture creation. * platform/graphics/gpu/cocoa/GPUTextureMetal.mm: (WebCore::mtlTextureUsageForGPUTextureUsageFlags): Refactor validation. (WebCore::tryCreateMtlTextureDescriptor): Ditto. (WebCore::GPUTexture::tryCreate): Now provide usage flags to texture creation. (WebCore::GPUTexture::create): Ditto. (WebCore::GPUTexture::GPUTexture): Ditto. (WebCore::GPUTexture::createDefaultTextureView): Ditto. LayoutTests: Add basic test to copy data with all new blitting functions and verify the result. * webgpu/blit-commands-expected.html: Added. * webgpu/blit-commands.html: Added. * webgpu/buffer-command-buffer-races.html: Fixed typo. * webgpu/resources/green-400.png: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/webgpu/buffer-command-buffer-races.html trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources-input.xcfilelist trunk/Source/WebCore/DerivedSources-output.xcfilelist trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.h trunk/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.idl trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.cpp trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.h trunk/Source/WebCore/Sources.txt
[webkit-changes] [242403] trunk
Title: [242403] trunk
Revision 242403
Author za...@apple.com
Date 2019-03-04 16:43:41 -0800 (Mon, 04 Mar 2019)
Log Message
[ContentChangeObserver] Introduce fixed duration content observation
https://bugs.webkit.org/show_bug.cgi?id=195295
Reviewed by Simon Fraser.
Source/WebCore:
Some pages have a runloop-like scheduling setup where the content triggering change happens at a nested timer firing.
This patch helps finding cases like that using a 32ms long fixed window. Currently nested timers get dropped on the floor and
we stop observing for content changes before they even get fired.
Test: fast/events/touch/ios/visibility-change-happens-on-timer-hops.html
* page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::ContentChangeObserver):
(WebCore::ContentChangeObserver::startContentObservationForDuration):
(WebCore::ContentChangeObserver::stopDurationBasedContentObservation):
(WebCore::ContentChangeObserver::hasDeterminateState const):
(WebCore::ContentChangeObserver::adjustObservedState):
* page/ios/ContentChangeObserver.h:
(WebCore::ContentChangeObserver::isObservingContentChanges const):
(WebCore::ContentChangeObserver::hasPendingActivity const):
Source/WebKit:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
LayoutTests:
* fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt: Added.
* fast/events/touch/ios/visibility-change-happens-on-timer-hops.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp
trunk/Source/WebCore/page/ios/ContentChangeObserver.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Added Paths
trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt
trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops.html
Diff
Modified: trunk/LayoutTests/ChangeLog (242402 => 242403)
--- trunk/LayoutTests/ChangeLog 2019-03-05 00:42:33 UTC (rev 242402)
+++ trunk/LayoutTests/ChangeLog 2019-03-05 00:43:41 UTC (rev 242403)
@@ -1,3 +1,14 @@
+2019-03-04 Zalan Bujtas
+
+[ContentChangeObserver] Introduce fixed duration content observation
+https://bugs.webkit.org/show_bug.cgi?id=195295
+
+
+Reviewed by Simon Fraser.
+
+* fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt: Added.
+* fast/events/touch/ios/visibility-change-happens-on-timer-hops.html: Added.
+
2019-03-04 Wenson Hsieh
Native text selection UI is incorrectly suppressed in Microsoft Visio
Added: trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt (0 => 242403)
--- trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt 2019-03-05 00:43:41 UTC (rev 242403)
@@ -0,0 +1,2 @@
+PASS if 'clicked' text is not shown below.
+
Added: trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops.html (0 => 242403)
--- trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/visibility-change-happens-on-timer-hops.html 2019-03-05 00:43:41 UTC (rev 242403)
@@ -0,0 +1,66 @@
+
+
+This tests the case when nested timers trigger visible content change
+
+#tapthis {
+width: 400px;
+height: 400px;
+border: 1px solid green;
+}
+
+#becomesVisible {
+visibility: hidden;
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+