[webkit-changes] [258541] trunk

2020-03-16 Thread simon . fraser 
Title: [258541] trunk








Revision 258541
Author simon.fra...@apple.com
Date 2020-03-16 22:27:00 -0700 (Mon, 16 Mar 2020)


Log Message
Remove the zero-delay ScrollingCoordinatorMac commit timer
https://bugs.webkit.org/show_bug.cgi?id=209164

Reviewed by Zalan Bujtas.

Source/WebCore:

The scrolling tree on macOS should just commit at rendering update time. There's no need
for a separate zero-delay timer.

Tested by existing tests.

* page/scrolling/mac/ScrollingCoordinatorMac.h:
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::pageDestroyed):
(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorMac::commitTreeState): Deleted.

LayoutTests:

Dumping layers just made this test flakey. It's enough to test for scroll events on the overflow.

* tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt:
* tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (258540 => 258541)

--- trunk/LayoutTests/ChangeLog	2020-03-17 05:22:41 UTC (rev 258540)
+++ trunk/LayoutTests/ChangeLog	2020-03-17 05:27:00 UTC (rev 258541)
@@ -1,3 +1,15 @@
+2020-03-16  Simon Fraser  
+
+Remove the zero-delay ScrollingCoordinatorMac commit timer
+https://bugs.webkit.org/show_bug.cgi?id=209164
+
+Reviewed by Zalan Bujtas.
+
+Dumping layers just made this test flakey. It's enough to test for scroll events on the overflow.
+
+* tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt:
+* tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html:
+
 2020-03-16  Lauro Moura  
 
 WPE and GTK gardening.


Modified: trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt (258540 => 258541)

--- trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt	2020-03-17 05:22:41 UTC (rev 258540)
+++ trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt	2020-03-17 05:27:00 UTC (rev 258541)
@@ -53,26 +53,4 @@
 
 TEST COMPLETE
 PASS Scrollable div did not receive wheel events.
-(GraphicsLayer
-  (anchor 0.00 0.00)
-  (bounds 2008.00 2266.00)
-  (visible rect 0.00, 70.00 785.00 x 585.00)
-  (coverage rect 0.00, 70.00 785.00 x 585.00)
-  (intersects coverage rect 1)
-  (contentsScale 1.00)
-  (children 1
-(GraphicsLayer
-  (bounds 2008.00 2266.00)
-  (contentsOpaque 1)
-  (visible rect 0.00, 70.00 785.00 x 585.00)
-  (coverage rect 0.00, 0.00 1570.00 x 1755.00)
-  (intersects coverage rect 1)
-  (contentsScale 1.00)
-  (tile cache coverage 0, 0 2008 x 2048)
-  (tile size 512 x 512)
-  (top left tile 0, 0 tiles grid 4 x 4)
-  (in window 1)
-)
-  )
-)
 


Modified: trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html (258540 => 258541)

--- trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html	2020-03-17 05:22:41 UTC (rev 258540)
+++ trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html	2020-03-17 05:27:00 UTC (rev 258541)
@@ -63,11 +63,6 @@
 else
 testPassed("Scrollable div did not receive wheel events.");
 
-if (window.internals) {
-document.getElementById('layers').innerText = internals.layerTreeAsText(document,
-internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS | internals.LAYER_TREE_INCLUDES_TILE_CACHES);
-}
-
 testRunner.notifyDone();
 }
 
@@ -175,7 +170,6 @@
 
 description("Tests that a scrollable div doesn't consume wheel events when scroll is latched to main frame.");
 
-Layer tree goes here

[webkit-changes] [258540] trunk/Source/JavaScriptCore

2020-03-16 Thread ysuzuki 
Title: [258540] trunk/Source/_javascript_Core








Revision 258540
Author ysuz...@apple.com
Date 2020-03-16 22:22:41 -0700 (Mon, 16 Mar 2020)


Log Message
[JSC] JSMapIterator and JSSetIterator are CellType
https://bugs.webkit.org/show_bug.cgi?id=209168


Reviewed by Saam Barati.

They are JSCell, not JSObject since they are not used as a user-observable set/map iterators in JSC.
However, their JSType is ObjectType. They should use CellType instead.

* runtime/JSMapIterator.h:
* runtime/JSSetIterator.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSMapIterator.h
trunk/Source/_javascript_Core/runtime/JSSetIterator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (258539 => 258540)

--- trunk/Source/_javascript_Core/ChangeLog	2020-03-17 05:09:56 UTC (rev 258539)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-03-17 05:22:41 UTC (rev 258540)
@@ -1,3 +1,17 @@
+2020-03-16  Yusuke Suzuki  
+
+[JSC] JSMapIterator and JSSetIterator are CellType
+https://bugs.webkit.org/show_bug.cgi?id=209168
+
+
+Reviewed by Saam Barati.
+
+They are JSCell, not JSObject since they are not used as a user-observable set/map iterators in JSC.
+However, their JSType is ObjectType. They should use CellType instead.
+
+* runtime/JSMapIterator.h:
+* runtime/JSSetIterator.h:
+
 2020-03-16  Keith Miller  
 
 _javascript_ identifier grammar supports unescaped astral symbols, but JSC doesn’t


Modified: trunk/Source/_javascript_Core/runtime/JSMapIterator.h (258539 => 258540)

--- trunk/Source/_javascript_Core/runtime/JSMapIterator.h	2020-03-17 05:09:56 UTC (rev 258539)
+++ trunk/Source/_javascript_Core/runtime/JSMapIterator.h	2020-03-17 05:22:41 UTC (rev 258540)
@@ -32,6 +32,8 @@
 namespace JSC {
 
 // Now, it is only used for serialization.
+// FIXME: We should use JSInternalFieldObjectImpl to implement real JSMapIterator used in JSC.
+// Currently, JSC is using final objects to implement MapIterator.
 class JSMapIterator final : public JSCell {
 typedef HashMapBucket HashMapBucketType;
 public:
@@ -47,7 +49,7 @@
 
 static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
 {
-return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
+return Structure::create(vm, globalObject, prototype, TypeInfo(CellType, StructureFlags), info());
 }
 
 static JSMapIterator* create(VM& vm, Structure* structure, JSMap* iteratedObject, IterationKind kind)


Modified: trunk/Source/_javascript_Core/runtime/JSSetIterator.h (258539 => 258540)

--- trunk/Source/_javascript_Core/runtime/JSSetIterator.h	2020-03-17 05:09:56 UTC (rev 258539)
+++ trunk/Source/_javascript_Core/runtime/JSSetIterator.h	2020-03-17 05:22:41 UTC (rev 258540)
@@ -32,6 +32,8 @@
 namespace JSC {
 
 // Now, it is only used for serialization.
+// FIXME: We should use JSInternalFieldObjectImpl to implement real JSSetIterator used in JSC.
+// Currently, JSC is using final objects to implement SetIterator.
 class JSSetIterator final : public JSCell {
 typedef HashMapBucket HashMapBucketType;
 public:
@@ -47,7 +49,7 @@
 
 static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
 {
-return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
+return Structure::create(vm, globalObject, prototype, TypeInfo(CellType, StructureFlags), info());
 }
 
 static JSSetIterator* create(VM& vm, Structure* structure, JSSet* iteratedObject, IterationKind kind)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258539] trunk/Source

2020-03-16 Thread simon . fraser 
Title: [258539] trunk/Source








Revision 258539
Author simon.fra...@apple.com
Date 2020-03-16 22:09:56 -0700 (Mon, 16 Mar 2020)


Log Message
Add a bit more UIHitTesting logging, and make it possible to dump EventRegions from WebKit
https://bugs.webkit.org/show_bug.cgi?id=209058

Reviewed by Antti Koivisto.

Source/WebCore:

Export operator<<(TextStream&, const EventRegion&) so it can be used from Webkit.

* rendering/EventRegion.h:

Source/WebKit:

Add a UIHitTesting log.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/EventRegion.cpp
trunk/Source/WebCore/rendering/EventRegion.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (258538 => 258539)

--- trunk/Source/WebCore/ChangeLog	2020-03-17 04:44:51 UTC (rev 258538)
+++ trunk/Source/WebCore/ChangeLog	2020-03-17 05:09:56 UTC (rev 258539)
@@ -1,3 +1,14 @@
+2020-03-16  Simon Fraser  
+
+Add a bit more UIHitTesting logging, and make it possible to dump EventRegions from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=209058
+
+Reviewed by Antti Koivisto.
+
+Export operator<<(TextStream&, const EventRegion&) so it can be used from Webkit.
+
+* rendering/EventRegion.h:
+
 2020-03-16  Tim Horton  
 
 Remove a 'using namespace WebCore' in MediaSessionManagerCocoa


Modified: trunk/Source/WebCore/rendering/EventRegion.cpp (258538 => 258539)

--- trunk/Source/WebCore/rendering/EventRegion.cpp	2020-03-17 04:44:51 UTC (rev 258538)
+++ trunk/Source/WebCore/rendering/EventRegion.cpp	2020-03-17 05:09:56 UTC (rev 258539)
@@ -205,6 +205,25 @@
 return actions;
 }
 
+void EventRegion::dump(TextStream& ts) const
+{
+ts << m_region;
+
+if (!m_touchActionRegions.isEmpty()) {
+TextStream::IndentScope indentScope(ts);
+ts << indent << "(touch-action\n";
+for (unsigned i = 0; i < m_touchActionRegions.size(); ++i) {
+if (m_touchActionRegions[i].isEmpty())
+continue;
+TextStream::IndentScope indentScope(ts);
+ts << indent << "(" << toTouchAction(i);
+ts << indent << m_touchActionRegions[i];
+ts << indent << ")\n";
+}
+ts << indent << ")\n";
+}
+}
+
 TextStream& operator<<(TextStream& ts, TouchAction touchAction)
 {
 switch (touchAction) {
@@ -227,22 +246,7 @@
 
 TextStream& operator<<(TextStream& ts, const EventRegion& eventRegion)
 {
-ts << eventRegion.m_region;
-
-if (!eventRegion.m_touchActionRegions.isEmpty()) {
-TextStream::IndentScope indentScope(ts);
-ts << indent << "(touch-action\n";
-for (unsigned i = 0; i < eventRegion.m_touchActionRegions.size(); ++i) {
-if (eventRegion.m_touchActionRegions[i].isEmpty())
-continue;
-TextStream::IndentScope indentScope(ts);
-ts << indent << "(" << toTouchAction(i);
-ts << indent << eventRegion.m_touchActionRegions[i];
-ts << indent << ")\n";
-}
-ts << indent << ")\n";
-}
-
+eventRegion.dump(ts);
 return ts;
 }
 


Modified: trunk/Source/WebCore/rendering/EventRegion.h (258538 => 258539)

--- trunk/Source/WebCore/rendering/EventRegion.h	2020-03-17 04:44:51 UTC (rev 258538)
+++ trunk/Source/WebCore/rendering/EventRegion.h	2020-03-17 05:09:56 UTC (rev 258539)
@@ -83,15 +83,16 @@
 // FIXME: Remove legacy decode.
 template static bool decode(Decoder&, EventRegion&);
 
+void dump(TextStream&) const;
+
 private:
 void uniteTouchActions(const Region&, OptionSet);
-friend TextStream& operator<<(TextStream&, const EventRegion&);
 
 Region m_region;
 Vector m_touchActionRegions;
 };
 
-TextStream& operator<<(TextStream&, const EventRegion&);
+WEBCORE_EXPORT TextStream& operator<<(TextStream&, const EventRegion&);
 
 template
 void EventRegion::encode(Encoder& encoder) const


Modified: trunk/Source/WebKit/ChangeLog (258538 => 258539)

--- trunk/Source/WebKit/ChangeLog	2020-03-17 04:44:51 UTC (rev 258538)
+++ trunk/Source/WebKit/ChangeLog	2020-03-17 05:09:56 UTC (rev 258539)
@@ -1,3 +1,15 @@
+2020-03-16  Simon Fraser  
+
+Add a bit more UIHitTesting logging, and make it possible to dump EventRegions from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=209058
+
+Reviewed by Antti Koivisto.
+
+Add a UIHitTesting log.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
+
 2020-03-16  Chris Dumez  
 
 Crash under WebCookieCache::clearForHost()


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (258538 => 258539)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-03-17 04:44:51 UTC (rev 258538)
+++

[webkit-changes] [258538] trunk/Source/WebCore

2020-03-16 Thread timothy_horton 
Title: [258538] trunk/Source/WebCore








Revision 258538
Author timothy_hor...@apple.com
Date 2020-03-16 21:44:51 -0700 (Mon, 16 Mar 2020)


Log Message
Remove a 'using namespace WebCore' in MediaSessionManagerCocoa
https://bugs.webkit.org/show_bug.cgi?id=209162

Reviewed by Simon Fraser.

* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
Unified source cleanliness. Not currently causing any trouble, but
it did when I changed something locally!

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (258537 => 258538)

--- trunk/Source/WebCore/ChangeLog	2020-03-17 01:32:19 UTC (rev 258537)
+++ trunk/Source/WebCore/ChangeLog	2020-03-17 04:44:51 UTC (rev 258538)
@@ -1,3 +1,14 @@
+2020-03-16  Tim Horton  
+
+Remove a 'using namespace WebCore' in MediaSessionManagerCocoa
+https://bugs.webkit.org/show_bug.cgi?id=209162
+
+Reviewed by Simon Fraser.
+
+* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
+Unified source cleanliness. Not currently causing any trouble, but
+it did when I changed something locally!
+
 2020-03-16  ChangSeok Oh  
 
 A change event gets dispatched when textarea gets changed without focus


Modified: trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (258537 => 258538)

--- trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm	2020-03-17 01:32:19 UTC (rev 258537)
+++ trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm	2020-03-17 04:44:51 UTC (rev 258538)
@@ -42,11 +42,11 @@
 
 #include "MediaRemoteSoftLink.h"
 
-using namespace WebCore;
-
 static const size_t kWebAudioBufferSize = 128;
 static const size_t kLowPowerVideoBufferSize = 4096;
 
+namespace WebCore {
+
 #if PLATFORM(MAC)
 std::unique_ptr PlatformMediaSessionManager::create()
 {
@@ -334,4 +334,6 @@
 #endif // USE(MEDIAREMOTE)
 }
 
-#endif // USE(AUDIO_SESSION)
+} // namespace WebCore
+
+#endif // USE(AUDIO_SESSION) && PLATFORM(COCOA)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258537] trunk/LayoutTests

2020-03-16 Thread lmoura 
Title: [258537] trunk/LayoutTests








Revision 258537
Author lmo...@igalia.com
Date 2020-03-16 18:32:19 -0700 (Mon, 16 Mar 2020)


Log Message
WPE and GTK gardening.

Unreviewed test gardening.

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (258536 => 258537)

--- trunk/LayoutTests/ChangeLog	2020-03-17 01:01:16 UTC (rev 258536)
+++ trunk/LayoutTests/ChangeLog	2020-03-17 01:32:19 UTC (rev 258537)
@@ -1,3 +1,12 @@
+2020-03-16  Lauro Moura  
+
+WPE and GTK gardening.
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2020-03-16  ChangSeok Oh  
 
 A change event gets dispatched when textarea gets changed without focus


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (258536 => 258537)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-03-17 01:01:16 UTC (rev 258536)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-03-17 01:32:19 UTC (rev 258537)
@@ -534,6 +534,7 @@
 webkit.org/b/187064 webrtc/multi-video.html
 webkit.org/b/187064 webrtc/video-addTrack.html
 webkit.org/b/187064 webrtc/video-rotation.html
+webkit.org/b/187064 webrtc/video-rotation-no-cvo.html [ Failure ]
 webkit.org/b/187064 webrtc/video-mute.html
 webkit.org/b/187064 webrtc/video-disabled-black.html
 webkit.org/b/187064 webrtc/video-replace-track.html
@@ -1338,6 +1339,8 @@
 
 webkit.org/b/209046 inspector/animation/lifecycle-css-animation.html [ Failure ]
 
+webkit.org/b/209163 webrtc/audio-video-element-playing.html [ Failure ]
+
 #
 # End of Expected failures.
 #


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (258536 => 258537)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2020-03-17 01:01:16 UTC (rev 258536)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2020-03-17 01:32:19 UTC (rev 258537)
@@ -72,6 +72,7 @@
 webkit.org/b/187064 webrtc/multi-video.html
 webkit.org/b/187064 webrtc/video-addTrack.html
 webkit.org/b/187064 webrtc/video-rotation.html
+webkit.org/b/187064 webrtc/video-rotation-no-cvo.html [ Failure ]
 webkit.org/b/187064 webrtc/video-mute.html
 webkit.org/b/187064 webrtc/video-disabled-black.html
 webkit.org/b/187064 webrtc/video-replace-track.html
@@ -705,6 +706,8 @@
 # SMOOTH_SCROLLING is disabled by default for WPE
 fast/events/drag-smooth-scroll-element.html [ Failure ]
 
+webkit.org/b/209163 webrtc/audio-video-element-playing.html [ Failure ]
+
 #
 # 3. UNRESOLVED TESTS
 #
@@ -1294,7 +1297,7 @@
 
 webkit.org/b/202736 http/tests/appcache/document-cookie-http-only.php [ Failure Pass ]
 webkit.org/b/202736 http/tests/appcache/history-test.html [ Failure Pass ]
-webkit.org/b/202736 http/tests/appcache/remove-cache.html [ Timeout Pass ]
+webkit.org/b/202736 http/tests/appcache/remove-cache.html [ Failure Timeout Pass ]
 webkit.org/b/202736 http/tests/cache-storage/cache-clearing-all.https.html [ Failure Pass ]
 webkit.org/b/202736 http/tests/cache-storage/cache-clearing-origin.https.html [ Failure Pass ]
 webkit.org/b/202736 http/tests/cache-storage/cache-origins.https.html [ Failure Pass ]
@@ -1390,6 +1393,23 @@
 
 webkit.org/b/209130 fast/mediastream/fast/mediastream/change-tracks-media-stream-being-played.html [ Pass Crash Timeout ]
 
+webkit.org/b/209144 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.basic.image.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.norepeat.coord3.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.repeat.basic.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.repeat.outside.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.repeatx.basic.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.repeatx.coord1.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.repeaty.basic.html [ Pass Failure ]
+webkit.org/b/209144 imported/w3c/web-platform-tests/offscreen-canvas/fill-and-stroke-styles/2d.pattern.paint.repeaty.coord1.html [ Pass Failure ]

[webkit-changes] [258536] trunk/Source/WebInspectorUI

2020-03-16 Thread nvasilyev 
Title: [258536] trunk/Source/WebInspectorUI








Revision 258536
Author nvasil...@apple.com
Date 2020-03-16 18:01:16 -0700 (Mon, 16 Mar 2020)


Log Message
REGRESSION(r257380): Web Inspector: deleting node causes TreeOutline to lose focus
https://bugs.webkit.org/show_bug.cgi?id=208364


Reviewed by Devin Rousso.

Maintain keyboard focus within TreeOutline when selection changes.

* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.select):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (258535 => 258536)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-03-17 00:32:42 UTC (rev 258535)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-03-17 01:01:16 UTC (rev 258536)
@@ -1,3 +1,16 @@
+2020-03-16  Nikita Vasilyev  
+
+REGRESSION(r257380): Web Inspector: deleting node causes TreeOutline to lose focus
+https://bugs.webkit.org/show_bug.cgi?id=208364
+
+
+Reviewed by Devin Rousso.
+
+Maintain keyboard focus within TreeOutline when selection changes.
+
+* UserInterface/Views/TreeElement.js:
+(WI.TreeElement.prototype.select):
+
 2020-03-15  Yusuke Suzuki  
 
 Should not use variable-length-array (VLA)


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (258535 => 258536)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js	2020-03-17 00:32:42 UTC (rev 258535)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js	2020-03-17 01:01:16 UTC (rev 258536)
@@ -520,17 +520,22 @@
 
 select(omitFocus, selectedByUser, suppressNotification)
 {
-if (!this.treeOutline || !this.selectable)
+let treeOutline = this.treeOutline;
+if (!treeOutline || !this.selectable)
 return;
 
 if (!omitFocus)
 this.focus();
+else if (treeOutline.element.contains(document.activeElement)) {
+// When treeOutline has focus, focus on the newly selected treeElement.
+this.focus();
+}
 
 if (this.selected && !this.treeOutline.allowsRepeatSelection)
 return;
 
 // Focusing on another node may detach "this" from tree.
-let treeOutline = this.treeOutline;
+treeOutline = this.treeOutline;
 if (!treeOutline)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258535] tags/Safari-610.1.7.4/

2020-03-16 Thread alancoon 
Title: [258535] tags/Safari-610.1.7.4/








Revision 258535
Author alanc...@apple.com
Date 2020-03-16 17:32:42 -0700 (Mon, 16 Mar 2020)


Log Message
Tag Safari-610.1.7.4.

Added Paths

tags/Safari-610.1.7.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258534] branches/safari-610.1.7-branch/Source

2020-03-16 Thread alancoon 
Title: [258534] branches/safari-610.1.7-branch/Source








Revision 258534
Author alanc...@apple.com
Date 2020-03-16 17:31:15 -0700 (Mon, 16 Mar 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.7-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.7-branch/Source/WebCore/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/WebCore/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.7-branch/Source/WebKit/Configurations/Version.xcconfig (258533 => 258534)

--- branches/safari-610.1.7-branch/Source/WebKit/Configurations/Version.xcconfig	2020-03-17 00:30:39 UTC (rev 258533)
+++ branches/safari-610.1.7-branch/Source/WebKit/Configurations/Version.xcconfig	2020-03-17 00:31:15 UTC (rev 258534)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION =

[webkit-changes] [258533] trunk/Source/WebCore/PAL

2020-03-16 Thread achristensen 
Title: [258533] trunk/Source/WebCore/PAL








Revision 258533
Author achristen...@apple.com
Date 2020-03-16 17:30:39 -0700 (Mon, 16 Mar 2020)


Log Message
Build fix.
   ​https://bugs.webkit.org/show_bug.cgi?id=208951

* pal/spi/cocoa/AVFoundationSPI.h:
r258314 was missing a nullability annotation.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (258532 => 258533)

--- trunk/Source/WebCore/PAL/ChangeLog	2020-03-17 00:14:34 UTC (rev 258532)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-03-17 00:30:39 UTC (rev 258533)
@@ -1,3 +1,11 @@
+2020-03-16  Alex Christensen  
+
+Build fix.
+   ​https://bugs.webkit.org/show_bug.cgi?id=208951
+
+* pal/spi/cocoa/AVFoundationSPI.h:
+r258314 was missing a nullability annotation.
+
 2020-03-16  Per Arne Vollan  
 
 [macOS] Accessibility sandbox regressions


Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h (258532 => 258533)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h	2020-03-17 00:14:34 UTC (rev 258532)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h	2020-03-17 00:30:39 UTC (rev 258533)
@@ -360,12 +360,15 @@
 #if USE(APPLE_INTERNAL_SDK)
 #include 
 #else
+
+NS_ASSUME_NONNULL_BEGIN
 @interface AVSampleBufferVideoOutput : NSObject
 - (CVPixelBufferRef)copyPixelBufferForSourceTime:(CMTime)sourceTime sourceTimeForDisplay:(nullable CMTime *)outSourceTimeForDisplay;
 @end
+NS_ASSUME_NONNULL_END
 
 @interface AVSampleBufferDisplayLayer (VideoOutput)
 @property (nonatomic, nullable) AVSampleBufferVideoOutput *output;
 @end
-#endif
-#endif
+#endif // USE(APPLE_INTERNAL_SDK)
+#endif // HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258532] trunk

2020-03-16 Thread rniwa 
Title: [258532] trunk








Revision 258532
Author rn...@webkit.org
Date 2020-03-16 17:14:34 -0700 (Mon, 16 Mar 2020)


Log Message
A change event gets dispatched when textarea gets changed without focus
https://bugs.webkit.org/show_bug.cgi?id=202144

Patch by ChangSeok Oh  on 2020-03-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

A crash happens in WebCore::ValidationMessage::buildBubbleTree. An immediate reason
is that DOM tree is modified in buildBubbleTree triggered by a timer.
The function calls document.updateLayout() that causes a change event
for textarea to fire when something changed in the textarea.
This bug is not reproduced on Mac because buildBubbleTree is not called.
See ValidationMessage::setMessage.
On the other hand, the root cause of this issue is triggering the change event
for textarea even if it is not focused when a change is made. This behavior
is different to what Gecko and Chromium do. When loading the test, they do not
trigger the change event although the textarea is filled by the script
since the textarea is not focused. Only when we manually make a change (meaning
the textarea is focused by user input), the event gets dispatched. To fix it,
setChangedSinceLastFormControlChangeEvent(true) is moved below the focus check
in HTMLTextAreaElement::subtreeHasChanged();

Test: fast/forms/textfield-onchange-without-focus.html

* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):

LayoutTests:

The test should be identical to the extected result without crash.

* fast/forms/textfield-onchange-without-focus-expected.html: Added.
* fast/forms/textfield-onchange-without-focus.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp


Added Paths

trunk/LayoutTests/fast/forms/textfield-onchange-without-focus-expected.html
trunk/LayoutTests/fast/forms/textfield-onchange-without-focus.html




Diff

Modified: trunk/LayoutTests/ChangeLog (258531 => 258532)

--- trunk/LayoutTests/ChangeLog	2020-03-17 00:12:17 UTC (rev 258531)
+++ trunk/LayoutTests/ChangeLog	2020-03-17 00:14:34 UTC (rev 258532)
@@ -1,3 +1,15 @@
+2020-03-16  ChangSeok Oh  
+
+A change event gets dispatched when textarea gets changed without focus
+https://bugs.webkit.org/show_bug.cgi?id=202144
+
+Reviewed by Ryosuke Niwa.
+
+The test should be identical to the extected result without crash.
+
+* fast/forms/textfield-onchange-without-focus-expected.html: Added.
+* fast/forms/textfield-onchange-without-focus.html: Added.
+
 2020-03-16  Keith Miller  
 
 _javascript_ identifier grammar supports unescaped astral symbols, but JSC doesn’t


Added: trunk/LayoutTests/fast/forms/textfield-onchange-without-focus-expected.html (0 => 258532)

--- trunk/LayoutTests/fast/forms/textfield-onchange-without-focus-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/textfield-onchange-without-focus-expected.html	2020-03-17 00:14:34 UTC (rev 258532)
@@ -0,0 +1,22 @@
+
+
+function test() {
+  const select = document.querySelector('select');
+  select.setCustomValidity('validity');
+  select.reportValidity();
+
+  const textarea = document.querySelector('textarea');
+  textarea.setRangeText('lol');
+  select.autofocus = true;
+
+  setTimeout(() => {
+select.reportValidity();
+textarea.blur();
+  }, 0);
+}
+
+
+  The onchange should not be triggered by textarea when it got something changed without being focused. Pass if not crashed, and the focused select box is displayed.
+  
+  
+


Added: trunk/LayoutTests/fast/forms/textfield-onchange-without-focus.html (0 => 258532)

--- trunk/LayoutTests/fast/forms/textfield-onchange-without-focus.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/textfield-onchange-without-focus.html	2020-03-17 00:14:34 UTC (rev 258532)
@@ -0,0 +1,22 @@
+
+
+function test() {
+  const select = document.querySelector('select');
+  select.setCustomValidity('validity');
+  select.reportValidity();
+
+  const textarea = document.querySelector('textarea');
+  textarea.setRangeText('lol');
+  select.autofocus = true;
+
+  setTimeout(() => {
+select.reportValidity();
+textarea.blur();
+  }, 0);
+}
+
+
+  The onchange should not be triggered by textarea when it got something changed without being focused. Pass if not crashed, and the focused select box is displayed.
+  
+  
+


Modified: trunk/Source/WebCore/ChangeLog (258531 => 258532)

--- trunk/Source/WebCore/ChangeLog	2020-03-17 00:12:17 UTC (rev 258531)
+++ trunk/Source/WebCore/ChangeLog	2020-03-17 00:14:34 UTC (rev 258532)
@@ -1,3 +1,30 @@
+2020-03-16  ChangSeok Oh  
+
+A change event gets dispatched when textarea gets changed without focus
+https://bugs.webkit.org/show_bug.cgi?id=202144
+
+Reviewed by Ryosuke Niwa.
+
+A crash happens in WebCore::ValidationMessage::buildBubbleTree. An immediate reason
+is that

[webkit-changes] [258531] trunk

2020-03-16 Thread keith_miller 
Title: [258531] trunk








Revision 258531
Author keith_mil...@apple.com
Date 2020-03-16 17:12:17 -0700 (Mon, 16 Mar 2020)


Log Message
_javascript_ identifier grammar supports unescaped astral symbols, but JSC doesn’t
https://bugs.webkit.org/show_bug.cgi?id=208998

Reviewed by Michael Saboff.

JSTests:

* stress/unicode-identifiers-with-surrogate-pairs.js: Added.
(let.c.of.chars.eval.foo):
(throwsSyntaxError):
(let.c.of.continueChars.throwsSyntaxError.foo):

Source/_javascript_Core:

This patch fixes a bug in the parser that allows for surrogate pairs when parsing identifiers.
It also makes a few other changes to the parser:

1) When looking for keywords we just need to check that subsequent
character cannot be a identifier part or an escape start.

2) The only time we call parseIdentifierSlowCase is when we hit an
escape start or a surrogate pair so we can optimize that to just
copy everything up slow character into our buffer.

3) We shouldn't allow for asking if a UChar is an identifier start/part.

* KeywordLookupGenerator.py:
(Trie.printSubTreeAsC):
(Trie.printAsC):
* parser/Lexer.cpp:
(JSC::isNonLatin1IdentStart):
(JSC::isIdentStart):
(JSC::isSingleCharacterIdentStart):
(JSC::cannotBeIdentStart):
(JSC::isIdentPart):
(JSC::isSingleCharacterIdentPart):
(JSC::cannotBeIdentPartOrEscapeStart):
(JSC::Lexer::currentCodePoint const):
(JSC::Lexer::currentCodePoint const):
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseIdentifierSlowCase):
(JSC::Lexer::lexWithoutClearingLineTerminator):
(JSC::Lexer::scanRegExp):
(JSC::isIdentPartIncludingEscapeTemplate): Deleted.
(JSC::isIdentPartIncludingEscape): Deleted.
* parser/Lexer.h:
(JSC::Lexer::setOffsetFromSourcePtr): Deleted.
* parser/Parser.cpp:
(JSC::Parser::printUnexpectedTokenText):
* parser/ParserTokens.h:

Source/WTF:

* wtf/text/WTFString.cpp:
(WTF::String::fromCodePoint):
* wtf/text/WTFString.h:

LayoutTests:

Fix broken test that asserted a non-ID_START codepoint was a start codepoint and
an ID_START codepoint was not a valid codepoint...

* js/script-tests/unicode-escape-sequences.js:
* js/unicode-escape-sequences-expected.txt:

Modified Paths

trunk/JSTests/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/unicode-escape-sequences.js
trunk/LayoutTests/js/unicode-escape-sequences-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/KeywordLookupGenerator.py
trunk/Source/_javascript_Core/parser/Lexer.cpp
trunk/Source/_javascript_Core/parser/Lexer.h
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/ParserTokens.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/WTFString.cpp
trunk/Source/WTF/wtf/text/WTFString.h


Added Paths

trunk/JSTests/stress/unicode-identifiers-with-surrogate-pairs.js




Diff

Modified: trunk/JSTests/ChangeLog (258530 => 258531)

--- trunk/JSTests/ChangeLog	2020-03-17 00:03:57 UTC (rev 258530)
+++ trunk/JSTests/ChangeLog	2020-03-17 00:12:17 UTC (rev 258531)
@@ -1,3 +1,15 @@
+2020-03-16  Keith Miller  
+
+_javascript_ identifier grammar supports unescaped astral symbols, but JSC doesn’t
+https://bugs.webkit.org/show_bug.cgi?id=208998
+
+Reviewed by Michael Saboff.
+
+* stress/unicode-identifiers-with-surrogate-pairs.js: Added.
+(let.c.of.chars.eval.foo):
+(throwsSyntaxError):
+(let.c.of.continueChars.throwsSyntaxError.foo):
+
 2020-03-13  Saam Barati  
 
 skip wasm/function-tests/grow-memory-cause-gc.js on memory limited devices


Added: trunk/JSTests/stress/unicode-identifiers-with-surrogate-pairs.js (0 => 258531)

--- trunk/JSTests/stress/unicode-identifiers-with-surrogate-pairs.js	(rev 0)
+++ trunk/JSTests/stress/unicode-identifiers-with-surrogate-pairs.js	2020-03-17 00:12:17 UTC (rev 258531)
@@ -0,0 +1,30 @@
+
+let chars = ["鴬", "ʧ", "Ϊ"];
+let continueChars =  [unescape("\u0311"), String.fromCharCode(...[0xDB40, 0xDD96])];
+
+let o = { };
+for (let c of chars) {
+eval(`var ${c};`);
+eval(`function foo() { var ${c} }`);
+eval(`o.${c}`);
+}
+
+function throwsSyntaxError(string) {
+try {
+eval(string);
+} catch (e) {
+if (!(e instanceof SyntaxError))
+throw new Error(string);
+return;
+}
+throw new Error(string);
+}
+
+for (let c of continueChars) {
+throwsSyntaxError(`var ${c}`);
+throwsSyntaxError(`function foo() { var ${c} }`);
+throwsSyntaxError(`o.${c}`);
+eval(`var ${("a" + c)}`);
+eval(`o.${"a" + c}`);
+
+}


Modified: trunk/LayoutTests/ChangeLog (258530 => 258531)

--- trunk/LayoutTests/ChangeLog	2020-03-17 00:03:57 UTC (rev 258530)
+++ trunk/LayoutTests/ChangeLog	2020-03-17 00:12:17 UTC (rev 258531)
@@ -1,3 +1,16 @@
+2020-03-16  Keith Miller  
+
+_javascript_ identifier grammar supports unescaped astral symbols, but JSC doesn’t
+https://bugs.webkit.org/show_bug.cgi?id=208998
+
+Reviewed by Michael Saboff.

[webkit-changes] [258530] trunk/Source/WebKit

2020-03-16 Thread cdumez 
Title: [258530] trunk/Source/WebKit








Revision 258530
Author cdu...@apple.com
Date 2020-03-16 17:03:57 -0700 (Mon, 16 Mar 2020)


Log Message
Crash under WebCookieCache::clearForHost()
https://bugs.webkit.org/show_bug.cgi?id=209149


Reviewed by Darin Adler.

Alternative fix for Bug 209149 based on comments from Darin.

* WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::clearForHost):
(WebKit::WebCookieCache::pruneCacheIfNecessary):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (258529 => 258530)

--- trunk/Source/WebKit/ChangeLog	2020-03-16 23:56:49 UTC (rev 258529)
+++ trunk/Source/WebKit/ChangeLog	2020-03-17 00:03:57 UTC (rev 258530)
@@ -1,3 +1,17 @@
+2020-03-16  Chris Dumez  
+
+Crash under WebCookieCache::clearForHost()
+https://bugs.webkit.org/show_bug.cgi?id=209149
+
+
+Reviewed by Darin Adler.
+
+Alternative fix for Bug 209149 based on comments from Darin.
+
+* WebProcess/WebPage/WebCookieCache.cpp:
+(WebKit::WebCookieCache::clearForHost):
+(WebKit::WebCookieCache::pruneCacheIfNecessary):
+
 2020-03-16  Tim Horton  
 
 Fix the macCatalyst build after r258525


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp (258529 => 258530)

--- trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp	2020-03-16 23:56:49 UTC (rev 258529)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp	2020-03-17 00:03:57 UTC (rev 258530)
@@ -102,14 +102,13 @@
 
 void WebCookieCache::clearForHost(const String& host)
 {
-auto it = m_hostsWithInMemoryStorage.find(host);
-if (it == m_hostsWithInMemoryStorage.end())
+String removedHost = m_hostsWithInMemoryStorage.take(host);
+if (removedHost.isNull())
 return;
 
-m_hostsWithInMemoryStorage.remove(it);
-inMemoryStorageSession().deleteCookiesForHostnames(Vector { host });
+inMemoryStorageSession().deleteCookiesForHostnames(Vector { removedHost });
 #if HAVE(COOKIE_CHANGE_LISTENER_API)
-WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::UnsubscribeFromCookieChangeNotifications(HashSet { host }), 0);
+WebProcess::singleton().ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::UnsubscribeFromCookieChangeNotifications(HashSet { removedHost }), 0);
 #endif
 }
 
@@ -118,10 +117,8 @@
 // We may want to raise this limit if we start using the cache for third-party iframes.
 static const unsigned maxCachedHosts = 5;
 
-while (m_hostsWithInMemoryStorage.size() >= maxCachedHosts) {
-String hostToRemove = *m_hostsWithInMemoryStorage.random();
-clearForHost(hostToRemove);
-}
+while (m_hostsWithInMemoryStorage.size() >= maxCachedHosts)
+clearForHost(*m_hostsWithInMemoryStorage.random());
 }
 
 #if !PLATFORM(COCOA)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258529] trunk/Source/WebKit

2020-03-16 Thread timothy_horton 
Title: [258529] trunk/Source/WebKit








Revision 258529
Author timothy_hor...@apple.com
Date 2020-03-16 16:56:49 -0700 (Mon, 16 Mar 2020)


Log Message
Fix the macCatalyst build after r258525

* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258528 => 258529)

--- trunk/Source/WebKit/ChangeLog	2020-03-16 23:34:37 UTC (rev 258528)
+++ trunk/Source/WebKit/ChangeLog	2020-03-16 23:56:49 UTC (rev 258529)
@@ -1,3 +1,10 @@
+2020-03-16  Tim Horton  
+
+Fix the macCatalyst build after r258525
+
+* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
+(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
+
 2020-03-15  Darin Adler  
 
 Move most of TextIterator off of live ranges


Modified: trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm (258528 => 258529)

--- trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm	2020-03-16 23:34:37 UTC (rev 258528)
+++ trunk/Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm	2020-03-16 23:56:49 UTC (rev 258529)
@@ -185,7 +185,7 @@
 size_t entireRangeLength;
 TextIterator::getLocationAndLengthFromRange(commonAncestor.get(), entireRange.get(), entireRangeLocation, entireRangeLength);
 
-for (TextIterator it(start.deepEquivalent(), end.deepEquivalent()); !it.atEnd(); it.advance()) {
+for (TextIterator it({ *makeBoundaryPoint(start.deepEquivalent()), *makeBoundaryPoint(end.deepEquivalent()) }); !it.atEnd(); it.advance()) {
 int currentTextLength = it.text().length();
 if (!currentTextLength)
 continue;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258528] trunk/Source/WebCore

2020-03-16 Thread simon . fraser 
Title: [258528] trunk/Source/WebCore








Revision 258528
Author simon.fra...@apple.com
Date 2020-03-16 16:34:37 -0700 (Mon, 16 Mar 2020)


Log Message
Update touch event regions once per frame
https://bugs.webkit.org/show_bug.cgi?id=209153

Reviewed by Zalan Bujtas.

Call document->updateTouchEventRegions() once at the end of Page::updateRendering() instead
of relying on a timer.

Also rename the functions called from Internal to make it clear they are testing-only.

Page::scrollingStateTreeAsText() needs to eagerly update event regions because they are input
to the scrolling tree.

* dom/Document.cpp:
(WebCore::Document::Document):
* page/Page.cpp:
(WebCore::Page::scrollingStateTreeAsText):
(WebCore::Page::touchEventRectsForEventForTesting):
(WebCore::Page::passiveTouchEventListenerRectsForTesting):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::touchEventRectsForEvent): Deleted.
(WebCore::Page::passiveTouchEventListenerRects): Deleted.
* page/Page.h:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
* testing/Internals.cpp:
(WebCore::Internals::touchEventRectsForEvent):
(WebCore::Internals::passiveTouchEventListenerRects):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/testing/Internals.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (258527 => 258528)

--- trunk/Source/WebCore/ChangeLog	2020-03-16 23:16:55 UTC (rev 258527)
+++ trunk/Source/WebCore/ChangeLog	2020-03-16 23:34:37 UTC (rev 258528)
@@ -1,3 +1,34 @@
+2020-03-16  Simon Fraser  
+
+Update touch event regions once per frame
+https://bugs.webkit.org/show_bug.cgi?id=209153
+
+Reviewed by Zalan Bujtas.
+
+Call document->updateTouchEventRegions() once at the end of Page::updateRendering() instead
+of relying on a timer.
+
+Also rename the functions called from Internal to make it clear they are testing-only.
+
+Page::scrollingStateTreeAsText() needs to eagerly update event regions because they are input
+to the scrolling tree.
+
+* dom/Document.cpp:
+(WebCore::Document::Document):
+* page/Page.cpp:
+(WebCore::Page::scrollingStateTreeAsText):
+(WebCore::Page::touchEventRectsForEventForTesting):
+(WebCore::Page::passiveTouchEventListenerRectsForTesting):
+(WebCore::Page::doAfterUpdateRendering):
+(WebCore::Page::touchEventRectsForEvent): Deleted.
+(WebCore::Page::passiveTouchEventListenerRects): Deleted.
+* page/Page.h:
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
+* testing/Internals.cpp:
+(WebCore::Internals::touchEventRectsForEvent):
+(WebCore::Internals::passiveTouchEventListenerRects):
+
 2020-03-15  Darin Adler  
 
 Move most of TextIterator off of live ranges


Modified: trunk/Source/WebCore/dom/Document.cpp (258527 => 258528)

--- trunk/Source/WebCore/dom/Document.cpp	2020-03-16 23:16:55 UTC (rev 258527)
+++ trunk/Source/WebCore/dom/Document.cpp	2020-03-16 23:34:37 UTC (rev 258528)
@@ -536,9 +536,6 @@
 : ContainerNode(*this, CreateDocument)
 , TreeScope(*this)
 , FrameDestructionObserver(frame)
-#if ENABLE(IOS_TOUCH_EVENTS)
-, m_touchEventsChangedTimer(*this, ::touchEventsChangedTimerFired)
-#endif
 , m_settings(frame ? Ref(frame->settings()) : Settings::create(nullptr))
 , m_quirks(makeUniqueRef(*this))
 , m_cachedResourceLoader(m_frame ? Ref(m_frame->loader().activeDocumentLoader()->cachedResourceLoader()) : CachedResourceLoader::create(nullptr))


Modified: trunk/Source/WebCore/page/Page.cpp (258527 => 258528)

--- trunk/Source/WebCore/page/Page.cpp	2020-03-16 23:16:55 UTC (rev 258527)
+++ trunk/Source/WebCore/page/Page.cpp	2020-03-16 23:34:37 UTC (rev 258528)
@@ -434,8 +434,12 @@
 
 String Page::scrollingStateTreeAsText()
 {
-if (Document* document = m_mainFrame->document())
+if (Document* document = m_mainFrame->document()) {
 document->updateLayout();
+#if ENABLE(IOS_TOUCH_EVENTS)
+document->updateTouchEventRegions();
+#endif
+}
 
 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
 return scrollingCoordinator->scrollingStateTreeAsText();
@@ -473,7 +477,7 @@
 return DOMRectList::create(quads);
 }
 
-Ref Page::touchEventRectsForEvent(const String& eventName)
+Ref Page::touchEventRectsForEventForTesting(const String& eventName)
 {
 if (Document* document = m_mainFrame->document()) {
 document->updateLayout();
@@ -496,7 +500,7 @@
 return DOMRectList::create(quads);
 }
 
-Ref Page::passiveTouchEventListenerRects()
+Ref Page::passiveTouchEventListenerRectsForTesting()
 {
 if (Document*

[webkit-changes] [258527] trunk/Tools

2020-03-16 Thread justin_michaud 
Title: [258527] trunk/Tools








Revision 258527
Author justin_mich...@apple.com
Date 2020-03-16 16:16:55 -0700 (Mon, 16 Mar 2020)


Log Message
Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
https://bugs.webkit.org/show_bug.cgi?id=209151

Reviewed by Yusuke Suzuki.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (258526 => 258527)

--- trunk/Tools/ChangeLog	2020-03-16 23:12:15 UTC (rev 258526)
+++ trunk/Tools/ChangeLog	2020-03-16 23:16:55 UTC (rev 258527)
@@ -1,3 +1,12 @@
+2020-03-16  Justin Michaud  
+
+Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=209151
+
+Reviewed by Yusuke Suzuki.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2020-03-16  Chris Dumez  
 
 Crash under WebCookieCache::clearForHost()


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (258526 => 258527)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2020-03-16 23:12:15 UTC (rev 258526)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2020-03-16 23:16:55 UTC (rev 258527)
@@ -3154,7 +3154,8 @@
},
"Justin Michaud" : {
   "emails" : [
- "justin_mich...@apple.com"
+ "justin_mich...@apple.com",
+ "jus...@justinmichaud.com"
   ],
   "status" : "committer"
},






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258526] trunk/LayoutTests

2020-03-16 Thread lawrence . j 
Title: [258526] trunk/LayoutTests








Revision 258526
Author lawrenc...@apple.com
Date 2020-03-16 16:12:15 -0700 (Mon, 16 Mar 2020)


Log Message
[ Mac wk1 ] http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209154

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (258525 => 258526)

--- trunk/LayoutTests/ChangeLog	2020-03-16 23:02:10 UTC (rev 258525)
+++ trunk/LayoutTests/ChangeLog	2020-03-16 23:12:15 UTC (rev 258526)
@@ -1,3 +1,12 @@
+2020-03-16  Jason Lawrence  
+
+[ Mac wk1 ] http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=209154
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2020-03-16  Pinki Gyanchandani  
 
 Crash in CSSValue::isPrimitiveValue


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (258525 => 258526)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-03-16 23:02:10 UTC (rev 258525)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-03-16 23:12:15 UTC (rev 258526)
@@ -953,3 +953,5 @@
 webkit.org/b/209067 http/tests/security/_javascript_URL/xss-DENIED-to-_javascript_-url-in-foreign-domain-subframe.html [ Pass Failure ]
 
 webkit.org/b/209073 [ Debug ] inspector/injected-script/avoid-getter-invocation.html [ Pass Failure ]
+
+webkit.org/b/209154 http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258524] branches/safari-610.1.7.3-branch/

2020-03-16 Thread repstein 
Title: [258524] branches/safari-610.1.7.3-branch/








Revision 258524
Author repst...@apple.com
Date 2020-03-16 15:49:24 -0700 (Mon, 16 Mar 2020)


Log Message
Delete branch.

Removed Paths

branches/safari-610.1.7.3-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258523] branches/safari-610.1.7.3-branch/

2020-03-16 Thread repstein 
Title: [258523] branches/safari-610.1.7.3-branch/








Revision 258523
Author repst...@apple.com
Date 2020-03-16 15:41:24 -0700 (Mon, 16 Mar 2020)


Log Message
New branch.

Added Paths

branches/safari-610.1.7.3-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258522] trunk

2020-03-16 Thread commit-queue 
Title: [258522] trunk








Revision 258522
Author commit-qu...@webkit.org
Date 2020-03-16 15:10:33 -0700 (Mon, 16 Mar 2020)


Log Message
Crash in CSSValue::isPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=208309

Patch by Pinki Gyanchandani  on 2020-03-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Added a NULL check before dereferencing value in ApplyStyleCommand::computedFontSize

Test: editing/execCommand/primitive-value.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):

LayoutTests:

Added a testcase attached to bugzilla issue 208309, with little modification.

* editing/execCommand/primitive-value-expected.txt: Added.
* editing/execCommand/primitive-value.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp


Added Paths

trunk/LayoutTests/editing/execCommand/primitive-value-expected.txt
trunk/LayoutTests/editing/execCommand/primitive-value.html




Diff

Modified: trunk/LayoutTests/ChangeLog (258521 => 258522)

--- trunk/LayoutTests/ChangeLog	2020-03-16 22:04:02 UTC (rev 258521)
+++ trunk/LayoutTests/ChangeLog	2020-03-16 22:10:33 UTC (rev 258522)
@@ -1,3 +1,15 @@
+2020-03-16  Pinki Gyanchandani  
+
+Crash in CSSValue::isPrimitiveValue
+https://bugs.webkit.org/show_bug.cgi?id=208309
+
+Reviewed by Ryosuke Niwa.
+
+Added a testcase attached to bugzilla issue 208309, with little modification. 
+
+* editing/execCommand/primitive-value-expected.txt: Added.
+* editing/execCommand/primitive-value.html: Added.
+
 2020-03-16  Jason Lawrence  
 
 [ Mac wk2 ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream tests are flaky failing.


Added: trunk/LayoutTests/editing/execCommand/primitive-value-expected.txt (0 => 258522)

--- trunk/LayoutTests/editing/execCommand/primitive-value-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/execCommand/primitive-value-expected.txt	2020-03-16 22:10:33 UTC (rev 258522)
@@ -0,0 +1 @@
+This test checks that pasing in a combination of nested blocks where one starts with a text field doesn't crash or fail assertions. x


Added: trunk/LayoutTests/editing/execCommand/primitive-value.html (0 => 258522)

--- trunk/LayoutTests/editing/execCommand/primitive-value.html	(rev 0)
+++ trunk/LayoutTests/editing/execCommand/primitive-value.html	2020-03-16 22:10:33 UTC (rev 258522)
@@ -0,0 +1,18 @@
+
+
+
+
+function primValueTest() {
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.designMode = 'on';
+document.execCommand("selectAll");
+document.execCommand("InsertHTML",false,"This test checks that pasing in a combination of nested blocks where one starts with a text field doesn't crash or fail assertions. \nx\n");
+document.execCommand("selectAll");
+document.execCommand("FontSizeDelta",false,3);
+}
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (258521 => 258522)

--- trunk/Source/WebCore/ChangeLog	2020-03-16 22:04:02 UTC (rev 258521)
+++ trunk/Source/WebCore/ChangeLog	2020-03-16 22:10:33 UTC (rev 258522)
@@ -1,3 +1,17 @@
+2020-03-16  Pinki Gyanchandani  
+
+Crash in CSSValue::isPrimitiveValue
+https://bugs.webkit.org/show_bug.cgi?id=208309
+
+Reviewed by Ryosuke Niwa.
+
+Added a NULL check before dereferencing value in ApplyStyleCommand::computedFontSize
+
+Test: editing/execCommand/primitive-value.html
+
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::computedFontSize):
+
 2020-03-16  Megan Gardner  
 
 Color Picker crashes on touch


Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (258521 => 258522)

--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp	2020-03-16 22:04:02 UTC (rev 258521)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp	2020-03-16 22:10:33 UTC (rev 258522)
@@ -1497,6 +1497,8 @@
 return 0;
 
 auto value = ComputedStyleExtractor(node).propertyValue(CSSPropertyFontSize);
+if (!value)
+return 0;
 return downcast(*value).floatValue(CSSUnitType::CSS_PX);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258521] trunk

2020-03-16 Thread cdumez 
Title: [258521] trunk








Revision 258521
Author cdu...@apple.com
Date 2020-03-16 15:04:02 -0700 (Mon, 16 Mar 2020)


Log Message
Crash under WebCookieCache::clearForHost()
https://bugs.webkit.org/show_bug.cgi?id=209149


Reviewed by Alex Christensen.

Source/WebKit:

Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing
to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator
and passing that to clearForHost(). However, clearForHost() would then drop the String from
the HashSet and the host would no longer be valid.

Change covered by new API test.

* WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::pruneCacheIfNecessary):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258520 => 258521)

--- trunk/Source/WebKit/ChangeLog	2020-03-16 21:50:22 UTC (rev 258520)
+++ trunk/Source/WebKit/ChangeLog	2020-03-16 22:04:02 UTC (rev 258521)
@@ -1,3 +1,21 @@
+2020-03-16  Chris Dumez  
+
+Crash under WebCookieCache::clearForHost()
+https://bugs.webkit.org/show_bug.cgi?id=209149
+
+
+Reviewed by Alex Christensen.
+
+Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing
+to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator
+and passing that to clearForHost(). However, clearForHost() would then drop the String from
+the HashSet and the host would no longer be valid.
+
+Change covered by new API test.
+
+* WebProcess/WebPage/WebCookieCache.cpp:
+(WebKit::WebCookieCache::pruneCacheIfNecessary):
+
 2020-03-16  Per Arne Vollan  
 
 [macOS] Accessibility sandbox regressions


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp (258520 => 258521)

--- trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp	2020-03-16 21:50:22 UTC (rev 258520)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp	2020-03-16 22:04:02 UTC (rev 258521)
@@ -118,8 +118,10 @@
 // We may want to raise this limit if we start using the cache for third-party iframes.
 static const unsigned maxCachedHosts = 5;
 
-while (m_hostsWithInMemoryStorage.size() >= maxCachedHosts)
-clearForHost(*m_hostsWithInMemoryStorage.random());
+while (m_hostsWithInMemoryStorage.size() >= maxCachedHosts) {
+String hostToRemove = *m_hostsWithInMemoryStorage.random();
+clearForHost(hostToRemove);
+}
 }
 
 #if !PLATFORM(COCOA)


Modified: trunk/Tools/ChangeLog (258520 => 258521)

--- trunk/Tools/ChangeLog	2020-03-16 21:50:22 UTC (rev 258520)
+++ trunk/Tools/ChangeLog	2020-03-16 22:04:02 UTC (rev 258521)
@@ -1,3 +1,16 @@
+2020-03-16  Chris Dumez  
+
+Crash under WebCookieCache::clearForHost()
+https://bugs.webkit.org/show_bug.cgi?id=209149
+
+
+Reviewed by Alex Christensen.
+
+Add API test coverage.
+
+* TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
+(TEST):
+
 2020-03-16  Keith Rollin  
 
 Remove support for WebKitSystemInterface


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm (258520 => 258521)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm	2020-03-16 21:50:22 UTC (rev 258520)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm	2020-03-16 22:04:02 UTC (rev 258521)
@@ -33,6 +33,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 
 static bool receivedAlert;
@@ -128,3 +129,22 @@
 } while (cookieString != "" && timeout < 50);
 EXPECT_WK_STREQ("foo=bar", cookieString);
 }
+
+TEST(WebKit, CookieCachePruning)
+{
+auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
+auto view = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
+
+for (unsigned i = 0; i < 100; ++i) {
+[view synchronouslyLoadHTMLString:@"foo" baseURL:[NSURL URLWithString:makeString("http://foo", i, ".example.com/")]];
+
+__block bool doneEvaluatingJavaScript = false;
+[view evaluateJavaScript:@"document.cookie;" completionHandler:^(id _Nullable cookie, NSError * _Nullable error) {
+EXPECT_NULL(error);
+EXPECT_TRUE([cookie isKindOfClass:[NSString class]]);
+EXPECT_WK_STREQ("", (NSString *)cookie);
+doneEvaluatingJavaScript = true;
+}];
+TestWebKitAPI::Util::run();
+}
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258520] trunk

2020-03-16 Thread krollin 
Title: [258520] trunk








Revision 258520
Author krol...@apple.com
Date 2020-03-16 14:50:22 -0700 (Mon, 16 Mar 2020)


Log Message
Remove support for WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=208894


Reviewed by Brent Fulgham.

This project provided support for facilities that are now handled
elsewhere and is no longer needed.

.:

* .gitignore:
* Source/PlatformWin.cmake:
* Source/cmake/OptionsAppleWin.cmake:

Tools:

* Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

* Makefile:
* WebKitSystemInterface.h: Removed.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h: Removed.
* win/lib32/WebKitSystemInterface.lib: Removed.

Modified Paths

trunk/.gitignore
trunk/ChangeLog
trunk/Source/PlatformWin.cmake
trunk/Source/cmake/OptionsAppleWin.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/Makefile


Removed Paths

trunk/WebKitLibraries/WebKitSystemInterface.h
trunk/WebKitLibraries/win/include/
trunk/WebKitLibraries/win/lib32/




Diff

Modified: trunk/.gitignore (258519 => 258520)

--- trunk/.gitignore	2020-03-16 21:41:31 UTC (rev 258519)
+++ trunk/.gitignore	2020-03-16 21:50:22 UTC (rev 258520)
@@ -33,8 +33,6 @@
 # Ignore files installed by WebKitSupportLibrary/WebKitAuxiliaryLibrary/WinCairoRequirements
 /WebKitSupportLibrary.zip
 /WebKitLibraries/win/
-!/WebKitLibraries/win/include/WebKitSystemInterface/
-!/WebKitLibraries/win/lib32/WebKitSystemInterface.lib
 !/WebKitLibraries/win/tools/scripts/
 
 # Ignore files generated by Qt Creator:


Modified: trunk/ChangeLog (258519 => 258520)

--- trunk/ChangeLog	2020-03-16 21:41:31 UTC (rev 258519)
+++ trunk/ChangeLog	2020-03-16 21:50:22 UTC (rev 258520)
@@ -1,3 +1,18 @@
+2020-03-16  Keith Rollin  
+
+Remove support for WebKitSystemInterface
+https://bugs.webkit.org/show_bug.cgi?id=208894
+
+
+Reviewed by Brent Fulgham.
+
+This project provided support for facilities that are now handled
+elsewhere and is no longer needed.
+
+* .gitignore:
+* Source/PlatformWin.cmake:
+* Source/cmake/OptionsAppleWin.cmake:
+
 2020-03-13  Sergio Villar Senin  
 
 [WebXR] IDLs, stubs and build configuration for WPE


Modified: trunk/Source/PlatformWin.cmake (258519 => 258520)

--- trunk/Source/PlatformWin.cmake	2020-03-16 21:41:31 UTC (rev 258519)
+++ trunk/Source/PlatformWin.cmake	2020-03-16 21:50:22 UTC (rev 258520)
@@ -10,10 +10,6 @@
 WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
 )
 
-if (EXISTS ${CMAKE_SOURCE_DIR}/../Internal/WebKit/WebKitSystemInterface/win/CMakeLists.txt)
-add_subdirectory(${CMAKE_SOURCE_DIR}/../Internal/WebKit/WebKitSystemInterface/win ${CMAKE_CURRENT_BINARY_DIR}/WebKitSystemInterface)
-endif ()
-
 if (EXISTS ${CMAKE_SOURCE_DIR}/../Internal/Tools/WKTestBrowser/CMakeLists.txt)
 add_subdirectory(${CMAKE_SOURCE_DIR}/../Internal/Tools/WKTestBrowser ${CMAKE_CURRENT_BINARY_DIR}/WKTestBrowser)
 endif ()


Modified: trunk/Source/cmake/OptionsAppleWin.cmake (258519 => 258520)

--- trunk/Source/cmake/OptionsAppleWin.cmake	2020-03-16 21:41:31 UTC (rev 258519)
+++ trunk/Source/cmake/OptionsAppleWin.cmake	2020-03-16 21:50:22 UTC (rev 258520)
@@ -1,5 +1,8 @@
-# The static runtime is required for AppleWin due to WebKitSystemInterface.lib
-# being compiled with a static runtime.
+# The static runtime used to be required for AppleWin due to
+# WebKitSystemInterface.lib being compiled with a static runtime. That library
+# is no longer used, but we keep building with static runtime for backward
+# compatibility. But if someone decides that it's OK to require existing
+# projects to build with the runtime DLLs, that's now technically possible.
 set(MSVC_STATIC_RUNTIME ON)
 
 if (DEFINED ENV{AppleApplicationSupportSDK})


Modified: trunk/Tools/ChangeLog (258519 => 258520)

--- trunk/Tools/ChangeLog	2020-03-16 21:41:31 UTC (rev 258519)
+++ trunk/Tools/ChangeLog	2020-03-16 21:50:22 UTC (rev 258520)
@@ -1,3 +1,16 @@
+2020-03-16  Keith Rollin  
+
+Remove support for WebKitSystemInterface
+https://bugs.webkit.org/show_bug.cgi?id=208894
+
+
+Reviewed by Brent Fulgham.
+
+This project provided support for facilities that are now handled
+elsewhere and is no longer needed.
+
+* Scripts/copy-webkitlibraries-to-product-directory:
+
 2020-03-16  Per Arne Vollan  
 
 [macOS] Accessibility sandbox regressions


Modified: trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory (258519 => 258520)

--- trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2020-03-16 21:41:31 UTC (rev 258519)
+++ trunk/Tools/Scripts/copy-webkitlibraries-to-product-directory	2020-03-16 21:50:22 UTC (rev 258520)
@@ -32,7 +32,6 @@
 use webkitdirs;
 
 my $showHelp = 0;
-my $wksi = 0;
 my $clean = 0;
 my $useFullLibPaths = 0;
 my $osxVersion;
@@ -44,7 +43,6 @@
 my $usage = < Usage: $programName [options]

[webkit-changes] [258519] trunk/Source/WebKitLegacy/mac

2020-03-16 Thread timothy_horton 
Title: [258519] trunk/Source/WebKitLegacy/mac








Revision 258519
Author timothy_hor...@apple.com
Date 2020-03-16 14:41:31 -0700 (Mon, 16 Mar 2020)


Log Message
Always include System.framework in WebKitLegacy's CPLUSPLUSFLAGS
https://bugs.webkit.org/show_bug.cgi?id=209147

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:
* Configurations/WebKitLegacy.xcconfig:
Bring WebKitLegacy's xcconfigs in line with all the other projects,
adding System.framework globally, and in Base.xcconfig.

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (258518 => 258519)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-03-16 21:11:00 UTC (rev 258518)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-03-16 21:41:31 UTC (rev 258519)
@@ -1,3 +1,15 @@
+2020-03-16  Timothy Horton  
+
+Always include System.framework in WebKitLegacy's CPLUSPLUSFLAGS
+https://bugs.webkit.org/show_bug.cgi?id=209147
+
+Reviewed by Darin Adler.
+
+* Configurations/Base.xcconfig:
+* Configurations/WebKitLegacy.xcconfig:
+Bring WebKitLegacy's xcconfigs in line with all the other projects,
+adding System.framework globally, and in Base.xcconfig.
+
 2020-03-16  Simon Fraser  
 
 Remove FrameView::scheduleRenderingUpdate()


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig (258518 => 258519)

--- trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig	2020-03-16 21:11:00 UTC (rev 258518)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig	2020-03-16 21:41:31 UTC (rev 258519)
@@ -123,7 +123,7 @@
 SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS);
-OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS);
+OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CPLUSPLUSFLAGS) -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 
 WK_COCOA_TOUCH = $(WK_COCOA_TOUCH_$(WK_PLATFORM_NAME));


Modified: trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig (258518 => 258519)

--- trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig	2020-03-16 21:11:00 UTC (rev 258518)
+++ trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig	2020-03-16 21:41:31 UTC (rev 258519)
@@ -45,7 +45,6 @@
 
 OTHER_CFLAGS = $(inherited) $(OTHER_CFLAGS_COCOA_TOUCH);
 OTHER_CFLAGS_COCOA_TOUCH = $(OTHER_CFLAGS_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
-OTHER_CFLAGS_COCOA_TOUCH_YES = -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders;
 OTHER_CFLAGS_COCOA_TOUCH_NO = -iframework $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Frameworks;
 OTHER_CPLUSPLUSFLAGS = $(inherited) $(OTHER_CFLAGS_COCOA_TOUCH);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258518] trunk

2020-03-16 Thread pvollan 
Title: [258518] trunk








Revision 258518
Author pvol...@apple.com
Date 2020-03-16 14:11:00 -0700 (Mon, 16 Mar 2020)


Log Message
[macOS] Accessibility sandbox regressions
https://bugs.webkit.org/show_bug.cgi?id=209065
Source/WebCore/PAL:


Reviewed by Brent Fulgham.

Add Accessibility notification name.

* pal/spi/cocoa/NSAccessibilitySPI.h:

Source/WebKit:



Reviewed by Brent Fulgham.

When Accessibility is enabled, the WebContent process needs access to the preference service, since Accessibility
is relying on some advanced features of the service. Also, when CF prefs direct mode is enabled, the WebContent
sandbox needs to explicitly allow reading of the various plist files.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
* WebProcess/com.apple.WebProcess.sb.in:

Tools:


Reviewed by Brent Fulgham.

* TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
(TEST):
* TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (258517 => 258518)

--- trunk/Source/WebCore/PAL/ChangeLog	2020-03-16 20:54:58 UTC (rev 258517)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-03-16 21:11:00 UTC (rev 258518)
@@ -1,3 +1,14 @@
+2020-03-16  Per Arne Vollan  
+
+[macOS] Accessibility sandbox regressions
+https://bugs.webkit.org/show_bug.cgi?id=209065
+
+Reviewed by Brent Fulgham.
+
+Add Accessibility notification name.
+
+* pal/spi/cocoa/NSAccessibilitySPI.h:
+
 2020-03-13  Sergio Villar Senin  
 
 [WebXR] IDLs, stubs and build configuration for WPE


Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h (258517 => 258518)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h	2020-03-16 20:54:58 UTC (rev 258517)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h	2020-03-16 21:11:00 UTC (rev 258518)
@@ -54,6 +54,8 @@
 
 WTF_EXTERN_C_BEGIN
 
+extern NSString *const NSApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification;
+
 void NSAccessibilityHandleFocusChanged();
 void NSAccessibilityUnregisterUniqueIdForUIElement(id element);
 


Modified: trunk/Source/WebKit/ChangeLog (258517 => 258518)

--- trunk/Source/WebKit/ChangeLog	2020-03-16 20:54:58 UTC (rev 258517)
+++ trunk/Source/WebKit/ChangeLog	2020-03-16 21:11:00 UTC (rev 258518)
@@ -1,5 +1,21 @@
 2020-03-16  Per Arne Vollan  
 
+[macOS] Accessibility sandbox regressions
+https://bugs.webkit.org/show_bug.cgi?id=209065
+
+
+Reviewed by Brent Fulgham.
+
+When Accessibility is enabled, the WebContent process needs access to the preference service, since Accessibility
+is relying on some advanced features of the service. Also, when CF prefs direct mode is enabled, the WebContent
+sandbox needs to explicitly allow reading of the various plist files.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::registerNotificationObservers):
+* WebProcess/com.apple.WebProcess.sb.in:
+
+2020-03-16  Per Arne Vollan  
+
 [Cocoa] Crash under -[WKPreferenceObserver init]
 https://bugs.webkit.org/show_bug.cgi?id=209145
 


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258517 => 258518)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-16 20:54:58 UTC (rev 258517)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-16 21:11:00 UTC (rev 258518)
@@ -613,6 +613,10 @@
 #if !PLATFORM(IOS_FAMILY)
 // Listen for enhanced accessibility changes and propagate them to the WebProcess.
 m_enhancedAccessibilityObserver = [[NSNotificationCenter defaultCenter] addObserverForName:WebKitApplicationDidChangeAccessibilityEnhancedUserInterfaceNotification object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *note) {
+#if ENABLE(CFPREFS_DIRECT_MODE)
+for (auto& process : m_processes)
+process->unblockPreferenceServiceIfNeeded();
+#endif
 setEnhancedAccessibility([[[note userInfo] objectForKey:@"AXEnhancedUserInterface"] boolValue]);
 }];
 
@@ -663,7 +667,9 @@
 #endif // PLATFORM(IOS)
 m_accessibilityEnabledObserver = [[NSNotificationCenter defaultCenter] addObserverForName:(__bridge id)kAXSApplicationAccessibilityEnabledNotification object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *) {
 for (size_t i = 0; i < m_processes.size(); ++i) {
+#if ENABLE(CFPREFS_DIRECT_MODE)

[webkit-changes] [258517] trunk/LayoutTests

2020-03-16 Thread lawrence . j 
Title: [258517] trunk/LayoutTests








Revision 258517
Author lawrenc...@apple.com
Date 2020-03-16 13:54:58 -0700 (Mon, 16 Mar 2020)


Log Message
[ Mac wk2 ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream tests are flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209148

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (258516 => 258517)

--- trunk/LayoutTests/ChangeLog	2020-03-16 20:21:03 UTC (rev 258516)
+++ trunk/LayoutTests/ChangeLog	2020-03-16 20:54:58 UTC (rev 258517)
@@ -1,3 +1,12 @@
+2020-03-16  Jason Lawrence  
+
+[ Mac wk2 ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream tests are flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=209148
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2020-03-16  Megan Gardner  
 
 Color Picker crashes on touch


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (258516 => 258517)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-16 20:21:03 UTC (rev 258516)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-03-16 20:54:58 UTC (rev 258517)
@@ -1089,4 +1089,8 @@
 
 webkit.org/b/209077 svg/custom/object-sizing-explicit-width.xhtml [ Pass Failure ]
 
-webkit.org/b/209052 fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/209052 fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html [ Pass Failure ]
+
+webkit.org/b/209148 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Pass Failure ]
+webkit.org/b/209148 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-removetrack.https.html [ Pass Failure ]
+webkit.org/b/209148 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-firstframe.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258516] trunk

2020-03-16 Thread megan_gardner 
Title: [258516] trunk








Revision 258516
Author megan_gard...@apple.com
Date 2020-03-16 13:21:03 -0700 (Mon, 16 Mar 2020)


Log Message
Color Picker crashes on touch
https://bugs.webkit.org/show_bug.cgi?id=209086

Reviewed by Darin Adler.

Source/WebCore:

Vector sizing lost in refactor. Not perfomance sensitive code, so just expanding vector as needed.

Test: fast/forms/color/color-input-activate-crash.html

* html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestedColors const):

LayoutTests:

* fast/forms/color/color-input-activate-crash-expected.txt: Added.
* fast/forms/color/color-input-activate-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ColorInputType.cpp


Added Paths

trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt
trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (258515 => 258516)

--- trunk/LayoutTests/ChangeLog	2020-03-16 20:11:01 UTC (rev 258515)
+++ trunk/LayoutTests/ChangeLog	2020-03-16 20:21:03 UTC (rev 258516)
@@ -1,3 +1,13 @@
+2020-03-16  Megan Gardner  
+
+Color Picker crashes on touch
+https://bugs.webkit.org/show_bug.cgi?id=209086
+
+Reviewed by Darin Adler.
+
+* fast/forms/color/color-input-activate-crash-expected.txt: Added.
+* fast/forms/color/color-input-activate-crash.html: Added.
+
 2020-03-16  Sihui Liu  
 
 IndexedDB hits assertion with crypto/workers/subtle/aes-indexeddb.html


Added: trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt (0 => 258516)

--- trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/color/color-input-activate-crash-expected.txt	2020-03-16 20:21:03 UTC (rev 258516)
@@ -0,0 +1,3 @@
+Touching the color input form should not crash.
+
+PASS: Test did not crash


Added: trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html (0 => 258516)

--- trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/color/color-input-activate-crash.html	2020-03-16 20:21:03 UTC (rev 258516)
@@ -0,0 +1,28 @@
+
+
+
+
+
+