[webkit-changes] [269945] trunk/Tools
Title: [269945] trunk/Tools
Revision 269945
Author dp...@igalia.com
Date 2020-11-17 22:37:17 -0800 (Tue, 17 Nov 2020)
Log Message
[buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
https://bugs.webkit.org/show_bug.cgi?id=213016
Reviewed by Carlos Alberto Lopez Perez.
Add a new post-commit bot to test WebKitGTK using GTK4 library.
The bot builds WebKitGTK and runs the following test suites: layout-test, api-test
and webdriver-test.
* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories.py:
(BuildAndTestAllButJSCFactory):
(BuildAndTestAllButJSCFactory.getProduct):
(BuildAndTestAllButJSCFactory.__init__):
* CISupport/build-webkit-org/steps_unittest.py:
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories.py
trunk/Tools/CISupport/build-webkit-org/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (269944 => 269945)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2020-11-18 06:37:17 UTC (rev 269945)
@@ -101,6 +101,7 @@
{ "name": "gtk-linux-bot-15", "platform": "gtk" },
{ "name": "gtk-linux-bot-16", "platform": "gtk" },
{ "name": "gtk-linux-bot-17", "platform": "gtk" },
+{ "name": "gtk-linux-bot-18", "platform": "gtk" },
{ "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
{ "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
@@ -408,6 +409,11 @@
"workernames": ["gtk-linux-bot-17"]
},
{
+ "name": "GTK-Linux-64-bit-Release-GTK4-Tests", "factory": "BuildAndTestAllButJSCFactory", "builddir": "gtk-linux-64-release-gtk4",
+ "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+ "workernames": ["gtk-linux-bot-18"]
+},
+{
"name": "WinCairo-64-bit-WKL-Release-Build", "factory": "BuildFactory", "builddir": "wincairo-wkl-release",
"platform": "wincairo", "configuration": "release", "architectures": ["x86_64"],
"triggers": ["wincairo-wkl-release-tests", "wincairo-jsc-release-tests"],
Modified: trunk/Tools/CISupport/build-webkit-org/factories.py (269944 => 269945)
--- trunk/Tools/CISupport/build-webkit-org/factories.py 2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/CISupport/build-webkit-org/factories.py 2020-11-18 06:37:17 UTC (rev 269945)
@@ -174,6 +174,14 @@
JSCTestClass = None
+class BuildAndTestAllButJSCFactory(BuildAndTestFactory):
+JSCTestClass = None
+
+def __init__(self, platform, configuration, architectures, triggers=None, additionalArguments=None, device_model=None, **kwargs):
+BuildAndTestFactory.__init__(self, platform, configuration, architectures, additionalArguments, device_model, **kwargs)
+self.addStep(RunWebDriverTests())
+
+
class BuildAndGenerateJSCBundleFactory(BuildFactory):
ShouldRunJSCBundleStep = True
Modified: trunk/Tools/CISupport/build-webkit-org/steps_unittest.py (269944 => 269945)
--- trunk/Tools/CISupport/build-webkit-org/steps_unittest.py 2020-11-18 06:27:30 UTC (rev 269944)
+++ trunk/Tools/CISupport/build-webkit-org/steps_unittest.py 2020-11-18 06:37:17 UTC (rev 269945)
@@ -583,6 +583,7 @@
'GTK-Linux-64-bit-Release-Wayland-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'extract-test-results', 'API-tests', 'webdriver-test'],
'GTK-Linux-64-bit-Release-Ubuntu-LTS-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
'GTK-Linux-64-bit-Release-Debian-Stable-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
+'GTK-Linux-64-bit-Release-GTK4-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'extract-test-results', 'API-tests', 'webdriver-test'],
'PlayStation-Debug-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'compile-webkit'],
'PlayStation-Release-Build': ['configure-build',
[webkit-changes] [269944] trunk/Source/WebCore
Title: [269944] trunk/Source/WebCore
Revision 269944
Author s...@apple.com
Date 2020-11-17 22:27:30 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION(r269614): [iOS] WebContent crashes when entering Full Screen video with text captions
https://bugs.webkit.org/show_bug.cgi?id=219065
Reviewed by Tim Horton.
Pass a CGImageRef of the video caption to CALayer instead of passing a
NativeImage which is now a WebCore class.
* platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
(WebCore::TextTrackRepresentationCocoa::update):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (269943 => 269944)
--- trunk/Source/WebCore/ChangeLog 2020-11-18 06:15:45 UTC (rev 269943)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 06:27:30 UTC (rev 269944)
@@ -1,3 +1,16 @@
+2020-11-17 Said Abou-Hallawa
+
+REGRESSION(r269614): [iOS] WebContent crashes when entering Full Screen video with text captions
+https://bugs.webkit.org/show_bug.cgi?id=219065
+
+Reviewed by Tim Horton.
+
+Pass a CGImageRef of the video caption to CALayer instead of passing a
+NativeImage which is now a WebCore class.
+
+* platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
+(WebCore::TextTrackRepresentationCocoa::update):
+
2020-11-16 Yusuke Suzuki
[JSC] Implement WebAssembly.Memory with shared
Modified: trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm (269943 => 269944)
--- trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2020-11-18 06:15:45 UTC (rev 269943)
+++ trunk/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm 2020-11-18 06:27:30 UTC (rev 269944)
@@ -130,7 +130,7 @@
void TextTrackRepresentationCocoa::update()
{
if (auto representation = m_client.createTextTrackRepresentationImage())
-[m_layer.get() setContents:(__bridge id)representation->nativeImage().get()];
+[m_layer.get() setContents:(__bridge id)representation->nativeImage()->platformImage().get()];
}
void TextTrackRepresentationCocoa::setContentScale(float scale)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269943] trunk/Source/WebKit
Title: [269943] trunk/Source/WebKit Revision 269943 Author timothy_hor...@apple.com Date 2020-11-17 22:15:45 -0800 (Tue, 17 Nov 2020) Log Message GPU-process-hosted RemoteLayerBackingStore should flush off the main thread https://bugs.webkit.org/show_bug.cgi?id=219063 Reviewed by Simon Fraser. * GPUProcess/graphics/RemoteRenderingBackend.h: * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::display): Construct the ImageBuffer flusher /after/ submitting the final DisplayList, so that it takes the correct flush identifier. * GPUProcess/graphics/RemoteImageBuffer.h: * GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::didFlush): (WebKit::RemoteRenderingBackend::flushDisplayListWasCommitted): Deleted. * WebProcess/GPU/graphics/RemoteImageBufferProxy.h: (WebKit::RemoteImageBufferProxy::didFlush): (WebKit::RemoteImageBufferProxy::lastSentFlushIdentifier const): (WebKit::RemoteImageBufferProxy::waitForDidFlushOnSecondaryThread): (WebKit::RemoteImageBufferProxy::hasPendingFlush const): (WebKit::RemoteImageBufferProxy::waitForDidFlushWithTimeout): (WebKit::ThreadSafeRemoteImageBufferFlusher::ThreadSafeRemoteImageBufferFlusher): (WebKit::RemoteImageBufferProxy::commitFlushDisplayList): Deleted. (WebKit::RemoteImageBufferProxy::isPendingFlush const): Deleted. (WebKit::RemoteImageBufferProxy::timeoutWaitForFlushDisplayListWasCommitted): Deleted. Some renames: Rename flushDisplayListWasCommitted to didFlush; this is the back-message from GPU process to Web Content process that a FlushContext display list item was completed successfully. Rename isPendingFlush to hasPendingFlush, for grammar. Rename timeoutWaitForFlushDisplayListWasCommitted to waitForDidFlushWithTimeout, for similar reasons. Rename waitForFlushDisplayListWasCommitted to waitForDidFlush. Rename commitFlushDisplayList to didFlush. * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::waitForDidFlush): (WebKit::RemoteRenderingBackendProxy::didFlush): (WebKit::RemoteRenderingBackendProxy::waitForFlushDisplayListWasCommitted): Deleted. (WebKit::RemoteRenderingBackendProxy::flushDisplayListWasCommitted): Deleted. * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in: Reimplement ThreadSafeRemoteImageBufferFlusher such that it waits (on the RemoteLayerTreeDrawingArea CommitQueue, in the only current use of it) for the correct flush reply to come in before continuing. This is analogous to what we do for in-process buffers, where we call CGContextFlush() in the flusher. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in Diff Modified: trunk/Source/WebKit/ChangeLog (269942 => 269943) --- trunk/Source/WebKit/ChangeLog 2020-11-18 05:09:50 UTC (rev 269942) +++ trunk/Source/WebKit/ChangeLog 2020-11-18 06:15:45 UTC (rev 269943) @@ -1,3 +1,52 @@ +2020-11-17 Tim Horton + +GPU-process-hosted RemoteLayerBackingStore should flush off the main thread +https://bugs.webkit.org/show_bug.cgi?id=219063 + +Reviewed by Simon Fraser. + +* GPUProcess/graphics/RemoteRenderingBackend.h: +* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: +(WebKit::RemoteLayerBackingStore::display): +Construct the ImageBuffer flusher /after/ submitting the final DisplayList, +so that it takes the correct flush identifier. + +* GPUProcess/graphics/RemoteImageBuffer.h: +* GPUProcess/graphics/RemoteRenderingBackend.cpp: +(WebKit::RemoteRenderingBackend::didFlush): +(WebKit::RemoteRenderingBackend::flushDisplayListWasCommitted): Deleted. +* WebProcess/GPU/graphics/RemoteImageBufferProxy.h: +(WebKit::RemoteImageBufferProxy::didFlush): +(WebKit::RemoteImageBufferProxy::lastSentFlushIdentifier const): +(WebKit::RemoteImageBufferProxy::waitForDidFlushOnSecondaryThread): +(WebKit::RemoteImageBufferProxy::hasPendingFlush const): +(WebKit::RemoteImageBufferProxy::waitForDidFlushWithTimeout): +(WebKit::ThreadSafeRemoteImageBufferFlusher::ThreadSafeRemoteImageBufferFlusher): +(WebKit::RemoteImageBufferProxy::commitFlushDisplayList): Deleted. +(WebKit::RemoteImageBufferProxy::isPendingFlush const): Deleted. +(WebKit::RemoteImageBufferProxy::timeoutWaitForFlushDisplayListWasCommitted):
[webkit-changes] [269942] trunk/LayoutTests
Title: [269942] trunk/LayoutTests
Revision 269942
Author lmo...@igalia.com
Date 2020-11-17 21:09:50 -0800 (Tue, 17 Nov 2020)
Log Message
[GLIB] Update webaudio baselines after r269853
Unreviewed test gardening.
* platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt: Removed.
* platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt
Removed Paths
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/
Diff
Modified: trunk/LayoutTests/ChangeLog (269941 => 269942)
--- trunk/LayoutTests/ChangeLog 2020-11-18 05:01:00 UTC (rev 269941)
+++ trunk/LayoutTests/ChangeLog 2020-11-18 05:09:50 UTC (rev 269942)
@@ -1,5 +1,15 @@
2020-11-17 Lauro Moura
+[GLIB] Update webaudio baselines after r269853
+
+Unreviewed test gardening.
+
+* platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt: Removed.
+* platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt: Removed.
+* platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt:
+
+2020-11-17 Lauro Moura
+
Gardening webrtc/audio-sframe.html flaky crashes
Unreviewed test gardening.
Modified: trunk/LayoutTests/platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt (269941 => 269942)
--- trunk/LayoutTests/platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt 2020-11-18 05:01:00 UTC (rev 269941)
+++ trunk/LayoutTests/platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt 2020-11-18 05:09:50 UTC (rev 269942)
@@ -7,32 +7,32 @@
PASS Audit report
PASS > [peaking-complex-roots] complex roots
PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): Actual Tail Frame 2304 is greater than or equal to 2077.
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[0:127] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[128:255] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[256:383] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[384:511] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[512:639] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[640:767] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[768:895] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[896:1023] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1024:1151] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1152:1279] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1280:1407] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1408:1535] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1536:1663] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1664:1791] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1792:1919] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}): output[1920:2047] is not constantly 0 (contains 128 different values).
-PASS Peaking complex roots: Biquad({"type":"peaking","Q":10,"gain":40,"frequency":4096}):
[webkit-changes] [269941] trunk/LayoutTests
Title: [269941] trunk/LayoutTests Revision 269941 Author lmo...@igalia.com Date 2020-11-17 21:01:00 -0800 (Tue, 17 Nov 2020) Log Message Gardening webrtc/audio-sframe.html flaky crashes Unreviewed test gardening. * platform/glib/TestExpectations: * platform/ios-simulator-wk2/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (269940 => 269941) --- trunk/LayoutTests/ChangeLog 2020-11-18 03:46:39 UTC (rev 269940) +++ trunk/LayoutTests/ChangeLog 2020-11-18 05:01:00 UTC (rev 269941) @@ -1,3 +1,13 @@ +2020-11-17 Lauro Moura + +Gardening webrtc/audio-sframe.html flaky crashes + +Unreviewed test gardening. + +* platform/glib/TestExpectations: +* platform/ios-simulator-wk2/TestExpectations: +* platform/mac/TestExpectations: + 2020-11-16 Yusuke Suzuki [JSC] Implement WebAssembly.Memory with shared Modified: trunk/LayoutTests/platform/glib/TestExpectations (269940 => 269941) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-11-18 03:46:39 UTC (rev 269940) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-11-18 05:01:00 UTC (rev 269941) @@ -869,6 +869,8 @@ webkit.org/b/218787 webrtc/ice-candidate-sdpMLineIndex.html [ Timeout ] webkit.org/b/218787 webrtc/webrtc-transform.html [ Failure ] +webkit.org/b/219066 webrtc/audio-sframe.html [ Failure Crash ] + # # End of WebRTC-related bugs # Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (269940 => 269941) --- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2020-11-18 03:46:39 UTC (rev 269940) +++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2020-11-18 05:01:00 UTC (rev 269941) @@ -163,3 +163,5 @@ webkit.org/b/217268 imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html [ Failure ] webkit.org/b/209139 fast/canvas/webgl/webgl-clear-composited-notshowing.html [ Failure ] + +webkit.org/b/219066 webrtc/audio-sframe.html [ Pass Crash ] Modified: trunk/LayoutTests/platform/mac/TestExpectations (269940 => 269941) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-11-18 03:46:39 UTC (rev 269940) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-11-18 05:01:00 UTC (rev 269941) @@ -2261,3 +2261,5 @@ # rdar://rdar://71039166 [ Mojave ] http/tests/canvas/color-fonts [ Skip ] + +webkit.org/b/219066 [ Mojave Catalina ] webrtc/audio-sframe.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269939] trunk
Title: [269939] trunk
Revision 269939
Author ysuz...@apple.com
Date 2020-11-17 19:19:04 -0800 (Tue, 17 Nov 2020)
Log Message
[JSC] Enable static public class fields
https://bugs.webkit.org/show_bug.cgi?id=219058
Reviewed by Saam Barati.
JSTests:
* stress/big-int-as-property-name.js:
* stress/class-fields-bytecode-cache.js:
* stress/class-fields-computed-to-property-key.js:
* stress/class-fields-function-name.js:
* stress/class-fields-harmony.js:
* stress/class-fields-private-use-eval.js:
* stress/class-fields-proxy-define-property.js:
* stress/class-fields-stress-instance.js:
* stress/class-fields-to-property-key-const-string-ftl.js:
* stress/class-fields-to-property-key-const-symbol-ftl.js:
* stress/class-fields-to-property-key-slow-object-tostring-ftl.js:
* stress/class-fields-to-property-key-slow-object-valueof-ftl.js:
* stress/class-fields-to-property-key-string-object-ftl.js:
* stress/class-fields-to-property-key-string-or-string-object-ftl.js:
* stress/class-fields-with-special-names.js:
* stress/generator-syntax.js:
* stress/method-name.js:
* stress/private-name-access-in-computed-property.js:
* test262/config.yaml:
Source/_javascript_Core:
Let's flip the runtime flag (usePublicStaticClassFields). And we drop usePublicClassFields flag since it is already shipped.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallValueNode::emitBytecode):
* parser/Parser.cpp:
(JSC::Parser::parseClass):
* runtime/OptionsList.h:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/big-int-as-property-name.js
trunk/JSTests/stress/class-fields-bytecode-cache.js
trunk/JSTests/stress/class-fields-computed-to-property-key.js
trunk/JSTests/stress/class-fields-function-name.js
trunk/JSTests/stress/class-fields-harmony.js
trunk/JSTests/stress/class-fields-private-use-eval.js
trunk/JSTests/stress/class-fields-proxy-define-property.js
trunk/JSTests/stress/class-fields-stress-instance.js
trunk/JSTests/stress/class-fields-to-property-key-const-string-ftl.js
trunk/JSTests/stress/class-fields-to-property-key-const-symbol-ftl.js
trunk/JSTests/stress/class-fields-to-property-key-slow-object-tostring-ftl.js
trunk/JSTests/stress/class-fields-to-property-key-slow-object-valueof-ftl.js
trunk/JSTests/stress/class-fields-to-property-key-string-object-ftl.js
trunk/JSTests/stress/class-fields-to-property-key-string-or-string-object-ftl.js
trunk/JSTests/stress/class-fields-with-special-names.js
trunk/JSTests/stress/generator-syntax.js
trunk/JSTests/stress/method-name.js
trunk/JSTests/stress/private-name-access-in-computed-property.js
trunk/JSTests/test262/config.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h
Diff
Modified: trunk/JSTests/ChangeLog (269938 => 269939)
--- trunk/JSTests/ChangeLog 2020-11-18 01:31:05 UTC (rev 269938)
+++ trunk/JSTests/ChangeLog 2020-11-18 03:19:04 UTC (rev 269939)
@@ -1,3 +1,30 @@
+2020-11-17 Yusuke Suzuki
+
+[JSC] Enable static public class fields
+https://bugs.webkit.org/show_bug.cgi?id=219058
+
+Reviewed by Saam Barati.
+
+* stress/big-int-as-property-name.js:
+* stress/class-fields-bytecode-cache.js:
+* stress/class-fields-computed-to-property-key.js:
+* stress/class-fields-function-name.js:
+* stress/class-fields-harmony.js:
+* stress/class-fields-private-use-eval.js:
+* stress/class-fields-proxy-define-property.js:
+* stress/class-fields-stress-instance.js:
+* stress/class-fields-to-property-key-const-string-ftl.js:
+* stress/class-fields-to-property-key-const-symbol-ftl.js:
+* stress/class-fields-to-property-key-slow-object-tostring-ftl.js:
+* stress/class-fields-to-property-key-slow-object-valueof-ftl.js:
+* stress/class-fields-to-property-key-string-object-ftl.js:
+* stress/class-fields-to-property-key-string-or-string-object-ftl.js:
+* stress/class-fields-with-special-names.js:
+* stress/generator-syntax.js:
+* stress/method-name.js:
+* stress/private-name-access-in-computed-property.js:
+* test262/config.yaml:
+
2020-11-17 Sergey Rubanov
Add support for the Wasm i32 sign-extension-ops proposal
Modified: trunk/JSTests/stress/big-int-as-property-name.js (269938 => 269939)
--- trunk/JSTests/stress/big-int-as-property-name.js 2020-11-18 01:31:05 UTC (rev 269938)
+++ trunk/JSTests/stress/big-int-as-property-name.js 2020-11-18 03:19:04 UTC (rev 269939)
@@ -1,5 +1,3 @@
-//@ runDefault("--usePublicClassFields=true")
-
let assert = {
sameValue(a, e) {
if (a !== e)
Modified: trunk/JSTests/stress/class-fields-bytecode-cache.js (269938 => 269939)
---
[webkit-changes] [269938] trunk/Source/WebCore
Title: [269938] trunk/Source/WebCore
Revision 269938
Author za...@apple.com
Date 2020-11-17 17:31:05 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION (r269744): ASSERTION FAILED: m_hasValidContentHeight in WebCore::Layout::BoxGeometry::contentBoxHeight()
https://bugs.webkit.org/show_bug.cgi?id=219004
Reviewed by Antti Koivisto.
Unfortunately we have to disable all percentage height/width content until after the integration codepath is fixed.
(in this case, the layout code assumes that percentage height values can always be resolved by climbing up on the
ancestor chain -worst case scenario we find the ICB which always has fixed height value.
However the integration codepath does not set the height on the fake ICB (RenderBlockFlow) even when the flow's height
is fixed and the IFC code can't climb farther up on the tree)
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (269937 => 269938)
--- trunk/Source/WebCore/ChangeLog 2020-11-18 01:24:56 UTC (rev 269937)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 01:31:05 UTC (rev 269938)
@@ -1,3 +1,20 @@
+2020-11-17 Zalan Bujtas
+
+REGRESSION (r269744): ASSERTION FAILED: m_hasValidContentHeight in WebCore::Layout::BoxGeometry::contentBoxHeight()
+https://bugs.webkit.org/show_bug.cgi?id=219004
+
+
+Reviewed by Antti Koivisto.
+
+Unfortunately we have to disable all percentage height/width content until after the integration codepath is fixed.
+(in this case, the layout code assumes that percentage height values can always be resolved by climbing up on the
+ancestor chain -worst case scenario we find the ICB which always has fixed height value.
+However the integration codepath does not set the height on the fake ICB (RenderBlockFlow) even when the flow's height
+is fixed and the IFC code can't climb farther up on the tree)
+
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForChild):
+
2020-11-17 Megan Gardner
Fix for localizableStrings.string in WebCore
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (269937 => 269938)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-18 01:24:56 UTC (rev 269937)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-18 01:31:05 UTC (rev 269938)
@@ -583,13 +583,11 @@
auto isSupportedStyle = [] (const auto& style) {
if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
return false;
-auto& width = style.width();
-auto& height = style.height();
-if (width.isPercent() || height.isPercent())
+if (style.width().isPercent() || style.height().isPercent())
return false;
-if (width.isAuto() && (style.minWidth().isPercent() || style.maxWidth().isPercent()))
+if (style.minWidth().isPercent() || style.maxWidth().isPercent())
return false;
-if (height.isAuto() && (style.minHeight().isPercent() || style.maxHeight().isPercent()))
+if (style.minHeight().isPercent() || style.maxHeight().isPercent())
return false;
return true;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269937] trunk/Source/WebCore
Title: [269937] trunk/Source/WebCore
Revision 269937
Author megan_gard...@apple.com
Date 2020-11-17 17:24:56 -0800 (Tue, 17 Nov 2020)
Log Message
Fix for localizableStrings.string in WebCore
https://bugs.webkit.org/show_bug.cgi?id=219060
Unreviewed build fix.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (269936 => 269937)
--- trunk/Source/WebCore/ChangeLog 2020-11-18 00:49:46 UTC (rev 269936)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 01:24:56 UTC (rev 269937)
@@ -1,3 +1,12 @@
+2020-11-17 Megan Gardner
+
+Fix for localizableStrings.string in WebCore
+https://bugs.webkit.org/show_bug.cgi?id=219060
+
+Unreviewed build fix.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2020-11-17 Fujii Hironori
Use SetForScope to temporarily change members of TextureMapperPaintOptions instead of copying all members
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (269936 => 269937)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-11-18 00:49:46 UTC (rev 269936)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-11-18 01:24:56 UTC (rev 269937)
@@ -35478,7 +35478,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "if [ -e $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.txt ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.txt > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelif [ -e $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.txt ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.txt > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelse\ncp $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nfi\n";
+ shellScript = "if [ -e $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings.txt ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings.txt > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelif [ -e $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings..txt ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings.txt > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelse\ncp $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nfi\n";
};
5325BDCC21DFF33E00A0DEE1 /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269936] trunk/Source/WebCore
Title: [269936] trunk/Source/WebCore
Revision 269936
Author hironori.fu...@sony.com
Date 2020-11-17 16:49:46 -0800 (Tue, 17 Nov 2020)
Log Message
Use SetForScope to temporarily change members of TextureMapperPaintOptions instead of copying all members
https://bugs.webkit.org/show_bug.cgi?id=219022
Reviewed by Carlos Garcia Campos.
All members of TextureMapperPaintOptions don't need to be copied
just to change some members. Use WTF::SetForScope to temporarily
change members of TextureMapperPaintOptions.
No behavior changes.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::TextureMapperLayer::applyMask):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
* platform/graphics/texmap/TextureMapperLayer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (269935 => 269936)
--- trunk/Source/WebCore/ChangeLog 2020-11-18 00:42:10 UTC (rev 269935)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 00:49:46 UTC (rev 269936)
@@ -1,3 +1,28 @@
+2020-11-17 Fujii Hironori
+
+Use SetForScope to temporarily change members of TextureMapperPaintOptions instead of copying all members
+https://bugs.webkit.org/show_bug.cgi?id=219022
+
+Reviewed by Carlos Garcia Campos.
+
+All members of TextureMapperPaintOptions don't need to be copied
+just to change some members. Use WTF::SetForScope to temporarily
+change members of TextureMapperPaintOptions.
+
+No behavior changes.
+
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::TextureMapperLayer::paintSelf):
+(WebCore::TextureMapperLayer::paintSelfAndChildren):
+(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
+(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
+(WebCore::TextureMapperLayer::applyMask):
+(WebCore::TextureMapperLayer::paintIntoSurface):
+(WebCore::commitSurface):
+(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
+(WebCore::TextureMapperLayer::paintRecursive):
+* platform/graphics/texmap/TextureMapperLayer.h:
+
2020-11-17 Megan Gardner
Fix for localizableStrings.string in WebCore
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (269935 => 269936)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2020-11-18 00:42:10 UTC (rev 269935)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2020-11-18 00:49:46 UTC (rev 269936)
@@ -24,6 +24,7 @@
#include "GraphicsLayerTextureMapper.h"
#include "Region.h"
#include
+#include
namespace WebCore {
@@ -151,7 +152,7 @@
return color.colorWithAlphaMultipliedBy(opacity);
}
-void TextureMapperLayer::paintSelf(const TextureMapperPaintOptions& options)
+void TextureMapperLayer::paintSelf(TextureMapperPaintOptions& options)
{
if (!m_state.visible || !m_state.contentsVisible)
return;
@@ -218,7 +219,7 @@
});
}
-void TextureMapperLayer::paintSelfAndChildren(const TextureMapperPaintOptions& options)
+void TextureMapperLayer::paintSelfAndChildren(TextureMapperPaintOptions& options)
{
if (m_state.backdropLayer && m_state.backdropLayer == options.backdropLayer)
return;
@@ -294,12 +295,12 @@
return true;
}
-void TextureMapperLayer::paintSelfAndChildrenWithReplica(const TextureMapperPaintOptions& options)
+void TextureMapperLayer::paintSelfAndChildrenWithReplica(TextureMapperPaintOptions& options)
{
if (m_state.replicaLayer) {
-TextureMapperPaintOptions replicaOptions(options);
-replicaOptions.transform.multiply(replicaTransform());
-paintSelfAndChildren(replicaOptions);
+SetForScope scopedTransform(options.transform, options.transform);
+options.transform.multiply(replicaTransform());
+paintSelfAndChildren(options);
}
paintSelfAndChildren(options);
@@ -367,7 +368,7 @@
}
}
-void TextureMapperLayer::paintUsingOverlapRegions(const TextureMapperPaintOptions& options)
+void TextureMapperLayer::paintUsingOverlapRegions(TextureMapperPaintOptions& options)
{
Region overlapRegion;
Region nonOverlapRegion;
@@ -421,7 +422,7 @@
}
}
-void TextureMapperLayer::applyMask(const TextureMapperPaintOptions& options)
+void TextureMapperLayer::applyMask(TextureMapperPaintOptions& options)
{
options.textureMapper.setMaskMode(true);
paintSelf(options);
@@ -432,10 +433,9 @@
{
[webkit-changes] [269935] trunk/Source/WebKit
Title: [269935] trunk/Source/WebKit Revision 269935 Author cdu...@apple.com Date 2020-11-17 16:42:10 -0800 (Tue, 17 Nov 2020) Log Message [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcess::didReceiveMessage https://bugs.webkit.org/show_bug.cgi?id=219055 Reviewed by Alex Christensen. Make sure GPUProcess::prepareToSuspend() calls its completion handler to avoid delaying suspension and avoid assertion hits in debug. * GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::prepareToSuspend): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/GPUProcess.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (269934 => 269935) --- trunk/Source/WebKit/ChangeLog 2020-11-18 00:36:12 UTC (rev 269934) +++ trunk/Source/WebKit/ChangeLog 2020-11-18 00:42:10 UTC (rev 269935) @@ -1,5 +1,19 @@ 2020-11-17 Chris Dumez +[iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcess::didReceiveMessage +https://bugs.webkit.org/show_bug.cgi?id=219055 + + +Reviewed by Alex Christensen. + +Make sure GPUProcess::prepareToSuspend() calls its completion handler to avoid delaying suspension +and avoid assertion hits in debug. + +* GPUProcess/GPUProcess.cpp: +(WebKit::GPUProcess::prepareToSuspend): + +2020-11-17 Chris Dumez + Make sure ProcessThrottler is always holding a ProcessAssertion for its child process https://bugs.webkit.org/show_bug.cgi?id=219053 Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.cpp (269934 => 269935) --- trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2020-11-18 00:36:12 UTC (rev 269934) +++ trunk/Source/WebKit/GPUProcess/GPUProcess.cpp 2020-11-18 00:42:10 UTC (rev 269935) @@ -163,6 +163,7 @@ RELEASE_LOG(ProcessSuspension, "%p - GPUProcess::prepareToSuspend(), isSuspensionImminent: %d", this, isSuspensionImminent); lowMemoryHandler(Critical::Yes); +completionHandler(); } void GPUProcess::processDidResume() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269934] trunk/Source/WebKit
Title: [269934] trunk/Source/WebKit
Revision 269934
Author cdu...@apple.com
Date 2020-11-17 16:36:12 -0800 (Tue, 17 Nov 2020)
Log Message
Make sure ProcessThrottler is always holding a ProcessAssertion for its child process
https://bugs.webkit.org/show_bug.cgi?id=219053
Reviewed by Geoff Garen.
Make sure ProcessThrottler is always holding a ProcessAssertion for its child process. Previously, when changing the assertion
type (e.g. when going from background to foreground) we would release the previous assertion and then take the new one.
RunningBoard developers recommend that we wait until the new ProcessAssertion is taken before we release the previous one to
avoid churn. It is also important we always hold a ProcessAssertion at all times for the child process because the child process
may exit otherwise.
* UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::setAssertionType):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ProcessThrottler.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (269933 => 269934)
--- trunk/Source/WebKit/ChangeLog 2020-11-18 00:04:16 UTC (rev 269933)
+++ trunk/Source/WebKit/ChangeLog 2020-11-18 00:36:12 UTC (rev 269934)
@@ -1,5 +1,22 @@
2020-11-17 Chris Dumez
+Make sure ProcessThrottler is always holding a ProcessAssertion for its child process
+https://bugs.webkit.org/show_bug.cgi?id=219053
+
+Reviewed by Geoff Garen.
+
+Make sure ProcessThrottler is always holding a ProcessAssertion for its child process. Previously, when changing the assertion
+type (e.g. when going from background to foreground) we would release the previous assertion and then take the new one.
+
+RunningBoard developers recommend that we wait until the new ProcessAssertion is taken before we release the previous one to
+avoid churn. It is also important we always hold a ProcessAssertion at all times for the child process because the child process
+may exit otherwise.
+
+* UIProcess/ProcessThrottler.cpp:
+(WebKit::ProcessThrottler::setAssertionType):
+
+2020-11-17 Chris Dumez
+
[macOS] Stop using RunLoopType=_WebKit starting in Big Sur
https://bugs.webkit.org/show_bug.cgi?id=219052
Modified: trunk/Source/WebKit/UIProcess/ProcessThrottler.cpp (269933 => 269934)
--- trunk/Source/WebKit/UIProcess/ProcessThrottler.cpp 2020-11-18 00:04:16 UTC (rev 269933)
+++ trunk/Source/WebKit/UIProcess/ProcessThrottler.cpp 2020-11-18 00:36:12 UTC (rev 269934)
@@ -127,6 +127,10 @@
return;
PROCESSTHROTTLER_RELEASE_LOG("setAssertionType: Updating process assertion type to %u (foregroundActivities: %u, backgroundActivities: %u)", newType, m_foregroundActivities.size(), m_backgroundActivities.size());
+
+// Keep the previous assertion around until after the new one has been created so that we always hold
+// a process assertion for the process.
+auto previousAssertion = std::exchange(m_assertion, nullptr);
if (m_shouldTakeUIBackgroundAssertion) {
auto assertion = makeUnique(m_processIdentifier, assertionName(newType), newType);
assertion->setUIAssertionExpirationHandler([this] {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269933] trunk/Source/JavaScriptCore
Title: [269933] trunk/Source/_javascript_Core Revision 269933 Author commit-qu...@webkit.org Date 2020-11-17 16:04:16 -0800 (Tue, 17 Nov 2020) Log Message [CMake] generate_offset_extractor.rb missing build dependency for llint/WebAssembly.asm https://bugs.webkit.org/show_bug.cgi?id=219043 Patch by Michael Catanzaro on 2020-11-17 Reviewed by Don Olmstead. generate_offset_extractor.rb is missing a build dependency for llint/WebAssembly.asm. If WebAssembly.asm is modified, generate_offset_extracter.rb needs to be run again. * CMakeLists.txt: Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (269932 => 269933) --- trunk/Source/_javascript_Core/CMakeLists.txt 2020-11-18 00:00:19 UTC (rev 269932) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2020-11-18 00:04:16 UTC (rev 269933) @@ -192,6 +192,7 @@ llint/LowLevelInterpreter.asm llint/LowLevelInterpreter32_64.asm llint/LowLevelInterpreter64.asm +llint/WebAssembly.asm ) set(OFFLINE_ASM Modified: trunk/Source/_javascript_Core/ChangeLog (269932 => 269933) --- trunk/Source/_javascript_Core/ChangeLog 2020-11-18 00:00:19 UTC (rev 269932) +++ trunk/Source/_javascript_Core/ChangeLog 2020-11-18 00:04:16 UTC (rev 269933) @@ -1,3 +1,15 @@ +2020-11-17 Michael Catanzaro + +[CMake] generate_offset_extractor.rb missing build dependency for llint/WebAssembly.asm +https://bugs.webkit.org/show_bug.cgi?id=219043 + +Reviewed by Don Olmstead. + +generate_offset_extractor.rb is missing a build dependency for llint/WebAssembly.asm. If +WebAssembly.asm is modified, generate_offset_extracter.rb needs to be run again. + +* CMakeLists.txt: + 2020-11-17 Saam Barati Add more info to the RELEASE_ASSERT inside Parser::parseInner ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269932] trunk/Source/WebCore
Title: [269932] trunk/Source/WebCore
Revision 269932
Author megan_gard...@apple.com
Date 2020-11-17 16:00:19 -0800 (Tue, 17 Nov 2020)
Log Message
Fix for localizableStrings.string in WebCore
https://bugs.webkit.org/show_bug.cgi?id=219056
Unreviewed build fix.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (269931 => 269932)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 23:53:49 UTC (rev 269931)
+++ trunk/Source/WebCore/ChangeLog 2020-11-18 00:00:19 UTC (rev 269932)
@@ -1,3 +1,12 @@
+2020-11-17 Megan Gardner
+
+Fix for localizableStrings.string in WebCore
+https://bugs.webkit.org/show_bug.cgi?id=219056
+
+Unreviewed build fix.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2020-11-17 Adrian Perez de Castro
Unreviewed build fix for non-unified builds.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (269931 => 269932)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-11-17 23:53:49 UTC (rev 269931)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-11-18 00:00:19 UTC (rev 269932)
@@ -35478,7 +35478,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "if [ -e $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelif [ -e $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelse\ncp $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nfi\n";
+ shellScript = "if [ -e $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.txt ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.txt > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelif [ -e $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.txt ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.txt > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelse\ncp $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nfi\n";
};
5325BDCC21DFF33E00A0DEE1 /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269931] trunk/Source/JavaScriptCore
Title: [269931] trunk/Source/_javascript_Core
Revision 269931
Author sbar...@apple.com
Date 2020-11-17 15:53:49 -0800 (Tue, 17 Nov 2020)
Log Message
Add more info to the RELEASE_ASSERT inside Parser::parseInner
https://bugs.webkit.org/show_bug.cgi?id=219054
Reviewed by Mark Lam.
We have some crashes here, and it'll be helpful for the crashlogs to have
more info in the register state.
* parser/Lexer.h:
(JSC::Lexer::codeLength):
* parser/Parser.cpp:
(JSC::Parser::parseInner):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.h
trunk/Source/_javascript_Core/parser/Parser.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (269930 => 269931)
--- trunk/Source/_javascript_Core/ChangeLog 2020-11-17 23:51:11 UTC (rev 269930)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-11-17 23:53:49 UTC (rev 269931)
@@ -1,3 +1,19 @@
+2020-11-17 Saam Barati
+
+Add more info to the RELEASE_ASSERT inside Parser::parseInner
+https://bugs.webkit.org/show_bug.cgi?id=219054
+
+
+Reviewed by Mark Lam.
+
+We have some crashes here, and it'll be helpful for the crashlogs to have
+more info in the register state.
+
+* parser/Lexer.h:
+(JSC::Lexer::codeLength):
+* parser/Parser.cpp:
+(JSC::Parser::parseInner):
+
2020-11-17 Sergey Rubanov
Add support for the Wasm i32 sign-extension-ops proposal
Modified: trunk/Source/_javascript_Core/parser/Lexer.h (269930 => 269931)
--- trunk/Source/_javascript_Core/parser/Lexer.h 2020-11-17 23:51:11 UTC (rev 269930)
+++ trunk/Source/_javascript_Core/parser/Lexer.h 2020-11-17 23:53:49 UTC (rev 269931)
@@ -125,6 +125,8 @@
return sourceProvider->getRange(token.m_location.startOffset, token.m_location.endOffset);
}
+size_t codeLength() { return m_codeEnd - m_codeStart; }
+
private:
void record8(int);
void append8(const T*, size_t);
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (269930 => 269931)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2020-11-17 23:51:11 UTC (rev 269930)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2020-11-17 23:53:49 UTC (rev 269931)
@@ -228,8 +228,8 @@
parameters = parseFunctionParameters(context, parseMode, functionInfo);
if (SourceParseModeSet(SourceParseMode::ArrowFunctionMode, SourceParseMode::AsyncArrowFunctionMode).contains(parseMode) && !hasError()) {
-// The only way we could have an error wile reparsing is if we run out of stack space.
-RELEASE_ASSERT(match(ARROWFUNCTION));
+// The only way we could have an error while reparsing is if we run out of stack space.
+RELEASE_ASSERT(match(ARROWFUNCTION), m_token.m_type, static_cast(parseMode), m_lexer->currentOffset(), m_lexer->codeLength());
next();
isArrowFunctionBodyExpression = !match(OPENBRACE);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269930] trunk/Source/WTF
Title: [269930] trunk/Source/WTF Revision 269930 Author ryanhad...@apple.com Date 2020-11-17 15:51:11 -0800 (Tue, 17 Nov 2020) Log Message Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange https://bugs.webkit.org/show_bug.cgi?id=219030 Unreviewed build fix for macCatalyst. * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h Diff Modified: trunk/Source/WTF/ChangeLog (269929 => 269930) --- trunk/Source/WTF/ChangeLog 2020-11-17 23:49:01 UTC (rev 269929) +++ trunk/Source/WTF/ChangeLog 2020-11-17 23:51:11 UTC (rev 269930) @@ -1,3 +1,12 @@ +2020-11-17 Ryan Haddad + +Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange +https://bugs.webkit.org/show_bug.cgi?id=219030 + +Unreviewed build fix for macCatalyst. + +* wtf/PlatformHave.h: + 2020-11-17 Kimmo Kinnunen Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange Modified: trunk/Source/WTF/wtf/PlatformHave.h (269929 => 269930) --- trunk/Source/WTF/wtf/PlatformHave.h 2020-11-17 23:49:01 UTC (rev 269929) +++ trunk/Source/WTF/wtf/PlatformHave.h 2020-11-17 23:51:11 UTC (rev 269930) @@ -775,6 +775,6 @@ #define HAVE_SANDBOX_MESSAGE_FILTERING 1 #endif -#if (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 11) +#if (PLATFORM(IOS) && !PLATFORM(IOS_FAMILY_SIMULATOR)) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 11) #define HAVE_COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES 1 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269929] trunk
Title: [269929] trunk
Revision 269929
Author commit-qu...@webkit.org
Date 2020-11-17 15:49:01 -0800 (Tue, 17 Nov 2020)
Log Message
Add support for the Wasm i32 sign-extension-ops proposal
https://bugs.webkit.org/show_bug.cgi?id=210302
Patch by Sergey Rubanov on 2020-11-17
Reviewed by Yusuke Suzuki.
JSTests:
* wasm/spec-tests/i32.wast.js:
* wasm/spec-tests/i64.wast.js:
* wasm/wasm.json:
Source/_javascript_Core:
* llint/LowLevelInterpreter.asm:
* llint/WebAssembly.asm:
* offlineasm/arm64.rb:
* offlineasm/cloop.rb:
* offlineasm/instructions.rb:
* offlineasm/x86.rb:
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addOp):
(JSC::Wasm::AirIRGenerator::addOp):
* wasm/wasm.json:
LayoutTests:
* workers/wasm-references/test.js:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/wasm/spec-tests/i32.wast.js
trunk/JSTests/wasm/spec-tests/i64.wast.js
trunk/JSTests/wasm/wasm.json
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/workers/wasm-references/test.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/llint/WebAssembly.asm
trunk/Source/_javascript_Core/offlineasm/arm64.rb
trunk/Source/_javascript_Core/offlineasm/cloop.rb
trunk/Source/_javascript_Core/offlineasm/instructions.rb
trunk/Source/_javascript_Core/offlineasm/x86.rb
trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp
trunk/Source/_javascript_Core/wasm/wasm.json
Diff
Modified: trunk/JSTests/ChangeLog (269928 => 269929)
--- trunk/JSTests/ChangeLog 2020-11-17 23:30:08 UTC (rev 269928)
+++ trunk/JSTests/ChangeLog 2020-11-17 23:49:01 UTC (rev 269929)
@@ -1,3 +1,14 @@
+2020-11-17 Sergey Rubanov
+
+Add support for the Wasm i32 sign-extension-ops proposal
+https://bugs.webkit.org/show_bug.cgi?id=210302
+
+Reviewed by Yusuke Suzuki.
+
+* wasm/spec-tests/i32.wast.js:
+* wasm/spec-tests/i64.wast.js:
+* wasm/wasm.json:
+
2020-11-17 Xan López
[JSC] Add support for static public class fields
Modified: trunk/JSTests/wasm/spec-tests/i32.wast.js (269928 => 269929)
--- trunk/JSTests/wasm/spec-tests/i32.wast.js 2020-11-17 23:30:08 UTC (rev 269928)
+++ trunk/JSTests/wasm/spec-tests/i32.wast.js 2020-11-17 23:49:01 UTC (rev 269929)
@@ -1,9 +1,6 @@
// i32.wast:3
-// FIXME: implement sign-extension operators
-// https://bugs.webkit.org/show_bug.cgi?id=210302
-// let $1 = instance("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x8c\x80\x80\x80\x00\x02\x60\x02\x7f\x7f\x01\x7f\x60\x01\x7f\x01\x7f\x03\xa0\x80\x80\x80\x00\x1f\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x01\x01\x01\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x07\xde\x81\x80\x80\x00\x1f\x03\x61\x64\x64\x00\x00\x03\x73\x75\x62\x00\x01\x03\x6d\x75\x6c\x00\x02\x05\x64\x69\x76\x5f\x73\x00\x03\x05\x64\x69\x76\x5f\x75\x00\x04\x05\x72\x65\x6d\x5f\x73\x00\x05\x05\x72\x65\x6d\x5f\x75\x00\x06\x03\x61\x6e\x64\x00\x07\x02\x6f\x72\x00\x08\x03\x78\x6f\x72\x00\x09\x03\x73\x68\x6c\x00\x0a\x05\x73\x68\x72\x5f\x73\x00\x0b\x05\x73\x68\x72\x5f\x75\x00\x0c\x04\x72\x6f\x74\x6c\x00\x0d\x04\x72\x6f\x74\x72\x00\x0e\x03\x63\x6c\x7a\x00\x0f\x03\x63\x74\x7a\x00\x10\x06\x70\x6f\x70\x63\x6e\x74\x00\x11\x09\x65\x78\x74\x65\x6e\x64\x38\x5f\x73\x00\x12\x0a\x65\x78\x74\x65\x6e\x64\x31\x36\x5f\x73\x00\x13\x03\x65\x71\x7a\x00\x14\x02\x65\x71\x00\x15\x02\x6e\x65\x00\x16\x04\x6c\x74\x5f\x73\x00\x
17\x04\x6c\x74\x5f\x75\x00\x18\x04\x6c\x65\x5f\x73\x00\x19\x04\x6c\x65\x5f\x75\x00\x1a\x04\x67\x74\x5f\x73\x00\x1b\x04\x67\x74\x5f\x75\x00\x1c\x04\x67\x65\x5f\x73\x00\x1d\x04\x67\x65\x5f\x75\x00\x1e\x0a\xe9\x82\x80\x80\x00\x1f\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x6a\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x6b\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x6c\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x6d\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x6e\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x6f\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x70\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x71\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x72\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x73\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x74\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x75\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x76\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x77\x0b\x87\x80\x80\x80\x00\x00\x20\x00\x20\x01\x78\x0b\x85\x80\x80\x80\x00\x00\x20\x00\x67\x0b\x85\x80\x8
[webkit-changes] [269928] trunk/Source/WebKit
Title: [269928] trunk/Source/WebKit
Revision 269928
Author cdu...@apple.com
Date 2020-11-17 15:30:08 -0800 (Tue, 17 Nov 2020)
Log Message
[macOS] Stop using RunLoopType=_WebKit starting in Big Sur
https://bugs.webkit.org/show_bug.cgi?id=219052
Reviewed by Geoffrey Garen.
Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right
scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType
to be NSRunLoop.
After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also
still working as expected.
* Configurations/WebContentService.xcconfig:
* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebContentService.xcconfig
trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist
Diff
Modified: trunk/Source/WebKit/ChangeLog (269927 => 269928)
--- trunk/Source/WebKit/ChangeLog 2020-11-17 22:59:03 UTC (rev 269927)
+++ trunk/Source/WebKit/ChangeLog 2020-11-17 23:30:08 UTC (rev 269928)
@@ -1,3 +1,21 @@
+2020-11-17 Chris Dumez
+
+[macOS] Stop using RunLoopType=_WebKit starting in Big Sur
+https://bugs.webkit.org/show_bug.cgi?id=219052
+
+
+Reviewed by Geoffrey Garen.
+
+Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right
+scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType
+to be NSRunLoop.
+
+After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also
+still working as expected.
+
+* Configurations/WebContentService.xcconfig:
+* WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist:
+
2020-11-17 Per Arne Vollan
[macOS] Issue sandbox extension to trust service if Media in the GPU process is not enabled
Modified: trunk/Source/WebKit/Configurations/WebContentService.xcconfig (269927 => 269928)
--- trunk/Source/WebKit/Configurations/WebContentService.xcconfig 2020-11-17 22:59:03 UTC (rev 269927)
+++ trunk/Source/WebKit/Configurations/WebContentService.xcconfig 2020-11-17 23:30:08 UTC (rev 269928)
@@ -47,9 +47,9 @@
WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_NO = $(WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG);
WK_WEBCONTENT_SERVICE_NEEDS_VERSIONED_FRAMEWORK_PATH_LDFLAG_YES = $(USE_STAGING_INSTALL_PATH);
-RUNLOOP_TYPE = $(RUNLOOP_TYPE$(WK_MACOS_1014));
-RUNLOOP_TYPE_MACOS_BEFORE_1014 = _NSApplicationMain;
-RUNLOOP_TYPE_MACOS_SINCE_1014 = _WebKit;
+RUNLOOP_TYPE = $(RUNLOOP_TYPE$(WK_MACOS_1016));
+RUNLOOP_TYPE_MACOS_BEFORE_1016 = _WebKit;
+RUNLOOP_TYPE_MACOS_SINCE_1016 = NSRunLoop;
ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK))
ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_ = NO;
Modified: trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist (269927 => 269928)
--- trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist 2020-11-17 22:59:03 UTC (rev 269927)
+++ trunk/Source/WebKit/WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-OSX.plist 2020-11-17 23:30:08 UTC (rev 269928)
@@ -46,6 +46,8 @@
Application
RunLoopType
${RUNLOOP_TYPE}
+_ProcessType
+App
_MultipleInstances
_HighBitsASLR
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269927] trunk/Source/WebCore
Title: [269927] trunk/Source/WebCore Revision 269927 Author ape...@igalia.com Date 2020-11-17 14:59:03 -0800 (Tue, 17 Nov 2020) Log Message Unreviewed build fix for non-unified builds. * rendering/RenderBox.cpp: Add missing LayoutIntegrationLineIterator.h header. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (269926 => 269927) --- trunk/Source/WebCore/ChangeLog 2020-11-17 22:39:42 UTC (rev 269926) +++ trunk/Source/WebCore/ChangeLog 2020-11-17 22:59:03 UTC (rev 269927) @@ -1,3 +1,9 @@ +2020-11-17 Adrian Perez de Castro + +Unreviewed build fix for non-unified builds. + +* rendering/RenderBox.cpp: Add missing LayoutIntegrationLineIterator.h header. + 2020-11-17 Andres Gonzalez Implementation of AXCoreObject::innerHTML and outerHTML. Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (269926 => 269927) --- trunk/Source/WebCore/rendering/RenderBox.cpp 2020-11-17 22:39:42 UTC (rev 269926) +++ trunk/Source/WebCore/rendering/RenderBox.cpp 2020-11-17 22:59:03 UTC (rev 269927) @@ -48,6 +48,7 @@ #include "HitTestResult.h" #include "InlineElementBox.h" #include "InlineRunAndOffset.h" +#include "LayoutIntegrationLineIterator.h" #include "LayoutIntegrationLineLayout.h" #include "Page.h" #include "PaintInfo.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269926] tags/Safari-611.1.5.1/
Title: [269926] tags/Safari-611.1.5.1/ Revision 269926 Author alanc...@apple.com Date 2020-11-17 14:39:42 -0800 (Tue, 17 Nov 2020) Log Message Tag Safari-611.1.5.1. Added Paths tags/Safari-611.1.5.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269925] branches/safari-611.1.5-branch/Source
Title: [269925] branches/safari-611.1.5-branch/Source Revision 269925 Author alanc...@apple.com Date 2020-11-17 14:35:03 -0800 (Tue, 17 Nov 2020) Log Message Versioning. WebKit-7611.1.5.1 Modified Paths branches/safari-611.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-611.1.5-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-611.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig (269924 => 269925) --- branches/safari-611.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-11-17 22:25:58 UTC (rev 269924) +++ branches/safari-611.1.5-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-11-17 22:35:03 UTC (rev 269925) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 5; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (269924 => 269925) --- branches/safari-611.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-11-17 22:25:58 UTC (rev 269924) +++ branches/safari-611.1.5-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-11-17 22:35:03 UTC (rev 269925) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 5; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (269924 => 269925) --- branches/safari-611.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-11-17 22:25:58 UTC (rev 269924) +++ branches/safari-611.1.5-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-11-17 22:35:03 UTC (rev 269925) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 5; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.5-branch/Source/WebCore/Configurations/Version.xcconfig (269924 => 269925) --- branches/safari-611.1.5-branch/Source/WebCore/Configurations/Version.xcconfig 2020-11-17 22:25:58 UTC (rev 269924) +++ branches/safari-611.1.5-branch/Source/WebCore/Configurations/Version.xcconfig 2020-11-17 22:35:03 UTC (rev 269925) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 5; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-611.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (269924 => 269925) --- branches/safari-611.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-11-17 22:25:58 UTC (rev 269924) +++ branches/safari-611.1.5-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-11-17 22:35:03 UTC (rev 269925) @@ -24,9 +24,9 @@ MAJOR_VERSION = 611; MINOR_VERSION = 1; TINY_VERSION = 5; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION =
[webkit-changes] [269924] trunk/Source/WebKit
Title: [269924] trunk/Source/WebKit Revision 269924 Author pvol...@apple.com Date 2020-11-17 14:25:58 -0800 (Tue, 17 Nov 2020) Log Message [macOS] Issue sandbox extension to trust service if Media in the GPU process is not enabled https://bugs.webkit.org/show_bug.cgi?id=218986 Reviewed by Brent Fulgham. Since Media is using the trust service, issue a sandbox extension to the WebContent process if Media in the GPU process is not enabled. * UIProcess/WebPageProxy.cpp: (WebKit::mediaRelatedMachServices): * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (269923 => 269924) --- trunk/Source/WebKit/ChangeLog 2020-11-17 22:14:20 UTC (rev 269923) +++ trunk/Source/WebKit/ChangeLog 2020-11-17 22:25:58 UTC (rev 269924) @@ -1,3 +1,17 @@ +2020-11-17 Per Arne Vollan + +[macOS] Issue sandbox extension to trust service if Media in the GPU process is not enabled +https://bugs.webkit.org/show_bug.cgi?id=218986 + + +Reviewed by Brent Fulgham. + +Since Media is using the trust service, issue a sandbox extension to the WebContent process if Media in the GPU process is not enabled. + +* UIProcess/WebPageProxy.cpp: +(WebKit::mediaRelatedMachServices): +* WebProcess/com.apple.WebProcess.sb.in: + 2020-11-17 Sihui Liu Add a default action for SpeechRecognition permission request Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (269923 => 269924) --- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-11-17 22:14:20 UTC (rev 269923) +++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-11-17 22:25:58 UTC (rev 269924) @@ -7755,7 +7755,7 @@ #if PLATFORM(MAC) || PLATFORM(MACCATALYST) "com.apple.coremedia.endpointstream.xpc"_s, "com.apple.coremedia.endpointplaybacksession.xpc"_s, "com.apple.coremedia.endpointremotecontrolsession.xpc"_s, "com.apple.coremedia.videodecoder"_s, -"com.apple.coremedia.videoencoder"_s, "com.apple.lskdd"_s, "com.apple.BluetoothServices"_s +"com.apple.coremedia.videoencoder"_s, "com.apple.lskdd"_s, "com.apple.trustd.agent"_s, "com.apple.BluetoothServices"_s #endif }); return services; Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (269923 => 269924) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-11-17 22:14:20 UTC (rev 269923) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-11-17 22:25:58 UTC (rev 269924) @@ -1237,7 +1237,7 @@ ;;; FIXME(207716): The following should be removed when the GPU process is complete "com.apple.audio.AudioComponentRegistrar" "com.apple.coremedia.endpoint.xpc" "com.apple.coremedia.endpointstream.xpc" "com.apple.coremedia.endpointplaybacksession.xpc" "com.apple.coremedia.endpointremotecontrolsession.xpc" "com.apple.coremedia.routediscoverer.xpc" -"com.apple.coremedia.routingcontext.xpc" "com.apple.coremedia.volumecontroller.xpc" "com.apple.lskdd" "com.apple.mediaremoted.xpc" +"com.apple.coremedia.routingcontext.xpc" "com.apple.coremedia.volumecontroller.xpc" "com.apple.lskdd" "com.apple.mediaremoted.xpc" "com.apple.trustd.agent" ;;; FIXME(207716): End services to remove. ) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269923] trunk/Source/WebCore
Title: [269923] trunk/Source/WebCore
Revision 269923
Author andresg...@apple.com
Date 2020-11-17 14:14:20 -0800 (Tue, 17 Nov 2020)
Log Message
Implementation of AXCoreObject::innerHTML and outerHTML.
https://bugs.webkit.org/show_bug.cgi?id=219037
Reviewed by Chris Fleizach.
No change in functionality, debugging code.
- Added innerHTML and outerHTmL methods to AXCoreObject for debugging
purposes.
- The AXIsolatedObject implementation of these methods forwards the call
to the associated AXObject and does a lazy caching of the Inner/OuterHTML
properties.
- The AXLogger class is now declared and defined only #if !LOG_DISABLED.
* accessibility/AXLogger.cpp:
(WebCore::AXLogger::log):
(WebCore::operator<<):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::innerHTML const):
(WebCore::AccessibilityObject::outerHTML const):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::innerHTML const):
(WebCore::AXIsolatedObject::outerHTML const):
* accessibility/isolatedtree/AXIsolatedObject.h:
* accessibility/isolatedtree/AXIsolatedTree.h:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase innerHTML]):
(-[WebAccessibilityObjectWrapperBase outerHTML]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXLogger.cpp
trunk/Source/WebCore/accessibility/AXLogger.h
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (269922 => 269923)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 21:37:39 UTC (rev 269922)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 22:14:20 UTC (rev 269923)
@@ -1,3 +1,36 @@
+2020-11-17 Andres Gonzalez
+
+Implementation of AXCoreObject::innerHTML and outerHTML.
+https://bugs.webkit.org/show_bug.cgi?id=219037
+
+Reviewed by Chris Fleizach.
+
+No change in functionality, debugging code.
+
+- Added innerHTML and outerHTmL methods to AXCoreObject for debugging
+purposes.
+- The AXIsolatedObject implementation of these methods forwards the call
+to the associated AXObject and does a lazy caching of the Inner/OuterHTML
+properties.
+- The AXLogger class is now declared and defined only #if !LOG_DISABLED.
+
+* accessibility/AXLogger.cpp:
+(WebCore::AXLogger::log):
+(WebCore::operator<<):
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::innerHTML const):
+(WebCore::AccessibilityObject::outerHTML const):
+* accessibility/AccessibilityObject.h:
+* accessibility/AccessibilityObjectInterface.h:
+* accessibility/isolatedtree/AXIsolatedObject.cpp:
+(WebCore::AXIsolatedObject::innerHTML const):
+(WebCore::AXIsolatedObject::outerHTML const):
+* accessibility/isolatedtree/AXIsolatedObject.h:
+* accessibility/isolatedtree/AXIsolatedTree.h:
+* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
+(-[WebAccessibilityObjectWrapperBase innerHTML]):
+(-[WebAccessibilityObjectWrapperBase outerHTML]):
+
2020-11-17 Zalan Bujtas
[LFC][Integration] Disable percentage type min/max-width/height
Modified: trunk/Source/WebCore/accessibility/AXLogger.cpp (269922 => 269923)
--- trunk/Source/WebCore/accessibility/AXLogger.cpp 2020-11-17 21:37:39 UTC (rev 269922)
+++ trunk/Source/WebCore/accessibility/AXLogger.cpp 2020-11-17 22:14:20 UTC (rev 269923)
@@ -27,6 +27,8 @@
*/
#include "config.h"
+
+#if !LOG_DISABLED
#include "AXLogger.h"
#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
@@ -57,11 +59,7 @@
void AXLogger::log(const String& message)
{
-#if !LOG_DISABLED
LOG(Accessibility, "%s", message.utf8().data());
-#else
-UNUSED_PARAM(message);
-#endif
}
void AXLogger::log(RefPtr object)
@@ -272,10 +270,8 @@
auto* parent = object.parentObject();
if (role == AccessibilityRole::StaticText && parent)
objectWithInterestingHTML = parent;
-if (objectWithInterestingHTML) {
-if (auto* element = objectWithInterestingHTML->element())
-stream.dumpProperty("outerHTML", element->outerHTML());
-}
+if (objectWithInterestingHTML)
+stream.dumpProperty("outerHTML", objectWithInterestingHTML->outerHTML());
stream.dumpProperty("address", );
stream.dumpProperty("wrapper", object.wrapper());
@@ -314,3 +310,5 @@
}
} // namespace WebCore
+
+#endif //
[webkit-changes] [269922] trunk
Title: [269922] trunk
Revision 269922
Author commit-qu...@webkit.org
Date 2020-11-17 13:37:39 -0800 (Tue, 17 Nov 2020)
Log Message
[JSC] Add support for static public class fields
https://bugs.webkit.org/show_bug.cgi?id=194095
Patch by Xan López on 2020-11-17
Reviewed by Yusuke Suzuki.
JSTests:
Enable static public fields, and import new stress tests from the
V8 project. Also split the support code into a separate file
(harmony-support.js) to avoid duplication.
* test262/config.yaml: enable static public fields.
* stress/class-fields-harmony.js: use the new support file.
* stress/class-fields-static-harmony.js: Added.
* stress/resources/harmony-support.js: Added.
Source/_javascript_Core:
Add support for static public class fields. We can reuse most of
the existing machinery available for instance fields. Like
instance fields, static fields are initialized with a synthetic
function. This is done to allow us to trivially follow the scoping
rules in the spec. As it happens with instance fields this could
be inlined in a future patch.
A lot of small changes in many files are just a matter of doing
s/instance/class/ for variables related to class fields, which
before were assuming there are only instance fields implemented.
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock): do s/instanceField/classField/.
* bytecode/UnlinkedFunctionExecutable.h: ditto.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewClassFieldInitializerFunction): ditto.
* bytecompiler/BytecodeGenerator.h: ditto, plus add a parameter
for static field locations in emitDefineClassElements.
* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode): save static fields
locations when going through the property list.
(JSC::PropertyListNode::emitSaveComputedFieldName): consider
static fields here too.
(JSC::ClassExprNode::emitBytecode): call the initializer for
static fields as the very last action of the class creation.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createDefineField): field nodes can be static
too now.
* parser/NodeConstructors.h:
(JSC::DefineFieldNode::DefineFieldNode): ditto.
* parser/Nodes.h: ditto.
* parser/Parser.cpp:
(JSC::Parser::parseInner): s/instanceField/classField/
(JSC::Parser::parseClass): consider static fields.
(JSC::Parser::parseInstanceFieldInitializerSourceElements):
s/instanceField/classField/, and consider static fields.
* parser/Parser.h:
(JSC::Parser::parse): s/instanceField/classField/
(JSC::parse): ditto.
* runtime/JSFunction.cpp:
(JSC::JSFunction::setFunctionName): s/instanceField/classField/
* runtime/OptionsList.h: add option to enable/disable static public fields.
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/class-fields-harmony.js
trunk/JSTests/test262/config.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/parser/ParserModes.h
trunk/Source/_javascript_Core/runtime/FunctionPrototype.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h
Added Paths
trunk/JSTests/stress/class-fields-static-harmony.js
trunk/JSTests/stress/resources/harmony-support.js
Diff
Modified: trunk/JSTests/ChangeLog (269921 => 269922)
--- trunk/JSTests/ChangeLog 2020-11-17 21:14:04 UTC (rev 269921)
+++ trunk/JSTests/ChangeLog 2020-11-17 21:37:39 UTC (rev 269922)
@@ -1,3 +1,19 @@
+2020-11-17 Xan López
+
+[JSC] Add support for static public class fields
+https://bugs.webkit.org/show_bug.cgi?id=194095
+
+Reviewed by Yusuke Suzuki.
+
+Enable static public fields, and import new stress tests from the
+V8 project. Also split the support code into a separate file
+(harmony-support.js) to avoid duplication.
+
+* test262/config.yaml: enable static public fields.
+* stress/class-fields-harmony.js: use the new support file.
+* stress/class-fields-static-harmony.js: Added.
+* stress/resources/harmony-support.js: Added.
+
2020-11-15 Sergey Rubanov
[JSC] Update wasm spec tests
Modified: trunk/JSTests/stress/class-fields-harmony.js (269921 => 269922)
--- trunk/JSTests/stress/class-fields-harmony.js 2020-11-17 21:14:04 UTC (rev 269921)
+++ trunk/JSTests/stress/class-fields-harmony.js 2020-11-17 21:37:39 UTC (rev 269922)
@@ -31,171 +31,8 @@
"use strict";
-function classOf(object) {
- // Argument must not be null or undefined.
- var string =
[webkit-changes] [269921] trunk/Source/WebCore
Title: [269921] trunk/Source/WebCore
Revision 269921
Author za...@apple.com
Date 2020-11-17 13:14:04 -0800 (Tue, 17 Nov 2020)
Log Message
[LFC][Integration] Disable percentage type min/max-width/height
https://bugs.webkit.org/show_bug.cgi?id=219045
Reviewed by Antti Koivisto.
The integration layer code does not support them yet.
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (269920 => 269921)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 21:05:07 UTC (rev 269920)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 21:14:04 UTC (rev 269921)
@@ -1,3 +1,15 @@
+2020-11-17 Zalan Bujtas
+
+[LFC][Integration] Disable percentage type min/max-width/height
+https://bugs.webkit.org/show_bug.cgi?id=219045
+
+Reviewed by Antti Koivisto.
+
+The integration layer code does not support them yet.
+
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForChild):
+
2020-11-17 Sihui Liu
Add a default action for SpeechRecognition permission request
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (269920 => 269921)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-17 21:05:07 UTC (rev 269920)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2020-11-17 21:14:04 UTC (rev 269921)
@@ -579,6 +579,21 @@
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)
}
+#if ALLOW_IMAGES || ALLOW_ALL_REPLACED || ALLOW_INLINE_BLOCK
+auto isSupportedStyle = [] (const auto& style) {
+if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
+return false;
+auto& width = style.width();
+auto& height = style.height();
+if (width.isPercent() || height.isPercent())
+return false;
+if (width.isAuto() && (style.minWidth().isPercent() || style.maxWidth().isPercent()))
+return false;
+if (height.isAuto() && (style.minHeight().isPercent() || style.maxHeight().isPercent()))
+return false;
+return true;
+};
+#endif
#if ALLOW_IMAGES || ALLOW_ALL_REPLACED
if (is(child)) {
auto& replaced = downcast(child);
@@ -588,13 +603,9 @@
if (replaced.isSVGRoot())
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
-auto& style = replaced.style();
-if (style.width().isPercent() || style.height().isPercent())
+if (!isSupportedStyle(replaced.style()))
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
-if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
-
if (is(replaced)) {
auto& image = downcast(replaced);
if (image.imageMap())
@@ -619,12 +630,10 @@
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
auto& style = block.style();
-if (block.style().display() != DisplayType::InlineBlock)
+if (!isSupportedStyle(style))
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)
-if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
-if (style.width().isPercent() || style.height().isPercent())
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
+if (style.display() != DisplayType::InlineBlock)
+SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)
return reasons;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269920] trunk/Tools
Title: [269920] trunk/Tools
Revision 269920
Author jlew...@apple.com
Date 2020-11-17 13:05:07 -0800 (Tue, 17 Nov 2020)
Log Message
Big Sur testers fail to find proper archives due to architecture keys.
https://bugs.webkit.org/show_bug.cgi?id=219039
Reviewed by Aakash Jain.
* CISupport/build-webkit-org/config.json:
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (269919 => 269920)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2020-11-17 21:01:52 UTC (rev 269919)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2020-11-17 21:05:07 UTC (rev 269920)
@@ -125,12 +125,12 @@
"workernames": ["bot279", "bot600", "bot614"]
},
{ "name": "Apple-BigSur-Release-WK1-Tests", "factory": "TestWebKit1AllButJSCFactory", "builddir": "bigsur-release-tests-wk1",
- "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
"additionalArguments": ["--no-retry-failures"],
"workernames": ["bot1020", "bot1021"]
},
{ "name": "Apple-BigSur-Release-WK2-Tests", "factory": "TestAllButJSCFactory", "builddir": "bigsur-release-tests-wk2",
- "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
"additionalArguments": ["--no-retry-failures"],
"workernames": ["bot1022", "bot1023"]
},
@@ -140,12 +140,12 @@
"workernames": ["bot684", "bot685"]
},
{ "name": "Apple-BigSur-Debug-WK1-Tests", "factory": "TestWebKit1AllButJSCFactory", "builddir": "bigsur-debug-tests-wk1",
- "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64", "arm64"],
"additionalArguments": ["--no-retry-failures"],
"workernames": ["bot1024", "bot1025"]
},
{ "name": "Apple-BigSur-Debug-WK2-Tests", "factory": "TestAllButJSCFactory", "builddir": "bigsur-debug-tests-wk2",
- "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64", "arm64"],
"additionalArguments": ["--no-retry-failures"],
"workernames": ["bot1026", "bot1027"]
},
Modified: trunk/Tools/ChangeLog (269919 => 269920)
--- trunk/Tools/ChangeLog 2020-11-17 21:01:52 UTC (rev 269919)
+++ trunk/Tools/ChangeLog 2020-11-17 21:05:07 UTC (rev 269920)
@@ -1,3 +1,12 @@
+2020-11-17 Matt Lewis
+
+Big Sur testers fail to find proper archives due to architecture keys.
+https://bugs.webkit.org/show_bug.cgi?id=219039
+
+Reviewed by Aakash Jain.
+
+* CISupport/build-webkit-org/config.json:
+
2020-11-17 Jonathan Bedard
[webkitcorepy] Support mocking request network calls.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269919] trunk/Tools
Title: [269919] trunk/Tools Revision 269919 Author jbed...@apple.com Date 2020-11-17 13:01:52 -0800 (Tue, 17 Nov 2020) Log Message [webkitcorepy] Support mocking request network calls. https://bugs.webkit.org/show_bug.cgi?id=218927 Rubber-stamped by Aakash Jain. * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version. * Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py: * Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py: Moved to requests_. * Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py: Copied from Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py. (Response): Object mimicking the structure of Requests's response object, useful for mocking. (Requests): Context manager which will intercept http and https requests to a specific host. (Requests.__exit__): * Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/requests_unittest.py: Added. (MockRequests): (MockRequests.test_basic): (MockRequests.test_fallback): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py Added Paths trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/requests_unittest.py Removed Paths trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py Diff Modified: trunk/Tools/ChangeLog (269918 => 269919) --- trunk/Tools/ChangeLog 2020-11-17 21:00:46 UTC (rev 269918) +++ trunk/Tools/ChangeLog 2020-11-17 21:01:52 UTC (rev 269919) @@ -1,3 +1,23 @@ +2020-11-17 Jonathan Bedard + +[webkitcorepy] Support mocking request network calls. +https://bugs.webkit.org/show_bug.cgi?id=218927 + + +Rubber-stamped by Aakash Jain. + +* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version. +* Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py: +* Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py: Moved to requests_. +* Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py: Copied from Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py. +(Response): Object mimicking the structure of Requests's response object, useful for mocking. +(Requests): Context manager which will intercept http and https requests to a specific host. +(Requests.__exit__): +* Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/requests_unittest.py: Added. +(MockRequests): +(MockRequests.test_basic): +(MockRequests.test_fallback): + 2020-11-17 Aakash Jain [build.webkit.org] Update ExtractTestResults step for new buildbot (follow-up fix) Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (269918 => 269919) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2020-11-17 21:00:46 UTC (rev 269918) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2020-11-17 21:01:52 UTC (rev 269919) @@ -35,7 +35,7 @@ from webkitcorepy.subprocess_utils import TimeoutExpired, CompletedProcess, run from webkitcorepy.output_capture import LoggerCapture, OutputCapture, OutputDuplicate -version = Version(0, 4, 20) +version = Version(0, 4, 21) from webkitcorepy.autoinstall import Package, AutoInstall if sys.version_info > (3, 0): Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py (269918 => 269919) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py 2020-11-17 21:00:46 UTC (rev 269918) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/__init__.py 2020-11-17 21:01:52 UTC (rev 269919) @@ -24,4 +24,4 @@ from webkitcorepy.mocks.time_ import Time from webkitcorepy.mocks.subprocess import ProcessCompletion, Subprocess -from webkitcorepy.mocks.requests import Response +from webkitcorepy.mocks.requests_ import Response, Requests Deleted: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py (269918 => 269919) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py 2020-11-17 21:00:46 UTC (rev 269918) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py 2020-11-17 21:01:52 UTC (rev 269919) @@ -1,62 +0,0 @@ -# Copyright (C) 2020 Apple Inc. All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# 1. Redistributions of source code must retain the above copyright -#notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -#notice, this list of conditions and the following disclaimer in the -#documentation and/or other materials provided with the distribution. -#
[webkit-changes] [269918] trunk/Source
Title: [269918] trunk/Source Revision 269918 Author sihui_...@apple.com Date 2020-11-17 13:00:46 -0800 (Tue, 17 Nov 2020) Log Message Add a default action for SpeechRecognition permission request https://bugs.webkit.org/show_bug.cgi?id=219021 Reviewed by Youenn Fablet. Source/WebCore: Manually tested in Minibrowser. * en.lproj/Localizable.strings: Source/WebKit: When there is no delegate or selector for deciding user permission on speech recognition, force an alert and let user decide. This is currently what we do for UserMedia permission request, and it makes testing easier. * SourcesCocoa.txt: * UIProcess/API/APIUIClient.h: (API::UIClient::decidePolicyForSpeechRecognitionPermissionRequest): * UIProcess/Cocoa/MediaPermissionUtilities.mm: (WebKit::visibleDomain): (WebKit::alertMessageText): (WebKit::allowButtonText): (WebKit::doNotAllowButtonText): (WebKit::alertForPermission): * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::decidePolicyForSpeechRecognitionPermissionRequest): * UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm: Removed. Moved alert code to MediaPermissionUtilities so it can be shared between UserMedia and SpeechRecognition. * UIProcess/MediaPermissionUtilities.h: * UIProcess/SpeechRecognitionPermissionManager.cpp: (WebKit::SpeechRecognitionPermissionManager::decideByDefaultAction): * UIProcess/SpeechRecognitionPermissionManager.h: * UIProcess/UserMediaPermissionRequestProxy.cpp: (WebKit::UserMediaPermissionRequestProxy::doDefaultAction): * UIProcess/UserMediaPermissionRequestProxy.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::requestSpeechRecognitionPermissionByDefaultAction): * UIProcess/WebPageProxy.h: * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/en.lproj/Localizable.strings trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/UIProcess/API/APIUIClient.h trunk/Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm trunk/Source/WebKit/UIProcess/MediaPermissionUtilities.h trunk/Source/WebKit/UIProcess/SpeechRecognitionPermissionManager.cpp trunk/Source/WebKit/UIProcess/SpeechRecognitionPermissionManager.h trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.cpp trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Removed Paths trunk/Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm Diff Modified: trunk/Source/WebCore/ChangeLog (269917 => 269918) --- trunk/Source/WebCore/ChangeLog 2020-11-17 20:25:14 UTC (rev 269917) +++ trunk/Source/WebCore/ChangeLog 2020-11-17 21:00:46 UTC (rev 269918) @@ -1,3 +1,14 @@ +2020-11-17 Sihui Liu + +Add a default action for SpeechRecognition permission request +https://bugs.webkit.org/show_bug.cgi?id=219021 + +Reviewed by Youenn Fablet. + +Manually tested in Minibrowser. + +* en.lproj/Localizable.strings: + 2020-11-17 Antti Koivisto [LFC][Integration] Cache inline boxes in logical order to run iterator Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (269917 => 269918) --- trunk/Source/WebCore/en.lproj/Localizable.strings 2020-11-17 20:25:14 UTC (rev 269917) +++ trunk/Source/WebCore/en.lproj/Localizable.strings 2020-11-17 21:00:46 UTC (rev 269918) @@ -142,6 +142,15 @@ /* Disallow button title in user media prompt */ "Don’t Allow (usermedia)" = "Don’t Allow"; +/* Message for speech recognition prompt */ +"Allow “%@” to capture your audio and use it for speech recognition?" = "Allow “%@” to capture your audio and use it for speech recognition?"; + +/* Allow button title in speech recognition prompt */ +"Allow (speechrecognition)" = "Allow"; + +/* Disallow button title in speech recognition prompt */ +"Don’t Allow (speechrecognition)" = "Don’t Allow"; + /* WKErrorUnknown description */ "An unknown error occurred" = "An unknown error occurred"; Modified: trunk/Source/WebKit/ChangeLog (269917 => 269918) --- trunk/Source/WebKit/ChangeLog 2020-11-17 20:25:14 UTC (rev 269917) +++ trunk/Source/WebKit/ChangeLog 2020-11-17 21:00:46 UTC (rev 269918) @@ -1,3 +1,38 @@ +2020-11-17 Sihui Liu + +Add a default action for SpeechRecognition permission request +https://bugs.webkit.org/show_bug.cgi?id=219021 + +Reviewed by Youenn Fablet. + +When there is no delegate or selector for deciding user permission on speech recognition, force an alert and let +user decide. This is currently what we do for UserMedia permission request, and it makes testing easier. + +* SourcesCocoa.txt: +* UIProcess/API/APIUIClient.h: +(API::UIClient::decidePolicyForSpeechRecognitionPermissionRequest): +* UIProcess/Cocoa/MediaPermissionUtilities.mm: +
[webkit-changes] [269917] trunk/Source/WebKit
Title: [269917] trunk/Source/WebKit
Revision 269917
Author commit-qu...@webkit.org
Date 2020-11-17 12:25:14 -0800 (Tue, 17 Nov 2020)
Log Message
Check com.apple.private.webkit.use-xpc-endpoint only on internal builds
https://bugs.webkit.org/show_bug.cgi?id=215423
Patch by Saagar Jha on 2020-11-17
Reviewed by Per Arne Vollan.
Signing with com.apple.private entitlements can only be done by Apple internally. Thus,
it should only checked for internal builds.
* Shared/Cocoa/XPCEndpoint.mm:
(WebKit::XPCEndpoint::XPCEndpoint): Wrap check in USE(APPLE_INTERNAL_SDK).
* Shared/Cocoa/XPCEndpointClient.mm:
(WebKit::XPCEndpointClient::setEndpoint): Wrap check in USE(APPLE_INTERNAL_SDK).
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm
trunk/Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (269916 => 269917)
--- trunk/Source/WebKit/ChangeLog 2020-11-17 20:24:20 UTC (rev 269916)
+++ trunk/Source/WebKit/ChangeLog 2020-11-17 20:25:14 UTC (rev 269917)
@@ -1,3 +1,18 @@
+2020-11-17 Saagar Jha
+
+Check com.apple.private.webkit.use-xpc-endpoint only on internal builds
+https://bugs.webkit.org/show_bug.cgi?id=215423
+
+Reviewed by Per Arne Vollan.
+
+Signing with com.apple.private entitlements can only be done by Apple internally. Thus,
+it should only checked for internal builds.
+
+* Shared/Cocoa/XPCEndpoint.mm:
+(WebKit::XPCEndpoint::XPCEndpoint): Wrap check in USE(APPLE_INTERNAL_SDK).
+* Shared/Cocoa/XPCEndpointClient.mm:
+(WebKit::XPCEndpointClient::setEndpoint): Wrap check in USE(APPLE_INTERNAL_SDK).
+
2020-11-17 Brent Fulgham
[macOS] Remove access to the unused AppleSNBFBUserClient IOKit class
Modified: trunk/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm (269916 => 269917)
--- trunk/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm 2020-11-17 20:24:20 UTC (rev 269916)
+++ trunk/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm 2020-11-17 20:25:14 UTC (rev 269917)
@@ -49,6 +49,7 @@
if (type == XPC_TYPE_CONNECTION) {
OSObjectPtr connection = message;
+#if USE(APPLE_INTERNAL_SDK)
auto pid = xpc_connection_get_pid(connection.get());
if (pid != getpid() && !WTF::hasEntitlement(connection.get(), "com.apple.private.webkit.use-xpc-endpoint")) {
@@ -67,6 +68,7 @@
return;
#endif
}
+#endif // USE(APPLE_INTERNAL_SDK)
xpc_connection_set_target_queue(connection.get(), dispatch_get_main_queue());
xpc_connection_set_event_handler(connection.get(), ^(xpc_object_t event) {
handleEvent(connection.get(), event);
Modified: trunk/Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm (269916 => 269917)
--- trunk/Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm 2020-11-17 20:24:20 UTC (rev 269916)
+++ trunk/Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm 2020-11-17 20:25:14 UTC (rev 269917)
@@ -56,12 +56,13 @@
auto connection = xpc_dictionary_get_remote_connection(message);
if (!connection)
return;
-
+#if USE(APPLE_INTERNAL_SDK)
auto pid = xpc_connection_get_pid(connection);
if (pid != getpid() && !WTF::hasEntitlement(connection, "com.apple.private.webkit.use-xpc-endpoint")) {
WTFLogAlways("Audit token does not have required entitlement com.apple.private.webkit.use-xpc-endpoint");
return;
}
+#endif
handleEvent(message);
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269916] trunk/Source/WebCore
Title: [269916] trunk/Source/WebCore Revision 269916 Author an...@apple.com Date 2020-11-17 12:24:20 -0800 (Tue, 17 Nov 2020) Log Message [LFC][Integration] Cache inline boxes in logical order to run iterator https://bugs.webkit.org/show_bug.cgi?id=219031 Reviewed by Zalan Bujtas. Expand use of the existing cache to cover line traversal. This will make porting code in VisibleUnit.cpp to iterator easier. Also a bunch of related cleanups. * layout/integration/LayoutIntegrationLineIterator.cpp: (WebCore::LayoutIntegration::LineIterator::logicalStartRun const): (WebCore::LayoutIntegration::LineIterator::logicalEndRun const): (WebCore::LayoutIntegration::LineIterator::logicalStartRunWithNode const): (WebCore::LayoutIntegration::LineIterator::logicalEndRunWithNode const): * layout/integration/LayoutIntegrationLineIterator.h: * layout/integration/LayoutIntegrationLineIteratorLegacyPath.h: (WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalStartRun const): (WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalEndRun const): (WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalStartRunWithNode const): Deleted. (WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalEndRunWithNode const): Deleted. * layout/integration/LayoutIntegrationLineIteratorModernPath.h: (WebCore::LayoutIntegration::LineIteratorModernPath::logicalStartRun const): (WebCore::LayoutIntegration::LineIteratorModernPath::logicalEndRun const): (WebCore::LayoutIntegration::LineIteratorModernPath::logicalStartRunWithNode const): Deleted. (WebCore::LayoutIntegration::LineIteratorModernPath::logicalEndRunWithNode const): Deleted. * layout/integration/LayoutIntegrationRunIterator.cpp: (WebCore::LayoutIntegration::RunIterator::traverseNextOnLineInLogicalOrder): (WebCore::LayoutIntegration::RunIterator::traversePreviousOnLineInLogicalOrder): (WebCore::LayoutIntegration::firstTextRunInTextOrderFor): * layout/integration/LayoutIntegrationRunIterator.h: * layout/integration/LayoutIntegrationRunIteratorLegacyPath.h: (WebCore::LayoutIntegration::RunIteratorLegacyPath::RunIteratorLegacyPath): (WebCore::LayoutIntegration::RunIteratorLegacyPath::traverseNextTextRunInTextOrder): (WebCore::LayoutIntegration::RunIteratorLegacyPath::traverseNextOnLineInLogicalOrder): (WebCore::LayoutIntegration::RunIteratorLegacyPath::traversePreviousOnLineInLogicalOrder): (WebCore::LayoutIntegration::RunIteratorLegacyPath::inlineTextBox const): (WebCore::LayoutIntegration::RunIteratorLegacyPath::initializeLogicalOrderCacheForLine): (WebCore::LayoutIntegration::RunIteratorLegacyPath::traverseNextInlineBoxInCacheOrder): (WebCore::LayoutIntegration::RunIteratorLegacyPath::traversePreviousInlineBoxInCacheOrder): (WebCore::LayoutIntegration::RunIteratorLegacyPath::nextInlineTextBoxInTextOrder const): Deleted. * layout/integration/LayoutIntegrationRunIteratorModernPath.h: (WebCore::LayoutIntegration::RunIteratorModernPath::traverseNextOnLineInLogicalOrder): (WebCore::LayoutIntegration::RunIteratorModernPath::traversePreviousOnLineInLogicalOrder): * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::getLogicalStartBoxWithNode const): Deleted. (WebCore::RootInlineBox::getLogicalEndBoxWithNode const): Deleted. * rendering/RootInlineBox.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.h trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorLegacyPath.h trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h trunk/Source/WebCore/rendering/RootInlineBox.cpp trunk/Source/WebCore/rendering/RootInlineBox.h Diff Modified: trunk/Source/WebCore/ChangeLog (269915 => 269916) --- trunk/Source/WebCore/ChangeLog 2020-11-17 19:34:27 UTC (rev 269915) +++ trunk/Source/WebCore/ChangeLog 2020-11-17 20:24:20 UTC (rev 269916) @@ -1,3 +1,53 @@ +2020-11-17 Antti Koivisto + +[LFC][Integration] Cache inline boxes in logical order to run iterator +https://bugs.webkit.org/show_bug.cgi?id=219031 + +Reviewed by Zalan Bujtas. + +Expand use of the existing cache to cover line traversal. This will make porting code in VisibleUnit.cpp to iterator easier. + +Also a bunch of related cleanups. + +* layout/integration/LayoutIntegrationLineIterator.cpp: +(WebCore::LayoutIntegration::LineIterator::logicalStartRun const): +(WebCore::LayoutIntegration::LineIterator::logicalEndRun const): +(WebCore::LayoutIntegration::LineIterator::logicalStartRunWithNode const): +
[webkit-changes] [269915] trunk/Source/WebCore
Title: [269915] trunk/Source/WebCore
Revision 269915
Author megan_gard...@apple.com
Date 2020-11-17 11:34:27 -0800 (Tue, 17 Nov 2020)
Log Message
Speculative fix for localizableStrings.string in WebCore
https://bugs.webkit.org/show_bug.cgi?id=219042
Unreviewed build fix.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (269914 => 269915)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 19:04:10 UTC (rev 269914)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 19:34:27 UTC (rev 269915)
@@ -1,3 +1,12 @@
+2020-11-17 Megan Gardner
+
+Speculative fix for localizableStrings.string in WebCore
+https://bugs.webkit.org/show_bug.cgi?id=219042
+
+Unreviewed build fix.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2020-11-17 Antoine Quint
[Web Animations] Move all effect-specific parts of WebAnimation::timeToNextTick() to effect classes
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (269914 => 269915)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-11-17 19:04:10 UTC (rev 269914)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-11-17 19:34:27 UTC (rev 269915)
@@ -35478,7 +35478,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "if [ -e $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings ] ; then\ncat $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings $SRCROOT/en.lproj/Localizable.strings > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelif [ -e $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings ] ; then\ncat $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings $SRCROOT/en.lproj/Localizable.strings > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelse\ncp $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nfi\n";
+ shellScript = "if [ -e $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/LocalizableAdditions.strings > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelif [ -e $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings ] ; then\ncat $SRCROOT/en.lproj/Localizable.strings $SDKROOT/usr/local/include/WebKitAdditions/LocalizableAdditions.strings > $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nelse\ncp $SRCROOT/en.lproj/Localizable.strings $BUILT_PRODUCTS_DIR/DerivedSources/WebCore/Localizable.strings\nfi\n";
};
5325BDCC21DFF33E00A0DEE1 /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269914] trunk/Source/WebCore
Title: [269914] trunk/Source/WebCore
Revision 269914
Author grao...@webkit.org
Date 2020-11-17 11:04:10 -0800 (Tue, 17 Nov 2020)
Log Message
[Web Animations] Move all effect-specific parts of WebAnimation::timeToNextTick() to effect classes
https://bugs.webkit.org/show_bug.cgi?id=219028
Reviewed by Antti Koivisto.
Most of WebAnimation::timeToNextTick() is code that is specific to effects. We move this code out to
KeyframeEffect and a virtual method with a default implementation on AnimationEffect. This is the first
step towards adding more smarts to this method such as avoiding style recalcs if there are no keyframes
set up on a KeyframeEffect or running fewer style recalcs when animating a discrete property.
No new tests since this we are just moving code around.
* animation/AnimationEffect.h:
(WebCore::AnimationEffect::timeToNextTick const):
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::timeToNextTick const):
* animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::isCompletelyAccelerated const): Make this method private since it is now only
called by KeyframeEffect.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::timeToNextTick const):
(WebCore::WebAnimation::isCompletelyAccelerated const): Deleted. This method no longer has any call sites.
* animation/WebAnimation.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/AnimationEffect.h
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/animation/KeyframeEffect.h
trunk/Source/WebCore/animation/WebAnimation.cpp
trunk/Source/WebCore/animation/WebAnimation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (269913 => 269914)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 18:59:12 UTC (rev 269913)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 19:04:10 UTC (rev 269914)
@@ -1,3 +1,29 @@
+2020-11-17 Antoine Quint
+
+[Web Animations] Move all effect-specific parts of WebAnimation::timeToNextTick() to effect classes
+https://bugs.webkit.org/show_bug.cgi?id=219028
+
+Reviewed by Antti Koivisto.
+
+Most of WebAnimation::timeToNextTick() is code that is specific to effects. We move this code out to
+KeyframeEffect and a virtual method with a default implementation on AnimationEffect. This is the first
+step towards adding more smarts to this method such as avoiding style recalcs if there are no keyframes
+set up on a KeyframeEffect or running fewer style recalcs when animating a discrete property.
+
+No new tests since this we are just moving code around.
+
+* animation/AnimationEffect.h:
+(WebCore::AnimationEffect::timeToNextTick const):
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::timeToNextTick const):
+* animation/KeyframeEffect.h:
+(WebCore::KeyframeEffect::isCompletelyAccelerated const): Make this method private since it is now only
+called by KeyframeEffect.
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::timeToNextTick const):
+(WebCore::WebAnimation::isCompletelyAccelerated const): Deleted. This method no longer has any call sites.
+* animation/WebAnimation.h:
+
2020-11-17 Aditya Keerthi
[iOS][FCR] Add new look for checkboxes
Modified: trunk/Source/WebCore/animation/AnimationEffect.h (269913 => 269914)
--- trunk/Source/WebCore/animation/AnimationEffect.h 2020-11-17 18:59:12 UTC (rev 269913)
+++ trunk/Source/WebCore/animation/AnimationEffect.h 2020-11-17 19:04:10 UTC (rev 269914)
@@ -102,11 +102,13 @@
void updateStaticTimingProperties();
-virtual Optional progressUntilNextStep(double) const;
+virtual Seconds timeToNextTick() const { return Seconds::infinity(); }
protected:
explicit AnimationEffect();
+virtual Optional progressUntilNextStep(double) const;
+
private:
enum class ComputedDirection : uint8_t { Forwards, Reverse };
Modified: trunk/Source/WebCore/animation/KeyframeEffect.cpp (269913 => 269914)
--- trunk/Source/WebCore/animation/KeyframeEffect.cpp 2020-11-17 18:59:12 UTC (rev 269913)
+++ trunk/Source/WebCore/animation/KeyframeEffect.cpp 2020-11-17 19:04:10 UTC (rev 269914)
@@ -1972,4 +1972,40 @@
return WTF::nullopt;
}
+Seconds KeyframeEffect::timeToNextTick() const
+{
+auto timing = getBasicTiming();
+switch (timing.phase) {
+case AnimationEffectPhase::Before:
+// The effect is in its "before" phase, in this case we can wait until it enters its "active" phase.
+return delay() - *timing.localTime;
+case AnimationEffectPhase::Active:
+if (isCompletelyAccelerated() && isRunningAccelerated()) {
+// Fully-accelerated running CSS Animations need to trigger "animationiteration" events, in this case we must wait until the next iteration.
+if (is(animation())) {
+if (auto iterationProgress = getComputedTiming().simpleIterationProgress)
+
[webkit-changes] [269913] trunk
Title: [269913] trunk Revision 269913 Author akeer...@apple.com Date 2020-11-17 10:59:12 -0800 (Tue, 17 Nov 2020) Log Message [iOS][FCR] Add new look for checkboxes https://bugs.webkit.org/show_bug.cgi?id=218808 Reviewed by Wenson Hsieh. Source/WebCore: Tests: fast/forms/ios/form-control-refresh/checkbox/border.html fast/forms/ios/form-control-refresh/checkbox/checked-appearance.html fast/forms/ios/form-control-refresh/checkbox/ignored-properties.html fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance.html fast/forms/ios/form-control-refresh/checkbox/width-height.html * css/iOSFormControlRefresh.css: (input[type="checkbox"]): Use "border: initial" and "box-sizing: border-box" to match macOS, now that the native checkbox styles on macOS and iOS are similar. * rendering/RenderThemeIOS.h: * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::paintCheckboxDecorations): Move away from using paintCheckboxDecorations to paintCheckbox for the new design. This is necessary to avoid painting custom borders and backgrounds for native checkboxes, matching macOS. Painting both a CSS background as well as the native checkbox can lead to background bleeding. Customizations can still be made using "-webkit-appearance: none". (WebCore::RenderThemeIOS::paintCheckbox): A new implementation for painting checkboxes to match the updated design. The checkmark drawing was generated using SF Symbols. LayoutTests: Added tests to verify the stylability of native checkboxes and to verify that different checkbox states are painted with a different appearance. * fast/forms/ios/form-control-refresh/checkbox/border-expected-mismatch.html: Added. * fast/forms/ios/form-control-refresh/checkbox/border.html: Added. * fast/forms/ios/form-control-refresh/checkbox/checked-appearance-expected-mismatch.html: Added. * fast/forms/ios/form-control-refresh/checkbox/checked-appearance.html: Added. * fast/forms/ios/form-control-refresh/checkbox/ignored-properties-expected.html: Added. * fast/forms/ios/form-control-refresh/checkbox/ignored-properties.html: Added. * fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance-expected-mismatch.html: Added. * fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance.html: Added. * fast/forms/ios/form-control-refresh/checkbox/width-height-expected-mismatch.html: Added. * fast/forms/ios/form-control-refresh/checkbox/width-height.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/iOSFormControlRefresh.css trunk/Source/WebCore/rendering/RenderThemeIOS.h trunk/Source/WebCore/rendering/RenderThemeIOS.mm Added Paths trunk/LayoutTests/fast/forms/ios/form-control-refresh/ trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/ trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/border-expected-mismatch.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/border.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/checked-appearance-expected-mismatch.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/checked-appearance.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/ignored-properties-expected.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/ignored-properties.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance-expected-mismatch.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/width-height-expected-mismatch.html trunk/LayoutTests/fast/forms/ios/form-control-refresh/checkbox/width-height.html Diff Modified: trunk/LayoutTests/ChangeLog (269912 => 269913) --- trunk/LayoutTests/ChangeLog 2020-11-17 18:06:26 UTC (rev 269912) +++ trunk/LayoutTests/ChangeLog 2020-11-17 18:59:12 UTC (rev 269913) @@ -1,3 +1,25 @@ +2020-11-17 Aditya Keerthi + +[iOS][FCR] Add new look for checkboxes +https://bugs.webkit.org/show_bug.cgi?id=218808 + + +Reviewed by Wenson Hsieh. + +Added tests to verify the stylability of native checkboxes and to verify +that different checkbox states are painted with a different appearance. + +* fast/forms/ios/form-control-refresh/checkbox/border-expected-mismatch.html: Added. +* fast/forms/ios/form-control-refresh/checkbox/border.html: Added. +* fast/forms/ios/form-control-refresh/checkbox/checked-appearance-expected-mismatch.html: Added. +* fast/forms/ios/form-control-refresh/checkbox/checked-appearance.html: Added. +* fast/forms/ios/form-control-refresh/checkbox/ignored-properties-expected.html: Added. +* fast/forms/ios/form-control-refresh/checkbox/ignored-properties.html: Added. +* fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance-expected-mismatch.html: Added. +
[webkit-changes] [269912] trunk
Title: [269912] trunk
Revision 269912
Author za...@apple.com
Date 2020-11-17 10:06:26 -0800 (Tue, 17 Nov 2020)
Log Message
[LFC][Integration] Add even more integral snapping to inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=219011
Reviewed by Antti Koivisto.
It is required to match current legacy inline geometries.
* layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::InlineLevelBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineLevelBox::setLogicalHeight):
* layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::InlineLevelBox::setLogicalTop): Deleted.
(WebCore::Layout::LineBox::InlineLevelBox::setLogicalHeight): Deleted.
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
Modified Paths
trunk/LayoutTests/platform/ios/css1/formatting_model/height_of_lines-expected.txt
trunk/LayoutTests/platform/ios/css1/text_properties/vertical_align-expected.txt
trunk/LayoutTests/platform/mac/css1/formatting_model/height_of_lines-expected.txt
trunk/LayoutTests/platform/mac/css1/text_properties/vertical_align-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBox.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp
Diff
Modified: trunk/LayoutTests/platform/ios/css1/formatting_model/height_of_lines-expected.txt (269911 => 269912)
--- trunk/LayoutTests/platform/ios/css1/formatting_model/height_of_lines-expected.txt 2020-11-17 17:56:44 UTC (rev 269911)
+++ trunk/LayoutTests/platform/ios/css1/formatting_model/height_of_lines-expected.txt 2020-11-17 18:06:26 UTC (rev 269912)
@@ -119,7 +119,7 @@
RenderText {#text} at (510,183) size 28x17
text run at (510,183) width 28: " and "
RenderImage {IMG} at (552,198) size 131x130 [border: (10px solid #00)]
-RenderText {#text} at (697,183) size 758x258
+RenderText {#text} at (697,183) size 758x257
text run at (697,183) width 8: ". "
text run at (704,183) width 39: "This is"
text run at (0,344) width 721: "additional text to make sure that there is enough room left below the image so that this line does not hit the image that is text-top"
Modified: trunk/LayoutTests/platform/ios/css1/text_properties/vertical_align-expected.txt (269911 => 269912)
--- trunk/LayoutTests/platform/ios/css1/text_properties/vertical_align-expected.txt 2020-11-17 17:56:44 UTC (rev 269911)
+++ trunk/LayoutTests/platform/ios/css1/text_properties/vertical_align-expected.txt 2020-11-17 18:06:26 UTC (rev 269912)
@@ -85,8 +85,8 @@
RenderText {#text} at (0,0) size 0x0
RenderBlock {P} at (0,746) size 784x70
RenderImage {IMG} at (0,0) size 15x50
-RenderText {#text} at (15,13) size 755x56
- text run at (15,13) width 740: " The image at the beginning of this sentence should be middle-aligned, which should align its middle with the point"
+RenderText {#text} at (15,14) size 755x55
+ text run at (15,14) width 740: " The image at the beginning of this sentence should be middle-aligned, which should align its middle with the point"
text run at (0,50) width 318: "defined as the text baseline plus half the x-height."
RenderBlock {P} at (0,832) size 784x126
RenderImage {IMG} at (0,0) size 15x50
@@ -428,8 +428,8 @@
RenderText {#text} at (0,0) size 0x0
RenderBlock {P} at (4,431) size 762x70
RenderImage {IMG} at (0,0) size 15x50
-RenderText {#text} at (15,13) size 755x56
- text run at (15,13) width 740: " The image at the beginning of this sentence should be middle-aligned, which should align its middle with the point"
+RenderText {#text} at (15,14) size 755x55
+ text run at (15,14) width 740: " The image at the beginning of this sentence should be middle-aligned, which should align its middle with the point"
text run at (0,50) width 318: "defined as the text baseline plus half the x-height."
RenderBlock {P} at (4,517) size 762x126
RenderImage {IMG} at (0,0) size 15x50
Modified: trunk/LayoutTests/platform/mac/css1/formatting_model/height_of_lines-expected.txt (269911 => 269912)
--- trunk/LayoutTests/platform/mac/css1/formatting_model/height_of_lines-expected.txt 2020-11-17 17:56:44 UTC (rev 269911)
+++ trunk/LayoutTests/platform/mac/css1/formatting_model/height_of_lines-expected.txt 2020-11-17 18:06:26 UTC (rev 269912)
@@ -68,7 +68,7 @@
RenderText {#text} at (510,183) size 28x17
text run at (510,183) width 28: " and "
RenderImage {IMG} at (552,198) size 131x130 [border: (10px solid #00)]
-RenderText {#text} at (697,183) size 769x258
[webkit-changes] [269911] trunk/Source/WebKit
Title: [269911] trunk/Source/WebKit Revision 269911 Author bfulg...@apple.com Date 2020-11-17 09:56:44 -0800 (Tue, 17 Nov 2020) Log Message [macOS] Remove access to the unused AppleSNBFBUserClient IOKit class https://bugs.webkit.org/show_bug.cgi?id=219014 Reviewed by Eric Carlson. Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it. * GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (269910 => 269911) --- trunk/Source/WebKit/ChangeLog 2020-11-17 17:53:35 UTC (rev 269910) +++ trunk/Source/WebKit/ChangeLog 2020-11-17 17:56:44 UTC (rev 269911) @@ -1,3 +1,17 @@ +2020-11-17 Brent Fulgham + +[macOS] Remove access to the unused AppleSNBFBUserClient IOKit class +https://bugs.webkit.org/show_bug.cgi?id=219014 + + +Reviewed by Eric Carlson. + +Although we originally thought this was needed for H.264 decoding, testing shows +that this class is never used in WebKit flows, and is not needed. We should remove it. + +* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: +* WebProcess/com.apple.WebProcess.sb.in: + 2020-11-17 Chris Dumez [iOS] Stop leaking an XPC transaction in our XPC services Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (269910 => 269911) --- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2020-11-17 17:53:35 UTC (rev 269910) +++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2020-11-17 17:56:44 UTC (rev 269911) @@ -117,12 +117,12 @@ ;; CoreVideo CVCGDisplayLink (allow iokit-open (iokit-registry-entry-class "IOFramebufferSharedUserClient")) +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 ;; H.264 Acceleration (allow iokit-open -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 (iokit-registry-entry-class "AppleIntelMEUserClient") +(iokit-registry-entry-class "AppleSNBFBUserClient")) #endif -(iokit-registry-entry-class "AppleSNBFBUserClient")) ;; QuartzCore (allow iokit-open (iokit-registry-entry-class "AGPMClient") Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (269910 => 269911) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-11-17 17:53:35 UTC (rev 269910) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-11-17 17:56:44 UTC (rev 269911) @@ -171,8 +171,8 @@ (allow iokit-open (iokit-registry-entry-class "IOFramebufferSharedUserClient")) #endif +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 ;; H.264 Acceleration -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500 (allow iokit-open (iokit-registry-entry-class "AppleIntelMEUserClient") #if HAVE(SANDBOX_MESSAGE_FILTERING) @@ -188,7 +188,6 @@ ) #endif ) -#endif (allow iokit-open (iokit-registry-entry-class "AppleSNBFBUserClient") #if HAVE(SANDBOX_MESSAGE_FILTERING) @@ -204,6 +203,7 @@ ) #endif ) +#endif ;; QuartzCore (allow iokit-open (iokit-registry-entry-class "AGPMClient") ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269910] branches/safari-611.1.6-branch
Title: [269910] branches/safari-611.1.6-branch
Revision 269910
Author alanc...@apple.com
Date 2020-11-17 09:53:35 -0800 (Tue, 17 Nov 2020)
Log Message
Cherry-pick r269895. rdar://problem/71490402
REGRESSION (r269824): YouTube media control bar sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=219017
Reviewed by Simon Fraser.
Source/WebKit:
Test: compositing/repaint/transparent-layer-repaint.html
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
I accidentally lost the Copy composite operator in r269824, causing
the repaint copy-forward to blend instead of just copying.
This wreaks havoc on layers with contents with colors that have 0 < alpha < 1,
because every repaint means the colors intensify.
LayoutTests:
* compositing/repaint/transparent-layer-repaint-expected.html: Added.
* compositing/repaint/transparent-layer-repaint.html: Added.
Add a test that:
- repaints a backingstoreful compositing layer
- more than once
- in a small enough area that we use partial repaint
- with partially-transparent pixels
And then ensures that the background of that layer (the non-repainted part)
remains the color that it should.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-611.1.6-branch/LayoutTests/ChangeLog
branches/safari-611.1.6-branch/Source/WebKit/ChangeLog
branches/safari-611.1.6-branch/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
Added Paths
branches/safari-611.1.6-branch/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html
branches/safari-611.1.6-branch/LayoutTests/compositing/repaint/transparent-layer-repaint.html
Diff
Modified: branches/safari-611.1.6-branch/LayoutTests/ChangeLog (269909 => 269910)
--- branches/safari-611.1.6-branch/LayoutTests/ChangeLog 2020-11-17 17:38:27 UTC (rev 269909)
+++ branches/safari-611.1.6-branch/LayoutTests/ChangeLog 2020-11-17 17:53:35 UTC (rev 269910)
@@ -1,3 +1,59 @@
+2020-11-17 Russell Epstein
+
+Cherry-pick r269895. rdar://problem/71490402
+
+REGRESSION (r269824): YouTube media control bar sometimes flickers
+https://bugs.webkit.org/show_bug.cgi?id=219017
+
+
+Reviewed by Simon Fraser.
+
+Source/WebKit:
+
+Test: compositing/repaint/transparent-layer-repaint.html
+
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::display):
+I accidentally lost the Copy composite operator in r269824, causing
+the repaint copy-forward to blend instead of just copying.
+This wreaks havoc on layers with contents with colors that have 0 < alpha < 1,
+because every repaint means the colors intensify.
+
+LayoutTests:
+
+* compositing/repaint/transparent-layer-repaint-expected.html: Added.
+* compositing/repaint/transparent-layer-repaint.html: Added.
+Add a test that:
+- repaints a backingstoreful compositing layer
+- more than once
+- in a small enough area that we use partial repaint
+- with partially-transparent pixels
+
+And then ensures that the background of that layer (the non-repainted part)
+remains the color that it should.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-11-17 Tim Horton
+
+REGRESSION (r269824): YouTube media control bar sometimes flickers
+https://bugs.webkit.org/show_bug.cgi?id=219017
+
+
+Reviewed by Simon Fraser.
+
+* compositing/repaint/transparent-layer-repaint-expected.html: Added.
+* compositing/repaint/transparent-layer-repaint.html: Added.
+Add a test that:
+- repaints a backingstoreful compositing layer
+- more than once
+- in a small enough area that we use partial repaint
+- with partially-transparent pixels
+
+And then ensures that the background of that layer (the non-repainted part)
+remains the color that it should.
+
2020-11-16 Youenn Fablet
TextEncoderStreamEncoder should not be exposed
Added: branches/safari-611.1.6-branch/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html (0 => 269910)
--- branches/safari-611.1.6-branch/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html (rev 0)
+++ branches/safari-611.1.6-branch/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html 2020-11-17 17:53:35 UTC (rev 269910)
@@ -0,0 +1,19 @@
+
+
+
+
+.container {
+border: 1px solid black; /* Needed to disable simple color layer compositing. */
+height: 200px;
+width: 200px;
+transform:
[webkit-changes] [269909] trunk/Source/WebCore
Title: [269909] trunk/Source/WebCore
Revision 269909
Author cl...@igalia.com
Date 2020-11-17 09:38:27 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION(r269579) [WPE] Many tests with scrolling flaky after this revision
https://bugs.webkit.org/show_bug.cgi?id=218859
Reviewed by Simon Fraser.
Set scrolling node ID correctly on CoordinatedGraphicsLayer.
* page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateBeforeChildren):
* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setScrollingNodeID):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp
trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp
trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (269908 => 269909)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 17:28:09 UTC (rev 269908)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 17:38:27 UTC (rev 269909)
@@ -1,3 +1,21 @@
+2020-11-17 Chris Lord
+
+REGRESSION(r269579) [WPE] Many tests with scrolling flaky after this revision
+https://bugs.webkit.org/show_bug.cgi?id=218859
+
+Reviewed by Simon Fraser.
+
+Set scrolling node ID correctly on CoordinatedGraphicsLayer.
+
+* page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
+(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateBeforeChildren):
+* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
+* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
+* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+(WebCore::CoordinatedGraphicsLayer::setScrollingNodeID):
+(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
+* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
+
2020-11-17 Peng Liu
[Media In GPU Process][MSE] Add infrastructure needed to run MediaPlayerPrivateMediaSourceAVFObjC in the GPU process
Modified: trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp (269908 => 269909)
--- trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp 2020-11-17 17:28:09 UTC (rev 269908)
+++ trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp 2020-11-17 17:38:27 UTC (rev 269909)
@@ -89,16 +89,6 @@
auto* layer = static_cast(scrollingStateNode.footerLayer());
m_footerLayer = downcast(layer);
}
-if (scrollingStateNode.hasChangedProperty(ScrollingStateNode::Property::ScrolledContentsLayer)) {
-auto* scrollLayer = static_cast(scrolledContentsLayer());
-ASSERT(scrollLayer);
-auto& compositionLayer = downcast(*scrollLayer);
-auto updateScope = compositionLayer.createUpdateScope();
-compositionLayer.updateState([nodeID = scrollingNodeID()](Nicosia::CompositionLayer::LayerState& state) {
-state.scrollingNodeID = nodeID;
-state.delta.scrollingNodeChanged = true;
-});
-}
}
void ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren(const ScrollingStateNode& stateNode)
Modified: trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp (269908 => 269909)
--- trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp 2020-11-17 17:28:09 UTC (rev 269908)
+++ trunk/Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp 2020-11-17 17:38:27 UTC (rev 269909)
@@ -56,23 +56,6 @@
ScrollingTreeOverflowScrollingNodeNicosia::~ScrollingTreeOverflowScrollingNodeNicosia() = default;
-void ScrollingTreeOverflowScrollingNodeNicosia::commitStateBeforeChildren(const ScrollingStateNode& stateNode)
-{
-ScrollingTreeScrollingNode::commitStateBeforeChildren(stateNode);
-
-const auto& scrollingStateNode = downcast(stateNode);
-if (scrollingStateNode.hasChangedProperty(ScrollingStateNode::Property::ScrolledContentsLayer)) {
-auto* scrollLayer = static_cast(scrolledContentsLayer());
-ASSERT(scrollLayer);
-auto& compositionLayer = downcast(*scrollLayer);
-auto updateScope = compositionLayer.createUpdateScope();
-
[webkit-changes] [269908] trunk/Source/WebKit
Title: [269908] trunk/Source/WebKit
Revision 269908
Author cdu...@apple.com
Date 2020-11-17 09:28:09 -0800 (Tue, 17 Nov 2020)
Log Message
[iOS] Stop leaking an XPC transaction in our XPC services
https://bugs.webkit.org/show_bug.cgi?id=219036
Reviewed by Geoffrey Garen.
Stop leaking an XPC transaction in our XPC services on iOS. We were doing this to control the lifetime of our child services
ourselves. However, this is not needed on iOS because the UIProcess takes RunningBoard process assertions on behalf of its
child processes.
I have verified that our child processes do not exit/jetsam early. I have verified that our child processes are in the
correct jetsam band (IDLE/0 when background and FG/10 when foreground). I have also verified that the main thread of these
processes runs at UserInitiated QoS before and after this change.
* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceExit):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (269907 => 269908)
--- trunk/Source/WebKit/ChangeLog 2020-11-17 17:25:27 UTC (rev 269907)
+++ trunk/Source/WebKit/ChangeLog 2020-11-17 17:28:09 UTC (rev 269908)
@@ -1,3 +1,23 @@
+2020-11-17 Chris Dumez
+
+[iOS] Stop leaking an XPC transaction in our XPC services
+https://bugs.webkit.org/show_bug.cgi?id=219036
+
+Reviewed by Geoffrey Garen.
+
+Stop leaking an XPC transaction in our XPC services on iOS. We were doing this to control the lifetime of our child services
+ourselves. However, this is not needed on iOS because the UIProcess takes RunningBoard process assertions on behalf of its
+child processes.
+
+I have verified that our child processes do not exit/jetsam early. I have verified that our child processes are in the
+correct jetsam band (IDLE/0 when background and FG/10 when foreground). I have also verified that the main thread of these
+processes runs at UserInitiated QoS before and after this change.
+
+* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
+(WebKit::XPCServiceInitializer):
+* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
+(WebKit::XPCServiceExit):
+
2020-11-17 Peng Liu
[Media In GPU Process][MSE] Add infrastructure needed to run MediaPlayerPrivateMediaSourceAVFObjC in the GPU process
Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h (269907 => 269908)
--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h 2020-11-17 17:25:27 UTC (rev 269907)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h 2020-11-17 17:28:09 UTC (rev 269908)
@@ -91,10 +91,13 @@
XPCServiceInitializerDelegateType delegate(WTFMove(connection), initializerMessage);
// We don't want XPC to be in charge of whether the process should be terminated or not,
-// so ensure that we have an outstanding transaction here.
+// so ensure that we have an outstanding transaction here. This is not needed on iOS because
+// the UIProcess takes process assertions on behalf of its child processes.
+#if PLATFORM(MAC)
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
xpc_transaction_begin();
ALLOW_DEPRECATED_DECLARATIONS_END
+#endif
InitializeWebKit2();
Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm (269907 => 269908)
--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm 2020-11-17 17:25:27 UTC (rev 269907)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm 2020-11-17 17:28:09 UTC (rev 269908)
@@ -144,10 +144,14 @@
{
// Make sure to destroy the priority boost message to avoid leaking a transaction.
priorityBoostMessage = nullptr;
+
// Balances the xpc_transaction_begin() in XPCServiceInitializer.
+#if PLATFORM(MAC)
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
xpc_transaction_end();
ALLOW_DEPRECATED_DECLARATIONS_END
+#endif
+
xpc_transaction_exit_clean();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269906] trunk/Source
Title: [269906] trunk/Source
Revision 269906
Author pvol...@apple.com
Date 2020-11-17 09:21:49 -0800 (Tue, 17 Nov 2020)
Log Message
[macOS] Perform AX TCC check in the UI process
https://bugs.webkit.org/show_bug.cgi?id=218870
Reviewed by Brent Fulgham.
Source/WebCore/PAL:
Add typedef for TCC authentication callback.
* pal/spi/mac/HIServicesSPI.h:
Source/WebKit:
On behalf of the WebContent process, perform AX TCC check in the UI process on macOS.
This is in preparation of blocking tccd in the WebContent process.
No new tests. It has been manually tested that the WebContent process is allowing VoiceOver
to perform AX requests with this patch.
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::isAXAuthenticated):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::isAXAuthenticatedCallback):
(WebKit::WebProcess::platformInitializeWebProcess):
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.messages.in
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (269905 => 269906)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-11-17 17:09:11 UTC (rev 269905)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-11-17 17:21:49 UTC (rev 269906)
@@ -1,3 +1,15 @@
+2020-11-17 Per Arne Vollan
+
+[macOS] Perform AX TCC check in the UI process
+https://bugs.webkit.org/show_bug.cgi?id=218870
+
+
+Reviewed by Brent Fulgham.
+
+Add typedef for TCC authentication callback.
+
+* pal/spi/mac/HIServicesSPI.h:
+
2020-11-17 Kimmo Kinnunen
Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
Modified: trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (269905 => 269906)
--- trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h 2020-11-17 17:09:11 UTC (rev 269905)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h 2020-11-17 17:21:49 UTC (rev 269906)
@@ -156,4 +156,10 @@
#endif // USE(APPLE_INTERNAL_SDK)
+WTF_EXTERN_C_BEGIN
+
+typedef Boolean (*AXAuditTokenIsAuthenticatedCallback)(audit_token_t);
+
+WTF_EXTERN_C_END
+
#define kAXClientTypeWebKitTesting 99
Modified: trunk/Source/WebKit/ChangeLog (269905 => 269906)
--- trunk/Source/WebKit/ChangeLog 2020-11-17 17:09:11 UTC (rev 269905)
+++ trunk/Source/WebKit/ChangeLog 2020-11-17 17:21:49 UTC (rev 269906)
@@ -1,3 +1,25 @@
+2020-11-17 Per Arne Vollan
+
+[macOS] Perform AX TCC check in the UI process
+https://bugs.webkit.org/show_bug.cgi?id=218870
+
+
+Reviewed by Brent Fulgham.
+
+On behalf of the WebContent process, perform AX TCC check in the UI process on macOS.
+This is in preparation of blocking tccd in the WebContent process.
+
+No new tests. It has been manually tested that the WebContent process is allowing VoiceOver
+to perform AX requests with this patch.
+
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::isAXAuthenticated):
+* UIProcess/WebProcessProxy.h:
+* UIProcess/WebProcessProxy.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::isAXAuthenticatedCallback):
+(WebKit::WebProcess::platformInitializeWebProcess):
+
2020-11-17 Brian Burg
[Cocoa] _WKInspectorExtensionHost should conform to NSObject protocol
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (269905 => 269906)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-11-17 17:09:11 UTC (rev 269905)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-11-17 17:21:49 UTC (rev 269906)
@@ -49,6 +49,14 @@
#import <_javascript_Core/RemoteInspectorConstants.h>
#endif
+#if PLATFORM(MAC)
+#import
+
+SOFT_LINK_PRIVATE_FRAMEWORK(TCC)
+SOFT_LINK(TCC, TCCAccessCheckAuditToken, Boolean, (CFStringRef service, audit_token_t auditToken, CFDictionaryRef options), (service, auditToken, options))
+SOFT_LINK_CONSTANT(TCC, kTCCServiceAccessibility, CFStringRef)
+#endif
+
namespace WebKit {
static const Seconds unexpectedActivityDuration = 10_s;
@@ -258,4 +266,12 @@
return overrideLanguages;
}
+#if PLATFORM(MAC)
+void WebProcessProxy::isAXAuthenticated(audit_token_t auditToken, CompletionHandler&& completionHandler)
+{
+auto authenticated = TCCAccessCheckAuditToken(getkTCCServiceAccessibility(), auditToken, nullptr);
+completionHandler(authenticated);
}
+#endif
+
+}
Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.h (269905 => 269906)
--- trunk/Source/WebKit/UIProcess/WebProcessProxy.h 2020-11-17 17:09:11 UTC (rev 269905)
+++
[webkit-changes] [269905] trunk/Source/WebKit
Title: [269905] trunk/Source/WebKit Revision 269905 Author bb...@apple.com Date 2020-11-17 09:09:11 -0800 (Tue, 17 Nov 2020) Log Message [Cocoa] _WKInspectorExtensionHost should conform to NSObject protocol https://bugs.webkit.org/show_bug.cgi?id=219035 Reviewed by Alex Christensen. This was overlooked in the initial patch. Without it, we can't call -isEqual: and similar basic methods on a type of id<_WKInspectorExtensionHost>. * UIProcess/API/Cocoa/_WKInspectorExtensionHost.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h Diff Modified: trunk/Source/WebKit/ChangeLog (269904 => 269905) --- trunk/Source/WebKit/ChangeLog 2020-11-17 17:07:28 UTC (rev 269904) +++ trunk/Source/WebKit/ChangeLog 2020-11-17 17:09:11 UTC (rev 269905) @@ -1,3 +1,15 @@ +2020-11-17 Brian Burg + +[Cocoa] _WKInspectorExtensionHost should conform to NSObject protocol +https://bugs.webkit.org/show_bug.cgi?id=219035 + +Reviewed by Alex Christensen. + +This was overlooked in the initial patch. Without it, we can't call -isEqual: and +similar basic methods on a type of id<_WKInspectorExtensionHost>. + +* UIProcess/API/Cocoa/_WKInspectorExtensionHost.h: + 2020-11-17 Tim Horton Preemptive build fix for https://bugs.webkit.org/show_bug.cgi?id=219024 Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h (269904 => 269905) --- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h 2020-11-17 17:07:28 UTC (rev 269904) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h 2020-11-17 17:09:11 UTC (rev 269905) @@ -30,7 +30,7 @@ @class _WKInspectorExtension; -@protocol _WKInspectorExtensionHost +@protocol _WKInspectorExtensionHost @optional /** ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269904] trunk/Tools
Title: [269904] trunk/Tools Revision 269904 Author aakash_j...@apple.com Date 2020-11-17 09:07:28 -0800 (Tue, 17 Nov 2020) Log Message [build.webkit.org] Update ExtractTestResults step for new buildbot (follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=218759 Unreviewed minor follow-up fix. * CISupport/build-webkit-org/steps.py: (ExtractTestResults): Modified Paths trunk/Tools/CISupport/build-webkit-org/steps.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (269903 => 269904) --- trunk/Tools/CISupport/build-webkit-org/steps.py 2020-11-17 16:38:16 UTC (rev 269903) +++ trunk/Tools/CISupport/build-webkit-org/steps.py 2020-11-17 17:07:28 UTC (rev 269904) @@ -1193,7 +1193,8 @@ class ExtractTestResults(master.MasterShellCommand): name = 'extract-test-results' descriptionDone = ['Extracted test results'] -renderables = ['resultDirectory', 'zipFile'] +if USE_BUILDBOT_VERSION2: +renderables = ['resultDirectory', 'zipFile'] def __init__(self, **kwargs): kwargs['command'] = "" Modified: trunk/Tools/ChangeLog (269903 => 269904) --- trunk/Tools/ChangeLog 2020-11-17 16:38:16 UTC (rev 269903) +++ trunk/Tools/ChangeLog 2020-11-17 17:07:28 UTC (rev 269904) @@ -1,3 +1,14 @@ +2020-11-17 Aakash Jain + +[build.webkit.org] Update ExtractTestResults step for new buildbot (follow-up fix) +https://bugs.webkit.org/show_bug.cgi?id=218759 + + +Unreviewed minor follow-up fix. + +* CISupport/build-webkit-org/steps.py: +(ExtractTestResults): + 2020-11-16 Jonathan Bedard [webkitscmpy] Generalize parts of local.Scm class ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269903] trunk/LayoutTests
Title: [269903] trunk/LayoutTests
Revision 269903
Author lmo...@igalia.com
Date 2020-11-17 08:38:16 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION(r269227) [GTK] editing/selection/navigation-clears-editor-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=219019
Reviewed by Chris Dumez.
Apply a similar fix to what was done in
requestidlecallback/requestidlecallback-document-gc.html in the
original revision, giving the timers a spin to allow the released
documents to be collected.
* editing/selection/navigation-clears-editor-state.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/navigation-clears-editor-state.html
Diff
Modified: trunk/LayoutTests/ChangeLog (269902 => 269903)
--- trunk/LayoutTests/ChangeLog 2020-11-17 16:29:25 UTC (rev 269902)
+++ trunk/LayoutTests/ChangeLog 2020-11-17 16:38:16 UTC (rev 269903)
@@ -1,3 +1,17 @@
+2020-11-17 Lauro Moura
+
+REGRESSION(r269227) [GTK] editing/selection/navigation-clears-editor-state.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=219019
+
+Reviewed by Chris Dumez.
+
+Apply a similar fix to what was done in
+requestidlecallback/requestidlecallback-document-gc.html in the
+original revision, giving the timers a spin to allow the released
+documents to be collected.
+
+* editing/selection/navigation-clears-editor-state.html:
+
2020-11-17 Rob Buis
Null check anchorNode of endingSelection start
Modified: trunk/LayoutTests/editing/selection/navigation-clears-editor-state.html (269902 => 269903)
--- trunk/LayoutTests/editing/selection/navigation-clears-editor-state.html 2020-11-17 16:29:25 UTC (rev 269902)
+++ trunk/LayoutTests/editing/selection/navigation-clears-editor-state.html 2020-11-17 16:38:16 UTC (rev 269903)
@@ -51,11 +51,12 @@
let resolved = 0;
for (let frame of frames) {
frame.src = ""
-frame._onload_ = () => {
+frame._onload_ = async () => {
++resolved;
if (resolved !== count)
return;
let before = internals.numberOfLiveDocuments();
+await wait(0);
GCController.collect();
let after = internals.numberOfLiveDocuments();
let delta = before - after;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269902] trunk
Title: [269902] trunk
Revision 269902
Author commit-qu...@webkit.org
Date 2020-11-17 08:29:25 -0800 (Tue, 17 Nov 2020)
Log Message
Null check anchorNode of endingSelection start
https://bugs.webkit.org/show_bug.cgi?id=218492
Patch by Rob Buis on 2020-11-17
Reviewed by Alex Christensen.
Source/WebCore:
Null check anchorNode of endingSelection start.
Test: editing/deleting/delete-contenteditable-crash.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):
LayoutTests:
Add testcase.
* editing/deleting/delete-contenteditable-crash-expected.txt: Added.
* editing/deleting/delete-contenteditable-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
Added Paths
trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt
trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (269901 => 269902)
--- trunk/LayoutTests/ChangeLog 2020-11-17 16:04:30 UTC (rev 269901)
+++ trunk/LayoutTests/ChangeLog 2020-11-17 16:29:25 UTC (rev 269902)
@@ -1,5 +1,17 @@
2020-11-17 Rob Buis
+Null check anchorNode of endingSelection start
+https://bugs.webkit.org/show_bug.cgi?id=218492
+
+Reviewed by Alex Christensen.
+
+Add testcase.
+
+* editing/deleting/delete-contenteditable-crash-expected.txt: Added.
+* editing/deleting/delete-contenteditable-crash.html: Added.
+
+2020-11-17 Rob Buis
+
Clean up title-text-property.html
https://bugs.webkit.org/show_bug.cgi?id=219025
Added: trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt (0 => 269902)
--- trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt 2020-11-17 16:29:25 UTC (rev 269902)
@@ -0,0 +1 @@
+Test passes if no crashes with asan.
Added: trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html (0 => 269902)
--- trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-contenteditable-crash.html 2020-11-17 16:29:25 UTC (rev 269902)
@@ -0,0 +1,26 @@
+
+
+
+
+
+function runTest()
+{
+if (window.testRunner)
+testRunner.dumpAsText();
+
+getSelection().setBaseAndExtent(span, 0, span, 2);
+document.execCommand("delete", false);
+document.write("Test passes if no crashes with asan.")
+}
+
+
+
+
+
+
+
+content
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (269901 => 269902)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 16:04:30 UTC (rev 269901)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 16:29:25 UTC (rev 269902)
@@ -1,3 +1,17 @@
+2020-11-17 Rob Buis
+
+Null check anchorNode of endingSelection start
+https://bugs.webkit.org/show_bug.cgi?id=218492
+
+Reviewed by Alex Christensen.
+
+Null check anchorNode of endingSelection start.
+
+Test: editing/deleting/delete-contenteditable-crash.html
+
+* editing/DeleteSelectionCommand.cpp:
+(WebCore::DeleteSelectionCommand::mergeParagraphs):
+
2020-11-17 Kimmo Kinnunen
Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (269901 => 269902)
--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2020-11-17 16:04:30 UTC (rev 269901)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2020-11-17 16:29:25 UTC (rev 269902)
@@ -761,7 +761,7 @@
// The endingPosition was likely clobbered by the move, so recompute it (moveParagraph selects the moved paragraph).
// FIXME (Bug 211793): endingSelection() becomes disconnected in moveParagraph
-if (endingSelection().start().anchorNode()->isConnected())
+if (auto* anchorNode = endingSelection().start().anchorNode(); anchorNode && anchorNode->isConnected())
m_endingPosition = endingSelection().start();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269901] trunk/Source/WebKit
Title: [269901] trunk/Source/WebKit
Revision 269901
Author timothy_hor...@apple.com
Date 2020-11-17 08:04:30 -0800 (Tue, 17 Nov 2020)
Log Message
Preemptive build fix for https://bugs.webkit.org/show_bug.cgi?id=219024
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(SOFT_LINK_CLASS):
(-[WKAirPlayRoutePicker show:fromRect:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (269900 => 269901)
--- trunk/Source/WebKit/ChangeLog 2020-11-17 15:31:47 UTC (rev 269900)
+++ trunk/Source/WebKit/ChangeLog 2020-11-17 16:04:30 UTC (rev 269901)
@@ -1,5 +1,13 @@
2020-11-17 Tim Horton
+Preemptive build fix for https://bugs.webkit.org/show_bug.cgi?id=219024
+
+* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
+(SOFT_LINK_CLASS):
+(-[WKAirPlayRoutePicker show:fromRect:]):
+
+2020-11-17 Tim Horton
+
REGRESSION (r269824): YouTube media control bar sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=219017
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm (269900 => 269901)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2020-11-17 15:31:47 UTC (rev 269900)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2020-11-17 16:04:30 UTC (rev 269901)
@@ -47,13 +47,11 @@
SOFT_LINK_CLASS(MediaPlayer, MPAudioVideoRoutingPopoverController)
SOFT_LINK_CLASS(MediaPlayer, MPAVRoutingSheet)
-using namespace WebKit;
-
@implementation WKAirPlayRoutePicker {
RetainPtr _routingController;
RetainPtr _popoverController; // iPad
RetainPtr _actionSheet; // iPhone
-WKContentView* _view; // Weak reference.
+WKContentView *_view;
}
- (instancetype)initWithView:(WKContentView *)view
@@ -154,7 +152,7 @@
[_routingController setDiscoveryMode:MPRouteDiscoveryModeDetailed];
MPAVItemType itemType = hasVideo ? MPAVItemTypeVideo : MPAVItemTypeAudio;
-if (currentUserInterfaceIdiomIsPadOrMac())
+if (WebKit::currentUserInterfaceIdiomIsPadOrMac())
[self showAirPlayPickerIPad:itemType fromRect:elementRect];
else
[self showAirPlayPickerIPhone:itemType];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269900] trunk/Source
Title: [269900] trunk/Source
Revision 269900
Author commit-qu...@webkit.org
Date 2020-11-17 07:31:47 -0800 (Tue, 17 Nov 2020)
Log Message
Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
https://bugs.webkit.org/show_bug.cgi?id=219030
Patch by Kimmo Kinnunen on 2020-11-17
Reviewed by Antti Koivisto.
Fix compile for simulator builds.
Rename HAVE_CV_AGX_420_PIXEL_FORMAT_TYPES to
HAVE_COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES to better reflect what the ifdef does.
Source/WebCore:
* platform/graphics/cv/GraphicsContextGLCVANGLE.cpp:
(WebCore::pixelRangeFromPixelFormat):
(WebCore::GraphicsContextGLCVANGLE::copyPixelBufferToTexture):
Source/WebCore/PAL:
* pal/spi/cf/CoreVideoSPI.h:
Source/WTF:
* wtf/PlatformHave.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h
trunk/Source/WebCore/platform/graphics/cv/GraphicsContextGLCVANGLE.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (269899 => 269900)
--- trunk/Source/WTF/ChangeLog 2020-11-17 14:48:07 UTC (rev 269899)
+++ trunk/Source/WTF/ChangeLog 2020-11-17 15:31:47 UTC (rev 269900)
@@ -1,3 +1,16 @@
+2020-11-17 Kimmo Kinnunen
+
+Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
+https://bugs.webkit.org/show_bug.cgi?id=219030
+
+Reviewed by Antti Koivisto.
+
+Fix compile for simulator builds.
+Rename HAVE_CV_AGX_420_PIXEL_FORMAT_TYPES to
+HAVE_COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES to better reflect what the ifdef does.
+
+* wtf/PlatformHave.h:
+
2020-11-17 Antoine Quint
Make disabled by default everywhere
Modified: trunk/Source/WTF/wtf/PlatformHave.h (269899 => 269900)
--- trunk/Source/WTF/wtf/PlatformHave.h 2020-11-17 14:48:07 UTC (rev 269899)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2020-11-17 15:31:47 UTC (rev 269900)
@@ -775,6 +775,6 @@
#define HAVE_SANDBOX_MESSAGE_FILTERING 1
#endif
-#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 11)
-#define HAVE_CV_AGX_420_PIXEL_FORMAT_TYPES 1
+#if (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 11)
+#define HAVE_COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES 1
#endif
Modified: trunk/Source/WebCore/ChangeLog (269899 => 269900)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 14:48:07 UTC (rev 269899)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 15:31:47 UTC (rev 269900)
@@ -1,3 +1,18 @@
+2020-11-17 Kimmo Kinnunen
+
+Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
+https://bugs.webkit.org/show_bug.cgi?id=219030
+
+Reviewed by Antti Koivisto.
+
+Fix compile for simulator builds.
+Rename HAVE_CV_AGX_420_PIXEL_FORMAT_TYPES to
+HAVE_COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES to better reflect what the ifdef does.
+
+* platform/graphics/cv/GraphicsContextGLCVANGLE.cpp:
+(WebCore::pixelRangeFromPixelFormat):
+(WebCore::GraphicsContextGLCVANGLE::copyPixelBufferToTexture):
+
2020-11-17 Claudio Saavedra
More non-unified build fixes
Modified: trunk/Source/WebCore/PAL/ChangeLog (269899 => 269900)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-11-17 14:48:07 UTC (rev 269899)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-11-17 15:31:47 UTC (rev 269900)
@@ -1,5 +1,18 @@
2020-11-17 Kimmo Kinnunen
+Build fails on internal simulator builds due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
+https://bugs.webkit.org/show_bug.cgi?id=219030
+
+Reviewed by Antti Koivisto.
+
+Fix compile for simulator builds.
+Rename HAVE_CV_AGX_420_PIXEL_FORMAT_TYPES to
+HAVE_COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES to better reflect what the ifdef does.
+
+* pal/spi/cf/CoreVideoSPI.h:
+
+2020-11-17 Kimmo Kinnunen
+
Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
https://bugs.webkit.org/show_bug.cgi?id=219026
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h (269899 => 269900)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h 2020-11-17 14:48:07 UTC (rev 269899)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h 2020-11-17 15:31:47 UTC (rev 269900)
@@ -31,7 +31,7 @@
#include
#else
-#if HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)
+#if HAVE(COREVIDEO_COMPRESSED_PIXEL_FORMAT_TYPES)
enum {
kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange = '&8v0',
kCVPixelFormatType_AGX_420YpCbCr8BiPlanarFullRange = '&8f0',
Modified: trunk/Source/WebCore/platform/graphics/cv/GraphicsContextGLCVANGLE.cpp (269899 => 269900)
---
[webkit-changes] [269899] trunk/Source/WebCore
Title: [269899] trunk/Source/WebCore Revision 269899 Author csaave...@igalia.com Date 2020-11-17 06:48:07 -0800 (Tue, 17 Nov 2020) Log Message More non-unified build fixes https://bugs.webkit.org/show_bug.cgi?id=219029 Unreviewed. * rendering/RenderLayerBacking.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayerBacking.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (269898 => 269899) --- trunk/Source/WebCore/ChangeLog 2020-11-17 14:07:00 UTC (rev 269898) +++ trunk/Source/WebCore/ChangeLog 2020-11-17 14:48:07 UTC (rev 269899) @@ -1,3 +1,12 @@ +2020-11-17 Claudio Saavedra + +More non-unified build fixes +https://bugs.webkit.org/show_bug.cgi?id=219029 + +Unreviewed. + +* rendering/RenderLayerBacking.cpp: + 2020-11-17 Rob Buis Check whether destination still can be selected Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (269898 => 269899) --- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2020-11-17 14:07:00 UTC (rev 269898) +++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2020-11-17 14:48:07 UTC (rev 269899) @@ -32,6 +32,7 @@ #include "CSSPropertyNames.h" #include "CachedImage.h" #include "Chrome.h" +#include "DebugOverlayRegions.h" #include "DocumentTimeline.h" #include "EventRegion.h" #include "Frame.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269898] trunk/Source
Title: [269898] trunk/Source
Revision 269898
Author commit-qu...@webkit.org
Date 2020-11-17 06:07:00 -0800 (Tue, 17 Nov 2020)
Log Message
Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
https://bugs.webkit.org/show_bug.cgi?id=219026
Patch by Kimmo Kinnunen on 2020-11-17
Reviewed by Antti Koivisto.
Fix compile for macOS versions before Big Sur.
On macOS, only use the private header on Big Sur. On Catalina, use the
manual enums.
Regressed in:
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
* pal/spi/cf/CoreVideoSPI.h:
Modified Paths
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h
trunk/Source/WebCore/platform/graphics/cv/GraphicsContextGLCVANGLE.cpp
Diff
Modified: trunk/Source/WTF/wtf/PlatformHave.h (269897 => 269898)
--- trunk/Source/WTF/wtf/PlatformHave.h 2020-11-17 12:56:59 UTC (rev 269897)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2020-11-17 14:07:00 UTC (rev 269898)
@@ -774,3 +774,7 @@
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 11 && defined __has_include && __has_include()
#define HAVE_SANDBOX_MESSAGE_FILTERING 1
#endif
+
+#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 11)
+#define HAVE_CV_AGX_420_PIXEL_FORMAT_TYPES 1
+#endif
Modified: trunk/Source/WebCore/PAL/ChangeLog (269897 => 269898)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-11-17 12:56:59 UTC (rev 269897)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-11-17 14:07:00 UTC (rev 269898)
@@ -1,3 +1,20 @@
+2020-11-17 Kimmo Kinnunen
+
+Build fails on internal Catalina due to missing enum kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
+https://bugs.webkit.org/show_bug.cgi?id=219026
+
+Reviewed by Antti Koivisto.
+
+Fix compile for macOS versions before Big Sur.
+
+On macOS, only use the private header on Big Sur. On Catalina, use the
+manual enums.
+
+Regressed in:
+Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
+
+* pal/spi/cf/CoreVideoSPI.h:
+
2020-11-16 Kimmo Kinnunen
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h (269897 => 269898)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h 2020-11-17 12:56:59 UTC (rev 269897)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h 2020-11-17 14:07:00 UTC (rev 269898)
@@ -30,8 +30,12 @@
#if USE(APPLE_INTERNAL_SDK)
#include
#else
+
+#if HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)
enum {
kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange = '&8v0',
kCVPixelFormatType_AGX_420YpCbCr8BiPlanarFullRange = '&8f0',
};
#endif
+
+#endif
Modified: trunk/Source/WebCore/platform/graphics/cv/GraphicsContextGLCVANGLE.cpp (269897 => 269898)
--- trunk/Source/WebCore/platform/graphics/cv/GraphicsContextGLCVANGLE.cpp 2020-11-17 12:56:59 UTC (rev 269897)
+++ trunk/Source/WebCore/platform/graphics/cv/GraphicsContextGLCVANGLE.cpp 2020-11-17 14:07:00 UTC (rev 269898)
@@ -147,7 +147,9 @@
case kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange:
case kCVPixelFormatType_422YpCbCr10BiPlanarVideoRange:
case kCVPixelFormatType_444YpCbCr10BiPlanarVideoRange:
+#if HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)
case kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange:
+#endif
return PixelRange::Video;
case kCVPixelFormatType_420YpCbCr8PlanarFullRange:
case kCVPixelFormatType_420YpCbCr8BiPlanarFullRange:
@@ -156,7 +158,9 @@
case kCVPixelFormatType_420YpCbCr10BiPlanarFullRange:
case kCVPixelFormatType_422YpCbCr10BiPlanarFullRange:
case kCVPixelFormatType_444YpCbCr10BiPlanarFullRange:
+#if HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)
case kCVPixelFormatType_AGX_420YpCbCr8BiPlanarFullRange:
+#endif
return PixelRange::Full;
default:
return PixelRange::Unknown;
@@ -583,8 +587,11 @@
OSType pixelFormat = CVPixelBufferGetPixelFormatType(image);
if (pixelFormat != kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange
&& pixelFormat != kCVPixelFormatType_420YpCbCr8BiPlanarFullRange
+#if HAVE(CV_AGX_420_PIXEL_FORMAT_TYPES)
&& pixelFormat != kCVPixelFormatType_AGX_420YpCbCr8BiPlanarVideoRange
-&& pixelFormat != kCVPixelFormatType_AGX_420YpCbCr8BiPlanarFullRange) {
+&& pixelFormat != kCVPixelFormatType_AGX_420YpCbCr8BiPlanarFullRange
+#endif
+) {
LOG(WebGL, "GraphicsContextGLCVANGLE::copyVideoTextureToPlatformTexture(%p) - Asked to copy an unsupported pixel format ('%s').", this, FourCC(pixelFormat).toString().utf8().data());
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269897] trunk/Source/WTF
Title: [269897] trunk/Source/WTF Revision 269897 Author grao...@webkit.org Date 2020-11-17 04:56:59 -0800 (Tue, 17 Nov 2020) Log Message Make disabled by default everywhere https://bugs.webkit.org/show_bug.cgi?id=219027 Reviewed by Devin Rousso. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (269896 => 269897) --- trunk/Source/WTF/ChangeLog 2020-11-17 10:43:32 UTC (rev 269896) +++ trunk/Source/WTF/ChangeLog 2020-11-17 12:56:59 UTC (rev 269897) @@ -1,3 +1,12 @@ +2020-11-17 Antoine Quint + +Make disabled by default everywhere +https://bugs.webkit.org/show_bug.cgi?id=219027 + +Reviewed by Devin Rousso. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2020-11-16 Sam Weinig Standardize enums that are used by Settings in preperation for autogeneration Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (269896 => 269897) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2020-11-17 10:43:32 UTC (rev 269896) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2020-11-17 12:56:59 UTC (rev 269897) @@ -573,7 +573,6 @@ WebKitLegacy: default: false WebKit: - "ENABLE(EXPERIMENTAL_FEATURES)" : true default: false WebCore: default: false ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269896] trunk/LayoutTests
Title: [269896] trunk/LayoutTests
Revision 269896
Author commit-qu...@webkit.org
Date 2020-11-17 02:43:32 -0800 (Tue, 17 Nov 2020)
Log Message
Clean up title-text-property.html
https://bugs.webkit.org/show_bug.cgi?id=219025
Patch by Rob Buis on 2020-11-17
Reviewed by Žan Doberšek.
Remove unused test function, it seems this was added
for debugging purposes.
* fast/dom/title-text-property.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/title-text-property.html
Diff
Modified: trunk/LayoutTests/ChangeLog (269895 => 269896)
--- trunk/LayoutTests/ChangeLog 2020-11-17 08:28:31 UTC (rev 269895)
+++ trunk/LayoutTests/ChangeLog 2020-11-17 10:43:32 UTC (rev 269896)
@@ -1,3 +1,15 @@
+2020-11-17 Rob Buis
+
+Clean up title-text-property.html
+https://bugs.webkit.org/show_bug.cgi?id=219025
+
+Reviewed by Žan Doberšek.
+
+Remove unused test function, it seems this was added
+for debugging purposes.
+
+* fast/dom/title-text-property.html:
+
2020-11-17 Tim Horton
REGRESSION (r269824): YouTube media control bar sometimes flickers
Modified: trunk/LayoutTests/fast/dom/title-text-property.html (269895 => 269896)
--- trunk/LayoutTests/fast/dom/title-text-property.html 2020-11-17 08:28:31 UTC (rev 269895)
+++ trunk/LayoutTests/fast/dom/title-text-property.html 2020-11-17 10:43:32 UTC (rev 269896)
@@ -25,13 +25,6 @@
debugOutput('New title is: \'' + titleElem.text + '\'');
}
-
-function test() {
-t = document.getElementsByTagName('title').item(0);
-alert(t.text);
-t.text = 'new title';
-alert(t.text);
-}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269895] trunk
Title: [269895] trunk
Revision 269895
Author timothy_hor...@apple.com
Date 2020-11-17 00:28:31 -0800 (Tue, 17 Nov 2020)
Log Message
REGRESSION (r269824): YouTube media control bar sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=219017
Reviewed by Simon Fraser.
Source/WebKit:
Test: compositing/repaint/transparent-layer-repaint.html
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
I accidentally lost the Copy composite operator in r269824, causing
the repaint copy-forward to blend instead of just copying.
This wreaks havoc on layers with contents with colors that have 0 < alpha < 1,
because every repaint means the colors intensify.
LayoutTests:
* compositing/repaint/transparent-layer-repaint-expected.html: Added.
* compositing/repaint/transparent-layer-repaint.html: Added.
Add a test that:
- repaints a backingstoreful compositing layer
- more than once
- in a small enough area that we use partial repaint
- with partially-transparent pixels
And then ensures that the background of that layer (the non-repainted part)
remains the color that it should.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
Added Paths
trunk/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html
trunk/LayoutTests/compositing/repaint/transparent-layer-repaint.html
Diff
Modified: trunk/LayoutTests/ChangeLog (269894 => 269895)
--- trunk/LayoutTests/ChangeLog 2020-11-17 08:22:08 UTC (rev 269894)
+++ trunk/LayoutTests/ChangeLog 2020-11-17 08:28:31 UTC (rev 269895)
@@ -1,3 +1,22 @@
+2020-11-17 Tim Horton
+
+REGRESSION (r269824): YouTube media control bar sometimes flickers
+https://bugs.webkit.org/show_bug.cgi?id=219017
+
+
+Reviewed by Simon Fraser.
+
+* compositing/repaint/transparent-layer-repaint-expected.html: Added.
+* compositing/repaint/transparent-layer-repaint.html: Added.
+Add a test that:
+- repaints a backingstoreful compositing layer
+- more than once
+- in a small enough area that we use partial repaint
+- with partially-transparent pixels
+
+And then ensures that the background of that layer (the non-repainted part)
+remains the color that it should.
+
2020-11-17 Rob Buis
Check whether destination still can be selected
Added: trunk/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html (0 => 269895)
--- trunk/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html 2020-11-17 08:28:31 UTC (rev 269895)
@@ -0,0 +1,19 @@
+
+
+
+
+.container {
+border: 1px solid black; /* Needed to disable simple color layer compositing. */
+height: 200px;
+width: 200px;
+transform: translateZ(0);
+background-color: rgba(0, 255, 0, 0.2);
+}
+
+
+
+Test for repaint in a transparent composited layer. The two squares below should be identical, green @ 20% alpha.
+
+
+
+
Added: trunk/LayoutTests/compositing/repaint/transparent-layer-repaint.html (0 => 269895)
--- trunk/LayoutTests/compositing/repaint/transparent-layer-repaint.html (rev 0)
+++ trunk/LayoutTests/compositing/repaint/transparent-layer-repaint.html 2020-11-17 08:28:31 UTC (rev 269895)
@@ -0,0 +1,45 @@
+
+
+
+
+.container {
+border: 1px solid black; /* Needed to disable simple color layer compositing. */
+height: 200px;
+width: 200px;
+transform: translateZ(0);
+background-color: rgba(0, 255, 0, 0.2);
+}
+
+#test {
+margin: 5px;
+height: 5px;
+width: 5px;
+background-color: red;
+}
+
+
+async function doTest() {
+for (var i = 0; i < 5; i++) {
+document.getElementById('test').style.backgroundColor = 'red';
+await UIHelper.renderingUpdate();
+document.getElementById('test').style.backgroundColor = 'transparent';
+await UIHelper.renderingUpdate();
+}
+if (window.testRunner)
+testRunner.notifyDone();
+}
+if (window.testRunner)
+testRunner.waitUntilDone();
+window.addEventListener('load', doTest);
+
+
+
+Test for repaint in a transparent composited layer. The two squares below should be identical, green @ 20% alpha.
+
+
+
+
+
+
+
Modified: trunk/Source/WebKit/ChangeLog (269894 => 269895)
--- trunk/Source/WebKit/ChangeLog 2020-11-17 08:22:08 UTC (rev 269894)
+++ trunk/Source/WebKit/ChangeLog 2020-11-17 08:28:31 UTC (rev 269895)
@@ -1,3 +1,20 @@
+2020-11-17 Tim Horton
+
+REGRESSION (r269824): YouTube media control bar sometimes flickers
+
[webkit-changes] [269894] trunk
Title: [269894] trunk
Revision 269894
Author commit-qu...@webkit.org
Date 2020-11-17 00:22:08 -0800 (Tue, 17 Nov 2020)
Log Message
Check whether destination still can be selected
https://bugs.webkit.org/show_bug.cgi?id=218491
Patch by Rob Buis on 2020-11-17
Reviewed by Ryosuke Niwa.
Source/WebCore:
Check whether destination still can be selected
after deletion.
Test: editing/deleting/delete-selection-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
LayoutTests:
Add testcase.
* editing/deleting/delete-selection-crash-expected.txt: Added.
* editing/deleting/delete-selection-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/CompositeEditCommand.cpp
Added Paths
trunk/LayoutTests/editing/deleting/delete-selection-crash-expected.txt
trunk/LayoutTests/editing/deleting/delete-selection-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (269893 => 269894)
--- trunk/LayoutTests/ChangeLog 2020-11-17 05:23:24 UTC (rev 269893)
+++ trunk/LayoutTests/ChangeLog 2020-11-17 08:22:08 UTC (rev 269894)
@@ -1,3 +1,15 @@
+2020-11-17 Rob Buis
+
+Check whether destination still can be selected
+https://bugs.webkit.org/show_bug.cgi?id=218491
+
+Reviewed by Ryosuke Niwa.
+
+Add testcase.
+
+* editing/deleting/delete-selection-crash-expected.txt: Added.
+* editing/deleting/delete-selection-crash.html: Added.
+
2020-11-16 Sam Weinig
Standardize enums that are used by Settings in preparation for autogeneration
Added: trunk/LayoutTests/editing/deleting/delete-selection-crash-expected.txt (0 => 269894)
--- trunk/LayoutTests/editing/deleting/delete-selection-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-selection-crash-expected.txt 2020-11-17 08:22:08 UTC (rev 269894)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Added: trunk/LayoutTests/editing/deleting/delete-selection-crash.html (0 => 269894)
--- trunk/LayoutTests/editing/deleting/delete-selection-crash.html (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-selection-crash.html 2020-11-17 08:22:08 UTC (rev 269894)
@@ -0,0 +1,15 @@
+
+window._onload_ = () => {
+if (window.testRunner)
+testRunner.dumpAsText();
+
+getSelection().setPosition(start, 0);
+document.querySelector('span').appendChild(document.createElement("video"));
+document.execCommand("delete", false);
+document.write("Test passes if it does not crash.")
+}
+
+
+
+content
+
Modified: trunk/Source/WebCore/ChangeLog (269893 => 269894)
--- trunk/Source/WebCore/ChangeLog 2020-11-17 05:23:24 UTC (rev 269893)
+++ trunk/Source/WebCore/ChangeLog 2020-11-17 08:22:08 UTC (rev 269894)
@@ -1,3 +1,18 @@
+2020-11-17 Rob Buis
+
+Check whether destination still can be selected
+https://bugs.webkit.org/show_bug.cgi?id=218491
+
+Reviewed by Ryosuke Niwa.
+
+Check whether destination still can be selected
+after deletion.
+
+Test: editing/deleting/delete-selection-crash.html
+
+* editing/CompositeEditCommand.cpp:
+(WebCore::CompositeEditCommand::moveParagraphs):
+
2020-11-16 Kimmo Kinnunen
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (269893 => 269894)
--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2020-11-17 05:23:24 UTC (rev 269893)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2020-11-17 08:22:08 UTC (rev 269894)
@@ -1458,7 +1458,7 @@
cleanupAfterDeletion(destination);
// FIXME (Bug 211793): We should redesign cleanupAfterDeletion or find another destination when it is removed.
-if (!destination.deepEquivalent().anchorNode()->isConnected())
+if (!destination.deepEquivalent().anchorNode()->isConnected() || VisibleSelection(destination, originalIsDirectional).isNone())
return;
// Add a br if pruning an empty block level element caused a collapse. For example:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
