[webkit-changes] [WebKit/WebKit] c1fefa: Simplify ContextMenuContextData serialization
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1fefa0bb16a18b82461ac3111b56f3395e7a1b7 https://github.com/WebKit/WebKit/commit/c1fefa0bb16a18b82461ac3111b56f3395e7a1b7 Author: Alex Christensen Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/editing/cocoa/AttributedString.h M Source/WebCore/editing/cocoa/AttributedString.mm M Source/WebKit/Shared/ContextMenuContextData.cpp M Source/WebKit/Shared/ContextMenuContextData.h M Source/WebKit/Shared/ContextMenuContextData.serialization.in M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm Log Message: --- Simplify ContextMenuContextData serialization https://bugs.webkit.org/show_bug.cgi?id=273329 rdar://124958882 Reviewed by Wenson Hsieh. Instead of taking an AttributedString, extracting an NSAttributedString, extracting an NSData, serializing the data, then reconstructing the NSAttributedString on the other side, just serialize the AttributedString then do one extraction operation to get an NSAttributedString. * Source/WebCore/editing/cocoa/AttributedString.h: * Source/WebKit/Shared/ContextMenuContextData.cpp: (WebKit::ContextMenuContextData::ContextMenuContextData): (WebKit::ContextMenuContextData::controlledDataIsEditable const): * Source/WebKit/Shared/ContextMenuContextData.h: (WebKit::ContextMenuContextData::ContextMenuContextData): (WebKit::ContextMenuContextData::controlledSelection const): (WebKit::ContextMenuContextData::controlledSelectionData const): Deleted. * Source/WebKit/Shared/ContextMenuContextData.serialization.in: * Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::setupServicesMenu): * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::handleSelectionServiceClick): Canonical link: https://commits.webkit.org/278074@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 03e3e1: [Unified Text Replacement] Multiple replacements c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03e3e16d57c4f22d56a1b84617b80a9b15617b5d https://github.com/WebKit/WebKit/commit/03e3e16d57c4f22d56a1b84617b80a9b15617b5d Author: Richard Robinson Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h Log Message: --- [Unified Text Replacement] Multiple replacements can sometimes result in incorrect text https://bugs.webkit.org/show_bug.cgi?id=273351 rdar://127013042 Reviewed by Aditya Keerthi. In the `textReplacementSessionDidReceiveReplacements`, the replacement location offset is stored and updated for each replacement, so that the range that is replaced is always up-to-date. However, if the function is called multiple times, subsequent calls will lose this additional offset information. Fix by storing the offset as a member variable on the controller. Also clean up the `UnifiedTextReplacementController` header a bit. * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements): (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession): (WebKit::UnifiedTextReplacementController::findReplacementMarkerByUUID const): (WebKit::UnifiedTextReplacementController::findReplacementMarkerContainingRange const): (WebKit::UnifiedTextReplacementController::findReplacementMarkerByUUID): Deleted. (WebKit::UnifiedTextReplacementController::findReplacementMarkerContainingRange): Deleted. * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: Canonical link: https://commits.webkit.org/278073@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18f50a: Form of Connection::send() that grabs the s_connec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18f50a6105512b7ba4abaa5a80493cdd9c8f97bd https://github.com/WebKit/WebKit/commit/18f50a6105512b7ba4abaa5a80493cdd9c8f97bd Author: Brady Eidson Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/Platform/IPC/Connection.h Log Message: --- Form of Connection::send() that grabs the s_connectionMapLock lock should not hold the lock for the entire duration of the message send rdar://126915951 Reviewed by Chris Dumez. Message sends can take awhile. Especially if they're on a low priority background thread, and on a system under pressure. Holding this lock for longer than necessary can be hazardous to other, higher priority threads. So let's stop doing that. * Source/WebKit/Platform/IPC/Connection.h: (IPC::Connection::send): Canonical link: https://commits.webkit.org/278072@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bbe301: [JSC] YarrJIT should save / restore fp and lr when...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bbe3017df2dc1cdc7b36c915543da171b681d099 https://github.com/WebKit/WebKit/commit/bbe3017df2dc1cdc7b36c915543da171b681d099 Author: Yusuke Suzuki Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: A JSTests/stress/yarr-call.js M Source/JavaScriptCore/yarr/YarrJIT.cpp Log Message: --- [JSC] YarrJIT should save / restore fp and lr when it can call https://bugs.webkit.org/show_bug.cgi?id=273337 rdar://127055796 Reviewed by Keith Miller. While newly added thunk can be called, we are not saving / restoring fp and lr. * JSTests/stress/yarr-call.js: Added. * Source/JavaScriptCore/yarr/YarrJIT.cpp: Canonical link: https://commits.webkit.org/278071@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a83a5: AX: The AX tree can be wrong if AccessibilityTable...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a83a57c9017d2ee5639862bbd64b8736fc44e79 https://github.com/WebKit/WebKit/commit/1a83a57c9017d2ee5639862bbd64b8736fc44e79 Author: Tyler Wilcock Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html-aam/table-roles-expected.txt M Source/WebCore/accessibility/AccessibilityTableCell.cpp Log Message: --- AX: The AX tree can be wrong if AccessibilityTableCell::determineAccessibilityRole() is called before parent table adds children https://bugs.webkit.org/show_bug.cgi?id=273345 rdar://problem/127138437 Reviewed by Chris Fleizach. AccessibilityTableCell::determineAccessibilityRole() calls rowIndexRange() and columnIndexRange(), which in turn call ensureIndexesUpToDate(). This causes the parentTable() to addChildren(), which causes the rows to addChildren(), then causing cells (including the one running determineAccessibilityRole() higher in the stack) to addChildren(). And because the cell may not have ever set its m_role (i.e. making it AccessibilityRole::Unknown), it can be erroneously ignored, causing the accessibility tree to be wrong. Fix this by using SetForScope to set a temporary cell role to tide us over until the real role has been set. Fixes one WPT subtest in html-aam/table-roles.html. * LayoutTests/imported/w3c/web-platform-tests/html-aam/table-roles-expected.txt: * Source/WebCore/accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::determineAccessibilityRole): (WebCore::AccessibilityTableCell::isColumnHeader const): (WebCore::AccessibilityTableCell::isRowHeader const): Improve some naming and use RefPtr. Canonical link: https://commits.webkit.org/278070@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 677afa: [Unified Text Replacement] Undo-ing a replacement ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 677afac9fefb30712341b5b909db687479ec7f53 https://github.com/WebKit/WebKit/commit/677afac9fefb30712341b5b909db687479ec7f53 Author: Richard Robinson Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/dom/DocumentMarkerController.cpp M Source/WebCore/dom/DocumentMarkerController.h M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h Log Message: --- [Unified Text Replacement] Undo-ing a replacement session can sometimes result in incorrect text https://bugs.webkit.org/show_bug.cgi?id=273331 rdar://127123467 Reviewed by Aditya Keerthi. When undo-ing a text replacement session, the original text may not be restored correctly. This is because in `didEndTextReplacementSession`, the markers were being iterated from the beginning and then their ranges were replaced with the original text. However, if the original text was a different length than the marker range length, the replacement of the subsequent markers will end up using an out-of-date replacement range. Fix by iterating the markers backwards, since the replacement range of prior markers will never be affected in this case. Also perform a minor refactor to share more common logic. * Source/WebCore/dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::forEach): (WebCore::DocumentMarkerController::forEach): (WebCore::DocumentMarkerController::forEachOfTypes): (WebCore::DocumentMarkerController::forEach): Deleted. * Source/WebCore/dom/DocumentMarkerController.h: * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidUpdateStateForReplacement): (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession): (WebKit::UnifiedTextReplacementController::textReplacementSessionPerformEditActionForPlainText): (WebKit::UnifiedTextReplacementController::updateStateForSelectedReplacementIfNeeded): (WebKit::UnifiedTextReplacementController::findReplacementMarkerByUUID): (WebKit::UnifiedTextReplacementController::findReplacementMarkerContainingRange): (WebKit::findReplacementMarkerByUUID): Deleted. (WebKit::findReplacementMarkerContainingRange): Deleted. * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: Canonical link: https://commits.webkit.org/278069@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2cb63f: Do not expect link filtering domains returned from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2cb63f8cc4d9a706916cb94617cd4ecb81e9ce5c https://github.com/WebKit/WebKit/commit/2cb63f8cc4d9a706916cb94617cd4ecb81e9ce5c Author: Charlie Wolfe Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm M Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm Log Message: --- Do not expect link filtering domains returned from WebPrivacy to contain a protocol https://bugs.webkit.org/show_bug.cgi?id=273349 rdar://127143043 Reviewed by Matthew Finkel and Wenson Hsieh. WebKit should no longer expect the domain returned from WebPrivacy to contain a protocol. Append one here so the URL parser works correctly. * Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm: (WebKit::LinkDecorationFilteringController::updateStrings): (WebKit::requestLinkDecorationFilteringData): * Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm: (TestWebKitAPI::TEST(AdvancedPrivacyProtections, RemoveTrackingQueryParametersByDomain)): (TestWebKitAPI::TEST(AdvancedPrivacyProtections, RemoveTrackingQueryParametersByDomainAndPath)): Canonical link: https://commits.webkit.org/278068@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96882c: Start to handle performImmediateActionHitTestAtLoc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96882cf2b4901d7c7d158c52ca645e28b6545c3d https://github.com/WebKit/WebKit/commit/96882cf2b4901d7c7d158c52ca645e28b6545c3d Author: Pascoe Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/rendering/HitTestResult.h M Source/WebKit/Shared/WebHitTestResultData.cpp M Source/WebKit/Shared/WebHitTestResultData.h M Source/WebKit/Shared/WebHitTestResultData.serialization.in M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm Log Message: --- Start to handle performImmediateActionHitTestAtLocation for remote frames https://bugs.webkit.org/show_bug.cgi?id=273330 rdar://problem/127122951 Reviewed by Charlie Wolfe. This change starts to tell the UI process to continue hit testing whenever it encounter a RemoteFrame. It does not yet translate the coordinates returned in WebHitTestResultData to be relative to the main frame. I plan to do that in rdar://127120734. * Source/WebCore/rendering/HitTestResult.h: * Source/WebKit/Shared/WebHitTestResultData.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::performImmediateActionHitTestAtLocation): (WebKit::WebPageProxy::didPerformImmediateActionHitTest): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/mac/WKImmediateActionController.mm: (-[WKImmediateActionController immediateActionRecognizerWillPrepare:]): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::performImmediateActionHitTestAtLocation): (WebKit::WebPage::lookupTextAtLocation): Canonical link: https://commits.webkit.org/278067@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b5714: Content Scripts running in subframe without mainfr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b5714016d2450752f2d89e2068d44bcbae9945c https://github.com/WebKit/WebKit/commit/3b5714016d2450752f2d89e2068d44bcbae9945c Author: Timothy Hatcher Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- Content Scripts running in subframe without mainframe permission fail to work properly. https://webkit.org/b/270218 rdar://problem/123750228 Reviewed by Brian Weinstein. Allow sending a message to a tab even if the extension does not have permissions for the main frame. The other browsers don't reject with an error in this case, the message is just dropped on the floor later on in processes() when the listeners are checked. Also allows subframes with content scripts to access storage if the main frame does not have host permission. This was being blocked by a permission check, but that required main frame host permissions. This is already covered in a permissive way for frames by the isStorageMessageAllowed() check that happens when a storage IPC message is received. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm: (WebKit::WebExtensionContext::storageGet): Removed extensionCanAccessWebPage() call. (WebKit::WebExtensionContext::storageGetBytesInUse): Ditto. (WebKit::WebExtensionContext::storageSet): Ditto. (WebKit::WebExtensionContext::storageRemove): Ditto. (WebKit::WebExtensionContext::storageClear): Ditto. (WebKit::WebExtensionContext::storageSetAccessLevel): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm: (WebKit::WebExtensionContext::tabsSendMessage): Removed permission check / error. (WebKit::WebExtensionContext::tabsConnect): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::extensionCanAccessWebPage): Deleted. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm: (TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromSubframe)): Added. (TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, ConnectFromSubframe)): Added. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm: (TestWebKitAPI::TEST(WKWebExtensionAPIStorage, StorageFromSubframe)): Added. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageFromBackgroundToSubframe)): Added. (TestWebKitAPI::TEST(WKWebExtensionAPITabs, ConnectToSubframe)): Added. Canonical link: https://commits.webkit.org/278066@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5859cb: [ iOS 17 Debug ] ASSERTION FAILED: containingBlock...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5859cb6b941d46247e2f57e589cd3202e6fa59b5 https://github.com/WebKit/WebKit/commit/5859cb6b941d46247e2f57e589cd3202e6fa59b5 Author: Jay Stfleur Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [ iOS 17 Debug ] ASSERTION FAILED: containingBlock.isInFlowPositioned() on imported/w3c/web-platform-tests/html/dom/elements/global-attributes/the-anchor-attribute-003-crash.tentative.html https://bugs.webkit.org/show_bug.cgi?id=268557 rdar://122108986 Unreviewed test gardening. Removing test expectation. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/278065@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 276e11: REGRESSION ( 275227@main): [ MacOS Debug ] importe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 276e11ba088ff5247fb2fc388e1030cf1e0a0b08 https://github.com/WebKit/WebKit/commit/276e11ba088ff5247fb2fc388e1030cf1e0a0b08 Author: Jay Stfleur Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION ( 275227@main): [ MacOS Debug ] imported/w3c/web-platform-tests/css/css-view-transitions/offscreen-element-modified-before-coming-onscreen.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=269996 rdar://123516775 Unreviewed test gardening. Removing test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/278064@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b2d8f: Unreviewed, reverting 276918@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b2d8fd2262406b4db5f463f6ee57d0bd0ddc00e https://github.com/WebKit/WebKit/commit/2b2d8fd2262406b4db5f463f6ee57d0bd0ddc00e Author: Commit Queue Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/dom/Element.cpp Log Message: --- Unreviewed, reverting 276918@main. https://bugs.webkit.org/show_bug.cgi?id=273342 This turned out to be incomplete. Needs more work. Reverted changeset: "Element::boundingClientRect should check the state of the tree" https://bugs.webkit.org/show_bug.cgi?id=271934 https://commits.webkit.org/276918@main Canonical link: https://commits.webkit.org/278063@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a1e52: REGRESSION (iOS 17.4): Tapping on a `` s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a1e52b41985bc3ea4e492dab50ec6c544243ca2 https://github.com/WebKit/WebKit/commit/8a1e52b41985bc3ea4e492dab50ec6c544243ca2 Author: Aditya Keerthi Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/ios/DataListTextSuggestionTests.mm M Tools/TestWebKitAPI/cocoa/TestWKWebView.h M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Log Message: --- REGRESSION (iOS 17.4): Tapping on a `` suggestion in the keyboard does not update the input's value https://bugs.webkit.org/show_bug.cgi?id=273327 rdar://124784204 Reviewed by Abrar Rahman Protyasha and Wenson Hsieh. Following BrowserEngineKit adoption in WebKit, `` suggestions are now sent to UIKit as `BETextSuggestion`s rather than `UITextSuggestion`s. However, underlying infrastructure in UIKit only deals with `UITextSuggestion`s. As a result, UIKit unwraps the `BETextSuggestion` into a `UITextSuggestion` upon reception, and then converts back to a `BETextSuggestion` at insertion time. The conversion between `BETextSuggestion` and `UITextSuggestion` breaks the existing insertion logic, which performs a class check for `WKDataListTextSuggestion` (a `BETextSuggestion` subclass) prior to performing insertion. Since a class check can no longer be relied upon, insertion is now gated upon whether the content view is aware of any active `` suggestions and whether the text of selected suggestion matches the text of a known `` suggestion. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView insertTextSuggestion:]): * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/ios/DataListTextSuggestionTests.mm: Added. (-[DataListTextSuggestionInputDelegate suggestions]): (-[DataListTextSuggestionInputDelegate setSuggestions:]): (-[DataListTextSuggestionInputDelegate selectionDidChange:]): (-[DataListTextSuggestionInputDelegate selectionWillChange:]): (-[DataListTextSuggestionInputDelegate textDidChange:]): (-[DataListTextSuggestionInputDelegate textWillChange:]): (-[DataListTextSuggestionInputDelegate handleWebViewCredentialsSaveForWebsiteURL:user:password:passwordIsAutoGenerated:]): (-[DataListTextSuggestionInputDelegate invalidateTextEntryContextForTextInput:]): (-[DataListTextSuggestionInputDelegate selectionDidChangeForTextInput:]): (-[DataListTextSuggestionInputDelegate selectionWillChangeForTextInput:]): (-[DataListTextSuggestionInputDelegate shouldDeferEventHandlingToSystemForTextInput:context:]): (-[DataListTextSuggestionInputDelegate textInput:deferReplaceTextActionToSystem:]): (-[DataListTextSuggestionInputDelegate textInput:setCandidateSuggestions:]): (-[DataListTextSuggestionTestView initWithFrame:]): (TestWebKitAPI::TEST(DataListTextSuggestionTestView, InsertSuggestion)): * Tools/TestWebKitAPI/cocoa/TestWKWebView.h: * Tools/TestWebKitAPI/cocoa/TestWKWebView.mm: (-[WKWebView insertTextSuggestion:]): Canonical link: https://commits.webkit.org/278062@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6db2e0: [Site Isolation] Send gesture events to isolated i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6db2e0d54d36e81136a968403ab30b5e9a51f7d0 https://github.com/WebKit/WebKit/commit/6db2e0d54d36e81136a968403ab30b5e9a51f7d0 Author: Charlie Wolfe Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/page/EventHandler.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp M Source/WebKit/WebProcess/WebPage/EventDispatcher.h M Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- [Site Isolation] Send gesture events to isolated iframes https://bugs.webkit.org/show_bug.cgi?id=273299 rdar://127094199 Reviewed by Alex Christensen. This follows the same pattern as all other input events implemented with site isolation, where IPC is sent between the UI process and web processes until a hit test does not lead to an out-of-process iframe. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/page/EventHandler.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::sendGestureEvent): (WebKit::WebPageProxy::handleGestureEvent): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::gestureEvent): (WebKit::EventDispatcher::dispatchGestureEvent): * Source/WebKit/WebProcess/WebPage/EventDispatcher.h: * Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::handleGestureEvent): (WebKit::WebPage::gestureEvent): * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/278061@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7be93: [macOS] REGRESSION(275831@main): Netflix can error...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7be93fa40d309506d29618823d9b181e558e481 https://github.com/WebKit/WebKit/commit/c7be93fa40d309506d29618823d9b181e558e481 Author: Jer Noble Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/mediasource/MediaSource.h M Source/WebCore/platform/graphics/MediaSourcePrivate.cpp M Source/WebCore/platform/graphics/MediaSourcePrivate.h M Source/WebCore/platform/graphics/MediaSourcePrivateClient.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp Log Message: --- [macOS] REGRESSION(275831@main): Netflix can error out while scrubbing https://bugs.webkit.org/show_bug.cgi?id=273306 rdar://126654352 Reviewed by Eric Carlson. A race condition can occur where the MediaSource object in the WebContent process does not check the buffered ranges for the new currentTime after a seek, which leads to the readyState remaining at HAVE_METADATA, and the seeked event failing to fire. Ensure that the MediaSource checks its buffered ranges after a seek by adding an explicit "seeked()" method to MediaSourcePrivateClient to be used when a seek completes in a MediaPlayerPrivate, to notify the MediaSource to revalidate its buffered ranges. To avaid adding a new race condition, call this new "seeked()" method from MediaPlayerPrivateRemote, rather than from MediaSourcePrivateRemote, to ensure that the "official" time is fully updated before the MediaSource monitiors its source buffers. * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::failedToCreateRenderer): (WebCore::MediaSource::seeked): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/platform/graphics/MediaSourcePrivate.cpp: (WebCore::MediaSourcePrivate::seeked): * Source/WebCore/platform/graphics/MediaSourcePrivate.h: * Source/WebCore/platform/graphics/MediaSourcePrivateClient.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::seeked): * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h: * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::seeked): Canonical link: https://commits.webkit.org/278060@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 506d7f: build-jsc should have a --rosetta option
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 506d7f9b1b39eea4d58b6ba9befeda94877e1d8d https://github.com/WebKit/WebKit/commit/506d7f9b1b39eea4d58b6ba9befeda94877e1d8d Author: Keith Miller Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/WTF/wtf/PlatformHave.h M Tools/Scripts/webkitperl/BuildSubproject.pm Log Message: --- build-jsc should have a --rosetta option https://bugs.webkit.org/show_bug.cgi?id=273338 rdar://127131119 Reviewed by Yusuke Suzuki. Right now if you try to run an x86_64 build of JSC under rosetta it won't have JIT. This is because Rosetta doesn't play nice with some of the security entitlements we use. Additionally, for historical perfomance reasons we disabled JIT when in a translated process. This patch adds a new option to build-jsc (--rosetta). The --rosetta option sets a flag in `process-entitlements.sh` to stop adding the bad entitlements for `jsc` and other JSC test binaries. The --rosetta option also sets `HAVE_CPU_TRANSLATION_CAPABILITY=0` making JSC think it's actually running natively. Also, pass --makeArgs as `GCC_PREPROCESSOR_ADDITONS` in `build-jsc` when building with xcodebuild. Lastly, do a little code cleanup in buildUpToProject as well. * Source/JavaScriptCore/Scripts/process-entitlements.sh: * Source/WTF/wtf/PlatformHave.h: * Tools/Scripts/webkitperl/BuildSubproject.pm: (buildUpToProject): Canonical link: https://commits.webkit.org/278059@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79ad68: Cherry-pick 275228@main (a216dd6f98bf). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 79ad68e7086aff98073fe99e3e9d53e20a3bb41e https://github.com/WebKit/WebKit/commit/79ad68e7086aff98073fe99e3e9d53e20a3bb41e Author: Olivier Blin Date: 2024-04-27 (Sat, 27 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp Log Message: --- Cherry-pick 275228@main (a216dd6f98bf). https://bugs.webkit.org/show_bug.cgi?id=269913 [WPE][GTK] Fully disable mDNS LibWebRTC support https://bugs.webkit.org/show_bug.cgi?id=269913 Reviewed by Philippe Normand. In 275090@main (c62c74690915), mDNS LibWebRTC support has been disabled for WPE and GTK in LibWebRTCNetworkManager::GetMdnsResponder(). But this is not synchronized with WebRTCProvider::isSupportingMDNS(), which is used to initialize m_shouldFilterICECandidates in PeerConnectionBackend::PeerConnectionBackend(). This triggers assertions in PeerConnectionBackend::newICECandidate(). * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: (WebKit::LibWebRTCProvider::LibWebRTCProvider): Canonical link: https://commits.webkit.org/275228@main Canonical link: https://commits.webkit.org/274313.167@webkitglib/2.44 Commit: 4746fa7ce6f922558e2b0f0c2a1a33464d823e38 https://github.com/WebKit/WebKit/commit/4746fa7ce6f922558e2b0f0c2a1a33464d823e38 Author: Olivier Blin Date: 2024-04-27 (Sat, 27 Apr 2024) Changed paths: M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp Log Message: --- Cherry-pick 275235@main (91dc14fd908d). https://bugs.webkit.org/show_bug.cgi?id=269915 [GStreamer][LibWebRTC] Conflict between two GStreamerVideoDecoder classes can lead to crash https://bugs.webkit.org/show_bug.cgi?id=269915 Reviewed by Philippe Normand. In the GStreamer ports, there are two different implementations of the WebCore::GStreamerVideoDecoder class: - one for WebRTC in Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp - one for WebCodecs in Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp This can lead to a crash in WebRTC usage, since the WebCore::GStreamerVideoDecoder destructor from the WebCodecs class can be mistakenly used instead of the one from the WebRTC class. Rename the WebRTC class as GStreamerWebRTCVideoDecoder. * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerWebRTCVideoDecoder::GStreamerWebRTCVideoDecoder): (WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder): Deleted. (WebCore::GStreamerVideoDecoder::decodebinPadAddedCb): Deleted. (WebCore::GStreamerVideoDecoder::pipeline): Deleted. (WebCore::GStreamerVideoDecoder::makeElement): Deleted. (WebCore::GStreamerVideoDecoder::handleError): Deleted. (WebCore::GStreamerVideoDecoder::CreateFilter): Deleted. (WebCore::GStreamerVideoDecoder::pullSample): Deleted. (WebCore::GStreamerVideoDecoder::GetCapsForFrame): Deleted. (WebCore::GStreamerVideoDecoder::AddDecoderIfSupported): Deleted. (WebCore::GStreamerVideoDecoder::ConfigureSupportedDecoder): Deleted. (WebCore::GStreamerVideoDecoder::GstDecoderFactory): Deleted. (WebCore::GStreamerVideoDecoder::HasGstDecoder): Deleted. Canonical link: https://commits.webkit.org/275235@main Canonical link: https://commits.webkit.org/274313.168@webkitglib/2.44 Compare: https://github.com/WebKit/WebKit/compare/40ff10f0156b...4746fa7ce6f9 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40ff10: Cherry-pick 278054@main (bfbc2e6fa7ad). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 40ff10f0156bb3bae91a752df3f9984b0e464dfc https://github.com/WebKit/WebKit/commit/40ff10f0156bb3bae91a752df3f9984b0e464dfc Author: Adrian Perez de Castro Date: 2024-04-27 (Sat, 27 Apr 2024) Changed paths: M Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp Log Message: --- Cherry-pick 278054@main (bfbc2e6fa7ad). https://bugs.webkit.org/show_bug.cgi?id=273245 REGRESSION(274201@main): Error embedding AT-SPI socket: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: org.freedesktop.DBus.Error.NameHasNoOwner https://bugs.webkit.org/show_bug.cgi?id=273245 Reviewed by Michael Catanzaro. Disable connecting to the accessibility socket when running the GTK4 port under Flatpak. This avoids spamming with warnings while still having accessibility support in other typical setup i.e. for users of distribution packages. * Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::bindAccessibilityTree): Canonical link: https://commits.webkit.org/278054@main Canonical link: https://commits.webkit.org/274313.166@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6c16b: Creating ImageBitmap out of WebGPU OffscreenCanvas...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6c16b9ea729135fc08ec21179373f59014c2901 https://github.com/WebKit/WebKit/commit/f6c16b9ea729135fc08ec21179373f59014c2901 Author: Kimmo Kinnunen Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: A LayoutTests/fast/webgpu/image-bitmap-no-crash-expected.html A LayoutTests/fast/webgpu/image-bitmap-no-crash.html M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm Log Message: --- Creating ImageBitmap out of WebGPU OffscreenCanvas context crashes https://bugs.webkit.org/show_bug.cgi?id=273255 rdar://126761479 Reviewed by Mike Wyrzykowski. Transfer the CGImage malloc buffer ownership to the CGDataProvider. * LayoutTests/fast/webgpu/image-bitmap-no-crash-expected.html: Added. * LayoutTests/fast/webgpu/image-bitmap-no-crash.html: Added. * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::PresentationContextIOSurface::getTextureAsNativeImage): Canonical link: https://commits.webkit.org/278058@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c728c7: Remove legacy serialization API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c728c767748d65727670d886204465d8761d9f2d https://github.com/WebKit/WebKit/commit/c728c767748d65727670d886204465d8761d9f2d Author: Claudio Saavedra Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WTF/wtf/ArgumentCoder.h M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Platform/IPC/Decoder.h Log Message: --- Remove legacy serialization API https://bugs.webkit.org/show_bug.cgi?id=273236 Reviewed by Alex Christensen. The last encoders using the legacy serialization API in GTK/WPE were ported, so the legacy API can be removed. * Source/WTF/wtf/ArgumentCoder.h: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::decode): Canonical link: https://commits.webkit.org/278057@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 745a77: REGRESSION (274894@main): [ iOS Debug ] accessibil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 745a77767bf2c116b74d62179fb68d431c9846c6 https://github.com/WebKit/WebKit/commit/745a77767bf2c116b74d62179fb68d431c9846c6 Author: Jay Stfleur Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- REGRESSION (274894@main): [ iOS Debug ] accessibility/text-marker/text-marker-range-stale-node-crash.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=270477 rdar://124030130 Unreviewed test gardening. Removing test expectation. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/278056@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a533d1: Create new BrowsingContextGroup for ProvisionPageP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a533d1e948108fe58ed1bb753c7bc5f1bcd498c5 https://github.com/WebKit/WebKit/commit/a533d1e948108fe58ed1bb753c7bc5f1bcd498c5 Author: Sihui Liu Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- Create new BrowsingContextGroup for ProvisionPageProxy if session is changed https://bugs.webkit.org/show_bug.cgi?id=273266 rdar://127066605 Reviewed by Alex Christensen. Make BrowsingContextGroup only contain processes and pages that are in the same session, to avoid it returning wrong process to page with a different session. * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::ensureProcessForDomain): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::processForRegistrableDomain): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): Canonical link: https://commits.webkit.org/278055@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bfbc2e: REGRESSION(274201@main): Error embedding AT-SPI so...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bfbc2e6fa7ad01a9051117cea47f12397f5ae26f https://github.com/WebKit/WebKit/commit/bfbc2e6fa7ad01a9051117cea47f12397f5ae26f Author: Adrian Perez de Castro Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp Log Message: --- REGRESSION(274201@main): Error embedding AT-SPI socket: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: org.freedesktop.DBus.Error.NameHasNoOwner https://bugs.webkit.org/show_bug.cgi?id=273245 Reviewed by Michael Catanzaro. Disable connecting to the accessibility socket when running the GTK4 port under Flatpak. This avoids spamming with warnings while still having accessibility support in other typical setup i.e. for users of distribution packages. * Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::bindAccessibilityTree): Canonical link: https://commits.webkit.org/278054@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc3187: Password entry visible during Clone Mirroring afte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc318704d271bcf5e75428dd6f56e22c8a7d3792 https://github.com/WebKit/WebKit/commit/bc318704d271bcf5e75428dd6f56e22c8a7d3792 Author: Megan Gardner Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm M Source/WebKit/UIProcess/ios/WKContentView.h M Source/WebKit/UIProcess/ios/WKContentView.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Password entry visible during Clone Mirroring after switching origins in the same tab. https://bugs.webkit.org/show_bug.cgi?id=273290 rdar://126586657 Reviewed by Abrar Rahman Protyasha and Wenson Hsieh. The state of screen capturing isn't be persisted between swapping processes in the same tab. Make sure that the state of screen capture is set on every new origin and process creation. * Source/WebKit/UIProcess/PageClient.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::isScreenBeingCaptured): * Source/WebKit/UIProcess/ios/WKContentView.mm: (-[WKContentView didMoveToWindow]): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: Canonical link: https://commits.webkit.org/278053@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae36ff: [WebGPU] Validate buffer length for bind group ent...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae36fffb790d1c33f548681ce46b41c007850418 https://github.com/WebKit/WebKit/commit/ae36fffb790d1c33f548681ce46b41c007850418 Author: Tadeu Zagallo Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: A LayoutTests/fast/webgpu/fuzz-126848520-auto-layout-expected.txt A LayoutTests/fast/webgpu/fuzz-126848520-auto-layout.html A LayoutTests/fast/webgpu/fuzz-126848520-explicit-layout-expected.txt A LayoutTests/fast/webgpu/fuzz-126848520-explicit-layout.html M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp M Source/WebGPU/WGSL/EntryPointRewriter.cpp M Source/WebGPU/WGSL/EntryPointRewriter.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/GlobalVariableRewriter.h M Source/WebGPU/WGSL/WGSL.cpp M Source/WebGPU/WGSL/WGSL.h M Source/WebGPU/WGSL/wgslc.cpp M Source/WebGPU/WebGPU/BindGroupLayout.mm M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/Pipeline.h M Source/WebGPU/WebGPU/Pipeline.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/RenderPipeline.mm M Source/WebGPU/WebGPU/ShaderModule.mm M Source/WebGPU/WebGPU/WebGPU.h Log Message: --- [WebGPU] Validate buffer length for bind group entries https://bugs.webkit.org/show_bug.cgi?id=273151 rdar://126848520 Reviewed by Mike Wyrzykowski. We were missing a validation that the size of the buffer passed into a bind group was big enough to fit the type of that entry. Most of the plumbing was already done, but we never populated the `minBindingSize` in the compiler info. That works out of the box for auto layouts, but for user-provided layouts we need to update the entries with the computed size, and this later needs to be checked from draw/dispatch. * LayoutTests/fast/webgpu/fuzz-126848520-auto-layout-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-126848520-auto-layout.html: Added. * LayoutTests/fast/webgpu/fuzz-126848520-explicit-layout-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-126848520-explicit-layout.html: Added. * Source/WebGPU/WGSL/EntryPointRewriter.cpp: (WGSL::rewriteEntryPoints): * Source/WebGPU/WGSL/EntryPointRewriter.h: * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::RewriteGlobalVariables): (WGSL::RewriteGlobalVariables::visitEntryPoint): (WGSL::bindingMemberForGlobal): (WGSL::RewriteGlobalVariables::insertStructs): (WGSL::rewriteGlobalVariables): * Source/WebGPU/WGSL/GlobalVariableRewriter.h: * Source/WebGPU/WGSL/WGSL.cpp: (WGSL::prepareImpl): (WGSL::prepare): * Source/WebGPU/WGSL/WGSL.h: * Source/WebGPU/WGSL/wgslc.cpp: (runWGSL): * Source/WebGPU/WebGPU/BindGroupLayout.mm: (WebGPU::createArgumentDescriptor): * Source/WebGPU/WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::executePreDispatchCommands): * Source/WebGPU/WebGPU/Pipeline.h: * Source/WebGPU/WebGPU/Pipeline.mm: (WebGPU::createLibrary): (WebGPU::validateBindGroup): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::executePreDrawCommands): * Source/WebGPU/WebGPU/RenderPipeline.mm: * Source/WebGPU/WebGPU/ShaderModule.mm: (WebGPU::earlyCompileShaderModule): Canonical link: https://commits.webkit.org/278052@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 103f05: [JSC] Remove use of Committed / Primordial state o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 103f05d044f0b05b0497833dba83a642526c229a https://github.com/WebKit/WebKit/commit/103f05d044f0b05b0497833dba83a642526c229a Author: Yusuke Suzuki Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp Log Message: --- [JSC] Remove use of Committed / Primordial state of AccessCase and cloning cases only when it is Generated and having CallLinkInfo https://bugs.webkit.org/show_bug.cgi?id=273276 rdar://127076206 Reviewed by Keith Miller. This is a change towards making AccessCase just a constant feedback information instead of having mutating state. This patch removes effective use of Committed / Primordial state since we do not care about them. Right now CallLinkInfo is tied to AccessCase so we still need to know about Generated state and we need to clone it. But we don't need to clone AccessCase when it doesn't have CallLinkInfo inside it. So this patch removes this cloning for AccessCases not holding CallLinkInfo*. This is paving a path towards https://bugs.webkit.org/show_bug.cgi?id=156456. Once CallLinkInfo* gets wiped from AccessCase, we can completely remove (1) Generated state since AccessCase now just becomes immutable data and (2) cloning feature since we no longer need this. * Source/JavaScriptCore/bytecode/AccessCase.cpp: (JSC::AccessCase::commit): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::doesJSCalls): (JSC::InlineCacheCompiler::generateWithGuard): (JSC::InlineCacheCompiler::generate): (JSC::InlineCacheCompiler::regenerate): Canonical link: https://commits.webkit.org/278051@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a480da: REGRESSION (278032@main): Video does not render in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a480da7fbd31f6bdde5b06706bb3dd11b7bca5ee https://github.com/WebKit/WebKit/commit/a480da7fbd31f6bdde5b06706bb3dd11b7bca5ee Author: Andy Estes Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm Log Message: --- REGRESSION (278032@main): Video does not render in element fullscreen after exiting LinearMediaKit fullscreen https://bugs.webkit.org/show_bug.cgi?id=273334 rdar://127125039 Reviewed by Jer Noble. While attempting to address a test failure before landing 278032@main I added two early returns that ended up not being necessary to fix the test, but did cause a regression where we never set a staged AVSampleBufferDisplayLayer on MediaSourcePrivateAVFObjC when returning from LinearMediaKit fullscreen. Resolved this by removing the unnecessary early returns. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayerOrVideoRenderer): Canonical link: https://commits.webkit.org/278050@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3df15f: [JSC] Avoid allocations in BinarySwitch
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3df15f02c1078c2c1257c865e1772f21d61d3a8d https://github.com/WebKit/WebKit/commit/3df15f02c1078c2c1257c865e1772f21d61d3a8d Author: Yusuke Suzuki Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/jit/BinarySwitch.cpp M Source/JavaScriptCore/jit/BinarySwitch.h M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- [JSC] Avoid allocations in BinarySwitch https://bugs.webkit.org/show_bug.cgi?id=273291 rdar://127081651 Reviewed by Keith Miller. This patch adds some initial capacity to the Vector of BinarySwitch so that we can cover most of cases without allocations. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::regenerate): * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::linkPolymorphicCall): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/jit/BinarySwitch.cpp: (JSC::BinarySwitch::BinarySwitch): (JSC::BinarySwitch::build): (JSC::BinarySwitch::~BinarySwitch): Deleted. * Source/JavaScriptCore/jit/BinarySwitch.h: * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJITImpl::BBQJIT::addSwitch): Canonical link: https://commits.webkit.org/278049@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b1589: Reduce use of WKBundlePageGetMainFrame in WebKitTe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b15896c8c44d9f7982a6123799b7f8495b5e86a https://github.com/WebKit/WebKit/commit/7b15896c8c44d9f7982a6123799b7f8495b5e86a Author: Alex Christensen Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm M Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityControllerPlayStation.cpp M Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp Log Message: --- Reduce use of WKBundlePageGetMainFrame in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=273322 rdar://127117771 Reviewed by Pascoe. With site isolation the main frame is not necessarily in the current process. Use the current JSContextRef instead. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h: * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: (WTR::AccessibilityController::addNotificationListener): * Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: * Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::addNotificationListener): * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: (WTR::AccessibilityController::addNotificationListener): * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler initWithContext:]): (-[AccessibilityNotificationHandler dealloc]): (-[AccessibilityNotificationHandler setCallback:]): (-[AccessibilityNotificationHandler _notificationReceived:]): (-[AccessibilityNotificationHandler init]): Deleted. * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::addNotificationListener): Canonical link: https://commits.webkit.org/278048@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8cecb: Disable OffscreenCanvasRenderingContext2D's commit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8cecb9d26e94ed6f13b6b2a4feeb7b0bcc1becd https://github.com/WebKit/WebKit/commit/f8cecb9d26e94ed6f13b6b2a4feeb7b0bcc1becd Author: Anne van Kesteren Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full-expected.txt M LayoutTests/inspector/canvas/resources/recording-2d.js M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl Log Message: --- Disable OffscreenCanvasRenderingContext2D's commit() method by default https://bugs.webkit.org/show_bug.cgi?id=272591 rdar://126758254 Reviewed by Matt Woodrow. This puts OffscreenCanvasRenderingContext2D's commit() behind a runtime setting marked testable (OffscreenCanvasDeprecatedCommitEnabled). This ensures this method continues to be tested for the time being and can be re-enabled should there be a need. The goal is to remove this method and underlying implementation completely as discussed here: https://github.com/whatwg/html/pull/9979 * LayoutTests/inspector/canvas/recording-offscreen-canvas-2d-full-expected.txt: * LayoutTests/inspector/canvas/resources/recording-2d.js: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl: Canonical link: https://commits.webkit.org/278047@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0eae9: Update ANGLE to 2024-04-25 (6cfb593174d2f9d432386f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0eae9e8c396d007d79ea66f525e7964fbfc9f33 https://github.com/WebKit/WebKit/commit/f0eae9e8c396d007d79ea66f525e7964fbfc9f33 Author: Kimmo Kinnunen Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/ThirdParty/ANGLE/ANGLE.plist M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj M Source/ThirdParty/ANGLE/BUILD.gn M Source/ThirdParty/ANGLE/Compiler.cmake M Source/ThirdParty/ANGLE/DEPS M Source/ThirdParty/ANGLE/GLESv2.cmake M Source/ThirdParty/ANGLE/PRESUBMIT.py M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h M Source/ThirdParty/ANGLE/WebKit/angle_commit.h M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/doc/CaptureAndReplay.md M Source/ThirdParty/ANGLE/doc/ContributingCode.md M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md A Source/ThirdParty/ANGLE/extensions/ANGLE_program_binary_readiness_query.txt M Source/ThirdParty/ANGLE/include/GLES2/gl2ext_angle.h M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h M Source/ThirdParty/ANGLE/include/platform/vk_features.json M Source/ThirdParty/ANGLE/infra/config/generated/luci-milo.cfg M Source/ThirdParty/ANGLE/infra/config/generated/project.cfg M Source/ThirdParty/ANGLE/infra/config/main.star M Source/ThirdParty/ANGLE/infra/specs/angle.json M Source/ThirdParty/ANGLE/infra/specs/mixins.pyl M Source/ThirdParty/ANGLE/infra/specs/waterfalls.pyl M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_translator.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Extension_files.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_WGL_loader.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GLenum_value_to_string_map.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/interpreter_utils.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/proc_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/uniform_type.json M Source/ThirdParty/ANGLE/scripts/export_targets.py M Source/ThirdParty/ANGLE/scripts/gen_vk_gl_cts_build.py M Source/ThirdParty/ANGLE/scripts/gl_angle_ext.xml M Source/ThirdParty/ANGLE/scripts/registry_xml.py M Source/ThirdParty/ANGLE/scripts/roll_chromium_deps.py M Source/ThirdParty/ANGLE/src/angle_program_serialize_data_version.gni M Source/ThirdParty/ANGLE/src/common/MemoryBuffer.h A Source/ThirdParty/ANGLE/src/common/SimpleMutex.cpp A Source/ThirdParty/ANGLE/src/common/SimpleMutex.h A Source/ThirdParty/ANGLE/src/common/SimpleMutex_unittest.cpp M Source/ThirdParty/ANGLE/src/common/debug.h M Source/ThirdParty/ANGLE/src/common/gen_uniform_type_table.py M Source/ThirdParty/ANGLE/src/common/gl_enum_utils_autogen.cpp A Source/ThirdParty/ANGLE/src/common/log_utils.h M Source/ThirdParty/ANGLE/src/common/uniform_type_info_autogen.cpp M Source/ThirdParty/ANGLE/src/common/utilities.h M Source/ThirdParty/ANGLE/src/common/vulkan/vulkan_icd.cpp M Source/ThirdParty/ANGLE/src/compiler.gni M Source/ThirdParty/ANGLE/src/compiler/translator/BaseTypes.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/BaseTypes.h M Source/ThirdParty/ANGLE/src/compiler/translator/CodeGen.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.h M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/OutputGLSLBase.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/OutputGLSLBase.h M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorESSL.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorGLSL.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/glslang.y M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_lex_autogen.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/glslang_tab_autogen.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/Name.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/TranslatorMSL.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/spirv/OutputSPIRV.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/util.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/util.h A Source/ThirdParty/ANGLE/src/compiler/translator/wgsl/TranslatorWGSL.cpp
[webkit-changes] [WebKit/WebKit] cb3333: Reduce use of `const char*` in the code base
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb5735a96497d668430668716a1b8f694e29 https://github.com/WebKit/WebKit/commit/cb5735a96497d668430668716a1b8f694e29 Author: Chris Dumez Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h M Source/JavaScriptCore/ftl/FTLCompile.cpp M Source/WTF/wtf/CodePtr.cpp M Source/WTF/wtf/CodePtr.h M Source/WTF/wtf/Dominators.h M Source/WTF/wtf/Gigacage.h M Source/WTF/wtf/MemoryPressureHandler.cpp M Source/WTF/wtf/SingleRootGraph.h M Source/WTF/wtf/StringHashDumpContext.h M Source/WTF/wtf/SuspendableWorkQueue.cpp M Source/WTF/wtf/SuspendableWorkQueue.h M Source/WTF/wtf/URLParser.cpp M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp M Source/WebCore/Modules/push-api/PushDatabase.h M Source/WebCore/Modules/webauthn/cbor/CBORReader.cpp M Source/WebCore/Modules/webauthn/cbor/CBORReader.h M Source/WebCore/Modules/webauthn/fido/FidoConstants.cpp M Source/WebCore/Modules/webauthn/fido/FidoConstants.h M Source/WebCore/Modules/webdatabase/Database.cpp M Source/WebCore/Modules/webdatabase/DatabaseTask.cpp M Source/WebCore/Modules/webdatabase/DatabaseTask.h M Source/WebCore/Modules/webdatabase/SQLTransaction.cpp M Source/WebCore/Modules/webdatabase/SQLTransaction.h M Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp M Source/WebCore/Modules/webdatabase/SQLTransactionStateMachine.cpp M Source/WebCore/Modules/webdatabase/SQLTransactionStateMachine.h M Source/WebCore/Modules/websockets/WebSocket.cpp M Source/WebCore/Modules/websockets/WebSocketExtensionParser.cpp M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Source/WebCore/contentextensions/ContentExtensionParser.cpp M Source/WebCore/contentextensions/DFABytecodeInterpreter.cpp M Source/WebCore/contentextensions/DFABytecodeInterpreter.h M Source/WebCore/crypto/SubtleCrypto.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmEd25519GCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp M Source/WebCore/css/CSSCounterStyleRule.cpp M Source/WebCore/css/CSSTimingFunctionValue.cpp M Source/WebCore/css/ShorthandSerializer.cpp M Source/WebCore/css/StyleColor.cpp M Source/WebCore/css/typedom/numeric/CSSNumericBaseType.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h M Source/WebCore/html/FTPDirectoryDocument.cpp M Source/WebCore/html/PermissionsPolicy.cpp M Source/WebCore/loader/MixedContentChecker.cpp M Source/WebCore/page/MemoryRelease.cpp M Source/WebCore/page/PerformanceLogging.cpp M Source/WebCore/page/PerformanceLogging.h M Source/WebCore/page/cocoa/PerformanceLoggingCocoa.mm M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/platform/RuntimeApplicationChecks.cpp M Source/WebCore/platform/RuntimeApplicationChecks.h M Source/WebCore/platform/graphics/GraphicsContextState.cpp M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm M Source/WebCore/platform/sql/SQLiteDatabase.cpp M Source/WebCore/rendering/RenderCounter.cpp M Source/WebCore/rendering/RenderCounter.h M Source/WebKit/Platform/IPC/HandleMessage.h M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Reduce use of `const char*` in the code base https://bugs.webkit.org/show_bug.cgi?id=273277 Reviewed by Darin Adler. Reduce use of `const char*` in the code base by leveraging ASCIILiteral. * Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodeRef::dump const): * Source/JavaScriptCore/ftl/FTLCompile.cpp: (JSC::FTL::compile): * Source/WTF/wtf/CodePtr.cpp: (WTF::CodePtrBase::dumpWithName): * Source/WTF/wtf/CodePtr.h: (WTF::CodePtr::dumpWithName const): (WTF::CodePtr::dump const): * Source/WTF/wtf/Dominators.h: (WTF::Dominators::Dominators): (WTF::Dominators::ValidationContext::reportError): * Source/WTF/wtf/Gigacage.h: (Gigacage::name): * Source/WTF/wtf/MemoryPressureHandler.cpp: (WTF::toString): (WTF::MemoryPressureHandler::setMemoryUsagePolicyBasedOnFootprint): * Source/WTF/wtf/SingleRootGraph.h: (WTF::SingleRootGraphNode::rootName): (WTF::SingleRootGraphSet::dump const): * Source/WTF/wtf/StringHashDumpContext.h: (WTF::StringHashDumpContext::dump const): * Source/WTF/wtf/SuspendableWorkQueue.cpp: (WTF::SuspendableWorkQueue::stateString): (WTF::SuspendableWorkQueue::suspend): (WTF::SuspendableWorkQueue::resume): * Source/WTF/wtf/SuspendableWorkQueue.h: * Source/WTF/wtf/URLParser.cpp: (WTF::serializeURLEncodedForm): * Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:
[webkit-changes] [WebKit/WebKit] c310b0: [WebCore] Optimize text layout building
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c310b02276953cd72ce53b9c8ec72d5d8a977d45 https://github.com/WebKit/WebKit/commit/c310b02276953cd72ce53b9c8ec72d5d8a977d45 Author: Yusuke Suzuki Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.h M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp M Source/WebCore/platform/graphics/FontCascade.cpp Log Message: --- [WebCore] Optimize text layout building https://bugs.webkit.org/show_bug.cgi?id=273301 rdar://127095998 Reviewed by Alan Baradlay. This does micro-optimizations for Text Layout. 1. TextUtil::containsStrongDirectionalityText should use StringView::codePoints. 2. FontCascade::characterRangeCodePath should first take size and data from span. 3. TextOnlySimpleLineBuilder should take rootStyle and threading it through line building code. 4. InlineItemsBuilder should appropriately expand the Vector capacity before appending items in loop. * Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp: (WebCore::Layout::InlineItemsBuilder::buildInlineItemListForTextFromBreakingPositionsCache): (WebCore::Layout::InlineItemsBuilder::handleTextContent): * Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp: (WebCore::Layout::TextOnlySimpleLineBuilder::layoutInlineContent): (WebCore::Layout::TextOnlySimpleLineBuilder::placeInlineTextContent): (WebCore::Layout::TextOnlySimpleLineBuilder::placeNonWrappingInlineTextContent): (WebCore::Layout::TextOnlySimpleLineBuilder::commitCandidateContent): (WebCore::Layout::TextOnlySimpleLineBuilder::handleOverflowingTextContent): (WebCore::Layout::TextOnlySimpleLineBuilder::handleLineEnding): (WebCore::Layout::TextOnlySimpleLineBuilder::revertToTrailingItem): (WebCore::Layout::TextOnlySimpleLineBuilder::revertToLastNonOverflowingItem): * Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.h: * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::containsStrongDirectionalityText): Canonical link: https://commits.webkit.org/278044@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6341c: Makefile.shared should pass SDKROOT to set-webkit-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6341cabd933197f63da3b9adcafed6dab5dd9e3 https://github.com/WebKit/WebKit/commit/a6341cabd933197f63da3b9adcafed6dab5dd9e3 Author: Keith Miller Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Makefile.shared Log Message: --- Makefile.shared should pass SDKROOT to set-webkit-configuration https://bugs.webkit.org/show_bug.cgi?id=273320 rdar://127114398 Reviewed by David Kilzer. This fixes the build scenario when Apple WebKittens try to do the OS build with `make debug SDKROOT=macosx`. Previously we wouldn't forward the `SDKROOT` to `set-webkit-configuration` which assumed the user wanted to use the .internal SDK. This meant `set-webkit-configuration` would complain because it couldn't find the Internal directory. * Makefile.shared: Canonical link: https://commits.webkit.org/278043@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a05d9b: REGRESSION (277275@main): [ MacOS ] TestWebKitAPI....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a05d9bc0b5409c65288cb3b82477d885bb0ca186 https://github.com/WebKit/WebKit/commit/a05d9bc0b5409c65288cb3b82477d885bb0ca186 Author: Alan Baradlay Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/page/LocalFrameViewLayoutContext.cpp Log Message: --- REGRESSION (277275@main): [ MacOS ] TestWebKitAPI.WebKit.AutoLayoutIntegration is a mostly consistent timeout https://bugs.webkit.org/show_bug.cgi?id=273270 Reviewed by Antti Koivisto. Autosize mode eagerly schedules layout even when there's no current document yet. * Source/WebCore/page/LocalFrameViewLayoutContext.cpp: (WebCore::LocalFrameViewLayoutContext::scheduleLayout): Canonical link: https://commits.webkit.org/278042@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f40df: [GTK][WPE][Skia] Disable accelerated ImageBitmap s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f40df743d937deb6c218695998b212243e0738d https://github.com/WebKit/WebKit/commit/8f40df743d937deb6c218695998b212243e0738d Author: Miguel Gomez Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/html/ImageBitmap.cpp Log Message: --- [GTK][WPE][Skia] Disable accelerated ImageBitmap support https://bugs.webkit.org/show_bug.cgi?id=273316 Reviewed by Carlos Garcia Campos. Disable accelerated support for ImageBitmap when using skia. * Source/WebCore/html/ImageBitmap.cpp: (WebCore::bufferRenderingMode): Canonical link: https://commits.webkit.org/278041@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8371e: Add a way to exclude certain game controllers from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8371eaa79e62ee1f18df46b5c5450e1e8d31e27 https://github.com/WebKit/WebKit/commit/c8371eaa79e62ee1f18df46b5c5450e1e8d31e27 Author: Ada Chan Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm Log Message: --- Add a way to exclude certain game controllers from Gamepad API https://bugs.webkit.org/show_bug.cgi?id=273274 rdar://127075441 Reviewed by Brady Eidson. * Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm: (WebCore::shouldExcludeGameController): (WebCore::GameControllerGamepadProvider::controllerDidConnect): Canonical link: https://commits.webkit.org/278040@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8803a: Reduce use of WKBundlePageGetMainFrame in WebKitTe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8803aadf9e780393cb65c6a67caf33f182886e9 https://github.com/WebKit/WebKit/commit/f8803aadf9e780393cb65c6a67caf33f182886e9 Author: Alex Christensen Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp M Tools/WebKitTestRunner/InjectedBundle/cocoa/AccessibilityCommonCocoa.mm M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp Log Message: --- Reduce use of WKBundlePageGetMainFrame in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=273302 Reviewed by Wenson Hsieh. With site isolation, the main frame might be in another process. Use the current JSContextRef instead. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::mathRootRadicand): (WTR::AccessibilityUIElement::children): (WTR::AccessibilityUIElement::imageOverlayElements): (WTR::AccessibilityUIElement::selectedChildren): (WTR::AccessibilityUIElement::detailsElements): (WTR::AccessibilityUIElement::mathRootRadicand const): Deleted. (WTR::AccessibilityUIElement::children const): Deleted. (WTR::AccessibilityUIElement::imageOverlayElements const): Deleted. (WTR::AccessibilityUIElement::selectedChildren const): Deleted. (WTR::AccessibilityUIElement::detailsElements const): Deleted. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: (WTR::AccessibilityUIElement::attributeValueAsync): (WTR::makeJSArray): * Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: (_generateImplementationFile): * Tools/WebKitTestRunner/InjectedBundle/cocoa/AccessibilityCommonCocoa.mm: (WTR::makeJSArray): * Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::children): (WTR::AccessibilityUIElement::detailsElements): (WTR::AccessibilityUIElement::errorMessageElements): (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): (WTR::AccessibilityUIElement::rowHeaders): (WTR::AccessibilityUIElement::selectedCells): (WTR::AccessibilityUIElement::columnHeaders): (WTR::AccessibilityUIElement::imageOverlayElements): (WTR::AccessibilityUIElement::children const): Deleted. (WTR::AccessibilityUIElement::detailsElements const): Deleted. (WTR::AccessibilityUIElement::errorMessageElements const): Deleted. (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const): Deleted. (WTR::AccessibilityUIElement::rowHeaders const): Deleted. (WTR::AccessibilityUIElement::selectedCells const): Deleted. (WTR::AccessibilityUIElement::columnHeaders const): Deleted. (WTR::AccessibilityUIElement::imageOverlayElements const): Deleted. * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::children): (WTR::AccessibilityUIElement::rowHeaders): (WTR::AccessibilityUIElement::selectedCells): (WTR::AccessibilityUIElement::columnHeaders): (WTR::AccessibilityUIElement::detailsElements): (WTR::AccessibilityUIElement::errorMessageElements): (WTR::AccessibilityUIElement::selectedChildren): (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): (WTR::AccessibilityUIElement::attributeValueAsync): (WTR::AccessibilityUIElement::searchTextWithCriteria): (WTR::AccessibilityUIElement::columns): (WTR::AccessibilityUIElement::imageOverlayElements): (WTR::AccessibilityUIElement::mathRootRadicand): (WTR::AccessibilityUIElement::children const): Deleted. (WTR::AccessibilityUIElement::rowHeaders const): Deleted. (WTR::AccessibilityUIElement::selectedCells const): Deleted. (WTR::AccessibilityUIElement::columnHeaders const): Deleted. (WTR::AccessibilityUIElement::detailsElements const): Deleted. (WTR::AccessibilityUIElement::errorMessageElements const): Deleted. (WTR::AccessibilityUIElement::selectedChildren const): Deleted. (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const): Deleted. (WTR::AccessibilityUIElement::imageOverlayElements const): Deleted. (WTR::AccessibilityUIElement::mathRootRadicand const): Deleted. Canonical link: https://commits.webkit.org/278039@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4deeed: Stop using mainFrameJSContext and firstRootFrameJS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4deeedaacec92708589899707d067bc335bc048b https://github.com/WebKit/WebKit/commit/4deeedaacec92708589899707d067bc335bc048b Author: Alex Christensen Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Log Message: --- Stop using mainFrameJSContext and firstRootFrameJSContext in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=273298 rdar://127093020 Reviewed by Charlie Wolfe. We need a JSContextRef to do things with JavaScript. It's easy to use a globally accessible function to get one that's always there, but with site isolation the main frame JS context is no longer always there. Instead, get the JSContextRef from the originating JS function call. For callbacks, store a JSRetainPtr and use it again when the callback happens. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::postMessageWithAsyncReply): (WTR::firstRootFrame): Deleted. (WTR::firstRootFrameJSContext): Deleted. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::findOptionsFromArray): (WTR::TestRunner::findString): (WTR::TestRunner::findStringMatchesInPage): (WTR::cacheTestRunnerCallback): (WTR::callTestRunnerCallback): (WTR::TestRunner::clearTestRunnerCallbacks): (WTR::TestRunner::addChromeInputField): (WTR::TestRunner::removeChromeInputField): (WTR::TestRunner::setTextInChromeInputField): (WTR::TestRunner::selectChromeInputField): (WTR::TestRunner::getSelectedTextInChromeInputField): (WTR::TestRunner::focusWebView): (WTR::TestRunner::setBackingScaleFactor): (WTR::TestRunner::removeAllCookies): (WTR::TestRunner::setEnterFullscreenForElementCallback): (WTR::TestRunner::setExitFullscreenForElementCallback): (WTR::TestRunner::simulateWebNotificationClick): (WTR::TestRunner::runUIScript): (WTR::TestRunner::runUIScriptImmediately): (WTR::TestRunner::runUIScriptCallback): (WTR::TestRunner::setAllowedMenuActions): (WTR::TestRunner::installDidBeginSwipeCallback): (WTR::TestRunner::installWillEndSwipeCallback): (WTR::TestRunner::installDidEndSwipeCallback): (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback): (WTR::TestRunner::setStatisticsDebugMode): (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode): (WTR::TestRunner::setStatisticsLastSeen): (WTR::TestRunner::setStatisticsMergeStatistic): (WTR::TestRunner::setStatisticsExpiredStatistic): (WTR::TestRunner::setStatisticsPrevalentResource): (WTR::TestRunner::setStatisticsVeryPrevalentResource): (WTR::TestRunner::setStatisticsHasHadUserInteraction): (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback): (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): (WTR::TestRunner::statisticsUpdateCookieBlocking): (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore): (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval): (WTR::TestRunner::setStatisticsShouldDowngradeReferrer): (WTR::TestRunner::setStatisticsShouldBlockThirdPartyCookies): (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode): (WTR::TestRunner::statisticsSetToSameSiteStrictCookies): (WTR::TestRunner::statisticsSetFirstPartyHostCNAMEDomain): (WTR::TestRunner::statisticsSetThirdPartyCNAMEDomain): (WTR::TestRunner::statisticsResetToConsistentState): (WTR::TestRunner::installTextDidChangeInTextFieldCallback): (WTR::TestRunner::installTextFieldDidBeginEditingCallback): (WTR::TestRunner::installTextFieldDidEndEditingCallback): (WTR::TestRunner::getAllStorageAccessEntries): (WTR::TestRunner::loadedSubresourceDomains): (WTR::captureDeviceProperties): (WTR::TestRunner::addMockCameraDevice): (WTR::TestRunner::addMockMicrophoneDevice): (WTR::TestRunner::removeAllSessionCredentials): (WTR::TestRunner::getApplicationManifestThen): (WTR::TestRunner::setAppBoundDomains): (WTR::TestRunner::setManagedDomains): (WTR::TestRunner::takeViewPortSnapshot): (WTR::TestRunner::flushConsoleLogs): (WTR::TestRunner::getAndClearReportedWindowProxyAccessDomains): (WTR::mainFrame): Deleted. (WTR::mainFrameJSContext): Deleted. * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: Canonical link: https://commits.webkit.org/278038@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 471d84: AX: AXObjectCache::m_deferredUnconnectedNodeList n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 471d8436650848188bd73cf3ac05e4654939860d https://github.com/WebKit/WebKit/commit/471d8436650848188bd73cf3ac05e4654939860d Author: Andres Gonzalez Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- AX: AXObjectCache::m_deferredUnconnectedNodeList needs to be clear after adding the objects to the isolated tree. https://bugs.webkit.org/show_bug.cgi?id=273296 Reviewed by Tyler Wilcock. This collection was not being cleared, so it would keep growing for the life time of the cache object. Also renamed it to m_deferredUnconnectedObjects to better reflect that it is a collection of AX objects and not a list of Nodes. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::deferAddUnconnectedNode): (WebCore::AXObjectCache::performDeferredCacheUpdate): * Source/WebCore/accessibility/AXObjectCache.h: Canonical link: https://commits.webkit.org/278037@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d0985: Do not run inline layout invalidation when formatt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d09859003293963034021c6345efe80f7740edf https://github.com/WebKit/WebKit/commit/0d09859003293963034021c6345efe80f7740edf Author: Alan Baradlay Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp Log Message: --- Do not run inline layout invalidation when formatting root is also destroyed https://bugs.webkit.org/show_bug.cgi?id=273200 Reviewed by Antti Koivisto. 1. Render tree tear down normally starts at leaf followed by destroying containers. 2. Invalidation code at the leaf level does not consider whether root is going to be destroy too. It could lead to unnecessary work at leaf level which now we just skip. * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::detachFromRenderElement): Canonical link: https://commits.webkit.org/278036@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25a322: Unreviewed. [Skia] Fix clean build after 278034@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25a3229a2c9c2f4ae7299bc8359e6bdfbb164dfd https://github.com/WebKit/WebKit/commit/25a3229a2c9c2f4ae7299bc8359e6bdfbb164dfd Author: Carlos Garcia Campos Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt Log Message: --- Unreviewed. [Skia] Fix clean build after 278034@main Ensure skia headers directory exists before trying to create the symlink there. * Source/ThirdParty/skia/CMakeLists.txt: Canonical link: https://commits.webkit.org/278035@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f3cd5: [CMake] Skia headers symlink is sometimes not crea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f3cd5542cb2f418a5f146e2565834f106008046 https://github.com/WebKit/WebKit/commit/6f3cd5542cb2f418a5f146e2565834f106008046 Author: Adrian Perez de Castro Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt Log Message: --- [CMake] Skia headers symlink is sometimes not created before it is needed https://bugs.webkit.org/show_bug.cgi?id=273315 Reviewed by Carlos Garcia Campos. * Source/ThirdParty/skia/CMakeLists.txt: Ensure that the symlink to the headers location is created while CMake, with file(CREATE_SYMLINK). This makes the symlink always available during the build and avoids using complicated dependency chains on interface targets or using custom_target(), which would that cause some targets to be considered always outdated. Canonical link: https://commits.webkit.org/278034@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a047e: ManagedSourceBuffer & BufferedChangeEvent to be ex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a047ea1ca602aafaa2cbdf820b298555432d55d https://github.com/WebKit/WebKit/commit/0a047ea1ca602aafaa2cbdf820b298555432d55d Author: Jean-Yves Avenard Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/Modules/mediasource/BufferedChangeEvent.idl M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl Log Message: --- ManagedSourceBuffer & BufferedChangeEvent to be exposed to 'DedicatedWorker' https://bugs.webkit.org/show_bug.cgi?id=272885 rdar://127041540 Reviewed by Eric Carlson. Exposed interfaces to DedicatedWorker. * Source/WebCore/Modules/mediasource/BufferedChangeEvent.idl: * Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl: Canonical link: https://commits.webkit.org/278033@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f11489: [visionOS] video goes blank and audio pauses when ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f114890c78b5bb1de5d09d133a3b702618d02a06 https://github.com/WebKit/WebKit/commit/f114890c78b5bb1de5d09d133a3b702618d02a06 Author: Andy Estes Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations M Source/WebCore/html/HTMLVideoElement.cpp M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/MediaPlayerPrivate.h M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp M Source/WebCore/platform/graphics/SourceBufferPrivate.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/WebSampleBufferVideoRendering.h M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h Log Message: --- [visionOS] video goes blank and audio pauses when transitioning to LinearMediaKit fullscreen https://bugs.webkit.org/show_bug.cgi?id=273171 rdar://125647233 Reviewed by Jer Noble. When transitioning to LinearMediaKit fullscreen, two issues cause the video to pause and show a black frame in the WKWebView: 1. VideoPresentationInterfaceIOS moves the video view from the web view to a new WebAVPlayerView, even though this view is not used by LMPlayableViewController. 2. When MediaPlayerPrivateMediaSourceAVFObjC switches from an AVSampleBufferDisplayLayer to an AVSampleBufferVideoRenderer, it flushes the display layer and sets the synchronizer's rate to 0 until the video render has an available frame. Resolved (1) by keeping the video view in the WKWebView's hierarchy when VideoPresentationInterfaceLMK is in use. This is OK since LMPLayableViewController will render to an entity rather than a layer. Resolved (2) by teaching MediaPlayerPrivateMediaSourceAVFObjC to stage the transition from AVSampleBufferDisplayLayer to AVSampleBufferVideoRenderer (and vice versa). When a video receiver endpoint is received an AVSampleBufferVideoRenderer is created, but the existing AVSampleBufferDisplayLayer is kept alive. It isn't flushed, so it continues to render samples that have been previously enqueued. Simultaneously, samples for the current time are enqueued to the AVSampleBufferVideoRenderer, and only once the video render has an available frame the display layer is destroyed. The synchronizer remains playing during this transition. A similar staged transition occurs when switching back from a video renderer to a display layer. * Source/WebCore/html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::didEnterFullscreenOrPictureInPicture): (WebCore::HTMLVideoElement::didExitFullscreenOrPictureInPicture): * Source/WebCore/platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setInFullscreenOrPictureInPicture): (WebCore::MediaPlayer::isInFullscreenOrPictureInPicture const): * Source/WebCore/platform/graphics/MediaPlayer.h: * Source/WebCore/platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::isInFullscreenOrPictureInPictureChanged): * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::reenqueSamples): (WebCore::SourceBufferPrivate::reenqueueMediaForTime): * Source/WebCore/platform/graphics/SourceBufferPrivate.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayerOrVideoRenderer const): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPresentationSize):
[webkit-changes] [WebKit/WebKit] 1ade9b: [Skia] Handle font style when finding fallback fonts
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ade9b72a383daa2aee2e964d15c42877b9fb999 https://github.com/WebKit/WebKit/commit/1ade9b72a383daa2aee2e964d15c42877b9fb999 Author: Carlos Garcia Campos Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp Log Message: --- [Skia] Handle font style when finding fallback fonts https://bugs.webkit.org/show_bug.cgi?id=273310 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: (WebCore::skiaFontStyle): (WebCore::FontCache::systemFallbackForCharacterCluster): Canonical link: https://commits.webkit.org/278031@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 56c9ce: Cherry-pick 275062@main (c1a059873be7). https://bu...
Branch: refs/heads/webkitglib/2.44
Home: https://github.com/WebKit/WebKit
Commit: 56c9ce1a60cf039c616345a8c3995c1eec12352d
https://github.com/WebKit/WebKit/commit/56c9ce1a60cf039c616345a8c3995c1eec12352d
Author: Nicolò Ribaudo
Date: 2024-04-26 (Fri, 26 Apr 2024)
Changed paths:
M JSTests/es6/String.prototype_methods_String.prototype.normalize.js
M Source/JavaScriptCore/runtime/StringPrototype.cpp
Log Message:
---
Cherry-pick 275062@main (c1a059873be7).
https://bugs.webkit.org/show_bug.cgi?id=269783
Normalize Latin-1 characters in `String#normalize("NFKC")``
https://bugs.webkit.org/show_bug.cgi?id=269783
Reviewed by Alexey Proskuryakov.
The `String.prototype.normalize` implementation has a fast-path in
cases where normalization does not affect the string. It was incorrectly
assumed that NFKC does not affect 8-bit strings. The only normalization
that doesn't affect them is NFC.
* JSTests/es6/String.prototype_methods_String.prototype.normalize.js:
(test):
* Source/JavaScriptCore/runtime/StringPrototype.cpp:
(JSC::normalize):
(JSC::normalizationAffects8Bit): Deleted.
Canonical link: https://commits.webkit.org/275062@main
Canonical link: https://commits.webkit.org/274313.164@webkitglib/2.44
Commit: 9f979ae34d0c6654e52938076551077782326e8d
https://github.com/WebKit/WebKit/commit/9f979ae34d0c6654e52938076551077782326e8d
Author: Kristina Bessonova
Date: 2024-04-26 (Fri, 26 Apr 2024)
Changed paths:
M Source/JavaScriptCore/heap/GCMemoryOperations.h
Log Message:
---
Cherry-pick 275057@main (a6fdfba9eced).
https://bugs.webkit.org/show_bug.cgi?id=269785
[JSC] Add missed "cc" inline asm clobber to ARM64 memory operations
https://bugs.webkit.org/show_bug.cgi?id=269785
Reviewed by Keith Miller.
Since inline asm touches flags, it should set "cc" clobber to ensure
a compiler will schedule instructions correctly.
W/o the clobber and if compiled with clang v16 and newer (AArch64,
Linux) may lead to a crash inside JSArray::unshiftCountSlowCase().
* Source/JavaScriptCore/heap/GCMemoryOperations.h:
(JSC::gcSafeMemcpy):
(JSC::gcSafeMemmove):
(JSC::gcSafeZeroMemory):
Canonical link: https://commits.webkit.org/275057@main
Canonical link: https://commits.webkit.org/274313.165@webkitglib/2.44
Compare: https://github.com/WebKit/WebKit/compare/25e470331432...9f979ae34d0c
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3de6c0: [Skia] Rotate the canvas when drawing vertical text
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3de6c04d645fa275940ec20f52d8694f5ac7ee1f https://github.com/WebKit/WebKit/commit/3de6c04d645fa275940ec20f52d8694f5ac7ee1f Author: Carlos Garcia Campos Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp Log Message: --- [Skia] Rotate the canvas when drawing vertical text https://bugs.webkit.org/show_bug.cgi?id=273303 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): * Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp: (WebCore::FontCascade::drawGlyphs): Canonical link: https://commits.webkit.org/278030@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26805f: [Skia] Use SkScalarToDouble when creating a Transf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26805fa9a852a7398ec4002871e4e85bf6e5f953 https://github.com/WebKit/WebKit/commit/26805fa9a852a7398ec4002871e4e85bf6e5f953 Author: Carlos Garcia Campos Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/TransformationMatrixSkia.cpp Log Message: --- [Skia] Use SkScalarToDouble when creating a TransformationMatrix from SkM44 https://bugs.webkit.org/show_bug.cgi?id=273182 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::TransformationMatrix::TransformationMatrix): (WebCore::TransformationMatrix::operator SkM44 const): (WebCore::AffineTransform::AffineTransform): Canonical link: https://commits.webkit.org/278029@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 69c582: Cherry-pick 275198@main (a45b3b20b106). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 69c582be05a46699bda0bd400f33e4782c0ac1c8 https://github.com/WebKit/WebKit/commit/69c582be05a46699bda0bd400f33e4782c0ac1c8 Author: Ben Nham Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WTF/wtf/MemoryPressureHandler.cpp M Source/WTF/wtf/MemoryPressureHandler.h M Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm M Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp M Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- Cherry-pick 275198@main (a45b3b20b106). https://bugs.webkit.org/show_bug.cgi?id=269859 WebContent process stays in the isUnderMemoryPressure state forever after it breaches the PROC_LIMIT_CRITICAL threshold https://bugs.webkit.org/show_bug.cgi?id=269859 rdar://118126701 Reviewed by Antti Koivisto. After 244148@main, a WebContent process that exceeds the PROC_LIMIT_CRITICAL threshold ends up in the isUnderMemoryPressure state forever. This is because we were mutating the memory pressure state instance variable when handling the process limit notification. Since the OS only notifies you when you exceed the proc limit, but not when you go back under the proc limit, that state variable ended up staying in the critical state forever. (This bug has occurred before, see r234646.) To fix this, stop mutating the memory pressure state when the process limit notification fires, and add a separate callback for handling process limit notifications. * Source/WTF/wtf/MemoryPressureHandler.cpp: (WTF::MemoryPressureHandler::setMemoryPressureStatus): (WTF::MemoryPressureHandler::memoryPressureStatusChanged): (WTF::MemoryPressureHandler::didExceedProcessMemoryLimit): * Source/WTF/wtf/MemoryPressureHandler.h: (WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback): (WTF::MemoryPressureHandler::setDidExceedProcessMemoryLimitCallback): (WTF::MemoryPressureHandler::isUnderMemoryWarning const): (WTF::MemoryPressureHandler::isUnderMemoryPressure const): * Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm: (WTF::MemoryPressureHandler::install): * Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp: (WTF::MemoryPressureHandler::triggerMemoryPressureEvent): * Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp: (WTF::MemoryPressureHandler::windowsMeasurementTimerFired): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Canonical link: https://commits.webkit.org/275198@main Canonical link: https://commits.webkit.org/274313.162@webkitglib/2.44 Commit: 25e4703314326cda79659dec3e4843263da30c32 https://github.com/WebKit/WebKit/commit/25e4703314326cda79659dec3e4843263da30c32 Author: Philippe Normand Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp Log Message: --- Cherry-pick 275090@main (c62c74690915). https://bugs.webkit.org/show_bug.cgi?id=269836 [WPE][GTK] Disable mDNS LibWebRTC support https://bugs.webkit.org/show_bug.cgi?id=269836 Reviewed by Adrian Perez de Castro. Disable mDNS address resolving for WPE and GTK ports, mDNS address registration is implemented only for the Mac ports, so resolving can work only for those, currently. * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp: (WebKit::LibWebRTCNetworkManager::GetMdnsResponder const): Canonical link: https://commits.webkit.org/275090@main Canonical link: https://commits.webkit.org/274313.163@webkitglib/2.44 Compare: https://github.com/WebKit/WebKit/compare/bb9c461af9bf...25e470331432 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95e791: AX: WebKit should not trim non-breaking space char...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95e791e34021f963c6c7dff0103d3b0eb924da2a https://github.com/WebKit/WebKit/commit/95e791e34021f963c6c7dff0103d3b0eb924da2a Author: Tyler Wilcock Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_text_node-expected.txt M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp Log Message: --- AX: WebKit should not trim non-breaking space characters when computing accessibility text https://bugs.webkit.org/show_bug.cgi?id=273292 rdar://problem/127084721 Reviewed by Andres Gonzalez. In https://bugs.webkit.org/show_bug.cgi?id=271896, we replaced usage of deprecatedIsSpaceOrNewline with isUnicodeWhitespace. Importantly, isUnicodeWhitespace trims non-breaking space characters, which is not the correct thing to do when computing accessibility text (we should only trim ASCII whitespace). * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_text_node-expected.txt: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const): (WebCore::AccessibilityNodeObject::textAsLabelFor const): (WebCore::AccessibilityNodeObject::textUnderElement const): (WebCore::accessibleNameForNode): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::stringForRange const): Canonical link: https://commits.webkit.org/278028@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
