[webkit-changes] [WebKit/WebKit] 3de868: Complete id-ref reflection implementation for ARIA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3de868265f6733df13d23d257d301b6f9f492ca6 https://github.com/WebKit/WebKit/commit/3de868265f6733df13d23d257d301b6f9f492ca6 Author: Manuel Rego Casasnovas Date: 2022-10-10 (Mon, 10 Oct 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Log Message: --- Complete id-ref reflection implementation for ARIAAttributes https://bugs.webkit.org/show_bug.cgi?id=245301 Reviewed by Ryosuke Niwa. Enable AriaReflectionForElementReferencesEnabled experimental flag by default. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Canonical link: https://commits.webkit.org/255358@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05f043: Set empty string for reflection of IDREF attributes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05f04306d2dc59ca6b5c255a6e31483799daf9f8 https://github.com/WebKit/WebKit/commit/05f04306d2dc59ca6b5c255a6e31483799daf9f8 Author: Manuel Rego Casasnovas Date: 2022-10-07 (Fri, 07 Oct 2022) Changed paths: M LayoutTests/accessibility/ARIA-reflection-expected.txt M LayoutTests/accessibility/ARIA-reflection.html M LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html M LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection.html M Source/WebCore/dom/Element.cpp Log Message: --- Set empty string for reflection of IDREF attributes https://bugs.webkit.org/show_bug.cgi?id=245299 This implements the agreement on the following HTML issue: https://github.com/whatwg/html/issues/8306 HTML PR is available at: https://github.com/whatwg/html/pull/8352 It just always set the content attribute to the empty string in Element::setElementAttribute() and Element::setElementsArrayAttribute(). The tests are updated accordingly to the new behavior. Reviewed by Ryosuke Niwa. * LayoutTests/accessibility/ARIA-reflection-expected.txt: * LayoutTests/accessibility/ARIA-reflection.html: * LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection.html: * Source/WebCore/dom/Element.cpp: (WebCore::Element::setElementAttribute): (WebCore::Element::setElementsArrayAttribute): Canonical link: https://commits.webkit.org/255267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a61ea: Integrate ARIA element reflection in the Accessibi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a61ea9a825740c42f60af419813acb143df91f7 https://github.com/WebKit/WebKit/commit/5a61ea9a825740c42f60af419813acb143df91f7 Author: Manuel Rego Casasnovas Date: 2022-09-27 (Tue, 27 Sep 2022) Changed paths: A LayoutTests/accessibility/element-reflection-ariaactivedescendant-expected.txt A LayoutTests/accessibility/element-reflection-ariaactivedescendant.html A LayoutTests/accessibility/element-reflection-ariacontrols-expected.txt A LayoutTests/accessibility/element-reflection-ariacontrols.html A LayoutTests/accessibility/element-reflection-ariadescribedby-expected.txt A LayoutTests/accessibility/element-reflection-ariadescribedby.html A LayoutTests/accessibility/element-reflection-ariadetails-expected.txt A LayoutTests/accessibility/element-reflection-ariadetails.html A LayoutTests/accessibility/element-reflection-ariaerrormessage-expected.txt A LayoutTests/accessibility/element-reflection-ariaerrormessage.html A LayoutTests/accessibility/element-reflection-ariaflowto-expected.txt A LayoutTests/accessibility/element-reflection-ariaflowto.html A LayoutTests/accessibility/element-reflection-arialabelledby-expected.txt A LayoutTests/accessibility/element-reflection-arialabelledby.html A LayoutTests/accessibility/element-reflection-ariaowns-expected.txt A LayoutTests/accessibility/element-reflection-ariaowns.html M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/win/TestExpectations M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h Log Message: --- Integrate ARIA element reflection in the Accessibility Tree https://bugs.webkit.org/show_bug.cgi?id=244972 Reviewed by Ryosuke Niwa. * LayoutTests/accessibility/element-reflection-ariaactivedescendant-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariaactivedescendant.html: Added. * LayoutTests/accessibility/element-reflection-ariacontrols-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariacontrols.html: Added. * LayoutTests/accessibility/element-reflection-ariadescribedby-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariadescribedby.html: Added. * LayoutTests/accessibility/element-reflection-ariadetails-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariadetails.html: Added. * LayoutTests/accessibility/element-reflection-ariaerrormessage-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariaerrormessage.html: Added. * LayoutTests/accessibility/element-reflection-ariaflowto-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariaflowto.html: Added. * LayoutTests/accessibility/element-reflection-arialabelledby-expected.txt: Added. * LayoutTests/accessibility/element-reflection-arialabelledby.html: Added. * LayoutTests/accessibility/element-reflection-ariaowns-expected.txt: Added. * LayoutTests/accessibility/element-reflection-ariaowns.html: Added. * LayoutTests/platform/mac-wk1/TestExpectations: Skip tests due to missing methods on WK1. * LayoutTests/platform/win/TestExpectations: Skip new tests on Windows. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::updateRelationsIfNeeded): Take into account element reflection information. * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore:: const): Ditto. * Source/WebCore/dom/Element.cpp: (WebCore::Element::isElementReflectionAttribute): Expose method so it can be used from the a11y code. (WebCore::Element::isElementsArrayReflectionAttribute): Ditto. (WebCore::isElementReflectionAttribute): Deleted. (WebCore::isElementsArrayReflectionAttribute): Deleted. * Source/WebCore/dom/Element.h: Canonical link: https://commits.webkit.org/254905@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 509911: [GTK][a11y] WTR: Add implementation for detailsEle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 509911566946e1fcd7298a38a5714f4b01631b4d https://github.com/WebKit/WebKit/commit/509911566946e1fcd7298a38a5714f4b01631b4d Author: Manuel Rego Casasnovas Date: 2022-09-21 (Wed, 21 Sep 2022) Changed paths: R LayoutTests/platform/gtk/accessibility/custom-elements/describedby-expected.txt M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp Log Message: --- [GTK][a11y] WTR: Add implementation for detailsElements() and errorMessageElements() https://bugs.webkit.org/show_bug.cgi?id=245469 Reviewed by Carlos Garcia Campos. * LayoutTests/platform/gtk/accessibility/custom-elements/describedby-expected.txt: Removed. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::detailsElements const): Deleted. (WTR::AccessibilityUIElement::errorMessageElements const): Deleted. * Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: (WTR::AccessibilityUIElement::detailsElements const): (WTR::AccessibilityUIElement::errorMessageElements const): * Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp: (WTR::elementsForRelation): (WTR::AccessibilityUIElement::detailsElements const): (WTR::AccessibilityUIElement::errorMessageElements const): Canonical link: https://commits.webkit.org/254726@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/element-reflection-a11y-tree Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57fec5: Integrate ARIA element reflection in the Accessibi...
Branch: refs/heads/element-reflection-a11y-tree Home: https://github.com/WebKit/WebKit Commit: 57fec55cf569c1bb57625c79834ce8dfdb084455 https://github.com/WebKit/WebKit/commit/57fec55cf569c1bb57625c79834ce8dfdb084455 Author: Manuel Rego Casasnovas Date: 2022-09-21 (Wed, 21 Sep 2022) Changed paths: A LayoutTests/accessibility/element-reflection-ariaactivedescendant-expected.txt A LayoutTests/accessibility/element-reflection-ariaactivedescendant.html A LayoutTests/accessibility/element-reflection-ariacontrols-expected.txt A LayoutTests/accessibility/element-reflection-ariacontrols.html A LayoutTests/accessibility/element-reflection-ariadescribedby-expected.txt A LayoutTests/accessibility/element-reflection-ariadescribedby.html A LayoutTests/accessibility/element-reflection-ariadetails-expected.txt A LayoutTests/accessibility/element-reflection-ariadetails.html A LayoutTests/accessibility/element-reflection-ariaerrormessage-expected.txt A LayoutTests/accessibility/element-reflection-ariaerrormessage.html A LayoutTests/accessibility/element-reflection-ariaflowto-expected.txt A LayoutTests/accessibility/element-reflection-ariaflowto.html A LayoutTests/accessibility/element-reflection-arialabelledby-expected.txt A LayoutTests/accessibility/element-reflection-arialabelledby.html A LayoutTests/accessibility/element-reflection-ariaowns-expected.txt A LayoutTests/accessibility/element-reflection-ariaowns.html M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h Log Message: --- Integrate ARIA element reflection in the Accessibility Tree https://bugs.webkit.org/show_bug.cgi?id=244972 Reviewed by NOBODY (OOPS!). ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295148] trunk
Title: [295148] trunk
Revision 295148
Author r...@igalia.com
Date 2022-06-02 14:45:04 -0700 (Thu, 02 Jun 2022)
Log Message
Reflection for FrozenArray caching invariant
https://bugs.webkit.org/show_bug.cgi?id=240563
Reviewed by Ryosuke Niwa.
This patch implements the caching layer described in the spec PR
for reflection of FrozenArray attributes:
https://github.com/whatwg/html/pull/3917
Which fixes the test cases that were checking for:
el.ariaDescribedByElements === el.ariaDescribedByElements
This patch stores a new JSObject in the JSElement using a PrivateName.
Then for each attribute we store the cached JSValue in the JSObject.
If the cached JSValue matches the current Vector of Elements that
we're going to return, we return the cached JSValue instead.
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
Update expectations.
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html:
Add new test cases.
* Source/WebCore/accessibility/AriaAttributes.idl: Add CustomGetter for
FrozenArray reflection.
* Source/WebCore/bindings/js/JSElementCustom.cpp:
(WebCore::getElementsArrayAttribute): New method that implements the
caching invariant.
(WebCore::JSElement::ariaControlsElements const): Custom getter that
calls getElementsArrayAttribute().
(WebCore::JSElement::ariaDescribedByElements const): Ditto.
(WebCore::JSElement::ariaDetailsElements const): Ditto.
(WebCore::JSElement::ariaFlowToElements const): Ditto.
(WebCore::JSElement::ariaLabelledByElements const): Ditto.
(WebCore::JSElement::ariaOwnsElements const): Ditto.
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h: New built-in
PrivateName.
Canonical link: https://commits.webkit.org/251237@main
Modified Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html
trunk/Source/WebCore/accessibility/AriaAttributes.idl
trunk/Source/WebCore/bindings/js/JSElementCustom.cpp
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
Diff
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt (295147 => 295148)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt 2022-06-02 21:43:23 UTC (rev 295147)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt 2022-06-02 21:45:04 UTC (rev 295148)
@@ -50,7 +50,7 @@
PASS Reparenting an element into a descendant shadow scope hides the element reference.
PASS Reparenting referenced element cannot cause retargeting of reference.
PASS Element reference set in invalid scope remains intact throughout move to valid scope.
-FAIL aria-labelledby. assert_equals: check idl attribute caching after parsing expected [Element node Billing, Element node Name] but got [Element node Billing, Element node Name]
+PASS aria-labelledby.
PASS aria-controls.
PASS aria-describedby.
PASS aria-flowto.
@@ -62,4 +62,6 @@
PASS Attaching element reference before it's inserted into the DOM.
PASS Cross-document references and moves.
PASS Adopting element keeps references.
+PASS Caching invariant different attributes.
+PASS Caching invariant different elements.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html (295147 => 295148)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html 2022-06-02 21:43:23 UTC (rev 295147)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html 2022-06-02 21:45:04 UTC (rev 295148)
@@ -730,6 +730,54 @@
}, "Adopting element keeps references.");
+
+
+
+
+
+
+
+
+test(function(t) {
+ cachingInvariantMain.ariaControlsElements = [cachingInvariantElement1, cachingInvariantElement2];
+ cachingInvariantMain.ariaDescribedByElements = [cachingInvariantElement3, cachingInvariantElement4];
+ cachingInvariantMain.ariaDetailsElements = [cachingInvariantElement5];
+ cachingInvariantMain.ariaFlowToElements = [cachingInvariantElement1, cachingInvariantElement3];
+ cachingInvariantMain.ariaLabelledByElements = [cachingInvariantElement2, cachingInvariantElement4];
+ cachingInvariantMain.ariaOwnsElements = [cachingInvariantElement1, cachingInvariantElement2, cachingInvariantElement3];
+
+ let ariaControlsElementsArray = cachingInvariantMain.ariaControlsElements;
+ let ariaDescribedByElementsArray = cachingInvariantMain.ariaDescribedByElements;
+ let ariaDetailsElementsArray = cachingInvariantMain.ariaDetailsElements;
+ let ariaFlowToElementsArray = cachingInvariantMain.ariaFlowToElements;
+ let ariaLabelledByElementsArray =
[webkit-changes] [294481] trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes
Title: [294481] trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes
Revision 294481
Author r...@igalia.com
Date 2022-05-19 08:13:42 -0700 (Thu, 19 May 2022)
Log Message
Update WPT dom/nodes/aria-element-reflection.tentative.html test
https://bugs.webkit.org/show_bug.cgi?id=240641
Reviewed by Chris Dumez.
Update test and expectations.
The new failure is due to https://webkit.org/b/240563.
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html:
Canonical link: https://commits.webkit.org/250740@main
Modified Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html
Diff
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt (294480 => 294481)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt 2022-05-19 14:55:34 UTC (rev 294480)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt 2022-05-19 15:13:42 UTC (rev 294481)
@@ -50,7 +50,7 @@
PASS Reparenting an element into a descendant shadow scope hides the element reference.
PASS Reparenting referenced element cannot cause retargeting of reference.
PASS Element reference set in invalid scope remains intact throughout move to valid scope.
-PASS aria-labelledby.
+FAIL aria-labelledby. assert_equals: check idl attribute caching after parsing expected [Element node Billing, Element node Name] but got [Element node Billing, Element node Name]
PASS aria-controls.
PASS aria-describedby.
PASS aria-flowto.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html (294480 => 294481)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html 2022-05-19 14:55:34 UTC (rev 294480)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html 2022-05-19 15:13:42 UTC (rev 294481)
@@ -24,10 +24,12 @@
// Element reference should be set if the content attribute was included.
assert_equals(parentListbox.getAttribute("aria-activedescendant"), "i1", "check content attribute after parsing.");
assert_equals(parentListbox.ariaActiveDescendantElement, i1, "check idl attribute after parsing.");
+assert_equals(parentListbox.ariaActiveDescendantElement, parentListbox.ariaActiveDescendantElement, "check idl attribute caching after parsing.");
// If we set the content attribute, the element reference should reflect this.
parentListbox.setAttribute("aria-activedescendant", "i2");
assert_equals(parentListbox.ariaActiveDescendantElement, i2, "setting the content attribute updates the element reference.");
+assert_equals(parentListbox.ariaActiveDescendantElement, parentListbox.ariaActiveDescendantElement, "check idl attribute caching after update.");
// Setting the element reference should be reflected in the content attribute.
parentListbox.ariaActiveDescendantElement = i1;
@@ -342,10 +344,12 @@
test(function(t) {
const billingElement = document.getElementById("billingElement")
assert_array_equals(input1.ariaLabelledByElements, [billingElement, nameElement], "parsed content attribute sets element references.");
+assert_equals(input1.ariaLabelledByElements, input1.ariaLabelledByElements, "check idl attribute caching after parsing");
assert_equals(input2.ariaLabelledByElements, null, "Testing missing content attribute after parsing.");
input2.ariaLabelledByElements = [billingElement, addressElement];
assert_array_equals(input2.ariaLabelledByElements, [billingElement, addressElement], "Testing IDL setter/getter.");
+assert_equals(input1.ariaLabelledByElements, input1.ariaLabelledByElements, "check idl attribute caching after update");
assert_equals(input2.getAttribute("aria-labelledby"), "billingElement addressElement");
// Remove the billingElement from the DOM.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294144] trunk/Source/WebCore
Title: [294144] trunk/Source/WebCore
Revision 294144
Author r...@igalia.com
Date 2022-05-13 00:26:01 -0700 (Fri, 13 May 2022)
Log Message
Remove unneeded check in HTMLSlotElement::assignedNodes()
https://bugs.webkit.org/show_bug.cgi?id=240340
Reviewed by Ryosuke Niwa.
* html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::assignedNodes const):
Canonical link: https://commits.webkit.org/250514@main
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSlotElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (294143 => 294144)
--- trunk/Source/WebCore/ChangeLog 2022-05-13 07:19:31 UTC (rev 294143)
+++ trunk/Source/WebCore/ChangeLog 2022-05-13 07:26:01 UTC (rev 294144)
@@ -1,5 +1,15 @@
2022-05-12 Manuel Rego Casasnovas
+Remove unneeded check in HTMLSlotElement::assignedNodes()
+https://bugs.webkit.org/show_bug.cgi?id=240340
+
+Reviewed by Ryosuke Niwa.
+
+* html/HTMLSlotElement.cpp:
+(WebCore::HTMLSlotElement::assignedNodes const):
+
+2022-05-12 Manuel Rego Casasnovas
+
ARIA reflection for FrozenArray attributes
https://bugs.webkit.org/show_bug.cgi?id=239853
Modified: trunk/Source/WebCore/html/HTMLSlotElement.cpp (294143 => 294144)
--- trunk/Source/WebCore/html/HTMLSlotElement.cpp 2022-05-13 07:19:31 UTC (rev 294143)
+++ trunk/Source/WebCore/html/HTMLSlotElement.cpp 2022-05-13 07:26:01 UTC (rev 294144)
@@ -146,7 +146,7 @@
return nodes;
}
-if (auto* nodes = assignedNodes(); nodes) {
+if (auto* nodes = assignedNodes()) {
return compactMap(*nodes, [](auto& nodeWeakPtr) -> RefPtr {
return nodeWeakPtr.get();
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294141] trunk
Title: [294141] trunk
Revision 294141
Author r...@igalia.com
Date 2022-05-12 22:04:23 -0700 (Thu, 12 May 2022)
Log Message
ARIA reflection for FrozenArray attributes
https://bugs.webkit.org/show_bug.cgi?id=239853
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update expectations with the new PASS lines.
* web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
Source/WebCore:
Implement ARIA reflection for attributes that refer to a list of Elements:
aria-controls, aria-describedby, aria-details, aria-flowto,
aria-labelledby and aria-owns.
For the properties names this patch uses "Elements" suffix:
ariaControlsElements, ariaDescribedByElements, ariaDescribedByElements,
ariaFlowToElements, ariaLabelledByElements, ariaOwnsElements
this matches Chromium implementation and AOM explainer, but not AOM spec:
https://github.com/w3c/aria/issues/1732
* accessibility/AriaAttributes.idl: Add the new properties under
AriaReflectionForElementReferencesEnabled runtime flag.
* bindings/scripts/CodeGenerator.pm:
(GetterExpression): Add function for FrozenArray properties.
(SetterExpression): Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Add tests.
(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObj_reflectedElementsArrayAttrGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::setJSTestObj_reflectedElementsArrayAttrSetter):
(WebCore::JSC_DEFINE_CUSTOM_SETTER):
* bindings/scripts/test/TestObj.idl: Add example attribute.
* dom/Element.cpp:
(WebCore::isElementsArrayReflectionAttribute): New utility method to
identify the attributes that refer to a list of Elements.
(WebCore::Element::attributeChanged): Include check for elements
array.
(WebCore::Element::getElementsArrayAttribute const): Implement getter.
(WebCore::Element::setElementsArrayAttribute): Implement setter.
* dom/Element.h: Remove FIXME in ExplicitlySetAttrElementsMap as now
it stores more than one element. Add headers for getter and setter.
LayoutTests:
Update test so it identifies the FrozenArray attributes.
* accessibility/ARIA-reflection-expected.txt:
* accessibility/ARIA-reflection.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt
trunk/LayoutTests/accessibility/ARIA-reflection.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AriaAttributes.idl
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
Diff
Modified: trunk/LayoutTests/ChangeLog (294140 => 294141)
--- trunk/LayoutTests/ChangeLog 2022-05-13 03:38:28 UTC (rev 294140)
+++ trunk/LayoutTests/ChangeLog 2022-05-13 05:04:23 UTC (rev 294141)
@@ -1,3 +1,16 @@
+2022-05-12 Manuel Rego Casasnovas
+
+ARIA reflection for FrozenArray attributes
+https://bugs.webkit.org/show_bug.cgi?id=239853
+
+
+Reviewed by Chris Dumez.
+
+Update test so it identifies the FrozenArray attributes.
+
+* accessibility/ARIA-reflection-expected.txt:
+* accessibility/ARIA-reflection.html:
+
2022-05-12 Diego Pino Garcia
[GTK] Unreviewed test gardening, update tests expected to fail but passed
Modified: trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt (294140 => 294141)
--- trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt 2022-05-13 03:38:28 UTC (rev 294140)
+++ trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt 2022-05-13 05:04:23 UTC (rev 294141)
@@ -67,6 +67,13 @@
element.setAttribute("aria-colspan", otherData);
PASS element[currentProperty] is otherDataProperty
+Test ariaControlsElements < - > aria-controls
+PASS element[currentProperty] is null
+PASS element.getAttribute(currentAttribute) is null
+PASS element.getAttribute(currentAttribute) is dataAttribute
+element.setAttribute("aria-controls", otherData);
+PASS element[currentProperty] is otherDataProperty
+
Test ariaCurrent < - > aria-current
PASS element[currentProperty] is null
PASS element.getAttribute(currentAttribute) is null
@@ -74,6 +81,20 @@
element.setAttribute("aria-current", otherData);
PASS element[currentProperty] is otherDataProperty
+Test ariaDescribedByElements < - > aria-describedby
+PASS element[currentProperty] is null
+PASS element.getAttribute(currentAttribute) is null
+PASS element.getAttribute(currentAttribute) is dataAttribute
+element.setAttribute("aria-describedby", otherData);
+PASS element[currentProperty] is otherDataProperty
+
+Test ariaDetailsElements < - > aria-details
+PASS element[currentProperty] is null
+PASS element.getAttribute(currentAttribute) is null
+PASS ele
[webkit-changes] [293970] trunk
Title: [293970] trunk
Revision 293970
Author r...@igalia.com
Date 2022-05-09 03:47:12 -0700 (Mon, 09 May 2022)
Log Message
[WinCairo][WK1] accessibility/aria-combobox-control-owns-elements.html is crashing after 250325@main
https://bugs.webkit.org/show_bug.cgi?id=240218
Reviewed by Joanmarie Diggs.
Source/WebCore:
Fix a wrong ASSERT for AriaReflectionForElementReferencesEnabled.
If AriaReflectionForElementReferencesEnabled is disabled, and you set
one of the attributes that have reflection under that flag,
we'll hit an ASSERT in Element::attributeChanged().
The fact that we set such attribute doesn't mean that the flag
has to be enabled.
Removed the ASSERT and added an if to check if the flag is enabled,
otherwise we don't need to do anything with the map.
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
LayoutTests:
* platform/wincairo-wk1/TestExpectations: Mark test as timeout as it
was before r293958.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (293969 => 293970)
--- trunk/LayoutTests/ChangeLog 2022-05-09 08:41:51 UTC (rev 293969)
+++ trunk/LayoutTests/ChangeLog 2022-05-09 10:47:12 UTC (rev 293970)
@@ -1,3 +1,14 @@
+2022-05-09 Manuel Rego Casasnovas
+
+[WinCairo][WK1] accessibility/aria-combobox-control-owns-elements.html is crashing after 250325@main
+https://bugs.webkit.org/show_bug.cgi?id=240218
+
+
+Reviewed by Joanmarie Diggs.
+
+* platform/wincairo-wk1/TestExpectations: Mark test as timeout as it
+was before r293958.
+
2022-05-08 Fujii Hironori
[WinCairo][WK1] accessibility/aria-combobox-control-owns-elements.html is crashing after 250325@main
Modified: trunk/LayoutTests/platform/wincairo-wk1/TestExpectations (293969 => 293970)
--- trunk/LayoutTests/platform/wincairo-wk1/TestExpectations 2022-05-09 08:41:51 UTC (rev 293969)
+++ trunk/LayoutTests/platform/wincairo-wk1/TestExpectations 2022-05-09 10:47:12 UTC (rev 293970)
@@ -258,7 +258,7 @@
webkit.org/b/181501 accessibility/table-header-calculation-for-header-rows.html [ Failure ]
-webkit.org/b/240218 accessibility/aria-combobox-control-owns-elements.html [ Skip ] # Crash
+webkit.org/b/240218 accessibility/aria-combobox-control-owns-elements.html [ Timeout ]
webkit.org/b/183955 accessibility/row-with-aria-role-in-native-table.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (293969 => 293970)
--- trunk/Source/WebCore/ChangeLog 2022-05-09 08:41:51 UTC (rev 293969)
+++ trunk/Source/WebCore/ChangeLog 2022-05-09 10:47:12 UTC (rev 293970)
@@ -1,3 +1,25 @@
+2022-05-09 Manuel Rego Casasnovas
+
+[WinCairo][WK1] accessibility/aria-combobox-control-owns-elements.html is crashing after 250325@main
+https://bugs.webkit.org/show_bug.cgi?id=240218
+
+
+Reviewed by Joanmarie Diggs.
+
+Fix a wrong ASSERT for AriaReflectionForElementReferencesEnabled.
+If AriaReflectionForElementReferencesEnabled is disabled, and you set
+one of the attributes that have reflection under that flag,
+we'll hit an ASSERT in Element::attributeChanged().
+
+The fact that we set such attribute doesn't mean that the flag
+has to be enabled.
+
+Removed the ASSERT and added an if to check if the flag is enabled,
+otherwise we don't need to do anything with the map.
+
+* dom/Element.cpp:
+(WebCore::Element::attributeChanged):
+
2022-05-09 Diego Pino Garcia
Unreviewed, non-unified build fixes after r293562
Modified: trunk/Source/WebCore/dom/Element.cpp (293969 => 293970)
--- trunk/Source/WebCore/dom/Element.cpp 2022-05-09 08:41:51 UTC (rev 293969)
+++ trunk/Source/WebCore/dom/Element.cpp 2022-05-09 10:47:12 UTC (rev 293970)
@@ -1942,8 +1942,7 @@
}
} else if (name == HTMLNames::partAttr)
partAttributeChanged(newValue);
-else if (isElementReflectionAttribute(name)) {
-ASSERT(document().settings().ariaReflectionForElementReferencesEnabled());
+else if (document().settings().ariaReflectionForElementReferencesEnabled() && isElementReflectionAttribute(name)) {
if (auto* map = explicitlySetAttrElementsMapIfExists())
map->remove(name);
} else if (name == HTMLNames::exportpartsAttr) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293926] trunk
Title: [293926] trunk
Revision 293926
Author r...@igalia.com
Date 2022-05-06 15:06:52 -0700 (Fri, 06 May 2022)
Log Message
[selectors] Double script focus after mouse click shouldn't match :focus-visible
https://bugs.webkit.org/show_bug.cgi?id=239472
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
* web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-script-focus-020.html: Added.
Source/WebCore:
When you do the second script focus, we were setting
m_latestFocusTrigger to FocusTrigger::Bindings, that makes us lose the
information about the previous element that was focused via mouse
click and start matching :focus-visible on that case.
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020.html
* dom/Document.cpp:
(WebCore::Document::setFocusedElement): We avoid setting
m_latestFocusTrigger if we come from script focus. That way we know if
the previous focused element was focused via mouse click after several
script focus.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293925 => 293926)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-06 21:54:27 UTC (rev 293925)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-06 22:06:52 UTC (rev 293926)
@@ -1,3 +1,14 @@
+2022-05-06 Manuel Rego Casasnovas
+
+[selectors] Double script focus after mouse click shouldn't match :focus-visible
+https://bugs.webkit.org/show_bug.cgi?id=239472
+
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-script-focus-020.html: Added.
+
2022-05-05 Ben Nham
Add support for Notification objects with custom data
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt (0 => 293926)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt 2022-05-06 22:06:52 UTC (rev 293926)
@@ -0,0 +1,10 @@
+This test checks that a double script focus after a mouse click on a focusable element that does not match :focus visible, does NOT match :focus-visible.
+
+Click on the element that says "Click me".
+If the element that says "Focused" has a red outline then the test result is FAILURE, if it has a green background then the test result is SUCCESS.
+Click me
+Focused
+
+PASS ":focus-visible" should be a valid selector
+PASS Double script focus after mouse click on a focusable element that does not match :focus-visible, does NOT match :focus-visible
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020.html (0 => 293926)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020.html 2022-05-06 22:06:52 UTC (rev 293926)
@@ -0,0 +1,70 @@
+
+
+CSS Test (Selectors): Double script focus after mouse click on a focusable element that does not match :focus-visible, does NOT match :focus-visible
+
+
+ #warning {
+display: none;
+background: red;
+ }
+
+ @supports not selector(:focus-visible) {
+#instructions {
+ display: none;
+}
+
+#warning {
+ display: block;
+}
+ }
+
+ :focus-visible {
+outline: solid thick red;
+ }
+
+ :focus:not(:focus-visible) {
+background-color: lime;
+ }
+</style>
+
+<p>This test checks that a double script focus after a mouse click on a focusable element that does not match <code>:focus visible</code>, does NOT match <code>:focus-visible</code>.</p>
+<ol id="instructions">
+ <li>Click on the element that says "Click me".</li>
+ <li>If the element that says "Focused" has a red outline then the test result is FAILURE, if it has a green background then the test result is SUCCESS.</li>
+</ol>
+<p id="warning">Your user-agent does not support <code>:focus-visible</code> pseudo-class, please SKIP this test.</p>
+
+<div id="initial" tabindex="0">Click me</div>
+<div id="target" tabindex="0"
[webkit-changes] [293860] trunk
Title: [293860] trunk Revision 293860 Author r...@igalia.com Date 2022-05-05 14:40:17 -0700 (Thu, 05 May 2022) Log Message ARIA reflection for Element attributes https://bugs.webkit.org/show_bug.cgi?id=239852 Reviewed by Chris Dumez. LayoutTests/imported/w3c: Small fix on the test and update test results with the new PASS. Add new test case to cover elements moved to a different document. * web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt: * web-platform-tests/dom/nodes/aria-element-reflection.tentative.html: Source/WebCore: Implement ARIA reflection for attributes that refer to a single Element: aria-activedescendant & aria-errormessage. For the properties names this patch uses "Element" suffix: ariaActiveDescendantElement & ariaErrorMessageElement; this matches Chromium implementation and AOM explainer, but not AOM spec: https://github.com/w3c/aria/issues/1732 This implementation is done following the proposed spec text defined at: https://github.com/whatwg/html/pull/3917 * accessibility/AriaAttributes.idl: Add ariaActiveDescendantElement & ariaErrorMessageElement. * bindings/scripts/CodeGenerator.pm: (GetterExpression): Add function for Element attributes. (SetterExpression): Ditto. * bindings/scripts/test/JS/JSTestObj.cpp: Add tests for element attribute reflection. (WebCore::JSTestObjDOMConstructor::construct): (WebCore::jsTestObj_reflectedElementAttrGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::setJSTestObj_reflectedElementAttrSetter): (WebCore::JSC_DEFINE_CUSTOM_SETTER): * bindings/scripts/test/TestObj.idl: Add reflectedElementAttr attribute. * dom/Element.cpp: (WebCore::isElementReflectionAttribute): Utility function to identify Element reflection attributes. (WebCore::Element::attributeChanged): If an element reflection attribute has changed we need to synchronize the map entry by removing it as it'll be properly updated in setElementAttribute() when needed. (WebCore::Element::explicitlySetAttrElementsMap): Kind of getter for the ExplicitlySetAttrElementsMap but that creates the map if it doesn't exist yet. (WebCore::Element::explicitlySetAttrElementsMapIfExists const): Getter for the map. (WebCore::Element::getElementAttribute const): Implement getter for element attribute. (WebCore::Element::setElementAttribute): Implement setter for element attribute. * dom/Element.h: Add new method headers and defines the ExplicitlySetAttrElementsMap, which so far only stores one Element in the Vector, but uses a Vector in preparation for supporting FrozenArray reflection in the future. * dom/ElementRareData.cpp: Update size of SameSizeAsElementRareData to include the new pointer. * dom/ElementRareData.h: Add m_explicitlySetAttrElementsMap attribute. (WebCore::ElementRareData::explicitlySetAttrElementsMap): Getter. (WebCore::ElementRareData::useTypes const):Include ExplicitlySetAttrElementsMap. * dom/Node.cpp: (WebCore::stringForRareDataUseType): Add ExplicitlySetAttrElementsMap. * dom/NodeRareData.h: Ditto. Source/WTF: Add new runtime flag AriaReflectionForElementReferencesEnabled. * Scripts/Preferences/WebPreferencesExperimental.yaml: LayoutTests: Update test to include the new reflected attributes. * accessibility/ARIA-reflection-expected.txt: * accessibility/ARIA-reflection.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt trunk/LayoutTests/accessibility/ARIA-reflection.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AriaAttributes.idl trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/TestObj.idl trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/dom/ElementRareData.cpp trunk/Source/WebCore/dom/ElementRareData.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/NodeRareData.h Diff Modified: trunk/LayoutTests/ChangeLog (293859 => 293860) --- trunk/LayoutTests/ChangeLog 2022-05-05 21:10:01 UTC (rev 293859) +++ trunk/LayoutTests/ChangeLog 2022-05-05 21:40:17 UTC (rev 293860) @@ -1,3 +1,15 @@ +2022-05-05 Manuel Rego Casasnovas + +ARIA reflection for Element attributes +https://bugs.webkit.org/show_bug.cgi?id=239852 + +Reviewed by Chris Dumez. + +Update test to include the new reflected attributes. + +* accessibility/ARIA-reflection-expected.txt: +* accessibility/ARIA-reflection.html: + 2022-05-05 Karl Rackler [ iOS ][ Monterey Release wk2 ] imported/w3c/web-platform-test
[webkit-changes] [293449] trunk/Source
Title: [293449] trunk/Source
Revision 293449
Author r...@igalia.com
Date 2022-04-26 14:29:25 -0700 (Tue, 26 Apr 2022)
Log Message
Remove AriaReflectionEnabled runtime flag
https://bugs.webkit.org/show_bug.cgi?id=239532
Reviewed by Chris Fleizach.
Source/WebCore:
ARIA reflection shipped in Safari 12.1 (July 2019)
so it looks the runtime flag is not needed anymore.
* accessibility/AccessibilityRole.idl:
* accessibility/AriaAttributes.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAriaReflectionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ariaReflectionEnabled const): Deleted.
Source/WebKit:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAriaReflectionEnabled): Deleted.
(WKPreferencesGetAriaReflectionEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences ariaReflectionEnabled]): Deleted.
(-[WebPreferences setAriaReflectionEnabled:]): Deleted.
Source/WTF:
* Scripts/Preferences/WebPreferencesInternal.yaml:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRole.idl
trunk/Source/WebCore/accessibility/AriaAttributes.idl
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
Diff
Modified: trunk/Source/WTF/ChangeLog (293448 => 293449)
--- trunk/Source/WTF/ChangeLog 2022-04-26 21:24:20 UTC (rev 293448)
+++ trunk/Source/WTF/ChangeLog 2022-04-26 21:29:25 UTC (rev 293449)
@@ -1,3 +1,12 @@
+2022-04-26 Manuel Rego Casasnovas
+
+Remove AriaReflectionEnabled runtime flag
+https://bugs.webkit.org/show_bug.cgi?id=239532
+
+Reviewed by Chris Fleizach.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
2022-04-26 Kate Cheney
Remove WebArchiveDebugMode
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (293448 => 293449)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-04-26 21:24:20 UTC (rev 293448)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-04-26 21:29:25 UTC (rev 293449)
@@ -79,17 +79,6 @@
WebCore:
default: true
-AriaReflectionEnabled:
- type: bool
- humanReadableName: "ARIA Reflection"
- humanReadableDescription: "ARIA Reflection support"
- webcoreBinding: RuntimeEnabledFeatures
- defaultValue:
-WebKitLegacy:
- default: true
-WebKit:
- default: true
-
AsyncFrameScrollingEnabled:
type: bool
webcoreOnChange: setNeedsRelayoutAllFrames
Modified: trunk/Source/WebCore/ChangeLog (293448 => 293449)
--- trunk/Source/WebCore/ChangeLog 2022-04-26 21:24:20 UTC (rev 293448)
+++ trunk/Source/WebCore/ChangeLog 2022-04-26 21:29:25 UTC (rev 293449)
@@ -1,3 +1,19 @@
+2022-04-26 Manuel Rego Casasnovas
+
+Remove AriaReflectionEnabled runtime flag
+https://bugs.webkit.org/show_bug.cgi?id=239532
+
+Reviewed by Chris Fleizach.
+
+ARIA reflection shipped in Safari 12.1 (July 2019)
+so it looks the runtime flag is not needed anymore.
+
+* accessibility/AccessibilityRole.idl:
+* accessibility/AriaAttributes.idl:
+* page/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setAriaReflectionEnabled): Deleted.
+(WebCore::RuntimeEnabledFeatures::ariaReflectionEnabled const): Deleted.
+
2022-04-26 Ziran Sun
Constructed FormData object should not contain an entry for the submit button that was used to submit the form
Modified: trunk/Source/WebCore/accessibility/AccessibilityRole.idl (293448 => 293449)
--- trunk/Source/WebCore/accessibility/AccessibilityRole.idl 2022-04-26 21:24:20 UTC (rev 293448)
+++ trunk/Source/WebCore/accessibility/AccessibilityRole.idl 2022-04-26 21:29:25 UTC (rev 293449)
@@ -24,8 +24,6 @@
*/
// https://wicg.github.io/aom/spec/aria-reflection.html#AccessibilityRole
-[
-EnabledAtRuntime=AriaReflectionEnabled
-] interface mixin AccessibilityRole {
+interface mixin AccessibilityRole {
[Reflect] attribute [AtomString] DOMString? role;
};
Modified: trunk/Source/WebCore/accessibility/AriaAttributes.idl (293448 => 293449)
--- trunk/Source/WebCore/accessibility/AriaAttributes.idl 2022-04-26 21:24:20 UTC (rev 293448)
+++ trunk/Source/WebCore/accessibility/AriaAttributes.idl 2022-04-26 21:29:25 UTC (rev 293449)
@@ -24,9 +24,7 @@
*/
// https://wicg.github.io/aom/spec/aria-reflection.html#AriaAttributes
-[
-Ena
[webkit-changes] [293431] trunk
Title: [293431] trunk
Revision 293431
Author r...@igalia.com
Date 2022-04-26 11:01:40 -0700 (Tue, 26 Apr 2022)
Log Message
Remove usage of makeWeakPtr() on Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=239768
Reviewed by Chris Dumez.
* Introduction.md:
Modified Paths
trunk/ChangeLog
trunk/Introduction.md
Diff
Modified: trunk/ChangeLog (293430 => 293431)
--- trunk/ChangeLog 2022-04-26 16:56:09 UTC (rev 293430)
+++ trunk/ChangeLog 2022-04-26 18:01:40 UTC (rev 293431)
@@ -1,3 +1,12 @@
+2022-04-26 Manuel Rego Casasnovas
+
+Remove usage of makeWeakPtr() on Introduction.md
+https://bugs.webkit.org/show_bug.cgi?id=239768
+
+Reviewed by Chris Dumez.
+
+* Introduction.md:
+
2022-04-24 Zan Dobersek
[RISCV64] Enable Baseline JIT
Modified: trunk/Introduction.md (293430 => 293431)
--- trunk/Introduction.md 2022-04-26 16:56:09 UTC (rev 293430)
+++ trunk/Introduction.md 2022-04-26 18:01:40 UTC (rev 293431)
@@ -661,7 +661,7 @@
...
function foo(A& a) {
-WeakPtr weakA = makeWeakPtr(a);
+WeakPtr weakA = a;
}
```
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292400] trunk
Title: [292400] trunk
Revision 292400
Author r...@igalia.com
Date 2022-04-05 10:04:57 -0700 (Tue, 05 Apr 2022)
Log Message
[macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button)
https://bugs.webkit.org/show_bug.cgi?id=236782
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Add specific test for element.
* web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html: Added.
Source/WebCore:
Document::m_latestFocusTrigger was not being updated after clicking on a button (or other form controls)
on platforms different than GTK and WPE.
This is because HTMLFormControlElement::isMouseFocusable() returns false on such platforms.
This issue is causing problems with :focus-visible, as the button is not actually focused via mouse click,
if you move the focus via script afterwards, the new focused element always match :focus-visible.
This patch is a workaround to solve that issue, by updating m_latestFocusTrigger on Document
even if the element is not actually focused.
That way :focus-visible doesn't match if there's a script focus afterwards.
Fix :focus-visible after clicking on a button on Mac
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html
* dom/Document.h:
(WebCore::Document::setLatestFocusTrigger):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292399 => 292400)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 16:57:35 UTC (rev 292399)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 17:04:57 UTC (rev 292400)
@@ -1,3 +1,16 @@
+2022-04-05 Manuel Rego Casasnovas
+
+[macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button)
+https://bugs.webkit.org/show_bug.cgi?id=236782
+
+
+Reviewed by Antti Koivisto.
+
+Add specific test for element.
+
+* web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html: Added.
+
2022-04-05 Alan Bujtas
[CSS-Contain] Add support for contain: inline-size
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt (0 => 292400)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt 2022-04-05 17:04:57 UTC (rev 292400)
@@ -0,0 +1,10 @@
+This test checks that a script focus after a mouse click on a button that does not match :focus visible, does NOT match :focus-visible.
+
+Click on the button that says "Click me".
+If the element that says "Focused" has a red outline then the test result is FAILURE, if it has a green background then the test result is SUCCESS.
+Click me
+Focused
+
+PASS ":focus-visible" should be a valid selector
+PASS Script focus after mouse click on a button that does not match :focus-visible, does NOT match :focus-visible
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html (0 => 292400)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html 2022-04-05 17:04:57 UTC (rev 292400)
@@ -0,0 +1,64 @@
+
+
+CSS Test (Selectors): Script focus after mouse click on a button that does not match :focus-visible, does NOT match :focus-visible
+
+
+ #warning {
+display: none;
+background: red;
+ }
+
+ @supports not selector(:focus-visible) {
+#instructions {
+ display: none;
+}
+
+#warning {
+ display: block;
+}
+ }
+
+ :focus-visible {
+outline: solid thick red;
+ }
+
+ :focus:not(:focus-visible) {
+background-color: lime;
+ }
+</style>
+
+<p>This test checks that a script focus after a mouse click on a button that does not match <code>:focus visible</code>, does NOT match <code>:focus-visible</code>.</p>
+<ol id="instructions">
+ <li>Click on the button that says "Click me".<
[webkit-changes] [289521] trunk
Title: [289521] trunk
Revision 289521
Author r...@igalia.com
Date 2022-02-10 00:10:04 -0800 (Thu, 10 Feb 2022)
Log Message
:focus-visible with click on radio/checkbox labels is broken
https://bugs.webkit.org/show_bug.cgi?id=236331
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Added new WPT test to cover this case.
* web-platform-tests/css/selectors/focus-visible-026-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-026.html: Added.
Source/WebCore:
When the label is clicked we have to send the FocusTrigger information to Element::focus().
There we avoid setting FocusVisibility:Visible if it has been triggered via mouse click.
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html
* dom/Element.cpp:
(WebCore::Element::focus): Add a check for FocusTrigger::Click to avoid setting FocusVisibility:Visible.
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler): Pass FocusTrigger::Click.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/html/HTMLLabelElement.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289520 => 289521)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-10 07:44:22 UTC (rev 289520)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-10 08:10:04 UTC (rev 289521)
@@ -1,3 +1,15 @@
+2022-02-10 Manuel Rego Casasnovas
+
+:focus-visible with click on radio/checkbox labels is broken
+https://bugs.webkit.org/show_bug.cgi?id=236331
+
+Reviewed by Antti Koivisto.
+
+Added new WPT test to cover this case.
+
+* web-platform-tests/css/selectors/focus-visible-026-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-026.html: Added.
+
2022-02-09 Chris Dumez
Resync web-platform-tests/html/browsers from upstream
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026-expected.txt (0 => 289521)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026-expected.txt 2022-02-10 08:10:04 UTC (rev 289521)
@@ -0,0 +1,5 @@
+ label
+
+PASS ":focus-visible" should be a valid selector
+PASS :focus-visible does NOT match when a checkbox is focused via click on the associated label
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html (0 => 289521)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html 2022-02-10 08:10:04 UTC (rev 289521)
@@ -0,0 +1,31 @@
+
+
+CSS Test (Selectors): Checkbox doesn't match :focus-visiblel after click on label
+
+
+
+ :focus-visible {
+outline: red solid 5px;
+ }
+</style>
+<input type="checkbox" id="checkbox">
+<label for="" id="label">label</label>
+<script>
+ // Check that :focus-visible is supported.
+ test_valid_selector(':focus-visible');
+
+ promise_test(async t => {
+await test_driver.click(label);
+assert_equals(getComputedStyle(checkbox).outlineStyle, "none", `outline-style for ${checkbox.tagName}#${checkbox.id} should be none`);
+t.done();
+ }, ":focus-visible does NOT match when a checkbox is focused via click on the associated label");
+
+
Modified: trunk/Source/WebCore/ChangeLog (289520 => 289521)
--- trunk/Source/WebCore/ChangeLog 2022-02-10 07:44:22 UTC (rev 289520)
+++ trunk/Source/WebCore/ChangeLog 2022-02-10 08:10:04 UTC (rev 289521)
@@ -1,3 +1,20 @@
+2022-02-10 Manuel Rego Casasnovas
+
+:focus-visible with click on radio/checkbox labels is broken
+https://bugs.webkit.org/show_bug.cgi?id=236331
+
+Reviewed by Antti Koivisto.
+
+When the label is clicked we have to send the FocusTrigger information to Element::focus().
+There we avoid setting FocusVisibility:Visible if it has been triggered via mouse click.
+
+Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-026.html
+
+* dom/Element.cpp:
+(WebCore::Element::focus): Add a check for FocusTrigger::Click to avoid setting FocusVisibility:Visible.
+* html/HTMLLabelElement.cpp:
+(WebCore::HTMLLabelElement::defaultEventHandler): Pass FocusTrigger::Click.
+
2022-02-09 Said Abou-Hallawa
[GPU Process] Move ImageBuffer::createCompatibleImageBuffer() and SVGRenderingContext::createImageBuffer to GraphicsContext
[webkit-changes] [287563] trunk
Title: [287563] trunk
Revision 287563
Author r...@igalia.com
Date 2022-01-04 05:29:08 -0800 (Tue, 04 Jan 2022)
Log Message
[selectors] :focus-visible not matching on accessKey focus after focusing something via mouse
https://bugs.webkit.org/show_bug.cgi?id=234077
Reviewed by Antti Koivisto.
Source/WebCore:
This patch adds Element::focusForBindings() to differentitate when this is called from _javascript_.
If that's the case it pass a new FocusTrigger::Bindings value to Element::focus(),
so we can differentiate when this was called from some internal code or from _javascript_.
When Element::focus() has been called internally, we always want to show the focus ring
(thus pass FocusVisibility::Visible). However when it's called from a script
we'll set it to Visible or Invisible depending on if the previously focused element
was focused via mouse click or not (this is needed to pass
the css/selectors/focus-visible-script-focus-* tests from WPT repository).
Test: fast/selectors/focus-visible-accesskey.html
* dom/Element.cpp:
(WebCore::Element::focus):
(WebCore::Element::focusForBindings):
* dom/Element.h:
(WebCore::Element::focusForBindings):
* dom/FocusOptions.h:
* html/HTMLOrForeignElement.idl:
LayoutTests:
Writing an internal test as WPT tests for this don't work due to webkit.org/b/234139.
* fast/selectors/focus-visible-accesskey-expected.txt: Added.
* fast/selectors/focus-visible-accesskey.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/FocusOptions.h
trunk/Source/WebCore/html/HTMLOrForeignElement.idl
Added Paths
trunk/LayoutTests/fast/selectors/focus-visible-accesskey-expected.txt
trunk/LayoutTests/fast/selectors/focus-visible-accesskey.html
Diff
Modified: trunk/LayoutTests/ChangeLog (287562 => 287563)
--- trunk/LayoutTests/ChangeLog 2022-01-04 13:05:31 UTC (rev 287562)
+++ trunk/LayoutTests/ChangeLog 2022-01-04 13:29:08 UTC (rev 287563)
@@ -1,3 +1,16 @@
+2022-01-04 Manuel Rego Casasnovas
+
+[selectors] :focus-visible not matching on accessKey focus after focusing something via mouse
+https://bugs.webkit.org/show_bug.cgi?id=234077
+
+
+Reviewed by Antti Koivisto.
+
+Writing an internal test as WPT tests for this don't work due to webkit.org/b/234139.
+
+* fast/selectors/focus-visible-accesskey-expected.txt: Added.
+* fast/selectors/focus-visible-accesskey.html: Added.
+
2022-01-03 Diego Pino Garcia
[GTK] Unreviewed test gardening, remove pending test failures filed under webkit.org/b/208292
Added: trunk/LayoutTests/fast/selectors/focus-visible-accesskey-expected.txt (0 => 287563)
--- trunk/LayoutTests/fast/selectors/focus-visible-accesskey-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/selectors/focus-visible-accesskey-expected.txt 2022-01-04 13:29:08 UTC (rev 287563)
@@ -0,0 +1,6 @@
+Initial
+Target
+
+PASS Initial element focused via click does NOT match :focus-visible
+PASS Target element focused via accesskey matches :focus-visible
+
Added: trunk/LayoutTests/fast/selectors/focus-visible-accesskey.html (0 => 287563)
--- trunk/LayoutTests/fast/selectors/focus-visible-accesskey.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/focus-visible-accesskey.html 2022-01-04 13:29:08 UTC (rev 287563)
@@ -0,0 +1,49 @@
+
+
+:focus-visible matches on accesskey after a previous element was focused via mouse
+
+:focus {
+ background: lime;
+}
+:focus-visible {
+ outline: solid 5px blue;
+}
+</style>
+
+<div id="initial" tabindex="0">Initial</div>
+<div id="target" tabindex="0" accesskey="t">Target</div>
+
+<script>
+
+function pressAccessKey(key)
+{
+if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
+modifiers = ["ctrlKey", "altKey"];
+else
+modifiers = ["altKey"];
+eventSender.keyDown(key, modifiers);
+}
+
+function clickElement(element)
+{
+eventSender.mouseMoveTo(element.offsetLeft + element.offsetWidth / 2, element.offsetTop + element.offsetTop / 2);
+eventSender.mouseDown();
+eventSender.mouseUp()
+}
+
+test(() => {
+clickElement(initial);
+assert_equals(document.activeElement, initial);
+assert_equals(getComputedStyle(initial).backgroundColor, "rgb(0, 255, 0)", `background-color for ${initial.tagName}#${initial.id} shoult be lime`);
+assert_not_equals(getComputedStyle(initial).outlineColor, "rgb(0, 0, 255)", `outline-color for ${initial.tagName}#${initial.id} shoult NOT be blue`);
+}, "Initial element focused via click does NOT match :focus-visible");
+
+test(() => {
+pressAccessKey("t");
+assert_equals(document.activeElement, target);
+assert_equals(getComputedStyle(target).ba
[webkit-changes] [287529] trunk
Title: [287529] trunk
Revision 287529
Author r...@igalia.com
Date 2022-01-02 21:52:39 -0800 (Sun, 02 Jan 2022)
Log Message
Access key should work on focusable element.
https://bugs.webkit.org/show_bug.cgi?id=72359
Reviewed by Darin Adler.
Source/WebCore:
Elements that have "accesskey" attribute and are focusable should be focused when you use the access key,
this is happening for some elements but not all.
To fix the issue this patch moves accessKeyAction() implementation from some subclasses to HTMLElement,
which makes us match other browsers.
This patch changes the behavior for HTMLAnchorElement, as it was not focused before, but that matches other browsers too.
Test: fast/dom/accesskey-focus-element.html
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::accessKeyAction): Deleted.
* html/HTMLAnchorElement.h:
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::accessKeyAction): Deleted.
* html/HTMLButtonElement.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::accessKeyAction):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::accessKeyAction): Deleted.
* html/HTMLSelectElement.h:
LayoutTests:
Add new test to check the behavior of accesskey on focusable and not focusable DIV, together with other elements
like INPUT, SELECT and A.
Update expectations for fast/forms/access-key.html test, as now more elements are focused than before.
Apart from that we had to modify accessibility/mac/search-predicate-visited-links.html as that was pressing a link
and the link is now focused.
This will make us also pass css/selectors/focus-visible-024.html from WPT, but that test cannot run properly on WebKit
due to webkit.org/b/234139.
* accessibility/mac/search-predicate-visited-links.html: Update test due to change of behavior.
* fast/dom/accesskey-focus-element-expected.txt: Added.
* fast/dom/accesskey-focus-element.html: Added.
* fast/forms/access-key-expected.txt: Update expectations.
* platform/ios/TestExpectations: Skip new accesskey test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/search-predicate-visited-links.html
trunk/LayoutTests/fast/forms/access-key-expected.txt
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/html/HTMLAnchorElement.h
trunk/Source/WebCore/html/HTMLButtonElement.cpp
trunk/Source/WebCore/html/HTMLButtonElement.h
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.h
Added Paths
trunk/LayoutTests/fast/dom/accesskey-focus-element-expected.txt
trunk/LayoutTests/fast/dom/accesskey-focus-element.html
Diff
Modified: trunk/LayoutTests/ChangeLog (287528 => 287529)
--- trunk/LayoutTests/ChangeLog 2022-01-03 05:40:18 UTC (rev 287528)
+++ trunk/LayoutTests/ChangeLog 2022-01-03 05:52:39 UTC (rev 287529)
@@ -1,3 +1,25 @@
+2022-01-02 Manuel Rego Casasnovas
+
+Access key should work on focusable element.
+https://bugs.webkit.org/show_bug.cgi?id=72359
+
+Reviewed by Darin Adler.
+
+Add new test to check the behavior of accesskey on focusable and not focusable DIV, together with other elements
+like INPUT, SELECT and A.
+Update expectations for fast/forms/access-key.html test, as now more elements are focused than before.
+Apart from that we had to modify accessibility/mac/search-predicate-visited-links.html as that was pressing a link
+and the link is now focused.
+
+This will make us also pass css/selectors/focus-visible-024.html from WPT, but that test cannot run properly on WebKit
+due to webkit.org/b/234139.
+
+* accessibility/mac/search-predicate-visited-links.html: Update test due to change of behavior.
+* fast/dom/accesskey-focus-element-expected.txt: Added.
+* fast/dom/accesskey-focus-element.html: Added.
+* fast/forms/access-key-expected.txt: Update expectations.
+* platform/ios/TestExpectations: Skip new accesskey test.
+
2022-01-02 Diego Pino Garcia
[GTK] Unreviewed test gardening, emit baseline for imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html
Modified: trunk/LayoutTests/accessibility/mac/search-predicate-visited-links.html (287528 => 287529)
--- trunk/LayoutTests/accessibility/mac/search-predicate-visited-links.html 2022-01-03 05:40:18 UTC (rev 287528)
+++ trunk/LayoutTests/accessibility/mac/search-predicate-visited-links.html 2022-01-03 05:52:39 UTC (rev 287529)
@@ -31,7 +31,6 @@
accessibilityController.focusedElement.childAtIndex(0).childAtIndex(0).press();
setTimeout(function() {
-startElement = accessibilityController.focusedElement.childAtIndex(0);
resultElement = containerElement.uiElementForSearchPredicate(startElement, true, "AXVisitedLinkSearchKey", "", false);
should
[webkit-changes] [287469] trunk/LayoutTests
Title: [287469] trunk/LayoutTests
Revision 287469
Author r...@igalia.com
Date 2021-12-28 04:28:33 -0800 (Tue, 28 Dec 2021)
Log Message
[selectors] Import two :focus-visible tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=234720
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
The tests were added in https://github.com/web-platform-tests/wpt/pull/32000
and are related to :focus-visible and accesskey.
They don't work on WebKit due to webkit.org/b/234139, though they work properly on wpt.fyi.
* web-platform-tests/css/selectors/focus-visible-024.html: Added.
* web-platform-tests/css/selectors/focus-visible-025.html: Added.
* web-platform-tests/css/selectors/w3c-import.log:
LayoutTests:
Skip the new imported tests as they fail due to webkit.org/b/234139.
* TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-024.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-025.html
Diff
Modified: trunk/LayoutTests/ChangeLog (287468 => 287469)
--- trunk/LayoutTests/ChangeLog 2021-12-28 10:14:42 UTC (rev 287468)
+++ trunk/LayoutTests/ChangeLog 2021-12-28 12:28:33 UTC (rev 287469)
@@ -1,3 +1,14 @@
+2021-12-28 Manuel Rego Casasnovas
+
+[selectors] Import two :focus-visible tests from WPT
+https://bugs.webkit.org/show_bug.cgi?id=234720
+
+Reviewed by Sergio Villar Senin.
+
+Skip the new imported tests as they fail due to webkit.org/b/234139.
+
+* TestExpectations:
+
2021-12-27 Arcady Goldmints-Orlov
[GLIB] Update test expectations and baselines. Unreviewed test gardening.
Modified: trunk/LayoutTests/TestExpectations (287468 => 287469)
--- trunk/LayoutTests/TestExpectations 2021-12-28 10:14:42 UTC (rev 287468)
+++ trunk/LayoutTests/TestExpectations 2021-12-28 12:28:33 UTC (rev 287469)
@@ -1456,6 +1456,8 @@
webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Skip ]
webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Skip ]
webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Skip ]
+webkit.org/b/234139 imported/w3c/web-platform-tests/css/selectors/focus-visible-024.html [ Skip ]
+webkit.org/b/234139 imported/w3c/web-platform-tests/css/selectors/focus-visible-025.html [ Skip ]
webkit.org/b/217904 imported/w3c/web-platform-tests/css/selectors/is-where-visited.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287468 => 287469)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-28 10:14:42 UTC (rev 287468)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-28 12:28:33 UTC (rev 287469)
@@ -1,3 +1,18 @@
+2021-12-28 Manuel Rego Casasnovas
+
+[selectors] Import two :focus-visible tests from WPT
+https://bugs.webkit.org/show_bug.cgi?id=234720
+
+Reviewed by Sergio Villar Senin.
+
+The tests were added in https://github.com/web-platform-tests/wpt/pull/32000
+and are related to :focus-visible and accesskey.
+They don't work on WebKit due to webkit.org/b/234139, though they work properly on wpt.fyi.
+
+* web-platform-tests/css/selectors/focus-visible-024.html: Added.
+* web-platform-tests/css/selectors/focus-visible-025.html: Added.
+* web-platform-tests/css/selectors/w3c-import.log:
+
2021-12-26 Antti Koivisto
[:has() pseudo-class] Support :disabled and :enabled pseudo-class invalidation
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-024.html (0 => 287469)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-024.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-024.html 2021-12-28 12:28:33 UTC (rev 287469)
@@ -0,0 +1,39 @@
+
+
+CSS Test (Selectors): Element matches :focus-visiblel after accesskey
+
+
+
+ :focus-visible {
+outline: green solid 5px;
+ }
+</style>
+
+<div id="targetA" tabindex="0" accesskey="a">Target A</div>
+<button id="targetB" tabindex="0" accesskey="b">Target B</button>
+<script>
+ // Check that :focus-visible is supported.
+ test_valid_selector(':focus-visible');
+
+ promise_test(async t => {
+await pressAccessKey("a");
+assert_equals(getComputedStyle(
[webkit-changes] [286847] trunk/LayoutTests/imported/w3c
Title: [286847] trunk/LayoutTests/imported/w3c Revision 286847 Author r...@igalia.com Date 2021-12-10 06:07:23 -0800 (Fri, 10 Dec 2021) Log Message [WPT] Import resources/accesskey.js https://bugs.webkit.org/show_bug.cgi?id=234137 Reviewed by Rob Buis. This just imports the changes from this WPT PR: https://github.com/web-platform-tests/wpt/pull/32000 Which will allow to write other WPT tests using pressAccessKey() method. * web-platform-tests/resources/accesskey.js: Added. (pressAccessKey): * web-platform-tests/resources/w3c-import.log: * web-platform-tests/shadow-dom/accesskey.tentative.html: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/resources/w3c-import.log trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/accesskey.tentative.html Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/resources/accesskey.js Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286846 => 286847) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-10 13:51:02 UTC (rev 286846) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-10 14:07:23 UTC (rev 286847) @@ -1,3 +1,20 @@ +2021-12-10 Manuel Rego Casasnovas + +[WPT] Import resources/accesskey.js +https://bugs.webkit.org/show_bug.cgi?id=234137 + +Reviewed by Rob Buis. + +This just imports the changes from this WPT PR: +https://github.com/web-platform-tests/wpt/pull/32000 + +Which will allow to write other WPT tests using pressAccessKey() method. + +* web-platform-tests/resources/accesskey.js: Added. +(pressAccessKey): +* web-platform-tests/resources/w3c-import.log: +* web-platform-tests/shadow-dom/accesskey.tentative.html: + 2021-12-09 Chris Dumez Add basic support for launching a SharedWorker Added: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/accesskey.js (0 => 286847) --- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/accesskey.js (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/accesskey.js 2021-12-10 14:07:23 UTC (rev 286847) @@ -0,0 +1,34 @@ +/* + * Function that sends an accesskey using the proper key combination depending on the browser and OS. + * + * This needs that the test imports the following scripts: + *
[webkit-changes] [286776] trunk
Title: [286776] trunk
Revision 286776
Author r...@igalia.com
Date 2021-12-09 06:03:45 -0800 (Thu, 09 Dec 2021)
Log Message
[selectors] Match :focus-visible on elements
https://bugs.webkit.org/show_bug.cgi?id=233924
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/forms/select-listbox-focusring.html
* dom/Element.cpp:
(WebCore::shouldAlwaysHaveFocusVisibleWhenFocused):
LayoutTests:
* fast/forms/select-listbox-focusring-expected.html: Added.
* fast/forms/select-listbox-focusring.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
Added Paths
trunk/LayoutTests/fast/forms/select-listbox-focusring-expected.html
trunk/LayoutTests/fast/forms/select-listbox-focusring.html
Diff
Modified: trunk/LayoutTests/ChangeLog (286775 => 286776)
--- trunk/LayoutTests/ChangeLog 2021-12-09 13:14:30 UTC (rev 286775)
+++ trunk/LayoutTests/ChangeLog 2021-12-09 14:03:45 UTC (rev 286776)
@@ -1,3 +1,13 @@
+2021-12-09 Manuel Rego Casasnovas
+
+[selectors] Match :focus-visible on elements
+https://bugs.webkit.org/show_bug.cgi?id=233924
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/select-listbox-focusring-expected.html: Added.
+* fast/forms/select-listbox-focusring.html: Added.
+
2021-12-08 Patrick Griffis
CSP: Skip whitespace at beginning of policy header
Added: trunk/LayoutTests/fast/forms/select-listbox-focusring-expected.html (0 => 286776)
--- trunk/LayoutTests/fast/forms/select-listbox-focusring-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/select-listbox-focusring-expected.html 2021-12-09 14:03:45 UTC (rev 286776)
@@ -0,0 +1,22 @@
+
+This test checks that focusing a SELECT element via mouse click, after focusing a previous element via mouse click, the SELECT element shows a focus ring.
+
+
+
+a
+b
+
+
+
+function clickElement(element) {
+if (window.eventSender) {
+eventSender.mouseMoveTo(element.offsetLeft + 5, element.offsetTop + 5);
+eventSender.mouseDown();
+eventSender.mouseUp();
+else {
+instructions.innerHTML = "Click on the element " + element.tagName;
+}
+}
+
+clickElement(select);
+
Added: trunk/LayoutTests/fast/forms/select-listbox-focusring.html (0 => 286776)
--- trunk/LayoutTests/fast/forms/select-listbox-focusring.html (rev 0)
+++ trunk/LayoutTests/fast/forms/select-listbox-focusring.html 2021-12-09 14:03:45 UTC (rev 286776)
@@ -0,0 +1,25 @@
+
+This test checks that focusing a SELECT element via mouse click, after focusing a previous element via mouse click, the SELECT element shows a focus ring.
+
+
+
+a
+b
+
+
+
+function clickElement(element) {
+if (window.eventSender) {
+eventSender.mouseMoveTo(element.offsetLeft + 5, element.offsetTop + 5);
+eventSender.mouseDown();
+eventSender.mouseUp();
+else {
+instructions.innerHTML = "Click on the element " + element.tagName;
+}
+}
+
+target.addEventListener("focus", () => {
+clickElement(select);
+});
+clickElement(target);
+
Modified: trunk/Source/WebCore/ChangeLog (286775 => 286776)
--- trunk/Source/WebCore/ChangeLog 2021-12-09 13:14:30 UTC (rev 286775)
+++ trunk/Source/WebCore/ChangeLog 2021-12-09 14:03:45 UTC (rev 286776)
@@ -1,3 +1,15 @@
+2021-12-09 Manuel Rego Casasnovas
+
+[selectors] Match :focus-visible on elements
+https://bugs.webkit.org/show_bug.cgi?id=233924
+
+Reviewed by Antti Koivisto.
+
+Test: fast/forms/select-listbox-focusring.html
+
+* dom/Element.cpp:
+(WebCore::shouldAlwaysHaveFocusVisibleWhenFocused):
+
2021-12-09 Antti Koivisto
[selectors] Use :focus-visible in the user agent style sheet
Modified: trunk/Source/WebCore/dom/Element.cpp (286775 => 286776)
--- trunk/Source/WebCore/dom/Element.cpp 2021-12-09 13:14:30 UTC (rev 286775)
+++ trunk/Source/WebCore/dom/Element.cpp 2021-12-09 14:03:45 UTC (rev 286776)
@@ -807,7 +807,7 @@
static bool shouldAlwaysHaveFocusVisibleWhenFocused(const Element& element)
{
-return element.isTextField() || element.isContentEditable();
+return element.isTextField() || element.isContentEditable() || is(element);
}
void Element::setFocus(bool flag, FocusVisibility visibility)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286415] trunk
Title: [286415] trunk
Revision 286415
Author r...@igalia.com
Date 2021-12-02 00:06:24 -0800 (Thu, 02 Dec 2021)
Log Message
[selectors] :focus-visible should stop matching after blur
https://bugs.webkit.org/show_bug.cgi?id=233688
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Add new test to check that :focus-visible stop matching after blur.
* web-platform-tests/css/selectors/focus-visible-023-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-023.html: Added.
Source/WebCore:
Move PseudoClassChangeInvalidation for :focus-visible together with the one for :focus,
as we need to keep both flags in sync when computing the invalidations
(it's not possible to have an element that matches :focus-visible but not :focus,
and that was happening before this change).
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-023.html
* dom/Element.cpp:
(WebCore::Element::setFocus): Add PseudoClassChangeInvalidation for :focus-visible change,
and put it in the same scope as the flags changes.
(WebCore::Element::setHasFocusVisible): Remove PseudoClassChangeInvalidation from this method.
* page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent): Use PseudoClassChangeInvalidation for :focus-visible change.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286414 => 286415)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-02 06:27:47 UTC (rev 286414)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-02 08:06:24 UTC (rev 286415)
@@ -1,3 +1,15 @@
+2021-12-02 Manuel Rego Casasnovas
+
+[selectors] :focus-visible should stop matching after blur
+https://bugs.webkit.org/show_bug.cgi?id=233688
+
+Reviewed by Antti Koivisto.
+
+Add new test to check that :focus-visible stop matching after blur.
+
+* web-platform-tests/css/selectors/focus-visible-023-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-023.html: Added.
+
2021-12-01 Chris Dumez
validity.valueMissing should not rely on element's disabled state for inputs of type radio/file/checkbox
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023-expected.txt (0 => 286415)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023-expected.txt 2021-12-02 08:06:24 UTC (rev 286415)
@@ -0,0 +1,5 @@
+Target
+
+PASS ":focus-visible" should be a valid selector
+PASS :focus-visible stop matching after blur
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023.html (0 => 286415)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-023.html 2021-12-02 08:06:24 UTC (rev 286415)
@@ -0,0 +1,33 @@
+
+
+CSS Test (Selectors): Element doesn't match :focus-visiblel after blur
+
+
+ :focus-visible {
+outline: green solid 5px;
+ }
+</style>
+
+<div id="target" tabindex="0">Target</div>
+<script>
+ // Check that :focus-visible is supported.
+ test_valid_selector(':focus-visible');
+
+ async_test(function(t) {
+target.addEventListener("focus", t.step_func(function() {
+ assert_equals(getComputedStyle(target).outlineStyle, "solid", `outline-style for ${target.tagName}#${target.id} should be solid`);
+ assert_equals(getComputedStyle(target).outlineColor, "rgb(0, 128, 0)", `outlineColor for ${target.tagName}#${target.id} should be green`);
+ target.blur();
+}));
+target.addEventListener("blur", t.step_func(function() {
+ assert_equals(getComputedStyle(target).outlineStyle, "none", `outline-style for ${target.tagName}#${target.id} should be none`);
+ t.done();
+}));
+target.focus();
+ }, ":focus-visible stop matching after blur");
+
+
Modified: trunk/Source/WebCore/ChangeLog (286414 => 286415)
--- trunk/Source/WebCore/ChangeLog 2021-12-02 06:27:47 UTC (rev 286414)
+++ trunk/Source/WebCore/ChangeLog 2021-12-02 08:06:24 UTC (rev 286415)
@@ -1,3 +1,24 @@
+2021-12-02 Manuel Rego Casasnovas
+
+[selectors] :focus-visible should stop matching after blur
+https://bugs.webkit.org/show_bug.cgi?id=233688
+
+Reviewed by Antti Koivisto.
+
+Move PseudoClassChangeInvalidation for :focus-visible to
[webkit-changes] [286146] trunk/LayoutTests
Title: [286146] trunk/LayoutTests Revision 286146 Author r...@igalia.com Date 2021-11-24 05:41:00 -0800 (Wed, 24 Nov 2021) Log Message [selectors] Import 2 new :focus-visible tests from WPT https://bugs.webkit.org/show_bug.cgi?id=233446 Reviewed by Antti Koivisto. LayoutTests/imported/w3c: We're slightly tweaking the tests due to bug webkit.org/b/233470. * web-platform-tests/css/selectors/focus-visible-017-2-expected.txt: Added. * web-platform-tests/css/selectors/focus-visible-017-2.html: Added. * web-platform-tests/css/selectors/focus-visible-018-2-expected.txt: Added. * web-platform-tests/css/selectors/focus-visible-018-2.html: Added. * web-platform-tests/css/selectors/w3c-import.log: LayoutTests: * platform/ios/TestExpectations: Skip one test in iOS. * tests-options.json: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/tests-options.json Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017-2-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-018-2-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-018-2.html Diff Modified: trunk/LayoutTests/ChangeLog (286145 => 286146) --- trunk/LayoutTests/ChangeLog 2021-11-24 10:02:19 UTC (rev 286145) +++ trunk/LayoutTests/ChangeLog 2021-11-24 13:41:00 UTC (rev 286146) @@ -1,3 +1,13 @@ +2021-11-24 Manuel Rego Casasnovas + +[selectors] Import 2 new :focus-visible tests from WPT +https://bugs.webkit.org/show_bug.cgi?id=233446 + +Reviewed by Antti Koivisto. + +* platform/ios/TestExpectations: Skip one test in iOS. +* tests-options.json: + 2021-11-23 Carlos Garcia Campos CSP: security policy violation event is always using document as target Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286145 => 286146) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-24 10:02:19 UTC (rev 286145) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-24 13:41:00 UTC (rev 286146) @@ -1,3 +1,18 @@ +2021-11-24 Manuel Rego Casasnovas + +[selectors] Import 2 new :focus-visible tests from WPT +https://bugs.webkit.org/show_bug.cgi?id=233446 + +Reviewed by Antti Koivisto. + +We're slightly tweaking the tests due to bug webkit.org/b/233470. + +* web-platform-tests/css/selectors/focus-visible-017-2-expected.txt: Added. +* web-platform-tests/css/selectors/focus-visible-017-2.html: Added. +* web-platform-tests/css/selectors/focus-visible-018-2-expected.txt: Added. +* web-platform-tests/css/selectors/focus-visible-018-2.html: Added. +* web-platform-tests/css/selectors/w3c-import.log: + 2021-11-23 Carlos Garcia Campos CSP: security policy violation event is always using document as target Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017-2-expected.txt (0 => 286146) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017-2-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017-2-expected.txt 2021-11-24 13:41:00 UTC (rev 286146) @@ -0,0 +1,72 @@ +This test checks that by default, if using _javascript_ to focus an element triggers :focus-visible matching, then the element should show a focus ring with outline-style: auto. + +Focus the following elements with the keyaboard navigation (pressing TAB), if the elements show a focus ring with outline-style: auto, then the test result is SUCCESS. +abbr +address +a bdi +blockquote +code +dd +summary +div +dl +dt +em legend +figcaption +figure +form + label +li +mark +ol +pre + +p + +small s strong sub sup +caption +table +td +time +ul +u + +PASS ":focus-visible" should be a valid selector +PASS By default initial programatic focus matches ':focus-visible', so the element ABBR shows a focus ring with 'outline-style: auto' +PASS By default initial programatic focus matches ':focus-visible', so the element ADDRESS shows a focus ring with 'outline-style: auto' +PASS By default initial programatic focus matches ':focus-visible', so the element BDI shows a focus ring with 'outline-style: auto' +PASS By default initial programatic focus matches ':focus-visible', so the element BLOCKQUOTE shows a focus ring with 'outline-style: auto' +PASS By default initial programatic focus matches ':focus-visible', so the element CODE shows a focus ring with 'outline-style: auto' +PASS By default initial programatic focus matches ':focus-visible', so the element DD shows a focus ring with 'outline-style: auto' +PASS By default initial programatic fo
[webkit-changes] [285567] trunk
Title: [285567] trunk Revision 285567 Author r...@igalia.com Date 2021-11-10 00:38:18 -0800 (Wed, 10 Nov 2021) Log Message Wavy decorations don't cover the whole line length https://bugs.webkit.org/show_bug.cgi?id=232663 Reviewed by Myles C. Maxfield. LayoutTests/imported/w3c: Import WPT tests from https://github.com/web-platform-tests/wpt/pull/31540. * web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001-expected-mismatch.html: Added. * web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html: Added. * web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added. * web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html: Added. * web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added. * web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html: Added. * web-platform-tests/css/css-text-decor/w3c-import.log: Source/WebCore: We have a problem with wavy decorations, because we are only painting whole waves. Which means that, sometimes, the last part of the line is not covered by the wavy decorations. To fix this we're modifying strokeWavyTextDecoration() method. We paint 2 extra waves before and after the line width, and we clip the wavy text decoration to match the line's width. This patch also removes adjustStepToDecorationLength() as the method was wrong (e.g. passing 40px length and 10px step, it'd modify the step to be 10.75px which makes no sense). Apart from that, as we're now clipping the wave to the text line, this adjustment is no longer needed. Tests: imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html * rendering/TextDecorationPainter.cpp: (WebCore::strokeWavyTextDecoration): (WebCore::adjustStepToDecorationLength): Deleted. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/TextDecorationPainter.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285566 => 285567) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-10 08:20:30 UTC (rev 285566) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-10 08:38:18 UTC (rev 285567) @@ -1,3 +1,20 @@ +2021-11-10 Manuel Rego Casasnovas + +Wavy decorations don't cover the whole line length +https://bugs.webkit.org/show_bug.cgi?id=232663 + +Reviewed by Myles C. Maxfield. + +Import WPT tests from https://github.com/web-platform-tests/wpt/pull/31540. + +* web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001-expected-mismatch.html: Added. +* web-platform-tests/css/css-text-decor/text-decoration-line-through-wavy-covers-whole-line-length-001.html: Added. +* web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added. +* web-platform-tests/css/css-text-decor/text-decoration-overline-wavy-covers-whole-line-length-001.html: Added. +* web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001-expected-mismatch.html: Added. +* web-platform-tests/css/css-text-decor/text-decoration-underline-wavy-covers-whole-line-length-001.html: Added. +* web-platform-tests/css/css-text-decor/w3c-import.log: + 2021-11-09 Ben Nham Add support for PushSubscriptionChangeEvent Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/t
[webkit-changes] [285414] trunk
Title: [285414] trunk Revision 285414 Author r...@igalia.com Date 2021-11-08 10:45:48 -0800 (Mon, 08 Nov 2021) Log Message WPT test importer imports rel="mismatch" as the reference https://bugs.webkit.org/show_bug.cgi?id=207175 Reviewed by Jonathan Bedard. LayoutTests/imported/w3c: Re-imported css/css-fonts/standard-font-family-5.html from WPT, so the -expected.html file gets renamed to -expected-mismatch.html. * web-platform-tests/css/css-fonts/standard-font-family-5-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected.html. * web-platform-tests/css/css-fonts/w3c-import.log: Tools: Setting "-expected-mismatch" suffix for references from WPT. * Scripts/webkitpy/w3c/test_importer.py: (TestImporter.find_importable_tests): Adding "-mismatch" suffix as needed. * Scripts/webkitpy/w3c/test_parser.py: (TestParser.analyze_test): Store the reference type in test_info["type"]. * Scripts/webkitpy/w3c/test_parser_unittest.py: (test_analyze_test_reftest_one_mismatch): Add new test cases for the reference type. LayoutTests: css/css-fonts/standard-font-family-5.html stars passing now. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/w3c-import.log trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/w3c/test_importer.py trunk/Tools/Scripts/webkitpy/w3c/test_parser.py trunk/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected-mismatch.html Removed Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected.html Diff Modified: trunk/LayoutTests/ChangeLog (285413 => 285414) --- trunk/LayoutTests/ChangeLog 2021-11-08 18:37:35 UTC (rev 285413) +++ trunk/LayoutTests/ChangeLog 2021-11-08 18:45:48 UTC (rev 285414) @@ -1,3 +1,15 @@ +2021-11-08 Manuel Rego Casasnovas + +WPT test importer imports rel="mismatch" as the reference +https://bugs.webkit.org/show_bug.cgi?id=207175 + + +Reviewed by Jonathan Bedard. + +css/css-fonts/standard-font-family-5.html stars passing now. + +* TestExpectations: + 2021-11-08 Antti Koivisto [CSS Cascade Layers] Support 'revert-layer' value Modified: trunk/LayoutTests/TestExpectations (285413 => 285414) --- trunk/LayoutTests/TestExpectations 2021-11-08 18:37:35 UTC (rev 285413) +++ trunk/LayoutTests/TestExpectations 2021-11-08 18:45:48 UTC (rev 285414) @@ -3573,7 +3573,6 @@ webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-20.html [ ImageOnlyFailure ] webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-3.html [ ImageOnlyFailure ] webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-4.html [ ImageOnlyFailure ] -webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5.html [ ImageOnlyFailure ] webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-6.html [ ImageOnlyFailure ] webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-7.html [ ImageOnlyFailure ] webkit.org/b/206881 imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-8.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285413 => 285414) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-08 18:37:35 UTC (rev 285413) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-08 18:45:48 UTC (rev 285414) @@ -1,3 +1,16 @@ +2021-11-08 Manuel Rego Casasnovas + +WPT test importer imports rel="mismatch" as the reference +https://bugs.webkit.org/show_bug.cgi?id=207175 + + +Reviewed by Jonathan Bedard. + +Re-imported css/css-fonts/standard-font-family-5.html from WPT, so the -expected.html file gets renamed to -expected-mismatch.html. + +* web-platform-tests/css/css-fonts/standard-font-family-5-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected.html. +* web-platform-tests/css/css-fonts/w3c-import.log: + 2021-11-08 Antti Koivisto [CSS Cascade Layers] Support 'revert-layer' value Copied: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected-mismatch.html (from rev 285413, trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected.html) (0 => 285414) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/standard-font-family-5-expected-mismatch.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-t
[webkit-changes] [283866] trunk
Title: [283866] trunk Revision 283866 Author r...@igalia.com Date 2021-10-09 04:47:50 -0700 (Sat, 09 Oct 2021) Log Message Add GitHub account to contributors.json and update expertise field https://bugs.webkit.org/show_bug.cgi?id=231476 Unreviewed. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (283865 => 283866) --- trunk/ChangeLog 2021-10-09 06:48:53 UTC (rev 283865) +++ trunk/ChangeLog 2021-10-09 11:47:50 UTC (rev 283866) @@ -1,3 +1,12 @@ +2021-10-09 Manuel Rego Casasnovas + +Add GitHub account to contributors.json and update expertise field +https://bugs.webkit.org/show_bug.cgi?id=231476 + +Unreviewed. + +* metadata/contributors.json: + 2021-10-08 Joonghun Park Unreviewed. Add github username for Joonghun Park. Modified: trunk/metadata/contributors.json (283865 => 283866) --- trunk/metadata/contributors.json 2021-10-09 06:48:53 UTC (rev 283865) +++ trunk/metadata/contributors.json 2021-10-09 11:47:50 UTC (rev 283866) @@ -4372,7 +4372,8 @@ "emails" : [ "r...@igalia.com" ], - "expertise" : "Layout, CSS, Selection, WebKitGTK port", + "expertise" : "Layout, CSS", + "github" : "mrego", "name" : "Manuel Rego Casasnovas", "nicks" : [ "rego", ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282208] trunk/LayoutTests
-vertical.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-overline.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-vertical-003-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-vertical-003.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-zero-position-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-zero-position.html Diff Modified: trunk/LayoutTests/ChangeLog (282207 => 282208) --- trunk/LayoutTests/ChangeLog 2021-09-09 11:18:52 UTC (rev 282207) +++ trunk/LayoutTests/ChangeLog 2021-09-09 11:26:30 UTC (rev 282208) @@ -1,3 +1,12 @@ +2021-09-09 Manuel Rego Casasnovas + +[css-text-decor] Update WPT test suite +https://bugs.webkit.org/show_bug.cgi?id=230042 + +Reviewed by Rob Buis. + +* TestExpectations: Mark some test failures. + 2021-09-09 Enrique Ocaña González [Gstreamer] timeouts in media/media-source/media-source-has-audio-video.html and media/media-source/media-source-seek-unbuffered.html Modified: trunk/LayoutTests/TestExpectations (282207 => 282208) --- trunk/LayoutTests/TestExpectations 2021-09-09 11:18:52 UTC (rev 282207) +++ trunk/LayoutTests/TestExpectations 2021-09-09 11:26:30 UTC (rev 282208) @@ -3425,6 +3425,8 @@ webkit.org/b/203583 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio-affects-container-width-when-height-changes.html [ Pass Failure ] # wpt css-text-decor failures +webkit.org/b/230041 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-color-selection-001.html [ ImageOnlyFailure ] +webkit.org/b/230041 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-color-selection-pseudo-01.html [ ImageOnlyFailure ] webkit.org/b/203530 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc.html [ ImageOnlyFailure ] webkit.org/b/203531 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-shadow.html [ ImageOnlyFailure ] webkit.org/b/203528 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-linethrough-001.html [ ImageOnlyFailure ] @@ -3433,8 +3435,12 @@ webkit.org/b/203528 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-underline-001.html [ ImageOnlyFailure ] webkit.org/b/203528 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-vertical-001.html [ ImageOnlyFailure ] webkit.org/b/203528 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-vertical-002.html [ ImageOnlyFailure ] +webkit.org/b/203528 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001.html [ ImageOnlyFailure ] +webkit.org/b/203528 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-single.html [ ImageOnlyFailure ] webkit.org/b/203529 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-position-vertical-ja.html [ ImageOnlyFailure ] webkit.org/b/203529 imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-underline-position-vertical.html [ ImageOnlyFailure ] +webkit.org/b/203529 imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-negative.html [ ImageOnlyFailure ] +webkit.org/b/203529 imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-zero-position.html [ ImageOnlyFailure ] # wpt css-position failures webkit.org/b/203445 [ Debug ] imported/w3c/web-platform-tests/css/css-position/position-absolute-container-dynamic-002.html [ Skip ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282207 => 282208) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-09 11:18:52 UTC (rev 282207) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-09 11:26:30 UTC (rev 282208) @@ -1,3 +1,62 @@ +2021-09-09 Manuel Rego Casasnovas + +[css-text-decor] Update WPT test suite +https://bugs.webkit.org/show_bug.cgi?id=230042 + +Import css-text-decor test suite based on WPT commit 5d2020c403. + +Reviewed by Rob Buis. + +* resources/resource-files.json: +* web-platform-tests/css/css-text-decor/invalidation/text-decoration-invalidation-dashed-expected.html: Added. +* web-platform-tests/css/css-text-decor/invalidation/text-decoration-invalidation-dashed.html: Added. +* web-platform-tests/css/css-text-decor/invalidation/text-decoration-invalidation-double-expected.html: Added. +* web-platform-tests/css/css-text-decor/invalidation/text-decoration-invalidation-double.html: Added. +* web-platform-tests/css/css-text-decor/invalidation/text-decoration-invalidation-solid-expected.html: Added. +* web-platform-tests/css/css-text-decor/invalidation/text-decoration-invalidation-solid.html: Added. +* web-platform-tests/css
[webkit-changes] [282158] trunk/Source/WebCore
Title: [282158] trunk/Source/WebCore
Revision 282158
Author r...@igalia.com
Date 2021-09-08 10:49:56 -0700 (Wed, 08 Sep 2021)
Log Message
[css-text-decor] text-decoration-* properties are no longer experimental
https://bugs.webkit.org/show_bug.cgi?id=230039
Reviewed by Simon Fraser.
* css/CSSProperties.json: Remove experimental status from text-decoration-* properties.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperties.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (282157 => 282158)
--- trunk/Source/WebCore/ChangeLog 2021-09-08 17:30:57 UTC (rev 282157)
+++ trunk/Source/WebCore/ChangeLog 2021-09-08 17:49:56 UTC (rev 282158)
@@ -1,3 +1,12 @@
+2021-09-08 Manuel Rego Casasnovas
+
+[css-text-decor] text-decoration-* properties are no longer experimental
+https://bugs.webkit.org/show_bug.cgi?id=230039
+
+Reviewed by Simon Fraser.
+
+* css/CSSProperties.json: Remove experimental status from text-decoration-* properties.
+
2021-09-08 Antti Koivisto
[LFC][Integration] Hovering over link switches to legacy inline boxes
Modified: trunk/Source/WebCore/css/CSSProperties.json (282157 => 282158)
--- trunk/Source/WebCore/css/CSSProperties.json 2021-09-08 17:30:57 UTC (rev 282157)
+++ trunk/Source/WebCore/css/CSSProperties.json 2021-09-08 17:49:56 UTC (rev 282158)
@@ -6695,9 +6695,6 @@
"-webkit-text-decoration-line"
]
},
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-3/#text-decoration-line"
@@ -6716,9 +6713,6 @@
"dashed",
"wavy"
],
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-3/#text-decoration-style"
@@ -6733,9 +6727,6 @@
"visited-link-color-support": true,
"color-property": true
},
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-3/#text-decoration-color"
@@ -6749,9 +6740,6 @@
"-webkit-text-decoration-skip"
]
},
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-3/#text-decoration-skip"
@@ -6764,9 +6752,6 @@
]
},
"inherited": true,
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-3/#text-underline-position-property"
@@ -6777,9 +6762,6 @@
"codegen-properties": {
"converter": "TextUnderlineOffset"
},
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-4/#underline-offset"
@@ -6790,9 +6772,6 @@
"codegen-properties": {
"converter": "TextDecorationThickness"
},
-"status": {
-"status": "experimental"
-},
"specification": {
"category": "css-text-decor",
"url": "https://www.w3.org/TR/css-text-decor-4/#text-decoration-thickness"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279981] trunk/PerformanceTests
Title: [279981] trunk/PerformanceTests
Revision 279981
Author r...@igalia.com
Date 2021-07-16 01:32:18 -0700 (Fri, 16 Jul 2021)
Log Message
Remove CSS Regions perf tests
https://bugs.webkit.org/show_bug.cgi?id=228016
Reviewed by Ryosuke Niwa.
The feature has been removed long time ago, so let's do the same with the associated perf tests.
* Layout/RegionsAuto.html: Removed.
* Layout/RegionsAutoMaxHeight.html: Removed.
* Layout/RegionsExtendingSelectionMixedContent.html: Removed.
* Layout/RegionsFixed.html: Removed.
* Layout/RegionsFixedShort.html: Removed.
* Layout/RegionsSelectAllMixedContent.html: Removed.
* Layout/RegionsSelection.html: Removed.
* Layout/RegionsShapes.html: Removed.
* Layout/Shapes/RegionsShapesNoShapes.html: Removed.
* Layout/Shapes/resources/RegionsShapesContent.html: Removed.
* Layout/Shapes/resources/RegionsShapesContentNoShapes.html: Removed.
* Layout/resources/regions.css: Removed.
* Layout/resources/regions.js: Removed.
Modified Paths
trunk/PerformanceTests/ChangeLog
Removed Paths
trunk/PerformanceTests/Layout/RegionsAuto.html
trunk/PerformanceTests/Layout/RegionsAutoMaxHeight.html
trunk/PerformanceTests/Layout/RegionsExtendingSelectionMixedContent.html
trunk/PerformanceTests/Layout/RegionsFixed.html
trunk/PerformanceTests/Layout/RegionsFixedShort.html
trunk/PerformanceTests/Layout/RegionsSelectAllMixedContent.html
trunk/PerformanceTests/Layout/RegionsSelection.html
trunk/PerformanceTests/Layout/RegionsShapes.html
trunk/PerformanceTests/Layout/Shapes/RegionsShapesNoShapes.html
trunk/PerformanceTests/Layout/Shapes/resources/RegionsShapesContent.html
trunk/PerformanceTests/Layout/Shapes/resources/RegionsShapesContentNoShapes.html
trunk/PerformanceTests/Layout/resources/regions.css
trunk/PerformanceTests/Layout/resources/regions.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (279980 => 279981)
--- trunk/PerformanceTests/ChangeLog 2021-07-16 07:19:05 UTC (rev 279980)
+++ trunk/PerformanceTests/ChangeLog 2021-07-16 08:32:18 UTC (rev 279981)
@@ -1,3 +1,26 @@
+2021-07-16 Manuel Rego Casasnovas
+
+Remove CSS Regions perf tests
+https://bugs.webkit.org/show_bug.cgi?id=228016
+
+Reviewed by Ryosuke Niwa.
+
+The feature has been removed long time ago, so let's do the same with the associated perf tests.
+
+* Layout/RegionsAuto.html: Removed.
+* Layout/RegionsAutoMaxHeight.html: Removed.
+* Layout/RegionsExtendingSelectionMixedContent.html: Removed.
+* Layout/RegionsFixed.html: Removed.
+* Layout/RegionsFixedShort.html: Removed.
+* Layout/RegionsSelectAllMixedContent.html: Removed.
+* Layout/RegionsSelection.html: Removed.
+* Layout/RegionsShapes.html: Removed.
+* Layout/Shapes/RegionsShapesNoShapes.html: Removed.
+* Layout/Shapes/resources/RegionsShapesContent.html: Removed.
+* Layout/Shapes/resources/RegionsShapesContentNoShapes.html: Removed.
+* Layout/resources/regions.css: Removed.
+* Layout/resources/regions.js: Removed.
+
2021-06-03 Said Abou-Hallawa
[MotionMark] Controller.filterOutOutliers() sorts the frameLengths array incorrectly
Deleted: trunk/PerformanceTests/Layout/RegionsAuto.html (279980 => 279981)
--- trunk/PerformanceTests/Layout/RegionsAuto.html 2021-07-16 07:19:05 UTC (rev 279980)
+++ trunk/PerformanceTests/Layout/RegionsAuto.html 2021-07-16 08:32:18 UTC (rev 279981)
@@ -1,19 +0,0 @@
-
-
-
-
-
-#log {
-position: fixed;
-}
-</style>
-</head>
-<body>
-<pre id="log"></pre>
-<script>
-PerfTestRunner.measureTime(createRegionsTest("300px", "auto", 400, 400, "auto", 0.8));
-
-
-
Deleted: trunk/PerformanceTests/Layout/RegionsAutoMaxHeight.html (279980 => 279981)
--- trunk/PerformanceTests/Layout/RegionsAutoMaxHeight.html 2021-07-16 07:19:05 UTC (rev 279980)
+++ trunk/PerformanceTests/Layout/RegionsAutoMaxHeight.html 2021-07-16 08:32:18 UTC (rev 279981)
@@ -1,19 +0,0 @@
-
-
-
-
-
-#log {
-position: fixed;
-}
-</style>
-</head>
-<body>
-<pre id="log"></pre>
-<script>
-PerfTestRunner.measureTime(createRegionsTest("300px", "auto", 1200, 400, "200px", 0.5));
-
-
-
Deleted: trunk/PerformanceTests/Layout/RegionsExtendingSelectionMixedContent.html (279980 => 279981)
--- trunk/PerformanceTests/Layout/RegionsExtendingSelectionMixedContent.html 2021-07-16 07:19:05 UTC (rev 279980)
+++ trunk/PerformanceTests/Layout/RegionsExtendingSelectionMixedContent.html 2021-07-16 08:32:18 UTC (rev 279981)
@@ -1,59 +0,0 @@
-
-
-
-
-
-#log {
-position: fixed;
-}
-<
[webkit-changes] [276698] trunk
Title: [276698] trunk
Revision 276698
Author r...@igalia.com
Date 2021-04-28 01:51:37 -0700 (Wed, 28 Apr 2021)
Log Message
[selectors] Using a modifier key on an element makes it stop matching :focus-visible
https://bugs.webkit.org/show_bug.cgi?id=225075
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
* web-platform-tests/css/selectors/focus-visible-021-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-021.html: Added.
Source/WebCore:
When we used a modifier key on a element that was matching :focus-visible, we stopped matching :focus-visible.
That was wrong, we shouldn't just start matching :focus-visible when a modifier key is used but not the other way around.
This patches fixed that without doing any work if the element is already matching :focus-visible when the user type a key.
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-021.html
* dom/Element.cpp:
(WebCore::shouldAlwaysHaveFocusVisibleWhenFocused): Helper method for inputs and content editable elements.
(WebCore::Element::setFocus): Use the new helper method.
(WebCore::Element::setHasFocusVisible): Add asserts to avoid setting/unsetting :focus-visible flag wrongly.
* dom/Node.cpp:
(WebCore::Node::isContentEditable const): Just mark as const.
(WebCore::Node::isContentRichlyEditable const): Ditto.
* dom/Node.h: Ditto.
* page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent): Don't do anything regarding :focus-visible flag if the element already matches :focus-visible.
LayoutTests:
* platform/ios/TestExpectations: Skip new test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021.html
Diff
Modified: trunk/LayoutTests/ChangeLog (276697 => 276698)
--- trunk/LayoutTests/ChangeLog 2021-04-28 08:39:01 UTC (rev 276697)
+++ trunk/LayoutTests/ChangeLog 2021-04-28 08:51:37 UTC (rev 276698)
@@ -1,3 +1,12 @@
+2021-04-28 Manuel Rego Casasnovas
+
+[selectors] Using a modifier key on an element makes it stop matching :focus-visible
+https://bugs.webkit.org/show_bug.cgi?id=225075
+
+Reviewed by Ryosuke Niwa.
+
+* platform/ios/TestExpectations: Skip new test.
+
2021-04-28 Cameron McCormack
Fix some test typos.
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (276697 => 276698)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-28 08:39:01 UTC (rev 276697)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-28 08:51:37 UTC (rev 276698)
@@ -1,3 +1,13 @@
+2021-04-28 Manuel Rego Casasnovas
+
+[selectors] Using a modifier key on an element makes it stop matching :focus-visible
+https://bugs.webkit.org/show_bug.cgi?id=225075
+
+Reviewed by Ryosuke Niwa.
+
+* web-platform-tests/css/selectors/focus-visible-021-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-021.html: Added.
+
2021-04-28 Cameron McCormack
Make img elements perform source selection even when not in the document.
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021-expected.txt (0 => 276698)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021-expected.txt 2021-04-28 08:51:37 UTC (rev 276698)
@@ -0,0 +1,9 @@
+This test checks that using a modifier key does not make the element to stop matching :focus-visible.
+If the element that says "Focused" has a red background, then the test result is a FAILURE.
+Press the Ctrl key.
+If the element keeps the green outline and has not a red background, then the test result is SUCCESS.
+Focused
+
+PASS ":focus-visible" should be a valid selector
+PASS Ctrl key doesn't make an element to stop matching :focus-visible
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021.html (0 => 276698)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-021.html 2021-04-28 08:51:37 UTC (rev 276698)
@@ -0,0 +1,67 @@
+
+
+CSS Test (Selectors): Modifier key doesn't make element to stop matching :focus-visible
+
+
+ #warning {
+display: none;
+background: red;
+ }
+
+ @supports not selector(:focus-visible) {
+#instructions {
+ display: none;
+}
+
+#warning {
+ display: block;
[webkit-changes] [276628] trunk
Title: [276628] trunk
Revision 276628
Author r...@igalia.com
Date 2021-04-26 22:44:59 -0700 (Mon, 26 Apr 2021)
Log Message
REGRESSION (r276264): Reproducible crash in WebCore::UserActionElementSet::clearFlags
https://bugs.webkit.org/show_bug.cgi?id=224957
Reviewed by Ryosuke Niwa.
Source/WebCore:
The crash was due to a problem with the focus and focus-visible flags getting out of sync.
The problem was related to how we deal we script focus in Element::focus(),
we were setting the focus-visible flag before doing focus,
and if the element was moved to a different document in that process,
we were resetting the flag for the same element, but pointing to the new document.
So the old document still kept information about the element and the flag, and it shouldn't.
This patch is based on a patch by Ryosuke Niwa .
The approach to solve the issue is to consolidate the timing for both focus and focus-visible flags
so they don't get out of sync.
For that we add a new FocusVisibility enum to FocusOptions, and we pass it to Element::setFocus()
and use it to pass a different value to Element::setHasFocusVisible().
Test: fast/selectors/focus-visible-crash.html
* dom/Document.cpp:
(WebCore::Document::setFocusedElement):
* dom/Element.cpp:
(WebCore::Element::setFocus):
(WebCore::Element::focus):
* dom/Element.h:
* dom/FocusOptions.h:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setFocus):
* html/HTMLAreaElement.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setFocus):
* html/HTMLFrameElementBase.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
* page/FrameView.cpp:
(WebCore::FrameView::scrollToFragmentInternal):
LayoutTests:
* fast/selectors/focus-visible-crash-expected.txt: Added.
* fast/selectors/focus-visible-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/FocusOptions.h
trunk/Source/WebCore/html/HTMLAreaElement.cpp
trunk/Source/WebCore/html/HTMLAreaElement.h
trunk/Source/WebCore/html/HTMLFrameElementBase.cpp
trunk/Source/WebCore/html/HTMLFrameElementBase.h
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/FocusController.cpp
trunk/Source/WebCore/page/FrameView.cpp
Added Paths
trunk/LayoutTests/fast/selectors/focus-visible-crash-expected.txt
trunk/LayoutTests/fast/selectors/focus-visible-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (276627 => 276628)
--- trunk/LayoutTests/ChangeLog 2021-04-27 05:31:07 UTC (rev 276627)
+++ trunk/LayoutTests/ChangeLog 2021-04-27 05:44:59 UTC (rev 276628)
@@ -1,3 +1,13 @@
+2021-04-26 Manuel Rego Casasnovas
+
+REGRESSION (r276264): Reproducible crash in WebCore::UserActionElementSet::clearFlags
+https://bugs.webkit.org/show_bug.cgi?id=224957
+
+Reviewed by Ryosuke Niwa.
+
+* fast/selectors/focus-visible-crash-expected.txt: Added.
+* fast/selectors/focus-visible-crash.html: Added.
+
2021-04-26 Tim Nguyen
Create a containing block when relevant properties are set in the current element will-change
Added: trunk/LayoutTests/fast/selectors/focus-visible-crash-expected.txt (0 => 276628)
--- trunk/LayoutTests/fast/selectors/focus-visible-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/selectors/focus-visible-crash-expected.txt 2021-04-27 05:44:59 UTC (rev 276628)
@@ -0,0 +1,3 @@
+This test verifies that moving an element to a different document during blur doesn't crash (see bug #224957).
+
+initial
Added: trunk/LayoutTests/fast/selectors/focus-visible-crash.html (0 => 276628)
--- trunk/LayoutTests/fast/selectors/focus-visible-crash.html (rev 0)
+++ trunk/LayoutTests/fast/selectors/focus-visible-crash.html 2021-04-27 05:44:59 UTC (rev 276628)
@@ -0,0 +1,18 @@
+
+This test verifies that moving an element to a different document during blur doesn't crash (see ).
+
+initial
+target
+
+
+
+ if (window.testRunner)
+testRunner.dumpAsText();
+
+ initial.addEventListener("blur", () => {
+iframe.contentDocument.body.appendChild(target);
+ });
+ initial.focus();
+ target.focus();
+ iframe.remove();
+
Modified: trunk/Source/WebCore/ChangeLog (276627 => 276628)
--- trunk/Source/WebCore/ChangeLog 2021-04-27 05:31:07 UTC (rev 276627)
+++ trunk/Source/WebCore/ChangeLog 2021-04-27 05:44:59 UTC (rev 276628)
@@ -1,3 +1,45 @@
+2021-04-26 Manuel Rego Casasnovas
+
+REGRESSION (r276264): Reproducible crash in WebCore::UserActionElementSet::clearFlags
+https://bugs.webkit.org/show_bug.cgi?id=224957
+
+Reviewed by Ryosuke Niwa.
+
+The crash was due to a problem with the focus and focus-visible flags getting out of sync.
+The problem was related to ho
[webkit-changes] [276350] trunk/LayoutTests/imported/w3c
Title: [276350] trunk/LayoutTests/imported/w3c
Revision 276350
Author r...@igalia.com
Date 2021-04-21 00:33:17 -0700 (Wed, 21 Apr 2021)
Log Message
[selectors] Import one more :focus-visible WPT test
https://bugs.webkit.org/show_bug.cgi?id=224827
Reviewed by Rob Buis.
* web-platform-tests/css/selectors/focus-visible-020-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-020.html: Added.
* web-platform-tests/css/selectors/w3c-import.log:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (276349 => 276350)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-21 07:33:00 UTC (rev 276349)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-21 07:33:17 UTC (rev 276350)
@@ -1,3 +1,14 @@
+2021-04-21 Manuel Rego Casasnovas
+
+[selectors] Import one more :focus-visible WPT test
+https://bugs.webkit.org/show_bug.cgi?id=224827
+
+Reviewed by Rob Buis.
+
+* web-platform-tests/css/selectors/focus-visible-020-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-020.html: Added.
+* web-platform-tests/css/selectors/w3c-import.log:
+
2021-04-20 Cathie Chen
Update html/rendering/replaced-elements/attributes-for-embedded-content-and-images/ tests from WPT
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020-expected.txt (0 => 276350)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020-expected.txt 2021-04-21 07:33:17 UTC (rev 276350)
@@ -0,0 +1,8 @@
+This test checks that :focus-visible doesn't math on ShadowRoot.
+
+The input should be focused on load, if it's not focused, focus it via mouse or keyboard.
+If you see no red the test result is SUCCESS.
+
+PASS ":focus-visible" should be a valid selector
+PASS :focus-visible doesn't match on ShadowRoot
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020.html (0 => 276350)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-020.html 2021-04-21 07:33:17 UTC (rev 276350)
@@ -0,0 +1,61 @@
+
+
+CSS Test (Selectors): :focus-visible doesn't match on ShadowRoot
+
+
+ #warning {
+display: none;
+background: red;
+ }
+
+ @supports not selector(:focus-visible) {
+#instructions {
+ display: none;
+}
+
+#warning {
+ display: block;
+}
+ }
+
+ #host:focus-visible {
+outline: 0;
+background-color: red;
+ }
+</style>
+
+<p>This test checks that <code>:focus-visible</code> doesn't math on ShadowRoot.</p>
+<ol id="instructions">
+ <li>The input should be focused on load, if it's not focused, focus it via mouse or keyboard.</li>
+ <li>If you see no red the test result is SUCCESS.</li>
+</ol>
+<p id="warning">Your user-agent does not support <code>:focus-visible</code> pseudo-class, please SKIP this test.</p>
+
+<div id="host" style="height: 100px;"></div>
+
+<script>
+ const shadowRoot = host.attachShadow({mode: 'open', delegatesFocus: true});
+ shadowRoot.innerHTML = '<input id="target" autofocus value="Focus me">';
+
+ // Check that :focus-visible is supported.
+ test_valid_selector(':focus-visible');
+
+ async_test((t) => {
+window.requestAnimationFrame(t.step_func_done(() => {
+ assert_not_equals(getComputedStyle(host).backgroundColor, "rgb(255, 0, 0)", `backgroundColor for ${host.tagName}#${host.id} should NOT be red`);
+
+ let focusVisiblePseudoAll = document.querySelectorAll(':focus-visible');
+ assert_equals(focusVisiblePseudoAll.length, 0, "No element matches ':focus-visible'");
+
+ let focusVisibleShadowDOMPseudoAll = shadowRoot.querySelectorAll(':focus-visible');
+ assert_equals(focusVisibleShadowDOMPseudoAll.length, 1, "Only one element matches ':focus-visible' in the Shadow DOM");
+
+ let target = shadowRoot.getElementById("target");
+ assert_equals(target, focusVisibleShadowDOMPseudoAll[0], "${target.tagName}#${target.id} matches ':focus-visible'");
+}));
+ }, ":focus-visible doesn't match on ShadowRoot");
+
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3
[webkit-changes] [276297] trunk/LayoutTests
Title: [276297] trunk/LayoutTests Revision 276297 Author r...@igalia.com Date 2021-04-20 03:24:08 -0700 (Tue, 20 Apr 2021) Log Message [WPE] Update expectations for 2 :focus-visible tests https://bugs.webkit.org/show_bug.cgi?id=224808 Unreviewed test gardening. The failures on these tests are related to the lack of support for in WPE. * platform/wpe/TestExpectations: * platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wpe/TestExpectations Added Paths trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (276296 => 276297) --- trunk/LayoutTests/ChangeLog 2021-04-20 10:19:21 UTC (rev 276296) +++ trunk/LayoutTests/ChangeLog 2021-04-20 10:24:08 UTC (rev 276297) @@ -1,3 +1,16 @@ +2021-04-20 Manuel Rego Casasnovas + +[WPE] Update expectations for 2 :focus-visible tests +https://bugs.webkit.org/show_bug.cgi?id=224808 + +Unreviewed test gardening. + +The failures on these tests are related to the lack of support for in WPE. + +* platform/wpe/TestExpectations: +* platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt: Added. + 2021-04-20 Cathie Chen Update html/rendering/replaced-elements/attributes-for-embedded-content-and-images/ tests from WPT Modified: trunk/LayoutTests/platform/wpe/TestExpectations (276296 => 276297) --- trunk/LayoutTests/platform/wpe/TestExpectations 2021-04-20 10:19:21 UTC (rev 276296) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-04-20 10:24:08 UTC (rev 276297) @@ -1463,10 +1463,6 @@ Bug(WPE) media/media-playback-page-visibility.html [ Timeout ] Bug(WPE) media/video-canvas-createPattern.html [ Failure ] -# Failing after r273812. -webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Failure ] -webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Failure ] - # # UNSORTED Expectations. When in doubt, put it here. # Added: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt (0 => 276297) --- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt (rev 0) +++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt 2021-04-20 10:24:08 UTC (rev 276297) @@ -0,0 +1,32 @@ +This test checks that :focus-visible is not triggered by mouse focus on elements which do not take text input. +If the user-agent does not claim to support the :focus-visible pseudo-class then SKIP this test. +Click each element element below to focus it. +If the element has a red outline, then the test result is FAILURE. If the element has a green background, then the test result is SUCCESS. + +Focus me +Focus me +Focus me +Focus me + + + + + Focus me. + Focus me. + + Focus me. + Focus me. + +PASS Focus element SPAN#el-1 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element SPAN#el-2 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element SPAN#el-3 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element BUTTON#el-4 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-5 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-6 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-7 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-8 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-9 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-10 via mouse should NOT match :focus-visible as it does NOT support keyboard input +PASS Focus element INPUT#el-12 via mouse should NOT match :focus-visible as it does NOT support keyboard input +FAIL Focus element INPUT#el-13 via mouse should NOT mat
[webkit-changes] [276264] trunk
ectors/focus-visible-script-focus-014-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-015-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-016.tentative-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-017.tentative-expected.txt trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/FocusOptions.h trunk/Source/WebCore/page/EventHandler.cpp Removed Paths trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (276263 => 276264) --- trunk/LayoutTests/ChangeLog 2021-04-19 17:53:04 UTC (rev 276263) +++ trunk/LayoutTests/ChangeLog 2021-04-19 17:59:26 UTC (rev 276264) @@ -1,3 +1,16 @@ +2021-04-19 Manuel Rego Casasnovas + +[selectors] Script focus and :focus-visible +https://bugs.webkit.org/show_bug.cgi?id=224598 + +Reviewed by Darin Adler. + +Update expectations for tests, most of them are passing on Mac. On iOS a bunch timeout so they're skipped, as other :focus-visible tests. + +* platform/ios/TestExpectations: +* platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt: Removed as test passes now. +* platform/mac/TestExpectations: + 2021-04-19 Darin Adler Nullptr crash in CSSCalcValue::category() via HTMLConverterCaches::floatPropertyValueForNode Modified: trunk/LayoutTests/imported/w3c/ChangeLog (276263 => 276264) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-19 17:53:04 UTC (rev 276263) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-19 17:59:26 UTC (rev 276264) @@ -1,3 +1,30 @@ +2021-04-19 Manuel Rego Casasnovas + +[selectors] Script focus and :focus-visible +https://bugs.webkit.org/show_bug.cgi?id=224598 + +Reviewed by Darin Adler. + +Update expectations as the tests pass now. + +* web-platform-tests/css/selectors/focus-visible-008-expected.txt: +* web-platform-tests/css/selectors/focus-visible-009-expected.txt: +* web-platform-tests/css/selectors/focus-visible-010-expected.txt: +* web-platform-tests/css/selectors/focus-visible-014-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-001-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-002.tentative-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-003.tentative-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-004-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-005-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-006.tentative-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-007.tentative-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-012-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-013-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-014-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-015-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-016.tentative-expected.txt: +* web-platform-tests/css/selectors/focus-visible-script-focus-017.tentative-expected.txt: + 2021-04-19 Darin Adler Nullptr crash in CSSCalcValue::category() via HTMLConverterCaches::floatPropertyValueForNode Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt (276263 => 276264) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt 2021-04-19 17:53:04 UTC (rev 276263) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt 2021-04-19 17:59:26 UTC (rev 276264) @@ -6,5 +6,5 @@ Tab to me and press ENTER. I will be focused programmatically. -FAIL Programmatic focus after keypress should match :focus-visible assert_equals: outlineColor for DIV#el should be green expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)" +PASS Programmatic focus after keypress should match :focus-visible Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt (276263 => 276264) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt 2021-04-19 17:53:04 UTC (rev 276263) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-
[webkit-changes] [276237] trunk/LayoutTests
Title: [276237] trunk/LayoutTests Revision 276237 Author r...@igalia.com Date 2021-04-18 23:57:16 -0700 (Sun, 18 Apr 2021) Log Message [selectors] Update :focus-visible tests from WPT https://bugs.webkit.org/show_bug.cgi?id=224601 Reviewed by Darin Adler. LayoutTests/imported/w3c: Fix expectations that were broken due to a mistake in the previous commit. The tests had some extra changes due to webkit.org/224658, the tests were modified but not the expectations. * web-platform-tests/css/selectors/focus-visible-002-expected.txt: * web-platform-tests/css/selectors/focus-visible-003-expected.txt: * web-platform-tests/css/selectors/focus-visible-004-expected.txt: LayoutTests: Remove glib expectations as they match the main ones. * platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt: Removed. * platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt: Removed. * platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt Removed Paths trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/selectors/ Diff Modified: trunk/LayoutTests/ChangeLog (276236 => 276237) --- trunk/LayoutTests/ChangeLog 2021-04-19 06:32:12 UTC (rev 276236) +++ trunk/LayoutTests/ChangeLog 2021-04-19 06:57:16 UTC (rev 276237) @@ -1,3 +1,17 @@ +2021-04-18 Manuel Rego Casasnovas + +[selectors] Update :focus-visible tests from WPT +https://bugs.webkit.org/show_bug.cgi?id=224601 + + +Reviewed by Darin Adler. + +Remove glib expectations as they match the main ones. + +* platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt: Removed. +* platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt: Removed. +* platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt: Removed. + 2021-04-18 Wenson Hsieh Selected image overlay text should never be visible Modified: trunk/LayoutTests/imported/w3c/ChangeLog (276236 => 276237) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-19 06:32:12 UTC (rev 276236) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-19 06:57:16 UTC (rev 276237) @@ -1,3 +1,18 @@ +2021-04-18 Manuel Rego Casasnovas + +[selectors] Update :focus-visible tests from WPT +https://bugs.webkit.org/show_bug.cgi?id=224601 + + +Reviewed by Darin Adler. + +Fix expectations that were broken due to a mistake in the previous commit. +The tests had some extra changes due to webkit.org/224658, the tests were modified but not the expectations. + +* web-platform-tests/css/selectors/focus-visible-002-expected.txt: +* web-platform-tests/css/selectors/focus-visible-003-expected.txt: +* web-platform-tests/css/selectors/focus-visible-004-expected.txt: + 2021-04-18 Antoine Quint Fix interpolation of the rotate CSS property Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt (276236 => 276237) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt 2021-04-19 06:32:12 UTC (rev 276236) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt 2021-04-19 06:57:16 UTC (rev 276237) @@ -1,4 +1,4 @@ -This test checks that :focus-visible always matches on elements which take text input, regardless of focus mechanism. +This test checks that :focus-visible always matches on elements which take text input, regardless of focus mechanism. If the user-agent does not claim to support the :focus-visible pseudo-class then SKIP this test. Click each form element below to focus it. If the element has a red background, then the test result is FAILURE. If the element has a green outline, then the test result is SUCCESS. Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt (276236 => 276237) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt 2021-04-19 06:32:12 UTC (rev 276236) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt 2021-04-19 06:57:16 UTC (rev 276237) @@ -1,4 +1,4 @@ -This test checks that :focus-visible is not triggered by mouse focus on elements which do not take text input. +This test checks that :focus-visible is not triggered by mouse focus on elements which do not tak
[webkit-changes] [276128] trunk/Tools
Title: [276128] trunk/Tools Revision 276128 Author r...@igalia.com Date 2021-04-16 02:04:23 -0700 (Fri, 16 Apr 2021) Log Message Avoid converting HTML chars in _W3CTestConverter https://bugs.webkit.org/show_bug.cgi?id=224658 Reviewed by Adrian Perez de Castro. There has been a change in Python HTMLParser in version 3.5 that makes convert_charrefs to be True by default: https://docs.python.org/3/library/html.parser.html This is causing that we're modifying the tests that have HTML characters, which is something we shouldn't change and was not happening in previous Python 3 versions, or Python 2. * Scripts/webkitpy/w3c/test_converter.py: (_W3CTestConverter.__init__): Set convert_charrefs to False. * Scripts/webkitpy/w3c/test_converter_unittest.py: Update test to include HTML chars and check that they're not modified. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/w3c/test_converter.py trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py Diff Modified: trunk/Tools/ChangeLog (276127 => 276128) --- trunk/Tools/ChangeLog 2021-04-16 08:53:33 UTC (rev 276127) +++ trunk/Tools/ChangeLog 2021-04-16 09:04:23 UTC (rev 276128) @@ -1,3 +1,20 @@ +2021-04-16 Manuel Rego Casasnovas + +Avoid converting HTML chars in _W3CTestConverter +https://bugs.webkit.org/show_bug.cgi?id=224658 + +Reviewed by Adrian Perez de Castro. + +There has been a change in Python HTMLParser in version 3.5 that makes convert_charrefs to be True by default: +https://docs.python.org/3/library/html.parser.html + +This is causing that we're modifying the tests that have HTML characters, which is something +we shouldn't change and was not happening in previous Python 3 versions, or Python 2. + +* Scripts/webkitpy/w3c/test_converter.py: +(_W3CTestConverter.__init__): Set convert_charrefs to False. +* Scripts/webkitpy/w3c/test_converter_unittest.py: Update test to include HTML chars and check that they're not modified. + 2021-04-16 Youenn Fablet Promote WKWebView device orientation permission delegate to API Modified: trunk/Tools/Scripts/webkitpy/w3c/test_converter.py (276127 => 276128) --- trunk/Tools/Scripts/webkitpy/w3c/test_converter.py 2021-04-16 08:53:33 UTC (rev 276127) +++ trunk/Tools/Scripts/webkitpy/w3c/test_converter.py 2021-04-16 09:04:23 UTC (rev 276128) @@ -66,7 +66,10 @@ class _W3CTestConverter(HTMLParser): def __init__(self, new_path, filename, reference_support_info, host=Host(), convert_test_harness_links=True, webkit_test_runner_options=''): -HTMLParser.__init__(self) +if sys.version_info > (3, 0): +HTMLParser.__init__(self, convert_charrefs=False) +else: +HTMLParser.__init__(self) self._host = host self._filesystem = self._host.filesystem Modified: trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py (276127 => 276128) --- trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py 2021-04-16 08:53:33 UTC (rev 276127) +++ trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py 2021-04-16 09:04:23 UTC (rev 276128) @@ -80,6 +80,7 @@ CONTENT OF TEST +We shouldn't convert HTML characters. """ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276077] trunk/Source/WebCore
Title: [276077] trunk/Source/WebCore
Revision 276077
Author r...@igalia.com
Date 2021-04-15 15:27:48 -0700 (Thu, 15 Apr 2021)
Log Message
Move FocusRemovalEventsMode into FocusOptions
https://bugs.webkit.org/show_bug.cgi?id=224549
Reviewed by Darin Adler.
Follow-up patch to use braces initializer for FocusOptions struct and simplify the code.
* dom/Document.cpp:
(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276076 => 276077)
--- trunk/Source/WebCore/ChangeLog 2021-04-15 22:09:14 UTC (rev 276076)
+++ trunk/Source/WebCore/ChangeLog 2021-04-15 22:27:48 UTC (rev 276077)
@@ -1,3 +1,16 @@
+2021-04-15 Manuel Rego Casasnovas
+
+Move FocusRemovalEventsMode into FocusOptions
+https://bugs.webkit.org/show_bug.cgi?id=224549
+
+
+Reviewed by Darin Adler.
+
+Follow-up patch to use braces initializer for FocusOptions struct and simplify the code.
+
+* dom/Document.cpp:
+(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
+
2021-04-15 Alex Christensen
Add deprecation macros
Modified: trunk/Source/WebCore/dom/Document.cpp (276076 => 276077)
--- trunk/Source/WebCore/dom/Document.cpp 2021-04-15 22:09:14 UTC (rev 276076)
+++ trunk/Source/WebCore/dom/Document.cpp 2021-04-15 22:27:48 UTC (rev 276077)
@@ -4357,9 +4357,7 @@
// FIXME: We should avoid synchronously updating the style inside setFocusedElement.
// FIXME: Object elements should avoid loading a frame synchronously in a post style recalc callback.
SubframeLoadingDisabler disabler(is(node) ? (node) : nullptr);
-FocusOptions focusOptions = { };
-focusOptions.removalEventsMode = FocusRemovalEventsMode::DoNotDispatch;
-setFocusedElement(nullptr, focusOptions);
+setFocusedElement(nullptr, { { }, { }, FocusRemovalEventsMode::DoNotDispatch, { } });
// Set the focus navigation starting node to the previous focused element so that
// we can fallback to the siblings or parent node for the next search.
// Also we need to call removeFocusNavigationNodeOfSubtree after this function because
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276016] trunk/Source/WebCore
Title: [276016] trunk/Source/WebCore
Revision 276016
Author r...@igalia.com
Date 2021-04-15 04:01:26 -0700 (Thu, 15 Apr 2021)
Log Message
Move FocusRemovalEventsMode into FocusOptions
https://bugs.webkit.org/show_bug.cgi?id=224549
Reviewed by Darin Adler.
This patch is just a refactoring that moves FocusRemovalEventsMode enum into FocusOptions.
This allows us to simplify some method signatures, as they'll just receive a FocusOptions parameter, instead of two parameters for FocusRemovalEventsMode and FocusDirection.
There is no change of behavior, just a code refactoring.
* dom/Document.cpp:
(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
(WebCore::Document::setFocusedElement):
* dom/Document.h:
(WebCore::Document::setFocusedElement):
* dom/Element.cpp:
(WebCore::Element::focus):
* dom/FocusOptions.h:
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedElement):
* page/FocusController.h:
(WebCore::FocusController::setFocusedElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/FocusOptions.h
trunk/Source/WebCore/page/FocusController.cpp
trunk/Source/WebCore/page/FocusController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (276015 => 276016)
--- trunk/Source/WebCore/ChangeLog 2021-04-15 10:59:18 UTC (rev 276015)
+++ trunk/Source/WebCore/ChangeLog 2021-04-15 11:01:26 UTC (rev 276016)
@@ -1,3 +1,28 @@
+2021-04-15 Manuel Rego Casasnovas
+
+Move FocusRemovalEventsMode into FocusOptions
+https://bugs.webkit.org/show_bug.cgi?id=224549
+
+Reviewed by Darin Adler.
+
+This patch is just a refactoring that moves FocusRemovalEventsMode enum into FocusOptions.
+This allows us to simplify some method signatures, as they'll just receive a FocusOptions parameter, instead of two parameters for FocusRemovalEventsMode and FocusDirection.
+
+There is no change of behavior, just a code refactoring.
+
+* dom/Document.cpp:
+(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
+(WebCore::Document::setFocusedElement):
+* dom/Document.h:
+(WebCore::Document::setFocusedElement):
+* dom/Element.cpp:
+(WebCore::Element::focus):
+* dom/FocusOptions.h:
+* page/FocusController.cpp:
+(WebCore::FocusController::setFocusedElement):
+* page/FocusController.h:
+(WebCore::FocusController::setFocusedElement):
+
2021-04-09 Sergio Villar Senin
Empty value is added in codePointsFromString in CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts
Modified: trunk/Source/WebCore/dom/Document.cpp (276015 => 276016)
--- trunk/Source/WebCore/dom/Document.cpp 2021-04-15 10:59:18 UTC (rev 276015)
+++ trunk/Source/WebCore/dom/Document.cpp 2021-04-15 11:01:26 UTC (rev 276016)
@@ -75,6 +75,7 @@
#include "ExtensionStyleSheets.h"
#include "FocusController.h"
#include "FocusEvent.h"
+#include "FocusOptions.h"
#include "FontFaceSet.h"
#include "FormController.h"
#include "Frame.h"
@@ -4356,7 +4357,9 @@
// FIXME: We should avoid synchronously updating the style inside setFocusedElement.
// FIXME: Object elements should avoid loading a frame synchronously in a post style recalc callback.
SubframeLoadingDisabler disabler(is(node) ? (node) : nullptr);
-setFocusedElement(nullptr, FocusDirection::None, FocusRemovalEventsMode::DoNotDispatch);
+FocusOptions focusOptions = { };
+focusOptions.removalEventsMode = FocusRemovalEventsMode::DoNotDispatch;
+setFocusedElement(nullptr, focusOptions);
// Set the focus navigation starting node to the previous focused element so that
// we can fallback to the siblings or parent node for the next search.
// Also we need to call removeFocusNavigationNodeOfSubtree after this function because
@@ -4438,7 +4441,7 @@
#endif
}
-bool Document::setFocusedElement(Element* element, FocusDirection direction, FocusRemovalEventsMode eventsMode)
+bool Document::setFocusedElement(Element* element, const FocusOptions& options)
{
RefPtr newFocusedElement = element;
// Make sure newFocusedElement is actually in this document
@@ -4460,7 +4463,7 @@
oldFocusedElement->setFocus(false);
setFocusNavigationStartingNode(nullptr);
-if (eventsMode == FocusRemovalEventsMode::Dispatch) {
+if (options.removalEventsMode == FocusRemovalEventsMode::Dispatch) {
// Dispatch a change event for form control elements that have been edited.
if (is(*oldFocusedElement)) {
HTMLFormControlElement& formControlElement = downcast(*oldFocusedElement);
@@ -4537,7 +4540,7 @@
}
// Dispatch the focus event and let the node do any other focus relat
[webkit-changes] [274365] trunk
Title: [274365] trunk
Revision 274365
Author r...@igalia.com
Date 2021-03-12 11:03:26 -0800 (Fri, 12 Mar 2021)
Log Message
[selectors] :focus-visible matches body after keyboard event
https://bugs.webkit.org/show_bug.cgi?id=223113
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
* web-platform-tests/css/selectors/focus-visible-001.html: Modify the test to verify
that only the element matches :focus-visible (and not the body).
* web-platform-tests/css/selectors/focus-visible-019-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-019.html: Added new test to check script focus in keyboard event,
and that again only the element matches :focus-visible (and not the body).
Source/WebCore:
Fix the bug with some changes in EventHandler::internalKeyEvent().
When you use TAB (or other key) the |element| variable in this method is the document body,
however that element is not focused (element->focused() is false).
Before this patch we were marking the element as matchin :focus-visible,
however we shouldn't do that if the element is not focused (added a condition to avoid doing that).
Apart from that this patch also fixes a related issue, if a keyboard event handler is changing focus via script
there's a part of this method that takes care of updating the |element| variable.
In that case we have to remove :focus-visible flag from the previous element, and add it to the new one.
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-019.html
* page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
LayoutTests:
* platform/ios/TestExpectations: Skip new test for iOS.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-019-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-019.html
Diff
Modified: trunk/LayoutTests/ChangeLog (274364 => 274365)
--- trunk/LayoutTests/ChangeLog 2021-03-12 18:49:22 UTC (rev 274364)
+++ trunk/LayoutTests/ChangeLog 2021-03-12 19:03:26 UTC (rev 274365)
@@ -1,3 +1,12 @@
+2021-03-12 Manuel Rego Casasnovas
+
+[selectors] :focus-visible matches body after keyboard event
+https://bugs.webkit.org/show_bug.cgi?id=223113
+
+Reviewed by Antti Koivisto.
+
+* platform/ios/TestExpectations: Skip new test for iOS.
+
2021-03-12 Robert Jenner
[MacOS wk2] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-updating.html is a flakey failure
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (274364 => 274365)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-12 18:49:22 UTC (rev 274364)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-12 19:03:26 UTC (rev 274365)
@@ -1,3 +1,16 @@
+2021-03-12 Manuel Rego Casasnovas
+
+[selectors] :focus-visible matches body after keyboard event
+https://bugs.webkit.org/show_bug.cgi?id=223113
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/selectors/focus-visible-001.html: Modify the test to verify
+that only the element matches :focus-visible (and not the body).
+* web-platform-tests/css/selectors/focus-visible-019-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-019.html: Added new test to check script focus in keyboard event,
+and that again only the element matches :focus-visible (and not the body).
+
2021-03-12 Antoine Quint
Support animation of perspective-origin property
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html (274364 => 274365)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html 2021-03-12 18:49:22 UTC (rev 274364)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html 2021-03-12 19:03:26 UTC (rev 274365)
@@ -39,10 +39,14 @@
Focus me.
</span><span class="cx"> async_test(function(t) {
</span><del>- el.addEventListener("focus", t.step_func(function() {
</del><ins>+ el.addEventListener("focus", t.step_func_done(function() {
</ins><span class="cx"> assert_equals(getComputedStyle(el).outlineColor, "rgb(0, 128, 0)", `outlineColor for ${el.tagName}#${el.id} should be green`);
</span><span class="cx"> assert_not_equals(getComputedStyle(el).backgroundColor, "rgb(255, 0, 0)", `backgroundColor for ${el.tagName}#${el.id} should NOT be red`);
</span><del>-t.don
[webkit-changes] [274173] trunk/Source/WebCore
Title: [274173] trunk/Source/WebCore
Revision 274173
Author r...@igalia.com
Date 2021-03-09 13:36:01 -0800 (Tue, 09 Mar 2021)
Log Message
[selectors] Move :focus-viisble & :focus-within flags from Node to UserActionElementSet
https://bugs.webkit.org/show_bug.cgi?id=222647
Reviewed by Antti Koivisto.
This patch avoids using flags in Node.h for :focus-visible and :focus-within pseudo classes,
and move them to UserActionElementSet.
This makes them consistent with :focus flag, and saves some bits in Node.h for other flags in the future.
On top of that this makes :focus-within SelectorCompiler implementation consistent with :focus and :focus-visible implementations.
* css/SelectorCheckerTestFunctions.h:
(WebCore::matchesFocusWithinPseudoClass):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
* dom/Element.cpp:
(WebCore::Element::isUserActionElementHasFocusVisible const):
(WebCore::Element::isUserActionElementHasFocusWithin const):
(WebCore::Element::setHasFocusVisible):
(WebCore::Element::setHasFocusWithin):
* dom/Element.h:
(WebCore::Element::hasFocusVisible const):
(WebCore::Element::hasFocusWithin const):
* dom/Node.h:
(WebCore::Node::flagIsLink):
* dom/UserActionElementSet.h:
(WebCore::UserActionElementSet::hasFocusVisible):
(WebCore::UserActionElementSet::hasFocusWithin):
(WebCore::UserActionElementSet::setHasFocusVisible):
(WebCore::UserActionElementSet::setHasFocusWithin):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/UserActionElementSet.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (274172 => 274173)
--- trunk/Source/WebCore/ChangeLog 2021-03-09 21:27:27 UTC (rev 274172)
+++ trunk/Source/WebCore/ChangeLog 2021-03-09 21:36:01 UTC (rev 274173)
@@ -1,3 +1,38 @@
+2021-03-09 Manuel Rego Casasnovas
+
+[selectors] Move :focus-viisble & :focus-within flags from Node to UserActionElementSet
+https://bugs.webkit.org/show_bug.cgi?id=222647
+
+Reviewed by Antti Koivisto.
+
+This patch avoids using flags in Node.h for :focus-visible and :focus-within pseudo classes,
+and move them to UserActionElementSet.
+This makes them consistent with :focus flag, and saves some bits in Node.h for other flags in the future.
+
+On top of that this makes :focus-within SelectorCompiler implementation consistent with :focus and :focus-visible implementations.
+
+* css/SelectorCheckerTestFunctions.h:
+(WebCore::matchesFocusWithinPseudoClass):
+* cssjit/SelectorCompiler.cpp:
+(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
+(WebCore::SelectorCompiler::addPseudoClassType):
+(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
+* dom/Element.cpp:
+(WebCore::Element::isUserActionElementHasFocusVisible const):
+(WebCore::Element::isUserActionElementHasFocusWithin const):
+(WebCore::Element::setHasFocusVisible):
+(WebCore::Element::setHasFocusWithin):
+* dom/Element.h:
+(WebCore::Element::hasFocusVisible const):
+(WebCore::Element::hasFocusWithin const):
+* dom/Node.h:
+(WebCore::Node::flagIsLink):
+* dom/UserActionElementSet.h:
+(WebCore::UserActionElementSet::hasFocusVisible):
+(WebCore::UserActionElementSet::hasFocusWithin):
+(WebCore::UserActionElementSet::setHasFocusVisible):
+(WebCore::UserActionElementSet::setHasFocusWithin):
+
2021-03-09 Antti Koivisto
REGRESSION (r273003): Animated style may lose original display property value
Modified: trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h (274172 => 274173)
--- trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h 2021-03-09 21:27:27 UTC (rev 274172)
+++ trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h 2021-03-09 21:36:01 UTC (rev 274173)
@@ -480,4 +480,12 @@
return element.hasFocusVisible() && isFrameFocused(element);
}
+ALWAYS_INLINE bool matchesFocusWithinPseudoClass(const Element& element)
+{
+if (InspectorInstrumentation::forcePseudoState(element, CSSSelector::PseudoClassFocusWithin))
+return true;
+
+return element.hasFocusWithin() && isFrameFocused(element);
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (274172 => 274173)
--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2021-03-09 21:27:27 UTC (rev 274172)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2021-03-09 21:36:01 UTC (rev 274173)
@@ -86,6 +86,7 @@
static JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL(o
[webkit-changes] [273812] trunk
/StyleSharingResolver.cpp Added Paths trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (273811 => 273812) --- trunk/LayoutTests/ChangeLog 2021-03-03 05:05:30 UTC (rev 273811) +++ trunk/LayoutTests/ChangeLog 2021-03-03 06:43:53 UTC (rev 273812) @@ -1,3 +1,14 @@ +2021-03-02 Manuel Rego Casasnovas + +[selectors] :focus-visible implementation +https://bugs.webkit.org/show_bug.cgi?id=222028 + + +Reviewed by Darin Adler. + +* platform/ios/TestExpectations: Skip focus-visible-008.html and focus-visible-011.html as they timeout in iOS. +* platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt. + 2021-03-02 Lauro Moura [GLIB] Rebaseline and update expectations Modified: trunk/LayoutTests/imported/w3c/ChangeLog (273811 => 273812) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-03 05:05:30 UTC (rev 273811) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-03 06:43:53 UTC (rev 273812) @@ -1,3 +1,29 @@ +2021-03-02 Manuel Rego Casasnovas + +[selectors] :focus-visible implementation +https://bugs.webkit.org/show_bug.cgi?id=222028 + + +Reviewed by Darin Adler. + +Update expectations, most of the :focus-visible tests are passing now. + +* web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt: +* web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt: +* web-platform-tests/css/selectors/focus-visible-001-expected.txt: +* web-platform-tests/css/selectors/focus-visible-002-expected.txt: +* web-platform-tests/css/selectors/focus-visible-006-expected.txt: +* web-platform-tests/css/selectors/focus-visible-007-expected.txt: +* web-platform-tests/css/selectors/focus-visible-007.html: Import last changes on this test +* web-platform-tests/css/selectors/focus-visible-008-expected.txt: +(see https://github.com/web-platform-tests/wpt/pull/27656). +* web-platform-tests/css/selectors/focus-visible-011-expected.txt: +* web-platform-tests/css/selectors/focus-visible-011.html: Import last changes on this test +(see https://github.com/web-platform-tests/wpt/pull/27700). +* web-platform-tests/css/selectors/focus-visible-013-expected.txt: +* web-platform-tests/css/selectors/focus-visible-014-expected.txt: +* web-platform-tests/css/selectors/focus-visible-016-expected.txt: + 2021-03-02 Rob Buis Take box-sizing into account in replaced element intrinsic sizing Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt (273811 => 273812) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt 2021-03-03 05:05:30 UTC (rev 273811) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt 2021-03-03 06:43:53 UTC (rev 273812) @@ -1,6 +1,6 @@ PASS Checks that ':focus' pseudo-class matches inside 'focus' event handler -FAIL Checks that ':focus-visible' pseudo-class matches inside 'focus' event handler assert_unreached: ':focus-visible' is an invalid selector. SyntaxError: Error: assert_equals: ':focus-visible' matches event.target expected null but got Element node Reached unreachable code +PASS Checks that ':focus-visible' pseudo-class matches inside 'focus' event handler PASS Checks that ':focus-within' pseudo-class matches inside 'focus' event handler Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt (273811 => 273812) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt 2021-03-03 05:05:30 UTC (rev 273811) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt 2021-03-03 06:43:53 UTC (rev 273812) @@ -1,6 +1,6 @@ PASS Checks that ':focus' pseudo-class matches inside 'focusin' event handler -FAIL Checks that ':focus-visible' pseudo-class matches inside 'focusin' event handler assert_unreached: ':focus-visible' is an invalid selector. SyntaxError: Error: assert_equals: ':focus-visible' matches event.target expected null but got Element node Reached unreachable code +PASS Checks that ':focus-visible' pseudo-class matches inside 'focusin' event handler PASS Checks that ':focus-within' pseudo-class matches inside 'focusin' event handler Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-001-expected.txt (273811 => 273812) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-001-expected.txt 2021-03-03 05
[webkit-changes] [273136] trunk/LayoutTests/imported/w3c
Title: [273136] trunk/LayoutTests/imported/w3c
Revision 273136
Author r...@igalia.com
Date 2021-02-19 02:30:25 -0800 (Fri, 19 Feb 2021)
Log Message
Fix Selenium key code for ENTER in testdriver-vendor.js
https://bugs.webkit.org/show_bug.cgi?id=222037
Reviewed by Carlos Garcia Campos.
In r272726 we added a bunch of Selenium key codes,
but the one for 0XE007 (ENTER) was wrong
as eventSender.keyDown() expects "\n" and not "enter".
This patch fixes the wrong code.
* web-platform-tests/resources/testdriver-vendor.js:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (273135 => 273136)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-19 09:42:20 UTC (rev 273135)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-19 10:30:25 UTC (rev 273136)
@@ -1,3 +1,17 @@
+2021-02-19 Manuel Rego Casasnovas
+
+Fix Selenium key code for ENTER in testdriver-vendor.js
+https://bugs.webkit.org/show_bug.cgi?id=222037
+
+Reviewed by Carlos Garcia Campos.
+
+In r272726 we added a bunch of Selenium key codes,
+but the one for 0XE007 (ENTER) was wrong
+as eventSender.keyDown() expects "\n" and not "enter".
+This patch fixes the wrong code.
+
+* web-platform-tests/resources/testdriver-vendor.js:
+
2021-02-19 Imanol Fernandez and Sergio Villar Senin
Implement WebXR getViewerPose and getPose
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (273135 => 273136)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-19 09:42:20 UTC (rev 273135)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-19 10:30:25 UTC (rev 273136)
@@ -160,7 +160,7 @@
0XE004: { key: '\t' },
0XE005: { key: 'clear' },
0XE006: { key: '\r' },
-0XE007: { key: 'enter' },
+0XE007: { key: '\n' },
0xE008: { key: 'leftShift', modifier: 'shiftKey' },
0xE009: { key: 'leftControl', modifier: 'ctrlKey' },
0xE00A: { key: 'leftAlt', modifier: 'altKey' },
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [272983] trunk
/WebCore/css/parser/CSSParserContext.h trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp trunk/Source/WebCore/cssjit/SelectorCompiler.cpp Added Paths trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (272982 => 272983) --- trunk/LayoutTests/ChangeLog 2021-02-17 05:36:13 UTC (rev 272982) +++ trunk/LayoutTests/ChangeLog 2021-02-17 05:54:15 UTC (rev 272983) @@ -1,3 +1,14 @@ +2021-02-16 Manuel Rego Casasnovas + +[selectors] :focus-visible parsing and experimental flag +https://bugs.webkit.org/show_bug.cgi?id=221895 + +Reviewed by Darin Adler. + +* platform/ios/TestExpectations: Skip test that timeouts in iOS platform. +* platform/mac/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt: +Slightly different rebaseline due to default outline color on Mac. + 2021-02-16 Jonathan Bedard [LayoutTests] Convert http/tests/resources/redirect.php to Python Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272982 => 272983) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-17 05:36:13 UTC (rev 272982) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-17 05:54:15 UTC (rev 272983) @@ -1,3 +1,30 @@ +2021-02-16 Manuel Rego Casasnovas + +[selectors] :focus-visible parsing and experimental flag +https://bugs.webkit.org/show_bug.cgi?id=221895 + +Reviewed by Darin Adler. + +Update expectations as now :focus-visible is a valid selector. + +* web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt: +* web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt: +* web-platform-tests/css/selectors/focus-visible-001-expected.txt: +* web-platform-tests/css/selectors/focus-visible-002-expected.txt: +* web-platform-tests/css/selectors/focus-visible-003-expected.txt: +* web-platform-tests/css/selectors/focus-visible-004-expected.txt: +* web-platform-tests/css/selectors/focus-visible-005-expected.txt: +* web-platform-tests/css/selectors/focus-visible-006-expected.txt: +* web-platform-tests/css/selectors/focus-visible-007-expected.txt: +* web-platform-tests/css/selectors/focus-visible-009-expected.txt: +* web-platform-tests/css/selectors/focus-visible-010-expected.txt: +* web-platform-tests/css/selectors/focus-visible-012-expected.txt: +* web-platform-tests/css/selectors/focus-visible-015-expected.txt: +* web-platform-tests/css/selectors/focus-visible-016-expected.txt: +* web-platform-tests/css/selectors/focus-visible-017-expected.txt: +* web-platform-tests/css/selectors/focus-visible-018-expected.txt: +* web-platform-tests/css/selectors/parsing/parse-focus-visible-expected.txt: + 2021-02-16 Youenn Fablet MediaRecorder.stop() does not work correctly when recording has been paused. Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt (272982 => 272983) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt 2021-02-17 05:36:13 UTC (rev 272982) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt 2021-02-17 05:54:15 UTC (rev 272983) @@ -1,6 +1,6 @@ PASS Checks that ':focus' pseudo-class matches inside 'focus' event handler -FAIL Checks that ':focus-visible' pseudo-class matches inside 'focus' event handler assert_unreached: ':focus-visible' is an invalid selector. SyntaxError: SyntaxError: The string did not match the expected pattern. Reached unreachable code +FAIL Checks that ':focus-visible' pseudo-class matches inside 'focus' event handler assert_unreached: ':focus-visible' is an invalid selector. SyntaxError: Error: assert_equals: ':focus-visible' matches event.target expected null but got Element node Reached unreachable code PASS Checks that ':focus-within' pseudo-class matches inside 'focus' event handler Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt (272982 => 272983) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt 2021-02-17 05:36:13 UTC (rev 272982) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt 2021-02-17 05:54:15 UTC (rev 272983) @@ -1,6 +1,6 @@ PASS Checks that ':focus' pseudo-class matches inside 'focusin' event handler -FAIL Checks that ':focus-visible' pseudo-class matches inside 'focusin' event handler assert_unreached: ':focus-visible' is an invalid selector. SyntaxError: SyntaxError: The string did not match the expected pattern. Reached unreachabl
[webkit-changes] [272847] trunk/LayoutTests
Title: [272847] trunk/LayoutTests Revision 272847 Author r...@igalia.com Date 2021-02-15 03:24:03 -0800 (Mon, 15 Feb 2021) Log Message [selectors] Update WPT test suite https://bugs.webkit.org/show_bug.cgi?id=221890 Reviewed by Carlos Alberto Lopez Perez. LayoutTests/imported/w3c: * web-platform-tests/css/selectors/focus-visible-002-expected.txt: * web-platform-tests/css/selectors/focus-visible-002.html: * web-platform-tests/css/selectors/focus-visible-006.html: * web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001-expected.xht: Added. * web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html: Added. * web-platform-tests/css/selectors/w3c-import.log: LayoutTests: * TestExpectations: Add test failure for :dir(). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-006.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001-expected.xht trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html Diff Modified: trunk/LayoutTests/ChangeLog (272846 => 272847) --- trunk/LayoutTests/ChangeLog 2021-02-15 11:05:48 UTC (rev 272846) +++ trunk/LayoutTests/ChangeLog 2021-02-15 11:24:03 UTC (rev 272847) @@ -1,3 +1,12 @@ +2021-02-15 Manuel Rego Casasnovas + +[selectors] Update WPT test suite +https://bugs.webkit.org/show_bug.cgi?id=221890 + +Reviewed by Carlos Alberto Lopez Perez. + +* TestExpectations: Add test failure for :dir(). + 2021-02-15 Frederic Wang Crash in RetainPtr::RetainPtr via ImageBufferCGBackend::toCFData Modified: trunk/LayoutTests/TestExpectations (272846 => 272847) --- trunk/LayoutTests/TestExpectations 2021-02-15 11:05:48 UTC (rev 272846) +++ trunk/LayoutTests/TestExpectations 2021-02-15 11:24:03 UTC (rev 272847) @@ -1244,6 +1244,7 @@ webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Skip ] webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Skip ] webkit.org/b/217904 imported/w3c/web-platform-tests/css/selectors/is-where-visited.html [ ImageOnlyFailure ] +webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html [ ImageOnlyFailure ] webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html [ ImageOnlyFailure ] webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-002.html [ ImageOnlyFailure ] webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-003.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272846 => 272847) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-15 11:05:48 UTC (rev 272846) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-15 11:24:03 UTC (rev 272847) @@ -1,3 +1,17 @@ +2021-02-15 Manuel Rego Casasnovas + +[selectors] Update WPT test suite +https://bugs.webkit.org/show_bug.cgi?id=221890 + +Reviewed by Carlos Alberto Lopez Perez. + +* web-platform-tests/css/selectors/focus-visible-002-expected.txt: +* web-platform-tests/css/selectors/focus-visible-002.html: +* web-platform-tests/css/selectors/focus-visible-006.html: +* web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001-expected.xht: Added. +* web-platform-tests/css/selectors/selectors-dir-selector-auto-direction-change-001.html: Added. +* web-platform-tests/css/selectors/w3c-import.log: + 2021-02-12 Sergio Villar Senin [css-flexbox] Another WPT test import Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt (272846 => 272847) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt 2021-02-15 11:05:48 UTC (rev 272846) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt 2021-02-15 11:24:03 UTC (rev 272847) @@ -18,7 +18,6 @@ - FAIL Focus element INPUT#input1 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor for INPUT#input1 should be green expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" FAIL Focus element INPUT#input2 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor
[webkit-changes] [272844] trunk/Source/WebCore
Title: [272844] trunk/Source/WebCore
Revision 272844
Author r...@igalia.com
Date 2021-02-15 02:23:23 -0800 (Mon, 15 Feb 2021)
Log Message
[selectors] Update :focus-visible status in features.json
https://bugs.webkit.org/show_bug.cgi?id=221889
Reviewed by Sergio Villar Senin.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (272843 => 272844)
--- trunk/Source/WebCore/ChangeLog 2021-02-15 09:04:34 UTC (rev 272843)
+++ trunk/Source/WebCore/ChangeLog 2021-02-15 10:23:23 UTC (rev 272844)
@@ -1,3 +1,12 @@
+2021-02-15 Manuel Rego Casasnovas
+
+[selectors] Update :focus-visible status in features.json
+https://bugs.webkit.org/show_bug.cgi?id=221889
+
+Reviewed by Sergio Villar Senin.
+
+* features.json:
+
2021-02-12 Sergio Villar Senin
Don't update form control elements validity status if they are detached from the document.
Modified: trunk/Source/WebCore/features.json (272843 => 272844)
--- trunk/Source/WebCore/features.json 2021-02-15 09:04:34 UTC (rev 272843)
+++ trunk/Source/WebCore/features.json 2021-02-15 10:23:23 UTC (rev 272844)
@@ -857,16 +857,17 @@
{
"name": "CSS Selector :focus-visible",
"status": {
-"status": "Under Consideration",
+"status": "In Development",
"enabled-by-default": false
},
"url": "https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo",
"specification": "CSS Selectors Level 4",
+"keywords": ["focus visible", "focus-visible", ":focus-visible"],
"description": "The selector :focus-visible matches an element that has received focus and the user-agent has determined that the focus should be made visible on the element.",
"contact": {
-"name": "Jonathan Davis",
-"twitter": "@jonathandavis",
-"email": "web-evangel...@apple.com"
+"name": "Manuel Rego",
+"twitter": "@regocas",
+"email": "r...@igalia.com"
}
},
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [272771] trunk
Title: [272771] trunk
Revision 272771
Author r...@igalia.com
Date 2021-02-11 21:43:50 -0800 (Thu, 11 Feb 2021)
Log Message
[WPE] event.ctrlKey and other are false in keydown event
https://bugs.webkit.org/show_bug.cgi?id=221760
Reviewed by Adrian Perez de Castro.
Source/WebKit:
This is the same issue that was fixed for WebKitGTK in r272489.
Test: fast/events/keyboardevent-modifier.html
* Shared/libwpe/WebEventFactory.cpp:
(WebKit::modifiersForEventModifiers):
(WebKit::modifiersForKeyboardEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
LayoutTests:
* platform/wpe/TestExpectations: The test passes now.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/libwpe/WebEventFactory.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (272770 => 272771)
--- trunk/LayoutTests/ChangeLog 2021-02-12 05:12:51 UTC (rev 272770)
+++ trunk/LayoutTests/ChangeLog 2021-02-12 05:43:50 UTC (rev 272771)
@@ -1,3 +1,12 @@
+2021-02-11 Manuel Rego Casasnovas
+
+[WPE] event.ctrlKey and other are false in keydown event
+https://bugs.webkit.org/show_bug.cgi?id=221760
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/wpe/TestExpectations: The test passes now.
+
2021-02-11 Alex Christensen
REGRESSION(r272293) WebGL 1.0.2 test expectations say HTTPS
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (272770 => 272771)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-12 05:12:51 UTC (rev 272770)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-12 05:43:50 UTC (rev 272771)
@@ -143,6 +143,8 @@
# Passing since r266083.
imported/w3c/web-platform-tests/css/css-content/quotes-033.html [ Pass ]
+fast/events/keyboardevent-modifier.html [ Pass ]
+
#//
# Triaged Expectations
# * KEEP THE SECTIONS SORTED ALPHABETICALLY.
Modified: trunk/Source/WebKit/ChangeLog (272770 => 272771)
--- trunk/Source/WebKit/ChangeLog 2021-02-12 05:12:51 UTC (rev 272770)
+++ trunk/Source/WebKit/ChangeLog 2021-02-12 05:43:50 UTC (rev 272771)
@@ -1,3 +1,19 @@
+2021-02-11 Manuel Rego Casasnovas
+
+[WPE] event.ctrlKey and other are false in keydown event
+https://bugs.webkit.org/show_bug.cgi?id=221760
+
+Reviewed by Adrian Perez de Castro.
+
+This is the same issue that was fixed for WebKitGTK in r272489.
+
+Test: fast/events/keyboardevent-modifier.html
+
+* Shared/libwpe/WebEventFactory.cpp:
+(WebKit::modifiersForEventModifiers):
+(WebKit::modifiersForKeyboardEvent):
+(WebKit::WebEventFactory::createWebKeyboardEvent):
+
2021-02-11 Alex Christensen
Unreviewed, reverting r272603.
Modified: trunk/Source/WebKit/Shared/libwpe/WebEventFactory.cpp (272770 => 272771)
--- trunk/Source/WebKit/Shared/libwpe/WebEventFactory.cpp 2021-02-12 05:12:51 UTC (rev 272770)
+++ trunk/Source/WebKit/Shared/libwpe/WebEventFactory.cpp 2021-02-12 05:43:50 UTC (rev 272771)
@@ -49,9 +49,45 @@
modifiers.add(WebEvent::Modifier::AltKey);
if (eventModifiers & wpe_input_keyboard_modifier_meta)
modifiers.add(WebEvent::Modifier::MetaKey);
+
return modifiers;
}
+static OptionSet modifiersForKeyboardEvent(struct wpe_input_keyboard_event* event)
+{
+OptionSet modifiers = modifiersForEventModifiers(event->modifiers);
+
+if (!event->pressed)
+return modifiers;
+
+// Handling of modifier masks in WPE is modelled after X. This code makes WPE to behave similar
+// to other platforms and other browsers under X (see http://crbug.com/127142#c8).
+
+switch (event->key_code) {
+case WPE_KEY_Control_L:
+case WPE_KEY_Control_R:
+modifiers.add(WebEvent::Modifier::ControlKey);
+break;
+case WPE_KEY_Shift_L:
+case WPE_KEY_Shift_R:
+modifiers.add(WebEvent::Modifier::ShiftKey);
+break;
+case WPE_KEY_Alt_L:
+case WPE_KEY_Alt_R:
+modifiers.add(WebEvent::Modifier::AltKey);
+break;
+case WPE_KEY_Meta_L:
+case WPE_KEY_Meta_R:
+modifiers.add(WebEvent::Modifier::MetaKey);
+break;
+case WPE_KEY_Caps_Lock:
+modifiers.add(WebEvent::Modifier::CapsLockKey);
+break;
+}
+
+return modifiers;
+}
+
WallTime wallTimeForEventTime(uint64_t msTimeStamp)
{
// WPE event time field is an uint32_t, too small for full ms timestamps since
@@ -90,7 +126,7 @@
WTFMove(preeditUnderlines),
WTFMove(preeditSelectionRange),
isWPEKeyCodeFromKeyPad(event->key_code),
-modifiersForEventModifiers(event->modifiers),
+modifiersForKeyboardEvent(event),
wallTimeForEventTime(event->time));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.or
[webkit-changes] [272726] trunk/LayoutTests
Title: [272726] trunk/LayoutTests Revision 272726 Author r...@igalia.com Date 2021-02-11 07:25:20 -0800 (Thu, 11 Feb 2021) Log Message Add more Selenium key codes for test_driver.send_keys() https://bugs.webkit.org/show_bug.cgi?id=221674 Reviewed by Carlos Garcia Campos. LayoutTests/imported/w3c: Add more Selenium key codes (https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html). Not all of them are added, only the ones that are supported in eventSender.keyDown(). * web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Updated expectations as this test was using the code for ENTER. * web-platform-tests/resources/testdriver-vendor.js: LayoutTests: * platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js Added Paths trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (272725 => 272726) --- trunk/LayoutTests/ChangeLog 2021-02-11 14:56:18 UTC (rev 272725) +++ trunk/LayoutTests/ChangeLog 2021-02-11 15:25:20 UTC (rev 272726) @@ -1,3 +1,12 @@ +2021-02-11 Manuel Rego Casasnovas + +Add more Selenium key codes for test_driver.send_keys() +https://bugs.webkit.org/show_bug.cgi?id=221674 + +Reviewed by Carlos Garcia Campos. + +* platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt. + 2021-02-11 Youenn Fablet Remove GPUProcess flag in MediaRecorder tests Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272725 => 272726) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-11 14:56:18 UTC (rev 272725) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-11 15:25:20 UTC (rev 272726) @@ -1,3 +1,17 @@ +2021-02-11 Manuel Rego Casasnovas + +Add more Selenium key codes for test_driver.send_keys() +https://bugs.webkit.org/show_bug.cgi?id=221674 + +Reviewed by Carlos Garcia Campos. + +Add more Selenium key codes (https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html). +Not all of them are added, only the ones that are supported in eventSender.keyDown(). + +* web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Updated expectations +as this test was using the code for ENTER. +* web-platform-tests/resources/testdriver-vendor.js: + 2021-02-11 Ziran Sun the nested grid container which has replaced item with 'max-height' has wrong width(0px). Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt (272725 => 272726) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt 2021-02-11 14:56:18 UTC (rev 272725) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt 2021-02-11 15:25:20 UTC (rev 272726) @@ -2,6 +2,6 @@ -FAIL Submit event with a submit button promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'event.bubbles')" -FAIL Submit event with no submit button promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'event.bubbles')" +FAIL Submit event with a submit button promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: SubmitEvent" +FAIL Submit event with no submit button assert_equals: expected (object) null but got (undefined) undefined Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (272725 => 272726) --- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-11 14:56:18 UTC (rev 272725) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-11 15:25:20 UTC (rev 272726) @@ -157,15 +157,39 @@
[webkit-changes] [272651] trunk/LayoutTests
Title: [272651] trunk/LayoutTests
Revision 272651
Author r...@igalia.com
Date 2021-02-10 07:19:02 -0800 (Wed, 10 Feb 2021)
Log Message
Add support for modifier keys in test_driver.send_keys()
https://bugs.webkit.org/show_bug.cgi?id=221465
Reviewed by Carlos Garcia Campos.
LayoutTests/imported/w3c:
Allow to send modifier keys combinations, like "Ctrl + y" through test_driver.send_keys().
* web-platform-tests/resources/testdriver-vendor.js:
(convertSeleniumKeyCode):
(window.test_driver_internal.send_keys):
* web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt: Added.
* web-platform-tests/uievents/keyboard/modifier-keys-combinations.html: Added.
LayoutTests:
Add specific -expected.txt file for Mac platform. Meta key is detected differently than in other platforms.
* platform/ios/TestExpectations: Skip test as it's timing out on iOS.
* platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt: Update expectations as it nows mostly passes.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations.html
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (272650 => 272651)
--- trunk/LayoutTests/ChangeLog 2021-02-10 15:04:17 UTC (rev 272650)
+++ trunk/LayoutTests/ChangeLog 2021-02-10 15:19:02 UTC (rev 272651)
@@ -1,3 +1,16 @@
+2021-02-10 Manuel Rego Casasnovas
+
+Add support for modifier keys in test_driver.send_keys()
+https://bugs.webkit.org/show_bug.cgi?id=221465
+
+Reviewed by Carlos Garcia Campos.
+
+Add specific -expected.txt file for Mac platform. Meta key is detected differently than in other platforms.
+
+* platform/ios/TestExpectations: Skip test as it's timing out on iOS.
+* platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt: Added.
+* platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt: Update expectations as it nows mostly passes.
+
2021-02-10 Zalan Bujtas
[LFC][IFC] Pass in sane content width values to InlineContentBreaker
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272650 => 272651)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-10 15:04:17 UTC (rev 272650)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-10 15:19:02 UTC (rev 272651)
@@ -1,3 +1,18 @@
+2021-02-10 Manuel Rego Casasnovas
+
+Add support for modifier keys in test_driver.send_keys()
+https://bugs.webkit.org/show_bug.cgi?id=221465
+
+Reviewed by Carlos Garcia Campos.
+
+Allow to send modifier keys combinations, like "Ctrl + y" through test_driver.send_keys().
+
+* web-platform-tests/resources/testdriver-vendor.js:
+(convertSeleniumKeyCode):
+(window.test_driver_internal.send_keys):
+* web-platform-tests/uievents/keyboard/modifier-keys-combinations-expected.txt: Added.
+* web-platform-tests/uievents/keyboard/modifier-keys-combinations.html: Added.
+
2021-02-10 Sergio Villar Senin
[css-flexbox] Import & update latest WPT flexbox tests
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (272650 => 272651)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-10 15:04:17 UTC (rev 272650)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-10 15:19:02 UTC (rev 272651)
@@ -155,30 +155,34 @@
// https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html
// FIXME: Add more cases.
-// FIXME: Add the support for modifier keys.
const SeleniumCharCodeToEventSenderKey = {
-0xE003: 'delete',
-0xE004: '\t',
-0xE00D: ' ',
-0xE012: 'leftArrow',
-0xE013: 'upArrow',
-0xE014: 'rightArrow',
-0xE015: 'downArrow',
-0xE008: 'leftShift',
-0xE009: 'leftControl',
-0xE00A: 'leftAlt',
-0xE03D: 'leftMeta',
+0xE003: { key: 'delete' },
+0xE004: { key: '\t' },
+0xE00D: { key: ' ' },
+0xE012: { key: 'leftArrow' },
+0xE013: { key: 'upArrow' },
+0xE014: { key: 'rightArrow' },
+
[webkit-changes] [272572] trunk
Title: [272572] trunk Revision 272572 Author r...@igalia.com Date 2021-02-09 02:34:26 -0800 (Tue, 09 Feb 2021) Log Message Allow sending modifier keys in test_driver.send_keys() https://bugs.webkit.org/show_bug.cgi?id=221466 Reviewed by Carlos Garcia Campos. LayoutTests/imported/w3c: Created new test that checks that modifier keys can be sent by test_driver.send_keys() and properly handled on "keydown" event. * web-platform-tests/resources/testdriver-vendor.js: Add modifier keys' codes. * web-platform-tests/uievents/keyboard/modifier-keys-expected.txt: Added. * web-platform-tests/uievents/keyboard/modifier-keys.html: Added. Tools: * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::getGDKKeySymForKeyRef): Add support for meta key. LayoutTests: Add specific -expected.txt file for Mac platform. Meta key is detected differently than in other platforms, also event.ctrlKey and other are not being set from the test (they work fine when checking that manually). * platform/ios/TestExpectations: Skip test as it's timing out in iOS. * platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js trunk/LayoutTests/platform/ios/TestExpectations trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys.html trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (272571 => 272572) --- trunk/LayoutTests/ChangeLog 2021-02-09 10:30:52 UTC (rev 272571) +++ trunk/LayoutTests/ChangeLog 2021-02-09 10:34:26 UTC (rev 272572) @@ -1,3 +1,16 @@ +2021-02-09 Manuel Rego Casasnovas + +Allow sending modifier keys in test_driver.send_keys() +https://bugs.webkit.org/show_bug.cgi?id=221466 + +Reviewed by Carlos Garcia Campos. + +Add specific -expected.txt file for Mac platform. Meta key is detected differently than in other platforms, +also event.ctrlKey and other are not being set from the test (they work fine when checking that manually). + +* platform/ios/TestExpectations: Skip test as it's timing out in iOS. +* platform/mac/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt: Added. + 2021-02-08 Rob Buis Make auto && use content box-sizing Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272571 => 272572) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-09 10:30:52 UTC (rev 272571) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-09 10:34:26 UTC (rev 272572) @@ -1,3 +1,17 @@ +2021-02-09 Manuel Rego Casasnovas + +Allow sending modifier keys in test_driver.send_keys() +https://bugs.webkit.org/show_bug.cgi?id=221466 + +Reviewed by Carlos Garcia Campos. + +Created new test that checks that modifier keys can be sent by test_driver.send_keys() +and properly handled on "keydown" event. + +* web-platform-tests/resources/testdriver-vendor.js: Add modifier keys' codes. +* web-platform-tests/uievents/keyboard/modifier-keys-expected.txt: Added. +* web-platform-tests/uievents/keyboard/modifier-keys.html: Added. + 2021-02-08 Imanol Fernandez WebXRSystem::RequestSession with 'viewer' as a required feature should succeed Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (272571 => 272572) --- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-09 10:30:52 UTC (rev 272571) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2021-02-09 10:34:26 UTC (rev 272572) @@ -164,6 +164,10 @@ 0xE013: 'upArrow', 0xE014: 'rightArrow', 0xE015: 'downArrow', +0xE008: 'leftShift', +0xE009: 'leftControl', +0xE00A: 'leftAlt', +0xE03D: 'leftMeta', }; function convertSeleniumKeyCode(key) Added: trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt (0 => 272572) --- trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/uievents/keyboard/modifier-keys-expected.txt 2021-02-09 10:34:26 UTC (rev 272572) @@ -0,0 +1,7 @@ +Target + +PASS Check sending Shift key +PASS Check sending Control key +PASS Check sending Alt ke
[webkit-changes] [272489] trunk
Title: [272489] trunk
Revision 272489
Author r...@igalia.com
Date 2021-02-08 05:52:53 -0800 (Mon, 08 Feb 2021)
Log Message
[GTK] event.ctrlKey and other are false in keydown event
https://bugs.webkit.org/show_bug.cgi?id=221456
Reviewed by Adrian Perez de Castro.
Source/WebKit:
Modifier keys were not being set on "keydown" events.
For example if you check event.ctrlKey (and other) you'll get always false when the user only typed Ctrl key
(it'll be true when it's in combination with some other key, like Ctrl + P).
This is due to some differences on how X system manages the modifier keys (see http://crbug.com/127142#c8),
but this patch will align WebKitGTK with other platforms and browsers on this case.
Test: fast/events/keyboardevent-modifier.html
* Shared/gtk/WebEventFactory.cpp:
(WebKit::modifiersForEvent): In the case of a keyboard press event check if some modifier key has been pressed.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSynthesizeKeyEvent): Check if some modifier key has been pressed.
LayoutTests:
The test only pass in GTK right now, despite testing it manually works fine in all platforms,
it looks like they might need changes to make the test pass.
* TestExpectations:
* fast/events/keyboardevent-modifier-expected.txt: Added.
* fast/events/keyboardevent-modifier.html: Added.
* platform/gtk/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/gtk/WebEventFactory.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
Added Paths
trunk/LayoutTests/fast/events/keyboardevent-modifier-expected.txt
trunk/LayoutTests/fast/events/keyboardevent-modifier.html
Diff
Modified: trunk/LayoutTests/ChangeLog (272488 => 272489)
--- trunk/LayoutTests/ChangeLog 2021-02-08 13:31:56 UTC (rev 272488)
+++ trunk/LayoutTests/ChangeLog 2021-02-08 13:52:53 UTC (rev 272489)
@@ -1,3 +1,18 @@
+2021-02-08 Manuel Rego Casasnovas
+
+[GTK] event.ctrlKey and other are false in keydown event
+https://bugs.webkit.org/show_bug.cgi?id=221456
+
+Reviewed by Adrian Perez de Castro.
+
+The test only pass in GTK right now, despite testing it manually works fine in all platforms,
+it looks like they might need changes to make the test pass.
+
+* TestExpectations:
+* fast/events/keyboardevent-modifier-expected.txt: Added.
+* fast/events/keyboardevent-modifier.html: Added.
+* platform/gtk/TestExpectations:
+
2021-02-08 Philippe Normand
Permission request API for MediaKeySystem access support
Modified: trunk/LayoutTests/TestExpectations (272488 => 272489)
--- trunk/LayoutTests/TestExpectations 2021-02-08 13:31:56 UTC (rev 272488)
+++ trunk/LayoutTests/TestExpectations 2021-02-08 13:52:53 UTC (rev 272489)
@@ -985,6 +985,7 @@
fast/misc/valid-primary-screen-displayID.html [ Skip ]
fast/events/detect-caps-lock.html [ Skip ]
+fast/events/keyboardevent-modifier.html [ Skip ]
fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-after-hiding-auto-fill-strong-password-button.html [ Skip ]
fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html [ Skip ]
fast/forms/password-scrolled-after-caps-lock-toggled.html [ Skip ]
Added: trunk/LayoutTests/fast/events/keyboardevent-modifier-expected.txt (0 => 272489)
--- trunk/LayoutTests/fast/events/keyboardevent-modifier-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/keyboardevent-modifier-expected.txt 2021-02-08 13:52:53 UTC (rev 272489)
@@ -0,0 +1,9 @@
+
+
+PASS Check key: leftControl - event.key: Control
+PASS Check key: rightControl - event.key: Control
+PASS Check key: leftAlt - event.key: Alt
+PASS Check key: rightAlt - event.key: Alt
+PASS Check key: leftShift - event.key: Shift
+PASS Check key: rightShift - event.key: Shift
+
Added: trunk/LayoutTests/fast/events/keyboardevent-modifier.html (0 => 272489)
--- trunk/LayoutTests/fast/events/keyboardevent-modifier.html (rev 0)
+++ trunk/LayoutTests/fast/events/keyboardevent-modifier.html 2021-02-08 13:52:53 UTC (rev 272489)
@@ -0,0 +1,28 @@
+
+
+<script>
+var input = document.getElementById("testInput");
+input.focus();
+
+function sendKeyAndTest(key, ctrlKey, altKey, shiftKey)
+{
+input._onkeydown_ = function(event) {
+test(function() {
+ assert_equals(event.ctrlKey, ctrlKey, "event.ctrlKey is: " + ctrlKey ? "true" : "false");
+ assert_equals(event.altKey, altKey, "event.altKey is: " + altKey ? "true" : "false");
+ assert_equals(event.shiftKey, shiftKey, "event.shiftKey is: " + shiftKey ? "true" : "false");
+}, "Check key: "
[webkit-changes] [272007] trunk/LayoutTests
Title: [272007] trunk/LayoutTests Revision 272007 Author r...@igalia.com Date 2021-01-28 02:20:15 -0800 (Thu, 28 Jan 2021) Log Message [selectors] Update :focus-visible tests from WPT https://bugs.webkit.org/show_bug.cgi?id=221037 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: * web-platform-tests/css/selectors/focus-visible-007-expected.txt: * web-platform-tests/css/selectors/focus-visible-007.html: * web-platform-tests/css/selectors/focus-visible-011.html: * web-platform-tests/css/selectors/focus-visible-013-expected.txt: Added. * web-platform-tests/css/selectors/focus-visible-013.html: Added. * web-platform-tests/css/selectors/focus-visible-017-expected.txt: Added. * web-platform-tests/css/selectors/focus-visible-017.html: Added. * web-platform-tests/css/selectors/focus-visible-018-expected.txt: Added. * web-platform-tests/css/selectors/focus-visible-018.html: Added. * web-platform-tests/css/selectors/w3c-import.log: LayoutTests: * TestExpectations: focus-visible-007.html has been fixed upstream and doesn't need to be skipped now. * platform/ios/TestExpectations: Skip focus-visible-013.html as it timeouts in iOS. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-007-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-007.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-011.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log trunk/LayoutTests/platform/ios/TestExpectations Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-013-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-013.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-017.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-018-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-018.html Diff Modified: trunk/LayoutTests/ChangeLog (272006 => 272007) --- trunk/LayoutTests/ChangeLog 2021-01-28 09:20:41 UTC (rev 272006) +++ trunk/LayoutTests/ChangeLog 2021-01-28 10:20:15 UTC (rev 272007) @@ -1,3 +1,15 @@ +2021-01-28 Manuel Rego Casasnovas + +[selectors] Update :focus-visible tests from WPT +https://bugs.webkit.org/show_bug.cgi?id=221037 + +Reviewed by Javier Fernandez. + +* TestExpectations: focus-visible-007.html has been fixed upstream + and doesn't need to be skipped now. +* platform/ios/TestExpectations: Skip focus-visible-013.html + as it timeouts in iOS. + 2021-01-27 Antoine Quint REGRESSION(r268615): images flicker on apple.com/ios/ios-14 Modified: trunk/LayoutTests/TestExpectations (272006 => 272007) --- trunk/LayoutTests/TestExpectations 2021-01-28 09:20:41 UTC (rev 272006) +++ trunk/LayoutTests/TestExpectations 2021-01-28 10:20:15 UTC (rev 272007) @@ -1233,7 +1233,6 @@ webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Skip ] webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Skip ] webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Skip ] -webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-007.html [ Skip ] # Test issues, see https://crbug.com/976438. webkit.org/b/217904 imported/w3c/web-platform-tests/css/selectors/is-where-visited.html [ ImageOnlyFailure ] webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html [ ImageOnlyFailure ] webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-002.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272006 => 272007) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-01-28 09:20:41 UTC (rev 272006) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-01-28 10:20:15 UTC (rev 272007) @@ -1,3 +1,21 @@ +2021-01-28 Manuel Rego Casasnovas + +[selectors] Update :focus-visible tests from WPT +https://bugs.webkit.org/show_bug.cgi?id=221037 + +Reviewed by Javier Fernandez. + +* web-platform-tests/css/selectors/focus-visible-007-expected.txt: +* web-platform-tests/css/selectors/focus-visible-007.html: +* web-platform-tests/css/selectors/focus-visible-011.html: +* web-platform-tests/css/selectors/focus-visible-013-expected.txt: Added. +* web-platform-tests/css/selectors/focus-visible-013.html: Added. +* web-platform-tests/css/selectors/focus-visible-017-expected.txt: Added. +* web-platform-tests/css/selectors/focus-vi
[webkit-changes] [271944] trunk/LayoutTests
Title: [271944] trunk/LayoutTests Revision 271944 Author r...@igalia.com Date 2021-01-27 03:41:20 -0800 (Wed, 27 Jan 2021) Log Message Upstream to WPT Shadow DOM tests related to :focus pseudo-class https://bugs.webkit.org/show_bug.cgi?id=220907 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: These tests landed originally in r250788 (bug #202432). * web-platform-tests/shadow-dom/focus/focus-pseudo-matches-on-shadow-host-expected.txt: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt. * web-platform-tests/shadow-dom/focus/focus-pseudo-matches-on-shadow-host.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host.html. Removed workaround to wait until :focus matches on "focus" event, as that has been fixed in r271146 (bug #220243). * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-1-expected.xht: Added. * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-1.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-1.html. * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-2-expected.xht: Added. * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-2.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-2.html. * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3-expected.xht: Added. * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html. LayoutTests: * fast/shadow-dom/focus-pseudo-on-shadow-host-1-expected.html: Removed. * fast/shadow-dom/focus-pseudo-on-shadow-host-2-expected.html: Removed. * fast/shadow-dom/focus-pseudo-on-shadow-host-3-expected.html: Removed. * platform/ios/TestExpectations: Mark the new exported tests as passing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-matches-on-shadow-host-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-matches-on-shadow-host.html trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-1-expected.xht trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-1.html trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-2-expected.xht trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3-expected.xht trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html Removed Paths trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host.html trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-1-expected.html trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-1.html trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-2-expected.html trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-2.html trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3-expected.html trunk/LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html Diff Modified: trunk/LayoutTests/ChangeLog (271943 => 271944) --- trunk/LayoutTests/ChangeLog 2021-01-27 11:06:21 UTC (rev 271943) +++ trunk/LayoutTests/ChangeLog 2021-01-27 11:41:20 UTC (rev 271944) @@ -1,3 +1,15 @@ +2021-01-27 Manuel Rego Casasnovas + +Upstream to WPT Shadow DOM tests related to :focus pseudo-class +https://bugs.webkit.org/show_bug.cgi?id=220907 + +Reviewed by Ryosuke Niwa. + +* fast/shadow-dom/focus-pseudo-on-shadow-host-1-expected.html: Removed. +* fast/shadow-dom/focus-pseudo-on-shadow-host-2-expected.html: Removed. +* fast/shadow-dom/focus-pseudo-on-shadow-host-3-expected.html: Removed. +* platform/ios/TestExpectations: Mark the new exported tests as passing. + 2021-01-27 Imanol Fernandez Complete WebXRRigidTransform implementation Deleted: trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt (271943 => 271944) --- trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt 2021-01-27 11:06:21 UTC (rev 271943) +++ trunk/LayoutTests/fast/shadow-dom/focus-pseudo-matches-on-shadow-host-expected.txt 2021-01-27 11:41:20 UTC (rev 271944) @@ -1,9 +0,0 @@ - - -PASS :focus must not match a shadow host with open mode shadow root that does not contain the focused element -PASS :focus must match a shadow host with open mode shadow root that contains the focused element -PASS :focus must not match a shadow host with open mode shad
[webkit-changes] [271671] trunk
Title: [271671] trunk
Revision 271671
Author r...@igalia.com
Date 2021-01-20 13:41:50 -0800 (Wed, 20 Jan 2021)
Log Message
[WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
https://bugs.webkit.org/show_bug.cgi?id=220578
Reviewed by Javier Fernandez.
Source/WebCore:
Dispatch "focus" event for form controls when they are focused via mouse click.
This was already done in GTK+ but was not yet in WPE.
This works different on Mac ports as it's a particularity of how focus works on Mac platforms
(see https://webkit.org/b/22261 for details).
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isMouseFocusable const): Add PLATFORM(WPE).
LayoutTests:
* platform/wpe/TestExpectations: Unskip tests that are not failing anymore.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (271670 => 271671)
--- trunk/LayoutTests/ChangeLog 2021-01-20 21:27:07 UTC (rev 271670)
+++ trunk/LayoutTests/ChangeLog 2021-01-20 21:41:50 UTC (rev 271671)
@@ -1,3 +1,12 @@
+2021-01-20 Manuel Rego Casasnovas
+
+[WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
+https://bugs.webkit.org/show_bug.cgi?id=220578
+
+Reviewed by Javier Fernandez.
+
+* platform/wpe/TestExpectations: Unskip tests that are not failing anymore.
+
2021-01-20 Alex Christensen
Fix nullptr dereference introduced in r268228
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (271670 => 271671)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2021-01-20 21:27:07 UTC (rev 271670)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-01-20 21:41:50 UTC (rev 271671)
@@ -167,10 +167,6 @@
# Flexbox layout
webkit.org/b/215502 fast/flexbox/image-percent-max-height.html [ Failure Pass ImageOnlyFailure ]
-# Focus-visible
-webkit.org/b/220578 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Failure ]
-webkit.org/b/220578 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Failure ]
-
# Link target
webkit.org/b/218553 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html [ Timeout ]
webkit.org/b/212083 loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag-from-subframe.html
Modified: trunk/Source/WebCore/ChangeLog (271670 => 271671)
--- trunk/Source/WebCore/ChangeLog 2021-01-20 21:27:07 UTC (rev 271670)
+++ trunk/Source/WebCore/ChangeLog 2021-01-20 21:41:50 UTC (rev 271671)
@@ -1,3 +1,19 @@
+2021-01-20 Manuel Rego Casasnovas
+
+[WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
+https://bugs.webkit.org/show_bug.cgi?id=220578
+
+Reviewed by Javier Fernandez.
+
+Dispatch "focus" event for form controls when they are focused via mouse click.
+This was already done in GTK+ but was not yet in WPE.
+
+This works different on Mac ports as it's a particularity of how focus works on Mac platforms
+(see https://webkit.org/b/22261 for details).
+
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::isMouseFocusable const): Add PLATFORM(WPE).
+
2021-01-20 Youenn Fablet
Two pages in the same process should not be able to play media stream backed video elements at the same time
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (271670 => 271671)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2021-01-20 21:27:07 UTC (rev 271670)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2021-01-20 21:41:50 UTC (rev 271671)
@@ -391,7 +391,7 @@
bool HTMLFormControlElement::isMouseFocusable() const
{
-#if PLATFORM(GTK)
+#if (PLATFORM(GTK) || PLATFORM(WPE))
return HTMLElement::isMouseFocusable();
#else
if (needsMouseFocusableQuirk())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [271395] trunk/LayoutTests
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-011.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-012-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-012.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-not-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-not.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log
trunk/LayoutTests/platform/glib/TestExpectations
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focusin-event-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-006-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-006.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-008-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-008.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-014-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-014.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-015-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-015.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-016-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-016.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-focus-visible-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-focus-visible.html
Removed Paths
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/selectors/
Diff
Modified: trunk/LayoutTests/ChangeLog (271394 => 271395)
--- trunk/LayoutTests/ChangeLog 2021-01-12 09:42:35 UTC (rev 271394)
+++ trunk/LayoutTests/ChangeLog 2021-01-12 10:42:26 UTC (rev 271395)
@@ -1,3 +1,16 @@
+2021-01-12 Manuel Rego Casasnovas
+
+[selectors] Update tests from WPT
+https://bugs.webkit.org/show_bug.cgi?id=220312
+
+Reviewed by Sergio Villar Senin.
+
+* TestExpectations: Unskip :focus-visible tests, except focus-visible-{002,003,004}.html
+because they timeout on Apple platforms, and focus-visible-007.html because
+it has some problems (see https://crbug.com/976438).
+* platform/glib/TestExpectations: Mark focus-visible-{002,003,004}.html as passing.
+* platform/glib/imported/w3c/web-platform-tests/css/selectors/focus-visible-009-expected.txt: Removed.
+
2021-01-12 Rob Buis
Null check CSSFilter::output()
Modified: trunk/LayoutTests/TestExpectations (271394 => 271395)
--- trunk/LayoutTests/TestExpectations 2021-01-12 09:42:35 UTC (rev 271394)
+++ trunk/LayoutTests/TestExpectations 2021-01-12 10:42:26 UTC (rev 271395)
@@ -1231,12 +1231,10 @@
imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-172b.xml [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-173a.xml [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-173b.xml [ ImageOnlyFailure ]
-webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html [ Skip ]
webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Skip ]
-webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-007.html [ Skip ]
-webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html [ Skip ]
-webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-010.html [ Skip ]
-webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-012.html [ Skip ]
+webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html [ Skip ]
+webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Skip ]
+webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-007.html [ Skip ] # Test issues, see https://crbug.com/976438.
webkit.org/b/217904 imported/w3c/web-platform-tests/css/selectors/is-where-visited.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-002.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (271394 => 271395)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-01-12 09:42:35
[webkit-changes] [271146] trunk
Title: [271146] trunk Revision 271146 Author r...@igalia.com Date 2021-01-05 05:39:54 -0800 (Tue, 05 Jan 2021) Log Message [selectors] :focus should match inside the focus event https://bugs.webkit.org/show_bug.cgi?id=220243 Reviewed by Frédéric Wang. LayoutTests/imported/w3c: Import focus-in-focus-event-001.html test from WPT. Rebaseline 2 tests: - focus-autofocus.html now passes after fixing this bug. - focus-visible-005.html now fails, but it was passing because it was not checking anything due to this bug. * web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt: Added. * web-platform-tests/css/selectors/focus-in-focus-event-001.html: Added. * web-platform-tests/css/selectors/focus-visible-005-expected.txt: Rebaseline. * web-platform-tests/css/selectors/w3c-import.log: * web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus-expected.txt: Rebaesline. Source/WebCore: Before this patch this was working different in WebKit than Chromium and Firefox. The specs are clear about the expected behavior for this: - From https://drafts.csswg.org/selectors-4/#the-focus-pseudo: "The :focus pseudo-class applies while an element has the focus" - From https://w3c.github.io/uievents/#event-type-focus: "The focus MUST be given to the element before the dispatch of this event type" A similar fix has been done on Blink in r201118 by (https://chromium.googlesource.com/chromium/src/+/cc49a6966f5ae6d89e86fbd3f53e4deea4e066ca). Test: imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001.html * dom/Document.cpp: (WebCore::Document::setFocusedElement): Just moved the call to m_focusedElement->setFocus(true) right before dispatching the events. LayoutTests: * TestExpectations: Skip some :focus-visible tests as current failure results depend on the platform. This issue has been fixed upstream in https://github.com/web-platform-tests/wpt/pull/27041 and these tests will be re-imported and unskipped in a follow-up patch. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-005-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-in-focus-event-001.html Diff Modified: trunk/LayoutTests/ChangeLog (271145 => 271146) --- trunk/LayoutTests/ChangeLog 2021-01-05 10:17:28 UTC (rev 271145) +++ trunk/LayoutTests/ChangeLog 2021-01-05 13:39:54 UTC (rev 271146) @@ -1,3 +1,15 @@ +2021-01-05 Manuel Rego Casasnovas + +[selectors] :focus should match inside the focus event +https://bugs.webkit.org/show_bug.cgi?id=220243 + +Reviewed by Frédéric Wang. + +* TestExpectations: Skip some :focus-visible tests as current failure results +depend on the platform. +This issue has been fixed upstream in https://github.com/web-platform-tests/wpt/pull/27041 +and these tests will be re-imported and unskipped in a follow-up patch. + 2021-01-04 Rob Buis Add missing support/refresh.sub.html Modified: trunk/LayoutTests/TestExpectations (271145 => 271146) --- trunk/LayoutTests/TestExpectations 2021-01-05 10:17:28 UTC (rev 271145) +++ trunk/LayoutTests/TestExpectations 2021-01-05 13:39:54 UTC (rev 271146) @@ -1230,7 +1230,11 @@ imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-172b.xml [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-173a.xml [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-173b.xml [ ImageOnlyFailure ] +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-001.html [ Skip ] webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Skip ] +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-007.html [ Skip ] +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-009.html [ Skip ] +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-010.html [ Skip ] webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-012.html [ Skip ] webkit.org/b/217904 imported/w3c/web-platform-tests/css/selectors/is-where-visited.html [ ImageOnlyFailure ] webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (271145 => 271146) --- trunk/LayoutTests/i
[webkit-changes] [270955] trunk
Title: [270955] trunk
Revision 270955
Author r...@igalia.com
Date 2020-12-17 15:21:58 -0800 (Thu, 17 Dec 2020)
Log Message
[selectors] Default namespace gets ignored inside non-type selectors for :is() and :not()
https://bugs.webkit.org/show_bug.cgi?id=219950
Reviewed by Antti Koivisto.
Source/WebCore:
Based on Blink r820500 and r820557 by .
Default namespace declarations do not affect the compound selector
representing the subject of any selector within a :is() or :not() pseudo-class,
unless that compound selector contains an explicit universal selector or type selector.
Spec: https://drafts.csswg.org/selectors-4/#matches
This patch aligns WebKit implementation with Chromium and Firefox, so two WPT tests pass now.
* css/parser/CSSSelectorParser.cpp:
(WebCore::atEndIgnoringWhitespace):
(WebCore::CSSSelectorParser::consumeCompoundSelector):
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::defaultNamespace const):
* css/parser/CSSSelectorParser.h:
LayoutTests:
* TestExpectations: Two WPT tests pass now.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
trunk/Source/WebCore/css/parser/CSSSelectorParser.h
Diff
Modified: trunk/LayoutTests/ChangeLog (270954 => 270955)
--- trunk/LayoutTests/ChangeLog 2020-12-17 23:19:51 UTC (rev 270954)
+++ trunk/LayoutTests/ChangeLog 2020-12-17 23:21:58 UTC (rev 270955)
@@ -1,3 +1,12 @@
+2020-12-17 Manuel Rego Casasnovas
+
+[selectors] Default namespace gets ignored inside non-type selectors for :is() and :not()
+https://bugs.webkit.org/show_bug.cgi?id=219950
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations: Two WPT tests pass now.
+
2020-12-17 Truitt Savell
Rebase http/tests/navigation/_javascript_link-frames.html for Big Sur
Modified: trunk/LayoutTests/TestExpectations (270954 => 270955)
--- trunk/LayoutTests/TestExpectations 2020-12-17 23:19:51 UTC (rev 270954)
+++ trunk/LayoutTests/TestExpectations 2020-12-17 23:21:58 UTC (rev 270955)
@@ -1233,9 +1233,7 @@
imported/w3c/web-platform-tests/css/selectors/old-tests/css3-modsel-173b.xml [ ImageOnlyFailure ]
webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Skip ]
webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-012.html [ Skip ]
-webkit.org/b/219950 imported/w3c/web-platform-tests/css/selectors/is-default-ns-002.html [ ImageOnlyFailure ]
webkit.org/b/217904 imported/w3c/web-platform-tests/css/selectors/is-where-visited.html [ ImageOnlyFailure ]
-webkit.org/b/219950 imported/w3c/web-platform-tests/css/selectors/not-default-ns-002.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-001.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-002.html [ ImageOnlyFailure ]
webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-change-003.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (270954 => 270955)
--- trunk/Source/WebCore/ChangeLog 2020-12-17 23:19:51 UTC (rev 270954)
+++ trunk/Source/WebCore/ChangeLog 2020-12-17 23:21:58 UTC (rev 270955)
@@ -1,3 +1,26 @@
+2020-12-17 Manuel Rego Casasnovas
+
+[selectors] Default namespace gets ignored inside non-type selectors for :is() and :not()
+https://bugs.webkit.org/show_bug.cgi?id=219950
+
+Reviewed by Antti Koivisto.
+
+Based on Blink r820500 and r820557 by .
+
+Default namespace declarations do not affect the compound selector
+representing the subject of any selector within a :is() or :not() pseudo-class,
+unless that compound selector contains an explicit universal selector or type selector.
+Spec: https://drafts.csswg.org/selectors-4/#matches
+
+This patch aligns WebKit implementation with Chromium and Firefox, so two WPT tests pass now.
+
+* css/parser/CSSSelectorParser.cpp:
+(WebCore::atEndIgnoringWhitespace):
+(WebCore::CSSSelectorParser::consumeCompoundSelector):
+(WebCore::CSSSelectorParser::consumePseudo):
+(WebCore::CSSSelectorParser::defaultNamespace const):
+* css/parser/CSSSelectorParser.h:
+
2020-12-17 Eric Carlson
[Cocoa] WebM format reader doesn't work with a url in a element
Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp (270954 => 270955)
--- trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2020-12-17 23:19:51 UTC (rev 270954)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2020-12-17 23:21:58 UTC (rev 270955)
@@ -32,6 +32,7 @@
#include
#include
+#include
#include
namespace WebCore {
@@ -324,6 +325,12 @@
return isPseudoClassValidAfterPseudoElement(pseudo, compoundPseudoElement);
}
[webkit-changes] [259562] trunk
Title: [259562] trunk Revision 259562 Author r...@igalia.com Date 2020-04-05 21:14:17 -0700 (Sun, 05 Apr 2020) Log Message Computed style for "outline-offset" is wrong when "outline-style" is "none" https://bugs.webkit.org/show_bug.cgi?id=209913 Reviewed by Daniel Bates. LayoutTests/imported/w3c: Imported css/css-ui/parsing/outline-offset-computed.html from WPT. And update baselines for web-animations tests. * web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt: Added. * web-platform-tests/css/css-ui/parsing/outline-offset-computed.html: Added. * web-platform-tests/css/css-ui/parsing/w3c-import.log: * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: Source/WebCore: Computed style for outline-offset was not returning the proper value if "outline-style" was "none". This was due to a check in RenderStyle::outlineOffset() that this patch removes. This code could be there because this is needed for "outline-width" as specified in the spec (https://drafts.csswg.org/css-ui/#outline-props), however there's nothing about this on the "outline-offset" property. Test: imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed.html * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::outlineOffset const): LayoutTests: Update baselines for web-animations tests. * platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: * platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: * platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/w3c-import.log trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/style/RenderStyle.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-offset-computed.html Diff Modified: trunk/LayoutTests/ChangeLog (259561 => 259562) --- trunk/LayoutTests/ChangeLog 2020-04-06 04:02:43 UTC (rev 259561) +++ trunk/LayoutTests/ChangeLog 2020-04-06 04:14:17 UTC (rev 259562) @@ -1,3 +1,16 @@ +2020-04-05 Manuel Rego Casasnovas + +Computed style for "outline-offset" is wrong when "outline-style" is "none" +https://bugs.webkit.org/show_bug.cgi?id=209913 + +Reviewed by Daniel Bates. + +Update baselines for web-animations tests. + +* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: +* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: +* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: + 2020-04-05 Alexey Shvayka Octal escapes should be max 3 digits and syntax errors in Unicode patterns Modified: trunk/LayoutTests/imported/w3c/ChangeLog (259561 => 259562) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-04-06 04:02:43 UTC (rev 259561) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-04-06 04:14:17 UTC (rev 259562) @@ -1,3 +1,20 @@ +2020-04-05 Manuel Rego Casasnovas + +Computed style for "outline-offset" is wrong when "outline-style" is "none" +https://bugs.webkit.org/show_bug.cgi?id=209913 + +Reviewed by Daniel Bates. + +Imported css
[webkit-changes] [252913] trunk/Source/WebCore
Title: [252913] trunk/Source/WebCore
Revision 252913
Author r...@igalia.com
Date 2019-11-27 15:07:46 -0800 (Wed, 27 Nov 2019)
Log Message
Using char* instead of String for StyleProperties::getShorthandValue()
https://bugs.webkit.org/show_bug.cgi?id=204644
Reviewed by Darin Adler.
This is follow-up patch for r252901. We don't need to create a String object
just for the separator and can use char* instead.
This was suggested by Darin Adler in webkit.org/b/204508.
* css/StyleProperties.cpp:
(WebCore::StyleProperties::getShorthandValue const):
* css/StyleProperties.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleProperties.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (252912 => 252913)
--- trunk/Source/WebCore/ChangeLog 2019-11-27 21:41:57 UTC (rev 252912)
+++ trunk/Source/WebCore/ChangeLog 2019-11-27 23:07:46 UTC (rev 252913)
@@ -1,3 +1,18 @@
+2019-11-27 Manuel Rego Casasnovas
+
+Using char* instead of String for StyleProperties::getShorthandValue()
+https://bugs.webkit.org/show_bug.cgi?id=204644
+
+Reviewed by Darin Adler.
+
+This is follow-up patch for r252901. We don't need to create a String object
+just for the separator and can use char* instead.
+This was suggested by Darin Adler in webkit.org/b/204508.
+
+* css/StyleProperties.cpp:
+(WebCore::StyleProperties::getShorthandValue const):
+* css/StyleProperties.h:
+
2019-11-27 Zalan Bujtas
[LFC] Run layout on the root when InvalidationState is empty.
Modified: trunk/Source/WebCore/css/StyleProperties.cpp (252912 => 252913)
--- trunk/Source/WebCore/css/StyleProperties.cpp 2019-11-27 21:41:57 UTC (rev 252912)
+++ trunk/Source/WebCore/css/StyleProperties.cpp 2019-11-27 23:07:46 UTC (rev 252913)
@@ -655,7 +655,7 @@
return getShorthandValue(shorthand, " / ");
}
-String StyleProperties::getShorthandValue(const StylePropertyShorthand& shorthand, const String& separator) const
+String StyleProperties::getShorthandValue(const StylePropertyShorthand& shorthand, const char* separator) const
{
String commonValue;
StringBuilder result;
Modified: trunk/Source/WebCore/css/StyleProperties.h (252912 => 252913)
--- trunk/Source/WebCore/css/StyleProperties.h 2019-11-27 21:41:57 UTC (rev 252912)
+++ trunk/Source/WebCore/css/StyleProperties.h 2019-11-27 23:07:46 UTC (rev 252913)
@@ -160,7 +160,7 @@
private:
String getGridShorthandValue(const StylePropertyShorthand&) const;
-String getShorthandValue(const StylePropertyShorthand&, const String& separator = " ") const;
+String getShorthandValue(const StylePropertyShorthand&, const char* separator = " ") const;
String getCommonValue(const StylePropertyShorthand&) const;
String getAlignmentShorthandValue(const StylePropertyShorthand&) const;
String borderPropertyValue(const StylePropertyShorthand&, const StylePropertyShorthand&, const StylePropertyShorthand&) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252901] trunk
Title: [252901] trunk Revision 252901 Author r...@igalia.com Date 2019-11-27 04:44:20 -0800 (Wed, 27 Nov 2019) Log Message [css-grid] Serialization of grid-area, grid-row and grid-column should include "/" separator https://bugs.webkit.org/show_bug.cgi?id=204508 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: After this patch several test cases are passing. There are still failures as the serialization is still not the right one in all the cases, but this makes WebKit behave like Chromium for these shorthands. * web-platform-tests/css/css-grid/grid-layout-properties-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt: Source/WebCore: Just use "/" separator instead of a white space when serializing the grid shorthands. There are still failures because serialization of grid shorthands still needs some extra work (see webkit.org/b/204611), however this change puts WebKit in the same status than Chromium regarding this topic. Several WPT test cases are passing thanks to this change. * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::getGridShorthandValue const): (WebCore::StyleProperties::getShorthandValue const): * css/StyleProperties.h: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/StyleProperties.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (252900 => 252901) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-27 12:24:54 UTC (rev 252900) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-27 12:44:20 UTC (rev 252901) @@ -1,3 +1,19 @@ +2019-11-27 Manuel Rego Casasnovas + +[css-grid] Serialization of grid-area, grid-row and grid-column should include "/" separator +https://bugs.webkit.org/show_bug.cgi?id=204508 + +Reviewed by Javier Fernandez. + +After this patch several test cases are passing. +There are still failures as the serialization is still not the right one in all the cases, +but this makes WebKit behave like Chromium for these shorthands. + +* web-platform-tests/css/css-grid/grid-layout-properties-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt: + 2019-11-26 Manuel Rego Casasnovas [css-grid] Avoid serializing [] in grid-template* specified values Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt (252900 => 252901) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt 2019-11-27 12:24:54 UTC (rev 252900) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt 2019-11-27 12:44:20 UTC (rev 252901) @@ -33,10 +33,10 @@ PASS grid-template FAIL grid-template.initial assert_equals: initial value of grid-template should be 150px / 50px 50px 50px expected "150px / 50px 50px 50px" but got "50px 50px 50px / 150px / none" FAIL grid-template.none assert_equals: none expected "150px / 50px 50px 50px" but got "50px 50px 50px / 150px / none" -FAIL grid-template. / assert_equals: / expected "100px 100px / 200px 200px" but got "100px 100px 200px 200px none" -FAIL grid-template. assert_equals: expected "[a] auto [b] auto [c] / [d] auto [e] auto [f]" but got "[a] auto [b] auto [c] [d] auto [e] auto [f] none" -FAIL grid-template.+ assert_equals: + expected "\"a b\" \"a b\"" but got "auto auto none \"a b\" \"a b\"" -FAIL grid-template.+ assert_equals: + expected "100px / \"a b\" 50px" but got "auto auto none \"a b\" \"a b\"" +FAIL grid-template. / assert_equals: / expected "100px 100px / 200px 200px" but got "100px 100px / 200px 200px / none" +FAIL grid-template. assert_equals: expected "[a] auto [b] auto [c] / [d] auto [e] auto [f]" but got "[a] auto [b] auto [c] / [d] auto [e] auto [f]
[webkit-changes] [252883] trunk
Title: [252883] trunk Revision 252883 Author r...@igalia.com Date 2019-11-26 04:09:04 -0800 (Tue, 26 Nov 2019) Log Message LayoutTests/imported/w3c: [css-grid] Avoid serializing [] in grid-template* specified values https://bugs.webkit.org/show_bug.cgi?id=204501 Reviewed by Javier Fernandez. Update tests results, several tests are now passing. Other are still failing due to different bugs like webkit.org/b/204508. * web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-template-columns-valid-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-template-rows-valid-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-template-shorthand-expected.txt: * web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt: Source/WebCore: [css-grid] Avoid serializing [] in grid-template-* specified values https://bugs.webkit.org/show_bug.cgi?id=204501 Reviewed by Javier Fernandez. Based on Blink r699101 by . This patch discards empty list of line names when parsing grid-template-* properties. That way we avoid these empty lists "[]" during serialization. This was discussed at: https://github.com/w3c/csswg-drafts/issues/4173. Several WPT tests are passing thanks to this change. * css/parser/CSSPropertyParser.cpp: (WebCore::consumeGridLineNames): (WebCore::consumeGridTrackList): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-rows-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (252882 => 252883) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-26 11:02:24 UTC (rev 252882) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-11-26 12:09:04 UTC (rev 252883) @@ -1,3 +1,20 @@ +2019-11-26 Manuel Rego Casasnovas + +[css-grid] Avoid serializing [] in grid-template* specified values +https://bugs.webkit.org/show_bug.cgi?id=204501 + +Reviewed by Javier Fernandez. + +Update tests results, several tests are now passing. +Other are still failing due to different bugs like webkit.org/b/204508. + +* web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-template-columns-valid-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-template-rows-valid-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-template-shorthand-expected.txt: +* web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt: + 2019-11-25 Manuel Rego Casasnovas [css-grid] Updating WPT parsing tests Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt (252882 => 252883) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt 2019-11-26 11:02:24 UTC (rev 252882) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt 2019-11-26 12:09:04 UTC (rev 252883) @@ -38,8 +38,8 @@ FAIL e.style['grid'] = " [] \"a a a\" [] [] \"b b b\" 1fr [] / [] auto 1fr [] auto []" should set grid-auto-flow assert_equals: grid-auto-flow should be canonical expected "row" but got "initial" FAIL e.style['grid'] = " [] \"a a a\" [] [] \"b b b\" 1fr [] / [] auto 1fr [] auto []" should set grid-auto-rows assert_equals: grid-auto-rows should be canonical expected "auto" but got "initial" PASS e.style['grid'] = " [] \"a a a\" [] [] \"b b b\" 1fr [] / [] auto 1fr [] auto []" should set grid-template-areas -FAIL e.style['grid'] = " [] \"a a a\" [] [] \"b b b\" 1fr [] / [] auto 1fr [] auto []" should set grid-template-columns assert_equals: grid-template-columns should be canonical expected "auto 1fr auto" but got "[] auto 1fr [] auto []" -FAIL e.style['grid'] = " [] \"a a a\" [] [] \"b b b\" 1f
[webkit-changes] [245279] trunk
Title: [245279] trunk Revision 245279 Author r...@igalia.com Date 2019-05-14 08:08:46 -0700 (Tue, 14 May 2019) Log Message [css-grid] Use max size to compute auto repeat tracks https://bugs.webkit.org/show_bug.cgi?id=197854 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: Imported WPT tests for this bug. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002-expected.txt: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001-expected.txt: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001.html: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001-expected.txt: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002-expected.txt: Added. * web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html: Added. * web-platform-tests/css/css-grid/grid-definition/w3c-import.log: Source/WebCore: When available size is indefinite we should use max size to compute the number of auto repeat tracks. The spec text is very clear (https://drafts.csswg.org/css-grid/#auto-repeat): > When auto-fill is given as the repetition number, if the grid container > has a definite size or **max size** in the relevant axis... So far we were not doing that for widths, in this patch we modify RenderGrid::computeAutoRepeatTracksCount() to do the same than for heights. We also take advantage to fix problems related to min|max sizes and box-sizing property, that were inconsistent for columns and rows. Tests: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html * rendering/RenderGrid.cpp: (WebCore::RenderGrid::computeAutoRepeatTracksCount const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (245278 => 245279) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-14 15:07:19 UTC (rev 245278) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-14 15:08:46 UTC (rev 245279) @@ -1,3 +1,24 @@ +2019-05-14 Manuel Rego Casasnovas + +[css-grid] Use max size to compute auto repeat tracks +https://bugs.webkit.org/show_bug.cgi?id=197854 + +Reviewed by Javier Fernandez. + +Imported WPT tests for this bug. + +* web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt: Added. +* web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html: Added. +* web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002-expected.txt: Added. +* web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html: Added. +* web-platform-tests/css
[webkit-changes] [244213] trunk
trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderButton.cpp trunk/Source/WebCore/rendering/RenderButton.h trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp trunk/Source/WebCore/rendering/RenderGrid.cpp Added Paths trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins-1-expected.html trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins-1.html trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins-2-expected.html trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-flexbox-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-flexbox-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-grid-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-grid-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-inline-block-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-inline-block-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/w3c-import.log trunk/LayoutTests/platform/ios/css3/flexbox/flexbox-baseline-margins-expected.png trunk/LayoutTests/platform/mac/css3/flexbox/flexbox-baseline-margins-expected.png trunk/LayoutTests/platform/win/css3/flexbox/flexbox-baseline-margins-expected.png Removed Paths trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins-expected.html trunk/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html Diff Modified: trunk/LayoutTests/ChangeLog (244212 => 244213) --- trunk/LayoutTests/ChangeLog 2019-04-12 08:46:57 UTC (rev 244212) +++ trunk/LayoutTests/ChangeLog 2019-04-12 12:04:20 UTC (rev 244213) @@ -1,3 +1,30 @@ +2019-04-12 Manuel Rego Casasnovas + +[css-flex][css-grid] Fix synthesized baseline +https://bugs.webkit.org/show_bug.cgi?id=196312 + +Reviewed by Javier Fernandez. + +Some of the tests were not checking the right behavior changed them to test the expected one. +We need new rebaselines for some tests. + +* TestExpectations: +* css3/flexbox/flexbox-baseline-margins.html: +* fast/css-grid-layout/grid-baseline-expected.html: +* fast/css-grid-layout/grid-baseline-margins-1-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins-expected.html. +* fast/css-grid-layout/grid-baseline-margins-1.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins.html. +* fast/css-grid-layout/grid-baseline-margins-2-expected.html: Added. +* fast/css-grid-layout/grid-baseline-margins-2.html: Added. +* fast/css-grid-layout/grid-baseline.html: This test is modified and split in two parts as it doesn't fit in the viewport. +* platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.png: +* platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.txt: +* platform/ios/css3/flexbox/flexbox-baseline-margins-expected.png: Added. +* platform/ios/css3/flexbox/flexbox-baseline-margins-expected.txt: +* platform/mac/css3/flexbox/flexbox-baseline-margins-expected.png: Added. +* platform/mac/css3/flexbox/flexbox-baseline-margins-expected.txt: +* platform/win/css3/flexbox/flexbox-baseline-margins-expected.png: Added. +* platform/win/css3/flexbox/flexbox-baseline-margins-expected.txt: + 2019-04-11 Carlos Garcia Campos [GTK] REGRESSION(r243860): Many tests failing Modified: trunk/LayoutTests/TestExpectations (244212 => 244213) --- trunk/LayoutTests/TestExpectations 2019-04-12 08:46:57 UTC (rev 244212) +++ trunk/LayoutTests/TestExpectations 2019-04-12 12:04:20 UTC (rev 244213) @@ -614,8 +614,6 @@ webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFailure ] # grid layout tests -webkit.org/b/165062 fast/css-grid-layout/grid-baseline.html [ ImageOnlyFailure ] -webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ] webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html [ ImageOnlyFailure ] webkit.org/b/191465 imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/css3/flexbox/flexbox-baseline-margins.html (244212 => 244213) --- trunk/LayoutTests/css3/flexbox/flexbox-baseline-margins.html 2019-04-12 08:46:57 UTC (rev 244212)
[webkit-changes] [243883] trunk/LayoutTests
Title: [243883] trunk/LayoutTests Revision 243883 Author r...@igalia.com Date 2019-04-04 10:55:22 -0700 (Thu, 04 Apr 2019) Log Message [css-grid] Scroll reset position when updating inner html on content https://bugs.webkit.org/show_bug.cgi?id=191506 Unreviewed gardening. The problem described in this bug was fixed in r243687 (webkit.org/b/191506). This test was still marked as Failure but it has been passing since then. * TestExpectations: Remove fast/css-grid-layout/grid-item-scroll-position.html as it's passing now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (243882 => 243883) --- trunk/LayoutTests/ChangeLog 2019-04-04 17:50:25 UTC (rev 243882) +++ trunk/LayoutTests/ChangeLog 2019-04-04 17:55:22 UTC (rev 243883) @@ -1,3 +1,16 @@ +2019-04-04 Manuel Rego Casasnovas + +[css-grid] Scroll reset position when updating inner html on content +https://bugs.webkit.org/show_bug.cgi?id=191506 + +Unreviewed gardening. + +The problem described in this bug was fixed in r243687 (webkit.org/b/191506). +This test was still marked as Failure but it has been passing since then. + +* TestExpectations: Remove fast/css-grid-layout/grid-item-scroll-position.html +as it's passing now. + 2019-04-04 Shawn Roberts scrollingcoordinator/ios/ui-scroll-fixed.html is a flakky failure Modified: trunk/LayoutTests/TestExpectations (243882 => 243883) --- trunk/LayoutTests/TestExpectations 2019-04-04 17:50:25 UTC (rev 243882) +++ trunk/LayoutTests/TestExpectations 2019-04-04 17:55:22 UTC (rev 243883) @@ -633,7 +633,6 @@ webkit.org/b/191463 imported/w3c/web-platform-tests/css/css-grid/grid-items/explicitly-sized-grid-item-as-table.html webkit.org/b/191627 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html [ Failure ] webkit.org/b/149890 fast/css-grid-layout/grid-shorthands-style-format.html [ Failure ] -webkit.org/b/191506 fast/css-grid-layout/grid-item-scroll-position.html [ Failure ] webkit.org/b/191507 fast/css-grid-layout/positioned-grid-container-percentage-tracks.html [ Failure ] webkit.org/b/191508 fast/css-grid-layout/crash-large-positions.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [243687] trunk
Title: [243687] trunk
Revision 243687
Author r...@igalia.com
Date 2019-03-31 23:42:31 -0700 (Sun, 31 Mar 2019)
Log Message
Scroll position gets reset when overflow:scroll is inside grid
https://bugs.webkit.org/show_bug.cgi?id=196337
Reviewed by Simon Fraser.
Fix scroll position when there are changes inside a grid item with "overflow: scroll".
Source/WebCore:
Test: fast/css-grid-layout/grid-item-content-scroll-position.html
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Use beginUpdateScrollInfoAfterLayoutTransaction()
and endAndCommitUpdateScrollInfoAfterLayoutTransaction().
LayoutTests:
* fast/css-grid-layout/grid-item-content-scroll-position-expected.txt: Added.
* fast/css-grid-layout/grid-item-content-scroll-position.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
Added Paths
trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position.html
Diff
Modified: trunk/LayoutTests/ChangeLog (243686 => 243687)
--- trunk/LayoutTests/ChangeLog 2019-04-01 02:03:14 UTC (rev 243686)
+++ trunk/LayoutTests/ChangeLog 2019-04-01 06:42:31 UTC (rev 243687)
@@ -1,3 +1,16 @@
+2019-03-31 Manuel Rego Casasnovas
+
+Scroll position gets reset when overflow:scroll is inside grid
+https://bugs.webkit.org/show_bug.cgi?id=196337
+
+
+Reviewed by Simon Fraser.
+
+Fix scroll position when there are changes inside a grid item with "overflow: scroll".
+
+* fast/css-grid-layout/grid-item-content-scroll-position-expected.txt: Added.
+* fast/css-grid-layout/grid-item-content-scroll-position.html: Added.
+
2019-03-31 Wenson Hsieh
[iOS] Crash when changing inputmode for certain types of focusable elements
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position-expected.txt (0 => 243687)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position-expected.txt 2019-04-01 06:42:31 UTC (rev 243687)
@@ -0,0 +1,4 @@
+
+PASS Checks that scroll position is kept when an element inside a grid item is showed.
+foo
+bar
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position.html (0 => 243687)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-content-scroll-position.html 2019-04-01 06:42:31 UTC (rev 243687)
@@ -0,0 +1,42 @@
+
+
+#grid {
+ display: grid;
+ height: 200px;
+}
+#item {
+ overflow: scroll;
+}
+#content {
+ height: 800px;
+}
+
+#bar {
+ display: none;
+ margin-top: 200px;
+}
+
+</div>
+
+<div id="grid">
+ <div id="item">
+<div id="content">
+ <div>foo</div>
+ <div id="bar">bar</div>
+</div>
+ </div>
+</div>
+
+<script>
+_onload_ = () => {
+ var item = document.getElementById("item");
+ item.scrollTo(0, 200);
+ document.getElementById("bar").style.display = "block";
+ test(() => {
+assert_equals(item.scrollTop, 200);
+ }, "Checks that scroll position is kept when an element inside a grid item is showed.");
+};
+
Modified: trunk/Source/WebCore/ChangeLog (243686 => 243687)
--- trunk/Source/WebCore/ChangeLog 2019-04-01 02:03:14 UTC (rev 243686)
+++ trunk/Source/WebCore/ChangeLog 2019-04-01 06:42:31 UTC (rev 243687)
@@ -1,3 +1,19 @@
+2019-03-31 Manuel Rego Casasnovas
+
+Scroll position gets reset when overflow:scroll is inside grid
+https://bugs.webkit.org/show_bug.cgi?id=196337
+
+
+Reviewed by Simon Fraser.
+
+Fix scroll position when there are changes inside a grid item with "overflow: scroll".
+
+Test: fast/css-grid-layout/grid-item-content-scroll-position.html
+
+* rendering/RenderGrid.cpp:
+(WebCore::RenderGrid::layoutBlock): Use beginUpdateScrollInfoAfterLayoutTransaction()
+and endAndCommitUpdateScrollInfoAfterLayoutTransaction().
+
2019-03-31 Ryosuke Niwa
Reduce the size of Node::deref by eliminating an explicit parentNode check
Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (243686 => 243687)
--- trunk/Source/WebCore/rendering/RenderGrid.cpp 2019-04-01 02:03:14 UTC (rev 243686)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp 2019-04-01 06:42:31 UTC (rev 243687)
@@ -188,6 +188,7 @@
LayoutStateMaintainer statePusher(*this, locationOffset(), hasTransform() || hasReflection() || style().isFlippedBlocksWritingMode());
preparePaginationBeforeBlockLayout(relayoutChildren);
+
[webkit-changes] [243432] trunk
Title: [243432] trunk
Revision 243432
Author r...@igalia.com
Date 2019-03-25 00:46:54 -0700 (Mon, 25 Mar 2019)
Log Message
[css-grid] Fix grid container baseline alignment for orthogonal items
https://bugs.webkit.org/show_bug.cgi?id=196141
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
Imported test from WPT. This patch is making some of the test cases pass but not all.
Some are still failing in WebKit as it never uses the central baseline on vertical writing modes (bug #94410),
also "text-orientation" is not supported yet in WebKit (bug #196139),
even the prefixed version "-webkit-text-orientation" doesn't fix anything in this test case.
* web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt: Added.
* web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html: Added.
* web-platform-tests/css/css-grid/alignment/w3c-import.log:
Source/WebCore:
Grid container baseline was wrongly computed when done in reference to an orthogonal item.
Test: imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::firstLineBaseline const): Simple change to use logicalTopForChild()
so it takes into account grid container and item writing modes.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (243431 => 243432)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-03-25 06:24:45 UTC (rev 243431)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-03-25 07:46:54 UTC (rev 243432)
@@ -1,3 +1,19 @@
+2019-03-25 Manuel Rego Casasnovas
+
+[css-grid] Fix grid container baseline alignment for orthogonal items
+https://bugs.webkit.org/show_bug.cgi?id=196141
+
+Reviewed by Javier Fernandez.
+
+Imported test from WPT. This patch is making some of the test cases pass but not all.
+Some are still failing in WebKit as it never uses the central baseline on vertical writing modes (bug #94410),
+also "text-orientation" is not supported yet in WebKit (bug #196139),
+even the prefixed version "-webkit-text-orientation" doesn't fix anything in this test case.
+
+* web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt: Added.
+* web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html: Added.
+* web-platform-tests/css/css-grid/alignment/w3c-import.log:
+
2019-03-22 Alicia Boya García
[MSE][GStreamer] Don't construct segments on PlaybackPipeline::flush
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt (0 => 243432)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001-expected.txt 2019-03-25 07:46:54 UTC (rev 243432)
@@ -0,0 +1,75 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+PASS .wrapper 1
+PASS .wrapper 2
+FAIL .wrapper 3 assert_equals:
+
+
+
+
+
+
+
+
+
+offsetLeft expected 65 but got 75
+FAIL .wrapper 4 assert_equals:
+
+
+
+
+
+
+
+
+
+offsetLeft expected 65 but got 75
+PASS .wrapper 5
+PASS .wrapper 6
+FAIL .wrapper 7 assert_equals:
+
+
+
+
+
+
+
+
+
+offsetLeft expected 65 but got 75
+FAIL .wrapper 8 assert_equals:
+
+
+
+
+
+
+
+
+
+offsetLeft expected 65 but got 75
+PASS .wrapper 9
+PASS .wrapper 10
+PASS .wrapper 11
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html (0 => 243432)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-container-baseline-001.html 2019-03-25 07:46:54 UTC (rev 243432)
@@ -0,0 +1,153 @@
+
+
+CSS Grid Layout Test: Grid container baseline
+
+
+.wrapper {
+ position: relative;
+ margin: 10px;
+}
+
+.grid {
+ display: inline-grid;
+ grid-auto-flow: column;
+ background: grey;
+}
+
+.i1 {
+ width: 150px;
+ height: 100px;
+ background: magenta;
+}
+
+.i2 {
+ align-self: baseline;
+ width: 75px;
+ height: 50px;
+ background: cyan;
+}
+
+.i3 {
+ width: 100px;
+ height: 75px;
+ background: yellow;
+}
+
+
[webkit-changes] [239502] trunk
Title: [239502] trunk Revision 239502 Author r...@igalia.com Date 2018-12-21 04:29:57 -0800 (Fri, 21 Dec 2018) Log Message [css-grid] Fix percentages in relative offsets for grid items https://bugs.webkit.org/show_bug.cgi?id=190492 Reviewed by Sergio Villar Senin. LayoutTests/imported/w3c: * web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: Update expected file as we're now passing this test. Source/WebCore: The method RenderBoxModelObject::relativePositionOffset() was not considering the case of grid items, where the containing block is the grid area. The patch modifies the method so the new code uses overrideContainingBlockContentWidth|Height when required. Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html * rendering/RenderBox.cpp: Implement the physical versions of the already existent methods. (WebCore::RenderBox::overrideContainingBlockContentWidth const): (WebCore::RenderBox::overrideContainingBlockContentHeight const): (WebCore::RenderBox::hasOverrideContainingBlockContentWidth const): (WebCore::RenderBox::hasOverrideContainingBlockContentHeight const): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffset const): Modified method to take into account overrideContainingBlockContentWidth|Height for grid items. * rendering/RenderBoxModelObject.h: Added new headers for physical virtual methods that will be overridden in RenderBox. (WebCore::RenderBoxModelObject::overrideContainingBlockContentWidth const): (WebCore::RenderBoxModelObject::overrideContainingBlockContentHeight const): (WebCore::RenderBoxModelObject::hasOverrideContainingBlockContentWidth const): (WebCore::RenderBoxModelObject::hasOverrideContainingBlockContentHeight const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (239501 => 239502) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-12-21 11:47:28 UTC (rev 239501) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-12-21 12:29:57 UTC (rev 239502) @@ -1,3 +1,13 @@ +2018-12-21 Manuel Rego Casasnovas + +[css-grid] Fix percentages in relative offsets for grid items +https://bugs.webkit.org/show_bug.cgi?id=190492 + +Reviewed by Sergio Villar Senin. + +* web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: + Update expected file as we're now passing this test. + 2018-12-19 Youenn Fablet Remove RTCRtpTransceiver.setDirection Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt (239501 => 239502) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt 2018-12-21 11:47:28 UTC (rev 239501) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt 2018-12-21 12:29:57 UTC (rev 239502) @@ -1,46 +1,10 @@ -FAIL .grid 1 assert_equals: - - - - - -offsetLeft expected 219 but got 240 -FAIL .grid 2 assert_equals: - - - - - -offsetLeft expected 219 but got 240 -FAIL .grid 3 assert_equals: - - - - - -offsetLeft expected 9 but got 30 -FAIL .grid 4 assert_equals: - - - - - -offsetLeft expected 9 but got 30 -FAIL .grid 5 assert_equals: - - - - - -offsetLeft expected 410 but got 430 -FAIL .grid 6 assert_equals: - - - - - -offsetLeft expected 10 but got 30 +PASS .grid 1 +PASS .grid 2 +PASS .grid 3 +PASS .grid 4 +PASS .grid 5 +PASS .grid 6 Direction LTR Direction RTL Modified: trunk/Source/WebCore/ChangeLog (239501 => 239502) --- trunk/Source/WebCore/ChangeLog 2018-12-21 11:47:28 UTC (rev 239501) +++ trunk/Source/WebCore/ChangeLog 2018-12-21 12:29:57 UTC (rev 239502) @@ -1,3 +1,32 @@ +2018-12-21 Manuel Rego Casasnovas + +[css-grid] Fix percentages in relative offsets for grid items +https://bugs.webkit.org/show_bug.cgi?id=190492 + +Reviewed by Sergio Villar Senin. + +The method RenderBoxModelObject::relativePositionOffset() was not considering the case of grid items, +where the containing block is the grid area. +The patch modifies the method so the new code uses overrideContainingBlockContentWidth|Height when required. + +Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html + +* rendering/RenderBox.cpp: Implement the physical versions of the already
[webkit-changes] [238488] trunk
Title: [238488] trunk
Revision 238488
Author r...@igalia.com
Date 2018-11-26 00:06:52 -0800 (Mon, 26 Nov 2018)
Log Message
[css-grid] Fix grid container sizing under min-content height
https://bugs.webkit.org/show_bug.cgi?id=191889
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
Imported tests from WPT.
* web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001-expected.txt: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/w3c-import.log:
Source/WebCore:
The spec is quite clear
(https://drafts.csswg.org/css-sizing/#valdef-width-min-content):
"min-content
If specified for the inline axis, use the min-content inline size;
otherwise behaves as the property’s initial value."
So if a grid container has "height: min-content" it should behave
the same than with "height: auto".
The patch removes computeIntrinsicLogicalContentHeightUsing() in
RenderGrid as we don't need a custom one anymore.
We can also get rid of m_minContentHeight and m_maxContentHeight
attributes that were only used for this logic.
Test: fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html
fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001.html
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):
* rendering/RenderGrid.h:
LayoutTests:
Update tests results to the new behavior.
Also modified a little bit the test to keep them in sync with Blink versions.
* fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt:
* fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html:
* fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html
trunk/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-sizing-constraints-001.html
Diff
Modified: trunk/LayoutTests/ChangeLog (238487 => 238488)
--- trunk/LayoutTests/ChangeLog 2018-11-26 06:55:00 UTC (rev 238487)
+++ trunk/LayoutTests/ChangeLog 2018-11-26 08:06:52 UTC (rev 238488)
@@ -1,3 +1,17 @@
+2018-11-26 Manuel Rego Casasnovas
+
+[css-grid] Fix grid container sizing under min-content height
+https://bugs.webkit.org/show_bug.cgi?id=191889
+
+Reviewed by Javier Fernandez.
+
+Update tests results to the new behavior.
+Also modified a little bit the test to keep them in sync with Blink versions.
+
+* fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt:
+* fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html:
+* fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html:
+
2018-11-25 Ryan Haddad
Unreviewed test gardening, rebaseline webgpu/queue-creation.html.
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt (238487 => 238488)
--- trunk/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt 2018-11-26 06:55:00 UTC (rev 238487)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows-expected.txt 2018-11-26 08:06:52 UTC (rev 238488)
@@ -1,3 +1,21 @@
+
+PASS .grid 1
+PASS .grid 2
+PASS .grid 3
+PASS .grid 4
+PASS .grid 5
+PASS .grid 6
+PASS .grid 7
+PASS .grid 8
+PASS .grid 9
+PASS .grid 10
+PASS .grid 11
+PASS .grid 12
+PASS .grid 13
+PASS .grid 14
+PASS .grid 15
+PASS .grid 16
+PASS .grid 17
This test checks that grid tracks are sizing correctly with orthogonal flows, so grid container's intrinsic size is computed accordingly.
Grid using fixed width and height.
@@ -7,7 +25,6 @@
XX XXX X XXX XX
X XXX XX X XX XXX X X XX
XX X XX XXX
-PASS
Grid width under min-content constrain and fixed height.
All grid items sized with min-{width, height} auto.
Orthogonal green row track assumed as infinity, hence 10px for the column track. Actual row tracks size is different, hence overflowing.
@@ -15,7 +32,6 @@
XX XXX X XXX XX
X X
[webkit-changes] [238395] trunk
Title: [238395] trunk
Revision 238395
Author r...@igalia.com
Date 2018-11-20 03:58:30 -0800 (Tue, 20 Nov 2018)
Log Message
[css-grid] Consider scrollbars in populateGridPositionsForDirection()
https://bugs.webkit.org/show_bug.cgi?id=191656
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
Imported tests from WPT.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/w3c-import.log:
Source/WebCore:
We never care about scrollbars in RenderGrid::populateGridPositionsForDirection(),
that's fine if the scrollbars are at the end (e.g. on the right in horizontal writing mode and LTR direction)
but it causes problems when they're at the beginning (e.g. on the left in horizontal writing mode and RTL direction).
The patch modifies the method so it takes into account scrollbar size
in order to compute the position of the columns/rows depending on the direction and the writing mode.
Tests: imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::populateGridPositionsForDirection):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238394 => 238395)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-20 09:02:25 UTC (rev 238394)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-20 11:58:30 UTC (rev 238395)
@@ -1,3 +1,20 @@
+2018-11-20 Manuel Rego Casasnovas
+
+[css-grid] Consider scrollbars in populateGridPositionsForDirection()
+https://bugs.webkit.org/show_bug.cgi?id=191656
+
+Reviewed by Javier Fernandez.
+
+Imported tests from WPT.
+
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html: Added.
+* web-platform-tests/css/css-grid/grid-model/w3c-import.log:
+
2018-11-19 Rob Buis
Setting document.title should have no effect for non SVG/HTML documents
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html (0 => 238395)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html 2018-11-20 11:58:30 UTC (rev 238395)
@@ -0,0 +1,96 @@
+
+
+CSS container Layout Test Reference
+
+ .container {
+font: 10px/1 Ahem;
+margin: 10px;
+background: grey;
+ }
+
+ .scrollX {
+overflow-x: scroll;
+ }
+
+ .scrollY {
+overflow-y: scroll;
+ }
+
+ .fixedSize {
+width: 200px;
+height: 50px;
+ }
+
+ .container > div {
+b
[webkit-changes] [238220] trunk
Title: [238220] trunk
Revision 238220
Author r...@igalia.com
Date 2018-11-15 04:19:24 -0800 (Thu, 15 Nov 2018)
Log Message
[css-grid] Consider scrollbars in populateGridPositionsForDirection()
https://bugs.webkit.org/show_bug.cgi?id=191656
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
Imported tests from WPT.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html: Added.
* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html: Added.
* web-platform-tests/css/css-grid/grid-model/w3c-import.log:
Source/WebCore:
We never care about scrollbars in RenderGrid::populateGridPositionsForDirection(),
that's fine if the scrollbars are at the end (e.g. on the right in horizontal writing mode and LTR direction)
but it causes problems when they're at the beginning (e.g. on the left in horizontal writing mode and RTL direction).
The patch modifies the method so it takes into account scrollbar size
in order to compute the position of the columns/rows depending on the direction and the writing mode.
Tests: imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::populateGridPositionsForDirection):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238219 => 238220)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-15 06:01:15 UTC (rev 238219)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-15 12:19:24 UTC (rev 238220)
@@ -1,3 +1,20 @@
+2018-11-15 Manuel Rego Casasnovas
+
+[css-grid] Consider scrollbars in populateGridPositionsForDirection()
+https://bugs.webkit.org/show_bug.cgi?id=191656
+
+Reviewed by Javier Fernandez.
+
+Imported tests from WPT.
+
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html: Added.
+* web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html: Added.
+* web-platform-tests/css/css-grid/grid-model/w3c-import.log:
+
2018-11-14 Youenn Fablet
Convert libwebrtc error types to DOM exceptions
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html (0 => 238220)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html 2018-11-15 12:19:24 UTC (rev 238220)
@@ -0,0 +1,95 @@
+
+
+CSS container Layout Test Reference
+
+ .container {
+margin: 10px;
+background: grey;
+ }
+
+ .scrollX {
+overflow-x: scroll;
+ }
+
+ .scrollY {
+overflow-y: scroll;
+ }
+
+ .fixedSize {
+width: 200px;
+height: 50px;
+ }
+
+ .container > div {
+background: cyan;
+width: 100%;
+he
[webkit-changes] [236126] trunk
Title: [236126] trunk Revision 236126 Author r...@igalia.com Date 2018-09-18 08:13:40 -0700 (Tue, 18 Sep 2018) Log Message [css-grid] Static position should use content-box, not padding-box https://bugs.webkit.org/show_bug.cgi?id=189698 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: * web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html: Update tests from WPT. Source/WebCore: This is a recent change by the CSSWG: https://github.com/w3c/csswg-drafts/issues/3020 The spec text (https://drafts.csswg.org/css-grid/#static-position): "The static position of an absolutely-positioned child of a grid container is determined as if it were the sole grid item in a grid area whose edges coincide with the content edges of the grid container." Test: imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html * rendering/RenderGrid.cpp: (WebCore::RenderGrid::prepareChildForPositionedLayout): Simple change to use border and padding. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236125 => 236126) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-18 14:50:41 UTC (rev 236125) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-18 15:13:40 UTC (rev 236126) @@ -1,3 +1,13 @@ +2018-09-18 Manuel Rego Casasnovas + +[css-grid] Static position should use content-box, not padding-box +https://bugs.webkit.org/show_bug.cgi?id=189698 + +Reviewed by Javier Fernandez. + +* web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html: +Update tests from WPT. + 2018-09-12 Ryosuke Niwa Update composedPath to match the latest spec Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html (236125 => 236126) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html 2018-09-18 14:50:41 UTC (rev 236125) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html 2018-09-18 15:13:40 UTC (rev 236126) @@ -41,19 +41,19 @@ - + - + - + @@ -77,19 +77,19 @@ - + - + - + Modified: trunk/Source/WebCore/ChangeLog (236125 => 236126) --- trunk/Source/WebCore/ChangeLog 2018-09-18 14:50:41 UTC (rev 236125) +++ trunk/Source/WebCore/ChangeLog 2018-09-18 15:13:40 UTC (rev 236126) @@ -1,3 +1,25 @@ +2018-09-18 Manuel Rego Casasnovas + +[css-grid] Static position should use content-box, not padding-box +https://bugs.webkit.org/show_bug.cgi?id=189698 + +Reviewed by Javier Fernandez. + +This is a recent change by the CSSWG: +https://github.com/w3c/csswg-drafts/issues/3020 + +The spec text (https://drafts.csswg.org/css-grid/#static-position): + "The static position of an absolutely-positioned child + of a grid container is determined as if it were the sole grid item + in a grid area whose edges coincide with the content edges + of the grid container." + +Test: imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html + +* rendering/RenderGrid.cpp: +(WebCore::RenderGrid::prepareChildForPositionedLayout): +Simple change to use border and padding. + 2018-09-18 Xabier Rodriguez Calvar [EME][GStreamer] The current EME implementation doesn't support the waitingforkey event Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (236125 => 236126) --- trunk/Source/WebCore/rendering/RenderGrid.cpp 2018-09-18 14:50:41 UTC (rev 236125) +++ trunk/Source/WebCore/rendering/RenderGrid.cpp 2018-09-18 15:13:40 UTC (rev 236126) @@ -903,8 +903,9 @@ child.containingBlock()->insertPositionedObject(child); RenderLayer* childLayer = child.layer(); -childLayer->setStaticInlinePosition(borderStart()); -childLayer->setStaticBlockPosition(borderBefore()); +// Static position of a positioned child should use the content-box (https://drafts.csswg.org/css-grid/#static-position). +childLayer->setStaticInlinePosition(borderAndPaddingStart()); +childLayer->setStaticBlockPosition(borderAndPaddingBefore()); } bool RenderGrid::hasStaticPositionForChild(const RenderBox& child, GridTrackSizingDirection direction) const ___ webkit-changes mailing list webkit-change
[webkit-changes] [234131] trunk
Title: [234131] trunk Revision 234131 Author r...@igalia.com Date 2018-07-23 21:50:20 -0700 (Mon, 23 Jul 2018) Log Message [css-grid] Add support for calc() in gutter properties https://bugs.webkit.org/show_bug.cgi?id=187902 Reviewed by Simon Fraser. LayoutTests/imported/w3c: Two new WPT tests are imported to verify the expected behavior. * web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-expected.txt: Added. * web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl-expected.txt: Added. * web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html: Added. * web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002.html: Added. * web-platform-tests/css/css-grid/abspos/w3c-import.log: Source/WebCore: The parsing was already accepting calc() in grid row and column gaps, however the code was not taking that into account properly. If the calc() had a percentage it was ignored and that's wrong. The fix is just a change in the ceck at RenderGrid::availableSpaceForGutters(). Tests: imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002.html imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-011.html imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-012.html * rendering/RenderGrid.cpp: (WebCore::RenderGrid::availableSpaceForGutters const): LayoutTests: Two tests are now passing thanks to this change. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002.html Diff Modified: trunk/LayoutTests/ChangeLog (234130 => 234131) --- trunk/LayoutTests/ChangeLog 2018-07-24 02:18:12 UTC (rev 234130) +++ trunk/LayoutTests/ChangeLog 2018-07-24 04:50:20 UTC (rev 234131) @@ -1,3 +1,14 @@ +2018-07-23 Manuel Rego Casasnovas + +[css-grid] Add support for calc() in gutter properties +https://bugs.webkit.org/show_bug.cgi?id=187902 + +Reviewed by Simon Fraser. + +Two tests are now passing thanks to this change. + +* TestExpectations: + 2018-07-23 Andy VanWagoner [INTL] Language tags are not canonicalized Modified: trunk/LayoutTests/TestExpectations (234130 => 234131) --- trunk/LayoutTests/TestExpectations 2018-07-24 02:18:12 UTC (rev 234130) +++ trunk/LayoutTests/TestExpectations 2018-07-24 04:50:20 UTC (rev 234131) @@ -2109,7 +2109,6 @@ imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-style-007.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-display/run-in/run-in-basic-007.xht [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/grid-items/percentage-size-replaced-subitems-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-012.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/cssom-view/scrollingElement-quirks-dynamic-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-right-002.xht [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-abspos-001.xht [ ImageOnlyFailure ] @@ -2137,7 +2136,6 @@ imported/w3c/web-platform-tests/css/css-ui/text-overflow-028.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-left-001.xht [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-display/display-contents-details.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-011.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-010.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-display/run-in/run-in-breaking-002.xht [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-between-003.xht [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (234130 => 234131) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-07-24 02:18:12 UTC (rev 234130) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-07-24 04:50:20 UTC (rev 234131) @@ -1,3 +1,18 @@ +2018-07-23 Ma
[webkit-changes] [233365] trunk
Title: [233365] trunk Revision 233365 Author r...@igalia.com Date 2018-06-29 11:54:41 -0700 (Fri, 29 Jun 2018) Log Message [WPE] Three CSS Grid Layout tests crash due to valueless std::optional access https://bugs.webkit.org/show_bug.cgi?id=186752 Reviewed by Frédéric Wang. Source/WebCore: This is a simple fix for the crash we're getting on WPE in IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep(). Covered by existent tests, just remove them from TestExpectations file. * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const): Check if minSize is null before trying to access it's value. LayoutTests: * platform/wpe/TestExpectations: Remove tests from TestExpectations file as they're passing now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wpe/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp Diff Modified: trunk/LayoutTests/ChangeLog (233364 => 233365) --- trunk/LayoutTests/ChangeLog 2018-06-29 18:12:50 UTC (rev 233364) +++ trunk/LayoutTests/ChangeLog 2018-06-29 18:54:41 UTC (rev 233365) @@ -1,3 +1,13 @@ +2018-06-29 Manuel Rego Casasnovas + +[WPE] Three CSS Grid Layout tests crash due to valueless std::optional access +https://bugs.webkit.org/show_bug.cgi?id=186752 + +Reviewed by Frédéric Wang. + +* platform/wpe/TestExpectations: Remove tests from TestExpectations file +as they're passing now. + 2018-06-29 Thibault Saunier [GTK][WPE]: Add a way to setup our development environment inside flatpak Modified: trunk/LayoutTests/platform/wpe/TestExpectations (233364 => 233365) --- trunk/LayoutTests/platform/wpe/TestExpectations 2018-06-29 18:12:50 UTC (rev 233364) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2018-06-29 18:54:41 UTC (rev 233365) @@ -1220,10 +1220,6 @@ webkit.org/b/184501 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures.worker.html [ Failure ] webkit.org/b/184501 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes.worker.html [ Failure ] -webkit.org/b/186752 fast/css-grid-layout/flex-sizing-rows-min-max-height.html [ Crash ] -webkit.org/b/186752 fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html [ Crash ] -webkit.org/b/186752 fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html [ Crash ] - webkit.org/b/186100 css3/color-filters/color-filter-color-property-list-item.html [ ImageOnlyFailure ] webkit.org/b/186100 css3/color-filters/color-filter-ignore-semantic.html [ ImageOnlyFailure ] webkit.org/b/186100 css3/color-filters/color-filter-opacity.html [ ImageOnlyFailure ] Modified: trunk/Source/WebCore/ChangeLog (233364 => 233365) --- trunk/Source/WebCore/ChangeLog 2018-06-29 18:12:50 UTC (rev 233364) +++ trunk/Source/WebCore/ChangeLog 2018-06-29 18:54:41 UTC (rev 233365) @@ -1,3 +1,19 @@ +2018-06-29 Manuel Rego Casasnovas + +[WPE] Three CSS Grid Layout tests crash due to valueless std::optional access +https://bugs.webkit.org/show_bug.cgi?id=186752 + +Reviewed by Frédéric Wang. + +This is a simple fix for the crash we're getting on WPE +in IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep(). + +Covered by existent tests, just remove them from TestExpectations file. + +* rendering/GridTrackSizingAlgorithm.cpp: +(WebCore::IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const): +Check if minSize is null before trying to access it's value. + 2018-06-29 David Fenton Unreviewed, rolling out r233349. Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (233364 => 233365) --- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2018-06-29 18:12:50 UTC (rev 233364) +++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2018-06-29 18:54:41 UTC (rev 233365) @@ -908,6 +908,8 @@ return LayoutUnit(); auto minSize = renderGrid()->computeContentLogicalHeight(MinSize, renderGrid()->style().logicalMinHeight(), std::nullopt); +if (!minSize) +return LayoutUnit(); return minSize.value() - computeTrackBasedSize(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [233021] trunk/Websites/webkit.org
Title: [233021] trunk/Websites/webkit.org Revision 233021 Author r...@igalia.com Date 2018-06-20 13:24:56 -0700 (Wed, 20 Jun 2018) Log Message [WPE] Some fixups on webkit.org page https://bugs.webkit.org/show_bug.cgi?id=186844 Unreviewed as the content is not modified, only some minor fixups on the format. * wpe.md: Remove title as it's already provided by the website CMS. Avoid breaking lines at 80 chars as it's not rendered as expected. Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/wpe.md Diff Modified: trunk/Websites/webkit.org/ChangeLog (233020 => 233021) --- trunk/Websites/webkit.org/ChangeLog 2018-06-20 20:23:16 UTC (rev 233020) +++ trunk/Websites/webkit.org/ChangeLog 2018-06-20 20:24:56 UTC (rev 233021) @@ -1,5 +1,15 @@ 2018-06-20 Manuel Rego Casasnovas +[WPE] Some fixups on webkit.org page +https://bugs.webkit.org/show_bug.cgi?id=186844 + +Unreviewed as the content is not modified, only some minor fixups on the format. + +* wpe.md: Remove title as it's already provided by the website CMS. +Avoid breaking lines at 80 chars as it's not rendered as expected. + +2018-06-20 Manuel Rego Casasnovas + [WPE] Add page for webkit.org https://bugs.webkit.org/show_bug.cgi?id=186844 Modified: trunk/Websites/webkit.org/wpe.md (233020 => 233021) --- trunk/Websites/webkit.org/wpe.md 2018-06-20 20:23:16 UTC (rev 233020) +++ trunk/Websites/webkit.org/wpe.md 2018-06-20 20:24:56 UTC (rev 233021) @@ -1,97 +1,52 @@ -# WPE +WPE is the reference WebKit port for embedded and low-consumption computer devices. It has been designed from the ground-up with performance, small footprint, accelerated content rendering, and simplicity of deployment in mind, bringing the excellence of the WebKit engine to countless platforms and target devices. -WPE is the reference WebKit port for embedded and -low-consumption computer devices. -It has been designed from the ground-up with performance, small footprint, -accelerated content rendering, and simplicity of deployment in mind, -bringing the excellence of the WebKit engine to countless platforms and -target devices. +In times where embedded devices power endless ad-hoc applications in a diverse range of industries and the Web continues to establish itself as one of the most popular application development frameworks for developers, WPE closes this gap and serves as a foundation over which embedders can build rich applications that run entirely on the Web. -In times where embedded devices power endless ad-hoc applications -in a diverse range of industries and the Web continues to establish itself as -one of the most popular application development frameworks for developers, -WPE closes this gap and serves as a foundation over which embedders -can build rich applications that run entirely on the Web. - ## Design goals -The design goals that set WPE apart from other ports of WebKit and -other engines are: +The design goals that set WPE apart from other ports of WebKit and other engines are: -* **To provide a no-frills, straight to the point, web runtime - for embedded devices.** +* **To provide a no-frills, straight to the point, web runtime for embedded devices.** - Thanks to the primary focus on the embedded world, - WPE is being developed each step of the way with the needs - and constraints of embedded devices in consideration, - allowing for the best experience in all kind of web-based applications. + Thanks to the primary focus on the embedded world, WPE is being developed each step of the way with the needs and constraints of embedded devices in consideration, allowing for the best experience in all kind of web-based applications. * **To be fast and lightweight, keeping software dependencies to a minimum.** - The minimal set of dependencies needed to run WPE ensures that - its footprint is small and that applications built with WPE - can run in low-end devices. + The minimal set of dependencies needed to run WPE ensures that its footprint is small and that applications built with WPE can run in low-end devices. -* **To keep up with Web standards and to continuously work in - ensuring compliance.** +* **To keep up with Web standards and to continuously work in ensuring compliance.** - By its complete upstream integration, WPE can leverage the work - on Web standards that goes into the WebKit project. - Additionally, the WPE team is committed to ensure that new specifications - are implemented in WPE with our goals in mind. + By its complete upstream integration, WPE can leverage the work on Web standards that goes into the WebKit project. Additionally, the WPE team is committed to ensure that new specifications are implemented in WPE with our goals in mind. -* **To use hardware acceleration wherever its advantageous: - WebGL, accelerated canvas, CSS 3D transforms, video playback.** +* **To use hardware acceleration wh
[webkit-changes] [233012] trunk/Websites/webkit.org
Title: [233012] trunk/Websites/webkit.org Revision 233012 Author r...@igalia.com Date 2018-06-20 08:51:51 -0700 (Wed, 20 Jun 2018) Log Message [WPE] Add page for webkit.org https://bugs.webkit.org/show_bug.cgi?id=186844 Reviewed by Michael Catanzaro. * wpe.md: Added. Modified Paths trunk/Websites/webkit.org/ChangeLog Added Paths trunk/Websites/webkit.org/wpe.md Diff Modified: trunk/Websites/webkit.org/ChangeLog (233011 => 233012) --- trunk/Websites/webkit.org/ChangeLog 2018-06-20 13:53:41 UTC (rev 233011) +++ trunk/Websites/webkit.org/ChangeLog 2018-06-20 15:51:51 UTC (rev 233012) @@ -1,3 +1,12 @@ +2018-06-20 Manuel Rego Casasnovas + +[WPE] Add page for webkit.org +https://bugs.webkit.org/show_bug.cgi?id=186844 + +Reviewed by Michael Catanzaro. + +* wpe.md: Added. + 2018-06-14 Roy Reapor Use new jQuery file layout Added: trunk/Websites/webkit.org/wpe.md (0 => 233012) --- trunk/Websites/webkit.org/wpe.md (rev 0) +++ trunk/Websites/webkit.org/wpe.md 2018-06-20 15:51:51 UTC (rev 233012) @@ -0,0 +1,97 @@ +# WPE + +WPE is the reference WebKit port for embedded and +low-consumption computer devices. +It has been designed from the ground-up with performance, small footprint, +accelerated content rendering, and simplicity of deployment in mind, +bringing the excellence of the WebKit engine to countless platforms and +target devices. + +In times where embedded devices power endless ad-hoc applications +in a diverse range of industries and the Web continues to establish itself as +one of the most popular application development frameworks for developers, +WPE closes this gap and serves as a foundation over which embedders +can build rich applications that run entirely on the Web. + +## Design goals + +The design goals that set WPE apart from other ports of WebKit and +other engines are: + +* **To provide a no-frills, straight to the point, web runtime + for embedded devices.** + + Thanks to the primary focus on the embedded world, + WPE is being developed each step of the way with the needs + and constraints of embedded devices in consideration, + allowing for the best experience in all kind of web-based applications. + +* **To be fast and lightweight, keeping software dependencies to a minimum.** + + The minimal set of dependencies needed to run WPE ensures that + its footprint is small and that applications built with WPE + can run in low-end devices. + +* **To keep up with Web standards and to continuously work in + ensuring compliance.** + + By its complete upstream integration, WPE can leverage the work + on Web standards that goes into the WebKit project. + Additionally, the WPE team is committed to ensure that new specifications + are implemented in WPE with our goals in mind. + +* **To use hardware acceleration wherever its advantageous: + WebGL, accelerated canvas, CSS 3D transforms, video playback.** + + For best performance, responsiveness, and user-experience, + WPE enables deployments to make the best out of + hardware acceleration capabilities present in the target embedded devices. + +* **To make deployment in new platforms and target devices as easy as possible, + through a backend architecture.** + + WPE has been designed with a backend architecture, + which allows easily developing backends for the widest range + of platform of devices, including, for example, + Wayland and Raspberry Pi devices. + +## A multimedia-oriented web engine + +Because of the extensive growth of multimedia in the embedded sector, +WPE has a strong focus on multimedia applications. +Some of the key multimedia features in WPE are: + +* Hardware-accelerated video rendering and CSS transformations. +* Punch-hole video playback available when needed by the target platform. +* MSE (MP4, WebM, VP9, Opus) supported and under constant development, + optimized for YouTube and YouTube TV. +* EME (V1 and V3, Clearkey, other third-party DRM frameworks) supported + and constantly improving. +* GStreamer-based multimedia framework. +* WebRTC partially supported and under heavy development. + +## How to get WPE? + +WPE is an upstream WebKit port, which means that you can just +[get it the usual way](https://webkit.org/getting-the-code/). +You can build the code following the instructions +in the [WPE Wiki page](https://trac.webkit.org/wiki/WPE). + +The WPE team is making periodic releases and +these are available at . + +## How to contribute? + +The WPE port has a mailing list where development and +general questions can be addressed. +You can subscribe at +[https://lists.webkit.org/mailman/listinfo/webkit-wpe](https://lists.webkit.org/mailman/listinfo/webkit-wpe). + +You can report issues, bugs, and file feature requests in WebKit Bugzilla, +under the WebKit WPE component: +[http://bugs.webkit.org](http://bugs.webkit.org/). +You can follow the instructions in +[https://webkit.org/reporting-bugs/](https://webk
[webkit-changes] [232107] trunk/LayoutTests
Title: [232107] trunk/LayoutTests Revision 232107 Author r...@igalia.com Date 2018-05-22 23:49:59 -0700 (Tue, 22 May 2018) Log Message [css-text] W3C test suite gardening https://bugs.webkit.org/show_bug.cgi?id=185879 Some more gardening on the css-text test suite. Unreviewed test gardening. * TestExpectations: * platform/gtk/TestExpectations: * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (232106 => 232107) --- trunk/LayoutTests/ChangeLog 2018-05-23 05:05:13 UTC (rev 232106) +++ trunk/LayoutTests/ChangeLog 2018-05-23 06:49:59 UTC (rev 232107) @@ -1,3 +1,17 @@ +2018-05-22 Manuel Rego Casasnovas <r...@igalia.com> + +[css-text] W3C test suite gardening +https://bugs.webkit.org/show_bug.cgi?id=185879 + +Some more gardening on the css-text test suite. + +Unreviewed test gardening. + +* TestExpectations: +* platform/gtk/TestExpectations: +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + 2018-05-22 Myles C. Maxfield <mmaxfi...@apple.com> Text can wrap between hyphens and commas Modified: trunk/LayoutTests/TestExpectations (232106 => 232107) --- trunk/LayoutTests/TestExpectations 2018-05-23 05:05:13 UTC (rev 232106) +++ trunk/LayoutTests/TestExpectations 2018-05-23 06:49:59 UTC (rev 232107) @@ -1568,10 +1568,6 @@ webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-first-001.xht [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-force-end-001.xht [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-last-001.xht [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-010.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-011.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-115.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-116.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-002.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-strict-011.xht [ ImageOnlyFailure ] @@ -1662,7 +1658,6 @@ webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapsing-discard-001.xht [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-collapsing-preserve-breaks-001.xht [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-004.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-008.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-keep-all-003.html [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-keep-all-004.xht [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (232106 => 232107) --- trunk/LayoutTests/platform/gtk/TestExpectations 2018-05-23 05:05:13 UTC (rev 232106) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-05-23 06:49:59 UTC (rev 232107) @@ -3378,6 +3378,15 @@ webkit.org/b/185714 js/intl-numberformat-format-to-parts.html [ Failure ] webkit.org/b/185714 js/intl-pluralrules.html [ Failure ] +# Imported css-text test suite from WPT +webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-control-chars-001.html [ ImageOnlyFailure ] +webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-002.html [ ImageOnlyFailure ] +webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-003.html [ ImageOnlyFailure ] +webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-005.html [ ImageOnlyFailure ] +webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/wor
[webkit-changes] [232063] trunk/LayoutTests
Title: [232063] trunk/LayoutTests Revision 232063 Author r...@igalia.com Date 2018-05-22 06:34:03 -0700 (Tue, 22 May 2018) Log Message [css-text] W3C test suite gardening https://bugs.webkit.org/show_bug.cgi?id=185862 Test suite landed in r232057 but some of the tests marked as failure are actually passing. Unreviewed test gardening. * TestExpectations: * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (232062 => 232063) --- trunk/LayoutTests/ChangeLog 2018-05-22 13:20:03 UTC (rev 232062) +++ trunk/LayoutTests/ChangeLog 2018-05-22 13:34:03 UTC (rev 232063) @@ -1,5 +1,19 @@ 2018-05-22 Manuel Rego Casasnovas <r...@igalia.com> +[css-text] W3C test suite gardening +https://bugs.webkit.org/show_bug.cgi?id=185862 + +Test suite landed in r232057 but some of the tests marked as failure +are actually passing. + +Unreviewed test gardening. + +* TestExpectations: +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + +2018-05-22 Manuel Rego Casasnovas <r...@igalia.com> + [css-text] Import WPT test suite https://bugs.webkit.org/show_bug.cgi?id=183258 Modified: trunk/LayoutTests/TestExpectations (232062 => 232063) --- trunk/LayoutTests/TestExpectations 2018-05-22 13:20:03 UTC (rev 232062) +++ trunk/LayoutTests/TestExpectations 2018-05-22 13:34:03 UTC (rev 232063) @@ -1568,154 +1568,10 @@ webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-first-001.xht [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-force-end-001.xht [ ImageOnlyFailure ] webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-last-001.xht [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-026.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-027.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-028.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-030.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-031.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-036.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-037.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-039.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-040.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-042.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-043.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-044.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-045.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-046.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-047.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-048.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-049.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-050.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-051.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-052.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-054.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-jazh-055.html [ ImageOnlyFailure ] -webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-b
[webkit-changes] [231757] trunk/Source/WebCore
/WebCore/rendering/RenderGrid.cpp trunk/Source/WebCore/rendering/RenderRubyBase.cpp trunk/Source/WebCore/rendering/RenderTableCell.cpp trunk/Source/WebCore/rendering/RenderTableCell.h trunk/Source/WebCore/rendering/RenderTableSection.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (231756 => 231757) --- trunk/Source/WebCore/ChangeLog 2018-05-14 14:52:50 UTC (rev 231756) +++ trunk/Source/WebCore/ChangeLog 2018-05-14 15:20:47 UTC (rev 231757) @@ -1,3 +1,88 @@ +2018-05-14 Manuel Rego Casasnovas <r...@igalia.com> + +Renaming of overrides in LayoutBox +https://bugs.webkit.org/show_bug.cgi?id=185609 + +Reviewed by Javier Fernandez. + +The names of the methods for the overrides were not consistent, +this patch fixes it by using the same structure in all the cases. + +No new tests, no change of behavior. + +* rendering/GridLayoutFunctions.cpp: +(WebCore::GridLayoutFunctions::hasOverrideContainingBlockContentSizeForChild): +* rendering/GridTrackSizingAlgorithm.cpp: +(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const): +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::computeChildPreferredLogicalWidths const): +(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const): +* rendering/RenderBlockFlow.cpp: +(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded): +* rendering/RenderBlockLineLayout.cpp: +(WebCore::RenderBlockFlow::updateRubyForJustifiedText): +* rendering/RenderBox.cpp: +(WebCore::RenderBox::willBeDestroyed): +(WebCore::RenderBox::hasOverrideContentLogicalHeight const): +(WebCore::RenderBox::hasOverrideContentLogicalWidth const): +(WebCore::RenderBox::setOverrideContentLogicalHeight): +(WebCore::RenderBox::setOverrideContentLogicalWidth): +(WebCore::RenderBox::clearOverrideContentLogicalHeight): +(WebCore::RenderBox::clearOverrideContentLogicalWidth): +(WebCore::RenderBox::clearOverrideContentSize): +(WebCore::RenderBox::overrideContentLogicalWidth const): +(WebCore::RenderBox::overrideContentLogicalHeight const): +(WebCore::RenderBox::overrideContainingBlockContentLogicalWidth const): +(WebCore::RenderBox::overrideContainingBlockContentLogicalHeight const): +(WebCore::RenderBox::hasOverrideContainingBlockContentLogicalWidth const): +(WebCore::RenderBox::hasOverrideContainingBlockContentLogicalHeight const): +(WebCore::RenderBox::setOverrideContainingBlockContentLogicalWidth): +(WebCore::RenderBox::setOverrideContainingBlockContentLogicalHeight): +(WebCore::RenderBox::clearOverrideContainingBlockContentSize): +(WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight): +(WebCore::RenderBox::containingBlockLogicalWidthForContent const): +(WebCore::RenderBox::containingBlockLogicalHeightForContent const): +(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const): +(WebCore::RenderBox::computeLogicalWidthInFragment const): +(WebCore::RenderBox::computeLogicalHeight const): +(WebCore::RenderBox::computePercentageLogicalHeight const): +(WebCore::RenderBox::computeReplacedLogicalHeightUsing const): +(WebCore::RenderBox::availableLogicalHeightUsing const): +(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const): +(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const): +* rendering/RenderBox.h: +* rendering/RenderBoxModelObject.cpp: +(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const): +* rendering/RenderDeprecatedFlexibleBox.cpp: +(WebCore::contentWidthForChild): +(WebCore::contentHeightForChild): +(WebCore::gatherFlexChildrenInfo): +(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): +(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): +(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): +(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): +* rendering/RenderFlexibleBox.cpp: +(WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild): +(WebCore::RenderFlexibleBox::crossSizeForPercentageResolution): +(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): +(WebCore::RenderFlexibleBox::constructFlexItem): +(WebCore::RenderFlexibleBox::setOverrideMainAxisContentSizeForChild): +(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): +* rendering/RenderFullScreen.cpp: +(WebCore::RenderFullScreen::unwrapRenderer): +* rendering/RenderGrid.cpp: +(WebCore::RenderGrid::layoutBlock): +(WebCore::RenderGrid::layoutGridItems): +(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded): +*
[webkit-changes] [230797] trunk
atform/mac/editing/selection/select-all-004-expected.txt
trunk/LayoutTests/platform/win/editing/deleting/5126166-expected.txt
trunk/LayoutTests/platform/win/editing/deleting/5206311-1-expected.txt
trunk/LayoutTests/platform/win/editing/deleting/5433862-2-expected.txt
trunk/LayoutTests/platform/win/editing/deleting/5483370-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableCell.cpp
trunk/Source/WebCore/rendering/RenderTableCell.h
Added Paths
trunk/LayoutTests/editing/caret/caret-in-empty-cell-expected.html
trunk/LayoutTests/editing/caret/caret-in-empty-cell.html
trunk/LayoutTests/platform/win/editing/deleting/5126166-expected.png
trunk/LayoutTests/platform/win/editing/deleting/5206311-1-expected.png
trunk/LayoutTests/platform/win/editing/deleting/5433862-2-expected.png
trunk/LayoutTests/platform/win/editing/deleting/5483370-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (230796 => 230797)
--- trunk/LayoutTests/ChangeLog 2018-04-19 05:38:53 UTC (rev 230796)
+++ trunk/LayoutTests/ChangeLog 2018-04-19 07:10:48 UTC (rev 230797)
@@ -1,3 +1,48 @@
+2018-04-19 Manuel Rego Casasnovas <r...@igalia.com>
+
+Caret rendered at incorrect location inside empty table cell
+https://bugs.webkit.org/show_bug.cgi?id=85385
+
+Reviewed by Zalan Bujtas.
+
+* editing/caret/caret-in-empty-cell-expected.html: Added.
+* editing/caret/caret-in-empty-cell.html: Added.
+* editing/deleting/5206311-2-expected.txt:
+* editing/deleting/5433862-1-expected.txt:
+* platform/gtk/editing/deleting/5126166-expected.png:
+* platform/gtk/editing/deleting/5126166-expected.txt:
+* platform/gtk/editing/deleting/5206311-1-expected.png:
+* platform/gtk/editing/deleting/5206311-1-expected.txt:
+* platform/gtk/editing/deleting/5433862-2-expected.png:
+* platform/gtk/editing/deleting/5433862-2-expected.txt:
+* platform/gtk/editing/deleting/5483370-expected.png:
+* platform/gtk/editing/deleting/5483370-expected.txt:
+* platform/gtk/editing/selection/move-by-line-001-expected.png:
+* platform/gtk/editing/selection/move-by-line-001-expected.txt:
+* platform/gtk/editing/selection/select-all-004-expected.txt:
+* platform/ios-simulator/editing/deleting/5126166-expected.txt:
+* platform/ios-simulator/editing/deleting/5206311-1-expected.txt:
+* platform/ios-simulator/editing/deleting/5433862-2-expected.txt:
+* platform/ios-simulator/editing/deleting/5483370-expected.txt:
+* platform/mac/editing/deleting/5126166-expected.png:
+* platform/mac/editing/deleting/5126166-expected.txt:
+* platform/mac/editing/deleting/5206311-1-expected.png:
+* platform/mac/editing/deleting/5206311-1-expected.txt:
+* platform/mac/editing/deleting/5433862-2-expected.png:
+* platform/mac/editing/deleting/5433862-2-expected.txt:
+* platform/mac/editing/deleting/5483370-expected.png:
+* platform/mac/editing/deleting/5483370-expected.txt:
+* platform/mac/editing/selection/move-by-line-001-expected.txt:
+* platform/mac/editing/selection/select-all-004-expected.txt:
+* platform/win/editing/deleting/5126166-expected.png: Added.
+* platform/win/editing/deleting/5126166-expected.txt:
+* platform/win/editing/deleting/5206311-1-expected.png: Added.
+* platform/win/editing/deleting/5206311-1-expected.txt:
+* platform/win/editing/deleting/5433862-2-expected.png: Added.
+* platform/win/editing/deleting/5433862-2-expected.txt:
+* platform/win/editing/deleting/5483370-expected.png: Added.
+* platform/win/editing/deleting/5483370-expected.txt:
+
2018-04-18 Youenn Fablet <you...@apple.com>
Allow SameOrigin credentials handling for synchronous XHR
Added: trunk/LayoutTests/editing/caret/caret-in-empty-cell-expected.html (0 => 230797)
--- trunk/LayoutTests/editing/caret/caret-in-empty-cell-expected.html (rev 0)
+++ trunk/LayoutTests/editing/caret/caret-in-empty-cell-expected.html 2018-04-19 07:10:48 UTC (rev 230797)
@@ -0,0 +1,25 @@
+
+
+ table {
+font-size: 2em;
+ }
+ td {
+padding: 5px;
+ }
+ #emptycell {
+width: 50%;
+ }
+
+
+Test passes if the caret in the empty cell is inside the cell itself (that means it's vertically aligned with the reference text).
+
+
+ Reference text
+
+
+
+
+ var selection = window.getSelection();
+ var emptycell = document.getElementById("emptycell");
+ selection.collapse(emptycell, 0);
+
Added: trunk/LayoutTests/editing/caret/caret-in-empty-cell.html (0 => 230797)
--- trunk/LayoutTests/editing/caret/caret-in-empty-cell.html (rev 0)
+++ trunk/LayoutTests/editing/caret/caret-in-empty-cell.html 2018-04-19 07:10:48 UTC (rev 230797)
@@ -0,0 +1,25 @@
+
+
+ table {
+font-size: 2em;
+ }
+ td {
[webkit-changes] [228830] trunk/LayoutTests
Title: [228830] trunk/LayoutTests Revision 228830 Author r...@igalia.com Date 2018-02-20 13:45:27 -0800 (Tue, 20 Feb 2018) Log Message Skip tests that need ENABLE_LINK_PREFETCH https://bugs.webkit.org/show_bug.cgi?id=182981 Unreviewed gardening. These tests were marked in the different TestExpectations fails of each port, when actually none of them were testing this code as ENABLE_LINK_PREFETCH is disabled by default (even in development builds). The patch just moves the flagged tests from the port specific TestExpectations files to the generic TestExpectations file skipping them. * TestExpectations: * platform/gtk/TestExpectations: * platform/ios/TestExpectations: * platform/mac/TestExpectations: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (228829 => 228830) --- trunk/LayoutTests/ChangeLog 2018-02-20 20:12:09 UTC (rev 228829) +++ trunk/LayoutTests/ChangeLog 2018-02-20 21:45:27 UTC (rev 228830) @@ -1,3 +1,23 @@ +2018-02-20 Manuel Rego Casasnovas <r...@igalia.com> + +Skip tests that need ENABLE_LINK_PREFETCH +https://bugs.webkit.org/show_bug.cgi?id=182981 + +Unreviewed gardening. + +These tests were marked in the different TestExpectations fails of each port, +when actually none of them were testing this code as ENABLE_LINK_PREFETCH is disabled by default +(even in development builds). + +The patch just moves the flagged tests from the port specific TestExpectations files +to the generic TestExpectations file skipping them. + +* TestExpectations: +* platform/gtk/TestExpectations: +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: +* platform/win/TestExpectations: + 2018-02-20 John Wilander <wilan...@apple.com> Make WebResourceLoadStatisticsStore::processStatisticsAndDataRecords() call WebProcessProxy::notifyPageStatisticsAndDataRecordsProcessed() in a proper callback Modified: trunk/LayoutTests/TestExpectations (228829 => 228830) --- trunk/LayoutTests/TestExpectations 2018-02-20 20:12:09 UTC (rev 228829) +++ trunk/LayoutTests/TestExpectations 2018-02-20 21:45:27 UTC (rev 228830) @@ -1596,6 +1596,18 @@ webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ Skip ] webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle [ Skip ] +# Link prefetch is disabled by default (needs ENABLE_LINK_PREFETCH) +webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-beforeload.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-too-many-clients.html [ Skip ] +webkit.org/b/3652 fast/dom/HTMLLinkElement/subresource.html [ Skip ] +webkit.org/b/3652 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ] +webkit.org/b/3652 http/tests/misc/prefetch-purpose.html [ Skip ] + ### END OF -disabled tests Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228829 => 228830) --- trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-20 20:12:09 UTC (rev 228829) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-20 21:45:27 UTC (rev 228830) @@ -1201,16 +1201,6 @@ webkit.org/b/177633 http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url.html [ Failure ] webkit.org/b/177633 http/tests/security/clipboard/copy-paste-html-across-origin-strips-mso-list.html [ Failure ] -# We should consider enabling ENABLE_LINK_PREFETCH -webkit.org/b/179989 http/tests/misc/prefetch-purpose.html [ Skip ] -webkit.org/b/179989 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ] -webkit.org/b/179989 fast/dom/HTMLLinkElement/subresource.html [ Skip ] -webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ] -webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ] -webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch.html [ Skip ] -webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ] -webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ] - webkit.org/b/180062 fast/text/user-installed-fonts [ Skip ] # Modified: trunk/Lay
[webkit-changes] [228817] trunk/LayoutTests
Title: [228817] trunk/LayoutTests Revision 228817 Author r...@igalia.com Date 2018-02-20 06:11:05 -0800 (Tue, 20 Feb 2018) Log Message [css3-text] Skip tests that need ENABLE_CSS3_TEXT https://bugs.webkit.org/show_bug.cgi?id=182963 Unreviewed gardening. These tests were marked in the different TestExpectations fails of each port, when actually none of them were testing this code as ENABLE_CSS3_TEXT is disabled by default (even in development builds). The patch just moves the flagged tests from the port specific TestExpectations files to the generic TestExpectations file skipping them. It also removes editing/pasteboard/insert-text-decoration.html from the skipping list as it should be passing for Mac an iOs too. * TestExpectations: * platform/gtk/TestExpectations: * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (228816 => 228817) --- trunk/LayoutTests/ChangeLog 2018-02-20 13:49:04 UTC (rev 228816) +++ trunk/LayoutTests/ChangeLog 2018-02-20 14:11:05 UTC (rev 228817) @@ -1,3 +1,25 @@ +2018-02-20 Manuel Rego Casasnovas <r...@igalia.com> + +[css3-text] Skip tests that need ENABLE_CSS3_TEXT +https://bugs.webkit.org/show_bug.cgi?id=182963 + +Unreviewed gardening. + +These tests were marked in the different TestExpectations fails of each port, +when actually none of them were testing this code as ENABLE_CSS3_TEXT is disabled by default +(even in development builds). + +The patch just moves the flagged tests from the port specific TestExpectations files +to the generic TestExpectations file skipping them. + +It also removes editing/pasteboard/insert-text-decoration.html from the skipping list +as it should be passing for Mac an iOs too. + +* TestExpectations: +* platform/gtk/TestExpectations: +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + 2018-02-19 Fujii Hironori <hironori.fu...@sony.com> null m_lastNodeInserted dereference at ReplaceSelectionCommand::InsertedNodes::lastLeafInserted Modified: trunk/LayoutTests/TestExpectations (228816 => 228817) --- trunk/LayoutTests/TestExpectations 2018-02-20 13:49:04 UTC (rev 228816) +++ trunk/LayoutTests/TestExpectations 2018-02-20 14:11:05 UTC (rev 228817) @@ -1590,6 +1590,12 @@ imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.https.html [ Skip ] imported/w3c/web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.https.html [ Skip ] +# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT). +webkit.org/b/76173 fast/css3-text/css3-text-align-last [ Skip ] +webkit.org/b/99945 fast/css3-text/css3-text-justify [ Skip ] +webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ Skip ] +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle [ Skip ] + ### END OF -disabled tests Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228816 => 228817) --- trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-20 13:49:04 UTC (rev 228816) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-20 14:11:05 UTC (rev 228817) @@ -1063,10 +1063,6 @@ webkit.org/b/158836 imported/w3c/web-platform-tests/encrypted-media [ Skip ] -# CSS3 Text each-line and hanging indent not supported -webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ] -webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html [ Failure ] - # CSS image-orientation is not yet enabled. webkit.org/b/89052 fast/css/image-orientation [ Skip ] @@ -1205,7 +1201,7 @@ webkit.org/b/177633 http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url.html [ Failure ] webkit.org/b/177633 http/tests/security/clipboard/copy-paste-html-across-origin-strips-mso-list.html [ Failure ] -# We should consider enabling ENABLE_LINK_PREFETCH and ENABLE_CSS3_TEXT +# We should consider enabling ENABLE_LINK_PREFETCH webkit.org/b/179989 http/tests/misc/prefetch-purpose.html [ Skip ] webkit.org/b/179989 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ] webkit.org/b/179989 fast/dom/HTMLLinkElement/subresource.html [ Skip ] @@ -1214,10 +1210,6 @@ webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch.html [ Skip ] webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ] webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ] -webkit.org/b/179989 fast/css3-text/css3-text-justify/getComputedStyle/getCompu
[webkit-changes] [228661] trunk
Title: [228661] trunk Revision 228661 Author r...@igalia.com Date 2018-02-19 04:10:16 -0800 (Mon, 19 Feb 2018) Log Message [css-grid] Apply automatic minimum size clamping to spanning items too https://bugs.webkit.org/show_bug.cgi?id=182684 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: Update WPT tests related to this change. * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html: * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html: * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024-expected.txt: Added. * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html: Added. * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025-expected.txt: Added. * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html: Added. * web-platform-tests/css/css-grid/grid-items/w3c-import.log: Source/WebCore: In r225776 we added the conditions from the spec to apply the automatic minimum size clamping when required but only to non-spanning items. See: https://drafts.csswg.org/css-grid/#min-size-auto This patch moves the code from GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem() to GridTrackSizingAlgorithmStrategy::minSizeForChild() that way the clamping is applied for both spanning and non-spanning items. This somehow reverts r225776, as it was adding some duplicated code. All the checks to know if we should use that part of the spec were already present in GridTrackSizingAlgorithmStrategy::minSizeForChild(). Apart from using the previous code, there's a new loop to verify that the max track sizing function is fixed for all the tracks of the item. Tests: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem): (WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (228660 => 228661) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-02-19 12:08:42 UTC (rev 228660) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-02-19 12:10:16 UTC (rev 228661) @@ -1,3 +1,22 @@ +2018-02-19 Manuel Rego Casasnovas <r...@igalia.com> + +[css-grid] Apply automatic minimum size clamping to spanning items too +https://bugs.webkit.org/show_bug.cgi?id=182684 + +Reviewed by Javier Fernandez. + +Update WPT tests related to this change. + +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt: +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html: +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt: +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html: +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024-expected.txt: Added. +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html: Added. +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025-expected.txt: Added. +* web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html: Added. +* web-platform-tests/css/css-grid/grid-items/w3c-import.log: + 2018-02-16 Daniel Bates <daba...@apple.com> Re
[webkit-changes] [227676] trunk
Title: [227676] trunk Revision 227676 Author r...@igalia.com Date 2018-01-26 06:57:47 -0800 (Fri, 26 Jan 2018) Log Message [css-multicol] Support percentages in column-gap https://bugs.webkit.org/show_bug.cgi?id=182004 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: New expected results for a few tests that are passing now. One is the test for this specific patch, the other are tests related to animations of "normal" and initial value, that were fixed with the introduction of GapLength. * web-platform-tests/css/css-multicol/multicol-gap-animation-002-expected.txt: * web-platform-tests/css/css-multicol/multicol-gap-animation-003-expected.txt: * web-platform-tests/css/css-multicol/multicol-gap-percentage-001-expected.txt: Source/WebCore: This patch adds percentage support to column-gap property. Most of the changes are related to the parsing logic, the column-gap property now accepts both length and percentages, on top of the "normal" initial value. A new utility class GapLength has been added, as it'll be useful to implement row-gap in the future. Apart from that the muticolumn layout code has been modified to resolve the percentage gaps (treating them as zero while computing preferred widths) and resolving them during layout. This doesn't follow the current text on the spec, but there is an ongoing discussion that might cause the text is changed: https://github.com/w3c/csswg-drafts/issues/509#issuecomment-355242101 We could update the implementation once we have a definitive answer from the CSS WG. Test: web-platform-tests/css/css-multicol/multicol-gap-percentage-001.html * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle): * css/CSSProperties.json: * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::convertGapLength): * css/StyleBuilderCustom.h: (WebCore::forwardInheritedValue): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeGapLength): (WebCore::CSSPropertyParser::parseSingleValue): * page/FrameView.cpp: (WebCore::FrameView::applyPaginationToViewport): * page/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::columnGap const): * rendering/RenderMultiColumnSet.cpp: (WebCore::RenderMultiColumnSet::columnGap const): * rendering/style/GapLength.cpp: Added. (WebCore::operator<<): * rendering/style/GapLength.h: Added. (WebCore::GapLength::GapLength): (WebCore::GapLength::isNormal const): (WebCore::GapLength::length const): (WebCore::GapLength::operator== const): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::columnGap const): (WebCore::RenderStyle::setColumnGap): (WebCore::RenderStyle::initialColumnGap): * rendering/style/StyleMultiColData.cpp: (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleMultiColData::operator== const): * rendering/style/StyleMultiColData.h: * style/StyleResolveForDocument.cpp: (WebCore::Style::resolveForDocument): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-animation-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-animation-003-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-gap-percentage-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSProperties.json trunk/Source/WebCore/css/StyleBuilderConverter.h trunk/Source/WebCore/css/StyleBuilderCustom.h trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleMultiColData.cpp trunk/Source/WebCore/rendering/style/StyleMultiColData.h trunk/Source/WebCore/style/StyleResolveForDocument.cpp Added Paths trunk/Source/WebCore/rendering/style/GapLength.cpp trunk/Source/WebCore/rendering/style/GapLength.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (227675 => 227676) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-01-26 14:52:26 UTC (rev 227675) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-01-26 14:57:47 UTC (rev 227676) @@ -1,3 +1,18 @@ +2018-01-26 Manuel Rego Casasnovas <r...@igalia.com> + +[css-multicol] Support percentages in column-gap +https://bugs.webkit.org/show_bug.cgi?id=182004 + +Reviewed by Javier Fernandez. + +New expected results for a few tests that are passing now. +One is the test
[webkit-changes] [227605] trunk/LayoutTests
Title: [227605] trunk/LayoutTests Revision 227605 Author r...@igalia.com Date 2018-01-25 07:25:48 -0800 (Thu, 25 Jan 2018) Log Message [css-multicol] Some test imported in r227600 are failing Unreviewed gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (227604 => 227605) --- trunk/LayoutTests/ChangeLog 2018-01-25 13:53:59 UTC (rev 227604) +++ trunk/LayoutTests/ChangeLog 2018-01-25 15:25:48 UTC (rev 227605) @@ -1,5 +1,13 @@ 2018-01-25 Manuel Rego Casasnovas <r...@igalia.com> +[css-multicol] Some test imported in r227600 are failing + +Unreviewed gardening. + +* TestExpectations: + +2018-01-25 Manuel Rego Casasnovas <r...@igalia.com> + [css-multicol] Update WPT test suite https://bugs.webkit.org/show_bug.cgi?id=182087 Modified: trunk/LayoutTests/TestExpectations (227604 => 227605) --- trunk/LayoutTests/TestExpectations 2018-01-25 13:53:59 UTC (rev 227604) +++ trunk/LayoutTests/TestExpectations 2018-01-25 15:25:48 UTC (rev 227605) @@ -1087,8 +1087,17 @@ webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-shorthand-2.xht [ ImageOnlyFailure ] webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-span-none-001.xht [ ImageOnlyFailure ] webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-width-ch-001.xht [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-001.html [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-002.html [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-003.html [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-basic-004.html [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-002.xht [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-px-001.xht [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-stacking-001.xht [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-shorthand-001.xht [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-span-all-block-sibling-003.xht [ ImageOnlyFailure ] +webkit.org/b/182087 imported/w3c/web-platform-tests/css/css-multicol/multicol-span-all-margin-nested-firstchild-001.xht [ ImageOnlyFailure ] - webkit.org/b/148884 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection.html [ Pass Failure ] webkit.org/b/148922 svg/as-object/svg-in-object-dynamic-attribute-change.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [227483] trunk/LayoutTests
Title: [227483] trunk/LayoutTests
Revision 227483
Author r...@igalia.com
Date 2018-01-24 01:28:07 -0800 (Wed, 24 Jan 2018)
Log Message
Remove unneeded -expected.txt files for reftest
Unreviewed gardening.
The test fast/multicol/pagination/RightToLeft-max-width.html was converted
into a reftest in r217943, however expectations for GTK+ and Win port were not removed.
* platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Removed.
* platform/win/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt
trunk/LayoutTests/platform/win/fast/multicol/pagination/RightToLeft-max-width-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (227482 => 227483)
--- trunk/LayoutTests/ChangeLog 2018-01-24 09:20:43 UTC (rev 227482)
+++ trunk/LayoutTests/ChangeLog 2018-01-24 09:28:07 UTC (rev 227483)
@@ -1,3 +1,15 @@
+2018-01-24 Manuel Rego Casasnovas <r...@igalia.com>
+
+Remove unneeded -expected.txt files for reftest
+
+Unreviewed gardening.
+
+The test fast/multicol/pagination/RightToLeft-max-width.html was converted
+into a reftest in r217943, however expectations for GTK+ and Win port were not removed.
+
+* platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Removed.
+* platform/win/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Removed.
+
2018-01-23 Wenson Hsieh <wenson_hs...@apple.com>
Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
Deleted: trunk/LayoutTests/platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt (227482 => 227483)
--- trunk/LayoutTests/platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt 2018-01-24 09:20:43 UTC (rev 227482)
+++ trunk/LayoutTests/platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt 2018-01-24 09:28:07 UTC (rev 227483)
@@ -1,24 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-RenderMultiColumnSet at (0,0) size 800x600
-layer at (273,0) size 527x600
- RenderMultiColumnFlowThread at (0,0) size 527x600
-layer at (273,0) size 527x600
- RenderBlock {HTML} at (0,0) size 527x600
-RenderBody {BODY} at (16,8) size 495x584
- RenderBlock {P} at (0,0) size 85x584
-RenderText {#text} at (0,0) size 85x584
- text run at (0,0) width 580: "1 Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt"
- text run at (17,0) width 536: "ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation"
- text run at (34,0) width 510: "ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in"
- text run at (51,0) width 553: "reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint"
- text run at (68,0) width 584: "occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
- RenderImage {IMG} at (164,0) size 180x100 [bgcolor=#00FF00]
- RenderBlock {DIV} at (344,0) size 50x50 [bgcolor=#FF]
- RenderBlock {P} at (410,0) size 85x584
-RenderText {#text} at (0,0) size 85x584
- text run at (0,0) width 580: "2 Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt"
- text run at (17,0) width 536: "ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation"
- text run at (34,0) width 510: "ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in"
- text run at (51,0) width 553: "reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint"
- text run at (68,0) width 584: "occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
Deleted: trunk/LayoutTests/platform/win/fast/multicol/pagination/RightToLeft-max-width-expected.txt (227482 => 227483)
--- trunk/LayoutTests/platform/win/fast/multicol/pagination/RightToLeft-max-width-expected.txt 2018-01-24 09:20:43 UTC (rev 227482)
+++ trunk/LayoutTests/platform/win/fast/multicol/pagination/RightToLeft-max-width-expected.txt 2018-01-24 09:28:07 UTC (rev 227483)
@@ -1,24 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-RenderMultiColumnSet at (0,0) size 800x600
-layer at (268,0) size 532x600
- RenderMultiColumnFlowThread at (0,0) size 532x600
-layer at (268,0) size 532x600
- RenderBlock {HTML} at (0,0) size 532x600
-RenderBody {BODY} at (16,8) size 500x584
- RenderBlock {P} at (0,0) size 90x584
-RenderText {#text} at (0,0) size 9
[webkit-changes] [225776] trunk
Title: [225776] trunk Revision 225776 Author r...@igalia.com Date 2017-12-11 23:11:04 -0800 (Mon, 11 Dec 2017) Log Message [css-grid] Automatic minimum size is not clamped if min track sizing function is auto https://bugs.webkit.org/show_bug.cgi?id=180283 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update expected result in the following WPT tests, as now everything is passing there. * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt: Source/WebCore: We were not clamping the automatic minimum size when the min track sizing function was intrinsic (e.g. minmax(auto, 0px)). However the spec (https://drafts.csswg.org/css-grid/#min-size-auto) is very clear regarding that. This patch modifies GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem(), so in the case of a fixed max track sizing function it clamps the automatic minimum size of the item to the stretch fit of the grid area's size. It needs to take into account if the item has fixed size, margin, border and/or padding as those cannot be clamped. Using WPT tests to verify this behavior, and corrected a bunch of other tests that were wrong. Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem): * rendering/GridTrackSizingAlgorithm.h: (WebCore::GridTrack::growthLimitIsInfinite const): * rendering/style/GridTrackSize.h: (WebCore::GridTrackSize::cacheMinMaxTrackBreadthTypes): (WebCore::GridTrackSize::hasFixedMaxTrackBreadth const): LayoutTests: This patch updates a bunch of tests that were wrong to follow the new behavior. * TestExpectations: Now we're passing one WPT test more. * fast/css-grid-layout/min-height-border-box.html: * fast/css-grid-layout/min-width-margin-box.html: * fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html: * fast/css-grid-layout/percent-of-indefinite-track-size.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/css-grid-layout/min-height-border-box.html trunk/LayoutTests/fast/css-grid-layout/min-width-margin-box.html trunk/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html trunk/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h trunk/Source/WebCore/rendering/style/GridTrackSize.h Diff Modified: trunk/LayoutTests/ChangeLog (225775 => 225776) --- trunk/LayoutTests/ChangeLog 2017-12-12 07:06:16 UTC (rev 225775) +++ trunk/LayoutTests/ChangeLog 2017-12-12 07:11:04 UTC (rev 225776) @@ -1,3 +1,19 @@ +2017-12-11 Manuel Rego Casasnovas <r...@igalia.com> + +[css-grid] Automatic minimum size is not clamped if min track sizing function is auto +https://bugs.webkit.org/show_bug.cgi?id=180283 + +Reviewed by Darin Adler. + +This patch updates a bunch of tests that were wrong +to follow the new behavior. + +* TestExpectations: Now we're passing one WPT test more. +* fast/css-grid-layout/min-height-border-box.html: +* fast/css-grid-layout/min-width-margin-box.html: +* fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html: +* fast/css-grid-layout/percent-of-indefinite-track-size.html: + 2017-12-11 Eric Carlson <eric.carl...@apple.com> Web Inspector: Optionally log WebKit log parameters as JSON Modified: trunk/LayoutTests/TestExpectations (225775 => 225776) --- trunk/LayoutTests/TestExpectations 2017-12-12 07:06:16 UTC (rev 225775) +++ trunk/LayoutTests/TestExpectations 2017-12-12 07:11:04 UTC (rev 225776) @@ -478,7 +478,6 @@ webkit.org/b/165062 fast/css-grid-layout/grid-baseline.html [ ImageOnlyFailure ] webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ] webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] -webkit.org/b/180283 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-001.html
[webkit-changes] [225741] trunk
Title: [225741] trunk Revision 225741 Author r...@igalia.com Date 2017-12-11 01:11:19 -0800 (Mon, 11 Dec 2017) Log Message REGRESSION(r221931): Row stretch doesn't work for grid container with min-height https://bugs.webkit.org/show_bug.cgi?id=180287 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt: Update expectations as the test is now passing. Source/WebCore: In r221931 we moved the stretch phase as the last step of the track sizing algorithm. However this introduced a regression as we were no longer taking into account the grid container min-width|height constraints during this step. The CSS WG modified the spec so it now defines what to do in these situations (https://drafts.csswg.org/css-grid/#algo-stretch): "If the free space is indefinite, but the grid container has a definite min-width/height, use that size to calculate the free space for this step instead." This patch adds a new method GridTrackSizingAlgorithmStrategy::freeSpaceForStretchAutoTracksStep(). When we're in the DefiniteSizeStrategy it just returns the current free space. For the IndefiniteSizeStrategy in the columns case we don't need any special computation (the same that happens in recomputeUsedFlexFractionIfNeeded()); for rows it uses the min size of the grid container (respecting min-width|height properties) to calculate the free space. Test: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-stretch-respects-min-size-001.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const): (WebCore::DefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const): (WebCore::GridTrackSizingAlgorithm::stretchAutoTracks): * rendering/GridTrackSizingAlgorithm.h: LayoutTests: * TestExpectations: Now layout-algorithm/grid-stretch-respects-min-size-001.html from WPT is passing, so this patch removes it from TestExpectations file. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h Diff Modified: trunk/LayoutTests/ChangeLog (225740 => 225741) --- trunk/LayoutTests/ChangeLog 2017-12-11 08:31:38 UTC (rev 225740) +++ trunk/LayoutTests/ChangeLog 2017-12-11 09:11:19 UTC (rev 225741) @@ -1,3 +1,13 @@ +2017-12-11 Manuel Rego Casasnovas <r...@igalia.com> + +REGRESSION(r221931): Row stretch doesn't work for grid container with min-height +https://bugs.webkit.org/show_bug.cgi?id=180287 + +Reviewed by Darin Adler. + +* TestExpectations: Now layout-algorithm/grid-stretch-respects-min-size-001.html +from WPT is passing, so this patch removes it from TestExpectations file. + 2017-12-10 Minsheng Liu <lam...@liu.ms> Incorrect bounds inside / when a stretchy operator is present Modified: trunk/LayoutTests/TestExpectations (225740 => 225741) --- trunk/LayoutTests/TestExpectations 2017-12-11 08:31:38 UTC (rev 225740) +++ trunk/LayoutTests/TestExpectations 2017-12-11 09:11:19 UTC (rev 225741) @@ -479,7 +479,6 @@ webkit.org/b/165062 fast/css-grid-layout/grid-baseline-margins.html [ ImageOnlyFailure ] webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] webkit.org/b/180283 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html [ ImageOnlyFailure ] -webkit.org/b/180287 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-stretch-respects-min-size-001.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-001.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-002.html [ ImageOnlyFailure ] webkit.org/b/180290 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-003.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225740 => 225741) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-11 08:31:38 UTC (rev 225740) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-11 09:11:19 UTC (rev 225741) @@ -1,3 +1,13 @@ +2017-12-11 Manuel Rego Casasnovas <r...@igalia.com> + +REGRESSION(r221931): Row stretch doesn't work for grid container with min-height +https://bugs.webkit.org/show_bug.cgi?id=180287 + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt: +Update expectations as the test is now passing. + 2017-12-08 Chris Dumez <cdu...@apple.com> ServiceWork
[webkit-changes] [225101] trunk
Title: [225101] trunk
Revision 225101
Author r...@igalia.com
Date 2017-11-22 12:37:35 -0800 (Wed, 22 Nov 2017)
Log Message
Available height is wrong for positioned elements with "box-sizing: border-box"
https://bugs.webkit.org/show_bug.cgi?id=178783
Reviewed by Darin Adler.
Source/WebCore:
These methods were returning a wrong value for positioned items
in combination with "box-sizing: border-box".
The problem was that if the height of the element is given
by its offset properties (top and bottom) we don't need to call
adjustContentBoxLogicalHeightForBoxSizing().
Tests: fast/box-sizing/fill-available.html
fast/box-sizing/replaced.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):
LayoutTests:
There are some cases failing in fast/box-sizing/fill-available.html,
this is because of a different bug (see https://webkit.org/b/178790)
as noted down in the text comments.
* fast/box-sizing/fill-available-expected.txt: Added.
* fast/box-sizing/fill-available.html: Added.
* fast/box-sizing/replaced-expected.txt: Added.
* fast/box-sizing/replaced.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/box-sizing/fill-available-expected.txt
trunk/LayoutTests/fast/box-sizing/fill-available.html
trunk/LayoutTests/fast/box-sizing/replaced-expected.txt
trunk/LayoutTests/fast/box-sizing/replaced.html
Diff
Modified: trunk/LayoutTests/ChangeLog (225100 => 225101)
--- trunk/LayoutTests/ChangeLog 2017-11-22 19:44:57 UTC (rev 225100)
+++ trunk/LayoutTests/ChangeLog 2017-11-22 20:37:35 UTC (rev 225101)
@@ -1,3 +1,19 @@
+2017-11-22 Manuel Rego Casasnovas <r...@igalia.com>
+
+Available height is wrong for positioned elements with "box-sizing: border-box"
+https://bugs.webkit.org/show_bug.cgi?id=178783
+
+Reviewed by Darin Adler.
+
+There are some cases failing in fast/box-sizing/fill-available.html,
+this is because of a different bug (see https://webkit.org/b/178790)
+as noted down in the text comments.
+
+* fast/box-sizing/fill-available-expected.txt: Added.
+* fast/box-sizing/fill-available.html: Added.
+* fast/box-sizing/replaced-expected.txt: Added.
+* fast/box-sizing/replaced.html: Added.
+
2017-11-22 Ms2ger <ms2...@igalia.com>
[WPE] Enable request-animation-frame-disabled.html.
Added: trunk/LayoutTests/fast/box-sizing/fill-available-expected.txt (0 => 225101)
--- trunk/LayoutTests/fast/box-sizing/fill-available-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/box-sizing/fill-available-expected.txt 2017-11-22 20:37:35 UTC (rev 225101)
@@ -0,0 +1,18 @@
+
+FAIL .wrapper 1 assert_equals:
+
+
+
+
+
+height expected 180 but got 140
+PASS .wrapper 2
+FAIL .wrapper 3 assert_equals:
+
+
+
+
+
+height expected 180 but got 140
+PASS .wrapper 4
+
Added: trunk/LayoutTests/fast/box-sizing/fill-available.html (0 => 225101)
--- trunk/LayoutTests/fast/box-sizing/fill-available.html (rev 0)
+++ trunk/LayoutTests/fast/box-sizing/fill-available.html 2017-11-22 20:37:35 UTC (rev 225101)
@@ -0,0 +1,66 @@
+
+
+
+
+.wrapper {
+ position: relative;
+ width: 200px;
+ height: 200px;
+}
+
+.positioned {
+ border: 10px solid magenta;
+ position: absolute;
+ left: 0;
+ right: 0;
+ top: 0;
+ bottom: 0;
+}
+
+.fill-available {
+ border: 20px dotted cyan;
+ background: yellow;
+ width: -webkit-fill-available;
+ height: -webkit-fill-available;
+}
+
+.border-box {
+ box-sizing: border-box;
+}
+
+
+
[webkit-changes] [223389] trunk
Title: [223389] trunk
Revision 223389
Author r...@igalia.com
Date 2017-10-16 05:10:47 -0700 (Mon, 16 Oct 2017)
Log Message
Don't use intrinsic width if our container's width is zero
https://bugs.webkit.org/show_bug.cgi?id=178073
Reviewed by Sergio Villar Senin.
Source/WebCore:
Based on Blink r173212 by <robho...@gmail.com>.
https://chromium.googlesource.com/chromium/src/+/1592e8a1e8e56dfa6e5d709c50b129ae659c2fad
Since at least r798 we use a replaced element's intrinsic width
if its containing block has a width of zero. As a result our rendering
of width100percent-image.html has disagreed with all other browsers
and we display replaced elements when they should be invisible.
Test: fast/replaced/container-width-zero.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
If our container has zero width then let our width be zero too.
LayoutTests:
New rebaseline for width100percent-image.html test.
* fast/replaced/container-width-zero-expected.txt: Added.
* fast/replaced/container-width-zero.html: Added.
* platform/ios/fast/replaced/width100percent-image-expected.txt:
* platform/gtk/fast/replaced/width100percent-image-expected.png:
* platform/gtk/fast/replaced/width100percent-image-expected.txt:
* platform/mac/fast/replaced/width100percent-image-expected.png:
* platform/mac/fast/replaced/width100percent-image-expected.txt:
* platform/win/TestExpectations: Skips test as it needs a rebaseline.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/replaced/width100percent-image-expected.png
trunk/LayoutTests/platform/gtk/fast/replaced/width100percent-image-expected.txt
trunk/LayoutTests/platform/ios/fast/replaced/width100percent-image-expected.txt
trunk/LayoutTests/platform/mac/fast/replaced/width100percent-image-expected.png
trunk/LayoutTests/platform/mac/fast/replaced/width100percent-image-expected.txt
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/replaced/container-width-zero-expected.txt
trunk/LayoutTests/fast/replaced/container-width-zero.html
Diff
Modified: trunk/LayoutTests/ChangeLog (223388 => 223389)
--- trunk/LayoutTests/ChangeLog 2017-10-16 11:59:45 UTC (rev 223388)
+++ trunk/LayoutTests/ChangeLog 2017-10-16 12:10:47 UTC (rev 223389)
@@ -1,3 +1,21 @@
+2017-10-16 Manuel Rego Casasnovas <r...@igalia.com>
+
+Don't use intrinsic width if our container's width is zero
+https://bugs.webkit.org/show_bug.cgi?id=178073
+
+Reviewed by Sergio Villar Senin.
+
+New rebaseline for width100percent-image.html test.
+
+* fast/replaced/container-width-zero-expected.txt: Added.
+* fast/replaced/container-width-zero.html: Added.
+* platform/ios/fast/replaced/width100percent-image-expected.txt:
+* platform/gtk/fast/replaced/width100percent-image-expected.png:
+* platform/gtk/fast/replaced/width100percent-image-expected.txt:
+* platform/mac/fast/replaced/width100percent-image-expected.png:
+* platform/mac/fast/replaced/width100percent-image-expected.txt:
+* platform/win/TestExpectations: Skips test as it needs a rebaseline.
+
2017-10-16 Wenson Hsieh <wenson_hs...@apple.com>
On ToT, event.dataTransfer.getData("text/uri-list") returns an empty string when dragging an image
Added: trunk/LayoutTests/fast/replaced/container-width-zero-expected.txt (0 => 223389)
--- trunk/LayoutTests/fast/replaced/container-width-zero-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/replaced/container-width-zero-expected.txt 2017-10-16 12:10:47 UTC (rev 223389)
@@ -0,0 +1,6 @@
+Bug #178073 - Don't use intrinsic width if our container's width is zero
+
+The test passes if you see PASS and no red.
+
+
+PASS
Added: trunk/LayoutTests/fast/replaced/container-width-zero.html (0 => 223389)
--- trunk/LayoutTests/fast/replaced/container-width-zero.html (rev 0)
+++ trunk/LayoutTests/fast/replaced/container-width-zero.html 2017-10-16 12:10:47 UTC (rev 223389)
@@ -0,0 +1,12 @@
+
+
[webkit-changes] [222441] trunk/Source/WebCore
Title: [222441] trunk/Source/WebCore
Revision 222441
Author r...@igalia.com
Date 2017-09-25 01:39:48 -0700 (Mon, 25 Sep 2017)
Log Message
[css-grid] Small refactoring adding RenderGrid::contentAlignment()
https://bugs.webkit.org/show_bug.cgi?id=177130
Reviewed by Sergio Villar Senin.
As a follow-up of r221931, this patch does a small refactoring
adding a new method RenderGrid::contentAlignment()
that is used from RenderGrid and GridTrackSizingAlgorithm.
No new tests, no change of behavior.
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::stretchAutoTracks):
* rendering/RenderGrid.cpp:
(WebCore::contentAlignmentNormalBehaviorGrid):
(WebCore::RenderGrid::contentAlignment const):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset const):
(WebCore::RenderGrid::contentAlignmentNormalBehaviorGrid): Deleted.
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.cpp:
(WebCore::resolvedContentAlignment):
(WebCore::RenderStyle::resolvedAlignContent const):
(WebCore::RenderStyle::resolvedJustifyContent const):
* rendering/style/RenderStyle.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (222440 => 222441)
--- trunk/Source/WebCore/ChangeLog 2017-09-25 07:28:07 UTC (rev 222440)
+++ trunk/Source/WebCore/ChangeLog 2017-09-25 08:39:48 UTC (rev 222441)
@@ -1,5 +1,32 @@
2017-09-25 Manuel Rego Casasnovas <r...@igalia.com>
+[css-grid] Small refactoring adding RenderGrid::contentAlignment()
+https://bugs.webkit.org/show_bug.cgi?id=177130
+
+Reviewed by Sergio Villar Senin.
+
+As a follow-up of r221931, this patch does a small refactoring
+adding a new method RenderGrid::contentAlignment()
+that is used from RenderGrid and GridTrackSizingAlgorithm.
+
+No new tests, no change of behavior.
+
+* rendering/GridTrackSizingAlgorithm.cpp:
+(WebCore::GridTrackSizingAlgorithm::stretchAutoTracks):
+* rendering/RenderGrid.cpp:
+(WebCore::contentAlignmentNormalBehaviorGrid):
+(WebCore::RenderGrid::contentAlignment const):
+(WebCore::RenderGrid::computeContentPositionAndDistributionOffset const):
+(WebCore::RenderGrid::contentAlignmentNormalBehaviorGrid): Deleted.
+* rendering/RenderGrid.h:
+* rendering/style/RenderStyle.cpp:
+(WebCore::resolvedContentAlignment):
+(WebCore::RenderStyle::resolvedAlignContent const):
+(WebCore::RenderStyle::resolvedJustifyContent const):
+* rendering/style/RenderStyle.h:
+
+2017-09-25 Manuel Rego Casasnovas <r...@igalia.com>
+
[css-grid] fit-content() tracks shouldn't stretch
https://bugs.webkit.org/show_bug.cgi?id=177300
Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (222440 => 222441)
--- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2017-09-25 07:28:07 UTC (rev 222440)
+++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2017-09-25 08:39:48 UTC (rev 222441)
@@ -1071,14 +1071,11 @@
void GridTrackSizingAlgorithm::stretchAutoTracks()
{
-if (m_autoSizedTracksForStretchIndex.isEmpty())
-return;
-
auto currentFreeSpace = freeSpace(m_direction);
-if (!currentFreeSpace
+if (m_autoSizedTracksForStretchIndex.isEmpty()
+|| !currentFreeSpace
|| currentFreeSpace.value() <= 0
-|| (m_direction == ForColumns && m_renderGrid->style().resolvedJustifyContentDistribution(m_renderGrid->contentAlignmentNormalBehaviorGrid()) != ContentDistributionStretch)
-|| (m_direction == ForRows && m_renderGrid->style().resolvedAlignContentDistribution(m_renderGrid->contentAlignmentNormalBehaviorGrid()) != ContentDistributionStretch))
+|| (m_renderGrid->contentAlignment(m_direction).distribution() != ContentDistributionStretch))
return;
Vector& allTracks = tracks(m_direction);
Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (222440 => 222441)
--- trunk/Source/WebCore/rendering/RenderGrid.cpp 2017-09-25 07:28:07 UTC (rev 222440)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp 2017-09-25 08:39:48 UTC (rev 222441)
@@ -877,7 +877,7 @@
return tracks;
}
-const StyleContentAlignmentData& RenderGrid::contentAlignmentNormalBehaviorGrid()
+static const StyleContentAlignmentData& contentAlignmentNormalBehaviorGrid()
{
static const StyleContentAlignmentData normalBehavior = {ContentPositionNormal, ContentDistributionStretch};
return normalBehavior;
@@ -1581,19 +1581,23 @@
return ContentAlignmentData::defaultOffsets();
}
+StyleContentAlignmentData RenderGrid::conten
[webkit-changes] [222440] trunk
Title: [222440] trunk Revision 222440 Author r...@igalia.com Date 2017-09-25 00:28:07 -0700 (Mon, 25 Sep 2017) Log Message [css-grid] fit-content() tracks shouldn't stretch https://bugs.webkit.org/show_bug.cgi?id=177300 Reviewed by Sergio Villar Senin. LayoutTests/imported/w3c: Imported a new test in WPT covering several cases for this issue. * web-platform-tests/css/css-grid-1/alignment/grid-fit-content-tracks-dont-stretch-001-expected.txt: Added. * web-platform-tests/css/css-grid-1/alignment/grid-fit-content-tracks-dont-stretch-001.html: Added. * web-platform-tests/css/css-grid-1/alignment/w3c-import.log: Source/WebCore: The spec is pretty clear regarding this (https://drafts.csswg.org/css-grid/#algo-stretch): "This step sizes expands tracks that have an auto max track sizing function by dividing any remaining positive, definite free space equally amongst them." The fit-content() tracks don't have an auto max track sizing function, so they shouldn't be considered in this step of the algorithm. The patch modifies GridTrackSizingAlgorithm::initializeTrackSizes() so it doesn't consider fit-content() tracks as auto sized ones (which are the ones later stretched in the last step of the algorithm). Test: imported/w3c/web-platform-tests/css/css-grid-1/alignment/grid-fit-content-tracks-dont-stretch-001.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::initializeTrackSizes): (WebCore::GridTrackSizingAlgorithm::stretchAutoTracks): (WebCore::GridTrackSizingAlgorithm::setup): (WebCore::GridTrackSizingAlgorithm::reset): * rendering/GridTrackSizingAlgorithm.h: LayoutTests: Added new case to an existent test and also modified the expected result in another one. * fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt: * fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html: * fast/css-grid-layout/grid-intrinsic-maximums-expected.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html trunk/LayoutTests/fast/css-grid-layout/grid-intrinsic-maximums-expected.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/alignment/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/alignment/grid-fit-content-tracks-dont-stretch-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/alignment/grid-fit-content-tracks-dont-stretch-001.html Diff Modified: trunk/LayoutTests/ChangeLog (222439 => 222440) --- trunk/LayoutTests/ChangeLog 2017-09-25 05:57:01 UTC (rev 222439) +++ trunk/LayoutTests/ChangeLog 2017-09-25 07:28:07 UTC (rev 222440) @@ -1,3 +1,17 @@ +2017-09-25 Manuel Rego Casasnovas <r...@igalia.com> + +[css-grid] fit-content() tracks shouldn't stretch +https://bugs.webkit.org/show_bug.cgi?id=177300 + +Reviewed by Sergio Villar Senin. + +Added new case to an existent test and also modified +the expected result in another one. + +* fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt: +* fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html: +* fast/css-grid-layout/grid-intrinsic-maximums-expected.html: + 2017-09-24 Joanmarie Diggs <jdi...@igalia.com> [ATK] Object attributes are missing for ARIA live region roles Modified: trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt (222439 => 222440) --- trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt 2017-09-25 05:57:01 UTC (rev 222439) +++ trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks-expected.txt 2017-09-25 07:28:07 UTC (rev 222440) @@ -21,3 +21,10 @@ cols: 'minmax(auto, max-content)' | rows: 'minmax(auto, max-content)' | definite-sized container | definite-sized items PASS +cols: 'fit-content(40px)' | rows: 'fit-content(20px)' | definite-sized container | content-sized items + +X XX XX X +X XX XX X +X XX XX X +X XX XX X +PASS Modified: trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html (222439 => 222440) --- trunk/LayoutTests/fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html 2017-09-25 05:57:01 UTC (rev 222439) +++ trunk/LayoutTests/fast/css-grid-layout/grid-content-alignm
[webkit-changes] [221931] trunk
Title: [221931] trunk
Revision 221931
Author r...@igalia.com
Date 2017-09-12 12:19:45 -0700 (Tue, 12 Sep 2017)
Log Message
[css-grid] Stretching auto tracks should be done as part of the track sizing algorithm
https://bugs.webkit.org/show_bug.cgi?id=176783
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Import changes on the test related to the new behavior.
* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html:
Source/WebCore:
CSS WG has agreed to modify the track sizing algorithm to include
a new step: https://drafts.csswg.org/css-grid/#algo-stretch
We used to do the stretch of the "auto" tracks at the end of
the track sizing algorithm, however this change integrates it
into the algorithm itself as the last step.
See: https://github.com/w3c/csswg-drafts/issues/1150
The patch moves the method
RenderGrid::applyStretchAlignmentToTracksIfNeeded() to
GridTrackSizingAlgorithm::stretchAutoTracks().
And then modifies the grid track sizing algorithm to execute
the new step.
This patch uses the WPT test updated to check the new behavior.
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes): Initialize
the list of auto tracks.
(WebCore::GridTrackSizingAlgorithm::stretchFlexibleTracks): Add
early return if there are not flexible tracks.
(WebCore::GridTrackSizingAlgorithm::stretchAutoTracks): Code moved from
RenderGrid::applyStretchAlignmentToTracksIfNeeded().
(WebCore::GridTrackSizingAlgorithm::setup): Reset list of auto tracks.
(WebCore::GridTrackSizingAlgorithm::run): Add new step
stretchAutoTracks().
(WebCore::GridTrackSizingAlgorithm::reset): Reset auto tracks.
* rendering/GridTrackSizingAlgorithm.h: Add m_autoSizedTracksIndex.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Avoid applying stretch here.
(WebCore::RenderGrid::contentAlignmentNormalBehaviorGrid): Make public.
(WebCore::RenderGrid::applyStretchAlignmentToTracksIfNeeded): Moved to
GridTrackSizingAlgorithm::stretchAutoTracks().
* rendering/RenderGrid.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (221930 => 221931)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-09-12 19:17:35 UTC (rev 221930)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-09-12 19:19:45 UTC (rev 221931)
@@ -1,5 +1,16 @@
2017-09-12 Manuel Rego Casasnovas <r...@igalia.com>
+[css-grid] Stretching auto tracks should be done as part of the track sizing algorithm
+https://bugs.webkit.org/show_bug.cgi?id=176783
+
+Reviewed by Sergio Villar Senin.
+
+Import changes on the test related to the new behavior.
+
+* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html:
+
+2017-09-12 Manuel Rego Casasnovas <r...@igalia.com>
+
[css-grid] Use transferred size over content size for automatic minimum size
https://bugs.webkit.org/show_bug.cgi?id=176688
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html (221930 => 221931)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html 2017-09-12 19:17:35 UTC (rev 221930)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html 2017-09-12 19:19:45 UTC (rev 221931)
@@ -68,14 +68,14 @@
function runTests() {
checkGridSizeTracksAndImageSize("grid-1", "img-1", "200px", "200px", "200px", "200px", "200px", "200px");
checkGridSizeTracksAndImageSize("grid-2", "img-2", "10px", "10px", "200px", "200px", "200px", "200px");
-checkGridSizeTracksAndImageSize("grid-3", "img-3", "200px", "50px", "200px", "50px", "200px", "200px");
-checkGridSizeTracksAndImageSize("grid-4", "img-4", "200px", "10px", "200px", "50px", "200px", "200px");
+checkGridSizeTracksAndImageSize("grid-3", "img-3", "200px", "200px", "200px", "200px", "200px", "200px");
+checkGridSizeTracksAndImageSize("grid-4", "img-4", "200px", "10px", "200px", "200px", "200
[webkit-changes] [221910] trunk
Title: [221910] trunk Revision 221910 Author r...@igalia.com Date 2017-09-12 04:30:48 -0700 (Tue, 12 Sep 2017) Log Message [css-grid] Use transferred size over content size for automatic minimum size https://bugs.webkit.org/show_bug.cgi?id=176688 Reviewed by Sergio Villar Senin. LayoutTests/imported/w3c: Import changes on the tests related to the new behavior. * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html: * web-platform-tests/css/css-grid-1/grid-items/support/100x50-green.png: Removed. * web-platform-tests/css/css-grid-1/grid-items/support/25x50-green.png: Added. * web-platform-tests/css/css-grid-1/grid-items/support/50x100-green.png: Removed. * web-platform-tests/css/css-grid-1/grid-items/support/50x25-green.png: Added. * web-platform-tests/css/css-grid-1/grid-items/support/w3c-import.log: Source/WebCore: CSS WG has agreed to modify the spec so now the transferred size is used (if it exists) independently if it's bigger or smaller than the content size. See: https://github.com/w3c/csswg-drafts/issues/1149 The spec text (https://drafts.csswg.org/css-grid/#min-size-auto): "The automatic minimum size for a grid item in a given dimension is its specified size if it exists, otherwise its transferred size if that exists, else its content size" This patch use the WPT tests updated to check the new behavior. * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const): Modified so it always returns the transferred size (if any). Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/w3c-import.log trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/25x50-green.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/50x25-green.png Removed Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/100x50-green.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/50x100-green.png Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (221909 => 221910) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-09-12 11:21:36 UTC (rev 221909) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-09-12 11:30:48 UTC (rev 221910) @@ -1,3 +1,23 @@ +2017-09-12 Manuel Rego Casasnovas <r...@igalia.com> + +[css-grid] Use transferred size over content size for automatic minimum size +https://bugs.webkit.org/show_bug.cgi?id=176688 + +Reviewed by Sergio Villar Senin. + +Import changes on the tests related to the new behavior. + +* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html: +* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.html: +* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.html: +* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.html: +* web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html: +* web-platform-tests/css/css-grid-1/grid-items/support/100x50-green.png: Removed. +* web-platform-tests/css/css-grid-1/grid-items/support/25x50-green.png: Added. +* web-platform-tests/css/css-grid-1/grid-items/support/50x100-green.png: Removed. +* web-platform-tests/css/css-grid-1/grid-items/support/50x25-green.png: Added. +* web-platform-tests/css/css-grid-1/grid-items/support/w3c-import.log: + 2017-09-11 Joseph Pecoraro <pecor...@apple.com> Make the WPT entry point for LayoutTests/http/wpt more discoverable Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html (221909 => 221910) --- trunk/LayoutTests/imported/w3c/web-platfo
[webkit-changes] [221668] trunk
Title: [221668] trunk
Revision 221668
Author r...@igalia.com
Date 2017-09-06 02:59:26 -0700 (Wed, 06 Sep 2017)
Log Message
[css-grid] grid shorthand should not reset the gutter properties
https://bugs.webkit.org/show_bug.cgi?id=176375
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Import new test from WPT.
* web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001-expected.txt: Added.
* web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html: Added.
* web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log:
Source/WebCore:
The CSS WG has resolved that the "grid" shorthand shouldn't reset
the gutter properties anymore:
https://github.com/w3c/csswg-drafts/issues/1036
This was originally implemented in r195529, so this is somehow
a revert of that change.
Test: imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html
* css/CSSProperties.json:
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeGridShorthand):
LayoutTests:
Update the test to check the new behavior.
* fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
* fast/css-grid-layout/grid-shorthand-get-set.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html
Diff
Modified: trunk/LayoutTests/ChangeLog (221667 => 221668)
--- trunk/LayoutTests/ChangeLog 2017-09-06 08:17:59 UTC (rev 221667)
+++ trunk/LayoutTests/ChangeLog 2017-09-06 09:59:26 UTC (rev 221668)
@@ -1,3 +1,15 @@
+2017-09-06 Manuel Rego Casasnovas <r...@igalia.com>
+
+[css-grid] grid shorthand should not reset the gutter properties
+https://bugs.webkit.org/show_bug.cgi?id=176375
+
+Reviewed by Sergio Villar Senin.
+
+Update the test to check the new behavior.
+
+* fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
+* fast/css-grid-layout/grid-shorthand-get-set.html:
+
2017-09-06 Zan Dobersek <zdober...@igalia.com>
[WebGL2] Implement getActiveUniforms()
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt (221667 => 221668)
--- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt 2017-09-06 08:17:59 UTC (rev 221667)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set-expected.txt 2017-09-06 09:59:26 UTC (rev 221668)
@@ -331,11 +331,11 @@
PASS getComputedStyle(element, '').getPropertyValue('grid-auto-rows') is "auto"
PASS element.style.gridAutoRows is "initial"
-Test the inherit value on reset-only subproperties (grid-*-gap)
+Test the inherit value does not affect gutter properties (grid-*-gap)
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "0px"
PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "0px"
-PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "20px"
-PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "100px"
+PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-column-gap') is "0px"
+PASS getComputedStyle(anotherElement, '').getPropertyValue('grid-row-gap') is "0px"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html (221667 => 221668)
--- trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html 2017-09-06 08:17:59 UTC (rev 221667)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html 2017-09-06 09:59:26 UTC (rev 221668)
@@ -205,7 +205,7 @@
testGridDefinitionsSetJSValues("none", "none", "none", "none", "row", "auto", "auto", "none", "none", "none", "initial", "initial", "initial");
debug("");
-debug("Test the inherit value on reset-only subproperties (grid-*-gap)");
+debug("Test the inherit value does not affect gutter properties (grid-*-gap)");
document.body.style.gridRowGap = "100px";
document.body.style.gridColumnGap = "20px";
var anotherElement = document.createElement("div");
@@ -213,8 +213,8 @@
shouldBeEqualToS
[webkit-changes] [220639] trunk
Title: [220639] trunk
Revision 220639
Author r...@igalia.com
Date 2017-08-13 23:31:35 -0700 (Sun, 13 Aug 2017)
Log Message
Composition underline color is always black
https://bugs.webkit.org/show_bug.cgi?id=174675
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.
Test: editing/composition-underline-color.html
* editing/CompositionUnderline.h:
(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.
Source/WebKit:
This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.
* UIProcess/gtk/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setCompositionForTesting): Ditto.
Source/WebKitLegacy/mac:
* WebView/WebHTMLView.mm:
(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.
Source/WebKitLegacy/win:
* WebView.cpp:
(WebView::setCompositionForTesting): Use text color for
composition underline.
LayoutTests:
Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.
* editing/composition-underline-color-expected-mismatch.html: Added.
* editing/composition-underline-color.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/CompositionUnderline.h
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebView.cpp
Added Paths
trunk/LayoutTests/editing/composition-underline-color-expected-mismatch.html
trunk/LayoutTests/editing/composition-underline-color.html
Diff
Modified: trunk/LayoutTests/ChangeLog (220638 => 220639)
--- trunk/LayoutTests/ChangeLog 2017-08-14 06:23:27 UTC (rev 220638)
+++ trunk/LayoutTests/ChangeLog 2017-08-14 06:31:35 UTC (rev 220639)
@@ -1,3 +1,19 @@
+2017-08-13 Manuel Rego Casasnovas <r...@igalia.com>
+
+Composition underline color is always black
+https://bugs.webkit.org/show_bug.cgi?id=174675
+
+Reviewed by Ryosuke Niwa.
+
+Added new test to check that the composition underline
+is using the text color.
+The test hides the text and the caret, so it only shows
+the composition underline and checks against an -expected-mismatch
+that the color of the composition marker is different.
+
+* editing/composition-underline-color-expected-mismatch.html: Added.
+* editing/composition-underline-color.html: Added.
+
2017-08-11 Ryosuke Niwa <rn...@webkit.org>
Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
Added: trunk/LayoutTests/editing/composition-underline-color-expected-mismatch.html (0 => 220639)
--- trunk/LayoutTests/editing/composition-underline-color-expected-mismatch.html (rev 0)
+++ trunk/LayoutTests/editing/composition-underline-color-expected-mismatch.html 2017-08-14 06:31:35 UTC (rev 220639)
@@ -0,0 +1,33 @@
+
+
+ div {
+position: absolute;
+top: 0;
+left: 0;
+ }
+ #test {
+color: magenta;
+font: 20px/1 Monospace;
+outline: none;
+ }
+ #overlapping-top {
+background: white;
+width: 100px;
+height: 15px;
+ }
+ #overlapping-right {
+background: white;
+width: 50px;
+height: 50px;
+left: 50px;
+ }
+
+
+
+
+
+
+ document.getElementById("test").focus();
+ if (window.textInputController)
+textInputController.setMarkedText("^", 5, 0);
+
Added: trunk/LayoutTests/editing/composition-underline-color.html (0 => 220639)
--- trunk/LayoutTests
[webkit-changes] [215463] trunk
Title: [215463] trunk Revision 215463 Author r...@igalia.com Date 2017-04-18 09:27:53 -0700 (Tue, 18 Apr 2017) Log Message [css-grid] Add support for percentage gaps https://bugs.webkit.org/show_bug.cgi?id=170764 Reviewed by Sergio Villar Senin. Source/WebCore: Part of the code to support percentage gaps was already imported from Blink in r213149 (bug #168657). However parsing was not enabled yet, so some pieces were missing. This patch accepts percentages in the parsing of grid-column-gap and grid-row-gap properties, and the grid-gap shorthand. On top of that it gets rid of GridTrackSizingAlgorithm::sizingOperation() method as it's not needed. And instead it passes the specific operation to each call to RenderGrid::guttersSize(), otherwise we would be getting wrong results. Test: fast/css-grid-layout/grid-gutters-as-percentage.html * css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseSingleValue): Add support for percentage values. (WebCore::CSSPropertyParser::parseShorthand): Ditto. * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::recomputeUsedFlexFractionIfNeeded): Pass the specific sizing operation. * rendering/GridTrackSizingAlgorithm.h: Remove sizingOperation(). * rendering/RenderGrid.cpp: (WebCore::RenderGrid::computeTrackBasedLogicalHeight): Pass the specific sizing operation. (WebCore::RenderGrid::computeTrackSizesForDefiniteSize): Ditto. (WebCore::RenderGrid::computeTrackSizesForIndefiniteSize): Ditto. (WebCore::RenderGrid::populateGridPositionsForDirection): Ditto. LayoutTests: Import tests from Blink. * fast/css-grid-layout/grid-gutters-as-percentage-expected.txt: Added. * fast/css-grid-layout/grid-gutters-as-percentage.html: Added. * fast/css-grid-layout/grid-gutters-get-set-expected.txt: * fast/css-grid-layout/grid-gutters-get-set.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h trunk/Source/WebCore/rendering/RenderGrid.cpp Added Paths trunk/LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html Diff Modified: trunk/LayoutTests/ChangeLog (215462 => 215463) --- trunk/LayoutTests/ChangeLog 2017-04-18 16:17:36 UTC (rev 215462) +++ trunk/LayoutTests/ChangeLog 2017-04-18 16:27:53 UTC (rev 215463) @@ -1,3 +1,17 @@ +2017-04-18 Manuel Rego Casasnovas <r...@igalia.com> + +[css-grid] Add support for percentage gaps +https://bugs.webkit.org/show_bug.cgi?id=170764 + +Reviewed by Sergio Villar Senin. + +Import tests from Blink. + +* fast/css-grid-layout/grid-gutters-as-percentage-expected.txt: Added. +* fast/css-grid-layout/grid-gutters-as-percentage.html: Added. +* fast/css-grid-layout/grid-gutters-get-set-expected.txt: +* fast/css-grid-layout/grid-gutters-get-set.html: + 2017-04-18 Miguel Gomez <mago...@igalia.com> [GTK+] Crash in WebCore::ImageFrame::ImageFrame() Added: trunk/LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage-expected.txt (0 => 215463) --- trunk/LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage-expected.txt 2017-04-18 16:27:53 UTC (rev 215463) @@ -0,0 +1,109 @@ + +PASS .grid 1 +PASS .grid 2 +PASS .grid 3 +PASS .grid 4 +PASS .grid 5 +PASS .grid 6 +PASS .grid 7 +PASS .grid 8 +PASS .grid 9 +PASS .grid 10 +PASS .grid 11 +PASS .grid 12 +PASS .grid 13 +PASS .grid 14 +PASS .grid 15 +PASS .grid 16 +Height is indefinite, so row gaps should be 0. Column gaps based on a grid's 'auto' width, which will reduce the available space for tracks; however, they can grow exceeding their content's max-width. + +XXX X XX X +XX XXX X X +X XX XXX X +X X XX +Height is indefinite, so row gaps should be 0. Column gaps based on a grid's 'instrinsic' width, which reduce the available space for tracks; however, since we use 'fit-content' intrinsic size, first column's width is reduced and height increased to let its content to fit. + +XXX X XX X +XX XXX X X +X XX XXX X +X X XX +Height is indefinite, so row gaps should be 0. Column gaps based on a grid's 'auto' width, which will reduce the available space for tracks; however, they can grow exceeding their content's max-width. + +XXX X XX X +XX XXX X X +X XX XXX X +X X XX +Height is indefinite, so row gaps should be 0. Column gaps based on a grid's 'instrinsic' width, which reduce the available space for tracks; however, since we use 'fit-content' intrinsic size, first column's width is reduced and height in
[webkit-changes] [215457] trunk/LayoutTests
ed/w3c/web-platform-tests/css/selectors4/focus-within-006.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-007-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-007.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-008-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-008.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-009-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-009.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-002.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-003.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-006-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-006.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/of-type-selectors-expected.xhtml trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/of-type-selectors.xhtml trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selector-required-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selector-required.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-ltr-001-expected.xht trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-ltr-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-rtl-001-expected.xht trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-rtl-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/w3c-import.log Diff Modified: trunk/LayoutTests/ChangeLog (215456 => 215457) --- trunk/LayoutTests/ChangeLog 2017-04-18 08:11:47 UTC (rev 215456) +++ trunk/LayoutTests/ChangeLog 2017-04-18 09:17:19 UTC (rev 215457) @@ -1,3 +1,13 @@ +2017-04-18 Manuel Rego Casasnovas <r...@igalia.com> + +[selectors4] Import W3C Test Suite +https://bugs.webkit.org/show_bug.cgi?id=170898 + +Reviewed by Youenn Fablet. + +* TestExpectations: Mark a few tests as failure linking to the related bugs. +* platform/mac-wk1/TestExpectations: Marking some tests that have issues on WK1. + 2017-04-18 Carlos Garcia Campos <cgar...@igalia.com> Unreviewed GTK+ gardening. Add several test expectations. Modified: trunk/LayoutTests/TestExpectations (215456 => 215457) --- trunk/LayoutTests/TestExpectations 2017-04-18 08:11:47 UTC (rev 215456) +++ trunk/LayoutTests/TestExpectations 2017-04-18 09:17:19 UTC (rev 215457) @@ -278,6 +278,12 @@ webkit.org/b/149891 imported/w3c/web-platform-tests/css/css-grid-1/grid-layout-properties.html [ Failure ] webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ] +# selectors4 +webkit.org/b/170900 imported/w3c/web-platform-tests/css/selectors4/focus-within-006.html [ ImageOnlyFailure ] +webkit.org/b/170899 imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-006.html [ ImageOnlyFailure ] +webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-ltr-001.html [ ImageOnlyFailure ] +webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-rtl-001.html [ ImageOnlyFailure ] + # nth-child tests takes long time and Debug build sometimes timeouts because there are many test cases. webkit.org/b/137149 fast/selectors/nth-child-of-basics.html [ Slow ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (215456 => 215457) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-04-18 08:11:47 UTC (rev 215456) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-04-18 09:17:19 UTC (rev 215457) @@ -1,3 +1,55 @@ +2017-04-18 Manuel Rego Casasnovas <r...@igalia.com> + +[selectors4] Import W3C Test Suite +https://bugs.webkit.org/show_bug.cgi?id=170898 + +Reviewed by
[webkit-changes] [215264] trunk/LayoutTests
Title: [215264] trunk/LayoutTests
Revision 215264
Author r...@igalia.com
Date 2017-04-12 03:14:30 -0700 (Wed, 12 Apr 2017)
Log Message
[css-grid] Replaced elements don't properly resolve percentage heights
https://bugs.webkit.org/show_bug.cgi?id=159670
Reviewed by Darin Adler.
The issue was fixed in r213149 (bug #168657), but the Blink test was not imported.
This patch only adds the test to avoid regressions in the future.
* fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt: Added.
* fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html
Diff
Modified: trunk/LayoutTests/ChangeLog (215263 => 215264)
--- trunk/LayoutTests/ChangeLog 2017-04-12 10:09:14 UTC (rev 215263)
+++ trunk/LayoutTests/ChangeLog 2017-04-12 10:14:30 UTC (rev 215264)
@@ -1,3 +1,16 @@
+2017-04-12 Manuel Rego Casasnovas <r...@igalia.com>
+
+[css-grid] Replaced elements don't properly resolve percentage heights
+https://bugs.webkit.org/show_bug.cgi?id=159670
+
+Reviewed by Darin Adler.
+
+The issue was fixed in r213149 (bug #168657), but the Blink test was not imported.
+This patch only adds the test to avoid regressions in the future.
+
+* fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt: Added.
+* fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html: Added.
+
2017-04-10 Antti Koivisto <an...@apple.com>
Cache small media resources in disk cache
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt (0 => 215264)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt 2017-04-12 10:14:30 UTC (rev 215264)
@@ -0,0 +1,23 @@
+
+PASS .grid 1
+PASS .grid 2
+PASS .grid 3
+PASS .grid 4
+PASS .grid 5
+This test checks that percentage heights are properly resolved for grid items that are replaced elements. You shouldn't see any red if the test is working as expected.
+
+1) 100% height on the image (grid item) should be resolved against the height of the grid area (200px). Actually we don't need the 100% height in this case as the grid items are stretched by default.
+
+
+2) 100% height on the image (grid item's child) should be resolved against the height of the grid item, which is stretched by default to the height of the grid area (200px).
+
+
+3) 100% height on the image (grid item) should be resolved against the height of the grid area (200px). The grid item is not stretched in this case but the height percentage can be resolved anyway.
+
+
+4) 100% height on the image (grid item's child) should be resolved against the height of the grid item, as it's not stretched the grid item's height is indefinite, so the percentage cannot be resolved.
+
+
+5) 100% height on the image (grid item's child) should be resolved against the height of the grid item, which also has a 100% height that is resolved against the height of the grid area (200px).
+
+
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html (0 => 215264)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html 2017-04-12 10:14:30 UTC (rev 215264)
@@ -0,0 +1,87 @@
+
+
+
+
+
+
+
+.grid {
+grid: 200px / 200px;
+width: 200px;
+}
+
+.red {
+background-color: red;
+}
+
+img {
+height: 100%;
+display: block;
+}
+
+.height100 {
+height: 100%;
+}
+
+
+
[webkit-changes] [215222] trunk/LayoutTests
Title: [215222] trunk/LayoutTests
Revision 215222
Author r...@igalia.com
Date 2017-04-11 02:20:16 -0700 (Tue, 11 Apr 2017)
Log Message
[css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
https://bugs.webkit.org/show_bug.cgi?id=167538
Reviewed by Darin Adler.
fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
as the caret was not always painted in the test runner.
The test was checking for a crash in simplified layout (see bug #163450)
and has nothing to do with the caret or "autofocus" behavior.
"autofocus" was needed to get the crash, so this change modifies
the test to blur the element, so the caret is not painted anymore.
* fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:
Don't focus the input element.
* fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur
the input element to avoid showing the caret.
* platform/mac-wk2/TestExpectations: Remove file from expectations.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html
trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html
trunk/LayoutTests/platform/mac-wk2/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (215221 => 215222)
--- trunk/LayoutTests/ChangeLog 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/ChangeLog 2017-04-11 09:20:16 UTC (rev 215222)
@@ -1,3 +1,23 @@
+2017-04-11 Manuel Rego Casasnovas <r...@igalia.com>
+
+[css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
+https://bugs.webkit.org/show_bug.cgi?id=167538
+
+Reviewed by Darin Adler.
+
+fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
+as the caret was not always painted in the test runner.
+The test was checking for a crash in simplified layout (see bug #163450)
+and has nothing to do with the caret or "autofocus" behavior.
+"autofocus" was needed to get the crash, so this change modifies
+the test to blur the element, so the caret is not painted anymore.
+
+* fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:
+Don't focus the input element.
+* fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur
+the input element to avoid showing the caret.
+* platform/mac-wk2/TestExpectations: Remove file from expectations.
+
2017-04-10 Jiewen Tan <jiewen_...@apple.com>
Unreviewed, test expectations update
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html (215221 => 215222)
--- trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned-expected.html 2017-04-11 09:20:16 UTC (rev 215222)
@@ -9,4 +9,4 @@
This text and input should appear at 100x100 position.
Like if they have a left and top margin of 100px.
-
+
Modified: trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html (215221 => 215222)
--- trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-simplified-layout-positioned.html 2017-04-11 09:20:16 UTC (rev 215222)
@@ -15,3 +15,15 @@
This text and input should appear at 100x100 position.
Like if they have a left and top margin of 100px.
+
+ if (window.testRunner)
+window.testRunner.waitUntilDone();
+ // "autofocus" is needed to force the simplified layout call.
+ // We are removing the focus here to match the expected file and avoid issues with the caret.
+ // We need a small timeout so "blur()" is run after "autofocus".
+ setTimeout(function() {
+document.querySelector("input").blur();
+if (window.testRunner)
+ window.testRunner.notifyDone();
+ }, 100);
+
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (215221 => 215222)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-11 08:29:43 UTC (rev 215221)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-04-11 09:20:16 UTC (rev 215222)
@@ -613,8 +613,6 @@
webkit.org/b/168065 inspector/unit-tests/heap-snapshot.html [ Pass Failure Timeout ]
-webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
-
webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
webkit.org/b/168085 tiled-drawing/scrolling/latched-to-deleted-node.html [ Pass Failure ]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [214222] trunk/Websites/planet.webkit.org
Title: [214222] trunk/Websites/planet.webkit.org Revision 214222 Author r...@igalia.com Date 2017-03-21 07:34:36 -0700 (Tue, 21 Mar 2017) Log Message [Planet WebKit] Use HTTPS instead of HTTP for Igalia blog Unreviewed patch just updating the Igalia WebKit blog configuration. * config.ini: Modified Paths trunk/Websites/planet.webkit.org/ChangeLog trunk/Websites/planet.webkit.org/config.ini Diff Modified: trunk/Websites/planet.webkit.org/ChangeLog (214221 => 214222) --- trunk/Websites/planet.webkit.org/ChangeLog 2017-03-21 14:12:09 UTC (rev 214221) +++ trunk/Websites/planet.webkit.org/ChangeLog 2017-03-21 14:34:36 UTC (rev 214222) @@ -1,3 +1,11 @@ +2017-03-21 Manuel Rego Casasnovas <r...@igalia.com> + +[Planet WebKit] Use HTTPS instead of HTTP for Igalia blog + +Unreviewed patch just updating the Igalia WebKit blog configuration. + +* config.ini: + 2016-05-15 Frederic Wang <fred.w...@free.fr> Remove Frédéric Wang's blog from the planet Modified: trunk/Websites/planet.webkit.org/config.ini (214221 => 214222) --- trunk/Websites/planet.webkit.org/config.ini 2017-03-21 14:12:09 UTC (rev 214221) +++ trunk/Websites/planet.webkit.org/config.ini 2017-03-21 14:34:36 UTC (rev 214222) @@ -118,5 +118,5 @@ name = Bruno de Oliveira Abinader nick = abinader -[http://planet.igalia.com/webkit/rss20.xml] +[https://planet.igalia.com/webkit/rss20.xml] name = Igalia WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
