[webkit-changes] [248965] trunk/Tools

[aperez]

Title: [248965] trunk/Tools








Revision 248965
Author ape...@igalia.com
Date 2019-08-21 14:49:00 -0700 (Wed, 21 Aug 2019)


Log Message
[GTK][WPE] Make debug-test-runner work
https://bugs.webkit.org/show_bug.cgi?id=193576

Reviewed by Michael Catanzaro.

* Scripts/webkitdirs.pm:
(wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
(setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
(execUnixAppForDebugging): Added.
(debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (248964 => 248965)

--- trunk/Tools/ChangeLog	2019-08-21 21:38:22 UTC (rev 248964)
+++ trunk/Tools/ChangeLog	2019-08-21 21:49:00 UTC (rev 248965)
@@ -1,3 +1,17 @@
+2019-08-21  Adrian Perez de Castro  
+
+[GTK][WPE] Make debug-test-runner work
+https://bugs.webkit.org/show_bug.cgi?id=193576
+
+Reviewed by Michael Catanzaro.
+
+* Scripts/webkitdirs.pm:
+(wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
+(setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
+TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
+(execUnixAppForDebugging): Added.
+(debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
+
 2019-08-20  Ryosuke Niwa  
 
 Put keygen element behind a runtime flag and disable it by default


Modified: trunk/Tools/Scripts/webkitdirs.pm (248964 => 248965)

--- trunk/Tools/Scripts/webkitdirs.pm	2019-08-21 21:38:22 UTC (rev 248964)
+++ trunk/Tools/Scripts/webkitdirs.pm	2019-08-21 21:49:00 UTC (rev 248965)
@@ -88,6 +88,7 @@



+   



@@ -2054,7 +2055,7 @@
 if (isAppleCocoaWebKit()) {
 return ("xcrun");
 }
-if (-e getJhbuildPath()) {
+if (shouldUseJhbuild() and ! shouldUseFlatpak()) {
 my @prefix = (File::Spec->catfile(sourceDir(), "Tools", "jhbuild", "jhbuild-wrapper"));
 if (isGtk()) {
 push(@prefix, "--gtk");
@@ -2494,6 +2495,14 @@
 setUpGuardMallocIfNeeded();
 }
 
+sub setupUnixWebKitEnvironment($)
+{
+my ($productDir) = @_;
+
+$ENV{TEST_RUNNER_INJECTED_BUNDLE_FILENAME} = File::Spec->catfile($productDir, "lib", "libTestRunnerInjectedBundle.so");
+$ENV{TEST_RUNNER_TEST_PLUGIN_PATH} = File::Spec->catdir($productDir, "lib", "plugins");
+}
+
 sub setupIOSWebKitEnvironment($)
 {
 my ($dyldFrameworkPath) = @_;
@@ -2837,6 +2846,24 @@
 exec { $debuggerPath } $debuggerPath, @architectureFlags, $argumentsSeparator, $appPath, argumentsForRunAndDebugMacWebKitApp() or die;
 }
 
+sub execUnixAppForDebugging($)
+{
+my ($appPath) = @_;
+
+my $debuggerPath = `which gdb | head -1`;
+chomp $debuggerPath;
+die "Can't find the gdb executable.\n" unless -x $debuggerPath;
+
+my $productDir = productDir();
+setupUnixWebKitEnvironment($productDir);
+
+my @cmdline = wrapperPrefixIfNeeded();
+push @cmdline, $debuggerPath, "--args", $appPath;
+
+print "Starting @{[basename($appPath)]} under gdb with build WebKit in $productDir.\n";
+exec @cmdline, @ARGV or die;
+}
+
 sub debugSafari
 {
 if (isAppleMacWebKit()) {
@@ -2900,6 +2927,8 @@
 {
 if (isAppleMacWebKit()) {
 execMacWebKitAppForDebugging(File::Spec->catfile(productDir(), "WebKitTestRunner"));
+} elsif (isGtk() or isWPE()) {
+execUnixAppForDebugging(File::Spec->catfile(productDir(), "bin", "WebKitTestRunner"));
 }
 
 return 1;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248968] tags/Safari-608.2.7/

[alancoon]

Title: [248968] tags/Safari-608.2.7/








Revision 248968
Author alanc...@apple.com
Date 2019-08-21 15:27:59 -0700 (Wed, 21 Aug 2019)


Log Message
Tag Safari-608.2.7.

Added Paths

tags/Safari-608.2.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248971] trunk/Source/WebCore

[cdumez]

Title: [248971] trunk/Source/WebCore








Revision 248971
Author cdu...@apple.com
Date 2019-08-21 15:45:46 -0700 (Wed, 21 Aug 2019)


Log Message
Crash under StringImpl::endsWith() in SQLiteIDBBackingStore::fullDatabaseDirectoryWithUpgrade()
https://bugs.webkit.org/show_bug.cgi?id=200990


Reviewed by Alex Christensen.

Make sure we call isolatedCopy() on SQLiteIDBBackingStore::m_databaseRootDirectory before using
it from background threads.

* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::fullDatabaseDirectoryWithUpgrade):
(WebCore::IDBServer::SQLiteIDBBackingStore::databasesSizeForOrigin const):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
* Modules/indexeddb/server/SQLiteIDBBackingStore.h:
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseRootDirectory const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (248970 => 248971)

--- trunk/Source/WebCore/ChangeLog	2019-08-21 22:42:48 UTC (rev 248970)
+++ trunk/Source/WebCore/ChangeLog	2019-08-21 22:45:46 UTC (rev 248971)
@@ -1,5 +1,23 @@
 2019-08-21  Chris Dumez  
 
+Crash under StringImpl::endsWith() in SQLiteIDBBackingStore::fullDatabaseDirectoryWithUpgrade()
+https://bugs.webkit.org/show_bug.cgi?id=200990
+
+
+Reviewed by Alex Christensen.
+
+Make sure we call isolatedCopy() on SQLiteIDBBackingStore::m_databaseRootDirectory before using
+it from background threads.
+
+* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
+(WebCore::IDBServer::SQLiteIDBBackingStore::fullDatabaseDirectoryWithUpgrade):
+(WebCore::IDBServer::SQLiteIDBBackingStore::databasesSizeForOrigin const):
+(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
+* Modules/indexeddb/server/SQLiteIDBBackingStore.h:
+(WebCore::IDBServer::SQLiteIDBBackingStore::databaseRootDirectory const):
+
+2019-08-21  Chris Dumez  
+
 Crash under StringImpl::~StringImpl() in IDBServer::computeSpaceUsedForOrigin()
 https://bugs.webkit.org/show_bug.cgi?id=200989
 


Modified: trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp (248970 => 248971)

--- trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp	2019-08-21 22:42:48 UTC (rev 248970)
+++ trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp	2019-08-21 22:45:46 UTC (rev 248971)
@@ -765,9 +765,10 @@
 
 String SQLiteIDBBackingStore::fullDatabaseDirectoryWithUpgrade()
 {
-String oldOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(m_databaseRootDirectory, "v0");
+auto databaseRootDirectory = this->databaseRootDirectory();
+String oldOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(databaseRootDirectory, "v0");
 String oldDatabaseDirectory = FileSystem::pathByAppendingComponent(oldOriginDirectory, filenameForDatabaseName());
-String newOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(m_databaseRootDirectory, "v1");
+String newOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(databaseRootDirectory, "v1");
 String fileNameHash = SQLiteFileSystem::computeHashForFileName(m_identifier.databaseName());
 Vector directoriesWithSameHash = FileSystem::listDirectory(newOriginDirectory, fileNameHash + "*");
 String newDatabaseDirectory = FileSystem::pathByAppendingComponent(newOriginDirectory, fileNameHash);
@@ -856,8 +857,9 @@
 
 uint64_t SQLiteIDBBackingStore::databasesSizeForOrigin() const
 {
-String oldVersionOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(m_databaseRootDirectory, "v0");
-String newVersionOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(m_databaseRootDirectory, "v1");
+auto databaseRootDirectory = this->databaseRootDirectory();
+String oldVersionOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(databaseRootDirectory, "v0");
+String newVersionOriginDirectory = m_identifier.databaseDirectoryRelativeToRoot(databaseRootDirectory, "v1");
 return databasesSizeForFolder(oldVersionOriginDirectory) + databasesSizeForFolder(newVersionOriginDirectory);
 }
 
@@ -2560,7 +2562,7 @@
 
 SQLiteFileSystem::deleteDatabaseFile(dbFilename);
 SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_databaseDirectory);
-SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_identifier.databaseDirectoryRelativeToRoot(m_databaseRootDirectory));
+SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_identifier.databaseDirectoryRelativeToRoot(databaseRootDirectory()));
 }
 
 void SQLiteIDBBackingStore::unregisterCursor(SQLiteIDBCursor& cursor)


Modified: trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h (248970 => 248971)

--- 

[webkit-changes] [248976] trunk/Tools

[aakash_jain]

Title: [248976] trunk/Tools








Revision 248976
Author aakash_j...@apple.com
Date 2019-08-21 16:56:24 -0700 (Wed, 21 Aug 2019)


Log Message
[ews-build] view layout test results option should be displayed next to layout-test build step
https://bugs.webkit.org/show_bug.cgi?id=200048

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
(ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (248975 => 248976)

--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-08-21 23:51:34 UTC (rev 248975)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-08-21 23:56:24 UTC (rev 248976)
@@ -1489,9 +1489,18 @@
 def resultsDownloadURL(self):
 return self.zipFile.replace('public_html/', '/')
 
+def getLastBuildStepByName(self, name):
+for step in reversed(self.build.executedSteps):
+if name in step.name:
+return step
+return None
+
 def addCustomURLs(self):
-self.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
-self.addURL('download layout test results', self.resultsDownloadURL())
+step = self.getLastBuildStepByName(RunWebKitTests.name)
+if not step:
+step = self
+step.addURL('view layout test results', self.resultDirectoryURL() + 'results.html')
+step.addURL('download layout test results', self.resultsDownloadURL())
 
 def finished(self, result):
 self.addCustomURLs()


Modified: trunk/Tools/ChangeLog (248975 => 248976)

--- trunk/Tools/ChangeLog	2019-08-21 23:51:34 UTC (rev 248975)
+++ trunk/Tools/ChangeLog	2019-08-21 23:56:24 UTC (rev 248976)
@@ -1,5 +1,16 @@
 2019-08-21  Aakash Jain  
 
+[ews-build] view layout test results option should be displayed next to layout-test build step
+https://bugs.webkit.org/show_bug.cgi?id=200048
+
+Reviewed by Jonathan Bedard.
+
+* BuildSlaveSupport/ews-build/steps.py:
+(ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
+(ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
+
+2019-08-21  Aakash Jain  
+
 [ews] Fix capitalization in Found x new Test failure message
 https://bugs.webkit.org/show_bug.cgi?id=201004
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248979] trunk/Tools

[jbedard]

Title: [248979] trunk/Tools








Revision 248979
Author jbed...@apple.com
Date 2019-08-21 17:21:50 -0700 (Wed, 21 Aug 2019)


Log Message
results.webkit.org: Add database table to save zip archives to
https://bugs.webkit.org/show_bug.cgi?id=200718

Rubber-stamped by Aakash Jain.

* resultsdbpy/resultsdbpy/model/archive_context.py: Added.
(ArchiveContext):
(ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
(ArchiveContext.ArchivesByCommit.unpack):
(ArchiveContext.assert_zipfile):
(ArchiveContext.open_zipfile):
(ArchiveContext.__init__):
(ArchiveContext.__enter__):
(ArchiveContext.__exit__):
(ArchiveContext.register): Save the provided archive to Cassandra.
(ArchiveContext.find_archive): Find all archives matching the specified criteria.
(ArchiveContext._files_for_archive):
(ArchiveContext.ls): List all files in the matching archives.
(ArchiveContext.file): Extract a file from the matching archives.
* resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
(ArchiveContextTest):
* resultsdbpy/resultsdbpy/model/mock_model_factory.py:
(MockModelFactory):
(MockModelFactory.process_results):
(MockModelFactory.add_mock_archives):
* resultsdbpy/resultsdbpy/model/model.py:
(Model.__init__): Add an ArchiveContext to the model.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/model/mock_model_factory.py
trunk/Tools/resultsdbpy/resultsdbpy/model/model.py


Added Paths

trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py
trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (248978 => 248979)

--- trunk/Tools/ChangeLog	2019-08-22 00:11:28 UTC (rev 248978)
+++ trunk/Tools/ChangeLog	2019-08-22 00:21:50 UTC (rev 248979)
@@ -1,3 +1,33 @@
+2019-08-21  Jonathan Bedard  
+
+results.webkit.org: Add database table to save zip archives to
+https://bugs.webkit.org/show_bug.cgi?id=200718
+
+Rubber-stamped by Aakash Jain.
+
+* resultsdbpy/resultsdbpy/model/archive_context.py: Added.
+(ArchiveContext):
+(ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
+(ArchiveContext.ArchivesByCommit.unpack):
+(ArchiveContext.assert_zipfile):
+(ArchiveContext.open_zipfile):
+(ArchiveContext.__init__):
+(ArchiveContext.__enter__):
+(ArchiveContext.__exit__):
+(ArchiveContext.register): Save the provided archive to Cassandra.
+(ArchiveContext.find_archive): Find all archives matching the specified criteria.
+(ArchiveContext._files_for_archive):
+(ArchiveContext.ls): List all files in the matching archives.
+(ArchiveContext.file): Extract a file from the matching archives.
+* resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
+(ArchiveContextTest):
+* resultsdbpy/resultsdbpy/model/mock_model_factory.py:
+(MockModelFactory):
+(MockModelFactory.process_results):
+(MockModelFactory.add_mock_archives):
+* resultsdbpy/resultsdbpy/model/model.py:
+(Model.__init__): Add an ArchiveContext to the model.
+
 2019-08-21  Aakash Jain  
 
 [ews-build] view layout test results option should be displayed next to layout-test build step


Added: trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py (0 => 248979)

--- trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py	(rev 0)
+++ trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py	2019-08-22 00:21:50 UTC (rev 248979)
@@ -0,0 +1,193 @@
+# Copyright (C) 2019 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS "AS IS" AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+

[webkit-changes] [248980] trunk/Tools

[ryanhaddad]

Title: [248980] trunk/Tools








Revision 248980
Author ryanhad...@apple.com
Date 2019-08-21 17:23:15 -0700 (Wed, 21 Aug 2019)


Log Message
Unreviewed, rolling out r248970.

Caused
lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
to fail.

Reverted changeset:

"[lldb-webkit] OptionSet summary shows size 0 sometimes for
non-empty set"
https://bugs.webkit.org/show_bug.cgi?id=200742
https://trac.webkit.org/changeset/248970

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/lldb/lldb_webkit.py




Diff

Modified: trunk/Tools/ChangeLog (248979 => 248980)

--- trunk/Tools/ChangeLog	2019-08-22 00:21:50 UTC (rev 248979)
+++ trunk/Tools/ChangeLog	2019-08-22 00:23:15 UTC (rev 248980)
@@ -1,3 +1,18 @@
+2019-08-21  Ryan Haddad  
+
+Unreviewed, rolling out r248970.
+
+Caused
+lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
+to fail.
+
+Reverted changeset:
+
+"[lldb-webkit] OptionSet summary shows size 0 sometimes for
+non-empty set"
+https://bugs.webkit.org/show_bug.cgi?id=200742
+https://trac.webkit.org/changeset/248970
+
 2019-08-21  Jonathan Bedard  
 
 results.webkit.org: Add database table to save zip archives to


Modified: trunk/Tools/lldb/lldb_webkit.py (248979 => 248980)

--- trunk/Tools/lldb/lldb_webkit.py	2019-08-22 00:21:50 UTC (rev 248979)
+++ trunk/Tools/lldb/lldb_webkit.py	2019-08-22 00:23:15 UTC (rev 248980)
@@ -735,7 +735,6 @@
 class FlagEnumerationProvider(object):
 def __init__(self, valobj, internal_dict):
 self.valobj = valobj
-self._elements = []
 self.update()
 
 # Subclasses must override this to return a dictionary that maps emumerator values to names.
@@ -751,24 +750,6 @@
 def _update(self):
 pass
 
-# Subclasses can override this to provide the index that corresponds to the specified name.
-# If this method is overridden then it is also expected that _get_child_at_index() will be
-# overridden to provide the value for the index returned by this method. Note that the
-# returned index must be greater than or equal to self.size in order to avoid breaking
-# printing of synthetic children.
-def _get_child_index(self, name):
-return None
-
-# Subclasses can override this to provide the SBValue for the specified index. It is only
-# meaningful to override this method if _get_child_index() is also overridden.
-def _get_child_at_index(self, index):
-return None
-
-@property
-def size(self):
-return len(self._elements)
-
-# LLDB overrides
 def has_children(self):
 return bool(self._elements)
 
@@ -776,7 +757,10 @@
 return len(self._elements)
 
 def get_child_index(self, name):
-return self._get_child_index(name)
+try:
+return int(name.lstrip('[').rstrip(']'))
+except:
+return None
 
 def get_child_at_index(self, index):
 if index < 0 or not self.valobj.IsValid():
@@ -784,11 +768,14 @@
 if index < len(self._elements):
 (name, value) = self._elements[index]
 return self.valobj.CreateValueFromExpression(name, str(value))
-return self._get_child_at_index(index)
+return None
 
 def update(self):
 self._update()
 
+self._elements = []
+self.size = 0
+
 enumerator_value_to_name_map = self._enumerator_value_to_name_map()
 if not enumerator_value_to_name_map:
 return
@@ -806,7 +793,9 @@
 elements.append((enumerator_value_to_name_map[current], current))  # e.g. ('Spelling', 4)
 bitmask = bitmask & (bitmask - 1)  # Turn off the rightmost set bit.
 self._elements = elements
+self.size = len(elements)
 
+
 class WTFOptionSetProvider(FlagEnumerationProvider):
 def _enumerator_value_to_name_map(self):
 template_argument_sbType = self.valobj.GetType().GetTemplateArgumentType(0)
@@ -823,17 +812,7 @@
 def _update(self):
 self.storage = self.valobj.GetChildMemberWithName('m_storage')  # May be an invalid value.
 
-def _get_child_index(self, name):
-if name == 'm_storage':
-return self.size
-return None
 
-def _get_child_at_index(self, index):
-if index == self.size:
-return self.storage
-return None
-
-
 class RawBitmaskProviderBase(FlagEnumerationProvider):
 ENUMERATOR_VALUE_TO_NAME_MAP = {}
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248982] branches/safari-608-branch/LayoutTests

[ryanhaddad]

Title: [248982] branches/safari-608-branch/LayoutTests








Revision 248982
Author ryanhad...@apple.com
Date 2019-08-21 17:24:54 -0700 (Wed, 21 Aug 2019)


Log Message
Cherry-pick r248964. rdar://problem/54561673

Unreviewed test gardening, land test expectations for rdar://54561673.

* platform/ios/TestExpectations:
* platform/ios-12/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@248964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations
branches/safari-608-branch/LayoutTests/platform/ios-12/TestExpectations




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (248981 => 248982)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-08-22 00:24:52 UTC (rev 248981)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-08-22 00:24:54 UTC (rev 248982)
@@ -1,5 +1,23 @@
 2019-08-21  Ryan Haddad  
 
+Cherry-pick r248964. rdar://problem/54561673
+
+Unreviewed test gardening, land test expectations for rdar://54561673.
+
+* platform/ios/TestExpectations:
+* platform/ios-12/TestExpectations:
+
+git-svn-id: http://svn.webkit.org/repository/webkit/trunk@248964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-08-21  Ryan Haddad  
+
+Unreviewed test gardening, land test expectations for rdar://54561673.
+
+* platform/ios/TestExpectations:
+* platform/ios-12/TestExpectations:
+
+2019-08-21  Ryan Haddad  
+
 Cherry-pick r248917. rdar://problem/53829560
 
 Updating Expectations for Multiple Newly Passing Tests.


Modified: branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations (248981 => 248982)

--- branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations	2019-08-22 00:24:52 UTC (rev 248981)
+++ branches/safari-608-branch/LayoutTests/platform/ios/TestExpectations	2019-08-22 00:24:54 UTC (rev 248982)
@@ -3360,3 +3360,6 @@
 
 # rdar://52961406 (scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure on iOS)
 scrollingcoordinator/ios/scroll-position-after-reattach.html [ Pass ImageOnlyFailure ]
+
+# rdar://54561673 (REGRESSION: Layout test http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html is a flaky timeout)
+http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html [ Pass Timeout ]


Modified: branches/safari-608-branch/LayoutTests/platform/ios-12/TestExpectations (248981 => 248982)

--- branches/safari-608-branch/LayoutTests/platform/ios-12/TestExpectations	2019-08-22 00:24:52 UTC (rev 248981)
+++ branches/safari-608-branch/LayoutTests/platform/ios-12/TestExpectations	2019-08-22 00:24:54 UTC (rev 248982)
@@ -25,3 +25,5 @@
 http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin.html [ Pass ]
 http/tests/misc/iframe-beforeunload-dialog-block-modals.html [ Pass ]
 
+# rdar://54561673 (REGRESSION: Layout test http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html is a flaky timeout)
+http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248984] branches/safari-608-branch/Source

[kocsen_chung]

Title: [248984] branches/safari-608-branch/Source








Revision 248984
Author kocsen_ch...@apple.com
Date 2019-08-21 17:40:05 -0700 (Wed, 21 Aug 2019)


Log Message
Versioning.

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (248983 => 248984)

--- branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-08-22 00:34:48 UTC (rev 248983)
+++ branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-08-22 00:40:05 UTC (rev 248984)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 2;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [248989] trunk

[mark . lam]

Title: [248989] trunk








Revision 248989
Author mark@apple.com
Date 2019-08-21 18:42:22 -0700 (Wed, 21 Aug 2019)


Log Message
Wasm::FunctionParser is failing to enforce maxFunctionLocals.
https://bugs.webkit.org/show_bug.cgi?id=201016


Reviewed by Yusuke Suzuki.

JSTests:

* wasm/stress/too-many-locals.js: Added.
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.catch):

Source/_javascript_Core:

Currently, Wasm::FunctionParser is allowing

maxFunctionParams + maxFunctionLocals * maxFunctionLocals

... locals, which is 0x9502FCE8.  It should be enforcing max locals of
maxFunctionLocals instead.

* wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::parse):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h


Added Paths

trunk/JSTests/wasm/stress/too-many-locals.js




Diff

Modified: trunk/JSTests/ChangeLog (248988 => 248989)

--- trunk/JSTests/ChangeLog	2019-08-22 01:25:48 UTC (rev 248988)
+++ trunk/JSTests/ChangeLog	2019-08-22 01:42:22 UTC (rev 248989)
@@ -1,3 +1,14 @@
+2019-08-21  Mark Lam  
+
+Wasm::FunctionParser is failing to enforce maxFunctionLocals.
+https://bugs.webkit.org/show_bug.cgi?id=201016
+
+
+Reviewed by Yusuke Suzuki.
+
+* wasm/stress/too-many-locals.js: Added.
+(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.catch):
+
 2019-08-21  Ross Kirsling  
 
 JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop


Added: trunk/JSTests/wasm/stress/too-many-locals.js (0 => 248989)

--- trunk/JSTests/wasm/stress/too-many-locals.js	(rev 0)
+++ trunk/JSTests/wasm/stress/too-many-locals.js	2019-08-22 01:42:22 UTC (rev 248989)
@@ -0,0 +1,33 @@
+import Builder from '../Builder.js'
+import * as assert from '../assert.js'
+
+{
+const b = new Builder();
+const locals = [];
+const maxFunctionLocals = 5;
+const numLocals = maxFunctionLocals;
+for (let i = 0; i < numLocals; ++i)
+locals[i] = "i32";
+let cont = b
+.Type().End()
+.Function().End()
+.Export()
+.Function("loop")
+.End()
+.Code()
+.Function("loop", { params: ["i32"], ret: "i32" }, locals)
+.I32Const(1)
+.Return()
+.End()
+.End()
+
+const bin = b.WebAssembly().get();
+var exception;
+try {
+const module = new WebAssembly.Module(bin);
+} catch (e) {
+exception = "" + e;
+}
+
+assert.eq(exception, "Error: WebAssembly.Module doesn't parse at byte 12: Function's number of locals is too big 50001 maximum 5, in function at index 0 (evaluating 'new WebAssembly.Module(bin)')");
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (248988 => 248989)

--- trunk/Source/_javascript_Core/ChangeLog	2019-08-22 01:25:48 UTC (rev 248988)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-08-22 01:42:22 UTC (rev 248989)
@@ -1,3 +1,21 @@
+2019-08-21  Mark Lam  
+
+Wasm::FunctionParser is failing to enforce maxFunctionLocals.
+https://bugs.webkit.org/show_bug.cgi?id=201016
+
+
+Reviewed by Yusuke Suzuki.
+
+Currently, Wasm::FunctionParser is allowing
+
+maxFunctionParams + maxFunctionLocals * maxFunctionLocals
+
+... locals, which is 0x9502FCE8.  It should be enforcing max locals of
+maxFunctionLocals instead.
+
+* wasm/WasmFunctionParser.h:
+(JSC::Wasm::FunctionParser::parse):
+
 2019-08-21  Michael Saboff  
 
 [JSC] incorrent JIT lead to StackOverflow


Modified: trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h (248988 => 248989)

--- trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h	2019-08-22 01:25:48 UTC (rev 248988)
+++ trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h	2019-08-22 01:42:22 UTC (rev 248989)
@@ -115,18 +115,19 @@
 template
 auto FunctionParser::parse() -> Result
 {
-uint32_t localCount;
+uint32_t localGroupsCount;
 
 WASM_PARSER_FAIL_IF(!m_context.addArguments(m_signature), "can't add ", m_signature.argumentCount(), " arguments to Function");
-WASM_PARSER_FAIL_IF(!parseVarUInt32(localCount), "can't get local count");
-WASM_PARSER_FAIL_IF(localCount > maxFunctionLocals, "Function section's local count is too big ", localCount, " maximum ", maxFunctionLocals);
+WASM_PARSER_FAIL_IF(!parseVarUInt32(localGroupsCount), "can't get local groups count");
 
-for (uint32_t i = 0; i < localCount; ++i) {
+uint64_t totalNumberOfLocals = m_signature.argumentCount();
+for (uint32_t i = 0; i < localGroupsCount; ++i) {
 uint32_t numberOfLocals;
 Type typeOfLocal;
 
 WASM_PARSER_FAIL_IF(!parseVarUInt32(numberOfLocals), "can't get Function's number of locals in group ", i);
-WASM_PARSER_FAIL_IF(numberOfLocals > 

[webkit-changes] [248991] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [248991] trunk/Source/WebInspectorUI








Revision 248991
Author nvasil...@apple.com
Date 2019-08-21 19:33:40 -0700 (Wed, 21 Aug 2019)


Log Message
Web Inspector: RTL: DOM outline in Elements tab should be LTR
https://bugs.webkit.org/show_bug.cgi?id=200601

Reviewed by Timothy Hatcher.

Make DOM outlines in Console and Elements tab always LTR,
and unsure that Left and Right arrow keys continue working correctly.

* UserInterface/Base/Main.js:
(WI.resolveLayoutDirectionForElement): Added.
The existing WI.resolvedLayoutDirection function returns the value of the root DOM element.
The newly added resolveLayoutDirectionForElement function returns the correct value for any element,
including elements with `dir=ltr` inside of ``.

* UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):
(.tree-outline.dom li:not(.editing)):
(.tree-outline.dom li.editing):
(.tree-outline.dom li .pseudo-class-indicator):
(.tree-outline.dom.single-node li):
(.tree-outline.dom li.parent):
(.tree-outline.dom li .html-tag.close):
(.tree-outline.dom li.parent::before):
(.tree-outline.dom li.parent.shadow::after):
Remove RTL logic.

* UserInterface/Views/DOMTreeOutline.js:
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):
Make Left and Right arrow keys work correctly for LTR DOM outlines inside of the global RTL.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (248990 => 248991)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-08-22 01:49:48 UTC (rev 248990)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-08-22 02:33:40 UTC (rev 248991)
@@ -1,3 +1,36 @@
+2019-08-21  Nikita Vasilyev  
+
+Web Inspector: RTL: DOM outline in Elements tab should be LTR
+https://bugs.webkit.org/show_bug.cgi?id=200601
+
+Reviewed by Timothy Hatcher.
+
+Make DOM outlines in Console and Elements tab always LTR,
+and unsure that Left and Right arrow keys continue working correctly.
+
+* UserInterface/Base/Main.js:
+(WI.resolveLayoutDirectionForElement): Added.
+The existing WI.resolvedLayoutDirection function returns the value of the root DOM element.
+The newly added resolveLayoutDirectionForElement function returns the correct value for any element,
+including elements with `dir=ltr` inside of ``.
+
+* UserInterface/Views/DOMTreeOutline.css:
+(.tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):
+(.tree-outline.dom li:not(.editing)):
+(.tree-outline.dom li.editing):
+(.tree-outline.dom li .pseudo-class-indicator):
+(.tree-outline.dom.single-node li):
+(.tree-outline.dom li.parent):
+(.tree-outline.dom li .html-tag.close):
+(.tree-outline.dom li.parent::before):
+(.tree-outline.dom li.parent.shadow::after):
+Remove RTL logic.
+
+* UserInterface/Views/DOMTreeOutline.js:
+* UserInterface/Views/TreeOutline.js:
+(WI.TreeOutline.prototype._treeKeyDown):
+Make Left and Right arrow keys work correctly for LTR DOM outlines inside of the global RTL.
+
 2019-08-21  Devin Rousso  
 
 Web Inspector: Page: re-add enable/disable after r248454


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (248990 => 248991)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2019-08-22 01:49:48 UTC (rev 248990)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2019-08-22 02:33:40 UTC (rev 248991)
@@ -2709,6 +2709,18 @@
 return layoutDirection;
 };
 
+WI.resolveLayoutDirectionForElement = function(element)
+{
+let layoutDirection = WI.resolvedLayoutDirection();
+
+// Global LTR never includes RTL containers. Return early.
+if (layoutDirection === WI.LayoutDirection.LTR)
+return layoutDirection;
+
+let style = getComputedStyle(element);
+return style.direction;
+};
+
 WI.setLayoutDirection = function(value)
 {
 console.assert(WI.isDebugUIEnabled());


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css (248990 => 248991)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css	2019-08-22 01:49:48 UTC (rev 248990)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css	2019-08-22 02:33:40 UTC (rev 248991)
@@ -101,14 +101,10 @@
 border: 0 solid hsla(0, 0%, 83%, 0.5);
 }
 
-body[dir=ltr] .tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded {
+.tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded {
 border-left-width: var(--sublist-border-width-start);
 }
 
-body[dir=rtl] .tree-outline.dom 

[webkit-changes] [248966] trunk

[achristensen]

Title: [248966] trunk








Revision 248966
Author achristen...@apple.com
Date 2019-08-21 15:03:02 -0700 (Wed, 21 Aug 2019)


Log Message
Disabling text autosizing should prevent text autosizing
https://bugs.webkit.org/show_bug.cgi?id=200955


Reviewed by Simon Fraser.

Source/WebCore:

Before this change there was no way to reliably change the text size on iOS when a -webkit-text-size-adjust:none style was applied
because it would ignore the WKPreferences value for _textAutosizingEnabled.  Now that value has the desired effect when laying out.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::checkForTextSizeAdjust):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
(TEST):

LayoutTests:

* fast/text-autosizing/ios/text-size-adjust-inline-style.html:
The comment was incorrect because we call WKPreferencesSetTextAutosizingEnabled(preferences, false) in TestController::platformResetPreferencesToConsistentValues.
In order to test the effect of text autosizing in this test, we need to explicitly turn it on.  The disabling of text autosizing didn't do anything before this
patch, so it wasn't needed before now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text-autosizing/ios/text-size-adjust-inline-style.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (248965 => 248966)

--- trunk/LayoutTests/ChangeLog	2019-08-21 21:49:00 UTC (rev 248965)
+++ trunk/LayoutTests/ChangeLog	2019-08-21 22:03:02 UTC (rev 248966)
@@ -1,3 +1,16 @@
+2019-08-21  Alex Christensen  
+
+Disabling text autosizing should prevent text autosizing
+https://bugs.webkit.org/show_bug.cgi?id=200955
+
+
+Reviewed by Simon Fraser.
+
+* fast/text-autosizing/ios/text-size-adjust-inline-style.html:
+The comment was incorrect because we call WKPreferencesSetTextAutosizingEnabled(preferences, false) in TestController::platformResetPreferencesToConsistentValues.
+In order to test the effect of text autosizing in this test, we need to explicitly turn it on.  The disabling of text autosizing didn't do anything before this
+patch, so it wasn't needed before now.
+
 2019-08-21  Ryan Haddad  
 
 Unreviewed test gardening, land test expectations for rdar://54561673.


Modified: trunk/LayoutTests/fast/text-autosizing/ios/text-size-adjust-inline-style.html (248965 => 248966)

--- trunk/LayoutTests/fast/text-autosizing/ios/text-size-adjust-inline-style.html	2019-08-21 21:49:00 UTC (rev 248965)
+++ trunk/LayoutTests/fast/text-autosizing/ios/text-size-adjust-inline-style.html	2019-08-21 22:03:02 UTC (rev 248966)
@@ -1,7 +1,7 @@
 
 
 
-
+internals.settings.setTextAutosizingEnabled(true)
 
 @font-face {
 font-family: Ahem;