[Bug 56849] Edit conflict detection has regressed and suffers a race condition

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56849

Adam Wight  changed:

   What|Removed |Added

 CC||s...@ludd.net

--- Comment #5 from Adam Wight  ---
A minor detail to add: we should always include the oldid in GET query
parameters to action=edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60156] CodeEditor doesn't automatically type matching closing } when I type {

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60156

--- Comment #9 from Gerrit Notification Bot  ---
Change 108050 merged by jenkins-bot:
Update ACE to Jan 17, 2014

https://gerrit.wikimedia.org/r/108050

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26032] Give "back to top" button

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26032

--- Comment #6 from kunalgrove...@gmail.com ---
Created attachment 14339
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=14339&action=edit
Back to top button implemented using JQuery

My patch had a few errors as indicated by the notification bot.
I fixed them but I couldn't make a change as I hadn't submitted the patch
through git-review.
I am uploading the new patch here. Please someone review it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26032] Give "back to top" button

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26032

kunalgrove...@gmail.com changed:

   What|Removed |Added

 CC||kunalgrove...@gmail.com

--- Comment #5 from kunalgrove...@gmail.com ---
Hi I submitted this patch through online gerrit uploader. Can someone review
the patch?
https://gerrit.wikimedia.org/r/108306

Also I am new here so please tell if there is a better way to write the patch
or if something else is wrong in the commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26032] Give "back to top" button

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26032

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26032] Give "back to top" button

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26032

--- Comment #4 from Gerrit Notification Bot  ---
Change 108306 had a related patch set uploaded by Jforrester:
Go to top button for pages. Implements go to top button with smooth scrolling.
Hidden when on top of page and appears when scrolled down to some extent.
Configurable-Enabled by default. Can be disabled by using "$wgShowTopButton =
false;" in LocalSettings

https://gerrit.wikimedia.org/r/108306

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60192] Documentation and API are inconsistent (action=parse, contentmodel)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60192

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |PATCH_TO_REVIEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60192] Documentation and API are inconsistent (action=parse, contentmodel)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60192

--- Comment #2 from Gerrit Notification Bot  ---
Change 108307 had a related patch set uploaded by Nullzero:
Update documentation and suppress warning when parsing summary

https://gerrit.wikimedia.org/r/108307

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|REOPENED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #83 from Gerrit Notification Bot  ---
Change 108221 had a related patch set uploaded by Jforrester:
Updated includes/Skin.php footer images #30113

https://gerrit.wikimedia.org/r/108221

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #82 from Wes Turner  ---
(In reply to comment #81)
> (In reply to comment #79)
> > (In reply to comment #77)
> > > This test fixture seems to indicate that a
> > > 
> > >  'background-image: url(' . $wgFooterIcons['powererdby']['src'] . ')';
> > > 
> > > CSS attribute containing input from configuration on the filesystem may be
> > > stripped:
> > > 
> > > https://git.wikimedia.org/blob/mediawiki%2Fcore/
> > > 6a2d25eed09c311c70657789b3f7a841bc5363db/
> > > tests%2Fphpunit%2Fincludes%2FSanitizerTest.php#L253
> > 
> > Yes, all url() constructs will make checkCss consider the css unsafe. So
> > you'll
> > have to sanitize the background-image separate from the rest of the css.
> > 
> > > HTML::element states:
> > > 
> > > // There's no point in escaping quotes, >, etc. in the 
> > > contents
> > > of
> > > // elements.
> > > 
> > > In this case, it is probably good to escape a '"; and/or javascript: in 
> > > the
> > > configuration-supplied variable.
> > > 
> > > It would be helpful if someone more familiar with the codebase could 
> > > indicate
> > > if there is a more appropriate function than htmlspecialchars (with
> > > ENT_NOQUOTES/ENT_QUOTES) for this.
> > 
> > Escaping of quotes ('") are already handled by Html::element, ignore
> > htmlspecialchars completely here.
> > 
> > For sanitizing the URL is safe/not javascript: use preg_match( '/^(' .
> > wfUrlProtocols() . ')[^\s]+$/', ... ) to test if the protocol is 
> > whitelisted.
> 
> It look like Sanitizer::safeEncodeAttribute [would] also reference
> wfUrlProtocols, though it seems to only escape double single quotes ("''",
> "''"), expecting the input to have already been run through
> encodeAttribute and htmlspecialchars with ENT_QUOTES.
> 
> The documentation for http://php.net/manual/en/function.htmlspecialchars.php
> reads:
> 
> 
> * '"' (double quote) becomes '"' when ENT_NOQUOTES is not set.
> * "'" (single quote) becomes ''' (or ') only when ENT_QUOTES is
> set.
> 
> And:
> 
> ENT_QUOTESWill convert both double and single quotes.

Updated this patch for this issue. Please advise if there is a local function
more suitable than Html::safeEncodeAttribute.

https://gerrit.wikimedia.org/r/#/c/108221/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27035] Write a secure group editor

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27035

PiRSquared17  changed:

   What|Removed |Added

 CC||pirsquare...@gmail.com

--- Comment #3 from PiRSquared17  ---
(In reply to comment #0)
> (From JeLuF)
> 
> Adding groups should be possible. You basically need:
> - Group name
> - Group permissions (checkbox list)
> - Who may add users to this group (checkbox list of existing groups)
> - Who may remove users from this group (checkbox list of existing groups)
> This should be something bureaucrats should be able to handle.

This is a good idea, but on WMF wikis only stewards should be able to modify
group rights (we have CU, OS, other private stuff). On external MediaWiki
installations, the situation may be different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #81 from Wes Turner  ---
(In reply to comment #79)
> (In reply to comment #77)
> > This test fixture seems to indicate that a
> > 
> >  'background-image: url(' . $wgFooterIcons['powererdby']['src'] . ')';
> > 
> > CSS attribute containing input from configuration on the filesystem may be
> > stripped:
> > 
> > https://git.wikimedia.org/blob/mediawiki%2Fcore/
> > 6a2d25eed09c311c70657789b3f7a841bc5363db/
> > tests%2Fphpunit%2Fincludes%2FSanitizerTest.php#L253
> 
> Yes, all url() constructs will make checkCss consider the css unsafe. So
> you'll
> have to sanitize the background-image separate from the rest of the css.
> 
> > HTML::element states:
> > 
> > // There's no point in escaping quotes, >, etc. in the contents
> > of
> > // elements.
> > 
> > In this case, it is probably good to escape a '"; and/or javascript: in the
> > configuration-supplied variable.
> > 
> > It would be helpful if someone more familiar with the codebase could 
> > indicate
> > if there is a more appropriate function than htmlspecialchars (with
> > ENT_NOQUOTES/ENT_QUOTES) for this.
> 
> Escaping of quotes ('") are already handled by Html::element, ignore
> htmlspecialchars completely here.
> 
> For sanitizing the URL is safe/not javascript: use preg_match( '/^(' .
> wfUrlProtocols() . ')[^\s]+$/', ... ) to test if the protocol is whitelisted.

It look like Sanitizer::safeEncodeAttribute [would] also reference
wfUrlProtocols, though it seems to only escape double single quotes ("''",
"''"), expecting the input to have already been run through
encodeAttribute and htmlspecialchars with ENT_QUOTES.

The documentation for http://php.net/manual/en/function.htmlspecialchars.php
reads:


* '"' (double quote) becomes '"' when ENT_NOQUOTES is not set.
* "'" (single quote) becomes ''' (or ') only when ENT_QUOTES is
set.

And:

ENT_QUOTESWill convert both double and single quotes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #80 from Daniel Friesen  ---
It's a shame that Facebook, etc... probably don't take WAI-ARIA's presentation
role into account.

Would be nice if we could just do:


-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #79 from Daniel Friesen  ---
(In reply to comment #77)
> This test fixture seems to indicate that a
> 
>  'background-image: url(' . $wgFooterIcons['powererdby']['src'] . ')';
> 
> CSS attribute containing input from configuration on the filesystem may be
> stripped:
> 
> https://git.wikimedia.org/blob/mediawiki%2Fcore/
> 6a2d25eed09c311c70657789b3f7a841bc5363db/
> tests%2Fphpunit%2Fincludes%2FSanitizerTest.php#L253

Yes, all url() constructs will make checkCss consider the css unsafe. So you'll
have to sanitize the background-image separate from the rest of the css.

> HTML::element states:
> 
> // There's no point in escaping quotes, >, etc. in the contents
> of
> // elements.
> 
> In this case, it is probably good to escape a '"; and/or javascript: in the
> configuration-supplied variable.
> 
> It would be helpful if someone more familiar with the codebase could indicate
> if there is a more appropriate function than htmlspecialchars (with
> ENT_NOQUOTES/ENT_QUOTES) for this.

Escaping of quotes ('") are already handled by Html::element, ignore
htmlspecialchars completely here.

For sanitizing the URL is safe/not javascript: use preg_match( '/^(' .
wfUrlProtocols() . ')[^\s]+$/', ... ) to test if the protocol is whitelisted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60218] Flow: Can bypass any protection and blank pages

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60218

James Forrester  changed:

   What|Removed |Added

  Group|security|
 CC||jforres...@wikimedia.org,
   ||oke...@wikimedia.org,
   ||pandiculat...@gmail.com,
   ||sp...@wikimedia.org
  Component|Extensions  |Flow
   Assignee|secur...@wikimedia.org  |wikibugs-l@lists.wikimedia.
   ||org
Product|Security|MediaWiki extensions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #78 from Wes Turner  ---
* In this case, it is probably good to escape a '"; and/or javascript: in the
configuration-supplied variable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #77 from Wes Turner  ---
(In reply to comment #76)
> (In reply to comment #71)
> > It looks like Sanitizer::validateAttributes would call Sanitizer::checkCss 
> > on
> > the style property; but the docstrings for Sanitizer::checkCss specify:
> > 
> > * Currently URL references, 'expression', 'tps' are forbidden.
> > 
> > so I suppose the following would be needed:
> > 
> > * background-image: '";>
> > * width: safeEncodeAttribute
> > * height: safeEncodeAttribute
> 
> Html::element already handles encoding attributes, you just want to sanitize
> css.(In reply to comment #74)

This test fixture seems to indicate that a

 'background-image: url(' . $wgFooterIcons['powererdby']['src'] . ')';

CSS attribute containing input from configuration on the filesystem may be
stripped:

https://git.wikimedia.org/blob/mediawiki%2Fcore/6a2d25eed09c311c70657789b3f7a841bc5363db/tests%2Fphpunit%2Fincludes%2FSanitizerTest.php#L253

https://www.mediawiki.org/wiki/Manual:$wgFooterIcons

HTML::element states:

// There's no point in escaping quotes, >, etc. in the contents of
// elements.

In this case, it is probably good to escape a ' and/or javascript: in the
configuration-supplied variable.

It would be helpful if someone more familiar with the codebase could indicate
if there is a more appropriate function than htmlspecialchars (with
ENT_NOQUOTES/ENT_QUOTES) for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60223] New: Install the certificate for *.toolserver.org

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60223

   Web browser: ---
Bug ID: 60223
   Summary: Install the certificate for *.toolserver.org
   Product: Wikimedia
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: SSL related
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: t...@tim-landscheidt.de
CC: m...@uberbox.org, silke.me...@wikimedia.de
Blocks: 60220
Classification: Unclassified
   Mobile Platform: ---

For bug #60220 and other services being migrated from Toolserver to WMF, we
need the (or a) certificate for *.toolserver.org installed on the WMF cluster
in the standard way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60220] Move wiki.toolserver.org to WMF

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60220

Tim Landscheidt  changed:

   What|Removed |Added

 Depends on||60223

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60222] New: Set up a clone of wiki.toolserver.org

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60222

   Web browser: ---
Bug ID: 60222
   Summary: Set up a clone of wiki.toolserver.org
   Product: Wikimedia
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Site requests
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: t...@tim-landscheidt.de
CC: benap...@gmail.com,
bugzilla+org.wikime...@tuxmachine.com,
dereck...@espace-win.org, g...@wikimedia.org,
m...@uberbox.org, tom...@twkozlowski.net,
wikimedia.b...@snowolf.eu
Blocks: 60220
Classification: Unclassified
   Mobile Platform: ---

Looking at [[wikitech:Add a wiki]], I believe this will be a "Special Wiki"
("fishbowl"?):

1. The users will be distinct from Wikipedia, so no CentralAuth.
2. The wiki can be replicated to LabsDB.
3. No new users should be able to register themselves.
4. No IP editing should be allowed.
5. Toolserver wiki uses "/view/" instead of "/wiki/".  Depending on
maintainability, this should either be enabled in the MediaWiki settings or
we'll need redirects.

https://wiki.toolserver.org/view/Special:Version lists standard extensions with
two exceptions:

1. Crowd Authentication Plugin: This will not be needed because we will take a
snapshot of the user database and not plug into Atlassian.
2. HTMLets: A full-text search for "htmlets" does only find
https://wiki.toolserver.org/view/HTMLets though, so apparently it isn't used on
the wiki and can be ignored.

The current LocalSettings.php (minus any private information) should be
attached to this bug so that we can look if there are any other non-standard
settings, but nosy and amette don't seem to be registered on Bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55899] Wiki markup synonym for   (non-breaking space)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55899

PiRSquared17  changed:

   What|Removed |Added

 CC||pirsquare...@gmail.com

--- Comment #1 from PiRSquared17  ---
I don't see the need. You only save four characters. Are there any similar
codes for characters?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60220] Move wiki.toolserver.org to WMF

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60220

Tim Landscheidt  changed:

   What|Removed |Added

 Depends on||60222

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56408] Enable FlaggedRevs extension on ce.wikipedia

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56408

--- Comment #39 from PiRSquared17  ---
(In reply to comment #38)
> Is it possible to use the Russian patch?

https://gerrit.wikimedia.org/r/#/c/108302/

I have no idea if I did this right. Maybe someone a lot more experienced like
odder could check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #76 from Daniel Friesen  ---
(In reply to comment #71)
> It looks like Sanitizer::validateAttributes would call Sanitizer::checkCss on
> the style property; but the docstrings for Sanitizer::checkCss specify:
> 
> * Currently URL references, 'expression', 'tps' are forbidden.
> 
> so I suppose the following would be needed:
> 
> * background-image: '";>
> * width: safeEncodeAttribute
> * height: safeEncodeAttribute

Html::element already handles encoding attributes, you just want to sanitize
css.(In reply to comment #74)

> (In reply to comment #73)
> Nice. So Facebook does parse (some?) og:image tags beyond just  tags
> within ?
> 
> https://stackoverflow.com/questions/10397510/are-open-graph-tags-just-for-
> facebook

Besides Google+ there's also a list of OGP parsers to test:
http://ogp.me/#implementations

(In reply to comment #75)
> (In reply to comment #68)
> Did anyone mention an RDFa 1.0 requirement?

The commit that implements that RFC includes a high level API for managing RDFa
prefixes, adding them to , and adding RDFa to the .

$og = $out->getPrefixContext()->prefix( 'og', 'http://ogp.me/ns#', true );
$out->addGraphProperty( $og->curie( 'image' ), ... );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 48946] Add font size adjustment feature to the mobile front end

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=48946

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 48946] Add font size adjustment feature to the mobile front end

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=48946

--- Comment #20 from Gerrit Notification Bot  ---
Change 108300 had a related patch set uploaded by Theopolisme:
[WIP] Allow users to adjust the font size

https://gerrit.wikimedia.org/r/108300

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60221] New: Installation is broken

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60221

   Web browser: ---
Bug ID: 60221
   Summary: Installation is broken
   Product: Pywikibot
   Version: core (2.0)
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: General
  Assignee: pywikipedia-b...@lists.wikimedia.org
  Reporter: hazard...@yahoo.com
Classification: Unclassified
   Mobile Platform: ---

I've attempted to reinstall pywikibot (core) on multiple occasions on Tool Labs
recently, and I keep getting the following when I attempt to use it:

local-hazard-bot@tools-login:~$ python
Python 2.7.3 (default, Sep 26 2013, 20:03:06)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import pywikibot
Traceback (most recent call last):
  File "", line 1, in 
ImportError: No module named pywikibot
>>>


The issue also happens for me on Toolserver.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60208] external PHP can't be started - open_basedir not checked

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60208

Joerg  changed:

   What|Removed |Added

 CC||mueller062001-...@yahoo.de

--- Comment #1 from Joerg  ---
I agree. Note that the open_basedir check should not be done against /usr/bin/,
but against the actual value of $wgPhpCli (which defaults to /usr/bin/, but
also might be different).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58719] Jobs are no longer executed

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58719

--- Comment #7 from Joerg  ---
I think this is not my problem: open_basedir (amongst other paths) contains
"/usr/bin/". That should allow access to /usr/bin/php.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60075] zh.wikivoyage not accepted in MassMessage

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60075

--- Comment #3 from Gerrit Notification Bot  ---
Change 108293 had a related patch set uploaded by Legoktm:
Clear MassMessage cache when creating a new wiki

https://gerrit.wikimedia.org/r/108293

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60075] zh.wikivoyage not accepted in MassMessage

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60075

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60075] zh.wikivoyage not accepted in MassMessage

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60075

--- Comment #2 from Gerrit Notification Bot  ---
Change 108292 had a related patch set uploaded by Legoktm:
Lower caching time on MassMessage::getDBName

https://gerrit.wikimedia.org/r/108292

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60220] Move wiki.toolserver.org to WMF

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60220

p858snake  changed:

   What|Removed |Added

 CC||p858sn...@gmail.com

--- Comment #1 from p858snake  ---
IIRC the TSWiki isn't setup on MySQL which will make it a tad bit harder to do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60207] expandTemplate doesn’t create a new frame

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60207

Brad Jorsch  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Brad Jorsch  ---
(In reply to comment #0)
> When a Lua module uses the function frame:expandTemplate, this doesn’t
> create a
> new frame (contrary to frame:preprocess) but expand the template in the "top"
> frame (the parent frame of the expanded template is the top frame).

A new frame *is* being created, but it's getting the wrong title and isn't a
child of the frame it should be a child of.

While it's not exactly obvious, this is the same as the problem in bug 55525.

*** This bug has been marked as a duplicate of bug 55525 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 55525] Transcluded edit section links direct to wrong page title

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55525

Brad Jorsch  changed:

   What|Removed |Added

 CC||seb35wikipe...@gmail.com

--- Comment #4 from Brad Jorsch  ---
*** Bug 60207 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60219] rev_parent_id wrong after history merge

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60219

Jackmcbarn  changed:

   What|Removed |Added

Summary|Page size delta wrong after |rev_parent_id wrong after
   |history merge   |history merge

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60219] Page size delta wrong after history merge

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60219

--- Comment #1 from Jackmcbarn  ---
The problem is that rev_parent_id no longer points to the previous revision
after a history merge.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58788] Toolserver migration to Tools (tracking)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58788

Tim Landscheidt  changed:

   What|Removed |Added

 Depends on||60220

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60220] New: Move wiki.toolserver.org to WMF

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60220

   Web browser: ---
Bug ID: 60220
   Summary: Move wiki.toolserver.org to WMF
   Product: Wikimedia Labs
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: tools
  Assignee: m...@uberbox.org
  Reporter: t...@tim-landscheidt.de
CC: benap...@gmail.com, t...@tim-landscheidt.de
Blocks: 58788
Classification: Unclassified
   Mobile Platform: ---

wiki.toolserver.org should be preserved as a live, editable, no-new-users wiki
at the WMF cluster.

Steps to that goal:

1. Decouple wiki from the Toolserver SSO
2. Dump users and data
3. Set up a wiki on the WMF cluster without CentralAuth (wmgUseCentralAuth =
false IIRC)
4. Load users and data
5. Reset the/mail out new users' passwords
6. Provide Toolserver SSL certificate to WMF
7. Set up wiki.toolserver.org as a CNAME for text-lb

NB: The individual steps are not part of the Tools project, but there will be
separate bugs filed for them in the appropriate components.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60192] Documentation and API are inconsistent (action=parse, contentmodel)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60192

--- Comment #1 from Niklas Laxström  ---
Latter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60219] New: Page size delta wrong after history merge

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60219

   Web browser: ---
Bug ID: 60219
   Summary: Page size delta wrong after history merge
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: Unprioritized
 Component: History/Diffs
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: jackmcbarn+w...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

At
https://en.wikipedia.org/w/index.php?title=Decisions_%28song%29&action=history
, the revision at 01:46, 19 January 2014‎ is 12,596 bytes, and the revision
immediately before it at 00:53, 19 January 2014‎ is 12,549 bytes, but the size
delta between the revisions is 0. These revisions were created in this way as a
result of a history merge.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58474] Some sysops can not edit sysop protected items unless also explicitly given 'confirmed user' flag

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58474

Techman224  changed:

   What|Removed |Added

 CC||techman...@techman224.ca

--- Comment #3 from Techman224  ---
I see that the edit and add links are greyed out too, and they say the page is
protected. However when I used the labelLister to edit a description it worked,
https://www.wikidata.org/w/index.php?title=Q5268366&diff=prev&oldid=103258789

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 59998] Installer warning irrelevant/obsolete for PHP ≥5.4: 'Could not find APC, XCache or WinCache'

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59998

--- Comment #5 from Dereckson  ---
In confirm the bug, in the extent we should detect the PHP version and stop to
recommend to install APC in 5.4+, as it could only lead system administrators
to try to install a broken stable or unstable beta extension on newest PHP
versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 59998] Installer warning irrelevant/obsolete for PHP ≥5.4: 'Could not find APC, XCache or WinCache'

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59998

Dereckson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||dereck...@espace-win.org
 Ever confirmed|0   |1

--- Comment #4 from Dereckson  ---
- The Zend OPcache extension is shipped and by default enabled with PHP 5.5.
Cf.  http://www.php.net/manual/en/migration55.new-features.php

- Zend OPcache doesn't contain an object-level cache. MediaWiki can takes
advantage of a cache allowing to store object representations (calling for APC
the apc_store function).

- Nor PHP 5.4, nor PHP 5.5 include APC. But PHP 5.4 introduced a new extension
API. Recent versions for APC works at a stable quality on PHP 5.3, but not on
PHP 5.4 or PHP 5.5. APC development hasn't been active since 2012.

- In October 2013, an XCache version with PHP 5.5 support has been released.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60217] New: Support one-time job scheduling

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60217

   Web browser: ---
Bug ID: 60217
   Summary: Support one-time job scheduling
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: JobQueue
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: s...@ludd.net
CC: tstarl...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

I'd like to enqueue a job which will not be run until a specified time in the
future.

Currently, my only option seems to be something really evil involving backoffs
and a Job::run() method which intentionally fails until the desired time.

Ideally, we could deprecate the mw-runJobs-backoffs.json system in favor of a
not_until column in the `job` table.

My use case is almost too hypothetical to mention: a workflow engine which can
do things like abandon AfD cases after a set number of days.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 8394] Link or formatting codes in {{DISPLAYTITLE}} breaking as of MW1.9

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=8394

Dereckson  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=60216

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60216] DISPLAYTITLE custom formatting break after an open parenthesis

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60216

Dereckson  changed:

   What|Removed |Added

   Keywords||code-update-regression
 CC||br...@wikimedia.org,
   ||linedw...@icloud.com
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=8394

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60216] New: DISPLAYTITLE custom formatting break after an open parenthesis

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60216

   Web browser: ---
Bug ID: 60216
   Summary: DISPLAYTITLE custom formatting break after an open
parenthesis
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Parser
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: dereck...@espace-win.org
Classification: Unclassified
   Mobile Platform: ---

{{DISPLAYTITLE:''Sweet Dreams (Are Made of This)''}} will print Sweet Dreams in
italic, then from the open parenthesis, will ignore any styling markup.

This isn't consistent, as Lua allows to pass a string with parenthesis to the
DISPLAYTITLE parser function:
https://en.wikipedia.org/w/index.php?title=Module:Italic_title&oldid=581780064.

[ History ]

In 2006, in bug 8394, Brion Vibber, states: “The display title should indeed
not contain any links or formatting codes.”

This behavior is reported to have been introduced in MediaWiki 1.9 according
the same bug.

This doesn't match the last 8 years practice of our main users, Wikipedia
projects, as italic titles are now widely use on Wikipedia projects for
entertainment and artistic works' titles.

[ Credit ]

Thank you to LeJC and Linedwell from the French Wikipedia to have reported this
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 27841] Merge AssertEdit extension into MediaWiki core

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=27841

Jarry1250  changed:

   What|Removed |Added

 CC||jarry1...@gmail.com

--- Comment #8 from Jarry1250  ---
Unintended consequence: passing a blank assert= parameter to the API now causes
an unknown_assert error, whereas before it was silently ignored. Bug or
feature?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60215] New: Mails to any wikimedia.org account/list from any account @wikimedia.org.ve bounces

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60215

   Web browser: ---
Bug ID: 60215
   Summary: Mails to any wikimedia.org account/list from any
account @wikimedia.org.ve bounces
   Product: Wikimedia
   Version: wmf-deployment
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: critical
  Priority: Unprioritized
 Component: Mailing lists
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: fhai...@gmail.com
CC: b...@caseybrown.org, jalexan...@wikimedia.org,
pbeaude...@wikimedia.org, thehelpfulonew...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

Every mail sent to/from any @lists.wikimedia.org.ve or @wikimedia.org from/to
any account @wikimedia.org.ve bounces (including WMVE lists at
lists.wikimedia.org) Mails to/from wikimedia.org.ve from/to any other domain
work fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37256] #tag cannot produce XHTML-style self-closing tags, required by LST

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37256

Gadget850  changed:

   What|Removed |Added

 CC||thoma...@hotmail.fr,
   ||valhall...@arctus.nl
  Component|Parser  |LabeledSectionTransclusion
Version|1.23-git|master
Product|MediaWiki   |MediaWiki extensions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60214] New: testImageusage in site_tests fails

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60214

   Web browser: ---
Bug ID: 60214
   Summary: testImageusage in site_tests fails
   Product: Pywikibot
   Version: core (2.0)
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: General
  Assignee: pywikipedia-b...@lists.wikimedia.org
  Reporter: mpaa.w...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

Line 549 in site_tests.py fails:
for using in mysite.imageusage(imagepage, namespaces=[3, 4], total=5):
self.assertType(using, pywikibot.Page)
self.assertTrue(imagepage in list(using.imagelinks()))  --> fails

imagepage on main page (current 'Main Page' on ew:WP) is different from images
in list(using.imagelinks()), in cached data in
c:\\users\\...\\AppData\\Roaming\\pywikibot\\apicache\\ff322b...

Cached data is used due to monkey patching in tests/__init__.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 39020] CSS 'left' gets rendered wrong.

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=39020

se4598  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 45020] Make preferences "Add pages I create and files I upload to my watchlist" and "pages and files I edit" true by default

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=45020

Nathan Larson  changed:

   What|Removed |Added

 CC||nathanlarson3...@gmail.com

--- Comment #19 from Nathan Larson  ---
This is in some ways a workaround for the difficulties in getting bug 3525
fixed. It definitely makes it seem less urgent, I think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #75 from Wes Turner  ---
(In reply to comment #68)
> (In reply to comment #64)
> > > However I have considered extracting the list of images included in the 
> > > page
> > > output and outputting og:image data in the head for them. Actually I've 
> > > had
> > > other ideas like allowing images in content to be marked as
> > > presentational/non-presentational so we can intelligently exclude bad 
> > > images.
> > 
> > TIL about https://www.mediawiki.org/wiki/Extension:OpenGraphMeta
> 
> I've actually been hoping to make this metadata part of core and deprecating
> OpenGraphMeta. This could all be done much better if re-implemented as part
> of
> core. And this really is basic stuff no wiki should be without.
> 
> Though that depends on stuff implemented alongside this RFC:
> https://www.mediawiki.org/wiki/Requests_for_comment/
> Update_our_code_to_use_RDFa_1.1_instead_of_RDFa_1.0

Did anyone mention an RDFa 1.0 requirement?

I've been parsing / checking / validating with PyRDFa.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #74 from Wes Turner  ---
(In reply to comment #73)
> Wes: I only tested for Facebook and debugged using
> https://developers.facebook.com/tools/debug/

Nice. So Facebook does parse (some?) og:image tags beyond just  tags
within ?

https://stackoverflow.com/questions/10397510/are-open-graph-tags-just-for-facebook

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #73 from Subfader  ---
Wes: I only tested for Facebook and debugged using
https://developers.facebook.com/tools/debug/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #72 from Wes Turner  ---
(In reply to comment #70)
> I hacked the logo as first og:image into the header, followed by all other
> article images. I see no disadvantages so far.

Cool! Which networks does it work w/?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60081] Inserting a new reference makes "Save button" become switched disabled

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60081

--- Comment #3 from Paulo  ---
Hi Andre,
Well, I'll try to explain better, my English is very poor.
When I edit text only, with internal links, the problem does not happen.
Otherwise, when I put several external references (sometimes also happens with
just one reference, only), the "Save page" button locks (it becomes without
function) and I can not save. I had some tests done at this time in my sandbox
(using Firefox) and it seems the problem was solved.
If my explanation was sufficient and you can test it, then you can close this
bug. Sorry my difficulty with the language.
Greetings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #71 from Wes Turner  ---
(In reply to comment #69)
> (In reply to comment #67)
> > ... Looking at makeFooterIcon() in includes/Skin.php (I had 'tested' the raw
> > HTML w/ Chrome): is there a fancy way to specify inline CSS style attributes
> > (like background-image, width, height, and display) with Html::element or
> > Html::rawElement? (Which templating library is this?)
> 
> Nope, we don't have such a thing right now. And you'll probably want to
> consider using the css sanitizing method inside Sanitize:: for stuff besides
> the background image and checking that nothing tries crossing a ;.

It's been awhile since I've written any PHP; I'll have to lookup what
htmlspecialchars does again. Are there test cases for these? It may be better
for someone familiar with the input sanitization codebase to tkae it from here.

Where in the docs would I look for 'trusted' configuration settings? Can these
variables be modified?

It looks like Sanitizer::validateAttributes would call Sanitizer::checkCss on
the style property; but the docstrings for Sanitizer::checkCss specify:

* Currently URL references, 'expression', 'tps' are forbidden.

so I suppose the following would be needed:

* background-image: '";>
* width: safeEncodeAttribute
* height: safeEncodeAttribute

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60213] Type mismatch when caching SMW IDs

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60213

--- Comment #1 from MWJames  ---
As site note, you may want to use the released 1.9.0.2 version for verification
and post a PR via [1].

[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53034] Property value changed after page move without redirect

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53034

Alexey  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=60213

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60213] Type mismatch when caching SMW IDs

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60213

Alexey  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=53034

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

Subfader  changed:

   What|Removed |Added

 CC||subfa...@gmail.com

--- Comment #70 from Subfader  ---
I hacked the logo as first og:image into the header, followed by all other
article images. I see no disadvantages so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53034] Property value changed after page move without redirect

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53034

Alexey  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Alexey  ---
MediaWiki1.22.1(721b9e0) 22:03, 14 January 2014
Semantic MediaWiki (Version 1.9 alpha-3) (9a55761) 19:21, 22 October 2013

I've run my test successfully.
Also I've made code review and debugging to make sure that corresponding
changes were made. So I can confirm that bug is fixed and can be closed.

However, the problem with types of page ids still exists, I filled new bug
#60213.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60213] New: Type mismatch when caching SMW IDs

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60213

   Web browser: ---
Bug ID: 60213
   Summary: Type mismatch when caching SMW IDs
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Unprioritized
 Component: Semantic MediaWiki
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: al...@all-x.net
CC: jamesin.hongkon...@gmail.com, jeroen_ded...@yahoo.com,
mar...@semantic-mediawiki.org, nischay...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

MediaWiki1.22.1(721b9e0) 22:03, 14 January 2014
Semantic MediaWiki (Version 1.9 alpha-3) (9a55761) 19:21, 22 October 2013

mediawiki/extensions/SemanticMediaWiki/includes/storage/SQLStore:

(SMW_Sql3SmwIds.php)SMWSql3SmwIds->setCache() is called from

(SMW_SQLStore3_Queries.php)SMWSQLStore3QueryEngine->getInstanceQueryResult()

with $id that is string, not integer as documented for setCache.

In most cases it is not a problem, php cast values automatically.
But arrays containing ids are serialized 
when hashes for property tables are computed.
In this case, types of ids are important - serialized arrays differs
and md5 hashes also differs.

For example (take a look at s_id or p_id):

smw_di_wikipage data:
a:2:{i:0;a:3:{s:4:"s_id";i:53;s:4:"p_id";i:55;s:4:"o_id";s:2:"51";}i:1;a:3:{s:4:"s_id";i:53;s:4:"p_id";i:56;s:4:"o_id";i:57;}}

a:2:{i:0;a:3:{s:4:"s_id";s:2:"53";s:4:"p_id";s:2:"55";s:4:"o_id";s:2:"51";}i:1;a:3:{s:4:"s_id";s:2:"53";s:4:"p_id";s:2:"56";s:4:"o_id";s:2:"57";}}

These hashes are used to compare new semantic data 
with current semantic data stored in database to avoid unnecessary writes.

Fortunately functionality is not affected, only performance.

I propose to add explicit type cast in
(SMW_Sql3SmwIds.php)SMWSql3SmwIds->setCache() method
to make sure ids are always integer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #69 from Daniel Friesen  ---
(In reply to comment #67)
> ... Looking at makeFooterIcon() in includes/Skin.php (I had 'tested' the raw
> HTML w/ Chrome): is there a fancy way to specify inline CSS style attributes
> (like background-image, width, height, and display) with Html::element or
> Html::rawElement? (Which templating library is this?)

Nope, we don't have such a thing right now. And you'll probably want to
consider using the css sanitizing method inside Sanitize:: for stuff besides
the background image and checking that nothing tries crossing a ;.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #68 from Daniel Friesen  ---
(In reply to comment #64)
> > However I have considered extracting the list of images included in the page
> > output and outputting og:image data in the head for them. Actually I've had
> > other ideas like allowing images in content to be marked as
> > presentational/non-presentational so we can intelligently exclude bad 
> > images.
> 
> TIL about https://www.mediawiki.org/wiki/Extension:OpenGraphMeta

I've actually been hoping to make this metadata part of core and deprecating
OpenGraphMeta. This could all be done much better if re-implemented as part of
core. And this really is basic stuff no wiki should be without.

Though that depends on stuff implemented alongside this RFC:
https://www.mediawiki.org/wiki/Requests_for_comment/Update_our_code_to_use_RDFa_1.1_instead_of_RDFa_1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 57877] removing custom sortkey while moving cat

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=57877

JAn Dudík  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||jan.du...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60212] Be more gracefull when a post fails to render

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60212

--- Comment #1 from Bingle  ---
The WMF core features team tracks this bug on Mingle card
https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/728, but people
from the community are welcome to contribute here and in Gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60212] New: Be more gracefull when a post fails to render

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60212

   Web browser: ---
Bug ID: 60212
   Summary: Be more gracefull when a post fails to render
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Flow
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: ebernhard...@wikimedia.org
CC: ebernhard...@wikimedia.org, oke...@wikimedia.org,
pandiculat...@gmail.com, sp...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

catch exceptions rendering posts and try to replace it with a stub post

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60210] MediaWiki starts external PHP on every request - even if job queue is empty

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60210

Jesús Martínez Novo (Ciencia Al Poder)  changed:

   What|Removed |Added

   Keywords||performance
   Priority|Unprioritized   |High
 CC||martinezn...@gmail.com
Version|unspecified |1.22.0

--- Comment #1 from Jesús Martínez Novo (Ciencia Al Poder) 
 ---
I can confirm this bug.

Setting $wgPhpCli to a bash script that writes a line to a log file, on a
development wiki with no edits and an empty job table, loading any page gives a
new line on the log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 6651] Don't list redirect pages on Special:DisambiguationPageLinks

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=6651

Waldir  changed:

   What|Removed |Added

 Depends on|3483|
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=3483

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 3483] Disambiguation pages should not be listed in Special:Lonelypages

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=3483

Waldir  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=6651
 Blocks|6651|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 6651] Don't list redirect pages on Special:DisambiguationPageLinks

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=6651

Bug 6651 depends on bug 3483, which changed state.

Bug 3483 Summary: Disambiguation pages should not be listed in 
Special:Lonelypages
https://bugzilla.wikimedia.org/show_bug.cgi?id=3483

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 3483] Disambiguation pages should not be listed in Special:Lonelypages

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=3483

Waldir  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #67 from Wes Turner  ---
... Looking at makeFooterIcon() in includes/Skin.php (I had 'tested' the raw
HTML w/ Chrome): is there a fancy way to specify inline CSS style attributes
(like background-image, width, height, and display) with Html::element or
Html::rawElement? (Which templating library is this?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58719] Jobs are no longer executed

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58719

Jesús Martínez Novo (Ciencia Al Poder)  changed:

   What|Removed |Added

 CC||martinezn...@gmail.com
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=60208

--- Comment #6 from Jesús Martínez Novo (Ciencia Al Poder) 
 ---
A probably cause is open_basedir restriction in effect preventing /usr/bin/php
to be accessed. See bug 60208

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60208] external PHP can't be started - open_basedir not checked

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60208

Jesús Martínez Novo (Ciencia Al Poder)  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=58719

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #66 from Wes Turner  ---
You're probably already aware of https://www.wikidata.org/wiki/Property:P18
(image) and https://www.wikidata.org/wiki/Property:P154 (logo image).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #65 from Wes Turner  ---
* schema:Thing has a schema:image property

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #64 from Wes Turner  ---
(In reply to comment #62)
> (In reply to comment #57)
> > Why isn't there an option to select between "a Wikimedia project" and
> > "Powered
> > by MediaWiki" if both images are 88x31?
> 
> Unfortunately you'll have to ask Facebook that, it's their proprietary code
> that's picking the images out of standardized html.
> 
> > But how/where does 'poweredbyico' get included into the Vector template?
> 
> poweredbyico is deprecated, skins now use footericons.
> See https://www.mediawiki.org/wiki/Manual:$wgFooterIcons
> 
> (In reply to comment #60)
> > As an aside, with RDFa, we could probably just add `property="og:image"` to
> > all
> > of the in-page images.
> 
> OGP isn't RDFa, they do state "We've based the initial version of the
> protocol
> on RDFa" but it isn't actual RDFa and it violates some of RDFa's rules. OGP's
> "spec" only accepts data from meta tags in the head.

Ah. Good call.

http://schema.org/WebPage .image

http://schema.org/WebPage .primaryImageOfPage

http://schema.org/ImageObject



> 
> However I have considered extracting the list of images included in the page
> output and outputting og:image data in the head for them. Actually I've had
> other ideas like allowing images in content to be marked as
> presentational/non-presentational so we can intelligently exclude bad images.

TIL about https://www.mediawiki.org/wiki/Extension:OpenGraphMeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #63 from Wes Turner  ---
I've submitted a preliminary patch to master to gerrit which implements #2
(with @title attributes instead of opacity:0)

https://gerrit.wikimedia.org/r/#/c/108221/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #62 from Daniel Friesen  ---
(In reply to comment #57)
> Why isn't there an option to select between "a Wikimedia project" and
> "Powered
> by MediaWiki" if both images are 88x31?

Unfortunately you'll have to ask Facebook that, it's their proprietary code
that's picking the images out of standardized html.

> But how/where does 'poweredbyico' get included into the Vector template?

poweredbyico is deprecated, skins now use footericons.
See https://www.mediawiki.org/wiki/Manual:$wgFooterIcons

(In reply to comment #60)
> As an aside, with RDFa, we could probably just add `property="og:image"` to
> all
> of the in-page images.

OGP isn't RDFa, they do state "We've based the initial version of the protocol
on RDFa" but it isn't actual RDFa and it violates some of RDFa's rules. OGP's
"spec" only accepts data from meta tags in the head.

However I have considered extracting the list of images included in the page
output and outputting og:image data in the head for them. Actually I've had
other ideas like allowing images in content to be marked as
presentational/non-presentational so we can intelligently exclude bad images.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 59648] Changes via Special:Translate not saved throwing TypeError (on meta.wikimedia.org)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=59648

Nemo  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60209] Auto-add Gerrit reviewers to changesets when linked with associated Bugzilla bug reports on a per-user opt-in basis

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60209

Umherirrender  changed:

   What|Removed |Added

 CC||umherirrender_de...@web.de

--- Comment #1 from Umherirrender  ---
There is a ReviewerBot which is adding some reviewers to change sets, maybe
that bot can get the emails from the bug and add it as reviewer or the bot is
using the bugzilla name of the account or both, if the user opt-in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60211] New: Install python-magic (binding to libmagic)

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60211

   Web browser: ---
Bug ID: 60211
   Summary: Install python-magic (binding to libmagic)
   Product: Wikimedia Labs
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: tools
  Assignee: m...@uberbox.org
  Reporter: dr.tri...@surfeu.ch
CC: benap...@gmail.com, t...@tim-landscheidt.de
Blocks: 53704
Classification: Unclassified
   Mobile Platform: ---

Hello admins!

I am setting up DrTrigonBot on Labs (migrating from TS). For this I need and
thus request the installation of the 'python-magic' (binding to libmagic)
module.

Thanks and Greetings
DrTrigon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53704] Packages to be added to gerrit

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53704

DrTrigon  changed:

   What|Removed |Added

 Depends on||60211

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60206] site.preloadpages does not preload all links and templates

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60206

--- Comment #4 from Merlijn van Deen  ---
After re-reading the Legacy Query Continue page, I think supporting that in
this case is not a huge hassle - we don't use a generator, so there is no need
to seperate the different query-continue parameters...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #61 from Wes Turner  ---
... For http://schema.org/Organization (which can be expressed in RDFa), we
could specify `property="logo"
content="https://upload.wikimedia.org/wikipedia/en/b/bc/Wiki.png"`

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60210] New: MediaWiki starts external PHP on every request - even if job queue is empty

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60210

   Web browser: ---
Bug ID: 60210
   Summary: MediaWiki starts external PHP on every request - even
if job queue is empty
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: JobQueue
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: mediawiki-b...@cboltz.de
CC: tstarl...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

Probably since https://gerrit.wikimedia.org/r/#/c/59797/ job handling starts an
external php process by default.

This happens even if the job queue is empty.

Is this intentional? I somehow doubt starting a php interpreter just to find
out it's empty won't improve performance...

I'm quite sure checking the database if there are jobs to run won't be too
"expensive", and can avoid lots of more expensive PHP interpreter starts ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60206] site.preloadpages does not preload all links and templates

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60206

--- Comment #3 from Mpaa  ---
Is it an option to migrate to
https://www.mediawiki.org/wiki/API:Query#Continuing_queries? This supported
only from MediaWiki version: ≥ 1.21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #60 from Wes Turner  ---
As an aside, with RDFa, we could probably just add `property="og:image"` to all
of the in-page images.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60209] New: Auto-add Gerrit reviewers to changesets when linked with associated Bugzilla bug reports on a per-user opt-in basis

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60209

   Web browser: ---
Bug ID: 60209
   Summary: Auto-add Gerrit reviewers to changesets when linked
with associated Bugzilla bug reports on a per-user
opt-in basis
   Product: Wikimedia
   Version: wmf-deployment
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Git/Gerrit
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: b...@mzmcbride.com
CC: christ...@quelltextlich.at, innocentkil...@gmail.com,
marcin.cies...@gmail.com, rlan...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

For any bug in Bugzilla, there is a group of e-mail addresses involved:
reporter, assignee, people on the CC list, people who have commented, et al.

From this list of users, individuals should be able to opt-in to the ability to
automatically be made reviewers of any associated Gerrit patches (as identified
by the "Bug:" keyword or similar).

This is likely a task for Gerrit Notification Bot, but there may be a much
better idea for doing this.

A user opting in to this feature would automatically have all of his or her
discovered relationships identified and cross-referenced. Opting in to this
feature might consist of a list somewhere or a user preference somewhere or
something, I don't know.

And whatever is adding reviewers to Gerrit changesets should also be able to
support e-mail address aliases. Some e-mail addresses in Bugzilla won't match
those in Gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #59 from Wes Turner  ---
#2: In includes/Skin.php, I believe the following approach to getPoweredBy()
would be accessible and ___-COMPLIANT.

 "";

"trans(Powered by)
MediaWiki"

I'm not sure why we wouldn't need to do the same for getCopyrightIcon().

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #58 from Wes Turner  ---
(BTW I'm following this tutorial in order to learn how to submit a patch to fix
this issue: 
https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 30113] When sharing articles without images on social sites (facebook, twitter, google+) the mediawiki logo is used in lieu of site logo

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=30113

--- Comment #57 from Wes Turner  ---
Why isn't there an option to select between "a Wikimedia project" and "Powered
by MediaWiki" if both images are 88x31?

Not too familiar with the mediawiki codebase [...]

   $ grin -i poweredby

   $ grin 'getPoweredBy|poweredbyico' . -C 5

I see a getPoweredBy function in includes/Skin.php :

$url = htmlspecialchars(
"$wgStylePath/common/images/poweredby_mediawiki_88x31.png" );

And then in includes/SkinTemplate.php a template variable is set:

$tpl->set( 'poweredbyico', $this->getPoweredBy() );

But how/where does 'poweredbyico' get included into the Vector template?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 60195] Warning message is unclear when using a callback parameter while trying to get a token

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=60195

--- Comment #2 from Umherirrender  ---
When you are on a mediawiki page, you can use mw.user.tokens.get('edittoken')
to get a token.

When you are on a mediawiki page, you can get a token also over
mw.api.getToken, have a look at mediawiki.api.js to see, how this module will
do it. The following comment was found in that file:

// Due to the API assuming we're logged out if we pass the callback-parameter,
// we have to disable jQuery's callback system, and instead parse JSON string,
// by setting 'jsonp' to false.

maybe that helps

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53034] Property value changed after page move without redirect

2014-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53034

--- Comment #10 from Alexey  ---
@Jeroen De Dauw, I used Selenium only to automate my test case mentioned above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


  1   2   >