[MediaWiki-CodeReview] [MediaWiki r91656]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r91656. Old Status: new New Status: resolved User Catrope also posted a comment on MediaWiki.r91656. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91656#c21155 Commit summary: untangling upload interface upload logic code -- upload controls filename acceptability, interface controls getting the preview Comment: pre - title: gM( 'mwe-upwiz-help-popup' ) + ': ' + gM( 'mwe-upwiz-help-allowed-filename-extensions' ), /pre Dialog title has disappeared, is that intentional? pre + fileChangedOk(); /pre Should be codefileNameOk()/code, already fixed in r91694. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91706]: Revision status changed
User Catrope changed the status of MediaWiki.r91706. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91706 Commit summary: Bug #28147: MediaWiki:Centralauth-login-global - rewording suggested to make it more concrete. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91812]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r91812.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r91812.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91812#c21157
Commit summary:
(bug 29563 comment 11) Use feed-atom and feed-rss messages instead of RSS and
ATOM.
Personally this feels a little icky since its kind of lego-ey/resusing messages
in different contexts, but I guess its ok.
Most everywhere else in mediawiki doesn't put the type of feed in the feed
description.
Comment:
That problem could be solved with code$msg = wfMessage( 'foo'
)-inContentLanguage(); if ( $msg-exists() ) { ... }/code , right?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94862]: Revision status changed
User Catrope changed the status of MediaWiki.r94862. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94862 Commit summary: follow-up r91885 rename testTiffFile since its not about tiff files This is probably what was referred to in CR, not what I changed in r94825 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94825]: Revision status changed
User Catrope changed the status of MediaWiki.r94825. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94825 Commit summary: follow-up r91885 - address CR comments * rename testTiffFile to something more descriptive * unserialize the serialized results before comparing Also follow-up r92635 - rm an extra wfDl that was outside any functions, and I'm assuming accidentally there (?) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91885]: Revision status changed
User Catrope changed the status of MediaWiki.r91885. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91885 Commit summary: (follow-up r90256) Unit tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92012]: Revision status changed
User Catrope changed the status of MediaWiki.r92012. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92012 Commit summary: * Made (un)watch action show a form if the token is bad/missing (this handles unwatch links given in emails) * Changed misleading watch/unwatch subtitle msgs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92138]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r92138.
Old Status: new
New Status: ok
User Catrope also posted a comment on MediaWiki.r92138.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92138#c21158
Commit summary:
InputBox:
* instead of checking each namespace if it is given through the parameter,
check each given namespace if it is a valid one
* this fixes the inconsistency where 2 namespaces are given but only 1 is valid
and that one is shown (normally if there is only 1 given, it is hidden)
* fix bug 22591 (Allow i18n of Main namespace search option label)
* allow namespace aliases as well
* also trim the given namespaces, so spaces do not make them invalid
Comment:
pre
+ if ( strstr( $userNS, '**' ) ) {
/pre
From the PHP manual:
blockquote
If you only want to determine if a particular needle occurs within haystack,
use the faster and less memory intensive function strpos() instead.
/blockquote
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92140]: Revision status changed
User Catrope changed the status of MediaWiki.r92140. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92140 Commit summary: (bug 25898) AbuseFilter: clearer permission error when attempting to view diff of private filter Also change some link functions to use Linker::link* ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92141]: Revision status changed
User Catrope changed the status of MediaWiki.r92141. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92141 Commit summary: Babel: (bug 29663) Babel doesn't validate babel-autocreate-user message - do nothing if the username is invalid. Also, do not create categories if the user is blocked. NewUserMessage: Fix fatal error when username is invalid. Instead, do nothing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94738]: Revision status changed
User Catrope changed the status of MediaWiki.r94738. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94738 Commit summary: Self-revert r79892: only got one opposition and apparently too hairy for anyone else to comment :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89304]: Revision status changed
User Catrope changed the status of MediaWiki.r89304. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89304 Commit summary: Does proper check for if the active campaigns exist ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89305]: Revision status changed
User Catrope changed the status of MediaWiki.r89305. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89305 Commit summary: Changed default path of cookie ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89306]: Revision status changed
User Catrope changed the status of MediaWiki.r89306. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89306 Commit summary: changed default path of cookie ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89407]: Revision status changed
User Catrope changed the status of MediaWiki.r89407. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89407 Commit summary: Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89483]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r89483. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r89483. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89483#c21159 Commit summary: SQLite-specific dropTable(): works a bit faster because it doesn't need a separate table existence check and does not rely on subtly broken tableExists() which I will fix a bit later Comment: Marking fixme per Aaron's comments. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added
User Hashar posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c21160 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to replace the pre look'n feel, removing the first-child last-child selectors. * line numbers are not selected on mouse selection. Makes it easy to copy paste the patch. Note: old code left unchanged. To use it again, change the array_map callback in splitLines from 'parseLine' to 'colorLine'. Comment: I am much like Domas: total world domination by using open source software! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89877]: Revision status changed
User Catrope changed the status of MediaWiki.r89877. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89877 Commit summary: fix for bug29320 drag to new location: when moving a reply (down under a thread) to become a new thread and leaving new subject (required) open: ApiThreadAction crashes with Error: no-valid-subject: undefined ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89900]: Revision status changed
User Catrope changed the status of MediaWiki.r89900. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89900 Commit summary: expressly set opensearch limit. Found a reproducible problem that on a large wiki a few case-insensitive matches were not shown when limit was not set to a meaningful value. But api.php has been found working by testing that via manual call from url. Perhaps a jQuery problem. Set limit to an value solved that problem immediately. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89967]: Revision status changed
User Catrope changed the status of MediaWiki.r89967. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89967 Commit summary: when adding a new thread with an empty text body, a placeholder default text is added with an action=edit link ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89958]: Revision status changed
User Catrope changed the status of MediaWiki.r89958. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89958 Commit summary: fix for bug29200 - Creation of new thread fails silently if no content is entered, but this should be possible. Solution: add automatically thread title as comment to new page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89990]: Revision status changed
User Catrope changed the status of MediaWiki.r89990. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89990 Commit summary: Bug 29362 - Templates are not exported with gadgets ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar
On 20/08/11 01:50, Daniel Friesen wrote:
The current implementation of MediaWiki:Sidebar supports a completely
undocumented * {{msg}} syntax.
snip
Are there any objections to it being removed?
The sidebar code is a hack and it is far from being user friendly. User
currently has to edit:
- [[MediaWiki:Sidebar]]
- a message for link
- a message for link name
We should just rewrite it from scratch, using some Special page to
easily add / remove links. Save them to the database and the cache system.
As for the {{msg}}, it might help if you list the revisions.
--
Ashar Voultoiz
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90915]: Revision status changed
User Catrope changed the status of MediaWiki.r90915. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90915 Commit summary: Added formatTimePeriod() tests for r90385 and made some fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90385]: Revision status changed
User Catrope changed the status of MediaWiki.r90385. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90385 Commit summary: * Added (and use) $format param to formatTimePeriod() to make output less verbose for ValidationStatistics_body.php * Small w/s changes to FlaggedRevsStats.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90849]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r90849. Old Status: new New Status: resolved User Catrope also posted a comment on MediaWiki.r90849. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90849#c21162 Commit summary: Apply rgcjones' patch for Bug#29533: Whe placing an external link in the sidebar, $wgExternalLinkTarget is ignored. Also enables applying of $wgNoFollowLinks in the sidebar. Comment: Code duplication fixed in r95072. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92822]: Revision status changed
User Awjrichards changed the status of MediaWiki.r92822. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92822 Commit summary: changing field prefix for banner logging so that it is consistant, adding beginnings of banner logging, and log switching ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95072]: New comment added
User Catrope posted a comment on MediaWiki.r95072. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95072#c21163 Commit summary: Per r90849, factor out most of the code that's duplicated between Parser::getExternalLinkAttribs() and Skin::addToSidebarPlain() into wfMatchesDomainList(). Change a loose comparison to a strict one, and add a FIXME comment about how whitelisting nl.wikipedia.org also whitelists nds-nl.wikipedia.org due to the function's simplistic substring approach. Comment: Tagging for 1.18 because r95073 depends on this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95067]: Revision status changed
User Reedy changed the status of MediaWiki.r95067. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95067 Commit summary: Revert r95058 (make letype multivalue): has been applied before in r88722 and reverted in r89348. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95058]: Revision status changed
User Reedy changed the status of MediaWiki.r95058. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95058 Commit summary: Upstream wikia change Make type multi ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82577]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r82577.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r82577.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/82577#c21164
Commit summary:
improve namespace related methods
MWNamespace::getTalk() could give erroneus results when using it on specials
namespaces (NS_MEDIA, NS_SPECIAL). It now use MWNamespace::isMethodValidFor()
which will throw an exception if a special namespace was given.
MWNamespace::getSubject() is now returning identity for specials namespaces.
New MWNamespace::getAssociated() used to find out the subject page of a talk
page and vice versa. Special namespaces will results in an exception.
TESTS:
Added tests for almost complete code coverage. Functions relying on global
$wgCanonicalNamespaces are still incomplete though.
MWNamespace::isMovable() needs more assertions.
Tests results (ignoring incomplete tests output):
$ php phpunit.php --filter MWNamespace
PHPUnit 3.5.10 by Sebastian Bergmann.
.I..
Time: 1 second, Memory: 31.75Mb
OK, but incomplete or skipped tests!
Tests: 24, Assertions: 99, Incomplete: 5.
Comment:
pre
+ $this-object = new MWNamespace;
/pre
This is useless (MWNamespace only has static methods) and unused.
pre
+ $this-assertEquals( MWNamespace::getTalk( NS_MAIN), NS_TALK );
/pre
It's codeassertEquals( $expected, $actual )/code , so you've got the order
wrong. This appears to apply to all calls in this test from a quick glance.
pre
+ public function testGetTalkExceptions() {
+ $this-assertNull( MWNamespace::getAssociated( NS_MEDIA ) );
+ $this-assertNull( MWNamespace::getAssociated( NS_SPECIAL ) );
+ }
/pre
This doesn't work the way you think it does. Because an exception stops the
execution of the function, this doesn't test that '''both''' calls throw an
exception, just that '''one''' of them does. Because the NS_MEDIA call throws
an exception, the NS_SPECIAL call is never executed, so we'd never notice if
that were to stop throwing an exception. Conversely, if NS_MEDIA were to stop
throwing an exception but NS_SPECIAL still threw one, we'd never notice either.
You would need to either split this up into two tests or use a data provider, I
guess. You did do this properly in
codetestGetAssociatedExceptionsForNsMedia()/code.
pre
+ public function testIsContent() {
/pre
Since the set of content namespaces is configurable, this test breaks on setups
with funky configs. If you add e.g. code$wgContentNamespaces[] =
NS_USER;/code to your config, this test will fail. To test this properly you
will have to exercise full control over code$wgContentNamespaces/code for
every assertion.
pre
+ public function testHasSubpages() {
/pre
Same thing; this was fixed properly though.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82900]: Revision status changed
User Catrope changed the status of MediaWiki.r82900. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/82900 Commit summary: Fixes bug when having multiple textareas, which is caused by the fact that dialogs are kept in memory for performance, even when selecting a different textarea. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95080]: Revision status changed
User Reedy changed the status of MediaWiki.r95080. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95080 Commit summary: Fix typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94958]: Revision status changed
User Reedy changed the status of MediaWiki.r94958. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94958 Commit summary: fix for bug 30118 provided by johnduhart ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94960]: Revision status changed
User Reedy changed the status of MediaWiki.r94960. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94960 Commit summary: mft r94958 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94961]: Revision status changed
User Reedy changed the status of MediaWiki.r94961. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94961 Commit summary: adding default icon ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94962]: Revision status changed
User Reedy changed the status of MediaWiki.r94962. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94962 Commit summary: mft r94961 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94947]: Revision status changed
User Reedy changed the status of MediaWiki.r94947. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94947 Commit summary: 1.17wmf1: MFT r91499, r92846 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94934]: Revision status changed
User Reedy changed the status of MediaWiki.r94934. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94934 Commit summary: Removed debugging code from r94932 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95041]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95041#c21165 Commit summary: New hook point to change $wgAccountCreationThrottle Needed for a new extension to make (mass) account creation easier for schools/colleges etc Comment: This hook looks overtly specific and changing the global variable like that feels icky . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95081]: Revision status changed
User Reedy changed the status of MediaWiki.r95081. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95081 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84915]: Revision status changed
User Catrope changed the status of MediaWiki.r84915. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84915 Commit summary: Adding user bucket support ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95043]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c21166 Commit summary: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to replace the pre look'n feel, removing the first-child last-child selectors. * line numbers are not selected on mouse selection. Makes it easy to copy paste the patch. Note: old code left unchanged. To use it again, change the array_map callback in splitLines from 'parseLine' to 'colorLine'. Comment: pre + private $left = 0; + private $right = 0; + private $chunk = 0; /pre Why private? source lang=php + $left = $right = 'nbsp;'; /source Use numerical entities or the symbol itself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84938]: Revision status changed
User Catrope changed the status of MediaWiki.r84938. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84938 Commit summary: added bucket name convenience functions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85087]: Revision status changed
User Catrope changed the status of MediaWiki.r85087. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85087 Commit summary: changed naming of allActive, changed sample to be closer to actual information being collected ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94640]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r94640. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r94640. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94640#c21167 Commit summary: Removed usage of internal API call in Special:AddComment that was broken by r83080; using WikiPage::doEdit() (or Article::doEdit() in earlier MW versions) instead. Comment: Done in r95082. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95055]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95055. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95055#c21168 Commit summary: Upstream wikia changes Comment: Could you also mention the intent on the change besides that it came from Wikia? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95059]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95059. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95059#c21169 Commit summary: Couple more pieces of wikia upstreaming Comment: isset? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87531]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87531. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87531#c21170 Commit summary: create wikitweet extension in trunk Comment: Thank you for your comments, I think that all these changes requests are made in r87717. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87531]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87531. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87531#c21171 Commit summary: create wikitweet extension in trunk Comment: Thank you for your comments, I think that all these changes requests are made in r87717. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85198]: Revision status changed
User Catrope changed the status of MediaWiki.r85198. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85198 Commit summary: Gadgets: refactored [options] parsing in preparation for adding moar ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95041]: New comment added
User Raymond posted a comment on MediaWiki.r95041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95041#c21172 Commit summary: New hook point to change $wgAccountCreationThrottle Needed for a new extension to make (mass) account creation easier for schools/colleges etc Comment: Do have a better idea instead to change the throttle (IP specific) with an extension? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95064]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95064.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95064#c21173
Commit summary:
WikiHiero: rewrote generateTables.php to be an ordinary maintenance script
Comment:
Just FYI I'm unable to parse the description:
pre
+ * WikiHiero - A PHP convert from text using Manual for the encoding of
+ * hieroglyphic texts for computer input syntax to HTML entities (table and
+ * images).
/pre
Extra tab:
pre
+ public static function getCode( $file ) {
+ return substr( $file, strlen( WH_IMG_PRE ), -( 1 +
strlen( self::IMG_EXT ) ) );
+ }
/pre
If this isn't going to be a major change, what is? Maybe just drop some parts
of the version string?
+ const VERSION = '0.3.0alpha';
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95055]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95055. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95055#c21174 Commit summary: Upstream wikia changes Comment: Why is there no \n in the last call? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95065]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95065. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95065 Commit summary: Rm a couple of unneeded files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85561]: Revision status changed
User Catrope changed the status of MediaWiki.r85561. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85561 Commit summary: bugfixes to user bucketing feature ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86158]: Revision status changed
User Catrope changed the status of MediaWiki.r86158. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86158 Commit summary: bugfixes to the way samplecampaign and userbuckets calculate values ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95068]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95068#c21175 Commit summary: WikiHiero: moved all tables out of extension body, comment style fixes Comment: Why not go one step further and make it a real data and not executable code? pre -// 2011/08/20 at 07:34 +// 2011/08/20 at 09:31 /pre Can you make it look like 2011-08-20? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User Catrope posted a comment on MediaWiki.r86305. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86305#c21176 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: PHP part looks OK. Tagging for Krinkle to review the JS part. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95075]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95075. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95075#c21177 Commit summary: changing form color Comment: Shouldn't the color be in the CSS files in the first place? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95076]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r95076. Old Status: deferred New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r95076. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95076#c21178 Commit summary: changing color of fieldset Comment: Change does not match commit message. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86436]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r86436.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r86436.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86436#c21179
Commit summary:
Created more sensible way to add campaigns, now working in ie6
Comment:
pre
+if(!JSON.stringify){
+/* Very limited JSON encoder */
/pre
Use the codejquery.json/code module instead. OK otherwise.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86521]: Revision status changed
User Catrope changed the status of MediaWiki.r86521. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86521 Commit summary: made registration return the string zero for consistency in parsing ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86684]: Revision status changed
User Catrope changed the status of MediaWiki.r86684. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86684 Commit summary: added support for all in campaigns, added better DB error handling ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86578]: Revision status changed
User Catrope changed the status of MediaWiki.r86578. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86578 Commit summary: fixed bug that namespace wasn't accurately being recorded, no more duplicate entries on user properties table, fixed errors on userbuckets ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86688]: New comment added
User Catrope posted a comment on MediaWiki.r86688. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86688#c21180 Commit summary: Narayam: Add Telugu InScript scheme, prepared by user:Veeven of Telugu Wikipedia Comment: Ping? So should we or shouldn't be include te-inscript? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95041]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95041#c21181 Commit summary: New hook point to change $wgAccountCreationThrottle Needed for a new extension to make (mass) account creation easier for schools/colleges etc Comment: Is it possible to let the hook directly determine whether the ip is should be throttled or not? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87308]: Revision status changed
User Catrope changed the status of MediaWiki.r87308. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87308 Commit summary: better language handling - abandon magic language switch in favor of using int:lang as parameter, use parser-getFunctionLang() instead of wgContLanguage in case of use in interface messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87308]: Revision status changed
User Catrope changed the status of MediaWiki.r87308. Old Status: ok New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87308 Commit summary: better language handling - abandon magic language switch in favor of using int:lang as parameter, use parser-getFunctionLang() instead of wgContLanguage in case of use in interface messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92571]: Revision status changed
User Catrope changed the status of MediaWiki.r92571. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92571 Commit summary: follow up to r87308 - defensive programming for bogus language codes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87305]: Revision status changed
User Catrope changed the status of MediaWiki.r87305. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87305 Commit summary: fix issues from r86927, user language and years over ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86927]: Revision status changed
User Catrope changed the status of MediaWiki.r86927. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86927 Commit summary: adding language support to #time parser function, per bug 28655 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87352]: Revision status changed
User Catrope changed the status of MediaWiki.r87352. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87352 Commit summary: PLEASE TEST: Bug #26332 — Patch that I think should fix the problem according to the comments, but needs more testing * Also, a one line w/s fix up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87546]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r87546.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r87546.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87546#c21182
Commit summary:
Update RSS to add the ability to restrict per-namespace.
Comment:
pre
+ if ( $wgRSSNamespaces !== null is_array($wgRSSNamespaces) ) {
/pre
This is redundant, codeis_array(null)/code is false.
Did any follow-up come out of that IRC discussion? Provisionally marking fixme
for the array_flip() weirdness and Chad's claim that it isn't working.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95033]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95033. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95033#c21183 Commit summary: added warnings when trying to use invalid or disabled campaign and added headerLabelPage setting Comment: You probably want tt, 0/tt here: +$article = new Article( $page ); Please see also https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mwe-upwiz-campaign-conf-autoCategories/he ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar
On 11-08-20 02:58 AM, Ashar Voultoiz wrote:
On 20/08/11 01:50, Daniel Friesen wrote:
The current implementation of MediaWiki:Sidebar supports a completely
undocumented * {{msg}} syntax.
snip
Are there any objections to it being removed?
The sidebar code is a hack and it is far from being user friendly. User
currently has to edit:
- [[MediaWiki:Sidebar]]
- a message for link
- a message for link name
We should just rewrite it from scratch, using some Special page to
easily add / remove links. Save them to the database and the cache system.
I didn't mention it, but with the navigation message parser I'm
building, instead of creating instances of NavigationMessageParser and
describing the format of the messages I actually use a $wg var with the
definitions of the navigation message formats.
The point there is actually so that if someone decides to build
something like a Special:EditNavigation page, Special:EditNavigation
will be able to list the navigation types, and
Special:EditNavigation/sidebar, Special:EditNavigation/header, etc...
will know what format the message is and be able to let the special page
give the user an interface
I should point out that the fact the {{msg}} syntax is there would also
be in the way of a navigation editing ui.
Though I suppose you do have a good point, completely dropping this
system of using MediaWiki: messages for configuration is something to
seriously consider.
As for the {{msg}}, it might help if you list the revisions.
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/66974
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95053]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r95053. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95053#c21184 Commit summary: rewrote most of the table QP and fixed numeric sorting JS Comment: Yeah, it'd definitely be cool just to use the native MW code. I'll have a look at this soonish :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Less than 100 new revs for 1.18 (yay!), please look at your fixmes
I've been doing some code review today, and updated the revision report at https://secure.wikimedia.org/wikipedia/mediawiki/wiki/MediaWiki_roadmap/1.18/Revision_report . The number of new revs in 1.18 dropped to 92 today, the first time it's below 100. Yay! A side effect of reviewing code, though, is that the number of fixmes increases. We now have 64 fixme's in 1.18. The 1.18 wall of shame is: platonides: 6 purodha, reedy, tstarling: 5 diebuche: 4 bawolff, freakolowsky, hashar, maxsem, mgrabovsky, robin, tparscal: 3 catrope, happy-melon, werdna: 2 aaron, btongminh, demon, hartman, hcatlin, ialex, mah, neilk, nimishg, preilly, wikinaut, yaron: 1 So please address your fixme's, people! Another call to action is for reviewers who have new revisions assigned to them: nikerabbit: 10 krinkle: 6 brion: 3 tim: 4 trevor: 2 chad: 1 neil: 1 Revision lists for assigned revs and fixme's are on the revision report. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95085]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95085. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95085 Commit summary: minor style changes, renamed a method for consistency ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95033]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r95033. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95033#c21185 Commit summary: added warnings when trying to use invalid or disabled campaign and added headerLabelPage setting Comment: Right, added the code, 0/code :) What do you suggest as delimiter then? I'll replace comma by | for now, but there might be a better one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86688]: New comment added
User Junaidpv posted a comment on MediaWiki.r86688. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86688#c21186 Commit summary: Narayam: Add Telugu InScript scheme, prepared by user:Veeven of Telugu Wikipedia Comment: Technically we should include it. Santhosh is talking about the standard that was in draft stage, now it is released. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86688]: Revision status changed
User Catrope changed the status of MediaWiki.r86688. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86688 Commit summary: Narayam: Add Telugu InScript scheme, prepared by user:Veeven of Telugu Wikipedia ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95015]: Revision status changed
User ^demon changed the status of MediaWiki.r95015. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95015 Commit summary: Kill WikimediaMobile from 1.17wmf1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95032]: Revision status changed
User MaxSem changed the status of MediaWiki.r95032. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95032 Commit summary: Making dialog buttons native-style. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95033]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95033. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95033#c21187 Commit summary: added warnings when trying to use invalid or disabled campaign and added headerLabelPage setting Comment: | at least is not valid in titles. I can't think of a better one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87531]: New comment added
User IAlex posted a comment on MediaWiki.r87531. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87531#c21188 Commit summary: create wikitweet extension in trunk Comment: The two firsts are still not resolved. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95064]: New comment added
User MaxSem posted a comment on MediaWiki.r95064. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95064#c21189 Commit summary: WikiHiero: rewrote generateTables.php to be an ordinary maintenance script Comment: Just FYI I'm unable to parse the description: Well, neither do I :P ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87531]: New comment added
User Faure.thomas posted a comment on MediaWiki.r87531. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87531#c21190 Commit summary: create wikitweet extension in trunk Comment: OK, I will work on it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95018]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r95018. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95018#c21126 Commit summary: renamed wh_main.php -- wikihiero.body.php Comment: Why continue the tradition of using lowercase? The extension is called WikiHiero, so it would've made sense to call the main body file WikiHiero.body.php mdash; maybe one day we can rename the whole directory from wikihiero to WikiHiero. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95041]: Revision status changed
User Raymond changed the status of MediaWiki.r95041. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95041 Commit summary: New hook point to change $wgAccountCreationThrottle Needed for a new extension to make (mass) account creation easier for schools/colleges etc ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Mediawiki and a standard template library
On wikimedia projects that are not Wikipedia (Wikia in specific comes
to mind) I often find myself using templates that have not been
defined on that installation. The English Wikipedia (which I am most
familiar with) has many very usefull templates, especially the
{{citeFoo}} templates, but numerous others as well. Trying to 'import'
one is a bit of a pain though. Many templates depend on other
templates, and it is not often very clear how (as a fun exercise for
the reader, try to import the {{convert}} template to a new wiki, and
see how easy it is!). I was wondering if it might be a good idea to
include a standard template library to Wikimedia installations,
containing a set of utility templates along with the Wikimedia
distribution. I'm cross-posting foudation, for possible discussion if
this is desirable, and wikitech, for possible discussion if this is
feasable.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Foundation-l] Mediawiki and a standard template library
2011/8/20 Martijn Hoekstra martijnhoeks...@gmail.com:
On wikimedia projects that are not Wikipedia (Wikia in specific comes
to mind) I often find myself using templates that have not been
defined on that installation. The English Wikipedia (which I am most
familiar with) has many very usefull templates, especially the
{{citeFoo}} templates, but numerous others as well. Trying to 'import'
one is a bit of a pain though. Many templates depend on other
templates, and it is not often very clear how (as a fun exercise for
the reader, try to import the {{convert}} template to a new wiki, and
see how easy it is!).
It is being rewritten as an extension now. The Babel extension already
exists to replace {{babel}}. For some templates that's probably the
right way.
It would also be much, much easier to translate them.
I was wondering if it might be a good idea to
include a standard template library to Wikimedia installations,
containing a set of utility templates along with the Wikimedia
distribution.
Just today i thought about having a little standard template library
for wikis in RTL languages. A template that produces stuff like span
dir=ltr{{{1}}}/span. It should be easy.
--
Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
http://aharoni.wordpress.com
“We're living in pieces,
I want to live in peace.” – T. Moore
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki and a standard template library
On 20.08.2011, 22:23 Martijn wrote:
On wikimedia projects that are not Wikipedia (Wikia in specific comes
to mind) I often find myself using templates that have not been
defined on that installation. The English Wikipedia (which I am most
familiar with) has many very usefull templates, especially the
{{citeFoo}} templates, but numerous others as well. Trying to 'import'
one is a bit of a pain though. Many templates depend on other
templates, and it is not often very clear how (as a fun exercise for
the reader, try to import the {{convert}} template to a new wiki, and
see how easy it is!). I was wondering if it might be a good idea to
include a standard template library to Wikimedia installations,
containing a set of utility templates along with the Wikimedia
distribution. I'm cross-posting foudation, for possible discussion if
this is desirable, and wikitech, for possible discussion if this is
feasable.
Don't forget, English is one of 300-something languages we support.
And users of other languages typically don't feel comfortable with
using English templates, because words like cite book, author and
link are meaningless to them. So we're speaking about 300+ sets of
templates. This is both unmaintainable and burdensome. And don't
forget, not every MediaWiki (that's how our software is called, not
Wikimedia!) will want them. I would suppport a system that downloads
them on-demand, however shipping zillion templates out of the box is
simply out of the question.
--
Best regards,
Max Semenik ([[User:MaxSem]])
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki and a standard template library
2011/8/20 Max Semenik maxsem.w...@gmail.com: Don't forget, English is one of 300-something languages we support. And users of other languages typically don't feel comfortable with using English templates, because words like cite book, author and link are meaningless to them. Translating the templates' names can be easily done in translatewiki.net. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95095]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95095. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95095#c21191 Commit summary: use MediaWikis native table sort stuff Comment: pre+== S%W 1.6.2 ==/pre Woo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94974]: Revision status changed
User Reedy changed the status of MediaWiki.r94974. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94974 Commit summary: To be forever known as The Great UI Cleanup of 2011 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki and a standard template library
On Sat, Aug 20, 2011 at 8:35 PM, Max Semenik maxsem.w...@gmail.com wrote:
On 20.08.2011, 22:23 Martijn wrote:
On wikimedia projects that are not Wikipedia (Wikia in specific comes
to mind) I often find myself using templates that have not been
defined on that installation. The English Wikipedia (which I am most
familiar with) has many very usefull templates, especially the
{{citeFoo}} templates, but numerous others as well. Trying to 'import'
one is a bit of a pain though. Many templates depend on other
templates, and it is not often very clear how (as a fun exercise for
the reader, try to import the {{convert}} template to a new wiki, and
see how easy it is!). I was wondering if it might be a good idea to
include a standard template library to Wikimedia installations,
containing a set of utility templates along with the Wikimedia
distribution. I'm cross-posting foudation, for possible discussion if
this is desirable, and wikitech, for possible discussion if this is
feasable.
Don't forget, English is one of 300-something languages we support.
And users of other languages typically don't feel comfortable with
using English templates, because words like cite book, author and
link are meaningless to them. So we're speaking about 300+ sets of
templates. This is both unmaintainable and burdensome. And don't
forget, not every MediaWiki (that's how our software is called, not
Wikimedia!) will want them. I would suppport a system that downloads
them on-demand, however shipping zillion templates out of the box is
simply out of the question.
--
Best regards,
Max Semenik ([[User:MaxSem]])
eh, Derp on the MediaWiki/Wikimedia, dunno where that came from. Also
I'm not proposing to export all the en.wiki templates, but rather
establish a core set of templates that could be exported (and
translated!) on demand.
Regards,
Martijn
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki and a standard template library
On Sat, Aug 20, 2011 at 11:23 AM, Martijn Hoekstra
martijnhoeks...@gmail.com wrote:
On wikimedia projects that are not Wikipedia (Wikia in specific comes
to mind) I often find myself using templates that have not been
defined on that installation. The English Wikipedia (which I am most
familiar with) has many very usefull templates, especially the
{{citeFoo}} templates, but numerous others as well. Trying to 'import'
one is a bit of a pain though. Many templates depend on other
templates, and it is not often very clear how (as a fun exercise for
the reader, try to import the {{convert}} template to a new wiki, and
see how easy it is!). I was wondering if it might be a good idea to
include a standard template library to Wikimedia installations,
containing a set of utility templates along with the Wikimedia
distribution. I'm cross-posting foudation, for possible discussion if
this is desirable, and wikitech, for possible discussion if this is
feasable.
Since Wikia was mentioned in this post, I thought I'd outline how
we've tackled this problem, as it might be interesting to the
discussion.
When a new wiki is created at Wikia, we don't start with an empty
database. Instead, we copy the contents of what we've called a
starter wiki into the newly created database.
Apart from the special role they play in the creation of new wikis,
starter wikis are pretty much normal wiki sites (with the exception of
tighter edit permissions to prevent vandalism).
Have a look at the English starter wiki:
http://starter.wikia.com/index.php?title=Special%3AAllPagesfrom=to=namespace=10
As you can see it has a ton of different templates. All of these exist
at every new wiki when it's created.
Martijn: if your Wikia wiki doesn't have some (or all) of those, that
might be because it was created before the starter system or because
it's in a language other than English and that language's starter wiki
doesn't have the template(s) you want (yes, we have per language
starters, too).
Mail me off-list, I'm sure I can help include the needed templates in
future wikis. :)
--
Lucas 'TOR' Garczewski
Community Engineer
t...@wikia-inc.com
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki and a standard template library
- Original Message -
From: Martijn Hoekstra martijnhoeks...@gmail.com
On wikimedia projects that are not Wikipedia (Wikia in specific comes
to mind) I often find myself using templates that have not been
defined on that installation. The English Wikipedia (which I am most
familiar with) has many very usefull templates, especially the
{{citeFoo}} templates, but numerous others as well. Trying to 'import'
one is a bit of a pain though. Many templates depend on other
templates, and it is not often very clear how (as a fun exercise for
the reader, try to import the {{convert}} template to a new wiki, and
see how easy it is!). I was wondering if it might be a good idea to
include a standard template library to Wikimedia installations,
containing a set of utility templates along with the Wikimedia
distribution. I'm cross-posting foudation, for possible discussion if
this is desirable, and wikitech, for possible discussion if this is
feasable.
+25. I had to pull the book citation template out of Wikipedia to use it
on a Wikia site, and it was a 2 hour process.
Cheers,
-- jra
--
Jay R. Ashworth Baylink j...@baylink.com
Designer The Things I Think RFC 2100
Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90749]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r90749. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90749#c21192 Commit summary: Added one-time promote support via Autopromote::autopromoteOnceHook function. This is still a bit rough on the edges. This uses a hook since extension may want to control when it's called for performance reasons. Patch by lampak. (for bug 24948) Comment: Why is this fixme? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
