[Wikitech-l] wiki page has embedded 'code error'

2011-12-30 Thread jidanni
These things should be caught before the public sees them
$ w3m -dump 'http://zh.wikipedia.org/wiki/王力_(语言学家)'|grep error
緝code error!(5人名中都有「心」字)。
$ w3m -dump 'http://zh.wikipedia.org/wiki/王力_(语言学家)?action=raw'|grep 人名中都有
)、[[王缉慈]](女)、[[王缉思]]、[[王缉憲|王缉-{zh-hans:憲;}-]](5人名中都有「

Maybe templates should 'also report to their master' any time they
produce a 'code error'... if indeed a template is involved.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r107621]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107621 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107621

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107621:

Fix indenting from r104642

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106509]: Revision status changed

2011-12-30 Thread MediaWiki Mail
SVG changed the status of MediaWiki.r106509 to deferred
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106509

Old status:  new
 New status: deferred

Commit summary for MediaWiki.r106509:

Change category links, only make links blue on non-help-page-fetching wikis, 
remove noarticletext et al messages per css

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106555]: Revision status changed

2011-12-30 Thread MediaWiki Mail
SVG changed the status of MediaWiki.r106555 to deferred
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106555

Old status:  new
 New status: deferred

Commit summary for MediaWiki.r106555:

Fixing minor bugs in follow-up to r106527

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106511]: Revision status changed

2011-12-30 Thread MediaWiki Mail
SVG changed the status of MediaWiki.r106511 to new
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106511

Old status:  fixme
 New status: new

Commit summary for MediaWiki.r106511:

Renaming SpecialBatchUserRights.php to BatchUserRights_body.php, adapting 
aliases file and changing a message in two languages

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107603]: New comment added

2011-12-30 Thread MediaWiki Mail
VitaliyFilippov posted a comment on MediaWiki.r107603.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107603#c28677

Commit summary for MediaWiki.r107603:

Rewritten a discontinued extension. Should work with MW 1.13+

VitaliyFilippov's comment:

These variables are passed as parameters, so deprecated globals are not 
needed...

Will mw.config.get work on older MediaWiki's?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107603]: New comment added

2011-12-30 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107603.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107603#c28678

Commit summary for MediaWiki.r107603:

Rewritten a discontinued extension. Should work with MW 1.13+

Nikerabbit's comment:

Not on the very olds because the don't have resource loader.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107610]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107610.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107610#c28679

Commit summary for MediaWiki.r107610:

[mediawiki.debug] highlight current pane and styling
* wrapping bits in container and centering tabs
* letting includes-pane use same markup and styling as queries
* move appendTo action into common function (more DRY)

Krinkle's comment:

Hm.. will check out in a few hours. Thanks :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Wikimedia Based Open Source Project - Help On Licencing

2011-12-30 Thread Huib Laurens
Hi,

I know that the software we use for our website is payed  (www.whmcs.com)
and you can add a wiki module. This module doesn't cost any extra money,
but you can grap a add-on that costs money what will tune the Wiki CSS into
your websites CSS (pretty cool do!)

But this is just MediaWiki: http://docs.whmcs.com/Special:Version
And the payed addon is a encrypte source code..

Best,

Huib

2011/12/30 Tim Starling tstarl...@wikimedia.org

 On 30/12/11 08:30, Dan Collins wrote:
  On Thu, Dec 29, 2011 at 4:24 PM, Huib Laurens sterke...@gmail.com
 wrote:
  It doesn't need to be compatible or open-source right?
 
  GPL 2.0 section 2 b:
 
  b) You must cause any work that you distribute or publish, that in
  whole or in part contains or is derived from the Program or any part
  thereof, to be licensed as a whole at no charge to all third parties
  under the terms of this License.

 You can modify GPL software for private use. That clause only kicks in
 when you distribute or publish the work, so you're generally OK if
 you're just using it within a single company. Maybe that's what Huib
 meant by closed source.

 -- Tim Starling


 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
Kind regards,

Huib Laurens
WickedWay.nl

Webhosting the wicked way.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Wikimedia Based Open Source Project - Help On Licencing

2011-12-30 Thread Henning Wangerin
Den 30-12-2011 05:02, Tim Starling skrev:

 You can modify GPL software for private use. That clause only kicks in
 when you distribute or publish the work, so you're generally OK if
 you're just using it within a single company. Maybe that's what Huib
 meant by closed source.

distribute or publish covers wen you put your additions for download, or 
otherwise gives away copies.


You can do any additions, keep it on your own servers, and sell the 
result to clients.

-- 
Henning Wangerin
Skoltoften 9, DK - 6400 Sonderborg
www.alslug.dk - www.opensourcedays.org - www.ubuntudanmark.dk


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r105612]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r105612.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105612#c28680

Commit summary for MediaWiki.r105612:

* (bug 32879) Upgrade jQuery to 1.7.1

Tests in qunit still pass fine

Krinkle's comment:

[[jQuery]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107610]: New comment added

2011-12-30 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107610.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107610#c28681

Commit summary for MediaWiki.r107610:

[mediawiki.debug] highlight current pane and styling
* wrapping bits in container and centering tabs
* letting includes-pane use same markup and styling as queries
* move appendTo action into common function (more DRY)

Nikerabbit's comment:

Just FYI if it comes in need: Google Chrome 16.0.912.63 in Linux. Seen on 
http://translatewiki.net/sw/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Wikimedia Based Open Source Project - Help On Licencing

2011-12-30 Thread Tei
If you take a open source proyect, and develop another open source
proyect based on it, you are forking.  You must continue with the same
license the original authors used. This is a must, if you can't
convince all the original authors to allow you to use a different
license (hard if theres a lot of then, easy if theres only one).

Forking is fun, but heres a caveat: the original proyect may go faster
and develop features you may need, but you cant have in your fork.
Forking is a good idea if you want to follow different guidelines, not
a good idea if you have the same ideas of the original authors.
Forking is sometimes obligatory wen the original authors are stubborn
and too slow to update a proyect. Sometimes forking is a good idea if
the original proyect is poisoned by bloat, and you want to use a axe
and remove all the complexity (perhaps that was the case of firefox?).
 Normally is not a good ideas, and all open source projects have
smarted up and include most features in plugins, so the core is
small, not bloated, and flexible for everyone need.

On 29 December 2011 07:31, Sajith Vimukthi sajith@gmail.com wrote:
 Hello All,

 I am planning to develop a new Open Source project keeping mediawiki as the
 baseline. I wonder how the  liciening  policy of mediawiki will affect my
 intention. Could somebody help me on whether it is possible to develop my
 own app using mediawiki and distribute it as an opensource project?

 Thanks,
 Regards,
 Sajith Vimukthi Weerakoon,
 T .P No : ++94-716102392
              ++94-727102392
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l



-- 
--
ℱin del ℳensaje.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r106295]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r106295.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106295#c28682

Commit summary for MediaWiki.r106295:


Remove stray trailing commas on last items in array literals -- this breaks IE 
6/7/8

Followup r105560

Krinkle's comment:

Good idea, I might try something with the JSLint/JSHint API.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r105619]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r105619.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105619#c28683

Commit summary for MediaWiki.r105619:

Update jquery.effects

Krinkle's comment:

It's upstream, but we do it as well. It ensures undefined is undefined 
because unfortunately JavaScript allows a variable to be named undefined, 
both locally and globally. So if anywhere down the line between global scope 
and here someone thought it would be funny to do that, there's a problem. I 
think this is rather far fetched, but people seem to do it quite often 
(especially in plugins and frameworks that need to work everywhere).

Another minor advantage (not a justification for this thought) is the scope. 
Normally undefined is global variable set to undefined, now it is a local 
variable instead of a global variable, which might speed up scripts that do a 
lot of comparisons which would otherwise have to bubble up the scope chain for 
each time undefined is referenced.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r105619]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r105619.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105619#c28684

Commit summary for MediaWiki.r105619:

Update jquery.effects

Krinkle's comment:

As of ECMAScript 5 undefined has become a non-writable global property.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102406]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r102406.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102406#c28685

Commit summary for MediaWiki.r102406:

* Use local context to get messages
* Changed three isset() to [!=]== null

Krinkle's comment:

pre+  } elseif( $from !== null  $to == null ) {/pre
Was it intentional that one is strict and not the other ?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102406]: New comment added

2011-12-30 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r102406.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102406#c28686

Commit summary for MediaWiki.r102406:

* Use local context to get messages
* Changed three isset() to [!=]== null

IAlex's comment:

Thanks! Fixed in r107631.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107631]: Revision status changed

2011-12-30 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r107631 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107631

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107631:

Per Krinkle, fix for r102406: use strict comparison

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107632]: Revision status changed

2011-12-30 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r107632 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107632

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107632:

svn:eol-style native

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107474]: Revision status changed

2011-12-30 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r107474 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107474

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107474:

integrated into post-merger extension

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107475]: New comment added

2011-12-30 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r107475.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107475#c28687

Commit summary for MediaWiki.r107475:

initial prep for localisation - not yet ready

^demon's comment:

Remove the svn:executable property, it's not needed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107329]: Revision status changed

2011-12-30 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r107329 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107329

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107329:

[Core JS] Remove long deprecated globals 'ta' and 'akeytt'
* Not used anywhere in ./phase3/
* Not used anywhere in ./extensions/
* Deprecated in MediaWiki 1.16 according to HISTORY

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Wikimedia Based Open Source Project - Help On Licencing

2011-12-30 Thread Jay Ashworth
- Original Message -
 From: Tim Starling tstarl...@wikimedia.org

 On 30/12/11 08:30, Dan Collins wrote:
  On Thu, Dec 29, 2011 at 4:24 PM, Huib Laurens sterke...@gmail.com
  wrote:
  It doesn't need to be compatible or open-source right?
 
  GPL 2.0 section 2 b:
 
  b) You must cause any work that you distribute or publish, that in
  whole or in part contains or is derived from the Program or any part
  thereof, to be licensed as a whole at no charge to all third parties
  under the terms of this License.
 
 You can modify GPL software for private use. That clause only kicks in
 when you distribute or publish the work, so you're generally OK if
 you're just using it within a single company. Maybe that's what Huib
 meant by closed source.

And since we're not under the *Affero* GPL, you can modify it, *and make it
publicly available*, and still not be constrained by the licence (I don't 
think I've got that backwards, do I?)

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth  Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Multilingual Wordpress

2011-12-30 Thread Guillaume Paumier
Salut Sébastien,

On Wed, Dec 28, 2011 at 11:44 AM, Seb35 seb35wikipe...@gmail.com wrote:

 I tried last days to mass-translate blog posts of the Foundation’s blog,
 aiming at building a parallel blog in French with the same posts,
 translated [1]. Some people are interested in regularly translating blog
 posts. So my question is: is it possible to make the Foundation’s blog
 multilingual?

The specific plug-in you linked to is described as pure alpha, so I
wouldn't necessarily be comfortable enabling it on our production blog
(at least not yet).

In principle, I'm personally not opposed to having a multilingual
setup on the Wikimedia blog, though. I think it's a great idea, at
least worth trying out. And as far as I know, other Communications
people also find the idea interesting.

I researched the topic a few weeks ago following a discussion we had,
and the best bet back then was the WPML plugin: http://wpml.org ; it's
a commercial plugin but it's not too expensive, and they have a
fee-waiving program for nonprofits. The plugin includes a translation
workflow, but I haven't tried it out.

 So: possible? difficult? thoughts?

I'd say: possible, probably desirable, and possibly not too difficult.
The real trick is going to be the choice of the tool, since we want
something that works, stays maintained and doesn't overly complicate
our own setup.

-- 
Guillaume Paumier
Technical Communications Manager — Wikimedia Foundation
http://donate.wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread John
a user Jan Kucera (Kozuch) (with email of garba...@seznam.cz) has been mass
changing the priority of bugs based on a very crude vote count. this is
very disruptive and counter productive issue. I would ask that one of our
devs mass revert this please.


Johh
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Huib Laurens
+1 my mailbox just got spammed by him...


2011/12/30, John phoenixoverr...@gmail.com:
 a user Jan Kucera (Kozuch) (with email of garba...@seznam.cz) has been mass
 changing the priority of bugs based on a very crude vote count. this is
 very disruptive and counter productive issue. I would ask that one of our
 devs mass revert this please.


 Johh
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l


-- 
Verzonden vanaf mijn mobiele apparaat

Kind regards,

Huib Laurens
WickedWay.nl

Webhosting the wicked way.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[Wikitech-l] Bugzilla: Minor enhancements should not be tagged highest priority.

2011-12-30 Thread Dan Collins
Greetings,

On Bugzilla, bugs which are minor enhancements should not be tagged
highest priority unless the priority is truly highest. This should
certainly not be done en masse without personally reviewing the bug
itself. Technological fact is not subject to democracy.

Search showing bugs which may need checking:
https://bugzilla.wikimedia.org/buglist.cgi?chfieldto=Nowchfield=priorityquery_format=advancedchfieldfrom=2011-12-29emaillongdesc1=1email1=garbage5%40seznam.czemailtype1=exactlist_id=72170

Examples of Highest priority probably minor feature requests or bugs:
https://bugzilla.wikimedia.org/show_bug.cgi?id=14396
https://bugzilla.wikimedia.org/show_bug.cgi?id=12974
https://bugzilla.wikimedia.org/show_bug.cgi?id=8697
https://bugzilla.wikimedia.org/show_bug.cgi?id=19796
https://bugzilla.wikimedia.org/show_bug.cgi?id=6379
https://bugzilla.wikimedia.org/show_bug.cgi?id=5309
https://bugzilla.wikimedia.org/show_bug.cgi?id=3461

There are also numerous highest priority extension installations.

--Dan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Bugzilla: Minor enhancements should not be tagged highest priority.

2011-12-30 Thread Jay Ashworth
- Original Message -
 From: Dan Collins en.wp.s...@gmail.com

 On Bugzilla, bugs which are minor enhancements should not be tagged
 highest priority unless the priority is truly highest. This should
 certainly not be done en masse without personally reviewing the bug
 itself. Technological fact is not subject to democracy.

On my Bugzilla installations, the Severity is owned by the reporter, but the
Priority by the assignee; this seems the best approach to me...

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth  Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Chad
Has anyone told him we don't use voting?

-Chad
On Dec 30, 2011 11:04 AM, John phoenixoverr...@gmail.com wrote:

 a user Jan Kucera (Kozuch) (with email of garba...@seznam.cz) has been
 mass
 changing the priority of bugs based on a very crude vote count. this is
 very disruptive and counter productive issue. I would ask that one of our
 devs mass revert this please.


 Johh
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Amir E. Aharoni
As long as it's there, people will think that we do.

This mass change should have been discussed somewhere first, but then
i never understood why voting is bad. Mozilla haven't disabled it in
their Bugzilla and Google use it in Google code (as stars), although i
don't whether either of them actually prioritize bugs according to it.

2011/12/30 Chad innocentkil...@gmail.com:
 Has anyone told him we don't use voting?

 -Chad
 On Dec 30, 2011 11:04 AM, John phoenixoverr...@gmail.com wrote:

 a user Jan Kucera (Kozuch) (with email of garba...@seznam.cz) has been
 mass
 changing the priority of bugs based on a very crude vote count. this is
 very disruptive and counter productive issue. I would ask that one of our
 devs mass revert this please.


 Johh
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Jeremy Baron
On Fri, Dec 30, 2011 at 11:38, Amir E. Aharoni
amir.ahar...@mail.huji.ac.il wrote:
 As long as it's there, people will think that we do.

 This mass change should have been discussed somewhere first, but then
 i never understood why voting is bad. Mozilla haven't disabled it in
 their Bugzilla and Google use it in Google code (as stars), although i
 don't whether either of them actually prioritize bugs according to it.

I thought stars were the only way to subscribe to future updates? and
hence they're not necessarily votes.

-Jeremy

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Chad
On Fri, Dec 30, 2011 at 11:42 AM, Jeremy Baron jer...@tuxmachine.com wrote:
 On Fri, Dec 30, 2011 at 11:38, Amir E. Aharoni
 amir.ahar...@mail.huji.ac.il wrote:
 As long as it's there, people will think that we do.

 This mass change should have been discussed somewhere first, but then
 i never understood why voting is bad. Mozilla haven't disabled it in
 their Bugzilla and Google use it in Google code (as stars), although i
 don't whether either of them actually prioritize bugs according to it.

 I thought stars were the only way to subscribe to future updates? and
 hence they're not necessarily votes.


CC list? But yes, we've just never used the voting--it's mainly just
there as a favorites type list.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mediawiki 2.0

2011-12-30 Thread Krinkle
On Dec 7, 2011, at 10:33 AM, Dmitriy Sintsov wrote:

 * Trevor Parscal tpars...@wikimedia.org [Tue, 6 Dec 2011 17:21:43 
 -0800]:
 The hype of 2.0 aside, is there a guideline for what should 
 constitute
 a
 major version number change?
 
 It looks like we are doing something like: Major.Minor.Release
 
 1.18 = Major: 1, Minor: 18, (alpha|beta|etc.)
 
 I'm just curious what people think would constitue a major version.
 We've
 certainly had major rewrites of systems in the past that didn't seem 
 to
 justify a version bump. Is there anything wrong with having version
 1.249?
 Is there a practical reason for bumping the version at some point 
 (like
 when the minor version hits tripple digits)?
 
 Also, a rewrite of MediaWiki should for sure be done in Node.js :)
 
 - Trevor
 
 Is Javascript really that good? Some people dislike prototypical 
 inheritance, it seems that jQuery prefers to use wrappers instead 
 (that's a kind of suboptimal architecture). Also, Google had some 
 complains about Javascript flaws (for example primitive types don't 
 allow high performance available in Java / C#), suggesting to replace it 
 with something else.. Although having common clientside / serverside 
 codebase is nice thing, for sure. And there's nothing more widespread 
 than Javascript at client side. Also, it's object side is strong 
 (something like Lisp with C-syntax), however it does not have generics, 
 named parameters etc..
 Dmitriy

I don't know how much you know about JavaScript but in my opinion it's often
misunderstood. I think it's superior than most other programming
languages because it's very expressive and it's simplicity is what allows
great complexity. Bad parts are kept in for compatibility, but once you start
treating those bad parts like they don't exist (by not using them, ever) one is
left with a language that is still as powerful. (btw, that's the great thing 
for being
a developer, we have the power to basically remove parts of the language
without changing the standards or breaking other peoples code).

It's fairly easy to use it in a classical inheritance way, (i.e. use classes 
that
extend from classes and use constructors for creating objects), which can't
be said for languages that use classical inheritance, there is no way to do
prototypal stuff there.

JavaScript's true power comes into play when using prototypal inheritance
directly (creating objects that inherit directly from other objects).

jQuery uses prototypal inheritance as well, it's what makes jQuery what it
is.

jQuery('#bodyContent').find( 'a' ).addClass( 'foobar' );

That chain is possible because the jQuery constructor (which is tucked away
and calling jQuery( .. ) just does return new jQuery.fn.init( .. );) which
creates an object that inherits all members in jQuery.prototype and does so
by reference (not by value)

So when a jQuery plugin is loaded onto the page at any time (that defines
jQuery.prototype.myPlugin), all existing jQuery objects will have that method.
And because all those methods return this, you can call another method on
the return value in a chain, and so on.

jQuery did choose not to extend the browsers' native objects'  prototypes but
that's purely a policy created because of how browsers work not because of
how the language itself work, it's technically possible and other libraries such
as MooTools do do that.


Indeed it's functions are primary citizens and object system is what makes it 
so strong.
Since virtually any value other than null and undefined is an object, including 
numbers,
strings and functions.





___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread John Du Hart
Revert it. Just like enwiki, you can't do stuff like this without
discussion.

On Fri, Dec 30, 2011 at 11:48 AM, Chad innocentkil...@gmail.com wrote:

 On Fri, Dec 30, 2011 at 11:42 AM, Jeremy Baron jer...@tuxmachine.com
 wrote:
  On Fri, Dec 30, 2011 at 11:38, Amir E. Aharoni
  amir.ahar...@mail.huji.ac.il wrote:
  As long as it's there, people will think that we do.
 
  This mass change should have been discussed somewhere first, but then
  i never understood why voting is bad. Mozilla haven't disabled it in
  their Bugzilla and Google use it in Google code (as stars), although i
  don't whether either of them actually prioritize bugs according to it.
 
  I thought stars were the only way to subscribe to future updates? and
  hence they're not necessarily votes.
 

 CC list? But yes, we've just never used the voting--it's mainly just
 there as a favorites type list.

 -Chad

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
John
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107315]: New comment added

2011-12-30 Thread MediaWiki Mail
Duplicatebug posted a comment on MediaWiki.r107315.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107315#c28688

Commit summary for MediaWiki.r107315:

fix for bug 33372, disabling CentralNotice on Special pages

Duplicatebug's comment:

I am not sure, if disabling on Special:Watchlist is good, because some users 
are only checking his watchlist (per bookmark and activ remember me cookie), to 
see, if some important thing is one the wiki and not looking at any other 
pages. When the CentralNotice is a maintenance warning or so, that is very 
useful to know.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106223]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Bsitu changed the status of MediaWiki.r106223 to new
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106223

Old status:  fixme
 New status: new

Commit summary for MediaWiki.r106223:

follow up -r 105969 - update feedback response email with latest copy

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread John Du Hart
Left him a note about this thread.
https://en.wikipedia.org/wiki/User_talk:Kozuch#Discussion_about_your_actions_in_Wikitech-l


On Fri, Dec 30, 2011 at 1:04 PM, John Du Hart compwhi...@gmail.com wrote:

 Revert it. Just like enwiki, you can't do stuff like this without
 discussion.


 On Fri, Dec 30, 2011 at 11:48 AM, Chad innocentkil...@gmail.com wrote:

 On Fri, Dec 30, 2011 at 11:42 AM, Jeremy Baron jer...@tuxmachine.com
 wrote:
  On Fri, Dec 30, 2011 at 11:38, Amir E. Aharoni
  amir.ahar...@mail.huji.ac.il wrote:
  As long as it's there, people will think that we do.
 
  This mass change should have been discussed somewhere first, but then
  i never understood why voting is bad. Mozilla haven't disabled it in
  their Bugzilla and Google use it in Google code (as stars), although i
  don't whether either of them actually prioritize bugs according to it.
 
  I thought stars were the only way to subscribe to future updates? and
  hence they're not necessarily votes.
 

 CC list? But yes, we've just never used the voting--it's mainly just
 there as a favorites type list.

 -Chad

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




 --
 John




-- 
John
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107610]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107610.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107610#c28689

Commit summary for MediaWiki.r107610:

[mediawiki.debug] highlight current pane and styling
* wrapping bits in container and centering tabs
* letting includes-pane use same markup and styling as queries
* move appendTo action into common function (more DRY)

Krinkle's comment:

I see it. Looks like the proper behavior for tables. They auto-expand and are 
really stubborn when it comes to wrapping lines.

Using codetable-layout: fixed;/code this will go away, but then we have to 
manually set the widths for column, browsers will then completely drop the 
auto-column devision. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107367]: New comment added

2011-12-30 Thread MediaWiki Mail
Amire80 posted a comment on MediaWiki.r107367.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107367#c28690

Commit summary for MediaWiki.r107367:

Workflow states logging.

Amire80's comment:

Addressed in r107642. Probably now it's functionally better, too.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107559]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
Amire80 changed the status of MediaWiki.r107559 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107559#c28691

Old Status: fixme
 New Status: new

Commit summary for MediaWiki.r107559:

Gender aliases for user and user talk pages.

Amire80's comment:

Addressed in r107645.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107645]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Amire80 changed the status of MediaWiki.r107645 to fixme
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107645

Old status:  new
 New status: fixme

Commit summary for MediaWiki.r107645:

Followup r107559. Added male aliases for User: to Russian and Hebrew. 
Requested by nikerabbit and reedy.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107559]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r107559 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107559

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107559:

Gender aliases for user and user talk pages.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107645]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r107645 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107645

Old status:  fixme
 New status: ok

Commit summary for MediaWiki.r107645:

Followup r107559. Added male aliases for User: to Russian and Hebrew. 
Requested by nikerabbit and reedy.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107645]: New comment added

2011-12-30 Thread MediaWiki Mail
Amire80 posted a comment on MediaWiki.r107645.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107645#c28692

Commit summary for MediaWiki.r107645:

Followup r107559. Added male aliases for User: to Russian and Hebrew. 
Requested by nikerabbit and reedy.

Amire80's comment:

Russian is broken here, fixed in r107648.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107648]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r107648 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107648

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107648:

Follow up to r107645, corrected Russian.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r93720]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Raindrift changed the status of MediaWiki.r93720 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93720

Old status:  fixme
 New status: resolved

Commit summary for MediaWiki.r93720:

Extend upload api adding an option to upload files in chunks,
using UploadStash to track the unfinished upload.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Daniel Friesen
On Fri, 30 Dec 2011 08:04:32 -0800, John phoenixoverr...@gmail.com wrote:

 a user Jan Kucera (Kozuch) (with email of garba...@seznam.cz) has been  
 mass
 changing the priority of bugs based on a very crude vote count. this is
 very disruptive and counter productive issue. I would ask that one of our
 devs mass revert this please.


 Johh

And here I thought this was just another run of bugspam vandalism to the  
tracker.

-- 
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107588]: New comment added

2011-12-30 Thread MediaWiki Mail
Robmoen posted a comment on MediaWiki.r107588.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107588#c28693

Commit summary for MediaWiki.r107588:

only show markashelpful for feedback response on the talk page of feedback owner

Robmoen's comment:

Trailing space on this line:

pre+  'mbfr_id' = intval( $item ) /pre

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Thehelpfulone Wikipedia
If you vote for a bug then you are automatically added to the CC list and you 
it's a nice way to keep track of the bugs you are interested in using 'My 
Votes'. However, at first when I saw the votes system, I too believed that more 
votes = more quickly done. As this is not the case, removing votes might be a 
good way forward.

Thehelpfulone

On 30 Dec 2011, at 19:33, Daniel Friesen li...@nadir-seen-fire.com wrote:

 On Fri, 30 Dec 2011 08:04:32 -0800, John phoenixoverr...@gmail.com wrote:
 
 a user Jan Kucera (Kozuch) (with email of garba...@seznam.cz) has been  
 mass
 changing the priority of bugs based on a very crude vote count. this is
 very disruptive and counter productive issue. I would ask that one of our
 devs mass revert this please.
 
 
 Johh
 
 And here I thought this was just another run of bugspam vandalism to the  
 tracker.
 
 -- 
 ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
 
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[Wikitech-l] Instructions for setting up regression tests on local machine?

2011-12-30 Thread Dan Nessett
I have poked around a bit (using Google), but have not found instructions 
for setting up the MW regression test framework (e.g., CruiseControl or 
Jenkins or whatever is now being used + PHPUnit tests + Selenium tests) 
on a local machine (so new code can be regression tested before 
submitting patches to Bugzilla). Do such instructions exist and if so, 
would someone provide a pointer to them?

Thanks,

-- 
-- Dan Nessett


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[Wikitech-l] Small-ish gadget project: Bug update gadget

2011-12-30 Thread Erik Moeller
Hi all,

in the new tradition of posting little gadget ideas and requests here:

http://www.mediawiki.org/wiki/Gadget_kitchen/Requests#Automatic_updates_to_pages_with_bug_templates

This would be helpful for pages which use bug templates like
[[mw:Template:Tracked]] to inform users about the status of bugs they
care about. If it's useful and efficient, we could promote it to
default gadget or site script.

Any takers? :)

Cheers,
Erik

-- 
Erik Möller
VP of Engineering and Product Development, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107305]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107305.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107305#c28694

Commit summary for MediaWiki.r107305:

Rework ext.translate.quickedit.js from global functions into mw.translate
Numerous JS fixes, like getting rid of legacy globals

Krinkle's comment:

@Santhosh: Are you referring to the way a reference to codemw/code is 
established or the way the property is defined ?

Using codevar mw = mediaWiki;/code is indeed not the way we do it per 
conventions (there's nothing wrong with it, pure stylistic convention to use 
the closure-callee to alias it).

Using a local variable and exposing it at the end is fine, we do that a lot and 
is better for performance as well if you refer to the current object a lot.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Instructions for setting up regression tests on local machine?

2011-12-30 Thread Roan Kattouw
On Fri, Dec 30, 2011 at 9:11 PM, Dan Nessett dness...@yahoo.com wrote:
 I have poked around a bit (using Google), but have not found instructions
 for setting up the MW regression test framework (e.g., CruiseControl or
 Jenkins or whatever is now being used + PHPUnit tests + Selenium tests)
 on a local machine (so new code can be regression tested before
 submitting patches to Bugzilla). Do such instructions exist and if so,
 would someone provide a pointer to them?

Jenkins is only really used to run the tests automatically when
someone commits. You ran run the PHPUnit tests locally without
Jenkins. Instructions on installing PHPUnit and running the tests is
at https://www.mediawiki.org/wiki/Manual:PHP_unit_testing .

I don't have URLs for you offhand, but QUnit and Selenium are probably
also documented on mediawiki.org .

Roan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Instructions for setting up regression tests on local machine?

2011-12-30 Thread Krinkle
QUnit tests (for our JavaScript modules) can be ran by opening

./tests/qunit/index.html

in your browser.

Note that this is about to change in a few days, but check
https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing
for the latest info.


On Fri, Dec 30, 2011 at 9:29 PM, Roan Kattouw roan.katt...@gmail.comwrote:

 On Fri, Dec 30, 2011 at 9:11 PM, Dan Nessett dness...@yahoo.com wrote:
  I have poked around a bit (using Google), but have not found instructions
  for setting up the MW regression test framework (e.g., CruiseControl or
  Jenkins or whatever is now being used + PHPUnit tests + Selenium tests)
  on a local machine (so new code can be regression tested before
  submitting patches to Bugzilla). Do such instructions exist and if so,
  would someone provide a pointer to them?
 
 Jenkins is only really used to run the tests automatically when
 someone commits. You ran run the PHPUnit tests locally without
 Jenkins. Instructions on installing PHPUnit and running the tests is
 at https://www.mediawiki.org/wiki/Manual:PHP_unit_testing .

 I don't have URLs for you offhand, but QUnit and Selenium are probably
 also documented on mediawiki.org .

 Roan

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r55905]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r55905.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/55905#c28695

Commit summary for MediaWiki.r55905:

Refactor redundant attrib dropping into new method

This saves code in a few places on the caller's side, and will reduce
the size of output HTML more consistently.

Krinkle's comment:

(message from the future: bug 33274)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Helder
On Fri, Dec 30, 2011 at 18:03, Thehelpfulone Wikipedia
thehelpfulonew...@gmail.com wrote:
 If you vote for a bug then you are automatically added to the CC list and you 
 it's a nice way to keep track of the bugs you are interested in using 'My 
 Votes'. However, at first when I saw the votes system, I too believed that 
 more votes = more quickly done. As this is not the case, removing votes might 
 be a good way forward.

Actually, when we vote for a bug we are not added to its CC list
(which would cause an email to be sent to everyone already on that
list), but we get followup messages anyway. This way, the votes can
also be used for silently watching some bugs without bothering others
with emails which just say we were added to the CC list...

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Brandon Harris

Why don't we just change the text vote to follow or watch?


On 12/30/11 12:51 PM, Helder wrote:
 On Fri, Dec 30, 2011 at 18:03, Thehelpfulone Wikipedia
 thehelpfulonew...@gmail.com  wrote:
 If you vote for a bug then you are automatically added to the CC list and 
 you it's a nice way to keep track of the bugs you are interested in using 
 'My Votes'. However, at first when I saw the votes system, I too believed 
 that more votes = more quickly done. As this is not the case, removing votes 
 might be a good way forward.

 Actually, when we vote for a bug we are not added to its CC list
 (which would cause an email to be sent to everyone already on that
 list), but we get followup messages anyway. This way, the votes can
 also be used for silently watching some bugs without bothering others
 with emails which just say we were added to the CC list...

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

-- 
Brandon Harris, Senior Designer, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107563]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Amire80 changed the status of MediaWiki.r107563 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107563

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107563:

Change the 'Disable input method' preference to 'Enable input method'.
Simplify some interface messages.

i18n card #362

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Chad
On Fri, Dec 30, 2011 at 3:51 PM, Helder helder.w...@gmail.com wrote:
 Actually, when we vote for a bug we are not added to its CC list
 (which would cause an email to be sent to everyone already on that
 list), but we get followup messages anyway. This way, the votes can
 also be used for silently watching some bugs without bothering others
 with emails which just say we were added to the CC list...


Did you know you can disable notifications for cc list changes?
In fact, we should probably make that the default.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Bugzilla: Minor enhancements should not be tagged highest priority.

2011-12-30 Thread Mark A. Hershberger
Jay Ashworth j...@baylink.com writes:

 - Original Message -
 From: Dan Collins en.wp.s...@gmail.com

 On Bugzilla, bugs which are minor enhancements should not be tagged
 highest priority unless the priority is truly highest. This should
 certainly not be done en masse without personally reviewing the bug
 itself. Technological fact is not subject to democracy.

 On my Bugzilla installations, the Severity is owned by the reporter, but the
 Priority by the assignee; this seems the best approach to me...

I agree.  This is how I have been handling it.

I leave Severity alone.

Priority defaults to unprioritized.

I make a first pass at prioritization with most things going into
Normal.

I think we have a pretty good handle on things in the Highest priority,
but with recent activity and the limited prioritization I've done while
on my break, there are too many things in Highest now.

I will cull the list on Tuesday, but if anyone wants to take a shot now,
be my guest.

(Still to discuss: How do I/we handle High priority bugs?)

Mark

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107653]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
Raymond changed the status of MediaWiki.r107653 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107653#c28696

Old Status: new
 New Status: fixme

Commit summary for MediaWiki.r107653:

* Inverted the precedence between section edition and revision undoing, now 
undo and undoafter will be ignored if the section (or even wpSection) is 
provided to be consistent the remaining of the interface
* Modified EditPage::getContent() to load the original content only when really 
needed
* Don't put the 'missing-article' in the textbox when a non-existing revision 
is provided, instead display it above the form
* Always diff to the current version when showing a conflict or a spam filter 
match
* Factorised code to get the current text on edit conflict
* Compare the correct text in EditPage::internalAttemptSave()
* Some little coding style fixes

Raymond's comment:

 PHP Notice: Undefined variable: section in /www/w/includes/EditPage.php on 
line 703

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107653]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
IAlex changed the status of MediaWiki.r107653 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107653#c28697

Old Status: fixme
 New Status: new

Commit summary for MediaWiki.r107653:

* Inverted the precedence between section edition and revision undoing, now 
undo and undoafter will be ignored if the section (or even wpSection) is 
provided to be consistent the remaining of the interface
* Modified EditPage::getContent() to load the original content only when really 
needed
* Don't put the 'missing-article' in the textbox when a non-existing revision 
is provided, instead display it above the form
* Always diff to the current version when showing a conflict or a spam filter 
match
* Factorised code to get the current text on edit conflict
* Compare the correct text in EditPage::internalAttemptSave()
* Some little coding style fixes

IAlex's comment:

Fixed in r107658.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107656]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107656.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107656#c28698

Commit summary for MediaWiki.r107656:

* Style fixes in EditPage::showEditForm() to more readable
* Use style=display:none; instead of non-existing type=hidden for the 
textarea when asking user for confirmation to save the edit if the page was 
deleted during edition; also drop other attributes since they are useless in 
that case

Krinkle's comment:

FYI, since bug 30719 is fixed, attributes like class may be an array when 
using codeHtml::element/code (which EditPage::showTextbox does)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r99732]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
Robmoen changed the status of MediaWiki.r99732 to ok and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99732#c28699

Old Status: new
 New Status: ok

Commit summary for MediaWiki.r99732:

switching from GPL to MIT license per 
http://www.mediawiki.org/wiki/Thread:Extension_talk:WikiLove/Reusing_the_default_WikiLove.js,
 Jan Paul agrees with switch

Robmoen's comment:

lol ^

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107464]: New comment added

2011-12-30 Thread MediaWiki Mail
NeilK posted a comment on MediaWiki.r107464.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107464#c28700

Commit summary for MediaWiki.r107464:

remove need to add newline at end of input

NeilK's comment:

fixed in r107464

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107654]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r107654 to reverted
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107654

Old status:  new
 New status: reverted

Commit summary for MediaWiki.r107654:

Bump to 0.60 from 
https://raw.github.com/themattharris/tmhOAuth/master/tmhOAuth.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107638]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107638 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107638

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107638:

followup to -r107617 - code style and consistency change

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Mass changes to bugs by Jan Kucera (Kozuch)

2011-12-30 Thread Daniel Friesen
On Fri, 30 Dec 2011 13:14:08 -0800, Chad innocentkil...@gmail.com wrote:

 On Fri, Dec 30, 2011 at 3:51 PM, Helder helder.w...@gmail.com wrote:
 Actually, when we vote for a bug we are not added to its CC list
 (which would cause an email to be sent to everyone already on that
 list), but we get followup messages anyway. This way, the votes can
 also be used for silently watching some bugs without bothering others
 with emails which just say we were added to the CC list...


 Did you know you can disable notifications for cc list changes?
 In fact, we should probably make that the default.

 -Chad

Long as we still get one when our friendly local vandal decides to remove  
us from the Cc list so we can add ourselves back.

-- 
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107662]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r107662 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107662

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107662:

Just requiring Maintenance.php isn't going to help when it's subclassing 
BatchAntiSpoof

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r82273]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r82273 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82273

Old status:  new
 New status: resolved

Commit summary for MediaWiki.r82273:

Moved Skin::makeGlobalVariablesScript() to OutputPage::getJSVars()
* merged script and if ( window.mediaWiki ) block with the one of 
mediaWiki.loader as stated in the doc
* removed dependency of $wgTitle
* the two only calls to this functions are in SemanticForms, but will not 
affect current version of MediaWiki:
** specials/SF_UploadWindow.php: this file is only used before 1.16
** specials/SF_UploadWindow2.php: the call is part of the else branch of a 
method_exists( $wgOut, 'addModules' ) check, which means it's not called 
since 1.17

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107640]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107640 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107640

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107640:

[mediawiki.debug] attempt at fixing off-screen mega wide cells for some queries.
* See also r107610 CR

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107641]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107641 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107641

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107641:

[UploadWizard] Uncaught ReferenceError: wgSiteName is not defined

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107643]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107643 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107643

Old status:  deferred
 New status: ok

Commit summary for MediaWiki.r107643:

Removing file - no longer needed, now that SF requires MW 1.16

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107644]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107644 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107644

Old status:  deferred
 New status: ok

Commit summary for MediaWiki.r107644:

SF_UploadWindow2.php renamed to SF_UploadWindow.php, now that old class (which 
provided compatibility for MW  1.16) is no longer needed

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107645]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107645 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107645

Old status:  ok
 New status: resolved

Commit summary for MediaWiki.r107645:

Followup r107559. Added male aliases for User: to Russian and Hebrew. 
Requested by nikerabbit and reedy.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107647]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107647 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107647

Old status:  deferred
 New status: ok

Commit summary for MediaWiki.r107647:

There is only one class for now upload window - SFUploadWindow

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107651]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107651 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107651

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107651:

[UploadWizard] Uncaught ReferenceError: UploadWizardConfig is not defined

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28701

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class=wikitable
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Krinkle's comment:

Did you test this ? Last I checked browsers insert (if not already) a TBODY 
element in between there

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r95340]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Danny B. changed the status of MediaWiki.r95340 to reverted
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95340

Old status:  ok
 New status: reverted

Commit summary for MediaWiki.r95340:

* (bug 30485) Fixed interference between wikihiero extension and 'wikitable' 
class style

Border  padding settings from the .wikitable class were overriding the rules 
for .mw-hiero-table and .mw-hiero-table td. Added !important on them to make 
sure that those inner styles consistently override whatever generic table cell 
rules might be in play that have the same or greater specificity.
Long-term of course it might be nice to rewrite the whole thing to compose SVG 
and output that. :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106752]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
GrafZahl changed the status of MediaWiki.r106752 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106752#c28702

Old Status: new
 New Status: fixme

Commit summary for MediaWiki.r106752:

Merged FileBackend branch. Manually avoiding merging the many prop-only changes 
SVN likes to sprinkle in (easy to spot from the change list). Did not add 
SwiftFileBackend.php as it still is in development.

GrafZahl's comment:

Breaks a maintenance script:
pre
$ php maintenance/rebuildImages.php --missing
PHP Fatal error:  Call to undefined method LocalRepo::enumFilesInFS() in 
maintenance/rebuildImages.php on line 168
PHP Stack trace:
PHP   1. {main}() maintenance/rebuildImages.php:0
PHP   2. require_once() maintenance/rebuildImages.php:225
PHP   3. ImageBuilder-execute() maintenance/doMaintenance.php:105
PHP   4. ImageBuilder-crawlMissing() maintenance/rebuildImages.php:64
/pre

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103202]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
GrafZahl changed the status of MediaWiki.r103202 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103202#c28703

Old Status: ok
 New Status: fixme

Commit summary for MediaWiki.r103202:

* Factorise common code in ImagePage::delete() and allow normal page deletion 
if $wgUploadMaintenance is true
* Moved $wgUploadMaintenance check after permissions and read only, so that the 
user doesn't think the error is temporary if he both doesn't have the 
permission and $wgUploadMaintenance is true
* Show normal error page when $wgUploadMaintenance and added a message for the 
error title
* Moved watchlist updating to FileDeletForm::execute(), it has nothing to do in 
doDelete() (would also be executed for api requests, etc.)
* Added $user parameter to FileDeletForm::doDelete() to pass the user doing the 
action
* Use WikiPage instead of Article

GrafZahl's comment:

Undefined variable title, when trying to delete a file and changing the 
watched status.

Did you mean code$this-title/code in lines 104 and 106?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107657]: Revision status changed

2011-12-30 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107657 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107657

Old status:  new
 New status: ok

Commit summary for MediaWiki.r107657:

fix tablesorter unit test in ie7.  Add semicolon to end of statement in 
tablesorter class

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added

2011-12-30 Thread MediaWiki Mail
Danny B. posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28704

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class=wikitable
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Danny B.'s comment:

Added complementary rules in r107673.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added

2011-12-30 Thread MediaWiki Mail
Danny B. posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28707

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class=wikitable
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Danny B.'s comment:

Having both is being surely compatible with all browsers supporting 
code/code selector thus staying on the safe side.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106926]: New comment added

2011-12-30 Thread MediaWiki Mail
NeilK posted a comment on MediaWiki.r106926.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106926#c28708

Commit summary for MediaWiki.r106926:

mw.language.parser - mw.jqueryMsg

NeilK's comment:

Important: Revert this change on commons, once deployed

http://commons.wikimedia.org/w/index.php?title=MediaWiki:Common.cssdiff=64610434oldid=64572893


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106926]: New comment added

2011-12-30 Thread MediaWiki Mail
NeilK posted a comment on MediaWiki.r106926.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106926#c28709

Commit summary for MediaWiki.r106926:

mw.language.parser - mw.jqueryMsg

NeilK's comment:

Added scaptrap to this change, not because it requires a config fix, because of 
the above CSS fix needed after push. If there's a better tag for this I don't 
know it

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107613]: New comment added

2011-12-30 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r107613.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107613#c28710

Commit summary for MediaWiki.r107613:

Kill trailing ?, especially if we're arbitarily including them

Reedy's comment:

This is also being upstreamed too, yaaay

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r106926]: New comment added

2011-12-30 Thread MediaWiki Mail
NeilK posted a comment on MediaWiki.r106926.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106926#c28711

Commit summary for MediaWiki.r106926:

mw.language.parser - mw.jqueryMsg

NeilK's comment:

And, this message should be changed in MediaWiki: space. 
http://commons.wikimedia.org/wiki/MediaWiki:Mwe-upwiz-license-custom

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28712

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class=wikitable
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Krinkle's comment:

I tested with only the code..table  tbody  tr ../code version in 
browserstack and works successfully in Chrome, Firefox 3.6+, IE7+ and Opera 
10.5+ (maybe earlier version of Opera too but don't have an older version).

This version does not work in IE6, but does the current version in SVN with 
both also does not work in IE6 (it does not support the code/code child 
selector and skips this selector entirely).

According to the W3 specification user agents must and do wrap tables in tbody 
if no table containers are specified in the document (thead, tbody, tfoot). So 
we're safe there. However, as you mentioned on IRC, this is only true in HTML 
mode.

MediaWiki is in HTML5 by default, but wikis can be put it in XHTML1 mode, and 
in that mode, according to the specification, user agents must not do these 
kind of changes.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107673]: New comment added, and revision status changed

2011-12-30 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r107673 to ok and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107673#c28706

Old Status: new
 New Status: ok

Commit summary for MediaWiki.r107673:

+ complementary tbody involved rules in wikitable definitions for browsers 
which add tbody not only virtually (follow-up to r107669)

Krinkle's comment:

Thx, now it works in Chrome too.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Small-ish gadget project: Bug update gadget

2011-12-30 Thread Rob Moen
I started making this but then I realized I was going to have issues making
the needed cross-domain post requests.
I found BugTender achieved this by routing requests through it's own
proxy.php script.

Here is what I have so far:
http://www.mediawiki.org/wiki/User:Robmoen/bugStatusUpdate.js

Any thoughts for a work around ?

~Rob

On Fri, Dec 30, 2011 at 12:17 PM, Erik Moeller e...@wikimedia.org wrote:

 Hi all,

 in the new tradition of posting little gadget ideas and requests here:


 http://www.mediawiki.org/wiki/Gadget_kitchen/Requests#Automatic_updates_to_pages_with_bug_templates

 This would be helpful for pages which use bug templates like
 [[mw:Template:Tracked]] to inform users about the status of bugs they
 care about. If it's useful and efficient, we could promote it to
 default gadget or site script.

 Any takers? :)

 Cheers,
 Erik

 --
 Erik Möller
 VP of Engineering and Product Development, Wikimedia Foundation

 Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107669]: New comment added

2011-12-30 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28705

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class=wikitable
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Krinkle's comment:

Nice :)

Perhaps we can try with only the code..table  tbody  tr ../code version, 
that one should work in firefox too.

Apparently Firefox has some special thingy that allows styles for code..table 
 tr../code to work also.

(by the way for more info, see 
[http://stackoverflow.com/questions/5568859/why-doesnt-table-tr-td-with-child-selectors-work
 here])

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Small-ish gadget project: Bug update gadget

2011-12-30 Thread Erik Moeller
On Fri, Dec 30, 2011 at 5:15 PM, Rob Moen rm...@wikimedia.org wrote:
 I started making this but then I realized I was going to have issues making
 the needed cross-domain post requests.
 I found BugTender achieved this by routing requests through it's own
 proxy.php script.

 Here is what I have so far:
 http://www.mediawiki.org/wiki/User:Robmoen/bugStatusUpdate.js

Got it to work using JSONP GET requests. Leaving a note on your talk
page with more details.

-- 
Erik Möller
VP of Engineering and Product Development, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r107710]: New comment added

2011-12-30 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r107710.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107710#c28714

Commit summary for MediaWiki.r107710:

Comitting new extension, ServerAdminLog. Meant as a replacement for the 
[[wikitech:Server Admin Log]] and SAL in labsconsole. Still an early work in 
progress.

Johnduhart's comment:

[[wikitech:Server Admin Log]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r107710]: New comment added

2011-12-30 Thread MediaWiki Mail
Johnduhart posted a comment on MediaWiki.r107710.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107710#c28715

Commit summary for MediaWiki.r107710:

Comitting new extension, ServerAdminLog. Meant as a replacement for the 
[[wikitech:Server Admin Log]] and SAL in labsconsole. Still an early work in 
progress.

Johnduhart's comment:

[[wikitech:Server admin log]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview