[Wikitech-l] MediaWiki Workshop: Preparing extensions for MediaWiki 1.19 - 1/13/2012 on #wikimedia-dev
Greetings! Utilizing the model set by Wikimedia staff IRC office hours, MediaWiki.org's WikiProject Extensions is presenting our first MediaWiki Workshops for developers (volunteer and staff). Preparing extensions for MediaWiki 1.19 will be held on 13 January, 2012 at 19:00 UTC in IRC (#wikimedia-dev). This IRC workshop will be an opportunity to find out about changes in MediaWiki 1.19 that may require revisions to extensions or skins. Also an opportunity to ask MediaWiki developers questions regarding extension development. Everyone is invited to attend. Developers interested in serving as extensions or MediaWiki 1.19 experts are encouraged to signup as participants at: http://www.mediawiki.org/wiki/Project:WikiProject_Extensions/MediaWiki_Workshops#MediaWiki_1.19_Experts If there's continued interest / demand, MediaWiki Workshops will typically last one hour, and happen no more than twice a month to present trainings, hold discussions and collaborate on community or WikiProject Extensions projects. Facilitators host the session to introduce any presenters, determine the order of questions, and generally helps to keep things going. Time of day will vary in order to offer people in different parts of the world the opportunity to participate. Future topics will likely include MediaWiki.org documentation, ResourceLouder orientation and workshops similar to our inaugural chat to prepare for each MediaWiki release. More information: http://www.mediawiki.org/wiki/Project:WikiProject_Extensions/MediaWiki_Workshops MediaWiki.org's WikiProject SysAdmins will also likely host similar MediaWiki Workshops to help third-party wiki system administrators. Stay tuned for more information, and chime in at: http://www.mediawiki.org/wiki/Project:WikiProject_SysAdmins/Ideas Look forward to seeing folks next Friday! Please feel free to forward this along to any interested folks. -greg aka varnent PS. Sorry if this is a duplicate - was having listserv problems earlier. --- Gregory Varnum Lead Administrator, WikiQueer Lead, Aequalitas Project @GregVarnum fb.com/GregVarnum ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108200]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108200 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108200 Old status: new New status: ok Commit summary for MediaWiki.r108200: Follow-up r107816: Update forgotten FuzzyBot reference. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108178]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108178 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108178 Old status: deferred New status: ok Commit summary for MediaWiki.r108178: Removed DTUtils::loadMessages() method - no longer needed, since versions of MediaWiki less than 1.16 are no longer being supported ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Pages-logging dump - more information?
Dear list, do you provide more information about the pages-logging dump somewhere? While parsing it we came across some questions that we are trying to clarify: * Why are there only ~40 million logs (at over 450 million revisions)? Which logs does the pages-logging dump / the public logging table (not) contain? (We double-checked the number of logs on the database, using our Toolserver-Account (Logging table).) * Can you give us more information about the TextElement that is defined for logitem in the XML Schema? Definition: element name=text type=mw:TextType/ In pages-logging it sometimes occurs as: text deleted=deleted / How is this being used? Kind regards, Katja Mueller ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108195]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108195 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108195 Old status: new New status: ok Commit summary for MediaWiki.r108195: Correction in the test comment, followup r107824 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108198]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108198 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108198 Old status: new New status: ok Commit summary for MediaWiki.r108198: Make spelling of MasterCard consistent. Spotted by EugeneZelenko https://translatewiki.net/wiki/Thread:Support/MediaWiki:Donate_interface-card-name-mc/en ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108199]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108199 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108199 Old status: new New status: ok Commit summary for MediaWiki.r108199: Consistency tweak: no space between word and ... in English language Spotted by OsamaK https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-wml-continue/en ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108201]: New comment added
Nikerabbit posted a comment on MediaWiki.r108201. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108201#c29039 Commit summary for MediaWiki.r108201: replace hard tabs with spaces Nikerabbit's comment: The ruling practice is to use tabs for indentation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108184]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r108184 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108184#c29040 Old Status: new New Status: fixme Commit summary for MediaWiki.r108184: ResourceLoader: Add an experimental option to move the main module loading queue (the bottom queue) from the bottom of the body up into the head , while still being loaded asynchronously. This makes them load earlier, which should make the page load faster. This is the product of a long discussion on bug 27488 * Added a blocking state to mw.loader . When loading scripts while the document is not ready, the loader will use document.write() if blocking is true, and append to the body or the head if blocking is false. If the document is ready, the loader will always append to the body * Enable blocking mode while loading the top queue, and disable it after. This ensures that modules in the top queue are still loaded in a blocking way as they were before * If $wgResourceLoaderExperimentalAsyncLoading is true, the bottom queue is also loaded in the head, but with blocking mode disabled. Otherwise, it's loaded at the bottom of the body as before * scripts-only and messages-only requests need special treatment: ** in the top queue, they can continue to use script src=... tags because they are blocking ** if the bottom queue is at the bottom of the body (experimental async loading disabled), they can continue to use script src=... tags as before ** if the bottom queue is in the head (experimental async loading enabled), they cannot use script src=... tags, because those would block. Instead, call mw.loader.load() on the load.php URL Nikerabbit's comment: Looks like this is breaking some scripts even when the new global is not set to true. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108212]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108212 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108212 Old status: new New status: ok Commit summary for MediaWiki.r108212: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108217]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r108217. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108217#c29042 Commit summary for MediaWiki.r108217: Updated ChangeLog Santhosh.thottingal's comment: Translatable pages can now be discourages, = discouraged ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108219]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r108219 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108219 Old status: new New status: ok Commit summary for MediaWiki.r108219: Short URL looks like a page tool ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r108203 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29043 Old Status: new New Status: fixme Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Catrope's comment: This is broken, causing codemw.loader::execute Exception thrown by ext.vector.simpleSearch: mw.jqueryMsg is undefined/code on TWN. Will look into fixing it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108217]: New comment added
Nikerabbit posted a comment on MediaWiki.r108217. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108217#c29044 Commit summary for MediaWiki.r108217: Updated ChangeLog Nikerabbit's comment: Yes, I did that in a hurry. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added
Krinkle posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29045 Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Krinkle's comment: I don't see how this is any different than r107556, please revert. The codemediawiki/code module can't have dependencies, and adding it to another random module isn't helping the obvious race condition. And branching Message into a separate module is not a solution in the short term because of backwards compatibility. As I've asked before, what's wrong with modules needing the parser simply adding mediawiki.jqueryMsg as a dependency and using it ? Or if you want it to be available by default, create a mediawiki.jqueryMsg.init module that will extend/overwrite the message prototype and use the parser by default (so that you don;t have to do codemw.jqueryMsg.getMessageFunction( )/code). Either way, this isn't working. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added
Catrope posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29046 Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Catrope's comment: No need for hasty reactions, I'm already fixing this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added
Krinkle posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29047 Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Krinkle's comment: Also, it appears this revision is introducing a regression in the unit tests. pre 6. mediawiki: mw.message mw.messages Message.escaped returns the escaped message Expected: Hello lt;bgt;awesomelt;/bgt; world Result: Hello lt;Bgt;awesomelt;/Bgt; world Diff: Hello lt;bgt;awesomelt;/bgt; lt;Bgt;awesomelt;/Bgt; world /pre It looks like the message is parsed as HTML before it is escaped, this causes tagnames to become uppercase. Although this is not a big problem, there should be no need to parse it before escaping. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added
Krinkle posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29048 Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Krinkle's comment: Alrighty, red blur on the swarm freaked me out.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108215]: New comment added
Krinkle posted a comment on MediaWiki.r108215. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108215#c29049 Commit summary for MediaWiki.r108215: Prevent #firstHeading overriding the language specific h1 height. Ref Bug 30809 Krinkle's comment: If at all possible, we should consider looking for another way. I'm not marking fixme as I don't if it is inevitable in this case (tagging todo instead), but there should be no need for code!important/code in core MediaWiki. Doing so makes future development harder than it needs to be. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added
Catrope posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29050 Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Catrope's comment: Hrmph, the Message prototype is private, so jQueryMsg can't extend it. Maybe I should make it public? Since you're commenting here and responding quite quickly, any chance you could get on IRC? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106556]: Revision status changed
SVG changed the status of MediaWiki.r106556 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106556 Old status: fixme New status: deferred Commit summary for MediaWiki.r106556: Replacing by in a few of most used extensions and renaming Specialphp to ..._body.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108229]: Revision status changed
SVG changed the status of MediaWiki.r108229 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108229 Old status: new New status: ok Commit summary for MediaWiki.r108229: Moretypeos ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added
Siebrand posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29051 Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Siebrand's comment: Lame comment to watch rev: yay! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108203]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r108203 to resolved and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29052
Old Status: fixme
New Status: resolved
Commit summary for MediaWiki.r108203:
Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER
Follow up r107556 and based on the discussions on wikitech-l about this.
mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required.
Add qunit test cases.
Catrope's comment:
I don't know where this came from, but it's gone now. Perhaps that's because
jqueryMsg notices the messages doesn't contain nowiki{{/nowiki and hands it
off to the normal parser in that case (which it probably shouldn't do for HTML
output? This conflation of HTML and non-HTML is a mess, as I remarked earlier).
Marking resolved, tests pass as of r108231.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Rolling towards 1.19... scheduling a code freeze
On 01/02/2012 08:49 AM, Chad wrote: On Sun, Jan 1, 2012 at 12:49 PM, Brion Vibber bvib...@wikimedia.org wrote: I'd like us to plan for a code freeze on trunk -- at least a feature refactoring freeze -- starting within a few days to give us all a chance to tidy up, catch up with code review, and prepare for deployments. +1 I believe we've got some general plans to hit deployment in February; if we hit code slush this week or so that gives some time for everybody to catch up on review, do more thorough testing and -- perhaps most importantly of all -- make sure we have good documentation on what's changed and what needs to be tested and tried out by real humans! Sounds good. Want to say Friday's the date to be feature complete to give people the rest of this week? -Chad Questions about today's freeze (from Niklas, Roan, me in IRC): on what -- all of trunk? core? wmf extensions? So does that mean you have to stop adding features when Friday starts, or ends? i.e. is Friday the first day of the frozen state, or the last day of the non-frozen state? Are we enforcing this in any way within SVN, or are we just agreeing to quickly revert any new features or refactoring commits that come in between now and [date]? -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Rolling towards 1.19... scheduling a code freeze
On Fri, Jan 6, 2012 at 9:38 AM, Sumana Harihareswara suma...@wikimedia.org wrote: Questions about today's freeze (from Niklas, Roan, me in IRC): on what -- all of trunk? core? wmf extensions? Definitely core. Probably should apply to wmf-deployed extensions too. I think non-deployed extensions can continue doing what they're doing. So does that mean you have to stop adding features when Friday starts, or ends? i.e. is Friday the first day of the frozen state, or the last day of the non-frozen state? Let's give until midnight UTC, end of Friday. Are we enforcing this in any way within SVN, or are we just agreeing to quickly revert any new features or refactoring commits that come in between now and [date]? No changes to access -- there's still legit reasons to commit things such as followups, regression fixes and the like. Remember everybody: we're calling this a slush and not an actual freeze. The idea is to at least try and get trunk feature-complete so we can make the push in CR. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r102428]: Revision status changed
Freakolowsky changed the status of MediaWiki.r102428 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102428 Old status: fixme New status: new Commit summary for MediaWiki.r102428: * Small bugfix, has already been fixed in 1.18 and trunk (installer issue: hardcoded NLS_NUMERIC_CHARACTERS) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106807]: Revision status changed
Freakolowsky changed the status of MediaWiki.r106807 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106807 Old status: fixme New status: new Commit summary for MediaWiki.r106807: * backport of r106806 * TESTED install ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108184]: New comment added
Catrope posted a comment on MediaWiki.r108184. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108184#c29053 Commit summary for MediaWiki.r108184: ResourceLoader: Add an experimental option to move the main module loading queue (the bottom queue) from the bottom of the body up into the head , while still being loaded asynchronously. This makes them load earlier, which should make the page load faster. This is the product of a long discussion on bug 27488 * Added a blocking state to mw.loader . When loading scripts while the document is not ready, the loader will use document.write() if blocking is true, and append to the body or the head if blocking is false. If the document is ready, the loader will always append to the body * Enable blocking mode while loading the top queue, and disable it after. This ensures that modules in the top queue are still loaded in a blocking way as they were before * If $wgResourceLoaderExperimentalAsyncLoading is true, the bottom queue is also loaded in the head, but with blocking mode disabled. Otherwise, it's loaded at the bottom of the body as before * scripts-only and messages-only requests need special treatment: ** in the top queue, they can continue to use script src=... tags because they are blocking ** if the bottom queue is at the bottom of the body (experimental async loading disabled), they can continue to use script src=... tags as before ** if the bottom queue is in the head (experimental async loading enabled), they cannot use script src=... tags, because those would block. Instead, call mw.loader.load() on the load.php URL Catrope's comment: This was fixed in r108220 and r108222. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108231]: Revision status changed
Siebrand changed the status of MediaWiki.r108231 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108231 Old status: new New status: ok Commit summary for MediaWiki.r108231: Fix broken oldParser call in r108230 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108236]: Revision status changed
Krinkle changed the status of MediaWiki.r108236 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108236 Old status: new New status: ok Commit summary for MediaWiki.r108236: Followup r108231, remove useless _this ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108207]: New comment added
Reedy posted a comment on MediaWiki.r108207. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108207#c29054 Commit summary for MediaWiki.r108207: revert back to tmhOAuth and add necessary SSL cert file now needed by tmhOAuth Reedy's comment: The missing cert was the problem? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108231]: Revision status changed
Krinkle changed the status of MediaWiki.r108231 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108231 Old status: ok New status: resolved Commit summary for MediaWiki.r108231: Fix broken oldParser call in r108230 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108197]: Revision status changed
Reedy changed the status of MediaWiki.r108197 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108197 Old status: new New status: ok Commit summary for MediaWiki.r108197: Fix grammar in r108154. Spotted by kgh https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Perfcached/en ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108241]: Revision status changed
Hashar changed the status of MediaWiki.r108241 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108241 Old status: new New status: ok Commit summary for MediaWiki.r108241: Add a few @since entries ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96225]: Revision status changed
Reedy changed the status of MediaWiki.r96225 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96225 Old status: new New status: ok Commit summary for MediaWiki.r96225: Do not use replaceafter, per r52735 CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108141]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r108141 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108141#c29055 Old Status: fixme New Status: new Commit summary for MediaWiki.r108141: rewrite getXCFMetaData() to get ride of im identify By reading the file header and unpacking the data, we can avoid shelling out to imagemagick 'identify'. Save up some CPU cycles :D An XCF is made of a canvas of a given width / height, the various layers are applied to it which must fit in the canvas. So we just use the canvas size :-) I do not think we have any usage for channels count, so I have just skip that part. I am not sure it makes any sense when the picture can be made of several layers each using different channels count. Bits per color is always 8 per definition. Grayscale is 0 - 255 and indexed palette is 256 colors at most. XCF spec: http://svn.gnome.org/viewvc/gimp/trunk/devel-docs/xcf.txt?view=markup pack() / unpack() is familiar to perl monkeys Fully reimplements r107351 Hashar's comment: r108248 I just suppressed warnings since I am not willing to handle exceptions thrown by wfUnpack() :-D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106807]: Revision status changed
^demon changed the status of MediaWiki.r106807 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106807 Old status: new New status: resolved Commit summary for MediaWiki.r106807: * backport of r106806 * TESTED install ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102428]: Revision status changed
^demon changed the status of MediaWiki.r102428 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102428 Old status: new New status: resolved Commit summary for MediaWiki.r102428: * Small bugfix, has already been fixed in 1.18 and trunk (installer issue: hardcoded NLS_NUMERIC_CHARACTERS) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99668]: Revision status changed
Reedy changed the status of MediaWiki.r99668 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99668 Old status: new New status: ok Commit summary for MediaWiki.r99668: (bug 31662) - 'CIDR calculator now has results reversed', regression from r88730 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102719]: Revision status changed
^demon changed the status of MediaWiki.r102719 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102719 Old status: fixme New status: ok Commit summary for MediaWiki.r102719: Add test to catch the problem fixed in r102595. Confirmed the test works by removing Test from one of the test file names. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101298]: Revision status changed
Reedy changed the status of MediaWiki.r101298 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101298 Old status: new New status: ok Commit summary for MediaWiki.r101298: Fixed 1.17 compatability issue ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101299]: Revision status changed
Reedy changed the status of MediaWiki.r101299 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101299 Old status: new New status: ok Commit summary for MediaWiki.r101299: Really added the script into version control ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101302]: Revision status changed
Reedy changed the status of MediaWiki.r101302 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101302 Old status: new New status: ok Commit summary for MediaWiki.r101302: Another 1.17 compatibility fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108227]: Revision status changed
Reedy changed the status of MediaWiki.r108227 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108227 Old status: new New status: ok Commit summary for MediaWiki.r108227: Typofix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107450]: Revision status changed
Reedy changed the status of MediaWiki.r107450 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107450 Old status: new New status: ok Commit summary for MediaWiki.r107450: Random eol w/s ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108248]: Revision status changed
^demon changed the status of MediaWiki.r108248 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108248 Old status: new New status: resolved Commit summary for MediaWiki.r108248: XCF: suppress warning on unpack + early exit on error follow r108141 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107310]: Revision status changed
Reedy changed the status of MediaWiki.r107310 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107310 Old status: new New status: ok Commit summary for MediaWiki.r107310: moar w/s ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108141]: New comment added
^demon posted a comment on MediaWiki.r108141. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108141#c29056 Commit summary for MediaWiki.r108141: rewrite getXCFMetaData() to get ride of im identify By reading the file header and unpacking the data, we can avoid shelling out to imagemagick 'identify'. Save up some CPU cycles :D An XCF is made of a canvas of a given width / height, the various layers are applied to it which must fit in the canvas. So we just use the canvas size :-) I do not think we have any usage for channels count, so I have just skip that part. I am not sure it makes any sense when the picture can be made of several layers each using different channels count. Bits per color is always 8 per definition. Grayscale is 0 - 255 and indexed palette is 256 colors at most. XCF spec: http://svn.gnome.org/viewvc/gimp/trunk/devel-docs/xcf.txt?view=markup pack() / unpack() is familiar to perl monkeys Fully reimplements r107351 ^demon's comment: Handled the exception in r108253. If someone wants to add $length for sanity they can. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108253]: Revision status changed
Platonides changed the status of MediaWiki.r108253 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108253 Old status: new New status: ok Commit summary for MediaWiki.r108253: Follow up r108248, r108141: use wfUnpack() so we don't duplicate logic. Could also pass $length for sanity, but someone else can do that ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108234]: New comment added
^demon posted a comment on MediaWiki.r108234. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108234#c29057 Commit summary for MediaWiki.r108234: * RN for r106807 and r102428 (sry 4 delay) ^demon's comment: Shouldn't it be in the changes since 1.17.1 section? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101336]: Revision status changed
^demon changed the status of MediaWiki.r101336 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101336 Old status: new New status: ok Commit summary for MediaWiki.r101336: * Actually made use of getStableRevId() function in some places. * Made RevisionReviewForm::doSubmit() sanity check the rev order when rejecting edits and also made it use timestamp to compare chronology rather than rev_id. WikiPage is used instead of Article. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102619]: Revision status changed
^demon changed the status of MediaWiki.r102619 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102619 Old status: new New status: ok Commit summary for MediaWiki.r102619: * Created FlaggedRevsSetup class with a defineSourcePaths() function to handle setting the file paths of code. This is cleaner and avoids global pollution. Unit tests added for this function. * Moved all setting of API pages (conditional or not) to FlaggedRevsSetup::setAPIModules(). * Moved most efFlaggedRevs* functions to FlaggedRevsSetup class. * Moved unconditional setting of $wgHooks to FlaggedRevsSetup::setUnconditionalHooks(). * Moved '$wgGroupPermissions['bot']['autoreview'] = true;' line down a bit. * Moved '$wgExtensionFunctions[] = 'efLoadFlaggedRevs';' line down near function. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102621]: Revision status changed
^demon changed the status of MediaWiki.r102621 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102621 Old status: new New status: ok Commit summary for MediaWiki.r102621: * Moved setting of $wgAjaxExportList to FlaggedRevsUISetup::defineAjaxFunctions(). * Moved setting of $wgSpecialPageUpdates to FlaggedRevsUISetup::defineSpecialPages(). We don't want to have ab UnreviewedPages query every time updateSpecialPages is run if aren't even using it (and it's also more expensive in the case where $wgFlaggedRevsProtection is on). * Moved FlaggedRevs::ready() function to FlaggedRevsSetup to avoid including the FlaggedRevs class on each request. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102627]: Revision status changed
^demon changed the status of MediaWiki.r102627 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102627 Old status: new New status: ok Commit summary for MediaWiki.r102627: * Moved MW_HTML_FOR_DUMP check to FlaggedRevsUISetup::defineHookHandlers(). We only want to disable the FR page view UI changes, not any backend and parser hook handlers. FR parser variables or includable special pages should still work, and DB related hooks should still trigger. * Moved parser hooks to FlaggedRevsSetup::setConditionalHooks. These are not UI hooks. * Reorganized hook definition order in defineHookHandlers() to group them a bit better. * Added some array type hinting. * A few whitespace and doc tweaks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102760]: Revision status changed
^demon changed the status of MediaWiki.r102760 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102760 Old status: new New status: ok Commit summary for MediaWiki.r102760: * Removed getArticleInstance() and updated callers to use getTitleInstance() directly. * Moved $wgJobClasses code and setUnconditionalHooks() call. * Moved b/c $wgLogActions code to defineLogActionHandlers(). * Minor comment tweaks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104215]: Revision status changed
^demon changed the status of MediaWiki.r104215 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104215 Old status: new New status: ok Commit summary for MediaWiki.r104215: Fixed doFlaggedRevsRevTimestamp() in updater, broken in r99755 and also had the wrong directory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106625]: Revision status changed
^demon changed the status of MediaWiki.r106625 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106625 Old status: new New status: resolved Commit summary for MediaWiki.r106625: * Added proper bypassValidationKey() function to review submission class and removed API hack. * Improved RevisionReviewForm::validationKey by using a per-user temp secret key ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108052]: New comment added
Reedy posted a comment on MediaWiki.r108052. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108052#c29058 Commit summary for MediaWiki.r108052: API module to search pages by coordinate Reedy's comment: $wgMaxGeoSearchRadius at the top is unused, as is $count ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108196]: Revision status changed
^demon changed the status of MediaWiki.r108196 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108196 Old status: new New status: ok Commit summary for MediaWiki.r108196: * Always show 'revreview-editnotice' msg on edit form if the edit can't be automatically reviewed. Also tweaked the message for consistency (also matches edit form review checkbox). * Made editWillBeAutoreviewed() use quickUserCan() for performance. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101316]: Revision status changed
^demon changed the status of MediaWiki.r101316 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101316 Old status: new New status: ok Commit summary for MediaWiki.r101316: * Made $oldFrev a member of RevisionReviewForm and get the tags from it, rather than fetching them in a seperate query. * Removed getRevisionTags(), now unused. * Renamed $oflags - $oldFlags. * Minor comment style fixes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108169]: Revision status changed
Reedy changed the status of MediaWiki.r108169 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108169 Old status: new New status: ok Commit summary for MediaWiki.r108169: Add missing variable. Thanks to Yuryu for bug fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101292]: Revision status changed
^demon changed the status of MediaWiki.r101292 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101292 Old status: new New status: ok Commit summary for MediaWiki.r101292: * Fixed undefined $rc var from r101286 * Made getRevQuality() and revIsFlagged() only need a rev ID * Removed unused $wgUser ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100948]: Revision status changed
^demon changed the status of MediaWiki.r100948 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100948 Old status: new New status: ok Commit summary for MediaWiki.r100948: Hotfix for breaking change of WikiError - Status ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101359]: Revision status changed
^demon changed the status of MediaWiki.r101359 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101359 Old status: new New status: ok Commit summary for MediaWiki.r101359: guessVariant doc and explicit boolean typecast ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103953]: Revision status changed
^demon changed the status of MediaWiki.r103953 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103953 Old status: new New status: resolved Commit summary for MediaWiki.r103953: MFT r103945: use canonical user NS in export, workaround for search prefix bug 31697 and friends ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105009]: Revision status changed
^demon changed the status of MediaWiki.r105009 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105009 Old status: new New status: ok Commit summary for MediaWiki.r105009: Use wfGetIP() instead of WebRequest method that is not defined in this MW version (bug 32754) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107332]: Revision status changed
^demon changed the status of MediaWiki.r107332 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107332 Old status: new New status: ok Commit summary for MediaWiki.r107332: Originally fixed in trunk back in r93677, so no idea why it is still there. Fixes fatal in production ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107541]: Revision status changed
^demon changed the status of MediaWiki.r107541 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107541 Old status: new New status: ok Commit summary for MediaWiki.r107541: 1.18wmf1: Update MarkAsHelpful and MoodBar to trunk state ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104133]: Revision status changed
Reedy changed the status of MediaWiki.r104133 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104133 Old status: new New status: resolved Commit summary for MediaWiki.r104133: add logout link to footer ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106134]: Revision status changed
Reedy changed the status of MediaWiki.r106134 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106134 Old status: new New status: ok Commit summary for MediaWiki.r106134: small spacing issues ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106133]: Revision status changed
Reedy changed the status of MediaWiki.r106133 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106133 Old status: new New status: ok Commit summary for MediaWiki.r106133: remove duplicate variables ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108052]: New comment added
MaxSem posted a comment on MediaWiki.r108052. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108052#c29059 Commit summary for MediaWiki.r108052: API module to search pages by coordinate MaxSem's comment: r108257 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106131]: Revision status changed
Reedy changed the status of MediaWiki.r106131 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106131 Old status: new New status: ok Commit summary for MediaWiki.r106131: modify wgAutoloadClasses array creation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108172]: Revision status changed
^demon changed the status of MediaWiki.r108172 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108172 Old status: new New status: ok Commit summary for MediaWiki.r108172: Branching ShortUrl into 1.18wmf1 for bug 1450 and bug 29827 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108260]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r108260 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108260#c29060 Old Status: new New Status: ok Commit summary for MediaWiki.r108260: Improve RELEASE-NOTES-1.18 for r108045 ^demon's comment: Not perfect, but better :p ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108045]: Revision status changed
^demon changed the status of MediaWiki.r108045 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108045 Old status: new New status: resolved Commit summary for MediaWiki.r108045: * (bug 29102) Upgrade fails Unknown character set: 'mysql4'. Merges r108044 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108259]: Revision status changed
^demon changed the status of MediaWiki.r108259 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108259 Old status: new New status: ok Commit summary for MediaWiki.r108259: release-notes: remove notes for r108203; adding new ones for r108230 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107770]: Revision status changed
^demon changed the status of MediaWiki.r107770 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107770 Old status: new New status: resolved Commit summary for MediaWiki.r107770: (bug 33447) Link to the broken image tracking category from Special:Wantedfiles Also add a note about how if you use a foreign repo, you're going to get plenty false positives. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108160]: Revision status changed
MaxSem changed the status of MediaWiki.r108160 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108160 Old status: new New status: ok Commit summary for MediaWiki.r108160: [Bug 33547] New: Toggling last section in MobileFrontend shows JS error ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108256]: Revision status changed
Reedy changed the status of MediaWiki.r108256 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108256 Old status: new New status: ok Commit summary for MediaWiki.r108256: NULL - null, ping r107199 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108257]: Revision status changed
Reedy changed the status of MediaWiki.r108257 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108257 Old status: new New status: ok Commit summary for MediaWiki.r108257: rm unused vars ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107932]: Revision status changed
Reedy changed the status of MediaWiki.r107932 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107932 Old status: new New status: resolved Commit summary for MediaWiki.r107932: Fix Bug 33384 - database drivers cannot be provided by extension Author: Adam Wight Love the simplicity of this fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108218]: Revision status changed
^demon changed the status of MediaWiki.r108218 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108218 Old status: new New status: ok Commit summary for MediaWiki.r108218: Read the language options from the content language. In case of content language != user language you would get an empty string. Prefix the language options message with the extenaion name to avoid conflicts with core and/or other extension message keys Refine message documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108237]: Revision status changed
^demon changed the status of MediaWiki.r108237 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108237 Old status: new New status: ok Commit summary for MediaWiki.r108237: attempt to get rid of weird error ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108235]: Revision status changed
Krinkle changed the status of MediaWiki.r108235 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108235 Old status: new New status: ok Commit summary for MediaWiki.r108235: Followup r108184: fix loading in Opera. Before, Opera would only begin to render the document after all async scripts were loaded, now it's the other way around (scripts load after the document is ready). This is not an improvement compared to the current situation, but it's not a regression either. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108245]: Revision status changed
^demon changed the status of MediaWiki.r108245 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108245 Old status: new New status: ok Commit summary for MediaWiki.r108245: Bug fix: when an error comes back from the submit api, it's a message token, not a translated message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107455]: Revision status changed
Reedy changed the status of MediaWiki.r107455 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107455 Old status: new New status: ok Commit summary for MediaWiki.r107455: r107451 - Add message to special page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108171]: Revision status changed
^demon changed the status of MediaWiki.r108171 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108171 Old status: new New status: ok Commit summary for MediaWiki.r108171: Add mw-content-ltr/rtl class: fixes bug 33538: Line numbers are outside of left border when using source ... line start= on RTL wikis Also make sure mw-content-ltr/rtl is the same as the dir attribute value. Restrict that value to either ltr or rtl (not sure if rtl really needed; source code is always ltr). Also remove text-align:left; as it can/should be set manually in the source tag. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108042]: Revision status changed
^demon changed the status of MediaWiki.r108042 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108042 Old status: new New status: ok Commit summary for MediaWiki.r108042: deprecated from project - these classes do not seem to be in use by search. they will be removed in the next version together with thier data file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] wikicaptcha on GitHub
Hello Cristian, Kudos to Alex and you for starting the ball rolling on this project. I recommend you to get an account in our repository [1]. Integrating this into ConfirmEdit extension shouldn't be hard. It's the extra features what makes this tricky. This system is interesting for gathering translations, but doesn't work for verifying that the answer is right. How would you verify that? The approach that comes to my mkind is to show both the current captcha plus another, optional, captcha, with a note about how filling that second captcha helps wikisource, and that the answer will be logged with their username/ip. Then dump all answers in a log restricted to captcha-reviewers. 1- http://www.mediawiki.org/wiki/Commit_access#Requesting_commit_access ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106656]: Revision status changed
^demon changed the status of MediaWiki.r106656 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106656 Old status: new New status: ok Commit summary for MediaWiki.r106656: WikimediaMaintenance: add script for getting the job queue length on all wikis ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108261]: Revision status changed
^demon changed the status of MediaWiki.r108261 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108261 Old status: new New status: ok Commit summary for MediaWiki.r108261: Fix mixed whitespace in r107455 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108179]: Revision status changed
^demon changed the status of MediaWiki.r108179 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108179 Old status: new New status: ok Commit summary for MediaWiki.r108179: ServerNames is a space delimited string, not an array. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107222]: Revision status changed
^demon changed the status of MediaWiki.r107222 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107222 Old status: new New status: ok Commit summary for MediaWiki.r107222: Fix conf name. Follow up to r107220. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102370]: Revision status changed
Reedy changed the status of MediaWiki.r102370 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102370 Old status: new New status: ok Commit summary for MediaWiki.r102370: Split AbuseFilter schema updates for SQLite out after briefly talking with MaxSem about the desired course of action. Perhaps later these can be merged back, but this seemed to be the quickest way to get AbuseFilter working with SQLite working for now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107221]: Revision status changed
^demon changed the status of MediaWiki.r107221 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107221 Old status: new New status: ok Commit summary for MediaWiki.r107221: Changes for compatibility with LdapAuthentication 2.0a ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102174]: Revision status changed
Reedy changed the status of MediaWiki.r102174 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102174 Old status: new New status: ok Commit summary for MediaWiki.r102174: Fixed compatibility with 1.17 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Pages-logging dump - more information?
On 06/01/12 10:42, Katja Mueller wrote: Dear list, do you provide more information about the pages-logging dump somewhere? While parsing it we came across some questions that we are trying to clarify: * Why are there only ~40 million logs (at over 450 million revisions)? Which logs does the pages-logging dump / the public logging table (not) contain? (We double-checked the number of logs on the database, using our Toolserver-Account (Logging table).) The logs live at Special:Log Most edits don't produce revisions, although some actions produce both and a log (upload, protect, move...) and others only leave a log entry (such as a block or patrol) * Can you give us more information about the TextElement that is defined forlogitem in the XML Schema? Definition:element name=text type=mw:TextType/ In pages-logging it sometimes occurs as: text deleted=deleted / How is this being used? It's used to hide log entries when they contain personal info. Replaces logtitle and params. It's not used for anything in non-revdeleted entries. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r101991]: Revision status changed
Reedy changed the status of MediaWiki.r101991 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101991 Old status: new New status: ok Commit summary for MediaWiki.r101991: Bug 21788 - allow fuzzy.php to take optional namespace prefix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
