[Wikitech-l] testing keyboards events in Narayam
Hi, We are writing QUnit tests for the Narayam extension and we ran into some trouble simulating JavaScript events. The extension transliterates ASCII Latin characters into characters which are hard to type without installing keyboard layouts, and it's used in some Wikimedia projects. The problem is in the extensions/Narayam/tests/qunit/ext.narayam.rules.tests.js file. It is successful in testing the keyboard layouts that are currently present there, but the same method doesn't work for testing layouts that have to keep a key buffer - to remember the keys that were typed before the last character. This is the case for German, for example, where '~o' is supposed to be converted to 'ö'. It works when we actually type, but if we try to test it using QUnit, it yields an empty string, because by the time we get to the 'o', the '~' is forgotten. Does anybody have an idea on how to solve this? -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113000]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113000 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113000#c31804 Old Status: fixme New Status: new Commit summary for MediaWiki.r113000: Remove invalid language codes from the priority languages. Santhosh.thottingal's comment: Used Language::getLanguageNames in r113005 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] PHP 5.4 has been released
And we will not be able to use them in core for next five years because of shared hosting compatibility. Yay! Shared hosting compatibility is for old branches ;-) Domas ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Bugzilla Weekly Report
Le 05/03/12 04:00, reporter a écrit : Top 5 Bug Resolvers john.next [AT] gmx.com 63 Top proof that this report is useless :-) -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] PHP 5.4 has been released
It's been awhile since I have been at school, But... print 0x00+2 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113000]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113000 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113000 Old status: new New status: resolved Commit summary for MediaWiki.r113000: Remove invalid language codes from the priority languages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113005]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113005 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113005 Old status: new New status: ok Commit summary for MediaWiki.r113005: Use getLanguageNames since fetchLanguageNames is available only in 1.20+ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113007]: Revision status changed
MaxSem changed the status of MediaWiki.r113007 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113007 Old status: new New status: ok Commit summary for MediaWiki.r113007: r112940: Register extension for translatewiki.net. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113004]: Revision status changed
MaxSem changed the status of MediaWiki.r113004 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113004 Old status: new New status: ok Commit summary for MediaWiki.r113004: Ping r113002 - addWikiMsg is your friend ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112993]: Revision status changed
MaxSem changed the status of MediaWiki.r112993 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112993 Old status: new New status: ok Commit summary for MediaWiki.r112993: Bug 34979 - [Regression] PHP fatal error in SpecialWikiSets.php Only build a sorted list of wikis if the set object is valid, otherwise use an empty array ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112988]: New comment added
MaxSem posted a comment on MediaWiki.r112988. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112988#c31805 Commit summary for MediaWiki.r112988: make file an argument, --title is script specific --file did not make that many sense, it is easier to just pass the filename as an argument Call to parent constructor was misplaced, that made the script specific options pretends they were generic maintenance parameters. MaxSem's comment: Use $this-error() instead of manual fwrite() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112982]: Revision status changed
MaxSem changed the status of MediaWiki.r112982 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112982 Old status: new New status: ok Commit summary for MediaWiki.r112982: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113006]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113006 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113006 Old status: deferred New status: ok Commit summary for MediaWiki.r113006: r112940: Consistency tweaks in preparation for adding extension to translatewiki.net * Fix description message key * Fix headers * Remove unused $aliase array ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113008]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113008 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113008 Old status: new New status: ok Commit summary for MediaWiki.r113008: r112932: Consistency tweaks in preparation for adding extension to translatewiki.net * Fix description message key * Fix headers * Remove unused $aliase array ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112822]: Revision status changed
Amire80 changed the status of MediaWiki.r112822 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112822 Old status: new New status: ok Commit summary for MediaWiki.r112822: redo alignement + some comments/TODO No code change ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113010]: Revision status changed
Amire80 changed the status of MediaWiki.r113010 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113010 Old status: new New status: ok Commit summary for MediaWiki.r113010: save some levels of indentation by early exiting ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113013]: Revision status changed
Amire80 changed the status of MediaWiki.r113013 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113013 Old status: new New status: ok Commit summary for MediaWiki.r113013: Bug 18831 always use real name when available Some failed logic made wikibugs to sometime override the real user name with the mail user part. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113011]: Revision status changed
Siebrand changed the status of MediaWiki.r113011 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113011 Old status: new New status: ok Commit summary for MediaWiki.r113011: Removed blacklisting of IE8 on Windows XP. Nobody can reproduce bug 32775 any more. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112936]: Revision status changed
MaxSem changed the status of MediaWiki.r112936 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112936 Old status: new New status: ok Commit summary for MediaWiki.r112936: Added FIXME to formatExpiry() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113016]: New comment added
Hashar posted a comment on MediaWiki.r113016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113016#c31806 Commit summary for MediaWiki.r113016: place holder to test bug 34919 when it is fixed Hashar's comment: Bug 34302 - Add email-verified or email-not-verified class to email options ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112939]: Revision status changed
MaxSem changed the status of MediaWiki.r112939 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112939 Old status: new New status: ok Commit summary for MediaWiki.r112939: [DatabaseBase] Made encodeExpiry() recognize 'infinity' and added a decodeExpiry() function ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113003]: Revision status changed
Amire80 changed the status of MediaWiki.r113003 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113003 Old status: ok New status: resolved Commit summary for MediaWiki.r113003: The message used in r113002 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Stuck category (broken file links)
Hi folks, I created categories in huwiki for pages with broken file links as written on https://bugzilla.wikimedia.org/show_bug.cgi?id=33413#c12 That was 5 days ago: https://hu.wikipedia.org/w/index.php?title=MediaWiki:Broken-file-categoryaction=history The old category is still not divided into the new categories! I tried to wait a few hours, a few days, purge articles and categories several times, but without any result. http://hu.wikipedia.org/wiki/Kateg%C3%B3ria:Hib%C3%A1s_f%C3%A1jlhivatkoz%C3%A1sokat_tartalmaz%C3%B3_lapokhas still 1258 members from various namespaces after 5 days. Only approx. 100 pages have leaked into new categories one by one, very slowly. For example, it has http://hu.wikipedia.org/wiki/Algoritmus. Clicking to this article it shows category Hibás fájlhivatkozásokat tartalmazó szócikkekhttp://hu.wikipedia.org/wiki/Kateg%C3%B3ria:Hib%C3%A1s_f%C3%A1jlhivatkoz%C3%A1sokat_tartalmaz%C3%B3_sz%C3%B3cikkekas expected (hidden category!), but opening this category you wont see this article in it. And so on. How is that possible? -- Bináris Hi. Basically the category will only change the next time the page has a linksupdate. This can happen in the following ways: *Someone edits a page *Someone does a null edit (not a purge) of the page. [aka Open page, change nothing, hit save] *Someone edits a template used on the page. In particular, doing ?action=purge does *not* update the categories that are used on a page. https://bugzilla.wikimedia.org/show_bug.cgi?id=28876 is a bug for making the category change happen quickly. Its on my list of bugs that I think would be nice if they were fixed. Cheers, Bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Stuck category (broken file links)
On Mon, Mar 5, 2012 at 8:49 PM, bawolff bawolff...@gmail.com wrote: Basically the category will only change the next time the page has a linksupdate. This can happen in the following ways: *Someone edits a page *Someone does a null edit (not a purge) of the page. [aka Open page, change nothing, hit save] *Someone edits a template used on the page. In particular, doing ?action=purge does *not* update the categories that are used on a page. Requesting api.php?action=purgetitles=page_nameforcelinkupdate updates categories. https://bugzilla.wikimedia.org/show_bug.cgi?id=28876 is a bug for making the category change happen quickly. Its on my list of bugs that I think would be nice if they were fixed. Cheers, Bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -Liangent ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113021]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113021 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113021 Old status: new New status: ok Commit summary for MediaWiki.r113021: FIx copypaste fail noticed in bug 34967. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113033]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113033 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113033 Old status: new New status: ok Commit summary for MediaWiki.r113033: Remove a redundant i18n file definition. Followup r113032 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112925]: Revision status changed
Reedy changed the status of MediaWiki.r112925 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112925 Old status: new New status: ok Commit summary for MediaWiki.r112925: [SpecialCentralAuth] Fix trailing comma in object literal. This is too much for IE7 too handle. * Fixes: -- (bug 34823) JavaScript error in IE8 on Special:CentralAuth ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113034]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113034 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113034 Old status: new New status: ok Commit summary for MediaWiki.r113034: $groupId is undefined here ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112758]: Revision status changed
Reedy changed the status of MediaWiki.r112758 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112758 Old status: new New status: ok Commit summary for MediaWiki.r112758: Use DerivativeRequest subclass of FauxRequest in order to pass on IP and Agent info for check user and friends ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113039]: Revision status changed
Reedy changed the status of MediaWiki.r113039 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113039 Old status: new New status: ok Commit summary for MediaWiki.r113039: Why is tis empty? Bug 34938 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Database dump of Bugzilla
Just a quick note from an unbiased observer who loves MediaWiki and open-source... Proprietary or not, Atlassian Jira is the best bug-tracker I have ever used, out of about 10 systems. - Very configurable - You can create very simple bug forms for nontechnical users - Plug-in architecture for developing your own features modifying app behavior (see https://plugins.atlassian.com/) - Helpful reporting capabilities that are easy to use - Its database schema is pretty understandable so you can extract data directly - The web interface doesn't do any stupid tricks that break in different browsers If you're considering another bug-tracker, Jira is worth a look. (I have no affiliation with the product or the vendor, except as an end-user.) DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112229]: Revision status changed
Reedy changed the status of MediaWiki.r112229 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112229 Old status: new New status: ok Commit summary for MediaWiki.r112229: May or may not help with bug 34601 UW mispositioned file control - still can't reproduce this on a local install. Force UploadWizard styles to load early there *is* HTML at output time, though it's hidden until some additional styling is applied to it. Sometimes in Chrome some of the HTML flashes briefly without style, which seems to be when we pick up the wrong positioning... this hopefully will avoid that possibility by ensuring the styles are preloaded. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112253]: Revision status changed
Reedy changed the status of MediaWiki.r112253 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112253 Old status: new New status: ok Commit summary for MediaWiki.r112253: * (bug 34652) Fix regression in UploadWizard custom language list Fixes regression in r107641 which removed the server portion of the URL from what's passed into mediawiki.loader.load, causing the relative URL not to be recognized as an absolute includable URL ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112260]: Revision status changed
Reedy changed the status of MediaWiki.r112260 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112260 Old status: new New status: ok Commit summary for MediaWiki.r112260: Use getLocalRefPath() for shell scripts that need a source file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112838]: Revision status changed
Reedy changed the status of MediaWiki.r112838 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112838 Old status: new New status: ok Commit summary for MediaWiki.r112838: Actually enforce the FileBackend name requirements instead of just having a comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113041]: Revision status changed
Hashar changed the status of MediaWiki.r113041 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113041 Old status: new New status: ok Commit summary for MediaWiki.r113041: Synchronise RELEASE-NOTES-1.19 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113042]: Revision status changed
Hashar changed the status of MediaWiki.r113042 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113042 Old status: new New status: ok Commit summary for MediaWiki.r113042: Documentation updates Normalise method returns ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113025]: Revision status changed
Reedy changed the status of MediaWiki.r113025 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113025 Old status: new New status: ok Commit summary for MediaWiki.r113025: Spelling fixes from r113003. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113046]: Revision status changed
Hashar changed the status of MediaWiki.r113046 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113046 Old status: new New status: ok Commit summary for MediaWiki.r113046: Fix minor issue from r112988 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112988]: New comment added
Hashar posted a comment on MediaWiki.r112988. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112988#c31807 Commit summary for MediaWiki.r112988: make file an argument, --title is script specific --file did not make that many sense, it is easier to just pass the filename as an argument Call to parent constructor was misplaced, that made the script specific options pretends they were generic maintenance parameters. Hashar's comment: Done by reedy in follow up r113046. Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112995]: New comment added
Reedy posted a comment on MediaWiki.r112995. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112995#c31808 Commit summary for MediaWiki.r112995: (bug 34922) If rev_parent_id is null, then the character delta displayed on Special:Contributions is wrong. In that case instead just display x bytes. Kind of sticks out, but better than a wrong number (possible alternative is just display no number at all) No release notes since issue introduced in 1.19 and I'm going to tag this commit for merging. Reedy's comment: I know it was already in the code, but should we be using something more like the message ellipsis? Both ChangesList and SpecialContributions are apparently the only things that use ' . . ' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112995]: New comment added
Nikerabbit posted a comment on MediaWiki.r112995. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112995#c31809 Commit summary for MediaWiki.r112995: (bug 34922) If rev_parent_id is null, then the character delta displayed on Special:Contributions is wrong. In that case instead just display x bytes. Kind of sticks out, but better than a wrong number (possible alternative is just display no number at all) No release notes since issue introduced in 1.19 and I'm going to tag this commit for merging. Nikerabbit's comment: Ellipsis doesn't feel right in here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112995]: New comment added
Reedy posted a comment on MediaWiki.r112995. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112995#c31810 Commit summary for MediaWiki.r112995: (bug 34922) If rev_parent_id is null, then the character delta displayed on Special:Contributions is wrong. In that case instead just display x bytes. Kind of sticks out, but better than a wrong number (possible alternative is just display no number at all) No release notes since issue introduced in 1.19 and I'm going to tag this commit for merging. Reedy's comment: I'd agree with you. It just feels weird using this different format for these few cases ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GSOC project Improve our Android application
Hello! On Mon, Mar 5, 2012 at 6:50 PM, Yeshow Lao yesh...@gmail.com wrote: Hello, everybody. I'm a GSOC student from China. With some development experience on Android, I would love to work on this project Improve our Android application -- integrate with SuggestBot to suggest a mobile task to a user.[1.] Awesome! Could somebody tell me some information, please? 1.Where to download the current Android application? I have searched the keyword Android on the wiki, but can not be sure which is the right page in so many result pages. 2.Where to see the source code for current Android application? 3.Where to see documents about this project? http://www.mediawiki.org/wiki/Mobile/PhoneGap/Tutorial has information on how to set it up and where to find the code. We use PhoneGap, so it is primarily a HTML/CSS/JS application. Give it a spin and see how you find it :) 4.Who developed the Android application? Is the developer a GSOC student? And whether will he still work on the project this GSOC? Come to #wikimedia-mobile on IRC to find us :) Wish for your reply. Thanks a lot! Thank you! Hoping to see contributions from you soon :) -- Yuvi Panda T http://yuvi.in/blog ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] diff colors - Chrome bug
Adding the borders to top/bottom is not a good thing though, because long changes result in ugly rendering with lots of parallel lines. I will look into the padding issue. - Trevor On Sat, Mar 3, 2012 at 1:33 AM, Erwin Dokter er...@darcoury.nl wrote: On 03-03-2012 09:35, Erwin Dokter wrote: The red font color was the only conflicting style. The misalignment is apparently a result of Chrome not handling the combined padding of the table cell and diffchange spans that contain one or more Tabs. To be more precise: any left-or right padding or border of the .diffchange will throw off the horizontal alignment in Chrome. The cell padding has no effect. This can be fixed by moving the borders to top/bottom and removing any left/right padding from .diffchange. -- Erwin Dokter __**_ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] diff colors
As I've said eslewhere, using top/bottom borders is a problem with long changes (not shown in his screenshot) and should be avoided. The original design (r112836) had this flaw, and was later fixed (r112853). The spacing issues need attention for sure, I will look at them today. - Trevor On Sat, Mar 3, 2012 at 8:15 PM, Steven Walling steven.wall...@gmail.comwrote: On Thursday, March 1, 2012, Trevor Parscal tpars...@wikimedia.org wrote: I've gone ahead and resolved bug #11374 after committing r112836. Screenshot of new diff styles: https://bugzilla.wikimedia.org/attachment.cgi?id=10148 Brandon and I talked about the colors and the way color-blind people will perceive them - this color set provides the best cross-cultural and accessible approach so far. The design also improves contrast issues and draw attention to the changed portions better than any previous versions. - Trevor I *really* like this design. Much better than the current diff style, and not just for the color blind. ;-) Accentuating changed phrases more strongly and removing color where unnecessary makes it much easier to scan a diff. Just my 2 cents, Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] install php-fss on php 5.3
Hi! Thanks to everyone. Tim, will that work in case of php 5.3? - Yury Katkov On Sun, Mar 4, 2012 at 6:42 AM, Tim Starling tstarl...@wikimedia.orgwrote: On 03/03/12 02:00, Yury Katkov wrote: Hi everyone! I want to install php module php-fss on php5.3 since I heard that it boosts MediaWiki performance a lot. Is it possible to do that? Is it installed on wikipedias? Prior to r82645, FSS was used in the wikitext parser for expanding tags like nowiki and ref. Installing FSS sped up this phase significantly. In MediaWiki 1.18 and later this is no longer the case, that part of the parser was rewritten to be fast whether or not FSS is installed. There are still a few uses of FSS in MediaWiki and its extensions: * Malayalam and Arabic character set normalisation * Chinese and Serbian variant conversion * Parsing edit section links (MWTidy) * Extensions: AbuseFilter, LiquidThreads, FCKeditor and Transliterator You probably won't get enough of a performance benefit to make it worthwhile unless you are using one of the four content languages mentioned above or Transliterator. The installation procedure is the same as any PHP extension, i.e. phpize ./configure make sudo make install -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Van de Bugger posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31811 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Van de Bugger's comment: Feeling adventurous with GPLv3 and PHP 5.3 only features? Please be direct and specific. I am not aware about your troubles with AGLPv3. (Note the A letter in the front.) I am not a PHP guru, and not aware which feature is specific for PHP 5.3. This code works for me, that's enough. If you want something to be fixed, just express in in Basic English. Please find another place for rhetoric exercises, ok? What advantage $egGenderize gives over setting $wgExtraGenderNamespaces directly, which also supports user talk pages? Do not understand what you talking about. The need to set variables before extension setup file is included is frowned upon. What the problem? Either explain or point me where it is explained. Really? Don't you believe? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112925]: New comment added
Duplicatebug posted a comment on MediaWiki.r112925. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112925#c31812 Commit summary for MediaWiki.r112925: [SpecialCentralAuth] Fix trailing comma in object literal. This is too much for IE7 too handle. * Fixes: -- (bug 34823) JavaScript error in IE8 on Special:CentralAuth Duplicatebug's comment: You are in a foreach loop, the removing of that comma removes the comma from each line, which is a bad idea and makes IE not happier. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112931]: New comment added
Van de Bugger posted a comment on MediaWiki.r112931. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112931#c31813 Commit summary for MediaWiki.r112931: Fixed link to extension page; README fixed. Van de Bugger's comment: So, using rXX anywhere in the commit message will be automatically recognized as the revision this one follows up? Ok, I will. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r109848]: New comment added
Duplicatebug posted a comment on MediaWiki.r109848. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109848#c31814 Commit summary for MediaWiki.r109848: Add the new SHA1 revision field to the XML export, add SHA1 field to export-0.6.xsd and fix namespace element from string to integer. Duplicatebug's comment: bug 34963 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112925]: New comment added
Krinkle posted a comment on MediaWiki.r112925. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112925#c31815 Commit summary for MediaWiki.r112925: [SpecialCentralAuth] Fix trailing comma in object literal. This is too much for IE7 too handle. * Fixes: -- (bug 34823) JavaScript error in IE8 on Special:CentralAuth Krinkle's comment: Aha, so this rev should be resolved (made redundant in r112930) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Nikerabbit posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31816 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Nikerabbit's comment: Most of the code around MediaWiki is GPLv2. The license is of course our choice. For example __DIR__ only exists in PHP 5.3.0 onwards. Reading global variables before they are set opens doors to register globals vulnerability. See for example [[Register_globals#Configure_extensions_only_after_their_setup_file_is_included]] Your commenting style is awfully verbose. I cannot figure any reason why comment saying end of file is useful. One more thing. PHP does not need semicolon after if/foreach/while blocks, so the convention is to not use them there. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Nikerabbit posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31817 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Nikerabbit's comment: Meant to say ''your choice''. Obviously everyone takes what suits them best and fits the contraints. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113028]: New comment added
Yuvipanda posted a comment on MediaWiki.r113028. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113028#c31818 Commit summary for MediaWiki.r113028: provide toggle buttons in html for Wikipedia Mobile app Older version of the Wikipedia Mobile app ( 1.3 ) do not use the api and instead request pages in mobile form and strip out the html but do not run the javascript provided in MobileFrontend as a result no toggle buttons are rendered and thus sections cannot be toggled on or off this fix injects these buttons into the html reversing the work in r111733 When usage of the versions of the Wikipedia Mobile app not using the api is low we will want to completely revert this revision Note it was not possible to serve the buttons based on the user agent as some versions of the Wikipedia Mobile app do not serve a special user agent and it is important we do not break toggling functionality for users of these apps Yuvipanda's comment: Just a note - it is needed for 1.1, not 1.3 as mentioned in the JS comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Siebrand posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31819 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Siebrand's comment: Why write this as an extension and not as a proposed patch for core? (That would require a relicense, though) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110520]: New comment added
Elizabeth M Smith posted a comment on MediaWiki.r110520. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110520#c31820 Commit summary for MediaWiki.r110520: AFT5: Fix query-continue support for rating/helpfulness sorting. Refs r110412, stil has a lingering issue with ratings sort. Elizabeth M Smith's comment: the rating for bucket 1 is actually yes or no for did you find what you were looking for since this doesn't use a numerical rating - so a boolean value ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110520]: New comment added
Catrope posted a comment on MediaWiki.r110520. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110520#c31821 Commit summary for MediaWiki.r110520: AFT5: Fix query-continue support for rating/helpfulness sorting. Refs r110412, stil has a lingering issue with ratings sort. Catrope's comment: Aaaah, OK, and I guess this only deals with bucket 1 stuff then. So that makes sense. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112988]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112988 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112988 Old status: new New status: resolved Commit summary for MediaWiki.r112988: make file an argument, --title is script specific --file did not make that many sense, it is easier to just pass the filename as an argument Call to parent constructor was misplaced, that made the script specific options pretends they were generic maintenance parameters. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] diff colors - more tweaking
Hi Erwin, The change to diff blocks is an interesting idea. Could you submit a patch for this? (either on list or in the bug) The different text highlighting style seems more controversial, so it might be better to keep that separate. Rob On Sun, Mar 4, 2012 at 5:32 AM, Erwin Dokter er...@darcoury.nl wrote: Never happy with the first result, I did some more tweaking. There were too many lines and too thick borders. Also, background was not needed. So I removed those and only used a bottom border for .diffchange and gave the cells consistent styling. http://windekind.demon.nl/images/Diffs-2.png -- Erwin Dokter ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113022]: Revision status changed
Krinkle changed the status of MediaWiki.r113022 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113022 Old status: new New status: ok Commit summary for MediaWiki.r113022: TODO about 'class' throwing a fatal error ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GSOC project Improve our Android application
Yeshow Lao yesh...@gmail.com wrote: Hello, everybody. I'm a GSOC student from China. With some development experience on Android, I would love to work on this project Improve our Android application -- integrate with SuggestBot to suggest a mobile task to a user.[1.] Could somebody tell me some information, please? Hello, You will find lots of information about the project from the recent announcement: http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/59033 //Saper ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Van de Bugger posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31822 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Van de Bugger's comment: Why write this as an extension and not as a proposed patch for core? Because (a) Pushing a patch to core even for fixing a bug requires a lot of efforts and time-consuming; this is not a bug but a missed feature and I am not sure how serious it is for core maintainers; (b) Anyway, patch will not be included into 1.18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] diff colors - more tweaking
On 05-03-2012 20:10, Rob Lanphier wrote: Hi Erwin, The change to diff blocks is an interesting idea. Could you submit a patch for this? (either on list or in the bug) The different text highlighting style seems more controversial, so it might be better to keep that separate. Rob I'm not submitting any more patches until there is some consensus. Apparently, my last submission blew up on IRC due to 'complaints' and was reverted as a result. Meanwhile, my current proposal seems to be ignored by those involved, so I'd really like some feedback. My current diff CSS can be found in my vector.css on enwki (http://en.wikipedia.org/wiki/User:Edokter/vector.css). -- Erwin Dokter ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113067]: Revision status changed
Amire80 changed the status of MediaWiki.r113067 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113067 Old status: new New status: ok Commit summary for MediaWiki.r113067: Add missing space. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112995]: New comment added
Bawolff posted a comment on MediaWiki.r112995. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112995#c31823 Commit summary for MediaWiki.r112995: (bug 34922) If rev_parent_id is null, then the character delta displayed on Special:Contributions is wrong. In that case instead just display x bytes. Kind of sticks out, but better than a wrong number (possible alternative is just display no number at all) No release notes since issue introduced in 1.19 and I'm going to tag this commit for merging. Bawolff's comment: Yeah I thought it was odd too... pre [00:35:27] bawolffwhats with all the periods on special:Contribs anyhow? [00:35:37] bawolff. . (+some numb)??? . . /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112979]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r112979. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112979#c31824 Commit summary for MediaWiki.r112979: cache html Jeroen De Dauw's comment: Apparently you can, see r113072 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] diff colors - more tweaking
Erwin, I'm happy to continue working with you on this if you have more ideas. Please don't just give up because the process isn't perfect. It's our responsibility together as a community to continue improving it. I'm sorry if you haven't had a great experience so far with this. I am personally very pleased that someone (like you) is being persistent enough to get this matter some attention. MediaWiki's diff view has been a blight for ages, and I think we are getting really close to something solid. I took your input, as well as that of others, and have submitted r113071 which I feel is the best version yet. See https://bugzilla.wikimedia.org/show_bug.cgi?id=11374#c45 for screenshots of how this looks in a variety of scenarios. - Trevor On Mon, Mar 5, 2012 at 11:30 AM, Erwin Dokter er...@darcoury.nl wrote: On 05-03-2012 20:10, Rob Lanphier wrote: Hi Erwin, The change to diff blocks is an interesting idea. Could you submit a patch for this? (either on list or in the bug) The different text highlighting style seems more controversial, so it might be better to keep that separate. Rob I'm not submitting any more patches until there is some consensus. Apparently, my last submission blew up on IRC due to 'complaints' and was reverted as a result. Meanwhile, my current proposal seems to be ignored by those involved, so I'd really like some feedback. My current diff CSS can be found in my vector.css on enwki ( http://en.wikipedia.org/wiki/**User:Edokter/vector.csshttp://en.wikipedia.org/wiki/User:Edokter/vector.css ). -- Erwin Dokter __**_ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105380]: New comment added
Umherirrender posted a comment on MediaWiki.r105380. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105380#c31825 Commit summary for MediaWiki.r105380: * (bug 32617) Fix for edit summary on section 0 containing a bogus section heading Based on patch posted by Dan Collins: https://bugzilla.wikimedia.org/attachment.cgi?id=9552 with a tweak to avoid breaking a similar case in other sections. Follows up on function extraction test cases added in r105379. Umherirrender's comment: This changes the behaviour of getting section header, when behind the section stands something like spaces or HTML comments. [http://de.wikipedia.org/w/index.php?title=Wikipedia:Hauptseite/Artikel_des_Tages/Chronologie_2012diff=100518531oldid=100470179 example]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113077]: Revision status changed
Reedy changed the status of MediaWiki.r113077 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113077 Old status: new New status: ok Commit summary for MediaWiki.r113077: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105380]: Revision status changed
Umherirrender changed the status of MediaWiki.r105380 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105380 Old status: ok New status: fixme Commit summary for MediaWiki.r105380: * (bug 32617) Fix for edit summary on section 0 containing a bogus section heading Based on patch posted by Dan Collins: https://bugzilla.wikimedia.org/attachment.cgi?id=9552 with a tweak to avoid breaking a similar case in other sections. Follows up on function extraction test cases added in r105379. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103941]: Revision status changed
Umherirrender changed the status of MediaWiki.r103941 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103941 Old status: ok New status: fixme Commit summary for MediaWiki.r103941: (bug 32586) Allow styling of message 'revreview-hist-pending-difflink' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110955]: Revision status changed
Umherirrender changed the status of MediaWiki.r110955 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110955 Old status: ok New status: fixme Commit summary for MediaWiki.r110955: (bug 33374) - 'Deletion log summary not properly truncated' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110520]: New comment added
Elizabeth M Smith posted a comment on MediaWiki.r110520. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110520#c31826 Commit summary for MediaWiki.r110520: AFT5: Fix query-continue support for rating/helpfulness sorting. Refs r110412, stil has a lingering issue with ratings sort. Elizabeth M Smith's comment: Followed up in r113062 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111471]: New comment added
Elizabeth M Smith posted a comment on MediaWiki.r111471. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111471#c31827 Commit summary for MediaWiki.r111471: AFTv5: intermittent commit for developers sync-up Elizabeth M Smith's comment: Followed up in r113082 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113017]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113017 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113017 Old status: new New status: ok Commit summary for MediaWiki.r113017: amend r113016 , that was for bug 34302 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113016]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113016 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113016 Old status: new New status: resolved Commit summary for MediaWiki.r113016: place holder to test bug 34919 when it is fixed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bugzilla Weekly Report
Antoine Musso hashar+...@free.fr writes: Le 05/03/12 04:00, reporter a écrit : Top 5 Bug Resolvers john.next [AT] gmx.com 63 Top proof that this report is useless :-) Obviously we need to improve it so that spammers are removed. Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113084]: New comment added
^demon posted a comment on MediaWiki.r113084. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113084#c31828 Commit summary for MediaWiki.r113084: Removed incorrect svn:executable properties ^demon's comment: Wow, these new code review diffs are SO MUCH NICER than the old ones ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bugzilla Weekly Report
Given that i wrote it 4 years ago and haven't touched it since. I'm amazed that its still running ;) --tomasz On Mon, Mar 5, 2012 at 1:01 PM, Mark A. Hershberger m...@wikimedia.org wrote: Antoine Musso hashar+...@free.fr writes: Le 05/03/12 04:00, reporter a écrit : Top 5 Bug Resolvers john.next [AT] gmx.com 63 Top proof that this report is useless :-) Obviously we need to improve it so that spammers are removed. Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113084]: Revision status changed
Raymond changed the status of MediaWiki.r113084 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113084 Old status: new New status: ok Commit summary for MediaWiki.r113084: Removed incorrect svn:executable properties ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110955]: New comment added
Aaron Schulz posted a comment on MediaWiki.r110955. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110955#c31829 Commit summary for MediaWiki.r110955: (bug 33374) - 'Deletion log summary not properly truncated' Aaron Schulz's comment: Why is *this* revision tagged fixme? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113085]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113085 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113085 Old status: new New status: ok Commit summary for MediaWiki.r113085: Appending a newline at the end of the message results in a much nicer console display ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113084]: New comment added
Hashar posted a comment on MediaWiki.r113084. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113084#c31830 Commit summary for MediaWiki.r113084: Removed incorrect svn:executable properties Hashar's comment: And you haven't seen the wonderful inline comment system that thankfully got reverted in January :-D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] install php-fss on php 5.3
On 06/03/12 04:31, Yury Katkov wrote: Hi! Thanks to everyone. Tim, will that work in case of php 5.3? Yes. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113089]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113089 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113089 Old status: new New status: ok Commit summary for MediaWiki.r113089: * Use local context to get messages * Use Language::userTime() and Language::userDate() instead of Language::time() and Language::date() to display dates with user's preferences ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113088]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113088 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113088 Old status: new New status: ok Commit summary for MediaWiki.r113088: Make RecentChangeTest work by using the same context for expected and actual results. They were failing on my installation because $wgLang-getCode() != $wgContLang-getCode() when the test was called. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] the new dropdown on Special:MovePage
On 04/03/12 14:51, Helder wrote: On Sun, Mar 4, 2012 at 10:43, Bináris wikipo...@gmail.com wrote: 2012/3/4 Amir E. Aharoni amir.ahar...@mail.huji.ac.il Hi, In 1.19 a dropdown was added to Special:MovePage for selecting a namespace. This new feature doesn't disturb me personally, Me disturbs, because I cannot past the target at once, so in some cases this makes things more difficult. That would be solved by resolving this: https://bugzilla.wikimedia.org/show_bug.cgi?id=34848 ( Improve mediawiki.special.movePage.js to remove the namespace name when the user paste the full target name in the field ) Helder But why is the namespace needed at all? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] diff colors - more tweaking
On 05-03-2012 20:51, Trevor Parscal wrote: Erwin, I'm happy to continue working with you on this if you have more ideas. Please don't just give up because the process isn't perfect. It's our responsibility together as a community to continue improving it. I'm sorry if you haven't had a great experience so far with this. I am personally very pleased that someone (like you) is being persistent enough to get this matter some attention. MediaWiki's diff view has been a blight for ages, and I think we are getting really close to something solid. It's just a bit frustrating. Development cycles are long, communication is slow and decentralized. I took your input, as well as that of others, and have submitted r113071 which I feel is the best version yet. See https://bugzilla.wikimedia.org/show_bug.cgi?id=11374#c45 for screenshots of how this looks in a variety of scenarios. That looks very nice. No more diffchange borders then. I hope it still meets the accesability rules. Only thing I would change is make the gray background slightly lighter. Is this planned to be rolled out, or are we waiting for 1.20? (In which case I can update the new diff gadget once the design is done.) -- Erwin Dokter ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New cryptographic random number generator up for review
On 29/02/12 10:09, Antoine Musso wrote: Daniel Friesen wrote: No, no, not a wiki. Let's fork the basic core code we use in MediaWiki (routing code, WebRequest, database code, etc...) and turn it into a framework library that can be shared with other applications. And then use that to write a new blogging engine. I would love to have some part of our code made into a framework then rebase MediaWiki on top of that. We might benefit from it since that would probably mean more developer will know about our code and thus be able to submit patch and hack MediaWiki :-) Some years ago I have asked to factor out some of our code to submit it in PEAR, but: - that repo is too restrictive when it comes to coding style - we did not want to be depending on a third party - will have to maintains our code for other usage we have no interest into. So I have abandoned the PEAR idea. It isn't a too bad idea. Although it may not be easy. I suspect there may be hidden knowledge about the deeper layers inside the front end ones. But forcing those classes to be used standalone, can help make a more robust system. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] diff colors - more tweaking
Erwin, I changed it to from #f2f2f2 to #f3f3f3, which is the same as Vector uses on the sidebar and footer. I know it seems subtle, but it's actually more noticeable than you would expect due to where it falls on a monitor's gamma curve. Any lighter and many people's monitors will render it as white. See r113098 - Trevor On Mon, Mar 5, 2012 at 2:31 PM, Erwin Dokter er...@darcoury.nl wrote: On 05-03-2012 20:51, Trevor Parscal wrote: Erwin, I'm happy to continue working with you on this if you have more ideas. Please don't just give up because the process isn't perfect. It's our responsibility together as a community to continue improving it. I'm sorry if you haven't had a great experience so far with this. I am personally very pleased that someone (like you) is being persistent enough to get this matter some attention. MediaWiki's diff view has been a blight for ages, and I think we are getting really close to something solid. It's just a bit frustrating. Development cycles are long, communication is slow and decentralized. I took your input, as well as that of others, and have submitted r113071 which I feel is the best version yet. See https://bugzilla.wikimedia.**org/show_bug.cgi?id=11374#c45https://bugzilla.wikimedia.org/show_bug.cgi?id=11374#c45for screenshots of how this looks in a variety of scenarios. That looks very nice. No more diffchange borders then. I hope it still meets the accesability rules. Only thing I would change is make the gray background slightly lighter. Is this planned to be rolled out, or are we waiting for 1.20? (In which case I can update the new diff gadget once the design is done.) -- Erwin Dokter __**_ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r1388]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1388 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1388 Old status: new New status: deferred Commit summary for Wikimedia.r1388: Unit tests: Updated default value for order id. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1389]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1389 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1389 Old status: new New status: deferred Commit summary for Wikimedia.r1389: Unit testing: added truncateContributionsTable() for removong records from `civicrm_contribution`. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1390]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1390 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1390 Old status: new New status: deferred Commit summary for Wikimedia.r1390: Unit testing: added invalid response from GlobalCollect. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1391]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1391 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1391 Old status: new New status: deferred Commit summary for Wikimedia.r1391: Unit testing: updated tests since GlobalCollect errors should not mark payments as failed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113001]: New comment added
Tim Starling posted a comment on MediaWiki.r113001. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113001#c31831 Commit summary for MediaWiki.r113001: * Fix for r41340, r96405, r97849: introduce a function which gets the current content language, called Parser::getTargetLanguage() following the ParserOptions terminology, and added doc comments, to improve the chances of a human being able to work out what is going on. Just because a function happens to do the thing you want doesn't mean you should call it. * The language object used for lc() in Parser::braceSubstitution() must match the one used in setFunctionHook() during firstCallInit(). It can't change depending on what message you are parsing. Use $wgContLang like before r97849. Tim Starling's comment: Tagged 1.19 because it is a dependency for r113024. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] the new dropdown on Special:MovePage
On 05/03/12 00:00, Amir E. Aharoni wrote: Hi, In 1.19 a dropdown was added to Special:MovePage for selecting a namespace. This new feature doesn't disturb me personally, but a few users in the Hebrew Wikipedia complained about it, saying that it causes users confusion. I don't have numbers, but the regular followers of the move logs said that in the days since the upgrade there was a higher number of mistakes because of this new feature. I think the feature should be reverted. In the title, h1, links, URLs and lots of other places in MediaWiki, page titles are presented as a single string. This is about the closest thing we have to a title concept in MediaWiki. We have namespace filters in a few places, but the full title is always shown in the results list. This move page feature seems confused about how MediaWiki users think about titles. It would make sense in a wiki engine like Confluence, where page titles are normally abbreviated, but it doesn't make sense in MediaWiki. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Wikisource API and ProofreadPage
Summarizing from elsewhere: Thibaut Horel (User:Zaran) is interested in taking the lead on ProofreadPage work; if you have requests, please coordinate with him. He will be developing a roadmap for the development of that MediaWiki extension soon. Àlex Hinojo (alexhin...@gmail.com) might have requests for the MediaWiki web API (and specifically the ProofreadPage web API) that would be especially helpful for Wikisource, because he is investigating starting a QRpedia project related to Wikisource (still tentative). Gaurav Vaidya (gau...@ggvaidya.com) writes that querying Wikisource-specific bits like ProofreadPage: works pretty well! You need to make an 'imageinfo' query on the multipage image file that the Index page points to to get the number of pages; you can then query for 'Page:ImageFileName.pdf/PageNumber' to get the transcribed content for each page. I'm currently working on a Perl module which handles this automatically, which -- with many more tests -- will hopefully make it to CPAN some day. But the source code is up at Github: https://github.com/gaurav/henderson/tree/develop/WWW-Wikisource -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r1395]: New comment added, and revision status changed
Khorn (WMF) changed the status of Wikimedia.r1395 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1395#c31832 Old Status: new New Status: ok Commit summary for Wikimedia.r1395: Updating styling for recurring contribution view. Khorn (WMF)'s comment: Cool. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1394]: New comment added, and revision status changed
Khorn (WMF) changed the status of Wikimedia.r1394 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1394#c31833 Old Status: new New Status: resolved Commit summary for Wikimedia.r1394: Updating recurring contribution template to display relevant fields. Khorn (WMF)'s comment: OK, when considered in conjunction with r1396 and r1395. By itself, it will cause errors. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
