[MediaWiki-CodeReview] [pywikipedia r9971]: New comment added
Valhallasw posted a comment on pywikipedia.r9971. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9971#c32020 Commit summary for pywikipedia.r9971: Starting the survey for old Python versions. See http://thread.gmane.org/gmane.comp.python.pywikipediabot.general/12473 Valhallasw's comment: Yes, and in a few months someone else removes it, and does this by changing 'output' to 'pass', while keeping the rest of the code in place. Or maybe it will be replaced by a warning 'hey, your python is too old, and we're dropping support for it in 2 months!' Therefore, beauty - or rather: reducing the possibility someone else fucks up your code - is always important, even for pieces of code you /think/ will be short-lived. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113459]: New comment added, and revision status changed
Siebrand changed the status of MediaWiki.r113459 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113459#c32021 Old Status: new New Status: ok Commit summary for MediaWiki.r113459: Messages for Special:NotifyTranslators. Siebrand's comment: Looks like a Send message is missing, but I assume that'll be there later. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9971]: New comment added
Xqt posted a comment on pywikipedia.r9971. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9971#c32022 Commit summary for pywikipedia.r9971: Starting the survey for old Python versions. See http://thread.gmane.org/gmane.comp.python.pywikipediabot.general/12473 Xqt's comment: Bináris, it's a good idea to follow the guiding principles PEP 20 zen of python ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113461]: New comment added
Raymond posted a comment on MediaWiki.r113461. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113461#c32023 Commit summary for MediaWiki.r113461: Bug 34737 - Patch from ThomasPT (Tpt) Raymond's comment: Hi Zaran, please mention the bug summary too in your commit message: Zoom buttons appear sometimes on the image, sometimes in the toolbar after update to MW 1.19 Makes life easier. Thanks :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Secure.w.o in js on wiki sites
Hi, sorry for the late reply. 2012/2/23 Antoine Musso hashar+...@free.fr: Le 17/02/12 13:47, Jérémie Roquet a écrit : The reference in this script is still useful for people that continue to use s.w.o; it shouldn't break anything even if s.w.o is down. What about a 301 redirect from s.w.o to the new URLs so that we can clean up all the references to s.w.o without breaking anything? We really should, personally want, stop using the secure.wikimedia.org domain. Sure, that's exactly why I suggest we redirect s.w.o to the new URLs. Any occurence should be replaced on sight :-) As long as we still provide s.w.o, it seems to me that we shouldn't make it less secure. Best regards, -- Jérémie ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MathJax scalable math rendering update for 1.19
În data de 8 martie 2012, 04:31, Mark A. Hershberger m...@wikimedia.org a scris: Brion Vibber br...@pobox.com writes: Here's a sample page on a test wiki, copied from en.wikipedia: http://leuksman.com/mw/index.php/Alpha_compositing Beautiful. Yes, but... is it just me or it takes at least 5s to load the formulas? I have a pretty decent computer, for people with lower-performance hardware it could easily take dozens of seconds. Strainu ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [pywikipedia r9971]: New comment added
Bináris posted a comment on pywikipedia.r9971. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9971#c32024 Commit summary for pywikipedia.r9971: Starting the survey for old Python versions. See http://thread.gmane.org/gmane.comp.python.pywikipediabot.general/12473 Bináris's comment: Done in r9973, thanks for commenting. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113464]: Revision status changed
Krinkle changed the status of MediaWiki.r113464 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113464 Old status: new New status: ok Commit summary for MediaWiki.r113464: Fix a very stupid copy-paste-caused typo. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110794]: Revision status changed
Krinkle changed the status of MediaWiki.r110794 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110794 Old status: deferred New status: new Commit summary for MediaWiki.r110794: * Update the list of the languages * Make the language to be used determined on server side * Allow extension to enable code editor for certain pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Announcing a new extension - SideBarMenu,
2012/3/8 Kim Eik k...@heldig.org By fixed do you mean the css style position: fixed; ? Yes. An absolutely simple, but effective idea. Really all tools and buttons should have a position:fixed css attribute - particularly when proofreading into wikisource. Recently I registered too into Distributed Proofreaders, they have a specialyzed proofreading interface (while wikisource has in intelligent customization of a general wiki interface) and I saw that once more we rediscovered the wheel, giving to some tools the position:fixed attribute, just as DP does. Alex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to list pages with a parser extension in a corresponding category
Is there a method to list all pages which uses a certain parser extension foo in a kind of auto-Category Pages-using-foo ? This is my #1 most-requested feature for wiki admins. If someone were to implement it, you'd have my undying thanks. :-) DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GUI for Git
Am 08.03.2012 19:25, schrieb Daniel Friesen: I've heard comments that TortoiseGit was sub-standard. It didn't even have support for the index. I put together this awhile ago: https://www.mediawiki.org/wiki/Git_Graphical_User_Interfaces Thanks, I was not aware of the existence of this list. Wonderful! I will try your suggestion. Raimond. signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113482]: Revision status changed
Raymond changed the status of MediaWiki.r113482 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113482 Old status: new New status: reverted Commit summary for MediaWiki.r113482: set remoteExtPath, extensions url might be different, this fixes resource loading issues on labs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113483]: Revision status changed
Raymond changed the status of MediaWiki.r113483 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113483 Old status: new New status: ok Commit summary for MediaWiki.r113483: revert changes accidentally commited in r113482 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Fundraising2011-like banner
I'm interested in displaying a banner similar to the ones found on en.wikipedia.org (and probably *.wikipedia.org) from the Fundraising 2011 campaign. I like the style (thin border, 'close' button) and was wondering where I could find the template for it, or any docs. I hunted around and came up with this page (http://meta.wikimedia.org/wiki/Fundraising_2011 ), but still can't find the templates. Any ideas *core* people? -User:DanielRenfro ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fundraising2011-like banner
Hi, I assume you're using MediaWiki. We use a fairly complex extension for deploying banners across our many sites, called CentralNotice. It's meant for multiple wikis and I can't provide support for setting it up myself, but I can tell you that the banners are made from a template in HTML code. You can take a look at the preferences for one fundraising banner at http://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/viewtemplate=B12_0206_AfricaTest_Jimmy_control I hope this helps a bit. Mono On Fri, Mar 9, 2012 at 10:20 AM, Daniel Renfro dren...@vistaprint.com wrote: I'm interested in displaying a banner similar to the ones found on en.wikipedia.org (and probably *.wikipedia.org) from the Fundraising 2011 campaign. I like the style (thin border, 'close' button) and was wondering where I could find the template for it, or any docs. I hunted around and came up with this page (http://meta.wikimedia.org/wiki/Fundraising_2011 ), but still can't find the templates. Any ideas *core* people? -User:DanielRenfro ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added
Saper posted a comment on MediaWiki.r113487. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32025 Commit summary for MediaWiki.r113487: Handle PostgreSQL transaction errors and improve schema detection * Introduce $wgDebugDBTransactions facility to help figure out what's going on with transactions. Currently PostgreSQL only. PostgresTransactionState can be easily be made more general to trace all sorts of state machinery. * Improve r113408: we don't need to full reconnect on error, rollback is enough. Rolling back breaks search_path, as PostgreSQL can manage sessions settings under transaction therefore we need to improve schema sniffing introduced in r82674 * Introduce few schema handling functions. This could probably be generalized for other databases like DB2 and Oracle. * Fix bug 15816 - Add a switch for SETting the search_path We try to avoid touching search_path at all unless really necessary. Even in this case we append MediaWiki core schema to the front of the list. * No longer add $wgDBmwschema to PostgreSQL role search_path in the installer. This is no longer necessary as setting schema on connect should ReallyWorkNow(tm). * Get rid as much as possible of $wgDBmwschema and bring us one step closer to fix bug 16794 (wgSharedDB support). All references to core MediaWiki schema in PostgreSQL specific code should now use Database::getCoreSchema() unless we know what we are doing. Followup-To: r113408 r82674 Saper's comment: Improved error handling is worth adding in 1.19 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] introduction (community communications for Wikidata)
Hi everyone! I wanted to take a moment to introduce myself. I'm Lydia and just started working for Wikimedia Germany. Some of you might know me from my work in Free Software projects. I'll be a part of the team working on Wikidata (http://meta.wikimedia.org/wiki/Wikidata) - the goal of the project is to create something similar to Wiki Commons for data). It's a huge undertaking for the German and global community. Wikidata is a project I am passionate about and I am even more passionate about doing it right. Doing it right in this case obviously means making sure everyone's input is heard and taken into consideration. My responsibility will be exactly that - working with all of you to make it a successful project. A lot of things concerning how, when and where this will be used in Wikipedia are still up for discussion and decisions need to be found in the community. I will be here to facilitate this. I assume many of you have not heard from me before so let me tell you a bit about myself. I studied computer science at the Karlsruhe Institute of Technology. There I worked on a program to plan robot-assisted laser surgeries on human skulls and wrote my diploma thesis on collaborative and transparent Free Software development. I'm passionate about enabling people to make awesome happen around Free Culture. I've spent most of my spare time in the last 7 years on community work in KDE (http://kde.org). This includes running its mentoring programs, co-founding its community working group, serving on the board of the non-profit behind it and generally making sure everything is running smoothly. I've also helped out other projects occasionally like Kubuntu, VLC/VideoLan and openSUSE in that position. Not long ago I released a free book called Open Advice (http://open-advice.org) that is a collaborative effort to make it easier for people to start contributing to Free Software. You probably know 4 of the authors from around Wikipedia. When it comes to MediaWiki I have done developer engagement for Semantic MediaWiki Plus for the last two years and am on the steering committee of the non-profit behind Semantic MediaWiki. Due to my day only having 24 hours (even if some people claim otherwise) I have not had a chance to get into contributing to Wikipedia. Thankfully that's going to change now. (As a very regular user: Thank you!) For the next days/weeks my focus will be: * collecting ideas/doubts/other input for Wikidata that you already have for me now (I'll work through any existing discussions I can find - if you want to make sure I see something please do send me a link.) * creating some resources to explain the project better * setting up some infrastructure to keep everyone updated on the status and able to contribute * work on collecting input in a structured manner and addressing it together If you have any questions please let me know. I'll be around on the English and German Wikipedia, IRC, XMPP, Skype or whatever else you prefer ( http://en.wikipedia.org/wiki/User:Lydia_Pintscher_(WMDE) ). You can subscribe to the Wikidata mailing list at https://lists.wikimedia.org/mailman/listinfo/wikidata-l and join the IRC channel #wikimedia-wikidata on freenode. Cheers Lydia, who is really looking forward to working with you -- Lydia Pintscher - http://about.me/lydia.pintscher Community Communications for Wikidata Wikimedia Deutschland e.V. Eisenacher Straße 2 10777 Berlin www.wikimedia.de Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/681/51985. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] introduction (community communications for Wikidata)
Welcome Lydia! Happy to see you on doing great work for Wiki Data @WMDE. Best Alolita __ Alolita Sharma Wikimedia Foundation - Reply message - From: Lydia Pintscher lydia.pintsc...@wikimedia.de To: foundatio...@lists.wikimedia.org, wikidat...@lists.wikimedia.org, wikitech-l@lists.wikimedia.org Subject: [Wikitech-l] introduction (community communications for Wikidata) Date: Fri, Mar 9, 2012 9:13 am Hi everyone! I wanted to take a moment to introduce myself. I'm Lydia and just started working for Wikimedia Germany. Some of you might know me from my work in Free Software projects. I'll be a part of the team working on Wikidata (http://meta.wikimedia.org/wiki/Wikidata) - the goal of the project is to create something similar to Wiki Commons for data). It's a huge undertaking for the German and global community. Wikidata is a project I am passionate about and I am even more passionate about doing it right. Doing it right in this case obviously means making sure everyone's input is heard and taken into consideration. My responsibility will be exactly that - working with all of you to make it a successful project. A lot of things concerning how, when and where this will be used in Wikipedia are still up for discussion and decisions need to be found in the community. I will be here to facilitate this. I assume many of you have not heard from me before so let me tell you a bit about myself. I studied computer science at the Karlsruhe Institute of Technology. There I worked on a program to plan robot-assisted laser surgeries on human skulls and wrote my diploma thesis on collaborative and transparent Free Software development. I'm passionate about enabling people to make awesome happen around Free Culture. I've spent most of my spare time in the last 7 years on community work in KDE (http://kde.org). This includes running its mentoring programs, co-founding its community working group, serving on the board of the non-profit behind it and generally making sure everything is running smoothly. I've also helped out other projects occasionally like Kubuntu, VLC/VideoLan and openSUSE in that position. Not long ago I released a free book called Open Advice (http://open-advice.org) that is a collaborative effort to make it easier for people to start contributing to Free Software. You probably know 4 of the authors from around Wikipedia. When it comes to MediaWiki I have done developer engagement for Semantic MediaWiki Plus for the last two years and am on the steering committee of the non-profit behind Semantic MediaWiki. Due to my day only having 24 hours (even if some people claim otherwise) I have not had a chance to get into contributing to Wikipedia. Thankfully that's going to change now. (As a very regular user: Thank you!) For the next days/weeks my focus will be: * collecting ideas/doubts/other input for Wikidata that you already have for me now (I'll work through any existing discussions I can find - if you want to make sure I see something please do send me a link.) * creating some resources to explain the project better * setting up some infrastructure to keep everyone updated on the status and able to contribute * work on collecting input in a structured manner and addressing it together If you have any questions please let me know. I'll be around on the English and German Wikipedia, IRC, XMPP, Skype or whatever else you prefer ( http://en.wikipedia.org/wiki/User:Lydia_Pintscher_(WMDE) ). You can subscribe to the Wikidata mailing list at https://lists.wikimedia.org/mailman/listinfo/wikidata-l and join the IRC channel #wikimedia-wikidata on freenode. Cheers Lydia, who is really looking forward to working with you -- Lydia Pintscher - http://about.me/lydia.pintscher Community Communications for Wikidata Wikimedia Deutschland e.V. Eisenacher Straße 2 10777 Berlin www.wikimedia.de Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/681/51985. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fundraising2011-like banner
2012/3/9 Daniel Renfro dren...@vistaprint.com I'm interested in displaying a banner similar to the ones found on en.wikipedia.org (and probably *.wikipedia.org) from the Fundraising 2011 campaign. I like the style (thin border, 'close' button) and was wondering where I could find the template for it Tell me if I misunderstand you, but if you just need the style, it is stored in stylesheets (CSS). So look at the source of the HTML page, look for class in it, and copy that class to another page; the same lookout should be reproduced. If you want to use it in a non-WMF wiki, you may have to steal :-) the CSS file itself. -- Bináris ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fundraising2011-like banner
Bináris, Yes, that's what I was investigating...but I was hoping there was something easier. I love the internet - it's amazing what you can borrow from other sites without any help. -Daniel -Original Message- From: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] On Behalf Of Bináris Sent: Friday, March 09, 2012 12:36 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Fundraising2011-like banner 2012/3/9 Daniel Renfro dren...@vistaprint.com I'm interested in displaying a banner similar to the ones found on en.wikipedia.org (and probably *.wikipedia.org) from the Fundraising 2011 campaign. I like the style (thin border, 'close' button) and was wondering where I could find the template for it Tell me if I misunderstand you, but if you just need the style, it is stored in stylesheets (CSS). So look at the source of the HTML page, look for class in it, and copy that class to another page; the same lookout should be reproduced. If you want to use it in a non-WMF wiki, you may have to steal :-) the CSS file itself. -- Bináris ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fundraising2011-like banner
2012/3/9 Daniel Renfro dren...@vistaprint.com Bináris, Yes, that's what I was investigating...but I was hoping there was something easier. I love the internet - it's amazing what you can borrow from other sites without any help. I think a CSS class is the template *itself *you are looking for. -- Bináris ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113442]: Revision status changed
MaxSem changed the status of MediaWiki.r113442 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113442 Old status: fixme New status: resolved Commit summary for MediaWiki.r113442: Making show/hide buttons translatable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113488]: Revision status changed
Awjrichards changed the status of MediaWiki.r113488 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113488 Old status: new New status: ok Commit summary for MediaWiki.r113488: Bug 35086 - Expand brokens show bad labels on non-western alphabets ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Minor git update
On Fri, Mar 2, 2012 at 9:07 AM, Chad innocentkil...@gmail.com wrote: Also, mediawiki core is in its final iteration before it begins mirroring as well. I'd encourage people to check it out and see what they think--feedback appreciated before we begin the mirroring process. The repo for that is test/mediawiki/core.git Took a little bit longer than I thought, but core is now mirroring SVN as well. It can be cloned from the mediawiki/core.git repository. If you spot any major problems--let me know, it's not too late to rewrite history. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113444]: New comment added
Awjrichards posted a comment on MediaWiki.r113444. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113444#c32026 Commit summary for MediaWiki.r113444: Followup r113442, using internal message array and escaping button messages Awjrichards's comment: It was suggested by someone else, but regardless, was changed in r113488 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1445]: New comment added, and revision status changed
Khorn (WMF) changed the status of Wikimedia.r1445 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1445#c32027 Old Status: new New Status: ok Commit summary for Wikimedia.r1445: This should be a j for the date format. See r1385. Khorn (WMF)'s comment: Oops: My bad. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1375]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1375 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1375 Old status: new New status: ok Commit summary for Wikimedia.r1375: Converting most queries to follow drupal convention and use token substitution. I left questionable query construction in _civicrm_recurring_globalcollect_update_record() untouched. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1446]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1446 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1446 Old status: new New status: ok Commit summary for Wikimedia.r1446: Removed the line that called for a function that did not exist. Changed $failure_retry_date to $date. Fixes r1375. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] gsoc proposal idea -enhancing CentralNotice Extension
Hi, I am a 3rd year Engineering student from India, I have a few project ideas for gsoc, one is regarding enhancement of the extension : CentralNotice. Here is a brief outline of the new features suggested - Enabling Editing of Banners - Campaigns notifying only specific targeted users - For example, Requesting Users with more than 100 edits in wikipedia but no activity in last 3 months to continue contributing. - Simpler UI-based Banner creation (herehttp://lists.wikimedia.org/pipermail/wikitech-l/2012-March/058765.htmlis a discussion regarding the same) - More Statistics - putting namespace specific notices - Making the extension more usable with respect to needs of Wikimedia and Non-Wikimedia needs However I think many more such features can be added.I would request Ryan Kaldari and Brion Vibber to give their feedback regarding this proposal. I also request Srikanth, who suggested many features mentioned here to comment if I have missed out any important features. -- With Regards Nischay Nahata B.tech 3rd year Department of Information Technology National Institute of Technology, Surathkal IRCnick- nischayn22 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113496]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113496 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113496 Old status: new New status: ok Commit summary for MediaWiki.r113496: (bug 23795) Add parser itself to ParserMakeImageParams hook. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] MathJax scalable math rendering update for 1.19
On Fri, Mar 9, 2012 at 1:48 AM, Strainu strain...@gmail.com wrote: Here's a sample page on a test wiki, copied from en.wikipedia: http://leuksman.com/mw/index.php/Alpha_compositing Yes, but... is it just me or it takes at least 5s to load the formulas? I have a pretty decent computer, for people with lower-performance hardware it could easily take dozens of seconds. For a large page with a lot of equations it can take a little while to finish them all; but in my experience so far, usually by the time I'm scrolling down it's done. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113486]: Revision status changed
Preilly changed the status of MediaWiki.r113486 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113486 Old status: new New status: ok Commit summary for MediaWiki.r113486: center images for wider screens looks strange on wider screens ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added, and revision status changed
Reedy changed the status of MediaWiki.r113487 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32028
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r113487:
Handle PostgreSQL transaction errors and improve schema detection
* Introduce $wgDebugDBTransactions facility to help
figure out what's going on with transactions.
Currently PostgreSQL only.
PostgresTransactionState can be easily be made more general
to trace all sorts of state machinery.
* Improve r113408: we don't need to full reconnect on error,
rollback is enough.
Rolling back breaks search_path, as PostgreSQL
can manage sessions settings under transaction therefore
we need to improve schema sniffing introduced in r82674
* Introduce few schema handling functions. This could
probably be generalized for other databases like DB2 and Oracle.
* Fix bug 15816 - Add a switch for SETting the search_path
We try to avoid touching search_path at all unless
really necessary. Even in this case we append MediaWiki
core schema to the front of the list.
* No longer add $wgDBmwschema to PostgreSQL role search_path
in the installer. This is no longer necessary as
setting schema on connect should ReallyWorkNow(tm).
* Get rid as much as possible of $wgDBmwschema and
bring us one step closer to fix bug 16794 (wgSharedDB
support).
All references to core MediaWiki schema in PostgreSQL
specific code should now use Database::getCoreSchema()
unless we know what we are doing.
Followup-To: r113408 r82674
Reedy's comment:
pg_array_parse:
*You're missing a few extra braces
**On the if( '{}' != $text )
**On if ( '},' == $match[3] )
**On the else
pre
$offset = $this-pg_array_parse( $text, $output[], $limit, $offset+1 );
/pre
That isn't valid syntax, you either want to just use $output, or
$output[$foobar]
You'd also broken UnitTests, but fixed that in r113498
pre
[exec] PHP Fatal error: Call to a member function getCoreSchema() on a
non-object in
/var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/db/DatabasePostgres.php
on line 216
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113501]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113501 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113501 Old status: new New status: ok Commit summary for MediaWiki.r113501: Fix syntax error and indenting from r113487 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1448]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1448 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1448 Old status: new New status: deferred Commit summary for Wikimedia.r1448: The order id value was in the wrong order. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added
Saper posted a comment on MediaWiki.r113487.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32029
Commit summary for MediaWiki.r113487:
Handle PostgreSQL transaction errors and improve schema detection
* Introduce $wgDebugDBTransactions facility to help
figure out what's going on with transactions.
Currently PostgreSQL only.
PostgresTransactionState can be easily be made more general
to trace all sorts of state machinery.
* Improve r113408: we don't need to full reconnect on error,
rollback is enough.
Rolling back breaks search_path, as PostgreSQL
can manage sessions settings under transaction therefore
we need to improve schema sniffing introduced in r82674
* Introduce few schema handling functions. This could
probably be generalized for other databases like DB2 and Oracle.
* Fix bug 15816 - Add a switch for SETting the search_path
We try to avoid touching search_path at all unless
really necessary. Even in this case we append MediaWiki
core schema to the front of the list.
* No longer add $wgDBmwschema to PostgreSQL role search_path
in the installer. This is no longer necessary as
setting schema on connect should ReallyWorkNow(tm).
* Get rid as much as possible of $wgDBmwschema and
bring us one step closer to fix bug 16794 (wgSharedDB
support).
All references to core MediaWiki schema in PostgreSQL
specific code should now use Database::getCoreSchema()
unless we know what we are doing.
Followup-To: r113408 r82674
Saper's comment:
Thanks for fixing those.
Still need to fix updater:
pre
Yeah, thanks for
CREATE SEQUENCE logging_log_id_seq
from within function .
Database returned error 1: ERROR: relation logging_log_id_seq already
exists
Backtrace:
#0 /usr/home/saper/public_html/pg/w/includes/db/DatabasePostgres.php(332):
DatabaseBase-reportQueryError('ERROR: relatio...', 1, 'CREATE SEQUENCE...',
'', false)
#1 /usr/home/saper/public_html/pg/w/includes/db/Database.php(906):
DatabasePostgres-reportQueryError('ERROR: relatio...', 1, 'CREATE
SEQUENCE...', '', false)
#2
/usr/home/saper/public_html/pg/w/includes/installer/PostgresUpdater.php(393):
DatabaseBase-query('CREATE SEQUENCE...')
#3 [internal function]: PostgresUpdater-addSequence('logging_log_id_...')
#4
/usr/home/saper/public_html/pg/w/includes/installer/DatabaseUpdater.php(281):
call_user_func_array(Array, Array)
#5
/usr/home/saper/public_html/pg/w/includes/installer/DatabaseUpdater.php(244):
DatabaseUpdater-runUpdates(Array, false)
#6 /usr/home/saper/public_html/pg/w/maintenance/update.php(121):
DatabaseUpdater-doUpdates(Array)
#7 /usr/home/saper/public_html/pg/w/maintenance/doMaintenance.php(105):
UpdateMediaWiki-execute()
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1449]: Revision status changed
Khorn (WMF) changed the status of Wikimedia.r1449 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1449 Old status: new New status: ok Commit summary for Wikimedia.r1449: The order id value words were reversed. See r1448. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113500]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113500 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113500 Old status: new New status: ok Commit summary for MediaWiki.r113500: PHP Fatal error: Call to undefined method DatabasePostgres::getCoreSchea() in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/installer/PostgresUpdater.php on line 309 Ping r113487 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How to list pages with a parser extension in a corresponding category
Am 09.03.2012 16:03, schrieb Daniel Barrett: Is there a method to list all pages which uses a certain parser extension foo in a kind of auto-Category Pages-using-foo ? This is my #1 most-requested feature for wiki admins. If someone were to implement it, you'd have my undying thanks. :-) DanB How to add a tracking category to a parser extension tag: see https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/AJAXPoll/AJAXPoll_body.php?r1=112698r2=113504 https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/AJAXPoll/AJAXPoll.php?r1=112135r2=113502 The patch includes a parameter (default = true ) to set or to disable the use of a tracking category. The t-cat name is a MediaWiki system text (here: MediaWiki:Ajaxpoll-tracking-category = Poll ) I will add this feature also to E:RSS and E:WikiArticleFeeds , which I maintain, today signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113500]: New comment added
Aaron Schulz posted a comment on MediaWiki.r113500. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113500#c32030 Commit summary for MediaWiki.r113500: PHP Fatal error: Call to undefined method DatabasePostgres::getCoreSchea() in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/installer/PostgresUpdater.php on line 309 Ping r113487 Aaron Schulz's comment: Maybe the effected code needs some tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] gsoc proposal idea -enhancing CentralNotice Extension
Hello Nischay, I'm on vacation for the next week, but please remind me to follow up on this after I get back on the 19th. At first glance these sound like good ideas, and I would probably be available to mentor on their development. Ryan Kaldari On Mar 9, 2012, at 10:30 AM, nischay nahata nischay...@gmail.com wrote: Hi, I am a 3rd year Engineering student from India, I have a few project ideas for gsoc, one is regarding enhancement of the extension : CentralNotice. Here is a brief outline of the new features suggested - Enabling Editing of Banners - Campaigns notifying only specific targeted users - For example, Requesting Users with more than 100 edits in wikipedia but no activity in last 3 months to continue contributing. - Simpler UI-based Banner creation (herehttp://lists.wikimedia.org/pipermail/wikitech-l/2012-March/058765.htmlis a discussion regarding the same) - More Statistics - putting namespace specific notices - Making the extension more usable with respect to needs of Wikimedia and Non-Wikimedia needs However I think many more such features can be added.I would request Ryan Kaldari and Brion Vibber to give their feedback regarding this proposal. I also request Srikanth, who suggested many features mentioned here to comment if I have missed out any important features. -- With Regards Nischay Nahata B.tech 3rd year Department of Information Technology National Institute of Technology, Surathkal IRCnick- nischayn22 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r1455]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1455. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1455#c32031 Commit summary for Wikimedia.r1455: Part of the problem with not sending the thank you email was that I was pulling the wrong key for an id: contribution_id should have been just id. See r1349. Jpostlethwaite's comment: I am getting this error now: WD thank_you: Sending thank you message failed for contribution (2): [error] 535 Invalid address: I am not sure if this is a bug. I may just not have my data setup properly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113510]: Revision status changed
Amire80 changed the status of MediaWiki.r113510 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113510 Old status: new New status: ok Commit summary for MediaWiki.r113510: follow up r113508 : escaped html tag brackets to make translaters happy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113511]: Revision status changed
Amire80 changed the status of MediaWiki.r113511 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113511 Old status: new New status: ok Commit summary for MediaWiki.r113511: follow up r113502 : escaped html tag brackets to make translaters happy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113512]: Revision status changed
Preilly changed the status of MediaWiki.r113512 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113512 Old status: new New status: ok Commit summary for MediaWiki.r113512: use negative text indent ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113472]: Revision status changed
Preilly changed the status of MediaWiki.r113472 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113472 Old status: new New status: ok Commit summary for MediaWiki.r113472: css cleanup remove :link - taken care of by a rule introduce new lines for readability ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113471]: Revision status changed
Preilly changed the status of MediaWiki.r113471 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113471 Old status: new New status: ok Commit summary for MediaWiki.r113471: cleanup beta_common.css remove trailing whitespace merge definitions remove unused placeholder definitions introduce new lines between definitions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113470]: Revision status changed
Preilly changed the status of MediaWiki.r113470 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113470 Old status: new New status: ok Commit summary for MediaWiki.r113470: jslinted beta_opensearch.js add new line at end remove unused variables remove left over redundant placeholder code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113469]: Revision status changed
Preilly changed the status of MediaWiki.r113469 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113469 Old status: new New status: ok Commit summary for MediaWiki.r113469: search suggestions as list style search suggestions as a list - it's a list so why not use list elements ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1454]: New comment added, and revision status changed
Khorn (WMF) changed the status of Wikimedia.r1454 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1454#c32032 Old Status: new New Status: fixme Commit summary for Wikimedia.r1454: Fixed issue with prepending RECURRING GLOBALCOLLECT to the order id. See r1448. Khorn (WMF)'s comment: This will work for Globalcollect Recurring, but as it's in the main queue consumer it really needs to be a universal answer to this problem. Looking at that now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113465]: Revision status changed
Preilly changed the status of MediaWiki.r113465 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113465 Old status: new New status: ok Commit summary for MediaWiki.r113465: update fixtures with globals ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1455]: New comment added, and revision status changed
Khorn (WMF) changed the status of Wikimedia.r1455 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1455#c32033 Old Status: new New Status: fixme Commit summary for Wikimedia.r1455: Part of the problem with not sending the thank you email was that I was pulling the wrong key for an id: contribution_id should have been just id. See r1349. Khorn (WMF)'s comment: We talked about this in IRC, so I'm putting it here for posterity: pre (12:01:02 PM) K4-713: You can rekey the array before or after you invoke the hook. (12:01:18 PM) K4-713: There is already a precedent for rekeying before the call. (12:01:27 PM) K4-713: On line 361 of [queue2civicrm.module]. (12:02:15 PM) K4-713: It's not necessarily nice, but it should be consistent, and as your module is newer and hooks are made of chicken bones and voodoo, yours is the safer call to change. /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113463]: Revision status changed
Preilly changed the status of MediaWiki.r113463 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463 Old status: new New status: ok Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113499]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113499 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113499 Old status: new New status: ok Commit summary for MediaWiki.r113499: Fix up some documentation weirdness from r113487 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113518]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113518 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113518 Old status: new New status: ok Commit summary for MediaWiki.r113518: No need to create a new Revision object if we already have one available ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] How to add tracking categories to parser extensions [SOLVED]
I just upgraded the extensions I maintain * RSS (render feeds on a wiki page) * WikiArticleFeeds (generate RSS feeds from Wiki pages) * EtherpadLite (you should know that) * AJAXPoll (a very simple and ultra-responsive poll I like very much...) with that feature(*). Please see the code changes (**), if you are interested. It's easy once you know how. (*) adding automatically pages which use the extension to a category with a meaningful name (**) https://www.mediawiki.org/wiki/Special:Code/MediaWiki/author/wikinaut signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113519]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113519 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113519 Old status: new New status: ok Commit summary for MediaWiki.r113519: Let's be consistent and use the same check to show an the deleted version and cascade the parameter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Minor git update
On Fri, Mar 9, 2012 at 11:56 AM, Chad innocentkil...@gmail.com wrote: On Fri, Mar 2, 2012 at 9:07 AM, Chad innocentkil...@gmail.com wrote: Also, mediawiki core is in its final iteration before it begins mirroring as well. I'd encourage people to check it out and see what they think--feedback appreciated before we begin the mirroring process. The repo for that is test/mediawiki/core.git Took a little bit longer than I thought, but core is now mirroring SVN as well. It can be cloned from the mediawiki/core.git repository. If you spot any major problems--let me know, it's not too late to rewrite history. What if our Labs and thus gerrit logins are different then our subversion username? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added, and revision status changed
MaxSem changed the status of MediaWiki.r113517 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32034 Old Status: new New Status: fixme Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. MaxSem's comment: # What if the parse is being performed by a different parser, not $wgParser? Calling parser gets passed as third parameter to the tag hook, use it. # nowiki[[Category:RSS authoring page]]/nowiki is not proper Ennglish. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113516]: New comment added
MaxSem posted a comment on MediaWiki.r113516. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113516#c32035 Commit summary for MediaWiki.r113516: add tracking category feature (enabled by default). Each page using this extensions get automatically the tracking category with MediaWiki:Etherpadlite-tracking-category name (= Etherpad). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. MaxSem's comment: Tracking category name should be something like Paged using Etherpad or something, current name is unclear. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
Wikinaut posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32036 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. Wikinaut's comment: Hi, pls. can you indicate exactly what to change ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
Wikinaut posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32037 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. Wikinaut's comment: I mean, I don't know what you mean by different parser. I am willing to learn, please let me know what I should change, or please, can you change it ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
MaxSem posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32038 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. MaxSem's comment: source lang=php $p = new Parser(); $po = new ParserOptions(); $parser-parse( $text, $title, $po ); /source Tracking category doesn't gets added. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Minor git update
What if our Labs and thus gerrit logins are different then our subversion username? Your shell account name is your svn username. It's linked with your gerrit user name. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to list pages with a parser extension in a corresponding category
How to add a tracking category to a parser extension tag:... Yep, I know about tracking categories. But if there were a way to track ALL parser tag extensions (i.e., what pages they are used on) without modifying their source, that would be better. DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
Wikinaut posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32039 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. Wikinaut's comment: Tracking category doesn't gets added. it does after editing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
Wikinaut posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32040 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. Wikinaut's comment: MaxSem, pls. indicate *exactly* what you would like me to change where in the code. I am willing to learn, but cannot know everything. I have the code running in all of my large wikis without problems. If you think, my code should be changed, I appreciate, that you guide me a little bit (better). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
MaxSem posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32041 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. MaxSem's comment: Rght. Because ordinary editing uses $wgParser. Unlike my example which fails because you always add this category to $wgParser. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
Wikinaut posted a comment on MediaWiki.r113517. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32042 Commit summary for MediaWiki.r113517: add tracking category feature (enabled by default). Each page using this extension get automatically the tracking category with MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page). Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can be assigned. Documentation of the switch is inline and follows on MediaWiki. Wikinaut's comment: You have more experience than I. Please let me know, how I can improve my code (currently, I do not know). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1455]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1455. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1455#c32043 Commit summary for Wikimedia.r1455: Part of the problem with not sending the thank you email was that I was pulling the wrong key for an id: contribution_id should have been just id. See r1349. Jpostlethwaite's comment: This is done in r1456. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1455]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1455 to new URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1455 Old status: fixme New status: new Commit summary for Wikimedia.r1455: Part of the problem with not sending the thank you email was that I was pulling the wrong key for an id: contribution_id should have been just id. See r1349. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [Foundation-l] introduction (community communications for Wikidata)
On Fri, Mar 9, 2012 at 12:36 PM, Kim Bruning k...@bruning.xs4all.nl wrote: http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/Wikidata/ I haven't looked at that in a while. Heh, I wonder what the current status is? Kipcool's the primary maintainer, and I believe it's exclusively used on http://www.omegawiki.org/ at this point (which is still alive, warts and all). -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: https://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113468]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113468 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113468 Old status: new New status: ok Commit summary for MediaWiki.r113468: Use WikiPage::getRevision() instead of another Revision object if the oldid parameter corresponds to the page's latest revision ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113528]: New comment added, and revision status changed
Jeroen De Dauw changed the status of MediaWiki.r113528 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113528#c32044 Old Status: deferred New Status: ok Commit summary for MediaWiki.r113528: fix bug 33594 (timeline parameter timelineposition=today doesn't work) Jeroen De Dauw's comment: _ ok, I failed... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110649]: Revision status changed
Awjrichards changed the status of MediaWiki.r110649 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110649 Old status: new New status: resolved Commit summary for MediaWiki.r110649: DB schema revamp based on discussion with Asher ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110209]: New comment added
Nemo bis posted a comment on MediaWiki.r110209. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110209#c32045 Commit summary for MediaWiki.r110209: [Special:MovePage] Split new title input, fix bug 29454 (byteLimit), namespaceSelector * Two reasons: -- Limit bug: Limit can't be enforced if the two are together because only page_title is limited, the namespace prefix is not part of the title. Plus even then, there is still ambiguity with the various ways to denote namespaces (aliases) and whitespace freedom between namespace, colon and title. -- Extra feature: Now that the two are separate it' s easier for users to move across namespaces as one doesn't have to type, can't make spelling mistakes. Also, in the future we could exclude certain target namespaces that are not possible or not allowed (now one can perfectly submit a request to move from NS_CATEGORY or NS_FILE, only to get a warning on submission). By showing them disabled in the drop down this becomes clearer). * Keeps backwards compatibility for gadgets and permalinks generated by templates on wikis so that they can still pre-set the new title from a url the old way. The new way can also be pre-set from the url, and allows them to be set separately (wpNewTitleNs=10wpNewTitleMain=Infobox) * Gadgets and templates linking to Special:MovePage with a preset target -- Old way (still works): wpNewTitle=Template:Infobox -- New way: wpNewTitleNs=10 (and/or) wpNewTitleMain=Infobox * Fixes bug 29454; Depends on r109990; -- (bug 29454) Enforce byteLimit for page title input on Special:MovePage Nemo bis's comment: Is this to blame for https://bugzilla.wikimedia.org/show_bug.cgi?id=34887 ? En passant, +1 on Siebrand. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113498]: New comment added, and revision status changed
Aaron Schulz changed the status of MediaWiki.r113498 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113498#c32046 Old Status: new New Status: ok Commit summary for MediaWiki.r113498: Fix broken unit tests post r113487 [exec] PHP Fatal error: Call to a member function getCoreSchema() on a non-object in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/db/DatabasePostgres.php on line 216 Aaron Schulz's comment: pre /** * @var DatabaseBase */ protected $mConn = null; /pre DatabaseBase docs are misleading. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110747]: Revision status changed
Awjrichards changed the status of MediaWiki.r110747 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110747 Old status: new New status: ok Commit summary for MediaWiki.r110747: Return to show normal message if the namespace is not in $wmincTestWikiNamespaces, and change order so it's also when the test wiki preference is set to Incubator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112233]: Revision status changed
Awjrichards changed the status of MediaWiki.r112233 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112233 Old status: deferred New status: ok Commit summary for MediaWiki.r112233: follow up r111749 r110692 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110692]: Revision status changed
Awjrichards changed the status of MediaWiki.r110692 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110692 Old status: new New status: resolved Commit summary for MediaWiki.r110692: importing CreatePage extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110807]: Revision status changed
Awjrichards changed the status of MediaWiki.r110807 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110807 Old status: new New status: ok Commit summary for MediaWiki.r110807: Follow-up r100165: * Fixed lack of $db-timestamp() formatting calls * Made a few w/s tweaks (to getAllowedParams, getParamDescription) * Broke some long lines ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113532]: Revision status changed
Raymond changed the status of MediaWiki.r113532 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113532 Old status: new New status: ok Commit summary for MediaWiki.r113532: Typo fix, followup r110807 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110860]: Revision status changed
Awjrichards changed the status of MediaWiki.r110860 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110860 Old status: new New status: ok Commit summary for MediaWiki.r110860: * Support for search overlapping the 180th meridian * Disables search on other globes for now due to lack of a use case ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113517]: New comment added
Jeremyb posted a comment on MediaWiki.r113517.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113517#c32047
Commit summary for MediaWiki.r113517:
add tracking category feature (enabled by default). Each page using this
extension get automatically the tracking category with
MediaWiki:Wikiarticlefeeds-tracking-category name (= RSS authoring page).
Tracking-Cat-Feature can be disabled, or a different MediaWiki message text can
be assigned. Documentation of the switch is inline and follows on MediaWiki.
Jeremyb's comment:
I pointed you to [{{fullurl:Manual:Tag extensions|oldid=503252}}#Example
Manual:Tag extensions#Example] on IRC and you still did not make any attempt at
fixing this yourself. (AFAICT. and you requested a diff)
I made a diff but I'm not sure it's correct (either the MW bits or the php in
general) and you /quit before I finished it.
syntaxhighlight lang=diff
From 1c5adc1e0b16d43591a57bfa78bc0e0f0902d896 Mon Sep 17 00:00:00 2001
From: jeremyb
Date: Fri, 9 Mar 2012 21:43:29 +
Subject: [PATCH] change per CR comments @ r113517 to match
https://www.mediawiki.org/wiki/Manual:Tag_extensions?oldid=503252#Example
---
WikiArticleFeeds.i18n.magic.php |2 +-
WikiArticleFeeds_body.php | 14 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/WikiArticleFeeds.i18n.magic.php b/WikiArticleFeeds.i18n.magic.php
index fb42a71..7299650 100644
--- a/WikiArticleFeeds.i18n.magic.php
+++ b/WikiArticleFeeds.i18n.magic.php
@@ -58,4 +58,4 @@ $magicWords['sr-ec'] = array(
/** Serbian (Latin script) (Srpski (latinica)) */
$magicWords['sr-el'] = array(
'itemtags' = array( 0, 'oznakestavke', 'oznake_stavke' ),
-);
\ No newline at end of file
+);
diff --git a/WikiArticleFeeds_body.php b/WikiArticleFeeds_body.php
index 8880048..98906d1 100644
--- a/WikiArticleFeeds_body.php
+++ b/WikiArticleFeeds_body.php
@@ -2,13 +2,13 @@
class WikiArticleFeeds{
- function feedStart( $text, $params = array() ) {
- global $wgParser, $wgWikiArticleFeedsTrackingCategory;
+ function feedStart( $text, $params = array(), Parser $parser) {
+ global $wgWikiArticleFeedsTrackingCategory;
if ( $wgWikiArticleFeedsTrackingCategory === true ) {
- $wgParser-addTrackingCategory(
'wikiarticlefeeds-tracking-category' );
+ $parser-addTrackingCategory(
'wikiarticlefeeds-tracking-category' );
} elseif ( is_string( $wgWikiArticleFeedsTrackingCategory ) ) {
- $wgParser-addTrackingCategory(
$wgWikiArticleFeedsTrackingCategory );
+ $parser-addTrackingCategory(
$wgWikiArticleFeedsTrackingCategory );
}
return '!-- FEED_START --';
}
@@ -25,13 +25,13 @@ class WikiArticleFeeds{
return ( $text ? '!-- ITEM_TAGS ' . base64_encode( serialize(
$text ) ) . ' --':'' );
}
- function itemTagsFunction( $parser ) {
+ function itemTagsFunction( Parser $parser ) {
$tags = func_get_args();
array_shift( $tags );
return ( !empty( $tags ) ? 'pre@ITEMTAGS@' . base64_encode(
serialize( implode( ',', $tags ) ) ) . '@ITEMTAGS@/pre':'' );
}
- function itemTagsPlaceholderCorrections( $parser, $text ) {
+ function itemTagsPlaceholderCorrections( Parser $parser, $text ) {
$text = preg_replace(
'|pre@ITEMTAGS@([0-9a-zA-Z\\+\\/]+=*)@ITEMTAGS@/pre|',
'!-- ITEM_TAGS $1 --',
@@ -41,7 +41,7 @@ class WikiArticleFeeds{
}
# Sets up the WikiArticleFeeds Parser hooks
- static function wfWikiArticleFeedsSetup( $parser ) {
+ static function wfWikiArticleFeedsSetup( Parser $parser ) {
global $wgWikiArticleFeeds;
$parser-setHook( 'startFeed', array( $wgWikiArticleFeeds,
'feedStart' ) );
--
1.7.2.5
/syntaxhighlight
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110953]: Revision status changed
Awjrichards changed the status of MediaWiki.r110953 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110953 Old status: new New status: ok Commit summary for MediaWiki.r110953: Fixes for r96546 (bug 33167): * Made LegacyLogFormatter try to respect the 'plaintext' parameter. * Changed LogPage::addEntry() to use LogFormatter to get the action text as such calls to LogPage::actionText() are broken. * Added comment to LogPage::actionText(). It's only OK to call this from the legacy log formatter, fetched via the proper factory functions. * Converted CheckUser to using LogFormatter so that cuc_actiontext values work. Eventually, cuc_actiontext should be replaced with new cuc_params, cuc_log_type, and cuc_log_action fields, similar to the RC table. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110962]: Revision status changed
Awjrichards changed the status of MediaWiki.r110962 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110962 Old status: new New status: ok Commit summary for MediaWiki.r110962: Followup r110959: reapply the good parts of r96722: * Drop useless aa_user_id conditions from queries. * Removed the useless and broken behavior of decrementing values in article_feedback_revisions. It was implemented inconsistently and never worked properly for that reason. This makes insertRevisionRating() much simpler * Due to the insertRevisionRating() change. $lastRevision is no longer needed. To properly update the revision delta, though, we still need to look at whether the previous rating's revid matches this one's, and only take that rating into account if it does. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110967]: Revision status changed
Awjrichards changed the status of MediaWiki.r110967 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110967 Old status: new New status: ok Commit summary for MediaWiki.r110967: Followup r110959: reintroduce another good part of r96722 (sort of): add an index on (page_id, user_text, anon_token, revision) so it properly indexes the queries we actually run, and delete the index on (user_id, page_id, revision) because it's not being used ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111118]: Revision status changed
Awjrichards changed the status of MediaWiki.r18 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/18 Old status: new New status: ok Commit summary for MediaWiki.r18: Bug 14447 - Can't log in without logging out ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1455]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1455. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1455#c32048 Commit summary for Wikimedia.r1455: Part of the problem with not sending the thank you email was that I was pulling the wrong key for an id: contribution_id should have been just id. See r1349. Jpostlethwaite's comment: I had never setup the Thank you module. There is no direct link to the Thank you module: http://civicrm.localhost.wikimedia.org/?q=admin/settings/thank_you ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1349]: Revision status changed
Jpostlethwaite changed the status of Wikimedia.r1349 to new URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1349 Old status: fixme New status: new Commit summary for Wikimedia.r1349: Added ability to send emails and log contributions. See r1212. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added
Saper posted a comment on MediaWiki.r113487. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32049 Commit summary for MediaWiki.r113487: Handle PostgreSQL transaction errors and improve schema detection * Introduce $wgDebugDBTransactions facility to help figure out what's going on with transactions. Currently PostgreSQL only. PostgresTransactionState can be easily be made more general to trace all sorts of state machinery. * Improve r113408: we don't need to full reconnect on error, rollback is enough. Rolling back breaks search_path, as PostgreSQL can manage sessions settings under transaction therefore we need to improve schema sniffing introduced in r82674 * Introduce few schema handling functions. This could probably be generalized for other databases like DB2 and Oracle. * Fix bug 15816 - Add a switch for SETting the search_path We try to avoid touching search_path at all unless really necessary. Even in this case we append MediaWiki core schema to the front of the list. * No longer add $wgDBmwschema to PostgreSQL role search_path in the installer. This is no longer necessary as setting schema on connect should ReallyWorkNow(tm). * Get rid as much as possible of $wgDBmwschema and bring us one step closer to fix bug 16794 (wgSharedDB support). All references to core MediaWiki schema in PostgreSQL specific code should now use Database::getCoreSchema() unless we know what we are doing. Followup-To: r113408 r82674 Saper's comment: Repaired in r113487 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added
Saper posted a comment on MediaWiki.r113487. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32050 Commit summary for MediaWiki.r113487: Handle PostgreSQL transaction errors and improve schema detection * Introduce $wgDebugDBTransactions facility to help figure out what's going on with transactions. Currently PostgreSQL only. PostgresTransactionState can be easily be made more general to trace all sorts of state machinery. * Improve r113408: we don't need to full reconnect on error, rollback is enough. Rolling back breaks search_path, as PostgreSQL can manage sessions settings under transaction therefore we need to improve schema sniffing introduced in r82674 * Introduce few schema handling functions. This could probably be generalized for other databases like DB2 and Oracle. * Fix bug 15816 - Add a switch for SETting the search_path We try to avoid touching search_path at all unless really necessary. Even in this case we append MediaWiki core schema to the front of the list. * No longer add $wgDBmwschema to PostgreSQL role search_path in the installer. This is no longer necessary as setting schema on connect should ReallyWorkNow(tm). * Get rid as much as possible of $wgDBmwschema and bring us one step closer to fix bug 16794 (wgSharedDB support). All references to core MediaWiki schema in PostgreSQL specific code should now use Database::getCoreSchema() unless we know what we are doing. Followup-To: r113408 r82674 Saper's comment: er, r113534 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111131]: Revision status changed
Awjrichards changed the status of MediaWiki.r31 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/31 Old status: new New status: ok Commit summary for MediaWiki.r31: AbuseFilter: Do not show the syntax checking / boxes / etc if the user cannot edit. * Resolves bug 20472. * Patch by EdoDodo with modifications. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87365]: New comment added
Dantman posted a comment on MediaWiki.r87365. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87365#c32051 Commit summary for MediaWiki.r87365: commit some ShoutWiki extensions from MediaWiki.org because ^demon has Evil Plans™ for extension pages Dantman's comment: SoftwareVersion What is blatant ShoutWiki specific (absolutely worthless to everyone else) code doing in our generic extensions repo occupying a '''very''' generic extension name? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111145]: Revision status changed
Awjrichards changed the status of MediaWiki.r45 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45 Old status: new New status: ok Commit summary for MediaWiki.r45: ripping apart and urlencoding the path before passing it back to ms5 to deal with \ signs correctly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111182]: Revision status changed
Awjrichards changed the status of MediaWiki.r82 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82 Old status: new New status: resolved Commit summary for MediaWiki.r82: (bug 26684) Deleting a reply and then replying again merges history, restoring causes database error. Patch by Nikola Kovacs, includes some performance tweaks by me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111214]: Revision status changed
Awjrichards changed the status of MediaWiki.r111214 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111214 Old status: new New status: ok Commit summary for MediaWiki.r111214: Small logic cleanups to maybeMakeEditReviewed(). There can be no base ID if there was no prior revision. Only trust 'baseRevId' if 'wpReviewEdit' was given to be safe. Also removed redundant $baseRevId conditional for existing pages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111925]: Revision status changed
Awjrichards changed the status of MediaWiki.r111925 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111925 Old status: new New status: ok Commit summary for MediaWiki.r111925: MFT to 1.19wmf1 r111832 (bug 34421) duplicate Subject / wrong To: headers in mail ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Bump of minimum required PHP version to 5.3 for MediaWiki 1.20
There does not seem to have been a decision made here - is there even a process for making a decision like this? We already have some extension code in production that requires PHP = 5.3 ( https://www.mediawiki.org/wiki/Special:Code/MediaWiki/111691). I assume that's not the case for core, but it seems a slippery road for us to go down allowing code that requires PHP 5.3 into production if we intend to support PHP = 5.2. While we await some sort of decision about this, what is the appropriate thing to do when we see PHP code that's only compatible with PHP = 5.3 in code review? I went ahead and tagged a couple of revisions I saw making use of late static bindings with 'php5.3' and left them as 'new' pending some sort of decision/guidance. Arthur On Thu, Feb 23, 2012 at 10:56 PM, Platonides platoni...@gmail.com wrote: On 23/02/12 22:23, Chad wrote: Under the hood performance improvements Optional garbage collection for cyclic references This is my favorite part of 5.3 3 -Chad You don't need 5.2 incompatible code for that. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
