[MediaWiki-CodeReview] [MediaWiki r113727]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113727 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113727 Old status: new New status: ok Commit summary for MediaWiki.r113727: * (bug 34887) Fix for r100138: make $3 and $4 parameters being substituted correctly in message movepage-moved ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113729]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113729 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113729 Old status: new New status: ok Commit summary for MediaWiki.r113729: Tweak 'vector-footercleanup-transclusion'. Also remove use of strong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107354]: New comment added, and revision status changed
IAlex changed the status of MediaWiki.r107354 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107354#c32108 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r107354: [mediawiki.action.watch.ajax.js] Rewrite using mw.Api and fixes bug 27146 * Use mw.Api and new it's new .watch() as of r107350 * No longer get title from url, use wgPageName instead * No longer simple queryParam check for action in url, now supports wgActionPaths as well. * Simplification and speed up (less back and forth between functions and jQuery-ism). Previously it had $(..) with several .add() calls. Now doing one call. * Uses mw.util.tooltipAccessKeyRegexp instead of local regex * Uses jQuery.fn.text instead of jQuery.fn.html for link text message * Should fix bug 27146 (previously a failed attempt in r82498) * Previousy worked on in r88527, r88511, r78150, r78147 * minor whitespace/comment fix in mediawiki.util.js/mediawiki.page.startup.js IAlex's comment: This causes bug 34972 since wgPageName is not the correct one on special pages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113690]: Revision status changed
Trevor Parscal changed the status of MediaWiki.r113690 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113690 Old status: new New status: ok Commit summary for MediaWiki.r113690: Add tests for list split tree sync ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113726]: Revision status changed
Robmoen changed the status of MediaWiki.r113726 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113726 Old status: new New status: ok Commit summary for MediaWiki.r113726: update opensearch.min.js to latest copy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113730]: Revision status changed
Robmoen changed the status of MediaWiki.r113730 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113730 Old status: new New status: ok Commit summary for MediaWiki.r113730: correct typo in hasClass deal with bad arguments should split on spaces be aware that sometimes an element might not exist in which case use a dummy element not in the dom ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113721]: Revision status changed
Robmoen changed the status of MediaWiki.r113721 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113721 Old status: new New status: ok Commit summary for MediaWiki.r113721: update minified version of toggle.js ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113693]: Revision status changed
Robmoen changed the status of MediaWiki.r113693 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113693 Old status: new New status: ok Commit summary for MediaWiki.r113693: remove unrecognised max-width property turns out this doesn't actually do anything. would help if there was good documentation on viewport viewport by default takes up max width possible ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111362]: Revision status changed
Siebrand changed the status of MediaWiki.r111362 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111362 Old status: new New status: ok Commit summary for MediaWiki.r111362: Made suggestions task use TTMServer ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107354]: New comment added, and revision status changed
IAlex changed the status of MediaWiki.r107354 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107354#c32110 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r107354: [mediawiki.action.watch.ajax.js] Rewrite using mw.Api and fixes bug 27146 * Use mw.Api and new it's new .watch() as of r107350 * No longer get title from url, use wgPageName instead * No longer simple queryParam check for action in url, now supports wgActionPaths as well. * Simplification and speed up (less back and forth between functions and jQuery-ism). Previously it had $(..) with several .add() calls. Now doing one call. * Uses mw.util.tooltipAccessKeyRegexp instead of local regex * Uses jQuery.fn.text instead of jQuery.fn.html for link text message * Should fix bug 27146 (previously a failed attempt in r82498) * Previousy worked on in r88527, r88511, r78150, r78147 * minor whitespace/comment fix in mediawiki.util.js/mediawiki.page.startup.js IAlex's comment: Fixed in r113737. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113556]: Revision status changed
Siebrand changed the status of MediaWiki.r113556 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113556 Old status: new New status: ok Commit summary for MediaWiki.r113556: Make group specific .css/.js pages visible on Special:AllMessages Per request of Der Umherirrende https://translatewiki.net/wiki/Thread:User_talk:Raymond/Keys_auf_Special:AllMessages_f%C3%BCr_group-*.js/.css Pass 1: Extensions running on the WMF cluster ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1474]: Revision status changed
Pgehres (WMF) changed the status of Wikimedia.r1474 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1474 Old status: new New status: ok Commit summary for Wikimedia.r1474: Fixed spelling mistake in watchdog message. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1472]: Revision status changed
Pgehres (WMF) changed the status of Wikimedia.r1472 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1472 Old status: new New status: ok Commit summary for Wikimedia.r1472: Fixed documentation for recurring_normalize_msg(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1471]: Revision status changed
Pgehres (WMF) changed the status of Wikimedia.r1471 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1471 Old status: new New status: ok Commit summary for Wikimedia.r1471: Changed default value for recurring_subscription to be the same as declared default in recurring_process_msg(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112470]: Revision status changed
Siebrand changed the status of MediaWiki.r112470 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112470 Old status: fixme New status: resolved Commit summary for MediaWiki.r112470: Backend logic and storage of language restriction Data (i18n #614) Generic Table and read/store code for metadata of a group. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113229]: Revision status changed
Siebrand changed the status of MediaWiki.r113229 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113229 Old status: new New status: ok Commit summary for MediaWiki.r113229: Deprecating $wgTranslateGroupStructure. The message group tree is now only based on aggregate groups and their subgroups. Cycles not allowed, but one group can have multiple parents and thus occur more than once in the tree in difference places. Will remove the global variable and other related code in later commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113622]: Revision status changed
Siebrand changed the status of MediaWiki.r113622 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113622 Old status: new New status: ok Commit summary for MediaWiki.r113622: Cleanup pass for my pedantic mind :) * Renamed some variable names to more commonly used names * Restructured to avoid duplication * Expanded comments * Whitespace fixes including stylize * Added TODOs for logging and FIXMEs for message group id validation Ping r113032 and r113615 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112814]: Revision status changed
Siebrand changed the status of MediaWiki.r112814 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112814 Old status: new New status: ok Commit summary for MediaWiki.r112814: Reverted the reversion of r112787 in rr112812 and add the missing continue ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112813]: Revision status changed
Siebrand changed the status of MediaWiki.r112813 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112813 Old status: new New status: ok Commit summary for MediaWiki.r112813: Add upper limit for string length to compare, the time taken grows very fast. Mark the function static as it is used as such. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] OAuth
Am 13.03.2012 16:10, schrieb John Erling Blad: Exporting authentication from Mediawiki by OAuth is probably both acceptable and interesting, even if OAuth is said to give a rather weak security. It could be that people are a bit confused about OAuth vs OpenID. Please don't touch or change https://www.mediawiki.org/wiki/Extension:OpenID . It is stable. signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113476]: Revision status changed
Siebrand changed the status of MediaWiki.r113476 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113476 Old status: new New status: ok Commit summary for MediaWiki.r113476: Updating README. Used some approximation when some features could be considered ready ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113623]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113623 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113623 Old status: new New status: ok Commit summary for MediaWiki.r113623: Removed the remaining parts of cookie password stuff, does nothing and no longer used since ages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113578]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113578 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113578 Old status: new New status: ok Commit summary for MediaWiki.r113578: Updated french planet blogs: * Removed no more existing entries * Removed duplicate entries * Updated entries that needed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113720]: Revision status changed
Robmoen changed the status of MediaWiki.r113720 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113720 Old status: new New status: ok Commit summary for MediaWiki.r113720: fix broken toggling tests introduce fixture for the config variable className is not sufficient use hasClass instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113714]: Revision status changed
Robmoen changed the status of MediaWiki.r113714 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113714 Old status: new New status: ok Commit summary for MediaWiki.r113714: update minified javascript copies ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111475]: New comment added
Catrope posted a comment on MediaWiki.r111475. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111475#c32111 Commit summary for MediaWiki.r111475: Updating english messages to use PLURAL for LastModified extension. See r99522. Catrope's comment: This should just work if you add a dependency on mediawiki.jqueryMsg ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113731]: Revision status changed
Robmoen changed the status of MediaWiki.r113731 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113731 Old status: new New status: ok Commit summary for MediaWiki.r113731: Remove leading newline in 'extdist-choose-version'. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111475]: New comment added, and revision status changed
Jpostlethwaite changed the status of MediaWiki.r111475 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111475#c32112 Old Status: fixme New Status: new Commit summary for MediaWiki.r111475: Updating english messages to use PLURAL for LastModified extension. See r99522. Jpostlethwaite's comment: Thanks! That fixed the problem. See r113748. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113518]: New comment added
IAlex posted a comment on MediaWiki.r113518. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113518#c32113 Commit summary for MediaWiki.r113518: No need to create a new Revision object if we already have one available IAlex's comment: codeArticle::$mRevision/code is only set in codeArticle::getOldIDFromRequest()/code and codeArticle::fetchContent()/code, but the latter will call the former before executing the relevant part of code, so codeArticle::getOldIDFromRequest()/code cannot be called with a codeRevision/code object being set. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113734]: Revision status changed
JanGerber changed the status of MediaWiki.r113734 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113734 Old status: new New status: ok Commit summary for MediaWiki.r113734: fixes MediaWikiPlayerSupport bindings updated binding event name to newEmbedPlayerEvent fixed case on getShareIframeSrc event name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113738]: Revision status changed
JanGerber changed the status of MediaWiki.r113738 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113738 Old status: new New status: ok Commit summary for MediaWiki.r113738: added in some missing methods from kaltura branch ( getTextTracks ) fixed getDownload sources to not be dependent on timedText binding add text binding at loader.js time ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] OAuth
On Tue, 13 Mar 2012 04:50:05 -0800, Petr Bena benap...@gmail.com wrote: Hi, it's been almost 4 years since we came with the idea of implementing an OAuth to mediawiki. I think it's time to start. Question now is if it should be a part of core or extension for mediawiki. I myself would rather make it as extension, since there is probably no use for most of installations, except for large wikis. Quote: OAuth provides a standard protocol to negotiate secure access tokens and to provide third-party tools (web or client) with granular access to private resources. This protocol does not reveal usernames or passwords to the third-party tool. Offering OAuth based authorization on Mediawiki wiki's will increase the reusability of its data and spur the creation of an ecosystem of app's around Mediawiki. Is there anyone who is willing to help with this? If there is no one interested in this, or no comments, I would start a new extension called OAuth, which only purpose would be to enable this feature in mediawiki. - We should support more than 'just' OAuth. There are reasons one might want OAuth 1, others might want OAuth 2, someone may come up with a better OAuth 3, or we may come up with a custom auth setup such as Google's application passwords for sites with no ssl. - We need generic code for handling the grouping of permissions that are handed out to applications. - Generic code for revoking applications and specifying new applications. - We need revisions, logs, etc... to all be able to be annotated with information about what application made the change. - We need tools that will allow administrators to block applications and easily and quickly revert large batches of changes made by an application that has gone rogue. Hence OAuth should really be implemented as a combination of core code an extension. The code that annotates revisions, etc... should be implemented in core. Along with permissions grouping. The UI for specifying, revoking, blocking, etc... applications. Perhaps an abstract UI for the visuals of what an Allow / Deny page will look like. Core would then be given a pluggable interface for protocols that allow for authorization of users. An OAuth1 or OAuth2 extension would then be implemented that implements OAuth using that pluggable interface so that OAuth becomes an option for applications. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113753]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113753 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113753 Old status: new New status: ok Commit summary for MediaWiki.r113753: Fix plural in 'backend-fail-maxsize' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113719]: Revision status changed
SPQRobin changed the status of MediaWiki.r113719 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113719 Old status: new New status: ok Commit summary for MediaWiki.r113719: + new language 'vep' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113717]: Revision status changed
Siebrand changed the status of MediaWiki.r113717 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113717 Old status: new New status: ok Commit summary for MediaWiki.r113717: Explained what CTA means for translators who don't know what it is. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113594]: New comment added
Siebrand posted a comment on MediaWiki.r113594. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594#c32114 Commit summary for MediaWiki.r113594: Add definitionFile to work with export.php's ppgettext. Siebrand's comment: Command documentation actually states: pre --ppgettext Group root path for checkout of product. msgmerge will post process on the export result based on the current definitionFile in that location /pre So this change shouldn't result in a fixme, as it is according to the current specification. I'll make a follow-up commit adding a todo. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113594]: Revision status changed
Siebrand changed the status of MediaWiki.r113594 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594 Old status: fixme New status: new Commit summary for MediaWiki.r113594: Add definitionFile to work with export.php's ppgettext. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113594]: New comment added
Nikerabbit posted a comment on MediaWiki.r113594. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594#c32115 Commit summary for MediaWiki.r113594: Add definitionFile to work with export.php's ppgettext. Nikerabbit's comment: Configuration documentation states: ;definitionFile:Use this to define the location of the definition file (with the English source messages) if it does not adhere to the sourcePattern. Path variables are supported. https://www.mediawiki.org/wiki/Help:Extension:Translate/Group_configuration#FILES FileBasedMessageGroups have method called getSourceFilePath() that could perhaps be suitable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113177]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113177 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113177 Old status: fixme New status: reverted Commit summary for MediaWiki.r113177: No need to do a database query when passing an IP address to User::idFromName() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113394]: New comment added
Aaron Schulz posted a comment on MediaWiki.r113394. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113394#c32116 Commit summary for MediaWiki.r113394: * (bug 35014) Fix for r100529: including a special page no longer sets the page's title to the included page Aaron Schulz's comment: Is the commit summary here correct? How does this work? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113132]: Revision status changed
Siebrand changed the status of MediaWiki.r113132 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113132 Old status: fixme New status: new Commit summary for MediaWiki.r113132: Update language bard properly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113518]: New comment added
Krinkle posted a comment on MediaWiki.r113518. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113518#c32117 Commit summary for MediaWiki.r113518: No need to create a new Revision object if we already have one available Krinkle's comment: Nice :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113746]: Revision status changed
Krinkle changed the status of MediaWiki.r113746 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113746 Old status: new New status: ok Commit summary for MediaWiki.r113746: update RELEASE-NOTES-1.20 follow up r113737 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113749]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113749 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113749 Old status: new New status: ok Commit summary for MediaWiki.r113749: Move delcaration of User::$mAllowUsertalk out of the cache variables block since it's not part of it; also reorder the cache variables for consistency. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113647]: New comment added
Aaron Schulz posted a comment on MediaWiki.r113647. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113647#c32118 Commit summary for MediaWiki.r113647: * Put the timer stuff after leading line breaks in debug log entries (mainly for the first call on a request) so that they are placed near the remaing text and not on its own line * Normalise line breaks in the first entry on a web request so that it's consistent with the one for command line requests Aaron Schulz's comment: pre+ $text = preg_replace( '/[^\n]/', $timer . '\0', $text, 1 );/pre Null byte? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112683]: Revision status changed
Siebrand changed the status of MediaWiki.r112683 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112683 Old status: new New status: ok Commit summary for MediaWiki.r112683: Don't rely on wgMemc being a real cache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112690]: Revision status changed
Siebrand changed the status of MediaWiki.r112690 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112690 Old status: new New status: ok Commit summary for MediaWiki.r112690: Google no more ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112691]: Revision status changed
Siebrand changed the status of MediaWiki.r112691 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112691 Old status: new New status: ok Commit summary for MediaWiki.r112691: Don't rely on wgMemc being real cache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113012]: Revision status changed
Siebrand changed the status of MediaWiki.r113012 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113012 Old status: new New status: ok Commit summary for MediaWiki.r113012: Committing nice patch from Siebrand, graphs for reviews/reviewers. Some tweaks and polishing done by myself. Moderately tested. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113668]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113668 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113668 Old status: new New status: ok Commit summary for MediaWiki.r113668: Revert r113650 and reapply r113619 and r113649 with one modification: User::createNew() was missing a DatabaseBase::timestamp() call ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113758]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113758 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113758 Old status: new New status: ok Commit summary for MediaWiki.r113758: moved release notes for r113737 to 1.19 (a 1.19-regression fix) * Follows-up r113746 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113737]: Revision status changed
Krinkle changed the status of MediaWiki.r113737 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113737 Old status: new New status: ok Commit summary for MediaWiki.r113737: User:PleaseStand patch fixes bug 34972 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113394]: New comment added
IAlex posted a comment on MediaWiki.r113394. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113394#c32119 Commit summary for MediaWiki.r113394: * (bug 35014) Fix for r100529: including a special page no longer sets the page's title to the included page IAlex's comment: Yes it is correct, sorry to not have been more explicit. The problem was that codeOutputPage::addWikiText()/code uses code$wgParser/code for the parse operation and thus the codeParserOutput/code is used for the both the parse of the article and the message. The title is set when calling codeOutputPage::addWikiText()/code inside the special page and get set in the codeParserOutput/code used for the parse of the article which in turns will be used for the title of the display. codeMessage::parseAsBlock()/code uses the codeParser/code set in codeMessageCache/code and the conflict won't happen. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113647]: New comment added
IAlex posted a comment on MediaWiki.r113647. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113647#c32120 Commit summary for MediaWiki.r113647: * Put the timer stuff after leading line breaks in debug log entries (mainly for the first call on a request) so that they are placed near the remaing text and not on its own line * Normalise line breaks in the first entry on a web request so that it's consistent with the one for command line requests IAlex's comment: No, it is what is captured by [^\n] in the regexp that would be lost otherwise ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113759]: Revision status changed
Awjrichards changed the status of MediaWiki.r113759 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113759 Old status: new New status: ok Commit summary for MediaWiki.r113759: Logo wasn't set for some actions that asked for confirmation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113755]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113755 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113755 Old status: new New status: ok Commit summary for MediaWiki.r113755: Reverted r113177 per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113751]: New comment added
Brion VIBBER posted a comment on MediaWiki.r113751. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113751#c32121 Commit summary for MediaWiki.r113751: make memcache key valid for the day Brion VIBBER's comment: Avoid using local time for things like this; we might well be fiddling the local timezone around. Consider gmdate() if this is appropriate. Would it make more sense to just expire after a day instead of putting it in the key? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113750]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113750 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113750 Old status: new New status: ok Commit summary for MediaWiki.r113750: French translations were missing $1. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113473]: Revision status changed
Siebrand changed the status of MediaWiki.r113473 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113473 Old status: new New status: ok Commit summary for MediaWiki.r113473: Removing svn:ignore entries that don't make sense anymore ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113233]: Revision status changed
Siebrand changed the status of MediaWiki.r113233 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113233 Old status: new New status: ok Commit summary for MediaWiki.r113233: Removing $wgTranslateGroupStructure ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] StripState question / advice?
I have a parser function #lookup that performs a database query, given a string
key. When a wiki page contains {{#lookup:MyKey}}, the callback function looks
up the associated value and uses StripState to place it into the article:
$parser-setFunctionHook('lookup', 'lookupCallback'));
...
function lookupCallback($parser, $key) {
$value = bigDatabaseQuery($key);
return $parser-insertStripItem($value);
}
This works fine, but when there are many #lookup calls on a single wiki page,
we are making many database calls. So I'd like to collect all the keys from all
the #lookup calls and perform a SINGLE database query where key in ('key1',
'key2', ..., 'keyN'), then call insertStripItem() with each value. I can't
seem to figure out how to architect this.
The callback (lookupCallback) is the ideal place to call insertStripItem with
the looked-up values, since it places the UNIQ string in the right location in
the article. But it also seems to be the only place that I can collect all the
keys for performing the single SQL query. This is a chicken-and-egg problem. I
can't seem to do the SQL query earlier than lookupCallback because if I do,
this logic will run even when #lookup is not present.
Any advice on how to structure this?
Thanks,
DanB
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113751]: New comment added
Preilly posted a comment on MediaWiki.r113751. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113751#c32122 Commit summary for MediaWiki.r113751: make memcache key valid for the day Preilly's comment: I've switched to gmdate in r113760. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113573]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113573 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113573 Old status: new New status: ok Commit summary for MediaWiki.r113573: r113572 in trunk file too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113553]: Revision status changed
Awjrichards changed the status of MediaWiki.r113553 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113553 Old status: new New status: ok Commit summary for MediaWiki.r113553: (bug 35116) Correct API documentation for prop=excerpts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113662]: Revision status changed
Awjrichards changed the status of MediaWiki.r113662 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113662 Old status: ok New status: deferred Commit summary for MediaWiki.r113662: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113760]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113760 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113760 Old status: new New status: ok Commit summary for MediaWiki.r113760: use a GMT/UTC date/time instead of local time/date ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113761]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113761 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113761 Old status: new New status: ok Commit summary for MediaWiki.r113761: 1.19wmf: MFT r113760 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113751]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113751 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113751 Old status: new New status: resolved Commit summary for MediaWiki.r113751: make memcache key valid for the day ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113740]: New comment added
Brion VIBBER posted a comment on MediaWiki.r113740. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113740#c32123 Commit summary for MediaWiki.r113740: (bug 33536) Make a list of print on demand publishers configurable for Extension:Collection Improve inteface to list print on demand providers including better fallback for browsers without JavaScript. Quell PHP warning: PHP Notice: Undefined index: writer in extensions/Collection/Collection.body.php on line 1214 Bump extension version to 1.6 New global variable: $wgCollectionPODPartners - Array of parameters needed to define print on demand providers. CSS ID converted into a class: collection-order-button classes added: CSS collection-partner coll-partnerlink collapsed classes moved: CSS coll-more_info classes removed: coll-hide_info i18n messages removed: coll-more_info coll-hide_info Brion VIBBER's comment: +var media_path = wgScriptPath + '/extensions/Collection/images/'; use wgExtensionAssetsPath instead here; in a multi-version wiki farm like Wikimedia's we may have different versions of MediaWiki (and thus the extension) in different places. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113685]: Revision status changed
Preilly changed the status of MediaWiki.r113685 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113685 Old status: new New status: ok Commit summary for MediaWiki.r113685: add class openSection to heading when toggling this allows us to style open headings differently from closed headings and is preparation for http://www.mediawiki.org/wiki/File:Mobile_article_expand.png ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113688]: New comment added
Brion VIBBER posted a comment on MediaWiki.r113688. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113688#c32124 Commit summary for MediaWiki.r113688: Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping. Brion VIBBER's comment: Offhand that doesn't look excess to me; if $wgPhpCli is in a directory with a space for instance, you need to be quoting that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Git, Gerrit and the coming migration
On 03/08/2012 06:21 AM, Antoine Musso wrote: Diederik van Liere wrote: 1) Migrating from a centralized source control system to a decentralized system (SVN - Git) Decentralization itself is just a buzz word for the twitter guys. In the end, it does not change that much since most people have a reference repository. I guess most developers will use the WMF repository as a reference, or at the very least, all patches will eventually end up in the WMF repository. We could imagine having the WMF feature team to use their own repository then submit a nice giant patch once in a while. Even though most people will have a reference repository, decentralizing work into a zillion branches will take some getting used to. People will need to take time and learn to change their workflows. 3) Introducing a gated-trunk model We have been using a gated-trunk model for as long as I can remember. No -- there's a big difference. In our current model (SVN and no gate between a committer and trunk), it's probable that revision n+70 depends on stuff in revision n, which hasn't been reviewed yet, which means that if revision n is a FIXME, then we have ugly ripple effects everywhere. This happens way too often, and once we're used to not having it happen anymore, we will be so happy. For this reason, in the short term we aim to eliminate the ability to push directly and bypass review. Everything will go through Gerrit, even if in some cases (as with individual translations) an automatic approver bot will auto-approve mergers to specific branches. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113562]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113562 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113562 Old status: new New status: ok Commit summary for MediaWiki.r113562: version 1.002 added missing system text 'right-openid-converter-access' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113565]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113565 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113565 Old status: new New status: ok Commit summary for MediaWiki.r113565: Tag for version 0.4.14. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113549]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113549 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113549 Old status: new New status: ok Commit summary for MediaWiki.r113549: Code documentation Some code simplification Remove trailing whitespace Remove someone unused variables ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113688]: New comment added
Aaron Schulz posted a comment on MediaWiki.r113688. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113688#c32125 Commit summary for MediaWiki.r113688: Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping. Aaron Schulz's comment: I'm kind of assuming the variable would be set to deal with that. If it is escaped, it needs to be done correctly. I wasted some good time trying to use this function and figure out why the shell call kept failing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113688]: New comment added
Brion VIBBER posted a comment on MediaWiki.r113688. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113688#c32126 Commit summary for MediaWiki.r113688: Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping. Brion VIBBER's comment: The variable should probably not assume that it's pre-escaped; other paths are not. Why's it failing for you? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113543]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113543 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113543 Old status: new New status: ok Commit summary for MediaWiki.r113543: Add message keys for 18 missing summary messages. * Patch for bug 34319 for Special:DeletedContributions and Special:Contributions contributed by Srikanth Lakshmanan * Other 16 instances identified by Der Umherirrende on translatewiki.net (https://translatewiki.net/wiki/Thread:Support/Missing_summary_message_keys_in_message_files), code updates by me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113763]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113763 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113763 Old status: new New status: ok Commit summary for MediaWiki.r113763: Update READMEs. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113762]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113762 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113762 Old status: new New status: deferred Commit summary for MediaWiki.r113762: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113764]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113764 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113764 Old status: new New status: ok Commit summary for MediaWiki.r113764: Use local context to get message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113132]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113132 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113132 Old status: new New status: reverted Commit summary for MediaWiki.r113132: Update language bard properly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113757]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113757 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113757 Old status: new New status: ok Commit summary for MediaWiki.r113757: Comment out code from r113132, because it didn't do that it needed to do. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113754]: Revision status changed
Brion VIBBER changed the status of MediaWiki.r113754 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113754 Old status: new New status: ok Commit summary for MediaWiki.r113754: Add new hooks to page triage ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Re-introducing UNCONFIRMED state to bugzilla
Why is it even restricted? We don't restrict closing bugs. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] OAuth
On Tue, Mar 13, 2012 at 8:10 AM, John Erling Blad jeb...@gmail.com wrote: Exporting authentication from Mediawiki by OAuth is probably both acceptable and interesting, even if OAuth is said to give a rather weak security. It could be that people are a bit confused about OAuth vs OpenID. In some of the projects where I've been involved the problem is not about exporting authentication, but more about how to log on to a Mediawiki-powered site from an other central site doing identity federation. The existing extensions don't handle this very well. Could it be possible to start a work on both importing and exporting identity, authentication and authorization, perhaps focusing on both SAML and OAuth? For serious use it seems to me that SAML is more important than OAuth, while the later is more widespread in social networks. So, since we're discussing SAML and OAuth and OpenID, and such, I should mention this: http://simplesamlphp.org/ It supports SAML, OpenID, OAuth, it's extendable and it supports multiple backends (LDAP, MySQL, etc). It is also localizable. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] OAuth
So, since we're discussing SAML and OAuth and OpenID, and such, I should mention this: http://simplesamlphp.org/ It supports SAML, OpenID, OAuth, it's extendable and it supports multiple backends (LDAP, MySQL, etc). It is also localizable. - Ryan That one is interesting for the Norwegian Wikipedia community as it would make it possible to log into Wikipedia from the identity federation system used in Norwegian schools. That is we would be able to block individual students that are trolling instead of whole schools. John ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113463]: New comment added, and revision status changed
Awjrichards changed the status of MediaWiki.r113463 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463#c32127 Old Status: ok New Status: fixme Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 Awjrichards's comment: Causes the following error in Chrome: Viewport argument key max-width not recognized and ignored. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113463]: New comment added
Jdlrobson posted a comment on MediaWiki.r113463. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463#c32128 Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 Jdlrobson's comment: See r113693 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113463]: New comment added
Jdlrobson posted a comment on MediaWiki.r113463. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463#c32129 Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 Jdlrobson's comment: See r113693 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Re-introducing UNCONFIRMED state to bugzilla
On 13 March 2012 21:44, K. Peachey p858sn...@gmail.com wrote: Why is it even restricted? We don't restrict closing bugs. As the rising tide of bugspam demonstrates, we *should*. --HM ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113463]: New comment added
Awjrichards posted a comment on MediaWiki.r113463. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463#c32130 Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 Awjrichards's comment: Cool, thanks! In the future, you can specify Followup r113463 (or whatever revision you're following up on) in the commit message or do it manually in the code review tool if you forget in the commit message. This helps reviewers/deployers pick up fixes for broken things like this :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
Krinkle posted a comment on MediaWiki.r113644. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32131 Commit summary for MediaWiki.r113644: add locale global for handling languages and message function for the benefit of the phonegap app Krinkle's comment: See also [[bugzilla:31675]]. Afaik the decision was already made to port MobileFrontend to ResourceLoader, and move the bar of get javascript to browser supports modern javascript (instead of browser supports basic javascript). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113463]: Revision status changed
Awjrichards changed the status of MediaWiki.r113463 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463 Old status: fixme New status: resolved Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104758]: New comment added, and revision status changed
Reedy changed the status of MediaWiki.r104758 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104758#c32132 Old Status: ok New Status: fixme Commit summary for MediaWiki.r104758: Script for cleaning up the mess left behind by bug 31576. Still haven't figured out what's causing this bug, but I've got it narrowed down to the job runners Reedy's comment: I'm not sure if this maintenance script is doing what it's supposed to be.. So I've just cancelled them all for the moment. e.g. abwiki - Less than 3000 pages, just over 6000 templatelinks... Why is the script reporting it's processed over 800,000 pages and counting? Shouldn't it need to (at worst!) refresh links on every page. Should the setting of $processed back to an empty array be moved to the top of the processSynonym method? Or even move it to a class variable, so we only attempt to parse any page ones per wiki? pre mysql select count(*) from page\G *** 1. row *** count(*): 2871 1 row in set (0.00 sec) mysql select count(*) from templatelinks\G *** 1. row *** count(*): 6046 1 row in set (0.00 sec) /pre Marking fixme so it gets some attention ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] OAuth
On Tue, Mar 13, 2012 at 3:32 PM, John Erling Blad jeb...@gmail.com wrote: So, since we're discussing SAML and OAuth and OpenID, and such, I should mention this: http://simplesamlphp.org/ It supports SAML, OpenID, OAuth, it's extendable and it supports multiple backends (LDAP, MySQL, etc). It is also localizable. - Ryan That one is interesting for the Norwegian Wikipedia community as it would make it possible to log into Wikipedia from the identity federation system used in Norwegian schools. That is we would be able to block individual students that are trolling instead of whole schools. Good to know. :) There's really two separate things that these systems can do. The classic OAuth scenario is like this: site A: Wikipedia user A site B: Huggle Site B initiates a special login on site A using a shared secret; on success, site A passes back authentication tokens to site B which verify that user A allowed site B access. Site B then uses those tokens when it accesses site A, in place of a username/password directly. OpenID, SAML, etc seem to be more appropriate for this scenario: site A: Wikipedia site B: University user B These systems allow user B to verify their identity to site A; one possibility is to use this to associate a user A' with the remote user B, letting you use the remote ID verification in place of a local password authentication. (This is what our current OpenID extension does, basically.) These are, IMO, totally separate use cases and I'm not sure they should be treated the same. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] OAuth
There's really two separate things that these systems can do. The classic OAuth scenario is like this: site A: Wikipedia user A site B: Huggle Site B initiates a special login on site A using a shared secret; on success, site A passes back authentication tokens to site B which verify that user A allowed site B access. Site B then uses those tokens when it accesses site A, in place of a username/password directly. OpenID, SAML, etc seem to be more appropriate for this scenario: site A: Wikipedia site B: University user B These systems allow user B to verify their identity to site A; one possibility is to use this to associate a user A' with the remote user B, letting you use the remote ID verification in place of a local password authentication. (This is what our current OpenID extension does, basically.) These are, IMO, totally separate use cases and I'm not sure they should be treated the same. The Extension:OpenID can be used for both cases ( given, that you set $wgOpenIDClientOnly = false; ) https://www.mediawiki.org/wiki/Extension:OpenID . The extension makes a MediaWiki installation OpenID 2.0-aware and lets users log in using their OpenID identity - a special URL - instead of (or as an alternative to) standard username/password log in. In that way, the MediaWiki acts as Relying part (RP) = OpenID consumer.[1] *As an option, it also allows the*_*MediaWiki to act as OpenID provider*, _so that users with an account on that wiki can use their userpage URL as OpenID with which they can log in to other OpenID-aware web sites. set $wgOpenIDClientOnly = false; if you want this Tom. signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113463]: New comment added
Jdlrobson posted a comment on MediaWiki.r113463. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113463#c32133 Commit summary for MediaWiki.r113463: use max-width for viewport not width setting width to device-width can have issues where the page is viewed in a webview as part of an app for example. We should actually use max-width here as this allows the screen to be smaller if there is not enough space this fixes bug 31214 Jdlrobson's comment: No worries think I forgot here! Was in the zone :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113772]: New comment added
Bawolff posted a comment on MediaWiki.r113772. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113772#c32134 Commit summary for MediaWiki.r113772: follow up r113554 . fixing a regression which was introduced in r113554. Making now all all ids unique even when you have several polls on a mw page. using, new, the resourceloader to load common methods. just a little bit ... more of jquery. fixing a forgotten wgParser to parser variable problem. introducing and moving js and css to resources. Bawolff's comment: + 'poll_title' = $parser-mTitle-getText() Not really this commit, and possibly not changable for backwards compatability reasons, but getText() gives the human readable version of title ''without'' namespace, and the namespace isn't recorded anywhere else in the db as far as I can tell, which seems like it would result in ambigious records. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] OAuth
Just as an idea, would it be possible for Wikimedia Foundation to establish some kind of joint project with the SimpleSAMLphp-folks? Those are basically Uninett, which is FEIDE, which is those that handle identity federation for lots of the Norwegian schools, colleges and universities.. The SimpleSAML solution is in use in several other projects/countries, not sure whats the current status. The platform for FEIDE is also in use in several other countries so if the log on problems in Norway are solved other countries will be able to use the same solution. Note also that OAuth 2.0 seems to be supported. https://rnd.feide.no/2012/03/08/releasing-a-oauth-2-0-javascript-library/ In april this year there is a conference GoOpen 2012 (http://www.goopen.no/) in Oslo and some folks from Wikimedia Foundation is there, perhaps some folks from Uninett too? Could it be possible for interested people to sit down and discuss wetter a joint project is possible? Uninett is hiring for SimpleSAML development and that could be interesting too! John On Wed, Mar 14, 2012 at 12:13 AM, Thomas Gries m...@tgries.de wrote: There's really two separate things that these systems can do. The classic OAuth scenario is like this: site A: Wikipedia user A site B: Huggle Site B initiates a special login on site A using a shared secret; on success, site A passes back authentication tokens to site B which verify that user A allowed site B access. Site B then uses those tokens when it accesses site A, in place of a username/password directly. OpenID, SAML, etc seem to be more appropriate for this scenario: site A: Wikipedia site B: University user B These systems allow user B to verify their identity to site A; one possibility is to use this to associate a user A' with the remote user B, letting you use the remote ID verification in place of a local password authentication. (This is what our current OpenID extension does, basically.) These are, IMO, totally separate use cases and I'm not sure they should be treated the same. The Extension:OpenID can be used for both cases ( given, that you set $wgOpenIDClientOnly = false; ) https://www.mediawiki.org/wiki/Extension:OpenID . The extension makes a MediaWiki installation OpenID 2.0-aware and lets users log in using their OpenID identity - a special URL - instead of (or as an alternative to) standard username/password log in. In that way, the MediaWiki acts as Relying part (RP) = OpenID consumer.[1] *As an option, it also allows the*_*MediaWiki to act as OpenID provider*, _so that users with an account on that wiki can use their userpage URL as OpenID with which they can log in to other OpenID-aware web sites. set $wgOpenIDClientOnly = false; if you want this Tom. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
