[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933350#comment-13933350 ] Hudson commented on YARN-1389: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1725 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1725/]) YARN-1389. Made ApplicationClientProtocol and ApplicationHistoryProtocol expose analogous getApplication(s)/Attempt(s)/Container(s) APIs. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577052) * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch, > YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch, YARN-1389.11.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933249#comment-13933249 ] Hudson commented on YARN-1389: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1700 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1700/]) YARN-1389. Made ApplicationClientProtocol and ApplicationHistoryProtocol expose analogous getApplication(s)/Attempt(s)/Container(s) APIs. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577052) * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch, > YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch, YARN-1389.11.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933111#comment-13933111 ] Hudson commented on YARN-1389: -- FAILURE: Integrated in Hadoop-Yarn-trunk #508 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/508/]) YARN-1389. Made ApplicationClientProtocol and ApplicationHistoryProtocol expose analogous getApplication(s)/Attempt(s)/Container(s) APIs. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577052) * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch, > YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch, YARN-1389.11.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932960#comment-13932960 ] Hudson commented on YARN-1389: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5316 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5316/]) YARN-1389. Made ApplicationClientProtocol and ApplicationHistoryProtocol expose analogous getApplication(s)/Attempt(s)/Container(s) APIs. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577052) * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch, > YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch, YARN-1389.11.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932950#comment-13932950 ] Zhijie Shen commented on YARN-1389: --- Test failures are not related. > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch, > YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch, YARN-1389.11.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932949#comment-13932949
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634349/YARN-1389.11.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3342//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3342//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch,
> YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch, YARN-1389.11.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932865#comment-13932865
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634332/YARN-1389.10.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3341//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3341//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3341//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch,
> YARN-1389-8.patch, YARN-1389-9.patch, YARN-1389.10.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931602#comment-13931602
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634119/YARN-1389-8.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3331//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3331//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch,
> YARN-1389-8.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931483#comment-13931483 ] Mayank Bansal commented on YARN-1389: - Thanks [~zjshen] for review bq. 1. Please remove this comment Done bq. 2. We'd better not, otherwise, when AHS is disabled, if the object is not found in RM, we will get this annoying exception. Please follow YOUR previous code pattern in YarnClientImpl#getApplicationReport Done bq. 3. Shouldn't you throw ApplicationNotFoundException, as what you did in getContainerReport()? we pass attemt id for containers so its better to have AttemptNotFoundEXception. bq. Please remove this code. attempts will never be null. It can be empty, but it's reasonable. If this application even hasn't its first attempt, the list is empty Done (Changed the check to empty) bq. 5. Similarly, rmContainers can't be null. After YARN-1794, we should have some walk-around to get the finished containers from RM. I think till we fixed this we need to have this check, I may be removing it part of this JIRA. bq. 6. Just return null. Let UI to decide is going to be printed if the diagnostics is not available. Done Thanks, Mayank > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931267#comment-13931267
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634051/YARN-1389-7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3323//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3323//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931266#comment-13931266 ] Zhijie Shen commented on YARN-1389: --- I've ran the latest patch on a presudo cluster, and the aforementioned bug is gone. Thanks, Mayank! > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931255#comment-13931255
]
Zhijie Shen commented on YARN-1389:
---
1. Please remove this comment
{code}
/*
* (non-Javadoc)
*
* @see
* org.apache.hadoop.yarn.api.ApplicationClientProtocol#getContainerReport
* (org.apache.hadoop.yarn.api.protocolrecords.GetContainerReportRequest)
{code}
2.
bq. 4. Shouldn't we remove "throw new YarnException("History service is not
enabled.");" in YarnClientImpl?
bq. Actually we should have this if history is not enabled
We'd better not, otherwise, when AHS is disabled, if the object is not found in
RM, we will get this annoying exception. Please follow YOUR previous code
pattern in YarnClientImpl#getApplicationReport
3. Shouldn't you throw ApplicationNotFoundException, as what you did in
getContainerReport()?
{code}
RMApp application = this.rmContext.getRMApps().get(appId);
if (application == null) {
// If the RM doesn't have the application, throw
// ApplicationNotFoundException and let client to handle.
throw new ApplicationAttemptNotFoundException(
"Application Attempt with id '" + appAttemptId
+ "' doesn't exist in RM.");
}
{code}
And in YarnClientImpl, please make the corresponding corresponding changes as
well.
{code}
if (e.getClass() != ContainerNotFoundException.class
&& e.getClass() != ApplicationAttemptNotFoundException.class) {
throw e;
}
{code}
4. Please remove this code. attempts will never be null. It can be empty, but
it's reasonable. If this application even hasn't its first attempt, the list is
empty.
{code}
if (attempts == null) {
throw new ApplicationAttemptNotFoundException(
"ApplicationAttempts not found for " + appId + " Not Found in RM");
}
{code}
5. Similarly, rmContainers can't be null. After YARN-1794, we should have some
walk-around to get the finished containers from RM.
{code}
if(rmContainers == null){
throw new ContainerNotFoundException("Containers for attempt "
+ appAttemptId + " not present");
}
{code}
6. Just return null. Let UI to decide is going to be printed if the diagnostics
is not available.
{code}
- return finishedStatus.getDiagnostics();
+ if (getFinishedStatus() != null) {
+return getFinishedStatus().getDiagnostics();
+ } else {
+return "N/A";
+ }
{code}
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch, YARN-1389-7.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931083#comment-13931083
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634028/YARN-1389-6.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3322//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch, YARN-1389-6.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931076#comment-13931076
]
Mayank Bansal commented on YARN-1389:
-
Thanks [~zjshen] for the review
bq. 1. is it simpler to use "e instanceof NotFoundException"?
Not needed , essentially same
bq. getFinishedStatus() is not necessary. You can directly do when() on
getDiagnostics/getExitStatus/getState.
Done
bq. 3. There're a lot of code duplication in TestClientRMService. You can move
the common code into a private createClientRMService method, which is called by
your test methods.
Done
bq. 4. Shouldn't we remove "throw new YarnException("History service is not
enabled.");" in YarnClientImpl?
Actually we should have this if history is not enabled
bq. 5. Shouldn't we assert fail here, because the exception is not excepted?
Similar in other test cases.
Done
bq. I've tested the patch locally. "yarn applicationattempt" seems to be able
to get and list attempts of RM cached application. "yarn container" is going to
result in the following crash:
Fixed
bq. One more nit: please add some comments to say "we're going to fix the issue
of showing non-running containers of the running application in YARN-1794" in
getContainers/getContainerReport of ClientRMService.
Done
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924654#comment-13924654 ] Zhijie Shen commented on YARN-1389: --- One more nit: please add some comments to say "we're going to fix the issue of showing non-running containers of the running application in YARN-1794" in getContainers/getContainerReport of ClientRMService. > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923628#comment-13923628
]
Hadoop QA commented on YARN-1389:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633260/YARN-1389-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3289//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3289//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923574#comment-13923574
]
Zhijie Shen commented on YARN-1389:
---
I've tested the patch locally. "yarn applicationattempt" seems to be able to
get and list attempts of RM cached application. "yarn container" is going to
result in the following crash:
{code}
zjshen-mac-pc:Deployment zshen$ yarn container -status
container_1394168341541_0003_01_01
14/03/06 21:06:51 INFO client.RMProxy: Connecting to ResourceManager at
localhost/127.0.0.1:9104
14/03/06 21:06:51 WARN util.NativeCodeLoader: Unable to load native-hadoop
library for your platform... using builtin-java classes where applicable
14/03/06 21:06:51 INFO client.AHSProxy: Connecting to Application History
server at /0.0.0.0:10200
Exception in thread "main" java.lang.NullPointerException:
java.lang.NullPointerException
at
org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerImpl.getDiagnosticsInfo(RMContainerImpl.java:253)
at
org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerImpl.createContainerReport(RMContainerImpl.java:439)
at
org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getContainerReport(ClientRMService.java:413)
at
org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.getContainerReport(ApplicationClientProtocolPBServiceImpl.java:364)
at
org.apache.hadoop.yarn.proto.ApplicationClientProtocol$ApplicationClientProtocolService$2.callBlockingMethod(ApplicationClientProtocol.java:349)
at
org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:605)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:932)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2071)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2067)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:394)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1597)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2065)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at
org.apache.hadoop.yarn.ipc.RPCUtil.instantiateException(RPCUtil.java:53)
at
org.apache.hadoop.yarn.ipc.RPCUtil.unwrapAndThrowException(RPCUtil.java:107)
at
org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl.getContainerReport(ApplicationClientProtocolPBClientImpl.java:375)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:189)
at
org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:102)
at com.sun.proxy.$Proxy10.getContainerReport(Unknown Source)
at
org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.getContainerReport(YarnClientImpl.java:519)
at
org.apache.hadoop.yarn.client.cli.ApplicationCLI.printContainerReport(ApplicationCLI.java:292)
at
org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:150)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
at
org.apache.hadoop.yarn.client.cli.ApplicationCLI.main(ApplicationCLI.java:76)
Caused by:
org.apache.hadoop.ipc.RemoteException(java.lang.NullPointerException):
java.lang.NullPointerException
at
org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerImpl.getDiagnosticsInfo(RMContainerImpl.java:253)
at
org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerImpl.createContainerReport(RMContainerImpl.java:439)
at
org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getContainerReport(ClientRMService.java:413)
at
org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.getContainerReport(ApplicationClientProtocolPBServiceImpl.java:364)
at
org.apache.hadoop.yarn.proto.ApplicationClientProtocol$ApplicationClientProtocolService$2.callBlockingMethod(ApplicationClientProtocol.java:349)
at
org.apache.hadoop.ipc.ProtobufRpc
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923569#comment-13923569
]
Zhijie Shen commented on YARN-1389:
---
Thanks for the update, Mayank! The patch is general fine. Here're some
additional comments
1. is it simpler to use "e instanceof NotFoundException"?
{code}
+ // Even if history-service is enabled, treat all exceptions still the
same
+ // except the following
+ if (e.getClass() != ApplicationNotFoundException.class
+ && e.getClass() != ApplicationAttemptNotFoundException.class) {
+throw e;
+ }
{code}
2. getFinishedStatus() is not necessary. You can directly do when() on
getDiagnostics/getExitStatus/getState.
{code}
+ContainerStatus cs = mock(ContainerStatus.class);
+when(containerimpl.getFinishedStatus()).thenReturn(cs);
+when(containerimpl.getFinishedStatus().getDiagnostics()).thenReturn("N/A");
+when(containerimpl.getFinishedStatus().getExitStatus()).thenReturn(0);
+when(containerimpl.getFinishedStatus().getState()).thenReturn(
+ContainerState.COMPLETE);
{code}
3. There're a lot of code duplication in TestClientRMService. You can move the
common code into a private createClientRMService method, which is called by
your test methods.
4. Shouldn't we remove "throw new YarnException("History service is not
enabled.");" in YarnClientImpl?
5. Shouldn't we assert fail here, because the exception is not excepted?
Similar in other test cases.
{code}
+} catch (ApplicationNotFoundException ex) {
+ Assert.assertEquals(ex.getMessage(),
+ "Application with id '" + request.getApplicationAttemptId()
+ + "' doesn't exist in RM.");
+}
{code}
In addition to that, personally, I'm still object to throwing
AppAttempt/Container not found exception when getting empty appattempt and
container list. Let's assume history service is disabled. Then, getting empty
applications is allowed while getting empty appattempt/container list will
result in exception. Th inconsistent behavior is going to confuse users. In
particular, It is likely that a running application doesn't have any appattempt
(e.g. the app is before ACCEPTED and is the first attempt).
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch, YARN-1389-5.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923301#comment-13923301 ] Mayank Bansal commented on YARN-1389: - Opened the JIRA for this issue YARN-1794 Thanks, Mayank > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923280#comment-13923280 ] Mayank Bansal commented on YARN-1389: - bq .I realize there will be an issue that may not have immediate solution. Currently, if an application is finished, we can get all the finished containers of it from the history store. However,if an application is still running, YarnScheduler is going to remove the container out of its cache once the container is done. Therefore, we're unable to get the finished containers of a running application. It seems that we need to cache RMContainer until the application is finished. Thoughts? yes we should have this as right now there is inconsistency in finished containers for running apps, I will create another JIRA to track that. Thanks, Mayank > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch, YARN-1389-5.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923278#comment-13923278 ] Mayank Bansal commented on YARN-1389: - Thanks [~zjshen] for review bq. 1. In javadoc of ApplicationClientProtocol, we shouldn't mention ApplicationHistoryServer, because the applications obtained from this protocol are all from RM cache instead of history store Done bq. 2. attempts won't be null, and getApplications doesn't throw ApplicationNotFoundException when getting an empty list of applications. Let's keep the behavior consistent. Same for getContainers. And in YarnClientImpl, don't process ApplicationAttemptNotFoundException and ContainerNotFoundException in the corresponding places. In some cases in can be null so keeping it that way. We wanted to avoid get status for application. bq. 3. TestClientRMService needs more test cases as well, like what you did in TestYarnClient Done bq. 4. Please test the new APIs in a presudo cluster to verify whether it works or not. Thanks! Done , it works :) > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922016#comment-13922016 ] Jian He commented on YARN-1389: --- sorry, my previous message is incorrect. I was in wrong impression.. > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922007#comment-13922007 ] Jian He commented on YARN-1389: --- I think SchedulerApplicationAttempt.liveContainers is keeping tracking of all including finished containers until the application is gone from scheduler's POV. > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921878#comment-13921878 ] Zhijie Shen commented on YARN-1389: --- I realize there will be an issue that may not have immediate solution. Currently, if an application is finished, we can get all the finished containers of it from the history store. However,if an application is still running, YarnScheduler is going to remove the container out of its cache once the container is done. Therefore, we're unable to get the finished containers of a running application. It seems that we need to cache RMContainer until the application is finished. Thoughts? > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921265#comment-13921265
]
Zhijie Shen commented on YARN-1389:
---
1. In javadoc of ApplicationClientProtocol, we shouldn't mention
ApplicationHistoryServer, because the applications obtained from this protocol
are all from RM cache instead of history store
{code}
+ * The ResourceManager or ApplicationHistoryServer
{code}
2. attempts won't be null, and getApplications doesn't throw
ApplicationNotFoundException when getting an empty list of applications. Let's
keep the behavior consistent. Same for getContainers. And in YarnClientImpl,
don't process ApplicationAttemptNotFoundException and
ContainerNotFoundException in the corresponding places.
{code}
+ Map attempts = application
+ .getAppAttempts();
+ List listAttempts = new
ArrayList();
+ if (attempts == null) {
+throw new ApplicationAttemptNotFoundException(
+"ApplicationAttempts not found for " + appId + " Not Found in RM");
+ }
{code}
3. TestClientRMService needs more test cases as well, like what you did in
TestYarnClient
4. Please test the new APIs in a presudo cluster to verify whether it works or
not. Thanks!
bq. We decided not to get completed list from history, it will be just rm apps
as before.
Then, in the current YarnClient can never inquiry a list of applications stored
in the history store, while it can do all the other remaining things. However,
let's imagine how users inspect the information: they will list the
applications, and get verbose information of a particular application. It's
difficult for users to locate a particular application in the history store
without knowing its application ID.
While it makes sense to show the running application only, we still need open
the option for users to get the finished applications. I don't want to block
the patch with this issue, but anyway, we should be aware of it and deal with
it later.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[
https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920760#comment-13920760
]
Hadoop QA commented on YARN-1389:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632799/YARN-1389-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
See
https://builds.apache.org/job/PreCommit-YARN-Build/3263//artifact/trunk/patchprocess/diffJavadocWarnings.txt
for details.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3263//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3263//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3263//console
This message is automatically generated.
> ApplicationClientProtocol and ApplicationHistoryProtocol should expose
> analogous APIs
> -
>
> Key: YARN-1389
> URL: https://issues.apache.org/jira/browse/YARN-1389
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch,
> YARN-1389-4.patch
>
>
> As we plan to have the APIs in ApplicationHistoryProtocol to expose the
> reports of *finished* application attempts and containers, we should do the
> same for ApplicationClientProtocol, which will return the reports of
> *running* attempts and containers.
> Later on, we can improve YarnClient to direct the query of running instance
> to ApplicationClientProtocol, while that of finished instance to
> ApplicationHistoryProtocol, making it transparent to the users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1389) ApplicationClientProtocol and ApplicationHistoryProtocol should expose analogous APIs
[ https://issues.apache.org/jira/browse/YARN-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920669#comment-13920669 ] Mayank Bansal commented on YARN-1389: - Thanks [~zjshen] for the review. bq. 1. I still see "ApplicationHistoryServer" in ApplicationClientProtocol. And some description sounds not accurate. For example, Done bq. ApplicationHistoryProtocol's javadoc has been wrongly modified. Done bq. Is it better to simplify the following condition? Same for all the similar conditions in the patch Done bq. Please match the NotFoundException that will be thrown in ClientRMService, and that is analyzed in YarnClientImpl. Done bq. It is still an in-progress patch, isn't it? The test cases are still missing. Done bq. Didn't see the change to allow user to get the application list from the history We decided not to get completed list from history, it will be just rm apps as before. bq. Please see what RMApp does Done > ApplicationClientProtocol and ApplicationHistoryProtocol should expose > analogous APIs > - > > Key: YARN-1389 > URL: https://issues.apache.org/jira/browse/YARN-1389 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1389-1.patch, YARN-1389-2.patch, YARN-1389-3.patch, > YARN-1389-4.patch > > > As we plan to have the APIs in ApplicationHistoryProtocol to expose the > reports of *finished* application attempts and containers, we should do the > same for ApplicationClientProtocol, which will return the reports of > *running* attempts and containers. > Later on, we can improve YarnClient to direct the query of running instance > to ApplicationClientProtocol, while that of finished instance to > ApplicationHistoryProtocol, making it transparent to the users. -- This message was sent by Atlassian JIRA (v6.2#6252)
