[jira] Commented: (ZOOKEEPER-608) Receipt of ACK from observer should not be logged as ERROR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803255#action_12803255 ] Hudson commented on ZOOKEEPER-608: -- Integrated in ZooKeeper-trunk #674 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/674/]) . Receipt of ACK from observer should not be logged as ERROR (henry via mahadev) > Receipt of ACK from observer should not be logged as ERROR > -- > > Key: ZOOKEEPER-608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-608.patch > > > Observers - in general - don't send ACKs. But a couple of times they need to. > Currently, these are all logged as an ERROR, which is wrong. They should at > most be WARN (and this would probably be confusing to the user). INFO might > be better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-608) Receipt of ACK from observer should not be logged as ERROR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803114#action_12803114 ] Mahadev konar commented on ZOOKEEPER-608: - +1 patch looks good. I will go ahead and commit it. henry, please to open a jira for testobservers hang and please mark it for 3.3. > Receipt of ACK from observer should not be logged as ERROR > -- > > Key: ZOOKEEPER-608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-608.patch > > > Observers - in general - don't send ACKs. But a couple of times they need to. > Currently, these are all logged as an ERROR, which is wrong. They should at > most be WARN (and this would probably be confusing to the user). INFO might > be better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-608) Receipt of ACK from observer should not be logged as ERROR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801517#action_12801517 ] Henry Robinson commented on ZOOKEEPER-608: -- Flavio - Observers send two ACKs each during the synchronisation protocol with the leader. These are legitimate responses so that the Leader can know that they're properly synced. We can potentially remove them, but it seems like more trouble than it's worth. I don't mind removing these debug messages, but I feel like they could be helpful if we do some Observers development in the future to verify any changes to the protocol. Happy to take them out though. We can open a JIRA for the testObservers hang, and I will take a look. I can't reproduce the failure but if it happens again, it'll be good to have somewhere to track it. Henry > Receipt of ACK from observer should not be logged as ERROR > -- > > Key: ZOOKEEPER-608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-608.patch > > > Observers - in general - don't send ACKs. But a couple of times they need to. > Currently, these are all logged as an ERROR, which is wrong. They should at > most be WARN (and this would probably be confusing to the user). INFO might > be better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-608) Receipt of ACK from observer should not be logged as ERROR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801159#action_12801159 ] Flavio Paiva Junqueira commented on ZOOKEEPER-608: -- Pat, Henry, I'm confused. Observers really shouldn't send ACKs, and if they do we have a bug. If we are seeing many of these, don't we have an issue with the observer logic then? Now, the patch is clearly good, my question is if receiving ACKs from observers should be really at debug level. Also, I checked the hudson run that failed, and it seems that it timed out on testObserver. Henry is right in that it doesn't seem to be related to his patch, but I wonder if we should open a new jira or not. There isn't enough to work with other than "testObserver timed out oin hudson". > Receipt of ACK from observer should not be logged as ERROR > -- > > Key: ZOOKEEPER-608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-608.patch > > > Observers - in general - don't send ACKs. But a couple of times they need to. > Currently, these are all logged as an ERROR, which is wrong. They should at > most be WARN (and this would probably be confusing to the user). INFO might > be better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-608) Receipt of ACK from observer should not be logged as ERROR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801093#action_12801093 ] Hadoop QA commented on ZOOKEEPER-608: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430453/ZOOKEEPER-608.patch against trunk revision 899383. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/106/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/106/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/106/console This message is automatically generated. > Receipt of ACK from observer should not be logged as ERROR > -- > > Key: ZOOKEEPER-608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-608.patch > > > Observers - in general - don't send ACKs. But a couple of times they need to. > Currently, these are all logged as an ERROR, which is wrong. They should at > most be WARN (and this would probably be confusing to the user). INFO might > be better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-608) Receipt of ACK from observer should not be logged as ERROR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801016#action_12801016 ] Hadoop QA commented on ZOOKEEPER-608: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430453/ZOOKEEPER-608.patch against trunk revision 899383. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/105/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/105/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/105/console This message is automatically generated. > Receipt of ACK from observer should not be logged as ERROR > -- > > Key: ZOOKEEPER-608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-608.patch > > > Observers - in general - don't send ACKs. But a couple of times they need to. > Currently, these are all logged as an ERROR, which is wrong. They should at > most be WARN (and this would probably be confusing to the user). INFO might > be better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
