Hadoop QA commented on ZOOKEEPER-608:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 899383.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> Receipt of ACK from observer should not be logged as ERROR
> ----------------------------------------------------------
>                 Key: ZOOKEEPER-608
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-608
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Critical
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-608.patch
> Observers - in general - don't send ACKs. But a couple of times they need to. 
> Currently, these are all logged as an ERROR, which is wrong. They should at 
> most be WARN (and this would probably be confusing to the user). INFO might 
> be better. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to