Re: [Zope-dev] zope.testrunner (Was: Circular dependency hell.)
Hi Lennart, On Mon, Apr 19, 2010 at 2:42 PM, Jonathan Ballet jonathan.bal...@securactive.net wrote: Hi, On Mon, Apr 19, 2010 at 1:03 PM, Lennart Regebro rege...@gmail.com wrote: OK, I made a branch of zope.testing that doesn't include the testrunner. That was easy peasy. http://svn.zope.org/zope.testing/branches/regebro-notestrunner/ And I made a zope.testrunner: http://svn.zope.org/zope.testrunner/trunk That was pretty easy too. Except one thing: The shuffle feature shuffles things differently in zope.testrunner compared to in zope.testing.testrunner, which seems to be because it finds the layers in a different order. I took some time to look at this yesterday, and it seems you were right: the order should have changed since the layers now have a different name. I can't speak for other people who are using the feature, but this will not affect us very much. We use the shuffle seed feature for two cases: * we want to reproduce on a developer computer a test run which has failed on the Buildbot; * while reviewing someone's code, if tests are failing on a computer but not on another, we want to provide a way for tests to fail the same way on both computers, by pinning the order. Both cases have a short life time (we don't need to reproduce a particular order from X months ago), so this change is OK for us. Regards, Jonathan ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Unauthorized handling in Zope2
Hi!
Wichert Akkerman wrote:
Unauthorised is doing stupid things here:
(Pdb) p v
Unauthorized()
(Pdb) p unicode(v)
u''
(Pdb) p str(v)
*** UnicodeEncodeError: UnicodeEncodeError('ascii',
u'!DOCTYPE html...', 1175, 1176, 'ordinal not in range(128)')
I added an extra change (see diff below) to fix that, after which things
seemed to work.
Looks like my patch didn't work for you because of this:
http://bugs.python.org/issue6108 (fixed in Python 2.6.5)
I committed a modified Unauthorized patch that should work with all
supported Python versions:
http://svn.zope.org/?rev=97view=rev
And I hope together with the change in HTTPResponse your issue is
resolved now:
http://svn.zope.org/?rev=99view=rev
Cheers,
Yuppie
___
Zope-Dev maillist - Zope-Dev@zope.org
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] bug tracker gardening for bugday
Hello, I've added the tag bugday20100424 to some bugs for the bugday. Feel free to do the same with others. -- Best regards, Adam GROSZER mailto:agros...@gmail.com -- Quote of the day: Action causes more trouble than thought ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testrunner (Was: Circular dependency hell.)
On Wed, Apr 21, 2010 at 09:13:30AM +0200, Jonathan Ballet wrote: Hi Lennart, On Mon, Apr 19, 2010 at 2:42 PM, Jonathan Ballet jonathan.bal...@securactive.net wrote: Hi, On Mon, Apr 19, 2010 at 1:03 PM, Lennart Regebro rege...@gmail.com wrote: OK, I made a branch of zope.testing that doesn't include the testrunner. That was easy peasy. http://svn.zope.org/zope.testing/branches/regebro-notestrunner/ And I made a zope.testrunner: http://svn.zope.org/zope.testrunner/trunk That was pretty easy too. Except one thing: The shuffle feature shuffles things differently in zope.testrunner compared to in zope.testing.testrunner, which seems to be because it finds the layers in a different order. I took some time to look at this yesterday, and it seems you were right: the order should have changed since the layers now have a different name. Layers plural? I'd expect the UnitTestLayer to change its name, but what are the others? Also see https://bugs.launchpad.net/zope.testing/+bug/497871: there's consensus that unit tests should always be the first layer to run, so the layer name shouldn't influence the ordering. Marius Gedminas -- http://pov.lt/ -- Zope 3 consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.test.doctest made into monkey-patches (Was: Circular dependency hell.)
On Wed, Apr 21, 2010 at 07:10:38AM +0200, Lennart Regebro wrote: Let zope.testing.doctest wither and die It hasn't been merged from python trunk since 2004, and the amount of bugfixes on that Python trunk since then is astounding. So I'd argue that is *is* withered. The monkey-patching kills it. :) Interestingly, there are two bugs fixed on zopes doctest that hasn't been fixed in the standard library. I've reported them: http://bugs.python.org/issue8471 *Thank you*, this was the only issue that caused me trouble when I ported our code base from zope.testing.doctest to stdlib's doctest. I ran out of tuits so I didn't report it. Marius Gedminas -- http://pov.lt/ -- Zope 3 consulting and development signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope Tests: 10 OK, 4 Failed
Summary of messages to the zope-tests list. Period Tue Apr 20 12:00:00 2010 UTC to Wed Apr 21 12:00:00 2010 UTC. There were 14 messages: 6 from Zope Tests, 7 from ccomb at free.fr, 1 from ct at gocept.com. Test failures - Subject: FAILED: Repository policy check found errors in 669 projects From: ct at gocept.com Date: Tue Apr 20 21:14:58 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014041.html Subject: FAILED : ZTK 1.0dev / Python2.4.6 Linux 32bit From: ccomb at free.fr Date: Tue Apr 20 23:56:07 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014052.html Subject: FAILED : ZTK 1.0dev / Python2.5.2 Linux 32bit From: ccomb at free.fr Date: Tue Apr 20 23:57:33 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014053.html Subject: FAILED : ZTK 1.0dev / Python2.6.4 Linux 32bit From: ccomb at free.fr Date: Tue Apr 20 23:57:38 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014054.html Tests passed OK --- Subject: OK : Zope-2.10 Python-2.4.6 : Linux From: Zope Tests Date: Tue Apr 20 21:29:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014042.html Subject: OK : Zope-2.11 Python-2.4.6 : Linux From: Zope Tests Date: Tue Apr 20 21:31:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014043.html Subject: OK : Zope-2.12 Python-2.6.4 : Linux From: Zope Tests Date: Tue Apr 20 21:33:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014044.html Subject: OK : Zope-2.12-alltests Python-2.6.4 : Linux From: Zope Tests Date: Tue Apr 20 21:35:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014045.html Subject: OK : Zope-trunk Python-2.6.4 : Linux From: Zope Tests Date: Tue Apr 20 21:37:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014046.html Subject: OK : Zope-trunk-alltests Python-2.6.4 : Linux From: Zope Tests Date: Tue Apr 20 21:39:41 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014047.html Subject: OK : BlueBream template / Python2.4.6 32bit linux From: ccomb at free.fr Date: Tue Apr 20 22:01:21 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014048.html Subject: OK : BlueBream template / Python2.6.4 32bit linux From: ccomb at free.fr Date: Tue Apr 20 22:01:25 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014049.html Subject: OK : BlueBream template / Python2.7b1 32bit linux From: ccomb at free.fr Date: Tue Apr 20 22:01:26 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014050.html Subject: OK : BlueBream template / Python2.5.2 32bit linux From: ccomb at free.fr Date: Tue Apr 20 22:01:27 EDT 2010 URL: http://mail.zope.org/pipermail/zope-tests/2010-April/014051.html ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Minutes of this weeks meeting
Hi, here's yesterday's minutes. I've been a bit less adventurous than last week and we're back on a text format. Unfortunately without tool support again, for now. :/ Christian -- Christian Theune · c...@gocept.com gocept gmbh co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development = Weekly Zope developer meeting = This is the summary of the weekly Zope developer meeting which happened on Tuesday, 2010-04-20 on #z...@irc.freenode.org from 3pm to 3:30pm (UTC). The agenda for this meeting is available in the mailing list archives: https://mail.zope.org/pipermail/zope-dev/2010-April/040226.html The IRC logs are located here: http://zope3.pov.lt/irclogs-zope/%23zope.2010-04-20.log.html#t2010-04-20T18:02:52 Version/release issues with ZTK packages Adam Groszer reported that in his work for the Zope 3.4.1 KGS he stumbled over problems with releases that improperly mixed features and bugfixes in major an minor releases. Tres and Adam suggested to remedie situations like this (where a minor release introduced features that break stuff) by making two new releases: a subsequent minor release that removes the features again and a subsequent major release to properly introduce the feature changes. Christophe Combelles specifically reported zope.app.securitypolicy as an example breaking z3c.formdemo. It seems like Martijn Faassen made that release so we need to check back on his oppinion. Tres noted that for packages that are developed with a specific version set in mind their buildout should point to that index. This will ensure successful builds and document the context they have been developed in. Christophe Combelles noted that we might want a tool to support developers verifying whether a release would be suitable for major or minor version. agroszer will report other packages he found having those kinds of issues to the Zope 3 bug tracker. The general approach of re-releasing packages when features have crept in should be documented in the developer documentation (Christian Theune). LP bug management / Triage of old Zope 3 bugs = Tres' and Christian spend some time cleaning up the Launchpad situation. Details are to be found in Tres' blog post: http://palladion.com/home/tseaver/obzervationz/2010/ztk_launchpad_gardening It wasn't clear what should happen about bug tracking for code that lives in zope.app.* packages as those aren't part of the ZTK itself anymore. We discussed having a separate Launchpad project group 'zopeapp' for them and create individual projects there. Christian Theune suggested to ponder merging the zope.app.* packages into a single distribution and thus having a single zopeapp project. As one goal is to slowly shrink the size and number of zope.app.* packages in use this could reduce the amount of overhead involved to manage the packages. The decision on this was deferred to the ZTK engineering group. [Note: we still need to do something about bug tracking *now*. Proposal for next time: go with a single zopeapp project with a single bug tracker for now.] [We didn't touch the issue of triaging bugs from the Zope 3 tracker to the individual packages' ones. It would be cool, though, if people had time before the bug day to actually move more of them over to the individual projects] Upcoming bugday === As a gentle reminder: there's a bug day coming up on Saturday 2010-04-24 and anyone who wants to help getting bugs triaged or fixed and who wants to contribute or help out otherwise is very welcome. Tres' will provide some documentation to help non-comitter volunteers interface with our development process which can later be incorporated into docs.zope.org. ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.testrunner (Was: Circular dependency hell.)
On Wed, Apr 21, 2010 at 13:47, Marius Gedminas mar...@gedmin.as wrote: Also see https://bugs.launchpad.net/zope.testing/+bug/497871: there's consensus that unit tests should always be the first layer to run, so the layer name shouldn't influence the ordering. The layers run in the same order, but the *discovery* of the layers means they get *shuffled* in a different order, which means the result of the shuffle is different, because the random shuffle is not reseeded between each layer. I hoped that the different discovery order was just for zope.testrunner vs zope.testing.testrunner, but from Jonathans answer above it seems not. -- Lennart Regebro: Python, Zope, Plone, Grok http://regebro.wordpress.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope.test.doctest made into monkey-patches (Was: Circular dependency hell.)
On Tue, Apr 20, 2010 at 15:23, Lennart Regebro rege...@gmail.com wrote: On Tue, Apr 20, 2010 at 13:44, Wichert Akkerman wich...@wiggy.net wrote: You may want to move it outside the zope.* namespace to encourage that :) We could certainly do that. But the support for that idea seems very small, so let's stay with zope.testrunner, as it's perfectly good. And even py.test have problems struggling against Nose, so I don't think we'll get many non Zopers anyway. :) -- Lennart Regebro: Python, Zope, Plone, Grok http://regebro.wordpress.com/ +33 661 58 14 64 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] bug tracker gardening for bugday
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam GROSZER wrote: Hello, I've added the tag bugday20100424 to some bugs for the bugday. Feel free to do the same with others. Here is the Launchpad tag page for it: https://bugs.launchpad.net/zopetoolkit/+bugs?field.tag=bugday20100424 I have updated the bugday wiki page with that link. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkvPLK4ACgkQ+gerLs4ltQ616ACgwrF4PEHRONk/0yhISlmcp7pr FucAn3+ntgHl+SgzB7pct41e63vB5pww =4OHH -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Minutes of this weeks meeting
On 4/21/10 7:21 AM, Christian Theune wrote: week and we're back on a text format. Hurrah! :) ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: Proposed new style for documenting and testing ZTK packages
Am 20.04.2010, 18:43 Uhr, schrieb Christian Theune c...@gocept.com: Let me raise another issue which is that we also need to figure out how to follow up with this once we start. Could get a lint template (or whatever it's called) to help here? Charlie -- Charlie Clark Managing Director Clark Consulting Research German Office Helmholtzstr. 20 Düsseldorf D- 40215 Tel: +49-211-600-3657 Mobile: +49-178-782-6226 ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] bug tracker gardening for bugday
On Wed, Apr 21, 2010 at 2:14 PM, Tres Seaver tsea...@palladion.com wrote: I have also tagged a bunch of other bugs (mostly those with patches) with the tag -- it would be good to adopt a culture where bugs with patches (or branches) never languish. There's a view for that!: https://bugs.edge.launchpad.net/zopetoolkit/+patches -- Sidnei ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: Proposed new style for documenting and testing ZTK packages
On 04/21/2010 09:05 PM, Charlie Clark wrote: Am 20.04.2010, 18:43 Uhr, schrieb Christian Theunec...@gocept.com: Let me raise another issue which is that we also need to figure out how to follow up with this once we start. Could get a lint template (or whatever it's called) to help here? Not sure what that means, can you elaborate a bit? Christian -- Christian Theune · c...@gocept.com gocept gmbh co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 0 · fax +49 345 1229889 1 Zope and Plone consulting and development ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
