[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2011-11-22T08-35-02.487Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/82572 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020
fixed a performance bug in the implementation of groupby: no node copying for
non-groupby vars
--
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/compiler/rewriter/rules/fold_rules.cpp'
--- src/compiler/rewriter/rules/fold_rules.cpp 2011-09-27 10:43:46 +
+++ src/compiler/rewriter/rules/fold_rules.cpp 2011-11-22 13:44:35 +
@@ -225,7 +225,6 @@
}
}
-
// Process the subexprs of the current expr. If any of the children is
// nondiscardable, unfoldable, or contains recursive calls, then the current
// expr is also nondiscardable, unfoldable, or contains recursive calls.
=== modified file 'src/runtime/core/flwor_iterator.cpp'
--- src/runtime/core/flwor_iterator.cpp 2011-10-22 15:44:45 +
+++ src/runtime/core/flwor_iterator.cpp 2011-11-22 13:44:35 +
@@ -1291,17 +1291,17 @@
FlworState::TuplesTable tuplesTable = iterState-theTuplesTable;
- ulong numTuples = (ulong)tuplesTable.size();
+ csize numTuples = tuplesTable.size();
tuplesTable.resize(numTuples + 1);
- ulong numForVars = (ulong)theMaterializeClause-theInputForVars.size();
- ulong numLetVars = (ulong)theMaterializeClause-theInputLetVars.size();
+ csize numForVars = theMaterializeClause-theInputForVars.size();
+ csize numLetVars = theMaterializeClause-theInputLetVars.size();
StreamTuple streamTuple = tuplesTable[numTuples];
streamTuple.theItems.resize(numForVars);
streamTuple.theSequences.resize(numLetVars);
- for (ulong i = 0; i numForVars; ++i)
+ for (csize i = 0; i numForVars; ++i)
{
store::Item_t forItem;
consumeNext(forItem,
@@ -1313,14 +1313,12 @@
theMaterializeClause-theInputForVars[i]-reset(planState);
}
- for (ulong i = 0; i numLetVars; ++i)
+ for (csize i = 0; i numLetVars; ++i)
{
store::TempSeq_t letTempSeq;
-const PlanIter_tvar_plan = theMaterializeClause-theInputLetVars[i];
-createTempSeq(letTempSeq,
- var_plan,
- planState,
- false);
+const PlanIter_t var_plan = theMaterializeClause-theInputLetVars[i];
+
+createTempSeq(letTempSeq, var_plan, planState, false);
streamTuple.theSequences[i].transfer(letTempSeq);
@@ -1330,7 +1328,7 @@
// Create the sort tuple
std::vectorOrderSpec orderSpecs = theMaterializeClause-theOrderSpecs;
- ulong numSpecs = (ulong)orderSpecs.size();
+ csize numSpecs = orderSpecs.size();
if (numSpecs == 0)
return;
@@ -1498,16 +1496,16 @@
std::vectorNonGroupingSpec nongroupingSpecs = theGroupByClause-theNonGroupingSpecs;
std::vectorstore::TempSeq_t* nongroupVarSequences = 0;
- ulong numNonGroupingSpecs = (ulong)nongroupingSpecs.size();
+ csize numNonGroupingSpecs = nongroupingSpecs.size();
if (groupMap-get(groupTuple, nongroupVarSequences))
{
-for (ulong i = 0; i numNonGroupingSpecs; ++i)
+for (csize i = 0; i numNonGroupingSpecs; ++i)
{
store::Iterator_t iterWrapper =
new PlanIteratorWrapper(nongroupingSpecs[i].theInput,
planState);
- (*nongroupVarSequences)[i]-append(iterWrapper, true);
+ (*nongroupVarSequences)[i]-append(iterWrapper, false);
nongroupingSpecs[i].reset(planState);
}
@@ -1518,12 +1516,12 @@
{
nongroupVarSequences = new std::vectorstore::TempSeq_t();
-for (ulong i = 0; i numNonGroupingSpecs; ++i)
+for (csize i = 0; i numNonGroupingSpecs; ++i)
{
store::Iterator_t iterWrapper =
new PlanIteratorWrapper(nongroupingSpecs[i].theInput, planState);
- store::TempSeq_t result = GENV_STORE.createTempSeq(iterWrapper, true, false);
+ store::TempSeq_t result = GENV_STORE.createTempSeq(iterWrapper, false, false);
nongroupVarSequences-push_back(result);
@@ -1547,18 +1545,18 @@
StreamTuple streamTuple =
iterState-theTuplesTable[tuplePos];
- ulong numForVarsRefs = (ulong)theMaterializeClause-theOutputForVarsRefs.size();
+ csize numForVarsRefs = theMaterializeClause-theOutputForVarsRefs.size();
- for (ulong i = 0; i numForVarsRefs; ++i)
+ for (csize i = 0; i numForVarsRefs; ++i)
{
bindVariables(streamTuple.theItems[i],
theMaterializeClause-theOutputForVarsRefs[i],
planState);
}
- ulong numLetVarsRefs = (ulong)theMaterializeClause-theOutputLetVarsRefs.size();
+ csize numLetVarsRefs = theMaterializeClause-theOutputLetVarsRefs.size();
- for (ulong i = 0; i numLetVarsRefs; ++i)
+ for (csize i = 0; i numLetVarsRefs; ++i)
{
bindVariables(streamTuple.theSequences[i],
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2011-11-22T13-46-13.008Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2011-11-22T13-46-13.008Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/83020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 866980] Re: Python compilation failing on Windows/debug
** Changed in: zorba Assignee: Gabriel Petrovay (gabipetrovay) = (unassigned) ** Changed in: zorba Status: New = Won't Fix -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/866980 Title: Python compilation failing on Windows/debug Status in Zorba - The XQuery Processor: Won't Fix Bug description: 2171 - python (Failed) If the python version is not good, CMake should complain. Start 2171: python 2171: Test command: D:\Software\Python27\python.exe python_test.py 2171: Test timeout computed to be: 1500 2171: Traceback (most recent call last): 2171: File python_test.py, line 17, in module 2171: import zorba_api 2171: ImportError: No module named zorba_api 1/1 Test #2171: python ...***Failed0.05 sec To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/866980/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867377] Re: Add debugger client command line execution support
This has been build and is available in the branch: lp:~zorba-coders/zorba/debugger_client ** Description changed: That is: - xqdb.exe zorba.exe -f -g mm.xq ... + xqdb.exe -f -q mm.xq ... This should start the debugger client AND zorba in background such that the user does not have to start zorba executable as a separate process. ** Changed in: zorba Status: New = Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867377 Title: Add debugger client command line execution support Status in Zorba - The XQuery Processor: Fix Committed Bug description: That is: xqdb.exe -f -q mm.xq ... This should start the debugger client AND zorba in background such that the user does not have to start zorba executable as a separate process. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867377/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867344] Re: Implementation of fn:parse and fn:serialize planned?
** Changed in: zorba Status: New = Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867344 Title: Implementation of fn:parse and fn:serialize planned? Status in Zorba - The XQuery Processor: Fix Released Bug description: Are there plans to implement functions to parse and serialize XML according to the W3C standard? That would be great! http://www.w3.org/TR/xpath-functions-11/#func-parse http://www.w3.org/TR/xpath-functions-11/#func-serialize Best regards Mike To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867344/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867373] Re: ser:serialize() must support binary serialization
** Changed in: zorba Importance: High = Medium -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867373 Title: ser:serialize() must support binary serialization Status in Zorba - The XQuery Processor: New Bug description: The serialize function in the serialize module (http://www.zorba- xquery.com/modules/serialize) has been aligned to the new fn:serialize() function. But the current implementation does not support the implementation dependent methods as the serialization spec allows. This is needed for all the image tests which have currently been disabled. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867373/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867159] Re: fn:match fails if the string is non-utf8
I am not sure if I am the right person to do this. Removing myself from this bug. ** Changed in: zorba Assignee: Gabriel Petrovay (gabipetrovay) = (unassigned) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867159 Title: fn:match fails if the string is non-utf8 Status in Zorba - The XQuery Processor: New Bug description: I have a query that reads a lot of files and apply fn:match on them. Some files have non-utf8 characters, and file:read-text reads with no problem. fn:matches calls to_string to convert to ICU string, but that fails. So fn:matches returns false, although I think it should raise an error. Actually to_string should raise an error, otherwise the non-utf8 problem gets unnoticed. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867159/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867159] Re: fn:match fails if the string is non-utf8
** Changed in: zorba Assignee: (unassigned) = Matthias Brantner (matthias-brantner) ** Changed in: zorba Milestone: None = 2.2 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867159 Title: fn:match fails if the string is non-utf8 Status in Zorba - The XQuery Processor: New Bug description: I have a query that reads a lot of files and apply fn:match on them. Some files have non-utf8 characters, and file:read-text reads with no problem. fn:matches calls to_string to convert to ICU string, but that fails. So fn:matches returns false, although I think it should raise an error. Actually to_string should raise an error, otherwise the non-utf8 problem gets unnoticed. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867159/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 874679] Re: Clean up second arg to ADD_TEST_DIRECTORY()
** Changed in: zorba Assignee: Gabriel Petrovay (gabipetrovay) = Chris Hillery (ceejatec) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/874679 Title: Clean up second arg to ADD_TEST_DIRECTORY() Status in Zorba - The XQuery Processor: New Bug description: The second (optional) argument to ADD_TEST_DIRECTORY() contains a list of test cases that should be skipped (ie, not created at all). This is extremely dangerous. By bypassing them entirely, there is no way of detecting when the bug is fixed. We have already had serious problems caused by test removal hiding the introduction of new bugs in the past. I understand that removing a test that segfaults is necessary on Windows in order for the tests to run unattended. However, it should never be done on other platforms. So ADD_TEST_DIRECTORY() should instead mark the bugs as EXPECTED_FAILURE()s on other platforms. (I realize that *currently* all places that pass a list of segfaulting tests to ADD_TEST_DIRECTORY() are inside an IF(WIN32), but this is not sufficient - ADD_TEST_DIRECTORY() itself must enforce that the tests are skipped only on Windows, or else sooner or later someone will accidentally do it wrong. There's currently no documentation either, making this much more likely.) In order to do this, ADD_TEST_DIRECTORY() needs to either accept a list of pairs of the form (testname, bug ID), or else accept two parallel lists (testnames and bug IDs), so it can pass the bug number to EXPECTED_FAILURE(). A slightly more difficult approach would be to introduce a new KNOWN_SEGFAULT() macro that handled this in conjunction with ADD_TEST_DIRECTORY(). I'm not totally sure this is a good idea, though, because it would (silently) not do anything for tests added by any means other than ADD_TEST_DIRECTORY(). To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/874679/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867266] Re: Unexpected updating expression illegal here
** Description changed: This raises an error: - 4,1: update static error [err:XUST0001]: updating expression illegal here; raised at /zorba/trunksrc/src/compiler/expression/fo_expr.cpp:23 + 4,1: update static error [err:XUST0001]: updating expression illegal here; raised at /zorba/trunksrc/src/compiler/expression/fo_expr.cpp:222 variable $x:=a/; for $y in $x return replace value of node $x with x - This doesn't: variable $x:=a/; for $y in $x return replace value of node $y with x -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867266 Title: Unexpected updating expression illegal here Status in Zorba - The XQuery Processor: New Bug description: This raises an error: 4,1: update static error [err:XUST0001]: updating expression illegal here; raised at /zorba/trunksrc/src/compiler/expression/fo_expr.cpp:222 variable $x:=a/; for $y in $x return replace value of node $x with x This doesn't: variable $x:=a/; for $y in $x return replace value of node $y with x To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867266/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 874679] Re: Clean up second arg to ADD_TEST_DIRECTORY()
Correction: This would only *work* for tests that failing uniformly on all platforms. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/874679 Title: Clean up second arg to ADD_TEST_DIRECTORY() Status in Zorba - The XQuery Processor: New Bug description: The second (optional) argument to ADD_TEST_DIRECTORY() contains a list of test cases that should be skipped (ie, not created at all). This is extremely dangerous. By bypassing them entirely, there is no way of detecting when the bug is fixed. We have already had serious problems caused by test removal hiding the introduction of new bugs in the past. I understand that removing a test that segfaults is necessary on Windows in order for the tests to run unattended. However, it should never be done on other platforms. So ADD_TEST_DIRECTORY() should instead mark the bugs as EXPECTED_FAILURE()s on other platforms. (I realize that *currently* all places that pass a list of segfaulting tests to ADD_TEST_DIRECTORY() are inside an IF(WIN32), but this is not sufficient - ADD_TEST_DIRECTORY() itself must enforce that the tests are skipped only on Windows, or else sooner or later someone will accidentally do it wrong. There's currently no documentation either, making this much more likely.) In order to do this, ADD_TEST_DIRECTORY() needs to either accept a list of pairs of the form (testname, bug ID), or else accept two parallel lists (testnames and bug IDs), so it can pass the bug number to EXPECTED_FAILURE(). A slightly more difficult approach would be to introduce a new KNOWN_SEGFAULT() macro that handled this in conjunction with ADD_TEST_DIRECTORY(). I'm not totally sure this is a good idea, though, because it would (silently) not do anything for tests added by any means other than ADD_TEST_DIRECTORY(). To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/874679/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 874679] Re: Clean up second arg to ADD_TEST_DIRECTORY()
I was about to do this but I still have some question: You say: In order to do this, ADD_TEST_DIRECTORY() needs to either accept a list of pairs of the form (testname, bug ID), or else accept two parallel lists (testnames and bug IDs), so it can pass the bug number to EXPECTED_FAILURE(). With this approach you cannot determine INSIDE the macro which of the following things to do: 1. ADD_TEST 2. EXPECTED_FAILURE on all platforms 3. EXPECTED_FAILURE on Windows For the seg-faulting on Windows, EXPECTED_FAILURE can not be the solution. For the tests failing only on Windows, there is no way to determine the correct logic inside ADD_TEST_DIRECTORY based only on a test name and a bug number. This would only only for tests that failing uniformly on all platforms. So probably a KNOWN_SEGFAULT solution would be the only solution (at least from the ones you mentioned). Please give detail/feedback on this. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/874679 Title: Clean up second arg to ADD_TEST_DIRECTORY() Status in Zorba - The XQuery Processor: New Bug description: The second (optional) argument to ADD_TEST_DIRECTORY() contains a list of test cases that should be skipped (ie, not created at all). This is extremely dangerous. By bypassing them entirely, there is no way of detecting when the bug is fixed. We have already had serious problems caused by test removal hiding the introduction of new bugs in the past. I understand that removing a test that segfaults is necessary on Windows in order for the tests to run unattended. However, it should never be done on other platforms. So ADD_TEST_DIRECTORY() should instead mark the bugs as EXPECTED_FAILURE()s on other platforms. (I realize that *currently* all places that pass a list of segfaulting tests to ADD_TEST_DIRECTORY() are inside an IF(WIN32), but this is not sufficient - ADD_TEST_DIRECTORY() itself must enforce that the tests are skipped only on Windows, or else sooner or later someone will accidentally do it wrong. There's currently no documentation either, making this much more likely.) In order to do this, ADD_TEST_DIRECTORY() needs to either accept a list of pairs of the form (testname, bug ID), or else accept two parallel lists (testnames and bug IDs), so it can pass the bug number to EXPECTED_FAILURE(). A slightly more difficult approach would be to introduce a new KNOWN_SEGFAULT() macro that handled this in conjunction with ADD_TEST_DIRECTORY(). I'm not totally sure this is a good idea, though, because it would (silently) not do anything for tests added by any means other than ADD_TEST_DIRECTORY(). To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/874679/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867266] Re: Unexpected updating expression illegal here
This is an optimization (hoisting) problem. Reassigning to Markos. ** Changed in: zorba Assignee: Gabriel Petrovay (gabipetrovay) = Markos Zaharioudakis (markos-za) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867266 Title: Unexpected updating expression illegal here Status in Zorba - The XQuery Processor: New Bug description: This raises an error: 4,1: update static error [err:XUST0001]: updating expression illegal here; raised at /zorba/trunksrc/src/compiler/expression/fo_expr.cpp:222 variable $x:=a/; for $y in $x return replace value of node $x with x This doesn't: variable $x:=a/; for $y in $x return replace value of node $y with x To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867266/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 874676] Re: Remove SET_CMAKE_MODULE_PATH
Will this still be a problem after Zorba 2.1 is published? (Which should
happen any time now)
This feature/convenience is optional. Module Authors are not required to
use it at all if they want.
There is a better solution for this:
One can enhance the macro with two optional parameters that, if not defined, it
will have the default values:
${PROJECT_SOURCE_DIR}/cmake_modules
${PROJECT_SOURCE_DIR}/cmake_modules/Windows
With those two parameters the developer can provide whatever path he
wants to his cmake modules.
Opinions?
** Changed in: zorba
Assignee: Gabriel Petrovay (gabipetrovay) = Chris Hillery (ceejatec)
** Changed in: zorba
Status: New = Opinion
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/874676
Title:
Remove SET_CMAKE_MODULE_PATH
Status in Zorba - The XQuery Processor:
Opinion
Bug description:
This macro wasn't in Zorba 2.0. Therefore, using it in modules means
that those modules require Zorba 2.1 for building, even though they
(as far as I know) don't need it for running.
There will probably be cases in the future where such dependencies are
un-avoidable, but in this case SET_CMAKE_MODULE_PATH is at best a
small convenience, so I don't think it's worth the cost. In fact, I
think it's actually kind of a bad idea, because it enforces a
directory naming convention on module authors.
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/874676/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/mytrunk into lp:zorba
Review: Approve I still don't understand the #include situation. Clearly dict_en.cpp is not *yet* using ZORBA_NO_FULL_TEXT or else it wouldn't compile. What I'm guessing is that there is some other change coming from somewhere else which depends on having that #include. If so, IMHO then the #include should be added in conjunction with that change, not this one. Still, assuming for the moment that the #include will be necessary *someday*, I'm approving this change 'cause frankly this proposal has been beaten to death already... -- https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/mytrunk into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/mytrunk into lp:zorba has been updated. Commit Message changed to: fn:analyze-string fix For more details, see: https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165 -- https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/mytrunk into lp:zorba
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/changelog into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 - Reorganization of ChangeLog for 2.1 release - added the xqxq-module to the modules that are downloaded automatically -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'ChangeLog' --- ChangeLog 2011-11-17 13:07:37 + +++ ChangeLog 2011-11-23 04:08:25 + @@ -2,13 +2,28 @@ version 2.1 +New Features: + * New node-position module. This module allows to obtain a representation of a node position, which +can be used to assess structural relationships with other nodes. + * New node-reference module. References can be obtained for any node, and + different nodes cannot have the same identifier. + * Custom Full-text thesaurus using Zorba URI resolver mechanism. * Modified C++ API to add isSequential, getExternalVariables, and -isBoundExternalVariable Functions - * Custom Full-text thesaurus using Zorba URI resolver mechanism. + isBoundExternalVariable Functions + * Collection allows to retrieve information about the type + and the annotations of a static collection. + * Implemented the probe-index-range-value for general indexes + * Added ExternalFunctionParameter class to be registered in the DynamicContext + * New module for compiling and executing XQueries from XQuery (xqxq) + +Optimization: * Optimization for positioned sequence access (e.g. $x[$x[1]] where $x is a sequence of integers) - * documentation improvements - * installer improvements + * Optimization for count(collection()) expressions + * Optimization of the fn:substring function in the case when its $start and $length arguments + are integers + +Bug Fixes/Other Changes: * Fixed bug #3403291 (build for Fedora 15) * Fixed bug #3397293 (Incorrect XQueryX error message) * Fixed bug #3398637 (Nested element constructors cause loss of namespace bindings) @@ -20,8 +35,6 @@ * Fixed bug #3406200 (node types were not being moved to new tree during node detach) * Fixed bug #3406191 (Namespace bindings lost after update due to bug in node detach) * Fixed bug #3290122 (ZDST0003 needs collection name) - * Collection allows to retrieve information about the type - and the annotations of a static collection. * Fixed bug #3406272 (merging of adjacent text nodes must be done after all updates have been applied). * Fixed bug #3409344 (during detach, if the node being detached is the root of @@ -37,32 +50,25 @@ * Fixed bug #859968 (Using put on an attribute produces an invalid XDM instance and may cause segmentation faults) * Fixed bug #855314 (should not fold a constant expr that returns an error item) * Fixed bug when parsing a document with a base-uri attribute. - * Added ExternalFunctionParameter class to be registered in the DynamicContext * Fixed bug #863320 (Sentence is incorrectly incremented when token characters end without sentence terminator) * Fixed bug #863730 (static delete-node* functions don't raise ZDDY0012) - * Implemented the probe-index-range-value for general indexes * Removed ZSTR0005 and ZSTR0006 error codes * Fixed bug #868258 (Assertion failure with two delete collection) * Fixed bug #871623 and #871629 (assertion failures with insertions in dynamic collections) * Fixed bug #867262 (allow reuse of iterator over ExtFuncArgItemSequence) * Fixed bug #869024 (segmentation fault with node-reference) * Fixed bug #869025 (segmentation fault with node-reference) - * New node-reference module. References can be obtained for any node, and - different nodes cannot have the same identifier. - * Fixed bug #872697 (segmentation fault with validation of NMTOKENS) + * Fixed bug #872697 (segmentation fault with validation of NMTOKENS) * General index cannot be declared as unique if the type of its key is -xs:anyAtomicType or xs:untypedAtomic. + xs:anyAtomicType or xs:untypedAtomic. * Added undo for node revalidation - * Optimization for count(collection()) expressions * Fixed bug #867133 (SWIG PHP build failure on Mac OSX) - * Fixed bug #872796 (validate-in-place can interfere with other update primitives) + * Fixed bug #872796 (validate-in-place can interfere with other update primitives) * Fixed bug #872799 (validate-in-place can set incorrect types) - * Fixed bug #872850 (Serialization of Tumbling Window For fails) + * Fixed bug #872850 (Serialization of Tumbling Window For fails) * Fixed bug #855715 (Invalid escaped characters in regex not caught) * Fixed bug #862089 (Split binary/xq install directories for modules) by - splitting module path into separate URI and Library paths - * New node-position module. This module allows to obtain a
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/changelog into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/changelog-2011-11-23T04-12-12.911Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/changelog into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job changelog-2011-11-23T04-12-12.911Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/changelog into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83103 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/changelog into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 - Reorganization of ChangeLog for 2.1 release - added the xqxq-module to the modules that are downloaded automatically -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'ChangeLog' --- ChangeLog 2011-11-17 13:07:37 + +++ ChangeLog 2011-11-23 04:49:25 + @@ -2,13 +2,28 @@ version 2.1 +New Features: + * New node-position module. This module allows to obtain a representation of a node position, which +can be used to assess structural relationships with other nodes. + * New node-reference module. References can be obtained for any node, and + different nodes cannot have the same identifier. + * Custom Full-text thesaurus using Zorba URI resolver mechanism. * Modified C++ API to add isSequential, getExternalVariables, and -isBoundExternalVariable Functions - * Custom Full-text thesaurus using Zorba URI resolver mechanism. + isBoundExternalVariable Functions + * Collection allows to retrieve information about the type + and the annotations of a static collection. + * Implemented the probe-index-range-value for general indexes + * Added ExternalFunctionParameter class to be registered in the DynamicContext + * New module for compiling and executing XQueries from XQuery (xqxq) + +Optimization: * Optimization for positioned sequence access (e.g. $x[$x[1]] where $x is a sequence of integers) - * documentation improvements - * installer improvements + * Optimization for count(collection()) expressions + * Optimization of the fn:substring function in the case when its $start and $length arguments + are integers + +Bug Fixes/Other Changes: * Fixed bug #3403291 (build for Fedora 15) * Fixed bug #3397293 (Incorrect XQueryX error message) * Fixed bug #3398637 (Nested element constructors cause loss of namespace bindings) @@ -20,8 +35,6 @@ * Fixed bug #3406200 (node types were not being moved to new tree during node detach) * Fixed bug #3406191 (Namespace bindings lost after update due to bug in node detach) * Fixed bug #3290122 (ZDST0003 needs collection name) - * Collection allows to retrieve information about the type - and the annotations of a static collection. * Fixed bug #3406272 (merging of adjacent text nodes must be done after all updates have been applied). * Fixed bug #3409344 (during detach, if the node being detached is the root of @@ -37,32 +50,25 @@ * Fixed bug #859968 (Using put on an attribute produces an invalid XDM instance and may cause segmentation faults) * Fixed bug #855314 (should not fold a constant expr that returns an error item) * Fixed bug when parsing a document with a base-uri attribute. - * Added ExternalFunctionParameter class to be registered in the DynamicContext * Fixed bug #863320 (Sentence is incorrectly incremented when token characters end without sentence terminator) * Fixed bug #863730 (static delete-node* functions don't raise ZDDY0012) - * Implemented the probe-index-range-value for general indexes * Removed ZSTR0005 and ZSTR0006 error codes * Fixed bug #868258 (Assertion failure with two delete collection) * Fixed bug #871623 and #871629 (assertion failures with insertions in dynamic collections) * Fixed bug #867262 (allow reuse of iterator over ExtFuncArgItemSequence) * Fixed bug #869024 (segmentation fault with node-reference) * Fixed bug #869025 (segmentation fault with node-reference) - * New node-reference module. References can be obtained for any node, and - different nodes cannot have the same identifier. - * Fixed bug #872697 (segmentation fault with validation of NMTOKENS) + * Fixed bug #872697 (segmentation fault with validation of NMTOKENS) * General index cannot be declared as unique if the type of its key is -xs:anyAtomicType or xs:untypedAtomic. + xs:anyAtomicType or xs:untypedAtomic. * Added undo for node revalidation - * Optimization for count(collection()) expressions * Fixed bug #867133 (SWIG PHP build failure on Mac OSX) - * Fixed bug #872796 (validate-in-place can interfere with other update primitives) + * Fixed bug #872796 (validate-in-place can interfere with other update primitives) * Fixed bug #872799 (validate-in-place can set incorrect types) - * Fixed bug #872850 (Serialization of Tumbling Window For fails) + * Fixed bug #872850 (Serialization of Tumbling Window For fails) * Fixed bug #855715 (Invalid escaped characters in regex not caught) * Fixed bug #862089 (Split binary/xq install directories for modules) by - splitting module path into separate URI and Library paths - * New node-position module. This module allows to obtain a
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/changelog into lp:zorba has been updated. Commit Message changed to: - Reorganization of ChangeLog for 2.1 release - added the xqxq-module to the modules that are downloaded automatically For more details, see: https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/changelog into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/changelog-2011-11-23T04-50-11.305Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Validation queue job changelog-2011-11-23T04-50-11.305Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/changelog into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/changelog/+merge/83108 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/mytrunk into lp:zorba
Yes, it would compile, but with the wrong error messages. The way Paul implemented it, it doesn't raise compile errors if the error messages are incorrect. I don't know if it raises runtime errors. So that include is necessary right now, it was necessary for some time ago. -- https://code.launchpad.net/~danielturcanu/zorba/mytrunk/+merge/79165 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 874676] Re: Remove SET_CMAKE_MODULE_PATH
It's still a problem after 2.1 is released, because the modules will depend on 2.1 and won't be able to be built against 2.0. So they'll all need to be upgraded to list that dependency, even though in most cases they would work against 2.0 if it weren't for their use of this macro. It's probably not the most important problem we have facing us, I just think it sets a bad precedent. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/874676 Title: Remove SET_CMAKE_MODULE_PATH Status in Zorba - The XQuery Processor: Opinion Bug description: This macro wasn't in Zorba 2.0. Therefore, using it in modules means that those modules require Zorba 2.1 for building, even though they (as far as I know) don't need it for running. There will probably be cases in the future where such dependencies are un-avoidable, but in this case SET_CMAKE_MODULE_PATH is at best a small convenience, so I don't think it's worth the cost. In fact, I think it's actually kind of a bad idea, because it enforces a directory naming convention on module authors. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/874676/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
