Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
- The function check_xquery_feature_options is too long. Could this be simplified and/or split into multiple functions? DONE -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
- It feels like most of the implementation should go into the translator and not into the static context. DONE -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
- The style of the error messages is not consistent with the other error messages. They should be changed as follows: XQST0120 $1: feature not supported XQST0128 $1: unable to disable a supported feature XQST0126 impossible to activate all extension features DONE -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
I think I addressed all comments. There are three expected failures left: EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature require-higher-order-function-5-s 0) EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature require-higher-order-function-10-s 0) - This is the for $f in () return $f(1, ?) issue, which needs to be solved separately. EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature require-all-optional-features-5-s 0) - This is because the new package with the W3C-FOTS fix is not there yet. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
I opened the bug for the first two expected failures here: bug 1171860. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature require-all-optional-features-5-s 0) - I removed it because the test suite got updated in the trunk. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Review: Disapprove Disapproving to allow running tests without merging. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 2 Approve, 1 Disapprove, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
- The fix for dynamic_function_invocation seems to be orthogonal. Why is this fixed in this merge proposal? I couldn't find a test to cover this behavior. It does fix some of the W3C tests: for $f in () return $f(1, ?) Raised an error in zorba because it was considered an object lookup. But it looks like valid XQuery to me? This is one of the cases that we will have to live with. It's a conflict between JSONiq and HOF. We were trying to push the W3C to make the dynamic function invocation a map (i.e. $f could be () or a sequence of function items). However, the w3c didn't want to go this way. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Review: Approve awesome -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
This is one of the cases that we will have to live with. It's a conflict between JSONiq and HOF. We were trying to push the W3C to make the dynamic function invocation a map (i.e. $f could be () or a sequence of function items). However, the w3c didn't want to go this way. - In this case, $f is not the empty object - it is just a virtual single item (as is always the case for a for variable, without allowing empty) that it will never get bound to. We do not have to consider $f an object lookup in this case, right? I have the more general feeling that there might be something wrong in type inference regarding for loops on empty sequences. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
We do not have to consider $f an object lookup in this case, right? I have the more general feeling that there might be something wrong in type inference regarding for loops on empty sequences. Since there is a partial application ?, it definitely cannot be an object lookup. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
- The fix for dynamic_function_invocation seems to be orthogonal. Why is this fixed in this merge proposal? I couldn't find a test to cover this behavior. It does fix some of the W3C tests: for $f in () return $f(1, ?) Raised an error in zorba because it was considered an object lookup. But it looks like valid XQuery to me? -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug-1123165-2013-04-19T14-11-47.953Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Review: Needs Fixing - The fix for dynamic_function_invocation seems to be orthogonal. Why is this fixed in this merge proposal? I couldn't find a test to cover this behavior. - The function check_xquery_feature_options is too long. Could this be simplified and/or split into multiple functions? It feels like most of the implementation should go into the translator and not into the static context. - The style of the error messages is not consistent with the other error messages. They should be changed as follows: XQST0120 $1: feature not supported XQST0128 $1: unable to disable a supported feature XQST0126 impossible to activate all extension features -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Ghislain, could you also please remove the fix that you submitted for scanner.l problem? Your proposal works, but on linux the GCC gives off a warning for that code. I have a proposal that fixes the issue in another branch, which Matthias will approve and merge soon. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
I too agree that it should be moved to the translator. That's where all the similar code currently is. Other than this and the scanner issue, it looks good for me. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1123165 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp