[JDK-8231144](https://bugs.openjdk.java.net/browse/JDK-8231144) wrapped the
contents of plain HTML documents into `` to apply
the styles and add the margins around the content for a consistent look.
This is no longer necessary after
On Tue, 12 Jan 2021 20:36:21 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/com/sun/media/sound/InvalidDataException.java
>> line 42:
>>
>>> 40: */
>>> 41: @Serial
>>> 42: private static final long serialVersionUID = 1L;
>>
>> This is the standard wording, yet
On Mon, 11 Jan 2021 06:21:52 GMT, Sergey Bylokhov wrote:
> Please review the application of @java.io.Serial annotation (JDK-8202385) to
> types in the desktop module to enable stricter compile-time checking of
> serialization-related declarations.
>
> This annotation can be applied to these
On Wed, 18 Nov 2020 09:11:11 GMT, Sergey Bylokhov wrote:
> The fix for https://bugs.openjdk.java.net/browse/JDK-8137571 where HiDPI
> support on Linux was implemented missed the change in the X11 pipeline, only
> XRender pipeline was updated. The same logic should be implemented in
>
On Tue, 10 Nov 2020 18:40:45 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/sun/java2d/SunGraphicsEnvironment.java line
>> 357:
>>
>>> 355: * @param config the graphics configuration which bounds are
>>> requested
>>> 356: * @return the bounds of the area covered by
On Wed, 28 Oct 2020 23:46:55 GMT, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk.
>>
>> Old review request:
>> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>>
>>
>> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
>> should
On Mon, 2 Nov 2020 09:04:39 GMT, Sergey Bylokhov wrote:
> Most of the broken links were fixed already by the JDK-8225368 and JDK-8214817
> This change fix just a few.
>
> Also two cleanups are applied:
> - The `../../java/awt/doc-files/` in some cases simplified to `doc-files/`
> - The html
On Sun, 4 Oct 2020 06:22:45 GMT, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk.
>>
>> Old review request:
>> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>>
>>
>> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
>> should
On Mon, 28 Sep 2020 15:20:33 GMT, Alexander Zuev wrote:
> Moving review from Mercurial. See
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016078.html for
> previous
> iteration.
src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 986:
> 984:
On Fri, 2 Oct 2020 23:29:10 GMT, Sergey Bylokhov wrote:
>> @aivanov-jdk Can you review this?
>
> I still suggest to try the approach recommended here:
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016074.html
>
> On 29.05.2020 14:35, Alexey Ivanov wrote:
On Fri, 18 Sep 2020 17:05:42 GMT, skodanda
wrote:
> Hello All,
>
> Could you please review a TEST_BUG fix for the JDK 16?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8248352
>
> Problem description: The test
> test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially
Looks good.
Regards,
Alexey
On 18/08/2020 15:23, Kumar Abhishek wrote:
Hi Alexey,
Please find the updated Webrev link here:-
http://cr.openjdk.java.net/~arapte/Abhishek/8200281/webrev.05
I have updated the missed annotation.
Thanks,
Abhishek
-Original Message-
From: Alexey Ivanov
/webrev.04/
Thanks,
Abhishek
-Original Message-
From: Alexey Ivanov
Sent: Thursday, August 6, 2020 3:20 AM
To: Kumar Abhishek
Cc: Dmitry Markov ; Philip Race ;
2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations
in I
There are also several unused imports in WBMPImageWriter.java which can
be removed.
On 05/08/2020 22:49, Alexey Ivanov wrote:
*WBMPImageWriter.java*
Missing @Override annotation:
137 public boolean canWriteRasters() {
--
Regards,
Alexey
wrote:
Hi Dmitry,
I have updated the year in the copyright section for the modified file.
Please find the updated Webrev:-
http://cr.openjdk.java.net/~jdv/8200281/webrev.03/
Thanks,
Abhishek
-Original Message-
From: Alexey Ivanov
Sent: Saturday, July 25, 2020 2:38 AM
To: Kumar Abhishek
Hi Abhishek,
*JPEGImageWriter.java*
240 public IIOMetadata convertStreamMetadata(IIOMetadata inData,
255 public IIOMetadata
256 convertImageMetadata(IIOMetadata inData,
1751 public synchronized void dispose() {
These methods are missed: no @Override annotation. In the
Hi Sergey,
Looks good to me.
Yet I don't quite understand the test. Does the test confirm, no print
services are returned if a SecurityManager is installed?
Regards,
Alexey
On 05/04/2020 02:40, Sergey Bylokhov wrote:
Hello,
Here is an updated patch:
On 02/04/2020 19:41, Sergey Bylokhov wrote:
On 4/2/20 10:51 am, Alexey Ivanov wrote:
What about this?
// Open the local printer server
BOOL ret = OpenPrinter(NULL, , NULL);
I found it useful, otherwise, I would be the first who deleted it.
Okay. Let the local variable live.
Concise
On 02/04/2020 03:56, Sergey Bylokhov wrote:
On 4/1/20 7:38 am, Alexey Ivanov wrote:
I agree, I'd remove printerName local variable. You can modify the
original comment:
// If pPrinterName (the first parameter) is NULL, "it indicates
the local printer server" - MSDN.
But
Thank you to Marc for updating webrev and to Sergey for uploading it.
The changes look fine to me as I already stated.
I just wanted to share more comments:
On 22/02/2020 09:50, Sergey Bylokhov wrote:
Thank you, an updated version is upload:
http://cr.openjdk.java.net/~serb/8237746/webrev.01
Shall the copyright year be updated in all the modified files?
Please let me know what would be the correct process.
Cheers,
-marc
On 17. Feb 2020, at 15:40, Alexey Ivanov
wrote:
Thank you, Marc, for your contribution.
And thank you to Sergey for creating the review.
*Font2DTest.java*
674
I have added the same for future
reference.
Thanks,
Jay
On 24-Feb-2020, at 7:15 PM, Alexey Ivanov wrote:
I'm still waiting for a second reviewer.
Anyone?
Thank you in advance!
On 17/02/2020 12:56, Alexey Ivanov wrote:
Thank you, Sergey, for your review!
Any other volunteers?
On 06/02
I'm still waiting for a second reviewer.
Anyone?
Thank you in advance!
On 17/02/2020 12:56, Alexey Ivanov wrote:
Thank you, Sergey, for your review!
Any other volunteers?
On 06/02/2020 23:10, Sergey Bylokhov wrote:
Looks fine.
On 2/6/20 1:39 pm, Alexey Ivanov wrote:
Hello once again
Thank you, Marc, for your contribution.
And thank you to Sergey for creating the review.
*Font2DTest.java*
674 if ( selectedText == fp.USER_TEXT )
675 userTextDialog.setVisible(true);
676 else
677 userTextDialog.setVisible(false);
I'd put the braces around
Thank you, Sergey, for your review!
Any other volunteers?
On 06/02/2020 23:10, Sergey Bylokhov wrote:
Looks fine.
On 2/6/20 1:39 pm, Alexey Ivanov wrote:
Hello once again,
After trying a few things suggested by Sergey, I found serious issues
in the new approaches although the code looked
Vote: yes
On 17/02/2020 08:49, Anton Tarasov wrote:
I hereby nominate Dmitry Batrak to JDK Committer.
Dmitry Batrak has contributed 8 significant fixes to Java 2D subsystem,
related to font rendering [3].
--
Regards,
Alexey
in passiveDCList when another DC is
requested.
With the fix, when running ManyFramesTest.java test case, the number of
entries in passiveDCList does not grow, the list contains at most 1 entry.
On 12/12/2019 20:46, Alexey Ivanov wrote:
Hi Sergey,
It does not work good. I found serious issues
Hi Sergey,
On 09/12/2019 21:26, Alexey Ivanov wrote:
Hi Sergey
On 04/12/2019 22:17, Sergey Bylokhov wrote:
On 12/4/19 6:06 am, Alexey Ivanov wrote:
Yes, we still need passiveDCList. A DC can be moved to the passive
list by DisposeThreadGraphicsInfo function in
GDIWindowSurfaceData.cpp
Hi Sergey
On 04/12/2019 22:17, Sergey Bylokhov wrote:
On 12/4/19 6:06 am, Alexey Ivanov wrote:
Yes, we still need passiveDCList. A DC can be moved to the passive
list by DisposeThreadGraphicsInfo function in
GDIWindowSurfaceData.cpp. This is called not on the toolkit thread,
so we have
On 04/12/2019 02:29, Sergey Bylokhov wrote:
On 12/2/19 2:45 am, Alexey Ivanov wrote:
We can have two different functions though:
ReleaseActiveDCs(HWND);
ReleasePassiveDCs();> Then we can drop the list parameter.
What do you think?
Yes, it is worth to try.
BTW it would be good to know do
Hi Sergey,
On 03/12/2019 18:23, Sergey Bylokhov wrote:
Hi, Alexey.
The fix looks fine, how did you find this issue? Axe and w3c online
validator are silent about it.
I used W3C validator, it reports the following errors [4]:
Error: Row 2 of a row group established by a |thead| element has
,
Brian
[1]
https://docs.oracle.com/en/java/javase/13/docs/api/java.desktop/javax/imageio/metadata/doc-files/tiff_metadata.html#Compression
On Dec 3, 2019, at 3:34 AM, Alexey Ivanov <mailto:alexey.iva...@oracle.com>> wrote:
Please review the following fix:
JBS:https://bugs.openjdk
On 28/11/2019 18:13, Alexey Ivanov wrote:
Hello,
Please review the following fix which removes the use of
ID2D1Factory::GetDesktopDpi API which is deprecated in VS2019.
JBS: https://bugs.openjdk.java.net/browse/JDK-8234398
Webrev: http://cr.openjdk.java.net/~aivanov/8234398/webrev.00/
I
Hello,
Please review the following fix:
JBS: https://bugs.openjdk.java.net/browse/JDK-8235245
Webrev: http://cr.openjdk.java.net/~aivanov/8235245/webrev.00/
The file tiff_metadata.html has a misplaced element which
breaks the structure.
The fix corrects the problem and makes the HTML
moveDC(hDC, hWnd)) != NULL) {
We can have two different functions though:
ReleaseActiveDCs(HWND);
ReleasePassiveDCs();
Then we can drop the list parameter.
What do you think?
On 12/1/19 7:04 am, Alexey Ivanov wrote:
Hello,
Please review the following fix for JDK:
JBS: https://bugs.openjd
Hello,
Please review the following fix which removes the use of
ID2D1Factory::GetDesktopDpi API which is deprecated in VS2019.
JBS: https://bugs.openjdk.java.net/browse/JDK-8234398
Webrev: http://cr.openjdk.java.net/~aivanov/8234398/webrev.00/
I have tested the new code on Windows 7 and 8.0,
:42, Alexey Ivanov wrote:
Hi Yasumasa,
I think this belongs to 2d-dev list.
On 07/11/2019 00:16, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8233707
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8233707/webrev.00/
I tried
Hi Yasumasa,
I think this belongs to 2d-dev list.
On 07/11/2019 00:16, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8233707
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8233707/webrev.00/
I tried to build OpenJDK with VS
On 24/10/2019 08:48, Sergey Bylokhov wrote:
On 10/23/19 3:32 pm, Alexey Ivanov wrote:
I'm confused now. Why would we exclude 32-bit Windows? It is the only
platform where the original bug could be reproduced and where OOME or
NPE is thrown in the test. With 64-bit platforms, it's nearly
On 23/10/2019 17:54, Sergey Bylokhov wrote:
On 10/22/19 6:09 am, Alexey Ivanov wrote:
Then, isn't it is a product bug on windows rather than a test issue?
That it runs for a long time? It's hard to say… The test has always
been slower on Windows.
Then probably we can exclude windows 32bit
On 22/10/2019 00:15, Sergey Bylokhov wrote:
On 10/21/19 3:48 pm, Alexey Ivanov wrote:
Yes, I noticed that the test is pretty fast both on Linux and Mac but
it's not as fast on Windows. In fact, I reproduced the bug only on
Windows and only on 32 bit. The bug was in shared code, that's why
Hi Sergey,
On 21/10/2019 20:47, Sergey Bylokhov wrote:
Hi, Alexey.
On 10/21/19 12:11 pm, Alexey Ivanov wrote:
I was running this test in different configurations and found that
the expected exception is thrown at 20-25 thousand iterations
(32-bit). It usually takes 3-4 minutes
Hello,
Please review the fix for the test:
bug: https://bugs.openjdk.java.net/browse/JDK-8232634
webrev: http://cr.openjdk.java.net/~aivanov/8232634/webrev.00/
The test exhausts native memory so that a memory allocation fails. This
situation is quite easy to achieve with 32 bit processes but
.
-phil.
On 10/7/19 5:07 AM, Alexey Ivanov wrote:
Hi Phil,
Thank you for your review.
I have updated the summary of the bug to be more specific: “Java does
not render Myanmar script correctly”.
This fix addresses only the rendering of Myanmar characters. Adding
Myanmar script and related languages
doing here on the display side.
-phil.
On 10/3/19 10:28 AM, Alexey Ivanov wrote:
Hi Phil,
Thank you for your review.
Please see my answers inline:
On 03/10/2019 17:31, Philip Race wrote:
1) This is an RFE, not a bug.
I have updated the CR type to RFE.
2) Does this font exist on Windows 7 ?
N
.
It can be brought to 11 updates.
Regards,
Alexey
-phil.
On 10/3/19, 8:57 AM, Alexey Ivanov wrote:
Any volunteers to review?
On 25/09/2019 20:38, Alexey Ivanov wrote:
Hello,
Please review the fix for JDK 14:
bug: https://bugs.openjdk.java.net/browse/JDK-8223558
webrev: http
Any volunteers to review?
On 25/09/2019 20:38, Alexey Ivanov wrote:
Hello,
Please review the fix for JDK 14:
bug: https://bugs.openjdk.java.net/browse/JDK-8223558
webrev: http://cr.openjdk.java.net/~aivanov/8223558/webrev.00/
Problem description:
Java renders Myanmar script incorrectly. Some
Hello,
Please review the fix for JDK 14:
bug: https://bugs.openjdk.java.net/browse/JDK-8223558
webrev: http://cr.openjdk.java.net/~aivanov/8223558/webrev.00/
Problem description:
Java renders Myanmar script incorrectly. Some glyphs are not combined,
which makes text unreadable.
For example,
Hello,
Please review the following simple fix for JDK 14:
bug: https://bugs.openjdk.java.net/browse/JDK-8231144
webrev: http://cr.openjdk.java.net/~aivanov/8231144/webrev.00/
docs:
http://cr.openjdk.java.net/~aivanov/8231144/docs.00/api/java.desktop/module-summary.html
Plain HTML
On 16/09/2019 20:09, Alexey Ivanov wrote:
Hi Sergey,
This version looks good to me.
On 09/09/2019 23:14, Sergey Bylokhov wrote:
Hi, Alexey.
- Modality.html: The was dropped from everywhere, it does not
seems to be useful
I think was used to make a term / concept stand out from its
ore.
Let's leave it that way for now.
- Modality.html: An example block was reworked as suggested:
http://cr.openjdk.java.net/~serb/8225372/docs.03/api/java.desktop/java/awt/doc-files/Modality.html
On 9/3/19 10:55 am, Alexey Ivanov wrote:
It looks fine to me. And it has more semantic markup
/~serb/8225372/docs.01/api/java.desktop/module-summary.html
See comments inline:
On 14/06/2019 09:19, Alexey Ivanov wrote:
*GridBagLayout.java*
Does it make sense to use nested lists for valid values> It could
make the presentation clearer rather than a paragraph followed by a
list.
We
Looks good to me too.
Regards,
Alexey
On 28/08/2019 03:56, Sergey Bylokhov wrote:
+1
On 8/27/19 10:34 am, Jayathirth Rao wrote:
Hi Phil,
I went through the changes and I see that we are doing similar
dynamic loading of d2d1.dll as we are doing for shcore.dll and
loading code looks good.
://docs.microsoft.com/en-us/windows/win32/printdocs/enumprinters
[2] https://docs.microsoft.com/en-us/windows/win32/printdocs/printer-info-4
On 03/07/2019 19:46, Alexey Ivanov wrote:
Hi Phil,
Thank you for your review! That's a valid point!
Please see the updated webrev:
http://cr.openjdk.java.net
t.sort(ComparableTimSort.java:188)
at java.util.Arrays.sort(Arrays.java:1246)
at Sort.main(Sort.java:4)
-phil.
On 7/2/19, 5:18 AM, Alexey Ivanov wrote:
Are there any other comments?
Other volunteers for reviewing?
Thanks in advance.
On 25/06/2019 20:17, Alexey Ivanov wrote:
Please see the updated w
Are there any other comments?
Other volunteers for reviewing?
Thanks in advance.
On 25/06/2019 20:17, Alexey Ivanov wrote:
Please see the updated webrev:
http://cr.openjdk.java.net/~aivanov/8222108/webrev.01/
On 25/06/2019 00:01, Sergey Bylokhov wrote:
On 24/06/2019 14:50, Alexey Ivanov
Please see the updated webrev:
http://cr.openjdk.java.net/~aivanov/8222108/webrev.01/
On 25/06/2019 00:01, Sergey Bylokhov wrote:
On 24/06/2019 14:50, Alexey Ivanov wrote:
I guess that the change in doCompare() passed a review because it
was assumed that the code inside will take care
he test, the list of printers always has the same order. We
do not sort the array returned by getAllPrinterNames() in
PrintServiceLookupProvider.refreshServices(), so I assume Windows
returns the installed printers in the same order. Therefore I think
sorting the array is not necessary in t
Hi,
Please review the following fix for JDK 13:
bug: https://bugs.openjdk.java.net/browse/JDK-8222108
webrev: http://cr.openjdk.java.net/~aivanov/8222108/webrev.00/
The main goal of this bug was to reduce the minimum refresh time for
updating remote printer list to facilitate testing.
While
Hi Sergey,
*GridBagLayout.java*
Does it make sense to use nested lists for valid values?
It could make the presentation clearer rather than a paragraph followed
by a list.
Line 125–
Absolute Values:
{@code GridBagConstraints.NORTH}
Orientation
Thank you, Sergey and Phil, for your review!
--
Alexey
On 08/04/2019 22:21, Phil Race wrote:
+1
-phil.
On 4/8/2019 12:14 PM, Sergey Bylokhov wrote:
On 08/04/2019 03:14, Alexey Ivanov wrote:
Exactly! I would've done it if it had been possible.
Changing the minRefreshTime requires changes
On 05/04/2019 23:32, Sergey Bylokhov wrote:
On 05/04/2019 15:30, Sergey Bylokhov wrote:
On 03/04/2019 09:35, Alexey Ivanov wrote:
We can make minRefreshTime equal to 2 minutes but leave the default
refresh time of 4 minutes. Does it sound good? This way the time of
waiting for two refresh
Hi Phil, Sergey,
On 01/04/2019 13:08, Alexey Ivanov wrote:
On 29/03/2019 20:35, Sergey Bylokhov wrote:
But it looks like an overkill to wait 8 minutes for one test, isn't it?
I agree 8 minutes seem too much. However, I admit it might take even
more time to setup a network printer
On 29/03/2019 08:28, Alexey Ivanov wrote:
Please take a look at the updated webrev where I've removed @ignore
tag from the test:
http://cr.openjdk.java.net/~aivanov/8221263/webrev.1/
On 29/03/2019 01:09, Philip Race wrote:
Are you looking for a reason other than that the implementation
is set
you add
the step6 to the instruction.
197 + "updated.\n"
198 + "Step 6: If the list is not updated, wait
for another "
199 + "4 minutes, and then click Refresh
again.\n"
On 28/03/2019 0
On 28/03/2019 17:15, Philip Race wrote:
> I've run SplashScreen jtreg tests, all tests pass.
I assume you mean you did this for 32 AND 64 bit builds ?
Yes, I ran the tests for both 32 and 64 bit builds.
--
Alexey
If so, then +1
-phil.
On 3/28/19, 9:11 AM, Alexey Ivanov wrote:
Any volunteers for review?
On 24/03/2019 19:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows
Hi,
Please review the following fix for jdk 13:
bug: https://bugs.openjdk.java.net/browse/JDK-8221263
webrev: http://cr.openjdk.java.net/~aivanov/8221263/webrev.0/
This is a complete re-write of the test.
It's semi-automatic: the tester is to add or remove a remote printer and
to make sure
umPrinters(PRINTER_ENUM_CONNECTIONS, …
If the list is not empty, it contains only remote printers. Nothing to
filter.
Regards,
Alexey
-phil.
On 3/26/19, 1:22 PM, Alexey Ivanov wrote:
Please see the updated webrev:
http://cr.openjdk.java.net/~aivanov/8221412/webrev.1/
The difference between .0 and .1
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows. It's because
the functions in splashscreen.dll are exported with
On 21/02/2019 22:48, Sergey Bylokhov wrote:
On 21/02/2019 04:23, Alexey Ivanov wrote:
Thank you, Sergey, for looking into this.
I guess this case requires more investigation. At first sight, it
does not look right, does it?
Right, I am not sure that "IndexColorModel" i
On 20/02/2019 01:38, Sergey Bylokhov wrote:
Hi, Andrey.
I found only one questionable place in the fix:
==
/**
* Returns an object created with id=key. If the object is not of
- * type type, this will throw an exception.
+ * that type, this will throw an
On 14/02/2019 22:39, Sergey Bylokhov wrote:
On 14/02/2019 13:02, Alexey Ivanov wrote:
BTW do we sure that the usage of IndexColorModel is not a bug?
I don't think it's a bug. Likely Windows Server OS is installed in
Server Code mode which has limited GUI support.
I was able to get
Hi Andrey,
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java
/*
* Used to override if system (desktop) text anti-aliasing
settings should
- * be used. The reasons for this are are is that currently its "off"
+ * be used. The reasons for this are
/2019 06:07, Alexey Ivanov wrote:
Hi Sergey,
Do you have any comments for the latest webrev:
http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/
Do I push the fix?
Regards,
Alexey
On 12/02/2019 18:33, Phil Race wrote:
+1
-phil.
On 2/12/19 6:24 AM, Alexey Ivanov wrote:
Hi Phil
Hi Sergey,
Do you have any comments for the latest webrev:
http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.01/
Do I push the fix?
Regards,
Alexey
On 12/02/2019 18:33, Phil Race wrote:
+1
-phil.
On 2/12/19 6:24 AM, Alexey Ivanov wrote:
Hi Phil,
On 11/02/2019 18:32, Phil Race
Hi Phil,
On 11/02/2019 18:32, Phil Race wrote:
On 2/11/19 1:44 AM, Alexey Ivanov wrote:
Hi Phil,
On 08/02/2019 21:02, Phil Race wrote:
can you add
@key headful
to all these tests ?
Yes, I can if you think it's required.
Yes. I think it is required.
Please see the updated webrev:
http
On 12/02/2019 02:14, Sergey Bylokhov wrote:
On 11/02/2019 10:41, Alexey Ivanov wrote:
Let me experiment with this.
Would it be acceptable if I submit a new CR to improve these tests?
Ok, fine.
Submitted https://bugs.openjdk.java.net/browse/JDK-8218827
--
Regards,
Alexey
On 11/02/2019 18:27, Sergey Bylokhov wrote:
On 11/02/2019 09:28, Alexey Ivanov wrote:
No, it does not look like it's possible directly.
In the case of DashOffset, VolatileImage contains #F8F8F8 instead of
#FF, #CC instead of #FF, #00CC00 instead of #00FF00. In
other
Hi Sergey,
On 11/02/2019 17:03, Sergey Bylokhov wrote:
Hi, Alexey.
On 11/02/2019 01:44, Alexey Ivanov wrote:
Isn't isHeadless() used by jtreg itself?
These tests seem to have failed only in Windows where there's no true
headless environment. Recent versions of Windows Server allow
message for skipping
VolatileImage when IndexColorModel is in effect…
Regards,
Alexey
-phil.
On 2/8/19 12:13 PM, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13:
bugs:
https://bugs.openjdk.java.net/browse/JDK-8218682
https://bugs.openjdk.java.net/browse/JDK-8198411
webrev:
http
Hi,
Please review the fix for jdk 13:
bugs:
https://bugs.openjdk.java.net/browse/JDK-8218682
https://bugs.openjdk.java.net/browse/JDK-8198411
webrev:
http://cr.openjdk.java.net/~aivanov/8218682-8198411/webrev.00/
Description:
The updated DashOffset test proved to fail in mach5.
It passed
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217263
webrev: http://cr.openjdk.java.net/~aivanov/8217263/webrev.00/
Description:
The test has been re-worked to an automatic test.
It uses only 2D API. When run in headful environment, it also tests with
Looks good.
There's one inconsistency though:
java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterDevice.java
72 return new GraphicsConfiguration[] {config};
In all the other implementations of getConfigurations() method, there's
no space between brackets and braces.
Shall the
Hi Sergey,
Looks good to me.
On 11/01/2019 22:33, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211885
Webrev: http://cr.openjdk.java.net/~serb/8211885/webrev.00
Duplicated and unused id were removed from the javadoc.
--
Sure!
+1
Regards,
Alexey
On 07/12/2018 09:22, Jayathirth D V wrote:
Hi Alexey,
Thanks for the review.
I will add space before pushing the change.
Regards,
Jay
-Original Message-
From: Alexey Ivanov
Sent: Thursday, December 06, 2018 12:45 AM
To: Jayathirth D V; 2d-dev
Subject: Re
Hi Jay,
“modified UTF-8” had space before but it doesn't.
Otherwise, looks good.
Regards,
Alexey
On 05/12/2018 12:35, Jayathirth D V wrote:
Hello All,
Please review the following fix in JDK12:
Bug : https://bugs.openjdk.java.net/browse/JDK-8214817
Webrev :
Hi Prasanta,
Looks good to me.
Regards,
Alexey
On 30/11/2018 17:23, Prasanta Sadhukhan wrote:
Hi Alexey,
Ok. Modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.2/
Regards
Prasanta
On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:
Hi Prasanta,
Adding style="text-align: c
1/
Regards
Prasanta
On 30-Nov-18 4:50 PM, Alexey Ivanov wrote:
Hi Prasanta,
Would the presentation benefit from
to keep X centred and thus to preserve the visual appearance?
Do you mind updating the copyright?
Otherwise, the change looks good to me.
Regards,
Alexey
On 30/11/2018 07:41, Prasanta
Hi Prasanta,
Would the presentation benefit from
to keep X centred and thus to preserve the visual appearance?
Do you mind updating the copyright?
Otherwise, the change looks good to me.
Regards,
Alexey
On 30/11/2018 07:41, Prasanta Sadhukhan wrote:
Hi All,
Please review a doc-fix to
Thank you!
--
Alexey
On 04/05/2018 18:53, Phil Race wrote:
Yes, your confirmation on the testing was all that was needed.
-phil.
On 5/4/2018 10:45 AM, Alexey Ivanov wrote:
Hi Phil,
Just to confirm: do you approve the change?
Thank you,
Alexey
On 02/05/2018 19:24, Alexey Ivanov wrote:
Hi
Hi Phil,
Just to confirm: do you approve the change?
Thank you,
Alexey
On 02/05/2018 19:24, Alexey Ivanov wrote:
Hi Phil,
Thank you for your review.
On 02/05/2018 17:28, Phil Race wrote:
So ... the original change that removed the mapfiles broke the 32 bit
build
because of inconsistency
as well.
/Magnus
2 maj 2018 kl. 11:52 skrev Alexey Ivanov <alexey.iva...@oracle.com>:
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202476
webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/
This is a follow-
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202476
webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/
This is a follow-up fix for JDK-8201226 which enabled building JDK for
32 bit Windows, its code review:
Hi,
Could you please review the following backport to 8u-dev?
jbs: https://bugs.openjdk.java.net/browse/JDK-8201240
review: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009122.html
jdk11 changeset: http://hg.openjdk.java.net/jdk/client/rev/69f7e3ed043c
The patch does not apply
Hi,
Could you please review the following backport to 8u-dev?
jbs: https://bugs.openjdk.java.net/browse/JDK-8201433
review: http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009129.html
jdk11 changeset: http://hg.openjdk.java.net/jdk/client/rev/4ed714d1f90b
The patch does not apply
, Matthias
-Original Message-
From: Alexey Ivanov [mailto:alexey.iva...@oracle.com]
Sent: Donnerstag, 12. April 2018 23:53
To: Phil Race <philip.r...@oracle.com>; Baesken, Matthias
<matthias.baes...@sap.com>; Alan Bateman <alan.bate...@oracle.com>;
Magnus Ihse Bursi
other purposes.
The test exhausts the available native memory to make malloc fail. The
amount of used memory reaches close to 2G before it fails.
Regards,
Alexey
On 12/04/2018 08:25, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk11:
bug: https://bugs.openjdk.java.net/browse/JDK-8
Hi Alan , this is the up to date webrev .
However we want to add Alexey Ivanov as additional author .
As I read it, this changes the calling convention of these functions on
32-bit Windows but it will have no impact on 64-bit Windows (as
__stdcall is ignored) or other platforms, is that cor
, but
no response so far .
Maybe the submit repo is not working currently , not sure about it .
Best regards , Matthias
-Original Message-
From: Baesken, Matthias
Sent: Mittwoch, 11. April 2018 11:20
To: 'Alexey Ivanov' <alexey.iva...@oracle.com>; Magnus Ihse Bursie
<magnus
101 - 200 of 224 matches
Mail list logo
