Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Thanks, Laurent Le 18 août 2017 7:29 PM, "Phil Race" a écrit : > CSR was approved and I have pushed the new API. > > -phil. > > On 08/17/2017 08:31 AM, Philip Race wrote: > > I have filed https://bugs.openjdk.java.net/browse/JDK-8186364 > and created and submitted the

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

CSR was approved and I have pushed the new API. -phil. On 08/17/2017 08:31 AM, Philip Race wrote: I have filed https://bugs.openjdk.java.net/browse/JDK-8186364 and created and submitted the CSR for it : https://bugs.openjdk.java.net/browse/JDK-8186365 -phil. On 8/17/17, 8:05 AM, Philip Race

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

I have filed https://bugs.openjdk.java.net/browse/JDK-8186364 and created and submitted the CSR for it : https://bugs.openjdk.java.net/browse/JDK-8186365 -phil. On 8/17/17, 8:05 AM, Philip Race wrote: OK I'll handle the bureaucracy. -phil. On 8/17/17, 7:31 AM, Laurent Bourgès wrote: Phil,

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

OK I'll handle the bureaucracy. -phil. On 8/17/17, 7:31 AM, Laurent Bourgès wrote: Phil, Thanks for the explanations. I am not at home until next week so I would prefer if you can create the new CSR and related bugs. As I said, this patch was reviewed and I want it to be pushed in jdk10

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Phil, Thanks for the explanations. I am not at home until next week so I would prefer if you can create the new CSR and related bugs. As I said, this patch was reviewed and I want it to be pushed in jdk10 finally. PS: I worked again on Marlin to implement an efficient path clipper that is

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

It seems we are going to have to file a completely new bug for this. It is not just a case of your permissions. The migrated "CCC" can't be set to fix version 10. So Joe Darcy suggested creating a backport targeted to 10 and creating a CSR from that but it turns out backports can't have CSRs.

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Ping ? In holidays ? Le 13 juil. 2017 9:36 AM, "Laurent Bourgès" a écrit : > Jim or Phil, > Could you handle the CSR process on that patch and then push it in jdk10 ? > > I consider that bug finished on my side. > > Laurent > > Le 8 juil. 2017 10:02, "Laurent Bourgès"

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Phil, Here are my comments on this CSR to be fixed in openjdk 10; I already submitted a patch and the review process happened in may. Le 3 juil. 2017 7:41 PM, "Phil Race" a écrit : Laurent, Investigation has determined that since this was ported over in the "CCC

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Phil, Here are my comments on this CSR to be fixed in openjdk 10; I already submitted a patch and the review process happened in may. Le 3 juil. 2017 7:41 PM, "Phil Race" a écrit : Laurent, Investigation has determined that since this was ported over in the "CCC

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Laurent, Investigation has determined that since this was ported over in the "CCC migration project", due to the way that is set up it can't be assigned to non-Oracle employees. It won't affect any new CSRs that are created. Since the likelihood of any other similar case is extremely low,

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

OK. Although we still need to wait for the CSR process. -phil. On 4/20/17, 3:05 PM, Laurent Bourgès wrote: Sorry (bad shortcut); Here is the fixed webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.3/ Laurent

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Sorry (bad shortcut); Here is the fixed webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.3/ Laurent 2017-04-21 0:04 GMT+02:00 Laurent Bourgès : > Sorry for the typo, I added also a newline before @since: > > > 2017-04-20 23:04 GMT+02:00 Philip Race

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Sorry for the typo, I added also a newline before @since: 2017-04-20 23:04 GMT+02:00 Philip Race : > You have a capital letter here and I think it must be lower case .. > > > 2499 * @Since 10 > > -phil. > > > On 4/20/17, 1:58 PM, Laurent Bourgès wrote: > > Hi Phil

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

You have a capital letter here and I think it must be lower case .. 2499 * @Since 10 -phil. On 4/20/17, 1:58 PM, Laurent Bourgès wrote: Hi Phil & Jim, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Hi Phil & Jim, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/ Changes: - trimToSize() return void - fixed test + jtreg passed Bye, Laurent 2017-04-20 21:30 GMT+02:00 Jim Graham : > Hi Laurent, > > The implementation looks

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Hi Laurent, The implementation looks good, except that the method chaining-style return value seems out of place here. Similar trimToSize() methods in Collections return void and none of the other methods in this area use the method chaining paradigm. In the interest of maintaining a common

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

ar.naraya...@oracle.com>: > >> Looks good to me. >> >> Thanks >> Have a good day >> >> Prahalad N. >> >> -- >> >> From: Laurent Bourgès [mailto:bourges.laur...@gmail.com] >>

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

Hello Laurent The code changes look good. . The new method trimToSize effectively does the same operation (Arrays.copyOf) as done by the copy contructors. . The test file- Path2DCopyConstructor now tests after executing the methods pathObj.trimToSize and pathObj.clone With regard to