[PATCH 30/51] js: Extract a function that changes the current context

Because I'd like to modify the context after init time, let's split out a function that updates the context (the object that holds global information, like which project, series, patch we're talking about). Signed-off-by: Damien Lespiau --- htdocs/js/patchwork.js | 6 +- 1

[PATCH 23/51] dynatable: Allow the user to have a pre-defined per-page element

Sometimes users of dynatable don't want the library to generate its own elements, but use the ones already present in the page. This patch adds support to do just that for the per-page element. Signed-off-by: Damien Lespiau --- lib/packages/jquery/jquery.dynatable.js

[PATCH 27/51] gitignore: Explicitely ignore sub-directories in lib/packages

This file ignores everything at the moment. This doesn't look like a good idea. Signed-off-by: Damien Lespiau --- lib/packages/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/packages/.gitignore b/lib/packages/.gitignore index 72e8ffc..d3e4ba5 100644 ---

[PATCH 28/51] series: Add a first attempt at a Series list view

This should hopefully make the editing/sorting/paging a bit less jarring as we're not reloading the whole page anymore. Signed-off-by: Damien Lespiau --- htdocs/js/patchwork.js | 86 ++ patchwork/templates/patchwork/series-list

[PATCH 26/51] dynatable: Allow the user to have pre-defined pagination links

that are already in the DOM is the user put them there. Signed-off-by: Damien Lespiau --- lib/packages/jquery/jquery.dynatable.js | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/packages/jquery/jquery.dynatable.js b/lib/packages/jquery/jquery.dynatable.js

[PATCH 24/51] dynatable: Use our theming for the table headers

Signed-off-by: Damien Lespiau --- htdocs/css/style.css| 2 +- lib/packages/jquery/jquery.dynatable.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index 8c8aa80..7588971 100644 --- a/htdocs/css/style.css

[PATCH 25/51] dynatable: Style the pagination widget to look list the patches one

Signed-off-by: Damien Lespiau --- lib/packages/jquery/jquery.dynatable.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/packages/jquery/jquery.dynatable.css b/lib/packages/jquery/jquery.dynatable.css index b896559..658cf24 100644 --- a/lib/packages/jquery

[PATCH 19/51] Move files where they belong

Signed-off-by: Damien Lespiau --- {apps/patchwork => patchwork}/serializers.py | 0 {apps/patchwork => patchwork}/views/api.py | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename {apps/patchwork => patchwork}/serializers.py (100%) rename {apps/patchwork => patchwork}/

[PATCH 21/51] api: Expose Revisions

Signed-off-by: Damien Lespiau --- patchwork/serializers.py | 22 +- patchwork/urls.py| 9 + patchwork/views/api.py | 19 +-- 3 files changed, 47 insertions(+), 3 deletions(-) diff --git a/patchwork/serializers.py b/patchwork/serializers.py

[PATCH 20/51] api: Expose Series

perly filter with the project name we've got from the URL. We're also using the handy mixin classes defined by DRF to only support a few operations on series. In particular, we don't want to be able to create or destroy a series with the API. Signed-off-by: Damien Lespiau --- patc

[PATCH 18/51] api: Expose projects

We'll expose Series and Patches as sub-urls of projects. So they are a good object to start with. Signed-off-by: Damien Lespiau --- apps/patchwork/serializers.py | 27 +++ apps/patchwork/views/api.py | 36 patchwork/ur

[PATCH 14/51] model: Split a user_name() helper out of UserProfile

Signed-off-by: Damien Lespiau --- patchwork/models.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py index 742a08d..1990989 100644 --- a/patchwork/models.py +++ b/patchwork/models.py @@ -78,6 +78,11 @@ class Project

[PATCH 16/51] settings: Add Django REST framework to the project

L-RPC API patchwork currently has). But for now, let's experiment on Series. Signed-off-by: Damien Lespiau --- docs/requirements-base.txt | 2 ++ patchwork/settings/base.py | 12 2 files changed, 14 insertions(+) diff --git a/docs/requirements-base.txt b/docs/requirement

[PATCH 17/51] style: Move the background color of the table headers to a class

class rather then a selector on the patchlist id. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 2 +- patchwork/templates/patchwork/patch-list.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css in

[PATCH 12/51] series: Create Series objects when parsing mails

Signed-off-by: Damien Lespiau --- patchwork/bin/parsemail.py | 86 +++--- 1 file changed, 81 insertions(+), 5 deletions(-) diff --git a/patchwork/bin/parsemail.py b/patchwork/bin/parsemail.py index 873415d..55b4e3b 100755 --- a/patchwork/bin/parsemail.py

[PATCH 15/51] models: Monkey patch User to have a name() method

The name is really a poperty of the User. Not always having to retrieve the profile for that makes things simpler. Signed-off-by: Damien Lespiau --- patchwork/models.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/patchwork/models.py b/patchwork/models.py index 1990989..1f13722 100644

[PATCH 11/51] series: Provide the migration step to add series

Signed-off-by: Damien Lespiau --- patchwork/migrations/0004_series.py | 73 + 1 file changed, 73 insertions(+) create mode 100644 patchwork/migrations/0004_series.py diff --git a/patchwork/migrations/0004_series.py b/patchwork/migrations/0004_series.py new

[PATCH 10/51] series: Add a Series model

v2: Add 'order' metadata to revisions as they do have a natural ordering. Signed-off-by: Damien Lespiau --- patchwork/models.py | 48 1 file changed, 48 insertions(+) diff --git a/patchwork/models.py b/patchwork/models.py ind

[PATCH 09/51] person: Don't return the email along with the name in __unicode__

If we have a person name, that's enough to identify her/him. We don't need to add ones email address there. Signed-off-by: Damien Lespiau --- patchwork/models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/models.py b/patchwork/models.py index cbc8b5

[PATCH 08/51] tests: Make sure all emails have a valid msgid

Messages ids will be used by the Series code as the way to uniquely identify series. We must ensure every single email that goes through the parser has a valid msgid to not fail once we parse series. Signed-off-by: Damien Lespiau --- patchwork/tests/test_patchparser.py | 14

[PATCH 07/51] parsemail: Strip mail signatures from comments

Those signature don't really add value to the comment. Signed-off-by: Damien Lespiau --- patchwork/bin/parsemail.py | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/patchwork/bin/parsemail.py b/patchwork/bin/parsemail.py index a622187..873415d 100755

[PATCH 05/51] parsemail: Add a function to parse series markers eg. "1/12"

This can be used to identify cover letters, patches part of series, length of series, ... Signed-off-by: Damien Lespiau --- patchwork/bin/parsemail.py | 12 patchwork/tests/test_patchparser.py | 9 - 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a

[PATCH 06/51] parsemail: Extract building the list of mail references

We'll need to figure out whether the mail we are parsing is the root of the thread to automatically build series, and we'll need the list of references for that. Signed-off-by: Damien Lespiau --- patchwork/bin/parsemail.py | 33 +++-- 1 file changed, 19

[PATCH 04/51] parsemail: Make find_content() return a MailContent object

Returning tuples is not super scalable. I now want to return a Series object along with a patch or a comment. So let's put the return values into a class, used as a typed dictionary really. Signed-off-by: Damien Lespiau --- patchwork/bin/parsemail.py | 29 +++-- patc

[PATCH 02/51] tests: Fix a typo in the MboxPassThroughHeaderTest description

Signed-off-by: Damien Lespiau --- patchwork/tests/test_mboxviews.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py index 02d04cb..fbea322 100644 --- a/patchwork/tests/test_mboxviews.py +++ b/patchwork

[PATCH 01/51] gitignore: Only ignore quilt files at the root of the repository

So, say, a 'series' directory in the project (added in a later patch) doesn't get ignored. Signed-off-by: Damien Lespiau --- .gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index b16c5e2..b718f0a 100644 --- a/.gitignore +

[PATCH 00/51] Series aware patchwork

#x27;s plenty of work/refinements left of the UI itself, no doubt about it. As always, thoughts and comments are most definitely welcomed. -- Damien Damien Lespiau (51): gitignore: Only ignore quilt files at the root of the repository tests: Fix a typo in the MboxPassThroughHeaderTest desc

[PATCH 03/51] parsemail: Return the list of prefixes when cleaning up the subject

The patch is a preparation step towards understanding series. It will be handy to parse those prefixes, looking for 'x/n' to retrieve the order of a patch in a series. Signed-off-by: Damien Lespiau --- patchwork/bin/parsemail.py | 6 +++--- patchwork/tests/test_patchpars

Re: [PATCH 45/51] patch: Capitalize "Incoming Patches"

On Thu, Sep 10, 2015 at 05:33:47PM +0100, Finucane, Stephen wrote: > > It's a title after all. > > > > Signed-off-by: Damien Lespiau > > I spent an hour reading about this yesterday. Use of title case for > sentence case is quite the heated topic. However, so

Re: [PATCH 37/51] patch: Single out the commit message

ction between introducing what the patch does > > and > > > > eventual review comments. > > > > > > > > v2: Use two new Patch methods to retrieve the commit message and the > > > > other comments (called answers here) (Jeremy Kerr) > > &

Re: [PATCH 37/51] patch: Single out the commit message

gt; v2: Use two new Patch methods to retrieve the commit message and the > > other comments (called answers here) (Jeremy Kerr) > > > > Signed-off-by: Damien Lespiau > > How about using tabs to separate the patch from the comments/commit message, > a lá GitHub? Th

Re: [Intel-gfx] [PATCH] drm/i915: make CSR firmware messages less verbose

org/archives/intel-gfx/2015-June/070093.html and: https://bugs.freedesktop.org/show_bug.cgi?id=90461 But, WARN_ONCE() is not awful I guess: Acked-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_csr.c| 12 +-- > drivers/gpu/drm/i915/in

Re: [PATCH 14/51] html: Turn the navbar into a breadcrumb bar

ject is defined. The '$project patches' link becomes > > insensitive in the list page. Finally the patch page adds the patch at > > the end. > > > > Signed-off-by: Damien Lespiau > > Signed-off-by: Belén Barros Peña > > Looks good. One usability su

Re: [PATCH 12/51] base: Move the project info into the navigation bar

On Wed, Sep 09, 2015 at 03:41:46PM +0100, Finucane, Stephen wrote: > The rewording of this leads to potentially poor UX. If, for example, > your project is called 'patchwork' then the title bar button reads > "About patchwork" - rather confusing, no? More importantly, seeing as > we've already give

Re: [PATCH 28/51] base: Group username/profile/logout with a dropdown

On Wed, Sep 09, 2015 at 04:21:08PM +0100, Finucane, Stephen wrote: > > > We regoup user related information (log out and profile) in a dropdown > > > with the user identity as label. > > > > > > Signed-off-by: Damien Lespiau > > > > Should

Re: [PATCH 24/51] filters: Rewrite the submitter autocompletion code

gt; > A slight change in behaviour is that we now don't allow "free form" > > submitter search, ie we need a valid completion to search with that > > specific person (through its primary key). I didn't remove the backend > > logic that allows the "free

Re: [PATCH 23/51] base: Add selectize to the base template

On Wed, Sep 09, 2015 at 04:06:49PM +0100, Finucane, Stephen wrote: > > > The only tricky thing is the inclusion of the EcmaScript shim for IE8. > > > > > > Signed-off-by: Damien Lespiau > > > > Combine this with patch 21. They're too closely relate

Re: [PATCH 09/51] templates: Redesign the breadcrumbs bar

On Wed, Sep 09, 2015 at 03:33:53PM +0100, Finucane, Stephen wrote: > Maybe you do this in a latter patch, but you could probably drop the > 'Project: NAME' part from the breadcrumbs bar, as it's appears to be a > duplicate of what's in the title bar. Seeing as this commit is stylistic only > tho

Re: [PATCH 08/51] templates: Redesign the title bar

On Wed, Sep 09, 2015 at 03:30:31PM +0100, Finucane, Stephen wrote: > > Among the nice things that bootstrap brings to the table, the navigation > > bar is now mobile friendly: it will collapse when either, being > > displayed on a mobile device or when the screen isn't wide enough, to > > show the

Re: [PATCH 04/51] list: Replace the 16-arrow* icons by glyphicons

On Wed, Sep 09, 2015 at 02:53:31PM +0100, Finucane, Stephen wrote: > Yay! Don't forget to update the about page accordingly (to remove the links > to the sweetie icons). > > Acked-by: Stephen Finucane I did think about it :) but we're still using some of those icons for bundles, which is the re

Re: [PATCH 03/51] template: Add bootstrap to the base template

On Wed, Sep 09, 2015 at 02:47:29PM +0100, Finucane, Stephen wrote: > > Bootstrap is a bit of a hammer and probably unnecessary for a site design > > as simple as this. It's a mostly-static website with little to no CSS3 and > > only the bare minimum of JavaScript. I also think it's a fair assumptio

Re: [PATCH 0/3] Fix migrations state & load initial data throuh migrations (v2)

On Wed, Sep 09, 2015 at 02:21:48PM +0100, Finucane, Stephen wrote: > > v2 of the previous series (long explanation there): > > > > https://lists.ozlabs.org/pipermail/patchwork/2015-August/001394.html > > > > This time passing the tests. > > Could you use a prefix next time ('--prefix="PATCH v2

Re: [PATCH 0/7] Support delegation to non-maintainers

On Wed, Sep 09, 2015 at 01:59:07PM +0100, Stephen Finucane wrote: > Add support for delegating patches to users other than maintainers, as > requested on the mailing list: > > https://lists.ozlabs.org/pipermail/patchwork/2015-July/001351.html > > The required change to enable this is actually v

Re: [PATCH v2 13/16] trivial: Resolve PEP8 issues with 'management'

On Fri, Aug 21, 2015 at 03:32:17PM +0100, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane This is not just "trivial" PEP8 fixes. The usage of self.stdout/err instead of sys.stdout/err probably worth mentioning. I guess it depends on what Jeremy wants to do here, but in theory you would

Re: [Intel-gfx] [PATCH] drm/i915: set CDCLK if DPLL0 enabled during resuming from S3

wed-by: Rodrigo Vivi > Reviewed-by: Damien Lespiau > Reviewed-by: Cooper Chiou > Reviewed-by: Wei Shun Chang > Tested-by: Gary Wang > Cc: Daniel Vetter > Cc: Gavin Hindman > Cc: Chris Wilson > Cc: Xiong Y Zhang > Signed-off-by: Gary Wang Hum I had not given my r-

Re: [PATCH 47/51] login: Focus the username field on load

On Wed, Aug 26, 2015 at 09:21:30PM +0200, Wolfram Sang wrote: > On Mon, Aug 24, 2015 at 07:23:36PM +0100, Damien Lespiau wrote: > > Wolfram wanted a small usability improvement that's easy to add: placing > > the cursor automatically in the user name field when loadin

Re: distributed tests of a patch

On Tue, Aug 25, 2015 at 03:06:09PM +0200, Thomas Monjalon wrote: > 2015-08-19 11:33, Damien Lespiau: > > patchwork know about series first though, otherwise I don't think it > > makes much sense to test patches in isolation. > > I think it makes sense to test every patch

Re: [PATCH 51/51] patch-list: Tweak how A/R/T tags are displayed

On Tue, Aug 25, 2015 at 10:30:32AM +0100, Finucane, Stephen wrote: > > +table#patchlist > tbody > tr > td.tag-A { > > +text-align: center; > > +background-color: #bdecb6; > > +} > > + > > +table#patchlist > tbody > tr > td.tag-R { > > +text-align: center; > > +background-color: #c3f

Re: [PATCH] parsemail.py: Avoid skipping patches when parsing

On Mon, Aug 24, 2015 at 10:20:34AM -0500, Jose Lamego wrote: > Sent patch v2 with missing character. I still need to work on the coverage. Thanks. I believe it's good practice to wait until the test coverage is in place to consider merging the change. When it touches to mail parsing it's fairly ea

[PATCH 51/51] patch-list: Tweak how A/R/T tags are displayed

- Use colors to distinguish the tags - Don't display any information when there's none (ie don't display "there's 0 r-b tag"). That part is something similar to what Thomas Petazzoni also did. Signed-off-by: Damien Lespiau --- htdocs/css/style.css

[PATCH 50/51] filters: Fix submitter display when we only have an email address

I'm fairly sure I fixed that already, but here we go again. It's totally valid to only have an email address for the submitter, so handle that case properly. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/filters.html | 10 +++--- 1 file changed, 7 insert

[PATCH 48/51] filter: Tweak the autocompletion behaviour on

ing useful for input strings that have fewer than 4 characters, the autocompletion query only triggers after that. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/filters.html | 23 +++ 1 file changed, 23 insertions(+) diff --git a/patchwork/templates/patchwork/filte

[PATCH 49/51] filters: Submit the form when is pressed on a closed submitter field

second time (ie. when the autocompletion option has be selected and the dropdown isn't shown), we submit the form. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/filters.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/patchwork/templates/patc

[PATCH 43/51] patch-list: Limit the number of chars to 100 for the patch subject

ff-by: Damien Lespiau --- patchwork/templates/patchwork/patch-list.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/templates/patchwork/patch-list.html b/patchwork/templates/patchwork/patch-list.html index 9de5c52..8f48dbc 100644 --- a/patchwork/templates/patc

[PATCH 47/51] login: Focus the username field on load

Wolfram wanted a small usability improvement that's easy to add: placing the cursor automatically in the user name field when loading the login page. Suggested-by: Wolfram Sang Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/login.html | 7 +++ 1 file changed, 7 inser

[PATCH 46/51] patch-list: Use table-condensed to display the patch list

Wolfram didn't like the fact we're now seeing far fewer patches on a single page. That sounds fair enough and the table-condensed bootstrap class removes some padding, hopefully making it better. Suggested-by: Wolfram Sang Signed-off-by: Damien Lespiau --- patchwork/templates/patch

[PATCH 45/51] patch: Capitalize "Incoming Patches"

It's a title after all. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/list.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html index f895d28..f4650ae 100644 --- a/patc

[PATCH 44/51] base: Don't put the logout button in the is_staff block

Regular users didn't have their logout/profile drop down! Signed-off-by: Damien Lespiau --- templates/base.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base.html b/templates/base.html index a5a16b1..6b254f7 100644 --- a/templates/base.html +++ b/temp

[PATCH 42/51] patch: Move the submitter and date out of the details

From: Belén Barros Peña Trying to reduce the number of read-only fields in details. Signed-off-by: Belén Barros Peña Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/patch.html | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/patchwork

[PATCH 41/51] patch: Redesign slightly the comment headers

From: Belén Barros Pena Signed-off-by: Belén Barros Pena Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 1 + patchwork/templates/patchwork/patch.html | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/htdocs/css/style.css b/htdocs

[PATCH 37/51] patch: Single out the commit message

e) (Jeremy Kerr) Signed-off-by: Damien Lespiau --- patchwork/models.py | 11 +++ patchwork/templates/patchwork/patch.html | 19 --- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py index 4a1a432..cbc8b

[PATCH 40/51] patch: Pull the download links next to the "Patch" header

From: Belén Barros Peña Signed-off-by: Belén Barros Peña Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 6 ++ patchwork/templates/patchwork/patch.html | 26 +- 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/htdocs

[PATCH 34/51] boxes: Style boxes like the patch form

Here again, a pass may be needed in the future, but for now, make things consistent. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index 65bdc1c..d4e9e81 100644 --- a

[PATCH 39/51] patch: Override Bootstrap's styling

To look more like what patchwork was using. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index 10ecd3d..3fe42b4 100644 --- a/htdocs/css/style.css +++ b/htdocs

[PATCH 38/51] patch: Pull the patch between the commit message and comments

This follows a logical flow, commit message, patch then comments. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/patch.html | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/patchwork/templates/patchwork/patch.html b/patchwork/templates

[PATCH 36/51] patch: Remove the permalink item

One just has to copy the URL, no real need to duplicate that fact. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/patch.html | 4 1 file changed, 4 deletions(-) diff --git a/patchwork/templates/patchwork/patch.html b/patchwork/templates/patchwork/patch.html index ef257f2

[PATCH 35/51] style: Make the submission tables use #0A0A47

Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index d4e9e81..10ecd3d 100644 --- a/htdocs/css/style.css +++ b/htdocs/css/style.css @@ -337,7 +337,7 @@ table.form td

[PATCH 33/51] patchform: Minimal changes so patchform titles don't look out of place

I'd like to add editing in place in the list of patches instead of having to select, scroll down and make the changes. For the time being, just change the header background color and padding space. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 5 ++--- 1 file changed, 2 inser

[PATCH 29/51] base: Capitalize the menu items in the navbar

Signed-off-by: Damien Lespiau --- templates/base.html | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/templates/base.html b/templates/base.html index fd27e04..3299193 100644 --- a/templates/base.html +++ b/templates/base.html @@ -42,29 +42,29

[PATCH 31/51] paginator: Tweak the number of pages shown

From: Belén Barros Peña We don't really need that many pages displayed in the pagination, tweak the numbers down a bit. Signed-off-by: Belén Barros Peña Signed-off-by: Damien Lespiau --- patchwork/paginator.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --

[PATCH 32/51] paginator: Redesign the paginator

From: Belén Barros Peña A few things: - Use the … glyph - Remove the box around the page numbers - Slight restyling Signed-off-by: Belén Barros Peña Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 36 --- patchwork/templates

[PATCH 30/51] base: Use a Bootstrap badge for the number of todo items

Signed-off-by: Damien Lespiau --- templates/base.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/templates/base.html b/templates/base.html index 3299193..a5a16b1 100644 --- a/templates/base.html +++ b/templates/base.html @@ -47,7 +47,8 @@ {% endif %} {% if

[PATCH 28/51] base: Group username/profile/logout with a dropdown

We regoup user related information (log out and profile) in a dropdown with the user identity as label. Signed-off-by: Damien Lespiau --- templates/base.html | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/templates/base.html b/templates/base.html index d836fd1

[PATCH 27/51] patch-list: Make the table header sticky

So, when scrolling down the list of patches, we still get what are the field displayed. This is espacially important as I plan to add a few more. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 3 +++ patchwork/templates/patchwork/patch-list.html | 5

[PATCH 26/51] package: Add the Sticky Table Header jQuery plugin

Signed-off-by: Damien Lespiau --- htdocs/js/jquery.stickytableheaders.min.js | 1 + lib/packages/jquery/README | 19 ++- lib/packages/jquery/jquery.stickytableheaders.min.js | 1 + 3 files changed, 16 insertions(+), 5 deletions(-) create

[PATCH 23/51] base: Add selectize to the base template

The only tricky thing is the inclusion of the EcmaScript shim for IE8. Signed-off-by: Damien Lespiau --- templates/base.html | 3 +++ 1 file changed, 3 insertions(+) diff --git a/templates/base.html b/templates/base.html index cef0671..8d9ff75 100644 --- a/templates/base.html +++ b/templates

[PATCH 25/51] patch-list: Re-design the main list of patches with Bootsrap

From: Belén Barros Peña A bit more spacing everywhere. Also opted for the highlight on hover instead of the alternating row background color. v2: Squash the patch fixing the unit tests (Jeremy Kerr) Signed-off-by: Belén Barros Pena Signed-off-by: Damien Lespiau --- htdocs/css/style.css

[PATCH 24/51] filters: Rewrite the submitter autocompletion code

idn't remove the backend logic that allows the "free form" mechanism, but maybe we should. v2: Squash the unit tests fixes into this patch (Jeremy Kerr) Signed-off-by: Damien Lespiau --- patchwork/filters.py | 16 ++- patchwork/templates/patchwork/filters.h

[PATCH 21/51] filters: Redesign the filters form with the help of bootstrap

Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 18 +-- patchwork/filters.py | 16 +++-- patchwork/templates/patchwork/filters.html | 36 +- 3 files changed, 40 insertions(+), 30 deletions

[PATCH 19/51] filters: Put the active filter values in bold

From: Belén Barros Peña Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/filters.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patchwork/templates/patchwork/filters.html b/patchwork/templates/patchwork/filters.html index 7652db5..ddd20dd 100644

[PATCH 20/51] filters: Fix a typo in comment

Signed-off-by: Damien Lespiau --- patchwork/filters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/filters.py b/patchwork/filters.py index 8c9690e..205be29 100644 --- a/patchwork/filters.py +++ b/patchwork/filters.py @@ -41,7 +41,7 @@ class Filter(object

[PATCH 18/51] patch-list: Split the filter out of the patch table

From: Belén Barros Peña Signed-off-by: Damien Lespiau Signed-off-by: Belén Barros Peña --- patchwork/templates/patchwork/patch-list.html | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/patchwork/templates/patchwork/patch-list.html b/patchwork/templates/patchwork

[PATCH 17/51] filters: Use the glyphicons for add/remove signs

They give a much better contrast the the one already there. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 5 + htdocs/images/16-circle-blue-add.png | Bin 477 -> 0 bytes htdocs/images/16-circle-blue-remove.png| Bin 475 -> 0 bytes pat

[PATCH 13/51] base: Don't display the breadcrumb bar on the project list page

We already have the information on the main bar, no need to have a breadcum bar here. Signed-off-by: Damien Lespiau --- templates/base.html | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/templates/base.html b/templates/base.html index 844640a..3b2c83e 100644 --- a

[PATCH 16/51] style.css: Rename the breadcrumb selectors

Bootstrap called what was the header bar "navigation". Let's rename the nav* selector with 'breadcrumb' so there's no confusion with bootstrap's nagivation elements and selectors. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 6 +++--- templates/b

[PATCH 15/51] style.css: Provide a default style

From: Belén Barros Peña Signed-off-by: Damien Lespiau Signed-off-by: Belén Barros Peña --- htdocs/css/style.css | 5 + 1 file changed, 5 insertions(+) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index 3cf4b95..d0a69c9 100644 --- a/htdocs/css/style.css +++ b/htdocs/css

[PATCH 14/51] html: Turn the navbar into a breadcrumb bar

th being links, so we can return to the list of patches from any page where the project is defined. The '$project patches' link becomes insensitive in the list page. Finally the patch page adds the patch at the end. Signed-off-by: Damien Lespiau Signed-off-by: Belén Barros Peña

[PATCH 10/51] templates: Move "About" at the bottom of the page

From: Belén Barros Peña This is part of the steps needed to make the "nav" bar into a pure breadcrumb trail. It's quite usual these days to have "about" style links at the bottom of pages. Signed-off-by: Damien Lespiau Signed-off-by: Belén Barros Peña --- template

[PATCH 11/51] templates: Remove extraneous blank line at the end of base.html

Signed-off-by: Damien Lespiau --- templates/base.html | 3 --- 1 file changed, 3 deletions(-) diff --git a/templates/base.html b/templates/base.html index 2ad2383..30f94d4 100644 --- a/templates/base.html +++ b/templates/base.html @@ -95,6 +95,3 @@ - - - -- 2.1.0

[PATCH 12/51] base: Move the project info into the navigation bar

The goal is still to have a proper breadcrumb bar. One more little step towards it. Signed-off-by: Damien Lespiau --- templates/base.html | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/templates/base.html b/templates/base.html index 30f94d4..844640a 100644 --- a

[PATCH 07/51] style.css: Tune styling

From: Belén Barros Peña The links aren't underlined anymore. If, once visited, they are to become black, we won't be able to distinguish them from regular text. Instead let's decide about a color for links so they can be spotted, even after a visit. Signed-off-by: Damien Lespi

[PATCH 09/51] templates: Redesign the breadcrumbs bar

Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index 2d8a6b2..3cf4b95 100644 --- a/htdocs/css/style.css +++ b/htdocs/css/style.css @@ -41,14 +41,9 @@ a:hover

[PATCH 08/51] templates: Redesign the title bar

items in a togglable menu. This can be tested by resizing the browser to have a width < 768px. This commit is just about layout changes, keeping the exact same information displayed on the page. This is based on work from Belén Barros Peña, but transposed to bootstrap. Signed-off-by: D

[PATCH 06/51] style.css: Move the global styling at the top

Otherwise we can't properly have a generic styling that gets specialized as needed. Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index c166374..b66acc8 100644

[PATCH 05/51] sytle.css: Remove the body selector, letting bootstrap's shine through

Signed-off-by: Damien Lespiau --- htdocs/css/style.css | 8 1 file changed, 8 deletions(-) diff --git a/htdocs/css/style.css b/htdocs/css/style.css index e5bbc75..c166374 100644 --- a/htdocs/css/style.css +++ b/htdocs/css/style.css @@ -1,11 +1,3 @@ -body { - background-color

[PATCH 03/51] template: Add bootstrap to the base template

Signed-off-by: Damien Lespiau --- templates/base.html | 9 + 1 file changed, 9 insertions(+) diff --git a/templates/base.html b/templates/base.html index 48ea4f0..3d07504 100644 --- a/templates/base.html +++ b/templates/base.html @@ -6,9 +6,18 @@ {% block title %}Patchwork

[PATCH 04/51] list: Replace the 16-arrow* icons by glyphicons

They look more modern. Signed-off-by: Damien Lespiau --- htdocs/images/16-arrow-down.png | Bin 354 -> 0 bytes htdocs/images/16-arrow-up.png | Bin 332 -> 0 bytes patchwork/templates/patchwork/patch-list.html | 55 +++--- patchwork/ut

[PATCH 00/51] A patchwork redesign v2

uot;Patch" header patch: Move the submitter and date out of the details Damien Lespiau (39): templates: Pull jquery into base.html htdocs: Add bootstrap template: Add bootstrap to the base template list: Replace the 16-arrow* icons by glyphicons sytle.css: Remove the body selec

[PATCH 01/51] templates: Pull jquery into base.html

Bootstrap needs jquery for its own JS facilities, so include it on every page. Signed-off-by: Damien Lespiau --- patchwork/templates/patchwork/bundle.html | 1 - templates/base.html | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/templates

Re: [PATCH 25/46] filters: Rewrite the submitter autocompletion code

On Mon, Aug 24, 2015 at 03:45:56PM +0100, Peter Maydell wrote: > On 10 November 2014 at 13:01, Jeremy Kerr wrote: > > Hi Damien, > > >> A slight change in behaviour is that we now don't allow "free form" > >> submitter search, ie we need a valid completion to search with that > >> specific person

<    1   2   3   4   5   6   7   8   9   10   >