Re: [Alsa-devel] An driver error when I using aplay!

2004-06-07 Thread Russell King
On Mon, Jun 07, 2004 at 03:24:46PM +0100, James Courtier-Dutton wrote: > Russell King wrote: > > > > But unfortunately I don't have the driver code myself to be able to > > comment, so its probably been fscked. > > > > If the code was posted publically, the

Re: [Alsa-devel] An driver error when I using aplay!

2004-06-07 Thread Russell King
g, so I can only guess. > The reason is same -- since hw_params is not called, > chan->tx_substream is not set, too. Wrong. It's memset to zero by matter of fact of how it is allocated. I'm surprised you don't know this. It is afterall code which I thought you'd be full

Re: [Alsa-devel] An driver error when I using aplay!

2004-06-07 Thread Russell King
On Mon, Jun 07, 2004 at 03:40:23PM +0200, Takashi Iwai wrote: > At Mon, 7 Jun 2004 14:08:17 +0100, > Russell King wrote: > > > > On Mon, Jun 07, 2004 at 02:45:20PM +0200, Takashi Iwai wrote: > > > i guess so, too. as you can see in the original post, the error &g

Re: [Alsa-devel] An driver error when I using aplay!

2004-06-07 Thread Russell King
f the old -rmk patches back in the 2.6.0-test era. Where Roc has got the source from, and what modifications have been made is anyones guess. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/

Re: [Alsa-devel] An driver error when I using aplay!

2004-06-07 Thread Russell King
d is called while the DMA or IO is still running. If DMA is still running here, we've already freed the DMA buffer, so we're either reading from or writing to memory we don't own - which is a major bug. The question is therefore: why is ALSA trying to shut down and free a device which

[Alsa-devel] 2.6.6-rc2 build warnings

2004-05-30 Thread Russell King
g: `struct pci_dev' declared inside parameter list include/sound/core.h:215: warning: its scope is only this definition or declaration, which is probably not what you want include/sound/core.h:216: warning: `struct pci_dev' declared inside parameter list ... -- Russell King Linux ker

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-31 Thread Russell King
On Wed, Mar 31, 2004 at 11:22:56AM +0200, Jaroslav Kysela wrote: > On Wed, 31 Mar 2004, Russell King wrote: > > > I suggest we add a load of preprocessor junk into the ALSA core and > > comment exactly _why_ its needed, thereby laying the reason completely > > at the d

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-31 Thread Russell King
ctly _why_ its needed, thereby laying the reason completely at the door of these ill-defined APIs where questions have been asked and responses not been received. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.ar

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-31 Thread Russell King
On Wed, Mar 31, 2004 at 10:29:06AM +0200, Jaroslav Kysela wrote: > On Wed, 31 Mar 2004, Russell King wrote: > > Keeping the existing ->nopage will not work - there is no way to get to > > a struct page on ARM given the information available to the ALSA code. > >

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-31 Thread Russell King
se problems in > ALSA. If you come with a solution, then people not agreeing with you > have to propose/implement a better solution. Keeping the existing ->nopage will not work - there is no way to get to a struct page on ARM given the information available to the ALSA code. -- Russell Ki

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-30 Thread Russell King
respond to agreeing what the API requires. It's no good one architecture implementing one version of the API and others then deciding that they don't actually like it after all and needing a different API. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-30 Thread Russell King
to trying to sort out these problems, I've decided that its not worth me spending my time fixing the core ALSA code any longer. Therefore, expect ALSA to be non-functional on ARM for at least the 2.6 kernel series. Sorry, but that's the way it is. -- Russell King Linux kernel2.6

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-09 Thread Russell King
now various people are calling for sa11xx-uda1341 to be deleted once my driver is merged. It's good when communities fragment, isn't it? 8( However, the problem I've been describing is a problem with the core ALSA implementation and affects all hardware drivers on ARM, whether t

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-09 Thread Russell King
th. Then there's the issue about the abuse of virt_to_page() taking a mapped virtual address (ie from pci_alloc_consistent or dma_alloc_coherent) rather than a direct-mapped virtual address (alloc_pages / kmalloc). -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/

Re: [Alsa-devel] buffer producer/consumer sync

2004-03-09 Thread Russell King
e appl_ptr and hw_ptr are mmaped to user space. I observed this > behaviour on SA11xx platform, too. > > Russell King already notified us about this problem. See the mail archive > for the proper fix of the midlevel code. There currently doesn't exist a public fix for this yet, s

Re: [Alsa-devel] runtime->dma_addr

2004-03-03 Thread Russell King
h may be unique to the device it's being programmed into. This is why DMA-mapping.txt says: pci_alloc_consistent returns two values: the virtual address which you can use to access it from the CPU and dma_handle which you pass to the card. rather than calling dma_handle the "physical"

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Russell King
t, neither was debugging enabled. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core --- SF.Net is sponsored by: Sp

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Russell King
are you looking at, because it doesn't seem to match mainline kernels. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core ---

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Russell King
memset(ret, 0, size); *dma_handle = handle; break; } free_pages((unsigned long)ret, order); gfp |= GFP_DMA; } return ret; Does that look reasonable? If so, I'll float the idea aro

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Russell King
On Mon, Mar 01, 2004 at 04:41:00PM +0100, Takashi Iwai wrote: > At Sun, 29 Feb 2004 22:38:20 +, > Russell King wrote: > > > > This is the first shot at this - I've tested it on ARM, covering both > > ISA ALSA devices on a PCI machine, and driver model devic

Re: [Alsa-devel] [PATCH] 1/5 Clean up Linux 2.6.4-rc1 sound/core/Makefile

2004-03-01 Thread Russell King
o bloat my local tree with too many ALSA changes. IOW, I'll wait for this set to make their way through your good selves and to Linus before submitting any further changes of this type. This will probably mean it'll be after 2.6.4 has been released. -- Russell King Linux k

[Alsa-devel] Re: [PATCH] 4/5 Clean up Linux 2.6.4-rc1 sound/core/Makefile

2004-03-01 Thread Russell King
,6 +6,7 @@ menu "PCMCIA devices" config SND_VXPOCKET tristate "Digigram VXpocket" depends on SND && PCMCIA && ISA + select SND_HWDEP select SND_PCM help Say 'Y' or 'M' to include supp

[Alsa-devel] Re: [PATCH] 5/5 Clean up Linux 2.6.4-rc1 sound/core/Makefile

2004-03-01 Thread Russell King
t;Generic MPU-401 UART driver" depends on SND + select SND_TIMER select SND_RAWMIDI help Say 'Y' or 'M' to include support for MPU401 hardware using UART access. -- Russell King Linux kernel2.6 ARM Linux

[Alsa-devel] Re: [PATCH] 3/5 Clean up Linux 2.6.4-rc1 sound/core/Makefile

2004-03-01 Thread Russell King
SND + select SND_RAWMIDI select SND_PCM help Say 'Y' or 'M' to include support for ICE1712 (Envy24) based soundcards. @@ -196,6 +212,7 @@ config SND_ICE1712 config SND_ICE1724 tristate "ICE/VT1724 (Envy24HT)" depends

[Alsa-devel] Re: [PATCH] 2/5 Clean up Linux 2.6.4-rc1 sound/core/Makefile

2004-03-01 Thread Russell King
SND_POWERMAC tristate "PowerMac (AWACS, DACA, Burgundy, Tumbler, Keywest)" depends on SND + select SND_PCM endmenu --- orig/sound/parisc/Kconfig Sat Jun 14 22:35:12 2003 +++ linux/sound/parisc/Kconfig Mon

[Alsa-devel] [PATCH] 1/5 Clean up Linux 2.6.4-rc1 sound/core/Makefile

2004-03-01 Thread Russell King
bj-$(CONFIG_SND_RAWMIDI) += snd-rawmidi.o -obj-$(CONFIG_SND_MIXER_OSS) += oss/ -obj-$(CONFIG_SND_PCM_OSS) += snd-pcm.o snd-timer.o snd-page-alloc.o oss/ -obj-$(CONFIG_SND_SEQUENCER) += snd-timer.o seq/ +obj-$(CONFIG_SND_OSSEMUL) += oss/ +ob

[Alsa-devel] Re: [PATCH] 3/3 Implement generic device DMA mapping support

2004-02-29 Thread Russell King
SNDRV_DMA_TYPE_DEV 6 /* generic device continuous */ #define SNDRV_DMA_TYPE_DEV_SG 7 /* generic device SG-buffer */ @@ -66,8 +63,8 @@ struct snd_dma_device { static inline void snd_dma_device_pci(struct snd_dma_device *dev, struct pci_dev *pci, unsigned int id)

[Alsa-devel] Re: [PATCH] 2/3 Implement generic device DMA mapping support

2004-02-29 Thread Russell King
_malloc_pci_pages(pci, PAGE_SIZE, addrp); } -#endif - #if 0 /* for kernel-doc */ /** * snd_free_pci_page - release a page -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2

[Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-02-29 Thread Russell King
bstream) ((substream)->runtime->dma_private) +#define snd_pcm_sgbuf_pages(size) snd_sgbuf_aligned_pages(size) +#define snd_pcm_sgbuf_get_addr(sgbuf,ofs) snd_sgbuf_get_addr(sgbuf,ofs) +struct page *snd_pcm_sgbuf_ops_page(snd_pcm_substream_t *substream, unsigned long offset); + static inline voi

Re: [Alsa-devel] alsa-lib pcm not starting

2004-02-29 Thread Russell King
On Sun, Feb 29, 2004 at 01:31:01PM +0100, Jaroslav Kysela wrote: > On Sun, 29 Feb 2004, Russell King wrote: > > Could someone enlighten me about the way alsa-lib / alsa-driver are > > supposed to work when using mmap mode please? I'm looking at the 1.0.2 > > code, al

Re: [Alsa-devel] 2.6.4-rc1: ALSA makes invalid assumptions about memory types

2004-02-29 Thread Russell King
On Sun, Feb 29, 2004 at 01:48:52PM +0100, Jaroslav Kysela wrote: > On Sun, 29 Feb 2004, Russell King wrote: > >I believe this needs discussing with the DMA API authors on LKML since > >AFAIK the kernel currently doesn't have a clear API to translate memory >

[Alsa-devel] 2.6.4-rc1: ALSA makes invalid assumptions about memory types

2004-02-29 Thread Russell King
acks in my tree which work around this using ARM specific functionality, but this is very much architecture specific at the moment, and I suspect requires a new kernel API for creating memory (it's similar to the DMA case above.) -- Russell King Linux kernel2.6 ARM Linu

[Alsa-devel] alsa-lib pcm not starting

2004-02-29 Thread Russell King
old: 16384 /proc/asound/card0/pcm0p/sub0/sw_params:silence_threshold: 0 /proc/asound/card0/pcm0p/sub0/sw_params:silence_size: 0 /proc/asound/card0/pcm0p/sub0/sw_params:boundary: 1073741824 -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmci

[Alsa-devel] ALSA skipping samples

2003-06-06 Thread Russell King
ame mp3 using the same mp3 player binary on a faster system using real OSS drivers but different hardware has the expected results.) -- Russell King ([EMAIL PROTECTED])The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html

[Alsa-devel] Re: UDA1341TS (iPAQ H3X00) sound driver for ALSA

2002-04-12 Thread Russell King - ARM Linux
On Fri, Apr 12, 2002 at 08:39:18PM +0200, Kasparek Tomas wrote: > I have in mind, that the name will change, I'm just waiting for enough > opinions to do this work just once. I haven't looked at any of the code yet, so... (too busy reading piles and piles and piles and piles of email.)

[Alsa-devel] Re: UDA1341TS (iPAQ H3X00) sound driver for ALSA

2002-04-12 Thread Russell King - ARM Linux
On Wed, Apr 10, 2002 at 09:55:43AM -0400, Hicks, Jamey wrote: > > -Original Message- > > From: Nicolas Pitre [mailto:[EMAIL PROTECTED]] > > > > No. Please pick a relevant name. H3600 is not the only > > device with an UDA1341 out there. > > The alsa driver mentioned is iPAQ specific.