RE: drm/amd/powerplay: expose max engine and memory clock info for powerplay enabled case

exdeuc...@gmail.com] Sent: Friday, October 14, 2016 5:52 AM To: Quan, Evan <evan.q...@amd.com> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; amd-gfx@lists.freedesktop.org; Zhang, Jerry <jerry.zh...@amd.com>; Huan, Alvin <alvin.h...@amd.com>; Huang, Ray <ray.hu...@amd.co

drm/amd/powerplay: expose max engine and memory clock info for powerplay enabled case

Hi All, We found the max engine clock and max memory clock are both wrongly reported as 0(by AMDGPU_INFO_DEV_INFO ioctl). The attached patch tries to fix it. Please help to review it. Any comment is welcomed. Regards, Evan 0001-drm-amd-powerplay-expose-max-engine-memory-clock-inf.patch

RE: drm/amd/powerplay: expose max engine and memory clock info for powerplay enabled case

Hi Alex, Thanks for your information. I updated the patch using the amdgpu_dpm_get_sclk/mclk APIs which make the patch much simpler. Regards, Evan From: Deucher, Alexander Sent: Thursday, October 13, 2016 6:04 AM To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org Cc:

RE: [PATCH] drm/amdgpu: fix DRM clockgating incorrect reading

Tested-by: Evan Quan <evan.q...@amd.com> >-Original Message- >From: Huang Rui [mailto:ray.hu...@amd.com] >Sent: Monday, March 27, 2017 2:50 PM >To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ><alexander.deuc...@amd.com> >Cc: Quan, Evan <evan.

RE: [PATCH] drm/amdgpu: fix "fix 64bit division"

Reviewed-by: Evan Quan >-Original Message- >From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of >Christian K?nig >Sent: Friday, April 07, 2017 4:44 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH] drm/amdgpu: fix "fix 64bit division" >

RE: [PATCH] drm/amd/display: fix NULL pointer dereference.

The issue seems already fixed by the following commit {{{ commit 52184bbf4773512d7c83fe21a0b4b4ec4be27caf Author: Jordan Lazare Date: Wed Apr 5 15:05:51 2017 -0400 drm/amd/display: fix nullptr on vega initialization Change-Id:

RE: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

Reviewed-by: Evan Quan <evan.q...@amd.com> >-Original Message- >From: Huang Rui [mailto:ray.hu...@amd.com] >Sent: Thursday, April 20, 2017 3:34 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Quan, Evan ><evan.

RE: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

Oops, the changes were made by a remote windows editor which added the executable bit wrongly. Thanks for the remind. Will pay attention to it. Regards, Evan >-Original Message- >From: Michel Dänzer [mailto:mic...@daenzer.net] >Sent: Friday, July 28, 2017 4:38 PM >To: Quan,

RE: [PATCH 04/18] drm/amdgpu/sriov:don't load psp fw during gpu reset

Hi Monk, I think your change affects barematal case. Per my confirmation, vega10 cannot boot with the change applied. If the change is only intended to cover gpu reset case of sriov, maybe the logic should be If (!(amdgpu_sriov_vf(adev) && adev->in_sriov_reset)) Regards, Evan >-Original

RE: [PATCH 2/2] drm/amd/powerplay: fix ret checks in amd_powerplay.c

Series are reviewed-by: Evan Quan Regards, Evan >-Original Message- >From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex >Zhu >Sent: Saturday, September 30, 2017 10:50 AM >To: amd-gfx@lists.freedesktop.org >Cc: Zhu, Rex

RE: [PATCH 2/2] drm/amdgpu: support polaris10/11/12 new cp firmwares

21, 2017 4:18 PM >To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH 2/2] drm/amdgpu: support polaris10/11/12 new cp firmwares > >Am 21.08.2017 um 03:39 schrieb Evan Quan: >> Newer versions of the CP firmware require changes in how the d

答复: [PATCH] drm/amd/pp: Refine the output of pp_power_profile_mode on VI

Reviewed-by: Evan Quan 发件人: amd-gfx 代表 Deucher, Alexander 发送时间: 2018年5月8日 5:32:06 收件人: Zhu, Rex; amd-gfx@lists.freedesktop.org 主题: Re: [PATCH] drm/amd/pp: Refine the output of

答复: [PATCH] drm/amd/pp: Implement force_clock_level for RV

Reviewed-by: Evan Quan 发件人: amd-gfx 代表 Rex Zhu 发送时间: 2018年5月8日 14:23:35 收件人: amd-gfx@lists.freedesktop.org 抄送: Zhu, Rex 主题: [PATCH] drm/amd/pp: Implement force_clock_level for RV under

RE: [PATCH] drm/amd/pp: Fix OD feature enable failed on Vega10 workstation cards

> But on workstation, vbios do not support OD featur, the OD max memory With typo "featur" fixed, Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Tuesday, June 12, 2018 3:09 PM > To:

RE: [PATCH] drm/amdgpu: detect buffer overflow and avoid unnecessary dereference

-Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, May 29, 2018 11:50 PM > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Huang, Ray > Subject: Re: [PATCH] drm/amdgpu: detect buffer overflow and avoid > unnecessary derefer

RE: [PATCH] drm/amd/pp: Enable powergate_gfx on Raven

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Tuesday, June 05, 2018 1:58 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amd/pp: Enable powergate_gfx on Raven > >

RE: [PATCH 4/5] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu

Comment inline > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Tuesday, June 05, 2018 1:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 4/5] drm/amd/pp: Add gfx pg support in smu through >

RE: [PATCH 1/2] drm/amdgpu: Change PG enable sequence

> /* skip CG for VCE/UVD, it's handled specially */ The comment should be fixed as this is for pg not cg. With that fixed, the patch is Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Tuesday, June

RE: [PATCH] drm/amd/powerplay: fix missed hwmgr check warning before call gfx_off_control handler

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Huang, Ray > Sent: Tuesday, June 05, 2018 6:11 PM > To: Huang, Ray ; Deucher, Alexander > ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Cc: Dan Carpenter >

Re: [PATCH] drm/amd/display: Implement dm_pp_get_clock_levels_by_type_with_latency

> + /* translate 10kHz to kHz */ > + clk_level_info->data[i].clocks_in_khz = > pp_clks->data[i].clocks_in_khz; > + clk_level_info->data[i].latency_in_us = > pp_clks->data[i].clocks_in_khz; This seems a typo(latency_in_us = clocks_in_khz ?). And the

RE: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

Hi Alex, Comment inline. > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, June 19, 2018 11:17 PM > To: Quan, Evan > Cc: amd-gfx list > Subject: Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on > power sta

RE: [PATCH 07/13] drm/amd/powerplay: initialize uvd/vce powergate status

: Tuesday, June 19, 2018 11:10 PM > To: Quan, Evan > Cc: amd-gfx list > Subject: Re: [PATCH 07/13] drm/amd/powerplay: initialize uvd/vce > powergate status > > On Tue, Jun 19, 2018 at 3:38 AM, Evan Quan wrote: > > On UVD/VCE dpm disabled, the powergate status should be

RE: [PATCH] drm/amd/powerplay: initialize uvd/vce powergate status v2

nesday, June 20, 2018 2:09 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH] drm/amd/powerplay: initialize uvd/vce powergate status > v2 > > On UVD/VCE dpm disabled, the powergate status should be set as true. So > that we will not try to gate them(enabl

RE: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

Hi Rex, Yes, per discussed, we may need another patch to consider how to set the PHM_PlatformCaps_UMDPState flag. But for now, I will keep the patch as it is. Regards, Evan From: Zhu, Rex Sent: Tuesday, June 19, 2018 11:43 PM To: Quan, Evan ; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH

RE: [PATCH 1/7] drm/amdgpu: Rename set_mmhub_powergating_by_smu to powergate_mmhub

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, June 13, 2018 7:18 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 1/7] drm/amdgpu: Rename >

RE: [PATCH 2/7] drm/amd/pp: Rename enable_per_cu_power_gating to powergate_gfx

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, June 13, 2018 7:18 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 2/7] drm/amd/pp: Rename

RE: [PATCH v2 6/7] drm/amdgpu: Make gfx_off control by GFX ip

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, June 13, 2018 7:37 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2 6/7] drm/amdgpu: Make gfx_off control by GFX

RE: [PATCH v2 7/7] drm/amdgpu: Change PG enable sequence

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, June 13, 2018 7:39 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2 7/7] drm/amdgpu: Change PG enable sequence >

答复: [PATCH v2 5/7] drm/amd/pp: Implement edit_dpm_table on smu7

+ for (i=0; idpm_table.sclk_table.count; i++) { + if (odn_table->odn_core_clock_dpm_levels.entries[i].clock != + data->dpm_table.sclk_table.dpm_levels[i].value) { + data->need_update_smu7_dpm_table |=

答复: [PATCH v2 7/7] drm/amd/pp: Add update_avfs call when set_power_state

Do we need to reset need_update_smu7_dpm_table flag as 0 in smu7_set_power_state_tasks? Regards, Evan 发件人: amd-gfx 代表 Rex Zhu 发送时间: 2018年1月19日 16:10:11 收件人: amd-gfx@lists.freedesktop.org 抄送: Zhu, Rex

答复: [PATCH v2 6/7] drm/amd/pp: Update smu7 dpm table with OD clock/voltage

@@ -4887,21 +4811,25 @@ static void smu7_check_dpm_table_updated(struct pp_hwmgr *hwmgr) dep_table = table_info->vdd_dep_on_mclk; odn_dep_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)&(odn_table->vdd_dependency_on_mclk); - for (i=0; icount; i++) { +

RE: [PATCH v2] drm/amdgpu: reserved requested gtt buffer for smu

>-Original Message- >From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex >Zhu >Sent: Tuesday, January 16, 2018 7:47 PM >To: amd-gfx@lists.freedesktop.org >Cc: Zhu, Rex >Subject: [PATCH v2] drm/amdgpu: reserved requested gtt buffer for smu >

RE: [PATCH] drm/amd/powerplay: fix compile warning

Please ignore this patch since i found there was already fix for this. Regards, Evan >-Original Message- >From: Evan Quan [mailto:evan.q...@amd.com] >Sent: Thursday, January 04, 2018 10:55 AM >To: amd-gfx@lists.freedesktop.org >Cc: Quan, Evan <evan.q...@amd.com> >

RE: [PATCH 5/7] drm/amd/powerplay: export vega10 specific thermal ranges

Created a new header file to place the shared structures. Please check the coming V2 patches. Regards, Evan >-Original Message- >From: Alex Deucher [mailto:alexdeuc...@gmail.com] >Sent: Thursday, January 04, 2018 10:53 AM >To: Quan, Evan <evan.q...@amd.com> >Cc:

RE: [PATCH 1/4] drm/amd/powerplay: show the right unit for the temp printed out

Got it. I will drop this patch. Regards, Evan From: Deucher, Alexander Sent: Sunday, December 31, 2017 2:29 AM To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amd/powerplay: show the right unit for the temp printed out I don't think the

RE: [PATCH 2/4] drm/amd/powerplay: remove unused parameter of phm_start_thermal_controller

To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/4] drm/amd/powerplay: remove unused parameter of phm_start_thermal_controller Should this be used to set the default critical temperatures? IIRC, they were set to 0 until last week when someone sent a

Re: [PATCH 1/3] drm/amd/pp: Delete duplicated interface in hwmgr_func

Reviewed-by: Evan Quan From: amd-gfx on behalf of Rex Zhu Sent: Sunday, July 29, 2018 7:42:25 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 1/3] drm/amd/pp: Delete duplicated interface in hwmgr_func gfx off support in smu can be via

Re: [PATCH 2/4] drm/amdgpu: Put enable gfx off feature to a delay thread

- if (!amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_GFX, true)) - adev->gfx.bin_off = true; + schedule_delayed_work(>gfx.delay_gfx_off_enable, GFX_OFF_DELAY_ENABLE); } else if (!enable && adev->gfx.bin_off) {

Re: [PATCH 3/4] drm/amdgpu: gfx ip ctrl gfx off via amdgpu_gfx_off_ctrl

Reviewed-by: Evan Quan From: amd-gfx on behalf of Rex Zhu Sent: Sunday, July 29, 2018 7:35:49 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 3/4] drm/amdgpu: gfx ip ctrl gfx off via amdgpu_gfx_off_ctrl use amdgpu_gfx_off_ctrl function so

Re: [PATCH 4/4] drm/amdgpu: Disable gfx off if VCN is busy

Reviewed-by: Evan Quan From: amd-gfx on behalf of Rex Zhu Sent: Sunday, July 29, 2018 7:35:50 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 4/4] drm/amdgpu: Disable gfx off if VCN is busy this patch is a workaround for the gpu hang at

Re: [PATCH 3/3] drm/amd/pp: Add gfx power status check support on Rv/Vega12

Since the gfxoff is always in dynamic switch, i do not think the status reported to user is reliable. It means user was told the gfx is on but actually it may switches to gfxoff already. Regards, Evan From: amd-gfx on behalf of Rex Zhu Sent: Sunday, July

Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function

+ if (adev->gfx.bready_for_off && !adev->gfx.bin_off + && !adev->gfx.disable_gfx_off_request) { + if (!amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_GFX, true)) + adev->gfx.bin_off = true; + } else if

Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function

u, Rex Sent: Monday, July 30, 2018 11:46:00 AM To: Quan, Evan; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function >"adev->gfx.bready_for_off" used for ? This flag should only be set by gfx ip after gfx cg/pg feature enabled. Other cl

Re: [PATCH 2/4] drm/amdgpu: Put enable gfx off feature to a delay thread

OK, I see. Then it's better to unlock the gfx_off_ctrl_mutex in amdgpu_gfx_off_ctrl() before calling schedule_delayed_work(). Regards, Evan From: Zhu, Rex Sent: Monday, July 30, 2018 11:52:41 AM To: Quan, Evan; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH

RE: [PATCH 2/2] drm/amdgpu/pp: endian fixes for processpptables.c

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Wednesday, August 08, 2018 5:32 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/2] drm/amdgpu/pp: endian fixes for processpptables.c > > Properly swap

RE: [PATCH 1/2] drm/amdgpu/pp: endian fixes for process_pptables_v1_0.c

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Wednesday, August 08, 2018 5:32 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 1/2] drm/amdgpu/pp: endian fixes for > process_pptables_v1_0.c > > Properly

Re: [PATCH v2 5/5] drm/amdgpu:add VCN booting with firmware loaded by PSP

Why only the mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW/HIGH use the new tmr_mc_addr? And the mmUVD_LMI_VCPU_CACHE1_64BIT_BAR_LOW/HIGH and mmUVD_LMI_VCPU_CACHE1_64BIT_BAR_LOW/HIGH still use the old adev->vcn.gpu_addr? Regards, Evan From: amd-gfx on behalf of James

Re: [PATCH] drm/amd/powerplay: expose vega20 OD features

so take the vega20 OD ways(that is we need the offset, not the exact value for voltage). So, based on previous considerations, i decide to have new APIs instead of reusing existing ones. Regards, Evan From: Zhu, Rex Sent: Saturday, August 25, 2018 12:32 AM To

Re: [PATCH] drm/amd/powerplay: expose vega20 OD features

file. Do you mean we can bind the sysfs file to other APIs? How? Regards, Evan From: Alex Deucher Sent: Monday, August 27, 2018 10:01:49 PM To: Quan, Evan Cc: Zhu, Rex; Deucher, Alexander; amd-gfx list; Xu, Feifei; Kuehling, Felix; Zhang, Hawking Subject:

Re: [Vega10] [bisected] Performance regression with Dawn Of War III and RADV

Yes, this is a bug fix for multi monitor case. Without this, we may have trouble to light up multi monitors. Regards, Evan From: Deucher, Alexander Sent: Tuesday, August 28, 2018 10:19:30 PM To: Samuel Pitoiset; Quan, Evan Cc: Zhu, Rex; amd-gfx

Re: [PATCH] drm/amd/powerplay: expose vega20 OD features

to the file to reset them. * */ Regards, Evan From: Alex Deucher Sent: Wednesday, August 29, 2018 1:26:42 AM To: Zhu, Rex Cc: Deucher, Alexander; Quan, Evan; amd-gfx list; Xu, Feifei; Kuehling, Felix; Zhang, Hawking Subject: Re: [PATCH] drm/amd/powerplay: expose vega20 OD f

Re: [PATCH] drm/amd/powerplay: expose vega20 OD features

I just sent out a new patch which reuses existing APIs. Let's move future discussion there. Regards, Evan From: Quan, Evan Sent: Wednesday, August 29, 2018 9:12 AM To: Alex Deucher; Zhu, Rex Cc: Deucher, Alexander; amd-gfx list; Xu, Feifei; Kuehling, Felix; Zhang

RE: [PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch

Ping .. > -Original Message- > From: Evan Quan > Sent: Friday, July 20, 2018 10:35 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex ; Quan, Evan > Subject: [PATCH 2/3] drm/amd/powerplay: correct the argument for > PPSMC_MSG_SetUclkFastSwitch > > The arg

RE: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled

Sent out the revised patch. Regards, Evan From: Zhu, Rex Sent: Friday, July 20, 2018 6:08 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled Hi Evan， Changing the title to "Only allow slow switch

Re: [PATCH 2/2] drm/amdgpu: fix a reversed condition

Series is Reviewed-by: Evan Quan From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, July 25, 2018 1:03:13 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amdgpu: fix a reversed condition This test was reversed so it would end up

RE: [PATCH] drm/amd/powerplay: fix compile warning for wrong data type

> -Original Message- > From: Deucher, Alexander > Sent: 2018年9月5日 12:33 > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: RE: [PATCH] drm/amd/powerplay: fix compile warning for wrong > data type > > > -Original Message

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

k whether we should update the usage on vega20 as: "s level clock" --> set fmin/fmax "m level clock" --> set Umax "vc level clock voltage" --> Newly added, set freq/voltage curve? Regards, Evan > -Original Message- > From: Quan, Evan &

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

Make sense to me. I will update the patch accordingly. Regards, Evan > -Original Message- > From: Alex Deucher > Sent: 2018年8月31日 12:19 > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Zhu, Rex > Subject: Re: [PATCH] drm/amd/powerplay: added veg

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

Hi Alex, comment inline > -Original Message- > From: Alex Deucher > Sent: 2018年8月30日 23:25 > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Zhu, Rex > Subject: Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support > > On Thu, Aug 30,

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support

i know there is no interface to get it set. > Are negative offsets supported? Sure. Regards, Evan From: Alex Deucher Sent: Thursday, August 30, 2018 12:25:35 AM To: Quan, Evan Cc: amd-gfx list; Deucher, Alexander; Zhu, Rex Subject: Re: [PATCH] drm/amd/powerplay: add

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

> Sent: 2018年8月30日 13:06 > To: Quan, Evan > Cc: amd-gfx list ; Deucher, Alexander > ; Zhu, Rex > Subject: Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support > > On Wed, Aug 29, 2018 at 11:54 PM Quan, Evan > wrote: > > > > Hi Alex, >

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

Thanks Paul, Comment inline > -Original Message- > From: Paul Menzel > Sent: 2018年8月29日 20:23 > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org; Alex Deucher > ; Zhu, Rex > Subject: Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support > > Dear E

RE: [PATCH] drm/amd/powerplay: added vega20 overdrive support

I just sent out a V2 patch which adds the clock overdrive and fixes some minor issues pointed out by Paul. Regards, Evan > -Original Message- > From: Quan, Evan > Sent: 2018年8月30日 13:56 > To: 'Alex Deucher' > Cc: amd-gfx list ; Deucher, Alexander > ; Zhu, Rex > Sub

Re: [PATCH] drm/amdgpu: Add CLK IP base offset

Reviewed-by: Evan Quan From: amd-gfx on behalf of Rex Zhu Sent: Thursday, July 5, 2018 4:39:44 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amdgpu: Add CLK IP base offset so we can read/write the registers in CLK domain through

RE: [PATCH 03/10] drm/amdgpu: init rlc save restore as long as the lists exist

+ if (adev->gfx.rlc.reg_list_format_size_bytes && + adev->gfx.rlc.reg_list_size_bytes && + adev->gfx.rlc.reg_restore_list_size) { Regards, Evan > -Original Message- > From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Friday, July 06, 2018 6:15 PM >

RE: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status

Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:09 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and > pg status > >

RE: [PATCH 04/10] drm/amdgpu: correct direct reg list length for v2_0 rlc

md.com] > Sent: Thursday, July 05, 2018 11:07 PM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 04/10] drm/amdgpu: correct direct reg list length for > v2_0 rlc > > On Thu, Jul 05, 2018 at 05:09:29PM +0800, Evan Quan wrote: > > For v2_0 rlc,

RE: [PATCH 06/10] drm/amdgpu: no touch for the reserved bit of RLC_CGTT_MGCG_OVERRIDE

Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 06/10] drm/amdgpu: no touch for the reserved bit of > RLC_CGTT_MGCG_OVERRIDE >

RE: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to wait before request CGCG

Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to > wait before request CGC

RE: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode Apis directly

Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode > Apis directly >

RE: [PATCH 10/10] drm/amd/powerplay: no need to mask workable gfxoff feature for vega12

Ping.. > -Original Message- > From: Evan Quan [mailto:evan.q...@amd.com] > Sent: Thursday, July 05, 2018 5:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan > Subject: [PATCH 10/10] drm/amd/powerplay: no need to mask workable > gfxoff feature for vega1

RE: [PATCH 03/10] drm/amdgpu: init rlc save restore as long as the lists exist

For vega10, the rlc save & restore list is still not imported yet. Regards, Evan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Huang Rui > Sent: Thursday, July 05, 2018 11:19 PM > To: Quan, Evan > Cc: amd-gfx

RE: [PATCH 01/10] drm/amdgpu: pin the csb buffer on hw init

Comment inline > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Thursday, July 05, 2018 11:25 PM > To: Huang, Ray > Cc: Quan, Evan ; amd-gfx list g...@lists.freedesktop.org> > Subject: Re: [PATCH 01/10] drm/amdgpu: pin the

RE: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to wait before request CGCG

Yes, Rv gfxoff is not affected. Regards, Evan > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Wednesday, July 11, 2018 1:20 AM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 07/10] drm/amdgpu: reduce the id

RE: [PATCH] drm/amd/powerplay: convert the sclk/mclk into Mhz for comparation

From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Wednesday, July 11, 2018 11:35 PM > To: Quan, Evan > Cc: amd-gfx list > Subject: Re: [PATCH] drm/amd/powerplay: convert the sclk/mclk into Mhz > for comparation > > On Wed, Jul 11, 2018 at 4:26 AM, Evan Quan wrot

RE: [PATCH v3] drm/amdgpu: reserved requested gtt buffer for smu

Reviewed-by: Evan Quan Regards, Evan >-Original Message- >From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex >Zhu >Sent: Wednesday, January 17, 2018 1:56 PM >To: amd-gfx@lists.freedesktop.org >Cc: Zhu, Rex >Subject:

RE: [PATCH 2/2] drm/amdgpu: Fix suspend hang on RV

Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Tuesday, March 13, 2018 3:01 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amdgpu: Fix

RE: [PATCH] drm/amd/pp: Fix memory leak in error path in smumgr

Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Wednesday, March 14, 2018 4:17 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amd/pp: Fix memory

RE: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path

Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Wednesday, March 14, 2018 9:46 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject:

RE: [PATCH] drm/amdgpu: Delete dead code when early init

Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Friday, March 16, 2018 12:49 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amdgpu: Delete dead

RE: [PATCH 4/5] drm/amd/pp: Remove unneeded void * casts in cz_hwmgr.c/cz_smumgr.c

Is there any compile warning with the casting stripped? There is similar casting in other files. Should I expect more similar patches? Other patches in the serial are Reviewed-by: Evan Quan Regards, Evan -Original Message- From: amd-gfx

答复: [PATCH] drm/amdgpu: fix null pointer panic with direct fw loading on gpu reset

Reviewed-by: Evan Quan 发件人: amd-gfx 代表 Huang Rui 发送时间: 2018年4月8日 14:57:34 收件人: Deucher, Alexander; amd-gfx@lists.freedesktop.org 抄送: Huang, Ray 主题: [PATCH] drm/amdgpu: fix null

答复: [PATCH 2/2] drm/amd/pp: Remove dead interface

Reviewed-by: Evan Quan 发件人: amd-gfx 代表 Rex Zhu 发送时间: 2018年4月13日 16:19:14 收件人: amd-gfx@lists.freedesktop.org 抄送: Zhu, Rex 主题: [PATCH 2/2] drm/amd/pp: Remove dead interface

答复: [PATCH 1/2] drm/amdgpu: Reserved vram for smu to save debug info.

Do we need to add check for adev->pm.smu_prv_buffer_size before calling pp_reserve_vram_for_smu()? I mean maybe for dev->pm.smu_prv_buffer_size ==0, there is no need to proceed pp_reserve_vram_for_smu. Regards, Evan 发件人: amd-gfx

RE: [PATCH] drm/amd/pp: Fix NULL point check error in smu_set_watermarks_for_clocks_ranges

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Thursday, April 19, 2018 12:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH]

RE: [PATCH v2] drm/amdgpu: Reserved vram for smu to save debug info.

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Monday, April 16, 2018 1:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2]

RE: [PATCH 2/2] drm/amd/pp: Use dynamic gfx_clk rather than hardcoded values

Series is Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Friday, April 20, 2018 2:30 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH

RE: [PATCH] drm/amdgpu: for sriov timeout is still enforced on compute rings

Yes, of course. I have sent out a new patch with the code cleaned. Regards, Evan From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, March 27, 2018 3:52 PM To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <alexa

RE: [PATCH] drm/amdgpu: drop compute ring timeout setting for non-sriov only (v2)

Thanks! Will correct it on patch submit. Regards, Evan > -Original Message- > From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Tuesday, March 27, 2018 4:20 PM > To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org > Cc: Koenig, Chr

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

adev)) ? Regards, Evan From: Deucher, Alexander Sent: Monday, March 26, 2018 11:20 PM To: Liu, Monk <monk@amd.com>; Quan, Evan <evan.q...@amd.com>; Michel Dänzer <mic...@daenzer.net> Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on

RE: [PATCH 2/2] drm/amd/pp: Not call cgs interface to get display info

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Tuesday, March 27, 2018 3:55 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 2/2]

RE: [PATCH] drm/amd/pp: Not call cgs interface to get display info

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, March 28, 2018 12:45 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH]

RE: [PATCH] drm/amd/powerplay: Enable ACG SS feature

Hi Kenneth, There are several places which fix old coding style(comment inline). Please drop them since this is not a patch to fix coding style. Other than that, the patch is reviewed-by: Evan Quan Regards, Evan > -Original Message- > From: amd-gfx

RE: [PATCH] drm/amdgpu: Use dpm_enabled as the dpm state flag

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Monday, March 26, 2018 4:24 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amdgpu:

RE: [PATCH] amd/powerplay: enable the ACG SS feature

Hi Kenneth, Per my understanding, this can be splitted into three patches: 1. add new PPSMC_MSG 2. GNLD_ACG renamed as GNLD_ACG_DEBUG related. In fact, this change seem not so necessary. 3. smc_dpm structure change related Regards, Evan > -Original Message- > From: amd-gfx

RE: [PATCH] drm/amdgpu: disable job timeout on GPU reset disabled

age- > From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Monday, March 19, 2018 5:42 PM > To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander <alexander.deuc...@amd.com> > Subject: Re: [PATCH] drm/amdgpu: disable job t

RE: [PATCH 5/6] drm/amd/pp: Delete get_xclk function in powerplay

There seems one unnecessary change in vega10_fan_ctrl_set_fan_speed_rpm(). Other than that, the series is Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Friday, March 16, 2018 5:40 PM

RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues

That's fine for me. Will update the patch accordingly. Regards, Evan From: Deucher, Alexander Sent: Saturday, March 17, 2018 1:17 AM To: Michel Dänzer <mic...@daenzer.net>; Quan, Evan <evan.q...@amd.com> Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: no job tim

RE: [PATCH] drm/amdgpu: disable job timeout on GPU reset disabled

[mailto:evan.q...@amd.com] Sent: Monday, March 19, 2018 2:08 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Quan, Evan <evan.q...@amd.com> Subject: [PATCH] drm/amdgpu: disable job timeout on GPU reset disabled Since under some heavy computing environmen

RE: [PATCH 1/4] drm/amd/pp: Implement get/set_power_profile_mode on smu7

Comment inline. Regards Evan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Friday, March 02, 2018 8:44 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 1/4] drm/amd/pp: Implement

  1   2   3   4   5   6   7   8   9   10   >