Failing tests

2021-09-21 Thread Patrick Eriksson

Hi all,

I have spent some time on trying to figure out how the changes in my 
branch could have created some failing tests. But just run make 
check-all with master and the same tests failed also there, so there 
seem to be older issues.


The failed tests listed below. These issues under control? Noticed that 
some tests demand an accuracy of 2nK! The deviation was 2.5 mK, which 
can be OK. On the other hand, there were also tests failing with 
deviations of 30-100 K.


Bye,

Patrick



The following tests FAILED:
 42 - arts.ctlfile.slow.artscomponents.clearsky.TestBatch (Failed)
 43 - python.arts.ctlfile.slow.artscomponents.clearsky.TestBatch 
(Failed)
152 - arts.ctlfile.slow.instruments.odinsmr.TestOdinSMR_1D (Failed)
153 - python.arts.ctlfile.slow.instruments.odinsmr.TestOdinSMR_1D 
(Failed)
156 - arts.ctlfile.slow.instruments.hirs.TestHIRS_fast (Failed)
157 - python.arts.ctlfile.slow.instruments.hirs.TestHIRS_fast (Failed)
158 - arts.ctlfile.slow.instruments.metmm.TestMetMM (Failed)
159 - python.arts.ctlfile.slow.instruments.metmm.TestMetMM (Failed)
	180 - 
arts.ctlfile.xmldata.artscomponents.arts-xml-data.TestPlanetIsoRatios 
(Failed)
	181 - 
python.arts.ctlfile.xmldata.artscomponents.arts-xml-data.TestPlanetIsoRatios 
(Failed)

184 - arts.ctlfile.xmldata.artscomponents.cia.TestRTwithCIA (Failed)
185 - python.arts.ctlfile.xmldata.artscomponents.cia.TestRTwithCIA 
(Failed)
232 - arts.pyarts.pytest (Failed)






Re: Correct text encoding for ARTS source code?

2021-09-21 Thread Oliver Lemke
Hi Stuart,

The Unix `file` command reports it as ISO-8859. If that doesn't work, send me a 
line number with an example of the broken characters, then I can have a closer 
look.

Cheers,
Oliver


> On 21 Sep 2021, at 15:02, Fox, Stuart  wrote:
> 
> Hi arts devs,
> 
> I’m currently working on incorporating v3.5 of the MT-CKD continuum into 
> ARTS, and have a question relating to the “correct” text encoding for the 
> ARTS source files.
> The file I’m working on (legacy_continua.cc) has some non-ASCII characters in 
> the comments, which I think are mostly things like superscripted numbers. 
> What text encoding is used for these? If I open the file in VS Code (which 
> assumes it is UTF-8 encoded by default) they show up as unknown characters, 
> and this particular editor then changes them when the file is saved which 
> leads to lots of undesired diffs. Which encoding should I tell the editor to 
> use for these files to avoid this? It looks to me like it’s probably one of 
> the “Western” encodings, e.g. Windows 1252 or ISO-8859-x , but it would be 
> good to confirm which one I should use!
> 
> Stuart



Correct text encoding for ARTS source code?

2021-09-21 Thread Fox, Stuart
Hi arts devs,

I'm currently working on incorporating v3.5 of the MT-CKD continuum into ARTS, 
and have a question relating to the "correct" text encoding for the ARTS source 
files.
The file I'm working on (legacy_continua.cc) has some non-ASCII characters in 
the comments, which I think are mostly things like superscripted numbers. What 
text encoding is used for these? If I open the file in VS Code (which assumes 
it is UTF-8 encoded by default) they show up as unknown characters, and this 
particular editor then changes them when the file is saved which leads to lots 
of undesired diffs. Which encoding should I tell the editor to use for these 
files to avoid this? It looks to me like it's probably one of the "Western" 
encodings, e.g. Windows 1252 or ISO-8859-x , but it would be good to confirm 
which one I should use!

Stuart