---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/
---
Review request for Asterisk Developers.
Bugs: /, ASTERISK-23897 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/
---
(Updated June 19, 2014, 6:17 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3629/#review12186
---
Ship it!
Thanks George your patch solves the issue.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3629/#review12187
---
Ship it!
Ship It!
- Joshua Colp
On June 18, 2014, 11:27
On June 10, 2014, 11:22 a.m., Joshua Colp wrote:
/branches/11/main/channel.c, line 7113
https://reviewboard.asterisk.org/r/3603/diff/1/?file=59449#file59449line7113
This change is hazardous. It makes it so that some file descriptors on
the original channel which were from the
On Fri, Jun 13, 2014 at 2:44 AM, Corey Farrell g...@cfware.com wrote:
I was looking at reviews.reviewboard.org to see if anything was in the works
to allow restricted reviews, I found
https://reviews.reviewboard.org/groups/security/ - This group is
invite-only. You must be a member of this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3626/#review12189
---
Ship it!
Ship It!
- Joshua Colp
On June 17, 2014, 10:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3646/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23905
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3647/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23905
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3646/
---
(Updated June 19, 2014, 8:51 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3646/#review12190
---
Closing this one out in favour of
On June 19, 2014, 8:51 a.m., Matt Jordan wrote:
Closing this one out in favour of https://reviewboard.asterisk.org/r/3647/
Bah. Just saw that this one was for trunk, while 3647 was for Asterisk 12.
(This is why filling out a description is sometimes helpful :-) )
Feel free re-open this if
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3647/#review12192
---
branches/12/main/tcptls.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/#review12193
---
Update:
* The sample config with the new option
* The
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/
---
(Updated June 19, 2014, 9:20 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3618/#review12195
---
Ship it!
Ship It!
- Matt Jordan
On June 18, 2014, 5:23
On June 19, 2014, 9:20 a.m., Matt Jordan wrote:
Update:
* The sample config with the new option
* The UPGRADE.txt file documenting the new option
This patch should also be written against 1.8, as that is where this issue was
first introduced.
- Matt
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3647/
---
(Updated June 19, 2014, 2:34 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3625/
---
(Updated June 19, 2014, 10:50 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/
---
Review request for Asterisk Developers and rmudgett.
Bugs: AFS-78
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23866
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3363/#review12197
---
Ship it!
Ship It!
- opticron
On June 15, 2014, 2:43 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3629/
---
(Updated June 19, 2014, 10:59 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/
---
Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3651/
---
Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12202
---
/trunk/pbx/pbx_config.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12200
---
/trunk/main/pbx.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12201
---
/trunk/pbx/pbx_config.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3651/#review12203
---
Ship it!
Ship It!
- Mark Michelson
On June 19, 2014, 5:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3652/
---
Review request for Asterisk Developers.
Repository: Asterisk
On June 19, 2014, 5:48 p.m., Mark Michelson wrote:
trunk/include/asterisk/bridge_channel.h, lines 645-653
https://reviewboard.asterisk.org/r/3649/diff/1/?file=59854#file59854line645
Add documentation that chan must be locked when calling this.
Ignore this since I covered this in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12204
---
trunk/include/asterisk/bridge_channel.h
On June 19, 2014, 12:08 p.m., opticron wrote:
/trunk/pbx/pbx_config.c, line 51
https://reviewboard.asterisk.org/r/3650/diff/1/?file=59862#file59862line51
s/N/n/
On June 19, 2014, 12:08 p.m., opticron wrote:
/trunk/pbx/pbx_config.c, line 46
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12210
---
As far as testing this patch is concerned, we should have Test
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3650/#review12211
---
/trunk/pbx/pbx_config.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3652/#review12209
---
branches/12/main/acl.c
On June 19, 2014, 12:48 p.m., Mark Michelson wrote:
trunk/main/bridge_channel.c, line 2468
https://reviewboard.asterisk.org/r/3649/diff/1/?file=59857#file59857line2468
Is this cast required? Either way, it's one of the weirder-looking
things I've come across :)
Matt Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12214
---
trunk/main/bridge_channel.c
On June 19, 2014, 12:48 p.m., Mark Michelson wrote:
trunk/main/bridge_channel.c, line 2468
https://reviewboard.asterisk.org/r/3649/diff/1/?file=59857#file59857line2468
Is this cast required? Either way, it's one of the weirder-looking
things I've come across :)
Matt Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/#review12217
---
/team/group/rls/res/res_pjsip_pubsub.c
On June 19, 2014, 6:12 p.m., Matt Jordan wrote:
/team/group/rls/res/res_pjsip_pubsub.c, lines 2087-2088
https://reviewboard.asterisk.org/r/3648/diff/1/?file=59859#file59859line2087
You may want to provide a min/max range for this option. Otherwise,
someone may provide a
On June 19, 2014, 1:03 p.m., Matt Jordan wrote:
This will also need dedicated tests in the Test Suite. Tests should verify
that for a particular feature code, bouncing out of a bridge and returning
to it activates the feature.
I'll write a couple of unit tests for this.
- opticron
On June 19, 2014, 6:01 p.m., Mark Michelson wrote:
branches/12/main/netsock2.c, lines 156-160
https://reviewboard.asterisk.org/r/3652/diff/1/?file=59870#file59870line156
This loop is incorrect. I believe it should be:
if (j = 0; j 8; ++j) {
if ((addr[i] j)
On June 19, 2014, 1:12 p.m., Matt Jordan wrote:
/team/group/rls/res/res_pjsip_pubsub.c, lines 2087-2088
https://reviewboard.asterisk.org/r/3648/diff/1/?file=59859#file59859line2087
You may want to provide a min/max range for this option. Otherwise,
someone may provide a
On June 19, 2014, 1 p.m., Matt Jordan wrote:
/trunk/pbx/pbx_config.c, lines 504-506
https://reviewboard.asterisk.org/r/3650/diff/1/?file=59862#file59862line504
Failed to add extension is not quite the correct error message to
send in this case.
Internal error a better choice?
On June 18, 2014, 3:54 a.m., rmudgett wrote:
/branches/1.8/configs/features.conf.sample, line 23
https://reviewboard.asterisk.org/r/3621/diff/2/?file=59773#file59773line23
You might want to have a standard default format for the options in
this file for consistency. You likely
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3628/#review12224
---
/trunk/res/res_pjsip_pubsub.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3652/
---
(Updated June 19, 2014, 1:29 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/
---
(Updated June 19, 2014, 7:29 p.m.)
Review request for Asterisk
On June 19, 2014, 12:01 p.m., Mark Michelson wrote:
branches/12/main/netsock2.c, lines 156-160
https://reviewboard.asterisk.org/r/3652/diff/1/?file=59870#file59870line156
This loop is incorrect. I believe it should be:
if (j = 0; j 8; ++j) {
if ((addr[i] j)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3622/
---
(Updated June 19, 2014, 7:30 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/#review12206
---
Most of the changes to eliminate the RTTI code can be
On June 19, 2014, 6:01 p.m., Mark Michelson wrote:
branches/12/main/acl.c, line 683
https://reviewboard.asterisk.org/r/3652/diff/1/?file=59869#file59869line683
It's typically a good idea to avoid ast_strdupa() inside a for loop
since it theoretically could blow the stack on a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3625/#review12220
---
Very nice work!
On June 19, 2014, 7:26 p.m., Matt Jordan wrote:
/trunk/res/res_pjsip_pubsub.c, line 302
https://reviewboard.asterisk.org/r/3628/diff/1/?file=59788#file59788line302
Parent/child aside, I do enjoy the name of this union
Honestly, this was the hardest part of the change. I really
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/#review12229
---
/team/group/rls/res/res_pjsip_pubsub.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3652/#review12231
---
Ship it!
Ship It!
- Mark Michelson
On June 19, 2014, 7:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3652/
---
(Updated June 19, 2014, 3:12 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3625/
---
(Updated June 19, 2014, 4:18 p.m.)
Review request for Asterisk
On June 19, 2014, 3:56 p.m., Matt Jordan wrote:
/team/group/media_formats-reviewed/main/core_unreal.c, line 900
https://reviewboard.asterisk.org/r/3625/diff/1/?file=59756#file59756line900
Given the number of off nominal paths *and* the fact that this will be
de-ref'd on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3625/#review12232
---
/team/group/media_formats-reviewed/main/sounds_index.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3628/
---
(Updated June 19, 2014, 8:29 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3625/
---
(Updated June 19, 2014, 4:31 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/
---
(Updated June 19, 2014, 9 p.m.)
Review request for Asterisk Developers.
On June 19, 2014, 2:56 p.m., Matt Jordan wrote:
/team/group/media_formats-reviewed/main/data.c, lines 3122-3126
https://reviewboard.asterisk.org/r/3625/diff/1/?file=59757#file59757line3122
Is/was fr_len used anywhere else?
Corey Farrell wrote:
fr_len is still referenced from
On June 19, 2014, 1 p.m., Matt Jordan wrote:
/trunk/pbx/pbx_config.c, lines 504-506
https://reviewboard.asterisk.org/r/3650/diff/1/?file=59862#file59862line504
Failed to add extension is not quite the correct error message to
send in this case.
Jonathan Rose wrote:
On June 19, 2014, 1:31 p.m., rmudgett wrote:
branches/12/main/astobj2_rbtree.c, lines 1324-1330
https://reviewboard.asterisk.org/r/3593/diff/3/?file=59520#file59520line1324
This is common code to any astobj2 container and should be pulled back
up to the general container code in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/
---
(Updated June 19, 2014, 3:26 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3363/
---
(Updated June 19, 2014, 4:34 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/#review12236
---
Ship it!
/team/group/rls/res/res_pjsip_pubsub.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3548/#review12237
---
Ship it!
Ship It!
- rmudgett
On June 17, 2014, 1:30 p.m.,
On June 19, 2014, 3:56 p.m., Matt Jordan wrote:
/team/group/media_formats-reviewed/main/data.c, lines 3122-3126
https://reviewboard.asterisk.org/r/3625/diff/1/?file=59757#file59757line3122
Is/was fr_len used anywhere else?
Corey Farrell wrote:
fr_len is still referenced from
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3476/
---
(Updated June 19, 2014, 5:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/#review12238
---
branches/12/main/astobj2_container.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/
---
(Updated June 19, 2014, 10:47 p.m.)
Review request for Asterisk
On June 19, 2014, 9:37 p.m., Matt Jordan wrote:
/team/group/rls/res/res_pjsip_pubsub.c, lines 2085-2086
https://reviewboard.asterisk.org/r/3648/diff/2/?file=59946#file59946line2085
I'm not sure if it will end up mattering, but if event is less than the
size of the char array (32)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/
---
(Updated June 19, 2014, 5:04 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/#review12241
---
The always_send_progress option needs to be documented in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/#review12242
---
branches/12/main/astobj2_container.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3621/#review12243
---
Ship it!
I haven't been looking at the v11 review since it
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3622/#review12244
---
Ship it!
Ship It!
- rmudgett
On June 19, 2014, 2:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/
---
(Updated June 19, 2014, 5:47 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/#review12245
---
Ship it!
Ship It!
- rmudgett
On June 19, 2014, 6:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12246
---
trunk/main/bridge.c
On June 19, 2014, 2:56 p.m., Matt Jordan wrote:
/team/group/media_formats-reviewed/main/data.c, lines 3122-3126
https://reviewboard.asterisk.org/r/3625/diff/1/?file=59757#file59757line3122
Is/was fr_len used anywhere else?
Corey Farrell wrote:
fr_len is still referenced from
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/
---
(Updated June 20, 2014, 5:28 a.m.)
Review request for Asterisk
86 matches
Mail list logo
