---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3396/#review11371
---
Ship it!
Ship It!
- Mark Michelson
On March 25, 2014, 6:59
, it looks good to me.
./asterisk/trunk/tests/channels/pjsip/headers/test-config.yaml
https://reviewboard.asterisk.org/r/3392/#comment21020
These two scenarios don't need '-d': '3000' since they do not have any
pause / elements in them.
- Mark Michelson
On March 25, 2014, 3:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3386/#review11374
---
Ship it!
Ship It!
- Mark Michelson
On March 25, 2014, 7:13
/3384/diff/
Testing
---
See /r/3385
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
-CREATION
Diff: https://reviewboard.asterisk.org/r/3385/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
/subscriptions/presence/tests.yaml
https://reviewboard.asterisk.org/r/3357/#comment21007
unallowed and below_min_expiry don't have anything to do with presence in
particular, so they shouldn't be in the presence subdirectory.
- Mark Michelson
On March 14, 2014, 7:13 p.m., Jonathan Rose wrote
for?
/asterisk/trunk/tests/apps/confbridge/confbridge_start_muted/test-config.yaml
https://reviewboard.asterisk.org/r/3374/#comment21008
I suggest organizing these events into their respective channels sections.
- Mark Michelson
On March 18, 2014, 7:54 p.m., Jonathan Rose wrote
---
On March 17, 2014, 8:31 p.m., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3326
because the realtime testsuite is a work
in progress.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
onto Corey's comment, if you add a third classification of objects
based on overaggressive ref decrementing, then that should also have its own
word here as well.
- Mark Michelson
On March 19, 2014, 6:22 p.m., Matt Jordan wrote
it is the correct fix to be
applying, but after going through the scenarios in my head, this looks like a
good way to get around the problem.
- Mark Michelson
On March 17, 2014, 2:21 p.m., one47 wrote:
---
This is an automatically generated e
/codec.h
https://reviewboard.asterisk.org/r/3319/#comment20940
Kind of a nitpick, but for this and ast_format_determine_length(), the word
determine is out of place. Just a simple get works better.
- Mark Michelson
On March 20, 2014, 11:40 a.m., Joshua Colp wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3318/#review11300
---
Ship it!
Ship It!
- Mark Michelson
On March 20, 2014, 11
/test-config.yaml
https://reviewboard.asterisk.org/r/3348/#comment20948
This should work for 12.0.0 as well.
- Mark Michelson
On March 14, 2014, 2:24 p.m., jbigelow wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3354/#review11307
---
Ship it!
Ship It!
- Mark Michelson
On March 14, 2014, 2:26
made are within the coding
guidelines. If the changes are working for you, then this change is fine to go
in.
- Mark Michelson
On March 20, 2014, 2:37 p.m., zvision wrote:
---
This is an automatically generated e-mail. To reply, visit
It'll take some getting
used to, but I don't mind switching. Are there other handy commands
besides #close and #comment that you can use?
Oh, and be sure to update the wiki page that has the commit message
template!
Matthew Jordan
Tuesday, March
18, 2014 1:25 PM
To answer my own question,
yes there are some other commands, but they're not really useful for
typical ASTERISK issues on the issue tracker (time-tracking commands and
workflow transition commands).
Mark Michelson
Tuesday, March
18, 2014 2:24 PM
It'll take some
to ensure that the specified file was actually being played as promised.
I also queued up several files in quick succession to ensure that they played
in series and not on top of each other.
In addition, I have created an automated test that is up for review at /r/3339
Thanks,
Mark Michelson
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3326/#review11258
---
On March 15, 2014, 5:29 p.m., Mark Michelson wrote
in progress.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
/diff/
Testing
---
My tests of retrieving data from realtime now get the expected objects. I don't
have any automated tests to post yet because the realtime testsuite is a work
in progress.
Thanks,
Mark Michelson
Diff: https://reviewboard.asterisk.org/r/3363/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
On March 13, 2014, 11:13 p.m., Mark Michelson wrote:
One thing I notice about this test is that it is structured to call the
first extension, then when that finishes, call the second, then when that
finishes, call the third, etc.
Since no call depends on any of the previous call
being played as promised.
I also queued up several files in quick succession to ensure that they played
in series and not on top of each other.
In addition, I have created an automated test that is up for review at /r/3339
Thanks,
Mark Michelson
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
to subscribe to
an AOR that provides MWI for that mailbox as well.
Diffs
-
/branches/12/res/res_pjsip_mwi.c 410467
Diff: https://reviewboard.asterisk.org/r/3344/diff/
Testing
---
I have posted an accompanying test at /r/3345
Thanks,
Mark Michelson
, the stores and updates are properly detected as successful
and sorcery now notifies observers when content is created.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
of retrieving data from realtime now get the expected objects. I don't
have any automated tests to post yet because the realtime testsuite is a work
in progress.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided
as promised.
I also queued up several files in quick succession to ensure that they played
in series and not on top of each other.
In addition, I have created an automated test that is up for review at /r/3339
Thanks,
Mark Michelson
your manual test
you did and translating it into a test for the testsuite.
- Mark Michelson
On March 12, 2014, 6:02 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
ends up committing this: This bug also exists in 1.8, 12, and
trunk. The 1.8 fix is exactly the same as this one. The 12 and trunk fixes will
be slightly different since the update_odbc() callback takes an ast_variable
list instead of va_args. The fix is still very similar though.
- Mark
://reviewboard.asterisk.org/r/3325/#comment20819
Description is incomplete.
- Mark Michelson
On March 10, 2014, 9:24 p.m., rmudgett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r
., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3338/
---
(Updated March 13, 2014, 2:53 p.m.)
Review
played as promised.
I also queued up several files in quick succession to ensure that they played
in series and not on top of each other.
In addition, I have created an automated test that is up for review at /r/3339
Thanks,
Mark Michelson
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3328/#review11194
---
Ship it!
Ship It!
- Mark Michelson
On March 11, 2014, 7:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3330/#review11195
---
Ship it!
Ship It!
- Mark Michelson
On March 11, 2014, 11
played as promised.
I also queued up several files in quick succession to ensure that they played
in series and not on top of each other.
In addition, I have created an automated test that is up for review at /r/3339
Thanks,
Mark Michelson
Michal Rybrik
Thursday, March
13, 2014 4:03 PM
Hello,
how and when is main/version.c generated ? I checked out branch-11
svn,
compiled, packaged for debian, and now I realized that "core show
version" is diffent than version that I got from SVN.
main/version.c
static
., Mark Michelson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3338/
---
(Updated March 13, 2014, 7 p.m.)
Review
numerals. Obviously,
as with every rule, there are exceptions to this.
./asterisk/trunk/tests/agi/exit_status/run-test
https://reviewboard.asterisk.org/r/3329/#comment20834
Change this to an error instead of info, and print the value of
test.success_count.
- Mark Michelson
On March 11, 2014
://reviewboard.asterisk.org/r/3339/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
an automated test that is up for review at /r/3339
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
/play_file.py
https://reviewboard.asterisk.org/r/3339/#comment20796
Note to self: Use the correct year in copyright headers.
- Mark Michelson
On March 12, 2014, 5:29 p.m., Mark Michelson wrote:
---
This is an automatically generated
/asterisk/trunk/tests/rest_api/playback/tests.yaml 4836
Diff: https://reviewboard.asterisk.org/r/3339/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
the expected objects. I don't
have any automated tests to post yet because the realtime testsuite is a work
in progress.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
tests. In this case, with store and update, the
easiest way to test was to use realtime as sorcery's backend when using
external MWI.
With these changes, the stores and updates are properly detected as successful
and sorcery now notifies observers when content is created.
Thanks,
Mark
/channels/pjsip/subscriptions/mwi/conflict/configs/ast1/pjsip.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3345/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http
://reviewboard.asterisk.org/r/3344/diff/
Testing
---
I have posted an accompanying test at /r/3345
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
/sorcery.c 410467
Diff: https://reviewboard.asterisk.org/r/3326/diff/
Testing
---
My tests of retrieving data from realtime now get the expected objects. I don't
have any automated tests to post yet because the realtime testsuite is a work
in progress.
Thanks,
Mark Michelson
On March 6, 2014, 9:20 p.m., Mark Michelson wrote:
I'm not a fan of this change, because I think it's not really fixing the
root problem. bridge_p2p_rtp_write() is called in only one place in
res_rtp_asterisk.c, and it's called like this:
/* If we are directly bridged
with flying colors.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
/sorcery.h 410010
Diff: https://reviewboard.asterisk.org/r/3305/diff/
Testing
---
All realtime sorcery unit tests pass with flying colors.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http
with flying colors.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
s/crash in/crash/
- Mark Michelson
On March 6, 2014, 5:44 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286
to verify this. The crashing thread has
channel 0x7f5e943a3cc0 being read from while simultaneously in thread 7380, the
same channel is part of a masquerade that occured as a result of a SIP attended
transfer.
- Mark Michelson
On March 5, 2014, 6:49 p.m., Russell Bryant wrote
on commit.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review6
---
On March 6, 2014, 8:17 p.m., Mark Michelson wrote
put it up there with tabs.
Matt Jordan wrote:
10/10 of wiki pages agree: spaces tabs
Mark Michelson wrote:
What's funny is that I didn't copy from the wiki page. I copied from a
hash function from within the file. I suppose that means the other hash
function is using spaces
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/#review11123
---
Ship it!
Ship It!
- Mark Michelson
On March 6, 2014, 8:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3206/#review11126
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 23, 2014, 6:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3102/#review11125
---
Ship it!
- Mark Michelson
On Feb. 23, 2014, 5:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3265/#review11124
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 25, 2014, 12:55
/branches/12/main/sorcery.c 409886
/branches/12/include/asterisk/sorcery.h 409886
Diff: https://reviewboard.asterisk.org/r/3305/diff/
Testing
---
All realtime sorcery unit tests pass with flying colors.
Thanks,
Mark Michelson
to the container type as I was not sure if
the ordering of the objects was important in the container. If so, then the
red-black tree option could be used with some small modifications to the
ast_sorcery_object_field structure.
- Mark Michelson
On March 5, 2014, 11:40 p.m., Mark Michelson wrote
/pjsua_mod.py 4701
Diff: https://reviewboard.asterisk.org/r/3238/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
to easily determine that res_pjsip_mwi.c is actually
doing the right thing.
I've done some brief manual tests with SIPp and I've run the MWI tests in the
testsuite to ensure that these code changes have not caused issues. But that
really doesn't exercise the code changes presented here.
Thanks,
Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3234/#review10920
---
Page 3 review complete. No issues found.
- Mark Michelson
the code in the referenced review be the
proper way to handle things or is the idea proposed in this message a
better idea?
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
George Joseph
Thursday,
February 20, 2014 9:47 AM
snipWith my
"user" hat on, I think this is fair. What would the subscription
rejection look like?
Since the issue doesn't lie with the SUBSCRIBE itself but rather with
server configuration, a 500 response seems
Brad Watkins
Thursday,
February 20, 2014 1:44 PM
For clarity I'd
like to see the error message be more explicit about*why* the
endpoint is already receiving notifications.- Brad
Sounds reasonable enough to me!
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3239/#review10914
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 19, 2014, 10:38
.
- Mark Michelson
On Feb. 19, 2014, 10:38 p.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3240
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3241/#review10916
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 20, 2014, 5:33
/#comment20531
This seems like as good a time as any to get rid of all this red while
you're in the area.
- Mark Michelson
On Feb. 16, 2014, 3:56 p.m., Joshua Colp wrote:
---
This is an automatically generated e-mail. To reply
brief manual tests with SIPp and I've run the MWI tests in the
testsuite to ensure that these code changes have not caused issues. But that
really doesn't exercise the code changes presented here.
Thanks,
Mark Michelson
,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
doesn't exercise the code changes presented here.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
that have a limited set
of values. This same practice can be applied to certain queue options. For
instance, the strategy option could use an enum to limit the choices to the
valid ring strategies.
- Mark Michelson
On Feb. 15, 2014, 1:40 a.m., rmudgett wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3235/#review10899
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 17, 2014, 9:57
SLIN to 1 idx. Now it's setting up a translation
path from SLIN to the channel's raw write format.
Why is this change being made?
- Mark Michelson
On Feb. 16, 2014, 3:56 p.m., Joshua Colp wrote:
---
This is an automatically
://reviewboard.asterisk.org/r/3218/
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml
4701
Diff: https://reviewboard.asterisk.org/r/3218/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation
had recommended making this unsigned before.
/branches/12/res/res_hep.c
https://reviewboard.asterisk.org/r/3207/#comment20497
Any particular reason you lowercased all these? It makes it less clear now
that these are constant values when used later.
- Mark Michelson
On Feb. 14, 2014, 3:58
Kevin Harwell
Thursday,
February 13, 2014 5:43 PM
Greetings,There is
a bug currently in Asterisk that essentially boils down to MOHnot
being [re]started for an attended transfered call when thetransferor
was listening to it.For example, here is a specific scenario
the defer flag
if the transfer does not succeed. Sending a NOTIFY stating that the transfer
failed could result in the transferrer resuming the call. If that happens, we
don't want to defer the BYE anymore.
- Mark Michelson
On Feb. 13, 2014, 4:29 a.m., Matt Jordan wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3214/#review10869
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 13, 2014, 3:01
/res_pjsip.c 407957
/branches/12/include/asterisk/res_pjsip.h 407957
/branches/12/contrib/ast-db-manage/config/versions/8b89128752a_add_user_agent.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3216/diff/
Testing
---
See https://reviewboard.asterisk.org/r/3218/
Thanks,
Mark
Diff: https://reviewboard.asterisk.org/r/3218/diff/
Testing
---
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
MWI using the testsuite's MWI test.
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com
---
See https://reviewboard.asterisk.org/r/3218/
Thanks,
Mark Michelson
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3185/#review10857
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 12, 2014, 1:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3213/#review10862
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 12, 2014, 7:26
it.
- Mark Michelson
On Feb. 11, 2014, 7:37 p.m., Scott Griepentrog wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3209
comment applies for the logging_on_rx_msg function)
- Mark Michelson
On Feb. 11, 2014, 12:21 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3207
/trunk/tests/hep/hep_capture_node.py
https://reviewboard.asterisk.org/r/3206/#comment20461
Another place for an enum-style class to be used.
- Mark Michelson
On Feb. 11, 2014, 12:22 p.m., Matt Jordan wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3201/#review10854
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 9, 2014, 9:44
recall if that's a guarantee or not though.
- Mark Michelson
On Feb. 11, 2014, 5:13 p.m., opticron wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3185
407935
/branches/12/res/res_pjsip_mwi.c 407935
Diff: https://reviewboard.asterisk.org/r/3205/diff/
Testing
---
Ran a manual test with a Digium phone that subscribes to MWI. Tested
unsolicited MWI using the testsuite's MWI test.
Thanks,
Mark Michelson
On Feb. 4, 2014, 4:53 p.m., Corey Farrell wrote:
I like what you've done in general, I think the use of ao2 objects in
timing implementations can be possibly stopped.
Most (if not all) users of struct ast_timer are already protected by a lock
or are owned exclusively by a single
be static. If kevent() allows it, this could also be const.
/trunk/res/res_timing_timerfd.c
https://reviewboard.asterisk.org/r/3175/#comment20260
You could make this static const.
- Mark Michelson
On Feb. 4, 2014, 3:16 p.m., Joshua Colp wrote
701 - 800 of 927 matches
Mail list logo
