On 5/14/2024 9:10 PM, Masahiro Yamada wrote:
> On Wed, May 15, 2024 at 3:14 AM Jeff Johnson
> wrote:
>>
>> On 5/14/2024 10:45 AM, Masahiro Yamada wrote:
>>> On Tue, May 14, 2024 at 11:43 PM Jeff Johnson
>>> wrote:
>>>>
>>>> On 5/1
On 5/14/2024 10:45 AM, Masahiro Yamada wrote:
> On Tue, May 14, 2024 at 11:43 PM Jeff Johnson
> wrote:
>>
>> On 5/11/2024 3:49 AM, Dmitry Baryshkov wrote:
>>> If ath10k_snoc is built-in, while Qualcomm remoteprocs are built as
>>> modules, compilation fails
On 5/11/2024 3:49 AM, Dmitry Baryshkov wrote:
> If ath10k_snoc is built-in, while Qualcomm remoteprocs are built as
> modules, compilation fails with:
>
> /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in
> function `ath10k_modem_init':
>
On 5/11/2024 7:17 AM, Kalle Valo wrote:
> Jeff Johnson writes:
>
>> On 5/10/2024 7:14 AM, Christian Marangi wrote:
>>
>>> On Thu, May 09, 2024 at 09:48:08AM -0700, Jeff Johnson wrote:
>>>> On 5/9/2024 9:37 AM, Jeff Johnson wrote:
>>>>&g
On 5/10/2024 7:14 AM, Christian Marangi wrote:
> On Thu, May 09, 2024 at 09:48:08AM -0700, Jeff Johnson wrote:
>> On 5/9/2024 9:37 AM, Jeff Johnson wrote:
>>> On 5/8/2024 9:50 PM, Kalle Valo wrote:
>>>> Sorry for the delay but finally I looked at this again. I decided
On 5/9/2024 9:37 AM, Jeff Johnson wrote:
> On 5/8/2024 9:50 PM, Kalle Valo wrote:
>> Sorry for the delay but finally I looked at this again. I decided to
>> just remove the fixme and otherwise it looks good for me. Please check
>> my changes:
>>
>> https://git.ke
On 5/8/2024 9:50 PM, Kalle Valo wrote:
> Sorry for the delay but finally I looked at this again. I decided to
> just remove the fixme and otherwise it looks good for me. Please check
> my changes:
>
>
8998-based devices are affected by this issue.
> Oddly, it seems safe to NOT wait for the indicator, and
> proceed immediately when QMI_EVENT_SERVER_ARRIVE.
>
> Jeff Johnson wrote:
>
> The feedback I received was "it might be ok to change all ath10k qmi
> to skip waiting for msa_r
y, it seems safe to NOT wait for the indicator, and
> proceed immediately when QMI_EVENT_SERVER_ARRIVE.
>
> fw_version 0x100204b2
> fw_build_timestamp 2019-09-04 03:01
> fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0-01202-QCAHLSWMTPLZ-1.221523.2
>
> Jeff Johnson wrote:
&
8998-based devices are affected by this issue.
> Oddly, it seems safe to NOT wait for the indicator, and
> proceed immediately when QMI_EVENT_SERVER_ARRIVE.
>
> Jeff Johnson wrote:
>
> The feedback I received was "it might be ok to change all ath10k qmi
> to skip waiting for msa_r
some useless code.
>
> Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log
> via tracing")
> Signed-off-by: Su Hui
(try that again)
Acked-by: Jeff Johnson
some useless code.
>
> Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log
> via tracing")
> Signed-off-by: Su Hui Acked-by: Jeff Johnson
>
On 4/17/2024 1:17 AM, Su Hui wrote:
> Clang Static Checker (scan-build) Warning:
> drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
> Value stored to 'ret' is never read.
>
> Return 'ret' rather than 'count' when 'ret' stores an error code.
> By the way, remove some useless code.
On 3/29/2024 9:48 PM, Dmitry Baryshkov wrote:
> On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov
> wrote:
>>
>> The ath10k driver fails to properly handle fallback from board-2.bin to
>> board.bin for WCN3990 cards. This happens because the
>> ath10k_hw_params_list doesn't include .fw.board*
On 3/29/2024 9:47 PM, Dmitry Baryshkov wrote:
> On Wed, 6 Mar 2024 at 10:16, Dmitry Baryshkov
> wrote:
>>
>> On WCN3990 platforms actual firmware, wlanmdsp.mbn, is sideloaded to the
>> modem DSP via the TQFTPserv. These MBN files are signed by the device
>> vendor, can only be used with the
On 4/2/2024 11:25 AM, Alexey Minnekhanov wrote:
>
>
> On 02.04.2024 18:55, Dmitry Baryshkov wrote:
>> I'd say, we should take a step back and actually verify how this was
>> handled in the vendor kernel.
>
>
> AFAIK there is no such thing in vendor kernel driver for this, as
> this startup
On 4/2/2024 8:55 AM, Dmitry Baryshkov wrote:
> I'd say, we should take a step back and actually verify how this was
> handled in the vendor kernel.
(error handling and other non-QMI code removed from the following for
readability)
In ath10k we unconditionally call the following in
On 3/29/2024 10:24 AM, Krzysztof Kozlowski wrote:
> Core in sdio_register_driver() already sets the .owner, so driver does
> not need to.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Jeff Johnson
>
> ---
>
> Depends on the first patch.
> ---
> drivers/net/
this device. Core kernel code
> already gives tools to investigate whether module was loaded or not.
>
> Drop the printing messages which allows to replace open-coded
> module_sdio_driver().
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Jeff Johnson
>
> ---
>
&g
On 3/27/2024 7:45 AM, Jakub Kicinski wrote:
> On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote:
>> -void init_dummy_netdev(struct net_device *dev)
>> +void init_dummy_netdev_core(struct net_device *dev)
>
> Can init_dummy_netdev_core() be a static function (and no export)?
>
On 3/26/2024 10:51 AM, Dmitry Baryshkov wrote:
> On Tue, 26 Mar 2024 at 19:45, Marc Gonzalez wrote:
>>
>> [ It has been pointed out to me that the previous message was unclear. ]
>> [ Below is my 2nd attempt at a clearer message. ]
>>
>> Problem: firmware-5.bin has not been parsed yet when we
On 3/21/2024 7:28 AM, Jakub Kicinski wrote:
> On Wed, 20 Mar 2024 08:12:46 -0700 Jeff Johnson wrote:
>> NAK this based upon the ath11k patch results.
>
> The ath11 patch is much more complex, I'd wager this one is fine.
>
>> As suggested there we should just us
On 3/19/2024 3:47 AM, Breno Leitao wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_device from struct ath10k by converting it
> into a pointer. Then use the
On 3/19/2024 10:15 AM, Breno Leitao wrote:
> On Tue, Mar 19, 2024 at 09:05:24AM -0700, Jeff Johnson wrote:
>> On 3/19/2024 3:47 AM, Breno Leitao wrote:
>>> @@ -3687,6 +3690,8 @@ struct ath10k *ath10k_core_create(size_t priv_size,
>>> struct device *dev,
&
On 3/19/2024 3:47 AM, Breno Leitao wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_device from struct ath10k by converting it
> into a pointer. Then use the
On 3/14/2024 10:52 AM, Marc Gonzalez wrote:
> Is this the line you're after:
> [ 32.367011] ath10k_snoc 1880.wifi: qmi fw_version 0x100204b2
> fw_build_timestamp 2019-09-04 03:01 fw_build_id
> QC_IMAGE_VERSION_STRING=WLAN.HL.1.0-01202-QCAHLSWMTPLZ-1.221523.2
perfect
> Is it legal for my
On 3/7/2024 8:46 AM, Jeff Johnson wrote:
> On 3/7/2024 7:29 AM, Marc Gonzalez wrote:
>> Have you heard back from the dev team?
>>
>> Do they confirm that an issue involving missing MSA_READY notifications
>> was ever noticed?
>>
>> What devices were affe
On 3/9/2024 9:58 AM, Sebastian Gottschall wrote:
>
> Am 07.03.2024 um 17:49 schrieb Kalle Valo:
>> Robert Marko writes:
>>
>>> On Wed, Mar 6, 2024 at 8:23 PM Jeff Johnson
>>> wrote:
>>>
>>>> Historically, prior to being incorporated into
On 3/7/2024 7:29 AM, Marc Gonzalez wrote:
> Have you heard back from the dev team?
>
> Do they confirm that an issue involving missing MSA_READY notifications
> was ever noticed?
>
> What devices were affected? (All msm8998? A subset of msm8998?)
>
> Was the issue eventually fixed?
> (Probably
On 3/6/2024 6:23 AM, Dmitry Baryshkov wrote:
> After some thought, I'd suggest to follow approach taken by the rest
> of qcom firmware:
> put a default (accepted by non-secured hardware) firmware to SoC dir
> and then put a vendor-specific firmware into subdir. If any of such
> vendors appear, we
Historically, prior to being incorporated into the linux-firmware
project, firmware for kernel.org ath1*k drivers has been first published
to Kalle's GitHub:
https://github.com/kvalo/ath10k-firmware
https://github.com/kvalo/ath11k-firmware
(ath12k firmware was pushed to the ath11k-firmware repo on
On 2/29/2024 10:40 AM, Conor Dooley wrote:
> On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote:
>> Marc Gonzalez writes:
>
>>> As mentioned in my other reply, there are several msm8998-based
>>> devices affected by this issue. Is it not appropriate to consider
>>> a kernel-based
On 2/28/2024 10:46 AM, James Prestwood wrote:
> This does appear to have fixed it! For reference this was my test:
>
> for i in $(seq 1 10); do sudo ip link set wlan0 down; sudo ip link
> set wlan0 up; echo $?; done
>
> I never saw the up command fail, and after a while I noticed one of
On 2/28/2024 5:24 AM, Marc Gonzalez wrote:
> The driver waits for this indicator before proceeding,
> yet some WCNSS firmwares apparently do not send it.
> On those devices, it seems safe to ignore the indicator,
> and continue loading the firmware.
Can you list the product/hardware/firmware
6-420e-ac2a-d61ae5e6c...@gmail.com/
> Signed-off-by: Baochen Qiang
Acked-by: Jeff Johnson
On 2/23/2024 9:56 AM, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.9 and submit it then. Hoping
>to keep the conflicts that it will cause to a minimum.
Add Jeff Johnson as a maintainer of the qcom,ath1*k.yaml files.
Signed-off-by: Jeff Johnson
---
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml | 1 +
Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 1 +
Documentation/devicetree/bindings/net/wireless
I now have a @kernel.org e-mail address, so use that for my
maintenance activities.
Signed-off-by: Jeff Johnson
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 92152ac346c8..77289fef78d9 100644
--- a/MAINTAINERS
+++ b
---
Jeff Johnson (2):
MAINTAINERS: update Jeff Johnson e-mail address
MAINTAINERS: Add N: ath1*k entries to match .yaml files
MAINTAINERS | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
---
base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
change-id: 20240217
referenced, so add N: entries to ath10k, ath11k, and
ath12k, and remove the explicit F: entries.
Link:
https://lore.kernel.org/linux-wireless/20240216203215.40870-7-b...@bgdev.pl/ [1]
Suggested-by: Bartosz Golaszewski
Signed-off-by: Jeff Johnson
---
MAINTAINERS | 5 +++--
1 file changed, 3
On 1/30/2024 8:38 AM, Dmitry Baryshkov wrote:
> On WCN3990 platforms actual firmware, wlanmdsp.mbn, is sideloaded to the
> modem DSP via the TQFTPserv. These MBN files are signed by the device
> vendor, can only be used with the particular SoC or device.
>
> Unfortunately different firmware
On 1/29/2024 10:47 PM, Dmitry Baryshkov wrote:
> The ath10k driver fails to properly handle fallback from board-2.bin to
> board.bin for WCN3990 cards. This happens because the
> ath10k_hw_params_list doesn't include .fw.board* parameters for the
> WCN3990 platform.
>
> Add board data
-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi-tlv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
index 83a8f07a687f..8a2f87d0a3a3 100644
--- a/drivers/net/wireless/ath/ath10k/wmi
only.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/coredump.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/coredump.h
b/drivers/net/wireless/ath/ath10k/coredump.h
index e5ef0352e319..8d274e0f374b 100644
--- a/drivers
' not described in enum 'wmi_10_4_feature_mask'
Update the kernel-doc for enum wmi_10_4_feature_mask to add the
missing documentation.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.h | 7 +--
1 file changed, 5 insertions(+), 2
ker "/**", it doesn't actual use kernel-doc syntax for
the documentation. Rather than try to update this legacy driver
documentation to use kernel-doc style, just replace the comment
marker.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson
---
drivers/net/wirele
for these two structs to resolve the warnings.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/htt.h | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath
With this series applied there are no kernel-doc issues in ath10k
(ath11k and ath12k have already been previously fixed).
---
Jeff Johnson (5):
wifi: ath10k: add missing wmi_10_4_feature_mask documentation
wifi: ath10k: correctly document enum wmi_tlv_tx_pause_id
wifi: ath10k
On 1/3/2024 7:15 PM, Karthikeyan Periyasamy wrote:
> ENOTSUPP is not a standard error code, don't use it. Replace with
> EOPNOTSUPP instead.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Karthikeyan Periyasamy
Acked-by: Jeff Johnson
On 1/3/2024 7:15 PM, Karthikeyan Periyasamy wrote:
> ENOTSUPP is not a standard error code, don't use it. Replace with
> EOPNOTSUPP instead.
>
> No functional changes, compile tested only.
>
I would have expected a changelog for v2
But no need to resend as a result of the missing changelog
On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
> ENOTSUPP is not a standard error code, don't use it. Replace with
> EOPNOTSUPP instead.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Karthikeyan Periyasamy
> ---
> diff --git a/drivers/net/wireless/ath/ath10k/htt.c
>
On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
> ENOTSUPP is not a standard error code, don't use it. Replace with
> EOPNOTSUPP instead.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Karthikeyan Periyasamy
Acked-by: Jeff Johnson
On 1/2/2024 8:12 PM, Karthikeyan Periyasamy wrote:
> ENOTSUPP is not a standard error code, don't use it. Replace with
> EOPNOTSUPP instead.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Karthikeyan Periyasamy
Acked-by: Jeff Johnson
On 12/13/2023 11:16 AM, Kees Cook wrote:
> On Wed, Dec 13, 2023 at 09:06:44AM -0800, Jeff Johnson wrote:
>> In [1] it was identified that in ath10k_wmi_10_4_gen_tdls_peer_update()
>> the memset(skb->data, 0, sizeof(*cmd)) is unnecessary since function
>> ath10k_wmi_alloc_
struct wmi_start_scan_tlvs is being used.
No functional changes, compile tested only.
[1]
https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.c | 8
drivers/net/wireless/ath/ath10k
changes, compile tested only.
[1]
https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.h | 24
1 file changed, 24 deletions(-)
diff --git a/drivers/net/wireless/ath
reless/626ae2e7-66f8-423b-b17f-e75c1a6d2...@embeddedor.com/
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
b/drivers/net/wireless/ath/ath10k/wmi.c
index 4d5aadbc7159..0cfd9484c45e
://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
[2] https://lore.kernel.org/linux-wireless/202308301529.AC90A9EF98@keescook/
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net
/626ae2e7-66f8-423b-b17f-e75c1a6d2...@embeddedor.com/
[3] https://lore.kernel.org/linux-wireless/202308301529.AC90A9EF98@keescook/
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless
, compile tested only.
[1]
https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/wmi.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h
b/drivers/net/wireless
Clean up the last remaining zero-length and one-element arrays in
ath10k to comply with:
https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
With these cleanups done the ath10k-check script no longer reports any
issues.
---
Jeff Johnson (6):
wifi: ath10k: use
On 10/25/2023 8:52 AM, Jeff Johnson wrote:
> On 10/24/2023 7:37 PM, Gustavo A. R. Silva wrote:
>>
>>
>> On 10/24/23 14:49, Johannes Berg wrote:
>>> On Tue, 2023-10-24 at 14:41 -0600, Gustavo A. R. Silva wrote:
>>>>
>>>> It seems
> Signed-off-by: Xingyuan Mo
Acked-by: Jeff Johnson
Update the copyright for all ath11k files modified on behalf of
Qualcomm Innovation Center, Inc. in 2021 through 2023.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath11k/ce.c| 2 +-
drivers/net/wireless/ath/ath11k/ce.h| 1 +
drivers/net/wireless/ath
Update the copyright for all ath10k, ath11k, and ath12k files modified
on behalf of Qualcomm Innovation Center, Inc. in 2021 through 2023.
---
Jeff Johnson (3):
wifi: ath12k: Update Qualcomm Innovation Center, Inc. copyrights
wifi: ath11k: Update Qualcomm Innovation Center, Inc
Update the copyright for all ath12k files modified on behalf of
Qualcomm Innovation Center, Inc. in 2023.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath12k/core.c| 2 +-
drivers/net/wireless/ath/ath12k/core.h| 2 +-
drivers/net/wireless/ath/ath12k/dbring.c | 2 +-
drivers
Update the copyright for all ath10k files modified on behalf of
Qualcomm Innovation Center, Inc. in 2021 through 2023.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/bmi.c | 1 +
drivers/net/wireless/ath/ath10k/ce.c | 1 +
drivers/net/wireless/ath/ath10k
On 11/27/2023 8:23 AM, Gustavo A. R. Silva wrote:
>
>
> On 11/27/23 10:14, Jeff Johnson wrote:
>> Transform the zero-length array in ath11k_htc_record into a proper
>> flexible array via the DECLARE_FLEX_ARRAY() macro. This helps with
>> ongoing efforts to glo
The misspelled pauload member of struct ath11k_htc_record is unused,
so remove it.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath11k/htc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/htc.h
b/drivers/net/wireless/ath/ath11k/htc.h
index
Transform the zero-length arrays in ath10k_htc_record into proper
flexible arrays via the DECLARE_FLEX_ARRAY() macro. This helps with
ongoing efforts to globally enable -Warray-bounds.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/htc.h | 6 +++---
1 file changed, 3 insertions
The misspelled pauload member of struct ath10k_htc_record is unused,
so remove it.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/htc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.h
b/drivers/net/wireless/ath/ath10k/htc.h
index
Fix ath10k_htc_record and ath11k_htc_record to remove an unused (and
misspelled) pauload member and to correctly use DECLARE_FLEX_ARRAY()
for the remaining flexible arrays. This helps with ongoing efforts to
globally enable -Warray-bounds.
---
Jeff Johnson (4):
wifi: ath10k: remove
Transform the zero-length array in ath11k_htc_record into a proper
flexible array via the DECLARE_FLEX_ARRAY() macro. This helps with
ongoing efforts to globally enable -Warray-bounds.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath11k/htc.h | 2 +-
1 file changed, 1 insertion
On 11/16/2023 9:32 AM, James Prestwood wrote:
> Broadcast action frames are needed for the Device Provisioning
> Protocol (DPP) for Presence and PKEX Exchange requests. Currently
> just ath9k has this capability so this is being enabled for
> ath10k (for at least one hardware variant).
>
> Add a
On 11/14/2023 11:31 AM, James Prestwood wrote:
> I hate to keep bringing this up, and if its a "won't fix" type of issue
> you don't have to tell me twice and I can deal with it out of tree. Any
> answer would be greatly appreciated so I know how to proceed, and if its
> something I can wait
On 11/14/2023 9:32 AM, Jeff Johnson wrote:
> On 11/12/2023 4:13 AM, Paul Menzel wrote:
>> Dear Linux folks,
>>
>>
>> Onn the Dell XPS 13 9360 with Debian sid/unstable, Linux 6.5.10 logs the
>> error below:
>>
>> $ sudo dmesg | g
On 11/12/2023 4:13 AM, Paul Menzel wrote:
> Dear Linux folks,
>
>
> Onn the Dell XPS 13 9360 with Debian sid/unstable, Linux 6.5.10 logs the
> error below:
>
> $ sudo dmesg | grep -e "DMI:" -e "Linux version" -e microcode
> [0.00] microcode: updated early: 0xf0 -> 0xf4, date
struct ath10k_htc_frame is unused, and since it illogically contains
two consecutive flexible arrays, it could never be used, so remove it.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/htc.h | 13 -
1 file changed, 13
On 11/2/2023 4:54 AM, Dmitry Antipov wrote:
Since 'ieee80211_txq_get_depth()' allows NULL for 2nd and
3rd arguments, simplify '__ath10k_htt_tx_txq_recalc()' by
dropping unused 'frame_cnt'. Compile tested only.
Signed-off-by: Dmitry Antipov
Acked-by: Jeff Johnson
On 10/24/2023 7:37 PM, Gustavo A. R. Silva wrote:
On 10/24/23 14:49, Johannes Berg wrote:
On Tue, 2023-10-24 at 14:41 -0600, Gustavo A. R. Silva wrote:
It seems we run into the same issue in the function below, even in the
case this `memset()` is unnecessary (which it seems it's not):
On 10/24/2023 2:43 PM, Kees Cook wrote:
On Tue, Oct 24, 2023 at 07:11:51AM -0700, Jeff Johnson wrote:
On 10/24/2023 6:03 AM, Kalle Valo wrote:
What about using just memcpy() to make it clear it's not really a proper
string:
arvif->u.ap.ssid_len = 4;
memcpy(arvif->u.ap.ssid, "m
On 10/24/2023 2:34 PM, Kees Cook wrote:
On Tue, Oct 24, 2023 at 05:42:16PM +, Justin Stitt wrote:
strncpy() is deprecated [1] and we should prefer less ambiguous
interfaces.
In this case, arvif->u.ap.ssid has its length maintained by
arvif->u.ap.ssid_len which indicates it may not need to
terminated-strings
[1]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-harden...@vger.kernel.org
Signed-off-by: Justin Stitt
Acked-by: Jeff Johnson
On 10/24/2023 6:03 AM, Kalle Valo wrote:
What about using just memcpy() to make it clear it's not really a proper
string:
arvif->u.ap.ssid_len = 4;
memcpy(arvif->u.ap.ssid, "mesh", arvif->u.ap.ssid_len);
In the "changed & BSS_CHANGED_SSID" case that comes soon after this we
just set the
On 10/18/2023 4:35 PM, Kees Cook wrote:
On Fri, Oct 13, 2023 at 05:58:03PM -0700, Jeff Johnson wrote:
Let's also mark ath10k_vif.u.ap.ssid as __nonstring.
what criteria is used to determine whether or not to use __nonstring?
doesn't the use of u8 vs char already communicate that distinction
On 10/17/2023 9:53 AM, James Prestwood wrote:
Advertise support for multicast frame registration and update the RX
filter with FIF_MCAST_ACTION to allow broadcast action frames to be
received. Broadcast action frames are needed for the Device
Provisioning Protocol (DPP) for Presence and PKEX
On 10/13/2023 10:20 PM, Kalle Valo wrote:
Kalle Valo writes:
Abhishek Kumar wrote:
Enabling this flag, ensures that reg_call_notifier is called
on beacon hints from handle_reg_beacon in cfg80211. This call
propagates the channel property changes to ath10k driver, thus
changing the channel
Stitt
Either with or without the __nonstring...
Acked-by: Jeff Johnson
he purpose is actually deprecated in favour of
different logic.
Convert every user of napi_reschedule to napi_schedule.
Signed-off-by: Christian Marangi
---
For
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
Acked-by: Jeff Johnson
On 10/2/2023 8:10 AM, Christian Marangi wrote:
Change napi_schedule to return a bool on NAPI successful schedule. This
might be useful for some driver to do additional step after a NAPI ahs
nit:s/ahs/has/
been scheduled.
Signed-off-by: Christian Marangi
---
include/linux/netdevice.h | 11
(just a resend with Wen's current e-mail address, no further comments)
On 9/20/2023 11:27 AM, James Prestwood wrote:
On 2/26/21 10:01 AM, Shuah Khan wrote:
On 2/11/21 4:24 AM, Kalle Valo wrote:
Shuah Khan writes:
On 2/10/21 1:28 AM, Kalle Valo wrote:
Wen Gong writes:
On 2021-02-10
that you were bitten by
the format change required. I would have left this as int and just let
it promote to size_t or ssize_t as needed.
That said:
Acked-by: Jeff Johnson
P.S.:
> Hopefully this doesn't violate "if it isn't broke, don't fix
> it" rule (the same thing was recently ac
On 9/18/2023 9:50 PM, Wu Yunchuan wrote:
No need cast (void*) to (struct htt_rx_ring_setup_ring32 *),
(struct htt_rx_ring_setup_ring64 *). Change the prototype to
remove the local variable.
Signed-off-by: Wu Yunchuan
Suggested-by: Jeff Johnson
Ideally your Signed-off-by: should be the last
On 9/18/2023 7:37 AM, Dmitry Antipov wrote:
This is an initial attempt to fix TODO found in SDIO bus support
code. As original comment says, an idea is to store SDIO-specific
'struct ath10k_sdio_bus_request' data within skb control buffer
instead of managing (a relatively large, 1024-items for
) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct ath10k_ce_ring.
[1]
https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Kalle Valo
Cc: Jeff Johnson
Cc: ath10k@lists.infradead.org
Cc: linux-wirel
On 9/14/2023 9:07 AM, Dmitry Antipov wrote:
According to Jeff, 'HTT_DATA_TX_STATUS_DOWNLOAD_FAIL' from
'enum htt_data_tx_status' is never actually used by the
firmware code and so may be dropped, with the related
adjustment to 'ath10k_htt_rx_tx_compl_ind()'.
Suggested-by: Jeff Johnson
Signed
On 9/13/2023 10:15 PM, Dmitry Antipov wrote:
In 'ath10k_htt_rx_tx_compl_ind()',
int status = MS(resp->data_tx_completion.flags, HTT_DATA_TX_STATUS);
actually is
int status = (((resp->data_tx_completion.flags) & 0x07) >> 0);
which can't be equal to HTT_DATA_TX_STATUS_DOWNLOAD_FAIL (128)
On 9/13/2023 9:05 PM, Wu Yunchuan wrote:
No need cast (void*) to (struct htt_rx_ring_setup_ring32 *),
(struct htt_rx_ring_setup_ring64 *), (struct ath_softc *)
or (struct ath_hw *).
Signed-off-by: Wu Yunchuan
---
drivers/net/wireless/ath/ath10k/htt_tx.c | 6 ++
of the whole array and not the first member to 'memcpy()'.
Signed-off-by: Dmitry Antipov
Acked-by: Jeff Johnson
---
drivers/net/wireless/ath/ath10k/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/debug.c
b/drivers/net/wireless/ath/ath10k
On 8/23/2023 10:51 PM, Dmitry Antipov wrote:
Change 'ath10k_ce_alloc_rri()' to return -ENOMEM in case
of 'dma_alloc_coherent()' failure and fix error handling in
'ath10k_snoc_hif_power_up()'.
Signed-off-by: Dmitry Antipov
Acked-by: Jeff Johnson
---
v3: split from the larger v2 patch
1 - 100 of 131 matches
Mail list logo
