Re: [PATCH v2 1/2] ath10k: add ppdu stats support for QCA6174/QCA9377

2020-04-06 Thread Kalle Valo
re WLAN.RM.4.4.1.c3-00031. > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. > > Signed-off-by: Yu Wang > Signed-off-by: Kalle Valo This has new warnings: drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_process_ppdu_stats': drivers/net/wireless/a

Re: [PATCH] ath10k: fix kernel null pointer dereference

2020-04-06 Thread Kalle Valo
from [] (kthread+0xd8/0xec) > > Tested HW: QCA9888 > Tested FW: 10.4-3.10-00047 > > Signed-off-by: Venkateswara Naralasetty > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. acb31476adc9 ath10k: fix kernel null pointer dereferen

Re: [PATCH v2 1/2] ath10k: enable VHT160 and VHT80+80 modes

2020-04-06 Thread Kalle Valo
> Signed-off-by: Rick Wu > Signed-off-by: Lei Wang > Signed-off-by: Sowmiya Sree Elavalagan > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 3db24065c2c8 ath10k: enable VHT160 and VHT80+80 modes 795def8b14ff ath10k: enable radar detec

Re: [PATCH] ath10k: Fix the race condition in firmware dump work queue

2020-04-06 Thread Kalle Valo
led gracefully, while the target is in the > 'hw-restart'. > > Tested HW: QCA9984 > Tested FW: 10.4-3.9.0.2-00044 > > Co-developed-by: Govindaraj Saminathan > Signed-off-by: Govindaraj Saminathan > Signed-off-by: Maharaja Kennadyrajan > Signed-off-by: Kalle V

Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes

2020-03-27 Thread Kalle Valo
ssree...@codeaurora.org writes: > On 2020-03-26 15:29, Kalle Valo wrote: >> Sowmiya Sree Elavalagan wrote: >> >>> From: Lei Wang >>> >>> Set right channel frequencies in VHT160 mode according to the VHT160 >>> interoperability workaround add

Re: [PATCH] ath10k: enable radar detection in secondary segment

2020-03-26 Thread Kalle Valo
Kalle Valo writes: > Sowmiya Sree Elavalagan wrote: > >> From: Lei Wang >> >> Enable radar detection in secondary segment for VHT160 and VHT80+80 mode >> on DFS channels. Otherwise, when injecting radar pulse in the secondary >> segment, the DUT can

Re: [PATCH] ath10k: enable radar detection in secondary segment

2020-03-26 Thread Kalle Valo
Sowmiya Sree Elavalagan wrote: > From: Lei Wang > > Enable radar detection in secondary segment for VHT160 and VHT80+80 mode > on DFS channels. Otherwise, when injecting radar pulse in the secondary > segment, the DUT can't detect radar pulse. > > Tested: qca9984 with firmware ver 10.4-3.10-00

Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes

2020-03-26 Thread Kalle Valo
Sowmiya Sree Elavalagan wrote: > From: Lei Wang > > Set right channel frequencies in VHT160 mode according to the VHT160 > interoperability workaround added as part of IEEE Std 802.11™-2016 in > "Table 9-252—VHT Operation Information subfields", band_center_freq2 > corresponds to CCFS1 in Table

Re: [PATCH v2 2/2] ath10k: correct legacy rate in tx stats

2020-03-24 Thread Kalle Valo
Yu Wang writes: > When working in station mode, after connected to a legacy > AP, 11g only, for example, the tx bitrate is incorrect in > output of command 'iw wlan0 link'. > > That's because the legacy tx bitrate value reported by > firmware is not well handled: > For QCA6174, the value represen

Re: [PATCH v2 2/2] ath10k: correct legacy rate in tx stats

2020-03-24 Thread Kalle Valo
Yu Wang writes: > When working in station mode, after connected to a legacy > AP, 11g only, for example, the tx bitrate is incorrect in > output of command 'iw wlan0 link'. > > That's because the legacy tx bitrate value reported by > firmware is not well handled: > For QCA6174, the value represen

Re: [PATCH 1/3] dt-bindings: ath10k: Add wifi-firmware subnode for wifi node

2020-03-24 Thread Kalle Valo
Rakesh Pillai wrote: > Add a wifi-firmware subnode for the wifi node. > This wifi-firmware subnode is needed for the > targets which do not support TrustZone. > > Signed-off-by: Rakesh Pillai Fails to build and has warnings. How did you test this? drivers/net/wireless/ath/ath10k/qmi.c: In fun

Re: [PATCH v2] ath10k: add retry mechanism for ath10k_start

2020-03-24 Thread Kalle Valo
Wen Gong writes: > On 2020-02-13 19:35, Kalle Valo wrote: >> >> I'm not convinved about this. ath10k assumes that SDIO bus works >> reliably and there's no data loss. In my opinion if the SDIO is not >> working reliably we should fail immediately with

Re: QCA6174 - failed to fetch board data

2020-03-24 Thread Kalle Valo
Tim Klicks writes: > I am running Fedora 31 on my Redmibook 14 and I am facing a problem > regarding the wifi. > The wifi is not working when using any linux-firmware package provided. > Neither the one coming via the official update channel nor cloning the > git repo and using the master branch

Re: ath10k_pci rawmode = 1 requires support from firmware

2020-03-24 Thread Kalle Valo
Cale Collins writes: > When attempting to bring up my mesh0 interface, I recieve an error and > in "dmesg": > > [ 901.62] ath10k_pci 0001:90:00.0: must load driver with > rawmode=1 to add mesh interfaces > > I enable this mode by changing my bootargs, appending "ath10k_core.rawmode=1". > > O

Re: [PATCH][next] ath: Replace zero-length array with flexible-array member

2020-03-23 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { > int

Re: [PATCH v2] ath10k: Fill GCMP MIC length for PMF

2020-03-22 Thread Kalle Valo
: QCA9984, QCA9888 > Tested FW: 10.4-3.6-00104 > > Signed-off-by: Yingying Tang > Co-developed-by: Sowmiya Sree Elavalagan > Signed-off-by: Sowmiya Sree Elavalagan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 95a568c4a461 ath10k: Fil

Re: [PATCH 1/2] nl80211: vendor-cmd: qca: add dynamic SAR power limits

2020-03-17 Thread Kalle Valo
Brian Norris writes: >> > > This was discussed during the 2019 wireless workshop. The conclusion >> > > from that discussion was that while there is clear need for SAR power >> > > limits for various devices and multiple vendors/drivers, it did not look >> > > clear that a single common interface

Re: ath10k: Fill GCMP MIC length for PMF

2020-03-17 Thread Kalle Valo
Sowmiya Sree Elavalagan wrote: > From: Yingying Tang > > GCMP MIC length is not filled for GCMP/GCMP-256 cipher suites in > PMF enabled case. Due to mismatch in MIC length, deauth/disassoc frames > are unencrypted. > This patch fills proper MIC length for GCMP/GCMP-256 cipher suites. > > Teste

Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.

2020-03-12 Thread Kalle Valo
Yibo Zhao wrote: > Hardwares tested : QCA9887 > Firmwares tested : 10.4-3.9.0.1-00036 > > Signed-off-by: Yibo Zhao > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 5637c4ca961b ath10k: allow qca988x family to support ack rssi of tx data pack

Re: [PATCH RFT] ath10k: add QCA9377 sdio hw_param item

2020-03-11 Thread Kalle Valo
Erik Stromdahl writes: > On 3/2/20 12:45 PM, Christian Hewitt wrote: >> >>> On 26 Sep 2019, at 6:24 pm, Kalle Valo wrote: >>> >>> From: Erik Stromdahl >>> >>> Add hardware parameters for QCA9377 sdio devices, it's now properly >&

Re: [PATCH] ath10k: fix not registering airtime of 11a station with WMM disable

2020-03-11 Thread Kalle Valo
airtime of > 11a station keeps unchanged in debugfs system. > > Mask the tid along with IEEE80211_QOS_CTL_TID_MASK to make it in > the valid range. > > Hardwares tested : QCA9984 > Firmwares tested : 10.4-3.10-00047 > > Signed-off-by: Yibo Zhao > Signed-off-by: K

Re: [PATCH v2] ath10k: fix unsupported chip reset debugs file write

2020-03-11 Thread Kalle Valo
> QCA9984 FW version: WLAN.BL.3.9.0.2-00042-S-1 > > Signed-off-by: Yingying Tang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. bbdc8c5abbd4 ath10k: fix unsupported chip reset debugs file write -- https://patchwork.kernel.org/patch/11381921/

Re: [PATCH] ath10k: use kzalloc to read for ath10k_sdio_hif_diag_read

2020-03-11 Thread Kalle Valo
mory which is kmalloc, if it is > vmalloc from ath10k_mem_value_read, then it have a memory error. > kzalloc of ath10k_sdio_hif_diag_read32 is the correct type, so > add kzalloc in ath10k_sdio_hif_diag_read to replace the buffer > which is vmalloc from ath10k_mem_value_read. > > Thi

Re: [PATCH] ath10k: start recovery process when read int status fail for sdio

2020-03-11 Thread Kalle Valo
rupts: -110 > > It has sdio errors since it can not read MBOX_HOST_INT_STATUS_ADDRESS, > then it has to do recovery process to recovery ath10k. > > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patc

Re: [PATCH RFT] ath10k: add QCA9377 sdio hw_param item

2020-03-11 Thread Kalle Valo
Kalle Valo wrote: > Add hardware parameters for QCA9377 sdio devices, it's now properly supported. > > Signed-off-by: Erik Stromdahl > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6e51b0e4913c ath10k: add QCA9377 sdio hw_para

Re: [PATCH] ath10k: avoid consecutive OTP download to reduce boot time

2020-03-11 Thread Kalle Valo
o marks board > id invalid in "ath10k_core_stop", which will force the OTP > download in ath10k_core_start and fetches valid board id. > > Tested HW: QCA9984 > Tested FW: 10.4-3.6-00104 > > Signed-off-by: Vikas Patel > Signed-off-by: Maharaja Kennadyrajan >

Re: [RESEND] ath10k: add tx hw 802.11 encapusaltion offloading support

2020-02-13 Thread Kalle Valo
Tom Psyborg writes: > On 17/12/2019, Kalle Valo wrote: >> John Crispin wrote: >> >>> This patch adds support for ethernet rxtx mode to the driver. The feature >>> is enabled via a new module parameter. If enabled to driver will enable >>> t

Re: [PATCH] ath10k: fix unsupported chip reset debugs file write

2020-02-13 Thread Kalle Valo
Yingying Tang wrote: > Before this change, after writing "warm_hw_reset" debugfs file, host > will send chip reset command to FW even though FW do not support this > service getting a warning print. > > Though there is no FW impact before this change, this patch restricts > chip reset command se

Re: [PATCH] ath10k: avoid consecutive OTP download to reduce boot time

2020-02-13 Thread Kalle Valo
Maharaja Kennadyrajan writes: > On 2020-01-07 11:53, Maharaja Kennadyrajan wrote: > > [Maha]: Please ignore/drop this duplicate patch as I sent it already. > Regret for inconvenience caused. Are you sure I should drop this? In the first patch I think you forgot to CC linux-wireless and that's wh

Re: [PATCH v2] ath10k: add retry mechanism for ath10k_start

2020-02-13 Thread Kalle Valo
Wen Gong writes: > When simulate random transfer fail for sdio write and read, it happened > "Could not init core: -110" and then wlan up fail. > > Test steps: > 1. Add config and update kernel: > CONFIG_FAIL_MMC_REQUEST=y > CONFIG_FAULT_INJECTION=y > CONFIG_FAULT_INJECTION_DEBUG_FS=y > > 2. Run

Re: [PATCH] ath10k: support PCIe enter L1 state

2020-02-13 Thread Kalle Valo
Brian Norris writes: > On Fri, Mar 8, 2019 at 1:42 AM Kalle Valo wrote: >> Brian Norris writes: >> > On Fri, Feb 8, 2019 at 5:42 AM Kalle Valo wrote: >> >> No replies from anyone (including Wen) for 3 months about testing this >> >> patch on anythin

Re: [PATCHv2 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support

2020-02-11 Thread Kalle Valo
ware QCA4019. > > Signed-off-by: Tamizh Chelvam > Reviewed-by: Rob Herring > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 7354de9c6e2c dt-bindings: ath10k: Add new dt entries to identify coex support 9f83993e1a92 ath10k: Add support to read btcoex related

Re: [PATCH] ath10k: fix few checkpatch warnings

2020-02-11 Thread Kalle Valo
Kalle Valo wrote: > Fix warnings which were recently introduced: > > drivers/net/wireless/ath/ath10k/ahb.c:462: Alignment should match open > parenthesis > drivers/net/wireless/ath/ath10k/ahb.c:470: Alignment should match open > parenthesis > drivers/net/wireless/ath/ath

[PATCH] ath10k: fix few checkpatch warnings

2020-02-11 Thread Kalle Valo
parenthesis ')' Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/ahb.c | 4 ++-- drivers/net/wireless/ath/ath10k/sdio.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/a

Re: [PATCH] ath10k: Use device_get_match_data() to simplify code

2020-01-26 Thread Kalle Valo
Stephen Boyd wrote: > Use device_get_match_data() here to simplify the code a bit. > > Signed-off-by: Stephen Boyd > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. fa43e99dd4b7 ath10k: Use device_get_match_data() to simplify cod

Re: [PATCH] ath10k: Add newlines to printk messages

2020-01-26 Thread Kalle Valo
Stephen Boyd wrote: > Some printks in here don't have newlines at the end, meaning the log > will be sort of hard to read. Add newlines. > > Signed-off-by: Stephen Boyd > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 79a4b788451d ath

Re: [PATCH] ath10k: Correct the DMA direction for management tx buffers

2020-01-26 Thread Kalle Valo
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 > > Fixes: dc405152bb6 ("ath10k: handle mgmt tx completion event") > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6ba8b3b6bd77 ath10k: Correct the DM

Re: [PATCH] ath10k: Use device_get_match_data() to simplify code

2020-01-26 Thread Kalle Valo
Justin Capella writes: > Maybe use dev here as well? > >> dev_err(&pdev->dev, "failed to find matching device tree >> id\n"); I changed that. And also fixed a checkpatch warning: drivers/net/wireless/ath/ath10k/snoc.c:1483: Please don't use multiple blank lines -- https://wi

Re: [PATCH v3 1/2] dt: bindings: add dt entry flag to skip SCM call for msa region

2020-01-26 Thread Kalle Valo
Govind Singh wrote: > Add boolean context flag to disable SCM call for statically > mapped msa region. > > Signed-off-by: Govind Singh > Acked-by: Rob Herring > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 6ca71a10aee8 dt: bindings:

Re: [PATCH, v4] Revert "ath10k: fix DMA related firmware crashes on multiple devices"

2020-01-26 Thread Kalle Valo
mware 10.4-3.9.0.2--00040 > > Signed-off-by: Zhi Chen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a1769bb68a85 Revert "ath10k: fix DMA related firmware crashes on multiple devices" -- https://patchwork.kernel.org/patch/11331293/ https

Re: [PATCH v2] ath10k: drop RX skb with invalid length for sdio

2020-01-26 Thread Kalle Valo
nsidered as ath10k_htc_hdr, > but actually the 8 bytes is not the ath10k_htc_hdr, so the act_len > from this ath10k_htc_hdr is not correct, if it is a big value, such > as 57013, it will trigger skb_panic. > > Drop the skb with invalid length will be reasonable. > > This patch o

Re: [PATCH 1/2] ath10k: Add optional qdss clk

2020-01-26 Thread Kalle Valo
gned-off-by: Bjorn Andersson > Acked-by: Rob Herring > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 57a3b60ddbfa ath10k: Add optional qdss clk -- https://patchwork.kernel.org/patch/11307779/ https://wireless.wiki.kernel.org/en/developers/documen

Re: [PATCH 1/2] ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe

2020-01-26 Thread Kalle Valo
memory dump support QCA9984") > Signed-off-by: Bryan O'Donoghue > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. d239380196c4 ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe 63ec5cbc31f7 ath10k: pci: Fix comment on ath10k_pci_dump_

Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150

2020-01-15 Thread Kalle Valo
Kalle Valo writes: > Bjorn Andersson writes: > >> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system >> will reset due to an NoC error. So this adds an optional clock to the ath10k >> binding and makes sure it's enabled while the WiFi f

Re: [PATCH 0/2] ath10k: Enable QDSS clock on sm8150

2020-01-09 Thread Kalle Valo
Bjorn Andersson writes: > On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system > will reset due to an NoC error. So this adds an optional clock to the ath10k > binding and makes sure it's enabled while the WiFi firmware needs it. > > Bjorn Andersson (2): > ath10k: Add op

[PULL] ath10k firmware 20191220

2019-12-20 Thread Kalle Valo
) Kalle Valo (6): ath10k: QCA6174 hw3.0: update board-2.bin ath10k: QCA9887 hw1.0: update firmware-5.bin to 10.2.4-1.0-00047 ath10k: QCA9888 hw2.0: update firmware-5.bin to 10.4-3.9.0.2-00070 ath10k: QCA988X hw2.0: update firmware-5.bin to

Re: [PATCH 1/2] ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe

2019-12-19 Thread Kalle Valo
Bryan O'Donoghue writes: > On 19/12/2019 13:53, Kalle Valo wrote: >> Bryan O'Donoghue writes: >> >>> ath10k_pci_dump_memory_reg() will try to access memory of type >>> ATH10K_MEM_REGION_TYPE_IOREG however, if a hardware restart is in progress >

Re: [PATCH 1/2] ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe

2019-12-19 Thread Kalle Valo
Bryan O'Donoghue writes: > ath10k_pci_dump_memory_reg() will try to access memory of type > ATH10K_MEM_REGION_TYPE_IOREG however, if a hardware restart is in progress > this can crash a system. > > Individual ioread32() time has been observed to jump from 15-20 ticks to > > 80k ticks followed by

Re: [PATCH, v3] Revert "ath10k: fix DMA related firmware crashes on multiple devices"

2019-12-19 Thread Kalle Valo
Zhi Chen wrote: > This reverts commit 76d164f582150fd0259ec0fcbc485470bcd8033e. > PCIe hung issue was observed on multiple platforms. The issue was > reproduced > when DUT was configured as AP and associated with 50+ STAs. > > For QCA9984/QCA9888, the DMA_BURST_SIZE register controls the AXI bu

[PATCH 1/2] nl80211: vendor-cmd: qca: add dynamic SAR power limits

2019-12-18 Thread Kalle Valo
: 2.4G power limit 0x11: 5G power limit Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo --- include/uapi/nl80211-vnd-qca.h | 68 ++ 1 file changed, 68 insertions(+) create mode 100644 include

[PATCH 2/2] ath10k: allow dynamic SAR power limits to be configured

2019-12-18 Thread Kalle Valo
the 2.4G and 5G WMI command will be set to firmware, otherwise it will not set to firmware at this moment. When STATION connect next time, it will set to firmware. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo --- drivers/net

[PATCH 0/2] ath10k: SAR power limit vendor command

2019-12-18 Thread Kalle Valo
Hi, here's a patchset adding dynamic SAR power limit vendor command to ath10k. This follows the new process documented in the wiki: https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api Please review. Kalle Wen Gong (2): nl80211: vendor-cmd: qca: add dynami

Re: [RESEND] ath10k: add tx hw 802.11 encapusaltion offloading support

2019-12-17 Thread Kalle Valo
John Crispin wrote: > This patch adds support for ethernet rxtx mode to the driver. The feature > is enabled via a new module parameter. If enabled to driver will enable > the feature on a per vif basis if all other requirements were met. > > Testing on a IPQ4019 based hardware shows a increase

Re: [PATCH] ath10k: Fix some typo in some warning messages

2019-12-17 Thread Kalle Valo
Christophe JAILLET wrote: > Fix some typo: > s/to to/to/ > s/even/event/ > > Signed-off-by: Christophe JAILLET > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a67bcec3569f ath10k: Fix some typo in some warning messages -- https://pa

Re: [PATCH v2 1/2] dt: bindings: add dt entry flag to skip SCM call for msa region

2019-12-17 Thread Kalle Valo
govi...@codeaurora.org writes: > On 2019-11-15 00:46, Rob Herring wrote: >> On Mon, Nov 11, 2019 at 09:55:07AM +0530, Govind Singh wrote: >>> Add boolean context flag to disable SCM call for statically >>> mapped msa region. >> >> Can't this be implied by the compatible string? >> > > same soc com

Re: [PATCH] ath: add support for special 0x0 regulatory domain

2019-12-02 Thread Kalle Valo
wg...@codeaurora.org writes: > On 2019-12-02 18:08, Kalle Valo wrote: >> Wen Gong wrote: >> >>> Some sdio chips of rome QCA6174's regulatory domain code of EEPROM is >>> empty, then ath_is_world_regd will return false for this case, and >>> it wi

Re: [PATCH] ath: add support for special 0x0 regulatory domain

2019-12-02 Thread Kalle Valo
s chip, it does not have the issue. > > For empty reulatory domain code chip, set it to world regulatory domain > in functio ath_regd_sanitize, then it will fix the issue. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-00029. > > Signed-off-by: Wen Gong > Si

Re: [PATCH] ath10k: change bundle count for max rx bundle for sdio

2019-12-02 Thread Kalle Valo
DLE, so the > final max rx bundle count will be set to 32 in firmware. > > This patch only effect sdio chips. > > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. > > Signed-off-by: Wen Gong > Fixes: 224776520ead69e ("ath10k: change max RX bundle size

Re: [PATCH v6] ath10k: enable napi on RX path for sdio

2019-12-02 Thread Kalle Valo
ive_skb_internal ([kernel.kallsyms]) > napi_gro_complete ([kernel.kallsyms]) > napi_gro_flush ([kernel.kallsyms]) > napi_complete_done ([kernel.kallsyms]) > ath10k_sdio_napi_poll ([ath10k_sdio]) > net_rx_action ([kernel.kallsyms]) > __softirqentry_text_start ([kernel.kallsyms]) >

Re: [PATCH] ath10k: enable wow feature for sdio chip

2019-11-28 Thread Kalle Valo
SDIO with firmware > WLAN.RMH.4.4.1-00029. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7321095ca39c ath10k: enable wow feature for sdio chip -- https://patchwork.kernel.org/patch/11263485/ https://wireless

Re: [PATCH] ath10k: change log level for mpdu status of sdio chip

2019-11-28 Thread Kalle Valo
Wen Gong wrote: > Change log level from warn to dbg level of mpdu status > of sdio chip. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-7-QCARMSWP-1. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.gi

Re: [PATCH] ath10k: set WMI_PEER_AUTHORIZE after a firmware crash

2019-11-28 Thread Kalle Valo
t; the issue. > > This was noticed by testing firmware crashing using simulate_fw_crash > debugfs file. > > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-7-QCARMSWP-1. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next b

Re: [PATCH] ath10k: set max mtu to 1500 for sdio chip

2019-11-28 Thread Kalle Valo
SDIO with firmware > WLAN.RMH.4.4.1-00017-QCARMSWP-1. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 376a30c7c9a0 ath10k: set max mtu to 1500 for sdio chip -- https://patchwork.kernel.org/patch/11263345/ https://wireless

Re: [PATCH] ath10k: enable firmware log by default for sdio

2019-11-28 Thread Kalle Valo
Wen Gong wrote: > On SDIO chips the firmware log does not impact performance. To make it > easier to debug firmware problems keep it enabled on the firmware. > > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. > > Signed-off-by: Wen Gong > Signed-off-b

Re: [PATCH] ath10k: move non-fatal warn logs to dbg level

2019-11-27 Thread Kalle Valo
gt; Move this log to debug level to remove un-necessary warn message > on console. > > htc.c:803: ath10k_warn(ar, "unsupported HTC service id: %d\n", > htc.c:881: ath10k_warn(ar, "unsupported HTC service id: %d\n", > > Signed-off-by: Govind Singh > Si

Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-25 Thread Kalle Valo
csfail" flag of a monitor mode interface > unset, frames with FCS errors should be dropped. With this patch, the > fcsfail flag is taken into account correctly. > > Tested-on: QCA4019 firmware-5-ct-full-community-12.bin-lede.011 > > Cc: Simon Wunderlich > Signed-of

Re: [PATCH] ath10k: report rssi of each chain to mac80211 for sdio

2019-11-25 Thread Kalle Valo
3 (on wlan-5000mhz) > signal: -43 [-46, -45, -79, -84] dBm > signal avg: -43 [-46, -46, -82, -83] dBm > > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00017-QCARMSWP-1. > Tested with QCA6174 PCIe with firmware WLAN.RM.4.4.1-00110-QCARMSWP-1

Re: [PATCH v2] ath10k: Handle "invalid" BDFs for msm8998 devices

2019-11-25 Thread Kalle Valo
; > Signed-off-by: Jeffrey Hugo > Reviewed-by: Bjorn Andersson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 319c2b71041f ath10k: Handle "invalid" BDFs for msm8998 devices -- https://patchwork.kernel.org/patch/11242143/ https://wirele

Re: [PATCH v2] ath10k: Fix qmi init error handling

2019-11-25 Thread Kalle Valo
on the hardware, and > freeing the irqs as error handling. > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > Signed-off-by: Jeffrey Hugo > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. f8a595a87e93 a

Re: [PATCH v2] ath10k: add NL80211_FEATURE_ND_RANDOM_MAC_ADDR for NLO

2019-11-25 Thread Kalle Valo
ssid foo. > After suspend, DUT will send probe request with mac AA:7B:A1:AC:B2:41. > > WCN3990, QCA9377, QCA6174 PCI also support this feature. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-00029. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo

Re: [PATCH] ath10k: Handle when FW doesn't support QMI_WLFW_HOST_CAP_REQ_V01

2019-11-25 Thread Kalle Valo
ware nor the ath10k driver, lets catch > this particular scenario and ignore it so that we can still bring up > wifi services successfully. > > Signed-off-by: Jeffrey Hugo > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 501d4152b018 ath10k: Han

Re: [PATCH] ath10k: add large size for BMI download data for SDIO

2019-11-25 Thread Kalle Valo
h firmware > WLAN.RMH.4.4.1-00017-QCARMSWP-1. > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. d58f466a5dee ath10k: add large size for BMI download data for SDIO -- https://patchwork.kernel.org/patch/11232449/ ht

Re: [PATCH] ath10k: correct the tlv len of ath10k_wmi_tlv_op_gen_config_pno_start

2019-11-25 Thread Kalle Valo
; Fixes: ce834e280f2f875 ("ath10k: support NET_DETECT WoWLAN feature") > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e01cc82c4d1e ath10k: correct the tlv len of ath10k_wmi_tlv_op_gen_config_pno_start -- https://pat

Re: [PATCH 1/2] ath10k: cosmetic cleanup to sdio files

2019-11-25 Thread Kalle Valo
Kalle Valo wrote: > Do some cosmetic cleanup while reviewing the files. No functional changes. > > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. efd2f4c5016b ath10k: sdio: cosmetic cleanup 2246c2156590 ath10k: sdio: remove struct ath10k_sdi

Re: [PATCH v6 1/3] ath10k: enable RX bundle receive for sdio

2019-11-25 Thread Kalle Valo
333 688 > 57344 660 695 > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-00017-QCARMSWPZ-1 > > Signed-off-by: Alagu Sankar > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo 3 patches applied to ath-next branch

Re: [PATCH v6 3/3] ath10k: add workqueue for RX path of sdio

2019-11-22 Thread Kalle Valo
Wen Gong writes: > On 2019-11-11 20:23, Kalle Valo wrote: >> Wen Gong writes: >> >>> On 2019-11-01 15:42, Wen Gong wrote: >>>> On 2019-10-31 17:08, Kalle Valo wrote: >>>> 、> I just realised that this is RX path so we should use >>>&

Re: [PATCH RFC, v2] Revert "ath10k: fix DMA related firmware crashes on multiple devices"

2019-11-22 Thread Kalle Valo
Zhi Chen writes: > This reverts commit 76d164f582150fd0259ec0fcbc485470bcd8033e. > PCIe hung issue was observed on multiple platforms. The issue was reproduced > when DUT was configured as AP and associated with 50+ STAs. > > With PCIe protocol analyzer, we can see DMA Read crossing 4KB boundary

Re: [PATCH v2 3/3] mmc: core: Re-work HW reset for SDIO cards

2019-11-20 Thread Kalle Valo
Ulf Hansson writes: > On Wed, 20 Nov 2019 at 08:20, Kalle Valo wrote: >> >> wg...@codeaurora.org writes: >> >> > On 2019-11-20 14:28, Kalle Valo wrote: >> >> + wen, ath10k >> >> >> >> Ulf Hansson writes: >> >> >&g

Re: [PATCH v2 3/3] mmc: core: Re-work HW reset for SDIO cards

2019-11-19 Thread Kalle Valo
wg...@codeaurora.org writes: > On 2019-11-20 14:28, Kalle Valo wrote: >> + wen, ath10k >> >> Ulf Hansson writes: >> >>> On Tue, 12 Nov 2019 at 01:33, Doug Anderson >>> wrote: >>>> >>>> Hi, >>>> >>>> O

Re: [PATCH v2 3/3] mmc: core: Re-work HW reset for SDIO cards

2019-11-19 Thread Kalle Valo
> >> What about: >> >> drivers/net/wireless/ath/ath10k/sdio.c >> >> ...I guess I don't know if there is more than one function probed >> there. Maybe there's not and thus we're fine here too? > > Well, honestly I don't know.

Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode

2019-11-15 Thread Kalle Valo
ct-full-community-12.bin-lede.011 I'll add this testing information to the commit log. (No need to resend just because of commit log changes) > But from looking at the code it seems that the vanilla ath10k has the > same issue, therefore su

Re: [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory

2019-11-14 Thread Kalle Valo
tem freezing. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b70b3a36ec33 ath10k: qmi: Sleep for a while before assigning MSA memory -- https://patchwork.kernel.org/patch/11242883/ https://wireless.wiki.kernel.org/en/dev

Re: [PATCH] ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()"

2019-11-14 Thread Kalle Valo
in > wlan_vdev.c:_wlan_vdev_up:3219 > > Revert the offending commit for now. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. f4fe2e53349f ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()" -

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-11-13 Thread Kalle Valo
124.402535] qcom-q6v5-mss 408.remoteproc: fatal error received: > err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3900:Asserted in > wlan_vdev.c:_wlan_vdev_up:3219 > > Can we please revert it for v5.5? Yes, let's revert it. And thanks for sending the patch to do that: https://pa

Re: [PATCH] ath10k: Handle "invalid" BDFs for msm8998 devices

2019-11-12 Thread Kalle Valo
Jeffrey Hugo writes: > On Tue, Nov 12, 2019 at 2:04 AM Simon Horman > wrote: >> >> On Wed, Nov 06, 2019 at 03:47:12PM -0800, Jeffrey Hugo wrote: >> > When the BDF download QMI message has the end field set to 1, it signals >> > the end of the transfer, and triggers the firmware to do a CRC chec

Re: [PATCH] ath10k: Fix qmi init error handling

2019-11-12 Thread Kalle Valo
Jeffrey Hugo writes: > On Tue, Nov 12, 2019 at 1:42 AM Simon Horman > wrote: >> >> On Wed, Nov 06, 2019 at 03:16:50PM -0800, Jeffrey Hugo wrote: >> > When ath10k_qmi_init() fails, the error handling does not free the irq >> > resources, which causes an issue if we EPROBE_DEFER as we'll attempt

Re: [PATCH v6 3/3] ath10k: add workqueue for RX path of sdio

2019-11-11 Thread Kalle Valo
Wen Gong writes: > On 2019-11-01 15:42, Wen Gong wrote: >> On 2019-10-31 17:08, Kalle Valo wrote: >> 、> I just realised that this is RX path so we should use >> ATH10K_SKB_RXCB() >>> instead. I made the change below to this commit in pending branch: >>>

Re: [PATCH] ath10k:mac: disassoc dbg msg after return check

2019-11-11 Thread Kalle Valo
Eduardo Abinader writes: > On Mon, 11 Nov 2019 at 09:50, Kalle Valo wrote: > >> Eduardo Abinader writes: >> >> > Signed-off-by: Eduardo Abinader >> >> No empty commit logs, please. >> >> > --- a/drivers/net/wireless/ath/ath10k/

Re: [PATCH] ath10k:mac: disassoc dbg msg after return check

2019-11-11 Thread Kalle Valo
Eduardo Abinader writes: > Signed-off-by: Eduardo Abinader No empty commit logs, please. > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -6786,13 +6786,13 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, > /* >

Re: [PATCH] ath10k: add large size for BMI download data for SDIO

2019-11-08 Thread Kalle Valo
Wen Gong writes: > Download firmware time cost of SDIO is too long, it is about 480ms, > add large size 2048 bytes for BMI download for SDIO chip, its time > cost will reduced to 240ms. > > This will optimize the download firmware time cost. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4

Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

2019-11-08 Thread Kalle Valo
oading by > applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw(). > > Tested-on: QCA9880 > Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00029 > > Signed-off-by: Ikjoon Jang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 3b58d6a599ba ath10k: di

Re: [PATCH] ath10k: fix potential issue of peer stats allocation

2019-11-08 Thread Kalle Valo
Zhi Chen wrote: > STA number was not restored if OOM happened. > > Tested: QCA9984 with firmware ver 10.4-3.9.0.1-00018 > Signed-off-by: Zhi Chen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 402838a05def ath10k: fix potential issu

Re: [PATCH] ath10k: fix get invalid tx rate for Mesh metric

2019-11-08 Thread Kalle Valo
0.2-00035 > > Signed-off-by: Hou Bao Hou > Signed-off-by: Anilkumar Kolli > Signed-off-by: Miaoqing Pan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 05a11003a565 ath10k: fix get invalid tx rate for Mesh metric -- https://patchwo

Re: [PATCH 1/2] dt: bindings: add dt entry flag to skip SCM call for msa region

2019-11-08 Thread Kalle Valo
Govind Singh wrote: > Add boolean context flag to disable SCM call for statically > mapped msa region. > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo I was wondering why there are no review comments from DT folks and then noticed that you didn't CC the dev

Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

2019-11-08 Thread Kalle Valo
Ikjoon Jang writes: > On Thu, Nov 7, 2019 at 2:23 AM Kalle Valo wrote: >> >> Ikjoon Jang writes: >> >> > Downloading ath10k firmware needs a large number of IOs and >> > cpuidle's miss predictions make it worse. In the worst case, >> > resu

Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

2019-11-08 Thread Kalle Valo
Tom Psyborg writes: > On 06/11/2019, Kalle Valo wrote: >> Ikjoon Jang writes: >> >>> Downloading ath10k firmware needs a large number of IOs and >>> cpuidle's miss predictions make it worse. In the worst case, >>> resume time can be three time

Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

2019-11-06 Thread Kalle Valo
Ikjoon Jang writes: > Downloading ath10k firmware needs a large number of IOs and > cpuidle's miss predictions make it worse. In the worst case, > resume time can be three times longer than the average on sdio. > > This patch disables cpuidle during firmware downloading by > applying PM_QOS_CPU_D

Re: [PATCH v6] ath10k: enable napi on RX path for sdio

2019-10-31 Thread Kalle Valo
Wen Gong writes: > For tcp RX, the quantity of tcp acks to remote is 1/2 of the quantity > of tcp data from remote, then it will have many small length packets > on TX path of sdio bus, then it reduce the RX packets's bandwidth of > tcp. > > This patch enable napi on RX path, then the RX packet o

Re: [PATCH v6 2/3] ath10k: change max RX bundle size from 8 to 32 for sdio

2019-10-31 Thread Kalle Valo
Wen Gong writes: > On 2019-10-24 18:05, Kalle Valo wrote: >> Wen Gong writes: > >> As you can see I also changed the macro to a function, as I prefer C >> over CPP :) And changed ATH10K_HTC_FLAG_BUNDLE_MASK to use GENMASK(). >> > yes. >> But this only c

Re: [PATCH v6 3/3] ath10k: add workqueue for RX path of sdio

2019-10-31 Thread Kalle Valo
Wen Gong writes: > For RX, it has two parts, one is to read data from sdio, another > is to indicate the packets to upper stack. Recently it has only > one thread to do all RX things, it results that it is sequential > for RX and low throughout, change RX to parallel for the two parts > will incr

<    3   4   5   6   7   8   9   10   11   12   >