On May 12, 2014, at 1:00 PM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
src/share/classes/sun/misc/UUDecoder.java
126 StringBuilder x = new StringBuilder();
Is only filled, but doesn't seem to be used anyhow.
Maybe just delete it?
Thanks, i will take a look at this and your
On May 12, 2014, at 4:07 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
Hi Paul,
I looked at -management and the changes there look good.
There is just some two spaces vs four space formatting in
On 12/05/2014 11:55, Paul Sandoz wrote:
On May 12, 2014, at 12:42 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 12/05/2014 11:03, Paul Sandoz wrote:
It covers many areas and i have grouped the patches into such areas to aid
reviewing. When commenting please including core-libs.
The
Hi AWT team.
Please review the backport from 9 to 8u:
https://bugs.openjdk.java.net/browse/JDK-7175457
The fix is available at:
http://cr.openjdk.java.net/~yan/7175457.8u/webrev.diff.00/
Test moved to open:
http://cr.openjdk.java.net/~yan/7175457.8u/webrev.00/
Thanks,
Andrei
HI, Andrei.
The fix looks good.
On 5/13/14 1:13 PM, andrei.eremeev wrote:
Hi AWT team.
Please review the backport from 9 to 8u:
https://bugs.openjdk.java.net/browse/JDK-7175457
The fix is available at:
http://cr.openjdk.java.net/~yan/7175457.8u/webrev.diff.00/
Test moved to open:
Hi. Oleg.
A few notes.
- Some tests contains empty/non-rethrow catch blocks. I guess we
should rethrow an exception and the test should fail in this case.
- Some tests use System.exit() which should be replaced by the exception.
On 5/9/14 7:32 PM, Oleg Pekhovskiy wrote:
Hi all,
please
Hi, Paul.
adding 2d-dev@
media: sound/awt/swing part looks fine.
Note that this part of the fix should be pushed to client forest.
On 5/12/14 2:03 PM, Paul Sandoz wrote:
Hi,
This is a request for review of Otavio's patch replacing StringBuffer
with StringBuilder within OpenJDK. (I also need
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
On 12 мая 2014 г., at 19:44, Alexander Zvegintsev
alexander.zvegint...@oracle.com wrote:
Hello AWT team,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8041896/00/
for the issue
Hello, Andrei.
Looks like the backport is the same as the 9 fix, isn't it? If not, what's the
difference?
FYI, you do not need to run an additional technical review for the backport if
it's
more or less the same. You just request approval on jdk8u-dev alias.
With best regards. Petr.
On 13
Hi, Alexander.
The fix looks good to me as well.
On 5/13/14 3:20 PM, Petr Pchelko wrote:
Hello, Alexander.
The fix looks good to me.
With best regards. Petr.
On 12 мая 2014 г., at 19:44, Alexander Zvegintsev
alexander.zvegint...@oracle.com
mailto:alexander.zvegint...@oracle.com wrote:
On 5/12/2014 3:53 PM, Anthony Petrov wrote:
Hi David,
The fix looks good to me. To answer your questions:
1. Using the XAWT macro is correct. It is only defined if we're building
the XToolkit, which we don't on the Mac. However, everywhere else we
actually check
XAWT is a legacy macro,
On May 13, 2014, at 1:10 PM, Sergey Bylokhov sergey.bylok...@oracle.com wrote:
Hi, Paul.
adding 2d-dev@
media: sound/awt/swing part looks fine.
Thanks.
Note that this part of the fix should be pushed to client forest.
Which classes exactly from here:
Hi David,
The fix looks good to me. To answer your questions:
1. Using the XAWT macro is correct. It is only defined if we're building
the XToolkit, which we don't on the Mac. However, everywhere else we
actually check
XAWT is a legacy macro, which was introduced to share code between
New version of the patch uploaded:
http://cr.openjdk.java.net/~ddehaven/8003900/jdk.1/
I just changed XAWT to !MACOSX
Would one of you mind pushing this for me once accepted?
-DrD-
Hi David,
src/solaris/native/sun/awt/awt.h
113 #if !defined(HEADLESS) defined(XAWT)
114 extern Display *awt_display; /* awt_GraphicsEnv.c */
You forgot to update this XAWT usage. Otherwise the fix looks fine.
--
best regards,
Anthony
On 5/13/2014 8:30 PM, David DeHaven wrote:
Hi Jim, Sergey, and Anton,
I'd like to revive this old thread and finally push this fix, which has
been reviewed and approved on this mailing list back in February. The
only additional change that I want to introduce, is the addition of
default implementations for the
src/solaris/native/sun/awt/awt.h
113 #if !defined(HEADLESS) defined(XAWT)
114 extern Display *awt_display; /* awt_GraphicsEnv.c */
You forgot to update this XAWT usage. Otherwise the fix looks fine.
Whoops! Updated in-place.
-DrD-
On 5/13/14 9:29 PM, Anthony Petrov wrote:
Hi Jim, Sergey, and Anton,
I'd like to revive this old thread and finally push this fix, which
has been reviewed and approved on this mailing list back in February.
The only additional change that I want to introduce, is the addition
of default
JBS Issue:
https://bugs.openjdk.java.net/browse/JDK-8026385
Webrev:
http://cr.openjdk.java.net/~ddehaven/8026385/jdk.0/
Basically extends the work Staffan performed for
https://bugs.openjdk.java.net/browse/JDK-8023786
Verified by running:
find
The JPEG code is 2d not awt ..
I was curious about that.
Apparently the root of this problem is
- longjmp will restore the signal mask using sigprocmask() which sets the
signal mask for the _process_.
Hmm .. so anyone using a JNI lib that uses setjmp/longjmp would have the same
On 5/13/2014 1:13 PM, David DeHaven wrote:
I tried not modifying libpng but still ended up with lingering references to
longjmp in pngread.o, despite libpng having png_ptr-longjmp_fn (bug in
libpng?). pngread.c calls setjmp to set a default location to jump to in case the
caller doesn't call
Paul,
I don't see why you changed the variable names in some cases.
See here where one change is only one line since you left it alone and
the other is 6 lines since you changed it
I tried not modifying libpng but still ended up with lingering references to
longjmp in pngread.o, despite libpng having png_ptr-longjmp_fn (bug in
libpng?). pngread.c calls setjmp to set a default location to jump to in
case the caller doesn't call setjmp, so if we continue down this path
23 matches
Mail list logo
