Re: [9] Review Request: 8177841 Some java/awt/Robot tests can be improved

On 3/30/2017 10:27 PM, Sergey Bylokhov wrote: sun.java2d.win.uiScaleX/Y is only applicable to windows which is likely why the test had @requires (os.family == "windows") even if it was not the right name. Now you are running unconditionally with those properties on all platforms which seems to

Re: 8177137: 8175293 breaks Windows build on Vs2010

The fix looks good to me. Thanks, Alexandr. On 3/20/2017 6:36 PM, Thomas Stüfe wrote: Hi all, please review this tiny fix: https://bugs.openjdk.java.net/browse/JDK-8177137 http://cr.openjdk.java.net/~stuefe/webrevs/8177137-8175293-breaks-windows-build-on-vs2010/webrev.00/webrev/

Re: [9] Review Request: 8160270 dual-screen issue with java.awt.Choice

It all looks plausible .. so +1 assuming no problems with the tests. -phil. On 03/16/2017 12:20 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 3/16/2017 7:44 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. This bug was caused by the change in JDK81

Re: [9] Review Request: 8160270 dual-screen issue with java.awt.Choice

The fix looks good to me. Thanks, Alexandr. On 3/16/2017 7:44 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. This bug was caused by the change in JDK8137571 where we started to use graphic configuration for each component to calculate the preferred size on the screen. The

Re: Java_Swings/AWT Native Interface give error in 32-bit window OS

Forwarded to the awt-dev alias. Thanks, Alexandr. On 3/7/2017 8:50 AM, mahendrag gajera wrote: Hello All, I follow step as mention in below link and create .dll and java application. https://en.wikibooks.org/wiki/Java_Swings/AWT. Every things work fine in window 7/8 64-bit OS. In window

[9] Review request for 8175301 Java GUI hangs on Windows when Display set to 125%

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8175301 webrev: http://cr.openjdk.java.net/~alexsch/8175301/webrev.00 D3DSurfaceData.swapBuffers() is updated to scale passed bounds on HiDPI display. Thanks, Alexandr.

Re: [9] Review request for 8176097 Window set location to a display with different DPI does not properly work

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8176097/webrev.02 - sysX and sysY values are kept the the same as the passed x and y values. Thanks, Alexandr. On 3/3/2017 8:19 PM, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http

Re: [9] Review request for 8176097 Window set location to a display with different DPI does not properly work

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8176097/webrev.01 - sysX and sysY values are updated in the same way as x and y in the WWindowPeer.setBounds(...) method. Thanks, Alexandr. On 3/2/2017 10:13 PM, Sergey Bylokhov wrote: Hi, Alex. Looks like aft

[9] Review request for 8176097 Window set location to a display with different DPI does not properly work

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8176097 webrev: http://cr.openjdk.java.net/~alexsch/8176097/webrev.00 Suppose the system has two displays with different DPI. A user can create a window on the first screen and set the windows bounds from t

Re: [9] Review Request: 8176009 The awt robot use incorrect location in a multi-screen environment

The fix looks good to me. Thanks, Alexandr. On 3/1/2017 4:51 PM, Alexander Zvegintsev wrote: +1 -- Thanks, Alexander. On 01.03.2017 12:55, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. The fix reverts the changes which were introduced in JDK-8145784(the test SpuriousMouseEv

Re: [9] Review Request: 8168307 Toolkit.getScreenSize() returns incorrect size on unix in multiscreen systems

The fix looks good to me. Thanks, Alexandr. On 2/28/2017 8:21 PM, Sergey Bylokhov wrote: Hi, Alexander. The XToolkit.getDefaultScreenWidth()/getDefaultScreenHeight() methods are supposed to return the width/height in the user space. Could you rename them and the screenWidth/screenHeight vari

Re: [9] Review Request: 8168307 Toolkit.getScreenSize() returns incorrect size on unix in multiscreen systems

The XToolkit.getDefaultScreenWidth()/getDefaultScreenHeight() methods are supposed to return the width/height in the user space. Could you rename them and the screenWidth/screenHeight variables to emphasize the fact that now they work with values in the device space? Thanks, Alexandr. On 2/1

[9] Review request for 8175293 Window size is not updated after setting location to display with different DPI

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8175293 webrev: http://cr.openjdk.java.net/~alexsch/8175293/webrev.00 The fix for the JDK-8147440 shifts a window position while it is dragging from one display to another. This causes that sometimes there i

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

ew. Updated patch: http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.09/ <http://cr.openjdk.java.net/%7Epkbalakr/8162959/webrev.09/> Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Tuesday, February 07, 2017 10:54 PM *To:* Prem

Re: [9] Review request for JDK-8173876 Fast precise scrolling and DeltaAccumulator fix for macOS Sierra 10.12.2

The fix looks good to me. Thanks, Alexandr. On 2/7/2017 8:17 PM, Sergey Malenkov wrote: Hello, Could you please review the following fix: bug: http://bugs.openjdk.java.net/browse/JDK-8173876 webrev: http://cr.openjdk.java.net/~alexsch/sergey.malenkov/8173876/webrev-all.00 It improves

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

finalize the signature and behavior, I shall update the patch and send it for review. Regards, Prem *From:*Philip Race *Sent:* Wednesday, January 25, 2017 11:44 PM *To:* Alexandr Scherbatiy *Cc:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net <m

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

- changing window size according to DPI when a window is moved from one display to another is added - window size updating is moved to the native side Thanks, Alexandr. On 10/25/2016 5:32 PM, Sergey Bylokhov wrote: On 25.10.16 14:11, Alexandr Scherbatiy wrote: Could you review the

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

:32 PM, Sergey Bylokhov wrote: On 25.10.16 14:11, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8147440/webrev.01/ - an undecorated frame does not set WWindowPeer.sysX/Y/W,H values so the fix is updated to retrieve a window bounds form the

Re: RFR: 8173409: make setMixingCutoutShape public and remove jdk.desktop

The fix looks good to me. Thanks, Alexandr. On 1/31/2017 11:28 AM, Sergey Bylokhov wrote: Looks fine. Bug: https://bugs.openjdk.java.net/browse/JDK-8173409 Webrev: http://cr.openjdk.java.net/~prr/8173409/ In OpenJDK the jdk.desktop module (not java.desktop) has only one method. It is the v

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

Prem *From:*Alexandr Scherbatiy *Sent:* Friday, January 20, 2017 4:50 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot On 1/19/2017 3:57 PM, Prem Balakrishnan wrote: H

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

splay There should be mention that this argument value is ignored when a screenshot is taken on non-HiDPI display Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Thursday, January 12, 2017 2:39 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

The fix looks good to me. Thanks, Alexandr. On 12/19/2016 10:29 PM, Sergey Bylokhov wrote: 19 дек. 2016 г., в 22:28, Sergey Bylokhov > написал(а): Hello. Please review an updated version of the fix. - The comments are updated. Two additional public api ar

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

esolution which returns Best Resolution Image while capturing screen using CGWindowListCreateImage() method. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Tuesday, January 10, 2017 1:08 AM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net; Philip Race *Subject:* Re: Review Re

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

59/screenshot/screenshot.png <http://cr.openjdk.java.net/%7Ealexsch/8162959/screenshot/screenshot.png> Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Monday, November 21, 2016 8:10 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net <mailto

Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data flavor

tly on Windows and Mac. Regards, Ajit *From:*Alexandr Scherbatiy *Sent:* Wednesday, September 14, 2016 8:33 PM *To:* Ajit Ghaisas; Yuri Nesterenko; awt-dev@openjdk.java.net *Subject:* Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data

Re: [9] Review Request: 4419271 Provide support for scrolling-mechanisms of non-mouse input-devices

The fix looks good to me. Thanks, Alexandr. On 11/23/2016 5:20 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Support of WM_MOUSEHWHEEL for Swing was added (AWT components were not touched), which mostly the code symmetric to the WM_MOUSEWHEEL, except that I changed the

Re: [9] Review Request: 8165769 Hang in the help menu item

The fix looks good to me. Thanks, Alexandr. On 11/16/2016 4:05 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. There are a few issues which can cause a hang in some of our menu stress tests: - Lack in synchronization in the Menu, we tried to synchronized the write of fie

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

ded an explanation what is the content of the first and the second resolution variant. Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Thursday, November 03, 2016 4:05 PM *To:* Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: Review Request JDK:-8162959

Re: RFR: 8155874: Fix java.desktop deprecation warnings about Class.newInstance

The fix looks good to me. Thanks, Alexandr. On 11/7/2016 10:12 PM, Sergey Bylokhov wrote: Looks fine. On 07.11.16 21:49, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8155874 Webrev: http://cr.openjdk.java.net/~prr/8155874/ This hits all across the desktop module, hence the

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

The fix looks good to me. Thanks, Alexandr. On 10/31/2016 9:31 PM, Jim Graham wrote: Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *cr.openjdk.java.net/~aniyogi/813877

Re: Review Request JDK:-8162959 [HiDPI] screenshot artifacts using AWT Robot

On 11/2/2016 1:57 PM, Prem Balakrishnan wrote: Hi Alexander, Please review updated patch. http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.01/ Added a new public API “*Image createHiDPIScreenCapture(Rectangle screenRect)”.* *

Re: Review Request: 8159132 : [PIT][TEST_BUG] java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java fails

The fix looks good to me. Thanks, Alexandr. On 10/27/2016 2:46 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-8159132 Webrev: http://cr.openjdk.java.net/~pkbalakr/8159132/webrev.00/

Re: [9] Review request for 8147440 HiDPI (Windows): Swing components have incorrect sizes after changing display resolution

. On 3/21/2016 11:33 PM, Alexandr Scherbatiy wrote: On 2/10/2016 5:32 AM, Sergey Bylokhov wrote: On 05.02.16 10:52, Alexandr Scherbatiy wrote: The first approach is to rescale only frame size on native level so newNativeWindow.size = newScale * javaWindow.size What location will be in

Re: Review Request for 8167288: [TEST_BUG] Consistent failure on Unity of WarningWindowDisposeTest.java

The fix looks good to me. Thanks, Alexandr. On 10/17/2016 9:46 AM, Semyon Sadetsky wrote: Looks good. --Semyon On 10/17/2016 5:54 AM, Ambarish Rapte wrote: Hi, Please review this test bug fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8167288

Re: [9] Review request: 8167159 [PIT][TEST_BUG] java/awt/image/multiresolution/MultiResolutionIcon/MultiResIconTest.java

The Windows OS is not listed in the test @requires tag but the test should work on Windows as well. Thanks, Alexandr. On 10/14/2016 7:02 PM, Andrey Rusakov wrote: Hello, please review the fix http://cr.openjdk.java.net/~arusakov/8167159/webrev.00 for the issue https://bugs.openjdk.java.n

[8u-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

Just corrected the subject to 8u-dev. Thanks, Alexandr. 05.10.2016 22:46, Alexandr Scherbatiy пишет: Hello, Could you review the backport of the fix to the JDK8u-dev: http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 This is just the same fix as for the JDK 9 (see [1

[8-dev] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

Hello, Could you review the backport of the fix to the JDK8u-dev: http://cr.openjdk.java.net/~alexsch/8166591/webrev-jdk8.00 This is just the same fix as for the JDK 9 (see [1]). There are some style differences between JDK 8u-dev and JDK 9 which I needed to merge manually. All logic i

Re: [9] Review request for 8166591 [macos 10.12] Trackpad scrolling of text on OS X 10.12 Sierra is very fast (Trackpad, Retina only)

On 9/30/2016 1:31 PM, Sergey Malenkov wrote: # C [AppKit+0x3a528e] -[NSApplication _crashOnException:]+0x6d The app is crashed as soon as I start scrolling. Investigating... May be it is my fault during backporting. Sorry, it was my fault. Now it works. Consider how it works for one short

Re: [9] fix for JDK-8134612 :clipboard.getData(dataFlavor) can throw UnsupportedFlavorException for registered data flavor

On 9/14/2016 1:14 PM, Ajit Ghaisas wrote: Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8134612 Issue : In this test, exportToClipboard() does not export anything to the clipboard due to incorrect text passed to TransferHandler. Obviously, when we do clipboard.getData() - it throws

Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambiguity for Window.setIconImages

.01/> Regards, Rajeev Chamyal *From:*Alexandr Scherbatiy *Sent:* 05 September 2016 16:04 *To:* Rajeev Chamyal; Sergey Bylokhov; awt-dev@openjdk.java.net *Subject:* Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambigui

Re: [9] Review Request JDK-8149371 multi-res. image: -Dsun.java2d.uiScale does not work for Window icons (some ambiguity for Window.setIconImages

On 9/2/2016 2:37 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8149371 Webrev: http://cr.openjdk.java.net/~rchamyal/8149371/webrev.00/ Issue: Multiresolution

Re: RFR (XXS) 8165269: (doc) Toolkit.isDynamicLayoutActive(): orphan '0' in first sentence

The fix looks good to me. Thanks, Alexandr. On 9/1/2016 11:46 PM, Iris Clark wrote: Hi. Let's try this again. Please review the following one character change to remove an unnecessary ')' in the first sentence of Toolkit.isDynamicLayoutActive(). The matching '(' was removed during res

Re: [9] Review request for 8163100: [hidpi] Linux: display-wise scaling factor issues

The fix looks good to me. Thanks, Alexandr. On 8/31/2016 2:07 PM, Sergey Bylokhov wrote: Looks fine. On 31.08.16 11:11, Semyon Sadetsky wrote: On 8/30/2016 11:57 PM, Sergey Bylokhov wrote: Why in X11GraphicsDevice.java we cannot call initScaleFactor() directly without isUIScaleEnabled() che

Re: [9] Review request for 8050478: [macosx] Cursor not updating correctly after closing a modal dialog

The fix looks good to me. Thanks, Alexandr. On 8/30/2016 11:20 AM, Dmitry Markov wrote: Thank you very much, Sergey! Looking for a second +1 from someone else. Thanks, Dmitry On 29 Aug 2016, at 18:53, Sergey Bylokhov wrote: Looks fine. On 25.08.16 13:53, Dmitry Markov wrote: Hi Sergey,

Re: [9] Review request for 8159432: [hidpi] Linux: display-wise scaling factor issues

The fix looks good to me. The bug id in the email subject should be updated to 8163100. Thanks, Alexandr. On 8/30/2016 4:26 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8163100 webrev: http://cr.openjdk.java.net/~ssadetsky/8163

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

should have a simple description in other case the compilation fails because of enabled javadoc warning errors. Thanks, Alexandr. Thank you in advance. With Regards, Avik Niyogi On 29-Aug-2016, at 5:55 pm, Alexandr Scherbatiy <mailto:alexandr.scherba...@oracle.com>> wrote: On

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

On 8/29/2016 9:52 AM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.01/ * There is the {@inheritDoc} which a

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

-Original Message- From: Alexandr Scherbatiy Sent: 25 August 2016 22:07 To: Rajeev Chamyal; Philip Race Cc: awt-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention On 8/22/2016 2:13 PM, Rajeev Chamyal wrote: Hello

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

. Regards, Rajeev Chamyal -Original Message- From: Alexandr Scherbatiy Sent: 25 August 2016 22:14 To: Rajeev Chamyal Cc: Phil Race; awt-dev@openjdk.java.net; Sergey Bylokhov; Victor Dyakov Subject: Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention Hi

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Hi Rajeev, You need to follow the following procedure for issues which require CCC request: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-June/004443.html - add jdk9-fc-request label to the JBS issue - update the JBS issue to add a comment whose first line is "FC Extension Request" -

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

Regards, Rajeev Chamyal *From:*Phil Race *Sent:* 16 August 2016 22:28 *To:* Alexandr Scherbatiy *Cc:* Rajeev Chamyal; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>; Sergey Bylokhov *Subject:* Re: [9] Review Request JDK-8151787 Unif

Re: Review Request for 8160056: TextField.setText breaks the contract of EOL

The fix looks good to me. Thanks, Alexandr. On 8/16/2016 1:16 PM, Ambarish Rapte wrote: Hi, Please review the change for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8160056 Webrev: http://cr.openjdk.java.net/~arapte/8160056/webrev.00/

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

27;as' variable which is of type AccelSurface object to SurfaceData is always VALID. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Wednesday, August 17, 2016 4:42 PM *To:* Prem Balakrishnan; Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey Bylokhov *Subject:* Re: Review Request: JDK-8144

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

/~pkbalakr/8144735/webrev.02/ <http://cr.openjdk.java.net/%7Epkbalakr/8144735/webrev.02/> Is it always true that the 'as' variable which has type AccelSurface in the fix is always instance of SurfaceData? Thanks, Alexandr. Regards, Prem *From:*Alexandr Scherbatiy *Sent:* Tu

Re: Swing Dev>[9] Review Request JDK-8161913 [PIT] java/awt/Window/8159168/SetShapeTest.java mostly fails

Changed the alias to the awt-dev. The fix looks good to me. Thanks, Alexandr. On 8/16/2016 10:23 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8161913 Webrev : http://cr.openjdk.java.net/~rchamyal/8161913/webrev.00/

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

fter setting the scaled image sizes in the fix? - Region.clipScale() which is used in many places rounds values. The usual rule is to use Math.floor() for image coordinates rounding and Math.ceil() for sizes. Should the same rule be applicable here? Thanks, Alexandr. Regards, Prem *Fr

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

ace; Sergey Bylokhov *Subject:* Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention On 10/08/16 19:24, Alexandr Scherbatiy wrote: On 8/9/2016 11:18 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev

Re: [9] Review Request JDK-8151787 Unify the HiDPI splash screen image naming convention

On 8/9/2016 11:18 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8151787 Webrev: http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/ Issue: Currently diff

Re: RFR(XXS): 8163408: Fix wrong prototype of getNativeScaleFactor() in systemScale.h

Calling getNativeScaleFactor(NULL) leads that "com.ubuntu.user-interface" "scale-factor" and "com.canonical.Unity.Interface" "text-scale-factor" properties are just skipped in getDesktopScale(char *output_name) method from systemScale.c file. Should there be provided some default output scree

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

On 8/3/2016 10:04 AM, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-8144735 *Webrev:*http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.00/ *Issue:* javax/swing/JWindow/S

Re: Review Request: JDK-8144709 [hidpi] [TestBug] java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java, java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java are failing

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 12:03 PM, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, *Bug:* https://bugs.openjdk.java.net/browse/JDK-8144709 *Webrev:* http://cr.openjdk.java.net/~pkbalakr/8144709/webrev.00/

Re: [9] Review Request JDK-8144594 HiDPI: awt.Choice looks improperly (Win 8)

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 11:21 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8144594 Webrev : http://cr.openjdk.java.net/~rchamyal/8144594/webrev.00

Re: [9] Review request for 8161273: [hidpi] The frame insets size is wrong on Linux HiDPI because it is not scaled.

The fix looks good to me. Thanks, Alexandr. On 7/20/2016 9:34 AM, Semyon Sadetsky wrote: On 7/19/2016 2:36 PM, Alexandr Scherbatiy wrote: On 7/15/2016 10:24 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8036915 webrev: http

Re: [9] Review request for 8161195: Regression: closed/javax/swing/text/FlowView/LayoutTest.java

The fix looks good to me. Thanks, Alexandr. On 7/14/2016 1:05 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161195 webrev: http://cr.openjdk.java.net/~ssadetsky/8161195/webrev.00/ The IMN_SETCOMPOSITIONWINDOW message is generate

Re: [9] Review request for 8161273: [hidpi] The frame insets size is wrong on Linux HiDPI because it is not scaled.

On 7/15/2016 10:24 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8036915 webrev: http://cr.openjdk.java.net/~ssadetsky/8161273/webrev.00/ Frame insets sizes are scaled according to the hidpi scale. Is it possible to use scaleDow

Re: [9] Review request for 8161007: GPL header missing comma in year - not swapped in licensee bundles

The fix looks good to me. Thanks, Alexandr. On 7/15/2016 2:46 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161007 webrev: http://cr.openjdk.java.net/~ssadetsky/8161007/webrev.00/ --Semyon

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

The fix looks good to me. Thanks, Alexandr. On 7/16/2016 2:55 AM, David Holmes wrote: Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we add

Re: RFR: 8161531: Provide a javadoc descriptions for java.datatransfer module

The fix looks good to me. Thanks, Alexandr. On 7/18/2016 9:43 PM, Semyon Sadetsky wrote: +1 --Semyon On 7/18/2016 8:50 PM, Phil Race wrote: The top-level "api/index.html" provides for including a summary description of a module taken from text in module-info.java eg java.base has /** * j

Re: [9] Review Request for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

The fix looks good to me. Thanks, Alexandr. On 7/14/2016 2:47 PM, Alexander Zvegintsev wrote: Hi Semyon, The fix looks good to me. Thanks, Alexander. On 07/13/2016 01:28 PM, Semyon Sadetsky wrote: Please review an updated version of the fix: http://cr.openjdk.java.net/~ssadetsky/8036915/we

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

used in some places. Please review the modified code. http://cr.openjdk.java.net/~mhalder/8160266/webrev.01/ <http://cr.openjdk.java.net/%7Emhalder/8160266/webrev.01/> Thanks, Manajit On 08-Jul-2016, at 3:57 pm, Alexandr Scherbatiy <mailto:alexandr.scherba...@oracle.com>>

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

The fix looks good to me. Thanks, Alexandr. On 7/12/2016 6:04 PM, Semyon Sadetsky wrote: Looks good to me. --Semyon On 12.07.2016 17:42, Alexander Zvegintsev wrote: Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/

Re: [8] Review request JDK-8160941: [macosx]"text/uri-list" dataflavor concats the first two strings

The fix looks good to me. Thanks, Alexandr. On 7/12/2016 3:12 PM, Robin Stevens wrote: Hello Mikhail, thanks for the review. Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ? I have no commit rights, so I cannot do it myself. T

Re: Review request for 4908075: Press shift and another key using robot does not trigger events properly

The fix looks good to me. Thanks, Alexandr. On 7/8/2016 3:09 PM, Oliver Bendig wrote: Ping It would be very nice if somebody could have a look at this webrev. Thanks and kind regards, Oliver Oliver Bendig hat am 29. Juni 2016 um 15:54 geschrieben: Hi, here is a test for this. I

Re: Taking screenshots on x11 composite desktop produce wrong result

The fix looks good to me. Thanks, Alexandr. On 7/11/2016 6:02 PM, Mario Torre wrote: On Fri, Jul 8, 2016 at 10:05 AM, Alexandr Scherbatiy wrote: On 7/4/2016 3:14 PM, Mario Torre wrote: On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote: Ping? Ping Ping? Just a question. The

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

43064/screenshots/checkbox-compare-00.png [2] http://cr.openjdk.java.net/~alexsch/8143064/screenshots/combobox-compare-00.png Thanks, Alexandr. --Semyon On 05.07.2016 16:53, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143064/webr

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

Is it possible to get rid of the RobotUtilities class? Methods like RobotUtilities.pressKey(int num)/releaseKey(int num) are just direct calls to the corresponding methods in Robot. Other necessary methods can be added to test/java/awt/regtesthelpers/Util.java Thanks, Alexandr. On 7/7/2016

Re: Taking screenshots on x11 composite desktop produce wrong result

On 7/4/2016 3:14 PM, Mario Torre wrote: On Wed, Jun 29, 2016 at 12:40 PM, Mario Torre wrote: Ping? Ping Ping? Just a question. The isGtkSupported is moved to be a local variable. It seems its value can't be changed in the 'if' condition on the line 60. Thanks, Alexandr. Cheers,

Re: [8] Review request JI-9041413: [macosx]"text/uri-list" dataflavor concats the first two strings

on this email, correct the bug id and provide the webrev link. Thanks, Alexandr. Robin On Thu, Jul 7, 2016 at 9:36 AM, Alexandr Scherbatiy <mailto:alexandr.scherba...@oracle.com>> wrote: The issue is recorded under id JDK-8160941 "text/uri-list" dataflavo

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 11:46 PM, Alexander Zvegintsev wrote: Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115

Re: [8] Review request JI-9041413: [macosx]"text/uri-list" dataflavor concats the first two strings

The issue is recorded under id JDK-8160941 "text/uri-list" dataflavor concats the first two strings https://bugs.openjdk.java.net/browse/JDK-8160941 The webrev is uploaded to http://cr.openjdk.java.net/~alexsch/robin.stevens/8160941/webrev.00 Thanks, Alexandr. On 7/7/2016 10:1

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

, "g_settings_schema_has_key"), NULL); CHECH_NULL_RETURN(fp_g_settings_new_full = dlsym(lib_handle, "g_settings_new_full"), NULL); On 7/6/16 5:27 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 4:46 PM, Semyon Sadetsky wrote:

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 4:46 PM, Semyon Sadetsky wrote: On 7/6/2016 12:26 PM, Alexandr Scherbatiy wrote: On 7/5/2016 9:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149115 webrev: http

Re: Review Request For 8160764: [TEST_BUG] java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 3:10 PM, Ambarish Rapte wrote: Hi, Please review this test bug fix, Webrev: http://cr.openjdk.java.net/~arapte/8160764/webrev.00/

Re: [9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

this is not the acceptable solution, we might consider to add setIconBadge(long badge) method. -- Thanks, Alexander. On 07/06/2016 10:25 AM, Alexandr Scherbatiy wrote: On 7/5/2016 5:54 PM, Alexander Zvegintsev wrote: We have two cases: 1. Underlying system(Linux) supports only numbers as

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

On 7/5/2016 9:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149115 webrev: http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.00/ Currently the hidpi support on linux only reads GDK_SCALE environment variable to get the nati

Re: [9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

Thanks, Alexandr. On 7/5/16 5:32 PM, Alexandr Scherbatiy wrote: On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8159374 Should the "chec

Re: [9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8159374 Should the "checkFeatureSupport(Feature.ICON_BADGE_TEXT)" be added to the setIconBadge() method?

Re: [9] Review request for 8156212 : Typo in javadoc of java.awt.Taskbar, setIconBadge spec

The fix looks good to me. Thanks, Alexandr. On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8156212/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8156212

Re: [9] Review request for 8155515 : Desktop.moveToTrash() javadoc issue

The fix looks good to me. Thanks, Alexandr. On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8155515/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8155515

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

cs2D requests the multi-resolution image size which leads that the base resolution image is recreated each time. I fixed it overridden the getWidth()/getHeight() methods. Thanks, Alexandr. Yet another question: why not use the actual scaling factor for the resolution variant instead of fi

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

pes. https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/FoundationTypesandCollections/FoundationTypesandCollections.html#//apple_ref/doc/uid/TP40011210-CH7-SW1 Thanks, Manajit On 30-Jun-2016, at 12:25 am, Alexandr Scherbatiy <mailto:alexandr.scherba...@oracl

Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

The fix looks good to me. Thanks, Alexandr. On 7/3/2016 10:08 PM, Manajit Halder wrote: Hi Alexandr, Thank you for your review comment. I have changed the if condition to chars.trim().isEmpty(). Please review the modified code: http://cr.openjdk.java.net/~mhalder/7156316/webrev.01/

Re: [9] Review request for 8160623: [PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java

The fix looks good to me. Thanks, Alexandr. On 6/30/2016 5:38 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160623 webrev: http://cr.openjdk.java.net/~ssadetsky/8160623/webrev.00/ This a regression from JDK-8139189. The wchar ar

Re: [9] Review request for JDK-8160650: Couple awt and swing tests have wrong require jtreg arguments

The fix looks good to me. Thanks, Alexandr. On 6/30/2016 4:01 PM, mikhail cherkasov wrote: Hi all, jbs: https://bugs.openjdk.java.net/browse/JDK-8160650 webrev:http://cr.openjdk.java.net/~mcherkas/8160650/9/webrev/ Couple awt and swing tests have wrong require jtreg arguments, the following t

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

On 6/28/2016 11:14 AM, Manajit Halder wrote: Hi All, Gentle remainder. Please review the changes. It is better to use "if (leftAltKeyPressed)" instead of "if (leftAltKeyPressed == YES)" and "if (!altGRPressed)" instead of "if (altGRPressed == NO)". Thanks, Alexandr. Thanks, Manajit

Re: [9] Review request for 8117886: There is no tooltip while moving the mouse on the tray icon.

On 6/29/2016 7:55 PM, Semyon Sadetsky wrote: Hi Alexander, On 6/29/2016 2:27 PM, Alexandr Scherbatiy wrote: On 6/14/2016 5:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8117886 webrev: http://cr.openjdk.java.net/~ssadetsky

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143064/webrev.01 The MultiResolutionImage image is used for the icons painting. Thanks, Alexandr. On 11/16/2015 7:07 PM, Sergey Bylokhov wrote: Hi, Alexander. 109 AffineTransform tx = ((Graphics2D) g).ge

Re: [9] Review request for 8117886: There is no tooltip while moving the mouse on the tray icon.

On 6/14/2016 5:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8117886 webrev: http://cr.openjdk.java.net/~ssadetsky/8117886/webrev.00/ gnome3 DE got a new DE notifications bar, so the tooltips for tray icons have gone. Just no

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

The change looks good to me. Thanks, Alexandr. On 6/17/2016 4:54 PM, Volker Simonis wrote: On Fri, Jun 17, 2016 at 3:40 PM, Alexandr Scherbatiy wrote: On 6/17/2016 4:17 PM, Lindenmaier, Goetz wrote: Hi Alexandr, yes, you are right, the test you mention is missing in this change. There are

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

other way almost all AWT/Swing tests should be marked by "headful" keyword. Thanks, Alexandr. Best regards, Goetz. -----Original Message- From: Alexandr Scherbatiy [mailto:alexandr.scherba...@oracle.com] Sent: Freitag, 17. Juni 2016 14:53 To: Volker Simonis Cc: Lindenmai

  1   2   3   >