Review request for JDK-7159591: [macosx] In SetFontTest there's no space for the second button.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7159591 Webrev: http://cr.openjdk.java.net/~arapte/manajit/7159591/webrev.00/ Issue:

Re: Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest in MacOSX

t jprt team expects that System.out/err are only used in tests, > so we may miss the Logger output in the test report. > > --Semyon > > > On 11/23/2015 2:38 PM, Manajit Halder wrote: >> Hi All, >> >> Kindly review the fix for JDK9. >> Bug: >> https:/

Re: Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest in MacOSX

Hi Semyon, Gentle remainder. Please review the changes. Thanks, Manajit > On 25-Nov-2015, at 5:52 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Semyon, > > Thank you for the comment. I have changed Logger with System.err.println. > > Please revie

Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest in MacOSX

Hi All, Kindly review the fix for JDK9. *Bug*: https://bugs.openjdk.java.net/browse/JDK-8132766 *Webrev*: http://cr.openjdk.java.net/~rchamyal/manajit/8132766/webrev.00/ *Issue*: Unable to determine title component. MetalLookAndFeel was not

Review request for 7087869: [TEST_BUG] [macosx] No mac os x support in test java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7087869 Webrev: http://cr.openjdk.java.net/~arapte/manajit/7087869/webrev.00/ Issue:

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Sadetsky <semyon.sadet...@oracle.com> > wrote: > > Hi Manajit, > > Could you improve the alignment of lines 272-286? > > --Semyon > > On 6/13/2016 2:29 PM, Manajit Halder wrote: >> Hi Semyon and Sergey, >> >> Code is modified as per

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

i, > > Okay, back to werev.01. > > Could you remove the comment in lines 262-268 since you assume that it is not > true anymore and so CGEventCreateKeyboardEvent/CGEventPost will not cause any > troubles. > Did you analyze why werev.02 fix did not pass those tests? > >

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Semyon Sadetsky <semyon.sadet...@oracle.com> > wrote: > > On 5/24/2016 2:09 PM, Manajit Halder wrote: >> Hi Semyon, >> >> It is not clear in the comment what was the problem, but it looks like the >> problem was observed just by using CGEventCreateKeyboardEvent/C

[9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

Hi All, Please review the regression fix for issue JDK-8156460 which fixes below mentioned test cases. http://cr.openjdk.java.net/~mhalder/8156460/webrev.00/ This fix resolves the

[9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7156316 Webrev: http://cr.openjdk.java.net/~mhalder/7156316/webrev.00/ Issue: [macosx]

Re: [9] Review request for JDK-8156460 [macosx] Test case javax/swing/JPopupMenu/6827786/bug6827786.java fails

Hi All, Gentle remainder. Please review the changes. Thanks, Manajit > On 25-Jun-2016, at 7:46 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > The code was changed on the same lines in one file after the first review was > generated. A new r

Review request for 8147834: [macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8147834 Webrev: http://cr.openjdk.java.net/~mhalder/8147834/webrev.00 Issue: [macosx] KeyEvents

Review request for 8075964: java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html fails intermittently with timeout error

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8075964 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8075964/webrev.00 Issue:

[9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

add " [9]" in the beginning of review subject. > > --Semyon > > On 3/9/2016 4:43 PM, Manajit Halder wrote: >> Hi All, >> >> Please review webrev.01 updated with Avik’s review comments. >> >> http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.0

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

With Regards, > Avik Niyogi >> On 09-Mar-2016, at 2:52 pm, Manajit Halder <manajit.hal...@oracle.com >> <mailto:manajit.hal...@oracle.com>> wrote: >> >> Hi All, >> >> Kindly review the fix for JDK9. >> >> Bug: >> https://bugs.

Re: [9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

Hi Sergey, Gentle remainder. Please review the changes. Thanks, Manajit > On 04-Apr-2016, at 3:06 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Sergey, > > In that case we have two options: > Depend on the dispose() method to call removeN

[9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8151136 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/

[9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8151136 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/

Re: [9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

Hi Sergey and Semyon, Thank you both for the review comments. Thanks, Manajit > On 13-Apr-2016, at 2:01 pm, Semyon Sadetsky <semyon.sadet...@oracle.com> > wrote: > > Looks good. > > --Semyon > > On 4/1/2016 1:58 PM, Manajit Halder wrote: >> Hi Serg

[9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

viewed-by: serb, ssadetsky username: mhalder Thanks, Manajit > On 13-Apr-2016, at 2:37 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Sergey and Semyon, > > Thank you both for the review comments. > > Thanks, > Manajit > >> On 13-Apr-20

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

Hi All, Gentle remainder. Please review the changes. Thanks, Manajit > On 07-Apr-2016, at 1:48 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Kindly review the fix for JDK9. > > Bug: > https://bugs.openjdk.java.ne

Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8149456 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.00/ Issue:

[9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8147841 Webrev: http://cr.openjdk.java.net/~arapte/manajit/8147841/webrev.00/ Issue:

Re: [9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

ease double check two cases. > - The initial popup menu is set to null in CTrayIcon(); it seems after the > fix it will never be changed to non-null value. > - Who and when will call removeNotify() on the old popup menu after you > replace it by the new popup. it will be leaked? > > On 30

Re: [9] Push request for 8151136: [macosx] According to the description, the case is failed

6827786.java > > please check the problem. > > On 27.04.16 12:15, Manajit Halder wrote: >> Hi Semyon, >> >> Rajeev is facing some issues with his ubuntu machine. So could you >> please commit this change. >> >> Regards, >> Manajit

Re: [9] Push request for 8151136: [macosx] According to the description, the case is failed

:44 pm, Semyon Sadetsky <semyon.sadet...@oracle.com> > wrote: > > pushed. > Please don't forget to file jira for Alt-GRAPH mapping. > > --Semyon > > On 4/27/2016 12:15 PM, Manajit Halder wrote: >> Hi Semyon, >> >> Rajeev is facing some issues with

Re: [9] Push request for 8151136: [macosx] According to the description, the case is failed

Hi Semyon, Rajeev is facing some issues with his ubuntu machine. So could you please commit this change. Regards, Manajit > On 27-Apr-2016, at 11:54 am, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Rajeev, > > Could you please push the patch to JDK9 with

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Phil, Gentle reminder. Please review the updated webrev http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ <http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/> Thanks, Manajit > On 20-Apr-2016, at 6:03 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > >

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

> wrote: > > Hi Manajit, > > Why robot.keyPress(KeyEvent.VK_ALT_GRAPH) cannot be used to press the right > Alt? > > --Semyon > > On 4/20/2016 3:16 PM, Manajit Halder wrote: >> Hi Semyon, >> >> Thank you for the review comment. >&g

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Hi Semyon, Gentle reminder. Please review the changes. Regards, Manajit > On 14-May-2016, at 2:20 am, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Semyon, > > The fix is changed a bit because it was observed that the modifier keys plus > alphabet keys w

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

I understand Numpad number keys did not work as well. Could you add > the corresponding test case since you provide a fix this extra issue? > > --Semyon > > > On 5/13/2016 11:50 PM, Manajit Halder wrote: >> Hi Semyon, >> >> The fix is

[9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8155740 Webrev: http://cr.openjdk.java.net/~mhalder/8155740/webrev.00/ Issue: [macosx]

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

a few questions to clarify on the fix. > What is difference between AXUIElementPostKeyboardEvent and > CGEventCreateKeyboardEvent? > Why the latter was commented? Does it mean that valid modifier keys have not > been sent by AWT robot? > > --Semyon > > > O

[9] Push request for 8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac

n, prr username: mhalder Thanks, Manajit > On 03-May-2016, at 10:57 pm, Phil Race <philip.r...@oracle.com> wrote: > > +1 > > -phil. > > On 04/19/2016 01:40 AM, prasanta sadhukhan wrote: >> Looks ok to me. >> >> Regards >> Prasanta >&

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

; > Hi Manajit, > > The fix itself is OK. > Why the test cannot be automated? > > --Semyon > > On 4/12/2016 1:46 PM, Manajit Halder wrote: >> Hi All, >> >> Gentle remainder. Please review the changes. >> >> Thanks, >> Manajit >&g

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Phil, Gentle remainder. Please review the changes. Thanks, Manajit > On 19-Apr-2016, at 2:10 pm, prasanta sadhukhan > <prasanta.sadhuk...@oracle.com> wrote: > > Looks ok to me. > > Regards > Prasanta > On 4/19/2016 1:25 PM, Manajit Halder wrote: &g

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

Swing components on non-EDT. > - The instructions are a little bit misleading, because popup will be shown > even when the test is passed. > - When I run the test on the current client ws, it is passed. Can you please > double check that the test fails before the fix. > > On 01.08.16 12:35, M

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

s that the test creates the Swing components on non-EDT. > - The instructions are a little bit misleading, because popup will be shown > even when the test is passed. > - When I run the test on the current client ws, it is passed. Can you please > double check that the test fails before th

Re: [9] Review request for JDK-8156099: [macosx] Drag and drop of link from web browser, DataFlavor types application/x-java-url and text/uri-list, getTransferData returns null

uble check that the test fails before the fix. > > On 01.08.16 12:35, Manajit Halder wrote: >> Hi All, >> >> Kindly review the fix for JDK9. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8156099 >> <https://bugs.openjdk.java.net/browse

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

obotUtilities.pressKey(int num)/releaseKey(int num) are just direct calls to > the corresponding methods in Robot. > Other necessary methods can be added to > test/java/awt/regtesthelpers/Util.java > > Thanks, > Alexandr. > > On 7/7/2016 1:32 PM, Manajit Halder wrote: >

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

Hi All, Gentle remainder. Please review the fix for issue https://bugs.openjdk.java.net/browse/JDK-8160266 <https://bugs.openjdk.java.net/browse/JDK-8160266>. Thanks, Manajit > On 24-Jun-2016, at 8:53 pm, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi Serge

Re: [9] Review request for JDK-7156316: [macosx] Ctrl+Space does generate Unknown keychar

16, at 10:33 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > On 27/06/16 21:57, Manajit Halder wrote: >> Hi All, >> >> Kindly review the fix for JDK9. >> >> Bug: >> >> <https://bugs.openjdk.java.net/browse/JD

Re: [9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

wrote: > > Hi Manajit, > Please include the jtreg tag: @key headful > & also include the bug id: 4009555 from the original test. > > Regards, > Ambarish > > From: Sergey Bylokhov > Sent: Monday, February 13, 2017 11:02 PM > To: Manajit Halder > Cc: awt-

Re: [9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

Bylokhov <sergey.bylok...@oracle.com> > wrote: > > Hi, Manajit. > I recognized that the test can be cleaned a little bit. We can move the code > from the init() to main and remove all other unnecessary stuff: > TestPassedException, pass(), setTimeoutTo(), etc. > >

[9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163270 Webrev: http://cr.openjdk.java.net/~mhalder/8163270/webrev.00/ Issue: [macosx] Robot(gc) issue on dual-screen system. Cause: Calculation of x coordinate value was wrong for the mouse cursor in

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

jdk.java.net/~mhalder/816/webrev.03/ > > <http://cr.openjdk.java.net/~mhalder/816/webrev.03/> > > > > Thanks, > > Manajit > > > > On 27-Sep-2016, at 4:15 pm, Sergey Bylokhov <sergey.bylok...@oracle.com > > <mailto:sergey.bylok...@ora

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

m, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 27.09.16 11:51, Manajit Halder wrote: >> Hi Sergey, >> >> Thanks for the comment. “self.javaToMacKeyMap is retaining the reference. >> Please review the modified code: >> >> http

[9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8158380 Webrev: http://cr.openjdk.java.net/~mhalder/8158380/webrev.00/ Issue: Regression:

Re: [9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

gt; wrote: > > Hi, Manajit. > Instead of adding these methods between operations you can call these after > robot creation: >Robot.setAutoDelay(int ms) >Robot.setAutoWaitForIdle(boolean isOn) > > On 07.10.16 15:10, Manajit Halder wrote: >> Hi All, >> &

[9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-816 Webrev: http://cr.openjdk.java.net/~mhalder/816/webrev.00/ Issue: [macosx] VM

Re: [9] Review request for JDK-8165555: [macosx] VM crashes on second attempt to execute JCK interactive tests that use Robot (single JVM, agent)

Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 21.09.16 16:01, Manajit Halder wrote: >> Hi Sergey, >> >> Thanks for the comment. >> >> Access to "instance" is not broken. The problem is with the dictionary >> variabl

[9] Review request for JDK-8165680: [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8165680 Webrev: http://cr.openjdk.java.net/~mhalder/8165680/webrev.00/ Issue: [macosx] Enhance

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Hi Sergey, Code is modified to correct a memory leak. Please review the modified webrev: http://cr.openjdk.java.net/~mhalder/7153700/webrev.01/ <http://cr.openjdk.java.net/~mhalder/7153700/webrev.01/> Thanks, Manajit > On 21-Oct-2016, at 1:20 pm, Manajit Halder <manajit.hal..

Re: [9] Review request for JDK-8165680: [macosx] Enhance handling of UTF-8 characters in CDataTransfer.java

ergey Bylokhov <sergey.bylok...@oracle.com> >> wrote: >> >> Looks fine. >> >> On 27.10.16 14:18, Manajit Halder wrote: >>> Hi All, >>> >>> Kindly review the fix for JDK9. >>> >>> Bug: >>> https:/

[9] Review request for JDK-8160453: [macosx] scary native stack trace in closed/java/awt/FileDialog/FileDialogBufferOverflowTest/FileNameTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8160453 Webrev: http://cr.openjdk.java.net/~mhalder/8160453/webrev.00/ Issue: Test passed but

[9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-7153700 Webrev: http://cr.openjdk.java.net/~mhalder/7153700/webrev.00/ Issue: [macosx] add

Re: [9] Review request for JDK-7153700: [macosx] add support for MouseMotionListener to the TrayIcon

ter trackingArea is not initialized to nil so it can > contains some non-nil garbage, and calling removeTrackingArea:trackingArea > can cause a crash. > > On 27.10.16 14:08, Manajit Halder wrote: >> Hi Sergey, >> >> Code is modified to correct a memory leak. Pleas

Re: [9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

sergey.bylok...@oracle.com> > wrote: > > It seems that "Copyright (c)" is incorrectly updated in both tests. > > On 10.10.16 14:41, Manajit Halder wrote: >> Hi Sergey, >> >> Thank you for the review. Please review the modified webrev. >> http

[9] Review request for JDK-8158390: [macosx] Regression: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8158390 Webrev: http://cr.openjdk.java.net/~mhalder/8158390/webrev.00/ Issue: [macosx]

[9] Review request for JDK-8160536: [macosx] Possible regression: com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8160536 Webrev: http://cr.openjdk.java.net/~mhalder/8160536/webrev.00/ Issue: Menubar event was

Re: [10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

Hi Sergey, Added the test case from the previous iteration of the fix. Please review the webrev: http://cr.openjdk.java.net/~mhalder/8136999/webrev.01/ Regards, Manajit > On 26-Jul-2017, at 10:32 PM, Sergey Bylokhov

[10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8136999 Webrev: http://cr.openjdk.java.net/~mhalder/8136999/webrev.00/ Fix: The flushEvent

[9] Review request for JDK-8172510: [TEST_BUG][macosx] set autodelay in java/awt/List/ItemEventTest/ItemEventTest.java

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8172510 Webrev: http://cr.openjdk.java.net/~mhalder/8172510/webrev.00/ Issue: Wrong ItemEvent

Re: [10] Review request for JDK-8163265: [macosx] numpad 0 instead of VK_0

v wrote: >> Looks fine. >> Please update the @bugid in the test before the push. >> >> On 16/10/2017 06:38, Manajit Halder wrote: >>> Hi All, >>> >>> Kindly review the fix for JDK10. >>> >>> Bug: >>> https://bugs

[10] Review request for JDK-8163265: [macosx] numpad 0 instead of VK_0

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8163265 Webrev: http://cr.openjdk.java.net/~mhalder/8163265/webrev.00/ Issue: Wrong event code

[10] Review request for JDK-8177326: [macosx] mouse event goes to button in java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8177326/ Webrev: http://cr.openjdk.java.net/~mhalder/8177326/webrev.00/ Issue: [macosx] mouse

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

ses > on Windows and Linux as well? > > Regards, > Ajit > > From: Manajit Halder > Sent: Monday, November 27, 2017 4:35 PM > To: Ajit Ghaisas > Cc: Prem Balakrishnan; Sergey Bylokhov; awt-dev@openjdk.java.net > Subject: Re: [10] Review request for JD

Re: [10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

shnan > Sent: Monday, November 27, 2017 12:02 PM > To: Sergey Bylokhov; Manajit Halder > Cc: awt-dev@openjdk.java.net > Subject: Re: [10] Review request for JDK-8158366: [macosx] > Regression: > closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails > > +1 >

[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8158366 Webrev: http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/ Issue: Test

Re: [11] Review Request: JDK-8196616 java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java fails

Looks good to me Regards, Manajit > On 14-May-2018, at 10:38 PM, Phil Race wrote: > > This works on my system. > > +1 > > -phil. > > On 05/10/2018 01:30 PM, Pankaj Bansal wrote: >> Hi Phil, >> >> Thanks for the quick review. >> >> <> takeWhile() which >> <>

[11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

Hi All, Kindly review the following AWT enhancement changes: Bug: https://bugs.openjdk.java.net/browse/JDK-8029250 Webrev: http://cr.openjdk.java.net/~mhalder/8029250/webrev.00/ Fix:

[11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

Hi Phil, Please review the test fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202841 Webrev: http://cr.openjdk.java.net/~mhalder/8202841/webrev.00/ Issue: Test fails

Re: [11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

gt; > But it seems this is only implemented for applets. > > So are those other strings applets or main programs. > > -phil. > > On 5/10/18, 1:58 PM, Sergey Bylokhov wrote: >> Hi, Manajit. >> Did you check other tests with such typos? >> I found the same stri

Re: [11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

gnal the main thread doesn't seem ideal. > You can either use a semaphore or it can use a sleep loop waiting for a flag > to be set. > > -phil. > > > > On 05/15/2018 05:19 AM, Manajit Halder wrote: >> Hi Phil, >> >> My observation on test written usin

Re: [11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

- The parentheses around target are not necessary >> CTrayIcon.java:359 if (image != (target).getImage()) >> >> >> On 03/05/2018 04:11, Manajit Halder wrote: >>> Hi Sergey, >>> >>> Please review the updated webrev. >>> http://cr.openjd

Re: [11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

case CMenuItem/CCustomCursor will not be >> changed. >> - The parentheses around target are not necessary >>CTrayIcon.java:359 if (image != (target).getImage()) >> >> >> On 03/05/2018 04:11, Manajit Halder wrote: >>> Hi Sergey, >>> >&

[11] Review request for JDK-8204859: [macosx] Remove javax/swing/plaf/nimbus/8057791/bug8057791.java from the ProblemList.txt

Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8204859 Webrev: http://cr.openjdk.java.net/~mhalder/8204859/webrev.00/ Changes: Removed

[11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8204860 Webrev: http://cr.openjdk.java.net/~mhalder/8204860/webrev.00/ Fix: Frame is focusable:

Re: [12] JDK-8195991: [TEST_BUG]:Regression manual Test java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.html fails

Hi Shashi, BUTTON1_MASK and BUTTON3_MASK are deprecated. Remaining code changes looks good. Regards, Manajit > On 02-Jul-2018, at 9:43 AM, Shashidhara Veerabhadraiah > wrote: > > Thank you Sergey for the review. > > -Shashi > > -Original Message- > From: Sergey Bylokhov > Sent:

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

et).isResizable() : > ((target instanceof Dialog) ? ((Dialog)target).isResizable() : false > > On 28/06/2018 05:54, Manajit Halder wrote: >> Hi Sergey, >> Thanks for your review comment. I have modified the fix to incorporate your >> suggestions. >> Please re

Re: [12] JDK-8195991: [TEST_BUG]:Regression manual Test java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.html fails

~sveerabhadra/8195991/webrev.02/> > Thanks and regards, > Shashi > > On 03/07/18 1:25 PM, Manajit Halder wrote: >> Hi Shashi, >> >> BUTTON1_MASK and BUTTON3_MASK are deprecated. >> Remaining code changes looks good. >> >> Regards, &

Re: [11] Review request for JDK-8029250: [macosx] There is no tray icon shown in the system tray area when case starts

t 4:06 PM, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Kindly review the following AWT enhancement changes: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8029250 > <https://bugs.openjdk.java.net/browse/JDK-8029250> > Webrev: http://c

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Correcting the JDK version to be reviewed for to JDK 11. > On 29-Jan-2018, at 6:09 PM, Manajit Halder <manajit.hal...@oracle.com> wrote: > > Hi All, > > Kindly review the fix for JDK11. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8190767 > <http

[10] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8190767 Webrev: http://cr.openjdk.java.net/~mhalder/8190767/webrev.00/ Problem: In this

Re: [11][JDK-8171000]Robot.createScreenCapture() crashes in wayland mode

Looks good to me +1 Regards, Manajit > On 05-Feb-2018, at 9:59 AM, Sergey Bylokhov > wrote: > > OK, then it looks fine. > > On 03/02/2018 20:13, Krishna Addepalli wrote: >> Hi Sergey, >> I'm aware of the C99 thing, so I looked around in the file before making >>

Re: [10] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

ith one exception if the window is MAXIMIZED_BOTH. > > On 29/01/2018 04:39, Manajit Halder wrote: >> Hi All, >> Kindly review the fix for JDK10. >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8190767 >> Webrev: >> http://cr.openjdk.java.net/~mhalder

Subject: [11] Review request for JDK-7158623: [macosx] Should an unfocusable maximized Frame be resizable?

Hi All, Kindly review the fix for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-7158623 Webrev: http://cr.openjdk.java.net/~mhalder/7158623/webrev.00/ Issue: Unfocusable frame

Re: Subject: [11] Review request for JDK-7158623: [macosx] Should an unfocusable maximized Frame be resizable?

t match > what you > say you are doing. > > -phil. > > On 02/16/2018 08:17 AM, Kevin Rushforth wrote: >> >> > Kindly review the fix for JDK10. >> >> You mean JDK 11, right? >> >> -- Kevin >> >> >> Manajit Halder wrote:

Re: [11] Review Request: JDK-8196435 Regression automated Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' fails

Looks good. +1 Regards, Manajit > On 26-Feb-2018, at 10:59 AM, Prem Balakrishnan > wrote: > > Hi All, > > Please review fix for JDK 11: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196435 > > >

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

Hi Krishna, Fix looks good. I suggest the following changes before committing. 1) Remove the comma in between the two bug ids. 2) Is the message “Test PASSED” required? Regards, Manajit > On 26-Feb-2018, at 10:23 PM, Semyon Sadetsky > wrote: > > +1 > >

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

e as per the suggestion. Please review the modified code. http://cr.openjdk.java.net/~mhalder/8204860/webrev.01/ <http://cr.openjdk.java.net/~mhalder/8204860/webrev.01/> Regards, Manajit > -phil. > > On 06/14/2018 11:37 PM, Manajit Halder wrote: >> Hi All, >> >>

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

anajit > On 20-Jun-2018, at 6:27 PM, Manajit Halder wrote: > > Hi Phil, > > Please find my answer inline to your comment. > >> On 15-Jun-2018, at 11:24 PM, Phil Race > <mailto:philip.r...@oracle.com>> wrote: >> >> I would like to refer

Subject: [11] Review request for JDK-8208125: Cannot input text into JOptionPane Text Input Dialog

Hi All, Please review the fix for JDK11. 

Bug: 
https://bugs.openjdk.java.net/browse/JDK-8208125 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8208125/webrev.00/ 
Issue:     

[11] Review request for JDK-8208394: [macosx] test java/awt/Frame/UnfocusableMaximizedFrameResizablity/UnfocusableMaximizedFrameResizablity.java compilation fail

Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8208394 Webrev: http://cr.openjdk.java.net/~mhalder/8208394/webrev.00/ Regards, Manajit

[12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called

Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8208743 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8208743/webrev.00/ Fix: 
     This reported issue is resolved by fix of issue

Re: Subject: [11] Review request for JDK-8208125: Cannot input text into JOptionPane Text Input Dialog

back story, and reference it here ? -phil. On 08/03/2018 04:23 AM, Manajit Halder wrote: Hi All, Please review the fix for JDK11. 

Bug: 
https://bugs.openjdk.java.net/browse/JDK-8208125 <https://bugs.openjdk.java.net/browse/JDK-8208125> 
Webrev: 
 http://cr.openjdk.java.net/~m

Re: [12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called

rds Prasanta On 8/16/2018 5:11 PM, Manajit Halder wrote: Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8208743 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8208743/webrev.00/ <http://cr.openjdk.java.net/%7Emhalder/8208743/webrev.00/> Fix: 


Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

release 8u131. 8169589 introduced new window ordering model and which has introduced the cycling through window issue. Thanks, Dmitry On 31 Aug 2018, at 07:55, Manajit Halder <mailto:manajit.hal...@oracle.com>> wrote: Hi All, Please review the fix for JDK12. 

B

Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

Sep 2018, at 12:22, Manajit Halder <mailto:manajit.hal...@oracle.com>> wrote: Hi Dmitry, Thanks for the test scenarios. I have run all the AWT, Swing and JCK automatic (open and closed) test cases along with manual test cases related to Modal Dialog and ordering to ensure that fix does

[12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

Hi All, Please review the fix for JDK12. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8206392 
Webrev: 
 http://cr.openjdk.java.net/~mhalder/8206392/webrev.00/ Fix: 
     Window

  1   2   >