Re: RFR: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

2021-08-19 Thread Prasanta Sadhukhan
On Wed, 18 Aug 2021 23:57:38 GMT, Phil Race wrote: > When Ctrl+Space is pressed mac generates a string that contains the single > unicode code point zero. > The fn that converts it from an NSString to a Java String is using > NewStringUTF. > The input to that is a null terminated string which

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v6]

2021-08-17 Thread Prasanta Sadhukhan
On Tue, 17 Aug 2021 06:09:51 GMT, Alexander Zuev wrote: >> Initial implementation and a test case. >> >> The problem is that Aqua LaF shows the focused component with the glow on >> the border, hence when the border is not painted the foxus is not displayed. >> The idea is to paint the

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v4]

2021-08-17 Thread Prasanta Sadhukhan
On Tue, 17 Aug 2021 06:04:39 GMT, Alexander Zuev wrote: >> You can trace the usage of graphics.getColor() for example in >> AquaMenuItemUI/WindowsMenuUI/BevelBorder/etc to check that the old color >> property is usually saved and then restored. > >> You can trace the usage of

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v3]

2021-08-13 Thread Prasanta Sadhukhan
On Fri, 13 Aug 2021 06:18:49 GMT, Alexander Zuev wrote: >> Initial implementation and a test case. >> >> The problem is that Aqua LaF shows the focused component with the glow on >> the border, hence when the border is not painted the foxus is not displayed. >> The idea is to paint the

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v7]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 19:37:51 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v6]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 15:42:48 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v5]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 11:59:14 GMT, Prasanta Sadhukhan wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed test instruction and execute the testcase on metal only for mac >

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v5]

2021-08-12 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 21:16:43 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v4]

2021-08-11 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 15:35:43 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-11 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java [v3]

2021-08-10 Thread Prasanta Sadhukhan
On Fri, 6 Aug 2021 15:17:48 GMT, lawrence.andrews wrote: >> 1) This testcase was throwing error saying Error: Not a test or directory >> containing tests: java/awt/print/PrinterJob/XparColor.java >> 2) Added @test tag so that this testcase can be run >> 3) Since Applet is deprecated and its

Re: RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64 [v2]

2021-08-09 Thread Prasanta Sadhukhan
On Mon, 9 Aug 2021 15:06:55 GMT, Phil Race wrote: >> As per the bug comments, these tests fail too often on macOS arm. >> This will be too noisy for CI. So I would like to problem list them for >> mac-arm > > Phil Race has updated the pull request incrementally with one additional > commit

Re: RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64

2021-08-08 Thread Prasanta Sadhukhan
On Mon, 9 Aug 2021 04:28:28 GMT, Sergey Bylokhov wrote: >> As per the bug comments, these tests fail too often on macOS arm. >> This will be too noisy for CI. So I would like to problem list them for >> mac-arm > > test/jdk/ProblemList.txt line 532: > >> 530: >> 531:

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-04 Thread Prasanta Sadhukhan
On Wed, 4 Aug 2021 21:43:53 GMT, rajat mahajan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > > rajat mahajan has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-03 Thread Prasanta Sadhukhan
On Tue, 3 Aug 2021 18:30:09 GMT, rajat mahajan wrote: >> test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> line 54: >> >>> 52: public class ButtonGroupLayoutTraversalTest { >>> 53: >>> 54: private static final int nx = 3; >>

Re: RFR: 8270058: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.desktop [v3]

2021-07-30 Thread Prasanta Sadhukhan
On Thu, 22 Jul 2021 06:29:13 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. >> >> As Mandy suggested, I create this PR for

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-07-29 Thread Prasanta Sadhukhan
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan wrote: > Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on > all OS. Added synchronization for focusCnt. Also, please give a CI run of this test running for several iterations(20+) for all platforms since it's supposed

Re: RFR: 8271396: Spelling errors

2021-07-28 Thread Prasanta Sadhukhan
On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Thanks for awt/swing

Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]

2021-07-23 Thread Prasanta Sadhukhan
On Fri, 23 Jul 2021 11:33:35 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]

2021-07-23 Thread Prasanta Sadhukhan
On Fri, 23 Jul 2021 05:49:25 GMT, Alexander Zuev wrote: >> Fixed the version string parsing to work correctly on macOS 11.x and beyond > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Demoved isBigSurOrAbove variable that

Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]

2021-07-22 Thread Prasanta Sadhukhan
On Thu, 22 Jul 2021 22:41:49 GMT, Sergey Bylokhov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> year bump > > test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java > line

Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled

2021-07-22 Thread Prasanta Sadhukhan
On Thu, 22 Jul 2021 16:25:40 GMT, Alexander Zuev wrote: > Fixed the version string parsing to work correctly on macOS 11.x and beyond Since existing currentMacOSXVersionMatchesGivenVersionRange() is changed, did you test in osx 10.15 or below to see current functionality is ok? ALso, please

Re: RFR: 8270058: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.desktop [v2]

2021-07-22 Thread Prasanta Sadhukhan
On Thu, 22 Jul 2021 06:23:43 GMT, Yi Yang wrote: >> test/jdk/javax/imageio/ImageReaderReadAll.java line 94: >> >>> 92: if (seekForwardOnly) { >>> 93: if (imageIndex < minIndex) >>> 94: throw new IndexOutOfBoundsException(); >> >> Can't we use

Re: RFR: 8270058: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.desktop [v2]

2021-07-21 Thread Prasanta Sadhukhan
On Wed, 21 Jul 2021 09:58:23 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. >> >> As Mandy suggested, I create this PR for

Re: RFR: 8270312: Error: Not a test or directory containing tests: java/awt/print/PrinterJob/XparColor.java

2021-07-15 Thread Prasanta Sadhukhan
On Tue, 13 Jul 2021 14:57:30 GMT, lawrence.andrews wrote: > 1) This testcase was throwing error saying Error: Not a test or directory > containing tests: java/awt/print/PrinterJob/XparColor.java > 2) Added @test tag so that this testcase can be run > 3) Since Applet is deprecated and its not

Withdrawn: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-05-15 Thread Prasanta Sadhukhan
On Fri, 9 Apr 2021 04:55:18 GMT, Prasanta Sadhukhan wrote: > This testcase was a regression testcase for a windows bug JDK-6242241 whereby > dragging an attachment from a Microsoft Outlook message to the application > results in blank or semicolons. > The testcase was later mad

Re: RFR: 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

2021-05-01 Thread Prasanta Sadhukhan
On Tue, 27 Apr 2021 01:09:44 GMT, Sergey Bylokhov wrote: > The fix for the JDK-8187639 reimplemented the tray icon messages using the > standard notification center, it worked fine on macOS 10.9. But on the new > macOS, the usage of that API requests permission from the user. Since the > code

Integrated: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

2021-04-29 Thread Prasanta Sadhukhan
On Thu, 29 Apr 2021 09:24:37 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "jjava.lang.RuntimeException: t2 is not a focus owner > > Updated test to > use swing components in EDT, > setAutoDelay for mouse events, &g

Re: RFR: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

2021-04-29 Thread Prasanta Sadhukhan
On Thu, 29 Apr 2021 09:24:37 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "jjava.lang.RuntimeException: t2 is not a focus owner > > Updated test to > use swing components in EDT, > setAutoDelay for mouse events, &g

Re: RFR: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

2021-04-29 Thread Prasanta Sadhukhan
On Thu, 29 Apr 2021 10:39:11 GMT, Jayathirth D V wrote: > > > I dont see CI test run link in JBS. > Also if we see duplicate of this bug : > https://bugs.openjdk.java.net/browse/JDK-8198233 . It is mentioned that if > fails only when run in group : >

RFR: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

2021-04-29 Thread Prasanta Sadhukhan
This test was failing earlier in our nightly testing citing "jjava.lang.RuntimeException: t2 is not a focus owner Updated test to use swing components in EDT, setAutoDelay for mouse events, add a delay after frame is made visible, move the frame to center of screen and dispose of the frame

Integrated: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows

2021-04-28 Thread Prasanta Sadhukhan
On Wed, 28 Apr 2021 12:46:56 GMT, Prasanta Sadhukhan wrote: > 2 tests java/awt/font/TextLayout/LigatureCaretTest.java and > java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java used to > fail on windows in CI testing citing "wrong text location" and &q

RFR: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows

2021-04-28 Thread Prasanta Sadhukhan
2 tests java/awt/font/TextLayout/LigatureCaretTest.java and java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java used to fail on windows in CI testing citing "wrong text location" and " right hit failed within layout " which is due to some layout issue. We have made harfbuzz

Withdrawn: 8203047: [macosx] java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java fails

2021-04-28 Thread Prasanta Sadhukhan
On Wed, 28 Apr 2021 06:16:38 GMT, Prasanta Sadhukhan wrote: > This test was seen to be failing long time back citing "exception is not > handled for modal dialog " > with stacktrace for some failiures seen to be > > sun.awt.SunToolkit$OperationTimedOut: 10469

RFR: 8203047: [macosx] java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java fails

2021-04-28 Thread Prasanta Sadhukhan
This test was seen to be failing long time back citing "exception is not handled for modal dialog " with stacktrace for some failiures seen to be sun.awt.SunToolkit$OperationTimedOut: 10469 at sun.awt.X11.XToolkit.syncNativeQueue(XToolkit.java:2447) at

Integrated: 8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows

2021-04-28 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 11:52:27 GMT, Prasanta Sadhukhan wrote: > This test rootcause which is > > sun.awt.SunToolkit$InfiniteLoop > at sun.awt.SunToolkit.realSync(SunToolkit.java:1498) > at sun.awt.SunToolkit.realSync(SunToolkit.java:1426) > at java.awt.Robot.waitForI

Integrated: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac

2021-04-27 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 08:52:23 GMT, Prasanta Sadhukhan wrote: > This test was failing in CI nightly testing due to samevm mode issue. > Modified test to use waitForIdle() judiciously, dispose frame in finally > block and move the frame to center of screen. > Several iterations of t

Integrated: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

2021-04-27 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 06:08:05 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "java.lang.RuntimeException: java.awt.IllegalComponentStateException: > component must be showing on the screen to determine its location " >

Integrated: 8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out

2021-04-26 Thread Prasanta Sadhukhan
On Mon, 26 Apr 2021 08:49:11 GMT, Prasanta Sadhukhan wrote: > This test was timing out on windows during nightly testing possibly due to > samevm mode issue when it was problemlisted. > Modified test to increase the timing delay after frame is made visible, added > waitForIdle()

Re: RFR: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

2021-04-26 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 06:08:05 GMT, Prasanta Sadhukhan wrote: > This test was failing earlier in our nightly testing citing > "java.lang.RuntimeException: java.awt.IllegalComponentStateException: > component must be showing on the screen to determine its location " >

Re: RFR: 8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows

2021-04-26 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 11:52:27 GMT, Prasanta Sadhukhan wrote: > This test rootcause which is > > sun.awt.SunToolkit$InfiniteLoop > at sun.awt.SunToolkit.realSync(SunToolkit.java:1498) > at sun.awt.SunToolkit.realSync(SunToolkit.java:1426) > at java.awt.Robot.waitForI

Re: RFR: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac [v3]

2021-04-26 Thread Prasanta Sadhukhan
On Mon, 26 Apr 2021 07:44:37 GMT, Prasanta Sadhukhan wrote: >> This test was failing in CI nightly testing due to samevm mode issue. >> Modified test to use waitForIdle() judiciously, dispose frame in finally >> block and move the frame to center of screen. >> Severa

RFR: 8196300: java/awt/TextArea/TextAreaScrolling/TextAreaScrolling.java times out

2021-04-26 Thread Prasanta Sadhukhan
This test was timing out on windows during nightly testing possibly due to samevm mode issue when it was problemlisted. Modified test to increase the timing delay after frame is made visible, added waitForIdle() at suitable places and delays to make sure the execution steps are visible during

Re: RFR: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac [v3]

2021-04-26 Thread Prasanta Sadhukhan
> This test was failing in CI nightly testing due to samevm mode issue. > Modified test to use waitForIdle() judiciously, dispose frame in finally > block and move the frame to center of screen. > Several iterations of the test pass in all platforms. Link in JBS. Prasanta Sadhukhan

Re: RFR: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac [v2]

2021-04-26 Thread Prasanta Sadhukhan
> This test was failing in CI nightly testing due to samevm mode issue. > Modified test to use waitForIdle() judiciously, dispose frame in finally > block and move the frame to center of screen. > Several iterations of the test pass in all platforms. Link in JBS. Prasanta Sadhukhan

Re: RFR: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac [v2]

2021-04-26 Thread Prasanta Sadhukhan
On Sun, 25 Apr 2021 20:56:30 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix > > test/jdk/java/awt/Focus/FocusTraversalPol

Re: RFR: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

2021-04-26 Thread Prasanta Sadhukhan
On Sun, 25 Apr 2021 21:00:06 GMT, Sergey Bylokhov wrote: > > > Please check that 6382144 can be verified by the updated test. Build without 6382144 fix still fails with the updated test. - PR: https://git.openjdk.java.net/jdk/pull/3614

Integrated: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac

2021-04-26 Thread Prasanta Sadhukhan
On Fri, 23 Apr 2021 08:13:53 GMT, Prasanta Sadhukhan wrote: > This test was failing in earlier test sprint in CI system citing > java.lang.Exception: Not all expected events were received > One of the reason could be the frame was placed at topleft corner of screen. > Modified

RFR: 8198621: java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java fails on mac

2021-04-23 Thread Prasanta Sadhukhan
This test was failing in earlier test sprint in CI system citing java.lang.Exception: Not all expected events were received One of the reason could be the frame was placed at topleft corner of screen. Modified test to move frame to center of screen. Also, frame is disposed at end. Several

Re: RFR: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac

2021-04-22 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 08:52:23 GMT, Prasanta Sadhukhan wrote: > This test was failing in CI nightly testing due to samevm mode issue. > Modified test to use waitForIdle() judiciously, dispose frame in finally > block and move the frame to center of screen. > Several iterations of t

Re: RFR: 8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows

2021-04-22 Thread Prasanta Sadhukhan
On Thu, 22 Apr 2021 11:52:27 GMT, Prasanta Sadhukhan wrote: > This test rootcause which is > > sun.awt.SunToolkit$InfiniteLoop > at sun.awt.SunToolkit.realSync(SunToolkit.java:1498) > at sun.awt.SunToolkit.realSync(SunToolkit.java:1426) > at java.awt.Robot.waitForI

RFR: 8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows

2021-04-22 Thread Prasanta Sadhukhan
This test rootcause which is ``` sun.awt.SunToolkit$InfiniteLoop at sun.awt.SunToolkit.realSync(SunToolkit.java:1498) at sun.awt.SunToolkit.realSync(SunToolkit.java:1426) at java.awt.Robot.waitForIdle(Robot.java:574) at NoEventsTest.pause(NoEventsTest.java:50) at

RFR: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac

2021-04-22 Thread Prasanta Sadhukhan
This test was failing in CI nightly testing due to samevm mode issue. Modified test to use waitForIdle() judiciously, dispose frame in finally block and move the frame to center of screen. Several iterations of the test pass in all platforms. Link in JBS. - Commit messages: - Fix

RFR: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac

2021-04-22 Thread Prasanta Sadhukhan
This test was failing earlier in our nightly testing citing "java.lang.RuntimeException: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location " Updated test to use swing components in EDT, setAutoDelay for mouse events, add a delay after

Integrated: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows

2021-04-21 Thread Prasanta Sadhukhan
On Wed, 21 Apr 2021 11:15:49 GMT, Prasanta Sadhukhan wrote: > This test was seen to be failing in windows and mac PIT run due to samevm > mode issue. It is now passing in default othervm mode. > Several iterations of this test running in all platforms is working fine, > link in J

Integrated: 8198422: Test java/awt/font/StyledMetrics/BoldSpace.java is unstable

2021-04-21 Thread Prasanta Sadhukhan
On Wed, 21 Apr 2021 11:08:40 GMT, Prasanta Sadhukhan wrote: > This test was marked as unstable in CI run due to samevm mode issue. It is > now passing in default othervm mode. > Several iterations of this test running in all platforms is working fine, > link in JBS. > We can

RFR: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows

2021-04-21 Thread Prasanta Sadhukhan
This test was seen to be failing in windows and mac PIT run due to samevm mode issue. It is now passing in default othervm mode. Several iterations of this test running in all platforms is working fine, link in JBS. We can remove the test from ProblemList, similar to what we have done for

RFR: 8198422: Test java/awt/font/StyledMetrics/BoldSpace.java is unstable

2021-04-21 Thread Prasanta Sadhukhan
This test was marked as unstable in CI run due to samevm mode issue. It is now passing in default othervm mode. Several iterations of this test running in all platforms is working fine, link in JBS. We can remove the test from ProblemList. - Commit messages: - 8198422: Test

Re: RFR: 8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

2021-04-19 Thread Prasanta Sadhukhan
On Mon, 19 Apr 2021 09:49:40 GMT, Tejpal Rebari wrote: > The test PopupPosTest.java fails for windows every time, and was problem > listed. > This test was added under the JDK-5044150, And the change was specific to > XToolkit as mentioned in JDK-5044150. > "this change is for XToolkit thus

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-16 Thread Prasanta Sadhukhan
On Mon, 12 Apr 2021 04:51:41 GMT, Prasanta Sadhukhan wrote: >> I am not sure I am understanding.. >> JDK-6242241 was Outlook bug so I am not sure how to remove "Outlook >> requirement" to verify that fix and thus bug? I don't think we can satisfy >> both r

Re: RFR: 8233564: [TESTBUG] MouseComboBoxTest.java is failing [v4]

2021-04-15 Thread Prasanta Sadhukhan
est works fine in all platforms after this > modification. Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision: - Revert unneeded master change - Revert unneeded master change - Changes: - all: https://git.openjdk.jav

Integrated: 8233564: [TESTBUG] MouseComboBoxTest.java is failing

2021-04-15 Thread Prasanta Sadhukhan
On Tue, 13 Apr 2021 09:11:44 GMT, Prasanta Sadhukhan wrote: > Test was problemlisted due to it failing repeatedly on macos in automated > nightly testing citing "java.awt.IllegalComponentStateException: component > must be showing on the screen to determine its location "

Re: RFR: 8233564: [TESTBUG] MouseComboBoxTest.java is failing [v3]

2021-04-15 Thread Prasanta Sadhukhan
est works fine in all platforms after this > modification. Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge master - Copyright year fix - 8233564: [TESTBUG] MouseComboBoxTest.java i

Integrated: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

2021-04-15 Thread Prasanta Sadhukhan
On Wed, 14 Apr 2021 10:38:03 GMT, Prasanta Sadhukhan wrote: > This test NullModalityDialogTest.java was failing repeatedly on macos in > automated testing citing "Tab navigation did not happen properly". > Modified to use invokeAndWait() instead of invokeLater and also

Re: RFR: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails [v2]

2021-04-15 Thread Prasanta Sadhukhan
On Thu, 15 Apr 2021 09:36:00 GMT, Jayathirth D V wrote: >> This bug is filed because of pixel color mismatch and i suspect it to be >> related to wrong display color profile in macOS. >> This test doesn't fail in local machine and in CI test machines in multiple >> runs. >> >> Also this test

Re: RFR: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails

2021-04-15 Thread Prasanta Sadhukhan
On Thu, 15 Apr 2021 08:03:27 GMT, Jayathirth D V wrote: > This bug is filed because of pixel color mismatch and i suspect it to be > related to wrong display color profile in macOS. > This test doesn't fail in local machine and in CI test machines in multiple > runs. > > Also this test was

Re: RFR: 8233564: [TESTBUG] MouseComboBoxTest.java is failing [v2]

2021-04-15 Thread Prasanta Sadhukhan
est works fine in all platforms after this > modification. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Copyright year fix - Changes: - all: https://git.openjdk.java.net/jdk/pull/3456/files - new: https://

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v4]

2021-04-14 Thread Prasanta Sadhukhan
penjdk.java.net/jdk9/jdk9/jdk/rev/d8efcad28072 > so we can remove the test from Problemlist which is problemlisted for linux > and mac. Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision: - Fix - Reinstate Outlook requirement -

RFR: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

2021-04-14 Thread Prasanta Sadhukhan
This test NullModalityDialogTest.java was failing repeatedly on macos in automated testing citing "Tab navigation did not happen properly". Modified to use invokeAndWait() instead of invokeLater and also use setAutoDelay() with appropriate delay time, in consistent with other automated tests

RFR: 8233564: [TESTBUG] MouseComboBoxTest.java is failing

2021-04-13 Thread Prasanta Sadhukhan
Test was problemlisted due to it failing repeatedly on macos in automated nightly testing citing "java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location " Added delay after the setVisible() is called to make sure enough time is given for frame

Integrated: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

2021-04-12 Thread Prasanta Sadhukhan
On Mon, 12 Apr 2021 04:37:31 GMT, Prasanta Sadhukhan wrote: > This test was problemlisted during nightly testing of jdk on macos which > seems to be caused by the fact that proper waiting was not done to make sure > frame is visible before commencing the test, which can be problemati

RFR: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

2021-04-11 Thread Prasanta Sadhukhan
This test was problemlisted during nightly testing of jdk on macos which seems to be caused by the fact that proper waiting was not done to make sure frame is visible before commencing the test, which can be problematic in some of the slower CI macos system. Modified the

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-11 Thread Prasanta Sadhukhan
On Mon, 12 Apr 2021 04:03:31 GMT, Prasanta Sadhukhan wrote: >> This bug was filed to remove the "Outlook requirement" but it does not mean >> that we should lose the opportunity to verify the JDK-6242241. > > I am not sure I am understanding.. > JDK-6242241 was O

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-11 Thread Prasanta Sadhukhan
On Sat, 10 Apr 2021 20:20:55 GMT, Sergey Bylokhov wrote: >> It will work fine as initial JDK-6242241 bug says "It works fine when >> dragging from Windows Explorer" but you told to remove Outlook requirement. >> The JDK-6242241 bug is specifically Outlook issue so that's why I told >>

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-09 Thread Prasanta Sadhukhan
On Sat, 10 Apr 2021 03:36:53 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove Outlook requirement > > test/jdk/java/awt/dnd/DnDFileGroupDescriptor/Dn

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-09 Thread Prasanta Sadhukhan
penjdk.java.net/jdk9/jdk9/jdk/rev/d8efcad28072 > so we can remove the test from Problemlist which is problemlisted for linux > and mac. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Remove Outlook requirement --

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v2]

2021-04-09 Thread Prasanta Sadhukhan
penjdk.java.net/jdk9/jdk9/jdk/rev/d8efcad28072 > so we can remove the test from Problemlist which is problemlisted for linux > and mac. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Fix - Ch

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v2]

2021-04-09 Thread Prasanta Sadhukhan
On Fri, 9 Apr 2021 08:09:16 GMT, Prasanta Sadhukhan wrote: >> The bug was added to the problem list by the JDK-8255365, because SQE >> reported it on Ubuntu in jdk15. This looks strange since the tag "@requires" >> was added in jdk9. >> >> BT

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-04-09 Thread Prasanta Sadhukhan
On Fri, 9 Apr 2021 07:10:14 GMT, Sergey Bylokhov wrote: >> This testcase was a regression testcase for a windows bug JDK-6242241 >> whereby dragging an attachment from a Microsoft Outlook message to the >> application results in blank or semicolons. >> The testcase was later made applicable to

RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-04-08 Thread Prasanta Sadhukhan
This testcase was a regression testcase for a windows bug JDK-6242241 whereby dragging an attachment from a Microsoft Outlook message to the application results in blank or semicolons. The testcase was later made applicable to windows only by JDK-7147083

Integrated: 8263928: Add JAWT test files for mac

2021-03-26 Thread Prasanta Sadhukhan
On Mon, 22 Mar 2021 07:02:18 GMT, Prasanta Sadhukhan wrote: > JAWT has testcase for windows and linux but no testcase is provided for mac. > We need to have a JAWT based testcase for mac, in similar lines to windows > and linux. This pull request has now been integrated. Changeset:

Re: RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows [v2]

2021-03-23 Thread Prasanta Sadhukhan
On Thu, 18 Mar 2021 12:29:01 GMT, Alexander Scherbatiy wrote: >> Printing text using GlyphVector outline has bad quality on printers with low >> DPI on Windows. >> The GDI system used for text printing on Windows accepts only integer path >> coordinates. >> Rounding GlyphVector outline

Re: RFR: 8263928: Add JAWT test files for mac [v2]

2021-03-22 Thread Prasanta Sadhukhan
> JAWT has testcase for windows and linux but no testcase is provided for mac. > We need to have a JAWT based testcase for mac, in similar lines to windows > and linux. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revisio

RFR: 8263928: Add JAWT test files for mac

2021-03-22 Thread Prasanta Sadhukhan
JAWT has testcase for windows and linux but no testcase is provided for mac. We need to have a JAWT based testcase for mac, in similar lines to windows and linux. - Commit messages: - fix - Add JAWT mac files Changes: https://git.openjdk.java.net/jdk/pull/3112/files Webrev:

Re: RFR: 8247370: Clean up unused printing code in awt_PrintJob.cpp

2021-03-18 Thread Prasanta Sadhukhan
On Thu, 18 Mar 2021 22:59:57 GMT, Phil Race wrote: > This removes a long time un-used code path. Maybe we should put noreg-cleanup in JBS. - Marked as reviewed by psadhukhan (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3083

Re: RFR: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-12 Thread Prasanta Sadhukhan
On Fri, 12 Mar 2021 12:30:13 GMT, Alexey Ivanov wrote: >> I can understand that as a user, you cannot /shouldn't change the name of a >> remote network printer but a network admin can change the name, so shouldn't >> we get notification on that name change when this method gets called after

Re: RFR: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-12 Thread Prasanta Sadhukhan
On Wed, 10 Mar 2021 15:38:27 GMT, Alexey Ivanov wrote: > [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented > polling for remote printers. > That bug description also mentions watching the registry for changes and > links to the article which describes the method yet

Re: RFR: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-12 Thread Prasanta Sadhukhan
On Fri, 12 Mar 2021 11:29:17 GMT, Alexey Ivanov wrote: >> Is this only about addition/removal? What about printer name change? >> Shouldn't we get notified in that case as trying to print on printer with >> old name will not find the printer!! >> If yes, in that regard I guess

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

2021-03-12 Thread Prasanta Sadhukhan
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

2021-03-12 Thread Prasanta Sadhukhan
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal

Re: RFR: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-11 Thread Prasanta Sadhukhan
On Thu, 11 Mar 2021 14:49:59 GMT, Alexey Ivanov wrote: >> I also am not sure on this. But I think since this is for remote printer, >> sometimes network availability issue might be there so it may fail more >> compared to local printer so I guess we should give this method a fair >> chance,

Re: RFR: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-11 Thread Prasanta Sadhukhan
On Thu, 11 Mar 2021 14:59:55 GMT, Alexey Ivanov wrote: >> [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented >> polling for remote printers. >> That bug description also mentions watching the registry for changes and >> links to the article which describes the method

Re: RFR: 8194129: Regression automated Test '/open/test/jdk/java/awt/Window/ShapedAndTranslucentWindows/TranslucentChoice.java' fails

2021-03-11 Thread Prasanta Sadhukhan
On Fri, 12 Mar 2021 00:25:39 GMT, Alexander Zvegintsev wrote: > First steps of the test are: > > - display undecorated background window > - click on it > - check if the window has received that click > - ... continue with test ... > > Unfortunately on Linux the test makes click before the

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]

2021-03-11 Thread Prasanta Sadhukhan
On Fri, 12 Mar 2021 00:48:58 GMT, Sergey Bylokhov wrote: >> Ajit Ghaisas has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 47 additional >>

Re: RFR: 8263311: Watch registry changes for remote printers update instead of polling

2021-03-11 Thread Prasanta Sadhukhan
On Thu, 11 Mar 2021 10:54:12 GMT, Alexey Ivanov wrote: >> src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp line 259: >> >>> 257: NULL, >>> 258: FALSE); >>> 259:

Re: RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

2021-03-10 Thread Prasanta Sadhukhan
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outline coordinates

Re: RFR: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

2021-03-10 Thread Prasanta Sadhukhan
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outline coordinates

Re: RFR: JDK-8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c

2021-02-26 Thread Prasanta Sadhukhan
On Fri, 26 Feb 2021 14:19:03 GMT, Matthias Baesken wrote: > The function wcstombsdmp is called at a few places in awt_InputMethod.c. > This function needs checking of a NULL return value and freeing of the memory > allocated by this function. However this is missing at one place in the file.

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-23 Thread Prasanta Sadhukhan
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov wrote: > Cleanup code to use new handy methods in > `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: > 1. java.io.InputStream#readAllBytes > 2. java.io.InputStream#transferTo > 3. java.nio.file.Files#copy > > Similar

Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v4]

2021-02-10 Thread Prasanta Sadhukhan
On Tue, 9 Feb 2021 12:29:52 GMT, Ajit Ghaisas wrote: >> **Description :** >> This is the implementation of [JEP 382 : New macOS Rendering >> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) >> It implements a Java 2D internal rendering pipeline for macOS using the >> Apple Metal

  1   2   3   >