Re: [11] Review Request: JDK-8196435 Regression automated Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' fails

Looks good. +1 Regards, Manajit > On 26-Feb-2018, at 10:59 AM, Prem Balakrishnan > wrote: > > Hi All, > > Please review fix for JDK 11: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196435 > > >

Re: [11] RFR JDK-8198693:Update ProblemsList for mac

Hi, Prasanta. Looks fine. But please add a comment to each bug that the test fails on macos, an example: + java/awt/Focus/ChoiceFocus/ChoiceFocus.java 8169103 windows-all,macosx-all https://bugs.openjdk.java.net/browse/JDK-8169103 "This issue was not observed on Linux, OSX " On 26/02/2018

Re: [11] JDK-8195738: scroll poistion in ScrollPane is reset after calling validate()

The bug was failed against Windows platform. So, I'd try to find the root cause why when the scroll is notified with the scrolled component size the scroll position is set to the wrong value. --Semyon On 02/26/2018 09:51 AM, shashidhara veerabhadraiah wrote: I think I agree Semyon. Thanks

Re: [11] Review Request: JDK-8171381 Test javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

+1 --Semyon On 02/26/2018 03:54 AM, Manajit Halder wrote: Hi All, Please review fix for JDK 11 Bug: https://bugs.openjdk.java.net/browse/JDK-8171381 Webrev: http://cr.openjdk.java.net/~mhalder/8171381/webrev.00/ Fix: Test failed due

Re: [11] Review Request: JDK-8196435 Regression automated Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' fails

+1 --Semyon On 02/25/2018 09:29 PM, Prem Balakrishnan wrote: Hi All, Please review fix for JDK 11: Bug: https://bugs.openjdk.java.net/browse/JDK-8196435 Webrev: http://cr.openjdk.java.net/~pkbalakr/8196435/webrev.00/ Test

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

Hi Krishna, Fix looks good. I suggest the following changes before committing. 1) Remove the comma in between the two bug ids. 2) Is the message “Test PASSED” required? Regards, Manajit > On 26-Feb-2018, at 10:23 PM, Semyon Sadetsky > wrote: > > +1 > >

Re: [11] RFR JDK-8198693:Update ProblemsList for mac

+1 .. good to get these mac issues problem listed. -phil. On 2/26/2018 4:35 AM, Prasanta Sadhukhan wrote: Hi All, Please review the problem list updation for mac to weed out the test that are failing at least once in few iterations. I tested on mac 10.13.3. With this problem list, the test

Re: [11] JDK-8195738: scroll poistion in ScrollPane is reset after calling validate()

I think I agree Semyon. Thanks for your detailed explanation. So how do we approach on this? I see a different behaviour on other platforms. Shouldn’t we have a common behaviour across platforms? I agree with your analysis and hence should we change the behaviour on other platforms so that all

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

Hi, Krishna. This test was added to the problemlist, please check that it works on other platforms and remove it from the problemlist. On 25/02/2018 17:53, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8197808: https://bugs.openjdk.java.net/browse/JDK-8197808 Webrev:

Re: [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Hi, Shashi. Why this test should be platform specific? It shows two common frames and use some generic api for mouse events. This test also was updated in JDK-8027154 and I assume it should works on macOS after that, maybe we have a new regression here? On 24/02/2018 07:32, Shashidhara

Re: [11] RFR 8187635: On Windows Swing changes keyboard layout on a window activation

Looks fine. On 26/02/2018 04:55, Dmitry Markov wrote: Hello, Could you review a fix for jdk11, please?  bug: https://bugs.openjdk.java.net/browse/JDK-8187635  webrev: http://cr.openjdk.java.net/~dmarkov/8187635/webrev.00/ Problem description: On Windows platform if AWT/Swing app is

Re: [11] Review Request: JDK-8196435 Regression automated Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' fails

Hi, Prem. Test fails due to synchronization issue. Can you please clarify what synchronization issue was fixed? The code before/after mostly identical except xxx.setResizable(false); -- Best regards, Sergey.

Re: [11] Review Request: JDK-8171381 Test javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

Hi, Manajit. Can you please clarify what synchronization issue was fixed? It is unclear because robot.waitForIdle() is implemented using realSync(). On 26/02/2018 03:54, Manajit Halder wrote: Hi All, Please review fix for JDK 11 Bug: https://bugs.openjdk.java.net/browse/JDK-8171381 Webrev:

Re: [11] JDK-8198690: Multiple failures in java/awt/Window/ShapedAndTranslucentWindows

Hi, Shashi. Please let me know if there is any better logic to avoid tolerance based color comparison. The difference between Color(0, 0, 255) used by the background frame and the Color(0, 0, ~216) captured by the robot is quite big. I guess the difference should be visible by the user, but if

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

On 2/26/18, 9:22 AM, Manajit Halder wrote: Hi Krishna, Fix looks good. I suggest the following changes before committing. 1) Remove the comma in between the two bug ids. yes .. not sure if jtreg cares though. 2) Is the message “Test PASSED” required? I find these statements useful ..

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

Yes .. even if bugs were added to the problem list in bulk, the expectation is that they'll be removed by the bug fix that fixes the failure. And if it still fails on some platforms then either (1) you aren't done with your fix, or (2) you need to find a different bug ID under which to now

Re: [11] JDK-8198690: Multiple failures in java/awt/Window/ShapedAndTranslucentWindows

I think you need to use Image I/O to save the failed image and examine it. The test is capturing pixels at offsets of 20 into the window, presumably to avoid any "nice" blending effects the desktop may apply to the edges of windows. If you save the image you can inspect it at leisure better

[11] JDK-8198690: Multiple failures in java/awt/Window/ShapedAndTranslucentWindows

Hi All, Please review a test fix for the following bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8198690 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8198690/webrev.00/ Summary: Certain tests under the folder java/awt/Window/ShapedAndTranslucentWindows fails due to color

[11] Review Request: JDK-8171381 Test javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

Hi All, Please review fix for JDK 11 Bug: https://bugs.openjdk.java.net/browse/JDK-8171381 Webrev: http://cr.openjdk.java.net/~mhalder/8171381/webrev.00/ Fix:

Re: [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

What Windows 10 version are you running ? As discussed a few times ... probably off-list .. there is a bug in Windows 10 Fall Creators (build 1709) that breaks mouse moves. -phil. On 2/26/18, 8:11 PM, Shashidhara Veerabhadraiah wrote: Hi Sergey, Before I sent out this review I ran this test

Re: [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Am using Windows 10 ProVersion: 1703!! Do you suspect this has those specific mouse move issues? Thanks and regards, Shashi -Original Message- From: Philip Race Sent: Tuesday, February 27, 2018 10:12 AM To: Shashidhara Veerabhadraiah Cc:

Re: [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Hi Sergey, Before I sent out this review I ran this test different platforms and saw that it was passing. But then after I sent it out for review I found that the test had not run on Windows 10!! That was strange and was not expecting it in the first place. I found that mouseMoved() event was

Re: [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Could be that it acquired the same bug via a patch release. -Phil. > On Feb 26, 2018, at 8:45 PM, Shashidhara Veerabhadraiah > wrote: > > Am using Windows 10 ProVersion: 1703!! Do you suspect this has those > specific mouse move issues? > > Thanks

Re: [11] Review Request: JDK-8196435 Regression automated Test 'java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java' fails

Hi Sergey, At times backFrame is rendered on top of frontFrame, due to which mouse position on backFrame is not NULL and test fails, solved this by adding waitForIdle() calls appropriately. Furthermore, mousemove from frontFrame to backFrame, caused the cursor to change to resize cursor and

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Hi Sergey, Phil and Kevin, Thank you all for your review comments. Changed the fix as per Sergey’s review comment. Now both Frame and Dialog are checked for resizibility before setting canFullScreen to true. Please review the modified webrev:

[11] RFR JDK-8198693:Update ProblemsList for mac

Hi All, Please review the problem list updation for mac to weed out the test that are failing at least once in few iterations. I tested on mac 10.13.3. With this problem list, the test failures and errors are nearly zero apart from 2-3 tests that are failing intermittently. Bug:

[11] RFR 8187635: On Windows Swing changes keyboard layout on a window activation

Hello, Could you review a fix for jdk11, please? bug: https://bugs.openjdk.java.net/browse/JDK-8187635 webrev: http://cr.openjdk.java.net/~dmarkov/8187635/webrev.00/ Problem description: On Windows platform if AWT/Swing app is inactive (does not have focus) and user changes keyboard layout,

Re: [11] JDK-8195738: scroll poistion in ScrollPane is reset after calling validate()

On 02/24/2018 05:27 AM, Shashidhara Veerabhadraiah wrote: Hi Semyon, Thanks for your review and these questions help us to reach the right requirements. Without this change, there is different behavior on windows compared to Mac/Linux platforms. Hence this change is required to make the

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

+1 --Semyon On 02/25/2018 05:53 PM, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8197808: https://bugs.openjdk.java.net/browse/JDK-8197808 Webrev: http://cr.openjdk.java.net/~kaddepalli/8197808/webrev00/ The