[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-16 Thread simon steiner (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128484#comment-16128484
 ] 

simon steiner commented on BATIK-1197:
--

http://svn.apache.org/viewvc?view=revision&revision=1805148

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-16 Thread simon steiner (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128464#comment-16128464
 ] 

simon steiner commented on BATIK-1197:
--

1.9.1 Tag has been added now

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-11 Thread Sven Haster (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123322#comment-16123322
 ] 

Sven Haster commented on BATIK-1197:


Creating separate sub-modules for jython/rhino/etc. seems like the optimal 
solution and we would welcome that change. We don't really need those 
dependencies.

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-09 Thread simon steiner (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120367#comment-16120367
 ] 

simon steiner commented on BATIK-1197:
--

from Glenn Adams:

In ANT builds, the inclusion of jpython/rhino support is conditioned on their 
presence on the build machine, so past release builds may or may not include 
compiled classes that reference these dependencies. I haven't studied past 
release builds to determine which do or do not include these classes.

The current Maven build, however, always include such classes (in the 
batik-script module), and may require runtime access to these deps. It may be 
useful to create a variant build of batik-script, call it batik-script-jpython, 
that does include the jpython interpreter classes and leave the "standard" 
batik-script module without this dep.

I have not studied this in depth to consider the pros/cons.

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-09 Thread Sven Haster (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119563#comment-16119563
 ] 

Sven Haster commented on BATIK-1197:


Yeah, I'd also rather see these dependencies made 
{code:xml}
true
{code}
That is a superior way way of handling optional dependencies to excluding them, 
not in the least because it is handled in the declaration of the dependencies 
in the artifact instead of wherever the artifact is being used as a dependency 
itself.

Especially the jtyhon artifact is .. not very well constructed, to say the 
least, and we don't want it on our classpath.

For now we also stick to 1.9(.0)

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-09 Thread Thomas Mortagne (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119557#comment-16119557
 ] 

Thomas Mortagne commented on BATIK-1197:


bq. The jython/rhino dependencies have been there a long time

Not sure what you mean exactly. You did not ended up with Jython with 1.9 or 
previous versions. Sure it was possible to use Jython if you added the JAR 
yourself as indicated on https://xmlgraphics.apache.org/batik/install.html but 
it was not a mandatory dependency from Maven point of view.

There is nothing about Jython or Rhino in 
https://www.mail-archive.com/batik-users@xmlgraphics.apache.org/msg10017.html 
so I don't understand where exactly "as suggested" come from.

It's not all or nothing, since those dependencies can be used it sure make sens 
to declare them as dependencies but they could be optional dependencies. Jython 
JAR is really not a details (it's big and wrongly embed lots of other 
libraries) especially when it's used for pretty edge cases when you are a FOP 
user. Excluding a dependency is always a hack and there is nothing telling you 
that batik-script is and will continue to work without it.

bq. Excluding jython seems to work

Yes but I'm trying to understand why this dependency suddenly became non 
optional and this upgrade is not critical for me right now. Also the fact that 
there is no 1.9.1 version in Jira or 
http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/ did not really 
reassured me on the quality of this release so I wanted to make all that really 
was intended and not a mistake. Adding such big dependencies in a minor version 
is quite weird.

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



Re: [jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-08 Thread Glenn Adams
In ANT builds, the inclusion of jpython/rhino support is conditioned on
their presence on the build machine, so past release builds may or may not
include compiled classes that reference these dependencies. I haven't
studied past release builds to determine which do or do not include these
classes.

The current Maven build, however, always include such classes (in the
batik-script module), and may require runtime access to these deps. It may
be useful to create a variant build of batik-script, call it
batik-script-jpython, that does include the jpython interpreter classes and
leave the "standard" batik-script module without this dep.

I have not studied this in depth to consider the pros/cons.

On Tue, Aug 8, 2017 at 11:49 AM, simon steiner (JIRA) 
wrote:

>
> [ https://issues.apache.org/jira/browse/BATIK-1197?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=16118739#comment-16118739 ]
>
> simon steiner commented on BATIK-1197:
> --
>
> The jython/rhino dependencies have been there a long time, they are now
> included in pom, you for now should exclude them as suggested.
>
> > Non optional dependencies on jython and rhino added in 1.9.1
> > 
> >
> > Key: BATIK-1197
> > URL: https://issues.apache.org/jira/browse/BATIK-1197
> > Project: Batik
> >  Issue Type: Bug
> >  Components: Scripting
> >Reporter: Thomas Mortagne
> >
> > Note: can't find the 1.9.1 version so I did not set it in "Affects
> Version/s".
> > Looks like a big change for a minor version. Is this really expected ?
> > Maybe 1.9.1 was release by mistake ? I can only see it in Maven central
> but can't find a version here on any corresponding tag in
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)
>
> -
> To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
> For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org
>
>


[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-08 Thread simon steiner (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118739#comment-16118739
 ] 

simon steiner commented on BATIK-1197:
--

The jython/rhino dependencies have been there a long time, they are now 
included in pom, you for now should exclude them as suggested.

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-08 Thread Sven Haster (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118089#comment-16118089
 ] 

Sven Haster commented on BATIK-1197:


[~ssteiner1] What exactly should we see in that mail? It seems to be a simple 
announcement that 1.9.1 has been released and not contain any information 
concerning the jython/rhino dependencies. 

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-08 Thread Sven Haster (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118064#comment-16118064
 ] 

Sven Haster commented on BATIK-1197:


Excluding jython seems to work (ie, it removes the duplicate classes from our 
classpath) but it is unclear how strong the dependency on jython exactly is in 
1.9.1 so we refrained from upgrading. 

Ie:


{code:xml}


...

org.apache.xmlgraphics
batik-script
${topicus.version.org.apache.xmlgraphics.batik}


org.python
jython



...


{code}


[~tmortagne] This might be a stopgap solution for you if you need to upgrade.

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-08 Thread simon steiner (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118056#comment-16118056
 ] 

simon steiner commented on BATIK-1197:
--

See 
https://www.mail-archive.com/batik-users@xmlgraphics.apache.org/msg10017.html

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org



[jira] [Commented] (BATIK-1197) Non optional dependencies on jython and rhino added in 1.9.1

2017-08-08 Thread Sven Haster (JIRA)

[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118050#comment-16118050
 ] 

Sven Haster commented on BATIK-1197:


This is a problem for us also. We have a dependency on fop, which has a 
dependency on batik, and with batik 1.9.1 we now get jython "for free". But we 
don't want jython because it contains a *copy* of all the classes from xml-apis 
( :( )

Please make this dependency optional again because right now we can't upgrade 
to 1.9.1+ 

> Non optional dependencies on jython and rhino added in 1.9.1
> 
>
> Key: BATIK-1197
> URL: https://issues.apache.org/jira/browse/BATIK-1197
> Project: Batik
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org