Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-02-18 Thread Yoav Weiss (@Shopify)
LGTM3 On Thursday, February 13, 2025 at 9:21:45 PM UTC+1 Mike Taylor wrote: > LGTM2 > On 2/12/25 10:59 PM, Domenic Denicola wrote: > > Indeed, thanks for working through this! LGTM1. > > On Thursday, February 13, 2025 at 3:28:47 AM UTC+9 Jeffrey Yasskin wrote: > >> On Wed, Feb 12, 2025 at 10:07 A

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-02-13 Thread Mike Taylor
LGTM2 On 2/12/25 10:59 PM, Domenic Denicola wrote: Indeed, thanks for working through this! LGTM1. On Thursday, February 13, 2025 at 3:28:47 AM UTC+9 Jeffrey Yasskin wrote: On Wed, Feb 12, 2025 at 10:07 AM Noam Rosenthal wrote: On Tuesday, January 28, 2025 at 10:49:02 AM UTC

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-02-12 Thread Domenic Denicola
Indeed, thanks for working through this! LGTM1. On Thursday, February 13, 2025 at 3:28:47 AM UTC+9 Jeffrey Yasskin wrote: > On Wed, Feb 12, 2025 at 10:07 AM Noam Rosenthal > wrote: > >> On Tuesday, January 28, 2025 at 10:49:02 AM UTC Noam Rosenthal wrote: >> >> On Mon, Jan 27, 2025 at 8:51 PM N

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-02-12 Thread Jeffrey Yasskin
On Wed, Feb 12, 2025 at 10:07 AM Noam Rosenthal wrote: > On Tuesday, January 28, 2025 at 10:49:02 AM UTC Noam Rosenthal wrote: > > On Mon, Jan 27, 2025 at 8:51 PM Noam Rosenthal > wrote: > > > >- https://github.com/w3c/csswg-drafts/issues/10647 > > This one is not actionable and doesn't affe

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-02-12 Thread Noam Rosenthal
On Tuesday, January 28, 2025 at 10:49:02 AM UTC Noam Rosenthal wrote: On Mon, Jan 27, 2025 at 8:51 PM Noam Rosenthal wrote: - https://github.com/w3c/csswg-drafts/issues/10647 This one is not actionable and doesn't affect shape(), it's about path(). I think "not actionable

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-01-28 Thread Noam Rosenthal
On Mon, Jan 27, 2025 at 8:51 PM Noam Rosenthal wrote: > > - https://github.com/w3c/csswg-drafts/issues/10647 This one is not actionable and doesn't affect shape(), it's about >>> path(). >>> >> >> I think "not actionable >>

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-01-27 Thread Noam Rosenthal
> >>>- https://github.com/w3c/csswg-drafts/issues/10647 >>> >>> This one is not actionable and doesn't affect shape(), it's about path(). >> > > I think "not actionable > " isn't a great > way to describe this issue: Lea's suggesting that t

Re: [blink-dev] Re: Intent to Ship: CSS shape() function

2025-01-27 Thread Jeffrey Yasskin
On Mon, Jan 27, 2025 at 3:08 AM Noam Rosenthal wrote: > On Mon, Jan 27, 2025 at 2:56 AM Domenic Denicola > wrote: > >> This overall seems promising, but a few inline comments. The only >> blocking one is the question about open spec edits. >> >> On Thursday, January 23, 2025 at 4:42:34 AM UTC+9

[blink-dev] Re: Intent to Ship: CSS shape() function

2025-01-27 Thread Noam Rosenthal
On Mon, Jan 27, 2025 at 2:56 AM Domenic Denicola wrote: > This overall seems promising, but a few inline comments. The only blocking > one is the question about open spec edits. > > On Thursday, January 23, 2025 at 4:42:34 AM UTC+9 Chromestatus wrote: > > Contact emails nrosent...@chromium.org >

[blink-dev] Re: Intent to Ship: CSS shape() function

2025-01-26 Thread Domenic Denicola
This overall seems promising, but a few inline comments. The only blocking one is the question about open spec edits. On Thursday, January 23, 2025 at 4:42:34 AM UTC+9 Chromestatus wrote: Contact emails nrosent...@chromium.org Explainer None I was able to piece together an explainer by looki