Re: bug#44037: Synchronising mixal-mode with GNU MDK's latest release
jao writes: >> Thanks! Should you want to make it more official, feel free to send a >> patch to update the "Maintainer" field with your name and email address. > > Sure, patch attached. Excellent! Pushed to master as commit 20728195b6. >> BTW, we are trying to push to convert code to use the new lexical scope. >> If you find some time, it would be great if you could test the attached >> patch that enables it for mixal-mode.el. (It would be hard for me to >> verify that it works since I don't use GNU MDK myself.) > > I've played with it a bit and there's no obvious problem with the switch > (this is just a mode for an assembly-like language without fancy > stuff). Please feel free to install the patch. Thanks for testing; pushed to master as commit 3b5a43f3d7.
Re: bug#44037: Synchronising mixal-mode with GNU MDK's latest release
close 44037 28.1 thanks Eli Zaretskii writes: >> FWIW, i've checked my archives and i do have separate PDFs with >> assignments for EMMS and EMACS. Happy to send them off-list if you need >> to. > > No, this information is enough for me, thanks. Your changes can be > installed. Pushed to master as commit 9513aa8f48.
Re: bug#44037: Synchronising mixal-mode with GNU MDK's latest release
jao writes: > We release less frequently than Emacs, so i am guessing users (all three > of them!) will be fine either way. OK, sounds good to me. > Yes, that's no problem. I am not the original author of the mode, so > back in the day I didn't pay attention, but my elisp skills have > improved enough in the intervening 20 years and i'm happy to take care > of it now :) Thanks! Should you want to make it more official, feel free to send a patch to update the "Maintainer" field with your name and email address. BTW, we are trying to push to convert code to use the new lexical scope. If you find some time, it would be great if you could test the attached patch that enables it for mixal-mode.el. (It would be hard for me to verify that it works since I don't use GNU MDK myself.) From 2f77be1207eedcbb7008db4f8d513bf25a4ad7db Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 17 Oct 2020 15:52:01 +0200 Subject: [PATCH] * lisp/progmodes/mixal-mode.el: Use lexical-binding. --- lisp/progmodes/mixal-mode.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/mixal-mode.el b/lisp/progmodes/mixal-mode.el index 468c116b67..6691074ac8 100644 --- a/lisp/progmodes/mixal-mode.el +++ b/lisp/progmodes/mixal-mode.el @@ -1,4 +1,4 @@ -;;; mixal-mode.el --- Major mode for the mix asm language. +;;; mixal-mode.el --- Major mode for the mix asm language. -*- lexical-binding:t -*- ;; Copyright (C) 2003-2020 Free Software Foundation, Inc. -- 2.28.0
Re: bug#44037: Synchronising mixal-mode with GNU MDK's latest release
jao writes: > Please find attached a patch that updates mixal-mode.el with latest > changes in GNU MDK. I should have papers in place for emacs. Thanks! The patch looks good to me. I can only see one previous commit from you (marked "Copyright-paperwork-exempt") in the git log, so I'll wait for someone with access to verify the copyright status. (OTOH, maybe it doesn't matter since these changes are already assigned to the FSF via GNU MDK?) > Do you think it'd be better if i just dropped that file from MDK's > tarball and maintain it by submitting patches here instead? I guess it depends on if your users can wait for the changes until the next major Emacs release, or if you feel that it would be beneficial to get the changes out there earlier than that. Orthogonally, one could perhaps consider if this should be distributed as a GNU ELPA package. In all cases, it would be very helpful if you could submit patches here when there are any changes. > Thanks a lot! Thanks for handling this very promptly!
Merge misc/mixal-mode.el with version in Emacs
I see that there are some changes in your misc/mixal-mode.el that are not in the version distributed with GNU Emacs. I suggest to merge all relevant changes from Emacs into your version and submitting either an updated file that can be part of Emacs 28.1, or even better a patch. Thanks.
